Re: [dpdk-dev] [PATCH] net/mlx5: fix Direct Verbs RSS hash field

2018-11-13 Thread Shahaf Shuler
Tuesday, November 13, 2018 8:00 AM, Shahaf Shuler: > Subject: [dpdk-dev] [PATCH] net/mlx5: fix Direct Verbs RSS hash field > > From: Yongseok Koh > > As mlx5_flow_hashfields_adjust() refers to flow->rss, actions must be > translated prior to items like in Verbs. Otherwise, hash fields are not >

Re: [dpdk-dev] Which counters are set by rte_eth_stats_get

2018-11-13 Thread Tom Barbette
> For others, if the driver has no places it allocates mbufs or drops packets > in the driver I see no > reason that the driver needs to do anything with those fields. I understand. I'll fix the driver I use then. There may still be some counters that should increase but are not reported by hard

Re: [dpdk-dev] [PATCH 1/1] eal: Don't fail secondary if primary is missing tailqs

2018-11-13 Thread Thomas Monjalon
13/11/2018 00:33, Burdick, Cliff: > This patch was submitted by Jean Tourrilhes over two years ago, but didn't > receive any responses. I hit the same issue recently when trying to use cgo > (Golang) as a primary process linked to libdpdk.a against a C++ application > linked against the same lib

Re: [dpdk-dev] [PATCH] example/ipv4_multicast: fix app hanging when using clone

2018-11-13 Thread Thomas Monjalon
Hi, 12/11/2018 21:46, Herakliusz Lipiec: > This example was dropping packets when using clone (ip 224.0.0.103). What is this IP? What is clone? > The problem was that mbufs were not freed. This was caused by coping > ol_flags from cloned mbuf to header mbufs. Mbuf is not freed because of ol_fla

Re: [dpdk-dev] Where is the padding code in DPDK?

2018-11-13 Thread Burakov, Anatoly
On 13-Nov-18 7:16 AM, Sam wrote: Hi all, As we know, ethernet frame must longer then 64B. So if I create rte_mbuf and fill it with just 60B data, will rte_eth_tx_burst add padding data, let the frame longer then 64B If it does, where is the code? Others can correct me if i'm wrong here, but

Re: [dpdk-dev] [dpdk-techboard] DPDK techboard minutes of October 24

2018-11-13 Thread Burakov, Anatoly
On 12-Nov-18 4:55 PM, Thomas Monjalon wrote: 12/11/2018 17:43, Stephen Hemminger: On Mon, 12 Nov 2018 12:36:45 + "Ananyev, Konstantin" wrote: From: Richardson, Bruce From: techboard [mailto:techboard-boun...@dpdk.org] On Behalf Of Ananyev, Konstantin Hi Anatoly, Meeting notes for th

Re: [dpdk-dev] [PATCH 1/1] eal: Don't fail secondary if primary is missing tailqs

2018-11-13 Thread Burakov, Anatoly
On 13-Nov-18 9:21 AM, Thomas Monjalon wrote: 13/11/2018 00:33, Burdick, Cliff: This patch was submitted by Jean Tourrilhes over two years ago, but didn't receive any responses. I hit the same issue recently when trying to use cgo (Golang) as a primary process linked to libdpdk.a against a C++

Re: [dpdk-dev] [PATCH v3 2/2] ethdev: device configuration enhancement

2018-11-13 Thread Ferruh Yigit
On 11/13/2018 12:46 AM, Lu, Wenzhuo wrote: > Hi Ferruh, > > >> -Original Message- >> From: Yigit, Ferruh >> Sent: Saturday, November 10, 2018 5:10 AM >> To: Andrew Rybchenko ; Lu, Wenzhuo >> ; dev@dpdk.org >> Subject: Re: [dpdk-dev] [PATCH v3 2/2] ethdev: device configuration >> enhanceme

Re: [dpdk-dev] [PATCH] example/ipv4_multicast: fix app hanging when using clone

2018-11-13 Thread Ananyev, Konstantin
> > Hi, > > 12/11/2018 21:46, Herakliusz Lipiec: > > This example was dropping packets when using clone (ip 224.0.0.103). The problem is that ipv4_multicast app: 1. invokes rte_pktmbuf_clone() for the packet (that creates a new mbuf with IND_ATTACHED_MBUF set in ol_flags). 2. creates new mb

[dpdk-dev] [PATCH v2 0/2] net/mlx5: update MPLS item support

2018-11-13 Thread Dekel Peled
This series updates support of MPLS item, in verbs flow engine and in Direct Verbs flow engine. Patch 1/2 adds support of MPLS item in DV flow engine. Patch 2/2 fixes the MPLS item validation in both flow engines. --- v2: - Add patch 1/2 to series. - Update patch 2/2 to correctly validate MPLS ite

[dpdk-dev] [PATCH v2 1/2] net/mlx5: add MPLS to Direct Verbs flow engine

2018-11-13 Thread Dekel Peled
From: Shahaf Shuler The support in MPLS on this flow engine was overlooked. It's absence is critical because there are required actions for MPLS which can be done only with the DV engine. To set correctly the MPLS filter, we need to reason about the flow item before the MPLS (UDP, GRE or other).

[dpdk-dev] [PATCH v2 2/2] net/mlx5: fix MPLS item validation

2018-11-13 Thread Dekel Peled
Update the mlx5_flow_validate_item_mpls() function to allow MPLS over IP, UDP, and GRE. Modify the flow_dv_validate() function with the new logic introduced in previous patch of this series: set new variable last_item after each validation, update item_flags after each item iteration. The new varia

Re: [dpdk-dev] [PATCH v2] crypto/octeontx: fix coverity issues

2018-11-13 Thread Akhil Goyal
On 11/12/2018 11:44 PM, Anoob Joseph wrote: > Coverity Issue: 323492 > > If the length of string pointed by 'name' is equal to or greater than > the sizeof cptvf->dev_name string, the resultant string will not be > null terminated. Using strlcpy would make sure the string would always > be null t

[dpdk-dev] [PATCH] mlx5: Report imissed stat

2018-11-13 Thread Tom Barbette
The imissed counters (number of packets dropped because the queues were full) were actually reported through xstats as "rx_out_of_buffer" but was not reported through stats. Following a recent discussion on the ML, as there is no way to tell the user if a counter is implemented or not, this should

Re: [dpdk-dev] [PATCH] example/ipv4_multicast: fix app hanging when using clone

2018-11-13 Thread Burakov, Anatoly
On 12-Nov-18 8:46 PM, Herakliusz Lipiec wrote: This example was dropping packets when using clone (ip 224.0.0.103). The problem was that mbufs were not freed. This was caused by coping ol_flags from cloned mbuf to header mbufs. Signed-off-by: Herakliusz Lipiec --- I agree with Thomas, needs c

Re: [dpdk-dev] [PATCH] example/ipv4_multicast: fix app hanging when using clone

2018-11-13 Thread Ananyev, Konstantin
> > --- > > I agree with Thomas, needs clearer description. Suggest using some of > the wording provided by Konstantin in later replies. Also, needs a > Fixes: tag and a CC: stable, because it appears that this bug has been > around for a few releases. Good point, I forgot about 'fixes' and 'st

Re: [dpdk-dev] [PATCH] net/octeontx: fix mbuf corruption with larger priv sizes

2018-11-13 Thread Jerin Jacob
-Original Message- > Date: Mon, 12 Nov 2018 23:24:09 +0530 > From: "Joseph, Anoob" > To: Ferruh Yigit , "Jacob, Jerin" > > CC: "Saxena, Nitin" , "Joseph, Anoob" > , "Athreya, Narayana Prasad" > , "dev@dpdk.org" , > "sta...@dpdk.org" > Subject: [PATCH] net/octeontx: fix mbuf corrupti

[dpdk-dev] [PATCH v4 1/3] ethdev: fix invalid device configuration after failure

2018-11-13 Thread Ferruh Yigit
From: Wenzhuo Lu The new configuration is stored during the rte_eth_dev_configure() API but the API may fail. After failure stored configuration will be invalid since it is not fully applied to the device. We better roll the configuration back after failure. Fixes: af75078fece3 ("first public r

[dpdk-dev] [PATCH v4 2/3] ethdev: fix device info getting

2018-11-13 Thread Ferruh Yigit
From: Wenzhuo Lu The device information cannot be gotten correctly before the configuration is set. Because on some NICs the information has dependence on the configuration. Fixes: 3be82f5cc5e3 ("ethdev: support PMD-tuned Tx/Rx parameters") Cc: sta...@dpdk.org Signed-off-by: Wenzhuo Lu Signed-

[dpdk-dev] [PATCH v4 3/3] ethdev: eliminate interim variable

2018-11-13 Thread Ferruh Yigit
`local_conf` variable was needed for offload conversions but no more required. No functional difference, only interim variable eliminated. Fixes: ab3ce1e0c193 ("ethdev: remove old offload API") Cc: sta...@dpdk.org Signed-off-by: Ferruh Yigit --- Cc: Andrew Rybchenko Cc: Wenzhuo Lu --- lib/lib

Re: [dpdk-dev] [PATCH v4 1/3] ethdev: fix invalid device configuration after failure

2018-11-13 Thread Andrew Rybchenko
On 11/13/18 2:12 PM, Ferruh Yigit wrote: From: Wenzhuo Lu The new configuration is stored during the rte_eth_dev_configure() API but the API may fail. After failure stored configuration will be invalid since it is not fully applied to the device. We better roll the configuration back after fai

Re: [dpdk-dev] [PATCH v4 2/3] ethdev: fix device info getting

2018-11-13 Thread Andrew Rybchenko
On 11/13/18 2:12 PM, Ferruh Yigit wrote: From: Wenzhuo Lu The device information cannot be gotten correctly before the configuration is set. Because on some NICs the information has dependence on the configuration. Fixes: 3be82f5cc5e3 ("ethdev: support PMD-tuned Tx/Rx parameters") Cc: sta...@d

Re: [dpdk-dev] [PATCH v4 3/3] ethdev: eliminate interim variable

2018-11-13 Thread Andrew Rybchenko
On 11/13/18 2:12 PM, Ferruh Yigit wrote: `local_conf` variable was needed for offload conversions but no more required. No functional difference, only interim variable eliminated. Fixes: ab3ce1e0c193 ("ethdev: remove old offload API") Cc: sta...@dpdk.org Signed-off-by: Ferruh Yigit I guess i

[dpdk-dev] [PATCH] security: remove experimental tag

2018-11-13 Thread Akhil Goyal
rte_security has been experimental since DPDK 17.11 release. Now the library has matured and expermental tag is removed in this patch. Signed-off-by: Akhil Goyal --- MAINTAINERS | 2 +- lib/librte_security/Makefile | 1 - lib/librte_security/mes

[dpdk-dev] [PATCH] lib: fix to free trail queue entry after use

2018-11-13 Thread Hari Kumar Vemula
In rte_efd_create() allocated memory for trail queue entry but not freed. Added freeing the trail queue entry. Fixes: 56b6ef874f80 ("efd: new Elastic Flow Distributor library") Cc: sta...@dpdk.org Signed-off-by: Hari Kumar Vemula --- lib/librte_efd/rte_efd.c | 21 + 1 file c

[dpdk-dev] [PATCH v2] example/ipv4_multicast: fix app hanging when using clone

2018-11-13 Thread Herakliusz Lipiec
The ipv4_multicast sample application was dropping packets when using mbuf clone. When creating an L2 header and copying metadata from the source packet, the ol_flags were also copied along with all the other metadata. Because the cloned packet had IND_ATTACHED_MBUF flag set in its ol_flags, this c

Re: [dpdk-dev] [PATCH] security: remove experimental tag

2018-11-13 Thread Ananyev, Konstantin
Hi Akhil, > -Original Message- > From: Akhil Goyal [mailto:akhil.go...@nxp.com] > Sent: Tuesday, November 13, 2018 11:28 AM > To: dev@dpdk.org > Cc: tho...@monjalon.net; Ananyev, Konstantin ; > jerin.ja...@caviumnetworks.com; > anoob.jos...@caviumnetworks.com; Nicolau, Radu ; > Doherty,

Re: [dpdk-dev] [PATCH v4 3/3] ethdev: eliminate interim variable

2018-11-13 Thread Ferruh Yigit
On 11/13/2018 11:22 AM, Andrew Rybchenko wrote: > On 11/13/18 2:12 PM, Ferruh Yigit wrote: >> `local_conf` variable was needed for offload conversions but no more >> required. No functional difference, only interim variable eliminated. >> >> Fixes: ab3ce1e0c193 ("ethdev: remove old offload API") >>

Re: [dpdk-dev] [PATCH v2] example/ipv4_multicast: fix app hanging when using clone

2018-11-13 Thread Ananyev, Konstantin
> -Original Message- > From: Lipiec, Herakliusz > Sent: Tuesday, November 13, 2018 11:49 AM > To: dev@dpdk.org > Cc: Ananyev, Konstantin ; Wang, Dong1 > ; tho...@monjalon.net; Burakov, > Anatoly ; Lipiec, Herakliusz > ; sta...@dpdk.org > Subject: [PATCH v2] example/ipv4_multicast: fix a

Re: [dpdk-dev] [PATCH] net/octeontx: fix mbuf corruption with larger priv sizes

2018-11-13 Thread Ferruh Yigit
On 11/13/2018 10:32 AM, Jerin Jacob wrote: > -Original Message- >> Date: Mon, 12 Nov 2018 23:24:09 +0530 >> From: "Joseph, Anoob" >> To: Ferruh Yigit , "Jacob, Jerin" >> >> CC: "Saxena, Nitin" , "Joseph, Anoob" >> , "Athreya, Narayana Prasad" >> , "dev@dpdk.org" , >> "sta...@dpdk.org

Re: [dpdk-dev] [PATCH v4 3/3] ethdev: eliminate interim variable

2018-11-13 Thread Andrew Rybchenko
On 11/13/18 2:51 PM, Ferruh Yigit wrote: On 11/13/2018 11:22 AM, Andrew Rybchenko wrote: On 11/13/18 2:12 PM, Ferruh Yigit wrote: `local_conf` variable was needed for offload conversions but no more required. No functional difference, only interim variable eliminated. Fixes: ab3ce1e0c193 ("eth

Re: [dpdk-dev] [PATCH] security: remove experimental tag

2018-11-13 Thread Akhil Goyal
Hi Konstantin, On 11/13/2018 5:19 PM, Ananyev, Konstantin wrote: > Hi Akhil, > >> -Original Message- >> From: Akhil Goyal [mailto:akhil.go...@nxp.com] >> Sent: Tuesday, November 13, 2018 11:28 AM >> To: dev@dpdk.org >> Cc: tho...@monjalon.net; Ananyev, Konstantin ; >> jerin.ja...@caviumne

Re: [dpdk-dev] [PATCH] net/qede: fix Tx tunnel offload notsup mask

2018-11-13 Thread Ferruh Yigit
On 11/12/2018 6:19 PM, Mody, Rasesh wrote: > From: Shahed Shaikh > > Tunneling offloads are represented by multi-bit values. So, feature > wise tunneling offload can only be entirely supported/unsupported > using PKT_TX_TUNNEL_MASK. Its upon PMDs to further isolate which of > the tunneling offloa

Re: [dpdk-dev] [PATCH] security: remove experimental tag

2018-11-13 Thread Ananyev, Konstantin
> > Hi Konstantin, > > On 11/13/2018 5:19 PM, Ananyev, Konstantin wrote: > > Hi Akhil, > > > >> -Original Message- > >> From: Akhil Goyal [mailto:akhil.go...@nxp.com] > >> Sent: Tuesday, November 13, 2018 11:28 AM > >> To: dev@dpdk.org > >> Cc: tho...@monjalon.net; Ananyev, Konstantin

Re: [dpdk-dev] [PATCH] security: remove experimental tag

2018-11-13 Thread Akhil Goyal
> > Hi Konstantin, > > On 11/13/2018 5:19 PM, Ananyev, Konstantin wrote: > > Hi Akhil, > > > >> -Original Message- > >> From: Akhil Goyal [mailto:akhil.go...@nxp.com] > >> Sent: Tuesday, November 13, 2018 11:28 AM > >> To: dev@dpdk.org > >> Cc: tho...@monjalon.net; Ananyev, Konstantin >

[dpdk-dev] [PATCH] lib: fix write unlock during ring creation

2018-11-13 Thread Chaitanya Babu Talluri
In rte_efd_create() write lock has already been unlocked before ring creation itself. So second unlock after the ring creation has been removed and added freeing of tail queue entry and efd table. Fixes: 56b6ef874f80 ("efd: new Elastic Flow Distributor library") Cc: sta...@dpdk.org Signed-off-by:

Re: [dpdk-dev] [PATCH 0/4] net/mlx5: prepare to add E-switch rule flags check

2018-11-13 Thread Shahaf Shuler
Monday, November 12, 2018 10:02 PM, Slava Ovsiienko: > Subject: [PATCH 0/4] net/mlx5: prepare to add E-switch rule flags check > > The tc flower filter rules are used to control E-switch from the application > side. In order to gain garanteed rule hardware offload the skip_sw flag > should be spec

Re: [dpdk-dev] [PATCH 1/4] net/mlx5: prepare Netlink communication routine to fix

2018-11-13 Thread Shahaf Shuler
Monday, November 12, 2018 10:02 PM, Slava Ovsiienko: > Subject: [PATCH 1/4] net/mlx5: prepare Netlink communication routine to fix > Maybe a better title can be "net/mlx5: remove unused TC message length parameter" > This patch removes the unused message length parameter, we do not send > multi

Re: [dpdk-dev] [PATCH 2/4] net/mlx5: fix Netlink communication routine

2018-11-13 Thread Shahaf Shuler
Monday, November 12, 2018 10:02 PM, Slava Ovsiienko: > Subject: [PATCH 2/4] net/mlx5: fix Netlink communication routine > > While receiving the Netlink reply messages we should stop at DONE or ACK > message. The existing implementation stops at DONE message or if no > multiple message flag set ( N

[dpdk-dev] [PATCH] test: fix to skip power acpi cpufreq autotest

2018-11-13 Thread Pallantla Poornima
Power_acpi_cpufreq_autotest should not be run on VM and platforms which dont have acpi_cpufreq module loaded. Hence changed return as TEST_SKIPPED Fixes: 0ea2dd4409 ("test: skip when required lib not available") Cc: sta...@dpdk.org Signed-off-by: Pallantla Poornima --- test/test/test_power_acpi

[dpdk-dev] [PATCH] test: fix to skip kni autotest

2018-11-13 Thread Pallantla Poornima
Kni_autotest should be skipped if rte_kni.ko module is not loaded. Hence changed return as TEST_SKIPPED. Fixes: ee1caebc4d ("test/kni: check module dependency") Cc: sta...@dpdk.org Signed-off-by: Pallantla Poornima --- test/test/test_kni.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

[dpdk-dev] [PATCH] app/pdump: fix port id storage size

2018-11-13 Thread Marko Kovacevic
port_id size should be uint16_t, fix where it is defined as uint8_t Fixes: f8244c6399d9 ("ethdev: increase port id range") Cc: zhiyong.y...@intel.com Signed-off-by: Marko Kovacevic --- app/pdump/main.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/app/pdump/main.c b/

[dpdk-dev] [PATCH] app/pdump: fix port id storage size

2018-11-13 Thread Marko Kovacevic
port_id size should be uint16_t, fix where it is defined as uint8_t Fixes: f8244c6399d9 ("ethdev: increase port id range") Cc: zhiyong.y...@intel.com Signed-off-by: Marko Kovacevic --- app/pdump/main.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/app/pdump/main.c b/

[dpdk-dev] [PATCH v2] app/pdump: fix port id storage size

2018-11-13 Thread Marko Kovacevic
port_id size should be uint16_t, fix where it is defined as uint8_t Fixes: f8244c6399d9 ("ethdev: increase port id range") Cc: zhiyong.y...@intel.com Cc: sta...@dpdk.org Signed-off-by: Marko Kovacevic -- v2: Added cc to stable --- app/pdump/main.c | 6 +++--- 1 file changed, 3 insertions(+),

[dpdk-dev] [PATCH] net/sfc/base: fix field order in filter spec struct

2018-11-13 Thread Andrew Rybchenko
From: Igor Romanov Fields in the struct efx_filter_spec_t starting from efs_outer_vid are hashed for software filter lookup. efs_mark is not a matching criteria. Exclude efs_mark from hash. Fixes: 5f78af523912 ("net/sfc: support MARK and FLAG actions in flow API") Cc: sta...@dpdk.org Signed-off

[dpdk-dev] [PATCH] eal: clean up unused files on initialization

2018-11-13 Thread Anatoly Burakov
When creating process data structures, EAL will create many files in EAL runtime directory. Because we allow multiple secondary processes to run, each secondary process gets their own unique file. With many secondary processes running and exiting on the system, runtime directory will, over time, cr

Re: [dpdk-dev] [PATCH] security: remove experimental tag

2018-11-13 Thread Ananyev, Konstantin
> > >> -Original Message- > > >> From: Akhil Goyal [mailto:akhil.go...@nxp.com] > > >> Sent: Tuesday, November 13, 2018 11:28 AM > > >> To: dev@dpdk.org > > >> Cc: tho...@monjalon.net; Ananyev, Konstantin > > >> ; jerin.ja...@caviumnetworks.com; > > >> anoob.jos...@caviumnetworks.com; Nic

[dpdk-dev] [PATCH] net/enic: fix the size check in Tx prepare handler

2018-11-13 Thread Hyong Youb Kim
The current code wrongly assumes that packets are non-TSO and ends up rejecting large TSO packets. Check non-TSO and TSO max packet sizes separately. Fixes: 5a12c387405a ("net/enic: check maximum packet size in Tx prepare handler") Cc: sta...@dpdk.org Signed-off-by: Hyong Youb Kim Reviewed-by:

Re: [dpdk-dev] [PATCH 1/1] eal: Don't fail secondary if primary is missing tailqs

2018-11-13 Thread Burdick, Cliff
-Original Message- From: Burakov, Anatoly [mailto:anatoly.bura...@intel.com] Sent: Tuesday, November 13, 2018 1:39 AM To: Thomas Monjalon; Burdick, Cliff Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH 1/1] eal: Don't fail secondary if primary is missing tailqs On 13-Nov-18 9:21 AM, Th

[dpdk-dev] [PATCH v2] eal: clean up unused files on initialization

2018-11-13 Thread Anatoly Burakov
When creating process data structures, EAL will create many files in EAL runtime directory. Because we allow multiple secondary processes to run, each secondary process gets their own unique file. With many secondary processes running and exiting on the system, runtime directory will, over time, cr

Re: [dpdk-dev] [PATCH v1 0/2] ring C11 library fix and optimization

2018-11-13 Thread Thomas Monjalon
09/11/2018 12:42, Gavin Hu: > V1: > Update the ring C11 library including the following changes: > 1) On relaxed ordering platforms(like Arm64,PPPC), in ring C11 implementation, >loading head and tail might be reodered, this makes CAS(compare and retry >the flow if the head is outdated) not

Re: [dpdk-dev] [dpdk-stable] [PATCH] devbind: check for lspci

2018-11-13 Thread Burakov, Anatoly
On 07-Nov-18 4:01 PM, Ferruh Yigit wrote: On 11/7/2018 1:56 PM, Anatoly Burakov wrote: On some distributions (such as CentOS 7) lspci may not be installed by default, causing exceptions which are difficult to interpret. Fix devbind script to check if lspci is installed at script startup. I gu

[dpdk-dev] [PATCH v2] devbind: check for lspci

2018-11-13 Thread Anatoly Burakov
On some distributions (such as CentOS 7) lspci may not be installed by default, causing exceptions which are difficult to interpret. Fix devbind script to check if lspci is installed at script startup. Cc: sta...@dpdk.org Signed-off-by: Anatoly Burakov --- Notes: v2: correct package name t

Re: [dpdk-dev] [PATCH 1/1] eal: Don't fail secondary if primary is missing tailqs

2018-11-13 Thread Thomas Monjalon
13/11/2018 16:45, Burdick, Cliff: > From: Burakov, Anatoly [mailto:anatoly.bura...@intel.com] > > On 13-Nov-18 9:21 AM, Thomas Monjalon wrote: > > > 13/11/2018 00:33, Burdick, Cliff: > > >> This patch was submitted by Jean Tourrilhes over two years ago, but > > >> didn't receive any responses. I h

Re: [dpdk-dev] [PATCH] test: fix to skip power acpi cpufreq autotest

2018-11-13 Thread Pattan, Reshma
> -Original Message- > From: Poornima, PallantlaX > Sent: Tuesday, November 13, 2018 1:58 PM > To: dev@dpdk.org > Cc: Pattan, Reshma ; Hunt, David > ; Poornima, PallantlaX > ; sta...@dpdk.org > Subject: [PATCH] test: fix to skip power acpi cpufreq autotest > > Power_acpi_cpufreq_autotes

Re: [dpdk-dev] [PATCH] test: fix to skip kni autotest

2018-11-13 Thread Pattan, Reshma
> -Original Message- > From: Poornima, PallantlaX > Sent: Tuesday, November 13, 2018 2:00 PM > To: dev@dpdk.org > Cc: Pattan, Reshma ; Yigit, Ferruh > ; Poornima, PallantlaX > ; sta...@dpdk.org > Subject: [PATCH] test: fix to skip kni autotest > > Kni_autotest should be skipped if rte_k

Re: [dpdk-dev] [PATCH v2 1/1] hash: separate lf and rw lock lookup code paths

2018-11-13 Thread Thomas Monjalon
11/11/2018 08:48, Jerin Jacob: > > > > The lock-free algorithm has caused significant lookup > > performance regression for certain use cases. The > > regression is attributed to the use of non-relaxed > > memory orderings. 2 versions of the lookup functions > > are created. One that uses the RW l

Re: [dpdk-dev] [PATCH 1/1] eal: Don't fail secondary if primary is missing tailqs

2018-11-13 Thread Burdick, Cliff
-Original Message- From: Thomas Monjalon [mailto:tho...@monjalon.net] Sent: Tuesday, November 13, 2018 8:07 AM To: Burdick, Cliff Cc: Burakov, Anatoly; dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH 1/1] eal: Don't fail secondary if primary is missing tailqs 13/11/2018 16:45, Burdick, Cl

Re: [dpdk-dev] [dpdk-stable] [PATCH v2 2/4] hash: add local cache for TSX region

2018-11-13 Thread Thomas Monjalon
12/11/2018 19:34, Honnappa Nagarahalli: > > > > From: Yipeng Wang > > > > This patch adds back the local cache when TSX support is turned on. > > > > When TSX is turned on, free key-data slot ring would be contended by various > > TSX regions. The purpose of this commit is to reduce possible me

[dpdk-dev] [PATCH] devbind: don't display non-existent device categories

2018-11-13 Thread Anatoly Burakov
If there aren't any devices of a particular category on user's system, we still display them, which is bad for usability. Fix devbind to not print out a category unless there are devices in it. Signed-off-by: Anatoly Burakov --- usertools/dpdk-devbind.py | 27 --- 1 file

Re: [dpdk-dev] [PATCH] lib: fix to free trail queue entry after use

2018-11-13 Thread Pattan, Reshma
> -Original Message- > From: Vemula, Hari KumarX > Sent: Tuesday, November 13, 2018 11:46 AM > To: dev@dpdk.org > Cc: Pattan, Reshma ; Marohn, Byron > ; De Lara Guarch, Pablo > ; Vemula, Hari KumarX > ; sta...@dpdk.org > Subject: [PATCH] lib: fix to free trail queue entry after use Nit:

Re: [dpdk-dev] [PATCH 1/1] eal: Don't fail secondary if primary is missing tailqs

2018-11-13 Thread Thomas Monjalon
13/11/2018 17:38, Burdick, Cliff: > > -Original Message- > From: Thomas Monjalon [mailto:tho...@monjalon.net] > Sent: Tuesday, November 13, 2018 8:07 AM > To: Burdick, Cliff > Cc: Burakov, Anatoly; dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH 1/1] eal: Don't fail secondary if primary is

[dpdk-dev] [PATCH] examples/bond: fix initialization error

2018-11-13 Thread Radu Nicolau
Queue setup will fail if called before adding slaves. Fixes: 7a0665940fa8 ("net/bonding: inherit descriptor limits from slaves") Cc: sta...@dpdk.org Signed-off-by: Radu Nicolau --- examples/bond/main.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/examples/b

Re: [dpdk-dev] [PATCH v2] net/pcap: enable data path on secondary

2018-11-13 Thread Ferruh Yigit
On 11/12/2018 4:51 PM, Qi Zhang wrote: > Private vdev on secondary is never supported by the new shared > device mode but pdump still relies on a private pcap PMD on secondary. > The patch enables pcap PMD's data path on secondary so that pdump can > work as usual. It would be great if you describ

Re: [dpdk-dev] [PATCH v2] eal: clean up unused files on initialization

2018-11-13 Thread Thomas Monjalon
13/11/2018 16:54, Anatoly Burakov: > When creating process data structures, EAL will create many files > in EAL runtime directory. Because we allow multiple secondary > processes to run, each secondary process gets their own unique > file. With many secondary processes running and exiting on the >

Re: [dpdk-dev] [PATCH] lib: fix write unlock during ring creation

2018-11-13 Thread Pattan, Reshma
> -Original Message- > From: Chaitanya Babu, TalluriX > Sent: Tuesday, November 13, 2018 12:55 PM > To: dev@dpdk.org > Cc: Marohn, Byron ; Pattan, Reshma > ; De Lara Guarch, Pablo > ; Chaitanya Babu, TalluriX > ; sta...@dpdk.org > Subject: [PATCH] lib: fix write unlock during ring creati

Re: [dpdk-dev] [PATCH] pci: fix parsing of address without function number

2018-11-13 Thread Thomas Monjalon
12/11/2018 10:29, Gaƫtan Rivet: > On Mon, Nov 12, 2018 at 12:58:56AM +0100, Thomas Monjalon wrote: > > If the last part of the PCI address (function number) is missing, > > the parsing was successful, assuming function 0. > > The call to strtoul is not returning an error in such a case, > > so an e

[dpdk-dev] [Bug 106] running dpdk-procinfo or any secondary leading to system memory exhaustion

2018-11-13 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=106 Vipin Varghese (vipin.vargh...@intel.com) changed: What|Removed |Added Status|IN_PROGRESS |RESOLVED Resol

Re: [dpdk-dev] [PATCH] app/pdump: fix port id storage size

2018-11-13 Thread Pattan, Reshma
> -Original Message- > From: Kovacevic, Marko > Sent: Tuesday, November 13, 2018 2:27 PM > To: dev@dpdk.org > Cc: Yigit, Ferruh ; Pattan, Reshma > ; Kovacevic, Marko ; > Yang, Zhiyong > Subject: [PATCH] app/pdump: fix port id storage size > > port_id size should be uint16_t, > fix wher

[dpdk-dev] [PATCH] net/pcap: fix pcap handlers for secondary

2018-11-13 Thread Ferruh Yigit
The intension in NOT to make a complete patch, this is to just for input to discussion. Signed-off-by: Ferruh Yigit --- drivers/net/pcap/rte_eth_pcap.c | 61 - 1 file changed, 52 insertions(+), 9 deletions(-) diff --git a/drivers/net/pcap/rte_eth_pcap.c b/drivers

Re: [dpdk-dev] [PATCH v2] net/pcap: enable data path on secondary

2018-11-13 Thread Thomas Monjalon
Just a quick comment: There are probably some ideas to take from what was done for tap. 13/11/2018 17:56, Ferruh Yigit: > On 11/12/2018 4:51 PM, Qi Zhang wrote: > > Private vdev on secondary is never supported by the new shared > > device mode but pdump still relies on a private pcap PMD on secon

Re: [dpdk-dev] [PATCH v2] ethdev: document RSS default key and types

2018-11-13 Thread Adrien Mazarguil
Again a bit late to the party, please see below. On Sun, Nov 11, 2018 at 09:35:22AM +, Ori Kam wrote: > > -Original Message- > > From: dev On Behalf Of Ophir Munk > > Sent: Friday, November 9, 2018 10:14 AM > > To: Yongseok Koh ; Adrien Mazarguil > > ; Andrew Rybchenko > > > > Cc: Fe

Re: [dpdk-dev] [dpdk-stable] [PATCH v2 2/4] hash: add local cache for TSX region

2018-11-13 Thread Honnappa Nagarahalli
> > > > > > From: Yipeng Wang > > > > > > This patch adds back the local cache when TSX support is turned on. > > > > > > When TSX is turned on, free key-data slot ring would be contended by > > > various TSX regions. The purpose of this commit is to reduce > > > possible memory collisions during

Re: [dpdk-dev] [dpdk-stable] [PATCH v2 2/4] hash: add local cache for TSX region

2018-11-13 Thread Wang, Yipeng1
>-Original Message- >From: Honnappa Nagarahalli [mailto:honnappa.nagaraha...@arm.com] >Sent: Tuesday, November 13, 2018 9:17 AM >To: Thomas Monjalon ; Richardson, Bruce >; Wang, Yipeng1 > >Cc: sta...@dpdk.org; dev@dpdk.org; nd ; nd >Subject: RE: [dpdk-stable] [dpdk-dev] [PATCH v2 2/4] has

[dpdk-dev] [PATCH 2/2] test: add new test-cases for rwlock autotest

2018-11-13 Thread Konstantin Ananyev
This patch targets 19.02 release. Add few functional and perfomance tests for rte_rwlock_read_trylock() and rte_rwlock_write_trylock(). Signed-off-by: Konstantin Ananyev --- test/test/test_rwlock.c | 405 ++-- 1 file changed, 386 insertions(+), 19 deletions(-

[dpdk-dev] [PATCH 1/2] rwlock: introduce 'try' semantics for RD and WR locking

2018-11-13 Thread Konstantin Ananyev
This patch targets 19.02 release. Introduce rte_rwlock_read_trylock() and rte_rwlock_write_trylock(). Signed-off-by: Konstantin Ananyev --- .../common/include/generic/rte_rwlock.h | 54 +++ lib/librte_eal/rte_eal_version.map| 2 + 2 files changed, 56 insertions

[dpdk-dev] [PATCH 0/2] Add 'try' semantics for RD and WR locking

2018-11-13 Thread Konstantin Ananyev
This series targets 19.02 release Introduce rte_rwlock_read_trylock() and rte_rwlock_write_trylock() and new UT test-case for it. Konstantin Ananyev (2): rwlock: introduce 'try' semantics for RD and WR locking test: add new test-cases for rwlock autotest .../common/include/generic/rte_rwloc

Re: [dpdk-dev] [PATCH v2] eal: clean up unused files on initialization

2018-11-13 Thread Burakov, Anatoly
On 13-Nov-18 4:57 PM, Thomas Monjalon wrote: 13/11/2018 16:54, Anatoly Burakov: When creating process data structures, EAL will create many files in EAL runtime directory. Because we allow multiple secondary processes to run, each secondary process gets their own unique file. With many secondary

Re: [dpdk-dev] [dpdk-stable] [PATCH v2 2/4] hash: add local cache for TSX region

2018-11-13 Thread Bruce Richardson
On Tue, Nov 13, 2018 at 05:24:55PM +, Wang, Yipeng1 wrote: > >-Original Message- > >From: Honnappa Nagarahalli [mailto:honnappa.nagaraha...@arm.com] > >Sent: Tuesday, November 13, 2018 9:17 AM > >To: Thomas Monjalon ; Richardson, Bruce > >; Wang, Yipeng1 > > > >Cc: sta...@dpdk.org; dev

Re: [dpdk-dev] [PATCH v4 1/3] ethdev: fix invalid device configuration after failure

2018-11-13 Thread Ferruh Yigit
On 11/13/2018 11:19 AM, Andrew Rybchenko wrote: > On 11/13/18 2:12 PM, Ferruh Yigit wrote: >> From: Wenzhuo Lu >> >> The new configuration is stored during the rte_eth_dev_configure() API >> but the API may fail. After failure stored configuration will be >> invalid since it is not fully applied t

[dpdk-dev] [PATCH 19.02 2/2] mem: use memfd for no-huge mode

2018-11-13 Thread Anatoly Burakov
When running in no-huge mode, we anonymously allocate our memory. While this works for regular NICs and vdev's, it's not suitable for memory sharing scenarios such as virtio with vhost_user backend. To fix this, allocate no-huge memory using memfd, and register it with memalloc just like any other

[dpdk-dev] [PATCH 19.02 1/2] memalloc: allow setting up segment list fd's

2018-11-13 Thread Anatoly Burakov
Currently, only segment fd's for multi-file segments are supported, while for memfd-backed no-huge memory we need single-file segments mode. Add support for single-file segments in the internal API. Signed-off-by: Anatoly Burakov --- lib/librte_eal/bsdapp/eal/eal_memalloc.c | 6 ++ lib/li

[dpdk-dev] [PATCH 19.02 0/2] Allow using virtio without hugepages

2018-11-13 Thread Anatoly Burakov
It is already possible to use both DPDK in general and virtio specifically, without hugetlbfs mounts, but currently virtio cannot be used without hugepage memory (i.e. with a --no-huge EAL switch) due to the fact that it needs to share memory with the backend. This patchset uses memfd to create ac

Re: [dpdk-dev] [dpdk-stable] [PATCH] net/sfc/base: fix field order in filter spec struct

2018-11-13 Thread Ferruh Yigit
On 11/13/2018 3:02 PM, Andrew Rybchenko wrote: > From: Igor Romanov > > Fields in the struct efx_filter_spec_t starting from efs_outer_vid > are hashed for software filter lookup. efs_mark is not a matching > criteria. Exclude efs_mark from hash. > > Fixes: 5f78af523912 ("net/sfc: support MARK a

Re: [dpdk-dev] [PATCH] net/enic: fix the size check in Tx prepare handler

2018-11-13 Thread Ferruh Yigit
On 11/13/2018 3:38 PM, Hyong Youb Kim wrote: > The current code wrongly assumes that packets are non-TSO and ends up > rejecting large TSO packets. Check non-TSO and TSO max packet sizes > separately. > > Fixes: 5a12c387405a ("net/enic: check maximum packet size in Tx prepare > handler") > Cc: st

[dpdk-dev] [PATCH v2] eal/mp: remove rte_panic and profanity

2018-11-13 Thread Anatoly Burakov
EAL should not crash when setting alarm fails. Also, remove the profanity in error message. Fixes: daf9bfca717e ("ipc: remove thread for async requests") Cc: sta...@dpdk.org Cc: step...@networkplumber.org Signed-off-by: Stephen Hemminger Signed-off-by: Anatoly Burakov --- Notes: v2: fix u

Re: [dpdk-dev] [PATCH v2] ethdev: document RSS default key and types

2018-11-13 Thread Ophir Munk
> -Original Message- > From: Adrien Mazarguil [mailto:adrien.mazarg...@6wind.com] > Sent: Tuesday, November 13, 2018 7:15 PM > To: Ori Kam > Cc: Ophir Munk ; Yongseok Koh > ; Andrew Rybchenko > ; Ferruh Yigit ; > dev@dpdk.org; Thomas Monjalon ; Asaf Penso > ; Shahaf Shuler ; Olga > Sher

Re: [dpdk-dev] [PATCH v2] net/pcap: enable data path on secondary

2018-11-13 Thread Zhang, Qi Z
First, apologies to make this in rush since I was somehow under pressure to make pdump works in 18.11. I agree there is lot of things need to improve, but the strategy here is to make it work quietly and not break anything else :) add some comments inline. > -Original Message- > From: T

Re: [dpdk-dev] [PATCH v2] ethdev: document RSS default key and types

2018-11-13 Thread Shahaf Shuler
Hi Adrien, Tuesday, November 13, 2018 7:15 PM, Adrien Mazarguil: > Subject: Re: [dpdk-dev] [PATCH v2] ethdev: document RSS default key and > types > > Again a bit late to the party, please see below. > > On Sun, Nov 11, 2018 at 09:35:22AM +, Ori Kam wrote: [...] > > > The setfault is the

Re: [dpdk-dev] [PATCH v2] net/pcap: enable data path on secondary

2018-11-13 Thread Ferruh Yigit
On 11/13/2018 6:27 PM, Zhang, Qi Z wrote: > First, apologies to make this in rush since I was somehow under pressure to > make pdump works in 18.11. > I agree there is lot of things need to improve, but the strategy here is to > make it work quietly and not break anything else :) > add some comm

Re: [dpdk-dev] [RFC] cryptodev: proposed changes in rte_cryptodev_sym_session

2018-11-13 Thread Ananyev, Konstantin
Hi Fiona, > -Original Message- > From: Trahe, Fiona > Sent: Monday, November 12, 2018 9:01 PM > To: Ananyev, Konstantin ; dev@dpdk.org > Cc: De Lara Guarch, Pablo ; Akhil Goyal > ; Doherty, Declan > ; Ravi Kumar ; Jerin Jacob > ; Zhang, Roy Fan > ; Tomasz Duszynski ; Hemant > Agrawal ;

Re: [dpdk-dev] [RFC] cryptodev: proposed changes in rte_cryptodev_sym_session

2018-11-13 Thread Ananyev, Konstantin
> -Original Message- > From: Trahe, Fiona > Sent: Monday, November 12, 2018 11:25 PM > To: Ananyev, Konstantin ; dev@dpdk.org > Cc: De Lara Guarch, Pablo ; Akhil Goyal > ; Doherty, Declan > ; Ravi Kumar ; Jerin Jacob > ; Zhang, Roy Fan > ; Tomasz Duszynski ; Hemant > Agrawal ; Natalie

[dpdk-dev] [PATCH 2/2] net/mlx5: fix initialization of struct members

2018-11-13 Thread Ali Alnubani
This patch fixes compilation errors with meson and the clang compiler caused by some of the struct members not being initialized. ``` ../drivers/net/mlx5/mlx5_mr.c:345:37: error: missing field 'end' initializer [-Werror,-Wmissing-field-initializers] struct mlx5_mr_cache entry = { 0

[dpdk-dev] [PATCH 1/2] net/mlx4: fix initialization of struct members

2018-11-13 Thread Ali Alnubani
This patch fixes compilation errors with meson and the clang compiler caused by some of the struct members not being initialized. ``` ../drivers/net/mlx4/mlx4_mr.c:357:37: error: missing field 'end' initializer [-Werror,-Wmissing-field-initializers] struct mlx4_mr_cache entry = { 0

[dpdk-dev] [PATCH 1/2] net/mlx4: fix typo

2018-11-13 Thread Ali Alnubani
Fixes: 9797bfcce1c9 ("net/mlx4: add new memory region support") Cc: sta...@dpdk.org Signed-off-by: Ali Alnubani --- drivers/net/mlx4/mlx4_mr.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/mlx4/mlx4_mr.c b/drivers/net/mlx4/mlx4_mr.c index bee858643..c2066ea4b 10

[dpdk-dev] [PATCH 2/2] net/mlx5: fix typo

2018-11-13 Thread Ali Alnubani
Fixes: e1114ff6a5ab ("net/mlx5: support e-switch flow count action") Cc: sta...@dpdk.org Signed-off-by: Ali Alnubani --- drivers/net/mlx5/mlx5_flow_tcf.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/mlx5/mlx5_flow_tcf.c b/drivers/net/mlx5/mlx5_flow_tcf.c index

Re: [dpdk-dev] [PATCH v2] net/pcap: enable data path on secondary

2018-11-13 Thread Zhang, Qi Z
> -Original Message- > From: Yigit, Ferruh > Sent: Tuesday, November 13, 2018 10:44 AM > To: Zhang, Qi Z ; Thomas Monjalon > > Cc: dev@dpdk.org; Lin, Xueqin > Subject: Re: [PATCH v2] net/pcap: enable data path on secondary > > On 11/13/2018 6:27 PM, Zhang, Qi Z wrote: > > First, apolog

Re: [dpdk-dev] [PATCH v2] net/ixgbe: fix ixgbevf link status

2018-11-13 Thread Zhang, Qi Z
> -Original Message- > From: Wu, Yanglong > Sent: Monday, November 12, 2018 10:35 PM > To: dev@dpdk.org > Cc: Zhang, Qi Z ; Xu, Rosen ; > Wang, Dong1 ; Wu, Yanglong > > Subject: [PATCH v2] net/ixgbe: fix ixgbevf link status > > For ixgbevf kernel driver, link status changes from down t

Re: [dpdk-dev] FW: [PATCH] net/i40e: add parameter check for RSS flow init

2018-11-13 Thread Ferruh Yigit
On 11/13/2018 2:41 AM, Zhao1, Wei wrote: > Add Ophir Munk for discussion. > > >> -Original Message- >> From: Peng, Yuan >> Sent: Tuesday, November 13, 2018 10:27 AM >> To: Zhao1, Wei ; Adrien Mazarguil >> >> Cc: dev@dpdk.org >> Subject: RE: FW: [PATCH] net/i40e: add parameter check for R

Re: [dpdk-dev] [PATCH 1/1] eal: Don't fail secondary if primary is missing tailqs

2018-11-13 Thread Burdick, Cliff
-Original Message- From: Thomas Monjalon [mailto:tho...@monjalon.net] Sent: Tuesday, November 13, 2018 8:44 AM To: Burdick, Cliff Cc: Burakov, Anatoly; dev@dpdk.org; bruce.richard...@intel.com Subject: Re: [dpdk-dev] [PATCH 1/1] eal: Don't fail secondary if primary is missing tailqs 1

  1   2   >