[dpdk-dev] [PATCH] kni: use kni_ethtool_ops only with unknown drivers

2018-11-30 Thread Igor Ryzhov
Current implementation of kni_ethtool_ops just uses corresponding ethtool_ops function of underlying driver for all functions except for .get_link. This commit sets kni->net_dev->ethtool_ops directly to the ethtool_ops of the corresponding driver. For unknown drivers (all but ixgbe and i40e) we st

[dpdk-dev] [PATCH v2] kni: use kni_ethtool_ops only with unknown drivers

2018-11-30 Thread Igor Ryzhov
Current implementation of kni_ethtool_ops just uses corresponding ethtool_ops function of underlying driver for all functions except for .get_link. This commit sets kni->net_dev->ethtool_ops directly to the ethtool_ops of the corresponding driver. For unknown drivers (all but ixgbe and i40e) we st

Re: [dpdk-dev] [RFC 0/3] tqs: add thread quiescent state library

2018-11-30 Thread Honnappa Nagarahalli
Hi Luca, Appreciate your comments. > > liburcu has many flavours already, qsbr being one of them. If none of those > are optimal for this use case, why not work with upstream to either improve > the existing flavours, or add a new one? > > You have the specific knowledge and expertise ab

[dpdk-dev] [PATCH] bus/vmbus: fix race in sub channel creation

2018-11-30 Thread Stephen Hemminger
When using multiple queues, there was a race with the kernel in setting up the second channel. This is do due to a kernel change whiche does not allow accessing sysfs files for Hyper-V channels that are not opened. The fix is simple, just move the logic to detect not ready sub channels earlier in

Re: [dpdk-dev] rte_eth_tx_burst send packet fail when upgrade dpdk from 17.02 to 18.02

2018-11-30 Thread Wiles, Keith
On Nov 9, 2018, at 3:18 AM, Jiang Huiyou mailto:jhy19941...@hotmail.com>> wrote: Hi Wiles, Thanks a lot for your reply, I'm not sure what you said "tx flush threshold" exactly is. Is it in parameter of rte_eth_tx_queue_setup function to init tx queue? If so, it's configured as Sorry, f

Re: [dpdk-dev] [RFC 0/3] tqs: add thread quiescent state library

2018-11-30 Thread Mattias Rönnblom
On 2018-11-30 03:13, Honnappa Nagarahalli wrote: Reinventing RCU is not helping anyone. IMO, this depends on what the rte_tqs has to offer and what the requirements are. Before starting this patch, I looked at the liburcu APIs. I have to say, fairly quickly (no offense) I concluded that this

Re: [dpdk-dev] [RFC 0/3] tqs: add thread quiescent state library

2018-11-30 Thread Mattias Rönnblom
On 2018-11-30 03:25, Honnappa Nagarahalli wrote: Generally I'm in favour of using established libraries (particularly for complex functionality like RCU) but in this case I think there's a tradeoff with raw performance. The licensing info [1] is very interesting. Again I am no lawyer :) [1] ht

Re: [dpdk-dev] 答复: [PATCH] net/bonding: fix double fetch for active_slave_count

2018-11-30 Thread Chas Williams
The problem is that I can't see how the API can ever provide accurate information. By the time you have the information it is potentially stale. There really isn't a way to control if a slave is active since that is protocol dependent. rte_eth_bond_slaves_get() is safer in the sense that you co

Re: [dpdk-dev] [PATCH v2] kni: use kni_ethtool_ops only with unknown drivers

2018-11-30 Thread Stephen Hemminger
On Fri, 30 Nov 2018 22:47:50 +0300 Igor Ryzhov wrote: > Current implementation of kni_ethtool_ops just uses corresponding > ethtool_ops function of underlying driver for all functions except for > .get_link. This commit sets kni->net_dev->ethtool_ops directly to the > ethtool_ops of the correspon

Re: [dpdk-dev] [RFC 0/3] tqs: add thread quiescent state library

2018-11-30 Thread Stephen Hemminger
On Fri, 30 Nov 2018 21:56:30 +0100 Mattias Rönnblom wrote: > On 2018-11-30 03:13, Honnappa Nagarahalli wrote: > >> > >> Reinventing RCU is not helping anyone. > > IMO, this depends on what the rte_tqs has to offer and what the > > requirements are. Before starting this patch, I looked at the l

[dpdk-dev] [PATCH] doc: fix a typo in testpmd guide

2018-11-30 Thread Rami Rosen
This patch fixes a typo in testpmd guide (should be ICMP and not IMCP) Signed-off-by: Rami Rosen --- doc/guides/testpmd_app_ug/testpmd_funcs.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/doc/guides/testpmd_app_ug/testpmd_funcs.rst b/doc/guides/testpmd_app_ug/testpmd_fu

[dpdk-dev] [Bug 115] pktgen panic when using big sized pcap file

2018-11-30 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=115 Bug ID: 115 Summary: pktgen panic when using big sized pcap file Product: DPDK Version: 18.11 Hardware: x86 OS: Linux Status: CONFIRMED Severity: major P

[dpdk-dev] [PATCH] net/ixgbe: enable LRO for x550

2018-11-30 Thread Wei Zhao
There is need for enable LRO for x550 NIC, it also support this feature. Signed-off-by: Wei Zhao --- drivers/net/ixgbe/ixgbe_rxtx.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/net/ixgbe/ixgbe_rxtx.c b/drivers/net/ixgbe/ixgbe_rxtx.c index ddc7efa..7771d0e 100644

[dpdk-dev] [Bug 114] rte_rand() is not thread-safe but not documented as such

2018-11-30 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=114 Bug ID: 114 Summary: rte_rand() is not thread-safe but not documented as such Product: DPDK Version: 18.11 Hardware: All OS: All Status: CONFIRMED

[dpdk-dev] Problems running netvsc multiq

2018-11-30 Thread Mohammed Gamal
Hi All, I am having the following errors when I run testpmd with the netvsc driver and --txq 2 and --rxq 2 options: testpmd: create a new mbuf pool : n=155456, size=2176, socket=0 testpmd: preferred mempool ops selected: ring_mp_mc Configuring Port 0 (socket 0) hn_dev_configure():  >> hn_rndis_lin

[dpdk-dev] [PATCH v2 1/2] devtools: report the incorrect section when complaining

2018-11-30 Thread David Marchand
It does not hurt reporting the incriminated section. Before: ERROR: symbol rte_plop is added in a section other than the EXPERIMENTAL section of the version map After: ERROR: symbol rte_plop is added in the DPDK_19.02 section, but is expected to be added in the EXPERIMENTAL section of the version

[dpdk-dev] [PATCH v2 2/2] devtools: drop '+' from the section name

2018-11-30 Thread David Marchand
The incriminated commit did relax the condition to catch all sections but dropped the + removal which can triggers false detection of the special EXPERIMENTAL section when adding symbols and the section in the same patch. Fixes: 7281cf520f89 ("devtools: relax rule for identifying symbol section")

Re: [dpdk-dev] [RFC] DFS (DPDK Filesystem)

2018-11-30 Thread Zhang, Qi Z
Hi Keith: > -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Wiles, Keith > Sent: Tuesday, November 27, 2018 11:00 PM > To: dpdk-dev > Cc: Richardson, Bruce ; Yigit, Ferruh > ; Thomas Monjalon ; > Ananyev, Konstantin > Subject: Re: [dpdk-dev] [RFC] DFS (DPDK Fil

[dpdk-dev] [RFC] sched: new features and improvements

2018-11-30 Thread Dumitrescu, Cristian
Hi guys, Here is a list of incremental features and improvements we are considering to prototype and add to the DPDK hierarchical scheduler SW library. This list is driven by our findings as well as feedback from various users. Please take a look and feel free to add more features to this list

Re: [dpdk-dev] [PATCH 2/3] app/compress-perf: add performance measurement

2018-11-30 Thread Jozwiak, TomaszX
Hi Shally, I'm about of sending V5 of compression-perf tool. Our performance testing shows that the number of sgls in a chain can be a factor in the performance. So we want to keep this on the cmd line for the performance tool. There are alternatives, like setting the input size and segment size

Re: [dpdk-dev] [PATCH v2 2/2] devtools: drop '+' from the section name

2018-11-30 Thread Neil Horman
On Fri, Nov 30, 2018 at 01:32:02PM +0100, David Marchand wrote: > The incriminated commit did relax the condition to catch all sections > but dropped the + removal which can triggers false detection of the > special EXPERIMENTAL section when adding symbols and the section in the > same patch. > >

Re: [dpdk-dev] [dpdk-stable] [PATCH] net/ifcvf: fix a typo

2018-11-30 Thread Ferruh Yigit
On 11/29/2018 8:41 AM, Wang, Xiao W wrote: > Hi, > >> -Original Message- >> From: Ye, Xiaolong >> Sent: Thursday, November 29, 2018 4:22 PM >> To: dev@dpdk.org; Maxime Coquelin ; Bie, >> Tiwei ; Wang, Zhihong >> Cc: Wang, Xiao W ; Ye, Xiaolong >> ; sta...@dpdk.org >> Subject: [PATCH] net/

Re: [dpdk-dev] [RFC] DFS (DPDK Filesystem)

2018-11-30 Thread Wiles, Keith
On Nov 30, 2018, at 7:13 AM, Zhang, Qi Z mailto:qi.z.zh...@intel.com>> wrote: Hi Keith: -Original Message- From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Wiles, Keith Sent: Tuesday, November 27, 2018 11:00 PM To: dpdk-dev mailto:dev@dpdk.org>> Cc: Richardson, Bruce mailto:bruce

Re: [dpdk-dev] [PATCH v2 2/2] devtools: drop '+' from the section name

2018-11-30 Thread David Marchand
Thomas, On Fri, Nov 30, 2018 at 4:28 PM Neil Horman wrote: > On Fri, Nov 30, 2018 at 01:32:02PM +0100, David Marchand wrote: > > The incriminated commit did relax the condition to catch all sections > > but dropped the + removal which can triggers false detection of the > > special EXPERIMENTAL

Re: [dpdk-dev] [dpdk-stable] [PATCH] net/i40e: fixed return value check for hash

2018-11-30 Thread Ferruh Yigit
On 11/30/2018 9:05 AM, Qiming Yang wrote: > RSS hash configure get API didn't check the return value. > Will return sucess even get RSS hash key failed. This patch > fixed teh issue. > > Fixes: d0a349409bd7 ("i40e: support AQ based RSS config") > Cc: sta...@dpdk.org > > Signed-off-by: Qiming Yang

Re: [dpdk-dev] [RFC] DFS (DPDK Filesystem)

2018-11-30 Thread Wiles, Keith
Plain text format is a real pain unless I time travel to the 1990’s :-( > On Nov 30, 2018, at 7:13 AM, Zhang, Qi Z wrote: > > Hi Keith: > > >> -Original Message- >> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Wiles, Keith >> Sent: Tuesday, November 27, 2018 11:00 PM >> To: dpd

Re: [dpdk-dev] [PATCH] helloworld: Windows DPDK sample application is compiled and built using eal and kvargs libraries in order to add windows support in the mainline repository.

2018-11-30 Thread Luca Boccassi
On Wed, 2018-11-28 at 21:05 -0800, Pallavi Kadam wrote: > Signed-off-by: Pallavi Kadam > --- > [RFC] This is a large patch that contains changes to build the > HelloWorld > sample application on Windows. It also contains changes to build the > librte_eal and librte_kvargs libraries which are requi

Re: [dpdk-dev] [RFC 0/3] tqs: add thread quiescent state library

2018-11-30 Thread Luca Boccassi
On Fri, 2018-11-30 at 02:13 +, Honnappa Nagarahalli wrote: > > > > > > > Mixed feelings about this one. > > > > > > > > > > Love to see RCU used for more things since it is much better > > > > > than > > > > > reader/writer locks for many applications. But hate to see > > > > > DPDK > > > > >

[dpdk-dev] [PATCH v2 0/9] ipsec: new library for IPsec data-path processing

2018-11-30 Thread Konstantin Ananyev
This patch series depends on the patch: http://patches.dpdk.org/patch/48044/ to be applied first. v1 -> v2 - Changes to get into account l2_len for outbound transport packets (Qi comments) - Several bug fixes - Some code restructured - Update MAINTAINERS file RFCv2 -> v1 - Changes per Jer

[dpdk-dev] [PATCH v2 1/9] cryptodev: add opaque userdata pointer into crypto sym session

2018-11-30 Thread Konstantin Ananyev
Add 'uint64_t opaque_data' inside struct rte_cryptodev_sym_session. That allows upper layer to easily associate some user defined data with the session. Signed-off-by: Konstantin Ananyev --- lib/librte_cryptodev/rte_cryptodev.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/lib/librte_cry

[dpdk-dev] [PATCH v2 2/9] security: add opaque userdata pointer into security session

2018-11-30 Thread Konstantin Ananyev
Add 'uint64_t opaque_data' inside struct rte_security_session. That allows upper layer to easily associate some user defined data with the session. Signed-off-by: Konstantin Ananyev --- lib/librte_security/rte_security.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/lib/librte_security/r

[dpdk-dev] [PATCH v2 5/9] ipsec: add SA data-path API

2018-11-30 Thread Konstantin Ananyev
Introduce Security Association (SA-level) data-path API Operates at SA level, provides functions to: - initialize/teardown SA object - process inbound/outbound ESP/AH packets associated with the given SA (decrypt/encrypt, authenticate, check integrity, add/remove ESP/AH related

[dpdk-dev] [PATCH v2 3/9] net: add ESP trailer structure definition

2018-11-30 Thread Konstantin Ananyev
Signed-off-by: Konstantin Ananyev --- lib/librte_net/rte_esp.h | 10 +- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/lib/librte_net/rte_esp.h b/lib/librte_net/rte_esp.h index f77ec2eb2..8e1b3d2dd 100644 --- a/lib/librte_net/rte_esp.h +++ b/lib/librte_net/rte_esp.h @@ -11,7

[dpdk-dev] [PATCH v2 4/9] lib: introduce ipsec library

2018-11-30 Thread Konstantin Ananyev
Introduce librte_ipsec library. The library is supposed to utilize existing DPDK crypto-dev and security API to provide application with transparent IPsec processing API. That initial commit provides some base API to manage IPsec Security Association (SA) object. Signed-off-by: Mohammad Abdul Awal

[dpdk-dev] [PATCH v2 6/9] ipsec: implement SA data-path API

2018-11-30 Thread Konstantin Ananyev
Provide implementation for rte_ipsec_pkt_crypto_prepare() and rte_ipsec_pkt_process(). Current implementation: - supports ESP protocol tunnel mode. - supports ESP protocol transport mode. - supports ESN and replay window. - supports algorithms: AES-CBC, AES-GCM, HMAC-SHA1, NULL. - covers all c

[dpdk-dev] [PATCH v2 9/9] test/ipsec: introduce functional test

2018-11-30 Thread Konstantin Ananyev
Create functional test for librte_ipsec. Signed-off-by: Mohammad Abdul Awal Signed-off-by: Bernard Iremonger Signed-off-by: Konstantin Ananyev --- test/test/Makefile |3 + test/test/meson.build |3 + test/test/test_ipsec.c | 2209 3 files c

[dpdk-dev] [PATCH v2 7/9] ipsec: rework SA replay window/SQN for MT environment

2018-11-30 Thread Konstantin Ananyev
With these changes functions: - rte_ipsec_pkt_crypto_prepare - rte_ipsec_pkt_process can be safely used in MT environment, as long as the user can guarantee that they obey multiple readers/single writer model for SQN+replay_window operations. To be more specific: for outbound SA there are

[dpdk-dev] [PATCH v2 8/9] ipsec: helper functions to group completed crypto-ops

2018-11-30 Thread Konstantin Ananyev
Introduce helper functions to process completed crypto-ops and group related packets by sessions they belong to. Signed-off-by: Konstantin Ananyev --- lib/librte_ipsec/Makefile | 1 + lib/librte_ipsec/meson.build | 2 +- lib/librte_ipsec/rte_ipsec.h | 2 +

Re: [dpdk-dev] [PATCH v2 1/2] version: 19.02-rc0

2018-11-30 Thread Ferruh Yigit
On 11/28/2018 2:52 PM, Thomas Monjalon wrote: > Start version numbering for a new release cycle, > and introduce a template file for release notes. > > The release notes comments are updated to mandate > a scope label for API and ABI changes. > > Signed-off-by: Thomas Monjalon > Reviewed-by: Fer

[dpdk-dev] [PATCH v2 3/7] examples/ipsec-secgw: fix crypto-op might never get dequeued

2018-11-30 Thread Konstantin Ananyev
In some cases crypto-ops could never be dequeued from the crypto-device. The easiest way to reproduce: start ipsec-secgw with crypto-dev and send to it less then 32 packets. none packets will be forwarded. Reason for that is that the application does dequeue() from crypto-queues only when new packe

[dpdk-dev] [PATCH v2 4/7] examples/ipsec-secgw: fix outbound codepath for single SA

2018-11-30 Thread Konstantin Ananyev
Looking at process_pkts_outbound_nosp() there seems few issues: - accessing mbuf after it was freed - invoking ipsec_outbound() for ipv4 packets only - copying number of packets, but not the mbuf pointers itself that patch provides fixes for that issues. Fixes: 906257e965b7 ("examples/ipsec-secgw

[dpdk-dev] [PATCH v2 5/7] examples/ipsec-secgw: make app to use ipsec library

2018-11-30 Thread Konstantin Ananyev
Changes to make ipsec-secgw to utilize librte_ipsec library. That patch provides: - changes in the related data structures. - changes in the initialization code. - new command-line parameters to enable librte_ipsec codepath and related features. Note that right now by default current (non-li

[dpdk-dev] [PATCH v2 6/7] examples/ipsec-secgw: make data-path to use ipsec library

2018-11-30 Thread Konstantin Ananyev
Changes to make ipsec-secgw data-path code to utilize librte_ipsec library. Note that right now by default current (non-librte_ipsec) code-path will be used. User has to run application with new command-line option ('-l') to enable new codepath. Signed-off-by: Mohammad Abdul Awal Signed-off-by: K

[dpdk-dev] [PATCH v2 1/7] examples/ipsec-secgw: avoid to request unused TX offloads

2018-11-30 Thread Konstantin Ananyev
ipsec-secgw always enables TX offloads (DEV_TX_OFFLOAD_MULTI_SEGS, DEV_TX_OFFLOAD_SECURITY), even when they are not requested by the config. That causes many PMD to choose full-featured TX function, which in many cases is much slower then one without offloads. That patch adds checks to enabled extr

[dpdk-dev] [PATCH v2 0/7] examples/ipsec-secgw: make app to use ipsec library

2018-11-30 Thread Konstantin Ananyev
This patch series depends on the patch series: Add 'try' semantics for RD and WR locking http://patches.dpdk.org/patch/48044/ http://patches.dpdk.org/patch/48045/ ipsec: new library for IPsec data-path processing http://patches.dpdk.org/patch/48436/ http://patches.dpdk.org/patch/48437/ http://pat

[dpdk-dev] [PATCH v2 2/7] examples/ipsec-secgw: allow to specify neighbor mac address

2018-11-30 Thread Konstantin Ananyev
In some cases it is useful to allow user to specify destination ether address for outgoing packets. This patch adds such ability by introducing new 'neigh' config file option. Signed-off-by: Konstantin Ananyev --- examples/ipsec-secgw/ipsec-secgw.c | 21 +++-- examples/ipsec-secgw/ipsec.h

[dpdk-dev] [PATCH v2 7/7] examples/ipsec-secgw: add scripts for functional test

2018-11-30 Thread Konstantin Ananyev
The purpose of these scripts is to automate ipsec-secgw functional testing. The scripts require two machines (SUT and DUT) connected through at least 2 NICs and running linux (so far tested only on Ubuntu 18.04). Introduced test-cases for the following scenarios: - Transport/Tunnel modes - AES-CBC

Re: [dpdk-dev] [PATCH v2 2/2] devtools: drop '+' from the section name

2018-11-30 Thread Ferruh Yigit
On 11/30/2018 3:28 PM, Neil Horman wrote: > On Fri, Nov 30, 2018 at 01:32:02PM +0100, David Marchand wrote: >> The incriminated commit did relax the condition to catch all sections >> but dropped the + removal which can triggers false detection of the >> special EXPERIMENTAL section when adding sym

Re: [dpdk-dev] Problems running netvsc multiq

2018-11-30 Thread Stephen Hemminger
On Fri, 30 Nov 2018 12:04:41 +0100 Mohammed Gamal wrote: > Hi All, > I am having the following errors when I run testpmd with the netvsc > driver and --txq 2 and --rxq 2 options: > > testpmd: create a new mbuf pool : n=155456, > size=2176, socket=0 > testpmd: preferred mempool ops selected: ring

Re: [dpdk-dev] [RFC 0/3] tqs: add thread quiescent state library

2018-11-30 Thread Stephen Hemminger
On Fri, 30 Nov 2018 16:26:25 + Luca Boccassi wrote: > On Fri, 2018-11-30 at 02:13 +, Honnappa Nagarahalli wrote: > > > > > > > > > Mixed feelings about this one. > > > > > > > > > > > > Love to see RCU used for more things since it is much better > > > > > > than > > > > > > reader/wr

Re: [dpdk-dev] Problems running netvsc multiq

2018-11-30 Thread Mohammed Gamal
- Stephen Hemminger wrote: > On Fri, 30 Nov 2018 12:04:41 +0100 > Mohammed Gamal wrote: > > > Hi All, > > I am having the following errors when I run testpmd with the netvsc > > driver and --txq 2 and --rxq 2 options: > > > > testpmd: create a new mbuf pool : n=155456, > > size=2176, sock

Re: [dpdk-dev] [PATCH 0/3] new software event timer adapter

2018-11-30 Thread Carrillo, Erik G
Hi Pavan, Thanks for the feedback. Response inline: > -Original Message- > From: Pavan Nikhilesh [mailto:pbhagavat...@caviumnetworks.com] > Sent: Friday, November 30, 2018 1:26 AM > To: Carrillo, Erik G ; Jacob, Jerin > ; rsanf...@akamai.com > Cc: step...@networkplumber.org; dev@dpdk.org

Re: [dpdk-dev] [PATCH] kni: implement header_ops parse method

2018-11-30 Thread Igor Ryzhov
Hi Ferruh, header_ops.parse method is used by raw-sockets to fill sockaddr_ll structure. It is used, for example, in isisd for frrouting. Regarding your question about eth_header_ops – I, unfortunately, don't know why .cache and .cache_update are disabled for KNI. I also think that it will be bet