[dpdk-dev] [PATCH v2] net/i40e: fixed get RSS conf

2018-12-24 Thread Qiming Yang
rte_eth_dev_rss_hash_conf_get API doesn't force 'rss_conf.rss_key' to be not NULL, so rss_key = NULL should be alllowed in i40e driver. Fixes: 16321de09396 ("ethdev: allow to get RSS hash functions and key") Cc: sta...@dpdk.org Signed-off-by: Qiming Yang --- drivers/net/i40e/i40e_ethdev.c | 5 +

Re: [dpdk-dev] [PATCH v4 1/9] examples/ipsec-secgw: avoid to request unused TX offloads

2018-12-24 Thread Akhil Goyal
On 12/21/2018 9:28 PM, Ananyev, Konstantin wrote: > >> -Original Message- >> From: Akhil Goyal [mailto:akhil.go...@nxp.com] >> Sent: Friday, December 21, 2018 1:57 PM >> To: Ananyev, Konstantin ; dev@dpdk.org >> Cc: Nicolau, Radu ; Horton, Remy >> >> Subject: Re: [dpdk-dev] [PATCH v4 1/

Re: [dpdk-dev] [PATCH v4 1/9] examples/ipsec-secgw: avoid to request unused TX offloads

2018-12-24 Thread Ananyev, Konstantin
> >> > >> On 12/14/2018 10:10 PM, Konstantin Ananyev wrote: > >>> ipsec-secgw always enables TX offloads > >>> (DEV_TX_OFFLOAD_MULTI_SEGS, DEV_TX_OFFLOAD_SECURITY), > >>> even when they are not requested by the config. > >>> That causes many PMD to choose full-featured TX function, > >>> which in

Re: [dpdk-dev] [PATCH] hash: fix possible uninitialized variable

2018-12-24 Thread Dumitrescu, Cristian
> -Original Message- > From: Stephen Hemminger [mailto:step...@networkplumber.org] > Sent: Sunday, December 23, 2018 7:44 AM > To: Haiyang Tan > Cc: Dumitrescu, Cristian ; dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH] hash: fix possible uninitialized variable > > On Sat, 22 Dec 2018 0

Re: [dpdk-dev] [PATCH v4 1/9] examples/ipsec-secgw: avoid to request unused TX offloads

2018-12-24 Thread Akhil Goyal
On 12/24/2018 3:49 PM, Ananyev, Konstantin wrote: > On 12/14/2018 10:10 PM, Konstantin Ananyev wrote: > ipsec-secgw always enables TX offloads > (DEV_TX_OFFLOAD_MULTI_SEGS, DEV_TX_OFFLOAD_SECURITY), > even when they are not requested by the config. > That causes many PMD to c

Re: [dpdk-dev] [PATCH v4 1/9] examples/ipsec-secgw: avoid to request unused TX offloads

2018-12-24 Thread Akhil Goyal
On 12/24/2018 4:24 PM, Akhil Goyal wrote: > > On 12/24/2018 3:49 PM, Ananyev, Konstantin wrote: > On 12/14/2018 10:10 PM, Konstantin Ananyev wrote: >> ipsec-secgw always enables TX offloads >> (DEV_TX_OFFLOAD_MULTI_SEGS, DEV_TX_OFFLOAD_SECURITY), >> even when they are not requeste

Re: [dpdk-dev] [PATCH v4 1/9] examples/ipsec-secgw: avoid to request unused TX offloads

2018-12-24 Thread Ananyev, Konstantin
> -Original Message- > From: Akhil Goyal [mailto:akhil.go...@nxp.com] > Sent: Monday, December 24, 2018 10:54 AM > To: Ananyev, Konstantin ; dev@dpdk.org > Cc: Nicolau, Radu ; Horton, Remy > > Subject: Re: [dpdk-dev] [PATCH v4 1/9] examples/ipsec-secgw: avoid to request > unused TX off

Re: [dpdk-dev] [PATCH v4 1/9] examples/ipsec-secgw: avoid to request unused TX offloads

2018-12-24 Thread Akhil Goyal
On 12/24/2018 4:52 PM, Ananyev, Konstantin wrote: > >> -Original Message- >> From: Akhil Goyal [mailto:akhil.go...@nxp.com] >> Sent: Monday, December 24, 2018 10:54 AM >> To: Ananyev, Konstantin ; dev@dpdk.org >> Cc: Nicolau, Radu ; Horton, Remy >> >> Subject: Re: [dpdk-dev] [PATCH v4 1

Re: [dpdk-dev] [PATCH v4 1/9] examples/ipsec-secgw: avoid to request unused TX offloads

2018-12-24 Thread Ananyev, Konstantin
> -Original Message- > From: Akhil Goyal [mailto:akhil.go...@nxp.com] > Sent: Monday, December 24, 2018 11:25 AM > To: Ananyev, Konstantin ; dev@dpdk.org > Cc: Nicolau, Radu ; Horton, Remy > > Subject: Re: [dpdk-dev] [PATCH v4 1/9] examples/ipsec-secgw: avoid to request > unused TX off

[dpdk-dev] [PATCH] examples/flow_filtering: fix example documentation

2018-12-24 Thread Dekel Peled
Previous patch removed the VLAN item from example code. This patch fixes the documentation accordingly. Fixes: 9af4eb565710 ("examples/flow_filtering: remove VLAN item") Cc: or...@mellanox.com Signed-off-by: Dekel Peled --- doc/guides/sample_app_ug/flow_filtering.rst | 74 +++---

Re: [dpdk-dev] [PATCH] net/ixgbe: enable x550 flexible byte filter

2018-12-24 Thread Zhang, Qi Z
Hi Wei: > -Original Message- > From: Zhao1, Wei > Sent: Monday, December 17, 2018 1:53 PM > To: dev@dpdk.org > Cc: adrien.mazarg...@6wind.com; sta...@dpdk.org; Lu, Wenzhuo > ; Zhang, Qi Z ; Zhao1, Wei > > Subject: [PATCH] net/ixgbe: enable x550 flexible byte filter > > There is need for

Re: [dpdk-dev] [PATCH v4 6/9] examples/ipsec-secgw: make app to use ipsec library

2018-12-24 Thread Ananyev, Konstantin
> > diff --git a/examples/ipsec-secgw/meson.build > > b/examples/ipsec-secgw/meson.build > > index 77d8b298f..31f68fee2 100644 > > --- a/examples/ipsec-secgw/meson.build > > +++ b/examples/ipsec-secgw/meson.build > > @@ -6,7 +6,7 @@ > > # To build this example as a standalone application with a

Re: [dpdk-dev] [PATCH v4 1/9] examples/ipsec-secgw: avoid to request unused TX offloads

2018-12-24 Thread Akhil Goyal
On 12/24/2018 5:07 PM, Ananyev, Konstantin wrote: > >> -Original Message- >> From: Akhil Goyal [mailto:akhil.go...@nxp.com] >> Sent: Monday, December 24, 2018 11:25 AM >> To: Ananyev, Konstantin ; dev@dpdk.org >> Cc: Nicolau, Radu ; Horton, Remy >> >> Subject: Re: [dpdk-dev] [PATCH v4 1

Re: [dpdk-dev] [PATCH v4 6/9] examples/ipsec-secgw: make app to use ipsec library

2018-12-24 Thread Akhil Goyal
On 12/24/2018 5:59 PM, Ananyev, Konstantin wrote: >>> diff --git a/examples/ipsec-secgw/meson.build >>> b/examples/ipsec-secgw/meson.build >>> index 77d8b298f..31f68fee2 100644 >>> --- a/examples/ipsec-secgw/meson.build >>> +++ b/examples/ipsec-secgw/meson.build >>> @@ -6,7 +6,7 @@ >>># To b

Re: [dpdk-dev] [PATCH v4 6/9] examples/ipsec-secgw: make app to use ipsec library

2018-12-24 Thread Ananyev, Konstantin
> -Original Message- > From: Akhil Goyal [mailto:akhil.go...@nxp.com] > Sent: Monday, December 24, 2018 12:33 PM > To: Ananyev, Konstantin ; dev@dpdk.org > Cc: Nicolau, Radu ; Awal, Mohammad Abdul > ; Iremonger, Bernard > > Subject: Re: [dpdk-dev] [PATCH v4 6/9] examples/ipsec-secgw: ma

Re: [dpdk-dev] [PATCH v2] net/i40e: fixed get RSS conf

2018-12-24 Thread Zhang, Qi Z
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Qiming Yang > Sent: Monday, December 24, 2018 11:34 PM > To: dev@dpdk.org > Cc: Yigit, Ferruh ; Yang, Qiming > ; sta...@dpdk.org > Subject: [dpdk-dev] [PATCH v2] net/i40e: fixed get RSS conf s/fixed/fix > > rte_et

[dpdk-dev] [PATCH] build: use generic march on arm64 when using 'default' machine

2018-12-24 Thread Luca Boccassi
When building for generic distribution we need a stable baseline architecture, or depending on the build worker the result will vary. Force the default flags if the user explicitly sets marchine=default at configuration time. Fixes: b1d48c41189a ("build: support ARM with meson") Cc: sta...@dpdk.o

Re: [dpdk-dev] [PATCH v4 6/9] examples/ipsec-secgw: make app to use ipsec library

2018-12-24 Thread Ananyev, Konstantin
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Ananyev, Konstantin > Sent: Monday, December 24, 2018 12:37 PM > To: Akhil Goyal ; dev@dpdk.org > Cc: Nicolau, Radu ; Awal, Mohammad Abdul > ; Iremonger, Bernard > > Subject: Re: [dpdk-dev] [PATCH v4 6/9] exampl

Re: [dpdk-dev] [PATCH v4 6/9] examples/ipsec-secgw: make app to use ipsec library

2018-12-24 Thread Akhil Goyal
On 12/24/2018 6:51 PM, Ananyev, Konstantin wrote: > >> -Original Message- >> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Ananyev, Konstantin >> Sent: Monday, December 24, 2018 12:37 PM >> To: Akhil Goyal ; dev@dpdk.org >> Cc: Nicolau, Radu ; Awal, Mohammad Abdul >> ; Iremonger,

Re: [dpdk-dev] [PATCH v4 6/9] examples/ipsec-secgw: make app to use ipsec library

2018-12-24 Thread Ananyev, Konstantin
> -Original Message- > From: Akhil Goyal [mailto:akhil.go...@nxp.com] > Sent: Monday, December 24, 2018 1:50 PM > To: Ananyev, Konstantin ; dev@dpdk.org > Cc: Nicolau, Radu ; Awal, Mohammad Abdul > ; Iremonger, Bernard > > Subject: Re: [dpdk-dev] [PATCH v4 6/9] examples/ipsec-secgw: mak

Re: [dpdk-dev] [PATCH] net/ixgbe: enable x550 flexible byte filter

2018-12-24 Thread Zhao1, Wei
Hi, qi > -Original Message- > From: Zhang, Qi Z > Sent: Monday, December 24, 2018 8:13 PM > To: Zhao1, Wei ; dev@dpdk.org > Cc: adrien.mazarg...@6wind.com; sta...@dpdk.org; Lu, Wenzhuo > > Subject: RE: [PATCH] net/ixgbe: enable x550 flexible byte filter > > Hi Wei: > > > -Original M

Re: [dpdk-dev] [PATCH] examples/flow_filtering: fix example documentation

2018-12-24 Thread Ori Kam
> -Original Message- > From: dev On Behalf Of Dekel Peled > Sent: Monday, December 24, 2018 12:51 PM > To: Ori Kam > Cc: dev@dpdk.org; Dekel Peled > Subject: [dpdk-dev] [PATCH] examples/flow_filtering: fix example > documentation > > Previous patch removed the VLAN item from example

[dpdk-dev] [PATCH v2 0/2] enable x550 flexible byte filter

2018-12-24 Thread Wei Zhao
There is need for users to use flexible byte filter on x550. Command line need to pase hex number. This patch enable all of these feature. --- v2: add some paser code for flow CLI and split it in v2 Zhao Wei (2): net/ixgbe: enable x550 flexible byte filter app/testpmd: add support of hex st

[dpdk-dev] [PATCH v2 1/2] net/ixgbe: enable x550 flexible byte filter

2018-12-24 Thread Wei Zhao
There is need for users to use flexible byte filter on x550. x550 support IP mode and tunnel mode flexible byte filter. tunnel mode flexible byte filter is used for vxlan packets and so on. It can be used combined with FDIR tunnel filter. By now, ixgbe PMD flow parer code do not support tunnel mode

[dpdk-dev] [PATCH v2 2/2] app/testpmd: add support of hex string parser for flow API

2018-12-24 Thread Wei Zhao
There is need for users to use flexible byte filter on ixgbe. The flexible byte should be pass down as hex number not char string. This patch enable users to make configuration using hex number for flexible byte filter. cmdline flow parse HEX number, in order to not using string which pass ASIC num

[dpdk-dev] [PATCH v3]/driver/raw/ifpga_rawdev: fix a memory leak bug in ifpga

2018-12-24 Thread AndyPei
When ifpga_rawdev_create() allocate memory for a new rawdev, the original code allocate redundant memory for adapter, which is a member of the rawdev. What is actually necessary is the adapter to be initialized, not memory allocated. What is different in v3 from v2 is that the adapter is no longe

Re: [dpdk-dev] [PATCH] examples/flow_filtering: fix example documentation

2018-12-24 Thread Dekel Peled
PSB. > -Original Message- > From: Ori Kam > Sent: Tuesday, December 25, 2018 5:25 AM > To: Dekel Peled > Cc: dev@dpdk.org; Dekel Peled > Subject: RE: [dpdk-dev] [PATCH] examples/flow_filtering: fix example > documentation > > > > > -Original Message- > > From: dev On Behalf O

Re: [dpdk-dev] [PATCH] examples/flow_filtering: fix example documentation

2018-12-24 Thread Ori Kam
PSB > -Original Message- > From: Dekel Peled > Sent: Tuesday, December 25, 2018 8:31 AM > To: Ori Kam > Cc: dev@dpdk.org > Subject: RE: [dpdk-dev] [PATCH] examples/flow_filtering: fix example > documentation > > PSB. > > > -Original Message- > > From: Ori Kam > > Sent: Tuesday,

[dpdk-dev] [PATCH] net/ice: fixed CRC strip issue

2018-12-24 Thread Qiming Yang
Fixes: 50370662b727 ("net/ice: support device and queue ops") Signed-off-by: Qiming Yang --- drivers/net/ice/ice_rxtx.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/ice/ice_rxtx.c b/drivers/net/ice/ice_rxtx.c index 78e40fe..c794ee8 100644 --- a/drivers/net/ice/ice_rxtx.c +++ b