Re: [dpdk-dev] [PATCH v3 0/2] vhost: Support external backend only vhost-user requests

On 3/19/19 11:54 AM, Maxime Coquelin wrote: The goals of this series is to provide more flexibility to external backends to implement their specific vhost-user request handling without having to patch vhost-user library. First patch implements a new API for external backend to advertize its s

Re: [dpdk-dev] [PATCH 00/10] net/virtio: cleanups and fixes for packed/split ring

On 3/19/19 7:43 AM, Tiwei Bie wrote: Tiwei Bie (10): net/virtio: fix typo in packed ring init net/virtio: fix interrupt helper for packed ring net/virtio: add missing barrier in interrupt enable net/virtio: optimize flags update for packed ring net/virtio: refactor virtqueue str

Re: [dpdk-dev] [PATCH] net/virtio-user: fix multiqueue support with vhost kernel

On 3/12/19 8:13 AM, Tiwei Bie wrote: The multiqueue support in virtio-user with vhost kernel backend is broken when tap name isn't specified by users explicitly, because the tap name returned by ioctl(TUNSETIFF) isn't saved properly, and multiple tap interfaces will be created in this case. Fi

Re: [dpdk-dev] [PATCH v2] vhost: fix interrupt suppression for the split ring

On 3/17/19 7:38 AM, Jiayu Hu wrote: The VIRTIO_RING_F_EVENT_IDX feature of split ring might be broken, as the value of signalled_used is invalid after live migration, start up and virtio driver reload. This patch fixes it by using signalled_used_valid. In addition, this patch makes the VIRTIO

Re: [dpdk-dev] [PATCH] raw/ifpga: modify log output.

Yes, I will do this way in v2. -Original Message- From: Xu, Rosen Sent: Tuesday, March 19, 2019 6:41 PM To: Pei, Andy ; dev@dpdk.org Cc: sta...@dpdk.org Subject: RE: [PATCH] raw/ifpga: modify log output. Hi Andy, Get your point, and my reply is online. > -Original Message- > F

Re: [dpdk-dev] [PATCH v2] raw/ifpga: modify log output

> -Original Message- > From: Pei, Andy > Sent: Wednesday, March 20, 2019 16:03 > To: dev@dpdk.org > Cc: Xu, Rosen ; Pei, Andy ; > sta...@dpdk.org > Subject: [PATCH v2] raw/ifpga: modify log output > > print function name in ifpga log and a new line goes after every IFPGA log. > > Fixes

[dpdk-dev] [PATCH v2 1/4] net/ice: load OS default package

This patch enables package downloading to the device. The package is to be in the /lib/firmware/intel/ice/ddp directory and named ice.pkg. The package is shared by the kernel driver and the DPDK PMD. There is no per device package be supported so far, all the devices can only download the same pac

[dpdk-dev] [PATCH v2 2/4] net/ice: add safe mode

If E810 download package failed, driver need to go to safe mode. In the safe mode, some advanced features will not be supported. Signed-off-by: Qiming Yang --- drivers/net/ice/ice_ethdev.c | 48 +--- drivers/net/ice/ice_ethdev.h | 1 + 2 files changed, 33

[dpdk-dev] [PATCH v2 0/4] enable package download in ice driver

This patch set enabled package downloading to the device. The package is to be in the /lib/firmware/intel/ice/ddp directory and named ice.pkg. The package is shared by the kernel driver and the DPDK PMD. If package download failed, driver need to go to safe mode. This patch set disabled RSS, QINQ,

[dpdk-dev] [PATCH v2 4/4] doc: add document update for package download

Updated ice.rst and release_19_05.rst. Signed-off-by: Qiming Yang --- doc/guides/nics/ice.rst| 9 + doc/guides/rel_notes/release_19_05.rst | 5 + 2 files changed, 14 insertions(+) diff --git a/doc/guides/nics/ice.rst b/doc/guides/nics/ice.rst index 3998d5e..6410ec5 1

[dpdk-dev] [PATCH v2 3/4] net/ice: enable RSS when device init

This patch enabled RSS for UPD/TCP/SCTP+IPV4/IPV6 packets. Signed-off-by: Qiming Yang --- drivers/net/ice/ice_ethdev.c | 39 +++ 1 file changed, 39 insertions(+) diff --git a/drivers/net/ice/ice_ethdev.c b/drivers/net/ice/ice_ethdev.c index a217da8..60aaedc 1

Re: [dpdk-dev] [PATCH] net/i40e: add warning info when no perfect RSS key

Tested-by: Peng Yuan - Tested Branch: master - Tested Commit: 239912fa798e6e671072ca7ff987afd74c1e506c - OS: 4.13.9-300.fc27.x86_64 - GCC: gcc (GCC) 7.3.1 20180303 (Red Hat 7.3.1-5) - CPU: Intel(R) Xeon(R) CPU E5-2699 v4 @ 2.20GHz - NIC: Intel Corporation Device Fortville [8086:1583] - Default x8

Re: [dpdk-dev] [PATCH v2 5/6] net/af_xdp: enable zero copy

On Tue, Mar 19, 2019 at 8:17 AM Xiaolong Ye wrote: > Try to check if external mempool (from rx_queue_setup) is fit for > af_xdp, if it is, it will be registered to af_xdp socket directly and > there will be no packet data copy on Rx and Tx. > > Signed-off-by: Xiaolong Ye > --- > drivers/net/af_

Re: [dpdk-dev] [PATCH v2 1/6] net/af_xdp: introduce AF XDP PMD driver

On Tue, Mar 19, 2019 at 8:17 AM Xiaolong Ye wrote: > diff --git a/doc/guides/nics/features/af_xdp.ini > b/doc/guides/nics/features/af_xdp.ini > new file mode 100644 > index 0..7b8fcce00 > --- /dev/null > +++ b/doc/guides/nics/features/af_xdp.ini > @@ -0,0 +1,11 @@ > +; > +; Supported feat

Re: [dpdk-dev] [PATCH v2 6/6] app/testpmd: add mempool flags parameter

On Wed, Mar 20, 2019 at 12:37 AM Jerin Jacob Kollanukkaran < jer...@marvell.com> wrote: > On Tue, 2019-03-19 at 15:12 +0800, Xiaolong Ye wrote: > > When create rte_mempool, flags can be parsed from command line. > > Now, it is possible for testpmd to create a af_xdp friendly > > mempool (which ena

Re: [dpdk-dev] [PATCH] net/i40e: add warning info when no perfect RSS key

Thank you! > -Original Message- > From: Peng, Yuan > Sent: Wednesday, March 20, 2019 5:21 PM > To: Zhao1, Wei ; dev@dpdk.org > Cc: sta...@dpdk.org; Zhang, Qi Z > Subject: RE: [PATCH] net/i40e: add warning info when no perfect RSS key > > Tested-by: Peng Yuan > > - Tested Branch: master

[dpdk-dev] [PATCH v9] eal_interrupts: add option for pending callback unregister

use case: if callback is used to receive message form socket, and the message received is disconnect/error, this callback needs to be unregistered, but cannot because it is still active. With this patch it is possible to mark the callback to be unregistered once the interrupt process is done with

Re: [dpdk-dev] [PATCH v6 1/2] eal/ticketlock: ticket based to improve fairness

Hi Gavin, > > > > > > > > > diff --git a/lib/librte_eal/common/include/generic/rte_ticketlock.h > > > > b/lib/librte_eal/common/include/generic/rte_ticketlock.h > > > > > new file mode 100644 > > > > > index 000..d63 > > > > > --- /dev/null > > > > > +++ b/lib/librte_eal/common/include/gene

Re: [dpdk-dev] [PATCH v2 5/6] net/af_xdp: enable zero copy

From: David Marchand [mailto:david.march...@redhat.com] Sent: Wednesday, March 20, 2019 5:22 PM To: Ye, Xiaolong Cc: dev ; Zhang, Qi Z ; Karlsson, Magnus ; Topel, Bjorn Subject: Re: [dpdk-dev] [PATCH v2 5/6] net/af_xdp: enable zero copy On Tue, Mar 19, 2019 at 8:17 AM Xiaolong Ye wrote: T

[dpdk-dev] [PATCH v3 0/4] display testpmd forwarding engine stats on the fly

Here is a little series that makes it possible to display and clear testpmd fwd engines while they run without having to stop them. This is mostly handy when running stress tests and you look for packets drops without having to stop/start testpmd forwarding. Example: testpmd> show fwd stats all

[dpdk-dev] [PATCH v3 2/4] app/testpmd: extend fwd statistics to 64bits

fwd engine statistics are stored as unsigned int (32bits) and can wrap quite quickly. Example: sending 7mpps for 614s gives us 429800 packets => 0x1002e4680 larger than 32bits. testpmd reports forwarding stats as: RX-packets: 3500381TX-packets: 3500010TX-dropped: 371 While the

[dpdk-dev] [PATCH v3 1/4] app/testpmd: add missing newline when showing statistics

Having the standard stats and the rx burst stats on the same line gives a really long line and is not consistent with the rest. Before: RX-packets: 3542977TX-packets: 3542971TX-dropped: 6 RX-bursts : 499440 [24% of 2 pkts + 15% of 1 pkts + 61% of others] TX-burst

[dpdk-dev] [PATCH v3 3/4] app/testpmd: remove useless casts on statistics

Caught by code review while investigating the fwd stats display code. Fixes: af75078fece3 ("first public release") Cc: sta...@dpdk.org Signed-off-by: David Marchand --- Changelog since v2: - focused on useless casts only - Cc'd stable --- app/test-pmd/testpmd.c | 8 1 file changed, 4

[dpdk-dev] [PATCH v3 4/4] app/testpmd: display/clear forwarding stats on demand

Add a new "show/clear fwd stats all" command to display fwd and port statistics on the fly. To be able to do so, the (testpmd only) rte_port structure can't be used to maintain any statistics. Moved the stats dump parts from stop_packet_forwarding() and merge with fwd_port_stats_display() into fwd

[dpdk-dev] [PATCH v3 0/3] enable package download in ice driver

This patch set enabled package downloading to the device. The package is to be in the /lib/firmware/intel/ice/ddp directory and named ice.pkg. The package is shared by the kernel driver and the DPDK PMD. If package download failed, driver need to go to safe mode. This patch set disabled RSS, QINQ,

[dpdk-dev] [PATCH v3 2/3] net/ice: add safe mode

If E810 download package failed, driver need to go to safe mode. In the safe mode, some advanced features will not be supported. Signed-off-by: Qiming Yang --- doc/guides/rel_notes/release_19_05.rst | 1 + drivers/net/ice/ice_ethdev.c | 48 ++ drivers/n

[dpdk-dev] [PATCH v3 1/3] net/ice: load OS default package

This patch enables package downloading to the device. The package is to be in the /lib/firmware/intel/ice/ddp directory and named ice.pkg. The package is shared by the kernel driver and the DPDK PMD. There is no per device package be supported so far, all the devices can only download the same pac

[dpdk-dev] [PATCH v3 3/3] net/ice: enable RSS when device init

This patch enabled RSS for UPD/TCP/SCTP+IPV4/IPV6 packets. Signed-off-by: Qiming Yang --- doc/guides/rel_notes/release_19_05.rst | 1 + drivers/net/ice/ice_ethdev.c | 39 ++ 2 files changed, 40 insertions(+) diff --git a/doc/guides/rel_notes/release_19

Re: [dpdk-dev] [PATCH v2] net/enic: add private API to set ingress VLAN rewrite mode

On 3/19/2019 8:30 PM, Thomas Monjalon wrote: > 19/03/2019 19:00, Ferruh Yigit: >> On 3/19/2019 5:36 PM, Thomas Monjalon wrote: >>> 19/03/2019 18:29, Ferruh Yigit: On 3/14/2019 10:04 PM, Thomas Monjalon wrote: > 14/03/2019 03:58, Hyong Youb Kim: >> On Wed, Mar 13, 2019 at 10:29:53PM +01

[dpdk-dev] [Bug 228] rte_mp_request_sync memleak with multiple recipients

https://bugs.dpdk.org/show_bug.cgi?id=228 Bug ID: 228 Summary: rte_mp_request_sync memleak with multiple recipients Product: DPDK Version: unspecified Hardware: All OS: All Status: CONFIRMED Severity: mino

Re: [dpdk-dev] checklist for DPDK on Windows

+Khoa -Original Message- From: Ranjit Menon Sent: Tuesday, March 19, 2019 12:34 PM To: Thomas Monjalon ; dev@dpdk.org Cc: Harini Ramakrishnan ; Omar Cardona ; anand.ra...@intel.com; pallavi.ka...@intel.com; jeffrey.b.s...@intel.com; bruce.richard...@intel.com; step...@networkplumber.o

Re: [dpdk-dev] [dpdk-stable] [PATCH v2] raw/ifpga: modify log output

On 3/20/2019 8:16 AM, Xu, Rosen wrote: > > >> -Original Message- >> From: Pei, Andy >> Sent: Wednesday, March 20, 2019 16:03 >> To: dev@dpdk.org >> Cc: Xu, Rosen ; Pei, Andy ; >> sta...@dpdk.org >> Subject: [PATCH v2] raw/ifpga: modify log output >> >> print function name in ifpga log and

Re: [dpdk-dev] [PATCH] app/testpmd: fix a typo.

> -Original Message- > From: Yigit, Ferruh > Sent: Tuesday, March 19, 2019 6:31 PM > To: Rami Rosen ; dev@dpdk.org > Cc: Lu, Wenzhuo ; Wu, Jingjing > ; Iremonger, Bernard > > Subject: Re: [dpdk-dev] [PATCH] app/testpmd: fix a typo. > > On 3/12/2019 5:48 AM, Rami Rosen wrote: > > This patc

Re: [dpdk-dev] checklist for DPDK on Windows

+Eilon Thanks, Olga -Original Message- From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Omar Cardona Sent: Tuesday, March 19, 2019 10:36 PM To: Ranjit Menon ; Thomas Monjalon ; dev@dpdk.org Cc: Harini Ramakrishnan ; anand.ra...@intel.com; pallavi.ka...@intel.com; jeffrey.b.s...@int

[dpdk-dev] [dpdk-announce] 2019 DPDK PRC Summit Call for Proposal -- Shanghai June 24

The 2019 DPDK PRC Summit will take place in Shanghai Expo Centre on June 24. It gathers developers and solution architects to share and learn about the cutting edge data plane technologies for Cloud and NFV, including latest updates on: * DPDK and other related projects (OVS, FD.io, Tungsten Fab

[dpdk-dev] [PATCH] test: fix build when pdump config is disabled

pdump unit test has dependency on pthread code in test.c and process.h to run send_pkts(), this code should be enabled only when CONFIG_RTE_LIBRTE_PDUMP is enabled. Bugzilla ID: 222 Fixes: 086eb64db3 ("test/pdump: add unit test for pdump library") CC: sta...@dpdk.org Signed-off-by: Reshma Pattan

Re: [dpdk-dev] [PATCH v2] net/enic: add private API to set ingress VLAN rewrite mode

20/03/2019 11:45, Ferruh Yigit: > On 3/19/2019 8:30 PM, Thomas Monjalon wrote: > > 19/03/2019 19:00, Ferruh Yigit: > >> On 3/19/2019 5:36 PM, Thomas Monjalon wrote: > >>> 19/03/2019 18:29, Ferruh Yigit: > On 3/14/2019 10:04 PM, Thomas Monjalon wrote: > > 14/03/2019 03:58, Hyong Youb Kim: >

[dpdk-dev] [PATCH 0/5] bonding fixes

Here is a first series of fixes on the bonding driver I caught while reviewing its code. -- David Marchand David Marchand (5): doc: fix incorrect bond examples net/bonding: fix incorrect bond port id types net/bonding: fix incorrect slave id types net/bonding: fix incorrect packet count

[dpdk-dev] [PATCH 2/5] net/bonding: fix incorrect bond port id types

Following the port id conversion to 16bits, two references to bonding port id have been missed. Fixes: f8244c6399d9 ("ethdev: increase port id range") Cc: sta...@dpdk.org Signed-off-by: David Marchand --- drivers/net/bonding/rte_eth_bond_pmd.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deleti

[dpdk-dev] [PATCH 1/5] doc: fix incorrect bond examples

Removed incorrect space character and fixed pci addresses. Fixes: fc1f2750a3ec ("doc: programmers guide") Cc: sta...@dpdk.org Signed-off-by: David Marchand --- doc/guides/prog_guide/link_bonding_poll_mode_drv_lib.rst | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/do

[dpdk-dev] [PATCH 4/5] net/bonding: fix incorrect packet count type for lacp

Caught by code review, those variables are supposed to be on 16bits to avoid endless loops in the (unlikely?) case where the application asks for receiving more than 256 packets and the accumulated num_rx_total count reaches 256: uint16_t num_rx_total = 0; uint8_t j, k; j = num_rx_total; num_rx_t

[dpdk-dev] [PATCH 3/5] net/bonding: fix incorrect slave id types

Caught by code review, with port id conversion to 16bits, the slave id have been extended to 16bits as well (both slave index and count). Fixes: f8244c6399d9 ("ethdev: increase port id range") Cc: sta...@dpdk.org Signed-off-by: David Marchand --- drivers/net/bonding/rte_eth_bond_8023ad.c | 10

[dpdk-dev] [PATCH 5/5] net/bonding: fix incorrect rxq/txq index types

Caught by code review, rxq and txq indexes are on 16bits. Fixes: d1d1e664c6c4 ("bonding: free queue memory when closing") Cc: sta...@dpdk.org Signed-off-by: David Marchand --- drivers/net/bonding/rte_eth_bond_pmd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/

[dpdk-dev] [PATCH] net/cxgbe: fix missing csum ol_flags and ptype

From: Vishal Kulkarni Checksum good offload flags are not being set and some of the packet type flags are missing on received packets. So, rework Rx path to set proper ol_flags and packet_type in mbufs. Fixes: 78fc1a716ae8 ("cxgbe: improve Rx performance") Cc: sta...@dpdk.org Signed-off-by: Vis

[dpdk-dev] [PATCH] net/cxgbe: remove unused code in Rx path

From: Vishal Kulkarni All Rx packet handling is done in process_responses() and hence t4_ethrx_handler() never gets called. So, remove it. Signed-off-by: Vishal Kulkarni Signed-off-by: Rahul Lakkireddy --- drivers/net/cxgbe/base/adapter.h | 2 - drivers/net/cxgbe/cxgbe_ethdev.c | 2 +- driv

[dpdk-dev] [PATCH] test/ipsec: fix test initialisation

Fix xform initialisation. Fix testsuite_setup. Loop on rte_cryptodev_dequeue_burst(). Remove unused variables. Fixes: 05fe65eb66b2 ("test/ipsec: introduce functional test") Fixes: 59d7353b0df0 ("test/ipsec: fix test suite setup") Signed-off-by: Bernard Iremonger --- app/test/test_ipsec.c | 44 +

Re: [dpdk-dev] [PATCH] net/i40e: add warning info when no perfect RSS key

On 20/03/2019 03:31, Wei Zhao wrote: > There need a warning info when no perfect RSS key is config, It is mixing info and warning levels in the description and log. Better to be consistent and use one (I think info). > so i40e will use default key. > > Fixes: ecad87d22383 ("net/i40e: move RSS to

Re: [dpdk-dev] [PATCH v3 4/4] app/testpmd: display/clear forwarding stats on demand

On 3/20/2019 10:02 AM, David Marchand wrote: > Add a new "show/clear fwd stats all" command to display fwd and port > statistics on the fly. Won't this be duplicating existing commands: "show port stats all|" "clear port stats all|" What benefit "show/clear fwd stats all" adds against existing on

Re: [dpdk-dev] [PATCH v3 4/4] app/testpmd: display/clear forwarding stats on demand

On Wed, Mar 20, 2019 at 1:25 PM Ferruh Yigit wrote: > On 3/20/2019 10:02 AM, David Marchand wrote: > > Add a new "show/clear fwd stats all" command to display fwd and port > > statistics on the fly. > > Won't this be duplicating existing commands: > "show port stats all|" > "clear port stats all|

Re: [dpdk-dev] [PATCH 2/2] doc: update Mellanox supported OFED version

Hi Tom, I couldn't reproduce that. I'm on (master 239912fa7) and testing with: Ubuntu 18.04.2 LTS / 4.15.1-ubuntu gcc: Ubuntu 7.3.0-3ubuntu1 7.3.0 Can you make sure that OFED was installed successfully, and that it's not conflicting with rdma-core libraries already installed on your system (if t

[dpdk-dev] [PATCH v4] build: use generic march on arm64 when using 'default' machine

From: Luca Boccassi When building for generic distribution we need a stable baseline architecture, or depending on the build worker the result will vary. Force the default flags if the user explicitly sets machine=default at configuration time. Fixes: b1d48c41189a ("build: support ARM with meso

Re: [dpdk-dev] [PATCH v3] build: use generic march on arm64 when using 'default' machine

On Wed, 2019-03-20 at 05:01 +, Pavan Nikhilesh Bhagavatula wrote: > On Mon, 2019-01-07 at 14:11 +, Luca Boccassi wrote: > > When building for generic distribution we need a stable baseline > > architecture, or depending on the build worker the result will > > vary. > > > > Force the defaul

Re: [dpdk-dev] [PATCH] app/testpmd: fix stdout flush absence after printing stats

Hi Andrew, > -Original Message- > From: Andrew Rybchenko [mailto:arybche...@solarflare.com] > Sent: Monday, March 18, 2019 11:36 AM > To: Lu, Wenzhuo ; Wu, Jingjing > ; Iremonger, Bernard > > Cc: dev@dpdk.org; Igor Romanov ; > sta...@dpdk.org > Subject: [PATCH] app/testpmd: fix stdout flu

Re: [dpdk-dev] [PATCH v3 03/10] net/atlantic: extra checks for error codes

On 3/12/2019 3:24 PM, Igor Russkikh wrote: > Found by Coverity scan. Checks are useless > because at these code places err is always zero. Can you please add Coverity issue number, I can squash it later. > > Signed-off-by: Igor Russkikh > --- <...>

Re: [dpdk-dev] [PATCH v3 00/11] net/atlantic: bugfixes and code cleanup

On 3/12/2019 3:24 PM, Igor Russkikh wrote: > The patchset mainly fixes some Coverity issues, > couple of minor bugs and overflows. > > It also improves eeprom get/set logic with ability of custom > device address and dump length. > > v3: added coverity ids where known > v2: better git log, line l

[dpdk-dev] [PATCH] net/bonding: fix Segfault when eal thread executing nic‘s lsc event for mode 4

Hi： When the number of slave slave devices exceeds 8, it will cause the array subscript to cross the boundary. According to the suggestions, Modified array subscript to RTE_MAX_ETHPORTS, and Changed uint8_t to uint16_t. Something like this: From 51a081ea88cca1599d458d8d1c7d9605

Re: [dpdk-dev] [PATCH v3 4/4] app/testpmd: display/clear forwarding stats on demand

On 3/20/2019 12:44 PM, David Marchand wrote: > On Wed, Mar 20, 2019 at 1:25 PM Ferruh Yigit > wrote: > > On 3/20/2019 10:02 AM, David Marchand wrote: > > Add a new "show/clear fwd stats all" command to display fwd and port > > statistics on the fly. > >

[dpdk-dev] [PATCH v3] cryptodev: make xform key pointer constant

This patch changes the key pointer data types in cipher, auth, and aead xforms from "uint8_t *" to "const uint8_t *" for a more intuitive and safe sessionn creation. Signed-off-by: Fan Zhang --- v3: - rebased on top of latest dpdk-next-crypto v2: - fixed a missed memory free for ixgbe ipsec dri

Re: [dpdk-dev] [PATCH] net/bonding: fix Segfault when eal thread executing nic‘s lsc event for mode 4

On Wed, Mar 20, 2019 at 2:26 PM Zhaohui (zhaohui, Polestar) < zhaoh...@huawei.com> wrote: > Hi： > When the number of slave slave devices exceeds 8, it will cause > the array subscript to cross the boundary. > According to the suggestions, Modified array subscript to > RTE_MAX_ETH

Re: [dpdk-dev] [PATCH 1/2] examples/ethtool: remove query of default config

On 3/13/2019 5:41 PM, Rami Rosen wrote: > On Wed, Mar 13, 2019 at 11:09:09AM +0100, Thomas Monjalon wrote: >>> The default config is used if the setup parameter is NULL. >>> No need to query the default config with rte_eth_dev_info_get(). >>> The function call will be removed with another useless i

Re: [dpdk-dev] [PATCH v3 1/4] app/testpmd: add missing newline when showing statistics

On 3/20/19 1:02 PM, David Marchand wrote: Having the standard stats and the rx burst stats on the same line gives a really long line and is not consistent with the rest. Before: RX-packets: 3542977TX-packets: 3542971TX-dropped: 6 RX-bursts : 499440 [24% of 2 pkt

Re: [dpdk-dev] [PATCH 1/2] examples/ethtool: remove query of default config

20/03/2019 14:46, Ferruh Yigit: > Applied to dpdk-next-net/master, thanks. > > (only this patch merged, not series. Other patch seems waiting for comment.) Applying half of patchset makes tracking of patches less obvious. I prefer we avoid such practice.

[dpdk-dev] [PATCH v4 1/4] ipsec: support AES-CTR

This patch adds AES-CTR cipher algorithm support to ipsec library. Signed-off-by: Fan Zhang Acked-by: Akhil Goyal --- lib/librte_ipsec/crypto.h | 17 ++ lib/librte_ipsec/sa.c | 133 ++ lib/librte_ipsec/sa.h | 18 +++ 3 files changed,

[dpdk-dev] [PATCH v4 2/4] ipsec-secgw: add test scripts for aes ctr

This patch adds the functional test scripts to ipsec-secgw sample application for both transport and tunnel working mode. Updated a bit on common_defs to use "mktemp" instead of "tempfile" as Fedora does not like the command. Signed-off-by: Fan Zhang --- examples/ipsec-secgw/test/common_defs.sh

[dpdk-dev] [PATCH v4 0/4] ipsec: support AES-CTR and 3DES-CBC

This patchset adds the AES-CTR and 3DES-CBC cipher algorithms support to ipsec library. The test scripts for ipsec-secgw sample application are added. v4: - changed patch titles. - changed ALGO_TYPE naming for 3DES-CBC v3: - fixed a bug in 3DES. v2: - removed unsupported tests. Fan Zhang (4):

Re: [dpdk-dev] [PATCH v4 1/2] timer: allow timer management in shared memory

Hi Erik, I have a few questions and comments on this patch series. 1. Don't you think we need new tests (in test/test/) to verify the secondary-process APIs? 2. I suggest we define default_data_id as const, and explicitly set it to 0. 3. The outer for-loop in rte_timer_alt_manage() touches beyon

[dpdk-dev] [PATCH v4 3/4] ipsec: support 3DES-CBC

This patch adds triple-des CBC mode cipher algorithm to ipsec library. Signed-off-by: Fan Zhang --- lib/librte_ipsec/sa.c | 40 ++-- lib/librte_ipsec/sa.h | 6 ++ 2 files changed, 28 insertions(+), 18 deletions(-) diff --git a/lib/librte_ipsec/sa.c b/lib

[dpdk-dev] [PATCH v4 4/4] ipsec-secgw: add 3des test files

This patch adds the functional test scripts to ipsec-secgw sample application for both transport and tunnel working mode. Signed-off-by: Fan Zhang --- examples/ipsec-secgw/test/run_test.sh | 8 ++- .../test/trs_3descbc_sha1_common_defs.sh | 73 ++ exam

Re: [dpdk-dev] [PATCH v3 2/4] app/testpmd: extend fwd statistics to 64bits

On 3/20/19 1:02 PM, David Marchand wrote: fwd engine statistics are stored as unsigned int (32bits) and can wrap quite quickly. Example: sending 7mpps for 614s gives us 429800 packets => 0x1002e4680 larger than 32bits. testpmd reports forwarding stats as: RX-packets: 3500381TX-packet

Re: [dpdk-dev] [PATCH 1/2] examples/ethtool: remove query of default config

On 3/20/2019 1:51 PM, Thomas Monjalon wrote: > 20/03/2019 14:46, Ferruh Yigit: >> Applied to dpdk-next-net/master, thanks. >> >> (only this patch merged, not series. Other patch seems waiting for comment.) > > Applying half of patchset makes tracking of patches less obvious. > I prefer we avoid su

[dpdk-dev] [PATCH] drivers/virtio: fix duplicate naming of include guard

The LGTM static code analysis tool is reporting "The macro name '_VHOST_NET_USER_H' of this include guard is used in 2 different header files." lib/librte_vhost/vhost_user.h has the same include guard. Renamed the include guard in vhost.h to differentiate. Fixes: 6a84c37e3975 ("net/virtio-user:

Re: [dpdk-dev] [PATCH v3 3/4] app/testpmd: remove useless casts on statistics

On 3/20/19 1:02 PM, David Marchand wrote: Caught by code review while investigating the fwd stats display code. Fixes: af75078fece3 ("first public release") Cc: sta...@dpdk.org Signed-off-by: David Marchand Reviewed-by: Andrew Rybchenko

Re: [dpdk-dev] [PATCH v3 03/10] net/atlantic: extra checks for error codes

Hi Ferruh, Sorry forgot that. Coverity issue: 187034 On 20.03.2019 16:24, Ferruh Yigit wrote: > On 3/12/2019 3:24 PM, Igor Russkikh wrote: >> Found by Coverity scan. Checks are useless >> because at these code places err is always zero. > > Can you please add Coverity issue number, I can squash

Re: [dpdk-dev] [PATCH 1/2] examples/ethtool: remove query of default config

20/03/2019 14:56, Ferruh Yigit: > On 3/20/2019 1:51 PM, Thomas Monjalon wrote: > > 20/03/2019 14:46, Ferruh Yigit: > >> Applied to dpdk-next-net/master, thanks. > >> > >> (only this patch merged, not series. Other patch seems waiting for > >> comment.) > > > > Applying half of patchset makes trac

[dpdk-dev] [dpdk-announce] DPDK 16.11.9 (LTS) released

Hi all, Here is a new stable release: https://fast.dpdk.org/rel/dpdk-16.11.9.tar.xz The git tree is at: https://dpdk.org/browse/dpdk-stable/?h=16.11 Known issues in this release include non-working GRE checksum offload on i40e, intermittent issues with link-state change with PF/V

Re: [dpdk-dev] [PATCH] net/bonding: fix Segfault when eal thread executing nic‘s lsc event for mode 4

Hello Zhaohui, On Wed, Mar 20, 2019 at 2:54 PM Zhaohui (zhaohui, Polestar) < zhaoh...@huawei.com> wrote: > Well done, Can you fix it? > > thanks > > by zhaohui > I can take it as part of my series yes. I will keep your SoB on this part.

Re: [dpdk-dev] [PATCH v1 0/3] ethdev: document more retained across restart

19/03/2019 14:21, Yigit, Ferruh: > On 12/19/2018 6:22 AM, Andrew Rybchenko wrote: > > The patch series tries to improve documentation of what is retained > > across default restart. > > > > Andrew Rybchenko (3): > > ethdev: advertise MTU as retained across device stop/start > > ethdev: adverti

Re: [dpdk-dev] [PATCH v3] ethdev: check for invalid device name

On 3/14/2019 4:20 PM, Stephen Hemminger wrote: > Do not allow creating a ethernet device with a name over the > allowed maximum (or zero length). This is safer than silently truncating > which is what happens now. > > Signed-off-by: Stephen Hemminger > Acked-by: Andrew Rybchenko > --- > v3 -- fi

Re: [dpdk-dev] [dpdk-stable] [PATCH] net/enic: fix max MTU calculation

On 3/14/2019 11:05 AM, Hyong Youb Kim wrote: > The maximum packet length (max_pkt_len) from the firmware does not > include CRC, so do not subtract 4 when deriving the max MTU. This > change effectively increases the max MTU by 4B. Apps often assume max > MTU = max_rx_pkt_len - 14 (ethernet header)

Re: [dpdk-dev] [PATCH v3 0/2] vhost: Support external backend only vhost-user requests

> -Original Message- > From: Maxime Coquelin [mailto:maxime.coque...@redhat.com] > Sent: Wednesday, March 20, 2019 8:35 AM > To: dev@dpdk.org; i.maxim...@samsung.com; Liu, Changpeng > ; Bie, Tiwei ; Stojaczyk, > Dariusz > Subject: Re: [PATCH v3 0/2] vhost: Support external backend only vh

Re: [dpdk-dev] [PATCH 1/3] rte_ethdev: Add API function to read dev clock

19/03/2019 14:32, Yigit, Ferruh: > On 1/8/2019 11:30 AM, Tom Barbette wrote: > > Ferruh Yigit wrote: > >> Why timestamp offloading become useless? When timestamp offloading enabled, > >> device fills 'mbuf.timestamp' and you can use it. > > But the frequency is unknown, and the reference time neith

Re: [dpdk-dev] [PATCH v2] net/octeontx: fix vdev name

On 3/19/2019 10:19 PM, Stephen Hemminger wrote: > On Tue, 19 Mar 2019 18:59:21 + > Ferruh Yigit wrote: > >> On 3/14/2019 3:35 PM, Jerin Jacob Kollanukkaran wrote: >>> On Wed, 2019-03-13 at 14:58 -0700, Stephen Hemminger wrote: The octeontx driver is creating vdev with name "OCTEONTX_P

Re: [dpdk-dev] [pull-request] next-eventdev 18.05 PRE-RC1

15/03/2019 06:50, Jerin Jacob Kollanukkaran: > http://dpdk.org/git/next/dpdk-next-eventdev Pulled, thanks

Re: [dpdk-dev] [PATCH] test: fix build when pdump config is disabled

pdump unit test has dependency on pthread code in test.c and process.h to run send_pkts(), this code should be enabled only when CONFIG_RTE_LIBRTE_PDUMP is enabled. Bugzilla ID: 222 Fixes: 086eb64db3 ("test/pdump: add unit test for pdump library") CC: sta...@dpdk.org Signed-off-by: Reshma Pattan

Re: [dpdk-dev] [PATCH v2 1/6] net/af_xdp: introduce AF XDP PMD driver

Thanks for your comments. On 03/20, David Marchand wrote: >On Tue, Mar 19, 2019 at 8:17 AM Xiaolong Ye wrote: > >> diff --git a/doc/guides/nics/features/af_xdp.ini >> b/doc/guides/nics/features/af_xdp.ini >> new file mode 100644 >> index 0..7b8fcce00 >> --- /dev/null >> +++ b/doc/guides/n

Re: [dpdk-dev] [PATCH v1 0/3] ethdev: document more retained across restart

On 3/20/2019 2:26 PM, Thomas Monjalon wrote: > 19/03/2019 14:21, Yigit, Ferruh: >> On 12/19/2018 6:22 AM, Andrew Rybchenko wrote: >>> The patch series tries to improve documentation of what is retained >>> across default restart. >>> >>> Andrew Rybchenko (3): >>> ethdev: advertise MTU as retained

Re: [dpdk-dev] [PATCH v2 6/6] app/testpmd: add mempool flags parameter

On 03/20, David Marchand wrote: >On Wed, Mar 20, 2019 at 12:37 AM Jerin Jacob Kollanukkaran < >jer...@marvell.com> wrote: > >> On Tue, 2019-03-19 at 15:12 +0800, Xiaolong Ye wrote: >> > When create rte_mempool, flags can be parsed from command line. >> > Now, it is possible for testpmd to create a

Re: [dpdk-dev] [PATCH] ethdev: claim device reset as async

On Wed, 20 Mar 2019 12:54:03 +0800 Qi Zhang wrote: > + ret = rte_ctrl_thread_create(&tid, pthread_name, NULL, > + do_dev_reset, args); > + > + return ret; combine the ret = and return (ie make it a tail call)

Re: [dpdk-dev] [PATCH v1 0/3] ethdev: document more retained across restart

20/03/2019 16:25, Ferruh Yigit: > On 3/20/2019 2:26 PM, Thomas Monjalon wrote: > > 19/03/2019 14:21, Yigit, Ferruh: > >> On 12/19/2018 6:22 AM, Andrew Rybchenko wrote: > >>> The patch series tries to improve documentation of what is retained > >>> across default restart. > >>> > >>> Andrew Rybchenk

[dpdk-dev] [PATCH 0/3]net/mlx5: Add Direct Rule support

This patch set adds support for Direct Rules API for MLX5 driver. As more and more applications like OVS are inserting and removing large number of flows, the flow insertion rate become more critical. In current MLX5 PMD rules are inserted to the device using the FW, this limits the max insertion

[dpdk-dev] [PATCH 1/3] net/mlx5: prepare Direct Verbs for Direct Rule

This is the first patch of a series that is designed to enable the Direct Rules API. The main difference between Direct Verbs and Direct Rules from API prespective, is that in Direct Rules each action has it's own create function and the object itself is of type void. In this patch I'm adding fun

[dpdk-dev] [PATCH 2/3] net/mlx5: add Direct Rules API

Adds calls to the Direct Rules API inside the glue functions. Due to difference in parameters between the Direct Rules and Direct Verbs some of the glue functions API was updated. Signed-off-by: Ori Kam --- drivers/net/mlx5/Makefile | 5 ++ drivers/net/mlx5/mlx5.c | 21 + dr

[dpdk-dev] [PATCH 3/3] net/mlx5: add jump action support for NIC

When using Direct Rules we can add actions to jump between tables. This is extra useful since rule insertion rate is much higher on other tables compared to table zero. if no group is selected the rule is added to group 0. Signed-off-by: Ori Kam --- drivers/net/mlx5/mlx5.h | 6 + driv

[dpdk-dev] [PATCH v5 0/5] ipsec: support AES-CTR and 3DES-CBC

This patchset adds the AES-CTR and 3DES-CBC cipher algorithms support to ipsec library. The test scripts for ipsec-secgw sample application are added. v5: - updated ipsec-secgw run_test.sh script - updated release note v4: - changed patch titles. - changed ALGO_TYPE naming for 3DES-CBC v3: - fix

[dpdk-dev] [PATCH v5 1/5] ipsec: support AES-CTR

This patch adds AES-CTR cipher algorithm support to ipsec library. Signed-off-by: Fan Zhang Acked-by: Akhil Goyal Acked-by: Konstantin Ananyev --- lib/librte_ipsec/crypto.h | 17 ++ lib/librte_ipsec/sa.c | 133 ++ lib/librte_ipsec/sa.h |

[dpdk-dev] [PATCH v5 3/5] ipsec: support 3DES-CBC

This patch adds triple-des CBC mode cipher algorithm to ipsec library. Signed-off-by: Fan Zhang Acked-by: Konstantin Ananyev --- lib/librte_ipsec/sa.c | 40 ++-- lib/librte_ipsec/sa.h | 6 ++ 2 files changed, 28 insertions(+), 18 deletions(-) diff --git

[dpdk-dev] [PATCH v5 4/5] ipsec-secgw: add 3des test files

This patch adds the functional test scripts to ipsec-secgw sample application for both transport and tunnel working mode. Signed-off-by: Fan Zhang Acked-by: Konstantin Ananyev --- examples/ipsec-secgw/test/run_test.sh | 10 ++- .../test/trs_3descbc_sha1_common_defs.sh | 7

[dpdk-dev] [PATCH v5 2/5] ipsec-secgw: add test scripts for aes ctr

This patch adds the functional test scripts to ipsec-secgw sample application for both transport and tunnel working mode. Updated a bit on common_defs to use "mktemp" instead of "tempfile" as Fedora does not like the command. Signed-off-by: Fan Zhang Acked-by: Konstantin Ananyev --- examples/i

[dpdk-dev] [PATCH v5 5/5] doc: update release note

This patch updates the 19.05 release note with IPsec library updates for the newly added AES-CTR and 3DES-CBC algorithm support. Signed-off-by: Fan Zhang --- doc/guides/rel_notes/release_19_05.rst | 6 ++ 1 file changed, 6 insertions(+) diff --git a/doc/guides/rel_notes/release_19_05.rst b

Re: [dpdk-dev] [PATCH 1/3] rte_ethdev: Add API function to read dev clock

On 3/20/19 5:48 PM, Thomas Monjalon wrote: 19/03/2019 14:32, Yigit, Ferruh: On 1/8/2019 11:30 AM, Tom Barbette wrote: Ferruh Yigit wrote: Why timestamp offloading become useless? When timestamp offloading enabled, device fills 'mbuf.timestamp' and you can use it. But the frequency is unknown,

  1   2   >