Re: [dpdk-dev] [PATCH] mbuf: update Tx VLAN and QinQ mbuf flags documentation

On Tue, Apr 02, 2019 at 06:09:46PM +0100, Ferruh Yigit wrote: > Currently PKT_TX_VLAN and PKT_TX_QINQ mbuf flags are documented as > they are to say packet contains VLAN or QINQ information. > > Updating the definition as they are requests from application to > driver to insert VLAN or double VLAN

Re: [dpdk-dev] [PATCH v5 00/14] Add patch set for IPN3KE

Hi, > -Original Message- > From: Yigit, Ferruh > Sent: Friday, April 05, 2019 2:38 > To: Xu, Rosen ; dev@dpdk.org > Cc: Zhang, Tianfei ; Wei, Dan > ; Pei, Andy ; Yang, Qiming > ; Wang, Haiyue ; Chen, > Santos ; Zhang, Zhang ; > Lomartire, David > Subject: Re: [PATCH v5 00/14] Add patch se

Re: [dpdk-dev] [PATCH v5 03/14] drivers/net/ipn3ke: add IPN3KE ethdev PMD driver

Hi, > -Original Message- > From: Yigit, Ferruh > Sent: Friday, April 05, 2019 3:38 > To: Xu, Rosen ; dev@dpdk.org > Cc: Zhang, Tianfei ; Wei, Dan > ; Pei, Andy ; Yang, Qiming > ; Wang, Haiyue ; Chen, > Santos ; Zhang, Zhang ; > Lomartire, David > Subject: Re: [PATCH v5 03/14] drivers/net/

Re: [dpdk-dev] [PATCH v5 04/14] drivers/net/ipn3ke: add IPN3KE representor of PMD driver

Hi, > -Original Message- > From: Yigit, Ferruh > Sent: Friday, April 05, 2019 3:02 > To: Xu, Rosen ; dev@dpdk.org > Cc: Zhang, Tianfei ; Wei, Dan > ; Pei, Andy ; Yang, Qiming > ; Wang, Haiyue ; Chen, > Santos ; Zhang, Zhang ; > Lomartire, David > Subject: Re: [PATCH v5 04/14] drivers/net/

Re: [dpdk-dev] [PATCH v7] sched: make RED scaling configurable

Hi Ferruh, We are still using this patch against DPDK 17.11 and 18.11 as part of the AT&T Vyatta NOS. It is needed to make WRED queues longer than 1024 packets work correctly. I'm afraid that I have no idea what is holding it up from being merged. Regards Alan On Fri, Apr 5, 2019 at 4:36 PM F

[dpdk-dev] [PATCH v2] net/ice: stop lldp by default

This patch stopped lldp by default to avoid the statistics error. Fixes: f9cf4f864150 ("net/ice: support device initialization") Signed-off-by: Qiming Yang --- drivers/net/ice/ice_ethdev.c | 5 + 1 file changed, 5 insertions(+) diff --git a/drivers/net/ice/ice_ethdev.c b/drivers/net/ice/ic

Re: [dpdk-dev] Secondary process crash in rte_eal_init

On 06-Apr-19 3:26 PM, Jim Holland (jimholla) wrote: Hi, We're seeing something similar to what is described in thread below. Our product uses dpdk 17.08. Was there ever a resolution to Souvik's issue? Thanks...Jim On 01/04/2015 06:00, Dey, Souvik wrote: Hi All, We have a si

Re: [dpdk-dev] [RFC 0/3] Add mdev (Mediated device) support in DPDK

On Wed, Apr 3, 2019 at 8:19 AM Tiwei Bie wrote: > Hi everyone, > > This is a draft implementation of the mdev (Mediated device [1]) > bus support in DPDK. Mdev is a way to virtualize devices in Linux > kernel. Based on the device-api (mdev_type/device_api), there could > be different types of mde

Re: [dpdk-dev] [PATCH v7] sched: make RED scaling configurable

08/04/2019 10:24, Alan Dewar: > On Fri, Apr 5, 2019 at 4:36 PM Ferruh Yigit wrote: > > On 1/16/2018 4:07 PM, alangordonde...@gmail.com wrote: > > > From: Alan Dewar > > > > > > The RED code stores the weighted moving average in a 32-bit integer as > > > a pseudo fixed-point floating number with 1

[dpdk-dev] [PATCH 2/2] crypto/caam_jr: fix total length in AUTH only sg case

CAAM return wrong digest value in AUTH only sg test case because digest calculated on wrong length of data Fixes: 71dd6b9d44e7 ("crypto/caam_jr: add scatter gather") Cc: g.si...@nxp.com Signed-off-by: Gagandeep Singh --- drivers/crypto/caam_jr/caam_jr.c | 2 +- 1 file changed, 1 insertion(+), 1

[dpdk-dev] [PATCH 1/2] crypto/caam_jr: fix the shared desc endianness

build a shared descriptor accordingly if core and CAAM endianness is same or different Fixes: 6ef6beca8844 ("crypto/caam_jr: add enqueue/dequeue operations") Cc: g.si...@nxp.com Signed-off-by: Gagandeep Singh --- drivers/crypto/caam_jr/caam_jr.c | 2 +- 1 file changed, 1 insertion(+), 1 deletio

Re: [dpdk-dev] [dpdk-techboard] DPDK ABI/API Stability

On 07/04/2019 10:48, Thomas Monjalon wrote: > 04/04/2019 16:07, Burakov, Anatoly: >> On 04-Apr-19 1:52 PM, Ray Kinsella wrote: >>> On 04/04/2019 11:54, Bruce Richardson wrote: On Thu, Apr 04, 2019 at 10:29:19AM +0100, Burakov, Anatoly wrote: > On 03-Apr-19 4:42 PM, Ray Kinsella wrote: [SNI

[dpdk-dev] [PATCH] net/nfp: fix file descriptor handle

Although it is rather unlikely getting 0 as the descriptor handle, better to contemplate that possibility. Coverity issue: 195018 Fixes: 896c265ef954 ("net/nfp: use new CPP interface") Cc: sta...@dpdk.org Signed-off-by: Alejandro Lucero --- drivers/net/nfp/nfp_net.c | 4 ++-- 1 file changed, 2

Re: [dpdk-dev] [PATCH v2] virtio: fix buffer leak on vlan insert

On Fri, Apr 05, 2019 at 09:31:15AM -0700, Stephen Hemminger wrote: The function rte_vlan_insert may allocate a new buffer for the vlan header and return a different mbuf than originally passed. In this case, the stored mbuf in txm[] array could point to wrong buffer. Fixes: dd856dfcb9e7 ("virtio

[dpdk-dev] [PATCH] app/test-crypto-perf: fix missing bounds check on socket id

The socket_id is used as an array index so should be within the range of zero to max numa nodes. Add a range check to ensure we don't get excessive values. Coverity issue: 336812 Coverity issue: 336829 Fixes: 2c59bd32b70d ("cryptodev: do not create session mempool internally") CC: sta...@dpdk.org

Re: [dpdk-dev] [PATCH] examples/l3fwd: support separate buffer pool per port

> > Hi Shreyansh, > > I tried this patch on MacchiatoBin + 82599 NIC. > Compared with global-pool mode, per-port-pool mode showed slightly lower > performance in single core test. That was my thought too - for the case when queues from multiple ports are handled by the same core it probably

Re: [dpdk-dev] [RFC 0/3] Add mdev (Mediated device) support in DPDK

On Mon, Apr 08, 2019 at 09:44:07AM +0100, Alejandro Lucero wrote: > On Wed, Apr 3, 2019 at 8:19 AM Tiwei Bie wrote: > > Hi everyone, > > > > This is a draft implementation of the mdev (Mediated device [1]) > > bus support in DPDK. Mdev is a way to virtualize devices in Linux > > kernel. Based on t

Re: [dpdk-dev] [PATCH v2 2/5] examples/vhost_scsi: fix missing NULL-check for parameter

On Mon, Apr 08, 2019 at 11:31:11AM +0800, Tiwei Bie wrote: > On Fri, Apr 05, 2019 at 03:37:06PM +0100, Bruce Richardson wrote: > > Coverity points out that there is a check in the main thread loop for the > > ctrlr->bdev being NULL, but by that stage the pointer has already been > > dereferenced. T

[dpdk-dev] [PATCH] net/nfp: fix potential integer overflow

Coverity issue: 277204 Fixes: defb9a5dd156 ("nfp: introduce driver initialization") Cc: sta...@dpdk.org Signed-off-by: Alejandro Lucero --- drivers/net/nfp/nfp_net.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/nfp/nfp_net.c b/drivers/net/nfp/nfp_net.c inde

[dpdk-dev] [PATCH v3 1/5] examples/vhost_scsi: fix header check for meson build

The header check for the example app was looking for virtio_scsi.h without the "linux/" prefix, which meant it was never getting found when it should have been. Fixes: 8d47a753b7cb ("examples/vhost_scsi: disable build if missing dependency") CC: sta...@dpdk.org CC: Maxime Coquelin CC: Tiwei Bie

[dpdk-dev] [PATCH v3 0/5] some small fixes

A few coverity fixes, along with a fix for one of the examples meson.build files which I caught along the way. v3: updated patch 2, to include fixes from Tiwei. v2: include a typo fix identified by Rami Rosen. Bruce Richardson (5): examples/vhost_scsi: fix header check for meson build example

[dpdk-dev] [PATCH v3 5/5] net/i40e: fix dereference before check when getting EEPROM

As flagged by coverity, the "info" structure is being explicitly dereferenced before being checked later for a NULL value. Coverity issue: 277241 Fixes: 98e60c0d43f1 ("net/i40e: add module EEPROM callbacks for i40e") CC: sta...@dpdk.org Cc: zijie@6wind.com CC: Beilei Xing CC: Qi Zhang Signe

[dpdk-dev] [PATCH v3 3/5] net/i40e: fix dereference before NULL check in mbuf release

Coverity flags that the txq variable is used before it's checked for NULL. Also fix typo in error message. Coverity issue: 195023 Fixes: 24853544c84c ("net/i40e: fix mbuf free in vector Tx") Cc: qi.z.zh...@intel.com CC: sta...@dpdk.org Signed-off-by: Bruce Richardson Acked-by: Rami Rosen --- d

[dpdk-dev] [PATCH v3 2/5] examples/vhost_scsi: fix missing NULL-check for parameter

Coverity points out that there is a check in the main thread loop for the ctrlr->bdev being NULL, but by that stage the pointer has already been dereferenced. Therefore, for safety, before we enter the loop do an initial check on the parameter structure. Coverity issue: 158657 Fixes: db75c7af19bb

[dpdk-dev] [PATCH v3 4/5] app/testpmd: fix variable use before NULL check

The value returned from rte_eth_dev_tx_offload_name() function is used for string comparison before being checked for NULL. Move the NULL check up to be done first. Coverity issue: 279438 Fixes: c73a9071877a ("app/testpmd: add commands to test new offload API") Cc: wei@intel.com Cc: sta...@dpd

[dpdk-dev] [PATCH] net/nfp: check value returned

Call to CPP read can fail. Coverity issue: 277209 Fixes: c7e9729da6b5 ("net/nfp: support CPP") Cc: sta...@dpdk.org Signed-off-by: Alejandro Lucero --- drivers/net/nfp/nfpcore/nfp_cppcore.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/net/nfp/nfpcore/nfp_cppcore.

[dpdk-dev] [PATCH] net/nfp: check value returned

If the call to _nfp6000_cppat_mu_locality fails, the function needs to return with an error. Coverity issue: 277215 Fixes: c7e9729da6b5 ("net/nfp: support CPP") Cc: sta...@dpdk.org Signed-off-by: Alejandro Lucero --- drivers/net/nfp/nfpcore/nfp-common/nfp_cppat.h | 3 +++ 1 file changed, 3 inse

[dpdk-dev] [PATCH] app/testpmd: fix ether header size calculation

From: Pavan Nikhilesh Fix ether header size calculation in Tx only mode. Coverity issue: 337684 Fixes: 01b645dcff7f ("app/testpmd: move txonly prepare in separate function") Signed-off-by: Pavan Nikhilesh --- app/test-pmd/txonly.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --

Re: [dpdk-dev] [dpdk-techboard] DPDK ABI/API Stability

On 08-Apr-19 10:04 AM, Ray Kinsella wrote: On 07/04/2019 10:48, Thomas Monjalon wrote: 04/04/2019 16:07, Burakov, Anatoly: On 04-Apr-19 1:52 PM, Ray Kinsella wrote: On 04/04/2019 11:54, Bruce Richardson wrote: On Thu, Apr 04, 2019 at 10:29:19AM +0100, Burakov, Anatoly wrote: On 03-Apr-19 4:4

[dpdk-dev] [PATCH] net/nfp: fix memory leak

If errors, release the allocated structure. Coverity issue: 277222 Fixes: c7e9729da6b5 ("net/nfp: support CPP") Cc: sta...@dpdk.org Signed-off-by: Alejandro Lucero --- drivers/net/nfp/nfpcore/nfp_cpp_pcie_ops.c | 18 +++--- 1 file changed, 11 insertions(+), 7 deletions(-) diff --gi

[dpdk-dev] [PATCH] net/ena: fix assigning Rx csum support to Tx flag

The boolean value was assigned to Tx flag twice, so it could cause bug whenever Rx checksum will not be supported and Tx will be. It was detected by the coverity scan, with CID 336831. Fixes: 117ba4a60488 ("net/ena: get device info statically") Cc: sta...@dpdk.org Signed-off-by: Michal Krawczyk

Re: [dpdk-dev] [PATCH v7 3/4] config: add thunderx2 machine config

06/04/2019 16:27, jerinjac...@gmail.com: > --- /dev/null > +++ b/config/arm/arm64_thunderx2_linux_gcc > @@ -0,0 +1,16 @@ > +[binaries] > +c = 'aarch64-linux-gnu-gcc' > +cpp = 'aarch64-linux-gnu-cpp' > +ar = 'aarch64-linux-gnu-gcc-ar' > +strip = 'aarch64-linux-gnu-strip' > +pcap-config = '' Strange

[dpdk-dev] [PATCH] net/nfp: check returned value

If the call fails just returns 0. Coverity issue: 277225 Fixes: c7e9729da6b5 ("net/nfp: support CPP") Cc: sta...@dpdk.org Signed-off-by: Alejandro Lucero --- drivers/net/nfp/nfpcore/nfp_cppcore.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/net/nfp/nfpcore/n

Re: [dpdk-dev] [PATCH] examples/ipsec-secgw: fix coherency of ESP sequence number

Hi Yongseok, > Outbound ESP sequence number should be incremented atomically and refeenced > indirectly. Otherwise, concurrent access by multiple threads will break > coherency. I think MT mode per SA is not supported right now by ipsec-secgw. >From https://doc.dpdk.org/guides/sample_app_ug/ips

[dpdk-dev] [PATCH 1/2] power: add fifo per core for JSON interface

This patch implement a separate FIFO for each cpu core. For proper handling JSON interface, removed fields from cmds: core_list, resource_id, name. Signed-off-by: Lukasz Krakowiak --- examples/vm_power_manager/channel_manager.c | 85 +-- examples/vm_power_manager/channel_manager.

[dpdk-dev] [PATCH 2/2] doc: update according to the fifo per core impl

Updated power management docs for fifo JSON API. Removed from JSON API: * 'name' * 'resource_id' * 'core_list' Signed-off-by: Lukasz Krakowiak --- .../sample_app_ug/vm_power_management.rst | 53 --- 1 file changed, 11 insertions(+), 42 deletions(-) diff --git a/doc/guides/sa

[dpdk-dev] [PATCH 0/2] power: add fifo per core for JSON interface

This patch implement a separate FIFO for each cpu core. Dependency to commit: 5c7c96571b7b7051ecc286f36be0b3d95b49995e (power: update for handling fifo path string). Lukasz Krakowiak (2): power: add fifo per core for JSON interface doc: update according to the fifo per core impl .../sample_

[dpdk-dev] [PATCH] crypto/qat: fix segmentation fault in QAT PMD

While running the IPsec unit test program the following segmentation fault is occurring: Thread 1 "test" received signal SIGSEGV, Segmentation fault. 0x00beaece in qat_sym_build_request(in_op=0x0, out_msg=0x100450580 "", op_cookie=0x101c6fd80, qat_dev_gen=QAT_GEN1) at /root/dpdk_ipsec_mast

[dpdk-dev] [PATCH] net/nfp: fix resource leak

Coverity issue: 32806 Fixes: ef28aa96e53b ("net/nfp: support multiprocess") Cc: sta...@dpdk.org Signed-off-by: Alejandro Lucero --- drivers/net/nfp/nfpcore/nfp_cpp_pcie_ops.c | 5 + 1 file changed, 5 insertions(+) diff --git a/drivers/net/nfp/nfpcore/nfp_cpp_pcie_ops.c b/drivers/net/nfp/nf

[dpdk-dev] [PATCH] net/nfp: close sockfd before return if errors

Not closing the socket implies a resource leak. Coverity issue: 336865 Fixes: 29a62d1476b6 ("net/nfp: add CPP bridge as service") Cc: sta...@dpdk.org Signed-off-by: Alejandro Lucero --- drivers/net/nfp/nfp_net.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/net/nfp/nfp_net.c b/

[dpdk-dev] [PATCH 00/13] ENETC PMD basic features and bug fixes

* support added for MTU, jumbo frame, queue start/stop, promiscuous, multicast, crc offload, RX checksum validation and basic stats * some bug fixes Gagandeep Singh (13): net/enetc: support physical addressing mode net/enetc: fix SMMU unhandled context fault net/enetc: use correct buffer a

[dpdk-dev] [PATCH 02/13] net/enetc: fix SMMU unhandled context fault

First configure ring with BDs properly then enable the ring. Fixes: 469c6111a799 ("net/enetc: enable Rx and Tx") Cc: g.si...@nxp.com Signed-off-by: Gagandeep Singh --- drivers/net/enetc/enetc_ethdev.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/net/enetc/en

[dpdk-dev] [PATCH 04/13] net/enetc: set interface mode for SXGMII

Support for SXGMII port has been enabled. It will depends on boot loader information passed through IERB. Signed-off-by: Gagandeep Singh --- drivers/net/enetc/base/enetc_hw.h | 13 - drivers/net/enetc/enetc_ethdev.c | 11 +++ 2 files changed, 23 insertions(+), 1 deletion(-)

[dpdk-dev] [PATCH 01/13] net/enetc: support physical addressing mode

Support added for physical addressing mode and change driver flags to don't care. Signed-off-by: Gagandeep Singh --- drivers/net/enetc/enetc_ethdev.c | 22 -- drivers/net/enetc/enetc_rxtx.c | 6 +++--- 2 files changed, 15 insertions(+), 13 deletions(-) diff --git a/driver

[dpdk-dev] [PATCH 03/13] net/enetc: use correct buffer allocation API

rte_pktmbuf_alloc API should be used to allocate mbuf instead of rte_pktmbuf_raw_alloc to avoid use of stale mbuf information. Fixes: 469c6111a799 ("net/enetc: enable Rx and Tx") Cc: g.si...@nxp.com Signed-off-by: Gagandeep Singh --- drivers/net/enetc/enetc_rxtx.c | 2 +- 1 file changed, 1 inse

[dpdk-dev] [PATCH 06/13] net/enetc: replace register read/write macros with functions

Replacing read-write macros with already available read-write functions. Signed-off-by: Gagandeep Singh --- drivers/net/enetc/enetc.h| 7 + drivers/net/enetc/enetc_ethdev.c | 61 2 files changed, 31 insertions(+), 37 deletions(-) diff --git

[dpdk-dev] [PATCH 08/13] net/enetc: enable promiscuous and allmulticast feature

Promiscuous and allmulticast enable/disable APIs added. Signed-off-by: Gagandeep Singh --- doc/guides/nics/enetc.rst | 2 + doc/guides/nics/features/enetc.ini | 2 + drivers/net/enetc/base/enetc_hw.h | 3 +- drivers/net/enetc/enetc_ethdev.c | 90 ---

[dpdk-dev] [PATCH 05/13] net/enetc: add statistics APIs

Add basic statistics APIs enetc_stats_get and enetc_stats_reset. Signed-off-by: Gagandeep Singh --- doc/guides/nics/enetc.rst | 1 + doc/guides/nics/features/enetc.ini | 1 + drivers/net/enetc/base/enetc_hw.h | 27 +- drivers/net/enetc/enetc_ethdev.c | 46 ++

[dpdk-dev] [PATCH 09/13] net/enetc: add MTU update and jumbo frames support

Enable the jumbo frames and mtu update feature. Signed-off-by: Gagandeep Singh --- doc/guides/nics/enetc.rst | 1 + doc/guides/nics/features/enetc.ini | 2 + drivers/net/enetc/base/enetc_hw.h | 6 ++- drivers/net/enetc/enetc.h | 5 +++ drivers/net/enetc/enetc_ethdev.c |

[dpdk-dev] [PATCH 07/13] net/enetc: remove forward declarations

Remove unneeded forward declarations and re-order the code. Signed-off-by: Gagandeep Singh --- drivers/net/enetc/enetc_ethdev.c | 237 ++- 1 file changed, 107 insertions(+), 130 deletions(-) diff --git a/drivers/net/enetc/enetc_ethdev.c b/drivers/net/enetc/en

[dpdk-dev] [PATCH 10/13] net/enetc: enable Rx-Tx queue start/stop feature

Rx and Tx queue start-stop and deferred queue start features enabled. Signed-off-by: Gagandeep Singh --- doc/guides/nics/enetc.rst | 2 + doc/guides/nics/features/enetc.ini | 1 + drivers/net/enetc/enetc_ethdev.c | 185 ++--- 3 files changed, 134 in

[dpdk-dev] [PATCH 11/13] net/enetc: enable CRC offload feature

CRC offload keep feature supported Signed-off-by: Gagandeep Singh --- doc/guides/nics/enetc.rst | 1 + doc/guides/nics/features/enetc.ini | 1 + drivers/net/enetc/base/enetc_hw.h | 1 + drivers/net/enetc/enetc.h | 1 + drivers/net/enetc/enetc_ethdev.c | 20 ++

[dpdk-dev] [PATCH 12/13] net/enetc: enable Rx checksum offload validation

Checksum Validation on Rx is supported. Signed-off-by: Gagandeep Singh --- doc/guides/nics/features/enetc.ini | 2 + drivers/net/enetc/base/enetc_hw.h | 5 ++ drivers/net/enetc/enetc_ethdev.c | 15 +- drivers/net/enetc/enetc_rxtx.c | 107 - 4 f

[dpdk-dev] [PATCH 13/13] net/enetc: fix crash at high speed traffic

On xmit side, there should be a check whether BD ring has free BDs available before transmit a packet to avoid data corruption and buffer leak issue. Fixes: 469c6111a799 ("net/enetc: enable Rx and Tx") Cc: g.si...@nxp.com Signed-off-by: Gagandeep Singh --- drivers/net/enetc/enetc_rxtx.c | 7 +++

Re: [dpdk-dev] [PATCH 05/13] net/enetc: add statistics APIs

On Mon, Apr 8, 2019 at 1:23 PM Gagandeep Singh wrote: > +static > +int enetc_stats_get(struct rte_eth_dev *dev, > + struct rte_eth_stats *stats) > +{ > + struct enetc_eth_hw *hw = > + ENETC_DEV_PRIVATE_TO_HW(dev->data->dev_private); > + struct enetc_hw

[dpdk-dev] [Bug 242] repeat to calling 'rte_pktmbuf_free' function, make the mempool exist the same 'rte_mbuf' obj;

https://bugs.dpdk.org/show_bug.cgi?id=242 Bug ID: 242 Summary: repeat to calling 'rte_pktmbuf_free' function, make the mempool exist the same 'rte_mbuf' obj; Product: DPDK Version: 18.11 Hardware: All OS: Al

Re: [dpdk-dev] [PATCH] app/testpmd: fix ether header size calculation

On Mon, Apr 08, 2019 at 10:13:04AM +, Pavan Nikhilesh Bhagavatula wrote: > From: Pavan Nikhilesh > > Fix ether header size calculation in Tx only mode. > > Coverity issue: 337684 > Fixes: 01b645dcff7f ("app/testpmd: move txonly prepare in separate function") > > Signed-off-by: Pavan Nikhile

Re: [dpdk-dev] [PATCH v7 3/4] config: add thunderx2 machine config

08/04/2019 12:32, Thomas Monjalon: > 06/04/2019 16:27, jerinjac...@gmail.com: > > --- /dev/null > > +++ b/config/arm/arm64_thunderx2_linux_gcc > > @@ -0,0 +1,16 @@ > > +[binaries] > > +c = 'aarch64-linux-gnu-gcc' > > +cpp = 'aarch64-linux-gnu-cpp' > > +ar = 'aarch64-linux-gnu-gcc-ar' > > +strip = '

Re: [dpdk-dev] [PATCH] crypto/qat: fix segmentation fault in QAT PMD

Hi Bernard, > > While running the IPsec unit test program the following > segmentation fault is occurring: > > Thread 1 "test" received signal SIGSEGV, Segmentation fault. > 0x00beaece in qat_sym_build_request(in_op=0x0, > out_msg=0x100450580 "", op_cookie=0x101c6fd80, qat_dev_gen=QAT_GE

Re: [dpdk-dev] [PATCH v7 3/4] config: add thunderx2 machine config

On Mon, Apr 08, 2019 at 02:05:00PM +0200, Thomas Monjalon wrote: > 08/04/2019 12:32, Thomas Monjalon: > > 06/04/2019 16:27, jerinjac...@gmail.com: > > > --- /dev/null > > > +++ b/config/arm/arm64_thunderx2_linux_gcc > > > @@ -0,0 +1,16 @@ > > > +[binaries] > > > +c = 'aarch64-linux-gnu-gcc' > > > +

[dpdk-dev] [PATCH] crypto/qat: fix second seg fault in QAT PMD

While running the IPsec unit tests the following segmentation fault is occurring: Thread 1 "test" received signal SIGSEGV, Segmentation fault. 0x00bf3b50 in qat_sym_process_response ( op=0x5355280 , resp=0x100455100 "") at /root/dpdk/drivers/crypto/qat/qat_sym.h:161 161 if (sess->bpi_c

Re: [dpdk-dev] [EXT] Re: [PATCH] app/testpmd: fix ether header size calculation

>-Original Message- >From: Bruce Richardson >Sent: Monday, April 8, 2019 5:28 PM >To: Pavan Nikhilesh Bhagavatula >Cc: Jerin Jacob Kollanukkaran ; tho...@monjalon.net; >dev@dpdk.org >Subject: [EXT] Re: [dpdk-dev] [PATCH] app/testpmd: fix ether header size >calculation > >External Email

[dpdk-dev] [RFC 3/3] Introduce random generator functions with upper bound

Add two functions rte_rand32_max() and rte_rand_max(), which generate uniformly distributed pseudo-random number less than a user-specified upper bound. The commonly used pattern rte_rand() % SOME_VALUE, in addition to being slow, also creates biased results if SOME_VALUE is not a power of 2. This

Re: [dpdk-dev] [PATCH] crypto/qat: fix segmentation fault in QAT PMD

Hi Konstantin, > Subject: RE: [PATCH] crypto/qat: fix segmentation fault in QAT PMD > > Hi Bernard, > > > > > While running the IPsec unit test program the following segmentation > > fault is occurring: > > > > Thread 1 "test" received signal SIGSEGV, Segmentation fault. > > 0x00beaece

[dpdk-dev] [RFC 1/3] Replace lrand48-based rte_rand with LFSR generator

This commit replaces rte_rand()'s use of lrand48() with a DPDK-native combined Linear Feedback Shift Register (LFSR) (also known as Tausworthe) pseudo-number generator, with four sequences. This generator is faster and produces better quality random numbers than libc's lrand48() implementation. Th

[dpdk-dev] [RFC 2/3] Add 32-bit version of rte_rand

Signed-off-by: Mattias Rönnblom --- lib/librte_eal/common/include/rte_random.h | 15 +++ lib/librte_eal/common/rte_random.c | 10 ++ lib/librte_eal/rte_eal_version.map | 1 + 3 files changed, 22 insertions(+), 4 deletions(-) diff --git a/lib/librte_eal/common

[dpdk-dev] [PATCH] net/mlx5: fix cross compilation on aarch64

In case of cross compilation on aarch64 we must add include for stdlib in order to use the free function. Fixes: cbb66daa3c85 ("net/mlx5: prepare Direct Verbs for Direct Rule") Signed-off-by: Ori Kam --- drivers/net/mlx5/mlx5_glue.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/n

Re: [dpdk-dev] [RFC 1/3] Replace lrand48-based rte_rand with LFSR generator

On 2019-04-08 14:30, Mattias Rönnblom wrote: +static void +__rte_srand_lfsr113(uint32_t seed, struct rte_rand_state *state) +{ + uint32_t lcg32_seed = seed; + state->z1 = __rte_rand_lfsr113_gen_seed(&lcg32_seed, 2U); + state->z2 = __rte_rand_lfsr113_gen_seed(&lcg32_seed, 8U); +

Re: [dpdk-dev] [PATCH v4 1/3] app/testpmd: add ability to set Tx IP and UDP parameters

Hi Stephen, > -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Stephen Hemminger > Sent: Tuesday, April 2, 2019 9:39 PM > To: dev@dpdk.org > Cc: Stephen Hemminger > Subject: [dpdk-dev] [PATCH v4 1/3] app/testpmd: add ability to set Tx IP and > UDP parameters > >

Re: [dpdk-dev] [dpdk-techboard] DPDK ABI/API Stability

On 08/04/2019 11:15, Burakov, Anatoly wrote: > On 08-Apr-19 10:04 AM, Ray Kinsella wrote: >> On 07/04/2019 10:48, Thomas Monjalon wrote: >>> 04/04/2019 16:07, Burakov, Anatoly: On 04-Apr-19 1:52 PM, Ray Kinsella wrote: > On 04/04/2019 11:54, Bruce Richardson wrote: >> On Thu, Apr 04

Re: [dpdk-dev] [PATCH v4 2/3] examples/l3fwd: use reserved IPv4/IPv6 addresses

Hi Stephen, > -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Stephen Hemminger > Sent: Tuesday, April 2, 2019 9:39 PM > To: dev@dpdk.org > Cc: Stephen Hemminger > Subject: [dpdk-dev] [PATCH v4 2/3] examples/l3fwd: use reserved IPv4/IPv6 > addresses > > The l3fw

Re: [dpdk-dev] [PATCH v4 3/3] examples/l3fwd: format the IP addresses for printing

Hi Stephen, > -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Stephen Hemminger > Sent: Tuesday, April 2, 2019 9:39 PM > To: dev@dpdk.org > Cc: Stephen Hemminger > Subject: [dpdk-dev] [PATCH v4 3/3] examples/l3fwd: format the IP addresses for > printing > > The

Re: [dpdk-dev] [PATCH 01/13] net/enetc: support physical addressing mode

On 4/8/2019 12:22 PM, Gagandeep Singh wrote: > Support added for physical addressing mode and > change driver flags to don't care. > > Signed-off-by: Gagandeep Singh Hi Gagandeep, Since the patchset has been sent after RC1, I assume it is for 19.08. Can you please mark patch title as 19.08 to n

Re: [dpdk-dev] [PATCH v7] sched: make RED scaling configurable

> -Original Message- > From: Thomas Monjalon [mailto:tho...@monjalon.net] > Sent: Monday, April 8, 2019 9:53 AM > To: Alan Dewar > Cc: Yigit, Ferruh ; Dumitrescu, Cristian > ; Kantecki, Tomasz > ; Stephen Hemminger > ; dev@dpdk.org; Alan Dewar > > Subject: Re: [dpdk-dev] [PATCH v7] sch

Re: [dpdk-dev] [PATCH] Improve the shaper accuracy for large packets

> -Original Message- > From: Yigit, Ferruh > Sent: Friday, April 5, 2019 4:54 PM > To: Dumitrescu, Cristian > Cc: alanrobertson...@gmail.com; dev@dpdk.org; Alan Robertson > ; Alan Robertson ; Thomas > Monjalon > Subject: Re: [dpdk-dev] [PATCH] Improve the shaper accuracy for large > pac

Re: [dpdk-dev] [PATCH v2 1/3] ethdev: add actions to modify TCP header fields

Thanks, PSB. > -Original Message- > From: Adrien Mazarguil > Sent: Thursday, April 4, 2019 4:26 PM > To: Ori Kam > Cc: Dekel Peled ; wenzhuo...@intel.com; > jingjing...@intel.com; bernard.iremon...@intel.com; Yongseok Koh > ; Shahaf Shuler ; > dev@dpdk.org > Subject: Re: [PATCH v2 1/3] e

Re: [dpdk-dev] [PATCH] lib/librte_table: fix arm64 hash function selection

> -Original Message- > From: Jerin Jacob Kollanukkaran [mailto:jer...@marvell.com] > Sent: Saturday, April 6, 2019 2:30 PM > To: Dumitrescu, Cristian > Cc: dev@dpdk.org; tho...@monjalon.net; Jerin Jacob Kollanukkaran > ; Gavin Hu ; sta...@dpdk.org > Subject: [dpdk-dev] [PATCH] lib/librte

Re: [dpdk-dev] [dpdk-techboard] DPDK ABI/API Stability

On 08-Apr-19 2:00 PM, Ray Kinsella wrote: On 08/04/2019 11:15, Burakov, Anatoly wrote: On 08-Apr-19 10:04 AM, Ray Kinsella wrote: On 07/04/2019 10:48, Thomas Monjalon wrote: 04/04/2019 16:07, Burakov, Anatoly: On 04-Apr-19 1:52 PM, Ray Kinsella wrote: On 04/04/2019 11:54, Bruce Richardson

[dpdk-dev] [PATCH v2] usertools: replace unsafe input function

LGTM static code analysis tool reports that the function 'input' is unsafe. Changed to use raw_input which then converts it using ast.literal_eval() which is safe. Fixes: d1b94da4a4e0 ("usertools: add client script for telemetry") Cc: ciara.po...@intel.com Signed-off-by: Andrius Sirvys Acked-by:

Re: [dpdk-dev] [PATCH v2 1/3] app/testpmd: fix mempool free on exit

> -Original Message- > From: Shahaf Shuler [mailto:shah...@mellanox.com] > Sent: Thursday, April 4, 2019 6:15 AM > To: Lu, Wenzhuo ; Wu, Jingjing > ; Iremonger, Bernard > Cc: dev@dpdk.org; rasl...@mellanox.com; tho...@monjalon.net; Yigit, > Ferruh ; sta...@dpdk.org > Subject: [PATCH v2 1/3

Re: [dpdk-dev] Secondary process crash in rte_eal_init

On 08-Apr-19 2:07 PM, Mohamed Mahmoud (mmahmoud) wrote: Hi Anatoly: For the secondary process all we are setting is the –proc-type set to secondary, maybe point me to your test that might give me some clues, also How I can generate detailed crash log ? When I checked the init code there are

Re: [dpdk-dev] [dpdk-stable] [PATCH] net/ena: fix assigning Rx csum support to Tx flag

On 4/8/2019 11:27 AM, Michal Krawczyk wrote: > The boolean value was assigned to Tx flag twice, so it could cause bug > whenever Rx checksum will not be supported and Tx will be. > > It was detected by the coverity scan, with CID 336831. > > Fixes: 117ba4a60488 ("net/ena: get device info statical

[dpdk-dev] Function name collision on bpf_validate

Hi, Has anyone run into this issue with bpf_validate? We have an application that links to both DPDK and libpcap and both define bpf_validate. I couldn't find other complaints on this so I'm wondering what would be the best way to handle this? Thanks and I appreciate for your input. Regards

Re: [dpdk-dev] [PATCH v2 1/3] ethdev: add actions to modify TCP header fields

On 4/8/19 4:36 PM, Dekel Peled wrote: Regarding Andrew's suggestion: "Shouldn't these action be RTE_FLOW_ACTION_TYPE_MOD_TCP_{ACK,SEQ} with singed 32-bit integer parameter (negative to decrement, positive to increment)?" I will leave the actions as is, the action names indicate the operation th

[dpdk-dev] [PATCH v3] usertools: replace unsafe input function

LGTM static code analysis tool reports that the function 'input' is unsafe. Changed to use raw_input which then converts it using ast.literal_eval() which is safe. Fixes: d1b94da4a4e0 ("usertools: add client script for telemetry") Cc: ciara.po...@intel.com Signed-off-by: Andrius Sirvys Acked-by:

Re: [dpdk-dev] [dpdk-techboard] DPDK ABI/API Stability

On Mon, Apr 8, 2019 at 3:39 PM Burakov, Anatoly wrote: > As a concrete proposal, my number one dream would be to see multiprocess > gone. I also recall desire for "DPDK to be more lightweight", and i > maintain that DPDK *cannot* be lightweight if we are to support > multiprocess - we can have on

Re: [dpdk-dev] [dpdk-techboard] DPDK ABI/API Stability

On 08-Apr-19 2:58 PM, David Marchand wrote: On Mon, Apr 8, 2019 at 3:39 PM Burakov, Anatoly mailto:anatoly.bura...@intel.com>> wrote: As a concrete proposal, my number one dream would be to see multiprocess gone. I also recall desire for "DPDK to be more lightweight", and i main

[dpdk-dev] [PATCH] net/sfc: set min and max MTU

Advertise minimum and maximum MTU value in device information. Signed-off-by: Andrew Rybchenko --- drivers/net/sfc/sfc_ethdev.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/net/sfc/sfc_ethdev.c b/drivers/net/sfc/sfc_ethdev.c index 6c33601e7..ff192314d 100644 --- a/drivers/net/

Re: [dpdk-dev] [PATCH 0/3] use a common eal device event for hot-unplug

Hi Jia > -Original Message- > From: Guo, Jia > Sent: Friday, December 14, 2018 7:46 AM > To: Iremonger, Bernard ; Lu, Wenzhuo > ; shah...@mellanox.com; tho...@monjalon.net; > ma...@mellanox.com > Cc: Yigit, Ferruh ; Ananyev, Konstantin > ; dev@dpdk.org; Guo, Jia > ; step...@networkplumber.

Re: [dpdk-dev] [PATCH v4 1/3] app/testpmd: fix mempool free on exit

> -Original Message- > From: Shahaf Shuler [mailto:shah...@mellanox.com] > Sent: Sunday, April 7, 2019 6:02 AM > To: Lu, Wenzhuo ; Wu, Jingjing > ; Iremonger, Bernard > Cc: dev@dpdk.org; rasl...@mellanox.com; tho...@monjalon.net; Yigit, > Ferruh ; sta...@dpdk.org > Subject: [PATCH v4 1/3]

Re: [dpdk-dev] [PATCH v2 1/3] ethdev: add actions to modify TCP header fields

Hi Andrew, *Dekel* (I swear I'm not doing it on purpose, hopefully I won't make that stupid mistake again :) On Mon, Apr 08, 2019 at 04:53:54PM +0300, Andrew Rybchenko wrote: > On 4/8/19 4:36 PM, Dekel Peled wrote: > > Regarding Andrew's suggestion: "Shouldn't these action be > > RTE_FLOW_ACTION_

[dpdk-dev] [PATCH] kni: fix build for ndo_fdb_add in Linux 5.1

Build error seen with Linux kernel 5.1 and when CONFIG_RTE_KNI_KMOD_ETHTOOL is enabled. Build error: .../dpdk/build/build/kernel/linux/kni/igb_main.c:2352:18: error: initialization of ... from incompatible pointer type ... [-Werror=incompatible-pointer-types] .ndo_fdb_add = igb_ndo_fdb_ad

Re: [dpdk-dev] [dpdk-stable] [PATCH] net/nfp: fix file descriptor handle

On 4/8/2019 10:20 AM, Alejandro Lucero wrote: > Although it is rather unlikely getting 0 as the descriptor handle, better > to contemplate that possibility. > > Coverity issue: 195018 > Fixes: 896c265ef954 ("net/nfp: use new CPP interface") > Cc: sta...@dpdk.org > > Signed-off-by: Alejandro Lucer

Re: [dpdk-dev] [dpdk-techboard] DPDK ABI/API Stability

On Mon, Apr 8, 2019 at 4:03 PM Burakov, Anatoly wrote: > On 08-Apr-19 2:58 PM, David Marchand wrote: > > On Mon, Apr 8, 2019 at 3:39 PM Burakov, Anatoly > > mailto:anatoly.bura...@intel.com>> wrote: > > > > As a concrete proposal, my number one dream would be to see > > multiprocess > >

Re: [dpdk-dev] [dpdk-stable] [PATCH] net/nfp: fix potential integer overflow

On 4/8/2019 10:39 AM, Alejandro Lucero wrote: > Coverity issue: 277204 > Fixes: defb9a5dd156 ("nfp: introduce driver initialization") > Cc: sta...@dpdk.org > > Signed-off-by: Alejandro Lucero Applied to dpdk-next-net/master, thanks.

Re: [dpdk-dev] Function name collision on bpf_validate

Hi Vivian, > > > > Hi, > > Has anyone run into this issue with bpf_validate? We have an application > that links to both DPDK and libpcap and both define bpf_validate. Didn't hit such issue so far. Could you provide some basic way to reproduce it? Thanks Konstantin > I > couldn't find o

Re: [dpdk-dev] [dpdk-techboard] DPDK ABI/API Stability

On Mon, 8 Apr 2019 16:38:55 +0200 David Marchand wrote: > On Mon, Apr 8, 2019 at 4:03 PM Burakov, Anatoly > wrote: > > > On 08-Apr-19 2:58 PM, David Marchand wrote: > > > On Mon, Apr 8, 2019 at 3:39 PM Burakov, Anatoly > > > mailto:anatoly.bura...@intel.com>> wrote: > > > > > > As a concr

[dpdk-dev] [PATCH] power: fix coverity issue

Coverity issue: 337668 Fixes: b60fd5f8b1ce8f0a2c ("power: add bit for high frequency cores") Signed-off-by: Liang Ma --- lib/librte_power/power_pstate_cpufreq.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/lib/librte_power/power_pstate_cpufreq.c b/lib/librte_power/power_pstate_cpufre

Re: [dpdk-dev] [PATCH] power: fix coverity issue

Hi Liang, On 8/4/2019 4:21 PM, Liang Ma wrote: Coverity issue: 337668 Fixes: b60fd5f8b1ce8f0a2c ("power: add bit for high frequency cores") Signed-off-by: Liang Ma --- lib/librte_power/power_pstate_cpufreq.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/lib/librte_power/power_psta

Re: [dpdk-dev] [dpdk-techboard] DPDK ABI/API Stability

On 08-Apr-19 3:38 PM, David Marchand wrote: On Mon, Apr 8, 2019 at 4:03 PM Burakov, Anatoly mailto:anatoly.bura...@intel.com>> wrote: On 08-Apr-19 2:58 PM, David Marchand wrote: > On Mon, Apr 8, 2019 at 3:39 PM Burakov, Anatoly > mailto:anatoly.bura...@intel.com>

  1   2   >