[dpdk-dev] [RFC] ethdev: add GRE optional fields to flow API

2019-05-14 Thread Xiaoyu Min
Add GRE's checksum, key, and sequence field to the struct rte_flow_item_gre in order to match. Signed-off-by: Xiaoyu Min --- lib/librte_ethdev/rte_flow.h | 4 1 file changed, 4 insertions(+) diff --git a/lib/librte_ethdev/rte_flow.h b/lib/librte_ethdev/rte_flow.h index 63f84fca65..fb04af32

Re: [dpdk-dev] [RFC] ethdev: add GRE optional fields to flow API

2019-05-14 Thread Andrew Rybchenko
On 5/14/19 10:18 AM, Xiaoyu Min wrote: Add GRE's checksum, key, and sequence field to the struct rte_flow_item_gre in order to match. Signed-off-by: Xiaoyu Min --- lib/librte_ethdev/rte_flow.h | 4 1 file changed, 4 insertions(+) diff --git a/lib/librte_ethdev/rte_flow.h b/lib/librte_e

Re: [dpdk-dev] [PATCH v3] doc: fix update release notes for Mellanox drivers

2019-05-14 Thread Ori Kam
Hi Tom, Thanks for your mail. PSB Best, Ori Kam From: Tom Barbette Sent: Tuesday, May 14, 2019 8:47 AM To: Ori Kam Cc: Yongseok Koh ; Shahaf Shuler ; Matan Azrad ; Thomas Monjalon ; dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH v3] doc: fix update release notes for Mellanox drivers Hi all,

Re: [dpdk-dev] [PATCH 2/2] doc: update Mellanox supported OFED version

2019-05-14 Thread Tom Barbette
Sorry to revamp the old thread, but I found the conditions to create the bug. It does affect 19.05 with OFED 4.5, but is fixed in 4.6. It happens when I build with CONFIG_RTE_IBVERBS_LINK_STATIC=y. I forgot I enabled that one specifically... System: Ubuntu 18.04.2 LTS / 4.15.1-ubuntu gcc: Ub

Re: [dpdk-dev] Using _XOPEN_SOURCE macros may break builds on FreeBSD

2019-05-14 Thread Smoczynski, MarcinX
> > Hey Konstantin, > > > > On Mon, May 13, 2019 at 10:49:00AM +, Ananyev, Konstantin wrote: > > > Hi Adrien, > > > > > > > > > > > On Mon, May 13, 2019 at 09:51:24AM +, Smoczynski, MarcinX > wrote: > > > > > 10/05/2019 20:17, Thomas Monjalon: > > > > > > 10/05/2019 19:14, Smoczynski, Marci

Re: [dpdk-dev] [RFC] ethdev: add GRE optional fields to flow API

2019-05-14 Thread Adrien Mazarguil
On Tue, May 14, 2019 at 10:34:22AM +0300, Andrew Rybchenko wrote: > On 5/14/19 10:18 AM, Xiaoyu Min wrote: > > Add GRE's checksum, key, and sequence field to the > > struct rte_flow_item_gre in order to match. > > > > Signed-off-by: Xiaoyu Min > > --- > > lib/librte_ethdev/rte_flow.h | 4 >

Re: [dpdk-dev] Using _XOPEN_SOURCE macros may break builds on FreeBSD

2019-05-14 Thread Adrien Mazarguil
On Tue, May 14, 2019 at 08:58:42AM +, Smoczynski, MarcinX wrote: > > > Hey Konstantin, > > > > > > On Mon, May 13, 2019 at 10:49:00AM +, Ananyev, Konstantin wrote: > > > > Hi Adrien, > > > > > > > > > > > > > > On Mon, May 13, 2019 at 09:51:24AM +, Smoczynski, MarcinX > > wrote: > > > >

[dpdk-dev] [PATCH 1/6] eal: replace libc-based random number generation with LFSR

2019-05-14 Thread Mattias Rönnblom
This commit replaces rte_rand()'s use of lrand48() with a DPDK-native combined Linear Feedback Shift Register (LFSR) (also known as Tausworthe) pseudo-random number generator. This generator is faster and produces better-quality random numbers than the linear congruential generator (LCG) of lib's

[dpdk-dev] [PATCH 0/6] Pseudo-random number generation improvements

2019-05-14 Thread Mattias Rönnblom
Make DPDK pseudo-random number generation multi-thread safe, go faster and produce better-quality pseudo-random numbers. Thanks to Stephen Hemminger, Keith Wiles and Neil Horman for valuable feedback. PATCH v1: * Added performance tests * Added __experimental to rte_rand_max() declaration * Intro

[dpdk-dev] [PATCH 2/6] eal: add pseudo-random number generation performance test

2019-05-14 Thread Mattias Rönnblom
Add performance test for rte_rand(). Signed-off-by: Mattias Rönnblom --- app/test/Makefile | 1 + app/test/test_rand_perf.c | 75 +++ 2 files changed, 76 insertions(+) create mode 100644 app/test/test_rand_perf.c diff --git a/app/test/Makefile b/app

[dpdk-dev] [PATCH 4/6] eal: introduce random generator function with upper bound

2019-05-14 Thread Mattias Rönnblom
Add a function rte_rand_max() which generates an uniformly distributed pseudo-random number less than a user-specified upper bound. The commonly used pattern rte_rand() % SOME_VALUE creates biased results (as in some values in the range are more frequently occurring than others) if SOME_VALUE is n

[dpdk-dev] [PATCH 5/6] eal: add bounded PRNG performance tests

2019-05-14 Thread Mattias Rönnblom
Add best- and worst-case performance tests for rte_rand_max(). Signed-off-by: Mattias Rönnblom --- app/test/test_rand_perf.c | 19 ++- 1 file changed, 18 insertions(+), 1 deletion(-) diff --git a/app/test/test_rand_perf.c b/app/test/test_rand_perf.c index 771713757..fe797ebfa 10

[dpdk-dev] [PATCH 6/6] eal: add pseudo-random number generation to MAINTAINERS

2019-05-14 Thread Mattias Rönnblom
Add a section on PRNG in MAINTAINERS. Signed-off-by: Mattias Rönnblom --- MAINTAINERS | 6 ++ 1 file changed, 6 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 15d0829c5..d06f5da90 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -222,6 +222,12 @@ M: Joyce Kong F: lib/librte_eal/c

[dpdk-dev] [PATCH 3/6] eal: improve entropy for initial PRNG seed

2019-05-14 Thread Mattias Rönnblom
Replace the use of rte_get_timer_cycles() with getentropy() for seeding the pseudo-random number generator. getentropy() provides a more truly random value. Suggested-by: Stephen Hemminger Signed-off-by: Mattias Rönnblom --- lib/librte_eal/common/rte_random.c | 12 +++- 1 file changed,

Re: [dpdk-dev] [PATCH 1/6] eal: replace libc-based random number generation with LFSR

2019-05-14 Thread Mattias Rönnblom
On 2019-05-14 11:20, Mattias Rönnblom wrote: Bugzilla ID: 114 Bugzilla ID: 276 I don't know which, if any, of these bugs you want to address in any stable releases. If fixing bug 276 "rte_rand() bit 31 and 63 are always zero" is enough, then one could either split this patch set in two (w

Re: [dpdk-dev] [PATCH 3/6] eal: improve entropy for initial PRNG seed

2019-05-14 Thread Mattias Rönnblom
On 2019-05-14 11:20, Mattias Rönnblom wrote: Replace the use of rte_get_timer_cycles() with getentropy() for seeding the pseudo-random number generator. getentropy() provides a more truly random value. getentropy() doens't exist in libc versions earler than 2.25, and it also (like Stephen men

Re: [dpdk-dev] [PATCH 3/6] eal: improve entropy for initial PRNG seed

2019-05-14 Thread Bruce Richardson
On Tue, May 14, 2019 at 11:20:43AM +0200, Mattias Rönnblom wrote: > Replace the use of rte_get_timer_cycles() with getentropy() for > seeding the pseudo-random number generator. getentropy() provides a > more truly random value. > > Suggested-by: Stephen Hemminger > Signed-off-by: Mattias Rönnblo

Re: [dpdk-dev] [PATCH 3/6] eal: improve entropy for initial PRNG seed

2019-05-14 Thread Bruce Richardson
On Tue, May 14, 2019 at 11:36:49AM +0200, Mattias Rönnblom wrote: > On 2019-05-14 11:20, Mattias Rönnblom wrote: > > Replace the use of rte_get_timer_cycles() with getentropy() for > > seeding the pseudo-random number generator. getentropy() provides a > > more truly random value. > > > > getentr

Re: [dpdk-dev] [dpdk-techboard] Discussion on the OS Packaging of DPDK

2019-05-14 Thread Ray Kinsella
On 10/05/2019 19:43, Thomas Monjalon wrote: > 10/05/2019 15:43, Bruce Richardson: >> On Fri, May 10, 2019 at 02:01:54PM +0100, Ray Kinsella wrote: >>> ( from the undersigned ) >>> >> To a certain extent, this only applies with the "make" build system, which >> is due to be deprecated in the nex

[dpdk-dev] KNI for FreeBSD.

2019-05-14 Thread Amin Saba
Hi all, Are there any specific issues in FreeBSD that have prevented implementation of KNI? Is implementation of KNI for FreeBSD in your roadmap? Thanks in adv, Amin

Re: [dpdk-dev] Using _XOPEN_SOURCE macros may break builds on FreeBSD

2019-05-14 Thread Ananyev, Konstantin
Hi Adrien, > On Tue, May 14, 2019 at 08:58:42AM +, Smoczynski, MarcinX wrote: > > > > Hey Konstantin, > > > > > > > > On Mon, May 13, 2019 at 10:49:00AM +, Ananyev, Konstantin wrote: > > > > > Hi Adrien, > > > > > > > > > > > > > > > > > On Mon, May 13, 2019 at 09:51:24AM +, Smoczynski

Re: [dpdk-dev] KNI for FreeBSD.

2019-05-14 Thread Burakov, Anatoly
On 14-May-19 11:27 AM, Amin Saba wrote: Hi all, Are there any specific issues in FreeBSD that have prevented implementation of KNI? Is implementation of KNI for FreeBSD in your roadmap? Thanks in adv, Amin Hi, I am not aware of KNI for FreeBSD being on a roadmap. I also don't think anyone

Re: [dpdk-dev] KNI for FreeBSD.

2019-05-14 Thread Ferruh Yigit
On 5/14/2019 11:27 AM, Amin Saba wrote: > Hi all, > > Are there any specific issues in FreeBSD that have prevented implementation > of KNI? > > Is implementation of KNI for FreeBSD in your roadmap? It is not in the roadmap as far as I know. cc'ed Paras, if I remember correctly he also mentioned

[dpdk-dev] [PATCH] build: enable BSD features visibility for FreeBSD

2019-05-14 Thread Marcin Smoczynski
When a component uses either XOPEN_SOURCE or POSIX_C_SOURCE macro explicitly in its build recipe, it restricts visibility of a non POSIX features subset, such as IANA protocol numbers (IPPROTO_* macros). Non standard features are enabled by default for DPDK both for Linux thanks to _GNU_SOURCE and

Re: [dpdk-dev] [PATCH] build: enable BSD features visibility for FreeBSD

2019-05-14 Thread Adrien Mazarguil
On Tue, May 14, 2019 at 01:43:54PM +0200, Marcin Smoczynski wrote: > When a component uses either XOPEN_SOURCE or POSIX_C_SOURCE macro > explicitly in its build recipe, it restricts visibility of a non POSIX > features subset, such as IANA protocol numbers (IPPROTO_* macros). > Non standard feature

Re: [dpdk-dev] [PATCH 3/6] eal: improve entropy for initial PRNG seed

2019-05-14 Thread Mattias Rönnblom
On 2019-05-14 11:39, Bruce Richardson wrote: On Tue, May 14, 2019 at 11:36:49AM +0200, Mattias Rönnblom wrote: On 2019-05-14 11:20, Mattias Rönnblom wrote: Replace the use of rte_get_timer_cycles() with getentropy() for seeding the pseudo-random number generator. getentropy() provides a more tr

Re: [dpdk-dev] [PATCH] build: enable BSD features visibility for FreeBSD

2019-05-14 Thread Bruce Richardson
On Tue, May 14, 2019 at 01:43:54PM +0200, Marcin Smoczynski wrote: > When a component uses either XOPEN_SOURCE or POSIX_C_SOURCE macro > explicitly in its build recipe, it restricts visibility of a non POSIX > features subset, such as IANA protocol numbers (IPPROTO_* macros). > Non standard feature

Re: [dpdk-dev] [PATCH] net/ixgbe: 10GBASE-T SFP+ copper support

2019-05-14 Thread Igor Russkikh
>>> TABLE 5-3 TRANSCEIVER COMPLIANCE CODES >>> 10G Ethernet Compliance Codes >>> 3 7 10G Base-ER >>> 3 6 10G Base-LRM >>> 3 5 10G Base-LR >>> 3 4 10G Base-SR >>> Infiniband Compliance Codes >>> 3 3 1X SX >>

Re: [dpdk-dev] KNI for FreeBSD.

2019-05-14 Thread Ray Kinsella
Doesn't netmap achieve similar functionality ? examples/netmap_compat/ Ray K On 14/05/2019 11:27, Amin Saba wrote: > Hi all, > > Are there any specific issues in FreeBSD that have prevented implementation > of KNI? > > Is implementation of KNI for FreeBSD in your roadmap? > > Thanks in adv, >

Re: [dpdk-dev] KNI for FreeBSD.

2019-05-14 Thread Bruce Richardson
On Tue, May 14, 2019 at 01:37:36PM +0100, Ray Kinsella wrote: > Doesn't netmap achieve similar functionality ? > > examples/netmap_compat/ > > Ray K > No, I don't think so. AFAIK, netmap is for pulling packets from the NIC into userspace. This is going from userspace to the kernel - the tap PMD

Re: [dpdk-dev] [PATCH 2/3] ipsec: fix transport mode for ipv6 with extensions

2019-05-14 Thread Ananyev, Konstantin
> > Reconstructing IPv6 header after encryption or decryption requires > updating 'next header' value in the preceding protocol header, which > is determined by parsing IPv6 header and iteratively looking for > next IPv6 header extension. > > It is required that 'l3_len' in the mbuf metadata c

Re: [dpdk-dev] [PATCH 1/3] net: new ipv6 header extension parsing function

2019-05-14 Thread Ananyev, Konstantin
> > Introduce new function for IPv6 header extension parsing able to > determine extension length and next protocol number. > > This function is helpful when implementing IPv6 header traversing. > > Signed-off-by: Marcin Smoczynski > --- Acked-by: Konstantin Ananyev > 2.21.0.windows.1

Re: [dpdk-dev] [PATCH 3/3] examples/ipsec-secgw: add support for ipv6 options

2019-05-14 Thread Ananyev, Konstantin
> > Using transport with IPv6 and header extensions requires calculating > total header length including extensions up to ESP header which is > achieved with iteratively parsing extensions when preparing traffic > for processing. Calculated l3_len is later used to determine SPI > field offset f

Re: [dpdk-dev] [PATCH] net/i40e: fix error when create two RSS flow rule

2019-05-14 Thread Zhang, Qi Z
> -Original Message- > From: Zhao1, Wei > Sent: Thursday, May 9, 2019 11:35 AM > To: dev@dpdk.org > Cc: sta...@dpdk.org; Zhang, Qi Z ; Peng, Yuan > ; Li, WenjieX A > Subject: RE: [PATCH] net/i40e: fix error when create two RSS flow rule > > Tested-by: Li WenjieX > > > -Original M

Re: [dpdk-dev] [PATCH v2] net/ice: set min and max MTU

2019-05-14 Thread Zhang, Qi Z
> -Original Message- > From: Yang, Qiming > Sent: Tuesday, May 14, 2019 10:16 AM > To: Zhang, Qi Z ; Lu, Wenzhuo > Cc: Stokes, Ian ; Yigit, Ferruh > ; > dev@dpdk.org > Subject: RE: [PATCH v2] net/ice: set min and max MTU > > > > > -Original Message- > > From: Zhang, Qi Z > >

Re: [dpdk-dev] [PATCH] build: enable BSD features visibility for FreeBSD

2019-05-14 Thread Smoczynski, MarcinX
> -Original Message- > From: Richardson, Bruce > Sent: Tuesday, May 14, 2019 2:20 PM > To: Smoczynski, MarcinX > Cc: tho...@monjalon.net; dev@dpdk.org; Ananyev, Konstantin > ; adrien.mazarg...@6wind.com > Subject: Re: [PATCH] build: enable BSD features visibility for FreeBSD > > On Tue

Re: [dpdk-dev] [PATCH] build: enable BSD features visibility for FreeBSD

2019-05-14 Thread Bruce Richardson
On Tue, May 14, 2019 at 02:15:04PM +0100, Smoczynski, MarcinX wrote: > > > > -Original Message- > > From: Richardson, Bruce > > Sent: Tuesday, May 14, 2019 2:20 PM > > To: Smoczynski, MarcinX > > Cc: tho...@monjalon.net; dev@dpdk.org; Ananyev, Konstantin > > ; adrien.mazarg...@6wind.com

[dpdk-dev] [PATCH v1] net/ice: change RSS RETA size to meet with ETH_RSS_RETA_SIZE_x

2019-05-14 Thread Haiyue Wang
Since ice can support 128, 512, 2K three RSS RETA size, and if set 2K by default, this will make it not compatible with ETH_RSS_RETA_SIZE_x value definition, limit it to 512 if the cap.rss_table_size exceeds the max value 512. Signed-off-by: Haiyue Wang --- drivers/net/ice/ice_ethdev.c | 22

[dpdk-dev] [PATCH 1/2] build: shorten code for instruction set detection

2019-05-14 Thread Bruce Richardson
Rather than checking flag by flag individually, use a loop to make it easier to check new flags. Signed-off-by: Bruce Richardson --- config/x86/meson.build | 34 +- 1 file changed, 13 insertions(+), 21 deletions(-) diff --git a/config/x86/meson.build b/config/x86

[dpdk-dev] [PATCH 2/2] build: add rdrand and rdseed checks to build

2019-05-14 Thread Bruce Richardson
The meson build never checked for the presence of rdrand and rdseed instructions, while make build never checked for rdseed. Ensure builds always have the appropriate checks - and therefore defines - for these instructions. For runtime, we also add in rdseed to the list of known bits returned from

Re: [dpdk-dev] [EXT] Re: [PATCH] ipsec: include high order bytes of esn in pkt len

2019-05-14 Thread Ananyev, Konstantin
Hi Lukasz, > >> > >> When esn is used then high-order 32 bits are included in ICV > >> calculation however are not transmitted. Update packet length > >> to be consistent with auth data offset and length before crypto > >> operation. High-order 32 bits of esn will be removed from packet > >> lengt

Re: [dpdk-dev] [RFC] crypto: handling of encrypted digest

2019-05-14 Thread Trahe, Fiona
After discussions with Pablo and Fan we plan to go with option 1 below and add a feature flag to capabilities, so by default existing PMDs won't publish support for it. We plan to push this in 19.08. > -Original Message- > From: Trahe, Fiona > Sent: Wednesday, May 8, 2019 6:39 PM > To: Do

Re: [dpdk-dev] [PATCH] net/ixgbe: fix cancel link handler when port is being removed

2019-05-14 Thread Zhang, Qi Z
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Zhao1, Wei > Sent: Monday, May 13, 2019 9:57 AM > To: wangyunjian ; dev@dpdk.org > Cc: i.maxim...@samsung.com; xudingke ; > sta...@dpdk.org > Subject: Re: [dpdk-dev] [PATCH] net/ixgbe: fix cancel link handler whe

[dpdk-dev] [PATCH v2 0/1] Enable BSD features visibility for FreeBSD

2019-05-14 Thread Marcin Smoczynski
v1 -> v2 * merge multiple -D__BSD_VISIBLE into one * merge multiple -D_GNU_SOURCE into one * add -D__BSD_VISIBLE to pc file for FreeBSD Marcin Smoczynski (1): build: enable BSD features visibility for FreeBSD app/meson.build | 3 --- config/meson.build| 8 dr

[dpdk-dev] [PATCH v2 1/1] build: enable BSD features visibility for FreeBSD

2019-05-14 Thread Marcin Smoczynski
When a component uses either XOPEN_SOURCE or POSIX_C_SOURCE macro explicitly in its build recipe, it restricts visibility of a non POSIX features subset, such as IANA protocol numbers (IPPROTO_* macros). Non standard features are enabled by default for DPDK both for Linux thanks to _GNU_SOURCE and

Re: [dpdk-dev] [PATCH 1/6] eal: replace libc-based random number generation with LFSR

2019-05-14 Thread Neil Horman
On Tue, May 14, 2019 at 11:20:41AM +0200, Mattias Rönnblom wrote: > This commit replaces rte_rand()'s use of lrand48() with a DPDK-native > combined Linear Feedback Shift Register (LFSR) (also known as > Tausworthe) pseudo-random number generator. > > This generator is faster and produces better-q

Re: [dpdk-dev] [EXT] Re: [PATCH] ipsec: include high order bytes of esn in pkt len

2019-05-14 Thread Lukas Bartosik
On 14.05.2019 15:52, Ananyev, Konstantin wrote: > Hi Lukasz, > When esn is used then high-order 32 bits are included in ICV calculation however are not transmitted. Update packet length to be consistent with auth data offset and length before crypto operation. High-order

Re: [dpdk-dev] [PATCH 1/6] eal: replace libc-based random number generation with LFSR

2019-05-14 Thread Mattias Rönnblom
On 2019-05-14 16:16, Neil Horman wrote: On Tue, May 14, 2019 at 11:20:41AM +0200, Mattias Rönnblom wrote: This commit replaces rte_rand()'s use of lrand48() with a DPDK-native combined Linear Feedback Shift Register (LFSR) (also known as Tausworthe) pseudo-random number generator. This generato

Re: [dpdk-dev] [PATCH] net/fm10k: advertise supported RSS hash function

2019-05-14 Thread Zhang, Qi Z
> -Original Message- > From: Wang, Xiao W > Sent: Monday, May 6, 2019 4:45 PM > To: Zhang, Qi Z > Cc: dev@dpdk.org; Yigit, Ferruh ; Wang, Xiao W > ; sta...@dpdk.org > Subject: [PATCH] net/fm10k: advertise supported RSS hash function > > PMD should advertise supported RSS hash functions

Re: [dpdk-dev] [PATCH] net/iavf: enable more link speed

2019-05-14 Thread Kevin Traynor
On 04/05/2019 15:09, Qi Zhang wrote: > Enable advanced link speed mode (VIRTCHNL_VF_CAP_ADV_LINK_SPEED) so iavf > PMD can identify more link speed that reported by pf. > > Cc: sta...@dpdk.org > There is no Fixes: tag and that looks correct as it is adding a new capability and in the process chan

Re: [dpdk-dev] [RFC] ethdev: add GRE optional fields to flow API

2019-05-14 Thread Stephen Hemminger
On Tue, 14 May 2019 10:18:29 +0300 Xiaoyu Min wrote: > Add GRE's checksum, key, and sequence field to the > struct rte_flow_item_gre in order to match. > > Signed-off-by: Xiaoyu Min > --- > lib/librte_ethdev/rte_flow.h | 4 > 1 file changed, 4 insertions(+) > > diff --git a/lib/librte_et

Re: [dpdk-dev] [dpdk-announce] release candidate 19.05-rc3

2019-05-14 Thread Ju-Hyoung Lee
Hello, DPDK https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgit.dpdk.org%2Fdpdk%2Fsnapshot%2Fdpdk-19.05-rc3.tar.xz&data=01%7C01%7Cjuhlee%40microsoft.com%7Cce65337d584e4524651b08d6d7f31501%7C72f988bf86f141af91ab2d7cd011db47%7C1&sdata=MUCwy8SE3czauyFK580w70owGbumw8k9Um6HXdjpmKw%3D

Re: [dpdk-dev] [PATCH 1/6] eal: replace libc-based random number generation with LFSR

2019-05-14 Thread Stephen Hemminger
On Tue, 14 May 2019 11:20:41 +0200 Mattias Rönnblom wrote: > +RTE_INIT(rte_rand_init) > +{ > + rte_srand(rte_get_timer_cycles()); > +} Please make initialization OS specific and use get_random() on Linux.

Re: [dpdk-dev] [PATCH v2] doc/compress: clarify error handling on data-plane

2019-05-14 Thread Trahe, Fiona
Hi Shally, Although we're close to agreement on this, I'm reconsidering. I think the difficulty we've had finding the best wording highlights the confusion an app developer will have in figuring out how to handle errors on enqueue. So I'm proposing to drop this - which was intended to allow some

Re: [dpdk-dev] [dpdk-announce] release candidate 19.05-rc4

2019-05-14 Thread Ju-Hyoung Lee
Hello, DPDK https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgit.dpdk.org%2Fdpdk%2Fsnapshot%2Fdpdk-19.05-rc4.tar.xz&data=01%7C01%7Cjuhlee%40microsoft.com%7C9a54854a243946e49c0e08d6d7f8e325%7C72f988bf86f141af91ab2d7cd011db47%7C1&sdata=Ako1OMrLmgmRTpExbu9bXSIaC4DqciA%2B7QOqw3%2BomF

Re: [dpdk-dev] [PATCH v2] doc/compress: clarify error handling on data-plane

2019-05-14 Thread Shally Verma
HI Fiona > -Original Message- > From: Trahe, Fiona > Sent: Tuesday, May 14, 2019 9:00 PM > To: Shally Verma ; dev@dpdk.org > Cc: akhil.go...@nxp.com; Ashish Gupta ; Daly, Lee > ; Sunila Sahu ; sta...@dpdk.org; > Trahe, Fiona > Subject: RE: [PATCH v2] doc/compress: clarify error handling

Re: [dpdk-dev] [PATCH] app/testpmd: change port detach interface

2019-05-14 Thread Thomas Monjalon
Hi, 13/05/2019 13:21, Nithin Dabilpuram: > With the latest published interface of > rte_eal_hotplug_[add,remove](), and rte_eth_dev_close(), > rte_eth_dev_close() would cleanup all the data structures of > port's eth dev leaving the device common resource intact > if RTE_ETH_DEV_CLOSE_REMOVE is se

Re: [dpdk-dev] DPDK Windows Community call - 02 May 2019

2019-05-14 Thread Thomas Monjalon
10/05/2019 01:34, Ranjit Menon: > Contact Cathal to be added to this meeting invite. Would it be possible to move this bi-weekly meeting to the Tuesday (same time), please? [...] > Encourage other dpdk.org Windows partners to join this call. Yes, would be nice to hear more developers joining the

[dpdk-dev] [PATCH] version: 19.08-rc0

2019-05-14 Thread Thomas Monjalon
Start a new release cycle with empty release notes. Signed-off-by: Thomas Monjalon --- VERSION| 2 +- doc/guides/rel_notes/index.rst | 1 + doc/guides/rel_notes/release_19_08.rst | 214 + 3 files changed, 216 insertions(+), 1 de

Re: [dpdk-dev] [PATCH] version: 19.08-rc0

2019-05-14 Thread David Marchand
On Tue, May 14, 2019 at 6:08 PM Thomas Monjalon wrote: > Start a new release cycle with empty release notes. > > Signed-off-by: Thomas Monjalon > --- > VERSION| 2 +- > doc/guides/rel_notes/index.rst | 1 + > doc/guides/rel_notes/release_19_08.rst | 2

Re: [dpdk-dev] DPDK Windows Community call - 02 May 2019

2019-05-14 Thread Harini Ramakrishnan
> - Draft repo needs a new branch to host latest Windows development >- currently WIP > Please, which up-to-date branch we can work on? "windpdk-next-dev" branch in the Windows DPDK draft repository is the most up to date branch that is currently a mirror of the upstream DPDK repository. http

Re: [dpdk-dev] [PATCH] net/ixgbe: 10GBASE-T SFP+ copper support

2019-05-14 Thread Ido Goshen
> -Original Message- > From: Stillwell Jr, Paul M > Sent: Wednesday, May 8, 2019 1:46 AM > To: Igor Russkikh ; Ido Goshen > ; Ananyev, Konstantin > ; Lu, Wenzhuo > Cc: dev@dpdk.org > Subject: RE: [dpdk-dev] [PATCH] net/ixgbe: 10GBASE-T SFP+ copper support > > > > -Original Message

[dpdk-dev] [PATCH v2 0/5] BBDEV PMD Drivers Extension for 19.08

2019-05-14 Thread Nicolas Chautru
This was deferred from 19.05 due to time running out. Addition of a PMD for 4G FEC encoding and decoding functions for Intel PAC N300 FPGA. Extension of PMD based on Intel optimised SW libraries for 5G FEC. The HW dependency is available now. v2 : Cosmetic updates from ci/checkpatch Nicolas C

[dpdk-dev] [PATCH v2 1/5] baseband/fpga_lte_fec: adding driver for FEC on FPGA

2019-05-14 Thread Nicolas Chautru
Supports for FEC 4G PMD Driver on FPGA card PAC N300 Signed-off-by: Nicolas Chautru --- config/common_base |6 + doc/guides/bbdevs/fpga_lte_fec.rst | 318 +++ doc/guides/bbdevs/index.rst|1 + drivers/baseband/Makefi

[dpdk-dev] [PATCH v2 2/5] bbdev: extension of BBDEV for 5G FEC

2019-05-14 Thread Nicolas Chautru
Supporting API for FEC operation with LDPC Signed-off-by: Nicolas Chautru --- doc/guides/prog_guide/bbdev.rst | 509 ++-- drivers/baseband/fpga_lte_fec/fpga_lte_fec.c | 24 +- drivers/baseband/turbo_sw/bbdev_turbo_software.c | 36 +- lib/librte_bbdev/rte_bb

[dpdk-dev] [PATCH v2 5/5] usertools: update to usertool for baseband device

2019-05-14 Thread Nicolas Chautru
Allows binding of baseband devices Signed-off-by: Nicolas Chautru --- usertools/dpdk-devbind.py | 10 +- usertools/dpdk-setup.sh | 6 +++--- 2 files changed, 12 insertions(+), 4 deletions(-) mode change 100755 => 100644 usertools/dpdk-devbind.py mode change 100755 => 100644 usertool

[dpdk-dev] [PATCH v2 3/5] baseband/turbo_sw: extension of turbosw for 5G FEC

2019-05-14 Thread Nicolas Chautru
Implementation still based on Intel SDK libraries Optimized for AVX512 instructions set Signed-off-by: Nicolas Chautru --- app/test-bbdev/test_bbdev_vector.c | 4 +- app/test-bbdev/test_bbdev_vector.h | 2 +- config/common_base | 3

Re: [dpdk-dev] [PATCH 0/5] BBDEV PMD Drivers Extension for 19.08

2019-05-14 Thread Thomas Monjalon
Hi, 14/05/2019 02:07, Chautru, Nicolas: > Hi Luca, > > Is that fair to consider support meson build in a separate patchset once > this one is applied? No, any new code must support meson now. > - Currently even on 19.05 there is no meson build support for the > existing baseband driv

Re: [dpdk-dev] [PATCH v2 0/5] BBDEV PMD Drivers Extension for 19.08

2019-05-14 Thread Thomas Monjalon
14/05/2019 21:45, Nicolas Chautru: > This was deferred from 19.05 due to time running out. No it is deferred because I am against new bbdev code in DPDK. We cannot compile the first PMD "turbo_sw", so it might be removed. > Addition of a PMD for 4G FEC encoding and decoding functions for Intel PA

Re: [dpdk-dev] [PATCH] version: 19.08-rc0

2019-05-14 Thread Thomas Monjalon
14/05/2019 18:32, David Marchand: > On Tue, May 14, 2019 at 6:08 PM Thomas Monjalon wrote: > > > Start a new release cycle with empty release notes. > > > > Signed-off-by: Thomas Monjalon > Reviewed-by: David Marchand Applied 19.08 release cycle is now officially started! Please don't forget

Re: [dpdk-dev] [RFC] crypto: handling of encrypted digest

2019-05-14 Thread Kusztal, ArkadiuszX
Hi Fiona, Two small things to clarify bit more. > -Original Message- > From: Trahe, Fiona > Sent: Tuesday, May 14, 2019 3:59 PM > To: Doherty, Declan ; De Lara Guarch, Pablo > ; akhil.go...@nxp.com; > ravi1.ku...@amd.com; Jerin Jacob Kollanukkaran ; > Anoob Joseph ; Zhang, Roy Fan > ; t..

[dpdk-dev] [PATCH] net/i40e: enable new device

2019-05-14 Thread Beilei Xing
This patch removes ifdef to enable new device. Signed-off-by: Beilei Xing --- drivers/net/i40e/base/i40e_adminq_cmd.h | 49 - drivers/net/i40e/base/i40e_common.c | 6 drivers/net/i40e/base/i40e_devids.h | 2 -- drivers/net/i40e/base/i40e_type.h

[dpdk-dev] [PATCH v9] app/pdump: exit with primary process

2019-05-14 Thread Suanming . Mou
From: Suanming Mou The pdump tool works as the secondary process. When the primary process exits and the residual secondary process keeps running, it will make the primary process can't start up again. Since the ex-fbarry files are still attached by the secondary process pdump, the 'new' primary

Re: [dpdk-dev] [PATCH] version: 19.08-rc0

2019-05-14 Thread Stephen Hemminger
On Tue, 14 May 2019 23:00:17 +0200 Thomas Monjalon wrote: > 14/05/2019 18:32, David Marchand: > > On Tue, May 14, 2019 at 6:08 PM Thomas Monjalon wrote: > > > > > Start a new release cycle with empty release notes. > > > > > > Signed-off-by: Thomas Monjalon > > Reviewed-by: David Marchand

[dpdk-dev] [Bug 278] bond_ethdev_rx_burst multithread access bond's different queue will crash

2019-05-14 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=278 Bug ID: 278 Summary: bond_ethdev_rx_burst multithread access bond's different queue will crash Product: DPDK Version: 18.11 Hardware: All OS: All Status:

Re: [dpdk-dev] [PATCH 0/3] fix invalid Tx threshhold setup

2019-05-14 Thread Xing, Beilei
> -Original Message- > From: Zhang, Qi Z > Sent: Saturday, May 4, 2019 5:30 PM > To: Xing, Beilei ; Lu, Wenzhuo > ; Yang, Qiming ; Ananyev, > Konstantin > Cc: dev@dpdk.org; Zhang, Qi Z > Subject: [PATCH 0/3] fix invalid Tx threshhold setup > > When tx_free_thresh + tx_rs_thresh > nb_d

Re: [dpdk-dev] [PATCH] app/testpmd: change port detach interface

2019-05-14 Thread Nithin Dabilpuram
Hi Thomas, On Tue, May 14, 2019 at 05:39:30PM +0200, Thomas Monjalon wrote: > Hi, > > 13/05/2019 13:21, Nithin Dabilpuram: > > With the latest published interface of > > rte_eal_hotplug_[add,remove](), and rte_eth_dev_close(), > > rte_eth_dev_close() would cleanup all the data structures of > > po