[dpdk-dev] [PATCH] eventdev: fix doxygen comment

2019-06-19 Thread jerinj
From: Jerin Jacob Update rte_eventdev.h file description to adapt to Tx adapter changes. Fixes: c9bf83947e2e ("eventdev: add eth Tx adapter APIs") Cc: sta...@dpdk.org Cc: Nikhil Rao Signed-off-by: Jerin Jacob --- lib/librte_eventdev/rte_eventdev.h | 6 +++--- 1 file changed, 3 insertions(+),

Re: [dpdk-dev] [PATCH v2] eventdev: change Rx adapter callback and stats structure

2019-06-19 Thread Rao, Nikhil
Hi Jerin, > -Original Message- > From: Jerin Jacob Kollanukkaran [mailto:jer...@marvell.com] > Sent: Monday, June 17, 2019 10:03 AM > To: Rao, Nikhil > Cc: dev@dpdk.org > Subject: RE: [PATCH v2] eventdev: change Rx adapter callback and stats > structure > > 2) remove the following > lib

[dpdk-dev] [PATCH] maintainers: update dpdk-next-net-intel

2019-06-19 Thread Qi Zhang
Xiaolong Ye will replace Beilei Xing as co-maintainer of dpdk-next-net-intel. Signed-off-by: Qi Zhang --- MAINTAINERS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/MAINTAINERS b/MAINTAINERS index fdc083db9..19f18b09d 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -33,7 +33,7

[dpdk-dev] [PATCH v3] doc: support new i40e device

2019-06-19 Thread Beilei Xing
Add support for new i40e device. Fixes: 4b748eef853c ("net/i40e: enable new device") Signed-off-by: Beilei Xing --- v3 change: - Add new section. - Add fixes line. v2 change: - Change indentation. doc/guides/rel_notes/release_19_08.rst | 18 ++ 1 file changed, 18 insertions

Re: [dpdk-dev] [PATCH v2] eventdev: change Rx adapter callback and stats structure

2019-06-19 Thread Rao, Nikhil
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Rao, Nikhil > Sent: Wednesday, June 19, 2019 1:40 PM > To: Jerin Jacob Kollanukkaran > Cc: dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v2] eventdev: change Rx adapter callback > and stats structure > > Hi Jerin,

[dpdk-dev] [PATCH v3 1/4] net/ipn3ke: add new register address

2019-06-19 Thread Andy Pei
ipn3ke can work on 10G mode and 25G mode. 10G mode and 25G mode has different MAC register address for statistics. This patch implemente statistics registers for 10G mode and 25G mode. Fixes: c01c748e4ae6 ("net/ipn3ke: add new driver") Cc: rosen...@intel.com Signed-off-by: Andy Pei --- drivers/

[dpdk-dev] [PATCH v3 4/4] net/ipn3ke: implementation of statistics

2019-06-19 Thread Andy Pei
This patch implemente statistics read and reset function for ipn3ke. Fixes: 70d6b7f550f4 ("net/ipn3ke: add representor") Cc: rosen...@intel.com Signed-off-by: Andy Pei --- drivers/net/ipn3ke/ipn3ke_representor.c | 3440 ++- 1 file changed, 3431 insertions(+), 9 delet

[dpdk-dev] [PATCH v3 2/4] net/ipn3ke: delete MAC register address mask

2019-06-19 Thread Andy Pei
original code is compatible with older device, whose mac register address is no more than 10 bits. Now we have mac register address longer than 10 bits, so we just delete the mask here. Fixes: c01c748e4ae6 ("net/ipn3ke: add new driver") Cc: rosen...@intel.com Signed-off-by: Andy Pei --- drivers

[dpdk-dev] [PATCH v3 3/4] net/ipn3ke: clear statistics when init and start dev

2019-06-19 Thread Andy Pei
clear line side and NIC side statistics registers when HW init and uinit, and when dev start. Fixes: c01c748e4ae6 ("net/ipn3ke: add new driver") Cc: rosen...@intel.com Signed-off-by: Andy Pei --- drivers/net/ipn3ke/ipn3ke_ethdev.c | 59 - drivers/net/ipn3ke/

Re: [dpdk-dev] [PATCH v3 4/4] net/ipn3ke: implementation of statistics

2019-06-19 Thread David Marchand
On Wed, Jun 19, 2019 at 10:56 AM Andy Pei wrote: > This patch implemente statistics read and reset > function for ipn3ke. > > Fixes: 70d6b7f550f4 ("net/ipn3ke: add representor") > Cc: rosen...@intel.com > > Signed-off-by: Andy Pei > --- > drivers/net/ipn3ke/ipn3ke_representor.c | 3440 > +++

Re: [dpdk-dev] [RFC 1/3] ethdev: extend flow metadata

2019-06-19 Thread Andrew Rybchenko
On 11.06.2019 3:06, Yongseok Koh wrote: On Mon, Jun 10, 2019 at 10:20:28AM +0300, Andrew Rybchenko wrote: On 6/10/19 6:19 AM, Wang, Haiyue wrote: -Original Message- From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Andrew Rybchenko Sent: Sunday, June 9, 2019 22:24 To: Yongseok Koh ;

Re: [dpdk-dev] [PATCH 2/2] net/vhost: support mrg-rxbuf disabling

2019-06-19 Thread Maxime Coquelin
Hi Noa, On 6/19/19 8:13 AM, Noa Ezra wrote: Rx mergeable buffers is a virtio feature that allows chaining of multiple virtio descriptors to handle large packet size. This behavior is supported and enabled by default, however in case the user knows that rx mergeable buffers are not needed, he can

[dpdk-dev] [PATCH] net/mlx5: fix check for rte calloc return value

2019-06-19 Thread Asaf Penso
rte_calloc functions returns a non-null pointer in case of success and null pointer in case of failure. The return value should be checked and the function flow should take that into consideration. This patch adds a check for rte_calloc return value in function flow_list_create. Fixes: 84c406e7

[dpdk-dev] [PATCH] net/mlx5: fix condition for calling mlx5_link_update_unlocked_gset

2019-06-19 Thread Asaf Penso
mlx5_link_update uses the newer ethtool command ETHTOOL_GLINKSETTINGS to determine interface capabilities but falls back to the older (deprecated) ETHTOOL_GSET command if the new method fails for any reason. The older method only supports reporting of capabilities up to 40G. However, mlx5_link_upd

Re: [dpdk-dev] [PATCH 1/2] net/vhost: support TSO disabling

2019-06-19 Thread Maxime Coquelin
On 6/19/19 8:13 AM, Noa Ezra wrote: TSO (TCP Segmentation Offload) is enabled by default on vhost. Add the ability to disable TSO on vhost. The user should also disable the feature on the virtual machine's xml. For TSO, I think it make sense to have the option to disable it, as it requires t

Re: [dpdk-dev] [PATCH v2 02/10] meson: add BUILDING_RTE_SDK

2019-06-19 Thread Neil Horman
On Thu, Jun 13, 2019 at 03:44:02PM +0100, Bruce Richardson wrote: > On Thu, Jun 13, 2019 at 10:23:36AM -0400, Neil Horman wrote: > > The __rte_internal macro is defined dependent on the value of the build > > environment variable BUILDING_RTE_SDK. This variable was set in the > > Makefile environm

Re: [dpdk-dev] [PATCH v2 02/10] meson: add BUILDING_RTE_SDK

2019-06-19 Thread Bruce Richardson
On Wed, Jun 19, 2019 at 06:39:00AM -0400, Neil Horman wrote: > On Thu, Jun 13, 2019 at 03:44:02PM +0100, Bruce Richardson wrote: > > On Thu, Jun 13, 2019 at 10:23:36AM -0400, Neil Horman wrote: > > > The __rte_internal macro is defined dependent on the value of the build > > > environment variable

Re: [dpdk-dev] [PATCH v2 05/10] fslmc: identify internal only functions and tag them as __rte_internal

2019-06-19 Thread Neil Horman
On Mon, Jun 17, 2019 at 07:30:34AM +, Hemant Agrawal wrote: > HI Neil, > The same code of low-level HW driver is shared with different OSs > (kernel, uboot etc) and different framework. If we introduce rte_internal in > these low-level hw files, it will be a big maintenance issue for NX

[dpdk-dev] Does DPDK support DEFAULTED state in Receive machine in 802.3ad bond implementation?

2019-06-19 Thread lidejun
Why doesn’t DPDK support `DEFAULTED` state in Receive machine in 802.3ad bond implementation?

[dpdk-dev] i219 reset hang

2019-06-19 Thread Anand H. Krishnan
Hello, Can somebody please provide an equivalent patch for DPDK. https://patchwork.ozlabs.org/patch/479888/ We are most likely hitting this issue in our setup, when we restart our DPDK application multiple times on the i219LM NIC. If someone can provide a patch, we can test it and see whether we

Re: [dpdk-dev] [PATCH v3] net/avp: remove resources when port is closed

2019-06-19 Thread Peters, Matt
> -Original Message- > From: Legacy, Allain > Sent: Tuesday, June 18, 2019 3:19 PM > To: tho...@monjalon.net > Cc: dev@dpdk.org; ferruh.yi...@intel.com; Peters, Matt > Subject: [PATCH v3] net/avp: remove resources when port is closed > > The rte_eth_dev_close() function now handles freeing

Re: [dpdk-dev] [PATCH] examples/vhost_crypto: fix unchecked return value

2019-06-19 Thread Jens Freimann
On Mon, Jun 17, 2019 at 09:09:59AM +, Zhang, Roy Fan wrote: Hi Jens, You are right. Sorry the code wasn't cleaned up properly in the first place. Do you want me to send a v2 with new title? No it's fine for me :) regards, Jens

Re: [dpdk-dev] [PATCH 1/4] net/virtio: fix memory leak in in-order Rx

2019-06-19 Thread Maxime Coquelin
On 6/18/19 9:41 AM, Tiwei Bie wrote: When there is no enough segments for a packet in in-order mergeable Rx path, we should free the whole mbuf chain instead of just the last segment. I would write instead: " we should free the whole mbuf chain instead of just recycling the last segment.

Re: [dpdk-dev] [PATCH 2/4] net/virtio: fix memory leak in mergeable Rx

2019-06-19 Thread Maxime Coquelin
On 6/18/19 9:41 AM, Tiwei Bie wrote: When there is no enough segments for a packet in mergeable Rx path, we should free the whole mbuf chain instead of just the last segment. Fixes: bcac5aa207f8 ("net/virtio: improve batching in mergeable path") Cc:sta...@dpdk.org Signed-off-by: Tiwei Bie --

Re: [dpdk-dev] [PATCH 3/4] net/virtio: fix memory leak in mergeable packed Rx

2019-06-19 Thread Maxime Coquelin
On 6/18/19 9:41 AM, Tiwei Bie wrote: When there is no enough segments for a packet in mergeable packed Rx path, we should free the whole mbuf chain instead of just the last segment. Fixes: a76290c8f1cf ("net/virtio: implement Rx path for packed queues") Cc:sta...@dpdk.org Signed-off-by: Tiwe

Re: [dpdk-dev] [PATCH v2 3/3] lib/lpm: remove unnecessary inline

2019-06-19 Thread Medvedkin, Vladimir
Hi Wang, 1. It is better to explicitly use __rte_noinline with this function because my gcc still inlines it even without the inline qualifier. 2. The same should be applied to _v20 functions. 3. Please try running the tests again and show the results. 4. Make this patch the first in a serie

Re: [dpdk-dev] [PATCH 4/4] net/virtio: fix packets check in mergeable packed Rx

2019-06-19 Thread Maxime Coquelin
On 6/18/19 9:41 AM, Tiwei Bie wrote: We should check the descriptor state instead of vq's internal free count (i.e. the number of descriptors that we haven't made available) for the remaining mergeable packets. Fixes: a76290c8f1cf ("net/virtio: implement Rx path for packed queues") Cc: sta...

Re: [dpdk-dev] Does DPDK support DEFAULTED state in Receive machine in 802.3ad bond implementation?

2019-06-19 Thread Chas Williams
On 6/19/19 7:29 AM, lidejun wrote: Why doesn’t DPDK support `DEFAULTED` state in Receive machine in 802.3ad bond implementation? Can you be a bit more specific about your question? This is some support for a DEFAULTED state.

Re: [dpdk-dev] [dpdk-stable] [PATCH] test-pmd: removed references to crc_strip

2019-06-19 Thread Sirvys, Andrius
That sounds like a good idea. Do you have any examples by chance of something like this or any advice how to implement. The string needs to be generated beforehand so where would we be able to put the code in for that. From: David Marchand [mailto:david.march...@redhat.com] Sent: Tuesday, June 1

Re: [dpdk-dev] [PATCH 0/2] support tso and mrg-rxbuf disabling

2019-06-19 Thread Aaron Conole
Noa Ezra writes: > Add support for disabling TSO and mrg-rxbuf in vhost. > > Noa Ezra (2): > net/vhost: support TSO disabling > net/vhost: support mrg-rxbuf disabling > > doc/guides/nics/vhost.rst | 10 + > drivers/net/vhost/rte_eth_vhost.c | 45 > +++

Re: [dpdk-dev] [dpdk-stable] [PATCH] test-pmd: removed references to crc_strip

2019-06-19 Thread David Marchand
On Wed, Jun 19, 2019 at 4:13 PM Sirvys, Andrius wrote: > That sounds like a good idea. Do you have any examples by chance of > something like this or any advice how to implement. > > The string needs to be generated beforehand so where would we be able to > put the code in for that. > For the us

Re: [dpdk-dev] [dpdk-stable] [PATCH] test-pmd: removed references to crc_strip

2019-06-19 Thread David Marchand
On Wed, Jun 19, 2019 at 4:23 PM David Marchand wrote: > > On Wed, Jun 19, 2019 at 4:13 PM Sirvys, Andrius > wrote: > >> That sounds like a good idea. Do you have any examples by chance of >> something like this or any advice how to implement. >> >> The string needs to be generated beforehand so

[dpdk-dev] DPDK19.08 Mellanox Roadmap

2019-06-19 Thread Asaf Penso
I apologize for the late notice. This is Mellanox's roadmap for DPDK19.08, which we are working on currently. Introduce rte_flow APIs for: * Matching and modification for TCP ACK and TCP SEQ. * Setting Metadata in RX and receiving it as part of mbuf, to have more info from packet processing in th

Re: [dpdk-dev] [PATCH v2] maintainers: claim maintainership of BBDEV

2019-06-19 Thread Akhil Goyal
> On Mon, Jun 17, 2019 at 11:21:28AM -0700, Nicolas Chautru wrote: > > Reorg within Intel teams causing transfer of maintainership > > > > Signed-off-by: Nicolas Chautru > > --- > > Acked-by: Bruce Richardson > Applied to dpdk-next-crypto Thanks

Re: [dpdk-dev] [PATCH v2] symmetric crypto, set message field to zero in SGL case

2019-06-19 Thread Akhil Goyal
> > Fixes: e09231eaa2af ("crypto/qat: add SGL capability") > > Cc: Arek Kusztal > > Cc: sta...@dpdk.org > > > > Signed-off-by: Gosia Bakota > Acked-by: Fiona Trahe No need to add " Cc: Arek Kusztal " in commit message. Also changes the subject as that of your v1. Please take care of this in fu

Re: [dpdk-dev] [PATCH] crypto/openssl: fix usage of non constant time memcmp for mac and signature

2019-06-19 Thread Akhil Goyal
> > > > -Original Message- > > From: Kusztal, ArkadiuszX > > Sent: Friday, May 31, 2019 7:59 AM > > To: dev@dpdk.org > > Cc: akhil.go...@nxp.com; Trahe, Fiona ; Doherty, > Declan > > ; Kusztal, ArkadiuszX > > > Subject: [PATCH] crypto/openssl: fix usage of non constant time memcmp for

Re: [dpdk-dev] [PATCH v2] crypto/octeontx: sync mbox changes done in kernel driver

2019-06-19 Thread Akhil Goyal
> From: Lukasz Bartosik > > Synchronize mbox with latest changes in kernel driver > > Signed-off-by: Lukasz Bartosik > Signed-off-by: Anoob Joseph > --- > drivers/crypto/octeontx/otx_cryptodev_mbox.c | 3 +++ > drivers/crypto/octeontx/otx_cryptodev_mbox.h | 12 +--- > 2 files chan

Re: [dpdk-dev] [PATCH] app/test-crypto-perf: fix csv format

2019-06-19 Thread Akhil Goyal
> From: Ankur Dwivedi > > The format for printing float is incorrect for the following fields > in pmd-cyclecount test: Cycles/Op,Cycles/Enq,Cycles/Deq. > > Currently, the format is %.f3. This format will round off the number to > the nearest integer and append a 3 after that. > > This patch ch

Re: [dpdk-dev] [PATCH 1/5] doc/guides/cryptodevs: cleanup for armv8 and openssl PMDs

2019-06-19 Thread Akhil Goyal
> The perf tests were removed in a previous commit. > > Fixes: 2ac67c32837a ('test/crypto: remove crypto perf tests') > Signed-off-by: Thierry Herbelot > --- > doc/guides/cryptodevs/armv8.rst | 1 - > doc/guides/cryptodevs/openssl.rst | 1 - > 2 files changed, 2 deletions(-) > Acked-by: Akhil

Re: [dpdk-dev] [PATCH] compress/isal: fix use after free

2019-06-19 Thread Akhil Goyal
> > > > > > The release function was using qp->stream after already releasing it and > > > the > > > null pointer checking was missing. > > > > > > Also since rte_free(NULL) is a no-op, remove unnecessary checks for NULL. > > > > > > Coverity issure: 340860 > > > Fixes: dc49e6aa4879 ("compress/isa

Re: [dpdk-dev] [PATCH] app/test-compress-perf: fix improper use of negative value

2019-06-19 Thread Akhil Goyal
> > > > This patch fixes coverity issue: Improper use of negative value. > > test_data->input_data_sz is passed to a parameter that > > cannot be negative. > > > > Coverity issue: 328504 > > Fixes: b68a82425da4 ("app/compress-perf: add performance measurement") > > Cc: sta...@dpdk.org > > > > Signe

Re: [dpdk-dev] [PATCH] examples/fips_validation: fix logically dead code

2019-06-19 Thread Akhil Goyal
> > > > Coverity issue: 336866 > > Coverity issue: 336841 > > Coverity issue: 336838 > > Fixes: 41d561cbdd24 ("examples/fips_validation: add power on self test") > > > > Signed-off-by: Fan Zhang > > --- > > Acked-by: Marko Kovacevic Cc: sta...@dpdk.org Applied to dpdk-next-crypto Thanks

Re: [dpdk-dev] [PATCH v3] doc/compress: clarify error handling on data-plane

2019-06-19 Thread Akhil Goyal
> > Fixed some typos and clarified how errors on ops which fail to get submitted > on > > the enqueue API should be handled. > > > > Fixes: a584d3bea902 ("doc: add compressdev library guide") > > cc: sta...@dpdk.org > > > > Signed-off-by: Fiona Trahe > > --- > Acked-by: Shally Verma > > Appl

Re: [dpdk-dev] [PATCH] app/compress-perf: add info about socket id used by app and by the driver

2019-06-19 Thread Akhil Goyal
> > Added info about socket id used by compression perf test process and by the > driver > > Signed-off-by: Tomasz Cel > Signed-off-by: Fiona Trahe > Acked-by: Artur Trybula < arturx.tryb...@intel.com> > --- Applied to dpdk-next-crypto Thanks.

Re: [dpdk-dev] [PATCH v1] crypto/virtio: fix return value check

2019-06-19 Thread Akhil Goyal
> > Fix unchecked return value issue for rte_pci_read_config. > > Coverity issue: 302861 > Fixes: 25500d4b8076 ("crypto/virtio: support device init") > Cc: sta...@dpdk.org > > Signed-off-by: Chenbo Xia > --- Acked-by: Akhil Goyal Applied to dpdk-next-crypto Thanks.

Re: [dpdk-dev] [PATCH] cryptodev: add an option to support both iv and J0 for GCM

2019-06-19 Thread Akhil Goyal
> > > > This patch adds an option to support both IV (of all supported sizes) > > and J0 when using Galois Counter Mode of crypto operation. > > > > Signed-off-by: Arek Kusztal > > --- > > lib/librte_cryptodev/rte_crypto_sym.h | 37 > > ++--- > -- > > 1 file change

Re: [dpdk-dev] [PATCH v3] cryptodev: make xform key pointer constant

2019-06-19 Thread Akhil Goyal
Hi Fan, > > > > Hi Akhil, > > > > This patch was sent in 19.05 but I just found it can be applied to 19.08 RC0 > > cleanly. > > Do you think I need to send a v4 (with no change) for 19.08? > > > No need to send a v4, I will take v3. Planning to take some patches next week. > Will let you know in ca

[dpdk-dev] [PATCH v7 1/1] eventdev: add new software event timer adapter

2019-06-19 Thread Erik Gabriel Carrillo
This patch introduces a new version of the event timer adapter software PMD. In the original design, timer event producer lcores in the primary and secondary processes enqueued event timers into a ring, and a service core in the primary process dequeued them and processed them further. To improve

[dpdk-dev] [PATCH v7 0/1] New software event timer adapter

2019-06-19 Thread Erik Gabriel Carrillo
This patch introduces a new version of the event timer adapter software PMD [1]. In the original design, timer event producer lcores in the primary and secondary processes enqueued event timers into a ring, and a service core in the primary process dequeued them and processed them further. To impr

[dpdk-dev] [PATCH 01/28] vhost: introduce vhost transport operations structure

2019-06-19 Thread Nikos Dragazis
This is the first of a series of patches, whose purpose is to add support for the virtio-vhost-user transport. This is a vhost-user transport implementation that is different from the default AF_UNIX transport. It uses the virtio-vhost-user PCI device in order to tunnel vhost-user protocol messages

[dpdk-dev] [PATCH 00/28] vhost: add virtio-vhost-user transport

2019-06-19 Thread Nikos Dragazis
Hi everyone, this patch series introduces the concept of the virtio-vhost-user transport. This is actually a revised version of an earlier RFC implementation that has been proposed by Stefan Hajnoczi [1]. Though this is a great feature, it seems to have been stalled, so I’d like to restart the con

[dpdk-dev] [PATCH 02/28] vhost: move socket management code

2019-06-19 Thread Nikos Dragazis
The socket.c file serves two purposes: 1. librte_vhost public API entry points, e.g. rte_vhost_driver_register(). 2. AF_UNIX socket management. Move AF_UNIX socket code into trans_af_unix.c so that socket.c only handles the librte_vhost public API entry points. This will make it possible to suppo

[dpdk-dev] [PATCH 03/28] vhost: allocate per-socket transport state

2019-06-19 Thread Nikos Dragazis
From: Stefan Hajnoczi vhost-user transports have per-socket state (like file descriptors). Make it possible for transports to keep state beyond what is included in struct vhost_user_socket. This patch makes it possible to move AF_UNIX-specific fields from struct vhost_user_socket into trans_af_u

[dpdk-dev] [PATCH 04/28] vhost: move socket fd and un sockaddr

2019-06-19 Thread Nikos Dragazis
The socket file descriptor and AF_UNIX sockaddr are specific to the AF_UNIX transport, so move them into trans_af_unix.c. In order to do this, we need to begin defining the vhost_transport_ops interface that will allow librte_vhost to support multiple transports. This patch adds socket_init() and

[dpdk-dev] [PATCH 06/28] vhost: move vhost-user connection

2019-06-19 Thread Nikos Dragazis
The AF_UNIX transport can accept multiple client connections on a server socket. Each connection instantiates a separate vhost-user device, which is stored as a vhost_user_connection. This behavior is specific to AF_UNIX and other transports may not support N connections per socket endpoint. Mov

[dpdk-dev] [PATCH 05/28] vhost: move start server/client calls

2019-06-19 Thread Nikos Dragazis
From: Stefan Hajnoczi Introduce a vhost_transport_ops->socket_start() interface so the transport can begin establishing vhost-user connections. This is part of the AF_UNIX transport refactoring and removes AF_UNIX code from vhost.h and socket.c. Signed-off-by: Stefan Hajnoczi --- lib/librte_v

[dpdk-dev] [PATCH 07/28] vhost: move vhost-user reconnection

2019-06-19 Thread Nikos Dragazis
The socket reconnection code is highly specific to AF_UNIX, so move the remaining pieces of it into trans_af_unix.c. Signed-off-by: Nikos Dragazis Signed-off-by: Stefan Hajnoczi --- lib/librte_vhost/socket.c| 4 lib/librte_vhost/trans_af_unix.c | 9 +++-- lib/librte_vhost/vho

[dpdk-dev] [PATCH 09/28] vhost: propagate vhost transport operations

2019-06-19 Thread Nikos Dragazis
This patch propagates struct vhost_user_socket's vhost_transport_ops into the newly created vhost device. This patch completes the initial refactoring of socket.c, with the AF_UNIX-specific code now in trans_af_unix.c and the librte_vhost API entrypoints in socket.c. Now it is time to turn toward

[dpdk-dev] [PATCH 08/28] vhost: move vhost-user fdset

2019-06-19 Thread Nikos Dragazis
The fdset is used by the AF_UNIX transport code but other transports may not need it. Move it to trans_af_unix.c and then make struct vhost_user private again since nothing outside socket.c needs it. Signed-off-by: Nikos Dragazis Signed-off-by: Stefan Hajnoczi --- lib/librte_vhost/socket.c

[dpdk-dev] [PATCH 10/28] vhost: use a single structure for the device state

2019-06-19 Thread Nikos Dragazis
There is a 1:1 relationship between struct virtio_net and struct vhost_user_connection. They share the same lifetime. struct virtio_net is the per-device state that is part of the vhost.h API. struct vhost_user_connection is the AF_UNIX-specific per-device state and is private to trans_af_unix.c

[dpdk-dev] [PATCH 11/28] vhost: extract socket I/O into transport

2019-06-19 Thread Nikos Dragazis
The core vhost-user protocol code should not do socket I/O, because the details are transport-specific. Move code to send and receive vhost-user messages into trans_af_unix.c. The connection fd is a transport-specific feature. Therefore, it should and eventually will be removed from the core vhos

[dpdk-dev] [PATCH 12/28] vhost: move slave request fd and lock

2019-06-19 Thread Nikos Dragazis
The slave request file descriptor is specific to the AF_UNIX transport. Move this field along with its spinlock out of struct virtio_net and into the trans_af_unix.c private struct vhost_user_connection struct. This implies that we also had to move the associated functions send_vhost_slave_message(

[dpdk-dev] [PATCH 13/28] vhost: move mmap/munmap

2019-06-19 Thread Nikos Dragazis
Mapping the vhost memory regions is a transport-specific operation, so this patch moves the relevant code into trans_af_unix.c. The new .map_mem_table()/.unmap_mem_table() interfaces allow transports to perform the mapping and unmapping. In addition, the function vhost_user_set_mem_table(), which

[dpdk-dev] [PATCH 14/28] vhost: move setup of the log memory region

2019-06-19 Thread Nikos Dragazis
Setting up the log memory region involves mapping/unmapping guest memory. This is a transport-specific operation. Other transports may use other means of accessing the guest memory log. Therefore, the mmap/unmap operations, that are related to the memory log, are moved to trans_af_unix.c. A new set

[dpdk-dev] [PATCH 15/28] vhost: remove main fd parameter from msg handlers

2019-06-19 Thread Nikos Dragazis
After refactoring the socket I/O and the vhost-user map/unmap operations in previous patches, there is no need for the connection fds in the core vhost-user code. This patch removes the connection fds from the core vhost-user code. Connection fds are used for socket I/O between master and slave. H

[dpdk-dev] [PATCH 16/28] vhost: move postcopy live migration code

2019-06-19 Thread Nikos Dragazis
Postcopy live migration is an AF_UNIX-bound feature due to the userfaultfd mechanism. Therefore, this patch moves the relevant code from vhost_user.c to trans_af_unix.c and exposes this functionality via transport-specific functions. Any other vhost-user transport could potentially implement this f

[dpdk-dev] [PATCH 17/28] vhost: support registering additional vhost-user transports

2019-06-19 Thread Nikos Dragazis
This patch introduces a global transport map which will hold pointers to the transport-specific operations of all the available transports. The AF_UNIX transport is supported by default. More transports can be hooked up by implementing struct vhost_transport_ops and registering this structure to th

[dpdk-dev] [PATCH 18/28] drivers/virtio_vhost_user: add virtio PCI framework

2019-06-19 Thread Nikos Dragazis
The virtio-vhost-user transport requires a driver for the virtio-vhost-user PCI device, hence it needs a virtio-pci driver. There is currently no librte_virtio API that we can use. This commit is a hack that duplicates the virtio pci code from drivers/net/ into drivers/virtio_vhost_user/. A bett

[dpdk-dev] [PATCH 19/28] vhost: add index field in vhost virtqueues

2019-06-19 Thread Nikos Dragazis
From: Stefan Hajnoczi Currently, the only way of determining a struct vhost_virtqueue's index is to search struct virtio_net->virtqueue[] for its address. Stash the index in struct vhost_virtqueue so we won't have to search the array. This new field will be used by virtio-vhost-user. Signed-of

[dpdk-dev] [PATCH 20/28] drivers: add virtio-vhost-user transport

2019-06-19 Thread Nikos Dragazis
This patch introduces the virtio-vhost-user transport. This transport is based on the virtio-vhost-user device. This device replaces the AF_UNIX socket used by the vhost-user protocol with a virtio device that tunnels vhost-user protocol messages. This allows a guest to act as a vhost device backe

[dpdk-dev] [PATCH 21/28] drivers/virtio_vhost_user: use additional device resources

2019-06-19 Thread Nikos Dragazis
Enhance the virtio-vhost-user device driver so that it utilizes the device's additional resource capabilities. In specific, this patch adds support for the doorbells and shared_memory capabilities. The former is used to find the location of the device doorbells. The latter is used to find the locat

[dpdk-dev] [PATCH 22/28] vhost: add flag for choosing vhost-user transport

2019-06-19 Thread Nikos Dragazis
Extend the API to support the virtio-vhost-user transport as an alternative to the AF_UNIX transport. The caller provides a PCI DomBDF address: rte_vhost_driver_register(":00:04.0", RTE_VHOST_USER_VIRTIO_TRANSPORT); Signed-off-by: Nikos Dragazis Signed-off-by:

[dpdk-dev] [PATCH 23/28] net/vhost: add virtio-vhost-user support

2019-06-19 Thread Nikos Dragazis
The new virtio-transport=0|1 argument enables virtio-vhost-user support: testpmd ... --pci-whitelist :00:04.0 \ --vdev vhost,iface=:00:04.0,virtio-transport=1 Signed-off-by: Nikos Dragazis Signed-off-by: Stefan Hajnoczi --- drivers/net/vhost/rte_eth_vhost.c | 13 +++

[dpdk-dev] [PATCH 24/28] examples/vhost_scsi: add --socket-file argument

2019-06-19 Thread Nikos Dragazis
From: Stefan Hajnoczi The default filename built into examples/vhost_scsi may not be convenient. Allow the user to specify the full UNIX domain socket path on the command-line. Signed-off-by: Stefan Hajnoczi --- examples/vhost_scsi/vhost_scsi.c | 93 1

[dpdk-dev] [PATCH 26/28] mk: link apps with virtio-vhost-user driver

2019-06-19 Thread Nikos Dragazis
Export the virtio-vhost-user transport to all the apps. Support using the virtio-vhost-user transport with shared libraries by unconditionally linking librte_virtio_vhost_user.so with the apps. Signed-off-by: Nikos Dragazis --- mk/rte.app.mk | 6 ++ 1 file changed, 6 insertions(+) diff --gi

[dpdk-dev] [PATCH 25/28] examples/vhost_scsi: add virtio-vhost-user support

2019-06-19 Thread Nikos Dragazis
From: Stefan Hajnoczi The new --virtio-vhost-user-pci command-line argument uses virtio-vhost-user instead of the default AF_UNIX transport. Signed-off-by: Stefan Hajnoczi --- examples/vhost_scsi/vhost_scsi.c | 14 +++--- 1 file changed, 11 insertions(+), 3 deletions(-) diff --git a/e

[dpdk-dev] [PATCH 27/28] config: add option for the virtio-vhost-user transport

2019-06-19 Thread Nikos Dragazis
Add a configuration option for compiling and linking with the virtio-vhost-user library. Signed-off-by: Nikos Dragazis --- config/common_base | 6 ++ config/common_linux | 1 + drivers/Makefile| 5 - mk/rte.app.mk | 2 +- 4 files changed, 12 insertions(+), 2 deletions(-) diff

[dpdk-dev] [PATCH 28/28] usertools: add virtio-vhost-user devices to dpdk-devbind.py

2019-06-19 Thread Nikos Dragazis
The virtio-vhost-user PCI adapter is not detected in any existing group of devices supported by dpdk-devbind.py. Add a new "Others" group for miscellaneous devices like this one. Signed-off-by: Nikos Dragazis Signed-off-by: Stefan Hajnoczi --- usertools/dpdk-devbind.py | 7 +++ 1 file chan

[dpdk-dev] [PATCH v3 00/69] shared code update

2019-06-19 Thread Leyi Rong
Main changes: 1. Advanced switch rule support. 2. Add more APIs for tunnel management. 3. Add some minor features. 4. Code clean and bug fix. --- v3: - Drop some patches which do not used. - Split some patches which include irrelevant code. - Squash some patches which needs to be put together. - A

[dpdk-dev] [PATCH v3 01/69] net/ice/base: update standard extr seq to include DIR flag

2019-06-19 Thread Leyi Rong
Once upon a time, the ice_flow_create_xtrct_seq() function in ice_flow.c extracted only protocol fields explicitly specified by the caller of the ice_flow_add_prof() function via its struct ice_flow_seg_info instances. However, to support different ingress and egress flow profiles with the same mat

[dpdk-dev] [PATCH v3 02/69] net/ice/base: add API to configure MIB

2019-06-19 Thread Leyi Rong
Decouple ice_cfg_lldp_mib_change from the ice_init_dcb function call. Signed-off-by: Chinh T Cao Signed-off-by: Paul M Stillwell Jr Signed-off-by: Leyi Rong --- drivers/net/ice/base/ice_dcb.c | 38 ++ drivers/net/ice/base/ice_dcb.h | 3 ++- 2 files changed, 36

[dpdk-dev] [PATCH v3 03/69] net/ice/base: add another valid DCBx state

2019-06-19 Thread Leyi Rong
When a port is not cabled, but DCBx is enabled in the firmware, the status of DCBx will be NOT_STARTED. This is a valid state for FW enabled and should not be treated as a is_fw_lldp true automatically. Add the code to treat NOT_STARTED as another valid state. Signed-off-by: Dave Ertman Signed-o

[dpdk-dev] [PATCH v3 04/69] net/ice/base: add more recipe commands

2019-06-19 Thread Leyi Rong
Add the Add Recipe (0x0290), Recipe to Profile (0x0291), Get Recipe (0x0292) and Get Recipe to Profile (0x0293) Commands. Signed-off-by: Lev Faerman Signed-off-by: Paul M Stillwell Jr Signed-off-by: Leyi Rong --- drivers/net/ice/base/ice_adminq_cmd.h | 73 +++ 1 file ch

[dpdk-dev] [PATCH v3 05/69] net/ice/base: add funcs to create new switch recipe

2019-06-19 Thread Leyi Rong
Add functions to support following admin queue commands: 1. 0x0208: allocate resource to hold a switch recipe. This is needed when a new switch recipe needs to be created. 2. 0x0290: create a recipe with protocol header information and other details that determine how this recipe filter work. 3. 0x

[dpdk-dev] [PATCH v3 06/69] net/ice/base: programming a new switch recipe

2019-06-19 Thread Leyi Rong
1. Added an interface to support adding advanced switch rules. 2. Advanced rules are provided in a form of protocol headers and values to match in addition to actions (limited actions are current supported). 3. Retrieve field vectors for ICE configuration package to determine extracted fields and e

[dpdk-dev] [PATCH v3 07/69] net/ice/base: replay advanced rule after reset

2019-06-19 Thread Leyi Rong
Code added to replay the advanced rule per VSI basis and remove the advanced rule information from shared code recipe list. Signed-off-by: Victor Raj Signed-off-by: Paul M Stillwell Jr Signed-off-by: Leyi Rong --- drivers/net/ice/base/ice_switch.c | 81 ++- 1 file c

[dpdk-dev] [PATCH v3 08/69] net/ice/base: code for removing advanced rule

2019-06-19 Thread Leyi Rong
This patch also contains ice_remove_adv_rule function to remove existing advanced rules. it also handles the case when we have multiple VSI using the same rule using the following helper functions: ice_adv_rem_update_vsi_list - function to remove VS from VSI list for advanced rules. Signed-off-by

[dpdk-dev] [PATCH v3 09/69] net/ice/base: save and post reset replay q bandwidth

2019-06-19 Thread Leyi Rong
Added code to save the queue bandwidth information when it is applied and it is replayed when queue is re-enabled again. Earlier saved value is used for replay purpose. Added vsi_handle, tc, and q_handle argument to the ice_cfg_q_bw_lmt, ice_cfg_q_bw_dflt_lmt. Signed-off-by: Tarun Singh Signed-of

[dpdk-dev] [PATCH v3 10/69] net/ice/base: rollback AVF RSS configurations

2019-06-19 Thread Leyi Rong
Adding support to remove RSS configurations added prior to failing case in AVF. Signed-off-by: Vignesh Sridhar Signed-off-by: Paul M Stillwell Jr Signed-off-by: Leyi Rong --- drivers/net/ice/base/ice_flow.c | 128 1 file changed, 128 insertions(+) diff --git a

[dpdk-dev] [PATCH v3 11/69] net/ice/base: move RSS replay list

2019-06-19 Thread Leyi Rong
1. Move the RSS list pointer and lock from the VSI context to the ice_hw structure. This is to ensure that the RSS configurations added to the list prior to reset and maintained until the PF is unloaded. This will ensure that the configuration list is unaffected by VFRs that would destroy the VSI c

[dpdk-dev] [PATCH v3 12/69] net/ice/base: cache the data of set PHY cfg AQ in SW

2019-06-19 Thread Leyi Rong
After the transition from cable-unplug to cable-plug events, FW will clear the set-phy-cfg data, sent by user. Thus, we will need to cache these info. 1. The submitted data when set-phy-cfg is called. This info will be used later to check if FW clears out the PHY info, requested by user. 2. The FC,

[dpdk-dev] [PATCH v3 13/69] net/ice/base: refactor HW table init function

2019-06-19 Thread Leyi Rong
1. Separated the calls to initialize and allocate the HW XLT tables from call to fill table. This is to allow the ice_init_hw_tbls call to be made prior to package download so that all HW structures are correctly initialized. This will avoid any invalid memory references if package download fails o

[dpdk-dev] [PATCH v3 14/69] net/ice/base: add lock around profile map list

2019-06-19 Thread Leyi Rong
Add locking mechanism around profile map list. Signed-off-by: Dan Nowlin Signed-off-by: Paul M Stillwell Jr Signed-off-by: Leyi Rong --- drivers/net/ice/base/ice_flex_pipe.c | 62 +--- drivers/net/ice/base/ice_flex_type.h | 5 ++- 2 files changed, 49 insertions(+), 18

[dpdk-dev] [PATCH v3 15/69] net/ice/base: add compatibility check for package version

2019-06-19 Thread Leyi Rong
1. Perform a check against the package version to make sure that it will be compatible with the shared code implementation. There will be points in time when the shared code and package will need to be changed in lock step; the mechanism added here is meant to deal with those situations. 2. Support

[dpdk-dev] [PATCH v3 16/69] net/ice/base: add API to init FW logging

2019-06-19 Thread Leyi Rong
In order to initialize the current status of the FW logging, the api ice_get_fw_log_cfg is added. The function retrieves the current setting of the FW logging from HW and updates the ice_hw structure accordingly. Signed-off-by: Dan Nowlin Signed-off-by: Paul M Stillwell Jr Signed-off-by: Leyi Ro

[dpdk-dev] [PATCH v3 17/69] net/ice/base: use macro instead of magic 8

2019-06-19 Thread Leyi Rong
Replace the use of the magic number 8 by BITS_PER_BYTE when calculating the number of bits from the number of bytes. Signed-off-by: Bruce Allan Signed-off-by: Paul M Stillwell Jr Signed-off-by: Leyi Rong Acked-by: Maxime Coquelin --- drivers/net/ice/base/ice_flex_pipe.c | 4 +- drivers/net/i

[dpdk-dev] [PATCH v3 18/69] net/ice/base: move and redefine ice debug cq API

2019-06-19 Thread Leyi Rong
The ice_debug_cq function is only called from ice_controlq.c, and has no other callers outside of that file. Move it and mark it static to avoid namespace pollution. Signed-off-by: Jacob Keller Signed-off-by: Paul M Stillwell Jr Signed-off-by: Leyi Rong --- drivers/net/ice/base/ice_common.c

[dpdk-dev] [PATCH v3 19/69] net/ice/base: separate out control queue lock creation

2019-06-19 Thread Leyi Rong
The ice_init_all_ctrlq and ice_shutdown_all_ctrlq functions create and destroy the locks used to protect the send and receive process of each control queue. Signed-off-by: Jacob Keller Signed-off-by: Paul M Stillwell Jr Signed-off-by: Leyi Rong --- drivers/net/ice/base/ice_common.c | 6 +-

Re: [dpdk-dev] [PATCH v6] baseband/fpga_lte_fec: adding driver for FEC on FPGA

2019-06-19 Thread Chautru, Nicolas
>-Original Message- >From: Chautru, Nicolas >Sent: Friday, June 14, 2019 9:18 AM >To: akhil.go...@nxp.com; dev@dpdk.org vCc: Yigit, Ferruh ; tho...@monjalon.net; Mokhtar, Amr ; Chalupnik, KamilX ; Chautru, Nicolas >Subject: [PATCH v6] baseband/fpga_lte_fec: adding driver for FEC on FP

[dpdk-dev] [PATCH v3 20/69] net/ice/base: added sibling head to parse nodes

2019-06-19 Thread Leyi Rong
There was a bug in the previous code which never traverses all the children to get the first node of the requested layer. Added a sibling head pointer to point the first node of each layer per TC. This helps the traverse easy and quicker and also removed the recursive, complexity of the code. Sig

  1   2   3   >