Re: [dpdk-dev] [PATCH v8 1/5] mempool: populate mempool with page sized chunks of memory

2019-07-24 Thread Vamsi Krishna Attunuru
> -Original Message- > From: Andrew Rybchenko > Sent: Wednesday, July 24, 2019 1:04 AM > To: Vamsi Krishna Attunuru ; dev@dpdk.org > Cc: tho...@monjalon.net; Jerin Jacob Kollanukkaran ; > olivier.m...@6wind.com; ferruh.yi...@intel.com; anatoly.bura...@intel.com; > Kiran Kumar Kokkilagadd

Re: [dpdk-dev] [PATCH v8 0/5] kni: add IOVA=VA support

2019-07-24 Thread Vamsi Krishna Attunuru
Ping, Req for V8 review comments.. > -Original Message- > From: vattun...@marvell.com > Sent: Tuesday, July 23, 2019 11:08 AM > To: dev@dpdk.org > Cc: tho...@monjalon.net; Jerin Jacob Kollanukkaran ; > olivier.m...@6wind.com; ferruh.yi...@intel.com; anatoly.bura...@intel.com; > arybche..

Re: [dpdk-dev] [dpdk-stable] [PATCH] net/pcap: fix issue with unnecessary mbufs freeing

2019-07-24 Thread David Marchand
On Thu, Jul 11, 2019 at 4:00 PM A.McLoughlin wrote: > > In the eth_pcap_tx() and eth_pcap_tx_dumper() functions mbufs were freed > without incrementing num_tx. To fix the issue, the mbuf freeing was > removed as it was not of any benefit. > > Fixes: 6db141c91e1f ("pcap: support jumbo frames") > Cc

Re: [dpdk-dev] [PATCH v8 1/5] mempool: populate mempool with page sized chunks of memory

2019-07-24 Thread Andrew Rybchenko
On 7/24/19 10:09 AM, Vamsi Krishna Attunuru wrote: -Original Message- From: Andrew Rybchenko Sent: Wednesday, July 24, 2019 1:04 AM To: Vamsi Krishna Attunuru ; dev@dpdk.org Cc: tho...@monjalon.net; Jerin Jacob Kollanukkaran ; olivier.m...@6wind.com; ferruh.yi...@intel.com; anatoly.bur

[dpdk-dev] [PATCH] net/ice: add vni/tni support for flow inputset match

2019-07-24 Thread Wang Ying A
For VXLAN/NVGRE packet, vni/tni should be included in the matching keys. This patch fixes this issue. Fixes: d76116a4678f ("net/ice: add generic flow API") Cc: sta...@dpdk.org Signed-off-by: Wang Ying A --- drivers/net/ice/ice_generic_flow.c | 8 drivers/net/ice/ice_generic_flow.h | 1

Re: [dpdk-dev] [PATCH v3 0/5] use WFE for locks and ring on aarch64

2019-07-24 Thread Thomas Monjalon
24/07/2019 04:44, Honnappa Nagarahalli: > > 23/07/2019 21:15, Honnappa Nagarahalli: > > > Hi Gavin, > > > I think this should have been V1 (I mean, no versioning, just 'PATCH'), > > since it is converted to patch. I think we should be able to resend it as > > V1 and > > mark this V3 as 'supersed

Re: [dpdk-dev] x552 transmit issue and rte_ethtool - rte_ethtool_get_regs()

2019-07-24 Thread Ananyev, Konstantin
Hi Mike, > Konstantin, > > The recommended use of rte_eth_tx_prepare() had no effect, which after > looking at it, makes sense. We are using "large" mbufs to support > Jumbo frames, so nb-seg will always == 1. Additionally, we are not currently > leveraging any HW offload capabilities. As such,

Re: [dpdk-dev] [PATCH] net/mlx5: fix Rx queue release of resources

2019-07-24 Thread Raslan Darawsheh
Hi Dekel, > -Original Message- > From: dev On Behalf Of Dekel Peled > Sent: Tuesday, July 23, 2019 6:35 PM > To: Yongseok Koh ; Slava Ovsiienko > ; Shahaf Shuler > Cc: Ori Kam ; dev@dpdk.org > Subject: [dpdk-dev] [PATCH] net/mlx5: fix Rx queue release of resources > > Function rxq_relea

Re: [dpdk-dev] [PATCH] net/mlx5: fix doorbell release on Rx queue release

2019-07-24 Thread Raslan Darawsheh
Hi Dekel, > -Original Message- > From: dev On Behalf Of Dekel Peled > Sent: Tuesday, July 23, 2019 5:55 PM > To: Yongseok Koh ; Slava Ovsiienko > ; Shahaf Shuler > Cc: Ori Kam ; dev@dpdk.org > Subject: [dpdk-dev] [PATCH] net/mlx5: fix doorbell release on Rx queue > release > > Function

[dpdk-dev] [v2] net/ice: CVL multi-process support

2019-07-24 Thread Xiao Zhang
Add multiple processes support for CVL, secondary processes will share memory and configuration with primary process, do not need further initialization for secondary processes. Cc: sta...@dpdk.org Signed-off-by: Xiao Zhang --- v2 Remove limitation for secondary processes control path configurat

[dpdk-dev] [PATCH v4 0/1] fbarray: get fbarrays from containerized secondary

2019-07-24 Thread yasufum . o
From: Yasufumi Ogawa In secondary_msl_create_walk(), it creates a file for fbarrays with its PID for reserving unique name among secondary processes. However, it does not work if secondary is run as app container because each of containerized secondary has PID 1. To reserve unique name, use hostn

[dpdk-dev] [PATCH v4 1/1] fbarray: get fbarrays from containerized secondary

2019-07-24 Thread yasufum . o
From: Yasufumi Ogawa In secondary_msl_create_walk(), it creates a file for fbarrays with its PID for reserving unique name among secondary processes. However, it does not work if secondary is run as app container because each of containerized secondary has PID 1. To reserve unique name, use hostn

[dpdk-dev] [PATCH v3] net/i40e: fix request queue fail in VF

2019-07-24 Thread taox . zhu
From: Zhu Tao When the VF configuration is larger than the number of queues reserved by PF, VF sends the request queue command through admin queue. When PF received this command, it may reset the VF and send a notification before resetting. If this notification is read by the timed task alarm, Ta

Re: [dpdk-dev] [PATCH v1 0/4] Replace license text with SPDX tag for intel drivers

2019-07-24 Thread Bruce Richardson
On Wed, Jul 24, 2019 at 07:30:37PM +0800, Xiaolong Ye wrote: > This patchset replaces the remaining full license headers in a number > of intel driver files with SPDX tags to achieve DPDK-license compliance. > > Xiaolong Ye (4): > net/iavf: replace license text with SPDX tag > net/fm10k: repla

[dpdk-dev] [PATCH] compress/zlib: fix coverity warning

2019-07-24 Thread Adam Dybkowski
Add missing return after setting the error status in case of invalid flush_flag in the operation. The issue was found by the coverity scan as the fin_flush variable, not initialized in such case, was used later in the flow. CID 340859: Uninitialized variables (UNINIT) Fixes: c7b436ec95fd ("comp

[dpdk-dev] [PATCH v1 1/2] lib/crypto: declare crypto asym xform immutable

2019-07-24 Thread Ayuj Verma
Update asym xform usage in cryptodev documentation. Change lib spec to mark xform as const read only pointer which cannot be manipulated once initiallized on session. Signed-off-by: Ayuj Verma --- doc/guides/prog_guide/cryptodev_lib.rst | 10 ++ lib/librte_cryptodev/rte_cryptodev.c

[dpdk-dev] [PATCH v1 0/2] declare crypto asym xform immutable

2019-07-24 Thread Ayuj Verma
Mark asym xform as immutable till lifetime of session. It will save session setup time for PMDs, which doesn't require any manipulation of xform data, by directly using these buffers. * Updated xform type in session init/configure API as constant. * Updated doc with proper transform description.

[dpdk-dev] [PATCH v1 2/2] crypto/openssl: mark asym xform constant

2019-07-24 Thread Ayuj Verma
Marked asym xform as constant. Signed-off-by: Ayuj Verma --- drivers/crypto/openssl/rte_openssl_pmd_ops.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/crypto/openssl/rte_openssl_pmd_ops.c b/drivers/crypto/openssl/rte_openssl_pmd_ops.c index a307c91..022a09

Re: [dpdk-dev] [PATCH v1 0/2] declare crypto asym xform immutable

2019-07-24 Thread Ayuj Verma
+Fiona. From: Ayuj Verma Sent: 24 July 2019 14:21:55 To: akhil.go...@nxp.com Cc: arkadiuszx.kusz...@intel.com ; Shally Verma ; Sunila Sahu ; Kanaka Durga Kotamarthy ; Anoob Joseph ; dev@dpdk.org ; Ayuj Verma Subject: [PATCH v1 0/2] declare crypto asym xform i

[dpdk-dev] [RFC] kni: support allmulticast mode set

2019-07-24 Thread Xiaolong Ye
This patch adds support to allow users enable/disable allmulticast mode for kni interface. This requirement comes from bugzilla 312, more details can refer to: https://bugs.dpdk.org/show_bug.cgi?id=312 Bugzilla ID: 312 Signed-off-by: Xiaolong Ye --- .../prog_guide/kernel_nic_interface.rst

[dpdk-dev] [PATCH v2] net/mlx5: fix Rx queue release of resources

2019-07-24 Thread Dekel Peled
Function rxq_release_rq_resources() releases resources of RQ object created by DevX API. This patch updates this function to properly clear the released resources, to avoid repeated release of the same resource. Fixes: 69abf7b1db4a ("net/mlx5: create advanced RxQ using new API") Signed-off-by: D

[dpdk-dev] [PATCH v2] net/mlx5: fix doorbell release on Rx queue release

2019-07-24 Thread Dekel Peled
Function mlx5_rxq_release() calls mlx5_release_dbr() to release the doorbell allocated for this Rx queue. This call is relevant only for Rx queue objects created using DevX API. This patch adds the required check, to call mlx5_release_dbr() only when relevant. It also updates mlx5_release_dbr() to

Re: [dpdk-dev] [PATCH] pci: fix missing pci bus with shared library build

2019-07-24 Thread Bruce Richardson
On Tue, Jul 23, 2019 at 11:11:14AM -0700, Stephen Hemminger wrote: > On Tue, 23 Jul 2019 13:30:33 +0100 > Bruce Richardson wrote: > > > On Mon, Jul 22, 2019 at 11:53:26AM -0700, Stephen Hemminger wrote: > > > On Mon, 22 Jul 2019 19:31:08 +0200 > > > Thomas Monjalon wrote: > > > > > > > 22/07/

[dpdk-dev] [PATCH] app/crypto-perf: disable asymmetric crypto

2019-07-24 Thread Anoob Joseph
Asymmetric crypto is not required for test-crypto-perf application. Disabling the feature using 'ff_disable' field. Signed-off-by: Anoob Joseph --- app/test-crypto-perf/main.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/app/test-crypto-perf/main.c b/app/test-crypto-perf

[dpdk-dev] [PATCH v3] net/mlx5: fix doorbell release on Rx queue release

2019-07-24 Thread Dekel Peled
Function mlx5_rxq_release() calls mlx5_release_dbr() to release the doorbell allocated for this Rx queue. This call is relevant only for Rx queue objects created using DevX API. This patch adds the required check, to call mlx5_release_dbr() only when relevant. It also updates mlx5_release_dbr() to

[dpdk-dev] [PATCH v3] net/mlx5: fix Rx queue release of resources

2019-07-24 Thread Dekel Peled
Function rxq_release_rq_resources() releases resources of RQ object created by DevX API. This patch updates this function to properly clear the released resources, to avoid repeated release of the same resource. Fixes: 13f4e1b32137 ("net/mlx5: create advanced RxQ using new API") --- v3: Use adeq

Re: [dpdk-dev] [PATCH] doc: add deprecation notice to fix ethdev API returning void

2019-07-24 Thread Jerin Jacob Kollanukkaran
> -Original Message- > From: dev On Behalf Of Andrew Rybchenko > Sent: Tuesday, July 23, 2019 7:38 PM > To: Thomas Monjalon ; Ferruh Yigit > > Cc: dev@dpdk.org > Subject: [dpdk-dev] [PATCH] doc: add deprecation notice to fix ethdev API > returning void > > void return value is bad for ge

Re: [dpdk-dev] [PATCH] app/crypto-perf: disable asymmetric crypto

2019-07-24 Thread Shally Verma
> -Original Message- > From: Anoob Joseph > Sent: Wednesday, July 24, 2019 2:34 PM > To: Akhil Goyal ; Declan Doherty > ; Pablo de Lara > > Cc: Anoob Joseph ; Jerin Jacob Kollanukkaran > ; Narayana Prasad Raju Athreya > ; Shally Verma ; > dev@dpdk.org > Subject: [PATCH] app/crypto-perf

Re: [dpdk-dev] [RFC] doc: deprecate legacy code path in ipsec-secgw

2019-07-24 Thread Akhil Goyal
Hi Bernard, > All the functionality of the legacy code path in now available in > the librte_ipsec library. It is planned to deprecate the legacy > code path in the 19.11 release and remove the legacy code path in > the 20.02 release. > > Signed-off-by: Bernard Iremonger > --- > doc/guides/rel_

Re: [dpdk-dev] [PATCH v4 1/1] fbarray: get fbarrays from containerized secondary

2019-07-24 Thread Burakov, Anatoly
On 24-Jul-19 9:20 AM, yasufu...@gmail.com wrote: From: Yasufumi Ogawa In secondary_msl_create_walk(), it creates a file for fbarrays with its PID for reserving unique name among secondary processes. However, it does not work if secondary is run as app container because each of containerized sec

[dpdk-dev] [PATCH v2] eal: fix proc type auto detection

2019-07-24 Thread Anatoly Burakov
Currently, primary process holds an exclusive lock on the config file, thereby preventing other primaries from spinning up. However, when the primary dies, the lock is no longer being held, even though there might be other secondary processes still running. The fix is two-fold. First of all, downg

[dpdk-dev] [PATCH] doc: deprecate legacy code path in ipsec-secgw

2019-07-24 Thread Bernard Iremonger
All the functionality of the legacy code path in now available in the librte_ipsec library. It is planned to deprecate the legacy code path in the 19.11 release and remove the legacy code path in the 20.02 release. Signed-off-by: Bernard Iremonger Acked-by: Konstantin Ananyev Acked-by: Fan Zhang

Re: [dpdk-dev] [PATCH] doc: deprecate legacy code path in ipsec-secgw

2019-07-24 Thread Akhil Goyal
+Anoob, Jerin > > All the functionality of the legacy code path in now available in > the librte_ipsec library. It is planned to deprecate the legacy > code path in the 19.11 release and remove the legacy code path in > the 20.02 release. > > Signed-off-by: Bernard Iremonger > Acked-by: Konstan

[dpdk-dev] [PATCH v1] test/crypto: improve asymmetric crypto testsuite setup

2019-07-24 Thread Ayuj Verma
Improve logic: * to get list of valid devices based on driver id so that to eliminate unnecessary if check for driver id match in device loop * loop till 1st device supporting asymmetric feature is found unlike previous logic which breaks on 1st device Ayuj Verma (1): test/crypto: im

[dpdk-dev] [PATCH v1] test/crypto: improve asymmetric crypto testsuite setup

2019-07-24 Thread Ayuj Verma
Improve logic: * to get list of valid devices based on driver id so that to eliminate unnecessary if check for driver id match in device loop * loop till 1st device supporting asymmetric feature is found unlike previous logic which breaks on 1st device Signed-off-by: Kanaka Durga Kotam

[dpdk-dev] [PATCH] app/testpmd: fix eth packet dump for small buffers

2019-07-24 Thread David Marchand
In the rather unlikely case where the first segment is too small to contain an ethernet header, we can't go and directly dereference the mbuf data buffer. Using rte_pktmbuf_read is a little more expensive but this is still acceptable for a debugging feature. Fixes: af75078fece3 ("first public rel

Re: [dpdk-dev] [PATCH v3] net/mlx5: fix Rx queue release of resources

2019-07-24 Thread Raslan Darawsheh
Hi, > -Original Message- > From: dev On Behalf Of Dekel Peled > Sent: Wednesday, July 24, 2019 12:05 PM > To: Yongseok Koh ; Slava Ovsiienko > ; Shahaf Shuler > Cc: Ori Kam ; dev@dpdk.org > Subject: [dpdk-dev] [PATCH v3] net/mlx5: fix Rx queue release of resources > > Function rxq_relea

Re: [dpdk-dev] [PATCH v3] net/mlx5: fix doorbell release on Rx queue release

2019-07-24 Thread Raslan Darawsheh
Hi, > -Original Message- > From: dev On Behalf Of Dekel Peled > Sent: Wednesday, July 24, 2019 12:05 PM > To: Yongseok Koh ; Slava Ovsiienko > ; Shahaf Shuler > Cc: Ori Kam ; dev@dpdk.org > Subject: [dpdk-dev] [PATCH v3] net/mlx5: fix doorbell release on Rx queue > release > > Function

[dpdk-dev] [PATCH] net/mlx5: fix RSS expand for IP-in-IP

2019-07-24 Thread Xiaoyu Min
The RSS expand function for IP-in-IP tunnel type is missed, which leads to create following flow failed: flow create 0 ingress pattern eth / ipv4 proto is 4 / ipv4 / udp / end actions rss queues 0 1 end level 2 types ip ipv4-other udp ipv4 ipv4-frag end / mark id 221 / c

Re: [dpdk-dev] [EXT] [PATCH v3 1/5] eal: add the APIs to wait until equal

2019-07-24 Thread Jerin Jacob Kollanukkaran
> -Original Message- > From: Gavin Hu > Sent: Tuesday, July 23, 2019 9:14 PM > To: dev@dpdk.org > Cc: n...@arm.com; tho...@monjalon.net; step...@networkplumber.org; > Jerin Jacob Kollanukkaran ; Pavan Nikhilesh > Bhagavatula ; > honnappa.nagaraha...@arm.com; gavin...@arm.com > Subject: [EX

[dpdk-dev] [PATCH 0/3] Multiseg fixes for pcap pmd

2019-07-24 Thread David Marchand
Here are some fixes caught while looking at oerrors statistics for this driver. The second patch can be seen as a revert or a followup of [1]. 1: https://git.dpdk.org/dpdk/commit/?id=49a0a2ffd5db -- David Marchand David Marchand (3): net/pcap: fix Rx with small buffers net/pcap: fix transmi

[dpdk-dev] [PATCH 1/3] net/pcap: fix Rx with small buffers

2019-07-24 Thread David Marchand
If the pkt pool contains only buffers smaller than the default headroom, then the driver will compute an invalid buffer size (negative value cast to an uint16_t). Rely on the mbuf api to check how much space is available in the mbuf. Fixes: 6eb0ae218a98 ("pcap: fix mbuf allocation") Cc: sta...@dpd

[dpdk-dev] [PATCH 2/3] net/pcap: fix transmit return count in error conditions

2019-07-24 Thread David Marchand
When a packet cannot be transmitted, the driver is supposed to free this packet and report it as handled. This is to prevent the application from retrying to send the same packet and ending up in a liveloop since the driver will never manage to send it. Fixes: 49a0a2ffd5db ("net/pcap: fix possible

[dpdk-dev] [PATCH 3/3] net/pcap: fix concurrent multiseg packet transmits

2019-07-24 Thread David Marchand
Two cores can send multi segment packets on two different pcap ports. Because of this, we can't have one single buffer to linearize packets. Use rte_pktmbuf_read() to copy the packet into a buffer on the stack and remove eth_pcap_gather_data(). Fixes: 6db141c91e1f ("pcap: support jumbo frames") C

[dpdk-dev] [PATCH v2] event/octeontx2: fix NULL dereference

2019-07-24 Thread pbhagavatula
From: Pavan Nikhilesh Fix NULL dereference after rte_realloc and add extra NULL checks. Fix few memory leak with kvargs. Coverity issue: 345023, 345022, 345009, 345011, 345026, 344997, 344990 Fixes: ffa4ec0b6063 ("event/octeontx2: allow adapters to resize inflight buffers") Signed-off-by: Pava

Re: [dpdk-dev] [EXT] [PATCH v3 4/5] spinlock: use wfe to reduce contention on aarch64

2019-07-24 Thread Jerin Jacob Kollanukkaran
> -Original Message- > From: Gavin Hu > Sent: Tuesday, July 23, 2019 9:14 PM > To: dev@dpdk.org > Cc: n...@arm.com; tho...@monjalon.net; step...@networkplumber.org; > Jerin Jacob Kollanukkaran ; Pavan Nikhilesh > Bhagavatula ; > honnappa.nagaraha...@arm.com; gavin...@arm.com > Subject: [EX

Re: [dpdk-dev] [EXT] [PATCH v3 5/5] config: add WFE config entry for aarch64

2019-07-24 Thread Jerin Jacob Kollanukkaran
> -Original Message- > From: Gavin Hu > Sent: Tuesday, July 23, 2019 9:14 PM > To: dev@dpdk.org > Cc: n...@arm.com; tho...@monjalon.net; step...@networkplumber.org; > Jerin Jacob Kollanukkaran ; Pavan Nikhilesh > Bhagavatula ; > honnappa.nagaraha...@arm.com; gavin...@arm.com > Subject: [EX

[dpdk-dev] [PATCH] examples/qos_sched: add more tc to red configuration

2019-07-24 Thread Jasvinder Singh
Add RED configuration to more traffic classes in app configuration files. Signed-off-by: Jasvinder Singh --- examples/qos_sched/profile.cfg| 20 examples/qos_sched/profile_ov.cfg | 20 2 files changed, 40 insertions(+) diff --git a/examples/qos_sche

Re: [dpdk-dev] [PATCH v3] net/i40e: fix request queue fail in VF

2019-07-24 Thread Zhang, Qi Z
> -Original Message- > From: Zhu, TaoX > Sent: Wednesday, July 24, 2019 4:33 PM > To: Xing, Beilei ; Zhang, Qi Z > Cc: dev@dpdk.org; Zhu, TaoX ; sta...@dpdk.org > Subject: [PATCH v3] net/i40e: fix request queue fail in VF > > From: Zhu Tao > > When the VF configuration is larger than

[dpdk-dev] [PATCH 1/3] net/sfc: fix power of 2 round up when align has smaller type

2019-07-24 Thread Andrew Rybchenko
Substitute driver-defined P2ROUNDUP() h with EFX_P2ROUNDUP() defined in libefx. Cast value and alignment to one specified type to guarantee result correctness. Fixes: e1b944598579 ("net/sfc: build libefx") Cc: sta...@dpdk.org Signed-off-by: Andrew Rybchenko --- drivers/net/sfc/base/ef10_impl.h

[dpdk-dev] [PATCH 0/3] net/sfc: fix power of 2 alignment macros

2019-07-24 Thread Andrew Rybchenko
P2ROUNDUP() and P2ALIGN() macros are buggy when alignment type is smaller than type of the value to be aligned. IS_P2ALIGNED() has no the problem since it cast its arugments to uintptr_t inside, but fixed anyway to follow the same approach as new EFX_P2ROUNDUP() and EFX_P2ALIGN(). Patches have ch

[dpdk-dev] [PATCH 2/3] net/sfc: fix align to power of 2 when align has smaller type

2019-07-24 Thread Andrew Rybchenko
Substitute driver-defined P2ALIGN() with EFX_P2ALIGN() defined in libefx. Cast value and alignment to one specified type to guarantee result correctness. Fixes: e1b944598579 ("net/sfc: build libefx") Cc: sta...@dpdk.org Signed-off-by: Andrew Rybchenko --- drivers/net/sfc/base/ef10_rx.c | 2 +-

[dpdk-dev] [PATCH 3/3] net/sfc: unify power of 2 alignment check macro

2019-07-24 Thread Andrew Rybchenko
Substitute driver-defined IS_P2ALIGNED() with EFX_IS_P2ALIGNED() defined in libefx. Add type argument and cast value and alignment to one specified type. Fixes: e1b944598579 ("net/sfc: build libefx") Cc: sta...@dpdk.org Signed-off-by: Andrew Rybchenko --- drivers/net/sfc/base/ef10_rx.c | 4 ++

Re: [dpdk-dev] [PATCH v2 2/2] net/i40e: fix RSS hash update problem for X722 VF

2019-07-24 Thread Zhang, Qi Z
> -Original Message- > From: Huang, Peng > Sent: Monday, July 22, 2019 9:50 PM > To: Zhang, Qi Z > Cc: dev@dpdk.org; Xing, Beilei ; Huang, Peng > ; sta...@dpdk.org > Subject: [PATCH v2 2/2] net/i40e: fix RSS hash update problem for X722 VF > > This patch fixes X722 VF problem when rece

Re: [dpdk-dev] [PATCH v1] net/ice: remove unnecessary type cast in rx/tx ring setup

2019-07-24 Thread Zhang, Qi Z
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Ye Xiaolong > Sent: Wednesday, July 24, 2019 4:18 PM > To: Wang, Haiyue > Cc: dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v1] net/ice: remove unnecessary type cast in > rx/tx ring setup Should be "Rx/Tx" > >

Re: [dpdk-dev] [PATCH 0/3] net/sfc: fix power of 2 alignment macros

2019-07-24 Thread Andrew Rybchenko
On 7/24/19 3:59 PM, Andrew Rybchenko wrote: P2ROUNDUP() and P2ALIGN() macros are buggy when alignment type is smaller than type of the value to be aligned. IS_P2ALIGNED() has no the problem since it cast its arugments to uintptr_t inside, but fixed anyway to follow the same approach as new EFX_P

Re: [dpdk-dev] [PATCH] net/ice: add vni/tni support for flow inputset match

2019-07-24 Thread Zhang, Qi Z
> -Original Message- > From: Wang, Ying A > Sent: Wednesday, July 24, 2019 7:21 AM > To: Zhang, Qi Z > Cc: Yang, Qiming ; dev@dpdk.org; Wang, Ying A > ; sta...@dpdk.org > Subject: [PATCH] net/ice: add vni/tni support for flow inputset match > > For VXLAN/NVGRE packet, vni/tni should be

[dpdk-dev] [PATCH v2 1/3] net/sfc: fix power of 2 round up when align has smaller type

2019-07-24 Thread Andrew Rybchenko
Substitute driver-defined P2ROUNDUP() h with EFX_P2ROUNDUP() defined in libefx. Cast value and alignment to one specified type to guarantee result correctness. Fixes: e1b944598579 ("net/sfc: build libefx") Cc: sta...@dpdk.org Signed-off-by: Andrew Rybchenko --- drivers/net/sfc/base/ef10_impl.h

[dpdk-dev] [PATCH v2 0/3] net/sfc: fix power of 2 alignment macros

2019-07-24 Thread Andrew Rybchenko
P2ROUNDUP() and P2ALIGN() macros are buggy when alignment type is smaller than type of the value to be aligned. IS_P2ALIGNED() has no the problem since it cast its arugments to uintptr_t inside, but fixed anyway to follow the same approach as new EFX_P2ROUNDUP() and EFX_P2ALIGN(). Patches have ch

[dpdk-dev] [PATCH v2 3/3] net/sfc: unify power of 2 alignment check macro

2019-07-24 Thread Andrew Rybchenko
Substitute driver-defined IS_P2ALIGNED() with EFX_IS_P2ALIGNED() defined in libefx. Add type argument and cast value and alignment to one specified type. Fixes: e1b944598579 ("net/sfc: build libefx") Cc: sta...@dpdk.org Signed-off-by: Andrew Rybchenko --- drivers/net/sfc/base/ef10_rx.c | 4 ++

[dpdk-dev] [PATCH v6 0/1] add extra features to test-compress-perf

2019-07-24 Thread Adam Dybkowski
v6 changes: - replace special bullet characters with normal asterisks v5 changes: - some minor changes (rewording, structure renaming, etc.) v4 changes: - information about compression threads printed on screen v3 changes: - commented code removed v2 changes:

[dpdk-dev] [PATCH v6 1/1] app/test-compress-perf: provide more detailed report

2019-07-24 Thread Adam Dybkowski
From: Artur Trybula This patch adds extra features to the compress performance test. Some important parameters (memory allocation, number of ops, number of segments) are calculated and printed out. Information about threads, cores, devices and queue-pairs is also printed. Signed-off-by: Artur Tr

Re: [dpdk-dev] [PATCH] net/ice: add vni/tni support for flow inputset match

2019-07-24 Thread Zhang, Qi Z
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Zhang, Qi Z > Sent: Wednesday, July 24, 2019 9:07 PM > To: Wang, Ying A > Cc: Yang, Qiming ; dev@dpdk.org; sta...@dpdk.org > Subject: Re: [dpdk-dev] [PATCH] net/ice: add vni/tni support for flow inputset > match

[dpdk-dev] [PATCH v3 1/3] net/sfc: fix power of 2 round up when align has smaller type

2019-07-24 Thread Andrew Rybchenko
Substitute driver-defined P2ROUNDUP() h with EFX_P2ROUNDUP() defined in libefx. Cast value and alignment to one specified type to guarantee result correctness. Fixes: e1b944598579 ("net/sfc: build libefx") Cc: sta...@dpdk.org Signed-off-by: Andrew Rybchenko --- drivers/net/sfc/base/ef10_impl.h

[dpdk-dev] [PATCH v3 0/3] net/sfc: fix power of 2 alignment macros

2019-07-24 Thread Andrew Rybchenko
P2ROUNDUP() and P2ALIGN() macros are buggy when alignment type is smaller than type of the value to be aligned. IS_P2ALIGNED() has no the problem since it cast its arugments to uintptr_t inside, but fixed anyway to follow the same approach as new EFX_P2ROUNDUP() and EFX_P2ALIGN(). Patches have ch

[dpdk-dev] [PATCH v3 2/3] net/sfc: fix align to power of 2 when align has smaller type

2019-07-24 Thread Andrew Rybchenko
Substitute driver-defined P2ALIGN() with EFX_P2ALIGN() defined in libefx. Cast value and alignment to one specified type to guarantee result correctness. Fixes: e1b944598579 ("net/sfc: build libefx") Cc: sta...@dpdk.org Signed-off-by: Andrew Rybchenko --- drivers/net/sfc/base/ef10_rx.c | 2 +-

[dpdk-dev] [PATCH v3 3/3] net/sfc: unify power of 2 alignment check macro

2019-07-24 Thread Andrew Rybchenko
Substitute driver-defined IS_P2ALIGNED() with EFX_IS_P2ALIGNED() defined in libefx. Add type argument and cast value and alignment to one specified type. Fixes: e1b944598579 ("net/sfc: build libefx") Cc: sta...@dpdk.org Signed-off-by: Andrew Rybchenko --- drivers/net/sfc/base/ef10_rx.c | 4 ++

[dpdk-dev] [PATCH v1] examples/power: fix oob frequency oscillations

2019-07-24 Thread David Hunt
The branch ratio algorithm in the vm_power_manager sample application can be very sensitive at patricular loads in a workload, causing oscillations between min and max frequency. For example, if a workload is at 50%, scaling up may change the ratio enough that it immediately thinks it needs to scal

[dpdk-dev] [PATCH v7 0/1] add extra features to test-compress-perf

2019-07-24 Thread Adam Dybkowski
v7 changes: - one more special character replaced with a minus sign v6 changes: - replace special bullet characters with normal asterisks v5 changes: - some minor changes (rewording, structure renaming, etc.) v4 changes: - information about compression threads pri

[dpdk-dev] [PATCH v7 1/1] app/test-compress-perf: provide more detailed report

2019-07-24 Thread Adam Dybkowski
From: Artur Trybula This patch adds extra features to the compress performance test. Some important parameters (memory allocation, number of ops, number of segments) are calculated and printed out. Information about threads, cores, devices and queue-pairs is also printed. Signed-off-by: Artur Tr

[dpdk-dev] [RFC] ethdev: allow multiple security sessions to use one rte flow

2019-07-24 Thread Anoob Joseph
The rte_security API which enables inline protocol/crypto feature mandates that for every security session an rte_flow is created. This would internally translate to a rule in the hardware which would do packet classification. In rte_securty, one SA would be one security session. And if an rte_flo

Re: [dpdk-dev] [PATCH] app/testpmd: fix eth packet dump for small buffers

2019-07-24 Thread Iremonger, Bernard
> -Original Message- > From: David Marchand [mailto:david.march...@redhat.com] > Sent: Wednesday, July 24, 2019 11:59 AM > To: dev@dpdk.org > Cc: olivier.m...@6wind.com; sta...@dpdk.org; Lu, Wenzhuo > ; Wu, Jingjing ; Iremonger, > Bernard > Subject: [PATCH] app/testpmd: fix eth packet dump

Re: [dpdk-dev] [PATCH] examples/qos_sched: add more tc to red configuration

2019-07-24 Thread Dumitrescu, Cristian
> -Original Message- > From: Singh, Jasvinder > Sent: Wednesday, July 24, 2019 1:27 PM > To: dev@dpdk.org > Cc: Dumitrescu, Cristian > Subject: [PATCH] examples/qos_sched: add more tc to red configuration > > Add RED configuration to more traffic classes in app configuration > files. >

[dpdk-dev] [PATCH] Revert "eal: fix parsing option --telemetry"

2019-07-24 Thread Sean Morrissey
This reverts commit debacba0297fbe214b4185a9791e6a9fdf6642ba. Reverting this patch as it currently breaks the initialization of telemetry, more investigation is ongoing to fix the issue for the printed error message for unrecognized argument. --- lib/librte_eal/common/eal_common_options.c | 3 ---

[dpdk-dev] [PATCH v2] Revert "eal: fix parsing option --telemetry"

2019-07-24 Thread Sean Morrissey
This reverts commit debacba0297fbe214b4185a9791e6a9fdf6642ba. Reverting this patch as it currently breaks the initialization of telemetry, more investigation is ongoing to fix the issue for the printed error message for unrecognized argument. Signed-off-by: Sean Morrissey --- v2: Adding sign o

Re: [dpdk-dev] [PATCH v2] Revert "eal: fix parsing option --telemetry"

2019-07-24 Thread Thomas Monjalon
24/07/2019 17:20, Sean Morrissey: > This reverts commit debacba0297fbe214b4185a9791e6a9fdf6642ba. > > Reverting this patch as it currently breaks the initialization of > telemetry, more investigation is ongoing to fix the issue for the > printed error message for unrecognized argument. > > Signed

[dpdk-dev] [PATCH 0/2] Small usability improvements for devbind

2019-07-24 Thread Anatoly Burakov
Over the course of using devbind, i find myself frequently bumping up against two common errors (with the assumption being that i'm not the only person who hits these errors). First happens when i forget to specify the driver. The error message in this case looks something like the following: ana

[dpdk-dev] [PATCH 2/2] usertools/devbind: check if module is loaded before binding

2019-07-24 Thread Anatoly Burakov
Currently, if an attempt is made to bind a device to a driver that is not loaded, a confusing and misleading error message appears. Fix it so that, before binding to the driver, we actually check if it is loaded in the kernel first. Signed-off-by: Anatoly Burakov --- usertools/dpdk-devbind.py |

[dpdk-dev] [PATCH 1/2] usertools/devbind: add error on forgetting to specify driver

2019-07-24 Thread Anatoly Burakov
A common user error is to forget driver to which the PCI devices should be bound to. Currently, the error message in this case looks unhelpful misleading and indecipherable to anyone but people who know how devbind works. Fix this by checking if the driver string is actually a valid device string.

[dpdk-dev] [Bug 335] Compilation fails when HEADROOM is 0

2019-07-24 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=335 Bug ID: 335 Summary: Compilation fails when HEADROOM is 0 Product: DPDK Version: unspecified Hardware: All OS: All Status: UNCONFIRMED Severity: normal P

Re: [dpdk-dev] [Bug 335] Compilation fails when HEADROOM is 0

2019-07-24 Thread Matan Azrad
Hi Hemant, Sachin Looks like issue in dpaa. Please check. > -Original Message- > From: dev On Behalf Of bugzi...@dpdk.org > Sent: Wednesday, July 24, 2019 6:35 PM > To: dev@dpdk.org > Subject: [dpdk-dev] [Bug 335] Compilation fails when HEADROOM is 0 > > https://eur03.safelinks.protecti

[dpdk-dev] [PATCH] test: enable installing test app with meson

2019-07-24 Thread Anatoly Burakov
Currently, the test app is not being installed by default when built and installed with meson build system. Fix that to enable installation of the test app alongside other DPDK apps. Fixes: b5dc795a8a55 ("test: build app with meson as dpdk-test") Cc: harry.van.haa...@intel.com Cc: bruce.richard...

Re: [dpdk-dev] [PATCH] test: enable installing test app with meson

2019-07-24 Thread Bruce Richardson
On Wed, Jul 24, 2019 at 04:47:31PM +0100, Anatoly Burakov wrote: > Currently, the test app is not being installed by default when > built and installed with meson build system. Fix that to enable > installation of the test app alongside other DPDK apps. > > Fixes: b5dc795a8a55 ("test: build app wi

[dpdk-dev] [PATCH v3] eal: fix proc type auto detection

2019-07-24 Thread Anatoly Burakov
Currently, primary process holds an exclusive lock on the config file, thereby preventing other primaries from spinning up. However, when the primary dies, the lock is no longer being held, even though there might be other secondary processes still running. The fix is two-fold. First of all, downg

[dpdk-dev] [PATCH v4] eal: fix proc type auto detection

2019-07-24 Thread Anatoly Burakov
Currently, primary process holds an exclusive lock on the config file, thereby preventing other primaries from spinning up. However, when the primary dies, the lock is no longer being held, even though there might be other secondary processes still running. The fix is two-fold. First of all, downg

Re: [dpdk-dev] [PATCH v1 4/4] net/i40e: replace license text with SPDX tag

2019-07-24 Thread Ferruh Yigit
On 7/24/2019 12:30 PM, Xiaolong Ye wrote: > Signed-off-by: Xiaolong Ye > --- > drivers/net/i40e/i40e_rxtx_vec_altivec.c | 35 ++-- > drivers/net/i40e/i40e_rxtx_vec_avx2.c| 33 ++ > 2 files changed, 5 insertions(+), 63 deletions(-) > > diff --git a/driv

[dpdk-dev] [PATCH] net/bnxt: use dedicated cpr for async events

2019-07-24 Thread Lance Richardson
This commit enables the creation of a dedicated completion ring for asynchronous event handling instead of handling these events on a receive completion ring. For the stingray platform and other platforms needing tighter control of resource utilization, we retain the ability to process async event

Re: [dpdk-dev] [Bug 335] Compilation fails when HEADROOM is 0

2019-07-24 Thread Stephen Hemminger
On Wed, 24 Jul 2019 15:37:40 + Matan Azrad wrote: > Hi Hemant, Sachin > > Looks like issue in dpaa. > Please check. > > > -Original Message- > > From: dev On Behalf Of bugzi...@dpdk.org > > Sent: Wednesday, July 24, 2019 6:35 PM > > To: dev@dpdk.org > > Subject: [dpdk-dev] [Bug 335

Re: [dpdk-dev] [PATCH] app/crypto-perf: disable asymmetric crypto

2019-07-24 Thread Trahe, Fiona
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Anoob Joseph > Sent: Wednesday, July 24, 2019 10:04 AM > To: Akhil Goyal ; Doherty, Declan > ; De Lara Guarch, > Pablo > Cc: Anoob Joseph ; Jerin Jacob ; > Narayana Prasad > ; Shally Verma ; dev@dpdk.org > Sub

Re: [dpdk-dev] [PATCH 2/2] usertools/devbind: check if module is loaded before binding

2019-07-24 Thread Stephen Hemminger
On Wed, 24 Jul 2019 16:34:44 +0100 Anatoly Burakov wrote: > +# check if a specific kernel module is loaded > +def module_is_loaded(module): > +# Get list of sysfs modules (both built-in and dynamically loaded) > +sysfs_path = '/sys/module/' > + > +# Get the list of directories in sysf

Re: [dpdk-dev] [PATCH 1/2] usertools/devbind: add error on forgetting to specify driver

2019-07-24 Thread Stephen Hemminger
On Wed, 24 Jul 2019 16:34:43 +0100 Anatoly Burakov wrote: > A common user error is to forget driver to which the PCI devices should > be bound to. Currently, the error message in this case looks unhelpful > misleading and indecipherable to anyone but people who know how devbind > works. > > Fix

Re: [dpdk-dev] [PATCH] net/bnxt: use dedicated cpr for async events

2019-07-24 Thread Lance Richardson
On Wed, Jul 24, 2019 at 12:14 PM Lance Richardson wrote: > process async events on a receive completion ring. This behavior > is controlled by a compile-time configuration variable. I will follow up with a v2 to correct the above statement in the commit log and to squash with these follow-up pat

Re: [dpdk-dev] [PATCH v2] Revert "eal: fix parsing option --telemetry"

2019-07-24 Thread Morrissey, Sean
Subject: Re: [PATCH v2] Revert "eal: fix parsing option --telemetry" 24/07/2019 17:20, Sean Morrissey: > This reverts commit debacba0297fbe214b4185a9791e6a9fdf6642ba. > > Reverting this patch as it currently breaks the initialization of > telemetry, more investigation is ongoing to fix the iss

Re: [dpdk-dev] [Bug 335] Compilation fails when HEADROOM is 0

2019-07-24 Thread Matan Azrad
From: Stephen Hemminger > Sent: Wednesday, July 24, 2019 7:24 PM > To: Matan Azrad > Cc: Hemant Agrawal ; sachin.sax...@nxp.com; > dev@dpdk.org > Subject: Re: [dpdk-dev] [Bug 335] Compilation fails when HEADROOM is 0 > > On Wed, 24 Jul 2019 15:37:40 + > Matan Azrad wrote: > > > Hi Heman

[dpdk-dev] [PATCH] examples/l3fwd: fix unaligned memory access

2019-07-24 Thread hgovindh
Fix unaligned memory access when reading IPv6 header which leads to segmentation fault by changing aligned memory read to unaligned memory read. Bugzilla ID: 279 Fixes: 64d3955de1de ("examples/l3fwd: fix ARM build") Cc: maciej.cze...@caviumnetworks.com Cc: sta...@dpdk.org Signed-off-by: hgovindh

[dpdk-dev] [PATCH] eal: pick IOVA as PA if IOMMU is not available

2019-07-24 Thread Anatoly Burakov
When IOMMU is not available, /sys/kernel/iommu_groups will not be populated. This is happening since at least 3.6 when VFIO support was added. If the directory is empty, EAL should not pick IOVA as VA as the default IOVA mode. We also assume that VFIO equals IOMMU, so if VFIO support is not compil

Re: [dpdk-dev] [PATCH 2/2] usertools/devbind: check if module is loaded before binding

2019-07-24 Thread Burakov, Anatoly
On 24-Jul-19 5:28 PM, Stephen Hemminger wrote: On Wed, 24 Jul 2019 16:34:44 +0100 Anatoly Burakov wrote: +# check if a specific kernel module is loaded +def module_is_loaded(module): +# Get list of sysfs modules (both built-in and dynamically loaded) +sysfs_path = '/sys/module/' + +

Re: [dpdk-dev] [PATCH v1 0/4] Replace license text with SPDX tag for intel drivers

2019-07-24 Thread Ferruh Yigit
On 7/24/2019 12:30 PM, Xiaolong Ye wrote: > This patchset replaces the remaining full license headers in a number > of intel driver files with SPDX tags to achieve DPDK-license compliance. > > Xiaolong Ye (4): > net/iavf: replace license text with SPDX tag > net/fm10k: replace license text wit

Re: [dpdk-dev] [PATCH 1/2] usertools/devbind: add error on forgetting to specify driver

2019-07-24 Thread Burakov, Anatoly
On 24-Jul-19 5:29 PM, Stephen Hemminger wrote: On Wed, 24 Jul 2019 16:34:43 +0100 Anatoly Burakov wrote: A common user error is to forget driver to which the PCI devices should be bound to. Currently, the error message in this case looks unhelpful misleading and indecipherable to anyone but pe

[dpdk-dev] [[PATCH v2]] net/bnxt: use dedicated cpr for async events

2019-07-24 Thread Lance Richardson
This commit enables the creation of a dedicated completion ring for asynchronous event handling instead of handling these events on a receive completion ring. For the stingray platform and other platforms needing tighter control of resource utilization, we retain the ability to process async event

  1   2   >