[dpdk-dev] [PATCH v2 1/2] bus: fix missing pci bus with shared library build

2019-07-26 Thread Stephen Hemminger
If DPDK is built as a shared library, then any application linked with rte.app.mk will not find any buses (including PCI devices). This is because the linker will not call the initializers of the bus libraries since they are not directly called by application or EAL. Bugzilla ID: 333 Fixes: c7529

[dpdk-dev] [PATCH v2 2/2] mk: fix missing mempool driver registration

2019-07-26 Thread Stephen Hemminger
Since mempool driver is now registered during constructor, the mempool driver must always be linked in during shared library build. Otherwise, application will fail because of missing default mbuf pool operations. Fixes: c6b3570f9e14 ("mk: link app with ring mempool by default") Cc: sta...@dpdk.or

[dpdk-dev] [PATCH] maintainers: add co-maintainer to sched library

2019-07-26 Thread Jasvinder Singh
Add myself as a co-maintainer to dpdk sched library. Signed-off-by: Jasvinder Singh --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index c2b575a94..fa4bad88a 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -1202,6 +1202,7 @@ F: doc/guides/sample_app_u

[dpdk-dev] [PATCH v2 01/11] net/ixgbe: replace license text with SPDX tag

2019-07-26 Thread Xiaolong Ye
Signed-off-by: Xiaolong Ye Acked-by: Bruce Richardson --- drivers/net/ixgbe/base/README | 34 +++--- 1 file changed, 3 insertions(+), 31 deletions(-) diff --git a/drivers/net/ixgbe/base/README b/drivers/net/ixgbe/base/README index 431be0260..b6b420e2f 100644 --- a/dr

[dpdk-dev] [PATCH v2 03/11] net/e1000: replace license text with SPDX tag

2019-07-26 Thread Xiaolong Ye
Signed-off-by: Xiaolong Ye Acked-by: Bruce Richardson --- drivers/net/e1000/base/README | 34 +++--- 1 file changed, 3 insertions(+), 31 deletions(-) diff --git a/drivers/net/e1000/base/README b/drivers/net/e1000/base/README index de1ae4cf7..56738d001 100644 --- a/dr

[dpdk-dev] [PATCH v2 04/11] net/vmxnet3: replace license text with SPDX tag

2019-07-26 Thread Xiaolong Ye
Signed-off-by: Xiaolong Ye Acked-by: Bruce Richardson --- drivers/net/vmxnet3/base/README | 34 +++-- 1 file changed, 3 insertions(+), 31 deletions(-) diff --git a/drivers/net/vmxnet3/base/README b/drivers/net/vmxnet3/base/README index 599a3661e..aaf5d3086 100644 ---

[dpdk-dev] [PATCH v2 05/11] examples/qos_sched: replace license text with SPDX tag

2019-07-26 Thread Xiaolong Ye
Signed-off-by: Xiaolong Ye Acked-by: Bruce Richardson --- examples/qos_sched/profile.cfg| 32 ++- examples/qos_sched/profile_ov.cfg | 32 ++- 2 files changed, 4 insertions(+), 60 deletions(-) diff --git a/examples/qos_sched/profile.cfg

[dpdk-dev] [PATCH v2 10/11] hash: replace license text with SPDX tag

2019-07-26 Thread Xiaolong Ye
Signed-off-by: Xiaolong Ye Acked-by: Bruce Richardson --- lib/librte_hash/rte_jhash.h | 33 ++--- 1 file changed, 2 insertions(+), 31 deletions(-) diff --git a/lib/librte_hash/rte_jhash.h b/lib/librte_hash/rte_jhash.h index 42c45685b..7a1eeff74 100644 --- a/lib/librt

[dpdk-dev] [PATCH v2 06/11] app/test-eventdev: replace license text with SPDX tag

2019-07-26 Thread Xiaolong Ye
Signed-off-by: Xiaolong Ye Acked-by: Bruce Richardson --- app/test-eventdev/parser.c | 35 +++ 1 file changed, 3 insertions(+), 32 deletions(-) diff --git a/app/test-eventdev/parser.c b/app/test-eventdev/parser.c index 9de41bf4a..24f1855e9 100644 --- a/app/test-e

[dpdk-dev] [PATCH v2 07/11] ethdev: replace license text with SPDX tag

2019-07-26 Thread Xiaolong Ye
Signed-off-by: Xiaolong Ye Acked-by: Bruce Richardson --- lib/librte_ethdev/rte_mtr.h | 36 lib/librte_ethdev/rte_tm.h | 37 - 2 files changed, 8 insertions(+), 65 deletions(-) diff --git a/lib/librte_ethdev/rte_mtr.h b/l

[dpdk-dev] [PATCH v2 08/11] lpm: replace license text with SPDX tag

2019-07-26 Thread Xiaolong Ye
Signed-off-by: Xiaolong Ye Acked-by: Bruce Richardson --- lib/librte_lpm/rte_lpm_neon.h | 39 +++ 1 file changed, 3 insertions(+), 36 deletions(-) diff --git a/lib/librte_lpm/rte_lpm_neon.h b/lib/librte_lpm/rte_lpm_neon.h index 28c815902..6c131d312 100644 --- a/l

[dpdk-dev] [PATCH v2 11/11] eal: replace license text with SPDX tag

2019-07-26 Thread Xiaolong Ye
Signed-off-by: Xiaolong Ye Acked-by: Bruce Richardson --- .../common/include/arch/x86/rte_atomic_32.h | 33 ++- .../common/include/arch/x86/rte_atomic_64.h | 33 ++- lib/librte_eal/common/include/rte_keepalive.h | 32 ++ lib/librte_eal/freebsd/

[dpdk-dev] [PATCH v2 02/11] net/i40e: replace license text with SPDX tag

2019-07-26 Thread Xiaolong Ye
Signed-off-by: Xiaolong Ye Acked-by: Bruce Richardson --- drivers/net/i40e/base/README | 34 +++--- 1 file changed, 3 insertions(+), 31 deletions(-) diff --git a/drivers/net/i40e/base/README b/drivers/net/i40e/base/README index 84f191fad..8a5339cff 100644 --- a/drive

[dpdk-dev] [PATCH v2 00/11] add SPDX tags to files with Intel copyright

2019-07-26 Thread Xiaolong Ye
This patchset replaces full BSD-3 license header with spdx tag for the remaining files that have Intel copyright. V2 changes: 1. remove "All rights reserved" 2. change "Intel shannon Ltd" to "Intel Corporation" 3. add ack tag from Bruce Xiaolong Ye (11): net/ixgbe: replace license text with

[dpdk-dev] [PATCH v2 09/11] port: replace license text with SPDX tag

2019-07-26 Thread Xiaolong Ye
Signed-off-by: Xiaolong Ye Acked-by: Bruce Richardson --- lib/librte_port/rte_port_kni.c | 35 +++--- lib/librte_port/rte_port_kni.h | 35 +++--- 2 files changed, 6 insertions(+), 64 deletions(-) diff --git a/lib/librte_port/rte_port_kni.c

[dpdk-dev] [PATCH v4 1/4] examples/multi_process/client_server_mp: check port validity

2019-07-26 Thread Stephen Hemminger
From: Stephen Hemminger The mp_server incorrectly allows a port mask that included hidden ports and which later caused either lost packets or failed initialization. This fixes explicitly checking that each bit in portmask is a valid port before using it. Fixes: 5b7ba31148a8 ("ethdev: add port o

[dpdk-dev] [PATCH v4 2/4] examples/multi_process/client_server_mp - fix crash in mp_client with sparse ports

2019-07-26 Thread Stephen Hemminger
From: Stephen Hemminger The mp_client crashes if run on Azure or any system where ethdev ports are owned. In that case, the tx_buffer and tx_stats for the real port were initialized correctly, but the wrong port was used. For example if the server has Ports 3 and 5. Then calling rte_eth_tx_buffe

Re: [dpdk-dev] Should we disallow running secondaries after primary has died?

2019-07-26 Thread Lipiec, Herakliusz
> -Original Message- > From: Burakov, Anatoly > > On 26-Jul-19 4:56 PM, Lipiec, Herakliusz wrote: > > > > > >> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Burakov, Anatoly > >> On 26-Jul-19 4:01 PM, Stephen Hemminger wrote: > >>> On Fri, 26 Jul 2019 10:53:58 +0100 > >>> "Burakov

[dpdk-dev] [PATCH v4 0/4] examples/client_server_mp: fix port issues

2019-07-26 Thread Stephen Hemminger
The client_server_mp application does not work correctly with failsafe or other devices using port ownership. v4 - fix checkpatch warning add patches to fix style issues and use ether format addr v3 - merge both patches in one series use alternative algorithm to check port ownership (N^

[dpdk-dev] [PATCH v4 3/4] examples/multi_process/client_server_mp/mp_server: fix style

2019-07-26 Thread Stephen Hemminger
Lots of little style complaints from checkpatch. Signed-off-by: Stephen Hemminger --- .../client_server_mp/mp_server/args.c | 37 ++-- .../client_server_mp/mp_server/init.c | 58 +++ .../client_server_mp/mp_server/main.c | 44 +++--- 3 file

[dpdk-dev] [PATCH v4 4/4] examples/multi_process/client_server_mp/mp_server: use ether format address

2019-07-26 Thread Stephen Hemminger
No need to use snprintf to print ethernet address. Signed-off-by: Stephen Hemminger --- .../client_server_mp/mp_server/main.c | 32 ++- 1 file changed, 9 insertions(+), 23 deletions(-) diff --git a/examples/multi_process/client_server_mp/mp_server/main.c b/examples/mult

Re: [dpdk-dev] [PATCH v2 06/11] app/test-eventdev: replace license text with SPDX tag

2019-07-26 Thread Jerin Jacob Kollanukkaran
> -Original Message- > From: Xiaolong Ye > Sent: Friday, July 26, 2019 10:14 PM > To: Ferruh Yigit ; Jerin Jacob Kollanukkaran > > Cc: dev@dpdk.org; Xiaolong Ye > Subject: [EXT] [PATCH v2 06/11] app/test-eventdev: replace license text with > SPDX tag > > -

Re: [dpdk-dev] Should we disallow running secondaries after primary has died?

2019-07-26 Thread Burakov, Anatoly
On 26-Jul-19 5:44 PM, Lipiec, Herakliusz wrote: -Original Message- From: Burakov, Anatoly On 26-Jul-19 4:56 PM, Lipiec, Herakliusz wrote: From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Burakov, Anatoly On 26-Jul-19 4:01 PM, Stephen Hemminger wrote: On Fri, 26 Jul 2019 10:53

Re: [dpdk-dev] [PATCH v2 08/11] lpm: replace license text with SPDX tag

2019-07-26 Thread Jerin Jacob Kollanukkaran
> -Original Message- > From: Xiaolong Ye > Sent: Friday, July 26, 2019 10:14 PM > To: Ferruh Yigit ; Jerin Jacob Kollanukkaran > ; Gavin Hu ; Bruce Richardson > ; Vladimir Medvedkin > > Cc: dev@dpdk.org; Xiaolong Ye > Subject: [PATCH v2 08/11] lpm: replace license text with SPDX tag

Re: [dpdk-dev] Should we disallow running secondaries after primary has died?

2019-07-26 Thread Lipiec, Herakliusz
> From: Burakov, Anatoly > > On 26-Jul-19 5:44 PM, Lipiec, Herakliusz wrote: > > > > > >> -Original Message- > >> From: Burakov, Anatoly > >> > >> On 26-Jul-19 4:56 PM, Lipiec, Herakliusz wrote: > >>> > >>> > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Burakov, > Anato

Re: [dpdk-dev] [PATCH] maintainers: add co-maintainer to sched library

2019-07-26 Thread Dumitrescu, Cristian
> -Original Message- > From: Singh, Jasvinder > Sent: Friday, July 26, 2019 5:42 PM > To: dev@dpdk.org > Cc: Dumitrescu, Cristian > Subject: [PATCH] maintainers: add co-maintainer to sched library > > Add myself as a co-maintainer to dpdk sched library. > > Signed-off-by: Jasvinder Si

Re: [dpdk-dev] [PATCH v2 05/11] examples/qos_sched: replace license text with SPDX tag

2019-07-26 Thread Dumitrescu, Cristian
> -Original Message- > From: Ye, Xiaolong > Sent: Friday, July 26, 2019 5:44 PM > To: Yigit, Ferruh ; Dumitrescu, Cristian > > Cc: dev@dpdk.org; Ye, Xiaolong > Subject: [PATCH v2 05/11] examples/qos_sched: replace license text with > SPDX tag > > Signed-off-by: Xiaolong Ye > Acked-by

Re: [dpdk-dev] [PATCH v2 07/11] ethdev: replace license text with SPDX tag

2019-07-26 Thread Dumitrescu, Cristian
> -Original Message- > From: Ye, Xiaolong > Sent: Friday, July 26, 2019 5:44 PM > To: Yigit, Ferruh ; Dumitrescu, Cristian > ; Thomas Monjalon > ; Andrew Rybchenko > > Cc: dev@dpdk.org; Ye, Xiaolong > Subject: [PATCH v2 07/11] ethdev: replace license text with SPDX tag > > Signed-off-

Re: [dpdk-dev] [PATCH v2 09/11] port: replace license text with SPDX tag

2019-07-26 Thread Dumitrescu, Cristian
> -Original Message- > From: Ye, Xiaolong > Sent: Friday, July 26, 2019 5:44 PM > To: Yigit, Ferruh ; Dumitrescu, Cristian > > Cc: dev@dpdk.org; Ye, Xiaolong > Subject: [PATCH v2 09/11] port: replace license text with SPDX tag > > Signed-off-by: Xiaolong Ye > Acked-by: Bruce Richards

[dpdk-dev] [PATCH v2] net/enic: retain previous message logging

2019-07-26 Thread John Daley
Prior to the fix, RTE_LOGTYPE_INFO messages were displayed by default. After the fix, only NOTICE level and higher were displayed by default and INFO level were not. There are INFO level vNIC config related messages which customers and tech support currently depend on for debugging and so on and to

Re: [dpdk-dev] [PATCH] net/enic: retain previous message logging

2019-07-26 Thread John Daley (johndale)
> -Original Message- > From: Ferruh Yigit > Sent: Friday, July 26, 2019 3:01 AM > To: John Daley (johndale) > Cc: dev@dpdk.org; Hyong Youb Kim (hyonkim) > Subject: Re: [PATCH] net/enic: retain previous message logging > > On 7/26/2019 9:17 AM, John Daley (johndale) wrote: > > Actually

Re: [dpdk-dev] [PATCH] net/enic: retain previous message logging

2019-07-26 Thread Stephen Hemminger
On Fri, 26 Jul 2019 04:21:23 + "Hyong Youb Kim (hyonkim)" wrote: > > -Original Message- > > From: John Daley (johndale) > > Sent: Friday, July 26, 2019 5:26 AM > > To: Ferruh Yigit > > Cc: dev@dpdk.org; Hyong Youb Kim (hyonkim) > > Subject: RE: [PATCH] net/enic: retain previous mess

Re: [dpdk-dev] [PATCH] net/enic: retain previous message logging

2019-07-26 Thread John Daley (johndale)
> -Original Message- > From: Stephen Hemminger > Sent: Friday, July 26, 2019 1:51 PM > To: Hyong Youb Kim (hyonkim) > Cc: John Daley (johndale) ; Ferruh Yigit > ; dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH] net/enic: retain previous message logging > > On Fri, 26 Jul 2019 04:21:23

Re: [dpdk-dev] [PATCH v2] net/ice: fix LLDP forward

2019-07-26 Thread Yang, Qiming
Hi, Ying > -Original Message- > From: Wang, Ying A > Sent: Thursday, July 25, 2019 4:36 PM > To: Zhang, Qi Z > Cc: dev@dpdk.org; Yang, Qiming ; Wang, Ying A > ; sta...@dpdk.org > Subject: [PATCH v2] net/ice: fix LLDP forward > > The patch fix the issue that lldp packet can't be forwarded

Re: [dpdk-dev] [PATCH v2] net/ice: fix LLDP forward

2019-07-26 Thread Ye Xiaolong
On 07/26, Wang Ying A wrote: >The patch fix the issue that lldp packet can't be forwarded to host. > >Fixes: 59d151de6673 ("net/ice: stop LLDP by default") >Cc: sta...@dpdk.org > >Signed-off-by: Wang Ying A >--- >--- >V2: Remove redundant macro definiton and function argument; >Modify the func

Re: [dpdk-dev] [EXT] [PATCH] compressdev: clarify destination buffer size for corner case

2019-07-26 Thread Shally Verma
> -Original Message- > From: Fiona Trahe > Sent: Thursday, July 25, 2019 10:34 PM > To: dev@dpdk.org > Cc: akhil.go...@nxp.com; fiona.tr...@intel.com; Shally Verma > > Subject: [EXT] [PATCH] compressdev: clarify destination buffer size for > corner case > > External Email > > ---

<    1   2