Re: [dpdk-dev] [RFC v2 1/3] ethdev: add the API for getting trace information

2019-08-15 Thread Ray Kinsella
On 13/08/2019 04:24, Stephen Hemminger wrote: > On Tue, 13 Aug 2019 11:06:10 +0800 > Haiyue Wang wrote: > >> Enhance the PMD to support retrieving trace information like >> Rx/Tx burst selection etc. >> >> Signed-off-by: Haiyue Wang >> --- >> lib/librte_ethdev/rte_ethdev.c | 18

Re: [dpdk-dev]   *rte_vhost_rx_queue_count* should be protected by vq->access_lock

2019-08-15 Thread He Peng
Hi, Would you please provide  a list of impacted APIs, thus we can check if our code has further issues. b.t.w, we are now using dpdk 18.11. Thanks. 2019年8月14日 下午11:09,Tiwei Bie 写道: On Wed, Aug 14, 2019 at 03:31:09AM +, He Peng wrote: Hi, We found that *rte_vhost_rx_queue_count* is

[dpdk-dev] [PATCH] net/mlx5: fix validation of drop action

2019-08-15 Thread Dekel Peled
Function mlx5_flow_validate_action_drop() checks if another fate action is already present in this flow rule, using defined value MLX5_FLOW_FATE_ACTIONS. This patch enhances the check using value (MLX5_FLOW_FATE_ACTIONS | MLX5_FLOW_FATE_ESWITCH_ACTIONS) to make sure all relevant fate actions are ch

[dpdk-dev] [PATCH] net/mlx5: fix validation of jump action

2019-08-15 Thread Dekel Peled
This patch updates the validation function of jump action. It adds check of conflicting fate actions in flow rule. It also removes check of action->type which is not needed. Fixes: 684b9a1b1f5c ("net/mlx5: support jump action") Cc: sta...@dpdk.org Signed-off-by: Dekel Peled --- drivers/net/mlx5

Re: [dpdk-dev] 19.11 Marvell Roadmap

2019-08-15 Thread Thomas Monjalon
That's a lot, thank you! We should publish all these items on the website. 09/08/2019 07:55, Jerin Jacob Kollanukkaran: > 1) eBPF arm64 JIT support > > 2) Enhance UT cases for eBPF verification > > 3) Add new l2fwd-event eventdev application > > 4) Update l3fwd application to support event mo

Re: [dpdk-dev] [RFC PATCH v1] regexdev: introduce regexdev subsystem

2019-08-15 Thread Thomas Monjalon
+Cc other interested vendors +Cc contributors to µDPI project in fd.io 27/06/2019 17:50, jer...@marvell.com: > From: Jerin Jacob > > Even though there are some vendors which offer Regex HW offload, due to > lack of standard API, It is diffcult for DPDK consumer to use them > in a portable way. >

Re: [dpdk-dev] [RFC] ethdev: allow multiple security sessions to use one rte flow

2019-08-15 Thread Ananyev, Konstantin
Hi Anoob, > > > > > > > > > > > The rte_security API which enables inline protocol/crypto feature > > > > > mandates that for every security session an rte_flow is created. > > > > > This would internally translate to a rule in the hardware which > > > > > would do packet > > > > classification.

[dpdk-dev] [PATCH v3 0/4] doc: changes to abi policy introducing major abi versions

2019-08-15 Thread Ray Kinsella
TL;DR abbreviation: A major ABI version that all DPDK releases during a one year period support. ABI versioning is managed at a project-level, in place of library-level management. ABI changes to add new features are permitted, as long as ABI compatibility with the major ABI version is maintained.

[dpdk-dev] [PATCH v3 2/4] doc: changes to abi policy introducing major abi versions

2019-08-15 Thread Ray Kinsella
This policy change introduces major ABI versions, these are declared every year, typically aligned with the LTS release and are supported by subsequent releases in the following year. This change is intended to improve ABI stabilty for those projects consuming DPDK. Signed-off-by: Ray Kinsella --

[dpdk-dev] [PATCH v3 1/4] doc: separate versioning.rst into version and policy

2019-08-15 Thread Ray Kinsella
Separate versioning.rst into abi versioning and abi policy guidance, in preparation for adding more detail to the abi policy. Signed-off-by: Ray Kinsella --- doc/guides/contributing/abi_policy.rst | 169 + doc/guides/contributing/abi_versioning.rst | 427 + doc/gu

[dpdk-dev] [PATCH v3 3/4] doc: updates to versioning guide for abi versions

2019-08-15 Thread Ray Kinsella
Updates to the ABI versioning guide, to account for the changes to the DPDK ABI/API policy. Fixes for references to abi versioning and policy guides. Signed-off-by: Ray Kinsella --- doc/guides/contributing/abi_versioning.rst | 248 +++-- doc/guides/contributing/patches.rs

[dpdk-dev] [PATCH v3 4/4] doc: add maintainer for abi policy

2019-08-15 Thread Ray Kinsella
Add an entry to the maintainer file for the abi policy. Signed-off-by: Ray Kinsella --- MAINTAINERS | 4 1 file changed, 4 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 4100260..a36afc1 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -81,6 +81,10 @@ M: Marko Kovacevic F: READM

[dpdk-dev] [RFC] net: new vdpa PMD for Mellanox devices

2019-08-15 Thread Matan Azrad
The last Mellanox adapters\SoCs support virtio operations to accelerate the vhost data path. A new net PMD will be added to implement the vdpa driver requirements on top of Mellanox devices support it like ConnectX6 and BlueField. Points: * The mlx5_vdpa PMD run on top of PCI devices VF an

Re: [dpdk-dev] [RFC PATCH v1] regexdev: introduce regexdev subsystem

2019-08-15 Thread Thomas Monjalon
+Cc more From: Jerin Jacob Even though there are some vendors which offer Regex HW offload, due to lack of standard API, It is diffcult for DPDK consumer to use them in a portable way. This _RFC_ attempts to standardize the RegEx/DPI offload APIs for DPDK. The Doxygen generate

Re: [dpdk-dev]   *rte_vhost_rx_queue_count* should be protected by vq->access_lock

2019-08-15 Thread Tiwei Bie
On Thu, Aug 15, 2019 at 09:14:52AM +, He Peng wrote: > Hi, > > > Would you please provide  a list of impacted APIs, thus we can check if our > code has further issues. b.t.w, we are now using dpdk 18.11. I'm looking into this issue. The API of the builtin backend is supposed to be protected

[dpdk-dev] [RFC] ethdev: configure SR-IOV VF from host

2019-08-15 Thread Thomas Monjalon
In a virtual environment, the network controller may have to configure some SR-IOV VF parameters for security reasons. When the PF (host port) is drived by DPDK (OVS-DPDK case), we face two different cases: - driver is bifurcated (Mellanox case), so the VF can be configured via the

Re: [dpdk-dev] [RFC] ethdev: configure SR-IOV VF from host

2019-08-15 Thread Jerin Jacob Kollanukkaran
> -Original Message- > From: dev On Behalf Of Thomas Monjalon > Sent: Thursday, August 15, 2019 8:36 PM > To: Ferruh Yigit ; Andrew Rybchenko > > Cc: dev@dpdk.org; Bernard Iremonger ; > Shahaf Shuler ; E. Scott Daniels > ; Wenzhuo Lu ; Alex > Zelezniak ; Ajit Khaparde ; > Declan Doherty

Re: [dpdk-dev] [PATCH 2/2] vhost: fix build error caused by 64bit print formatting

2019-08-15 Thread David Christensen
Use of %llx print formatting causes meson build error on Power systems with RHEL 7.6 and gcc 4.8.5. Replace with PRIx64 macro. + (uint64_t)reg_struct.range.start, + (uint64_t)reg_struct.range.start + + (uin

[dpdk-dev] [PATCH 1/4] reciprocal: remove redundant boilerplate license text

2019-08-15 Thread Stephen Hemminger
The SPDX-License-Identifier carries the same information as the boilerplate. Signed-off-by: Stephen Hemminger --- lib/librte_eal/common/rte_reciprocal.c | 32 -- 1 file changed, 32 deletions(-) diff --git a/lib/librte_eal/common/rte_reciprocal.c b/lib/librte_eal/common/

[dpdk-dev] [PATCH 2/4] uuid: remove redundant BSD boilerplate

2019-08-15 Thread Stephen Hemminger
The BSD license text is redundant now that these files have SPDX-License-Identifier. Signed-off-by: Stephen Hemminger --- lib/librte_eal/common/eal_common_uuid.c | 26 lib/librte_eal/common/include/rte_uuid.h | 26 2 files changed, 52 deletions(

[dpdk-dev] [PATCH 3/4] drivers: add SPDX license id to map files

2019-08-15 Thread Stephen Hemminger
The map files were (mostly) missing required SPDX license id. Add the BSD license as is done on all other files. Signed-off-by: Stephen Hemminger --- .../baseband/fpga_lte_fec/rte_pmd_bbdev_fpga_lte_fec_version.map | 1 + drivers/baseband/null/rte_pmd_bbdev_null_version.map | 1 + dr

[dpdk-dev] [PATCH 0/4] SPDX license tagging

2019-08-15 Thread Stephen Hemminger
Remove redundant boilerplate on libraries I submitted. Add license id to map files. Stephen Hemminger (4): reciprocal: remove redundant boilerplate license text uuid: remove redundant BSD boilerplate drivers: add SPDX license id to map files lib: add SPDX license id to map files .../rte_

[dpdk-dev] [PATCH 4/4] lib: add SPDX license id to map files

2019-08-15 Thread Stephen Hemminger
The map files were missing required SPDX license id. Signed-off-by: Stephen Hemminger --- lib/librte_acl/rte_acl_version.map | 1 + lib/librte_bbdev/rte_bbdev_version.map | 1 + lib/librte_bitratestats/rte_bitratestats_version.map | 1 + lib/librte_bpf/rte_b

Re: [dpdk-dev] [RFC] ethdev: configure SR-IOV VF from host

2019-08-15 Thread Thomas Monjalon
15/08/2019 17:34, Jerin Jacob Kollanukkaran: > From: Thomas Monjalon > > > > In a virtual environment, the network controller may have to configure some > > SR-IOV VF parameters for security reasons. > > > > When the PF (host port) is drived by DPDK (OVS-DPDK case), we face two > > different case

[dpdk-dev] 17.11.7-rc1 (LTS) patches review and test

2019-08-15 Thread Yongseok Koh
Hi all, Here is a list of patches targeted for LTS release 17.11.7. Please help review and test. The planned date for the final release is Aug 23, Before that, please shout if anyone has objections with these patches being applied. Also for the companies committed to running regression tests, ple

[dpdk-dev] [PATCH 2/2] timer: don't check tsc flags in secondary processes

2019-08-15 Thread Jim Harris
check_tsc_flags() parses /proc/cpuinfo and prints warning messages if any cores don't have constant_tsc and nonstop_tsc. It has no functional meaning. This consumes a noticeable amount of time in secondary processes - on my test system, it consumes 21ms out of the 66ms total execution time for rte

[dpdk-dev] [PATCH 1/2] timer: use rte_mp_msg to pass TSC hz to secondary procs

2019-08-15 Thread Jim Harris
rte_eal_init() is much faster in secondary processes since hugepages don't need to be zeroed. But there's still non-trivial delays in the timer subsystem initialization due to the 100ms sleep used to calculate TSC hz. So use the rte_mp_msg framework to allow secondary processes to get the TSC hz

[dpdk-dev] [PATCH] net/mlx5: add support for vectorized code on Power systems

2019-08-15 Thread David Christensen
Added mlx5_rxtx_vec_altivec.h which supports vectorized RX using Altivec vector code. Modified associated build files to use the new code. Cc: shah...@mellanox.com Cc: ys...@mellanox.com Cc: viachesl...@mellanox.com Signed-off-by: David Christensen --- drivers/net/mlx5/Makefile

[dpdk-dev] [PATCH] examples/l3fwd: prefetch the content of the next packet

2019-08-15 Thread Feifei Wang
The cache-misses problem is very serious when the function lpm_cb_parse_ptype is called to read the content of packets. That is because the contents of packages previously stored in the cache are overwritten by the following instructions or variables. Thus the prefetch order can be used to prefetch

[dpdk-dev] Issue with DCB with X710 Quad 10Gb NIC

2019-08-15 Thread Mike DeVico
Hello, I am having an issue getting the DCB feature to work with an Intel X710 Quad SFP+ NIC. Here’s my setup: 1. DPDK 18.08 built with the following I40E configs: CONFIG_RTE_LIBRTE_I40E_PMD=y CONFIG_RTE_LIBRTE_I40E_DEBUG_RX=n CONFIG_RTE_LIBRTE_I40E_DEBUG_TX=n CONFIG_RTE_LIBRTE_I40E_DEBUG_

[dpdk-dev] [PATCH] Change email in maintainers file

2019-08-15 Thread Michael Santana
Change email address for Michael Santana to personal email in the MAINTAINERS file Signed-off-by: Michael Santana Signed-off-by: Michael Santana --- NOTE: My internship at Red Hat is ending soon so I will not be able to monitor my red hat email. I will not monitor the mailing list as much, so C

Re: [dpdk-dev] [RFC] ethdev: allow multiple security sessions to use one rte flow

2019-08-15 Thread Anoob Joseph
Hi Konstantin, Please see inline. Thanks, Anoob > -Original Message- > From: Ananyev, Konstantin > Sent: Thursday, August 15, 2019 3:18 PM > To: Anoob Joseph ; Akhil Goyal > ; Adrien Mazarguil ; > Doherty, Declan ; De Lara Guarch, Pablo > ; Thomas Monjalon > > Cc: Jerin Jacob Kollanukk

[dpdk-dev] [PATCH] net/octeontx2: fix port Tx VLAN insertion

2019-08-15 Thread Nithin Dabilpuram
This patch fixes configuration for port Tx vlan insertion feature. As per latest Tx KEX profile, pf_func should be at KW[0](47:32) and not KW[1](63:48). Fixes: 168c59cfe42b ("net/octeontx2: add flow MCAM utility functions") Cc: kirankum...@marvell.com Signed-off-by: Nithin Dabilpuram --- driver

Re: [dpdk-dev] [RFC] ethdev: configure SR-IOV VF from host

2019-08-15 Thread Jerin Jacob Kollanukkaran
> -Original Message- > From: Thomas Monjalon > Sent: Thursday, August 15, 2019 11:29 PM > To: Jerin Jacob Kollanukkaran > Cc: Ferruh Yigit ; Andrew Rybchenko > ; dev@dpdk.org; Bernard Iremonger > ; Shahaf Shuler ; > E. Scott Daniels ; Wenzhuo Lu > ; Alex Zelezniak ; Ajit Khaparde > ; D

[dpdk-dev] [PATCH 1/7] ethdev: add set ptype function

2019-08-15 Thread pbhagavatula
From: Pavan Nikhilesh Add `rte_eth_dev_set_supported_ptypes` function that will allow the application to inform the PMD the packet types it is interested in. Based on the ptypes set PMDs can optimize their Rx path. -If application doesn’t want any ptype information it can call `rte_eth_dev_set_s

[dpdk-dev] [PATCH 5/7] net: update Rx flow action offload capabilities

2019-08-15 Thread pbhagavatula
From: Pavan Nikhilesh Add DEV_RX_OFFLOAD_FLOW_MARK flag for all supported NICs. Signed-off-by: Pavan Nikhilesh --- drivers/net/bnxt/bnxt_ethdev.c | 3 ++- drivers/net/enic/enic_res.c | 3 ++- drivers/net/i40e/i40e_ethdev.c | 3 ++- drivers/net/iavf/iavf_ethdev.c

[dpdk-dev] [PATCH 0/7] ethdev: add new Rx offload flags

2019-08-15 Thread pbhagavatula
From: Pavan Nikhilesh Add new Rx offload flags `DEV_RX_OFFLOAD_RSS_HASH` and `DEV_RX_OFFLOAD_FLOW_MARK`. These flags can be used to enable/disable PMD writes to rte_mbuf fields `hash.rss` and `hash.fdir.hi` and also `ol_flags:PKT_RX_RSS` and `ol_flags:PKT_RX_FDIR`. Add new packet type set functi

[dpdk-dev] [PATCH 2/7] ethdev: add mbuf RSS update as a offload

2019-08-15 Thread pbhagavatula
From: Pavan Nikhilesh Add new Rx offload flag `DEV_RX_OFFLOAD_RSS_HASH` which can be used to enable/disable PMDs write to `rte_mbuf::hash::rss`. Signed-off-by: Pavan Nikhilesh --- doc/guides/nics/features.rst | 2 ++ lib/librte_ethdev/rte_ethdev.h | 1 + 2 files changed, 3 insertions(+) dif

[dpdk-dev] [PATCH 3/7] ethdev: add flow action type update as an offload

2019-08-15 Thread pbhagavatula
From: Pavan Nikhilesh Add new Rx offload flag `DEV_RX_OFFLOAD_FLOW_MARK` that can be used to enable/disable PMDs write to `rte_mbuf::hash::fdir::hi`. Signed-off-by: Pavan Nikhilesh --- doc/guides/nics/features.rst | 12 lib/librte_ethdev/rte_ethdev.h | 1 + 2 files changed, 13

[dpdk-dev] [PATCH 4/7] net: update Rx RSS hash offload capabilities

2019-08-15 Thread pbhagavatula
From: Pavan Nikhilesh Add DEV_RX_OFFLOAD_RSS_HASH flag for all supported NICs. Signed-off-by: Pavan Nikhilesh --- drivers/net/bnxt/bnxt_ethdev.c | 3 ++- drivers/net/cxgbe/cxgbe.h| 3 ++- drivers/net/dpaa/dpaa_ethdev.c | 3 ++- drivers/net/dpaa2/dpaa2_ethdev.c |

[dpdk-dev] [PATCH 7/7] examples/eventdev_pipeline: add new Rx RSS hash offload

2019-08-15 Thread pbhagavatula
From: Pavan Nikhilesh Since pipeline_generic uses `rte_mbuf::hash::rss` add the new Rx offload flag `DEV_RX_OFFLOAD_RSS_HASH` to inform PMD to copy the RSS hash result into the mbuf. Signed-off-by: Pavan Nikhilesh --- examples/eventdev_pipeline/main.c | 4 1 file changed, 4 insertions(+)

[dpdk-dev] [PATCH 6/7] net: add ptype set default functionality

2019-08-15 Thread pbhagavatula
From: Pavan Nikhilesh Add ptype set default functionality i.e. enable ptype by default and report ptypes even if application disables ptypes. Signed-off-by: Pavan Nikhilesh --- drivers/net/atlantic/atl_ethdev.c | 12 drivers/net/bnxt/bnxt_ethdev.c | 10 ++ dri

Re: [dpdk-dev] [PATCH 7/7] examples/eventdev_pipeline: add new Rx RSS hash offload

2019-08-15 Thread Jerin Jacob Kollanukkaran
> -Original Message- > From: pbhagavat...@marvell.com > Sent: Friday, August 16, 2019 11:25 AM > To: Jerin Jacob Kollanukkaran ; ferruh.yi...@intel.com; > Harry van Haaren > Cc: dev@dpdk.org; Pavan Nikhilesh Bhagavatula > > Subject: [dpdk-dev] [PATCH 7/7] examples/eventdev_pipeline: add

Re: [dpdk-dev] [PATCH 0/7] ethdev: add new Rx offload flags

2019-08-15 Thread Jerin Jacob Kollanukkaran
> -Original Message- > From: pbhagavat...@marvell.com > Sent: Friday, August 16, 2019 11:25 AM > To: Jerin Jacob Kollanukkaran ; ferruh.yi...@intel.com > Cc: dev@dpdk.org; Pavan Nikhilesh Bhagavatula > > Subject: [dpdk-dev] [PATCH 0/7] ethdev: add new Rx offload flags > > From: Pavan Nik

[dpdk-dev] [PATCH v10 0/5] kni: add IOVA=VA support

2019-08-15 Thread vattunuru
From: Vamsi Attunuru --- V10 Changes: * Fixed function return code on failure when min_chunk_size > pg_sz. * Marked new mempool populate routine as EXPERIMENTAL. V9 Changes: * Used rte_mempool_ops_calc_mem_size() instead of default handler in the new mempool populate routine. * Check min_chunk_s

[dpdk-dev] [PATCH v10 1/5] mempool: populate mempool with the page sized chunks

2019-08-15 Thread vattunuru
From: Vamsi Attunuru Patch adds a routine to populate mempool from page aligned and page sized chunks of memory to ensure memory objs do not fall across the page boundaries. It's useful for applications that require physically contiguous mbuf memory while running in IOVA=VA mode. Signed-off-by:

[dpdk-dev] [PATCH v10 5/5] kni: modify IOVA mode checks to support VA

2019-08-15 Thread vattunuru
From: Vamsi Attunuru Patch addresses checks in KNI and eal that enforce IOVA=PA when IOVA=VA mode is enabled, since KNI kernel module supports VA mode for kernel versions >= 4.4.0. Updated KNI documentation with above details. Signed-off-by: Vamsi Attunuru Signed-off-by: Kiran Kumar K --- do

[dpdk-dev] [PATCH v10 2/5] kni: add IOVA=VA support in KNI lib

2019-08-15 Thread vattunuru
From: Vamsi Attunuru Current KNI implementation only operates in IOVA=PA mode, patch adds required functionality in KNI lib to support IOVA=VA mode. KNI kernel module requires device info to get iommu domain related information for IOVA addr related translations. Patch defines device related inf

[dpdk-dev] [PATCH v10 4/5] kni: add IOVA=VA support in KNI module

2019-08-15 Thread vattunuru
From: Kiran Kumar K Patch adds support for kernel module to work in IOVA = VA mode, the idea is to get physical address from IOVA address using iommu_iova_to_phys API and later use phys_to_virt API to convert the physical address to kernel virtual address. When compared with IOVA = PA mode, ther

[dpdk-dev] [PATCH v10 3/5] kni: add app specific mempool create and free routines

2019-08-15 Thread vattunuru
From: Vamsi Attunuru When KNI operates in IOVA = VA mode, it requires mbuf memory to be physically contiguous to ensure KNI kernel module could translate IOVA addresses properly. Patch adds a KNI specific mempool create routine to populate the KNI packet mbuf pool with memory objects that are bei