Re: [dpdk-dev] net/ixgbe: fix X553 wrong speed capability

2019-09-25 Thread Gavin Hu (Arm Technology China)
Hi Xiao, > -Original Message- > From: dev On Behalf Of Zhang Xiao > Sent: Wednesday, September 25, 2019 10:50 AM > To: dev@dpdk.org > Cc: wenzhuo...@intel.com; Zhang Xiao ; > marcde...@gmail.com; sta...@dpdk.org > Subject: [dpdk-dev] net/ixgbe: fix X553 wrong speed capability > > The spe

Re: [dpdk-dev] [PATCH v6 01/17] net/i40e: i40e support ipn3ke FPGA port bonding

2019-09-25 Thread Pei, Andy
Hi Qi, Will modify in next version. -Original Message- From: Zhang, Qi Z Sent: Friday, September 20, 2019 8:55 AM To: Pei, Andy ; dev@dpdk.org Cc: Xu, Rosen ; Zhang, Tianfei ; Ye, Xiaolong ; Lomartire, David ; Yigit, Ferruh Subject: RE: [PATCH v6 01/17] net/i40e: i40e support ipn3ke F

Re: [dpdk-dev] [PATCH v2 08/16] vhost: add flush function for burst enqueue

2019-09-25 Thread Gavin Hu (Arm Technology China)
Hi Marvin, > -Original Message- > From: Liu, Yong > Sent: Wednesday, September 25, 2019 2:52 PM > To: Gavin Hu (Arm Technology China) ; > 'maxime.coque...@redhat.com' ; Bie, > Tiwei ; Wang, Zhihong > Cc: 'dev@dpdk.org' ; nd > Subject: RE: [dpdk-dev] [PATCH v2 08/16] vhost: add flush fun

Re: [dpdk-dev] [PATCH v1 1/1] kernel/linux: introduce vfio_pf kernel module

2019-09-25 Thread Andrew Rybchenko
On 9/25/19 7:06 AM, Vamsi Krishna Attunuru wrote: Hi, We would like to have these support in 19.11. Please let us know if there are any comments or suggestions, we can discuss and address accordingly. -Original Message- From: Jerin Jacob Kollanukkaran Sent: Friday, September 6, 2019 6

Re: [dpdk-dev] [PATCH 03/20] security: add hfn override option in PDCP

2019-09-25 Thread Anoob Joseph
Hi Akhil, Please see inline. Thanks, Anoob > -Original Message- > From: Akhil Goyal > Sent: Thursday, September 19, 2019 9:01 PM > To: konstantin.anan...@intel.com; Anoob Joseph ; > Radu Nicolau > Cc: Hemant Agrawal ; Vakul Garg > ; dev@dpdk.org; Akhil Goyal > Subject: [EXT] RE: [PATC

[dpdk-dev] [PATCH] net/mlx5: fix Bluefield VF type recognition

2019-09-25 Thread Viacheslav Ovsiienko
The PCI virtual function type was recognized correctly for Bluefield VF. Fixes: f38c54571d62 ("net/mlx5: split PCI from generic probing") Cc: sta...@dpdk.org Signed-off-by: Viacheslav Ovsiienko --- drivers/net/mlx5/mlx5.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/mlx5/mlx5

[dpdk-dev] [PATCH] net/mlx5: fix ConnectX-6 VF type recognition

2019-09-25 Thread Viacheslav Ovsiienko
The PCI virtual function type was not recognized correctly for ConnectX-6 VF. Fixes: f0354d842344 ("net/mlx5: add ConnectX-6 device IDs") Cc: sta...@dpdk.org Signed-off-by: Viacheslav Ovsiienko --- drivers/net/mlx5/mlx5.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/mlx5/mlx5

Re: [dpdk-dev] [PATCH] net/mlx5: fix ConnectX-6 VF type recognition

2019-09-25 Thread Matan Azrad
From: Viacheslav Ovsiienko > The PCI virtual function type was not recognized correctly for ConnectX-6 VF. > > Fixes: f0354d842344 ("net/mlx5: add ConnectX-6 device IDs") > Cc: sta...@dpdk.org > > Signed-off-by: Viacheslav Ovsiienko Acked-by: Matan Azrad

Re: [dpdk-dev] [PATCH] net/mlx5: fix Bluefield VF type recognition

2019-09-25 Thread Matan Azrad
From: Viacheslav Ovsiienko > The PCI virtual function type was recognized correctly for Bluefield VF. > > Fixes: f38c54571d62 ("net/mlx5: split PCI from generic probing") > Cc: sta...@dpdk.org > > Signed-off-by: Viacheslav Ovsiienko Acked-by: Matan Azrad

[dpdk-dev] [PATCH 01/12] net/mlx5: move backing PCI device to private context

2019-09-25 Thread Viacheslav Ovsiienko
Now all devices created over the same multiport IB device have shared context containing the backing PCI device field. For the VF LAG configurations it becomes possible the representors might be connected to VF created over different PFs. In this case representors have the different backing PCI dev

[dpdk-dev] [PATCH 00/12] net/mlx5: add bonding configuration support

2019-09-25 Thread Viacheslav Ovsiienko
Multiport Mellanox NICs may support the bonding configurations internally. Let's suppose there is ConnectX-5 NIC with two physical ports, on the host it presents two PCI physical functions: - PF0, say with PCI address :82:00.0 and net interface ens1f0 - PF1, say with PCI address :82:00.1 a

[dpdk-dev] [PATCH 02/12] net/mlx5: update PCI address retrieving routine

2019-09-25 Thread Viacheslav Ovsiienko
The routine mlx5_ibv_device_to_pci_addr() takes Infiniband device list object, takes the device sysfs path from there and retrieves PCI address. The routine may be implemented in more generic way by taking sysfs path directly as parameter and can be used for getting PCI address of netdevs. The gen

[dpdk-dev] [PATCH 04/12] net/mlx5: add VF LAG mode bonding device recognition

2019-09-25 Thread Viacheslav Ovsiienko
The Mellanox NICs starting from ConnectX-5 support LAG over NIC ports internally, implemented by the NIC firmware and hardware. The multiport NIC presents multiple physical PCI functions (PF), with SR-IOV multiple virtual PCI functions (VFs) might be presented. With switchdev mode the VF represento

[dpdk-dev] [PATCH 03/12] net/mlx5: allocate device list explicitly

2019-09-25 Thread Viacheslav Ovsiienko
At device probing the device list to spawn was allocated as dynamic size local variable. It was no possible to have one unified exit point from routine due to compiler warnings. This patch allocates the spawn device list directly with rte_zmalloc() and it is possible to goto to unified exit label f

[dpdk-dev] [PATCH 08/12] net/mlx5: elaborate E-Switch port parameters query

2019-09-25 Thread Viacheslav Ovsiienko
The routine mlx5_port_to_eswitch_info() is elaborated to two ones (get E-Switch port parameters by port and by device pointer) and simplified to returning structure containing all parameters instead of copying. Signed-off-by: Viacheslav Ovsiienko --- drivers/net/mlx5/mlx5.h | 4 +-- dri

[dpdk-dev] [PATCH 09/12] net/mlx5: update source and destination vport translations

2019-09-25 Thread Viacheslav Ovsiienko
There new kernel/rdma_core [1] supports matching on metadata register instead of vport field to provide operations over VF LAG bonding configurations. This patch provides correct translations for flow matchers and destination port actions if united E-Switch (for VF LAG) is configured and/or new vpo

[dpdk-dev] [PATCH 05/12] net/mlx5: generate bonding device name

2019-09-25 Thread Viacheslav Ovsiienko
If device is VF LAG bonding one the port name includes the bonding Infiniband device name and looks like: 82:00.0_mlx5_bond_0 - for master device port PF0 82:00.1_mlx5_bond_0_representor_5 - for representor VF5 over PF1 where bonding Infiniband devic

[dpdk-dev] [PATCH 07/12] net/mlx5: query vport index match mode and parameters

2019-09-25 Thread Viacheslav Ovsiienko
There new kernel/rdma_core [1] supports matching on metadata register instead of vport field to provide operations over VF LAG bonding configurations. The patch retrieves parameters and information about the way is engaged to match vport on E-Switch. [1] http://patchwork.ozlabs.org/cover/1122170/

[dpdk-dev] [PATCH 06/12] net/mlx5: check the kernel support for VF LAG bonding

2019-09-25 Thread Viacheslav Ovsiienko
If bonding Infiniband device is found the unified E-Switch is supposed and the extra rdma-core/kernel support is needed to retrieve vport indices. The patch introduces this feature defines, bonding support check is added to probe routine. Signed-off-by: Viacheslav Ovsiienko --- drivers/net/mlx5/

[dpdk-dev] [PATCH 12/12] net/mlx5: check sibling device configurations mismatch

2019-09-25 Thread Viacheslav Ovsiienko
The devices backed by mlx5 PMD might share the same multiport Infiniband device context. It regards representors and slaves of bonding device. These ports are spawned with devargs. These patch check whether configuration deduced from these devargs is compatible with configurations if devices sharin

[dpdk-dev] [PATCH 11/12] net/mlx5: update switch port ID in bonding configuration

2019-09-25 Thread Viacheslav Ovsiienko
With bonding configuration multiple PFs may represent the single switching device with multiple ports as representors. To distinguish representors belonging to different PFs we should generated unique port ID. It is proposed to use the PF index in bonding configuration to generate this unique port

[dpdk-dev] [PATCH 10/12] net/mlx5: extend switch domain searching range

2019-09-25 Thread Viacheslav Ovsiienko
With bonding configurations the switch domain may be shared between multiple PCI devices, we should search the switch sibling devices within the entire set of present ethernet devices backed by the mlx5 PMD. Signed-off-by: Viacheslav Ovsiienko --- drivers/net/mlx5/mlx5.c| 25

Re: [dpdk-dev] [PATCH] lib/rcu: fix possible spurious thread unregister

2019-09-25 Thread David Marchand
On Mon, Sep 9, 2019 at 3:52 PM Ruifeng Wang wrote: > > Thread unregister returns success while unregister not been performed. > This is due to incorrect thread registration status check. > Fix this issue by correcting bitmap check. > > Fixes: 64994b56cfd7 ("rcu: add RCU library supporting QSBR mec

Re: [dpdk-dev] net/ixgbe: fix X553 wrong speed capability

2019-09-25 Thread Zhang, Xiao
Hi Gavin, > -Original Message- > From: Gavin Hu (Arm Technology China) [mailto:gavin...@arm.com] > Sent: Wednesday, September 25, 2019 3:04 PM > To: Zhang, Xiao ; dev@dpdk.org > Cc: Lu, Wenzhuo ; marcde...@gmail.com; > sta...@dpdk.org; nd > Subject: RE: [dpdk-dev] net/ixgbe: fix X553 wron

Re: [dpdk-dev] [PATCH v2] kni: rework rte_kni_update_link using ioctl

2019-09-25 Thread Igor Ryzhov
Sure, my bad, sorry. Will send v3. On Tue, Sep 24, 2019 at 11:37 PM Aaron Conole wrote: > Igor Ryzhov writes: > > > Current implementation doesn't allow us to update KNI carrier if the > > interface is not yet UP in kernel. It means that we can't use it in the > > same thread which is processin

Re: [dpdk-dev] net/ixgbe: fix X553 wrong speed capability

2019-09-25 Thread Gavin Hu (Arm Technology China)
Hi Xiao, > -Original Message- > From: Zhang, Xiao > Sent: Wednesday, September 25, 2019 4:16 PM > To: Gavin Hu (Arm Technology China) ; > dev@dpdk.org > Cc: Lu, Wenzhuo ; marcde...@gmail.com; > sta...@dpdk.org; nd > Subject: RE: [dpdk-dev] net/ixgbe: fix X553 wrong speed capability > >

Re: [dpdk-dev] [PATCH v1 1/1] bus/pci: probe PCI devices in whitelisted order

2019-09-25 Thread Gaëtan Rivet
On Wed, Sep 25, 2019 at 06:41:36AM +, Slava Ovsiienko wrote: > > -Original Message- > > From: dev On Behalf Of vattun...@marvell.com > > Sent: Monday, September 23, 2019 14:57 > > To: dev@dpdk.org > > Cc: gaetan.ri...@6wind.com; ferruh.yi...@intel.com; > > anatoly.bura...@intel.com; Th

[dpdk-dev] [DPDK] app/testpmd: fix unused variable compile error

2019-09-25 Thread taox . zhu
From: Zhu Tao This minor patch fixes unused variable ‘ret’ compile error When CONFIG_RTE_LIBRTE_I40E_16BYTE_RX_DESC was selected. Fixes: f5267e485a2a ("app/testpmd: check status of getting ethdev info") Signed-off-by: Zhu Tao --- app/test-pmd/config.c | 2 +- 1 file changed, 1 insertion(+), 1

Re: [dpdk-dev] [PATCH] net/i40e: fix conflict with multi-driver

2019-09-25 Thread Xing, Beilei
> -Original Message- > From: Zhang, AlvinX > Sent: Friday, September 20, 2019 6:57 PM > To: Zhang, Qi Z ; Xing, Beilei > Cc: dev@dpdk.org; Zhang, AlvinX ; > sta...@dpdk.org > Subject: [PATCH] net/i40e: fix conflict with multi-driver > > From: Alvin Zhang > > If support-multi-driver op

[dpdk-dev] [PATCH v2] app/testpmd: fix unused variable compile error

2019-09-25 Thread taox . zhu
From: Zhu Tao This minor patch fixes unused variable ‘ret’ compile error When CONFIG_RTE_LIBRTE_I40E_16BYTE_RX_DESC was selected. Fixes: f5267e485a2a ("app/testpmd: check status of getting ethdev info") Signed-off-by: Zhu Tao --- app/test-pmd/config.c | 2 +- 1 file changed, 1 insertion(+), 1

Re: [dpdk-dev] [PATCH v2 03/16] vhost: add burst enqueue function for packed ring

2019-09-25 Thread Gavin Hu (Arm Technology China)
Hi Marvin, > -Original Message- > From: Liu, Yong > Sent: Tuesday, September 24, 2019 11:31 AM > To: Gavin Hu (Arm Technology China) ; > maxime.coque...@redhat.com; Bie, Tiwei ; Wang, > Zhihong > Cc: dev@dpdk.org; nd > Subject: RE: [dpdk-dev] [PATCH v2 03/16] vhost: add burst enqueue fu

[dpdk-dev] [PATCH v3 00/15] vhost packed ring performance optimization

2019-09-25 Thread Marvin Liu
Packed ring has more compact ring format and thus can significantly reduce the number of cache miss. It can lead to better performance. This has been approved in virtio user driver, on normal E5 Xeon cpu single core performance can raise 12%. http://mails.dpdk.org/archives/dev/2018-April/095470.ht

[dpdk-dev] [PATCH v3 01/15] vhost: add single packet enqueue function

2019-09-25 Thread Marvin Liu
Add vhost enqueue function for single packet and meanwhile left space for flush used ring function. Signed-off-by: Marvin Liu diff --git a/lib/librte_vhost/virtio_net.c b/lib/librte_vhost/virtio_net.c index 5b85b832d..520c4c6a8 100644 --- a/lib/librte_vhost/virtio_net.c +++ b/lib/librte_vhost/vi

[dpdk-dev] [PATCH v3 02/15] vhost: unify unroll pragma parameter

2019-09-25 Thread Marvin Liu
Add macro for unifying Clang/ICC/GCC unroll pragma format. Batch functions were contained of several small loops which optimized by compiler’s loop unrolling pragma. Signed-off-by: Marvin Liu diff --git a/lib/librte_vhost/Makefile b/lib/librte_vhost/Makefile index 8623e91c0..30839a001 100644 ---

[dpdk-dev] [PATCH v3 04/15] vhost: add single packet dequeue function

2019-09-25 Thread Marvin Liu
Add vhost single packet dequeue function for packed ring and meanwhile left space for shadow used ring update function. Signed-off-by: Marvin Liu diff --git a/lib/librte_vhost/virtio_net.c b/lib/librte_vhost/virtio_net.c index 5e08f7d9b..17aabe8eb 100644 --- a/lib/librte_vhost/virtio_net.c +++ b

[dpdk-dev] [PATCH v3 03/15] vhost: add batch enqueue function for packed ring

2019-09-25 Thread Marvin Liu
Batch enqueue function will first check whether descriptors are cache aligned. It will also check prerequisites in the beginning. Batch enqueue function not support chained mbufs, single packet enqueue function will handle it. Signed-off-by: Marvin Liu diff --git a/lib/librte_vhost/vhost.h b/lib

[dpdk-dev] [PATCH v3 05/15] vhost: add batch dequeue function

2019-09-25 Thread Marvin Liu
Add batch dequeue function like enqueue function for packed ring, batch dequeue function will not support chained descritpors, single packet dequeue function will handle it. Signed-off-by: Marvin Liu diff --git a/lib/librte_vhost/vhost.h b/lib/librte_vhost/vhost.h index e241436c7..e50e137ca 1006

[dpdk-dev] [PATCH v3 07/15] vhost: add flush function for batch enqueue

2019-09-25 Thread Marvin Liu
Flush used flags when batched enqueue function is finished. Descriptor's flags are pre-calculated as they will be reset by vhost. Signed-off-by: Marvin Liu diff --git a/lib/librte_vhost/vhost.h b/lib/librte_vhost/vhost.h index 18a207fc6..7bf9ff9b7 100644 --- a/lib/librte_vhost/vhost.h +++ b/lib/

[dpdk-dev] [PATCH v3 06/15] vhost: flush vhost enqueue shadow ring by batch

2019-09-25 Thread Marvin Liu
Buffer vhost enqueue shadow ring update, flush shadow ring until buffered descriptors number exceed one batch. Thus virtio can receive packets at a faster frequency. Signed-off-by: Marvin Liu diff --git a/lib/librte_vhost/vhost.h b/lib/librte_vhost/vhost.h index e50e137ca..18a207fc6 100644 --- a

[dpdk-dev] [PATCH v3 08/15] vhost: buffer vhost dequeue shadow ring

2019-09-25 Thread Marvin Liu
Buffer used ring updates as many as possible in vhost dequeue function for coordinating with virtio driver. For supporting buffer, shadow used ring element should contain descriptor index and its wrap counter. First shadowed ring index is recorded for calculating buffered number. Signed-off-by: Ma

[dpdk-dev] [PATCH v3 09/15] vhost: split enqueue and dequeue flush functions

2019-09-25 Thread Marvin Liu
Vhost enqueue descriptors are updated by batch number, while vhost dequeue descriptors are buffered. Meanwhile in dequeue function only first descriptor is buffered. Due to these differences, split vhost enqueue and dequeue flush functions. Signed-off-by: Marvin Liu diff --git a/lib/librte_vhost

[dpdk-dev] [PATCH v3 10/15] vhost: optimize enqueue function of packed ring

2019-09-25 Thread Marvin Liu
Optimize vhost device Tx datapath by separate functions. Packets can be filled into one descriptor will be handled by batch and others will be handled one by one as before. Signed-off-by: Marvin Liu diff --git a/lib/librte_vhost/virtio_net.c b/lib/librte_vhost/virtio_net.c index 1b0fa2c64..c485e

[dpdk-dev] [PATCH v3 12/15] vhost: optimize dequeue function of packed ring

2019-09-25 Thread Marvin Liu
Optimize vhost device Rx datapath by separate functions. No-chained and direct descriptors will be handled by batch and other will be handled one by one as before. Signed-off-by: Marvin Liu diff --git a/lib/librte_vhost/virtio_net.c b/lib/librte_vhost/virtio_net.c index 9ab95763a..20624efdc 1006

[dpdk-dev] [PATCH v3 13/15] vhost: cache address translation result

2019-09-25 Thread Marvin Liu
Cache address translation result and use it in next translation. Due to limited regions are supported, buffers are most likely in same region when doing data transmission. Signed-off-by: Marvin Liu diff --git a/lib/librte_vhost/rte_vhost.h b/lib/librte_vhost/rte_vhost.h index 7fb172912..d90235cd

[dpdk-dev] [PATCH v3 11/15] vhost: add batch and single zero dequeue functions

2019-09-25 Thread Marvin Liu
Optimize vhost zero copy dequeue path like normal dequeue path. Signed-off-by: Marvin Liu diff --git a/lib/librte_vhost/virtio_net.c b/lib/librte_vhost/virtio_net.c index c485e7f49..9ab95763a 100644 --- a/lib/librte_vhost/virtio_net.c +++ b/lib/librte_vhost/virtio_net.c @@ -1881,6 +1881,141 @@ v

[dpdk-dev] [PATCH v3 15/15] vhost: optimize packed ring dequeue when in-order

2019-09-25 Thread Marvin Liu
When VIRTIO_F_IN_ORDER feature is negotiated, vhost can optimize dequeue function by only update first used descriptor. Signed-off-by: Marvin Liu diff --git a/lib/librte_vhost/virtio_net.c b/lib/librte_vhost/virtio_net.c index e3872e384..1e113fb3a 100644 --- a/lib/librte_vhost/virtio_net.c +++ b

[dpdk-dev] [PATCH v3 14/15] vhost: check whether disable software pre-fetch

2019-09-25 Thread Marvin Liu
Disable software pre-fetch actions on Skylake and later platforms. Hardware can fetch needed data for vhost, additional software pre-fetch will impact performance. Signed-off-by: Marvin Liu diff --git a/lib/librte_vhost/Makefile b/lib/librte_vhost/Makefile index 30839a001..5f3b42e56 100644 --- a

[dpdk-dev] [PATCH v3] kni: rework rte_kni_update_link using ioctl

2019-09-25 Thread Igor Ryzhov
Current implementation doesn't allow us to update KNI carrier if the interface is not yet UP in kernel. It means that we can't use it in the same thread which is processing rte_kni_ops.config_network_if, which is very convenient, because it allows us to have correct carrier status of the interface

Re: [dpdk-dev] [PATCH v2 03/16] vhost: add burst enqueue function for packed ring

2019-09-25 Thread Liu, Yong
> -Original Message- > From: Gavin Hu (Arm Technology China) [mailto:gavin...@arm.com] > Sent: Wednesday, September 25, 2019 5:29 PM > To: Liu, Yong ; maxime.coque...@redhat.com; Bie, Tiwei > ; Wang, Zhihong > Cc: dev@dpdk.org; nd ; nd > Subject: RE: [dpdk-dev] [PATCH v2 03/16] vhost:

[dpdk-dev] [PATCH v4 1/4] doc: separate versioning.rst into version and policy

2019-09-25 Thread Ray Kinsella
Separate versioning.rst into abi versioning and abi policy guidance, in preparation for adding more detail to the abi policy. Signed-off-by: Ray Kinsella --- doc/guides/contributing/abi_policy.rst | 169 + doc/guides/contributing/abi_versioning.rst | 427 + doc/gu

[dpdk-dev] [PATCH v4 2/4] doc: changes to abi policy introducing major abi versions

2019-09-25 Thread Ray Kinsella
This policy change introduces major ABI versions, these are declared every year, typically aligned with the LTS release and are supported by subsequent releases in the following year. This change is intended to improve ABI stabilty for those projects consuming DPDK. Signed-off-by: Ray Kinsella --

[dpdk-dev] [PATCH v4 0/4] doc: changes to abi policy introducing major abi versions

2019-09-25 Thread Ray Kinsella
TL;DR abbreviation: A major ABI version that all DPDK releases during a one year period support. ABI versioning is managed at a project-level, in place of library-level management. ABI changes to add new features are permitted, as long as ABI compatibility with the major ABI version is maintained.

[dpdk-dev] [PATCH v4 3/4] doc: updates to versioning guide for abi versions

2019-09-25 Thread Ray Kinsella
Updates to the ABI versioning guide, to account for the changes to the DPDK ABI/API policy. Fixes for references to abi versioning and policy guides. Signed-off-by: Ray Kinsella --- doc/guides/contributing/abi_versioning.rst | 248 +++-- doc/guides/contributing/patches.rs

[dpdk-dev] [PATCH v4 4/4] doc: add maintainer for abi policy

2019-09-25 Thread Ray Kinsella
Add an entry to the maintainer file for the abi policy. Signed-off-by: Ray Kinsella --- MAINTAINERS | 4 1 file changed, 4 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index b3d9aad..d231f03 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -80,6 +80,10 @@ M: Marko Kovacevic F: READM

Re: [dpdk-dev] [PATCH 00/12] net/mlx5: add bonding configuration support

2019-09-25 Thread Matan Azrad
From: Viacheslav Ovsiienko > Multiport Mellanox NICs may support the bonding configurations internally. > Let's suppose there is ConnectX-5 NIC with two physical ports, on the host it > presents two PCI physical functions: > > - PF0, say with PCI address :82:00.0 and net interface ens1f0 >

Re: [dpdk-dev] [PATCH v2 1/2] ethdev: extend RSS offload types

2019-09-25 Thread Ye Xiaolong
On 09/23, Simei Su wrote: >This patch cover two aspects: > (1)decouple RTE_ETH_FLOW_* and ETH_RSS_*. Because both serve > different purposes. I saw in the comment of flow types definition "Note that the flow types are used to define RSS offload types". We need to remove it if we do the dec

[dpdk-dev] Clarification on RTE Flow action

2019-09-25 Thread Kiran Kumar Kokkilagadda
Hi,     We have the following use case and need clarification on which RTE Flow action suits the requirement (ACTION_VF and ACTION_PORT_ID, ..). We have 2 PF's (pf0, pf1) and corresponding VF's (pf0_vf0 , pf1_vf0). And we have 3 applications running. 1st application on pf0 and pf1 2nd applicatio

Re: [dpdk-dev] [DPDK] app/testpmd: fix unused variable compile error

2019-09-25 Thread Andrew Rybchenko
On 9/25/19 8:54 PM, taox@intel.com wrote: From: Zhu Tao This minor patch fixes unused variable ‘ret’ compile error When CONFIG_RTE_LIBRTE_I40E_16BYTE_RX_DESC was selected. Fixes: f5267e485a2a ("app/testpmd: check status of getting ethdev info") Signed-off-by: Zhu Tao Reviewed-by: Andre

[dpdk-dev] [PATCH v2] test/bpf: add new test cases

2019-09-25 Thread Harman Kalra
This patch implements following new test cases: - test_call4: test case to verify if stack corruption occurs across with multiple function calls. - test_jump2: test case with a default packet in memory, parse the packet and check if dest ip is part of a subnet. - test_call5: test case with string d

Re: [dpdk-dev] [PATCH v2 1/2] ethdev: extend RSS offload types

2019-09-25 Thread Ye Xiaolong
On 09/23, Simei Su wrote: >This patch cover two aspects: > (1)decouple RTE_ETH_FLOW_* and ETH_RSS_*. Because both serve > different purposes. > > (2)reserve several bits as input set selection from bottom > of the 64 bits. It is combined with exisiting ETH_RSS_* to > represent rss typ

[dpdk-dev] [PATCH] net/mlx5: adjust inline setting for large Tx queue sizes

2019-09-25 Thread Viacheslav Ovsiienko
The hardware may have limitations on maximal amount of supported Tx descriptors building blocks (WQEBB). Application requires the Tx queue must accept the specified amount of packets. If inline data feature is engaged the packet may require more WQEBBs and overall amount of blocks may exceed the ha

Re: [dpdk-dev] [PATCH v2 1/2] ethdev: extend RSS offload types

2019-09-25 Thread Su, Simei
Hi, xiaolong > -Original Message- > From: Ye, Xiaolong > Sent: Wednesday, September 25, 2019 6:50 PM > To: Su, Simei > Cc: Zhang, Qi Z ; Wu, Jingjing ; > dev@dpdk.org > Subject: Re: [PATCH v2 1/2] ethdev: extend RSS offload types > > On 09/23, Simei Su wrote: > >This patch cover two aspe

[dpdk-dev] [PATCH v2 1/2] mbuf: add bulk free function

2019-09-25 Thread Morten Brørup
Add function for freeing a bulk of mbufs. Signed-off-by: Morten Brørup --- lib/librte_mbuf/rte_mbuf.h | 17 + 1 file changed, 17 insertions(+) diff --git a/lib/librte_mbuf/rte_mbuf.h b/lib/librte_mbuf/rte_mbuf.h index 98225ec80..f2e174da1 100644 --- a/lib/librte_mbuf/rte_mbuf.h

[dpdk-dev] [PATCH v2 2/2] mbuf: add bulk free function

2019-09-25 Thread Morten Brørup
Add function for freeing a bulk of mbufs. Signed-off-by: Morten Brørup --- lib/librte_mbuf/rte_mbuf.c | 35 +++ lib/librte_mbuf/rte_mbuf.h | 16 +--- 2 files changed, 40 insertions(+), 11 deletions(-) diff --git a/lib/librte_mbuf/rte_mbuf.c b/lib/libr

[dpdk-dev] [PATCH v2 0/2] mbuf: add bulk free function

2019-09-25 Thread Morten Brørup
Add function for freeing a bulk of mbufs. v2: * Function is not inline. * Optimized to free multible mbufs belonging to the same mempool in bulk. Inspired by ixgbe_tx_free_bufs(), but allowing NULL pointers in the array, just like rte_pktmbuf_free() can take a NULL pointer. * Use unsigned int inst

Re: [dpdk-dev] [PATCH v2 1/2] ethdev: extend RSS offload types

2019-09-25 Thread Su, Simei
Hi, xiaolong > -Original Message- > From: Ye, Xiaolong > Sent: Wednesday, September 25, 2019 6:28 PM > To: Su, Simei > Cc: Zhang, Qi Z ; Wu, Jingjing ; > dev@dpdk.org > Subject: Re: [PATCH v2 1/2] ethdev: extend RSS offload types > > On 09/23, Simei Su wrote: > >This patch cover two aspe

Re: [dpdk-dev] |WARNING| pw59738 [PATCH v2 2/2] mbuf: add bulk free function

2019-09-25 Thread Morten Brørup
Dear Thomas - listed as checkpatch maintainer, I think this warning is bogus, and is a bug checkpatch. The line in question was deliberately indented using tabs to the current indentation level, and using spaces for the readability alignment. This makes the code readable in editors with another

Re: [dpdk-dev] [PATCH v4 1/4] doc: separate versioning.rst into version and policy

2019-09-25 Thread Neil Horman
On Wed, Sep 25, 2019 at 11:23:53AM +0100, Ray Kinsella wrote: > Separate versioning.rst into abi versioning and abi policy guidance, in > preparation for adding more detail to the abi policy. > > Signed-off-by: Ray Kinsella > --- > doc/guides/contributing/abi_policy.rst | 169 + > do

Re: [dpdk-dev] [PATCH v2 1/2] ethdev: extend RSS offload types

2019-09-25 Thread Ye Xiaolong
On 09/25, Su, Simei wrote: >Hi, xiaolong > >> -Original Message- >> From: Ye, Xiaolong >> Sent: Wednesday, September 25, 2019 6:50 PM >> To: Su, Simei >> Cc: Zhang, Qi Z ; Wu, Jingjing ; >> dev@dpdk.org >> Subject: Re: [PATCH v2 1/2] ethdev: extend RSS offload types >> >> On 09/23, Simei

Re: [dpdk-dev] [PATCH v2 1/2] ethdev: extend RSS offload types

2019-09-25 Thread Ye Xiaolong
On 09/25, Su, Simei wrote: >> >+/* >> >+ * We use the following macros to combine with above ETH_RSS_* for >> >+ * more specific input set selection. These bits are defined starting >> >+ * from the bottom of the 64 bits. >> >> s/bottom/high end/ > > Sorry, what does it mean, I didn't understand i

Re: [dpdk-dev] [PATCH v3 2/4] doc: changes to abi policy introducing major abi versions

2019-09-25 Thread Kevin Traynor
On 24/09/2019 12:32, Ray Kinsella wrote: > > Thanks Kevin for working through all this. > Other comments are inline. > > On 30/08/2019 17:20, Kevin Traynor wrote: >> Hi Ray, >> >> On 15/08/2019 11:23, Ray Kinsella wrote: >>> This policy change introduces major ABI versions, these are >>> declared

Re: [dpdk-dev] [PATCH v2 1/2] ethdev: extend RSS offload types

2019-09-25 Thread Su, Simei
> -Original Message- > From: Ye, Xiaolong > Sent: Wednesday, September 25, 2019 8:23 PM > To: Su, Simei > Cc: Zhang, Qi Z ; Wu, Jingjing ; > dev@dpdk.org > Subject: Re: [PATCH v2 1/2] ethdev: extend RSS offload types > > On 09/25, Su, Simei wrote: > >Hi, xiaolong > > > >> -Original

Re: [dpdk-dev] [PATCH v2 1/2] ethdev: extend RSS offload types

2019-09-25 Thread Su, Simei
> -Original Message- > From: Ye, Xiaolong > Sent: Wednesday, September 25, 2019 8:24 PM > To: Su, Simei > Cc: Zhang, Qi Z ; Wu, Jingjing ; > dev@dpdk.org > Subject: Re: [PATCH v2 1/2] ethdev: extend RSS offload types > > On 09/25, Su, Simei wrote: > >> >+/* > >> >+ * We use the followi

Re: [dpdk-dev] [PATCH v4 1/4] doc: separate versioning.rst into version and policy

2019-09-25 Thread Ray Kinsella
Hi Neil, Thanks for the feedback, other comment below. On 25/09/2019 13:24, Neil Horman wrote: > On Wed, Sep 25, 2019 at 11:23:53AM +0100, Ray Kinsella wrote: >> Separate versioning.rst into abi versioning and abi policy guidance, in >> preparation for adding more detail to the abi policy. >> >>

Re: [dpdk-dev] [RFC] Proposals and notes from ABI stability panel @ DPDK Userspace

2019-09-25 Thread Kevin Traynor
On 23/09/2019 18:51, Ray Kinsella wrote: > Folks, > > As you may be aware, there was a panel on ABI Stability @ DPDK > Userspace. There where a number of proposed amendments to the ABI > stability proposal made, as well as a number of points and comments, you > will find all these below. The prop

[dpdk-dev] [PATCH v3 2/2] app/testpmd: add RSS offload types extending support

2019-09-25 Thread Simei Su
This patch adds cmdline support for extended rss types configuration. Signed-off-by: Simei Su --- app/test-pmd/config.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/app/test-pmd/config.c b/app/test-pmd/config.c index 1a5a5c1..b95bd43 100644 --- a/app/test-pmd/config.c +++ b/app/test

[dpdk-dev] [PATCH v3 0/2] extend RSS offload types

2019-09-25 Thread Simei Su
[PATCH v3 1/2] ethdev: add several bits for extending rss offload types. [PATCH v3 2/2] app/testpmd: add cmdline support for extending rss types. v3: * update code comments and code style. v2: * Revise annotation. Simei Su (2): ethdev: extend RSS offload types app/testpmd: add RSS offload ty

[dpdk-dev] [PATCH v3 1/2] ethdev: extend RSS offload types

2019-09-25 Thread Simei Su
This patch cover two aspects: (1)decouple RTE_ETH_FLOW_* and ETH_RSS_*. Because both serve different purposes. (2)reserve several bits as input set selection from the high end of the 64 bits. It is combined with exisiting ETH_RSS_* to represent rss types. for example: ETH

[dpdk-dev] [PATCH v2 00/17] Add advanced features for Huawei hinic pmd

2019-09-25 Thread Xiaoyun wang
This patch set adds advanced features for Huawei hinic pmd, such as VLAN filter and VLAN offload, SR-IOV, FW version get, set link down and up, Flow director for LACP, VRRP, BGP and so on. Xiaoyun wang (17): net/hinic/base: add mbox command channel for SRIOV net/hinic/base: add HW interfaces f

[dpdk-dev] [PATCH v2 01/17] net/hinic/base: add mbox command channel for SRIOV

2019-09-25 Thread Xiaoyun wang
Add mbox command channel for SRIOV, which is used to communicate between VF and VF, VF and PF. This patch introduces data structures, initialization, interfaces and commands of mbox channel. Signed-off-by: Xiaoyun wang --- drivers/net/hinic/Makefile | 1 + drivers/net/hinic/base/

[dpdk-dev] [PATCH v2 02/17] net/hinic/base: add HW interfaces for SRIOV

2019-09-25 Thread Xiaoyun wang
This patch introduces some HW interfaces required for SRIOV function, including: init hwdev, set port state, get default cos, vf dma attribute table, vf txrx flush and so on. Signed-off-by: Xiaoyun wang --- drivers/net/hinic/base/hinic_compat.h | 32 drivers/net/hinic/base/hinic_pmd_a

[dpdk-dev] [PATCH v2 03/17] net/hinic: add VF PMD operation interfaces

2019-09-25 Thread Xiaoyun wang
This patch adds VF PMD operation interfaces to support SRIOV. Signed-off-by: Xiaoyun wang --- drivers/net/hinic/base/hinic_pmd_niccfg.c | 35 drivers/net/hinic/base/hinic_pmd_niccfg.h | 14 ++ drivers/net/hinic/hinic_pmd_ethdev.c | 255 -- 3 files changed,

[dpdk-dev] [PATCH v2 05/17] net/hinic: add allmulticast mode and MTU set

2019-09-25 Thread Xiaoyun wang
When enable allmulticast mode, all multicast packets can be received. This patch also adds support for mtu set, the range of MTU is from 256 to 9600. Signed-off-by: Xiaoyun wang --- drivers/net/hinic/hinic_pmd_ethdev.c | 108 ++- drivers/net/hinic/hinic_pmd_ethdev

[dpdk-dev] [PATCH v2 04/17] net/hinic: add VLAN filter and offload

2019-09-25 Thread Xiaoyun wang
This patch adds support for VLAN filter and VLAN offload. Signed-off-by: Xiaoyun wang --- drivers/net/hinic/base/hinic_pmd_cmd.h| 1 + drivers/net/hinic/base/hinic_pmd_niccfg.c | 136 + drivers/net/hinic/base/hinic_pmd_niccfg.h | 29 + drivers/net/hinic/hinic_pmd_e

[dpdk-dev] [PATCH v2 06/17] net/hinic: add unicast and multicast MAC set

2019-09-25 Thread Xiaoyun wang
This patch adds unicast and multicast set interfaces. Application can add or remove unicast MAC address, also can set multicast MAC address, tha maximum multicast list size is 2048. Signed-off-by: Xiaoyun wang --- drivers/net/hinic/base/hinic_pmd_niccfg.c | 55 +++ drivers/net/hinic/hinic_p

[dpdk-dev] [PATCH v2 07/17] net/hinic: add fdir config interface

2019-09-25 Thread Xiaoyun wang
This patch adds fdir config operation, including set fdir filter, normal filter, set and clear fdir tcam. Signed-off-by: Xiaoyun wang --- drivers/net/hinic/base/hinic_pmd_cmd.h| 2 + drivers/net/hinic/base/hinic_pmd_niccfg.c | 205 ++ drivers/net/hinic/base/hini

[dpdk-dev] [PATCH v2 08/17] net/hinic: add fdir validate flow operations

2019-09-25 Thread Xiaoyun wang
This patch is to validate the filter rules, which includes ntuple filter, ethertype filter and fdir filter. The packets type that supported are BGP,VRRP,LACP,ARP and ICMP. Signed-off-by: Xiaoyun wang --- drivers/net/hinic/Makefile |1 + drivers/net/hinic/hinic_pmd_ethdev.c | 42 +

[dpdk-dev] [PATCH v2 10/17] net/hinic: create and destroy fdir filter

2019-09-25 Thread Xiaoyun wang
Add support for creating/destroying fdir filter. The filter rule includes LACP,ARP and ICMP packet type. Signed-off-by: Xiaoyun wang --- drivers/net/hinic/hinic_pmd_ethdev.h | 16 ++ drivers/net/hinic/hinic_pmd_flow.c | 423 +-- 2 files changed, 422 insertions(

[dpdk-dev] [PATCH v2 09/17] net/hinic: create and destroy ntuple filter

2019-09-25 Thread Xiaoyun wang
Add support for creating/destroying ntuple filter. The filter rule includes BGP and VRRP packet type. Signed-off-by: Xiaoyun wang --- drivers/net/hinic/hinic_pmd_ethdev.h | 75 drivers/net/hinic/hinic_pmd_flow.c | 684 +++ 2 files changed, 759 insertions(+

[dpdk-dev] [PATCH v2 13/17] net/hinic: support inner L3 checksum offload

2019-09-25 Thread Xiaoyun wang
This patch supports inner L3 checksum offload, modifies rx checksum offload. Signed-off-by: Xiaoyun wang --- drivers/net/hinic/hinic_pmd_ethdev.h | 1 + drivers/net/hinic/hinic_pmd_rx.c | 10 +- drivers/net/hinic/hinic_pmd_tx.c | 190 ++- 3 files change

[dpdk-dev] [PATCH v2 11/17] net/hinic: flush fdir filter

2019-09-25 Thread Xiaoyun wang
Supports to flush fdir filter. Destroy all flow rules associated with a port on hinic. Signed-off-by: Xiaoyun wang --- drivers/net/hinic/hinic_pmd_ethdev.c | 16 drivers/net/hinic/hinic_pmd_ethdev.h | 3 +- drivers/net/hinic/hinic_pmd_flow.c | 140 +++ 3

[dpdk-dev] [PATCH v2 15/17] net/hinic: add hinic PMD doc files

2019-09-25 Thread Xiaoyun wang
Add doc files about new features and modification. Signed-off-by: Xiaoyun wang --- doc/guides/nics/features/hinic.ini | 12 - doc/guides/nics/hinic.rst | 6 + doc/guides/rel_notes/release_19_11.rst | 45 ++ 3 files changed, 25 inserti

[dpdk-dev] [PATCH v2 12/17] net/hinic: set link down and up

2019-09-25 Thread Xiaoyun wang
This patch supports setting link down and up, Also adds support for geting firmware version. Signed-off-by: Xiaoyun wang --- drivers/net/hinic/base/hinic_pmd_cmd.h| 4 ++ drivers/net/hinic/base/hinic_pmd_niccfg.c | 78 drivers/net/hinic/base/hinic_pmd_niccfg.h |

[dpdk-dev] [PATCH v2 16/17] net/hinic/base: optimize aeq interfaces

2019-09-25 Thread Xiaoyun wang
This patch deletes ceq interfaces that not needed, fix aeq buges in some scenarios. Signed-off-by: Xiaoyun wang --- drivers/net/hinic/base/hinic_csr.h | 29 +--- drivers/net/hinic/base/hinic_pmd_cmd.h | 5 +- drivers/net/hinic/base/hinic_pmd_eqs.c | 245 +

[dpdk-dev] [PATCH v2 14/17] net/hinic: support LRO offload

2019-09-25 Thread Xiaoyun wang
This patch supports LRO offload. Signed-off-by: Xiaoyun wang --- drivers/net/hinic/hinic_pmd_ethdev.c | 24 ++-- 1 file changed, 18 insertions(+), 6 deletions(-) diff --git a/drivers/net/hinic/hinic_pmd_ethdev.c b/drivers/net/hinic/hinic_pmd_ethdev.c index 8ea5998..6f3eb18

[dpdk-dev] [PATCH v2 17/17] net/hinic: optimize tx&rx performance

2019-09-25 Thread Xiaoyun wang
This patch optimizes receive packets performance in arm platform. Signed-off-by: Xiaoyun wang --- drivers/net/hinic/hinic_pmd_rx.c | 17 + drivers/net/hinic/hinic_pmd_rx.h | 11 +++ 2 files changed, 28 insertions(+) diff --git a/drivers/net/hinic/hinic_pmd_rx.c b/drivers

Re: [dpdk-dev] [PATCH v7 00/10] vhost: support inflight share memory protocol feature

2019-09-25 Thread Tiwei Bie
> [PATCH v7 00/10] vhost: support inflight share memory protocol feature This should be v8. Please increase the version number when sending a new series. Thanks, Tiwei On Fri, Sep 20, 2019 at 08:00:52PM +0800, Jin Yu wrote: > This patches introduces two new messages VHOST_USER_GET_INFLIGHT_FD

Re: [dpdk-dev] [RFC] Proposals and notes from ABI stability panel @ DPDK Userspace

2019-09-25 Thread Ray Kinsella
> In the short term, based on the feedback at the conference and to give > something concrete to be considered, here is a suggestion, > > ABI freeze starts at 20.02 for 9 months, with a review as planned to see > if 20.11 should be frozen 2 years. > > pros: > + Eliminates any need for delaying

Re: [dpdk-dev] [PATCH v4 1/4] doc: separate versioning.rst into version and policy

2019-09-25 Thread Neil Horman
On Wed, Sep 25, 2019 at 02:01:01PM +0100, Ray Kinsella wrote: > Hi Neil, > > Thanks for the feedback, other comment below. > > On 25/09/2019 13:24, Neil Horman wrote: > > On Wed, Sep 25, 2019 at 11:23:53AM +0100, Ray Kinsella wrote: > >> Separate versioning.rst into abi versioning and abi policy

Re: [dpdk-dev] [dpdk-techboard] [RFC] Proposals and notes from ABI stability panel @ DPDK Userspace

2019-09-25 Thread Bruce Richardson
On Wed, Sep 25, 2019 at 03:29:16PM +0100, Ray Kinsella wrote: > > > In the short term, based on the feedback at the conference and to give > > something concrete to be considered, here is a suggestion, > > > > ABI freeze starts at 20.02 for 9 months, with a review as planned to see > > if 20.11 s

  1   2   >