[dpdk-dev] [PATCH v3 10/14] net/ppfe: add supported packet types and basic statistics

2019-10-01 Thread Gagandeep Singh
This patch add support for supported packet types by the platform andbasic statistics like numbers of packets/bytes receive and transmit. Signed-off-by: Gagandeep Singh Acked-by: Nipun Gupta Acked-by: Akhil Goyal --- doc/guides/nics/features/ppfe.ini | 2 ++ doc/guides/nics/ppfe.rst

[dpdk-dev] [PATCH v3 07/14] net/ppfe: add device start stop operations

2019-10-01 Thread Gagandeep Singh
This patch adds device start, stop and close operations. Signed-off-by: Gagandeep Singh Signed-off-by: Akhil Goyal Acked-by: Nipun Gupta --- drivers/net/ppfe/Makefile | 2 +- drivers/net/ppfe/pfe_eth.h | 1 + drivers/net/ppfe/pfe_hif.c | 139 + drivers/net/ppfe/pfe

[dpdk-dev] [PATCH v3 09/14] net/ppfe: add burst enqueue and dequeue operations

2019-10-01 Thread Gagandeep Singh
This patch add burst enqueue and dequeue operations to the ppfe PMD. Signed-off-by: Gagandeep Singh Acked-by: Nipun Gupta Acked-by: Akhil Goyal --- drivers/net/ppfe/pfe_hif.c | 360 - drivers/net/ppfe/pfe_hif.h | 8 + drivers/net/ppfe/pfe_hif_lib.c | 1

[dpdk-dev] [PATCH v3 12/14] net/ppfe: add allmulticast and promiscuous

2019-10-01 Thread Gagandeep Singh
This patch adds support to enable multicast and promiscuous mode. Signed-off-by: Gagandeep Singh Acked-by: Nipun Gupta Acked-by: Akhil Goyal --- doc/guides/nics/features/ppfe.ini | 2 ++ doc/guides/nics/ppfe.rst | 2 ++ drivers/net/ppfe/ppfe_ethdev.c| 42

[dpdk-dev] [PATCH v3 11/14] net/ppfe: add MTU and MAC address set operations

2019-10-01 Thread Gagandeep Singh
To update MAC address or MTU, operations are added to the driver. Signed-off-by: Gagandeep Singh Acked-by: Nipun Gupta Acked-by: Akhil Goyal --- doc/guides/nics/features/ppfe.ini | 1 + doc/guides/nics/ppfe.rst | 1 + drivers/net/ppfe/ppfe_ethdev.c| 63 ++

[dpdk-dev] [PATCH v3 14/14] doc: add NXP PPFE PMD in release notes

2019-10-01 Thread Gagandeep Singh
Update release notes for NXP PPFE driver supported for 19.11. Signed-off-by: Gagandeep Singh --- doc/guides/rel_notes/release_19_11.rst | 5 + 1 file changed, 5 insertions(+) diff --git a/doc/guides/rel_notes/release_19_11.rst b/doc/guides/rel_notes/release_19_11.rst index cd4e35061..9ec26

[dpdk-dev] [PATCH v3 13/14] net/ppfe: add link status update

2019-10-01 Thread Gagandeep Singh
This patch add link related operations like link update, up and down. Signed-off-by: Gagandeep Singh Acked-by: Nipun Gupta Acked-by: Akhil Goyal --- doc/guides/nics/features/ppfe.ini | 1 + doc/guides/nics/ppfe.rst | 1 + drivers/net/ppfe/ppfe_ethdev.c| 106 +++

[dpdk-dev] [PATCH 4/6] test/event_crypto: support to release the atomic ctxt

2019-10-01 Thread Hemant Agrawal
The test cases uses ATOMIC queues. Once the packet is recived it is required to release the ATOMIC ctxt, at least for the HW based eventdevs. This patch makes empty dq call, which in turn releases the atomic ctxt. Signed-off-by: Hemant Agrawal --- app/test/test_event_crypto_adapter.c | 6 ++

[dpdk-dev] [PATCH 6/6] test/event_crypto: separate the NEW and FWD mode inits

2019-10-01 Thread Hemant Agrawal
The earlier patch was using a single method to init the crypto adapter for FWD and NEW mode, which was also causing the adapter mode to be set incorrectly for NEW mode. This patch segregate the init for NEW and FWD modes. In case of NEW mode the packets will be directly sent to the cryptodev, so p

[dpdk-dev] [PATCH 1/6] test/event_crypto: fix missing IV value for AES algo

2019-10-01 Thread Hemant Agrawal
The IV was not set, which was causing HW based SEC on DPAA1 to fail. Fixes: ce02103ad072 ("test/event_crypto: change the SEC cipher algo") Signed-off-by: Hemant Agrawal --- Please squash if possible. app/test/test_event_crypto_adapter.c | 12 1 file changed, 12 insertions(+) diff

[dpdk-dev] [PATCH 5/6] test/event_crypto: use device cap instead of fixed values

2019-10-01 Thread Hemant Agrawal
Instead of hardcoded event device capabilities, it is better to enquire and use the device supported caps. Signed-off-by: Hemant Agrawal --- app/test/test_event_crypto_adapter.c | 19 --- 1 file changed, 8 insertions(+), 11 deletions(-) diff --git a/app/test/test_event_crypto_ad

[dpdk-dev] [PATCH 2/6] test/event_crypto: fix check for HW support

2019-10-01 Thread Hemant Agrawal
When HW is available but the mode mismatches, it is better to skip the test case. Fixes: cfe599b325e8 ("test/event_crypto: no service core when HW support available") Signed-off-by: Hemant Agrawal --- please squash if possible. app/test/test_event_crypto_adapter.c | 16 1 fil

[dpdk-dev] [PATCH 3/6] test/event_crypto: fix to avail the mempool entries

2019-10-01 Thread Hemant Agrawal
Added the missed code to avail the mempool entries before pool free. Fixes: 24054e3640a2 ("test/crypto: use separate session mempools"); Cc: sta...@dpdk.org Signed-off-by: Hemant Agrawal --- The file location has been changed, thus check-git-log is giving err on this patch app/test/test_event_c

Re: [dpdk-dev] [PATCH] eventdev: flag to identify same destined packets enqueue

2019-10-01 Thread Nipun Gupta
> -Original Message- > From: Jerin Jacob > Sent: Tuesday, October 1, 2019 1:14 PM > To: Nipun Gupta > Cc: dpdk-dev ; Jerin Jacob ; Pavan > Nikhilesh ; Sunil Kumar Kori ; > Hemant Agrawal ; Richardson, Bruce > ; Marko Kovacevic > ; Ori Kam ; Radu Nicolau > ; Tomasz Kantecki ; Van > Haare

[dpdk-dev] [PATCH 1/2] test/crypto: change the failure condition check

2019-10-01 Thread Hemant Agrawal
In some of the cases, the test is looking for a specific failure returned from the CryptoDev. Not all cryptodev support returning specific errors. This patch changes such checks to NOT-SUCCESS Signed-off-by: Hemant Agrawal --- app/test/test_cryptodev.c | 12 ++-- 1 file changed, 6 insert

[dpdk-dev] [PATCH 2/2] test/crypto: add negative test support for dpaaX

2019-10-01 Thread Hemant Agrawal
Signed-off-by: Hemant Agrawal --- app/test/test_cryptodev.c | 20 1 file changed, 20 insertions(+) diff --git a/app/test/test_cryptodev.c b/app/test/test_cryptodev.c index 915acf13c..eb2cfdde6 100644 --- a/app/test/test_cryptodev.c +++ b/app/test/test_cryptodev.c @@ -11513,6

Re: [dpdk-dev] [PATCH 2/5] lib/ring: add template to support different element sizes

2019-10-01 Thread Ananyev, Konstantin
> > > Add templates to support creating ring APIs with different > ring element sizes. > > Signed-off-by: Honnappa Nagarahalli > Reviewed-by: Dharmik Thakkar > Reviewed-by: Gavin Hu > Reviewed-by: Ruifeng Wang > --- > lib/librte_ring/Makefile| 4 +- > lib/librte_ring/meson.

Re: [dpdk-dev] [PATCH v5 4/7] drivers/net: update Rx RSS hash offload capabilities

2019-10-01 Thread Hemant Agrawal
> diff --git a/drivers/net/dpaa/dpaa_ethdev.c > b/drivers/net/dpaa/dpaa_ethdev.c index 7154fb9b4..18c7bd0d5 100644 > --- a/drivers/net/dpaa/dpaa_ethdev.c > +++ b/drivers/net/dpaa/dpaa_ethdev.c > @@ -49,7 +49,8 @@ > /* Supported Rx offloads */ > static uint64_t dev_rx_offloads_sup = >

Re: [dpdk-dev] [PATCH 0/7] net/mlx5: support for flow action on VLAN header

2019-10-01 Thread Hideyuki Yamashita
Hello Moti, I have some questions on the patch. Just want to know how to use it. Q1. Is it correct understanding that the patch will be reflected in 19.11 if it is approved? Q2.Which action should I specify when I want to insert VLAN tag to non-VLAN frame? OF_PUSH_VLAN and OF_SET_VLAN_VID and O

Re: [dpdk-dev] [PATCH 2/8] crypto/octeontx: add RSA and modexp asym capabilities

2019-10-01 Thread Akhil Goyal
Hi Anoob, > const struct rte_cryptodev_capabilities * > -otx_get_capabilities(void) > +otx_get_capabilities(uint64_t flags) > { > - return otx_capabilities; > + if (flags & RTE_CRYPTODEV_FF_ASYMMETRIC_CRYPTO) > + return otx_asym_capabilities; > + else > + retu

Re: [dpdk-dev] [PATCH v6 1/4] doc: separate versioning.rst into version and policy

2019-10-01 Thread Hemant Agrawal
Hi Ray, > +DPDK ABI/API policy > +=== > + > +Description > +--- > + > +This document details some methods for handling ABI management in the > DPDK. > + > +General Guidelines > +-- > + > +#. Whenever possible, ABI should be preserved #. ABI/API may be change

[dpdk-dev] [PATCH 1/9] net/pcap: fix argument checks

2019-10-01 Thread Kevin Traynor
Previously rx/tx_queues were passed into eth_from_pcaps_common() as ptrs and were checked for being NULL. In commit da6ba28f0540 ("net/pcap: use a struct to pass user options") that changed to pass in a ptr to a pmd_devargs_all which contains the rx/tx_queues. The parameter checking was not updat

[dpdk-dev] [PATCH 0/9] Coverity fixes and other cleanups

2019-10-01 Thread Kevin Traynor
Patches 1-5 are Coverity fixes. Patches 6-9 are removing commented out code. Kevin Traynor (9): net/pcap: fix argument checks crypto/octeontx: fix possible NULL deference net/bnxt: remove logically dead code net/ipn3ke: fix incorrect commit check logic net/ipn3ke: remove useless if state

Re: [dpdk-dev] [PATCH v1] eal: add manual probing option

2019-10-01 Thread Aaron Conole
Gaëtan Rivet writes: > On Mon, Sep 30, 2019 at 01:51:35PM -0400, Aaron Conole wrote: >> Gaetan Rivet writes: >> >> > Add a new EAL option enabling manual probing in the EAL. >> > This command line option will configure the EAL so that buses >> > will not trigger their probe step on their own. >

Re: [dpdk-dev] [PATCH 3/8] crypto/octeontx: add asymmetric session operations

2019-10-01 Thread Akhil Goyal
Hi Anoob, Just a couple of nits > + > +static __rte_always_inline void > +cpt_modex_param_normalize(uint8_t **data, size_t *len) > +{ > + size_t i; > + > + /* Strip leading NUL bytes */ Typo NULL > + > + for (i = 0; i < *len; i++) { > + if ((*data)[i] != 0) > +

[dpdk-dev] [PATCH 4/9] net/ipn3ke: fix incorrect commit check logic

2019-10-01 Thread Kevin Traynor
Coverity is complaining about identical code regardless of which branch of the if else is taken. Functionally it means an error will always be returned if this if else is hit. Remove the else branch. CID 337928 (#1 of 1): Identical code for different branches (IDENTICAL_BRANCHES)identical_

[dpdk-dev] [PATCH 3/9] net/bnxt: remove logically dead code

2019-10-01 Thread Kevin Traynor
If rc contains a non-zero return code from bnxt_hwrm_send_message(), HWRM_CHECK_RESULT_SILENT() will return. Just after that code, there is an 'if (!rc) {...} else {...}'. Coverity is complaining that this if else statement is dead code as rc will always be 0 if that code is reached. 4309

[dpdk-dev] [PATCH 5/9] net/ipn3ke: remove useless if statement

2019-10-01 Thread Kevin Traynor
Coverity complains that this statement is not needed as the goto label is on the next line anyway. Remove the if statement. 653ret = ipn3ke_cfg_parse_i40e_pf_ethdev(afu_name, pf_name); CID 337930 (#1 of 1): Identical code for different branches (IDENTICAL_BRANCHES)identical_branches:

[dpdk-dev] [PATCH 6/9] net/ipn3ke: remove commented out code

2019-10-01 Thread Kevin Traynor
These struct members and variable were commented out. Remove them. Fixes: c01c748e4ae6 ("net/ipn3ke: add new driver") Fixes: c820468ac99c ("net/ipn3ke: support TM") Cc: rosen...@intel.com Cc: sta...@dpdk.org Signed-off-by: Kevin Traynor --- drivers/net/ipn3ke/ipn3ke_ethdev.h | 7 --- driver

[dpdk-dev] [PATCH 2/9] crypto/octeontx: fix possible NULL deference

2019-10-01 Thread Kevin Traynor
Coverity complains that ctrl_flags is set to NULL at the start of the function and it may not have been set before there is a jump to fc_success and it is dereferenced. Check for NULL before dereference. 312fc_success: CID 344983 (#1 of 1): Explicit null dereferenced (FORWARD_NULL)7. var_de

[dpdk-dev] [PATCH 7/9] compress/octeontx: remove commented out code

2019-10-01 Thread Kevin Traynor
This code is commented out. Remove it. Fixes: 43e610bb8565 ("compress/octeontx: introduce octeontx zip PMD") Cc: ss...@marvell.com Cc: sta...@dpdk.org Signed-off-by: Kevin Traynor --- drivers/compress/octeontx/include/zip_regs.h | 8 1 file changed, 8 deletions(-) diff --git a/drivers

Re: [dpdk-dev] [PATCH 4/8] common/cpt: add helper functions for asymmetric crypto

2019-10-01 Thread Akhil Goyal
Hi Anoob, > > From: Kanaka Durga Kotamarthy > > Add helper functions to get meta len for asymmetric operations > > Signed-off-by: Anoob Joseph > Signed-off-by: Kanaka Durga Kotamarthy > Signed-off-by: Sunila Sahu > --- > diff --git a/drivers/crypto/octeontx/otx_cryptodev_hw_access.c > b/d

[dpdk-dev] [PATCH 8/9] event/opdl: remove commented out code

2019-10-01 Thread Kevin Traynor
Some variables are commented out. Remove them. Fixes: d548ef513cd7 ("event/opdl: add unit tests") Cc: liang.j...@intel.com Cc: sta...@dpdk.org Signed-off-by: Kevin Traynor --- drivers/event/opdl/opdl_test.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/event/opdl/opdl_test.c b/d

[dpdk-dev] [PATCH 9/9] net/bnxt: remove commented out code

2019-10-01 Thread Kevin Traynor
This commented out todo and code is old. Remove it. Fixes: b7435d660a8c ("net/bnxt: add ntuple filtering support") Cc: ajit.khapa...@broadcom.com Cc: sta...@dpdk.org Signed-off-by: Kevin Traynor --- drivers/net/bnxt/bnxt_ethdev.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/net

Re: [dpdk-dev] [PATCH] eventdev: flag to identify same destined packets enqueue

2019-10-01 Thread Jerin Jacob
On Tue, Oct 1, 2019 at 5:11 PM Nipun Gupta wrote: > > > > > -Original Message- > > From: Jerin Jacob > > Sent: Tuesday, October 1, 2019 1:14 PM > > To: Nipun Gupta > > Cc: dpdk-dev ; Jerin Jacob ; Pavan > > Nikhilesh ; Sunil Kumar Kori ; > > Hemant Agrawal ; Richardson, Bruce > > ; Marko

Re: [dpdk-dev] [PATCH 1/2] crypto/dpaa_sec: support event crypto adapter

2019-10-01 Thread Jerin Jacob
On Tue, Oct 1, 2019 at 12:01 PM Akhil Goyal wrote: > > > > > > > > > > meson cross-build is failing with this patch. Please fix it in v2 and > > > > If it makes sense then add this new feature in release notes. > > > > > > V2 sent with the required changes. > > > > Looks like there are still error

Re: [dpdk-dev] [PATCH v6 1/4] doc: separate versioning.rst into version and policy

2019-10-01 Thread Ray Kinsella
Hemant, Patch 1/4 - doc: separate versioning.rst into version and policy. So it essentially re-organizes the existing policy into two separate documents, one dealing with the policy and the other dealing with the mechanics of abi versioning Patch 2/4 - doc: changes to abi policy introducing maj

Re: [dpdk-dev] [PATCH v2 2/2] build: support building ABI versioned files twice

2019-10-01 Thread Andrzej Ostruszka
Thanks Bruce for the patch. I like the idea of splitting versioning out of rte_compat.h, but I have some comments. On 9/27/19 10:59 PM, Bruce Richardson wrote: [...] > --- a/config/common_base > +++ b/config/common_base > @@ -111,6 +111,7 @@ CONFIG_RTE_MAX_VFIO_CONTAINERS=64 > CONFIG_RTE_MALLOC_

Re: [dpdk-dev] [PATCH 8/8] doc: update octeontx asymmetric features

2019-10-01 Thread Akhil Goyal
Hi Anoob, > > From: Sunila Sahu > > Update documentation with supported asymmetric features for octeontx > > Signed-off-by: Anoob Joseph > Signed-off-by: Kanaka Durga Kotamarthy > Signed-off-by: Sunila Sahu > --- > doc/guides/cryptodevs/features/octeontx.ini | 6 +- > doc/guides/crypt

Re: [dpdk-dev] [PATCH v3 2/6] mbuf: delinline rte_pktmbuf_linearize

2019-10-01 Thread Andrew Rybchenko
On 9/30/19 10:20 PM, Stephen Hemminger wrote: This copy part of this function is too big to be put inline. The places it is used are only in special exception paths where a highly fragmented mbuf arrives at a device that can't handle it. Signed-off-by: Stephen Hemminger Acked-by: Andrew Rybch

Re: [dpdk-dev] [PATCH v3 1/2] ethdev: add symmetric toeplitz hash support

2019-10-01 Thread Andrew Rybchenko
On 10/1/19 12:22 PM, Simei Su wrote: Currently, there are DEFAULT,TOEPLITZ and SIMPLE_XOR hash function. To support symmetric hash by rte_flow RSS action, this patch adds new hash function "Symmetric Toeplitz" which is supported by some hardware. Signed-off-by: Simei Su Reviewed-by: Qi Zhang A

Re: [dpdk-dev] [PATCH v3 3/6] mbuf: deinline rte_pktmbuf_clone

2019-10-01 Thread Andrew Rybchenko
On 9/30/19 10:20 PM, Stephen Hemminger wrote: Cloning mbufs requires allocations and iteration and therefore should not be an inline. Signed-off-by: Stephen Hemminger Acked-by: Andrew Rybchenko

Re: [dpdk-dev] [PATCH] eventdev: flag to identify same destined packets enqueue

2019-10-01 Thread Nipun Gupta
> -Original Message- > From: Jerin Jacob > Sent: Tuesday, October 1, 2019 6:40 PM > To: Nipun Gupta > Cc: dpdk-dev ; Jerin Jacob ; Pavan > Nikhilesh ; Sunil Kumar Kori > ; Hemant Agrawal ; > Richardson, Bruce ; Marko Kovacevic > ; Ori Kam ; Radu > Nicolau ; Tomasz Kantecki > ; Van Haare

Re: [dpdk-dev] [PATCH v3 4/6] mbuf: add a pktmbuf copy routine

2019-10-01 Thread Andrew Rybchenko
On 9/30/19 10:20 PM, Stephen Hemminger wrote: This is a commonly used operation that surprisingly the DPDK has not supported. The new rte_pktmbuf_copy does a deep copy of packet. This is a complete copy including meta-data. It handles the case where the source mbuf comes from a pool with larger

Re: [dpdk-dev] [PATCH v1] eal: add manual probing option

2019-10-01 Thread Gaëtan Rivet
On Tue, Oct 01, 2019 at 03:19:42PM +0530, Jerin Jacob wrote: > On Tue, Oct 1, 2019 at 2:40 PM Gaëtan Rivet wrote: > > > > On Mon, Sep 30, 2019 at 11:53:33AM -0700, Stephen Hemminger wrote: > > > On Mon, 30 Sep 2019 14:51:03 +0200 > > > Gaetan Rivet wrote: > > > > > > > Add a new EAL option enabli

Re: [dpdk-dev] [PATCH 4/6] crypto/octeontx2: add asymmetric in enqueue/dequeue ops

2019-10-01 Thread Akhil Goyal
Hi Anoob, > static __rte_always_inline int __hot > otx2_cpt_enqueue_sym(struct otx2_cpt_qp *qp, struct rte_crypto_op *op, >struct pending_queue *pend_q) > @@ -488,7 +560,9 @@ otx2_cpt_enqueue_burst(void *qptr, struct > rte_crypto_op **ops, uint16_t nb_ops) > > for (c

Re: [dpdk-dev] [PATCH 5/6] app/test: register octeontx2 PMD to asym testsuite

2019-10-01 Thread Akhil Goyal
> > From: Sunila Sahu > > This patch updates asymmetric crypto unit-test application to > validate asymmetric crypto operation supported by octeontx2 PMD. > > Signed-off-by: Anoob Joseph > Signed-off-by: Kanaka Durga Kotamarthy > Signed-off-by: Sunila Sahu > --- > app/test/test_cryptodev_as

Re: [dpdk-dev] [PATCH] eventdev: flag to identify same destined packets enqueue

2019-10-01 Thread Jerin Jacob
On Tue, Oct 1, 2019 at 7:32 PM Nipun Gupta wrote: > > > > > -Original Message- > > From: Jerin Jacob > > Sent: Tuesday, October 1, 2019 6:40 PM > > To: Nipun Gupta > > Cc: dpdk-dev ; Jerin Jacob ; Pavan > > Nikhilesh ; Sunil Kumar Kori > > ; Hemant Agrawal ; > > Richardson, Bruce ; Marko

Re: [dpdk-dev] [PATCH v1] eal: add manual probing option

2019-10-01 Thread Jerin Jacob
On Tue, Oct 1, 2019 at 7:39 PM Gaëtan Rivet wrote: > > On Tue, Oct 01, 2019 at 03:19:42PM +0530, Jerin Jacob wrote: > > On Tue, Oct 1, 2019 at 2:40 PM Gaėtan Rivet wrote: > > > > > > On Mon, Sep 30, 2019 at 11:53:33AM -0700, Stephen Hemminger wrote: > > > > On Mon, 30 Sep 2019 14:51:03 +0200 > >

[dpdk-dev] [PATCH v8 0/3] extend RSS offload types

2019-10-01 Thread Simei Su
[PATCH v8 1/3] ethdev: decouple flow types and RSS offload types. [PATCH v8 2/3] ethdev: add several bits for extending rss offload types. [PATCH v8 3/3] app/testpmd: add cmdline support for extending rss types. v8: * Add to check the simultaneous use of SRC/DST_ONLY of the same level in rte_eth

[dpdk-dev] [PATCH v8 2/3] ethdev: extend RSS offload types

2019-10-01 Thread Simei Su
This patch reserves several bits as input set selection from the high end of the 64 bits. It is combined with exisiting ETH_RSS_* to represent RSS types. Signed-off-by: Simei Su Reviewed-by: Qi Zhang Acked-by: Ori Kam --- lib/librte_ethdev/rte_ethdev.c | 22 ++ lib/librte_e

[dpdk-dev] [PATCH v8 3/3] app/testpmd: add RSS offload types extending support

2019-10-01 Thread Simei Su
This patch adds cmdline support for extended rss types configuration. Signed-off-by: Simei Su Reviewed-by: Qi Zhang --- app/test-pmd/cmdline.c | 18 +++--- app/test-pmd/config.c | 4 2 files changed, 19 insertions(+), 3 deletions(-) diff --git a/app/test-pmd/cmdline.c b/app/

[dpdk-dev] [PATCH v8 1/3] ethdev: decouple flow types and RSS offload types

2019-10-01 Thread Simei Su
This patch decouples RTE_ETH_FLOW_* and ETH_RSS_*. The former defines flow types and the latter defines RSS offload types. Signed-off-by: Simei Su Reviewed-by: Qi Zhang Acked-by: Ori Kam Acked-by: Andrew Rybchenko --- lib/librte_ethdev/rte_ethdev.h | 49 ---

Re: [dpdk-dev] [PATCH] eventdev: flag to identify same destined packets enqueue

2019-10-01 Thread Aaron Conole
Nipun Gupta writes: > This patch introduces a `flag` in the Eth TX adapter enqueue API. > Some drivers may support burst functionality only with the packets > having same destination device and queue. > > The flag `RTE_EVENT_ETH_TX_ADAPTER_ENQUEUE_SAME_DEST` can be used > to indicate this so the

Re: [dpdk-dev] [PATCH v2 4/7] drivers/net: update Rx RSS hash offload capabilities

2019-10-01 Thread Jerin Jacob
On Thu, Aug 22, 2019 at 2:18 AM wrote: > > From: Pavan Nikhilesh > > Add DEV_RX_OFFLOAD_RSS_HASH flag for all PMDs that support RSS hash > delivery. > > Signed-off-by: Pavan Nikhilesh For net/octeontx2: Acked-by: Jerin Jacob

Re: [dpdk-dev] [PATCH v2 5/7] drivers/net: update Rx flow flag and mark capabilities

2019-10-01 Thread Jerin Jacob
On Thu, Aug 22, 2019 at 2:18 AM wrote: > > From: Pavan Nikhilesh > > Add DEV_RX_OFFLOAD_FLOW_MARK flag for all PMDs that support flow action > flag and mark. > > Signed-off-by: Pavan Nikhilesh > --- > diff --git a/drivers/net/octeontx2/otx2_flow_parse.c > b/drivers/net/octeontx2/otx2_flow_parse

Re: [dpdk-dev] [RFC PATCH 1/9] security: introduce CPU Crypto action type and API

2019-10-01 Thread Ananyev, Konstantin
Hi Akhil, > > > > > > > > > > > > > This action type allows the burst of symmetric crypto > > workload > > > > using > > > > > > > the > > > > > > > > > > > same > > > > > > > > > > > > > algorithm, key, and direction being processed by CPU > > > > > > > > > > > > > cycles > > > > > > > > > syn

Re: [dpdk-dev] [PATCH v8 2/3] ethdev: extend RSS offload types

2019-10-01 Thread Andrew Rybchenko
On 10/1/19 5:36 PM, Simei Su wrote: This patch reserves several bits as input set selection from the high end of the 64 bits. It is combined with exisiting ETH_RSS_* to represent RSS types. Signed-off-by: Simei Su Reviewed-by: Qi Zhang Acked-by: Ori Kam --- lib/librte_ethdev/rte_ethdev.c |

Re: [dpdk-dev] [PATCH v2 1/7] ethdev: add set ptype function

2019-10-01 Thread Jerin Jacob
On Thu, Aug 22, 2019 at 2:18 AM wrote: > > From: Pavan Nikhilesh > > Add `rte_eth_dev_set_supported_ptypes` function that will allow the > application to inform the PMD the packet types it is interested in. > Based on the ptypes set PMDs can optimize their Rx path. > > -If application doesn’t wan

Re: [dpdk-dev] [PATCH] net/mlx5: fix compilation issue with gcc pragma

2019-10-01 Thread Stephen Hemminger
On Tue, 1 Oct 2019 11:10:23 + Viacheslav Ovsiienko wrote: > +#if defined(RTE_TOOLCHAIN_GCC) && (GCC_VERSION >= 40600) > +#pragma GCC diagnostic push > #pragma GCC diagnostic ignored "-Wformat-nonliteral" > +#endif > + /* Use safe format to check maximal buffer length. */ > while (

Re: [dpdk-dev] [PATCH] eventdev: flag to identify same destined packets enqueue

2019-10-01 Thread Nipun Gupta
> -Original Message- > From: Jerin Jacob > Sent: Tuesday, October 1, 2019 7:50 PM > To: Nipun Gupta > Cc: Jerin Jacob ; dpdk-dev ; Pavan > Nikhilesh ; Sunil Kumar Kori > ; Hemant Agrawal ; > Richardson, Bruce ; Marko Kovacevic > ; Ori Kam ; Radu > Nicolau ; Tomasz Kantecki > ; Van Haare

Re: [dpdk-dev] [PATCH v3 0/2] add symmetric toeplitz hash support

2019-10-01 Thread Ferruh Yigit
On 10/1/2019 10:22 AM, Simei Su wrote: > [PATCH v3 1/2] ethdev: add new hash function "Symmetric Toeplitz" supported > by hardware. > [PATCH v3 2/2] app/testpmd: add command line support for symmetric toeplitz > hash configuration. > > v3: > * Add a definition for Symmetric Toeplitz function. >

Re: [dpdk-dev] [PATCH] eventdev: flag to identify same destined packets enqueue

2019-10-01 Thread Nipun Gupta
> -Original Message- > From: Aaron Conole > Sent: Tuesday, October 1, 2019 8:12 PM > To: Nipun Gupta > Cc: dev@dpdk.org; jer...@marvell.com; pbhagavat...@marvell.com; > sk...@marvell.com; Hemant Agrawal ; > bruce.richard...@intel.com; marko.kovace...@intel.com; > or...@mellanox.com; ra

[dpdk-dev] [PATCH v2 3/3] examples/ipsec-secgw: update pktest.sh script

2019-10-01 Thread Bernard Iremonger
Drop SGW_CMD_XPRM=l, as default is IPsec library now. Signed-off-by: Bernard Iremonger --- examples/ipsec-secgw/test/pkttest.sh | 1 - 1 file changed, 1 deletion(-) diff --git a/examples/ipsec-secgw/test/pkttest.sh b/examples/ipsec-secgw/test/pkttest.sh index 04cd96b..7c78de7 100755 --- a/exam

[dpdk-dev] [PATCH v2 1/3] examples/ipsec-secgw: set default to IPsec library mode

2019-10-01 Thread Bernard Iremonger
Set the default code path to librte_ipsec mode. Add parameter 0 | 1 to -l option and update error message. Check for conflicting options, -w -a -e and reassembly options are not supported in legacy mode. Show fragment table size. Update print_usage. Update the ipsec-secgw guide. Update the release

[dpdk-dev] [PATCH v2 0/3] examples/ipsec-secgw: set default

2019-10-01 Thread Bernard Iremonger
This patch set, sets the default code path in the ipsec-secgw application to use the librte_ipsec. The *_old test scripts have been modified to use the legacy code path. Changes in v2: - The error messages for the -l option have been updated. The pktest.sh script has been updated to d

[dpdk-dev] [PATCH v2 2/3] examples/ipsec-secgw: add -l 0 parameter to old scripts

2019-10-01 Thread Bernard Iremonger
enable legacy mode in *_old scripts Signed-off-by: Bernard Iremonger --- examples/ipsec-secgw/test/trs_3descbc_sha1_old_defs.sh | 2 +- examples/ipsec-secgw/test/trs_aescbc_sha1_old_defs.sh | 2 +- examples/ipsec-secgw/test/trs_aesctr_sha1_old_defs.sh | 2 +- examples/i

Re: [dpdk-dev] [PATCH v4 6/6] doc: deprecation notice for VFIO DMA map APIs

2019-10-01 Thread David Marchand
Hello Shahaf, On 10/03/2019 09:28, Shahaf Shuler wrote: > As those should be replaced by rte_dev_dma_map and rte_dev_dma_unmap > APIs. > > Signed-off-by: Shahaf Shuler > --- > doc/guides/prog_guide/env_abstraction_layer.rst | 2 +- > doc/guides/rel_notes/deprecation.rst| 4 > 2

Re: [dpdk-dev] [PATCH 01/10] security: introduce CPU Crypto action type and API

2019-10-01 Thread Ananyev, Konstantin
Hi Hemant, > >>> This patch introduce new RTE_SECURITY_ACTION_TYPE_CPU_CRYPTO action type > >>> to > >>> security library. The type represents performing crypto operation with CPU > >>> cycles. The patch also includes a new API to process crypto operations in > >>> bulk and the function pointers

Re: [dpdk-dev] [PATCH] eventdev: flag to identify same destined packets enqueue

2019-10-01 Thread Jerin Jacob
On Tue, Oct 1, 2019 at 8:36 PM Nipun Gupta wrote: > > > > > -Original Message- > > From: Jerin Jacob > > Sent: Tuesday, October 1, 2019 7:50 PM > > To: Nipun Gupta > > Cc: Jerin Jacob ; dpdk-dev ; Pavan > > Nikhilesh ; Sunil Kumar Kori > > ; Hemant Agrawal ; > > Richardson, Bruce ; Marko

Re: [dpdk-dev] [PATCH v2 4/7] drivers/net: update Rx RSS hash offload capabilities

2019-10-01 Thread Ajit Khaparde
On Wed, Aug 21, 2019 at 1:48 PM wrote: > From: Pavan Nikhilesh > > Add DEV_RX_OFFLOAD_RSS_HASH flag for all PMDs that support RSS hash > delivery. > > Signed-off-by: Pavan Nikhilesh > For net/bnxt: Acked-by: Ajit Khaparde > --- > drivers/net/bnxt/bnxt_ethdev.c | 3 ++- > drivers/net/

Re: [dpdk-dev] [PATCH 9/9] net/bnxt: remove commented out code

2019-10-01 Thread Ajit Khaparde
On Tue, Oct 1, 2019 at 6:04 AM Kevin Traynor wrote: > This commented out todo and code is old. Remove it. > > Fixes: b7435d660a8c ("net/bnxt: add ntuple filtering support") > Cc: ajit.khapa...@broadcom.com > Cc: sta...@dpdk.org > > Signed-off-by: Kevin Traynor > Acked-by: Ajit Khaparde --- >

[dpdk-dev] [PATCH 1/3] net/virtio: reject deferred start Rx queue setup

2019-10-01 Thread Andrew Rybchenko
From: Dilshod Urazov Deferred start Rx queue is not supported by the driver. Fixes: 0748be2cf9a2 ("ethdev: queue start and stop") Cc: sta...@dpdk.org Signed-off-by: Dilshod Urazov Signed-off-by: Andrew Rybchenko --- drivers/net/virtio/virtio_rxtx.c | 5 + 1 file changed, 5 insertions(+)

[dpdk-dev] [PATCH 3/3] net/virtio: reject unsupported Rx multi queue modes

2019-10-01 Thread Andrew Rybchenko
From: Dilshod Urazov This driver supports none of DCB, RSS or VMDQ modes, therefore must check and return error if configured incorrectly. Fixes: c1f86306a026 ("virtio: add new driver") Cc: sta...@dpdk.org Signed-off-by: Dilshod Urazov Signed-off-by: Andrew Rybchenko --- drivers/net/virtio/v

[dpdk-dev] [PATCH 2/3] net/virtio: reject deferred start Tx queue setup

2019-10-01 Thread Andrew Rybchenko
From: Dilshod Urazov Deferred start Tx queue is not supported by the driver. Fixes: 0748be2cf9a2 ("ethdev: queue start and stop") Cc: sta...@dpdk.org Signed-off-by: Dilshod Urazov Signed-off-by: Andrew Rybchenko --- drivers/net/virtio/virtio_rxtx.c | 5 + 1 file changed, 5 insertions(+)

Re: [dpdk-dev] [PATCH] net/null: fix multi-process rx and tx

2019-10-01 Thread Ferruh Yigit
On 9/29/2019 3:41 AM, Yasufumi Ogawa wrote: > Packet processing in secondary process cannot work because rx_pkt_burst > and tx_pkt_burst in eth_dev are not initialized while probing device. > This patch is to the initialization. > > Signed-off-by: Yasufumi Ogawa > --- > drivers/net/null/rte_eth_

Re: [dpdk-dev] [PATCH v8 2/3] ethdev: extend RSS offload types

2019-10-01 Thread Iremonger, Bernard
Hi Simei, > -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Andrew Rybchenko > Sent: Tuesday, October 1, 2019 3:49 PM > To: Su, Simei ; Zhang, Qi Z ; Ye, > Xiaolong ; Yigit, Ferruh > Cc: dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v8 2/3] ethdev: extend RSS off

Re: [dpdk-dev] [PATCH] net/null: fix multi-process rx and tx

2019-10-01 Thread Ferruh Yigit
On 10/1/2019 5:00 PM, Ferruh Yigit wrote: > On 9/29/2019 3:41 AM, Yasufumi Ogawa wrote: >> Packet processing in secondary process cannot work because rx_pkt_burst >> and tx_pkt_burst in eth_dev are not initialized while probing device. >> This patch is to the initialization. >> >> Signed-off-by: Ya

Re: [dpdk-dev] [PATCH] doc: fix list of unsupported features for IPsec lib

2019-10-01 Thread Iremonger, Bernard
Hi Konstantin, > -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Konstantin > Ananyev > Sent: Friday, September 27, 2019 3:21 PM > To: dev@dpdk.org > Cc: Ananyev, Konstantin > Subject: [dpdk-dev] [PATCH] doc: fix list of unsupported features for IPsec > lib > >

Re: [dpdk-dev] [PATCH 1/3] net/virtio: reject deferred start Rx queue setup

2019-10-01 Thread Kevin Traynor
Hi, On 01/10/2019 16:44, Andrew Rybchenko wrote: > From: Dilshod Urazov > > Deferred start Rx queue is not supported by the driver. > > Fixes: 0748be2cf9a2 ("ethdev: queue start and stop") > Cc: sta...@dpdk.org > > Signed-off-by: Dilshod Urazov > Signed-off-by: Andrew Rybchenko > --- > driv

Re: [dpdk-dev] [PATCH 1/3] net/virtio: reject deferred start Rx queue setup

2019-10-01 Thread Andrew Rybchenko
Hi Kevin, On 10/1/19 7:29 PM, Kevin Traynor wrote: Hi, On 01/10/2019 16:44, Andrew Rybchenko wrote: From: Dilshod Urazov Deferred start Rx queue is not supported by the driver. Fixes: 0748be2cf9a2 ("ethdev: queue start and stop") Cc: sta...@dpdk.org Signed-off-by: Dilshod Urazov Signed-of

Re: [dpdk-dev] [PATCH v8 2/3] ethdev: extend RSS offload types

2019-10-01 Thread Ferruh Yigit
On 10/1/2019 5:02 PM, Iremonger, Bernard wrote: > Hi Simei, > >> -Original Message- >> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Andrew Rybchenko >> Sent: Tuesday, October 1, 2019 3:49 PM >> To: Su, Simei ; Zhang, Qi Z ; Ye, >> Xiaolong ; Yigit, Ferruh >> Cc: dev@dpdk.org >> Su

Re: [dpdk-dev] [PATCH v2 2/2] build: support building ABI versioned files twice

2019-10-01 Thread Bruce Richardson
On Tue, Oct 01, 2019 at 03:23:47PM +0200, Andrzej Ostruszka wrote: > Thanks Bruce for the patch. I like the idea of splitting versioning out > of rte_compat.h, but I have some comments. > > On 9/27/19 10:59 PM, Bruce Richardson wrote: > [...] > > --- a/config/common_base > > +++ b/config/common_b

Re: [dpdk-dev] [PATCH 00/17] bnxt patchset to improve rte flow support

2019-10-01 Thread Ferruh Yigit
On 9/3/2019 3:18 AM, Ajit Khaparde wrote: > Among other changes, this patchset adds support to: > - create filters with RSS action. > - create source MAC filters. > - use user provided priority to place rule appropriately in HW. > > This series is dependent on the series "bnxt patchset" submitted

Re: [dpdk-dev] [PATCH v5 09/12] test/fib: add FIB library autotests

2019-10-01 Thread Medvedkin, Vladimir
Hi Aaron, On 12/09/2019 15:07, Aaron Conole wrote: Vladimir Medvedkin writes: Functional tests for the new FIB library. Signed-off-by: Vladimir Medvedkin --- app/test/Makefile | 1 + app/test/autotest_data.py | 6 + app/test/meson.build | 3 + app/test/test_fib.c

Re: [dpdk-dev] [PATCH] net/mlx5: fix compilation issue with gcc pragma

2019-10-01 Thread Slava Ovsiienko
> -Original Message- > From: Stephen Hemminger > Sent: Tuesday, October 1, 2019 17:54 > To: Slava Ovsiienko > Cc: dev@dpdk.org; Matan Azrad ; Raslan > Darawsheh ; ferruh.yi...@intel.com > Subject: Re: [dpdk-dev] [PATCH] net/mlx5: fix compilation issue with gcc > pragma > > On Tue, 1 Oct

Re: [dpdk-dev] [PATCH v1 3/5] ipsec: add SAD add/delete/lookup implementation

2019-10-01 Thread Medvedkin, Vladimir
Hi Konstantin, On 12/09/2019 18:58, Ananyev, Konstantin wrote: Hi Vladimir, Replace rte_ipsec_sad_add(), rte_ipsec_sad_del() and rte_ipsec_sad_lookup() stubs with actual implementation. It uses three librte_hash tables each of which contains an entries for a specific SA type (either it is add

[dpdk-dev] [PATCH v2 0/5] ipsec: add inbound SAD

2019-10-01 Thread Vladimir Medvedkin
According to RFC 4301 IPSec implementation needs an inbound SA database (SAD). For each incoming inbound IPSec-protected packet (ESP or AH) it has to perform a lookup within it’s SAD. Lookup should be performed by: Security Parameters Index (SPI) + destination IP (DIP) + source IP (SIP) or SPI +

[dpdk-dev] [PATCH v2 2/5] ipsec: add SAD create/destroy implementation

2019-10-01 Thread Vladimir Medvedkin
Replace rte_ipsec_sad_create(), rte_ipsec_sad_destroy() and rte_ipsec_sad_find_existing() API stubs with actual implementation. Signed-off-by: Vladimir Medvedkin --- lib/librte_ipsec/Makefile| 2 +- lib/librte_ipsec/ipsec_sad.c | 233 +-- lib/librte_

[dpdk-dev] [PATCH v2 1/5] ipsec: add inbound SAD API

2019-10-01 Thread Vladimir Medvedkin
Add inbound security association database (SAD) API and stub implementation. Signed-off-by: Vladimir Medvedkin --- lib/librte_ipsec/Makefile | 2 + lib/librte_ipsec/ipsec_sad.c | 50 ++ lib/librte_ipsec/meson.build | 4 +- lib/librte_ipsec/rte_ipsec_

[dpdk-dev] [PATCH v2 4/5] test/ipsec: add ipsec SAD autotests

2019-10-01 Thread Vladimir Medvedkin
Signed-off-by: Vladimir Medvedkin --- app/test/Makefile | 1 + app/test/autotest_data.py | 6 + app/test/meson.build | 1 + app/test/test_ipsec_sad.c | 856 ++ 4 files changed, 864 insertions(+) create mode 100644 app/test/test_ipsec

[dpdk-dev] [PATCH v2 3/5] ipsec: add SAD add/delete/lookup implementation

2019-10-01 Thread Vladimir Medvedkin
Replace rte_ipsec_sad_add(), rte_ipsec_sad_del() and rte_ipsec_sad_lookup() stubs with actual implementation. It uses three librte_hash tables each of which contains an entries for a specific SA type (either it is addressed by SPI only or SPI+DIP or SPI+DIP+SIP) Signed-off-by: Vladimir Medvedkin

[dpdk-dev] [PATCH v2 5/5] app: add test-sad application

2019-10-01 Thread Vladimir Medvedkin
Usage example and performance evaluation for the ipsec SAD library Signed-off-by: Vladimir Medvedkin --- app/Makefile | 1 + app/meson.build | 3 +- app/test-sad/Makefile| 18 ++ app/test-sad/main.c | 662 +++ app/tes

Re: [dpdk-dev] [PATCH] doc: fix list of unsupported features for IPsec lib

2019-10-01 Thread Ananyev, Konstantin
> -Original Message- > From: Iremonger, Bernard > Sent: Tuesday, October 1, 2019 5:27 PM > To: Ananyev, Konstantin ; dev@dpdk.org > Subject: RE: [dpdk-dev] [PATCH] doc: fix list of unsupported features for > IPsec lib > > Hi Konstantin, > > > -Original Message- > > From: dev [

Re: [dpdk-dev] [PATCH v2 2/3] examples/ipsec-secgw: add -l 0 parameter to old scripts

2019-10-01 Thread Ananyev, Konstantin
> -Original Message- > From: Iremonger, Bernard > Sent: Tuesday, October 1, 2019 4:18 PM > To: dev@dpdk.org; Ananyev, Konstantin ; > akhil.go...@nxp.com > Cc: Iremonger, Bernard > Subject: [PATCH v2 2/3] examples/ipsec-secgw: add -l 0 parameter to old > scripts > > enable legacy mode

Re: [dpdk-dev] [PATCH v2 3/3] examples/ipsec-secgw: update pktest.sh script

2019-10-01 Thread Ananyev, Konstantin
> -Original Message- > From: Iremonger, Bernard > Sent: Tuesday, October 1, 2019 4:18 PM > To: dev@dpdk.org; Ananyev, Konstantin ; > akhil.go...@nxp.com > Cc: Iremonger, Bernard > Subject: [PATCH v2 3/3] examples/ipsec-secgw: update pktest.sh script > > Drop SGW_CMD_XPRM=l, as default

Re: [dpdk-dev] [PATCH v2 0/3] examples/ipsec-secgw: set default

2019-10-01 Thread Ananyev, Konstantin
Hi Bernard, > > This patch set, sets the default code path in the ipsec-secgw > application to use the librte_ipsec. > The *_old test scripts have been modified to use the legacy code > path. > > Changes in v2: > - > The error messages for the -l option have been updated. > The pkt

Re: [dpdk-dev] [PATCH 00/17] bnxt patchset to improve rte flow support

2019-10-01 Thread Ajit Khaparde
Ferruh. Yes. We are working on that already. Thanks On Tue, Oct 1, 2019 at 10:02 AM Ferruh Yigit wrote: > On 9/3/2019 3:18 AM, Ajit Khaparde wrote: > > Among other changes, this patchset adds support to: > > - create filters with RSS action. > > - create source MAC filters. > > - use user provid

Re: [dpdk-dev] [PATCH v3 4/6] mbuf: add a pktmbuf copy routine

2019-10-01 Thread Slava Ovsiienko
Hi, Stephen > -Original Message- > From: dev On Behalf Of Stephen Hemminger > Sent: Monday, September 30, 2019 22:21 > To: dev@dpdk.org > Cc: Stephen Hemminger > Subject: [dpdk-dev] [PATCH v3 4/6] mbuf: add a pktmbuf copy routine > > This is a commonly used operation that surprisingly t

[dpdk-dev] [PATCH v3 1/3] lib/lpm: integrate RCU QSBR

2019-10-01 Thread Honnappa Nagarahalli
From: Ruifeng Wang Currently, the tbl8 group is freed even though the readers might be using the tbl8 group entries. The freed tbl8 group can be reallocated quickly. This results in incorrect lookup results. RCU QSBR process is integrated for safe tbl8 group reclaim. Refer to RCU documentation t

  1   2   3   >