[dpdk-dev] [PATCH v11 04/19] raw/ifpga/base: add SEU error support

2019-10-21 Thread Andy Pei
From: Tianfei zhang This patch exposes SEU error information to application then application could compare this information (128bit) with its own SMH file to know if this SEU is a fatal error or not. Signed-off-by: Tianfei zhang Signed-off-by: Andy Pei --- drivers/raw/ifpga/base/ifpga_defines

[dpdk-dev] [PATCH v11 01/19] net/i40e: i40e support ipn3ke FPGA port bonding

2019-10-21 Thread Andy Pei
In ipn3ke, each FPGA network side port bonding to an i40e pf, each i40e pf link status should get data from FPGA network, side port. This patch provide bonding relationship. Signed-off-by: Rosen Xu Signed-off-by: Andy Pei --- drivers/net/i40e/base/i40e_type.h | 3 +++ drivers/net/i40e/

[dpdk-dev] [PATCH v11 02/19] raw/ifpga/base: add irq support

2019-10-21 Thread Andy Pei
From: Tianfei zhang Add irq support for ifpga FME global error, port error and uint unit. We implmented this feature by vfio interrupt mechanism. To build this feature, CONFIG_RTE_EAL_VFIO should be enabled. Signed-off-by: Tianfei zhang Signed-off-by: Andy Pei --- config/common_base

[dpdk-dev] [PATCH v11 00/19] add PCIe AER disable and IRQ support for ipn3ke

2019-10-21 Thread Andy Pei
This patch set adds PCIe AER disable and FPGA interrupt support for ipn3ke. It also provides a small rework for port bonding between FPGA line side port and I40e PF port. What is the PCI Express AER(Advanced Error Reporting)? Advanced Error Reporting capability is implemented with a PCI Express ad

[dpdk-dev] [PATCH v11 03/19] raw/ifpga/base: clear pending bit

2019-10-21 Thread Andy Pei
From: Tianfei zhang Every defined bit in FME_ERROR0 is RW1C. Other reserved bits are always 0 when readout and it will plan to be RW1C if needed in future. So it is safe just write the read back value to clear all the errors. Signed-off-by: Tianfei zhang Signed-off-by: Andy Pei --- drivers/ra

[dpdk-dev] [PATCH v11 05/19] raw/ifpga/base: add device tree support

2019-10-21 Thread Andy Pei
From: Tianfei zhang In PAC N3000 card, this is a BMC chip which using MAX10 FPGA to manage the board configuration, like sensors, flash controller, QSFP, powers. And this is a SPI bus connected between A10 FPGA and MAX10, we can access the MAX10 registers over this SPI bus. In BMC, there are abo

[dpdk-dev] [PATCH v11 06/19] raw/ifpga/base: align the send buffer for SPI

2019-10-21 Thread Andy Pei
From: Tianfei zhang The length of send buffer of SPI bus should be 4bytes align. Signed-off-by: Tianfei Zhang Signed-off-by: Andy Pei --- drivers/raw/ifpga/base/opae_spi_transaction.c | 40 --- 1 file changed, 36 insertions(+), 4 deletions(-) diff --git a/drivers/raw/

[dpdk-dev] [PATCH v11 08/19] raw/ifpga/base: introducing sensor APIs

2019-10-21 Thread Andy Pei
From: Tianfei zhang Introducing sensor APIs to PMD driver for PAC N3000 card. Those sensor APIs: 1. opae_mgr_for_each_sensor() 2. opae_mgr_get_sensor_by_name() 3. opae_mgr_get_sensor_by_id() 4. opae_mgr_get_sensor_value_by_name() 5. opae_mgr_get_sensor_value_by_id() 6. opae_mgr_get_sensor_value(

[dpdk-dev] [PATCH v11 10/19] raw/ifpga: add SEU error handler

2019-10-21 Thread Andy Pei
From: Rosen Xu Add SEU interrupt support for FPGA. Signed-off-by: Tianfei zhang Signed-off-by: Rosen Xu Signed-off-by: Andy Pei --- drivers/raw/ifpga/ifpga_rawdev.c | 245 +++ 1 file changed, 245 insertions(+) diff --git a/drivers/raw/ifpga/ifpga_rawdev.c

[dpdk-dev] [PATCH v11 09/19] raw/ifpga/base: update SEU register definition

2019-10-21 Thread Andy Pei
From: Tianfei zhang Update the SEU registser definition. Signed-off-by: Tianfei zhang Signed-off-by: Andy Pei --- drivers/raw/ifpga/base/ifpga_defines.h | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/raw/ifpga/base/ifpga_defines.h b/drivers/raw/ifpga/base/ifpg

[dpdk-dev] [PATCH v11 11/19] raw/ifpga: add PCIe BDF devices tree scan

2019-10-21 Thread Andy Pei
From: Rosen Xu Add PCIe BDF devices tree scan for ipn3ke. Signed-off-by: Rosen Xu Signed-off-by: Andy Pei --- drivers/raw/ifpga/ifpga_rawdev.c | 551 ++- drivers/raw/ifpga/ifpga_rawdev.h | 16 ++ 2 files changed, 562 insertions(+), 5 deletions(-) diff --g

[dpdk-dev] [PATCH v11 07/19] raw/ifpga/base: add sensor support

2019-10-21 Thread Andy Pei
From: Tianfei zhang The sensor devices are connected in MAX10 FPGA. we used the device tree to describe those sensor devices. Parse the device tree to get the sensor devices and add them into a list. Signed-off-by: Tianfei zhang Signed-off-by: Andy Pei --- drivers/raw/ifpga/base/opae_intel_ma

[dpdk-dev] [PATCH v11 12/19] net/ipn3ke: remove configuration for i40e port bonding

2019-10-21 Thread Andy Pei
From: Rosen Xu The ipn3ke board FPGA and i40e BDF scan has added in ifpga_rawdev, so it doesn't need to provide configuration for i40e port bonding. Signed-off-by: Rosen Xu Signed-off-by: Andy Pei --- drivers/meson.build| 7 +- drivers/net/ipn3ke/Makefile

[dpdk-dev] [PATCH v11 13/19] raw/ifpga/base: add secure support

2019-10-21 Thread Andy Pei
From: Tianfei zhang Add secure max10 device support. Signed-off-by: Tianfei zhang Signed-off-by: Andy Pei --- drivers/raw/ifpga/base/ifpga_defines.h| 2 + drivers/raw/ifpga/base/ifpga_fme.c| 26 -- drivers/raw/ifpga/base/opae_intel_max10.c | 137 +---

[dpdk-dev] [PATCH v11 15/19] raw/ifpga/base: clean fme errors

2019-10-21 Thread Andy Pei
From: Tianfei zhang Clean fme errors register when some fme errors occurred. Signed-off-by: Tianfei zhang Signed-off-by: Andy Pei --- drivers/raw/ifpga/base/ifpga_fme_error.c | 24 ++-- drivers/raw/ifpga/ifpga_rawdev.c | 22 ++ 2 files changed,

[dpdk-dev] [PATCH v11 16/19] raw/ifpga/base: add new API get board info

2019-10-21 Thread Andy Pei
From: Tianfei zhang Add new API to get the board info. opae_mgr_get_board_info() Signed-off-by: Tianfei zhang Signed-off-by: Andy Pei --- drivers/raw/ifpga/base/ifpga_api.c | 11 +++ drivers/raw/ifpga/base/ifpga_defines.h | 55 ++ drivers/raw/ifpga/base

[dpdk-dev] [PATCH v11 14/19] raw/ifpga/base: configure FEC mode

2019-10-21 Thread Andy Pei
From: Tianfei zhang We can change the PKVL FEC mode when the A10 NIOS FW initialization. The end-user can use this feature the change the FEC mode, the default mode is RS FEC mode. Signed-off-by: Tianfei zhang Signed-off-by: Andy Pei --- drivers/raw/ifpga/base/ifpga_fme.c | 42 +++

[dpdk-dev] [PATCH v11 17/19] raw/ifpga: add lightweight fpga image support

2019-10-21 Thread Andy Pei
if fpga image support lightweight feature, set afu uuid to all 0, ipn3ke representor will not be probed. Signed-off-by: Andy Pei --- drivers/raw/ifpga/ifpga_rawdev.c | 44 +--- 1 file changed, 32 insertions(+), 12 deletions(-) diff --git a/drivers/raw/ifpga/i

Re: [dpdk-dev] [PATCH 0/7] net/mlx5: support for flow action on VLAN header

2019-10-21 Thread Hideyuki Yamashita
Dear Slava, Moti and all, Please let me know if you need more information. Partial answer is acceptable for me. Thanks in advaince! BR, HIdeyuki Yamashita NTT TechnoCross > Dear Slava and experts, > > Thanks for your answering me. > Baased on your answer, I tested using testpmd. > And about th

[dpdk-dev] [PATCH v11 18/19] raw/ifpga/base: add multiple cards support

2019-10-21 Thread Andy Pei
From: Tianfei zhang In PAC N3000 card, there is one MAX10 chip in each card, and all of the sensors are connected to MAX10 chip. To support multiple cards in one server, we introducing a sensor device list under intel_max10_device instead of a global list. On the other hand, we using separate int

[dpdk-dev] [PATCH v11 19/19] raw/ifpga: introducing new irq API

2019-10-21 Thread Andy Pei
From: Tianfei zhang Introducing new register and unregister API for ifpga interrupt. 1. register FME and AFU interrupt ifpga_register_msix_irq() 2. unregister FME and AFU interrupt ifpga_unregister_msix_irq() On PAC N3000 card, there is one PCIe MSIX interrupt for FME managerment, like th

Re: [dpdk-dev] [PATCH v7 2/7] eal: add the APIs to wait until equal

2019-10-21 Thread Gavin Hu (Arm Technology China)
> -Original Message- > From: Ananyev, Konstantin > Sent: Thursday, October 17, 2019 9:15 PM > To: Gavin Hu (Arm Technology China) ; dev@dpdk.org > Cc: nd ; tho...@monjalon.net; > step...@networkplumber.org; hemant.agra...@nxp.com; > jer...@marvell.com; pbhagavat...@marvell.com; Honnappa

Re: [dpdk-dev] [PATCH v11 12/19] net/ipn3ke: remove configuration for i40e port bonding

2019-10-21 Thread Ye Xiaolong
+Bruce for the meson change. Thanks, Xiaolong On 10/21, Andy Pei wrote: >From: Rosen Xu > >The ipn3ke board FPGA and i40e BDF scan has added in ifpga_rawdev, >so it doesn't need to provide configuration for i40e port bonding. > >Signed-off-by: Rosen Xu >Signed-off-by: Andy Pei >--- > drivers/m

Re: [dpdk-dev] [PATCH v7 3/7] spinlock: use wfe to reduce contention on aarch64

2019-10-21 Thread Gavin Hu (Arm Technology China)
Hi David, > -Original Message- > From: David Marchand > Sent: Friday, October 18, 2019 2:28 AM > To: Gavin Hu (Arm Technology China) > Cc: dev ; nd ; tho...@monjalon.net; > Stephen Hemminger ; > hemant.agra...@nxp.com; jer...@marvell.com; Pavan Nikhilesh > ; Honnappa Nagarahalli > ; Ruif

Re: [dpdk-dev] [PATCH 0/7] net/mlx5: support for flow action on VLAN header

2019-10-21 Thread Slava Ovsiienko
Hi, Hideyuki > -Original Message- > From: Hideyuki Yamashita > Sent: Monday, October 21, 2019 10:12 > To: Hideyuki Yamashita > Cc: Slava Ovsiienko ; Moti Haimovsky > ; dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH 0/7] net/mlx5: support for flow action on > VLAN header > > Dear Slava, M

Re: [dpdk-dev] [PATCH v7 2/7] eal: add the APIs to wait until equal

2019-10-21 Thread Gavin Hu (Arm Technology China)
Hi David, One comment about the experimental tag for the API inlined. /Gavin > -Original Message- > From: David Marchand > Sent: Thursday, October 17, 2019 11:45 PM > To: Gavin Hu (Arm Technology China) > Cc: dev ; nd ; tho...@monjalon.net; > Stephen Hemminger ; > hemant.agra...@nxp.co

Re: [dpdk-dev] [PATCH] eal: add option --iso-cmem for external custom memory

2019-10-21 Thread Rajesh Ravi
+ Srinath Thanks Anatoly for reviewing this. Please find my reply inline below: [Anatoly] First of all, what is "iso-cmem"? It doesn't seem to have any defined meaning nor any relation to any existing functionality, and it's not explained anywhere what is "isolated cmem". [Rajesh] I 'll correct

[dpdk-dev] [PATCH v7 00/13] vhost packed ring performance optimization

2019-10-21 Thread Marvin Liu
Packed ring has more compact ring format and thus can significantly reduce the number of cache miss. It can lead to better performance. This has been approved in virtio user driver, on normal E5 Xeon cpu single core performance can raise 12%. http://mails.dpdk.org/archives/dev/2018-April/095470.ht

[dpdk-dev] [PATCH v7 01/13] vhost: add packed ring indexes increasing function

2019-10-21 Thread Marvin Liu
When enqueuing or dequeuing, the virtqueue's local available and used indexes are increased. Signed-off-by: Marvin Liu Reviewed-by: Maxime Coquelin diff --git a/lib/librte_vhost/vhost.h b/lib/librte_vhost/vhost.h index c76d40115..02b3c91ff 100644 --- a/lib/librte_vhost/vhost.h +++ b/lib/librte_

[dpdk-dev] [PATCH v7 02/13] vhost: add packed ring single enqueue

2019-10-21 Thread Marvin Liu
Add vhost enqueue function for single packet and meanwhile left space for flush used ring function. Signed-off-by: Marvin Liu Reviewed-by: Maxime Coquelin diff --git a/lib/librte_vhost/virtio_net.c b/lib/librte_vhost/virtio_net.c index 070d62bc0..4fb6552cc 100644 --- a/lib/librte_vhost/virtio_n

[dpdk-dev] [PATCH v7 06/13] vhost: add packed ring batch dequeue

2019-10-21 Thread Marvin Liu
Add batch dequeue function like enqueue function for packed ring, batch dequeue function will not support chained descritpors, single packet dequeue function will handle it. Signed-off-by: Marvin Liu diff --git a/lib/librte_vhost/vhost.h b/lib/librte_vhost/vhost.h index a2b9221e0..67724c342 1006

[dpdk-dev] [PATCH v7 03/13] vhost: try to unroll for each loop

2019-10-21 Thread Marvin Liu
Create macro for adding unroll pragma before for each loop. Batch functions will be contained of several small loops which can be optimized by compilers' loop unrolling pragma. Signed-off-by: Marvin Liu diff --git a/lib/librte_vhost/Makefile b/lib/librte_vhost/Makefile index 8623e91c0..87ce1fb27

[dpdk-dev] [PATCH v7 04/13] vhost: add packed ring batch enqueue

2019-10-21 Thread Marvin Liu
Batch enqueue function will first check whether descriptors are cache aligned. It will also check prerequisites in the beginning. Batch enqueue function do not support chained mbufs, single packet enqueue function will handle it. Signed-off-by: Marvin Liu Reviewed-by: Maxime Coquelin diff --git

[dpdk-dev] [PATCH v7 05/13] vhost: add packed ring single dequeue

2019-10-21 Thread Marvin Liu
Add vhost single packet dequeue function for packed ring and meanwhile left space for shadow used ring update function. Signed-off-by: Marvin Liu Reviewed-by: Maxime Coquelin diff --git a/lib/librte_vhost/virtio_net.c b/lib/librte_vhost/virtio_net.c index 4ddf26567..317be1aed 100644 --- a/lib/l

[dpdk-dev] [PATCH v7 07/13] vhost: flush enqueue updates by cacheline

2019-10-21 Thread Marvin Liu
Buffer vhost packed ring enqueue updates, flush ring descs if buffered content filled up one cacheline. Thus virtio can receive packets at a faster frequency. Signed-off-by: Marvin Liu diff --git a/lib/librte_vhost/vhost.h b/lib/librte_vhost/vhost.h index 67724c342..d59446442 100644 --- a/lib/li

[dpdk-dev] [PATCH v7 08/13] vhost: flush batched enqueue descs directly

2019-10-21 Thread Marvin Liu
Flush used elements when batched enqueue function is finished. Descriptor's flags are pre-calculated as they will be reset by vhost. Signed-off-by: Marvin Liu Reviewed-by: Gavin Hu Reviewed-by: Maxime Coquelin diff --git a/lib/librte_vhost/vhost.h b/lib/librte_vhost/vhost.h index d59446442..f8

[dpdk-dev] [PATCH v7 09/13] vhost: buffer packed ring dequeue updates

2019-10-21 Thread Marvin Liu
Buffer used ring updates as many as possible in vhost dequeue function for coordinating with virtio driver. For supporting buffer, shadow used ring element should contain descriptor's flags. First shadowed ring index was recorded for calculating buffered number. Signed-off-by: Marvin Liu Reviewed

[dpdk-dev] [PATCH v7 11/13] vhost: add packed ring zcopy batch and single dequeue

2019-10-21 Thread Marvin Liu
Add vhost packed ring zero copy batch and single dequeue functions like normal dequeue path. Signed-off-by: Marvin Liu Reviewed-by: Maxime Coquelin diff --git a/lib/librte_vhost/virtio_net.c b/lib/librte_vhost/virtio_net.c index 2f90c3a7c..e053766f5 100644 --- a/lib/librte_vhost/virtio_net.c ++

[dpdk-dev] [PATCH v7 10/13] vhost: optimize packed ring enqueue

2019-10-21 Thread Marvin Liu
Optimize vhost device packed ring enqueue function by splitting batch and single functions. Packets can be filled into one desc will be handled by batch and others will be handled by single as before. Signed-off-by: Marvin Liu Reviewed-by: Maxime Coquelin diff --git a/lib/librte_vhost/virtio_ne

[dpdk-dev] [PATCH v7 13/13] vhost: optimize packed ring dequeue when in-order

2019-10-21 Thread Marvin Liu
When VIRTIO_F_IN_ORDER feature is negotiated, vhost can optimize dequeue function by only update first used descriptor. Signed-off-by: Marvin Liu Reviewed-by: Maxime Coquelin diff --git a/lib/librte_vhost/virtio_net.c b/lib/librte_vhost/virtio_net.c index ca3a6551b..670790850 100644 --- a/lib/l

[dpdk-dev] [PATCH v7 12/13] vhost: optimize packed ring dequeue

2019-10-21 Thread Marvin Liu
Optimize vhost device packed ring dequeue function by splitting batch and single functions. No-chained and direct descriptors will be handled by batch and other will be handled by single as before. Signed-off-by: Marvin Liu Reviewed-by: Maxime Coquelin diff --git a/lib/librte_vhost/virtio_net.c

[dpdk-dev] [PATCH v11 0/4] kni: add IOVA=VA mode support

2019-10-21 Thread vattunuru
From: Vamsi Attunuru --- V11 Changes: * Added iova to kva address translation routines in kernel module to make it work in iova=va mode which enables DPDK to create kni devices on any kind of backed device/memory. * Added ``--legacy-kni`` eal option to make existing KNI applications work with DPD

[dpdk-dev] [PATCH v11 2/4] eal: add legacy kni option

2019-10-21 Thread vattunuru
From: Vamsi Attunuru This adds a "--legacy-kni" command-line option. It will be used to run existing KNI applications with DPDK 19.11 and later. Signed-off-by: Vamsi Attunuru Suggested-by: Ferruh Yigit --- doc/guides/rel_notes/release_19_11.rst | 4 lib/librte_eal/common/eal_common_o

[dpdk-dev] [PATCH v11 3/4] kni: add IOVA=VA support

2019-10-21 Thread vattunuru
From: Vamsi Attunuru Current KNI implementation only operates in IOVA_PA mode patch adds required functionality to enable KNI in IOVA_VA mode. Packet pool's mbuf memory should be physically contiguous for the KNI kernel module to work in IOVA=VA mode, new KNI packet pool create APIs are introduc

[dpdk-dev] [PATCH v11 1/4] mempool: populate mempool with the page sized chunks

2019-10-21 Thread vattunuru
From: Vamsi Attunuru Patch adds a routine to populate mempool from page aligned and page sized chunks of memory to ensure memory objs do not fall across the page boundaries. It's useful for applications that require physically contiguous mbuf memory while running in IOVA=VA mode. Signed-off-by:

[dpdk-dev] [PATCH v11 4/4] kni: add IOVA=VA support in kernel module

2019-10-21 Thread vattunuru
From: Vamsi Attunuru Patch adds support for kernel module to work in IOVA = VA mode by providing address translation routines to convert IOVA aka user space VA to kernel virtual addresses. Signed-off-by: Vamsi Attunuru Signed-off-by: Kiran Kumar K --- kernel/linux/kni/compat.h | 4 ke

Re: [dpdk-dev] [PATCH v6 6/6] doc/ipsec: update ipsec programmer's guide

2019-10-21 Thread Akhil Goyal
Hi Vladimir, > > Add section about ipsec SAD > Update release notes > > Signed-off-by: Vladimir Medvedkin > --- > doc/guides/prog_guide/ipsec_lib.rst| 152 > + > doc/guides/rel_notes/release_19_11.rst | 3 + > 2 files changed, 155 insertions(+) > This patc

Re: [dpdk-dev] [dpdk-stable] [PATCH] net/axgbe: fix double unlock coverity issue

2019-10-21 Thread Kumar, Ravi1
>On 10/9/2019 9:41 AM, Ferruh Yigit wrote: >> On 9/19/2019 12:01 PM, Pallantla Poornima wrote: >>> One issue caught by Coverity 340835 >>> *unlock: axgbe_phy_set_mode unlocks pdata->phy_mutex >>> *double_unlock: axgbe_phy_sfp_detect unlocks pdata->phy_mutex while >>> it is unlocked. >>> >>> In axg

Re: [dpdk-dev] [PATCH v6 RESEND] eal: add tsc_hz to rte_mem_config

2019-10-21 Thread David Marchand
On Tue, Oct 8, 2019 at 10:39 AM Bruce Richardson wrote: > > On Mon, Oct 07, 2019 at 08:28:21AM -0700, Jim Harris wrote: > > This ensures secondary processes never have to > > calculate the TSC rate themselves, which can be > > noticeable in VMs that don't have access to > > arch-specific detection

Re: [dpdk-dev] [PATCH v11 1/3] eal/arm64: add 128-bit atomic compare exchange

2019-10-21 Thread David Marchand
On Fri, Oct 18, 2019 at 4:36 PM Jerin Jacob wrote: > > On Fri, Oct 18, 2019 at 8:04 PM David Marchand > wrote: > > > > On Fri, Oct 18, 2019 at 4:25 PM Jerin Jacob wrote: > > > > > > On Fri, Oct 18, 2019 at 7:46 PM David Marchand > > > wrote: > > > > > > > > On Fri, Oct 18, 2019 at 1:22 PM Phil

Re: [dpdk-dev] [PATCH v11 2/3] test/atomic: add 128b compare and swap test

2019-10-21 Thread David Marchand
On Fri, Oct 18, 2019 at 1:22 PM Phil Yang wrote: > > Add 128b atomic compare and swap test for aarch64 and x86_64. > Extend the test iteration from 10 thousand to 1 million times to test > the stability of the atomic APIs. > > Signed-off-by: Phil Yang > Reviewed-by: Honnappa Nagarahalli > Acked-

Re: [dpdk-dev] [PATCH v11 3/3] eal/stack: enable lock-free stack for aarch64

2019-10-21 Thread David Marchand
On Fri, Oct 18, 2019 at 1:22 PM Phil Yang wrote: > > Enable both c11 atomic and non c11 atomic lock-free stack for aarch64. > > Introduced a new header to reduce the ifdef clutter across generic and c11 > files. The rte_stack_lf_stubs.h contains stub implementations of > __rte_stack_lf_count, __rt

Re: [dpdk-dev] [PATCH v2 2/2] crypto/aesni_gcm: allow device init if no AES-NI is present

2019-10-21 Thread Akhil Goyal
> > The IPSec Multi buffer library does not require AES-NI > instructions to be supported by the CPU, as it can emulate these > instructions in software (adding a big performance penalty when > using AES algorithms). > > Signed-off-by: Pablo de Lara > --- > v2: > - Fixed leading whitespaces >

Re: [dpdk-dev] [dpdk-stable] 18.11.3 (LTS) patches review and test

2019-10-21 Thread Kevin Traynor
On 20/10/2019 14:16, Ali Alnubani wrote: > Hi, > > Replaying here because I can't find the first email in the thread. > > Regarding testing results with Mellanox devices, we did basic functional > testing with testpmd, and don't see any issues. > > Testing matrix: > - NIC: ConnectX-5 / OS: RHEL

Re: [dpdk-dev] [PATCH] tools: add EditorConfig file

2019-10-21 Thread Bruce Richardson
On Fri, Oct 18, 2019 at 09:08:25AM -0700, Stephen Hemminger wrote: > On Fri, 18 Oct 2019 17:56:48 +0200 > Robin Jarry wrote: > > > 2019-10-18, Stephen Hemminger: > > > Why not add this (since git doesn't like trailing whitespace). > > > > > > trim_trailing_whitespace=true > > > > Because Edit

Re: [dpdk-dev] [PATCH v4 1/2] lib/ring: apis to support configurable element size

2019-10-21 Thread Ananyev, Konstantin
> > > > fix patch > > === > > > > From a2be5a9b136333a56d466ef042c655e522ca7012 Mon Sep 17 00:00:00 > > 2001 > > From: Konstantin Ananyev > > Date: Fri, 18 Oct 2019 15:50:43 +0100 > > Subject: [PATCH] fix1 > > > > Signed-off-by: Konstantin Ananyev > > --- > > lib/librte_ring/rte_ring_elem.

Re: [dpdk-dev] [dpdk-stable] [PATCH] net/axgbe: fix double unlock coverity issue

2019-10-21 Thread Ferruh Yigit
On 10/21/2019 9:20 AM, Kumar, Ravi1 wrote: >> On 10/9/2019 9:41 AM, Ferruh Yigit wrote: >>> On 9/19/2019 12:01 PM, Pallantla Poornima wrote: One issue caught by Coverity 340835 *unlock: axgbe_phy_set_mode unlocks pdata->phy_mutex *double_unlock: axgbe_phy_sfp_detect unlocks pdata->ph

[dpdk-dev] [PATCH v2 0/2] enetc PMD specific changes

2019-10-21 Thread Gagandeep Singh
v2 change-log: * dpaax integration added * compilation fixed Gagandeep Singh (2): net/enetc: set random MAC in case no MAC for SI net/enetc: enable dpaax library drivers/net/enetc/Makefile | 4 ++- drivers/net/enetc/enetc_ethdev.c | 43 +++- 2 files changed

[dpdk-dev] [PATCH v2 2/2] net/enetc: enable dpaax library

2019-10-21 Thread Gagandeep Singh
With this patch, enetc driver would start using the physical-virtual library interfaces. Signed-off-by: Gagandeep Singh --- drivers/net/enetc/Makefile | 2 ++ drivers/net/enetc/enetc_ethdev.c | 8 2 files changed, 10 insertions(+) diff --git a/drivers/net/enetc/Makefile b/drivers

[dpdk-dev] [PATCH v2 1/2] net/enetc: set random MAC in case no MAC for SI

2019-10-21 Thread Gagandeep Singh
for SGMII interfaces, there can be 0 value written on MAC registers. This patch set the random MAC address for those interfaces. Signed-off-by: Gagandeep Singh --- drivers/net/enetc/Makefile | 2 +- drivers/net/enetc/enetc_ethdev.c | 35 +++- 2 files changed, 3

[dpdk-dev] [PATCH v9] ethdev: add HIGIG2 key field to flow API

2019-10-21 Thread kirankumark
From: Kiran Kumar K Add new rte_flow_item_higig2_hdr in order to match higig2 header. It is a layer 2.5 protocol and used in Broadcom switches. Header format is based on the following document. http://read.pudn.com/downloads558/doc/comm/2301468/HiGig_protocol.pdf Signed-off-by: Kiran Kumar K Ac

[dpdk-dev] [PATCH v3 2/3] net/enetc: set random MAC in case no MAC for SI

2019-10-21 Thread Gagandeep Singh
for SGMII interfaces, there can be 0 value written on MAC registers. This patch set the random MAC address for those interfaces. Signed-off-by: Gagandeep Singh --- drivers/net/enetc/Makefile | 2 +- drivers/net/enetc/enetc_ethdev.c | 35 +++- 2 files changed, 3

[dpdk-dev] [PATCH v3 0/3] enetc PMD specific changes

2019-10-21 Thread Gagandeep Singh
v2 change-log: * dpaax integration added * compilation fixed v3 change-log: * added missing BD ring alignment patch Gagandeep Singh (3): net/enetc: add macro for BD ring alignment net/enetc: set random MAC in case no MAC for SI net/enetc: enable dpaax library drivers/net/enetc/Makefile

[dpdk-dev] [PATCH v3 1/3] net/enetc: add macro for BD ring alignment

2019-10-21 Thread Gagandeep Singh
enetc BD rings should be aligned to 128 instead of RTE_CACHE_LINE_SIZE. Signed-off-by: Gagandeep Singh --- drivers/net/enetc/base/enetc_hw.h | 3 +++ drivers/net/enetc/enetc_ethdev.c | 8 2 files changed, 7 insertions(+), 4 deletions(-) diff --git a/drivers/net/enetc/base/enetc_hw.h

[dpdk-dev] [PATCH v3 3/3] net/enetc: enable dpaax library

2019-10-21 Thread Gagandeep Singh
With this patch, enetc driver would start using the physical-virtual library interfaces. Signed-off-by: Gagandeep Singh --- drivers/net/enetc/Makefile | 2 ++ drivers/net/enetc/enetc_ethdev.c | 8 2 files changed, 10 insertions(+) diff --git a/drivers/net/enetc/Makefile b/drivers

Re: [dpdk-dev] [PATCH v4] app/testpmd: enable GTP header parse and Tx checksum offload

2019-10-21 Thread Ferruh Yigit
On 10/21/2019 1:29 PM, Ting Xu wrote: > This patch enables testpmd to forward GTP packet in csum fwd mode. > GTP header structure (without optional fields and extension header) > and parser function are added. GTPU and GTPC packets are both > supported, with respective UDP destination port and GTP

Re: [dpdk-dev] [PATCH] crypto/qat: fix null auth issues when using vfio_pci

2019-10-21 Thread Akhil Goyal
> > > > > > > > When running auth NULL cases while using > > > vfio_pci, DMAR read/write faults appear. It > > > happens even if digest_length is set to 0. > > > This is caused by auth_res_addr initialized > > > as 0x0. > > > > > > Fixes: 4e0955bddb08 > > > Cc: Fiona Trahe > > > > > > Signed-o

Re: [dpdk-dev] [PATCH] crypto/qat: fix null auth issues when using vfio_pci

2019-10-21 Thread Akhil Goyal
> > > > When running auth NULL cases while using > > vfio_pci, DMAR read/write faults appear. It > > happens even if digest_length is set to 0. > > This is caused by auth_res_addr initialized > > as 0x0. > > > > Fixes: 4e0955bddb08 > > Cc: Fiona Trahe > > > > Signed-off-by: Damian Nowak > Acked

Re: [dpdk-dev] [PATCH v7 05/13] vhost: add packed ring single dequeue

2019-10-21 Thread Maxime Coquelin
On 10/21/19 5:40 PM, Marvin Liu wrote: > Add vhost single packet dequeue function for packed ring and meanwhile > left space for shadow used ring update function. > > Signed-off-by: Marvin Liu > Reviewed-by: Maxime Coquelin > > diff --git a/lib/librte_vhost/virtio_net.c b/lib/librte_vhost/vi

Re: [dpdk-dev] [PATCH v7 06/13] vhost: add packed ring batch dequeue

2019-10-21 Thread Maxime Coquelin
On 10/21/19 5:40 PM, Marvin Liu wrote: > Add batch dequeue function like enqueue function for packed ring, batch > dequeue function will not support chained descritpors, single packet > dequeue function will handle it. > > Signed-off-by: Marvin Liu > > diff --git a/lib/librte_vhost/vhost.h b/

[dpdk-dev] [PATCH v8 1/6] bus/fslmc: fix the conflicting dmb function

2019-10-21 Thread Gavin Hu
There are two definitions conflicting each other, for more details, refer to [1]. include/rte_atomic_64.h:19: error: "dmb" redefined [-Werror] drivers/bus/fslmc/mc/fsl_mc_sys.h:36: note: this is the location of the previous definition #define dmb() {__asm__ __volatile__("" : : : "memory"); } The

[dpdk-dev] [PATCH v8 0/6] use WFE for aarch64

2019-10-21 Thread Gavin Hu
V8: - define wfe() and sev() macros and use them inside normal C code (Ananyev Konstantin) - pass memorder as parameter, not to incorporate it into function name, less functions, similar to C11 atomic intrinsics (Ananyev Konstantin) - remove mandating RTE_FORCE_INTRINSICS in arm spinlock implemen

[dpdk-dev] [PATCH v8 6/6] event/opdl: use new API to save cycles on aarch64

2019-10-21 Thread Gavin Hu
Use the new API to wait in low power state instead of continuous polling to save CPU cycles and power. Signed-off-by: Gavin Hu Reviewed-by: Ruifeng Wang Reviewed-by: Jerin Jacob --- drivers/event/opdl/Makefile| 1 + drivers/event/opdl/meson.build | 1 + drivers/event/opdl/opdl_ring.c | 5 +

[dpdk-dev] [PATCH v8 2/6] eal: add the APIs to wait until equal

2019-10-21 Thread Gavin Hu
The rte_wait_until_equal_xx APIs abstract the functionality of 'polling for a memory location to become equal to a given value'. Add the RTE_ARM_USE_WFE configuration entry for aarch64, disabled by default. When it is enabled, the above APIs will call WFE instruction to save CPU cycles and power.

[dpdk-dev] [PATCH v8 3/6] spinlock: use wfe to reduce contention on aarch64

2019-10-21 Thread Gavin Hu
In acquiring a spinlock, cores repeatedly poll the lock variable. This is replaced by rte_wait_until_equal API. Running the micro benchmarking and the testpmd and l3fwd traffic tests on ThunderX2, Ampere eMAG80 and Arm N1SDP, everything went well and no notable performance gain nor degradation was

[dpdk-dev] [PATCH v8 5/6] net/thunderx: use new API to save cycles on aarch64

2019-10-21 Thread Gavin Hu
Use the new API to wait in low power state instead of continuous polling to save CPU cycles and power. Signed-off-by: Gavin Hu Reviewed-by: Ruifeng Wang Acked-by: Jerin Jacob --- drivers/net/thunderx/Makefile | 1 + drivers/net/thunderx/meson.build | 1 + drivers/net/thunderx/nicvf_rxtx.c

[dpdk-dev] [PATCH v8 4/6] ticketlock: use new API to reduce contention on aarch64

2019-10-21 Thread Gavin Hu
While using ticket lock, cores repeatedly poll the lock variable. This is replaced by rte_wait_until_equal API. Running ticketlock_autotest on ThunderX2, Ampere eMAG80, and Arm N1SDP[1], there were variances between runs, but no notable performance gain or degradation were seen with and without th

Re: [dpdk-dev] [PATCH v6 0/4] doc: changes to abi policy introducing major abi versions

2019-10-21 Thread Thomas Monjalon
27/09/2019 18:54, Ray Kinsella: > TL;DR abbreviation: > A major ABI version that all DPDK releases during a one year period > support. ABI versioning is managed at a project-level, in place of > library-level > management. ABI changes to add new features are permitted, as long as ABI > compatibili

Re: [dpdk-dev] [PATCH v6 1/4] doc: separate versioning.rst into version and policy

2019-10-21 Thread Thomas Monjalon
27/09/2019 18:54, Ray Kinsella: > Separate versioning.rst into abi versioning and abi policy guidance, in > preparation for adding more detail to the abi policy. > > Signed-off-by: Ray Kinsella > --- > --- /dev/null > +++ b/doc/guides/contributing/abi_policy.rst > @@ -0,0 +1,169 @@ > +.. SPDX-Li

Re: [dpdk-dev] [PATCH v6 5/6] app: add test-sad application

2019-10-21 Thread Akhil Goyal
> > Introduce new application to provide user to evaluate and perform > custom functional and performance tests for IPsec SAD implementation. > > Signed-off-by: Vladimir Medvedkin > Acked-by: Akhil Goyal > Acked-by: Konstantin Ananyev > Tested-by: Konstantin Ananyev > --- > app/Makefile

Re: [dpdk-dev] [PATCH v2 2/3] net/af_xdp: support pinning of IRQs

2019-10-21 Thread Loftus, Ciara
> > On Mon, 30 Sep 2019 16:42:04 + > > Ciara Loftus wrote: > > > > > +/* drivers supported for the queue_irq option */ > > > +enum supported_drivers { > > > + I40E_DRIVER, > > > + IXGBE_DRIVER, > > > + MLX5_DRIVER, > > > + NUM_DRIVERS > > > +}; > > > > Anything device specific like this raises

Re: [dpdk-dev] [PATCH v6 0/4] doc: changes to abi policy introducing major abi versions

2019-10-21 Thread Ray Kinsella
On 21/10/2019 10:50, Thomas Monjalon wrote: > 27/09/2019 18:54, Ray Kinsella: >> TL;DR abbreviation: >> A major ABI version that all DPDK releases during a one year period >> support. ABI versioning is managed at a project-level, in place of >> library-level >> management. ABI changes to add ne

Re: [dpdk-dev] [PATCH v4] cryptodev: extend api of asymmetric crypto by sessionless

2019-10-21 Thread Trahe, Fiona
Hi Anoob, Akhil, I know this patch is already applied, and that's ok. Just want to update with my thoughts on terminology of sessionless vs session-less. Arek suggested below using session-less for all except C code, for consistency with Symmetric crypto. And has done in a few places in API and d

Re: [dpdk-dev] [PATCH v2 0/5] Add session-less, RSA, RSA-CRT to QAT

2019-10-21 Thread Trahe, Fiona
Hi Akhil, There are also some minor changes needed in QAT asymmetric PMD patches - Arek plans to send a v3 later today with the RSA signature tests and those QAT changes. Fiona > -Original Message- > From: Trahe, Fiona > Sent: Thursday, October 17, 2019 10:27 AM > To: Akhil Goyal ; Kuszt

Re: [dpdk-dev] [PATCH v4] app/testpmd: enable GTP header parse and Tx checksum offload

2019-10-21 Thread Ferruh Yigit
On 10/21/2019 10:28 AM, Ferruh Yigit wrote: > On 10/21/2019 1:29 PM, Ting Xu wrote: >> This patch enables testpmd to forward GTP packet in csum fwd mode. >> GTP header structure (without optional fields and extension header) >> and parser function are added. GTPU and GTPC packets are both >> suppor

Re: [dpdk-dev] [PATCH 1/3] net/qede/base: fix for FW bug

2019-10-21 Thread Kevin Traynor
On 20/10/2019 06:20, Rasesh Mody wrote: > In our testing we have identified a critical FW bug. Performance > is degraded significantly for certain packet sizes with 8.40.25.0 FW. > > This patch updates the FW to version 8.40.33.0. The updated FW has a > fix to performance issue. > > The patch als

[dpdk-dev] [PATCH v4 2/3] net/enetc: set random MAC in case no MAC for SI

2019-10-21 Thread Gagandeep Singh
for SGMII interfaces, there can be 0 value written on MAC registers. This patch set the random MAC address for those interfaces. Signed-off-by: Gagandeep Singh --- drivers/net/enetc/Makefile | 2 +- drivers/net/enetc/enetc_ethdev.c | 35 +++- 2 files changed, 3

[dpdk-dev] [PATCH v4 0/3] enetc PMD specific changes

2019-10-21 Thread Gagandeep Singh
v2 change-log: * dpaax integration added * compilation fixed v3 change-log: * added missing BD ring alignment patc v4 change-log: * fixed meson build Gagandeep Singh (3): net/enetc: add macro for BD ring alignment net/enetc: set random MAC in case no MAC for SI net/enetc: enable dpaax libr

[dpdk-dev] [PATCH v4 3/3] net/enetc: enable dpaax library

2019-10-21 Thread Gagandeep Singh
With this patch, enetc driver would start using the physical-virtual library interfaces. Signed-off-by: Gagandeep Singh --- drivers/net/enetc/Makefile | 2 ++ drivers/net/enetc/enetc_ethdev.c | 8 drivers/net/enetc/meson.build| 1 + 3 files changed, 11 insertions(+) diff --gi

[dpdk-dev] [PATCH v4 1/3] net/enetc: add macro for BD ring alignment

2019-10-21 Thread Gagandeep Singh
enetc BD rings should be aligned to 128 instead of RTE_CACHE_LINE_SIZE. Signed-off-by: Gagandeep Singh --- drivers/net/enetc/base/enetc_hw.h | 3 +++ drivers/net/enetc/enetc_ethdev.c | 8 2 files changed, 7 insertions(+), 4 deletions(-) diff --git a/drivers/net/enetc/base/enetc_hw.h

[dpdk-dev] [PATCH v2 0/1] test/crypto: add tests for encrypted digest AES CTR+CMAC

2019-10-21 Thread Adam Dybkowski
This patch adds tests for encrypted digest AES-CTR + AES CMAC using mixed auth-cipher algorithm functions. Tests allow easy extending with new cases, check in-place and out-of-place operations and use linear and sgl buffers as input/output. --- v2: * Improve commit message and fix test function nam

[dpdk-dev] [PATCH v2 1/1] test/crypto: add tests for encrypted digest AES CTR+CMAC

2019-10-21 Thread Adam Dybkowski
This patch adds tests for encrypted digest AES-CTR + AES CMAC using mixed auth-cipher algorithm functions. Tests allow easy extending with new cases, check in-place and out-of-place operations and use linear and sgl buffers as input/output. Signed-off-by: Adam Dybkowski --- app/test/test_cryptod

Re: [dpdk-dev] [PATCH v2 1/1] test/crypto: add tests for encrypted digest AES CTR+CMAC

2019-10-21 Thread Kusztal, ArkadiuszX
> -Original Message- > From: Dybkowski, AdamX > Sent: Monday, October 21, 2019 1:30 PM > To: dev@dpdk.org; Trahe, Fiona ; Kusztal, > ArkadiuszX ; akhil.go...@nxp.com > Cc: Dybkowski, AdamX > Subject: [PATCH v2 1/1] test/crypto: add tests for encrypted digest AES > CTR+CMAC > > This pat

Re: [dpdk-dev] [PATCH] eventdev: flag to identify same destined packets enqueue

2019-10-21 Thread Rao, Nikhil
> -Original Message- > From: Jerin Jacob [mailto:jerinjac...@gmail.com] > Sent: Thursday, October 3, 2019 3:57 PM > To: Hemant Agrawal > Cc: Rao, Nikhil ; Nipun Gupta ; > Jerin Jacob ; dpdk-dev ; Pavan Nikhilesh > ; Sunil Kumar Kori ; > Richardson, Bruce ; Kovacevic, Marko > ; Ori Kam ; Ni

Re: [dpdk-dev] [EXT] Re: [PATCH v10 4/5] kni: add IOVA=VA support in KNI module

2019-10-21 Thread Ferruh Yigit
On 10/18/2019 6:15 PM, Vamsi Krishna Attunuru wrote: > > >> -Original Message- >> From: dev On Behalf Of Ferruh Yigit >> Sent: Wednesday, October 16, 2019 9:44 PM >> To: Vamsi Krishna Attunuru ; Stephen Hemminger >> ; Yigit, Ferruh >> >> Cc: dev@dpdk.org; tho...@monjalon.net; Jerin Jaco

[dpdk-dev] [PATCH] doc: add missing info regard Geneve matching

2019-10-21 Thread Raslan Darawsheh
Fixes: 398b0cdcd ("net/mlx5: add flow match on GENEVE item") Signed-off-by: Raslan Darawsheh --- doc/guides/nics/mlx5.rst | 4 1 file changed, 4 insertions(+) diff --git a/doc/guides/nics/mlx5.rst b/doc/guides/nics/mlx5.rst index 08039bc..fc7de52 100644 --- a/doc/guides/nics/mlx5.rst +++ b

Re: [dpdk-dev] [PATCH v2 1/1] test/crypto: add tests for encrypted digest AES CTR+CMAC

2019-10-21 Thread Akhil Goyal
Hi All, The test_cryptodev.c is getting bloated with a lot of duplicated code. We should plan to consolidate the code so that it is scalable and whenever a new PMD is added, a new testsuite is built and the file gets bloated. In this release we are allowing these type of changes but going forward

Re: [dpdk-dev] [PATCH v11 2/4] eal: add legacy kni option

2019-10-21 Thread Ferruh Yigit
On 10/21/2019 9:03 AM, vattun...@marvell.com wrote: > From: Vamsi Attunuru > > This adds a "--legacy-kni" command-line option. It will > be used to run existing KNI applications with DPDK 19.11 > and later. > > Signed-off-by: Vamsi Attunuru > Suggested-by: Ferruh Yigit <...> > diff --git a/l

Re: [dpdk-dev] [PATCH v11 4/4] kni: add IOVA=VA support in kernel module

2019-10-21 Thread Ferruh Yigit
On 10/21/2019 9:03 AM, vattun...@marvell.com wrote: > From: Vamsi Attunuru > > Patch adds support for kernel module to work in > IOVA = VA mode by providing address translation > routines to convert IOVA aka user space VA to > kernel virtual addresses. > > Signed-off-by: Vamsi Attunuru > Signed

Re: [dpdk-dev] [PATCH] net/mlx5: fix segfault when create hash rxq of drop

2019-10-21 Thread Raslan Darawsheh
Hi, > -Original Message- > From: dev On Behalf Of Xiaoyu Min > Sent: Thursday, October 17, 2019 1:50 PM > To: Shahaf Shuler ; Yongseok Koh > > Cc: dev@dpdk.org; sta...@dpdk.org; Zengmo Gao > Subject: [dpdk-dev] [PATCH] net/mlx5: fix segfault when create hash rxq of > drop > > When to c

  1   2   3   >