Hi Pavan,
thanks for the patch. Please, see my review notes below.
On 10/29/19 8:03 AM, pbhagavat...@marvell.com wrote:
From: Pavan Nikhilesh
Some PMD can't work when certain offloads are disabled, to work around
this the PMD auto enable the offloads internally and expose it through
dev->data
On 10/29/19 8:03 AM, pbhagavat...@marvell.com wrote:
From: Pavan Nikhilesh
Add new Rx offload flag `DEV_RX_OFFLOAD_RSS_HASH` which can be used to
enable/disable PMDs write to `rte_mbuf::hash::rss`.
PMDs notify the validity of `rte_mbuf::hash:rss` to the applcation
by enabling `PKT_RX_RSS_HASH `
On 10/29/19 8:03 AM, pbhagavat...@marvell.com wrote:
From: Pavan Nikhilesh
Add DEV_RX_OFFLOAD_RSS_HASH flag for all PMDs that support RSS hash
delivery.
Signed-off-by: Pavan Nikhilesh
Reviewed-by: Andrew Rybchenko
Reviewed-by: Hemant Agrawal
Acked-by: Jerin Jacob
Acked-by: Ajit Khaparde
On Tue, Oct 29, 2019 at 7:43 AM Wangxiaoyun (Cloud, Network Chip
Application Development Dept) wrote:
>
> Hi David ,
> Thanks for your comments, I check the test-report from
> dpdk.org(https://mails.dpdk.org/archives/test-report/2019-October/101893.html),
> which shows hinic pmd driver passed
On 10/28/19 9:44 PM, Ori Kam wrote:
Hi Andrew,
-Original Message-
From: Andrew Rybchenko
Sent: Monday, October 28, 2019 5:16 PM
To: Ori Kam ; John McNamara
; Marko Kovacevic
; Thomas Monjalon ;
Ferruh Yigit
Cc: dev@dpdk.org; jingjing...@intel.com; step...@networkplumber.org
Subject:
> -Original Message-
> From: Eelco Chaudron
> Sent: Friday, October 25, 2019 5:24 PM
> To: Xing, Beilei ; Zhang, Xiao
> Cc: Zhang, Qi Z ; dev@dpdk.org
> Subject: Re: [dpdk-dev] [PATCH] net/i40e: force promiscuous state after VF
> reset
>
>
>
> On 17 Oct 2019, at 8:34, Xing, Beilei wr
The original design is to use rte_mbuf::udata64 to save the metadata of
protocol extraction which has network protocol data fields and type, an
private API is used to decode this metadata. It is not so generic.
Use the new dynamic mbuf field and flags to handle protocol extraction.
Then the metada
On 29 Oct 2019, at 8:39, Zhang, Xiao wrote:
-Original Message-
From: Eelco Chaudron
Sent: Friday, October 25, 2019 5:24 PM
To: Xing, Beilei ; Zhang, Xiao
Cc: Zhang, Qi Z ; dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] net/i40e: force promiscuous state
after VF
reset
On 17 Oct
Thanks for the information, got it.
Qiming
> -Original Message-
> From: Ye, Xiaolong
> Sent: Tuesday, October 29, 2019 2:26 PM
> To: Yang, Qiming
> Cc: Jiang, JunyuX ; dev@dpdk.org; Chas Williams
> ; sta...@dpdk.org
> Subject: Re: [dpdk-dev] [PATCH] net/bonding: fix segfault using invalid
Hi,
> -Original Message-
> From: dev On Behalf Of Dekel Peled
> Sent: Sunday, October 27, 2019 5:33 PM
> To: Matan Azrad ; Slava Ovsiienko
> ; Shahaf Shuler
> Cc: Ori Kam ; dev@dpdk.org; sta...@dpdk.org
> Subject: [dpdk-dev] [PATCH] net/mlx5: fix use of wrong compilation directive
>
> G
>-Original Message-
>From: dev On Behalf Of Andrew Rybchenko
>Sent: Tuesday, October 29, 2019 12:36 PM
>To: Pavan Nikhilesh Bhagavatula ;
>ferruh.yi...@intel.com; Jerin Jacob Kollanukkaran
>; Thomas Monjalon
>Cc: dev@dpdk.org
>Subject: Re: [dpdk-dev] [PATCH v14 3/7] ethdev: log offloads
> > > > > > 1) We can not standardize all flags when it comes to HW specific
> > > > > > details. We should NOT pollute public API with HW specific details.
> > > > >
> > > > > Currently, no detail to HW NIC specific.
> > > >
> > > > Yes. What if I want to add a "String" they represent a specific m
>On 10/29/19 8:03 AM, pbhagavat...@marvell.com wrote:
>> From: Pavan Nikhilesh
>>
>> Add new Rx offload flag `DEV_RX_OFFLOAD_RSS_HASH` which can be
>used to
>> enable/disable PMDs write to `rte_mbuf::hash::rss`.
>> PMDs notify the validity of `rte_mbuf::hash:rss` to the applcation
>> by enabling `
On Mon, Oct 28, 2019 at 5:09 PM Andrew Rybchenko
wrote:
>
> On 10/28/19 1:49 PM, Thomas Monjalon wrote:
> > The function rte_eth_dev_count() was marked as deprecated in DPDK 18.05
> > in commit d9a42a69febf ("ethdev: deprecate port count function").
> > It was planned to be removed after 19.11 LTS
On 10/29/19 11:33 AM, Pavan Nikhilesh Bhagavatula wrote:
-Original Message-
From: dev On Behalf Of Andrew Rybchenko
Sent: Tuesday, October 29, 2019 12:36 PM
To: Pavan Nikhilesh Bhagavatula ;
ferruh.yi...@intel.com; Jerin Jacob Kollanukkaran
; Thomas Monjalon
Cc: dev@dpdk.org
Subject:
macsec setting is not valid when port is stopped.
In order to make it valid, the patch changes the setting
to where port is started.
Fixes: 597f9fafe13b ("app/testpmd: convert to new Tx offloads API")
Cc: sta...@dpdk.org
Signed-off-by: Sun GuinanX
---
v2:
* Modified function name
* Refactored th
>> @@ -1556,6 +1557,9 @@ sfc_rx_check_mode(struct sfc_adapter *sa,
>struct rte_eth_rxmode *rxmode)
>> rxmode->offloads |=
>DEV_RX_OFFLOAD_OUTER_IPV4_CKSUM;
>> }
>>
>> +if (!(rxmode->offloads & DEV_RX_OFFLOAD_RSS_HASH))
>> +rxmode->offloads |= DEV_RX_OFFLOAD_RSS_HA
Port validation should be prior to getting device data
to avoid segment fault. This patch fixed the segment fault
caused by invalid port using.
Fixes: 6d72657ce379 ("net/bonding: add other aggregator modes")
Fixes: 112891cd27e5 ("net/bonding: add dedicated HW queues for LACP control")
Cc: sta...@d
Hi,
> -Original Message-
> From: dev On Behalf Of Dekel Peled
> Sent: Thursday, October 24, 2019 3:47 PM
> To: Matan Azrad ; Slava Ovsiienko
> ; Shahaf Shuler
> Cc: Ori Kam ; dev@dpdk.org; sta...@dpdk.org
> Subject: [dpdk-dev] [PATCH] net/mlx5: fix LRO dependency to include DV
> flow
>
Hi Olivier,
Thanks for patch set, able run the tests with 512MB page size with this patch
set on Octeontx2 platform, somehow mbuf is holding null fields when pool is
created with 2MB page size, tests like l3fwd, kni are failing due to the
malformed mbufs. Can you confirm if the patch set was ve
On Tue, Oct 15, 2019 at 9:00 PM Flavio Leitner wrote:
> diff --git a/lib/librte_vhost/virtio_net.c b/lib/librte_vhost/virtio_net.c
> index 5b85b832d..da69ab1db 100644
> --- a/lib/librte_vhost/virtio_net.c
> +++ b/lib/librte_vhost/virtio_net.c
> @@ -1289,6 +1289,93 @@ get_zmbuf(struct vhost_virtque
On 10/29, Sun GuinanX wrote:
>macsec setting is not valid when port is stopped.
>In order to make it valid, the patch changes the setting
>to where port is started.
>
>Fixes: 597f9fafe13b ("app/testpmd: convert to new Tx offloads API")
>Cc: sta...@dpdk.org
>
>Signed-off-by: Sun GuinanX
>---
>v2:
>
Hi Vamsi,
On Tue, Oct 29, 2019 at 09:02:26AM +, Vamsi Krishna Attunuru wrote:
> Hi Olivier,
>
> Thanks for patch set, able run the tests with 512MB page size with this patch
> set on Octeontx2 platform, somehow mbuf is holding null fields when pool is
> created with 2MB page size, tests like
Hi Olivier,
> -Original Message-
> From: Olivier Matz
> Sent: Tuesday, October 29, 2019 2:43 PM
> To: Vamsi Krishna Attunuru
> Cc: Anatoly Burakov ; Andrew Rybchenko
> ; Ferruh Yigit ;
> Giridharan, Ganesan ; Jerin Jacob Kollanukkaran
> ; Kiran Kumar Kokkilagadda ;
> Stephen Hemminger ;
On 10/28/19 5:01 PM, Olivier Matz wrote:
rte_mempool_populate_virt() currently requires that both addr
and length are page-aligned.
Remove this uneeded constraint which can be annoying with big
hugepages (ex: 1GB).
Signed-off-by: Olivier Matz
One note below, other than that
Reviewed-by: Andr
On 10/28/2019 5:18 PM, Stephen Hemminger wrote:
> On Mon, 26 Aug 2019 18:32:35 +0530
> Gagandeep Singh wrote:
>
>> --- a/config/common_base
>> +++ b/config/common_base
>> @@ -224,6 +224,11 @@ CONFIG_RTE_LIBRTE_CXGBE_DEBUG_TX=n
>> CONFIG_RTE_LIBRTE_CXGBE_DEBUG_RX=n
>> CONFIG_RTE_LIBRTE_CXGBE_TPU
> -Original Message-
> From: David Marchand
> Sent: Sunday, October 27, 2019 8:48 AM
> To: Pattan, Reshma
> Cc: dev ; dpdk stable ; Rao, Nikhil
> ; Chas Williams ; Richardson, Bruce
> ; Stephen Hemminger
>
> Subject: Re: [dpdk-stable] [PATCH v3] app/test: fix build when ring PMD is
> d
On 10/28/19 3:13 AM, Liu, Yong wrote:
>
>
>> -Original Message-
>> From: Adrian Moreno [mailto:amore...@redhat.com]
>> Sent: Friday, October 25, 2019 8:21 PM
>> To: Liu, Yong ; maxime.coque...@redhat.com; Bie, Tiwei
>> ; Wang, Zhihong
>> Cc: dev@dpdk.org
>> Subject: Re: [PATCH] vhost: fi
On 10/28/19 5:01 PM, Olivier Matz wrote:
The size returned by rte_mempool_op_calc_mem_size_default() is aligned
to the specified page size. Therefore, with big pages, the returned size
can be much more that what we really need to populate the mempool.
For instance, populating a mempool that requ
On 10/28/19 5:01 PM, Olivier Matz wrote:
The previous commit reduced the amount of required memory when
populating the mempool with non iova-contiguous memory.
Since there is no big advantage to have a fully iova-contiguous mempool
if it is not explicitly asked, remove this code, it simplifies t
On 10/28/19 5:01 PM, Olivier Matz wrote:
In rte_mempool_populate_default(), we determine the page size,
which is needed for calc_size and allocation of memory.
Move this in a function and export it, it will be used in next
commit.
Signed-off-by: Olivier Matz
One question below:
Reviewed-by:
On Mon, Oct 28, 2019 at 03:21:35PM +0100, Andrzej Ostruszka wrote:
> Every implementation of a particular version of given symbol needs to be
> marked in its declaration as such (using `__vsym` macro). This patch
> fixes this and also clarifies the documentation about that.
>
> Signed-off-by: And
On 10/28/19 5:01 PM, Olivier Matz wrote:
When populating a mempool, ensure that objects are not located across
several pages, except if user did not request iova contiguous objects.
I think it breaks distribution across memory channels which could
affect performance significantly.
Signed-off-
On 10/28/19 5:07 PM, Olivier Matz wrote:
On Wed, Aug 07, 2019 at 06:21:58PM +0300, Andrew Rybchenko wrote:
On 7/19/19 4:38 PM, Olivier Matz wrote:
When using iova contiguous memory and objets smaller than page size,
ensure that objects are not located across several pages.
It looks like as an
The definition is conflicting with that of the compiler, as show the
following error: ../drivers/net/bnx2x/bnx2x_osal.h:27:17: error:
conflicting types for ‘uint64_t’ #define __le64 uint64_t ^~~~ In file
included from /usr/include/stdint.h:37, from
/usr/lib/gcc/aarch64-linux-gnu/8/include/stdint.h
Hi Jerin,
> -Original Message-
> From: Jerin Jacob
> Sent: Tuesday, October 29, 2019 16:35
> To: Wang, Haiyue
> Cc: Thomas Monjalon ; Yigit, Ferruh
> ; dpdk-dev
> ; Ye, Xiaolong ; Kinsella, Ray
> ;
> Iremonger, Bernard ; Sun, Chenmin
> ; Andrew
> Rybchenko ; Slava Ovsiienko
> ; Steph
From: Kiran Kumar K
Adding support to check TX and RX descriptor status.
Signed-off-by: Kiran Kumar K
---
V2 Changes:
* Merged rx and tx command line tags
* added desc tag for descriptor id
* Added help string
app/test-pmd/cmdline.c | 100
doc/guides/
If there are no ports available to the guest cli application, it will
exit when setting up the default policy because it fails to set the mac
address. This should not be the case, as this example can be used for
many other use cases that do not need ports.
If ports not found, simply set nb_mac_to_
> -Original Message-
> From: David Marchand
> Sent: Sunday 27 October 2019 13:27
> To: Power, Ciara
> Cc: dev ; Richardson, Bruce
> Subject: Re: [dpdk-dev] [PATCH] raw/ioat: enable xstats reset for ioat device
>
> On Wed, Oct 16, 2019 at 3:36 PM Bruce Richardson
> wrote:
> >
> > On Wed
On Tue, Oct 29, 2019 at 12:52 PM Power, Ciara wrote:
> > This patch conflicts with the other series on this driver.
> > Is it really necessary to reset those statistics once the device has been
> > stopped?
> >> It is a necessary change because stopping the device does not reset the
> >> stats, w
> -Original Message-
> From: dev On Behalf Of yasufu...@gmail.com
> Sent: Monday, October 28, 2019 8:08 AM
> To: Burakov, Anatoly ; david.march...@redhat.com
> Cc: dev@dpdk.org; sta...@dpdk.org; yasufu...@gmail.com; Yasufumi Ogawa
>
> Subject: [dpdk-dev] [PATCH v5 1/1] fbarray: fix du
On 10/25/2019 2:48 AM, Di, ChenxuX wrote:
> Hi, Ferruh
>
>> -Original Message-
>> From: Yigit, Ferruh
>> Sent: Friday, October 25, 2019 1:24 AM
>> To: Di, ChenxuX ; dev@dpdk.org
>> Cc: Lu, Wenzhuo ; Yang, Qiming
>>
>> Subject: Re: [dpdk-dev] [PATCH] app/testpmd: fix device hotplug remove
Updates documentation for traffic manager cli as per the changes
made to qos scheduler library.
Signed-off-by: Jasvinder Singh
---
doc/guides/sample_app_ug/ip_pipeline.rst | 24
1 file changed, 16 insertions(+), 8 deletions(-)
diff --git a/doc/guides/sample_app_ug/ip_pi
Updates documentation to reflect the changes in the qos scheduler
library.
Signed-off-by: Jasvinder Singh
---
.../prog_guide/img/sched_hier_per_port.png| Bin 58973 -> 0 bytes
.../prog_guide/img/sched_hier_per_port.svg| Bin 0 -> 1463490 bytes
doc/guides/prog_guide/qos_framework.rst
Update documentation according to the changes made to qos sample
app.
Signed-off-by: Jasvinder Singh
---
doc/guides/sample_app_ug/qos_scheduler.rst | 92 +++---
1 file changed, 81 insertions(+), 11 deletions(-)
diff --git a/doc/guides/sample_app_ug/qos_scheduler.rst
b/doc/guide
On Tue, 29 Oct 2019 10:02:57 +0100
David Marchand wrote:
> On Tue, Oct 15, 2019 at 9:00 PM Flavio Leitner
> wrote:
> > diff --git a/lib/librte_vhost/virtio_net.c
> > b/lib/librte_vhost/virtio_net.c index 5b85b832d..da69ab1db 100644
> > --- a/lib/librte_vhost/virtio_net.c
> > +++ b/lib/librte_vho
On 10/27/2019 9:04 AM, Matan Azrad wrote:
> Hi All
>
> From: Andrew Rybchenko
>> On 10/18/19 7:35 PM, Ferruh Yigit wrote:
>>> On 10/2/2019 2:58 PM, Thomas Monjalon wrote:
24/09/2019 14:03, Matan Azrad:
> From: Ferruh Yigit
>> On 9/15/2019 8:48 AM, Matan Azrad wrote:
>>> Hi Ferruh
On Tue, Oct 29, 2019 at 12:42:20AM +0800, Marvin Liu wrote:
> As doc mentioned, promisc and multicast are by-default supported in
> virtio pmd. Mac/vlan filter are supported by best effort. These control
> messages should return pass.
>
> Fixes: f9b9d1a55775 ("net/virtio-user: add multiple queues
On Tue, Oct 29, 2019 at 4:56 PM Wang, Haiyue wrote:
>
> Hi Jerin,
Hi Wang
>
> > -Original Message-
> > From: Jerin Jacob
> > Sent: Tuesday, October 29, 2019 16:35
> > To: Wang, Haiyue
> > Cc: Thomas Monjalon ; Yigit, Ferruh
> > ; dpdk-dev
> > ; Ye, Xiaolong ; Kinsella, Ray
> > ;
> >
PFE and ENETC depend on DPAA features.
Fixes: e56463ec47f0 ('net/enetc: enable dpaax library')
Fixes: 67fc3ff97c39 ('net/pfe: introduce basic functions')
Cc: Gagandeep Singh
Signed-off-by: Thierry Herbelot
---
drivers/net/Makefile | 4
mk/rte.app.mk| 4
2 files changed, 8 ins
On Mon, Oct 28, 2019 at 10:18:11PM +0800, Marvin Liu wrote:
> Virtio spec only set rule that packed ring maximum size is up to 2^15
> entries. Do not limit packed ring size to power of two.
Please add a "Fixes:" line.
>
> Signed-off-by: Marvin Liu
> ---
> lib/librte_vhost/vhost_user.c | 15 +++
> -Original Message-
> From: dev On Behalf Of Ali Alnubani
> Sent: Wednesday, October 23, 2019 12:56 PM
> To: dev@dpdk.org
> Subject: [dpdk-dev] [PATCH v2] doc: disable doxygen's HAVE_DOT tag
>
> Ubuntu ships with a patched version of doxygen that enables HAVE_DOT
> (disabled by defaul
On Mon, Oct 28, 2019 at 06:34:43PM +0800, Jin Yu wrote:
> Compile librte_vhost/vhost_crypto.c needs the rte_hash.h
> So we need the librte_hash to be compiled before vhost.
> Add the DEPDIRs to make sure this.
>
> Bugzilla ID: 356
> Cc: sta...@dpdk.org
Fixes: 939066d96563 ("vhost/crypto: add publ
The rawdev xstats_reset function is now enabled. It is called when the
ioat autotest completes, to reset all xstat values after they have been
modified during testing.
Signed-off-by: Ciara Power
Reviewed-by: Bruce Richardson
---
v2: Rebased onto master
---
drivers/raw/ioat/ioat_rawdev.c
On Fri, Oct 18, 2019 at 10:26:39AM +0200, Adrian Moreno wrote:
> Currently there are a couple of limitations on the logging system: Most
> of the logs are compiled out and both datapath and controlpath logs
> share the same loglevel.
>
> This patch tries to help fix that situation by:
> - Splittin
> -Original Message-
> From: Jerin Jacob
> Sent: Tuesday, October 29, 2019 20:57
> To: Wang, Haiyue
> Cc: Thomas Monjalon ; Yigit, Ferruh
> ; dpdk-dev
> ; Ye, Xiaolong ; Kinsella, Ray
> ;
> Iremonger, Bernard ; Sun, Chenmin
> ; Andrew
> Rybchenko ; Slava Ovsiienko
> ; Stephen Hemminge
On 27/10/2019 18:35, Thomas Monjalon wrote:
06/08/2019 13:18, Thomas Monjalon:
26/07/2019 12:15, Burakov, Anatoly:
So it's biased towards scaling up quickly, but it's doing that over a
period. Please correct me if i'm wrong as i'm not really familiar with
this codebase, but, assuming the wind
> > > >
> > >
> > > How about *_str_* style ?
> >
> > _name kind of implies it the string. may be _mode is good as it is short.
> >
> > > int
> > > rte_eth_rx_burst_mode_str_get(uint16_t port_id, uint16_t queue_id,
> > > char *buf, int buflen)
> >
>
> About the
This patch series adds an option to make use of link time optimization
(if compiler has support for it). It is split as follows:
- 1st patch is just a minor doc fix for versioning macros
- 2nd patch fixes missing __vsym annotations (needed for LTO)
- 3rd is the LTO enablement
- remaining patches a
This patch adds an option to enable link time optimization. In addition
to LTO option itself (-flto) fat-lto-objects are being used. This is
because during the build pmdinfogen scans the generated ELF objects to
find this_pmd_name* symbol in symbol table. Without fat-lto-objects gcc
produces ELF
Every implementation of a particular version of given symbol needs to be
marked in its declaration as such (using `__vsym` macro). This patch
fixes this and also clarifies the documentation about that.
Signed-off-by: Andrzej Ostruszka
Acked-by: Neil Horman
---
doc/guides/contributing/versionin
During LTO build compiler reports some 'false positive' warnings about
variables being possibly used uninitialized. This patch silences these
warnings.
Exemplary compiler warning to suppress (with LTO enabled):
error: ‘service_id’ may be used uninitialized in this function
[-Werror=maybe-uninitia
This patch fixes documentation of versioning macros so that they are
aligned with their implementation (no underscore is added by macros).
Signed-off-by: Andrzej Ostruszka
Acked-by: Neil Horman
---
doc/guides/contributing/versioning.rst | 4 ++--
lib/librte_eal/common/include/r
Fix the logic for the case of event queue allowing all schedule types.
Compiler warning pointing to this error (with LTO enabled):
error: ‘sched_type’ may be used uninitialized in this function
[-Werror=maybe-uninitialized]
if ((ret < 0 && ret != -EOVERFLOW) ||
Fixes: 6750b21bd6af ("eventdev: a
This patch fixes 'maybe-uninitialized' warnings reported by compiler
when using LTO.
Compiler warning pointing to this error (with LTO enabled):
error: ‘kg_cfg.extracts[0].masks[0].mask’ may be used uninitialized in
this function [-Werror=maybe-uninitialized]
extr->masks[j].mask = cfg->extract
During LTO build compiler reports some 'false positive' warnings about
variables being possibly used uninitialized. This patch silences these
warnings.
Exemplary compiler warning to suppress (with LTO enabled):
error: ‘chunk’ may be used uninitialized in this function
[-Werror=maybe-uninitialized
During LTO build compiler reports some 'false positive' warnings about
variables being possibly used uninitialized. This patch silences these
warnings.
Exemplary compiler warning to suppress (with LTO enabled):
error: ‘features’ may be used uninitialized in this function
[-Werror=maybe-uninitiali
During LTO build compiler reports some 'false positive' warnings about
variables being possibly used uninitialized. This patch silences these
warnings.
Exemplary compiler warning to suppress (with LTO enabled):
error: ‘stats.greatest_free_size’ may be used uninitialized in this
function [-Werror=
During LTO build compiler reports some 'false positive' warnings about
variables being possibly used uninitialized. This patch silences these
warnings.
Exemplary compiler warning to suppress (with LTO enabled):
error: ‘transceiver_type’ may be used uninitialized in this function
[-Werror=maybe-un
During LTO build compiler reports some 'false positive' warnings about
variables being possibly used uninitialized. This patch silences these
warnings.
Exemplary compiler warning to suppress (with LTO enabled):
error: ‘link’ may be used uninitialized in this function
[-Werror=maybe-uninitialized]
During LTO build compiler reports some 'false positive' warnings about
variables being possibly used uninitialized. This patch silences these
warnings.
Exemplary compiler warning to suppress (with LTO enabled):
error: ‘filter_idx’ may be used uninitialized in this function
[-Werror=maybe-uninitia
On 10/26/2019 5:23 PM, Thomas Monjalon wrote:
> 26/10/2019 11:23, Wang, Haiyue:
>> From: Thomas Monjalon [mailto:tho...@monjalon.net]
>>> 26/10/2019 06:40, Wang, Haiyue:
From: Thomas Monjalon [mailto:tho...@monjalon.net]
> 25/10/2019 18:02, Jerin Jacob:
>> On Fri, Oct 25, 2019 at 9:15
On Fri, Oct 25, 2019 at 6:45 PM Yigit, Ferruh
wrote:
>
> On 8/22/2019 9:18 AM, Jakub Grajciar wrote:
> > Zero-copy slave support for memif PMD.
> > Slave interface exposes DPDK memory to
> > master interface. Only single file segments
> > are supported (EAL option --single-file-segments).
Do you
From: Pavan Nikhilesh
Add `rte_eth_dev_set_supported_ptypes` function that will allow the
application to inform the PMD the packet types it is interested in.
Based on the ptypes set PMDs can optimize their Rx path.
-If application doesn’t want any ptype information it can call
`rte_eth_dev_set_s
From: Pavan Nikhilesh
Add new Rx offload flag `DEV_RX_OFFLOAD_RSS_HASH` which can be used to
enable/disable PMDs write to `rte_mbuf::hash::rss`.
PMDs notify the validity of `rte_mbuf::hash:rss` to the applcation
by enabling `PKT_RX_RSS_HASH ` flag in `rte_mbuf::ol_flags`.
Signed-off-by: Pavan Ni
From: Pavan Nikhilesh
Add new Rx offload flags `DEV_RX_OFFLOAD_RSS_HASH` These flags can be used
to enable/disable PMD writes to rte_mbuf fields `hash.rss` and also
`ol_flags:PKT_RX_RSS` and `ol_flags:PKT_RX_FDIR`.
Add new packet type set function `rte_eth_dev_set_supported_ptypes`,
allows appli
From: Pavan Nikhilesh
Some PMDs cannot work when certain offloads are enable/disabled, as a
workaround PMDs auto enable/disable offloads internally and expose it
through dev->data->dev_conf.rxmode.offloads.
After device specific dev_configure is called compare the requested
offloads to the offlo
From: Pavan Nikhilesh
Disable packet type parsing as l2fwd doesn't rely on packet types.
Signed-off-by: Pavan Nikhilesh
---
examples/l2fwd/Makefile| 1 +
examples/l2fwd/main.c | 2 ++
examples/l2fwd/meson.build | 1 +
3 files changed, 4 insertions(+)
diff --git a/examples/l2fwd/Makef
From: Pavan Nikhilesh
Add command to set supported ptype mask.
Usage:
set port ptype_mask
Disable ptype parsing by default.
Signed-off-by: Pavan Nikhilesh
---
app/test-pmd/cmdline.c | 80 +
app/test-pmd/testpmd.c | 6 ++
From: Pavan Nikhilesh
Since pipeline_generic uses `rte_mbuf::hash::rss` add the new Rx offload
flag `DEV_RX_OFFLOAD_RSS_HASH` to inform PMD to copy the RSS hash result
into the mbuf.
Signed-off-by: Pavan Nikhilesh
---
examples/eventdev_pipeline/main.c | 128 -
.../p
From: Pavan Nikhilesh
Add DEV_RX_OFFLOAD_RSS_HASH flag for all PMDs that support RSS hash
delivery.
Signed-off-by: Pavan Nikhilesh
Reviewed-by: Andrew Rybchenko
Reviewed-by: Hemant Agrawal
Acked-by: Jerin Jacob
Acked-by: Ajit Khaparde
---
drivers/net/bnxt/bnxt_ethdev.c | 8 +++-
> -Original Message-
> From: Jerin Jacob
> Sent: Tuesday, October 29, 2019 22:09
> To: Wang, Haiyue
> Cc: Thomas Monjalon ; Yigit, Ferruh
> ; dpdk-dev
> ; Ye, Xiaolong ; Kinsella, Ray
> ;
> Iremonger, Bernard ; Sun, Chenmin
> ; Andrew
> Rybchenko ; Slava Ovsiienko
> ; Stephen Hemminge
On Thu, 27 Jun 2019 16:18:20 +0800
Ziyang Xuan wrote:
> +#
> +# Compile burst-oriented HINIC PMD driver
> +#
> +CONFIG_RTE_LIBRTE_HINIC_PMD=n
The most common naming convention for drivers is:
CONFIG_RTE_LIBRTE_PMD_XXX
so please use that.
On 10/28/19 10:23 PM, Jiang JunyuX wrote:
Port validation should be prior to getting device data
to avoid segment fault. This patch fixed the segment fault
caused by invalid port using.
Fixes: 6d72657ce379 ("net/bonding: add other aggregator modes")
Fixes: 112891cd27e5 ("net/bonding: add dedicat
On Tue, Oct 29, 2019 at 9:12 PM Wang, Haiyue wrote:
>
> > -Original Message-
> > From: Jerin Jacob
> > Sent: Tuesday, October 29, 2019 22:09
> > To: Wang, Haiyue
> > Cc: Thomas Monjalon ; Yigit, Ferruh
> > ; dpdk-dev
> > ; Ye, Xiaolong ; Kinsella, Ray
> > ;
> > Iremonger, Bernard ; Sun
> -Original Message-
> From: Jerin Jacob
> Sent: Tuesday, October 29, 2019 23:59
> To: Wang, Haiyue
> Cc: Thomas Monjalon ; Yigit, Ferruh
> ; dpdk-dev
> ; Ye, Xiaolong ; Kinsella, Ray
> ;
> Iremonger, Bernard ; Sun, Chenmin
> ; Andrew
> Rybchenko ; Slava Ovsiienko
> ; Stephen Hemminge
On Tue, Oct 29, 2019 at 1:21 PM Flavio Leitner wrote:
> On Tue, 29 Oct 2019 10:02:57 +0100
> David Marchand wrote:
> > Using rte_malloc() means that the allocation can end up on any numa
> > node. This external buffer might end up on a different node than the
> > mbuf (which resides on mp->socket
On 10/27/19 9:40 PM, Viacheslav Ovsiienko wrote:
Currently, metadata can be set on egress path via mbuf tx_metadata field
with PKT_TX_METADATA flag and RTE_FLOW_ITEM_TYPE_META matches metadata.
This patch extends the metadata feature usability.
1) RTE_FLOW_ACTION_TYPE_SET_META
When supporting
Hi Slava,
Looks good to me overall. Few minor comments below.
On Sun, Oct 27, 2019 at 06:40:36PM +, Viacheslav Ovsiienko wrote:
> Currently, metadata can be set on egress path via mbuf tx_metadata field
> with PKT_TX_METADATA flag and RTE_FLOW_ITEM_TYPE_META matches metadata.
>
> This patch
On 10/29/19 6:50 PM, Stephen Hemminger wrote:
On Thu, 27 Jun 2019 16:18:20 +0800
Ziyang Xuan wrote:
+#
+# Compile burst-oriented HINIC PMD driver
+#
+CONFIG_RTE_LIBRTE_HINIC_PMD=n
The most common naming convention for drivers is:
CONFIG_RTE_LIBRTE_PMD_XXX
so please use that.
It looks like
On Tue, Oct 29, 2019 at 05:25:22PM +0100, Olivier Matz wrote:
> Hi Slava,
>
> Looks good to me overall. Few minor comments below.
>
> On Sun, Oct 27, 2019 at 06:40:36PM +, Viacheslav Ovsiienko wrote:
> > Currently, metadata can be set on egress path via mbuf tx_metadata field
> > with PKT_TX_
23/10/2019 04:54, Joyce Kong:
> There are a lot functions of bit operations scattered in PMDs,
> consolidate them into a common API family and applied in different
> PMDs to reduce code duplication.
Please, could you look at what Adrien did in the Mellanox PMD?
http://code.dpdk.org/dpdk/latest/so
On 10/29/19 6:37 PM, pbhagavat...@marvell.com wrote:
From: Pavan Nikhilesh
Some PMDs cannot work when certain offloads are enable/disabled, as a
workaround PMDs auto enable/disable offloads internally and expose it
through dev->data->dev_conf.rxmode.offloads.
After device specific dev_configur
On 10/26/2019 7:58 AM, Jerin Jacob wrote:
> On Sat, Oct 26, 2019 at 3:57 AM Thomas Monjalon wrote:
>>
>> 25/10/2019 18:02, Jerin Jacob:
>>> On Fri, Oct 25, 2019 at 9:15 PM Thomas Monjalon wrote:
25/10/2019 16:08, Ferruh Yigit:
> On 10/25/2019 10:36 AM, Thomas Monjalon wrote:
>> 15/10
Hi Andrew,
On Tue, Oct 29, 2019 at 12:21:27PM +0300, Andrew Rybchenko wrote:
> On 10/28/19 5:01 PM, Olivier Matz wrote:
> > rte_mempool_populate_virt() currently requires that both addr
> > and length are page-aligned.
> >
> > Remove this uneeded constraint which can be annoying with big
> > huge
On Tue, Oct 29, 2019 at 01:09:01PM +0300, Andrew Rybchenko wrote:
> On 10/28/19 5:01 PM, Olivier Matz wrote:
> > The size returned by rte_mempool_op_calc_mem_size_default() is aligned
> > to the specified page size. Therefore, with big pages, the returned size
> > can be much more that what we real
On Tue, Oct 29, 2019 at 01:31:22PM +0300, Andrew Rybchenko wrote:
> On 10/28/19 5:01 PM, Olivier Matz wrote:
> > In rte_mempool_populate_default(), we determine the page size,
> > which is needed for calc_size and allocation of memory.
> >
> > Move this in a function and export it, it will be used
On Tue, Oct 29, 2019 at 01:25:10PM +0300, Andrew Rybchenko wrote:
> On 10/28/19 5:01 PM, Olivier Matz wrote:
> > The previous commit reduced the amount of required memory when
> > populating the mempool with non iova-contiguous memory.
> >
> > Since there is no big advantage to have a fully iova-c
Hi, Andrew
Thank you for the review.
> -Original Message-
> From: Andrew Rybchenko
> Sent: Tuesday, October 29, 2019 18:22
> To: Slava Ovsiienko ; dev@dpdk.org
> Cc: Thomas Monjalon ; Matan Azrad
> ; olivier.m...@6wind.com; Ori Kam
> ; Yongseok Koh
> Subject: Re: [dpdk-dev] [PATCH v4] e
Hi Olivier,
> -Original Message-
> From: Olivier Matz
> Sent: Monday, October 28, 2019 7:31 PM
> To: dev@dpdk.org
> Cc: Anatoly Burakov ; Andrew Rybchenko
> ; Ferruh Yigit ;
> Giridharan, Ganesan ; Jerin Jacob Kollanukkaran
> ; Kiran Kumar Kokkilagadda
> ; Stephen Hemminger
> ; Thomas Mon
1 - 100 of 156 matches
Mail list logo
