[dpdk-dev] [PATCH 1/2] buildtools: fix experimental symbols listing

The map-list-symbol.sh script displays the filename, section and symbol names of map files. Example: $ buildtools/map-list-symbol.sh -S EXPERIMENTAL \ lib/librte_ethdev/rte_ethdev_version.map |grep rte_mtr_create lib/librte_ethdev/rte_ethdev_version.map EXPERIMENTAL rte_mtr_create The experim

[dpdk-dev] [PATCH 2/2] buildtools: fix build with coverage enabled

A compiler can reuse a variable name and prefix it when instrumenting with coverage. Example: $ make defconfig T=x86_64-native-linux-gcc O=master $ make EXTRA_CFLAGS='--coverage' O=master [...] CC rte_flow.o rte_flow_dynf_metadata_offs is not flagged as experimental but is listed in version

Re: [dpdk-dev] [PATCH v3] mbuf: extend pktmbuf pool private structure

On Sun, Nov 24, 2019 at 05:53:46AM +, Shahaf Shuler wrote: > With the API and ABI freeze ahead, it will be good to reserve > some bits on the private structure for future use. > > Otherwise we will potentially need to maintain two different > private structure during 2020 period. > > There is

[dpdk-dev] [PATCH 20.02 v2] net/virtio-user: do not close tap when disabling queue pairs

Do not close the tap fds when disabling queue pairs, instead, we just need to unbind the backend. Otherwise, tap port can be destroyed unexpectedly. Fixes: e3b434818bbb ("net/virtio-user: support kernel vhost") Cc: sta...@dpdk.org Reported-by: Stephen Hemminger Signed-off-by: Tiwei Bie --- v2:

[dpdk-dev] [PATCH] app/testpmd: show mac addresses added to a port

From: Kalesh AP Patch adds a runtime function to display the unicast and multicast MAC addresses added to a port. Syntax: show port (port_id) macs|mcast_macs Usage: testpmd> show port 0 macs Number of MAC address added: 1 B0:26:28:7F:F5:C1 testpmd> testpmd> show port 0 mcast_macs Numb

Re: [dpdk-dev] [PATCH 1/2] buildtools: fix experimental symbols listing

On 11/25/19 11:10 AM, David Marchand wrote: > The map-list-symbol.sh script displays the filename, section and symbol > names of map files. > > Example: > $ buildtools/map-list-symbol.sh -S EXPERIMENTAL \ > lib/librte_ethdev/rte_ethdev_version.map |grep rte_mtr_create > lib/librte_ethdev/rte_et

Re: [dpdk-dev] [External] RE: mlx5: the default rule makes VF rep cannot get packets

Hi, please, see below. From: 贺鹏 Sent: Monday, November 25, 2019 9:44 To: Slava Ovsiienko Cc: dev@dpdk.org; Matan Azrad Subject: Re: [External] RE: mlx5: the default rule makes VF rep cannot get packets Hi, 在 2019年11月25日，下午3:32，Slava Ovsiienko mailto:viachesl...@mellanox.com>> 写道： Hi, What

Re: [dpdk-dev] [PATCH 2/2] buildtools: fix build with coverage enabled

On 11/25/19 11:10 AM, David Marchand wrote: > A compiler can reuse a variable name and prefix it when instrumenting > with coverage. > > Example: > $ make defconfig T=x86_64-native-linux-gcc O=master > $ make EXTRA_CFLAGS='--coverage' O=master > [...] > CC rte_flow.o > rte_flow_dynf_metadata_

Re: [dpdk-dev] [PATCH] doc: update metadata feature description for mlx5

Hi, > -Original Message- > From: Viacheslav Ovsiienko > Sent: Monday, November 18, 2019 1:21 PM > To: dev@dpdk.org > Cc: Matan Azrad ; Raslan Darawsheh > ; Ori Kam > Subject: [PATCH] doc: update metadata feature description for mlx5 > > Legacy Verbs supports MARK and FLAG metadata actio

[dpdk-dev] [Bug 371] mlx5: failed to probe the port at testpmd (DPDK 19.11-rc3)

https://bugs.dpdk.org/show_bug.cgi?id=371 Bug ID: 371 Summary: mlx5: failed to probe the port at testpmd (DPDK 19.11-rc3) Product: DPDK Version: unspecified Hardware: ARM OS: Linux Status: UNCONF

Re: [dpdk-dev] [External] RE: mlx5: the default rule makes VF rep cannot get packets

Hi, I see. I am going to try OFED 4.7 official version and see if it works. Thanks. > 在 2019年11月25日，下午4:28，Slava Ovsiienko 写道： > > Hi, > > please, see below. > > From: 贺鹏 mailto:hepeng.0...@bytedance.com>> > Sent: Monday, November 25, 2019 9:44 > To: Slava Ovsiienko

[dpdk-dev] [PATCH] net/hns3: fix checking enough Tx BDs

From: "Wei Hu (Xavier)" In .tx_pkt_burst ops implementation function of hns3 PMD driver, there is one check whether there are enough BDs in the TX queue. If not, driver will stop sending the packets. Currently in the 'for' process loop, the next_to_use member of TX queue is not updated in time a

[dpdk-dev] [PATCH v4 2/4] eal: fix IOVA mode selection as VA for PCI drivers

On 7/22/2019 1:56 PM, David Marchand wrote: > The incriminated commit broke the use of RTE_PCI_DRV_IOVA_AS_VA which > was intended to mean "driver only supports VA" but had been understood > as "driver supports both PA and VA" by most net drivers and used to let > dpdk processes to run as non roo

Re: [dpdk-dev] [PATCH] build: fix windows build failure for 19.11

On Fri, Nov 22, 2019 at 06:59:59PM -0800, Pallavi Kadam wrote: > This patch fixes Windows build failure caused due to > 'config: change ABI versioning to global' patch. Underlying reason is: "While most windows apps can handle both "\" and "/" as path separators, "more" is treating the "/" as the

Re: [dpdk-dev] [PATCH v2 1/5] doc: fix app usage in CCP guide

> > From: Amaranath Somalapuram > > Updateing the CCP doc, fixing description of some parameter. > Changing AES_CBC to aes-cbc, SHA1_HMAC to sha1-hmac > > Fixes: 4433ced9aa ("doc: add AMD CCP guide") > Cc: sta...@dpdk.org > > Signed-off-by: Amaranath Somalapuram > --- Series Applied to dpd

Re: [dpdk-dev] [PATCH] app/crypto-perf: fix incorrect input data for AEAD decrypt

> > > > In AEAD decrypt(verify mode), test data should point to cipher text instead > > of > > plain text > > > > Fixes: 5b2b0a740fba ("app/crypto-perf: overwrite mbuf when verifying") > > > > Signed-off-by: Archana Muniganti > > Acked-by: Anoob Joseph Acked-by: Akhil Goyal Applied to dpdk-n

[dpdk-dev] [PATCH v4] mbuf: extend pktmbuf pool private structure

With the API and ABI freeze ahead, it will be good to reserve some bits on the private structure for future use. Otherwise we will potentially need to maintain two different private structure during 2020 period. There is already one use case for those reserved bits[1] The reserved field should b

Re: [dpdk-dev] [PATCH v4 2/4] eal: fix IOVA mode selection as VA for PCI drivers

25/11/2019 10:33, Ferruh Yigit: > It looks like DPDK application initialized as IOVA=VA, > and the new device is bound to 'igb_uio' which forces it to PA, > fails on above check. Do you mean this use case was not tested earlier with DPDK 19.08? > I would like to get your comment on the issue. >

Re: [dpdk-dev] [PATCH v4] mbuf: extend pktmbuf pool private structure

On Mon, Nov 25, 2019 at 10:21:32AM +, Shahaf Shuler wrote: > With the API and ABI freeze ahead, it will be good to reserve > some bits on the private structure for future use. > > Otherwise we will potentially need to maintain two different > private structure during 2020 period. > > There is

Re: [dpdk-dev] [PATCH v2 3/3] ethdev: improve flow mark Rx offload deprecation notice

On Sun, Nov 24, 2019 at 3:12 AM Thomas Monjalon wrote: > > 23/11/2019 10:42, Jerin Jacob: > > On Sat, Nov 23, 2019 at 3:58 AM Thomas Monjalon wrote: > > > 22/11/2019 12:53, Andrew Rybchenko: > > > > On 11/22/19 2:15 PM, Thomas Monjalon wrote: > > > > > 22/11/2019 11:12, Andrew Rybchenko: > > > >

Re: [dpdk-dev] [PATCH] doc: add abi policy changes to release notes

> -Original Message- > From: Ray Kinsella > Sent: Monday, November 18, 2019 1:15 PM > To: dev@dpdk.org > Cc: Mcnamara, John ; marko.kovace...@intel.co; > Ray Kinsella > Subject: [PATCH] doc: add abi policy changes to release notes > > Add some pointers to the releases notes on the cha

Re: [dpdk-dev] [dpdk-users] What is the 'unit of timestamp' assigned to mbuf packet in DPDK?

From lib/librte_mbuf/rte_mbuf_core.h: |605 /** Valid if PKT_RX_TIMESTAMP is set. The unit and time reference 606 * are not normalized but are always the same for a given port. 607 * Some devices allow to query rte_eth_read_clock that will return the 608 * current device timestamp. 609 */ 610 u

Re: [dpdk-dev] [PATCH 2/2] buildtools: fix build with coverage enabled

On Mon, Nov 25, 2019 at 9:29 AM Andrew Rybchenko wrote: > > On 11/25/19 11:10 AM, David Marchand wrote: > > A compiler can reuse a variable name and prefix it when instrumenting > > with coverage. > > > > Example: > > $ make defconfig T=x86_64-native-linux-gcc O=master > > $ make EXTRA_CFLAGS='--c

[dpdk-dev] [PATCH v3] hash: added a new API to hash to query key id

Adding new API function to query the maximum key ID that could possibly returned by rte_hash_add_key and rte_hash_add_key_with_hash. When RTE_HASH_EXTRA_FLAGS_MULTI_WRITER_ADD is set, the maximum key id is larger than the entry count specified by the user. Signed-off-by: Kumar Amber --- lib/libr

Re: [dpdk-dev] [PATCH v4 2/4] eal: fix IOVA mode selection as VA for PCI drivers

On Mon, Nov 25, 2019 at 6:33 PM Ferruh Yigit wrote: > > > On 7/22/2019 1:56 PM, David Marchand wrote: > > The incriminated commit broke the use of RTE_PCI_DRV_IOVA_AS_VA which > > was intended to mean "driver only supports VA" but had been understood > > as "driver supports both PA and VA" by most

[dpdk-dev] [PATCH v3 2/5] eal: add API to check if its interrupt context

Added an API to check if current execution is in interrupt context. This will be helpful to handle nested interrupt cases. Signed-off-by: Harman Kalra Signed-off-by: Sunil Kumar Kori --- V3: * Rebased patch on latest commit V2: * Removed unnecessary if statement * Reworded subject line * Upd

[dpdk-dev] [PATCH 3/5] common/octeontx2: add interrupt offset to mbox structure

mbox response are triggered at bar2 + RVU_PF_INT or bar2 + RVU_VF_INT, depending upon the device. To process these interrupts different irq handlers are installed. To unify it, added offset field into mbox structure which is initialized with RVU_PF_INT or RVU_VF_INT at the time of otx2_mbox_init.

[dpdk-dev] [PATCH 1/5] drivers/octeontx2: allow experimental symbols

Multiple experimental symbols are used. They must be allowed to avoid compilation error. Signed-off-by: Sunil Kumar Kori --- drivers/common/octeontx2/Makefile | 2 ++ drivers/net/octeontx2/Makefile | 2 ++ drivers/raw/octeontx2_dma/Makefile | 2 ++ 3 files changed, 6 insertions(+) diff --g

[dpdk-dev] [PATCH 5/5] common/octeontx2: enhancing mbox APIs to get response

Based on thread context, mbox API will get response for submitted request. If thread runs in interrupt context then it uses polling based get response API otherwise interrupt based. Signed-off-by: Sunil Kumar Kori --- drivers/common/octeontx2/otx2_dev.c | 27 --- drivers

[dpdk-dev] [PATCH 4/5] common/octeontx2: add polling based response mbox message

Currently otx2_mbox_get_rsp get response once AF driver interrupts after completion. But this funciton will get into deadlock if called in another interrupt context. To avoid it, implemented another version of this function which polls on dedicated memory for a given timeout. Also after clearing

Re: [dpdk-dev] [PATCH v2 3/3] ethdev: improve flow mark Rx offload deprecation notice

25/11/2019 11:44, Jerin Jacob: > On Sun, Nov 24, 2019 at 3:12 AM Thomas Monjalon wrote: > > > > 23/11/2019 10:42, Jerin Jacob: > > > On Sat, Nov 23, 2019 at 3:58 AM Thomas Monjalon > > > wrote: > > > > 22/11/2019 12:53, Andrew Rybchenko: > > > > > On 11/22/19 2:15 PM, Thomas Monjalon wrote: > >

Re: [dpdk-dev] Intel X710, DPDK with SFP - FTLX8574D3BCV-IT link down

Hello, The below patch works for me. With the below patch on 1st retry attempt i40e_aq_get_phy_capabilities returns success. diff --git a/dpdk-17.05/drivers/net/i40e/i40e_ethdev.c b/dpdk-17.05/drivers/net/i40e/i40e_ethdev.c index e9185c44bc..e79fa80854 100644 --- a/dpdk-17.05/drivers/net/i40e/i40

Re: [dpdk-dev] [PATCH v4 2/4] eal: fix IOVA mode selection as VA for PCI drivers

On 11/25/2019 10:22 AM, Thomas Monjalon wrote: 25/11/2019 10:33, Ferruh Yigit: It looks like DPDK application initialized as IOVA=VA, and the new device is bound to 'igb_uio' which forces it to PA, fails on above check. Do you mean this use case was not tested earlier with DPDK 19.08? Perhap

[dpdk-dev] [PATCH v1] doc: update release notes for 19.11

Fix grammar, spelling and formatting of DPDK 19.11 release notes. Signed-off-by: John McNamara --- doc/guides/rel_notes/release_19_11.rst | 148 + 1 file changed, 78 insertions(+), 70 deletions(-) diff --git a/doc/guides/rel_notes/release_19_11.rst b/doc/guides/

Re: [dpdk-dev] [PATCH v4 2/4] eal: fix IOVA mode selection as VA for PCI drivers

On Mon, Nov 25, 2019 at 1:03 PM Ferruh Yigit wrote: > >> I would like to get your comment on the issue. > >> > >> For the OvS mode, hopefully binding the device to 'vfio-pci' > >> can be a solution, but for the cases we don't have that option, > >> can/should we force the DPDK to PA mode after ini

[dpdk-dev] [pull-request] next-crypto 19.11 rc4

The following changes since commit c143928d8977f9d118078a0e6545d9058bbdbe52: devtools: disable automatic probing in null testing (2019-11-24 23:52:02 +0100) are available in the Git repository at: http://dpdk.org/git/next/dpdk-next-crypto for you to fetch changes up to cece4cc134c5b1d73bd

Re: [dpdk-dev] [PATCH v4 2/4] eal: fix IOVA mode selection as VA for PCI drivers

On 25-Nov-19 12:36 PM, David Marchand wrote: On Mon, Nov 25, 2019 at 1:03 PM Ferruh Yigit wrote: I would like to get your comment on the issue. For the OvS mode, hopefully binding the device to 'vfio-pci' can be a solution, but for the cases we don't have that option, can/should we force the D

Re: [dpdk-dev] [PATCH] net/octeontx2: fix ptype parsing disabled by default

On Sat, Nov 23, 2019 at 5:58 PM wrote: > > From: Pavan Nikhilesh > > Enable Ptype parsing by default, only disable when `rte_eth_dev_set_ptypes` > is called with ptype_mask as 0. > This would enable applications that are dependent on packet type parsing > like l3fwd. > > Fixes: d2706e15e6fb ("net

Re: [dpdk-dev] [PATCH] build: fix windows build failure for 19.11

On 23-Nov-19 2:59 AM, Pallavi Kadam wrote: This patch fixes Windows build failure caused due to 'config: change ABI versioning to global' patch. This patch can be merged in 19.11 release. Signed-off-by: Bruce Richardson Reviewed-by: Ranjit Menon Tested-by: Pallavi Kadam --- Missing Fixes: t

Re: [dpdk-dev] [PATCH 2/8] doc: add building with meson to linux GSG

On 22-Nov-19 4:03 PM, Bruce Richardson wrote: Add instructions on building DPDK and using the pkg-config file to the linux GSG. Signed-off-by: Bruce Richardson --- doc/guides/linux_gsg/build_dpdk.rst | 94 +++-- 1 file changed, 90 insertions(+), 4 deletions(-) diff -

Re: [dpdk-dev] [PATCH 2/8] doc: add building with meson to linux GSG

On 22-Nov-19 4:03 PM, Bruce Richardson wrote: Add instructions on building DPDK and using the pkg-config file to the linux GSG. Signed-off-by: Bruce Richardson --- + +Building Applications Using Installed DPDK +~~ + +When installed system-wide, DPDK

Re: [dpdk-dev] [PATCH 1/2] buildtools: fix experimental symbols listing

On Mon, Nov 25, 2019 at 09:10:06AM +0100, David Marchand wrote: > The map-list-symbol.sh script displays the filename, section and symbol > names of map files. > > Example: > $ buildtools/map-list-symbol.sh -S EXPERIMENTAL \ > lib/librte_ethdev/rte_ethdev_version.map |grep rte_mtr_create > lib

Re: [dpdk-dev] [PATCH 2/8] doc: add building with meson to linux GSG

On Mon, Nov 25, 2019 at 01:19:13PM +, Burakov, Anatoly wrote: > On 22-Nov-19 4:03 PM, Bruce Richardson wrote: > > Add instructions on building DPDK and using the pkg-config file to the > > linux GSG. > > > > Signed-off-by: Bruce Richardson > > --- > > doc/guides/linux_gsg/build_dpdk.rst | 9

Re: [dpdk-dev] [PATCH 2/8] doc: add building with meson to linux GSG

On 25-Nov-19 1:27 PM, Bruce Richardson wrote: On Mon, Nov 25, 2019 at 01:19:13PM +, Burakov, Anatoly wrote: On 22-Nov-19 4:03 PM, Bruce Richardson wrote: Add instructions on building DPDK and using the pkg-config file to the linux GSG. Signed-off-by: Bruce Richardson --- doc/guides/lin

Re: [dpdk-dev] [PATCH] build: fix windows build failure for 19.11

On Mon, Nov 25, 2019 at 2:06 PM Burakov, Anatoly wrote: > > On 23-Nov-19 2:59 AM, Pallavi Kadam wrote: > > This patch fixes Windows build failure caused due to > > 'config: change ABI versioning to global' patch. > > This patch can be merged in 19.11 release. > > > > Signed-off-by: Bruce Richardso

Re: [dpdk-dev] [PATCH] net/octeontx2: fix ptype parsing disabled by default

On 11/25/2019 1:00 PM, Jerin Jacob wrote: On Sat, Nov 23, 2019 at 5:58 PM wrote: From: Pavan Nikhilesh Enable Ptype parsing by default, only disable when `rte_eth_dev_set_ptypes` is called with ptype_mask as 0. This would enable applications that are dependent on packet type parsing like l3f

Re: [dpdk-dev] [PATCH] build: fix windows build failure for 19.11

Confirmed author with Bruce offlist. Applied with commitlog proposed by Bruce: While most windows apps can handle both "\" and "/" as path separators, "more" is treating the "/" as the start of a command-line flag in this case, causing errors. Fixes: cba806e07d6f ("build: change ABI versioning t

Re: [dpdk-dev] [PATCH v3 16/19] net/mlx5: add meta data support to Rx datapath

On Thu, Nov 7, 2019 at 6:13 PM Viacheslav Ovsiienko wrote: > @@ -1011,7 +1010,29 @@ > pkts[pos + 3]->timestamp = > rte_be_to_cpu_64(cq[pos + p3].timestamp); > } > - > + if (rte_flow_dynf_metadata_avail()) { > +

Re: [dpdk-dev] [PATCH v4 2/4] eal: fix IOVA mode selection as VA for PCI drivers

25/11/2019 13:58, Burakov, Anatoly: > On 25-Nov-19 12:36 PM, David Marchand wrote: > > On Mon, Nov 25, 2019 at 1:03 PM Ferruh Yigit wrote: > I would like to get your comment on the issue. > > For the OvS mode, hopefully binding the device to 'vfio-pci' > can be a solution, but

Re: [dpdk-dev] [PATCH 2/8] doc: add building with meson to linux GSG

> -Original Message- > From: Burakov, Anatoly > Sent: Monday, November 25, 2019 1:23 PM > To: Richardson, Bruce ; Mcnamara, John > > Cc: dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH 2/8] doc: add building with meson to linux > GSG > > On 22-Nov-19 4:03 PM, Bruce Richardson wrote: > >

Re: [dpdk-dev] [PATCH 2/8] doc: add building with meson to linux GSG

> >>> +.. code-block:: makefile > >>> + > >>> +PKGCONF = pkg-config > >>> + > >>> +CFLAGS += -O3 $(shell $(PKGCONF) --cflags libdpdk) > >>> +LDFLAGS += $(shell $(PKGCONF) --libs libdpdk) > >>> + > >>> +$(APP): $(SRCS-y) Makefile > >>> +$(CC) $(CFLAGS)

[dpdk-dev] [PATCH v2 0/8] GSG Documentation updates

This patchset includes documentation updates for both the Linux and FreeBSD Getting Started Guide Docs. The majority of changes are to add information on building using meson and ninja, with some additional cleanups being performed at the same time. V2: Updated patch 2 following feedback from Anat

[dpdk-dev] [PATCH v2 2/8] doc: add building with meson to linux GSG

Add instructions on building DPDK and using the pkg-config file to the linux GSG. Signed-off-by: Bruce Richardson --- V2: Changes following Anatoly's review: * minor grammar fix * added ldconfig call to instructions and note about needing to add /usr/local/lib* to loader paths on RHEL/Fedora *

[dpdk-dev] [PATCH v2 1/8] doc: update Linux GSG system requirements section

Update the system requirements section of the doc to cover builds with meson and ninja. This involves updating the package dependencies to include meson, ninja and python 3.5, and also updating the optional dependencies section to explain that the components are enabled/disabled automatically by me

[dpdk-dev] [PATCH v2 4/8] doc: remove reference to old versions of FreeBSD

FreeBSD 10 is now EOL and all testing with DPDK takes place on BSD versions 11 and 12, so we can just remove the note. The BSD ports are supported on all non-EOL versions of BSD. Signed-off-by: Bruce Richardson --- doc/guides/freebsd_gsg/install_from_ports.rst | 6 -- 1 file changed, 6 delet

[dpdk-dev] [PATCH v2 3/8] doc: reorder meson and make build instructions for arm

Since the meson instructions are the simpler of the two sets, and also the ones most future-proof, put those first in the user documentation with make instructions following them. Signed-off-by: Bruce Richardson Acked-by: Gavin Hu --- .../linux_gsg/cross_build_dpdk_for_arm64.rst | 32 +

[dpdk-dev] [PATCH v2 6/8] doc: add meson install instructions for FreeBSD

Update the FreeBSD GSG doc with instructions for installing using meson and ninja rather than make. Signed-off-by: Bruce Richardson --- doc/guides/freebsd_gsg/build_dpdk.rst | 164 +++--- 1 file changed, 40 insertions(+), 124 deletions(-) diff --git a/doc/guides/freebsd_gsg/

[dpdk-dev] [PATCH v2 7/8] doc: update documentation on build and running FreeBSD apps

Update the documentation on building and running apps on FreeBSD, taking account of having used meson for building. We can also update the section on the command-line parameters, rather than claiming to be a complete list of parameters, it should describe how to get the complete list and only cover

[dpdk-dev] [PATCH v2 5/8] doc: update examples output in FreeBSD GSG

The output of running the helloworld example on FreeBSD was a little out-of-date and can be shortened by using the latest version of DPDK. Update appropriately. Signed-off-by: Bruce Richardson --- doc/guides/freebsd_gsg/install_from_ports.rst | 56 --- 1 file changed, 22 insertio

[dpdk-dev] [PATCH v2 8/8] doc: drop EAL command-line reference from FreeBSD GSG

The EAL command-line reference section duplicated material covered in a previous chapter, was out of date, and generally is unnecessary as options are best queried directly by passing "--help" to a DPDK binary. Therefore we can drop this section to avoid having to try and keep it up-to-date in the

[dpdk-dev] [PATCH v1] lib/power: fix incorrect parameter to strerror

Should be passing errno rather than ret, which could be negative. Coverity issue: 350362 Fixes: 9dc843eb273b ("power: extend guest channel API for reading") Cc: sta...@dpdk.org Signed-off-by: David Hunt --- lib/librte_power/guest_channel.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

Re: [dpdk-dev] [PATCH v2 2/8] doc: add building with meson to linux GSG

On 25-Nov-19 2:55 PM, Bruce Richardson wrote: Add instructions on building DPDK and using the pkg-config file to the linux GSG. Signed-off-by: Bruce Richardson --- Acked-by: Anatoly Burakov -- Thanks, Anatoly

[dpdk-dev] [PATCH] examples/ioat: handle failure case for ioat dequeue

On a failure with the ioat dequeue, -1 is returned, which was not properly handled. This could lead to out-of-bounds reads on a later loop which assumed a positive return value. Fix this by treating an error as though a dequeue of 0 had been encountered. Coverity issue: 350342 Fixes: 2328542ed84e

Re: [dpdk-dev] [PATCH v2] doc: update qede PMD guide

On 11/22/2019 11:31 PM, Rasesh Mody wrote: > - Add note for sharing an adapter between DPDK and Linux drivers. > - Update the firmware version in example. > - Add Config note for potential error due to lack of memzone desciptor >count. > > Signed-off-by: Rasesh Mody Applied to dpdk-next-n

[dpdk-dev] [PATCH] examples/ioat: handle error when querying number of stats

To get the amount of memory needed for stats, we call the xstats_get_names function with a NULL parameter, which can return -1 on error. This negative value was not previously handled correctly, so we adjust things to quit the stats printing routine if this basic call fails. Coverity issue: 350346

Re: [dpdk-dev] [PATCH] doc: clarify virtio PMD path selection

Thanks your suggestion, I will add the link in v2 version. > -Original Message- > From: Stephen Hemminger > Sent: 2019年11月18日 10:24 > To: Wang, Yinan > Cc: dev@dpdk.org; maxime.coque...@redhat.com; Bie, Tiwei > ; Wang, Zhihong ; > Mcnamara, John ; Kovacevic, Marko > > Subject: Re: [dpdk

Re: [dpdk-dev] [PATCH v3] hash: added a new API to hash to query key id

Hi all , I want to report random untouched unit test cases failed by Jenkins . pls can you guys check why it is unstable ? Every upload shows random test failed . http://mails.dpdk.org/archives/test-report/2019-November/109120.html Regards Amber -Original Message- From: dev On Beha

[dpdk-dev] [PATCH v2] doc: clarify virtio PMD path selection

From: Wang Yinan add virtio paths selection and usage introduction for better virtio usability. Signed-off-by: Wang Yinan --- .../virtio_paths_selection_and_usage.rst | 142 ++ 1 file changed, 142 insertions(+) create mode 100644 doc/guides/howto/virtio_paths_selection_an

Re: [dpdk-dev] [PATCH] net/octeontx2: fix ptype parsing disabled by default

Hi Ferruh, >-Original Message- >From: dev On Behalf Of Ferruh Yigit >Sent: Monday, November 25, 2019 7:32 PM >To: Jerin Jacob ; Pavan Nikhilesh Bhagavatula > >Cc: Jerin Jacob Kollanukkaran ; Nithin Kumar >Dabilpuram ; Kiran Kumar Kokkilagadda >; dpdk-dev >Subject: Re: [dpdk-dev] [PATCH]

Re: [dpdk-dev] [PATCH] net/hns3: fix checking enough Tx BDs

On 11/25/2019 9:00 AM, Wei Hu (Xavier) wrote: > From: "Wei Hu (Xavier)" > > In .tx_pkt_burst ops implementation function of hns3 PMD driver, > there is one check whether there are enough BDs in the TX queue. Out of curiosity, is BD refers to "buffer descriptor"? What is the difference between Tx

Re: [dpdk-dev] [PATCH v3] hash: added a new API to hash to query key id

"Amber, Kumar" writes: > Hi all , > > I want to report random untouched unit test cases failed by Jenkins > . pls can you guys check why it is unstable ? > Every upload shows random test failed . I'll work on the service_autotest patch. > http://mails.dpdk.org/archives/test-report/2019-November

Re: [dpdk-dev] [PATCH] net/octeontx2: fix ptype parsing disabled by default

On 11/25/2019 3:55 PM, Pavan Nikhilesh Bhagavatula wrote: > Hi Ferruh, > >> -Original Message- >> From: dev On Behalf Of Ferruh Yigit >> Sent: Monday, November 25, 2019 7:32 PM >> To: Jerin Jacob ; Pavan Nikhilesh Bhagavatula >> >> Cc: Jerin Jacob Kollanukkaran ; Nithin Kumar >> Dabilpur

Re: [dpdk-dev] [PATCH] net/hns3: fix checking enough Tx BDs

On 11/25/2019 9:00 AM, Wei Hu (Xavier) wrote: > From: "Wei Hu (Xavier)" > > In .tx_pkt_burst ops implementation function of hns3 PMD driver, > there is one check whether there are enough BDs in the TX queue. > If not, driver will stop sending the packets. > > Currently in the 'for' process loop,

[dpdk-dev] [RFC PATCH] mark experimental variables

So far, we did not pay attention to direct access to variables but they are part of the API/ABI too and should be clearly identified. Introduce a __rte_experimental_var tag and mark existing variables. Fixes: a4bcd61de82d ("buildtools: add script to check experimental API exports") Cc: sta...@dpd

Re: [dpdk-dev] Build with coverage fail on rte_flow_dynf_metadata_offs is not flagged as experimental

On Sun, Nov 24, 2019 at 9:18 PM David Marchand wrote: > - I don't think variables were considered in the rte_experimental > framework: seeing the __rte_experimental macro, I doubt it would work > for variables to be put in .text. > Do we need a different marker for those? or did I miss something e

Re: [dpdk-dev] [PATCH] examples/ioat: handle failure case for ioat dequeue

On Mon, Nov 25, 2019 at 03:23:03PM +, Bruce Richardson wrote: > On a failure with the ioat dequeue, -1 is returned, which was not properly > handled. This could lead to out-of-bounds reads on a later loop which > assumed a positive return value. Fix this by treating an error as though a > deque

Re: [dpdk-dev] [PATCH v2 2/3] ethdev: remove deprecation notice about RSS hash offload

On 11/19/2019 3:04 PM, Ferruh Yigit wrote: > On 11/19/2019 12:12 PM, Andrew Rybchenko wrote: >> The offload was added, but the deprecation notice was not removed. >> >> Fixes: 5d308972954c ("ethdev: add mbuf RSS update as an offload") >> >> Signed-off-by: Andrew Rybchenko > > Acked-by: Ferruh Yig

Re: [dpdk-dev] [PATCH v2 1/3] ethdev: remove deprecation notice for packet type set

On 11/19/2019 3:04 PM, Ferruh Yigit wrote: > On 11/19/2019 12:12 PM, Andrew Rybchenko wrote: >> The functionality is added, but the deprecation notice is not >> removed. >> >> Fixes: 5d4813acda2c ("ethdev: add packet type range function") >> >> Signed-off-by: Andrew Rybchenko > > Acked-by: Ferruh

[dpdk-dev] [PATCH] examples/ioat: fix possible null dereference

When searching for raw devices with the correct type, we check the driver name using strcmp, without first checking that the call to info get succeeded and assigned a value to that pointer. If the call to get the device info fails, we can treat it as if the device didn't match, and continue the lo

Re: [dpdk-dev] [PATCH v3] hash: added a new API to hash to query key id

"Amber, Kumar" writes: > Hi all , > > I want to report random untouched unit test cases failed by Jenkins > . pls can you guys check why it is unstable ? > Every upload shows random test failed . > > http://mails.dpdk.org/archives/test-report/2019-November/109120.html I think the service core c

Re: [dpdk-dev] FW: [PATCH] net/nfp: replace license text with SPDX tag

On 11/7/2019 9:13 AM, Hemant Agrawal wrote: > Alejandro, > Please ack this patch also. Unfortunately we don't have a nfp PMD maintainer as of now. If this PMD keeps holding the updates, unfortunately we need to consider removing the PMD from DPDK. > > Regards, > Hemant > >> -Original

[dpdk-dev] [PATCH] net/netvsc: disable before changing RSS parameters

In order to change RSS parameters, the host requires that RSS is disable first. Fixes: 92d23a57cafe ("net/netvsc: support configuring RSS parameters") Cc: sta...@dpdk.org Signed-off-by: Dexuan Cui Signed-off-by: Stephen Hemminger --- drivers/net/netvsc/hn_ethdev.c | 14 ++ 1 file ch

Re: [dpdk-dev] [PATCH v3] hash: added a new API to hash to query key id

Hey Folks, > -Original Message- > From: Aaron Conole > Sent: Monday, November 25, 2019 4:59 PM > To: Amber, Kumar > Cc: dev@dpdk.org; Wang, Yipeng1 ; Yigit, Ferruh > ; tho...@monjalon.net; Van Haaren, Harry > ; Thakur, Sham Singh > ; David Marchand > Subject: Re: [dpdk-dev] [PATCH v3] h

Re: [dpdk-dev] [PATCH v3] hash: added a new API to hash to query key id

> From: Aaron Conole > > - if (!service_valid(id)) > > + if (id >= RTE_SERVICE_NUM_MAX || !service_valid(id)) Why not adding this check in service_valid()?

[dpdk-dev] [PATCH] fix lacp check system address

From: podovinnikov --- drivers/net/bonding/rte_eth_bond_8023ad.c | 22 +- 1 file changed, 21 insertions(+), 1 deletion(-) diff --git a/drivers/net/bonding/rte_eth_bond_8023ad.c b/drivers/net/bonding/rte_eth_bond_8023ad.c index b77a37ddb..132ff74a1 100644 --- a/drivers/net/b

[dpdk-dev] [PATCH] add drop statistic for af_packet

--- drivers/net/af_packet/rte_eth_af_packet.c | 11 ++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/drivers/net/af_packet/rte_eth_af_packet.c b/drivers/net/af_packet/rte_eth_af_packet.c index f5806bf42..eb1902170 100644 --- a/drivers/net/af_packet/rte_eth_af_packet.c +++

Re: [dpdk-dev] [PATCH v3] hash: added a new API to hash to query key id

Thomas Monjalon writes: >> From: Aaron Conole >> > - if (!service_valid(id)) >> > + if (id >= RTE_SERVICE_NUM_MAX || !service_valid(id)) > > Why not adding this check in service_valid()? I think the best fix is to use SERVICE_VALID_GET_OR_ERR_RET() in these places. For this, I at least want

Re: [dpdk-dev] [PATCH] lib/hash: remove unnecessary locks in lock-free

>-Original Message- >From: Dharmik Thakkar [mailto:dharmik.thak...@arm.com] >Sent: Thursday, November 21, 2019 10:18 AM >To: Wang, Yipeng1 ; Gobriel, Sameh >; Richardson, Bruce > >Cc: dev@dpdk.org; honnappa.nagaraha...@arm.com; Dharmik Thakkar > >Subject: [PATCH] lib/hash: remove unnecess

Re: [dpdk-dev] [PATCH] MAINTAINERS: resign from NFP PMD maintainer

13/11/2019 14:05, Alejandro Lucero: > On Wed, Nov 13, 2019 at 12:55 PM Ferruh Yigit > wrote: > > On 11/13/2019 12:47 PM, Alejandro Lucero wrote: > > > I'm leaving Netronome and will not work with the NFP anymore. [...] > > > --- a/MAINTAINERS > > > +++ b/MAINTAINERS > > > Netronome nfp > > > -M:

Re: [dpdk-dev] [PATCH v3] hash: added a new API to hash to query key id

Hi, Amber, Thanks for the patch! A bit comment inlined: >-Original Message- >From: Amber, Kumar >Sent: Monday, November 25, 2019 3:08 AM >To: dev@dpdk.org >Cc: Wang, Yipeng1 >Subject: [PATCH v3] hash: added a new API to hash to query key id > >Adding new API function to query the maximum

Re: [dpdk-dev] [PATCH V1] doc: add tested Intel platforms with Intel NICs

> -Original Message- > From: dev On Behalf Of Chen, Zhaoyan > Sent: Friday, November 22, 2019 2:13 AM > To: dev@dpdk.org > Cc: Li, WenjieX A > Subject: [dpdk-dev] [PATCH V1] doc: add tested Intel platforms with Intel > NICs > > From: Wenjie Li > > Add tested Intel platforms with Int

Re: [dpdk-dev] [PATCH v4] mbuf: extend pktmbuf pool private structure

25/11/2019 11:27, Olivier Matz: > On Mon, Nov 25, 2019 at 10:21:32AM +, Shahaf Shuler wrote: > > With the API and ABI freeze ahead, it will be good to reserve > > some bits on the private structure for future use. > > > > Otherwise we will potentially need to maintain two different > > private

[dpdk-dev] [PATCH] pktgen: Fix IPv6 addressing for set/sequence/save commands, packet headers, UI printing

Current IPv6 functionality in pktgen is broken. This fix makes it so that IPv6 addresses are properly set when using the set, sequence, and save commands and that the IP header and UDP/TCP psuedo-header IPV6 addresses are properly set. To preserve the runtime commands, the `_atoip` function no lon

Re: [dpdk-dev] [PATCH] lib/hash: remove unnecessary locks in lock-free

25/11/2019 19:49, Wang, Yipeng1: > >-Original Message- > >From: Dharmik Thakkar [mailto:dharmik.thak...@arm.com] > >Sent: Thursday, November 21, 2019 10:18 AM > >To: Wang, Yipeng1 ; Gobriel, Sameh > >; Richardson, Bruce > > > >Cc: dev@dpdk.org; honnappa.nagaraha...@arm.com; Dharmik Thakkar

Re: [dpdk-dev] [PATCH] pktgen: Fix IPv6 addressing for set/sequence/save commands, packet headers, UI printing

> On Nov 25, 2019, at 3:46 PM, Frank Li wrote: > > Current IPv6 functionality in pktgen is broken. This fix makes it so that > IPv6 addresses are properly set when using the set, sequence, and save > commands and that the IP header and UDP/TCP psuedo-header IPV6 addresses > are properly set. >

Re: [dpdk-dev] [PATCH] lib/hash: remove unnecessary locks in lock-free

>-Original Message- >From: Thomas Monjalon [mailto:tho...@monjalon.net] >Sent: Monday, November 25, 2019 1:55 PM >To: Wang, Yipeng1 ; Dharmik Thakkar > >Cc: dev@dpdk.org; Gobriel, Sameh ; Richardson, Bruce >; >honnappa.nagaraha...@arm.com >Subject: Re: [dpdk-dev] [PATCH] lib/hash: remove

Re: [dpdk-dev] [PATCH v2] mk: remove library search path from binary

22/11/2019 12:30, Ferruh Yigit: > This patch functionally reverts the patch in fixes line to not have any > hardcoded library path in the final binary for the security reasons, in > case this binary distributed to production environment. > > RPATH only added in RTE_DEVEL_BUILD case and this binary

Re: [dpdk-dev] [PATCH] fix lacp check system address

On Mon, 25 Nov 2019 16:13:26 +0300 Vadim wrote: > + MODE4_DEBUG("prefered partner system > %02x:%02x:%02x:%02x:%02x:%02x " > + "not equal self system: > %02x:%02x:%02x:%02x:%02x:%02x\n", > + partner->port_params.system.addr_byt

Re: [dpdk-dev] [dpdk-stable] [PATCH v4] test/rcu: fix build for small number of cores

25/11/2019 04:36, Gavin Hu: > If the RTE_MAX_LCORE is less than 10, a compilation error is generated: > app/test/test_rcu_qsbr.c:234:10: error: comparison of integer > expressions of different signedness: ‘unsigned int’ and ‘int’ > [-Werror=sign-compare] > > The cause is (RTE_MAX_LCORE - 10) resul

Re: [dpdk-dev] [PATCH] lib/hash: remove unnecessary locks in lock-free

25/11/2019 23:02, Wang, Yipeng1: > From: Thomas Monjalon [mailto:tho...@monjalon.net] > >25/11/2019 19:49, Wang, Yipeng1: > >> From: Dharmik Thakkar [mailto:dharmik.thak...@arm.com] > >> > > >> >Remove __hash_rw_reader_unlock() calls from lock free hash lookup > >> > > >> >Signed-off-by: Dharmik Th

  1   2   >