Re: [dpdk-dev] [PATCH v1 1/3] drivers: introduce vDPA class

2020-01-09 Thread Maxime Coquelin
On 1/8/20 10:28 PM, Thomas Monjalon wrote: > 07/01/2020 18:32, Maxime Coquelin: >> Hi Matan, >> >> On 12/25/19 4:19 PM, Matan Azrad wrote: >>> The vDPA (vhost data path acceleration) drivers provide support for >>> the vDPA operations introduced by the rte_vhost library. >>> >>> Any driver which

Re: [dpdk-dev] [PATCH v1 2/3] doc: add vDPA feature table

2020-01-09 Thread Matan Azrad
From: Tiwei Bie > On Wed, Jan 08, 2020 at 10:42:48AM +, Matan Azrad wrote: > > Hi all > > > > Thanks very much for the review. > > Please see below. > > > > From: Andrew Rybchenko > > > On 1/8/20 8:28 AM, Tiwei Bie wrote: > > > > On Tue, Jan 07, 2020 at 06:39:36PM +0100, Maxime Coquelin wrote

Re: [dpdk-dev] 18.11.6 (LTS) patches review and test

2020-01-09 Thread Julien Meunier
Hi, I launched UT on my target which has a QAT VF device, binded to igb_uio. + TestCase [97] : test_null_auth_only_operation failed + TestCase [99] : test_null_cipher_auth_operation failed When I did some debug, I saw that the content of the digest is 0. If I revert ac0a49ed9258 ("crypto/qat

Re: [dpdk-dev] [PATCH v1 0/3] Introduce new class for vDPA device drivers

2020-01-09 Thread Thomas Monjalon
09/01/2020 03:27, Xu, Rosen: > Hi, > > From: Thomas Monjalon > > 08/01/2020 13:39, Xu, Rosen: > > > From: Matan Azrad > > > > From: Xu, Rosen > > > > > Did you think about OVS DPDK? > > > > > vDPA is a basic module for OVS, currently it will take some > > > > > exception path packet processing f

Re: [dpdk-dev] [dpdk-stable] [PATCH] net/mlx5: fix ConnectX-4LX Tx burst routines set

2020-01-09 Thread Slava Ovsiienko
> -Original Message- > From: Ferruh Yigit > Sent: Wednesday, January 8, 2020 17:55 > To: Slava Ovsiienko ; dev@dpdk.org > Cc: Matan Azrad ; Raslan Darawsheh > ; Ori Kam ; sta...@dpdk.org; > Thomas Monjalon > Subject: Re: [dpdk-stable] [PATCH] net/mlx5: fix ConnectX-4LX Tx burst > routines

Re: [dpdk-dev] [PATCH v2 01/10] app/testpmd: parse flow command line for ESP

2020-01-09 Thread Iremonger, Bernard
Hi Ori, > > Subject: RE: [dpdk-dev] [PATCH v2 01/10] app/testpmd: parse flow > > command line for ESP > > > > Hi Ori, > > > > Thanks for the review. > > > > > > > > > Subject: RE: [dpdk-dev] [PATCH v2 01/10] app/testpmd: parse flow > > > command line for ESP > > > > > > Hi just small comment in

Re: [dpdk-dev] [PATCH v1 0/3] Introduce new class for vDPA device drivers

2020-01-09 Thread Maxime Coquelin
On 1/9/20 9:41 AM, Thomas Monjalon wrote: > 09/01/2020 03:27, Xu, Rosen: >> Hi, >> >> From: Thomas Monjalon >>> 08/01/2020 13:39, Xu, Rosen: From: Matan Azrad > From: Xu, Rosen >> Did you think about OVS DPDK? >> vDPA is a basic module for OVS, currently it will take some

Re: [dpdk-dev] [PATCH v1 0/3] Introduce new class for vDPA device drivers

2020-01-09 Thread Xu, Rosen
> -Original Message- > From: Maxime Coquelin > Sent: Thursday, January 09, 2020 17:24 > To: Thomas Monjalon ; Xu, Rosen > > Cc: Matan Azrad ; Bie, Tiwei ; > Wang, Zhihong ; Wang, Xiao W > ; Yigit, Ferruh ; > dev@dpdk.org; Pei, Andy > Subject: Re: [dpdk-dev] [PATCH v1 0/3] Introduce new

Re: [dpdk-dev] [PATCH v2 0/10] dpdk: introduce __rte_internal tag

2020-01-09 Thread David Marchand
Hello Neil, On Tue, Aug 6, 2019 at 2:22 PM Neil Horman wrote: > > On Tue, Aug 06, 2019 at 12:03:38PM +0200, Thomas Monjalon wrote: > > I think it would be good to rebase and send at the beginning of the 19.11 > > cycle. > > Thank you > > > I'm on PTO for the next 10 days or so, but yes, I'll tak

Re: [dpdk-dev] [PATCH v1] net/axgbe: Add a HW quirk for register definitions

2020-01-09 Thread Ferruh Yigit
On 1/9/2020 7:15 AM, Sebastian, Selwin wrote: > [AMD Official Use Only - Internal Distribution Only] > > Hi Ferruh, > I submitted v2 of the patch as per your guidelines. I checked > sub-device ids and they are also the same. I am not aware of a better way to > address this issue and even L

Re: [dpdk-dev] l2fwd application are not sending continuous packets .

2020-01-09 Thread satyavalli rama
Thanks Stephen, We've tried to debug issue in couple of ways, please correct us whether these approaches or right not wrong? 1. We have increased the MAX_PKT_BURST from 32 to 64 and MEMEPOOL_CAHCE_SIZE 256 to 512 2. Keeping IGB_UIO as the only driver module. 3. Resetting the RX queues. But still we

[dpdk-dev] [PATCH v7 1/4] net/i40e: cleanup Tx buffers

2020-01-09 Thread Chenxu Di
Add support to the i40e driver for the API rte_eth_tx_done_cleanup to force free consumed buffers on Tx ring. Signed-off-by: Chenxu Di --- drivers/net/i40e/i40e_ethdev.c| 3 + drivers/net/i40e/i40e_ethdev_vf.c | 3 + drivers/net/i40e/i40e_rxtx.c | 151 ++

[dpdk-dev] [PATCH v7 0/4] drivers/net: cleanup Tx buffers

2020-01-09 Thread Chenxu Di
Add support to the drivers inclulding i40e, ice, ixgbe and igb vf for the API rte_eth_tx_done_cleanup to force free consumed buffers on Tx ring. --- v7: changed the design of code, reuse exist function. Chenxu Di (4): net/i40e: cleanup Tx buffers net/ice: cleanup Tx buffers net/ixgbe: cle

[dpdk-dev] [PATCH v7 2/4] net/ice: cleanup Tx buffers

2020-01-09 Thread Chenxu Di
Add support to the ice driver for the API rte_eth_tx_done_cleanup to force free consumed buffers on Tx ring. Signed-off-by: Chenxu Di --- drivers/net/ice/ice_ethdev.c | 3 + drivers/net/ice/ice_rxtx.c | 155 +++ drivers/net/ice/ice_rxtx.h | 11 +++ 3 files

[dpdk-dev] [PATCH v7 3/4] net/ixgbe: cleanup Tx buffers

2020-01-09 Thread Chenxu Di
Add support to the ixgbe driver for the API rte_eth_tx_done_cleanup to force free consumed buffers on Tx ring. Signed-off-by: Chenxu Di --- drivers/net/ixgbe/ixgbe_ethdev.c | 4 + drivers/net/ixgbe/ixgbe_rxtx.c | 156 ++- drivers/net/ixgbe/ixgbe_rxtx.h | 10 ++

[dpdk-dev] [PATCH v7 4/4] net/e1000: cleanup Tx buffers

2020-01-09 Thread Chenxu Di
Add support to the igb vf for the API rte_eth_tx_done_cleanup to force free consumed buffers on Tx ring. Signed-off-by: Chenxu Di --- drivers/net/e1000/igb_ethdev.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/e1000/igb_ethdev.c b/drivers/net/e1000/igb_ethdev.c index a3e30dbe

Re: [dpdk-dev] [PATCH v1 0/3] Introduce new class for vDPA device drivers

2020-01-09 Thread Maxime Coquelin
On 1/9/20 10:49 AM, Xu, Rosen wrote: > > >> -Original Message- >> From: Maxime Coquelin >> Sent: Thursday, January 09, 2020 17:24 >> To: Thomas Monjalon ; Xu, Rosen >> >> Cc: Matan Azrad ; Bie, Tiwei ; >> Wang, Zhihong ; Wang, Xiao W >> ; Yigit, Ferruh ; >> dev@dpdk.org; Pei, Andy >

Re: [dpdk-dev] [PATCH v1 0/3] Introduce new class for vDPA device drivers

2020-01-09 Thread Maxime Coquelin
On 1/9/20 10:49 AM, Xu, Rosen wrote: > > >> -Original Message- >> From: Maxime Coquelin >> Sent: Thursday, January 09, 2020 17:24 >> To: Thomas Monjalon ; Xu, Rosen >> >> Cc: Matan Azrad ; Bie, Tiwei ; >> Wang, Zhihong ; Wang, Xiao W >> ; Yigit, Ferruh ; >> dev@dpdk.org; Pei, Andy >

Re: [dpdk-dev] [dpdk-stable] [PATCH] net/mlx5: fix ConnectX-4LX Tx burst routines set

2020-01-09 Thread Ferruh Yigit
On 1/9/2020 9:03 AM, Slava Ovsiienko wrote: >> -Original Message- >> From: Ferruh Yigit >> Sent: Wednesday, January 8, 2020 17:55 >> To: Slava Ovsiienko ; dev@dpdk.org >> Cc: Matan Azrad ; Raslan Darawsheh >> ; Ori Kam ; sta...@dpdk.org; >> Thomas Monjalon >> Subject: Re: [dpdk-stable] [P

Re: [dpdk-dev] [PATCH v1 0/3] Introduce new class for vDPA device drivers

2020-01-09 Thread Xu, Rosen
> -Original Message- > From: Thomas Monjalon > Sent: Thursday, January 09, 2020 16:41 > To: Xu, Rosen > Cc: Matan Azrad ; Maxime Coquelin > ; Bie, Tiwei ; Wang, > Zhihong ; Wang, Xiao W > ; Yigit, Ferruh ; > dev@dpdk.org; Pei, Andy > Subject: Re: [dpdk-dev] [PATCH v1 0/3] Introduce ne

[dpdk-dev] [PATCH v2 1/4] net/mlx5: move Tx complete request routine

2020-01-09 Thread Viacheslav Ovsiienko
The complete request flag is set once per Tx burst call, the code of appropriate routine moved to the end of sending loop. This is preparation step to remove WQE reserved field usage to store index of elts to free. Signed-off-by: Viacheslav Ovsiienko Acked-by: Matan Azrad --- drivers/net/mlx5/m

[dpdk-dev] [PATCH v2 0/4] net/mlx5: remove Tx descriptor reserved field usage

2020-01-09 Thread Viacheslav Ovsiienko
The current Tx datapath implementation in mlx5 PMD uses the 16-bit reserved field within transmit descriptor to store the indices of the elts array keeping the mbuf pointers to be freed on transmit completion. On completion PMD fetches the descriptor index, then fetches the elts array index from re

[dpdk-dev] [PATCH v2 3/4] net/mlx5: add free on completion queue

2020-01-09 Thread Viacheslav Ovsiienko
The new software manged entity is introduced in Tx datapath - free on completion queue. This queue keeps the information how many buffers stored in elts array must freed on send comletion. Each element of the queue contains transmitting descriptor index to be in synch with completion entries (in de

[dpdk-dev] [PATCH v2 4/4] net/mlx5: engage free on completion queue

2020-01-09 Thread Viacheslav Ovsiienko
The free on completion queue keeps the indices of elts array, all mbuf stored below this index should be freed on arrival of normal send completion. In debug version it also contains an index of completed transmitting descriptor (WQE) to check queues synchronization. Signed-off-by: Viacheslav Ovsi

[dpdk-dev] [PATCH v2 2/4] net/mlx5: update Tx error handling routine

2020-01-09 Thread Viacheslav Ovsiienko
This is preparation step, we are going to store the index of elts to free on completion in the dedicated free on completion queue, this patch updates the elts freeing routine and updates Tx error handling routine to be synched with coming new queue. Signed-off-by: Viacheslav Ovsiienko Acked-by: M

[dpdk-dev] [PATCH v2 0/3] Introduce new class for vDPA device drivers

2020-01-09 Thread Matan Azrad
As discussed and as described in RFC "[RFC] net: new vdpa PMD for Mellanox devices", new vDPA driver is going to be added for Mellanox devices - vDPA mlx5 and more. The only vDPA driver now is the IFC driver that is located in net directory. The IFC driver and the new vDPA mlx5 driver provide t

[dpdk-dev] [PATCH v2 1/3] drivers: introduce vDPA class

2020-01-09 Thread Matan Azrad
The vDPA (vhost data path acceleration) drivers provide support for the vDPA operations introduced by the rte_vhost library. Any driver which provides the vDPA operations should be moved\added to the vdpa class under drivers/vdpa/. Create the general files for vDPA class in drivers and in documen

[dpdk-dev] [PATCH v2 2/3] doc: add vDPA feature table

2020-01-09 Thread Matan Azrad
Add vDPA devices features table and explanation. Any vDPA driver can add its own supported features by ading a new ini file to the features directory in doc/guides/vdpadevs/features. Signed-off-by: Matan Azrad --- doc/guides/conf.py| 5 +++ doc/guides/vdpadevs/features/

[dpdk-dev] [PATCH v2 3/3] drivers: move ifc driver to the vDPA class

2020-01-09 Thread Matan Azrad
A new vDPA class was recently introduced. IFC driver implements the vDPA operations, hence it should be moved to the vDPA class. Move it. Signed-off-by: Matan Azrad --- MAINTAINERS | 14 +- doc/guides/nics/features/ifcvf.ini |8 - doc/guides/nics/ifc.rs

[dpdk-dev] [PATCH v2] net/mlx5: fix ConnectX-4LX Tx burst routines set

2020-01-09 Thread Viacheslav Ovsiienko
The tx_burst routine supporting multi-segment packets with legacy MPW and without inline was missed, and there was no valid selection for these options, patch adds the missing routine. Fixes: 82e75f8323bf ("net/mlx5: fix legacy multi-packet Tx descriptors") Cc: sta...@dpdk.org Signed-off-by: Viac

Re: [dpdk-dev] [dpdk-stable] [PATCH] net/mlx5: fix ConnectX-4LX Tx burst routines set

2020-01-09 Thread Slava Ovsiienko
> -Original Message- > From: Ferruh Yigit > Sent: Thursday, January 9, 2020 12:50 > To: Slava Ovsiienko ; dev@dpdk.org > Cc: Matan Azrad ; Raslan Darawsheh > ; Ori Kam ; sta...@dpdk.org; > Thomas Monjalon > Subject: Re: [dpdk-stable] [PATCH] net/mlx5: fix ConnectX-4LX Tx burst > routines

Re: [dpdk-dev] [PATCH v2] testpmd: call cleanup on exit

2020-01-09 Thread Ferruh Yigit
On 1/8/2020 3:28 PM, Stephen Hemminger wrote: > On Wed, 8 Jan 2020 09:45:54 + > "Iremonger, Bernard" wrote: > >> Hi Stephen, >> >>> -Original Message- >>> From: dev On Behalf Of Stephen Hemminger >>> Sent: Tuesday, January 7, 2020 7:00 PM >>> To: dev@dpdk.org >>> Cc: Stephen Hemminge

Re: [dpdk-dev] [PATCH v2] testpmd: call cleanup on exit

2020-01-09 Thread Ferruh Yigit
On 1/9/2020 11:16 AM, Ferruh Yigit wrote: > On 1/8/2020 3:28 PM, Stephen Hemminger wrote: >> On Wed, 8 Jan 2020 09:45:54 + >> "Iremonger, Bernard" wrote: >> >>> Hi Stephen, >>> -Original Message- From: dev On Behalf Of Stephen Hemminger Sent: Tuesday, January 7, 2020 7:

Re: [dpdk-dev] [PATCH v1 0/3] Introduce new class for vDPA device drivers

2020-01-09 Thread Matan Azrad
From: Xu, Rosen > > -Original Message- > > From: Thomas Monjalon > > Sent: Thursday, January 09, 2020 16:41 > > To: Xu, Rosen > > Cc: Matan Azrad ; Maxime Coquelin > > ; Bie, Tiwei ; Wang, > > Zhihong ; Wang, Xiao W > > ; Yigit, Ferruh ; > > dev@dpdk.org; Pei, Andy > > Subject: Re: [

Re: [dpdk-dev] [PATCH v2 0/10] dpdk: introduce __rte_internal tag

2020-01-09 Thread Neil Horman
On Thu, Jan 09, 2020 at 10:55:04AM +0100, David Marchand wrote: > Hello Neil, > > On Tue, Aug 6, 2019 at 2:22 PM Neil Horman wrote: > > > > On Tue, Aug 06, 2019 at 12:03:38PM +0200, Thomas Monjalon wrote: > > > I think it would be good to rebase and send at the beginning of the 19.11 > > > cycle

Re: [dpdk-dev] [PATCH 12/14] examples/ipsec-secgw: add driver outbound worker

2020-01-09 Thread Anoob Joseph
Hi Konstantin, Please see inline. Thanks, Anoob > -Original Message- > From: dev On Behalf Of Ananyev, Konstantin > Sent: Tuesday, January 7, 2020 8:01 PM > To: Anoob Joseph ; Akhil Goyal > ; Nicolau, Radu ; Thomas > Monjalon > Cc: Ankur Dwivedi ; Jerin Jacob Kollanukkaran > ; Narayana

Re: [dpdk-dev] [PATCH v2 0/10] dpdk: introduce __rte_internal tag

2020-01-09 Thread David Marchand
On Thu, Jan 9, 2020 at 12:46 PM Neil Horman wrote: > > On Thu, Jan 09, 2020 at 10:55:04AM +0100, David Marchand wrote: > > Hello Neil, > > > > On Tue, Aug 6, 2019 at 2:22 PM Neil Horman wrote: > > > > > > On Tue, Aug 06, 2019 at 12:03:38PM +0200, Thomas Monjalon wrote: > > > > I think it would be

[dpdk-dev] [PATCH 0/6] meson build improvements

2020-01-09 Thread Bruce Richardson
These patches make some improvements to the meson build, particularly for documentation. They also remove many, but not all warnings issued by meson e.g. warnings about newer features unsupported in baseline. The biggest change is to improve the handling of the guide html docs. The change here is

[dpdk-dev] [PATCH 3/6] doc/api: fix warning with meson build

2020-01-09 Thread Bruce Richardson
The install parameter to configure_file is new in 0.50 and generates a warning since it is newer than our minimum version of 0.47.1. The parameter, however, is unneeded as the documentation states: "When omitted it defaults to true when install_dir is set and not empty, false otherwise." Given th

[dpdk-dev] [PATCH 1/6] kernel/linux/kni: fix meson warning about console keyword

2020-01-09 Thread Bruce Richardson
Since kni no longer includes the ethtool code and so is faster to build, we no longer need the console parameter to have incremental screen updates as it builds. Therefore, we drop the keyword which removes the warning. Fixes: b78f32cff94d ("kni: support meson build") Cc: bl...@debian.org Signed-

[dpdk-dev] [PATCH 2/6] build: skip processing docs folder if docs disabled

2020-01-09 Thread Bruce Richardson
While each target is set to be ignored if the docs are disabled in the meson build, there is little reason to process the docs folder at all. Signed-off-by: Bruce Richardson --- doc/meson.build | 4 1 file changed, 4 insertions(+) diff --git a/doc/meson.build b/doc/meson.build index c5410d

[dpdk-dev] [PATCH 6/6] doc/api: reduce indentation in meson build file

2020-01-09 Thread Bruce Richardson
When building the API docs, we can make the meson.build file easier to read, and allow more code per line, by using subdir_done() to quit early. Signed-off-by: Bruce Richardson --- doc/api/meson.build | 98 +++-- 1 file changed, 50 insertions(+), 48 deleti

[dpdk-dev] [PATCH 4/6] doc/guides: reduce whitespace in meson build file

2020-01-09 Thread Bruce Richardson
For building the guides, we can make the meson.build easier to read by using the subdir_done function to quit early. Signed-off-by: Bruce Richardson --- doc/guides/meson.build | 44 ++ 1 file changed, 23 insertions(+), 21 deletions(-) diff --git a/doc/gui

[dpdk-dev] [PATCH 5/6] doc/guides: rebuild with meson whenever a file changes

2020-01-09 Thread Bruce Richardson
Add proper support for calling sphinx whenever a file in the doc directory changes. This is accomplished by using a wrapper script for sphinx, which runs sphinx but also emits a gcc-format dependency file listing all the doc files. This is used by ninja so that any change to the doc files triggers

Re: [dpdk-dev] [PATCH 01/14] examples/ipsec-secgw: add default rte_flow for inline Rx

2020-01-09 Thread Lukas Bartosik
Hi Konstantin, Please see my question inline. Thanks, Lukasz On 16.12.2019 16:58, Anoob Joseph wrote: > Hi Konstantin, > > Thanks for the review. Please see inline. > > Thanks, > Anoob > >> -Original Message- >> From: Ananyev, Konstantin >> Sent: Monday, December 16, 2019 7:51 PM >>

[dpdk-dev] [PATCH v2 0/6] meson build improvements

2020-01-09 Thread Bruce Richardson
These patches make some improvements to the meson build, particularly for documentation. They also remove many, but not all warnings issued by meson e.g. warnings about newer features unsupported in baseline. The biggest change is to improve the handling of the guide html docs. The change here is

[dpdk-dev] [PATCH v2 2/6] build: skip processing docs folder if docs disabled

2020-01-09 Thread Bruce Richardson
While each target is set to be ignored if the docs are disabled in the meson build, there is little reason to process the docs folder at all. Signed-off-by: Bruce Richardson --- doc/meson.build | 4 1 file changed, 4 insertions(+) diff --git a/doc/meson.build b/doc/meson.build index c5410d

[dpdk-dev] [PATCH v2 0/6] meson build improvements

2020-01-09 Thread Bruce Richardson
These patches make some improvements to the meson build, particularly for documentation. They also remove many, but not all warnings issued by meson e.g. warnings about newer features unsupported in baseline. The biggest change is to improve the handling of the guide html docs. The change here is

[dpdk-dev] [PATCH v2 5/6] doc/guides: rebuild with meson whenever a file changes

2020-01-09 Thread Bruce Richardson
Add proper support for calling sphinx whenever a file in the doc directory changes. This is accomplished by using a wrapper script for sphinx, which runs sphinx but also emits a gcc-format dependency file listing all the doc files. This is used by ninja so that any change to the doc files triggers

[dpdk-dev] [PATCH v2 1/6] kernel/linux/kni: fix meson warning about console keyword

2020-01-09 Thread Bruce Richardson
Since kni no longer includes the ethtool code and so is faster to build, we no longer need the console parameter to have incremental screen updates as it builds. Therefore, we drop the keyword which removes the warning. Fixes: b78f32cff94d ("kni: support meson build") Cc: bl...@debian.org Signed-

[dpdk-dev] [PATCH v2 3/6] doc/api: fix warning with meson build

2020-01-09 Thread Bruce Richardson
The install parameter to configure_file is new in 0.50 and generates a warning since it is newer than our minimum version of 0.47.1. The parameter, however, is unneeded as the documentation states: "When omitted it defaults to true when install_dir is set and not empty, false otherwise." Given th

[dpdk-dev] [PATCH v2 4/6] doc/guides: reduce whitespace in meson build file

2020-01-09 Thread Bruce Richardson
For building the guides, we can make the meson.build easier to read by using the subdir_done function to quit early. Signed-off-by: Bruce Richardson --- doc/guides/meson.build | 44 ++ 1 file changed, 23 insertions(+), 21 deletions(-) diff --git a/doc/gui

[dpdk-dev] [PATCH v2 6/6] doc/api: reduce indentation in meson build file

2020-01-09 Thread Bruce Richardson
When building the API docs, we can make the meson.build file easier to read, and allow more code per line, by using subdir_done() to quit early. Signed-off-by: Bruce Richardson --- doc/api/meson.build | 98 +++-- 1 file changed, 50 insertions(+), 48 deleti

[dpdk-dev] [PATCH v3 3/9] net/i40e: improve RSS debug

2020-01-09 Thread Bernard Iremonger
improve RSS debug in i40e_ethdev.c Signed-off-by: Bernard Iremonger --- drivers/net/i40e/i40e_ethdev.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/drivers/net/i40e/i40e_ethdev.c b/drivers/net/i40e/i40e_ethdev.c index 5999c96..5f1cf8a 100644 --- a/drivers/net/i40e/

[dpdk-dev] [PATCH v3 1/9] app/testpmd: parse flow command line for ESP

2020-01-09 Thread Bernard Iremonger
add ITEM_ESP add ITEM_ESP_SPI add debug to cmdline_flow.c Signed-off-by: Bernard Iremonger Acked-by: Ori Kam --- app/test-pmd/cmdline_flow.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/app/test-pmd/cmdline_flow.c b/app/test-pmd/cmdline_flow.c index 9643148..9c6edb8 10

[dpdk-dev] [PATCH v3 2/9] app/testpmd: dump Rx and Tx mbuf

2020-01-09 Thread Bernard Iremonger
add call to rte_pktmbuf_dump() in dump_pkt_burst in util.c Signed-off-by: Bernard Iremonger --- app/test-pmd/util.c | 1 + 1 file changed, 1 insertion(+) diff --git a/app/test-pmd/util.c b/app/test-pmd/util.c index b514be5..bf03873 100644 --- a/app/test-pmd/util.c +++ b/app/test-pmd/util.c @@ -

[dpdk-dev] [PATCH v3 8/9] doc: release note for ESP

2020-01-09 Thread Bernard Iremonger
Release note for ESP support on the i40e PMD. Release note for ESP support on testpmd. Signed-off-by: Bernard Iremonger --- doc/guides/rel_notes/release_20_02.rst | 9 + 1 file changed, 9 insertions(+) diff --git a/doc/guides/rel_notes/release_20_02.rst b/doc/guides/rel_notes/release_2

[dpdk-dev] [PATCH v3 0/9] net/i40e: ESP support

2020-01-09 Thread Bernard Iremonger
Add support for ESP flows to testpmd. Improve debug information in testpmd and the i40e PMD. Process ESP flows on the i40e Flow Director and RSS. Changes in V3: - Added i40e_flow_set_filter_spi() function in i40e_flow.c Set UDP destination port to 4500 for ESP in i40e_ethdev.h Split f

[dpdk-dev] [PATCH v3 6/9] net/i40e: display Flow Director packet

2020-01-09 Thread Bernard Iremonger
call rte_hexdump in i40e_flow_fdir_construct_pkt() in i40e_fdir.c Signed-off-by: Bernard Iremonger --- drivers/net/i40e/i40e_fdir.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/net/i40e/i40e_fdir.c b/drivers/net/i40e/i40e_fdir.c index 3fa6297..78329d2 100644 ---

[dpdk-dev] [PATCH v3 9/9] doc: update i40e user guide

2020-01-09 Thread Bernard Iremonger
Update the i40e user guide with ESP information. Signed-off-by: Bernard Iremonger --- doc/guides/nics/i40e.rst | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/doc/guides/nics/i40e.rst b/doc/guides/nics/i40e.rst index 38acf59..5cf34d9 100644 --- a/doc/guides/nics/i40e.rst +

[dpdk-dev] [PATCH v3 7/9] librte_ethdev: add ESP and AH flow types to RSS

2020-01-09 Thread Bernard Iremonger
Add flow types for the following PCTYPE's in the DDP ipsec profile: 14: IPV6 ESP 15: IPV4 ESP 16: IPV6 AH 17: IPV4 AH 18: IPV6 UDP ESP 19: IPV4 UDP ESP Add the following RSS macros for IPsec: ETH_RSS_ESP ETH_RSS_AH ETH_RSS_IPSEC Signed-off-by: Bernard Iremonger --- lib/librte_ethdev/rte_ethdev.

[dpdk-dev] [PATCH v3 5/9] net/i40e: process ESP flows

2020-01-09 Thread Bernard Iremonger
Process ESP flows on Flow Director and RSS. add eth/ipv4/esp and eth/ipv6/esp patterns add eth/ipv4/udp/esp and eth/ipv6/esp/udp patterns add flow structures for above patterns update i40e_flow_parse_fdir_filter() add i40e_flow_set_filter_spi() add fill_ip6_head() add oip_type in filter add is_udp

[dpdk-dev] [PATCH v3 4/9] net/i40e: handle ESP tunnel

2020-01-09 Thread Bernard Iremonger
handle ESP tunnel in rte_pmd_i40e.c Signed-off-by: Bernard Iremonger --- drivers/net/i40e/rte_pmd_i40e.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/net/i40e/rte_pmd_i40e.c b/drivers/net/i40e/rte_pmd_i40e.c index fdcb1a4..b987346 100644 --- a/drivers/net/i40e/rt

[dpdk-dev] [PATCH v2] net/virtio-user: fix return value of tap offload sets not checked

2020-01-09 Thread Yunjian Wang
The function vhost_kernel_tap_set_offload() could return errors, the return value need to be checked. And there is no need to fail when error is -ENOTSUP. Fixes: 1db4d2330bc8 ("net/virtio-user: check negotiated features before set") Cc: sta...@dpdk.org Signed-off-by: Yunjian Wang --- v2: * No n

[dpdk-dev] [PATCH] ethdev: fix secondary process change share memory

2020-01-09 Thread Fang TongHao
Hi all,I am from Sangfor Tech.I found a bug when using DPDK in multiprocess scenario.The secondary process enters "rte_eth_dev_pci_copy_info" function when initializing.Then it sets the value of struct "rte_eth_dev_data.dev_flags" to zero, but this struct is shared by primary process and secondary

Re: [dpdk-dev] [PATCH v3 6/9] net/i40e: display Flow Director packet

2020-01-09 Thread Zhang, Qi Z
Hi Bernard: > -Original Message- > From: Iremonger, Bernard > Sent: Thursday, January 9, 2020 8:17 PM > To: dev@dpdk.org; Xing, Beilei ; Zhang, Qi Z > ; Doherty, Declan > Cc: Ananyev, Konstantin ; Byrne, Stephen1 > ; Zhang, Helin ; > Iremonger, Bernard > Subject: [PATCH v3 6/9] net/i40e

[dpdk-dev] [PATCH 1/2] build: fix libm detection in meson

2020-01-09 Thread David Marchand
Using version 0.47.1, meson is unable to find the math library in Travis for the 32bits job. Quite surprisingly, this problem is not seen with the 64bits jobs. Switching to 0.48.0, the problem disappears. But we should pass 'm' to find_library instead of 'libm' anyway. Fixes: 98edcbb5ab2f ("eal/

[dpdk-dev] [PATCH 2/2] ci: use meson 0.47.1

2020-01-09 Thread David Marchand
meson 0.53.0 has a compatibility issue [1] with the python 3.5.2 that comes in Ubuntu 16.04. On the other hand, the minimal version supported in dpdk is 0.47.1. Stick to this version to avoid getting hit by regressions in meson latest shiny release. 1: https://github.com/mesonbuild/meson/issues/6

Re: [dpdk-dev] [PATCH 1/4] lib/crypto: add support for ECDSA

2020-01-09 Thread Kusztal, ArkadiuszX
Hi Anoob, > -Original Message- > From: Anoob Joseph > Sent: Thursday, January 2, 2020 8:55 AM > To: Kusztal, ArkadiuszX ; Akhil Goyal > ; Doherty, Declan ; De > Lara Guarch, Pablo > Cc: Ayuj Verma ; Trahe, Fiona > ; Jerin Jacob Kollanukkaran ; > Narayana Prasad Raju Athreya ; Shally Verm

Re: [dpdk-dev] [PATCH 1/2] build: fix libm detection in meson

2020-01-09 Thread Bruce Richardson
On Thu, Jan 09, 2020 at 01:59:15PM +0100, David Marchand wrote: > Using version 0.47.1, meson is unable to find the math library in Travis > for the 32bits job. > Quite surprisingly, this problem is not seen with the 64bits jobs. > > Switching to 0.48.0, the problem disappears. > > But we should

Re: [dpdk-dev] [PATCH 2/2] ci: use meson 0.47.1

2020-01-09 Thread Bruce Richardson
On Thu, Jan 09, 2020 at 01:59:16PM +0100, David Marchand wrote: > meson 0.53.0 has a compatibility issue [1] with the python 3.5.2 that comes > in Ubuntu 16.04. > On the other hand, the minimal version supported in dpdk is 0.47.1. > > Stick to this version to avoid getting hit by regressions in me

[dpdk-dev] [PATCH] mempool: fix mempool virt populate with small chunks

2020-01-09 Thread Olivier Matz
To populate a mempool with a virtual area, the mempool code calls rte_mempool_populate_iova() for each iova-contiguous area. It happens (rarely) that this area is too small to store one object. In this case, rte_mempool_populate_iova() returns an error, which is forwarded by rte_mempool_populate_vi

[dpdk-dev] [PATCH] mempool: fix slow allocation of large mempools

2020-01-09 Thread Olivier Matz
When allocating a mempool which is larger than the largest available area, it can take a lot of time: a- the mempool calculate the required memory size, and tries to allocate it, it fails b- then it tries to allocate the largest available area (this does not request new huge pages) c- add th

Re: [dpdk-dev] Inconsistent behavior of mempool with regards to hugepage allocation

2020-01-09 Thread Olivier Matz
On Tue, Jan 07, 2020 at 01:06:01PM +, Burakov, Anatoly wrote: > On 27-Dec-19 11:11 AM, Olivier Matz wrote: > > Hi Bao-Long, > > > > On Fri, Dec 27, 2019 at 06:05:57PM +0800, Bao-Long Tran wrote: > > > Hi Olivier, > > > > > > > On 27 Dec 2019, at 4:11 PM, Olivier Matz wrote: > > > > > > > >

Re: [dpdk-dev] 18.11.6 (LTS) patches review and test

2020-01-09 Thread Kevin Traynor
On 25/12/2019 05:17, Pei Zhang wrote: > Hi Kevin, > > Testing with 18.11.6-rc1 from Red Hat looks good. > Ack, thanks for testing Pei. > We cover below 14 scenarios and and all get PASS: > > (1)Guest with device assignment(PF) throughput testing(1G hugepage size): > PASS > (2)Guest with devi

Re: [dpdk-dev] [PATCH] mempool: fix mempool virt populate with small chunks

2020-01-09 Thread David Marchand
On Thu, Jan 9, 2020 at 2:27 PM Olivier Matz wrote: > > To populate a mempool with a virtual area, the mempool code calls > rte_mempool_populate_iova() for each iova-contiguous area. It happens > (rarely) that this area is too small to store one object. In this case, > rte_mempool_populate_iova() r

Re: [dpdk-dev] 18.11.6 (LTS) patches review and test

2020-01-09 Thread Kevin Traynor
On 26/12/2019 13:35, Ali Alnubani wrote: > Hi, > >> -Original Message- >> From: Kevin Traynor >> Sent: Wednesday, December 18, 2019 1:42 PM >> To: sta...@dpdk.org >> Cc: dev@dpdk.org; Abhishek Marathe ; >> Akhil Goyal ; Ali Alnubani ; >> benjamin.wal...@intel.com; David Christensen ; >> H

Re: [dpdk-dev] [PATCH v3 3/9] net/i40e: improve RSS debug

2020-01-09 Thread Zhang, Qi Z
> -Original Message- > From: Iremonger, Bernard > Sent: Thursday, January 9, 2020 8:16 PM > To: dev@dpdk.org; Xing, Beilei ; Zhang, Qi Z > ; Doherty, Declan > Cc: Ananyev, Konstantin ; Byrne, Stephen1 > ; Zhang, Helin ; > Iremonger, Bernard > Subject: [PATCH v3 3/9] net/i40e: improve

Re: [dpdk-dev] [PATCH] mempool: fix mempool virt populate with small chunks

2020-01-09 Thread Olivier Matz
On Thu, Jan 09, 2020 at 02:40:06PM +0100, David Marchand wrote: > On Thu, Jan 9, 2020 at 2:27 PM Olivier Matz wrote: > > > > To populate a mempool with a virtual area, the mempool code calls > > rte_mempool_populate_iova() for each iova-contiguous area. It happens > > (rarely) that this area is to

Re: [dpdk-dev] [PATCH] mempool: fix mempool virt populate with small chunks

2020-01-09 Thread Burakov, Anatoly
On 09-Jan-20 1:27 PM, Olivier Matz wrote: To populate a mempool with a virtual area, the mempool code calls rte_mempool_populate_iova() for each iova-contiguous area. It happens (rarely) that this area is too small to store one object. In this case, rte_mempool_populate_iova() returns an error, w

Re: [dpdk-dev] [PATCH] mempool: fix slow allocation of large mempools

2020-01-09 Thread Burakov, Anatoly
On 09-Jan-20 1:27 PM, Olivier Matz wrote: When allocating a mempool which is larger than the largest available area, it can take a lot of time: a- the mempool calculate the required memory size, and tries to allocate it, it fails b- then it tries to allocate the largest available area (this

Re: [dpdk-dev] [PATCH v3 5/9] net/i40e: process ESP flows

2020-01-09 Thread Zhang, Qi Z
Hi Bernard: > -Original Message- > From: Iremonger, Bernard > Sent: Thursday, January 9, 2020 8:17 PM > To: dev@dpdk.org; Xing, Beilei ; Zhang, Qi Z > ; Doherty, Declan > Cc: Ananyev, Konstantin ; Byrne, Stephen1 > ; Zhang, Helin ; > Iremonger, Bernard > Subject: [PATCH v3 5/9] net/i40e

Re: [dpdk-dev] [PATCH v7 3/4] net/ixgbe: cleanup Tx buffers

2020-01-09 Thread Ananyev, Konstantin
Hi Chenxu, Good progress wih _full_version, but still some issues remains I think. More comments inline. Konstantin > > Signed-off-by: Chenxu Di > --- > drivers/net/ixgbe/ixgbe_ethdev.c | 4 + > drivers/net/ixgbe/ixgbe_rxtx.c | 156 ++- > drivers/net/ixgbe/ixg

Re: [dpdk-dev] [PATCH v3 6/9] net/i40e: display Flow Director packet

2020-01-09 Thread Iremonger, Bernard
Hi Qi, > -Original Message- > From: Zhang, Qi Z > Sent: Thursday, January 9, 2020 12:44 PM > To: Iremonger, Bernard ; dev@dpdk.org; > Xing, Beilei ; Doherty, Declan > > Cc: Ananyev, Konstantin ; Byrne, Stephen1 > ; Zhang, Helin > Subject: RE: [PATCH v3 6/9] net/i40e: display Flow Direc

Re: [dpdk-dev] 18.11.6 (LTS) patches review and test

2020-01-09 Thread Kevin Traynor
On 30/12/2019 08:56, Lili Deng wrote: > Hi Kevin, > > > > I'd like to sign off validation dpdk-stable-18.11.6-rc1 against Azure gallery > images. > > Version used - > https://git.dpdk.org/dpdk-stable/snapshot/dpdk-stable-18.11.6-rc1.tar.xz

Re: [dpdk-dev] [PATCH v3 4/9] net/i40e: handle ESP tunnel

2020-01-09 Thread Zhang, Qi Z
Hi Bernard: > -Original Message- > From: Iremonger, Bernard > Sent: Thursday, January 9, 2020 8:16 PM > To: dev@dpdk.org; Xing, Beilei ; Zhang, Qi Z > ; Doherty, Declan > Cc: Ananyev, Konstantin ; Byrne, Stephen1 > ; Zhang, Helin ; > Iremonger, Bernard > Subject: [PATCH v3 4/9] net/i40e:

Re: [dpdk-dev] [PATCH 1/2] build: fix libm detection in meson

2020-01-09 Thread David Marchand
On Thu, Jan 9, 2020 at 2:09 PM Bruce Richardson wrote: > > On Thu, Jan 09, 2020 at 01:59:15PM +0100, David Marchand wrote: > > Using version 0.47.1, meson is unable to find the math library in Travis > > for the 32bits job. > > Quite surprisingly, this problem is not seen with the 64bits jobs. > >

Re: [dpdk-dev] [PATCH v3 6/9] net/i40e: display Flow Director packet

2020-01-09 Thread Zhang, Qi Z
> -Original Message- > From: Iremonger, Bernard > Sent: Thursday, January 9, 2020 10:03 PM > To: Zhang, Qi Z ; dev@dpdk.org; Xing, Beilei > ; Doherty, Declan > Cc: Ananyev, Konstantin ; Byrne, Stephen1 > ; Zhang, Helin > Subject: RE: [PATCH v3 6/9] net/i40e: display Flow Director pack

Re: [dpdk-dev] [dpdk-stable] [PATCH] mark experimental variables

2020-01-09 Thread Thomas Monjalon
02/12/2019 16:20, David Marchand: > So far, we did not pay attention to direct access to variables but they > are part of the API/ABI too and should be clearly identified. > > Introduce a __rte_experimental_var tag and mark existing exported > variables. > > Fixes: a4bcd61de82d ("buildtools: add

Re: [dpdk-dev] [PATCH 2/2] ci: use meson 0.47.1

2020-01-09 Thread Aaron Conole
David Marchand writes: > meson 0.53.0 has a compatibility issue [1] with the python 3.5.2 that comes > in Ubuntu 16.04. > On the other hand, the minimal version supported in dpdk is 0.47.1. > > Stick to this version to avoid getting hit by regressions in meson latest > shiny release. > > 1: https

Re: [dpdk-dev] [PATCH 1/2] build: fix libm detection in meson

2020-01-09 Thread Aaron Conole
David Marchand writes: > Using version 0.47.1, meson is unable to find the math library in Travis > for the 32bits job. > Quite surprisingly, this problem is not seen with the 64bits jobs. > > Switching to 0.48.0, the problem disappears. > > But we should pass 'm' to find_library instead of 'libm

Re: [dpdk-dev] [PATCH v2 1/6] kernel/linux/kni: fix meson warning about console keyword

2020-01-09 Thread Aaron Conole
Bruce Richardson writes: > Since kni no longer includes the ethtool code and so is faster to build, we > no longer need the console parameter to have incremental screen updates as > it builds. Therefore, we drop the keyword which removes the warning. > > Fixes: b78f32cff94d ("kni: support meson b

Re: [dpdk-dev] 18.11.6 (LTS) patches review and test

2020-01-09 Thread Kevin Traynor
On 09/01/2020 08:30, Julien Meunier wrote: > Hi, > Hi Julien, > I launched UT on my target which has a QAT VF device, binded to igb_uio. > > + TestCase [97] : test_null_auth_only_operation failed > + TestCase [99] : test_null_cipher_auth_operation failed > > When I did some debug, I saw th

Re: [dpdk-dev] [PATCH v2 2/6] build: skip processing docs folder if docs disabled

2020-01-09 Thread Aaron Conole
Bruce Richardson writes: > While each target is set to be ignored if the docs are disabled in the > meson build, there is little reason to process the docs folder at all. > > Signed-off-by: Bruce Richardson > --- Makes sense. Acked-by: Aaron Conole

Re: [dpdk-dev] [PATCH v2 3/6] doc/api: fix warning with meson build

2020-01-09 Thread Aaron Conole
Bruce Richardson writes: > The install parameter to configure_file is new in 0.50 and generates a > warning since it is newer than our minimum version of 0.47.1. The > parameter, however, is unneeded as the documentation states: > > "When omitted it defaults to true when install_dir is set and no

Re: [dpdk-dev] [PATCH v2 4/6] doc/guides: reduce whitespace in meson build file

2020-01-09 Thread Aaron Conole
Bruce Richardson writes: > For building the guides, we can make the meson.build easier to read by > using the subdir_done function to quit early. > > Signed-off-by: Bruce Richardson > --- Nice. Acked-by: Aaron Conole

Re: [dpdk-dev] [PATCH v2 0/4] net/mlx5: remove Tx descriptor reserved field usage

2020-01-09 Thread Raslan Darawsheh
Hi, Series applied on next-net-mlx, Kindest regards, Raslan Darawsheh > -Original Message- > From: Viacheslav Ovsiienko > Sent: Thursday, January 9, 2020 12:56 PM > To: dev@dpdk.org > Cc: Matan Azrad ; Raslan Darawsheh > ; Ori Kam > Subject: [PATCH v2 0/4] net/mlx5: remove Tx descripto

Re: [dpdk-dev] [PATCH v3 4/9] net/i40e: handle ESP tunnel

2020-01-09 Thread Iremonger, Bernard
Hi Qi, > -Original Message- > From: Zhang, Qi Z > Sent: Thursday, January 9, 2020 2:09 PM > To: Iremonger, Bernard ; dev@dpdk.org; > Xing, Beilei ; Doherty, Declan > > Cc: Ananyev, Konstantin ; Byrne, Stephen1 > ; Zhang, Helin > Subject: RE: [PATCH v3 4/9] net/i40e: handle ESP tunnel >

Re: [dpdk-dev] [PATCH] mempool: fix mempool virt populate with small chunks

2020-01-09 Thread Olivier Matz
On Thu, Jan 09, 2020 at 01:52:41PM +, Burakov, Anatoly wrote: > On 09-Jan-20 1:27 PM, Olivier Matz wrote: > > To populate a mempool with a virtual area, the mempool code calls > > rte_mempool_populate_iova() for each iova-contiguous area. It happens > > (rarely) that this area is too small to s

Re: [dpdk-dev] [dpdk-stable] [PATCH] net/mlx5: fix ConnectX-4LX Tx burst routines set

2020-01-09 Thread Raslan Darawsheh
Hi, > -Original Message- > From: Slava Ovsiienko > Sent: Thursday, January 9, 2020 1:10 PM > To: Ferruh Yigit ; dev@dpdk.org > Cc: Matan Azrad ; Raslan Darawsheh > ; Ori Kam ; > sta...@dpdk.org; Thomas Monjalon > Subject: RE: [dpdk-stable] [PATCH] net/mlx5: fix ConnectX-4LX Tx burst > ro

  1   2   >