Re: [dpdk-dev] [PATCH] vhost: fix deadlock on port deletion

2020-01-15 Thread Eelco Chaudron
On 14 Jan 2020, at 19:53, Maxime Coquelin wrote: > If the vhost-user application (e.g. OVS) deletes the vhost-user > port while Qemu sends a vhost-user request, a deadlock can > happen if the request handler tries to acquire vhost-user's > global mutex, which is also locked by the vhost-user po

[dpdk-dev] [PATCH v2] pktgen: fix generating sequences with vlan header

2020-01-15 Thread Ivan Dyukov
The issue happens with following lua code: pktgen.seqTable(0, "0", seq_table); pktgen.set("all", "seqCnt", 1); pktgen.vlan("all", "on"); This code does not work because seqCnt set sequence flag on the port then vlan resets the sequence flag on the port. To solve the issue vlan should not reset EX

[dpdk-dev] [PATCH v1] pktgen: fix sequence help message

2020-01-15 Thread Ivan Dyukov
pktgen cli does not show sequence help if it's wrong or incomplete Signed-off-by: Ivan Dyukov --- app/cli-functions.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/app/cli-functions.c b/app/cli-functions.c index f104781..4e949f3 100644 --- a/app/cli-functions.c +++ b/ap

Re: [dpdk-dev] [PATCH] ethdev: fix switching domain allocation

2020-01-15 Thread Slava Ovsiienko
> -Original Message- > From: Ferruh Yigit > Sent: Tuesday, January 14, 2020 17:32 > To: Slava Ovsiienko ; dev@dpdk.org > Cc: Thomas Monjalon ; declan.dohe...@intel.com; > sta...@dpdk.org > Subject: Re: [PATCH] ethdev: fix switching domain allocation > > On 12/19/2019 12:47 PM, Viacheslav

Re: [dpdk-dev] [PATCH v4 0/6] meson build improvements

2020-01-15 Thread David Marchand
On Tue, Jan 14, 2020 at 6:36 PM Bruce Richardson wrote: > > On Tue, Jan 14, 2020 at 04:35:09PM +, Luca Boccassi wrote: > > On Tue, 2020-01-14 at 16:19 +, Bruce Richardson wrote: > > > On Tue, Jan 14, 2020 at 05:00:17PM +0100, David Marchand wrote: > > > > On Fri, Jan 10, 2020 at 10:52 PM B

Re: [dpdk-dev] [PATCH v5 01/14] app/testpmd: parse flow command line for ESP

2020-01-15 Thread Iremonger, Bernard
Hi Ferruh, > -Original Message- > From: Yigit, Ferruh > Sent: Tuesday, January 14, 2020 7:04 PM > To: Iremonger, Bernard ; dev@dpdk.org; > Xing, Beilei ; Zhang, Qi Z ; > Doherty, Declan > Cc: Ananyev, Konstantin ; Byrne, Stephen1 > ; Zhang, Helin > Subject: Re: [dpdk-dev] [PATCH v5 0

Re: [dpdk-dev] [PATCH v5 12/14] librte_ethdev: add ESP and AH flow types to RSS

2020-01-15 Thread Andrew Rybchenko
On 1/14/20 9:45 PM, Ferruh Yigit wrote: > On 1/14/2020 1:55 PM, Bernard Iremonger wrote: >> Add macros for the following protocols in the DDP esp-ah profile: >> ESP >> AH >> >> Add the following RSS macro for IPsec: >> ETH_RSS_IPSEC >> >> Signed-off-by: Bernard Iremonger > > +Ori and other ethdev

Re: [dpdk-dev] [PATCH v5 11/14] net/i40e: display Flow Director packet

2020-01-15 Thread Iremonger, Bernard
Hi Ferruh, > -Original Message- > From: Yigit, Ferruh > Sent: Tuesday, January 14, 2020 6:53 PM > To: Iremonger, Bernard ; dev@dpdk.org; > Xing, Beilei ; Zhang, Qi Z ; > Doherty, Declan > Cc: Ananyev, Konstantin ; Byrne, Stephen1 > ; Zhang, Helin > Subject: Re: [dpdk-dev] [PATCH v5 11/1

Re: [dpdk-dev] [PATCH v5 11/14] net/i40e: display Flow Director packet

2020-01-15 Thread Iremonger, Bernard
Hi Qi, > > Subject: [PATCH v5 11/14] net/i40e: display Flow Director packet > > > > include rte_config.h in i40e_fdir.c > > In debug mode call rte_hexdump in i40e_flow_fdir_construct_pkt() and > > in > > i40e_fdir_construct_pkt() > > > > Signed-off-by: Bernard Iremonger > > --- > > drivers/net

Re: [dpdk-dev] [PATCH v5 12/14] librte_ethdev: add ESP and AH flow types to RSS

2020-01-15 Thread Iremonger, Bernard
Hi Qi, > > Subject: [PATCH v5 12/14] librte_ethdev: add ESP and AH flow types to > > RSS > > > > Add macros for the following protocols in the DDP esp-ah profile: > > ESP > > AH > > > > Add the following RSS macro for IPsec: > > ETH_RSS_IPSEC > > > > Signed-off-by: Bernard Iremonger > > --- > >

Re: [dpdk-dev] [PATCH] net/mlx5: fix doorbell register offset type

2020-01-15 Thread Raslan Darawsheh
Hi, > -Original Message- > From: Viacheslav Ovsiienko > Sent: Monday, January 13, 2020 4:23 PM > To: dev@dpdk.org > Cc: Matan Azrad ; Raslan Darawsheh > ; Ori Kam ; Shahaf Shuler > ; sta...@dpdk.org > Subject: [PATCH] net/mlx5: fix doorbell register offset type > > The doorbell register

[dpdk-dev] [PATCH v4] net/i40e: add PF MDD event handler

2020-01-15 Thread taox . zhu
From: Zhu Tao add warning and counter to handle the maliciouse driver detection event. update doc/guides/nics/i40e.rst update doc/guides/rel_notes/release_20_02.rst Signed-off-by: Zhu Tao --- doc/guides/nics/i40e.rst | 1 + doc/guides/rel_notes/release_20_02.rst | 4 +- drivers

Re: [dpdk-dev] [RFC PATCH 0/3] introduce IF proxy library

2020-01-15 Thread Bruce Richardson
On Tue, Jan 14, 2020 at 06:38:37PM +0100, Andrzej Ostruszka wrote: > On 1/14/20 4:16 PM, Morten Brørup wrote: > > Andrzej, > > Hello Morten > > > Basically you are adding a very small subset of the Linux IP stack> to > > interface with DPDK applications via callbacks. > > Yes, at the moment thi

Re: [dpdk-dev] [PATCH] net/ixgbe: fix build for gcc 4.8.5

2020-01-15 Thread Ye Xiaolong
On 01/14, Ferruh Yigit wrote: >Build error: > In function ‘ixgbe_recv_pkts_lro_bulk_alloc’: >../drivers/net/ixgbe/ixgbe_rxtx.c:2209:24: > error: ‘next_sc_entry’ may be used uninitialized in this function > [-Werror=maybe-uninitialized] >next_sc_entry->fbuf = first_seg; >

Re: [dpdk-dev] [PATCH] ethdev: fix secondary process change share memory

2020-01-15 Thread Burakov, Anatoly
On 09-Jan-20 2:35 AM, Fang TongHao wrote: Hi all,I am from Sangfor Tech.I found a bug when using DPDK in multiprocess scenario.The secondary process enters "rte_eth_dev_pci_copy_info" function when initializing.Then it sets the value of struct "rte_eth_dev_data.dev_flags" to zero, but this struct

Re: [dpdk-dev] [PATCH v5 12/14] librte_ethdev: add ESP and AH flow types to RSS

2020-01-15 Thread Ferruh Yigit
On 1/15/2020 9:13 AM, Andrew Rybchenko wrote: > On 1/14/20 9:45 PM, Ferruh Yigit wrote: >> On 1/14/2020 1:55 PM, Bernard Iremonger wrote: >>> Add macros for the following protocols in the DDP esp-ah profile: >>> ESP >>> AH >>> >>> Add the following RSS macro for IPsec: >>> ETH_RSS_IPSEC >>> >>> Sig

Re: [dpdk-dev] [PATCH v5] net/virtio-user: fix packed ring server mode

2020-01-15 Thread Maxime Coquelin
On 1/15/20 7:13 AM, Xuan Ding wrote: > This patch fixes the situation where data path does not work properly when > vhost reconnects to virtio in server mode with packed ring. > > Currently, virtio and vhost share memory of vring. For split ring, vhost > can read the status of descriptors direc

[dpdk-dev] [PATCH v2] net/ixgbe: fix blocking system events

2020-01-15 Thread taox . zhu
From: Zhu Tao IXGBE link status task use rte alarm thread in old implementation. Sometime ixgbe link status task takes up to 9 seconds. This will severely affect the rte-alarm-thread-dependent a task in the system, like interrupt or hotplug event. So replace with a independent thread which has th

Re: [dpdk-dev] [PATCH v3 0/4] Intel iavf and ice PMDs clean up

2020-01-15 Thread Zhang, Qi Z
> -Original Message- > From: Wang, Haiyue > Sent: Wednesday, January 15, 2020 8:50 AM > To: dev@dpdk.org; Ye, Xiaolong ; Zhang, Qi Z > ; Yang, Qiming > Cc: Wang, Haiyue > Subject: [PATCH v3 0/4] Intel iavf and ice PMDs clean up > > a. Remove the unused definitions in osdep.h. > > b.

Re: [dpdk-dev] [PATCH v5 12/14] librte_ethdev: add ESP and AH flow types to RSS

2020-01-15 Thread Andrew Rybchenko
On 1/15/20 1:44 PM, Ferruh Yigit wrote: > On 1/15/2020 9:13 AM, Andrew Rybchenko wrote: >> On 1/14/20 9:45 PM, Ferruh Yigit wrote: >>> On 1/14/2020 1:55 PM, Bernard Iremonger wrote: Add macros for the following protocols in the DDP esp-ah profile: ESP AH Add the following R

Re: [dpdk-dev] [EXT] Re: [PATCH] net/bnx2x: add support for secondary process

2020-01-15 Thread Kevin Traynor
On 14/01/2020 19:51, Rasesh Mody wrote: > Hi Kevin, > >> From: Kevin Traynor >> Sent: Tuesday, January 14, 2020 10:52 AM >> >> On 14/01/2020 04:51, Jerin Jacob wrote: >>> On Sat, Dec 21, 2019 at 7:12 AM Rasesh Mody >> wrote: Skip the device re-initialization for secondary process.

Re: [dpdk-dev] [PATCH v5 11/14] net/i40e: display Flow Director packet

2020-01-15 Thread Ferruh Yigit
On 1/15/2020 9:18 AM, Iremonger, Bernard wrote: > Hi Ferruh, > >> -Original Message- >> From: Yigit, Ferruh >> Sent: Tuesday, January 14, 2020 6:53 PM >> To: Iremonger, Bernard ; dev@dpdk.org; >> Xing, Beilei ; Zhang, Qi Z ; >> Doherty, Declan >> Cc: Ananyev, Konstantin ; Byrne, Stephen1

Re: [dpdk-dev] [PATCH 1/2] test/eventdev: fix unintended vdev creation

2020-01-15 Thread Jerin Jacob
On Mon, Jan 6, 2020 at 1:12 PM wrote: > > From: Pavan Nikhilesh > > Virtual eventdevice should only be created when there is no existing > device with the same name. > > Fixes: e0f4a0ed4237 ("test: skip tests when missing requirements") > Cc: sta...@dpdk.org > > Signed-off-by: Pavan Nikhilesh A

Re: [dpdk-dev] [PATCH v5] net/virtio-user: fix packed ring server mode

2020-01-15 Thread Maxime Coquelin
On 1/15/20 7:13 AM, Xuan Ding wrote: > This patch fixes the situation where data path does not work properly when > vhost reconnects to virtio in server mode with packed ring. > > Currently, virtio and vhost share memory of vring. For split ring, vhost > can read the status of descriptors direc

Re: [dpdk-dev] [PATCH v3] net/virtio-user: fix return value of tap offload sets not checked

2020-01-15 Thread Maxime Coquelin
On 1/13/20 8:40 AM, Yunjian Wang wrote: > The function vhost_kernel_tap_set_offload() could return errors, > the return value need to be checked. And there is no need to fail > when error is -ENOTSUP. > > Fixes: 1db4d2330bc8 ("net/virtio-user: check negotiated features before set") > Cc: sta...

Re: [dpdk-dev] [PATCH] vhost: fix deadlock on port deletion

2020-01-15 Thread Maxime Coquelin
On 1/14/20 7:53 PM, Maxime Coquelin wrote: > If the vhost-user application (e.g. OVS) deletes the vhost-user > port while Qemu sends a vhost-user request, a deadlock can > happen if the request handler tries to acquire vhost-user's > global mutex, which is also locked by the vhost-user port > de

Re: [dpdk-dev] [PATCH v4] net/virtio: packed ring notification data feature support

2020-01-15 Thread Maxime Coquelin
On 1/13/20 4:31 AM, Cheng Jiang wrote: > This patch supports the feature that the driver passes extra data > (besides identifying the virtqueue) in its device notifications, > expanding the notifications to include the avail index and avail > wrap counter. > > Signed-off-by: Cheng Jiang > ---

Re: [dpdk-dev] [PATCH 20.02 v2] net/virtio-user: do not close tap when disabling queue pairs

2020-01-15 Thread Maxime Coquelin
On 11/25/19 9:14 AM, Tiwei Bie wrote: > Do not close the tap fds when disabling queue pairs, instead, > we just need to unbind the backend. Otherwise, tap port can be > destroyed unexpectedly. > > Fixes: e3b434818bbb ("net/virtio-user: support kernel vhost") > Cc: sta...@dpdk.org > > Reported-

Re: [dpdk-dev] [PATCH v5] vhost: add config change slave msg support

2020-01-15 Thread Maxime Coquelin
On 12/20/19 9:22 AM, Li Feng wrote: > This msg is used to notify qemu that should get the config of backend. > > For example, vhost-user-blk uses this msg to notify guest os the > capacity of backend has changed. > > The need_reply flag is not mandatory because it will block the sender > threa

Re: [dpdk-dev] [RFC PATCH 0/3] introduce IF proxy library

2020-01-15 Thread Jerin Jacob
On Wed, Jan 15, 2020 at 3:45 PM Bruce Richardson wrote: > > On Tue, Jan 14, 2020 at 06:38:37PM +0100, Andrzej Ostruszka wrote: > > On 1/14/20 4:16 PM, Morten Brřrup wrote: > > > Andrzej, > > > > Hello Morten > > > > > Basically you are adding a very small subset of the Linux IP stack> to > > > in

Re: [dpdk-dev] [PATCH] event/octeontx2: fix device name in device info

2020-01-15 Thread Jerin Jacob
On Mon, Jan 6, 2020 at 1:13 PM wrote: > > From: Pavan Nikhilesh > > Fix imcorrect device name being used in device info. > > Fixes: bebc3dbcf4a6 ("event/octeontx2: add device capabilities function") > Cc: sta...@dpdk.org > > Signed-off-by: Pavan Nikhilesh Applied to dpdk-next-eventdev/master.

Re: [dpdk-dev] [PATCH] add ABI checks

2020-01-15 Thread Neil Horman
On Wed, Jan 15, 2020 at 12:19:30AM +0100, Thomas Monjalon wrote: > 20/12/2019 17:20, Kinsella, Ray: > > From: Richardson, Bruce > > > From: David Marchand > > > > +Checking ABI compatibility > > > > +-- > > > > + > > > > +The first thing is to build reference binaries for

Re: [dpdk-dev] [PATCH] event/octeontx2: relax memory requirement for event timers

2020-01-15 Thread Jerin Jacob
On Tue, Jan 7, 2020 at 6:47 PM wrote: > > From: Pavan Nikhilesh > > Relax memory requirement for event timers when internal mempool used is > octeontx2 mempool. > Add debug log to print the memory used. > > Signed-off-by: Pavan Nikhilesh Applied to dpdk-next-eventdev/master. Thanks. > --- > d

[dpdk-dev] [pull-request] next-eventdev 20.02 RC1

2020-01-15 Thread Jerin Jacob Kollanukkaran
Following items moved to RC2: a) Eventdev l3fwd integration http://patches.dpdk.org/patch/64446/ Status: - Addressed the review comments from NXP - Got the Acked-by from NXP after testing on their HW. - Addressed the first set of review comments from Konstantin - Pushing to RC2 to enable to more

Re: [dpdk-dev] [PATCH v5 12/14] librte_ethdev: add ESP and AH flow types to RSS

2020-01-15 Thread Ferruh Yigit
On 1/15/2020 10:55 AM, Andrew Rybchenko wrote: > On 1/15/20 1:44 PM, Ferruh Yigit wrote: >> On 1/15/2020 9:13 AM, Andrew Rybchenko wrote: >>> On 1/14/20 9:45 PM, Ferruh Yigit wrote: On 1/14/2020 1:55 PM, Bernard Iremonger wrote: > Add macros for the following protocols in the DDP esp-ah pr

Re: [dpdk-dev] [RFC PATCH 0/3] introduce IF proxy library

2020-01-15 Thread Morten Brørup
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Bruce Richardson > Sent: Wednesday, January 15, 2020 11:16 AM > > On Tue, Jan 14, 2020 at 06:38:37PM +0100, Andrzej Ostruszka wrote: > > On 1/14/20 4:16 PM, Morten Brørup wrote: > > > Andrzej, > > > > Hello Morten

Re: [dpdk-dev] [PATCH] add ABI checks

2020-01-15 Thread Thomas Monjalon
15/01/2020 12:33, Neil Horman: > On Wed, Jan 15, 2020 at 12:19:30AM +0100, Thomas Monjalon wrote: > > 20/12/2019 17:20, Kinsella, Ray: > > > From: Richardson, Bruce > > > > From: David Marchand > > > > > +Checking ABI compatibility > > > > > +-- > > > > > + > > > > > +The

Re: [dpdk-dev] [PATCH] ethdev: fix switching domain allocation

2020-01-15 Thread Ferruh Yigit
On 1/15/2020 8:50 AM, Slava Ovsiienko wrote: >> -Original Message- >> From: Ferruh Yigit >> Sent: Tuesday, January 14, 2020 17:32 >> To: Slava Ovsiienko ; dev@dpdk.org >> Cc: Thomas Monjalon ; declan.dohe...@intel.com; >> sta...@dpdk.org >> Subject: Re: [PATCH] ethdev: fix switching domain

[dpdk-dev] [PATCH v2 2/4] crypto/octeontx: add ECDSA support

2020-01-15 Thread Anoob Joseph
From: Sunila Sahu Adding support for ECDSA operations in crypto_octeontx PMD. Signed-off-by: Anoob Joseph Signed-off-by: Ayuj Verma Signed-off-by: Sunila Sahu --- doc/guides/cryptodevs/features/octeontx.ini|8 +- drivers/common/cpt/Makefile|1 + driver

[dpdk-dev] [PATCH v2 3/4] crypto/octeontx2: add ECDSA support

2020-01-15 Thread Anoob Joseph
From: Sunila Sahu Adding support for ECDSA operations in crypto_octeontx2 PMD. Signed-off-by: Anoob Joseph Signed-off-by: Balakrishna Bhamidipati Signed-off-by: Sunila Sahu --- doc/guides/cryptodevs/features/octeontx2.ini | 8 +++-- .../crypto/octeontx2/otx2_cryptodev_capabilities.c |

[dpdk-dev] [PATCH v2 0/4] add ECDSA support

2020-01-15 Thread Anoob Joseph
This series adds support for ECDSA asymmetric operations. Library changes and PMD changes for crypto_octeontx & crypto_octoentx2 is added. The final patch adds the required test vectors and verification routines. v2: * Changed all NIST references to use SECP. * Minor updates to documentation/comme

[dpdk-dev] [PATCH v2 1/4] cryptodev: support ECDSA

2020-01-15 Thread Anoob Joseph
From: Ayuj Verma Asymmetric crypto library is extended to add ECDSA. Elliptic curve xform and ECDSA op params are introduced. Signed-off-by: Anoob Joseph Signed-off-by: Ayuj Verma Signed-off-by: Sunila Sahu --- doc/guides/cryptodevs/features/default.ini | 11 ++-- doc/guides/rel_notes/releas

[dpdk-dev] [PATCH v2 4/4] app/test: add ECDSA sign/verify tests

2020-01-15 Thread Anoob Joseph
From: Ayuj Verma This patch adds ECDSA sign and verify test routine and test vectors. Signed-off-by: Anoob Joseph Signed-off-by: Ayuj Verma Signed-off-by: Sunila Sahu --- app/test/test_cryptodev_asym.c | 219 +++- app/test/test_cryptodev_asym_util.h | 11 + ap

Re: [dpdk-dev] [EXT] Re: [PATCH] net/bnx2x: add support for secondary process

2020-01-15 Thread Ferruh Yigit
On 1/15/2020 10:58 AM, Kevin Traynor wrote: > On 14/01/2020 19:51, Rasesh Mody wrote: >> Hi Kevin, >> >>> From: Kevin Traynor >>> Sent: Tuesday, January 14, 2020 10:52 AM >>> >>> On 14/01/2020 04:51, Jerin Jacob wrote: On Sat, Dec 21, 2019 at 7:12 AM Rasesh Mody >>> wrote: > > Skip t

Re: [dpdk-dev] [RFC 2/4] app/testpmd: new flow dump CLI

2020-01-15 Thread Jack Min
On Tue, 20-01-14, 19:30, Jerin Jacob wrote: > On Tue, Jan 14, 2020 at 3:45 PM Jack Min wrote: > > > > On Tue, 20-01-14, 10:01, Jerin Jacob wrote: > > > On Tue, Jan 14, 2020 at 9:15 AM Xiaoyu Min wrote: > > > > > > > > From: Xueming Li > > > > > > > > New flow dump CLI to dump MLX5 PMD specific f

Re: [dpdk-dev] [PATCH v3 1/4] mbuf: detach mbuf with pinned external buffer

2020-01-15 Thread Slava Ovsiienko
> -Original Message- > From: Olivier Matz > Sent: Tuesday, January 14, 2020 17:27 > To: Slava Ovsiienko > Cc: dev@dpdk.org; Matan Azrad ; Raslan Darawsheh > ; Ori Kam ; Shahaf Shuler > ; step...@networkplumber.org > Subject: Re: [PATCH v3 1/4] mbuf: detach mbuf with pinned external buffer

[dpdk-dev] [PATCH v2 0/4] add ECPM support

2020-01-15 Thread Anoob Joseph
This series adds support for ECPM (Elliptic Curve Point Multiplication) asymmetric operations. Library changes and PMD changes for crypto_octeontx & crypto_octeontx2 is added. The final patch adds the required test vectors and verification routines. v2: * Made all references to point multiplicatio

[dpdk-dev] [PATCH v2 2/4] crypto/octeontx: add ECPM support

2020-01-15 Thread Anoob Joseph
From: Sunila Sahu Add support for asymmetric opertion EC Point Multiplication, in crypto_octeontx PMD. Signed-off-by: Anoob Joseph Signed-off-by: Balakrishna Bhamidipati Signed-off-by: Sunila Sahu --- doc/guides/cryptodevs/features/octeontx.ini| 1 + drivers/common/cpt/cpt_mcode_def

[dpdk-dev] [PATCH v2 1/4] cryptodev: support ECPM

2020-01-15 Thread Anoob Joseph
From: Balakrishna Bhamidipati Asymmetric crypto library is extended to add ECPM (Elliptic Curve Point Multiplication). The required xform type and op parameters are introduced. Signed-off-by: Anoob Joseph Signed-off-by: Balakrishna Bhamidipati Signed-off-by: Sunila Sahu --- doc/guides/crypto

Re: [dpdk-dev] [RFC PATCH 0/3] introduce IF proxy library

2020-01-15 Thread Jerin Jacob
On Wed, Jan 15, 2020 at 5:58 PM Morten Brørup wrote: > > > -Original Message- > > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Bruce Richardson > > Sent: Wednesday, January 15, 2020 11:16 AM > > > > On Tue, Jan 14, 2020 at 06:38:37PM +0100, Andrzej Ostruszka wrote: > > > On 1/14/2

[dpdk-dev] [PATCH v2 3/4] crypto/octeontx2: add ECPM support

2020-01-15 Thread Anoob Joseph
From: Sunila Sahu Add support asymmetric operation EC Point MUltiplication, in crypto_octeontx2 PMD. Signed-off-by: Anoob Joseph Signed-off-by: Balakrishna Bhamidipati Signed-off-by: Sunila Sahu --- doc/guides/cryptodevs/features/octeontx2.ini | 1 + .../crypto/octeontx2/otx2_cryptode

[dpdk-dev] [PATCH v2 4/4] app/test: add ECPM tests

2020-01-15 Thread Anoob Joseph
From: Sunila Sahu Add test vectors and verify routines for asymmetric operation, EC Point Multiplication. Signed-off-by: Anoob Joseph Signed-off-by: Sunila Sahu --- app/test/test_cryptodev_asym.c | 176 ++ app/test/test_cryptodev_asym_util.h | 11 + app/test/

Re: [dpdk-dev] [EXT] Re: [PATCH] net/bnx2x: add support for secondary process

2020-01-15 Thread Kevin Traynor
On 15/01/2020 12:47, Ferruh Yigit wrote: > On 1/15/2020 10:58 AM, Kevin Traynor wrote: >> On 14/01/2020 19:51, Rasesh Mody wrote: >>> Hi Kevin, >>> From: Kevin Traynor Sent: Tuesday, January 14, 2020 10:52 AM On 14/01/2020 04:51, Jerin Jacob wrote: > On Sat, Dec 21, 2019 at

Re: [dpdk-dev] [PATCH] add ABI checks

2020-01-15 Thread Burakov, Anatoly
On 06-Jan-20 1:17 PM, Aaron Conole wrote: Thomas Monjalon writes: 20/12/2019 17:20, Kinsella, Ray: -Original Message- From: Richardson, Bruce Sent: Friday 20 December 2019 15:32 To: David Marchand ; dev@dpdk.org Cc: tho...@monjalon.net; Laatz, Kevin ; acon...@redhat.com; nhor...@tuxd

Re: [dpdk-dev] [EXT] Re: [PATCH] net/bnx2x: add support for secondary process

2020-01-15 Thread Ferruh Yigit
On 1/15/2020 12:57 PM, Kevin Traynor wrote: > On 15/01/2020 12:47, Ferruh Yigit wrote: >> On 1/15/2020 10:58 AM, Kevin Traynor wrote: >>> On 14/01/2020 19:51, Rasesh Mody wrote: Hi Kevin, > From: Kevin Traynor > Sent: Tuesday, January 14, 2020 10:52 AM > > On 14/01/2020 0

Re: [dpdk-dev] [PATCH 1/2] app/testpmd: add dynamic flag support

2020-01-15 Thread Ferruh Yigit
On 1/13/2020 9:29 AM, Ori Kam wrote: > DPDK now supports registration of dynamic flags (dynf) to the mbuf. > dynf can be given any name, and can be used with a supporting PMD or > supporting application. > > Due to the generic concept of the dynf, it is impossible and meaningless, > to define regi

Re: [dpdk-dev] [PATCH v2 2/2] test/crypto: add more tests for mixed encypted-digest

2020-01-15 Thread Akhil Goyal
Hi Adam, > > This patch adds unit tests for QAT PMD for mixed encrypted-digest > cases, involving SNOW3G UIA2, ZUC EIA3, AES CMAC and NULL auth > algorithms together with SNOW3G UEA2, ZUC EEA3, AES CTR and NULL > cipher algorithms in various combinations. > > Signed-off-by: Adam Dybkowski This

Re: [dpdk-dev] [PATCH 2/2] net/mlx5: add fine grain dynamic flag support

2020-01-15 Thread Ferruh Yigit
On 1/13/2020 9:29 AM, Ori Kam wrote: > The inline feature is designed to save PCI bandwidth by copying some > of the data to the wqe. This feature if enabled works for all packets. > > In some cases when using external memory, the PCI bandwidth is not > relevant since the memory can be accessed by

Re: [dpdk-dev] [EXT] Re: [PATCH] net/bnx2x: add support for secondary process

2020-01-15 Thread Kevin Traynor
On 15/01/2020 13:11, Ferruh Yigit wrote: > On 1/15/2020 12:57 PM, Kevin Traynor wrote: >> On 15/01/2020 12:47, Ferruh Yigit wrote: >>> On 1/15/2020 10:58 AM, Kevin Traynor wrote: On 14/01/2020 19:51, Rasesh Mody wrote: > Hi Kevin, > >> From: Kevin Traynor >> Sent: Tuesday, Jan

Re: [dpdk-dev] [RFC PATCH 0/3] introduce IF proxy library

2020-01-15 Thread Bruce Richardson
On Wed, Jan 15, 2020 at 01:28:46PM +0100, Morten Brørup wrote: > > -Original Message- From: dev [mailto:dev-boun...@dpdk.org] On > > Behalf Of Bruce Richardson Sent: Wednesday, January 15, 2020 11:16 AM > > > > On Tue, Jan 14, 2020 at 06:38:37PM +0100, Andrzej Ostruszka wrote: > > > On 1/1

Re: [dpdk-dev] [PATCH v5 12/14] librte_ethdev: add ESP and AH flow types to RSS

2020-01-15 Thread Iremonger, Bernard
Hi Ferruh, > Subject: Re: [dpdk-dev] [PATCH v5 12/14] librte_ethdev: add ESP and AH > flow types to RSS > > On 1/15/2020 10:55 AM, Andrew Rybchenko wrote: > > On 1/15/20 1:44 PM, Ferruh Yigit wrote: > >> On 1/15/2020 9:13 AM, Andrew Rybchenko wrote: > >>> On 1/14/20 9:45 PM, Ferruh Yigit wrote:

[dpdk-dev] [PATCH v5 1/4] common/qat: remove tail write coalescing feature

2020-01-15 Thread Arek Kusztal
From: Fiona Trahe The feature Coalescing Tail Writes on Enqueue is removed as it is not thread-safe and a dual-thread feature will be added shortly. Signed-off-by: Fiona Trahe Signed-off-by: Arek Kusztal --- drivers/common/qat/qat_qp.c | 16 +++- drivers/common/qat/qat_qp.h | 6 -

[dpdk-dev] [PATCH v5 2/4] common/qat: move max inflights param into qp

2020-01-15 Thread Arek Kusztal
From: Fiona Trahe The max_inflights parameter is moved from qat_queue to qat_qp as it's a more appropriate location. Signed-off-by: Fiona Trahe Signed-off-by: Arek Kusztal Acked-by: Fiona Trahe --- drivers/common/qat/qat_qp.c | 23 --- drivers/common/qat/qat_qp.h | 2 +-

[dpdk-dev] [PATCH v5 3/4] common/qat: add dual thread support

2020-01-15 Thread Arek Kusztal
From: Fiona Trahe Remove the limitation whereby enqueue and dequeue must be done in same thread. The inflight calculation is reworked to be thread-safe for 2 threads - note this is not general multi-thread support, i.e all enqueues to a qp must still be done in one thread and all dequeues must be

[dpdk-dev] [PATCH v5 0/4] Add dual threading in QAT PMD

2020-01-15 Thread Arek Kusztal
Remove the limitation whereby enqueue and dequeue must be done in same thread. The inflight calculation is reworked to be thread-safe for 2 threads - note this is not general multi-thread support, i.e all enqueues to a qp must still be done in one thread and all dequeues must be done in one thread,

[dpdk-dev] [PATCH v5 4/4] crypto/qat: add minimum enq threshold to qat pmd

2020-01-15 Thread Arek Kusztal
This patch adds minimum enqueue threshold to Intel QuickAssist Technology PMD. It is an optimisation, configured by a command line option, which can be used to reduce MMIO write occurrences. Signed-off-by: Fiona Trahe Signed-off-by: Arek Kusztal --- doc/guides/cryptodevs/qat.rst | 18

Re: [dpdk-dev] [PATCH v9 2/4] net/ice: cleanup Tx buffers

2020-01-15 Thread Ferruh Yigit
On 1/14/2020 12:40 PM, Ferruh Yigit wrote: > On 1/13/2020 9:57 AM, Chenxu Di wrote: >> Add support to the ice driver for the API rte_eth_tx_done_cleanup >> to force free consumed buffers on Tx ring. >> >> Signed-off-by: Chenxu Di > > <...> > >> +static int >> +ice_tx_done_cleanup_vec(struct ice_

Re: [dpdk-dev] [PATCH v5 12/14] librte_ethdev: add ESP and AH flow types to RSS

2020-01-15 Thread Ferruh Yigit
On 1/15/2020 2:11 PM, Iremonger, Bernard wrote: > Hi Ferruh, > > > >> Subject: Re: [dpdk-dev] [PATCH v5 12/14] librte_ethdev: add ESP and AH >> flow types to RSS >> >> On 1/15/2020 10:55 AM, Andrew Rybchenko wrote: >>> On 1/15/20 1:44 PM, Ferruh Yigit wrote: On 1/15/2020 9:13 AM, Andrew Ryb

Re: [dpdk-dev] [PATCH] examples/fips_validation: add AES XTS support

2020-01-15 Thread Akhil Goyal
Hi Marko, > > From: Sucharitha Sarananaga > > AES XTS support is added to fips application. Parse test-vectors > from input files, populate AES XTS tests and prepare AES XTS > operations for fips validation. > > Signed-off-by: Abed Kamaluddin > Signed-off-by: Archana Muniganti > Signed-off-b

[dpdk-dev] [PATCH v3 0/2] Handle mixed algorithms on GEN3 QAT

2020-01-15 Thread Adam Dybkowski
v2: * Added release notes update. v3: * Rebase, update release notes. Adam Dybkowski (2): crypto/qat: handle mixed hash-cipher requests on GEN3 QAT test/crypto: add more tests for mixed encypted-digest app/test/test_cryptodev.c| 400 +- app/test/test_cryptodev_mixed

[dpdk-dev] [PATCH v3 1/2] crypto/qat: handle mixed hash-cipher requests on GEN3 QAT

2020-01-15 Thread Adam Dybkowski
This patch implements handling mixed encrypted digest hash-cipher requests (e.g. SNOW3G + ZUC or ZUC + AES CTR) possible when running on GEN3 QAT. Such algorithm combinations are not supported on GEN1/GEN2 hardware. Signed-off-by: Adam Dybkowski --- doc/guides/cryptodevs/qat.rst | 2

[dpdk-dev] [PATCH v3 2/2] test/crypto: add more tests for mixed encypted-digest

2020-01-15 Thread Adam Dybkowski
This patch adds unit tests for QAT PMD for mixed encrypted-digest cases, involving SNOW3G UIA2, ZUC EIA3, AES CMAC and NULL auth algorithms together with SNOW3G UEA2, ZUC EEA3, AES CTR and NULL cipher algorithms in various combinations. Signed-off-by: Adam Dybkowski --- app/test/test_cryptodev.c

Re: [dpdk-dev] [PATCH v5 11/14] net/i40e: display Flow Director packet

2020-01-15 Thread Iremonger, Bernard
Hi Ferruh > >> Subject: Re: [dpdk-dev] [PATCH v5 11/14] net/i40e: display Flow > >> Director packet > >> > >> On 1/14/2020 1:55 PM, Bernard Iremonger wrote: > >>> include rte_config.h in i40e_fdir.c > >>> In debug mode call rte_hexdump in i40e_flow_fdir_construct_pkt() and > >>> in i40e_fdir_con

Re: [dpdk-dev] [PATCH v3 1/2] crypto/qat: handle mixed hash-cipher requests on GEN3 QAT

2020-01-15 Thread Trahe, Fiona
> -Original Message- > From: Dybkowski, AdamX > Sent: Wednesday, January 15, 2020 2:59 PM > To: dev@dpdk.org; Trahe, Fiona ; akhil.go...@nxp.com > Cc: Dybkowski, AdamX > Subject: [PATCH v3 1/2] crypto/qat: handle mixed hash-cipher requests on GEN3 > QAT > > This patch implements handl

Re: [dpdk-dev] [PATCH v3 2/2] test/crypto: add more tests for mixed encypted-digest

2020-01-15 Thread Trahe, Fiona
> -Original Message- > From: Dybkowski, AdamX > Sent: Wednesday, January 15, 2020 2:59 PM > To: dev@dpdk.org; Trahe, Fiona ; akhil.go...@nxp.com > Cc: Dybkowski, AdamX > Subject: [PATCH v3 2/2] test/crypto: add more tests for mixed encypted-digest > > This patch adds unit tests for QAT

Re: [dpdk-dev] [RFC PATCH 0/3] introduce IF proxy library

2020-01-15 Thread Morten Brørup
> -Original Message- > From: Jerin Jacob [mailto:jerinjac...@gmail.com] > Sent: Wednesday, January 15, 2020 1:57 PM > > On Wed, Jan 15, 2020 at 5:58 PM Morten Brørup > wrote: > > > > > -Original Message- > > > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Bruce > Richardson

Re: [dpdk-dev] [dpdk-stable] [PATCH v5] net/virtio-user: fix packed ring server mode

2020-01-15 Thread Ferruh Yigit
On 1/15/2020 11:16 AM, Maxime Coquelin wrote: > > > On 1/15/20 7:13 AM, Xuan Ding wrote: >> This patch fixes the situation where data path does not work properly when >> vhost reconnects to virtio in server mode with packed ring. >> >> Currently, virtio and vhost share memory of vring. For split

Re: [dpdk-dev] [PATCH v4 0/5] integrate librte_ipsec SAD into ipsec-secgw

2020-01-15 Thread Akhil Goyal
Hi Vladimir, There is more than 10% drop with this patchset on NXP hardware with both legacy mode and the ipsec lib mode. This would need some debugging. Didn't you see any drop on intel? Regards, Akhil > -Original Message- > From: Vladimir Medvedkin > Sent: Tuesday, January 14, 2020 7

Re: [dpdk-dev] [PATCH v3 0/2] Handle mixed algorithms on GEN3 QAT

2020-01-15 Thread Akhil Goyal
> v2: > * Added release notes update. > > v3: > * Rebase, update release notes. > > Adam Dybkowski (2): > crypto/qat: handle mixed hash-cipher requests on GEN3 QAT > test/crypto: add more tests for mixed encypted-digest > > app/test/test_cryptodev.c| 400 +- > app

Re: [dpdk-dev] [PATCH v5 0/4] Add dual threading in QAT PMD

2020-01-15 Thread Akhil Goyal
> > Remove the limitation whereby enqueue and dequeue must be > done in same thread. > The inflight calculation is reworked to be thread-safe for 2 > threads - note this is not general multi-thread support, i.e > all enqueues to a qp must still be done in one thread and > all dequeues must be done

Re: [dpdk-dev] [PATCH v2 0/4] add ECPM support

2020-01-15 Thread Akhil Goyal
> This series adds support for ECPM (Elliptic Curve Point Multiplication) > asymmetric operations. Library changes and PMD changes for > crypto_octeontx & crypto_octeontx2 is added. The final patch adds > the required test vectors and verification routines. > > v2: > * Made all references to poi

Re: [dpdk-dev] [PATCH v2 1/4] cryptodev: support ECPM

2020-01-15 Thread Akhil Goyal
> From: Balakrishna Bhamidipati > > Asymmetric crypto library is extended to add ECPM (Elliptic Curve Point > Multiplication). The required xform type and op parameters are > introduced. > > Signed-off-by: Anoob Joseph > Signed-off-by: Balakrishna Bhamidipati > Signed-off-by: Sunila Sahu >

Re: [dpdk-dev] [PATCH v2 0/4] add ECDSA support

2020-01-15 Thread Akhil Goyal
> This series adds support for ECDSA asymmetric operations. Library changes > and PMD changes for crypto_octeontx & crypto_octoentx2 is added. The final > patch adds the required test vectors and verification routines. > > v2: > * Changed all NIST references to use SECP. > * Minor updates to do

Re: [dpdk-dev] [PATCH v2 1/4] cryptodev: support ECDSA

2020-01-15 Thread Akhil Goyal
> From: Ayuj Verma > > Asymmetric crypto library is extended to add ECDSA. Elliptic curve > xform and ECDSA op params are introduced. > > Signed-off-by: Anoob Joseph > Signed-off-by: Ayuj Verma > Signed-off-by: Sunila Sahu > --- Acked-by: Akhil Goyal

Re: [dpdk-dev] [PATCH v3] cryptodev: add chacha20-poly1305 aead algorithm

2020-01-15 Thread Akhil Goyal
> > > > This patch adds Chacha20-Poly1305 AEAD algorithm to Cryptodev. > > > > Signed-off-by: Arek Kusztal > > Acked-by: Fiona Trahe > > Acked-by: Anoob Joseph > Acked-by: Akhil Goyal Applied to dpdk-next-crypto Thanks.

[dpdk-dev] [PATCH v6 00/13] net/i40e: ESP support

2020-01-15 Thread Bernard Iremonger
Changes in V6: - Rebase to latest master branch Fixed patch 0001-app-testpmd-parse-flow-command-line-for-ESP.patch Dropped the following v5 patch due to ABI breakage: 0012-librte_ethdev-add-ESP-and-AH-flow-types-to-RSS.patch Changes in V5: - Rebase to latest master branch U

[dpdk-dev] [PATCH v6 03/13] app/testpmd: dump Rx and Tx mbuf

2020-01-15 Thread Bernard Iremonger
add call to rte_pktmbuf_dump() in dump_pkt_burst in util.c Signed-off-by: Bernard Iremonger --- app/test-pmd/util.c | 1 + 1 file changed, 1 insertion(+) diff --git a/app/test-pmd/util.c b/app/test-pmd/util.c index b514be5..bf03873 100644 --- a/app/test-pmd/util.c +++ b/app/test-pmd/util.c @@ -

[dpdk-dev] [PATCH v6 02/13] app/testpmd: improve debug

2020-01-15 Thread Bernard Iremonger
print function name in port_flow_complain() Signed-off-by: Bernard Iremonger --- app/test-pmd/config.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app/test-pmd/config.c b/app/test-pmd/config.c index d599682..2753ec5 100644 --- a/app/test-pmd/config.c +++ b/app/test-pmd/co

[dpdk-dev] [PATCH v6 01/13] app/testpmd: parse flow command line for ESP

2020-01-15 Thread Bernard Iremonger
add ITEM_ESP add ITEM_ESP_SPI Signed-off-by: Bernard Iremonger Acked-by: Ori Kam --- app/test-pmd/cmdline_flow.c | 34 +++--- 1 file changed, 31 insertions(+), 3 deletions(-) diff --git a/app/test-pmd/cmdline_flow.c b/app/test-pmd/cmdline_flow.c index 99dade7..9c6ed

[dpdk-dev] [PATCH v6 04/13] net/i40e: improve RSS debug

2020-01-15 Thread Bernard Iremonger
improve RSS debug in i40e_ethdev.c Signed-off-by: Bernard Iremonger Acked-by: Qi Zhang --- drivers/net/i40e/i40e_ethdev.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/drivers/net/i40e/i40e_ethdev.c b/drivers/net/i40e/i40e_ethdev.c index 5999c96..5f1cf8a 100644 ---

[dpdk-dev] [PATCH v6 05/13] net/i40e: handle ESP tunnel

2020-01-15 Thread Bernard Iremonger
handle ESP tunnel in rte_pmd_i40e.c Signed-off-by: Bernard Iremonger --- drivers/net/i40e/rte_pmd_i40e.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/net/i40e/rte_pmd_i40e.c b/drivers/net/i40e/rte_pmd_i40e.c index fdcb1a4..b987346 100644 --- a/drivers/net/i40e/rt

[dpdk-dev] [PATCH v6 06/13] net/i40e: support ipsec-ah profile

2020-01-15 Thread Bernard Iremonger
Add flow structures for the following patterns in i40e_ethdev files: eth/ipv4/esp eth/ipv6/esp eth/ipv4/udp/esp eth/ipv6/esp/udp add oip_type in filter add is_udp in filter use tenant_id in filter for spi Signed-off-by: Bernard Iremonger --- drivers/net/i40e/i40e_ethdev.h | 38 +

[dpdk-dev] [PATCH v6 09/13] net/i40e: support ESP in Flow Director

2020-01-15 Thread Bernard Iremonger
add fill_ip6_head() hardcode udp destination port to 4500 handle ESP and AH pctypes in ESP-AH profile Signed-off-by: Bernard Iremonger --- drivers/net/i40e/i40e_fdir.c | 126 --- 1 file changed, 118 insertions(+), 8 deletions(-) diff --git a/drivers/net/i

[dpdk-dev] [PATCH v6 07/13] net/i40e: support ESP in customized code

2020-01-15 Thread Bernard Iremonger
update customized code for ESP Signed-off-by: Bernard Iremonger --- drivers/net/i40e/i40e_ethdev.c | 44 +- 1 file changed, 43 insertions(+), 1 deletion(-) diff --git a/drivers/net/i40e/i40e_ethdev.c b/drivers/net/i40e/i40e_ethdev.c index 5f1cf8a..a462eba

[dpdk-dev] [PATCH v6 08/13] net/i40e: support ESP flows

2020-01-15 Thread Bernard Iremonger
add eth/ipv4/esp and eth/ipv6/esp patterns add eth/ipv4/udp/esp and eth/ipv6/esp/udp patterns update i40e_flow_parse_fdir_filter() add i40e_flow_set_filter_spi() Signed-off-by: Bernard Iremonger --- drivers/net/i40e/i40e_flow.c | 135 ++- 1 file changed, 1

[dpdk-dev] [PATCH v6 10/13] config: add debug to I40E Flow Director

2020-01-15 Thread Bernard Iremonger
add CONFIG_RTE_LIBRTE_I40E_DEBUG_FD to config/common_base file Signed-off-by: Bernard Iremonger --- config/common_base | 1 + 1 file changed, 1 insertion(+) diff --git a/config/common_base b/config/common_base index 7dec7ed..7a76c26 100644 --- a/config/common_base +++ b/config/common_base @@ -3

Re: [dpdk-dev] [PATCH v2 1/1] test/crypto: fix missing operation status check

2020-01-15 Thread Akhil Goyal
> > > > Fixes: c0f87eb5252b ("cryptodev: change burst API to be crypto op oriented") > > Fixes: 77a217a19bb7 ("test/crypto: add AES-CCM tests") > > > > Signed-off-by: Adam Dybkowski > > --- > > app/test/test_cryptodev.c | 96 +-- > > 1 file changed, 52 insertio

[dpdk-dev] [PATCH v6 12/13] doc: release note for ESP

2020-01-15 Thread Bernard Iremonger
Release note for ESP support on the i40e PMD. Release note for ESP support on testpmd. Signed-off-by: Bernard Iremonger --- doc/guides/rel_notes/release_20_02.rst | 9 + 1 file changed, 9 insertions(+) diff --git a/doc/guides/rel_notes/release_20_02.rst b/doc/guides/rel_notes/release_2

[dpdk-dev] [PATCH v6 11/13] net/i40e: display Flow Director packet

2020-01-15 Thread Bernard Iremonger
include rte_config.h in i40e_fdir.c In debug mode call rte_hexdump in i40e_flow_fdir_construct_pkt() and in i40e_fdir_construct_pkt() Signed-off-by: Bernard Iremonger Acked-by: Qi Zhang --- drivers/net/i40e/i40e_fdir.c | 12 ++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --

Re: [dpdk-dev] [PATCH v2] examples/ipsec-secgw: return on encountering algo as NULL

2020-01-15 Thread Akhil Goyal
> Hi, > > > > if algo is NULL set the status to error and return. This change > > prevent crashing of ipsec-secgw application when a specific > > cipher/auth/aead algo are not supported by application. > > It seems you forgot 'fix' in the header 😊 > examples/ipsec-secgw: fix ... Fixed title. >

  1   2   >