[dpdk-dev] [PATCH] net/ice: fix flow fdir/switch memory leak.

2020-01-16 Thread taox . zhu
From: Tao Zhu 1. Fix ice fdir and hash flow memory leak. 2. Fix the ice definition of LIST_FOR_EACH_ENTRY_SAFE not save tmp which cause list deletion incompletely. Fixes: 5f0978e9622 ("net/ice/base: add OS specific implementation") Fixes: f5cafa961fa ("net/ice: add flow director create and d

Re: [dpdk-dev] [PATCH 1/2] app/testpmd: add dynamic flag support

2020-01-16 Thread Ori Kam
Hi Ferruh, > -Original Message- > From: Ferruh Yigit > Sent: Wednesday, January 15, 2020 3:32 PM > To: Ori Kam ; Wenzhuo Lu ; > Jingjing Wu ; Bernard Iremonger > ; John McNamara > ; Marko Kovacevic > > Cc: dev@dpdk.org; Slava Ovsiienko ; Matan > Azrad > Subject: Re: [PATCH 1/2] app/test

Re: [dpdk-dev] [PATCH] net/nfp: use macro PCI_PRI_FMT for PCI log format

2020-01-16 Thread Heinrich Kuhn
> Use PCI_PRI_FMT instead of "%04d:%02d:%02d:%d" print format. > > Signed-off-by: Yunjian Wang > --- > drivers/net/nfp/nfp_net.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/net/nfp/nfp_net.c b/drivers/net/nfp/nfp_net.c > index 3aafa7f80..64d9d218d 10

Re: [dpdk-dev] [PATCH v2 0/3] Use Intel IPSec MB library in Wireless PMDs

2020-01-16 Thread De Lara Guarch, Pablo
Hi, > -Original Message- > From: Ali Alnubani > Sent: Monday, January 13, 2020 2:18 PM > To: De Lara Guarch, Pablo ; > akhil.go...@nxp.com; Doherty, Declan > Cc: dev@dpdk.org > Subject: RE: [dpdk-dev] [PATCH v2 0/3] Use Intel IPSec MB library in Wireless > PMDs > > Hi, > > > -Origi

Re: [dpdk-dev] [PATCH v9 2/4] net/ice: cleanup Tx buffers

2020-01-16 Thread Ferruh Yigit
On 1/13/2020 9:57 AM, Chenxu Di wrote: > Add support to the ice driver for the API rte_eth_tx_done_cleanup > to force free consumed buffers on Tx ring. > > Signed-off-by: Chenxu Di > --- > drivers/net/ice/ice_ethdev.c | 1 + > drivers/net/ice/ice_rxtx.c | 111

Re: [dpdk-dev] [PATCH v9 3/4] net/ixgbe: cleanup Tx buffers

2020-01-16 Thread Ferruh Yigit
On 1/13/2020 9:57 AM, Chenxu Di wrote: > Add support to the ixgbe driver for the API rte_eth_tx_done_cleanup > to force free consumed buffers on Tx ring. > > Signed-off-by: Chenxu Di <...> > @@ -253,7 +253,6 @@ struct ixgbe_txq_ops { >IXGBE_ADVTXD_DCMD_DEXT |\ >

Re: [dpdk-dev] [PATCH v2] Fixes: ethdev: secondary process change shared memory

2020-01-16 Thread Ferruh Yigit
On 1/15/2020 8:43 PM, Thomas Monjalon wrote: > 15/01/2020 19:35, Ferruh Yigit: >> On 1/15/2020 6:49 AM, 方统浩50450 wrote: >>> Hi Ferruh, thanks for your message. >>> >>> >>> We developed a ethtool-dpdk which is secondary process based dpdk 17.08 >>> version. Our device >>> support hotplug detach, bu

Re: [dpdk-dev] [PATCH v2] Fixes: ethdev: secondary process change shared memory

2020-01-16 Thread Ferruh Yigit
On 1/16/2020 7:43 AM, Andrew Rybchenko wrote: > On 1/15/20 11:43 PM, Thomas Monjalon wrote: >> 15/01/2020 19:35, Ferruh Yigit: >>> On 1/15/2020 6:49 AM, 方统浩50450 wrote: Hi Ferruh, thanks for your message. We developed a ethtool-dpdk which is secondary process based dpdk 17.08 >

Re: [dpdk-dev] [RFC PATCH 0/3] introduce IF proxy library

2020-01-16 Thread Andrzej Ostruszka
On 1/15/20 7:15 PM, Morten Brørup wrote: [...] > OK, you convinced me that a general API for interfacing to the O/S > control plane might be useful. Glad to hear that. [...] > You should consider that most DPDK APIs are not thread safe, > meaning that their internal structures cannot be manipulat

Re: [dpdk-dev] [RFC PATCH 0/3] introduce IF proxy library

2020-01-16 Thread Morten Brørup
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Jerin Jacob > Sent: Thursday, January 16, 2020 8:15 AM > > On Wed, Jan 15, 2020 at 11:45 PM Morten Brørup > wrote: > > > > > > IMO, in order to have effective use of data plane, the control > > > > > plane has to

[dpdk-dev] [PATCH 2/4] net/hns3: remove unnecessary input parameter valid judgement

2020-01-16 Thread Wei Hu (Xavier)
From: Lijun Ou Since the input parameter named dev has been guaranteed not to be NULL in the rte layer of DPDK framework, it doesn't need to check dev whether is null in the 'filter_ctrl' ops implementation function named hns3_dev_filter_ctrl. Signed-off-by: Lijun Ou Signed-off-by: Wei Hu (Xavi

[dpdk-dev] [PATCH 0/4] improvement and cleanup for hns3 PMD driver

2020-01-16 Thread Wei Hu (Xavier)
This series are improvement and cleanup for hns3 PMD driver. Chengwen Feng (1): net/hns3: replace memory barrier with data dependency order Lijun Ou (2): net/hns3: remove unnecessary input parameter valid judgement net/hns3: remove unnecessary branch Wei Hu (Xavier) (1): doc: update rele

[dpdk-dev] [PATCH 1/4] net/hns3: replace memory barrier with data dependency order

2020-01-16 Thread Wei Hu (Xavier)
From: Chengwen Feng This patch optimizes the Rx performance by using data dependency ordering to instead of memory barrier which is rte_cio_rmb in the '.rx_pkt_burst' ops implementation function named hns3_recv_pkts. Signed-off-by: Chengwen Feng Signed-off-by: Wei Hu (Xavier) --- drivers/net/

[dpdk-dev] [PATCH 3/4] net/hns3: remove unnecessary branch

2020-01-16 Thread Wei Hu (Xavier)
From: Lijun Ou Because the rte layer of DPDK framework has already processed the case when the idx is zero before calling the '.mac_addr_remove' ops function, the input parameter named idx can not be zero in the '.mac_addr_remove' function. This patch removes unnecessary branch process to check w

[dpdk-dev] [PATCH 4/4] doc: update release notes for hns3

2020-01-16 Thread Wei Hu (Xavier)
From: "Wei Hu (Xavier)" Update release doc briefly describing updates to hns3 PMD for 20.02 release. The support for these was added include the following commits: 1) commit 6e79a0ad1236 ("net/hns3: support Rx interrupt") 2) commit 34c5c2d5abb8 ("net/hns3: support setting VF MAC address by PF

Re: [dpdk-dev] [RFC PATCH 0/3] introduce IF proxy library

2020-01-16 Thread Morten Brørup
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Andrzej Ostruszka > Sent: Thursday, January 16, 2020 10:10 AM > > On 1/15/20 7:15 PM, Morten Brørup wrote: > [...] > > OK, you convinced me that a general API for interfacing to the O/S > > control plane might be u

Re: [dpdk-dev] [PATCH v3 2/6] crypto/aesni_gcm: cpu crypto support

2020-01-16 Thread Zhang, Roy Fan
> -Original Message- > From: Smoczynski, MarcinX > Sent: Wednesday, January 15, 2020 6:28 PM > To: akhil.go...@nxp.com; Ananyev, Konstantin > ; Zhang, Roy Fan > ; Doherty, Declan ; > Nicolau, Radu > Cc: dev@dpdk.org; Smoczynski, MarcinX > Subject: [PATCH v3 2/6] crypto/aesni_gcm: cpu cry

Re: [dpdk-dev] [PATCH v3 3/6] security: add cpu crypto action type

2020-01-16 Thread Zhang, Roy Fan
> -Original Message- > From: Smoczynski, MarcinX > Sent: Wednesday, January 15, 2020 6:28 PM > To: akhil.go...@nxp.com; Ananyev, Konstantin > ; Zhang, Roy Fan > ; Doherty, Declan ; > Nicolau, Radu > Cc: dev@dpdk.org; Smoczynski, MarcinX > Subject: [PATCH v3 3/6] security: add cpu crypto

Re: [dpdk-dev] [PATCH v3 1/6] cryptodev: introduce cpu crypto support API

2020-01-16 Thread Zhang, Roy Fan
Hi Marcin, > -Original Message- > From: Smoczynski, MarcinX > Sent: Wednesday, January 15, 2020 6:28 PM > To: akhil.go...@nxp.com; Ananyev, Konstantin > ; Zhang, Roy Fan > ; Doherty, Declan ; > Nicolau, Radu > Cc: dev@dpdk.org; Smoczynski, MarcinX > Subject: [PATCH v3 1/6] cryptodev: in

[dpdk-dev] [PATCH 0/5] ethdev: add API to dump device internal flow info

2020-01-16 Thread Xiaoyu Min
This serial patchs is based on RFC [1] and the comments on it. A new rte flow API is added to dump device internal representation information for the offloaded rte flows. This is very helpful for user and developer to debug flow offloading stuff, i.e, to check whether PMD offloads the rte flow in

[dpdk-dev] [PATCH 2/5] net/mlx5: support flow dump API

2020-01-16 Thread Xiaoyu Min
Dump fdb/nic_rx/nic_tx raw flow data into specified file. Signed-off-by: Xueming Li Signed-off-by: Xiaoyu Min --- drivers/net/mlx5/Makefile | 7 ++- drivers/net/mlx5/meson.build | 2 ++ drivers/net/mlx5/mlx5.h | 4 drivers/net/mlx5/mlx5_devx_cmds.c | 35 ++

[dpdk-dev] [PATCH 1/5] ethdev: add API to dump device internal flow info

2020-01-16 Thread Xiaoyu Min
Introduce an API which dump the device's internal representation information of rte flows in hardware. Signed-off-by: Xiaoyu Min --- lib/librte_ethdev/rte_ethdev_version.map | 3 +++ lib/librte_ethdev/rte_flow.c | 16 lib/librte_ethdev/rte_flow.h | 21 ++

[dpdk-dev] [PATCH 3/5] app/testpmd: new flow dump CLI

2020-01-16 Thread Xiaoyu Min
From: Xueming Li New flow dump CLI to dump device internal representation information of flows into screen. Signed-off-by: Xueming Li Signed-off-by: Xiaoyu Min --- app/test-pmd/cmdline_flow.c | 91 + app/test-pmd/config.c | 27 +++ app/test-pm

[dpdk-dev] [PATCH 4/5] net/mlx5: add socket server for external tools

2020-01-16 Thread Xiaoyu Min
From: Xueming Li Add pmd unix socket server to enable external tool applications to trigger flow dump. Socket path: /var/tmp/dpdk_mlx5_ Socket format: io_raw: port_id of uint16 file: file descriptor of int Signed-off-by: Xueming Li Signed-off-by: Xiaoyu Min --- driver

[dpdk-dev] [PATCH 5/5] doc: update mlx5 document for flow dump feature

2020-01-16 Thread Xiaoyu Min
From: Xueming Li Guide of mlx5 is updated on how to dump HW flows. Signed-off-by: Xueming Li Signed-off-by: Xiaoyu Min --- doc/guides/nics/mlx5.rst | 28 1 file changed, 28 insertions(+) diff --git a/doc/guides/nics/mlx5.rst b/doc/guides/nics/mlx5.rst index 92228

Re: [dpdk-dev] [PATCH] net/ice: cleanup for vec path check

2020-01-16 Thread Ferruh Yigit
On 1/16/2020 7:09 AM, Xiaolong Ye wrote: > Move the conditional compilation block to the inner check helper, so we > can reduce the number of multiple ifdef check pairs used. > > Signed-off-by: Xiaolong Ye <...> > @@ -2794,10 +2792,8 @@ ice_tx_done_cleanup(void *txq, uint32_t free_cnt)

Re: [dpdk-dev] [PATCH 1/5] ethdev: add API to dump device internal flow info

2020-01-16 Thread Jerin Jacob
On Thu, Jan 16, 2020 at 3:45 PM Xiaoyu Min wrote: > > Introduce an API which dump the device's internal representation > information of rte flows in hardware. > > Signed-off-by: Xiaoyu Min Looks good to me. > --- > lib/librte_ethdev/rte_ethdev_version.map | 3 +++ > lib/librte_ethdev/rte_flow

[dpdk-dev] [PATCH v4 0/4] Refactor crypto unit tests.

2020-01-16 Thread Adam Dybkowski
This patch set is a first step to refactor the overly complex symmetric crypto unit tests. It merges many separate arrays of the tests for these PMDs: null, aesni_mb, aesni_gcm, openssl, qat, sw_snow3g, sw_kasumi, sw_zuc into one big array that's then used when running unit tests on these PMDs. In

[dpdk-dev] [PATCH v4 2/4] test/crypto: refactor unit tests - continuation

2020-01-16 Thread Adam Dybkowski
Remove the functions that are not used any more but were left after the previous commit. Signed-off-by: Adam Dybkowski --- app/test/test_cryptodev.c | 323 -- 1 file changed, 323 deletions(-) diff --git a/app/test/test_cryptodev.c b/app/test/test_cryptodev.c

[dpdk-dev] [PATCH v4 3/4] test/crypto: add capability checks

2020-01-16 Thread Adam Dybkowski
This patch adds capability checks to many tests meant to be run in the future on various PMDs. This way the code is prepared for more thorough refactoring in order to create one big central unit tests array. Signed-off-by: Adam Dybkowski --- app/test/test_cryptodev.c | 616 ++

[dpdk-dev] [PATCH v4 4/4] test/crypto: refactor unit tests into one combined array

2020-01-16 Thread Adam Dybkowski
This patch refactors most of unit tests to be contained in one combined array, and run depending on the PMD capabilities instead of providing multiple array with tests for individual PMDs. Only a subset of unit tests was merged into one array - it combines all tests originally meant to be run on th

[dpdk-dev] [PATCH v4 1/4] test/crypto: refactor unit tests

2020-01-16 Thread Adam Dybkowski
This patch gets rid of individual functions that all call test_blockcipher_all_tests separately for every PMD and instead provides just one set universal for all PMDs that's basing on the driver id from the global variable gbl_driver_id. Signed-off-by: Adam Dybkowski --- app/test/test_cryptodev.

Re: [dpdk-dev] [RFC PATCH 0/3] introduce IF proxy library

2020-01-16 Thread Andrzej Ostruszka
On 1/16/20 10:30 AM, Morten Brørup wrote: [...] >> You are thinking already about modification of the application data. >> That is actually beyond the scope of the library. > > Yes, it is beyond the scope of the library; but I prefer the library to > be designed for how typical applications are go

[dpdk-dev] [PATCH] vhost: catch overflow causing mmap of size 0

2020-01-16 Thread Maxime Coquelin
This patch catches an overflow that could happen if an invalid region size or page alignement is provided by the guest via the VHOST_USER_SET_MEM_TABLE request. If the sum of the size to mmap and the alignment overflows uint64_t, then RTE_ALIGN_CEIL(mmap_size, alignment) macro will return 0. This

[dpdk-dev] [PATCH] vhost: check vhost message header size read

2020-01-16 Thread Maxime Coquelin
This patch adds a check to ensure the read size of the Vhost-user message header is not smaller than the expected size. Fixes: 8f972312b8f4 ("vhost: support vhost-user") Cc: sta...@dpdk.org Reported-by: Ilja Van Sprundel Signed-off-by: Maxime Coquelin --- lib/librte_vhost/vhost_user.c | 6

Re: [dpdk-dev] [PATCH v3 4/6] ipsec: introduce support for cpu crypto mode

2020-01-16 Thread Zhang, Roy Fan
> -Original Message- > From: Smoczynski, MarcinX > Sent: Wednesday, January 15, 2020 6:29 PM > To: akhil.go...@nxp.com; Ananyev, Konstantin > ; Zhang, Roy Fan > ; Doherty, Declan ; > Nicolau, Radu > Cc: dev@dpdk.org; Smoczynski, MarcinX > Subject: [PATCH v3 4/6] ipsec: introduce support

Re: [dpdk-dev] [PATCH v3 4/6] ipsec: introduce support for cpu crypto mode

2020-01-16 Thread Zhang, Roy Fan
> -Original Message- > From: Smoczynski, MarcinX > Sent: Wednesday, January 15, 2020 6:29 PM > To: akhil.go...@nxp.com; Ananyev, Konstantin > ; Zhang, Roy Fan > ; Doherty, Declan ; > Nicolau, Radu > Cc: dev@dpdk.org; Smoczynski, MarcinX > Subject: [PATCH v3 4/6] ipsec: introduce support

Re: [dpdk-dev] [PATCH v3 5/6] examples/ipsec-secgw: cpu crypto support

2020-01-16 Thread Zhang, Roy Fan
> -Original Message- > From: Smoczynski, MarcinX > Sent: Wednesday, January 15, 2020 6:29 PM > To: akhil.go...@nxp.com; Ananyev, Konstantin > ; Zhang, Roy Fan > ; Doherty, Declan ; > Nicolau, Radu > Cc: dev@dpdk.org; Smoczynski, MarcinX > Subject: [PATCH v3 5/6] examples/ipsec-secgw: cpu

Re: [dpdk-dev] [PATCH v3 6/6] examples/ipsec-secgw: cpu crypto testing

2020-01-16 Thread Zhang, Roy Fan
> -Original Message- > From: Smoczynski, MarcinX > Sent: Wednesday, January 15, 2020 6:29 PM > To: akhil.go...@nxp.com; Ananyev, Konstantin > ; Zhang, Roy Fan > ; Doherty, Declan ; > Nicolau, Radu > Cc: dev@dpdk.org; Smoczynski, MarcinX > Subject: [PATCH v3 6/6] examples/ipsec-secgw: cpu

Re: [dpdk-dev] [RFC PATCH 0/3] introduce IF proxy library

2020-01-16 Thread Morten Brørup
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Andrzej Ostruszka > Sent: Thursday, January 16, 2020 11:43 AM > > On 1/16/20 10:30 AM, Morten Brørup wrote: > [...] > >> You are thinking already about modification of the application data. > >> That is actually be

[dpdk-dev] DPDK Release Status Meeting 16/01/2020

2020-01-16 Thread Ferruh Yigit
Minutes 16 January 2020 --- Agenda: * Release Dates * Subtrees * OvS Participants: * Debian/Microsoft * Intel * Marvell * Mellanox * NXP * Red Hat Release Dates - * v20.02 dates: * Integration deadline passed, it was on Wednesday 15 January 2020 * RC1 is e

Re: [dpdk-dev] [PATCH v3 09/10] net/bnxt: release port upon close

2020-01-16 Thread Ferruh Yigit
On 1/14/2020 2:49 PM, Somnath Kotur wrote: > Ferruh, > Will recheck and revert on Hi Ajit, this is blocking the next-net-brcm tree to be pulled. Would you want to drop this patch from your tree and continue with merge and deal with this patch later? Or if this patch is the critical for the serie

Re: [dpdk-dev] [dpdk-stable] [PATCH] meter: move RFC4115 trTCM APIs as none experimental

2020-01-16 Thread David Marchand
On Tue, Dec 17, 2019 at 2:08 PM Eelco Chaudron wrote: > > Moved RFC4115 APIs to none experimental as they have been there > since 19.02. Also, these APIs are the same as the none RFC4115 APIs. > > Signed-off-by: Eelco Chaudron There is a discussion on the OVS ml at the moment to get these symbol

Re: [dpdk-dev] [PATCH v3 09/10] net/bnxt: release port upon close

2020-01-16 Thread Somnath Kotur
Ferruh, On Thu, 16 Jan 2020, 16:50 Ferruh Yigit, wrote: > On 1/14/2020 2:49 PM, Somnath Kotur wrote: > > Ferruh, > > Will recheck and revert on > > Hi Ajit, > > this is blocking the next-net-brcm tree to be pulled. Would you want to > drop > this patch from your tree and continue with merge an

Re: [dpdk-dev] [PATCH v2] Fixes: ethdev: secondary process change shared memory

2020-01-16 Thread 方统浩50450
>@Fang, only can you please make a new version to update the >'rte_eth_copy_pci_info' function comment to document shared data is not updated >for the secondary process? >So this suggest going on with Fang's patch. I only requested an additional note >in function comment related to this seconda

Re: [dpdk-dev] [EXT] Re: [PATCH] ethdev: allow multiple security sessions to use one rte flow

2020-01-16 Thread Ori Kam
> -Original Message- > From: dev On Behalf Of Anoob Joseph > Sent: Tuesday, January 14, 2020 11:28 AM > To: Ori Kam ; Medvedkin, Vladimir > ; Ananyev, Konstantin > ; Akhil Goyal ; > Adrien Mazarguil ; Doherty, Declan > ; Yigit, Ferruh ; Jerin > Jacob Kollanukkaran ; Thomas Monjalon > >

Re: [dpdk-dev] [PATCH dpdk-dev] net/mlx5: support hairpin between different ports

2020-01-16 Thread Ori Kam
Sorry for the late response, Thank you very much for this patch. We are planning to add such support, but this patch is not the best way. I will keep you updated about the progress, and will be very to hear your inputs. Best, Ori > -Original Message- > From: xiangxia.m@gmail.com

[dpdk-dev] [PATCH v3 0/3] Use Intel IPSec MB library in Wireless PMDs

2020-01-16 Thread Pablo de Lara
The three Intel SW Crypto PMDs supporting SNOW3G, ZUC and KASUMI link against libSSO libraries. The Intel IPSec Multi-buffer library recently integrated the code from these libraries, in version v0.53. This library can be downloaded from https://github.com/intel/intel-ipsec-mb. KASUMI, SNOW3G an

[dpdk-dev] [PATCH v3 1/3] crypto/zuc: use IPSec library

2020-01-16 Thread Pablo de Lara
Link against Intel IPSec Multi-buffer library, which added support for ZUC-EEA3 and ZUC-EIA3 from version v0.53, moving from libSSO ZUC library. Signed-off-by: Pablo de Lara --- devtools/test-build.sh | 6 ++-- doc/guides/cryptodevs/zuc.rst | 52 ++--

[dpdk-dev] [PATCH v3 2/3] crypto/kasumi: use IPSec library

2020-01-16 Thread Pablo de Lara
Link against Intel IPSec Multi-buffer library, which added support for KASUMI-F8 and KASUMI-F9 from version v0.53, moving from libSSO KASUMI library. Signed-off-by: Pablo de Lara --- devtools/test-build.sh | 6 +-- doc/guides/cryptodevs/kasumi.rst | 62

[dpdk-dev] [PATCH v3 3/3] crypto/snow3g: use IPSec library

2020-01-16 Thread Pablo de Lara
Link against Intel IPSec Multi-buffer library, which added support for SNOW3G-UEA2 and SNOW3G-UIA2 from version v0.53, moving from libSSO SNOW3G library. Signed-off-by: Pablo de Lara --- devtools/test-build.sh | 4 +- doc/guides/cryptodevs/snow3g.rst | 58 +

Re: [dpdk-dev] [PATCH] add ABI checks

2020-01-16 Thread Neil Horman
On Wed, Jan 15, 2020 at 01:38:17PM +0100, Thomas Monjalon wrote: > 15/01/2020 12:33, Neil Horman: > > On Wed, Jan 15, 2020 at 12:19:30AM +0100, Thomas Monjalon wrote: > > > 20/12/2019 17:20, Kinsella, Ray: > > > > From: Richardson, Bruce > > > > > From: David Marchand > > > > > > +Checking ABI co

Re: [dpdk-dev] [dpdk-stable] [PATCH] meter: move RFC4115 trTCM APIs as none experimental

2020-01-16 Thread Neil Horman
On Thu, Jan 16, 2020 at 12:25:06PM +0100, David Marchand wrote: > On Tue, Dec 17, 2019 at 2:08 PM Eelco Chaudron wrote: > > > > Moved RFC4115 APIs to none experimental as they have been there > > since 19.02. Also, these APIs are the same as the none RFC4115 APIs. > > > > Signed-off-by: Eelco Chau

Re: [dpdk-dev] [EXT] Re: [PATCH] ethdev: allow multiple security sessions to use one rte flow

2020-01-16 Thread Anoob Joseph
Hi Ori, Please see inline. Thanks, Anoob > -Original Message- > From: dev On Behalf Of Ori Kam > Sent: Thursday, January 16, 2020 5:06 PM > To: Anoob Joseph ; Medvedkin, Vladimir > ; Ananyev, Konstantin > ; Akhil Goyal ; Adrien > Mazarguil ; Doherty, Declan > ; Yigit, Ferruh ; Jerin >

Re: [dpdk-dev] [PATCH 2/2] net/mlx5: add fine grain dynamic flag support

2020-01-16 Thread Ori Kam
Hi Ferruh, > -Original Message- > From: Ferruh Yigit > Sent: Wednesday, January 15, 2020 4:02 PM > To: Ori Kam ; Matan Azrad ; > Shahaf Shuler ; Slava Ovsiienko > > Cc: dev@dpdk.org > Subject: Re: [PATCH 2/2] net/mlx5: add fine grain dynamic flag support > > On 1/13/2020 9:29 AM, Ori Ka

Re: [dpdk-dev] [RFC PATCH 0/3] introduce IF proxy library

2020-01-16 Thread Andrzej Ostruszka
Morten First of all thank you for your feedback. If anything else pops into your mind please do not hesitate to share it. We just had a quick internal discussion and we decided that we'll try to come up with both options (callback and message queue). On 1/16/20 11:58 AM, Morten Brørup wrote: >>

Re: [dpdk-dev] [PATCH v2] Fixes: ethdev: secondary process change shared memory

2020-01-16 Thread Ferruh Yigit
On 1/16/2020 11:35 AM, 方统浩50450 wrote: > > >>@Fang, only can you please make a new version to update the >>'rte_eth_copy_pci_info' function comment to document shared data is not >>updated >>for the secondary process? > >>So this suggest going on with Fang's patch. I only requested an additiona

Re: [dpdk-dev] [PATCH 2/2] net/mlx5: add fine grain dynamic flag support

2020-01-16 Thread Ferruh Yigit
On 1/16/2020 12:05 PM, Ori Kam wrote: > Hi Ferruh, > >> -Original Message- >> From: Ferruh Yigit >> Sent: Wednesday, January 15, 2020 4:02 PM >> To: Ori Kam ; Matan Azrad ; >> Shahaf Shuler ; Slava Ovsiienko >> >> Cc: dev@dpdk.org >> Subject: Re: [PATCH 2/2] net/mlx5: add fine grain dyna

[dpdk-dev] [PATCH] ethdev: move non null judgment of ops function pointer ahead

2020-01-16 Thread Wei Hu (Xavier)
From: "Wei Hu (Xavier)" This patch moves the following judgement statement to the first half of the function named rte_eth_dev_set_vlan_offload, so we can avoid changing the content of dev->data->dev_conf.rxmode.offloads even when the pointer named dev->dev_ops->vlan_offload_set is NULL: RTE_FUNC

Re: [dpdk-dev] [PATCH 2/2] net/mlx5: add fine grain dynamic flag support

2020-01-16 Thread Ori Kam
> -Original Message- > From: Ferruh Yigit > Sent: Thursday, January 16, 2020 2:24 PM > To: Ori Kam ; Matan Azrad ; > Shahaf Shuler ; Slava Ovsiienko > > Cc: dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH 2/2] net/mlx5: add fine grain dynamic flag > support > > On 1/16/2020 12:05 PM, Ori

[dpdk-dev] [PATCH v5 0/4] Refactor crypto unit tests.

2020-01-16 Thread Adam Dybkowski
This patch set is a first step to refactor the overly complex symmetric crypto unit tests. It merges many separate arrays of the tests for these PMDs: null, aesni_mb, aesni_gcm, openssl, qat, sw_snow3g, sw_kasumi, sw_zuc into one big array that's then used when running unit tests on these PMDs. In

[dpdk-dev] [PATCH v5 1/4] test/crypto: refactor unit tests

2020-01-16 Thread Adam Dybkowski
This patch gets rid of individual functions that all call test_blockcipher_all_tests separately for every PMD and instead provides just one set universal for all PMDs that's basing on the driver id from the global variable gbl_driver_id. Signed-off-by: Adam Dybkowski --- app/test/test_cryptodev.

Re: [dpdk-dev] [dpdk-stable] [PATCH] meter: move RFC4115 trTCM APIs as none experimental

2020-01-16 Thread Ferruh Yigit
On 1/16/2020 11:54 AM, Neil Horman wrote: > On Thu, Jan 16, 2020 at 12:25:06PM +0100, David Marchand wrote: >> On Tue, Dec 17, 2019 at 2:08 PM Eelco Chaudron wrote: >>> >>> Moved RFC4115 APIs to none experimental as they have been there >>> since 19.02. Also, these APIs are the same as the none RF

[dpdk-dev] [PATCH v5 4/4] test/crypto: refactor unit tests into one combined array

2020-01-16 Thread Adam Dybkowski
This patch refactors most of unit tests to be contained in one combined array, and run depending on the PMD capabilities instead of providing multiple array with tests for individual PMDs. Only a subset of unit tests was merged into one array - it combines all tests originally meant to be run on th

[dpdk-dev] [PATCH v5 2/4] test/crypto: refactor unit tests - continuation

2020-01-16 Thread Adam Dybkowski
Remove the functions that are not used any more but were left after the previous commit. Signed-off-by: Adam Dybkowski --- app/test/test_cryptodev.c | 323 -- 1 file changed, 323 deletions(-) diff --git a/app/test/test_cryptodev.c b/app/test/test_cryptodev.c

[dpdk-dev] [PATCH v5 3/4] test/crypto: add capability checks

2020-01-16 Thread Adam Dybkowski
This patch adds capability checks to many tests meant to be run in the future on various PMDs. This way the code is prepared for more thorough refactoring in order to create one big central unit tests array. Signed-off-by: Adam Dybkowski --- app/test/test_cryptodev.c | 616 ++

[dpdk-dev] [PATCH v7 02/10] app/testpmd: improve debug

2020-01-16 Thread Bernard Iremonger
print function name in port_flow_complain() Signed-off-by: Bernard Iremonger --- app/test-pmd/config.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app/test-pmd/config.c b/app/test-pmd/config.c index d599682..2753ec5 100644 --- a/app/test-pmd/config.c +++ b/app/test-pmd/co

[dpdk-dev] [PATCH v7 03/10] net/i40e: improve RSS debug

2020-01-16 Thread Bernard Iremonger
improve RSS debug in i40e_ethdev.c Signed-off-by: Bernard Iremonger Acked-by: Qi Zhang --- drivers/net/i40e/i40e_ethdev.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/drivers/net/i40e/i40e_ethdev.c b/drivers/net/i40e/i40e_ethdev.c index 5999c96..5f1cf8a 100644 ---

[dpdk-dev] [PATCH v7 01/10] app/testpmd: parse flow command line for ESP

2020-01-16 Thread Bernard Iremonger
add ITEM_ESP add ITEM_ESP_SPI update release notes for testpmd changes add sample ESP rules in testpmd guide Signed-off-by: Bernard Iremonger Acked-by: Ori Kam --- app/test-pmd/cmdline_flow.c | 34 ++--- doc/guides/rel_notes/release_20_02.rst | 4 ++

[dpdk-dev] [PATCH v7 05/10] net/i40e: support ipsec-ah profile

2020-01-16 Thread Bernard Iremonger
Add flow structures for the following patterns in i40e_ethdev files: eth/ipv4/esp eth/ipv6/esp eth/ipv4/udp/esp eth/ipv6/esp/udp add oip_type in filter add is_udp in filter use tenant_id in filter for spi Signed-off-by: Bernard Iremonger Acked-by: Qi Zhang --- drivers/net/i40e/i40e_ethdev.h |

[dpdk-dev] [PATCH v7 04/10] net/i40e: handle ESP tunnel

2020-01-16 Thread Bernard Iremonger
handle ESP tunnel in rte_pmd_i40e.c Signed-off-by: Bernard Iremonger Acked-by: Qi Zhang --- drivers/net/i40e/rte_pmd_i40e.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/net/i40e/rte_pmd_i40e.c b/drivers/net/i40e/rte_pmd_i40e.c index fdcb1a4..b987346 100644 --- a

[dpdk-dev] [PATCH v7 00/10] net/i40e: ESP support

2020-01-16 Thread Bernard Iremonger
Add support for ESP flows to testpmd. Improve debug information in testpmd and the i40e PMD. Process ESP flows on the i40e Flow Director. Changes in V7: - Dropped the following debug patch from v6 patchset 0003-app-testpmd-dump-Rx-and-Tx-mbuf.patch Included release notes and doc patch

[dpdk-dev] [PATCH v7 09/10] config: add debug to I40E Flow Director

2020-01-16 Thread Bernard Iremonger
add CONFIG_RTE_LIBRTE_I40E_DEBUG_FD to config/common_base file Signed-off-by: Bernard Iremonger Acked-by: Qi Zhang --- config/common_base | 1 + 1 file changed, 1 insertion(+) diff --git a/config/common_base b/config/common_base index 7dec7ed..7a76c26 100644 --- a/config/common_base +++ b/conf

[dpdk-dev] [PATCH v7 08/10] net/i40e: support ESP in Flow Director

2020-01-16 Thread Bernard Iremonger
add fill_ip6_head() hardcode udp destination port to 4500 handle ESP and AH pctypes in ESP-AH profile update the i40e user guide with ESP information. update release notes for i40e changes Signed-off-by: Bernard Iremonger Acked-by: Qi Zhang --- doc/guides/nics/i40e.rst | 4 +- d

[dpdk-dev] [PATCH v7 10/10] net/i40e: display Flow Director packet

2020-01-16 Thread Bernard Iremonger
include rte_config.h in i40e_fdir.c In debug mode call rte_hexdump in i40e_flow_fdir_construct_pkt() and in i40e_fdir_construct_pkt() Signed-off-by: Bernard Iremonger Acked-by: Qi Zhang --- drivers/net/i40e/i40e_fdir.c | 12 ++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --

[dpdk-dev] [PATCH v7 06/10] net/i40e: support ESP in customized code

2020-01-16 Thread Bernard Iremonger
update customized code for ESP Signed-off-by: Bernard Iremonger Acked-by: Qi Zhang --- drivers/net/i40e/i40e_ethdev.c | 44 +- 1 file changed, 43 insertions(+), 1 deletion(-) diff --git a/drivers/net/i40e/i40e_ethdev.c b/drivers/net/i40e/i40e_ethdev.c in

[dpdk-dev] [PATCH v7 07/10] net/i40e: support ESP flows

2020-01-16 Thread Bernard Iremonger
add eth/ipv4/esp and eth/ipv6/esp patterns add eth/ipv4/udp/esp and eth/ipv6/esp/udp patterns update i40e_flow_parse_fdir_filter() add i40e_flow_set_filter_spi() Signed-off-by: Bernard Iremonger Acked-by: Qi Zhang --- drivers/net/i40e/i40e_flow.c | 135 ++

[dpdk-dev] [PATCH V4 00/10] bnxt patchset with bug fixes

2020-01-16 Thread Kalesh A P
From: Kalesh AP v1->v2: fixed the correct the commit ids in Fixes tag. v2->v3: shorten commit log and update commit ids for Fixes tag. v3->v4: addressed Ferruh's comment on Patch#1 and Pacth#9 and marked required patches for stable inclusion. Kalesh AP (8): net/bnxt: fix flow create failure

[dpdk-dev] [PATCH V4 04/10] net/bnxt: fix enable/disable VLAN filtering

2020-01-16 Thread Kalesh A P
From: Kalesh AP There is no condition check for the user requested operation for VLAN filtering. As a result, VLAN filtering is getting disabled when the user enables/disables VLAN stripping on same port. The function bnxt_hwrm_clear_l2_filter() didn't actually free L2 filter in HW if the refere

[dpdk-dev] [PATCH V4 02/10] net/bnxt: fix probe failure in FreeBSD

2020-01-16 Thread Kalesh A P
From: Kalesh AP In FreeBSD environment, nic_uio driver does not support interrupts and rte_intr_callback_register() will fail to register interrupts which in turn causes bnxt driver probe failure. Fixed driver to ignore interrupt callback failures in FreeBSD. Also fixed to not use a dedicated co

[dpdk-dev] [PATCH V4 03/10] net/bnxt: fix to use correct IOVA mapping

2020-01-16 Thread Kalesh A P
From: Kalesh AP Use rte_malloc_virt2iova() to obtain the IO address of a virtual address obtained through rte_malloc(). Fixed to use the iova address returned by rte_memzone_reserve_aligned() as the call always returns with populating "mz->iova" with rte_malloc_virt2iova(mz->addr). Removed redu

[dpdk-dev] [PATCH V4 06/10] net/bnxt: handle hw filter setting when port is stopped

2020-01-16 Thread Kalesh A P
From: Kalesh AP Driver destroy the vnic when the port is brought down. Port hw filter setting such as promiscuos, allmulti and vlan filtering will be applied when port is started. Fixed to return success silently for these callbacks when port is stopped. Also fixed to clear "bp->dev_stopped" bef

[dpdk-dev] [PATCH V4 01/10] net/bnxt: fix flow create failure

2020-01-16 Thread Kalesh A P
From: Kalesh AP If flow create fails due to not enough filter resources, driver does not populate the rte_flow_error using rte_flow_error_set(). Since "rte_errno" could have garbage value and is not relaiable, it could cause a segfault in the stack in port_flow_complain(). Fix it to set rte_flo

[dpdk-dev] [PATCH V4 05/10] net/bnxt: fix VLAN strip support

2020-01-16 Thread Kalesh A P
From: Kalesh AP HWRM_VNIC_CFG command to configure vnic dynamically with traffic running is not working. Driver has to free and recreate the vnic and then reconfigure the vnic filters. Fixes: 7fe5668d2ea3 ("net/bnxt: support VLAN filter and strip") Cc: sta...@dpdk.org Signed-off-by: Kalesh AP

[dpdk-dev] [PATCH V4 07/10] net/bnxt: fix a memory leak in port stop

2020-01-16 Thread Kalesh A P
From: Kalesh AP The memory for mark table is allocated during port start. But the allocated memory is freed only during port close or driver unload which in turn causes a memory leakage on each port start/stop. Fixed it by moving the memory free to port stop. Fixes: a968a9f5456d ("net/bnxt: add

[dpdk-dev] [PATCH V4 09/10] net/bnxt: release port upon close

2020-01-16 Thread Kalesh A P
From: Somnath Kotur Set RTE_ETH_DEV_CLOSE_REMOVE upon probe so all the private resources for the port can be freed by rte_eth_dev_close(). Signed-off-by: Somnath Kotur Reviewed-by: Kalesh Anakkur Purayil Reviewed-by: Ajit Kumar Khaparde --- drivers/net/bnxt/bnxt_ethdev.c | 53 +++

[dpdk-dev] [PATCH V4 10/10] net/bnxt: fix to cap max rings to minimum of compl rings and stat contexts

2020-01-16 Thread Kalesh A P
From: Somnath Kotur Max Tx rings count could be lesser than max Rx rings in some cases, so take this into account as well. Account for stat contexts available(one for each ring) along with no: of completion rings(one for each ring) to cap the max no: of Tx /Rx rings that can be possibly created.

[dpdk-dev] [PATCH V4 08/10] net/bnxt: use macro for PCI log format

2020-01-16 Thread Kalesh A P
From: Kalesh AP Fixes: 19e6af01bb36 ("net/bnxt: support get/set EEPROM") Cc: sta...@dpdk.org Signed-off-by: Kalesh AP Reviewed-by: Somnath Kotur --- drivers/net/bnxt/bnxt_ethdev.c | 22 +++--- 1 file changed, 11 insertions(+), 11 deletions(-) diff --git a/drivers/net/bnxt/bnx

Re: [dpdk-dev] DPDK Release Status Meeting 16/01/2020

2020-01-16 Thread Ananyev, Konstantin
Hi everyone, > > * next-net-crypto > * Pull request sent > * There is a performance concern on some ipsec-gw patches, > they can go in -rc2 if the issue is solved > * CPU crypto from last release may be breaking ABI, need to confirm AFAIK, there is no ABI breakage. > and discussed

[dpdk-dev] [PATCH v2] app/testpmd: add dynamic flag support

2020-01-16 Thread Ori Kam
DPDK now supports registration of dynamic flags (dynf) to the mbuf. dynf can be given any name, and can be used with a supporting PMD or supporting application. Due to the generic concept of the dynf, it is impossible and meaningless, to define register set/get function for each flag. This commit

[dpdk-dev] [PATCH v4 0/5] mbuf: detach mbuf with pinned external buffer

2020-01-16 Thread Viacheslav Ovsiienko
Today's pktmbuf pool contains only mbufs with no external buffers. This means data buffer for the mbuf should be placed right after the mbuf structure (+ the private data when enabled). On some cases, the application would want to have the buffers allocated from a different device in the platform.

[dpdk-dev] [PATCH v4 1/5] mbuf: introduce routine to get private mbuf pool flags

2020-01-16 Thread Viacheslav Ovsiienko
The routine rte_pktmbuf_priv_flags is introduced to fetch the flags from the mbuf memory pool private structure in unified fashion. Signed-off-by: Viacheslav Ovsiienko --- lib/librte_mbuf/rte_mbuf.h | 17 + 1 file changed, 17 insertions(+) diff --git a/lib/librte_mbuf/rte_mbuf.h

[dpdk-dev] [PATCH v4 4/5] app/testpmd: add mempool with external data buffers

2020-01-16 Thread Viacheslav Ovsiienko
The new mbuf pool type is added to testpmd. To engage the mbuf pool with externally attached data buffers the parameter "--mp-alloc=xbuf" should be specified in testpmd command line. The objective of this patch is just to test whether mbuf pool with externally attached data buffers works OK. The m

[dpdk-dev] [PATCH v4 2/5] mbuf: detach mbuf with pinned external buffer

2020-01-16 Thread Viacheslav Ovsiienko
Update detach routine to check the mbuf pool type. Introduce the special internal version of detach routine to handle the special case of pinned external bufferon mbuf freeing. Signed-off-by: Shahaf Shuler Signed-off-by: Viacheslav Ovsiienko --- lib/librte_mbuf/rte_mbuf.h | 95 +

[dpdk-dev] [PATCH v4 3/5] mbuf: create packet pool with external memory buffers

2020-01-16 Thread Viacheslav Ovsiienko
The dedicated routine rte_pktmbuf_pool_create_extbuf() is provided to create mbuf pool with data buffers located in the pinned external memory. The application provides the external memory description and routine initializes each mbuf with appropriate virtual and physical buffer address. It is enti

[dpdk-dev] [PATCH v4 5/5] net/mlx5: allow use allocated mbuf with external buffer

2020-01-16 Thread Viacheslav Ovsiienko
In the Rx datapath the flags in the newly allocated mbufs are all explicitly cleared but the EXT_ATTACHED_MBUF must be preserved. It would allow to use mbuf pools with pre-attached external data buffers. The vectorized rx_burst routines are updated in order to inherit the EXT_ATTACHED_MBUF from mb

Re: [dpdk-dev] [PATCH v2 1/3] eal: introduce structure marker typedefs

2020-01-16 Thread Jerin Jacob
On Thu, Jan 2, 2020 at 3:18 PM Matan Azrad wrote: > > > > From: Jerin Jacob > > On Thu, Dec 26, 2019 at 1:45 PM Matan Azrad > > wrote: > > > > > > Hi > > Sorry, missed it. > Series-acked-by: Matan Azrad Ping for merge. > > > > > > > > > /** > > > > * Combines 32b inputs most significant s

Re: [dpdk-dev] [PATCH v4] mempool: remove memory wastage on non x86

2020-01-16 Thread Jerin Jacob
On Wed, Jan 15, 2020 at 2:35 AM wrote: > > From: Jerin Jacob > > The existing optimize_object_size() function address the memory object > alignment constraint on x86 for better performance. > > Different (micro) architecture may have different memory alignment > constraint for better performance

Re: [dpdk-dev] [PATCH] config: disable all kmods by default from v20.02

2020-01-16 Thread Jerin Jacob
Ping. On Thu, Dec 12, 2019 at 6:42 PM wrote: > > From: Jerin Jacob > > Based on the techboard meeting held on 2019-11-06, > It's been decided to disable all kmods by default from v20.02. > > http://mails.dpdk.org/archives/dev/2019-November/151763.html > > Signed-off-by: Jerin Jacob > --- > con

Re: [dpdk-dev] DPDK Release Status Meeting 16/01/2020

2020-01-16 Thread Akhil Goyal
Hi Konstantin, > Hi everyone, > > > > > * next-net-crypto > > * Pull request sent > > * There is a performance concern on some ipsec-gw patches, > > they can go in -rc2 if the issue is solved > > * CPU crypto from last release may be breaking ABI, need to confirm > > AFAIK, there is no

  1   2   >