08/06/2020 09:50, Olivier Matz:
> On Mon, Jun 01, 2020 at 03:24:16PM +, Alexander Kozyrev wrote:
> > Memzones are created in testpmd in order to test external data
> > buffers functionality. Each memzone is 2Mb in size and divided among
> > the pool of external memory buffers.
> >
> > Memzone
11/06/2020 08:37, Jerin Jacob:
> On Thu, Jun 11, 2020 at 12:02 PM Thomas Monjalon wrote:
> >
> > Since dynamic fields and flags were added in 19.11,
> > the idea was to use them for new features, not only PMD-specific.
> >
> > The guideline is made more explicit in doxygen, in the mbuf guide,
> >
Interrupt callback unregister can fail with -EAGAIN
when interrupt handler is active in interrupt thread.
Hence retry before reporting a failure or proceeding further.
Signed-off-by: Nithin Dabilpuram
---
drivers/common/octeontx2/otx2_irq.c | 19 +--
1 file changed, 17 insertions
09/06/2020 09:12, Xiaolong Ye:
> TAILQ_ENTRY next is not needed in struct mbuf_dynfield_elt and
> mbuf_dynflag_elt, since they are actually chained by rte_tailq_entry's
> next field when calling TAILQ_INSERT_TAIL(mbuf_dynfield/dynflag_list, te,
> next).
>
> Fixes: 4958ca3a443a ("mbuf: support dyna
09/06/2020 10:24, Xiaolong Ye:
> Fixes: 4958ca3a443a ("mbuf: support dynamic fields and flags")
> Cc: sta...@dpdk.org
>
> Signed-off-by: Xiaolong Ye
Applied with title "fix a dynamic flag log".
When hardware timestamping is enabled on Rx path, system time should
no longer be used to calculate the timestamps when dumping packets.
Instead, use the value stored by the driver in mbuf->timestamp
and assume it is already converted to nanoseconds (otherwise the
application may edit the packet h
On 08/06/20 17:53 +0200, Maxime Coquelin wrote:
> In order to simplify the use of rte_dev_probe() and
> rte_dev_remove() by applications, rte_dev_probe() will
> return a reference on the rte_device stating DPDK v20.11.
>
> Signed-off-by: Maxime Coquelin
> ---
> doc/guides/rel_notes/deprecation.r
Main changes:
1. support outer IP filter for GTPU (include IPv6)
2. recipe can be reused between PFs.
3. fix VSI ID mask
4. some code refactor and clean
Qi Zhang (10):
net/ice/base: adjust profile id map locks
net/ice/base: refactor to avoid need to retry
net/ice/base: add FD support for out
The profile id map lock should be held till the caller completes
all references of that profile entries.
The current code releases the lock right after the match search.
This caused a driver issue when the profile map entries were
referenced after it was freed in other thread after the lock was
re
The ice_discover_caps function is used to read the device and function
capabilities, updating the hardware capabilities structures with
relevant data.
The exact number of capabilities returned by the hardware is unknown
ahead of time. The AdminQ command will report the total number of
capabilities
Add outer IP address fields while generating the training packets for
GTPU, so that we can support FDIR based on outer IP of GTPU.
Signed-off-by: Junfeng Guo
Signed-off-by: Paul M Stillwell Jr
Signed-off-by: Qi Zhang
---
drivers/net/ice/base/ice_fdir.c | 6 +++---
1 file changed, 3 insertions(
The grst_delay variable in ice_check_reset contains the maximum time
(in 100 msec units) that the driver will wait for a reset event to
transition to the Device Active state. The value is the sum of three
separate components:
1) The maximum time it may take for the firmware to process its
outstandi
Add FDir support for MAC_IPV6_GTPU type with outer IPv6 address, teid
and qfi fields matching.
Signed-off-by: Junfeng Guo
Signed-off-by: Paul M Stillwell Jr
Signed-off-by: Qi Zhang
---
drivers/net/ice/base/ice_fdir.c | 36
drivers/net/ice/base/ice_fdir.h |
This patch add support to get tunnel type of recipe
after get recipe from fw. This will fix the issue in
function ice_find_recp() for tunnel type comparing.
Signed-off-by: Wei Zhao
Signed-off-by: Paul M Stillwell Jr
Signed-off-by: Qi Zhang
---
drivers/net/ice/base/ice_switch.c | 177 ++
In order to find proper dummy packets for switch filter,
it need to check ipv4 next protocol number, if it is 0x06,
which means next payload is TCP, we need to use TCP
format dummy packet.
Signed-off-by: Wei Zhao
Signed-off-by: Paul M Stillwell Jr
Signed-off-by: Qi Zhang
---
drivers/net/ice/ba
System diagnostic solution extend the ability to fetch FW
internal status data and error indication.
Signed-off-by: Sharon Haroni
Signed-off-by: Paul M Stillwell Jr
Signed-off-by: Qi Zhang
---
drivers/net/ice/base/ice_adminq_cmd.h | 54 +++
1 file changed, 54 in
Replacing flow profile locks with RSS profile locks in the function to
remove all RSS rules for a given VSI. This is to align the locks used
for RSS rule addition to VSI and removal during VSI teardown to avoid
a race condition owing to several iterations of the above operations.
In function to get
set_rss_lut failed due to incorrect vsi_id mask. vsi_id is 10 bit
but mask was 0x1FF whereas it should be 0x3FF.
For vsi_num >= 512, FW set_rss_lut has been failing with return code
EACCESS (vsi ownership issue) because software was providing
incorrect vsi_num (dropping 10th bit due to incorrect m
> -Original Message-
> From: dev On Behalf Of Stephen Hemminger
> Sent: Friday, November 8, 2019 4:47 PM
> To: dev@dpdk.org
> Cc: Stephen Hemminger
> Subject: [dpdk-dev] [PATCH v2 0/2] pdump: cleanups
>
> These are a couple of small cleanups for 19.10 which came out of work on
> pcapng s
On 10-Jun-20 5:39 PM, Dmitry Kozlyuk wrote:
On Wed, 10 Jun 2020 16:48:58 +0100
"Burakov, Anatoly" wrote:
On 10-Jun-20 3:31 PM, Dmitry Kozlyuk wrote:
On Wed, 10 Jun 2020 11:26:22 +0100
"Burakov, Anatoly" wrote:
[snip]
+ addr = eal_get_virtual_area(
+ msl->base_va, &mem_s
From: Qi Zhang
Enable device configuration function in DCF.
Signed-off-by: Qi Zhang
Signed-off-by: Ting Xu
---
drivers/net/ice/ice_dcf_ethdev.c | 11 ++-
1 file changed, 10 insertions(+), 1 deletion(-)
diff --git a/drivers/net/ice/ice_dcf_ethdev.c b/drivers/net/ice/ice_dcf_ethdev.c
i
This patchset adds support to configure DCF datapath, including
Rx/Tx queues setup, start and stop, device configuration, RSS
and flexible descriptor RXDID initialization and MAC filter setup.
Qi Zhang (11):
net/ice: init RSS and supported RXDID in DCF
net/ice: complete device info get in DCF
From: Qi Zhang
Add support to get complete device information for DCF, including
Rx/Tx offload capabilities and default configuration.
Signed-off-by: Qi Zhang
Signed-off-by: Ting Xu
---
drivers/net/ice/ice_dcf_ethdev.c | 72 ++--
1 file changed, 69 insertions(+), 3
From: Qi Zhang
Delete original DCF queue setup functions and use ice
queue setup and release functions instead.
Signed-off-by: Qi Zhang
Signed-off-by: Ting Xu
---
drivers/net/ice/ice_dcf_ethdev.c | 42 +++-
drivers/net/ice/ice_dcf_ethdev.h | 3 ---
drivers/net/ice
From: Qi Zhang
Add stop flag for DCF device start and stop.
Signed-off-by: Qi Zhang
Signed-off-by: Ting Xu
---
drivers/net/ice/ice_dcf_ethdev.c | 12
drivers/net/ice/ice_dcf_parent.c | 1 +
2 files changed, 13 insertions(+)
diff --git a/drivers/net/ice/ice_dcf_ethdev.c b/driver
From: Qi Zhang
Enable RSS parameters initialization and get the supported
flexible descriptor RXDIDs bitmap from PF during DCF init.
Signed-off-by: Qi Zhang
Signed-off-by: Ting Xu
---
drivers/net/ice/ice_dcf.c | 54 ++-
drivers/net/ice/ice_dcf.h | 3 +++
2
From: Qi Zhang
Enable Rx queues initialization during device start in DCF.
Signed-off-by: Qi Zhang
Signed-off-by: Ting Xu
---
drivers/net/ice/ice_dcf.h| 1 +
drivers/net/ice/ice_dcf_ethdev.c | 83
2 files changed, 84 insertions(+)
diff --git a/driver
From: Qi Zhang
Enable RSS initialization during DCF start. Add RSS LUT and
RSS key configuration functions.
Signed-off-by: Qi Zhang
Signed-off-by: Ting Xu
---
drivers/net/ice/ice_dcf.c| 117 +++
drivers/net/ice/ice_dcf.h| 1 +
drivers/net/ice/ice_
From: Qi Zhang
Add queue start and stop in DCF. Support queue enable and disable
through virtual channel. Add support for Rx queue mbufs allocation
and queue reset.
Signed-off-by: Qi Zhang
Signed-off-by: Ting Xu
---
drivers/net/ice/ice_dcf.c| 57 ++
drivers/net/ice/ice_dcf.h
From: Qi Zhang
Add queues and Rx queue irqs configuration during device start
in DCF. The setup is sent to PF via virtchnl.
Signed-off-by: Qi Zhang
Signed-off-by: Ting Xu
---
drivers/net/ice/ice_dcf.c| 111 +++
drivers/net/ice/ice_dcf.h| 6 ++
drivers
From: Qi Zhang
Add support to get and reset Rx/Tx stats in DCF. Query stats
from PF.
Signed-off-by: Qi Zhang
Signed-off-by: Ting Xu
---
drivers/net/ice/ice_dcf.c| 27
drivers/net/ice/ice_dcf.h| 4 ++
drivers/net/ice/ice_dcf_ethdev.c | 102 ++
From: Qi Zhang
Add support to add and delete MAC address filter in DCF.
Signed-off-by: Qi Zhang
Signed-off-by: Ting Xu
---
drivers/net/ice/ice_dcf.c| 42
drivers/net/ice/ice_dcf.h| 1 +
drivers/net/ice/ice_dcf_ethdev.c | 7 ++
3 files ch
Add doc for DCF datapath configuration in DPDK 20.08 release note.
Signed-off-by: Ting Xu
---
doc/guides/rel_notes/release_20_08.rst | 6 ++
1 file changed, 6 insertions(+)
diff --git a/doc/guides/rel_notes/release_20_08.rst
b/doc/guides/rel_notes/release_20_08.rst
index dee4ccbb5..1a3a4cd
So apologies for resurrecting an old thread - I did want to chime on this.
From a past life as a Windows Programmer, I would say that shared libraries
model on Windows is not as strong as on Linux/Unix.
Libraries on Windows are typically packaged and distributed along with the
applications, not
Add rte_write32_wc function that implements a WC store
using movdiri instruction.
Signed-off-by: Radu Nicolau
---
lib/librte_eal/x86/include/rte_io.h | 20
1 file changed, 20 insertions(+)
diff --git a/lib/librte_eal/x86/include/rte_io.h
b/lib/librte_eal/x86/include/rte_io
If available use movdiri instruction instead of a regular mmio write to
update queue tail registers.
Signed-off-by: Radu Nicolau
---
drivers/net/i40e/base/i40e_osdep.h| 20
drivers/net/i40e/i40e_ethdev_vf.c | 10 ++
drivers/net/i40e/i40e_fdir.c | 4
From: Patrick
This patch introduces registration/un-registration APIs
for async data path together with all required data
structures and DMA callback function proto-types.
Signed-off-by: Patrick
---
lib/librte_vhost/Makefile | 3 +-
lib/librte_vhost/rte_vhost.h | 1 +
lib/li
From: Patrick
This patch implement async enqueue data path for split ring.
Signed-off-by: Patrick
---
lib/librte_vhost/rte_vhost_async.h | 38 +++
lib/librte_vhost/virtio_net.c | 538 -
2 files changed, 574 insertions(+), 2 deletions(-)
diff --git a/l
From: Patrick Fu
Performing large memory copies usually takes up a major part of CPU
cycles and becomes the hot spot in vhost-user enqueue operation. To
offload expensive memory operations from the CPU, this patch set
proposes to leverage DMA engines, e.g., I/OAT, a DMA engine in the
Intel's proc
The event status has been cleaned up by the CAS operation when we free
the event data, so there is no need to set it to invalid after that.
Fixes: 49e2f374e45a ("eal/linux: support external Rx interrupt")
Cc: shah...@mellanox.com
Cc: sta...@dpdk.org
Signed-off-by: Phil Yang
Reviewed-by: Ruifeng
The event status is defined as a volatile variable and shared
between threads. Use c11 atomics with explicit ordering instead
of rte_atomic ops which enforce unnecessary barriers on aarch64.
Signed-off-by: Phil Yang
Reviewed-by: Ruifeng Wang
---
lib/librte_eal/include/rte_eal_interrupts.h | 2
Use c11 atomics with explicit ordering instead of rte_atomic ops which
enforce unnecessary barriers on aarch64.
Signed-off-by: Phil Yang
Reviewed-by: Ruifeng Wang
---
lib/librte_mbuf/rte_mbuf.c | 1 -
lib/librte_mbuf/rte_mbuf.h | 19 ++-
lib/librte_mbuf/rte_mbuf_core.
On Tue, May 19, 2020 at 03:15:19PM -0700, Ranjit Menon wrote:
> On 5/19/2020 1:18 PM, Thomas Monjalon wrote:
> > 19/05/2020 21:57, Dmitry Kozlyuk:
> > > On Tue, 19 May 2020 20:49:50 +0200
> > > Thomas Monjalon wrote:
> > >
> > > > +Cc more maintainers
> > > >
> > > > 19/05/2020 20:41, tal...@mel
This patch enables FDIR with input set ethertype.
Signed-off-by: Simei Su
---
drivers/net/ice/ice_fdir_filter.c | 58 +++
1 file changed, 40 insertions(+), 18 deletions(-)
diff --git a/drivers/net/ice/ice_fdir_filter.c
b/drivers/net/ice/ice_fdir_filter.c
ind
Hi David,
> > > >
> > > > >
> > > > > /** Status of crypto operation */ @@ -121,6 +123,13 @@ struct
> > > > > rte_crypto_op {
> > > > > struct rte_crypto_asym_op asym[0];
> > > > > /**< Asymmetric operation parameters */
> > > > >
> > > > > +#ifdef RTE_LIBRTE_SECURITY
On Thu, Jun 11, 2020 at 3:41 PM Radu Nicolau wrote:
>
> Add rte_write32_wc function that implements a WC store
> using movdiri instruction.
>
> Signed-off-by: Radu Nicolau
> ---
> lib/librte_eal/x86/include/rte_io.h | 20
> 1 file changed, 20 insertions(+)
>
> diff --git a/l
Giving invalid or zero portmask as command line option to
these applications will have an unexpected response.
The reason behind this is that the return value of function
that parses portmask is stored in a variable whose datatype is
unsigned int, hence returning -1 in case of zero or
invalid por
When using full offload, all traffic will be handled by the HW, and
directed to the requested vf or wire, the control application loses
visibility on the traffic.
So there's a need for an action that will enable the control application
some visibility.
The solution is introduced a new action that
Hi Arek,
> -Original Message-
> From: Kusztal, ArkadiuszX
> Sent: Wednesday, June 10, 2020 7:53 PM
> To: dev@dpdk.org
> Cc: akhil.go...@nxp.com; Trahe, Fiona ;
> arkaduszx.kusz...@intel.com
> Subject: [PATCH 1/2] cryptodev: add function to check if qp was setup
>
> From: Fiona Trahe
>
Application updates first line of each test vector with
COUNT = i(where i = 1,2,3..) assuming first line contains
COUNT string. But few of the TDES input test vectors don't
contain COUNT string and thus COUNT is getting overwritten on
other data.
Fixes: 527cbf3d5ee3 ("examples/fips_validation: sup
> -Original Message-
> From: Kusztal, ArkadiuszX
> Sent: Wednesday, June 10, 2020 7:53 PM
> To: dev@dpdk.org
> Cc: akhil.go...@nxp.com; Trahe, Fiona ;
> arkaduszx.kusz...@intel.com
> Subject: [PATCH 2/2] cryptodev: add cryptodev trace in multi process function
>
> From: Fiona Trahe
>
Fix missing callback registration and the incorrect
callback definition for interim NK_STR. The callback
should compare input key against the interim.
Fixes: 527cbf3d5ee3 ("examples/fips_validation: support TDES parsing")
Signed-off-by: Archana Muniganti
---
examples/fips_validation/fips_valida
From: Ayuj Verma
Processing of test vector for COUNT = 0 is getting skipped, as
some of the NIST TDES files doesn't have an empty line after
[ENCRYPT]/[DECRYPT] and thus treated as an interim block.
Parse function now identifies such blocks, separates out interim
and test vector data, and then p
Hi Arek,
> -Original Message-
> From: Kusztal, ArkadiuszX
> Sent: Wednesday, June 10, 2020 8:06 PM
> To: dev@dpdk.org
> Cc: akhil.go...@nxp.com; Trahe, Fiona ; Kusztal,
> ArkadiuszX
>
> Subject: [PATCH] crypto/qat: add handling of multi process
>
> This patch improves handling of multi
On 6/11/2020 1:23 PM, Jerin Jacob wrote:
On Thu, Jun 11, 2020 at 3:41 PM Radu Nicolau wrote:
Add rte_write32_wc function that implements a WC store
using movdiri instruction.
Signed-off-by: Radu Nicolau
---
lib/librte_eal/x86/include/rte_io.h | 20
1 file changed, 20
Hi Konstantin,
> > > > >
> > > > > >
> > > > > > /** Status of crypto operation */ @@ -121,6 +123,13 @@ struct
> > > > > > rte_crypto_op {
> > > > > > struct rte_crypto_asym_op asym[0];
> > > > > > /**< Asymmetric operation parameters */
> > > > > >
> > > > > > +#ifdef RTE
11/06/2020 13:43, Olivier Matz:
> On Tue, May 19, 2020 at 03:15:19PM -0700, Ranjit Menon wrote:
> > On 5/19/2020 1:18 PM, Thomas Monjalon wrote:
> > > 19/05/2020 21:57, Dmitry Kozlyuk:
> > > > On Tue, 19 May 2020 20:49:50 +0200
> > > > Thomas Monjalon wrote:
> > > >
> > > > > +Cc more maintainers
02/06/2020 04:00, Tasnim Bashar:
> --- a/lib/librte_eal/windows/include/rte_windows.h
> +++ b/lib/librte_eal/windows/include/rte_windows.h
> @@ -29,6 +29,7 @@
> #define INITGUID
> #endif
> #include
> +#include
Why do you need adding rte_log in rte_windows?
[AMD Official Use Only - Internal Distribution Only]
Hi Pablo,
Can you please help ?
Thanks and Regards
Selwin Sebastian
-Original Message-
From: Ferruh Yigit
Sent: Tuesday, June 9, 2020 9:34 PM
To: Sebastian, Selwin ; dev@dpdk.org
Cc: Somalapuram, Amaranath ; Pablo de Lara
25/05/2020 03:08, Dmitry Kozlyuk:
> On Wed, 20 May 2020 17:32:53 -0700
> Tasnim Bashar wrote:
>
> > Add rte_sys_gettid function to use rte_gettid() on Windows.
> > rte_gettid() is required for recursive spin lock and recursive ticket lock.
> >
> > Signed-off-by: Tasnim Bashar
>
> Acked-by: Dmi
19/05/2020 01:20, Fady Bader:
> This patchset splits OS dependent EAL timer functions and implements them for
> windows.
>
> Fady Bader (3):
> timer: move from common to Unix directory
> eal: proc type function for Windows
> timer: support EAL functions on Windows
This series is pending fo
On Thu, Jun 11, 2020 at 08:48:01AM +0800, Xiaolong Ye wrote:
> We should make sure off + size < sizeof(struct rte_mbuf) to avoid
> possible out-of-bounds access of free_space array, there is no issue
> currently due to the low bits of free_flags (which is adjacent to
> free_space) are always set to
Minor nit inline.
Acked-by: Anoob Joseph
> -Original Message-
> From: dev On Behalf Of Arek Kusztal
> Sent: Thursday, June 11, 2020 12:48 AM
> To: dev@dpdk.org
> Cc: akhil.go...@nxp.com; fiona.tr...@intel.com; Arek Kusztal
>
> Subject: [dpdk-dev] [PATCH v4 2/2] test/cryptodev: add chac
While some devices update their own clock info to provide current time,
mlx5dv part of libibverbs already handles this and also converts any raw
counter cycle to nanoseconds.
Signed-off-by: Patrick Keroulas
---
drivers/common/mlx5/linux/mlx5_glue.c | 16 ++
drivers/common/mlx5/linux/
Existing ethdev functions can read/write time from/to device but
they're all related to timesync and none of them can translate a raw
counter in real time unit which is usefull in a pdump application.
A new API is required because the conversion is derived from dev clock
info.
Signed-off-by: Patr
When hardware timestamping is activated, system time should no longer be
used to timestamp dumped the packets. Instead, use value held by
forwarded and assume they were converted to nanoseconds.
Signed-off-by: Patrick Keroulas
Signed-off-by: Vivien Didelot
---
drivers/net/pcap/rte_eth_pcap.c |
The intention is to produce a pcap with nanosecond precision when
timestamp offloading is activated on mlx5 NIC.
The packets forwarded by testpmd hold the raw counter but a pcap
requires a time unit. Assuming that the NIC clock is already synced
with external master clock, this patchset simply int
We should make sure off + size < sizeof(struct rte_mbuf) to avoid
possible out-of-bounds access of free_space array, there is no issue
currently due to the low bits of free_flags (which is adjacent to
free_space) are always set to 0. But we shouldn't rely on it since it's
fragile and layout of stru
On Thu, Jun 11, 2020 at 7:26 PM Nicolau, Radu wrote:
>
>
> On 6/11/2020 1:23 PM, Jerin Jacob wrote:
> > On Thu, Jun 11, 2020 at 3:41 PM Radu Nicolau wrote:
> >> Add rte_write32_wc function that implements a WC store
> >> using movdiri instruction.
> >>
> >> Signed-off-by: Radu Nicolau
> >> ---
>
A vDPA driver can configure its device FD to be notified directly by
the guest memory mapping using `rte_vhost_host_notifier_ctrl` API.
The driver request is managed by the dpdk vhost management and is
forwarded to the QEMU, the vhost massage includes reply request in order
to be sure that the mem
29/05/2020 01:14, Pallavi Kadam:
> Added -Werror in meson file to consider all the warnings
> as errors on Windows.
>
> Signed-off-by: Pallavi Kadam
> Reviewed-by: Ranjit Menon
> ---
> --- a/config/meson.build
> +++ b/config/meson.build
> +# add -Werror to treat warnings as errors on Windows
> +
29/05/2020 01:14, Pallavi Kadam:
> Fixed bunch of warnings when compiling using clang on Windows
> such as the use of an unsafe string function (strerror),
> [-Wunused-variable], [-Wunused-function] in eal_common_options.c
> [-Wunused-const-variable] in getopt.c and [-Wunused-parameter]
> in eal_co
10/06/2020 16:27, Dmitry Kozlyuk:
> Introduce OS-independent wrappers in order to support common EAL code
> on Unix and Windows:
>
> * eal_file_open: open or create a file.
> * eal_file_lock: lock or unlock an open file.
> * eal_file_truncate: enforce a given size for an open file.
>
> Implementa
10/06/2020 16:27, Dmitry Kozlyuk:
> This patchset implements basic MM with the following features:
There are some compilation issues on FreeBSD and 32-bit Linux:
http://mails.dpdk.org/archives/test-report/2020-June/135764.html
The Legacy MPW (multi-packet write) should not be engaged implicitly.
We should exclude this function form a Tx burst routine selection process
unless it is requested specifically by setting the txq_mpw_en devarg.
Exclude this function from the selection process the same way it is done
for the Enha
The number of descriptors to configure in a Rx/Tx queue is passed to
the mlx5_tx/rx_queue_pre_setup() function by value. That means any
adjustments of this variable are local and cannot affect the actual
value that is used to allocate mbufs in the mlx5_txq/rxq_new()
functions. Pass the number as a
On 6/9/2020 12:59 PM, Qi Zhang wrote:
> The commit ef92cee94cdb ("ice-shared: Fix remaining minor casting
> issues") changed the idx variable within ice_acl_add_entry() from
> a u16 to a u8.
Where is this commit, I guess it is not in the DPDK repo, and the DPDK repo one
is already listed in the '
On 6/9/2020 12:59 PM, Qi Zhang wrote:
> Remove unncessary case branch.
's/unncessary/unnecessary/'
'ICE_BLK_SW' & 'ICE_BLK_PE' cases seems removed, is there any context for record
why they are unnecessary, can you please add to the commit log?
>
> Signed-off-by: Qi Zhang
<...>
On 6/9/2020 12:59 PM, Qi Zhang wrote:
In patch title, 's/protoypes/prototypes/'
> There are some function prototypes at the beginning of the file and
> some at the end, group them all together so that they are in one
> consistent location.
>
> Signed-off-by: Tony Nguyen
> Signed-off-by: Paul M.
On 6/9/2020 12:59 PM, Qi Zhang wrote:
> By default the queues are configured in legacy mode. The default
> BW settings for legacy/advanced modes are different.
BW == Bandwidth?
> The existing
> code was using the advanced mode default value of 1 which was
> incorrect. This caused the unbalanced B
On 6/9/2020 12:59 PM, Qi Zhang wrote:
> This patch add more tunnel type defination ipv4/ipv6 packet,
's/defination/definition/'
> it enable tcp/udp layer of ipv4/ipv6 as L4 payload but without
> L4 dst/src port number as input set for switch filter rule.
>
> For example:
> we can download a swit
On 6/9/2020 12:59 PM, Qi Zhang wrote:
> FDIR can forward Ethernet packets with non-IP ethertype.
In patch title, isn't "non-IP Layer2 protocol" confusing? Should it be "non-IP
Layer 3 protocol"? But I think description in commit log is better, what do you
think:
"support flow director for non-IP p
On 6/9/2020 12:59 PM, Qi Zhang wrote:
> To allow for resets during package download, increase the timeout period
> after performing a PFR. The time waited is the global config lock
> timeout plus the normal PFSWR timeout.
Is PFR == PF Reset, right? And is this same as FLR?
>
> Signed-off-by: Dan
On 6/9/2020 12:59 PM, Qi Zhang wrote:
> Return ICE_ERR_DOES_NOT_EXIST return code if admin command error code is
> ICE_AQ_RC_ENOENT (not exist). ice_aq_sw_rules is used when switch
> rule is getting added/deleted/updated. In case of delete/update
> switch rule, admin command can return ICE_AQ_RC_EN
On 6/9/2020 12:59 PM, Qi Zhang wrote:
> This patch mainly does cleanups related to unnecessary braces.
Personally I think better to keep the braces when the block is more than single
line, otherwise you are mostly relying on indentation which is prone to error.
If you have strong opinion/need to
On 6/9/2020 12:59 PM, Qi Zhang wrote:
> Mask bits before accessing the profile type field.
RL profile == Rate Limiter profile?
>
> Signed-off-by: Tarun Singh
> Signed-off-by: Paul M. Stillwell Jr
> Signed-off-by: Qi Zhang
<...>
The startup of VFIO is too noisy. Logging is expensive on some
systems, and distracting to the user.
It should not be logging at NOTICE level, reduce it to INFO level.
It really should be DEBUG here but that would hide it by default.
Signed-off-by: Stephen Hemminger
---
lib/librte_eal/linux/eal
On 6/9/2020 12:59 PM, Qi Zhang wrote:
> Function ice_rem_adv_rule_id return incorrect error code (ICE_ERR_PARAM)
> whereas it should have returned ICE_ERR_DOES_NOT_EXIST return code
> if filter list is empty or unable to find "rule" in list
Can you please add the "Fixes: " tag?
And the patch titl
On 6/9/2020 12:59 PM, Qi Zhang wrote:
> Needs to update the VSI handle to the last remaining VSI using the
> rule for ICE_FWD_TO_VSI. Otherwise it may have error for deleting the
> rule.
The reason of the patch is not clear, it looks to "prevent an error for deleting
the rule", but can you please
On 6/9/2020 12:59 PM, Qi Zhang wrote:
> struct ice_aqc_get_phy_caps_data has multiple autoneg enable bits.
> ice_is_phy_caps_an_enabled checks all bits and returns true if any
> autoneg enable bits are set.
We refer as API to the functions that are exposed to applications, what do you
think about
On 6/9/2020 12:59 PM, Qi Zhang wrote:
> This patch add initialization for prof_res_bm_init flag
> to zero in order that the possible resource for field vector
> in the files can be initialized.
I guess this is fixing initialization of _something_ (resource for field vector
in package file?), and t
On Mon, 24 Feb 2020 13:01:30 -0800
Stephen Hemminger wrote:
> Simple script to look for drivers and scripts that
> are missing requires SPDX header.
>
> Update the contribution guidelines to indicate that SPDX license
> identfier is required for this project.
>
> Signed-off-by: Stephen Hemminge
On 6/9/2020 1:00 PM, Qi Zhang wrote:
> In the flow API, add ability to add IPV4/IPV6 rules that match on
> packets with or without inner L4 protocols.
>
> Also, remove PPPOD packet from PPPOE bitmap.
I can't spot this change among other changes, if it is not directly related to
the main feature,
On 6/11/2020 9:12 AM, Thomas Monjalon wrote:
29/05/2020 01:14, Pallavi Kadam:
Added -Werror in meson file to consider all the warnings
as errors on Windows.
Signed-off-by: Pallavi Kadam
Reviewed-by: Ranjit Menon
---
--- a/config/meson.build
+++ b/config/meson.build
+# add -Werror to treat
On 6/11/2020 9:14 AM, Thomas Monjalon wrote:
29/05/2020 01:14, Pallavi Kadam:
Fixed bunch of warnings when compiling using clang on Windows
such as the use of an unsafe string function (strerror),
[-Wunused-variable], [-Wunused-function] in eal_common_options.c
[-Wunused-const-variable] in ge
Fixed bunch of warnings when compiling using clang on Windows
such as the use of an unsafe string function (strerror),
[-Wunused-variable], [-Wunused-function] in eal_common_options.c
[-Wunused-const-variable] in getopt.c and [-Wunused-parameter]
in eal_common_thread.c.
Also fixed warnings generate
On Thu, Jun 11, 2020 at 12:50:55PM -0700, Pallavi Kadam wrote:
> Fixed bunch of warnings when compiling using clang on Windows
> such as the use of an unsafe string function (strerror),
> [-Wunused-variable], [-Wunused-function] in eal_common_options.c
> [-Wunused-const-variable] in getopt.c and [-
11/06/2020 20:46, Stephen Hemminger:
> On Mon, 24 Feb 2020 13:01:30 -0800
> Stephen Hemminger wrote:
>
> > Simple script to look for drivers and scripts that
> > are missing requires SPDX header.
> >
> > Update the contribution guidelines to indicate that SPDX license
> > identfier is required f
This patches fixes a null pointer derefencing that happens
when the device string passed to the iterator is NULL. This
situation can happen when iterating on a class type.
For example:
RTE_DEV_FOREACH(dev, "class=eth", &dev_iter) {
...
}
Fixes: e67a61614d0b ("bus/fslmc: support device iterati
This patches fixes a null pointer derefencing that happens
when the device string passed to the iterator is NULL. This
situation can happen when iterating on a class type.
For example:
RTE_DEV_FOREACH(dev, "class=eth", &dev_iter) {
...
}
Fixes: e79df833d3f6 ("bus/dpaa: support hotplug ops")
C
1 - 100 of 161 matches
Mail list logo
