[dpdk-dev] [DPDK] net/iavf: release port upon close

2020-08-11 Thread SteveX Yang
Set RTE_ETH_DEV_CLOSE_REMOVE upon probe so all the private resources for the port can be freed by rte_eth_dev_close(). Signed-off-by: SteveX Yang --- drivers/net/iavf/iavf_ethdev.c | 43 -- 1 file changed, 25 insertions(+), 18 deletions(-) diff --git a/drivers/ne

[dpdk-dev] [PATCH] net/iavf: release port upon close

2020-08-11 Thread SteveX Yang
Set RTE_ETH_DEV_CLOSE_REMOVE upon probe so all the private resources for the port can be freed by rte_eth_dev_close(). Signed-off-by: SteveX Yang --- drivers/net/iavf/iavf_ethdev.c | 43 -- 1 file changed, 25 insertions(+), 18 deletions(-) diff --git a/drivers/ne

[dpdk-dev] [PATCH v2] net/virtio: fix 57f90f8("net/virtio: reuse packed ring functions")

2020-08-11 Thread Vipul Ashri
tx packets are not going out and standard tx path is not working due to cleanup malfunctioning. Signed-off-by: Vipul Ashri --- drivers/net/virtio/virtqueue.h | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/net/virtio/virtqueue.h b/drivers/net/virtio/virtqueue.h

[dpdk-dev] [PATCH 0/7] Bugs Porting from I40evf For IAVF Feature

2020-08-11 Thread SteveX Yang
These patches are bugs porting from i40evf to iavf. [PATCH 1/7] net/iavf: fix scattered Rx enabling [PATCH 2/7] net/iavf: set speed to undefined for default case [PATCH 3/7] net/iavf: fix port start during configuration restore [PATCH 4/7] net/iavf: fix setting of MAC address on iavf [PA

[dpdk-dev] [PATCH 1/7] net/iavf: fix scattered Rx enabling

2020-08-11 Thread SteveX Yang
No need to add additional vlan tag size for max packet size, since for i40e, the queue's Rx Max Frame Size (rxq->max_pkt_len) already includes the vlan header size. Fixes: 69dd4c3d0898 ("net/avf: enable queue and device") Signed-off-by: SteveX Yang --- drivers/net/iavf/iavf_ethdev.c | 2 +- 1 f

[dpdk-dev] [PATCH 2/7] net/iavf: set speed to undefined for default case

2020-08-11 Thread SteveX Yang
During PF/VF link update, a default speed value of 100M will be set if get_link_info has failed or speed is unknown. Consequently if PF is put in no-carrier state, VFs will switch to "in carrier" state due to a link up + a link speed set to 100M (default value if no speed detected). To be consist

[dpdk-dev] [PATCH 3/7] net/iavf: fix port start during configuration restore

2020-08-11 Thread SteveX Yang
If configuring VF promiscuous mode is not supported, return -ENOTSUP error code in .promiscuous_enable/disable dev_ops. This is to fix the port start during configuration restore, where if .promiscuous_enable/disable dev_ops exists and return any value other than -ENOTSUP, start will fail. Same is

[dpdk-dev] [PATCH 4/7] net/iavf: fix setting of MAC address on iavf

2020-08-11 Thread SteveX Yang
When setting the MAC address, the ethdev layer copies the new mac address in dev->data->mac_addrs[0] before calling the dev_ops. Therefore, is_same_ether_addr(mac_addr, dev->data->mac_addrs) was always true, and the MAC was never set. Remove this test to fix the issue. Fixes: 538da7a1cad2 ("net:

[dpdk-dev] [PATCH 7/7] net/iavf: fix port close

2020-08-11 Thread SteveX Yang
Port reset will call iavf_dev_uninit() to release resources. It wants to call iavf_dev_close() to release resources. So there will be a call conflict if calling iavf_dev_reset() and iavf_dev_close() at the same time. This patch added adapter->closed flag in iavf_dev_close() to control the status o

[dpdk-dev] [PATCH 6/7] net/iavf: downgrade error log

2020-08-11 Thread SteveX Yang
When receiving the unsupported AQ messages, it's taken as an error. It's not appropriate and triggers too much unnecessary print. Fixes: 22b123a36d07 ("net/avf: initialize PMD") Signed-off-by: SteveX Yang --- drivers/net/iavf/iavf_vchnl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) d

[dpdk-dev] [PATCH 5/7] net/iavf: fix multiple interrupts for VF

2020-08-11 Thread SteveX Yang
Interrupt mapping should be 1:n queue(s).This patch fixes the logic of interrupt bind by code reconstruction. Fixes: 69dd4c3d0898 ("net/avf: enable queue and device") Signed-off-by: SteveX Yang --- drivers/net/iavf/iavf_vchnl.c | 56 --- 1 file changed, 45 insert

[dpdk-dev] [PATCH v9 02/24] ethdev: add a link status text representation

2020-08-11 Thread Ivan Dyukov
Link status structure keeps complicated values which are hard to represent to end user. e.g. link_speed has INT_MAX value which means that speed is unknown, link_duplex equal to 0 means 'half-duplex' etc. To simplify processing of the values in application, new dpdk function is introduced. This co

[dpdk-dev] [PATCH v9 00/24] ethdev: allow unknown link speed

2020-08-11 Thread Ivan Dyukov
MAINTAINERS | 1 + app/proc-info/main.c | 9 +- app/test-pipeline/init.c | 11 ++- app/test-pmd/config.c| 20 +++-- app/test-pmd/testpmd.c

[dpdk-dev] [PATCH v9 01/24] ethdev: allow unknown link speed

2020-08-11 Thread Ivan Dyukov
From: Thomas Monjalon When querying the link information, the link status is a mandatory major information. Other boolean values are supposed to be accurate: - duplex mode (half/full) - negotiation (auto/fixed) This API update is making explicit that the link speed information is

[dpdk-dev] [PATCH v9 03/24] app: UNKNOWN link speed print

2020-08-11 Thread Ivan Dyukov
Add usage of rte_eth_link_to_str function to example applications and docs Signed-off-by: Ivan Dyukov --- app/proc-info/main.c | 13 ++- app/test-pipeline/init.c | 11 - app/test-pmd/config.c | 23 -

[dpdk-dev] [PATCH v9 06/24] net/ice: return unknown speed in status

2020-08-11 Thread Ivan Dyukov
rte_ethdev has declared new NUM_UNKNOWN speed which could be used in case when no speed information is available and link is up. NUM_NONE should be returned, if link is down. Signed-off-by: Ivan Dyukov Reviewed-by: Ferruh Yigit --- drivers/net/ice/ice_ethdev.c | 5 - 1 file changed, 4 inser

[dpdk-dev] [PATCH v9 04/24] net/ixgbe: return unknown speed in status

2020-08-11 Thread Ivan Dyukov
rte_ethdev has declared new NUM_UNKNOWN speed which could be used in case when no speed information is available Signed-off-by: Ivan Dyukov Reviewed-by: Wei Zhao --- drivers/net/ixgbe/ixgbe_ethdev.c | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/drivers/net/ixgbe/ixgbe

[dpdk-dev] [PATCH v9 05/24] net/i40e: return unknown speed in status

2020-08-11 Thread Ivan Dyukov
rte_ethdev has declared new NUM_UNKNOWN speed which could be used in case when no speed information is available and link is up. NUM_NONE should be returned, if link is down. Signed-off-by: Ivan Dyukov Acked-by: Jeff Guo --- drivers/net/i40e/i40e_ethdev.c| 5 - drivers/net/i40e/i40e_et

[dpdk-dev] [PATCH v9 08/24] examples/bbdev_app: new link status print format

2020-08-11 Thread Ivan Dyukov
Add usage of rte_eth_link_to_str function to example applications Signed-off-by: Ivan Dyukov --- examples/bbdev_app/main.c | 9 - 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/examples/bbdev_app/main.c b/examples/bbdev_app/main.c index 68a46050c..2eff5441a 100644 --- a/ex

[dpdk-dev] [PATCH v9 10/24] examples/ip_*: new link status print format

2020-08-11 Thread Ivan Dyukov
Add usage of rte_eth_link_to_str function to example applications: * ip_fragmentation * ip_reassembly * l3fwd-acl Signed-off-by: Ivan Dyukov --- examples/ip_fragmentation/main.c | 13 + examples/ip_reassembly/main.c| 13 + examples/l3fwd-acl/ma

[dpdk-dev] [PATCH v9 07/24] examples: new link status print format

2020-08-11 Thread Ivan Dyukov
Add usage of rte_eth_link_to_str function to example applications: * ipv4_multicast * l2fwd-jobstats * l2fwd-keepalive * l3fwd * link_status_interrupt Signed-off-by: Ivan Dyukov --- examples/ipv4_multicast/main.c| 14 ++-- examples/l2fwd-jo

[dpdk-dev] [PATCH v9 09/24] examples/ioat: new link status print format

2020-08-11 Thread Ivan Dyukov
Add usage of rte_eth_link_to_str function to example applications Signed-off-by: Ivan Dyukov --- examples/ioat/ioatfwd.c | 14 ++ 1 file changed, 6 insertions(+), 8 deletions(-) diff --git a/examples/ioat/ioatfwd.c b/examples/ioat/ioatfwd.c index b66ee73bc..bb8cff7c1 100644 --- a/ex

[dpdk-dev] [PATCH v9 11/24] examples/ip_pipeline: new link status print format

2020-08-11 Thread Ivan Dyukov
Add usage of rte_eth_link_to_str function to example applications Signed-off-by: Ivan Dyukov --- examples/ip_pipeline/cli.c | 12 +++- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/examples/ip_pipeline/cli.c b/examples/ip_pipeline/cli.c index d79699e2e..236553aae 100644 -

[dpdk-dev] [PATCH v9 14/24] examples/l2fwd-crypt: new link status print format

2020-08-11 Thread Ivan Dyukov
Add usage of rte_eth_link_to_str function to example applications Signed-off-by: Ivan Dyukov --- examples/l2fwd-crypto/main.c | 12 1 file changed, 4 insertions(+), 8 deletions(-) diff --git a/examples/l2fwd-crypto/main.c b/examples/l2fwd-crypto/main.c index 827da9b3e..da3b12f4f 10

[dpdk-dev] [PATCH v9 15/24] examples/l2fwd-event: new link status print format

2020-08-11 Thread Ivan Dyukov
Add usage of rte_eth_link_to_str function to example applications Signed-off-by: Ivan Dyukov --- examples/l2fwd-event/main.c | 13 + 1 file changed, 5 insertions(+), 8 deletions(-) diff --git a/examples/l2fwd-event/main.c b/examples/l2fwd-event/main.c index 4fe500333..f43b61daf 1006

[dpdk-dev] [PATCH v9 12/24] examples/ipsec-secgw: new link status print format

2020-08-11 Thread Ivan Dyukov
Add usage of rte_eth_link_to_str function to example applications Signed-off-by: Ivan Dyukov --- examples/ipsec-secgw/ipsec-secgw.c | 13 + 1 file changed, 5 insertions(+), 8 deletions(-) diff --git a/examples/ipsec-secgw/ipsec-secgw.c b/examples/ipsec-secgw/ipsec-secgw.c index f77

[dpdk-dev] [PATCH v9 13/24] examples/kni: new link status print format

2020-08-11 Thread Ivan Dyukov
Add usage of rte_eth_link_to_str function to example applications Signed-off-by: Ivan Dyukov --- examples/kni/main.c | 26 +- 1 file changed, 9 insertions(+), 17 deletions(-) diff --git a/examples/kni/main.c b/examples/kni/main.c index f5d12a5b8..f1045b284 100644 --- a/e

[dpdk-dev] [PATCH v9 17/24] examples/l3fwd-graph: new link status print format

2020-08-11 Thread Ivan Dyukov
Add usage of rte_eth_link_to_str function to example applications Signed-off-by: Ivan Dyukov --- examples/l3fwd-graph/main.c | 15 +-- 1 file changed, 5 insertions(+), 10 deletions(-) diff --git a/examples/l3fwd-graph/main.c b/examples/l3fwd-graph/main.c index c70270c4d..ccf55859f 1

[dpdk-dev] [PATCH v9 16/24] examples/l2fwd: new link status print format

2020-08-11 Thread Ivan Dyukov
Add usage of rte_eth_link_to_str function to example applications Signed-off-by: Ivan Dyukov --- examples/l2fwd/main.c | 13 + 1 file changed, 5 insertions(+), 8 deletions(-) diff --git a/examples/l2fwd/main.c b/examples/l2fwd/main.c index e04c601b5..b229a760a 100644 --- a/examples/

[dpdk-dev] [PATCH v9 18/24] examples/l3fwd-power: new link status print format

2020-08-11 Thread Ivan Dyukov
Add usage of rte_eth_link_to_str function to example applications Signed-off-by: Ivan Dyukov --- examples/l3fwd-power/main.c | 14 +- 1 file changed, 5 insertions(+), 9 deletions(-) diff --git a/examples/l3fwd-power/main.c b/examples/l3fwd-power/main.c index 9db94ce04..ff862fbc8 100

[dpdk-dev] [PATCH v9 21/24] example/performance*: new link status print format

2020-08-11 Thread Ivan Dyukov
Add usage of rte_eth_link_to_str function to example applications Signed-off-by: Ivan Dyukov --- examples/performance-thread/l3fwd-thread/main.c | 13 + 1 file changed, 5 insertions(+), 8 deletions(-) diff --git a/examples/performance-thread/l3fwd-thread/main.c b/examples/performan

[dpdk-dev] [PATCH v9 19/24] examples/multi_proc*: new link status print format

2020-08-11 Thread Ivan Dyukov
Add usage of rte_eth_link_to_str function to example applications Signed-off-by: Ivan Dyukov --- .../client_server_mp/mp_server/init.c | 15 ++- examples/multi_process/symmetric_mp/main.c| 13 + 2 files changed, 11 insertions(+), 17 deletions(-) diff

[dpdk-dev] [PATCH v9 22/24] examples/qos_sched: new link status print format

2020-08-11 Thread Ivan Dyukov
Add usage of rte_eth_link_to_str function to example applications Signed-off-by: Ivan Dyukov --- examples/qos_sched/init.c | 13 + 1 file changed, 5 insertions(+), 8 deletions(-) diff --git a/examples/qos_sched/init.c b/examples/qos_sched/init.c index 9626c15b8..99521bc4a 100644 ---

[dpdk-dev] [PATCH v9 20/24] examples/ntb: new link status print format

2020-08-11 Thread Ivan Dyukov
Add usage of rte_eth_link_strf function to example applications Signed-off-by: Ivan Dyukov --- examples/ntb/ntb_fwd.c | 11 ++- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/examples/ntb/ntb_fwd.c b/examples/ntb/ntb_fwd.c index eba8ebf9f..abb05a612 100644 --- a/examples/n

[dpdk-dev] [PATCH v9 23/24] examples/server_nod*: new link status print format

2020-08-11 Thread Ivan Dyukov
Add usage of rte_eth_link_to_str function to example applications Signed-off-by: Ivan Dyukov --- examples/server_node_efd/server/init.c | 15 +-- 1 file changed, 5 insertions(+), 10 deletions(-) diff --git a/examples/server_node_efd/server/init.c b/examples/server_node_efd/server/i

[dpdk-dev] [PATCH v9 24/24] examples/vm_power_*: new link status print format

2020-08-11 Thread Ivan Dyukov
Add usage of rte_eth_link_to_str function to example applications Signed-off-by: Ivan Dyukov --- examples/vm_power_manager/main.c | 14 +- 1 file changed, 5 insertions(+), 9 deletions(-) diff --git a/examples/vm_power_manager/main.c b/examples/vm_power_manager/main.c index 273bfec29

[dpdk-dev] [PATCH] net/i40e: i40evf exposes LSC flag to application.

2020-08-11 Thread SteveX Yang
When PF event VIRTCHNL_EVENT_LINK_CHANGE recevied, i40evf need update the link status, and issue RTE_ETH_EVENT_INTR_LSC via _rte_eth_dev_callback_process(). Signed-off-by: SteveX Yang --- drivers/net/i40e/i40e_ethdev_vf.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a

[dpdk-dev] [PATCH] net/i40e: i40evf exposes LSC flag to application.

2020-08-11 Thread SteveX Yang
When PF event VIRTCHNL_EVENT_LINK_CHANGE received, i40evf need update the link status and issue RTE_ETH_EVENT_INTR_LSC via _rte_eth_dev_callback_process(). Signed-off-by: SteveX Yang --- drivers/net/i40e/i40e_ethdev_vf.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/

Re: [dpdk-dev] [EXT] [PATCH v2] tracepoint: fix compilation with C++

2020-08-11 Thread Sunil Kumar Kori
Hello Pawel, Few suggestions: 1. use 'trace' instead of 'tracepoint' in subject line. i.e. "trace: fix compilation with C++" 1. Update change history. 2. Add Fixes tag. 3. Superseed the previous version of this fix. Reference: http://patches.dpdk.org/patch/66396/ Rest Looks okay. Please submit n

[dpdk-dev] [PATCH v2] version: 20.11-rc0

2020-08-11 Thread Thomas Monjalon
Start a new release cycle with empty release notes. The ABI version becomes 21.0. The map files are updated to the new ABI major number (21). Travis ABI check is disabled because compatibility is not preserved. Signed-off-by: Thomas Monjalon --- v2: bump major ABI number (including .map changes)

[dpdk-dev] [PATCH v3 1/2] version: 20.11-rc0

2020-08-11 Thread Thomas Monjalon
Start a new release cycle with empty release notes. The ABI version becomes 21.0. The ABI major is back to normal, having only one number (21 vs 20.0). The map files are updated to the new ABI major number (21). Travis ABI check is disabled because compatibility is not preserved. Signed-off-by: T

[dpdk-dev] [PATCH v3 2/2] devtools: fix ABI update in map files

2020-08-11 Thread Thomas Monjalon
The script was using the full ABI version, including the minor number, to version the symbols in the map files. It is fixed to use only the major number for symbol versioning. Signed-off-by: Thomas Monjalon --- devtools/update_version_map_abi.py | 7 --- 1 file changed, 4 insertions(+), 3 de

[dpdk-dev] [PATCH RFC 0/1] net/af_xdp: shared UMEM support

2020-08-11 Thread Ciara Loftus
This RFC integrates shared UMEM support into the AF_XDP PMD. It is based on the WIP kernel series [1] by Magnus Karlsson. Detailed information on the shared UMEM feature can be found in the final patch in the aforementioned series. Support for the kernel feature can eventually be detected in DPDK

[dpdk-dev] [PATCH RFC 1/1] net/af_xdp: shared UMEM support

2020-08-11 Thread Ciara Loftus
A future kernel will introduce the ability to efficiently share a UMEM between AF_XDP sockets bound to different queue ids on the same or different devices. This patch integrates that functionality into the AF_XDP PMD. A PMD will attempt to share a UMEM with others if the shared_umem=1 vdev arg is

[dpdk-dev] [RFC v2 1/5] eal: add power management intrinsics

2020-08-11 Thread Liang Ma
Add two new power management intrinsics, and provide an implementation in eal/x86 based on UMONITOR/UMWAIT instructions. The instructions are implemented as raw byte opcodes because there is not yet widespread compiler support for these instructions. The power management instructions provide an ar

[dpdk-dev] [RFC v2 2/5] ethdev: add simple power management API and callback

2020-08-11 Thread Liang Ma
Add a simple on/off switch that will enable saving power when no packets are arriving. It is based on counting the number of empty polls and, when the number reaches a certain threshold, entering an architecture-defined optimized power state that will either wait until a TSC timestamp expires, or w

[dpdk-dev] [RFC v2 4/5] net/i40e: implement power management API

2020-08-11 Thread Liang Ma
Implement support for the power management API by implementing a `next_rx_desc` function that will return an address of an RX ring's status bit. Signed-off-by: Liang Ma Signed-off-by: Anatoly Burakov --- drivers/net/i40e/i40e_ethdev.c | 1 + drivers/net/i40e/i40e_rxtx.c | 23

[dpdk-dev] [RFC v2 3/5] net/ixgbe: implement power management API

2020-08-11 Thread Liang Ma
Implement support for the power management API by implementing a `next_rx_desc` function that will return an address of an RX ring's status bit. Signed-off-by: Anatoly Burakov Signed-off-by: Liang Ma --- drivers/net/ixgbe/ixgbe_ethdev.c | 1 + drivers/net/ixgbe/ixgbe_rxtx.c | 22

[dpdk-dev] [RFC v2 5/5] net/ice: implement power management API

2020-08-11 Thread Liang Ma
Implement support for the power management API by implementing a `next_rx_desc` function that will return an address of an RX ring's status bit. Signed-off-by: Liang Ma Signed-off-by: Anatoly Burakov --- drivers/net/ice/ice_ethdev.c | 1 + drivers/net/ice/ice_rxtx.c | 23

Re: [dpdk-dev] [PATCH v9 02/24] ethdev: add a link status text representation

2020-08-11 Thread Gaëtan Rivet
On 11/08/20 11:52 +0300, Ivan Dyukov wrote: > Link status structure keeps complicated values which are hard to > represent to end user. e.g. link_speed has INT_MAX value which > means that speed is unknown, link_duplex equal to 0 means > 'half-duplex' etc. To simplify processing of the values > in

[dpdk-dev] [PATCH v4 2/2] devtools: fix ABI update in map files

2020-08-11 Thread Thomas Monjalon
The script was using the full ABI version, including the minor number, to version the symbols in the map files. It is fixed to use only the major number for symbol versioning. Signed-off-by: Thomas Monjalon --- devtools/update_version_map_abi.py | 7 --- 1 file changed, 4 insertions(+), 3 de

[dpdk-dev] [PATCH v4 1/2] version: 20.11-rc0

2020-08-11 Thread Thomas Monjalon
Start a new release cycle with empty release notes. The ABI version becomes 21.0. The ABI major is back to normal, having only one number (21 vs 20.0). The map files are updated to the new ABI major number (21). The ABI exceptions specific to previous major version are dropped. Travis ABI check is

[dpdk-dev] [PATCH v4 3/8] net/dpaa: add support for fmcless mode

2020-08-11 Thread Hemant Agrawal
From: Sachin Saxena This patch uses fmlib to configure the FMAN HW for flow and distribution configuration, thus avoiding the need for static FMC tool execution optionally. Signed-off-by: Sachin Saxena Signed-off-by: Hemant Agrawal --- drivers/net/dpaa/Makefile | 1 + drivers/net/dpaa/

[dpdk-dev] [PATCH v4 2/8] net/dpaa: add VSP support in FMLIB

2020-08-11 Thread Hemant Agrawal
From: Jun Yang This patch adds support for VSP (Virtual Storage Profile) in fmlib routines. VSP allow a network interface to be divided into physical and virtual instance(s). The concept is very similar to SRIOV. Signed-off-by: Jun Yang Acked-by: Hemant Agrawal --- drivers/net/dpaa/Makefile

[dpdk-dev] [PATCH v4 5/8] bus/dpaa: add Virtual Storage Profile port init

2020-08-11 Thread Hemant Agrawal
This patch add support to initialize the VSP ports in the FMAN library. Signed-off-by: Hemant Agrawal --- drivers/bus/dpaa/base/fman/fman.c | 57 +++ drivers/bus/dpaa/include/fman.h | 3 ++ 2 files changed, 60 insertions(+) diff --git a/drivers/bus/dpaa/base/fman/

[dpdk-dev] [PATCH v4 4/8] bus/dpaa: add shared MAC support

2020-08-11 Thread Hemant Agrawal
From: Radu Bulie A shared MAC interface is an interface which can be used by both kernel and userspace based on classification configuration It is defined in dts with the compatible string "fsl,dpa-ethernet-shared" which bpool will be seeded by the dpdk partition and configured as a netdev by the

[dpdk-dev] [PATCH v4 6/8] net/dpaa: add support for Virtual Storage Profile

2020-08-11 Thread Hemant Agrawal
From: Jun Yang This patch adds support for Virtual Storage profile (VSP) feature. With VSP support when memory pool is created, the hw buffer pool id i.e. bpid is not allocated; thhe bpid is identified by dpaa flow create API. The memory pool of RX queue is attached to specific BMan pool accordin

[dpdk-dev] [PATCH v4 7/8] net/dpaa: add fmc parser support for VSP

2020-08-11 Thread Hemant Agrawal
From: Jun Yang Parse the fmc.bin generated by fmc to setup RXQs for each port on fmc mode. The parser gets the fqids and vspids from fmc.bin. Signed-off-by: Jun Yang Acked-by: Hemant Agrawal --- drivers/net/dpaa/Makefile | 1 + drivers/net/dpaa/dpaa_ethdev.c | 26 +- drivers/net/dpaa/

[dpdk-dev] [PATCH v4 8/8] net/dpaa: add RSS update func with FMCless

2020-08-11 Thread Hemant Agrawal
From: Sachin Saxena With fmlib (FMCLESS) mode now RSS can be modified on runtime. This patch add support for RSS update functions Signed-off-by: Hemant Agrawal Signed-off-by: Sachin Saxena --- drivers/net/dpaa/dpaa_ethdev.c | 37 ++ 1 file changed, 37 insertion

Re: [dpdk-dev] [PATCH v9 02/24] ethdev: add a link status text representation

2020-08-11 Thread Ivan Dyukov
11.08.2020 14:02, Gaëtan Rivet пишет: > On 11/08/20 11:52 +0300, Ivan Dyukov wrote: >> Link status structure keeps complicated values which are hard to >> represent to end user. e.g. link_speed has INT_MAX value which >> means that speed is unknown, link_duplex equal to 0 means >> 'half-duplex' etc

Re: [dpdk-dev] [PATCH v9 02/24] ethdev: add a link status text representation

2020-08-11 Thread Gaëtan Rivet
On 11/08/20 15:48 +0300, Ivan Dyukov wrote: > 11.08.2020 14:02, Gaëtan Rivet пишет: > > On 11/08/20 11:52 +0300, Ivan Dyukov wrote: > >> Link status structure keeps complicated values which are hard to > >> represent to end user. e.g. link_speed has INT_MAX value which > >> means that speed is unkn

Re: [dpdk-dev] [PATCH v9 02/24] ethdev: add a link status text representation

2020-08-11 Thread Ivan Dyukov
11.08.2020 15:53, Gaëtan Rivet пишет: > On 11/08/20 15:48 +0300, Ivan Dyukov wrote: >> 11.08.2020 14:02, Gaëtan Rivet пишет: >>> On 11/08/20 11:52 +0300, Ivan Dyukov wrote: Link status structure keeps complicated values which are hard to represent to end user. e.g. link_speed has INT_MAX

Re: [dpdk-dev] [EXT] [PATCH v2] tracepoint: fix compilation with C++

2020-08-11 Thread Pawel Wodkowski
Hi Sunil, I finished porting app to DPDK 20.05 and I'm afraid that I can't do anything more here as I don't have proper development environment anymore nor the time for setting it up again. If you find this change useful please take over it. Otherwise there will be long time before I can send nex

Re: [dpdk-dev] [PATCH v4 1/2] version: 20.11-rc0

2020-08-11 Thread Kinsella, Ray
Hi Thomas, On 11/08/2020 12:27, Thomas Monjalon wrote: > Start a new release cycle with empty release notes. > > The ABI version becomes 21.0. > The ABI major is back to normal, having only one number (21 vs 20.0). > The map files are updated to the new ABI major number (21). > The ABI exceptions

[dpdk-dev] [PATCH v5 1/2] version: 20.11-rc0

2020-08-11 Thread Thomas Monjalon
Start a new release cycle with empty release notes. The ABI version becomes 21.0. The ABI major is back to normal, having only one number (21 vs 20.0). The map files are updated to the new ABI major number (21). The ABI exceptions are dropped. Travis ABI check is disabled because compatibility is

[dpdk-dev] [PATCH v5 2/2] devtools: fix ABI update in map files

2020-08-11 Thread Thomas Monjalon
The script was using the full ABI version, including the minor number, to version the symbols in the map files. It is fixed to use only the major number for symbol versioning. Signed-off-by: Thomas Monjalon --- devtools/update_version_map_abi.py | 7 --- 1 file changed, 4 insertions(+), 3 de

Re: [dpdk-dev] [PATCH v4 1/2] version: 20.11-rc0

2020-08-11 Thread Thomas Monjalon
11/08/2020 15:47, Kinsella, Ray: > On 11/08/2020 12:27, Thomas Monjalon wrote: > > --- a/devtools/libabigail.abignore > > +++ b/devtools/libabigail.abignore > > @@ -8,12 +8,6 @@ > > [suppress_variable] > > symbol_version = INTERNAL > > > > -; Ignore ABI 20.0.1 replaced with ABI 21 > > -

[dpdk-dev] [PATCH] doc: add section describing new abi versions

2020-08-11 Thread Ray Kinsella
Added a section describing new abi versions, this provides pointers to the relevant amended rules that apply during the abi breakage window. Also remove the large note a the head of the abi policy describing the abi stability process that has taken place over the previous year. Signed-off-by: Ray

[dpdk-dev] [PATCH v1] net/ice: optimize the Rx metadata hardware check

2020-08-11 Thread Haiyue Wang
Only check the hardware support when the user specifies the 'proto_xtr' feature. And not require all the types need to be support in hardware, so that if new protocol extraction type is introduced, just check it as needed. Also the ice Rx metadata can also support protocol offset metadata, not onl

Re: [dpdk-dev] [PATCH 2/4] bus/vmbus: remove vmbus_send_interrupt

2020-08-11 Thread Stephen Hemminger
On Mon, 10 Aug 2020 19:33:12 -0700 lon...@linuxonhyperv.com wrote: > From: Long Li > > netvsc is a high speed VMBus device that uses monitor bit to signal the > host. It's not necessary to send interrupts via INT bit. > > Signed-off-by: Long Li Acked-by: Stephen Hemminger

Re: [dpdk-dev] [PATCH 3/4] net/netvsc: mark chim_index as NVS_CHIM_IDX_INVALID after freeing it

2020-08-11 Thread Stephen Hemminger
On Mon, 10 Aug 2020 19:33:13 -0700 lon...@linuxonhyperv.com wrote: > From: Long Li > > chim_index could potentially be used in other hn_txdesc when re-allocated. > Mark it as invalid to prevent stale value being used. > > Signed-off-by: Long Li Acked-by: Stephen Hemminger

Re: [dpdk-dev] [PATCH 4/4] net/netvsc: check for overflow on packet info from host

2020-08-11 Thread Stephen Hemminger
On Mon, 10 Aug 2020 19:33:14 -0700 lon...@linuxonhyperv.com wrote: > From: Stephen Hemminger > > The data from the host is trusted but checked by the driver. > One check that is missing is that the packet offset and length > might cause wraparound. > > Cc: sta...@dpdk.org > > Signed-off-by: St

Re: [dpdk-dev] [PATCH v9 02/24] ethdev: add a link status text representation

2020-08-11 Thread Stephen Hemminger
On Tue, 11 Aug 2020 11:52:21 +0300 Ivan Dyukov wrote: > Link status structure keeps complicated values which are hard to > represent to end user. e.g. link_speed has INT_MAX value which > means that speed is unknown, link_duplex equal to 0 means > 'half-duplex' etc. To simplify processing of the

Re: [dpdk-dev] [PATCH v5 1/2] version: 20.11-rc0

2020-08-11 Thread Kinsella, Ray
Hi Thomas, In general it looks good, however you are letting the old version node DPDK_20.0 linger in a few places. We need to include an explicit FYI to tidy this up. Remove versioning code: Cryptodev Fiona Trahe Arek Kusztal Mempool Olivier Matz Remove alias to experimental: Metering F

[dpdk-dev] [PATCH] doc: add section describing new abi versions

2020-08-11 Thread Ray Kinsella
Added a section describing new abi versions, this provides pointers to the relevant amended rules that apply during the abi breakage window. Also remove the large note a the head of the abi policy describing the abi stability process that has taken place over the previous year. Signed-off-by: Ray

[dpdk-dev] [PATCH v3] doc: add section describing new abi versions

2020-08-11 Thread Ray Kinsella
Added a section describing new abi versions, this provides pointers to the relevant amended rules that apply during the abi breakage window. Also remove the large note a the head of the abi policy describing the abi stability process that has taken place over the previous year. Signed-off-by: Ray

Re: [dpdk-dev] [PATCH 01/27] eventdev: dlb upstream prerequisites

2020-08-11 Thread Jerin Jacob
On Fri, Jul 31, 2020 at 1:23 AM McDaniel, Timothy wrote: > > From: "McDaniel, Timothy" Please change to "McDaniel Timothy " > > The DLB hardware does not conform exactly to the eventdev interface. > 1) It has a limit on the number of queues that may be linked to a port. > 2) Some ports a furth

Re: [dpdk-dev] [PATCH 02/27] eventdev: do not pass disable_implicit_release bit to trace macro

2020-08-11 Thread Jerin Jacob
On Fri, Jul 31, 2020 at 1:23 AM McDaniel, Timothy wrote: > > From: "McDaniel, Timothy" > > Previous implementation traced u8 disable_impl_release, which > is now a bit field contained in the new u32 event_port_cfg > field. > > Signed-off-by: McDaniel, Timothy > --- > lib/librte_eventdev/rte_eve

Re: [dpdk-dev] [PATCH v9 02/24] ethdev: add a link status text representation

2020-08-11 Thread Ivan Dyukov
11.08.2020 18:47, Stephen Hemminger пишет: > On Tue, 11 Aug 2020 11:52:21 +0300 > Ivan Dyukov wrote: > >> Link status structure keeps complicated values which are hard to >> represent to end user. e.g. link_speed has INT_MAX value which >> means that speed is unknown, link_duplex equal to 0 means

Re: [dpdk-dev] [EXT] [PATCH 03/27] event/dlb: add shared code version 10.7.9

2020-08-11 Thread Jerin Jacob Kollanukkaran
> -Original Message- > From: McDaniel, Timothy > Sent: Friday, July 31, 2020 1:20 AM > To: Jerin Jacob Kollanukkaran > Cc: mattias.ronnb...@ericsson.com; dev@dpdk.org; gage.e...@intel.com; > harry.van.haa...@intel.com; McDaniel, Timothy > > Subject: [EXT] [PATCH 03/27] event/dlb: add s

Re: [dpdk-dev] [PATCH 04/27] event/dlb: add make and meson build infrastructure

2020-08-11 Thread Jerin Jacob
On Fri, Jul 31, 2020 at 1:23 AM McDaniel, Timothy wrote: > > From: "McDaniel, Timothy" > > Signed-off-by: McDaniel, Timothy > --- > config/common_base| 19 ++- > config/rte_config.h |8 +++- > drivers/event/Makefile|7 +++ > driver

Re: [dpdk-dev] [PATCH 05/27] event/dlb: add DLB documentation

2020-08-11 Thread Jerin Jacob
On Fri, Jul 31, 2020 at 1:24 AM McDaniel, Timothy wrote: > > From: "McDaniel, Timothy" > > Signed-off-by: McDaniel, Timothy > --- > doc/guides/eventdevs/dlb.rst | 343 > ++ > 1 file changed, 343 insertions(+) > create mode 100644 doc/guides/eventdevs/d

Re: [dpdk-dev] [PATCH 06/27] event/dlb: add dynamic logging

2020-08-11 Thread Jerin Jacob
On Fri, Jul 31, 2020 at 1:24 AM McDaniel, Timothy wrote: > > From: "McDaniel, Timothy" Please avoid empty comments. > > Signed-off-by: McDaniel, Timothy > --- > drivers/event/dlb/dlb_log.h | 25 + > 1 file changed, 25 insertions(+) > create mode 100644 drivers/event

Re: [dpdk-dev] [PATCH 1/4] test/stack: avoid trivial memory allocations

2020-08-11 Thread Eads, Gage
Hi Steven, > -Original Message- > From: Steven Lariau > Sent: Wednesday, August 5, 2020 10:57 AM > To: Eads, Gage ; Olivier Matz > > Cc: dev@dpdk.org; honnappa.nagaraha...@arm.com; > dharmik.thak...@arm.com; n...@arm.com; Steven Lariau > > Subject: [PATCH 1/4] test/stack: avoid trivial

Re: [dpdk-dev] [PATCH 2/4] test/stack: launch tests with mp remote launch API

2020-08-11 Thread Eads, Gage
> -Original Message- > From: Steven Lariau > Sent: Wednesday, August 5, 2020 10:57 AM > To: Eads, Gage ; Olivier Matz > > Cc: dev@dpdk.org; honnappa.nagaraha...@arm.com; > dharmik.thak...@arm.com; n...@arm.com; Steven Lariau > > Subject: [PATCH 2/4] test/stack: launch tests with mp remot

Re: [dpdk-dev] [PATCH 3/4] test/stack: propagate errors to main core

2020-08-11 Thread Eads, Gage
> -Original Message- > From: Steven Lariau > Sent: Wednesday, August 5, 2020 10:57 AM > To: Eads, Gage ; Olivier Matz > > Cc: dev@dpdk.org; honnappa.nagaraha...@arm.com; > dharmik.thak...@arm.com; n...@arm.com; Steven Lariau > > Subject: [PATCH 3/4] test/stack: propagate errors to mai

Re: [dpdk-dev] [PATCH 4/4] test/stack: remove atomics operations

2020-08-11 Thread Eads, Gage
> -Original Message- > From: Steven Lariau > Sent: Wednesday, August 5, 2020 10:57 AM > To: Eads, Gage ; Olivier Matz > > Cc: dev@dpdk.org; honnappa.nagaraha...@arm.com; > dharmik.thak...@arm.com; n...@arm.com; Steven Lariau > > Subject: [PATCH 4/4] test/stack: remove atomics operatio

Re: [dpdk-dev] [PATCH 1/4] test/stack: avoid trivial memory allocations

2020-08-11 Thread Stephen Hemminger
On Tue, 11 Aug 2020 20:13:24 + "Eads, Gage" wrote: > Hi Steven, > > > -Original Message- > > From: Steven Lariau > > Sent: Wednesday, August 5, 2020 10:57 AM > > To: Eads, Gage ; Olivier Matz > > > > Cc: dev@dpdk.org; honnappa.nagaraha...@arm.com; > > dharmik.thak...@arm.com; n...@

Re: [dpdk-dev] [PATCH 1/4] test/stack: avoid trivial memory allocations

2020-08-11 Thread Honnappa Nagarahalli
> > > > > > Replace the arguments array by one argument. > > > All objects in the args array have the same values, so there is no > > > need to use an array, only one struct is enough. > > > The args object is a lot smaller, and the allocation can be replaced > > > with a stack variable. > > > >

Re: [dpdk-dev] [PATCH] lib/metrics: fix memory leak

2020-08-11 Thread Honnappa Nagarahalli
> > fix memory leak > > Fixes: c5b7197f66 ("telemetry: move some functions to metrics library") > > Signed-off-by: Gaurav Singh > --- > lib/librte_metrics/rte_metrics_telemetry.c | 21 - > 1 file changed, 16 insertions(+), 5 deletions(-) > > diff --git a/lib/librte_metri

[dpdk-dev] [PATCH] doc: add stack mempool guide

2020-08-11 Thread Gage Eads
Signed-off-by: Gage Eads --- doc/guides/mempool/index.rst | 1 + doc/guides/mempool/stack.rst | 38 +++ doc/guides/prog_guide/mempool_lib.rst | 2 ++ doc/guides/prog_guide/stack_lib.rst | 4 4 files changed, 45 insertions(+) create mode

Re: [dpdk-dev] [PATCH 1/4] test/stack: avoid trivial memory allocations

2020-08-11 Thread Eads, Gage
> -Original Message- > From: Honnappa Nagarahalli > Sent: Tuesday, August 11, 2020 3:50 PM > To: Stephen Hemminger ; Eads, Gage > > Cc: Steven Lariau ; Olivier Matz > ; dev@dpdk.org; Dharmik Thakkar > ; nd ; Honnappa Nagarahalli > ; nd > Subject: RE: [dpdk-dev] [PATCH 1/4] test/stack:

[dpdk-dev] [dpdk-announce] git branches renamed

2020-08-11 Thread Thomas Monjalon
Following a decision from the Technical Board (http://mails.dpdk.org/archives/dev/2020-July/174483.html), some branch names have been renamed in some repositories. For instance, the "master" branch of the main repository becomes "main". Sorry for not announcing the change in advance. More branche

Re: [dpdk-dev] [PATCH 0/3] Add missing SPDX license tags

2020-08-11 Thread Stephen Hemminger
On Tue, 14 Jul 2020 16:50:08 -0700 Stephen Hemminger wrote: > Fix some recent gaps in SPDX license information. > > Stephen Hemminger (3): > eal/windows: add missing SPDX license tag > net/qede/base: add missing license information > doc: add missing SPDX license tags > > doc/guides/cust

Re: [dpdk-dev] [PATCH 0/7] proc-info enhancements

2020-08-11 Thread Stephen Hemminger
On Wed, 6 May 2020 12:37:34 -0700 Stephen Hemminger wrote: > The current proc-info command is useful for diagnosing issues > with external DPDK applications, but the display is limited > and somewhat ugly. This patchset adds some enhancements which > show more info and suppress unnecessary stuff

[dpdk-dev] [PATCH v2] net/ice: optimize the FlexiMD hardware check

2020-08-11 Thread Haiyue Wang
The Flexible Metadata #4 and #5 in the Rx Flex Descriptor are defined to extract the protocol specified fields or its offset. Its function relays on the DDP package support in hardware. Optimize to only check the hardware support when the user specifies the 'proto_xtr' devargs. And not require all

[dpdk-dev] [PATCH v2] net/ice: fix VF index check for DCF

2020-08-11 Thread Wei Zhao
The vf index in rte_flow command need to check in order that larger the actual number. Also change some error log for wrong action. Fixes: 829c3106812d ("net/ice: enable switch flow on DCF") Cc: sta...@dpdk.org Signed-off-by: Wei Zhao --- v2: change error log --- drivers/net/ice/ice_switch_fil

Re: [dpdk-dev] [PATCH 1/7] net/iavf: fix scattered Rx enabling

2020-08-11 Thread Xing, Beilei
> -Original Message- > From: Yang, SteveX > Sent: Tuesday, August 11, 2020 2:29 PM > To: Wu, Jingjing ; Xing, Beilei > ; > dev@dpdk.org > Cc: Yang, SteveX > Subject: [PATCH 1/7] net/iavf: fix scattered Rx enabling > > No need to add additional vlan tag size for max packet size, since

Re: [dpdk-dev] [PATCH v2] net/ice: fix VF index check for DCF

2020-08-11 Thread Lu, Nannan
> -Original Message- > From: Zhao1, Wei > Sent: Wednesday, August 12, 2020 8:57 AM > To: dev@dpdk.org > Cc: sta...@dpdk.org; Zhang, Qi Z ; Lu, Nannan > ; Zhao1, Wei > Subject: [PATCH v2] net/ice: fix VF index check for DCF > > The vf index in rte_flow command need to check in order that

Re: [dpdk-dev] [PATCH 7/7] net/iavf: fix port close

2020-08-11 Thread Wu, Jingjing
If RTE_ETH_DEV_CLOSE_REMOVE is set, port would be released when dev_close is called. So it is not necessary to mark it as closed. Another concern in my mind is the REST virtchnl message is missed to send to PF in iavf_dev_reset. Thanks Jingjing > -Original Message- > From: Yang, SteveX

  1   2   >