Re: [dpdk-dev] [PATCH v2 4/5] cryptodev: remove list ends from asymmetric crypto api

2020-10-09 Thread Kusztal, ArkadiuszX
Hi Akhil, > -Original Message- > From: Akhil Goyal > Sent: czwartek, 8 października 2020 21:51 > To: Kusztal, ArkadiuszX ; dev@dpdk.org > Cc: Trahe, Fiona ; ruifeng.w...@arm.com; > michae...@marvell.com > Subject: RE: [PATCH v2 4/5] cryptodev: remove list ends from asymmetric crypto > api

Re: [dpdk-dev] [PATCH] build: add -moutline-atomics to default Arm build

2020-10-09 Thread Ruifeng Wang
> -Original Message- > From: Thomas Monjalon > Sent: Friday, October 9, 2020 2:53 PM > To: Juraj Linkeš ; Ruifeng Wang > > Cc: bruce.richard...@intel.com; dev@dpdk.org; jer...@marvell.com; > Honnappa Nagarahalli ; nd > Subject: Re: [dpdk-dev] [PATCH] build: add -moutline-atomics to defa

Re: [dpdk-dev] [PATCH v2 2/2] net/virtio: check return from rte_raw_cksum_mbuf

2020-10-09 Thread Maxime Coquelin
On 10/1/20 12:22 PM, Chas Williams wrote: > rte_raw_cksum_mbuf can fail, so we should check to see if it > has. If so, return with an error. > > Fixes: 96cb6711939e ("net/virtio: support Rx checksum offload") > > Signed-off-by: Chas Williams <3ch...@gmail.com> > --- > drivers/net/virtio/virti

[dpdk-dev] [PATCH] eal: fix doxygen for EAL cleanup

2020-10-09 Thread David Marchand
Align rte_eal_cleanup return codes description to the rest of dpdk. Fixes: aec9c13c5257 ("eal: add function to release internal resources") Cc: sta...@dpdk.org Signed-off-by: David Marchand --- lib/librte_eal/include/rte_eal.h | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --g

Re: [dpdk-dev] [PATCH] vhost: fix external mbuf creation

2020-10-09 Thread Maxime Coquelin
On 10/7/20 2:53 PM, Olivier Matz wrote: > In virtio_dev_extbuf_alloc(), the shinfo structure used to store > the reference counter and the free callback of the external buffer > is by default stored inside the mbuf data. > > This is wrong because the mbuf (and its data) can be freed before > th

Re: [dpdk-dev] [PATCH 2/2] vhost: use fixed Virtio-net header len packed ring

2020-10-09 Thread Maxime Coquelin
Welcome back Chenbo, On 10/9/20 8:36 AM, Xia, Chenbo wrote: > Hi Maxime, > >> -Original Message- >> From: Maxime Coquelin >> Sent: Thursday, October 1, 2020 6:12 PM >> To: dev@dpdk.org; Xia, Chenbo ; Liu, Yong >> >> Cc: Maxime Coquelin >> Subject: [PATCH 2/2] vhost: use fixed Virtio-ne

Re: [dpdk-dev] [PATCH 0/2] Fix packed ring header len

2020-10-09 Thread Maxime Coquelin
On 10/1/20 12:11 PM, Maxime Coquelin wrote: > First patch is fixing packed ring header len. Issue was > reported by Marvin. > > Second patch is a (very) light optimization, to make used > directly of the static hdr len value in packed-ring only > functions. > > Maxime Coquelin (2): > vhost:

Re: [dpdk-dev] [PATCH] vhost: fix external mbuf creation

2020-10-09 Thread Maxime Coquelin
On 10/7/20 2:53 PM, Olivier Matz wrote: > In virtio_dev_extbuf_alloc(), the shinfo structure used to store > the reference counter and the free callback of the external buffer > is by default stored inside the mbuf data. > > This is wrong because the mbuf (and its data) can be freed before > th

Re: [dpdk-dev] [PATCH] eal: fix doxygen for EAL cleanup

2020-10-09 Thread David Marchand
On Fri, Oct 9, 2020 at 9:16 AM David Marchand wrote: > > Align rte_eal_cleanup return codes description to the rest of dpdk. > > Fixes: aec9c13c5257 ("eal: add function to release internal resources") > Cc: sta...@dpdk.org > > Signed-off-by: David Marchand > --- > lib/librte_eal/include/rte_eal.

Re: [dpdk-dev] [dpdk-dev v2 2/2] vhost/crypto: fix feature negotiation

2020-10-09 Thread Maxime Coquelin
On 10/2/20 5:36 PM, Fan Zhang wrote: > This patch fixes the feature negotiation for vhost crypto during > initialization. The patch uses the newly created driver start > function to inform the driver type with the fixed vhost features. > In addtion the patch provides a new API specifically used

Re: [dpdk-dev] [RFC v2 1/1] lib/ring: add scatter gather APIs

2020-10-09 Thread Olivier Matz
On Thu, Oct 08, 2020 at 08:44:13PM +, Honnappa Nagarahalli wrote: > > > > > > Hi Honnappa, > > > > From a quick walkthrough, I have some questions/comments, please see > > below. > Hi Olivier, appreciate your input. > > > > > On Tue, Oct 06, 2020 at 08:29:05AM -0500, Honnappa Nagarahalli

Re: [dpdk-dev] [dpdk-dev v2 2/2] vhost/crypto: fix feature negotiation

2020-10-09 Thread Maxime Coquelin
On 10/6/20 10:37 AM, Zhang, Roy Fan wrote: > Hi Maxime, > > Thanks I will verify it after you applied the patch. Thanks, Your patch is now on dpdk-next-virtio/main. I would be glad if you could test it before Ferruh merges it. Thanks, Maxime > Regards, > Fan > >> -Original Message-

[dpdk-dev] [PATCH] doc: update rel_notes for GRO

2020-10-09 Thread yang_y_yi
From: Yi Yang Release 20.11 added UDP/IPv4 and VXLAN UDP/IPv4 support for GRO, so update rel_notes to reflect these changes. Signed-off-by: Yi Yang Acked-by: Jiayu Hu --- doc/guides/rel_notes/release_20_11.rst | 6 ++ 1 file changed, 6 insertions(+) diff --git a/doc/guides/rel_notes/rele

Re: [dpdk-dev] [PATCH] eal: fix doxygen for EAL cleanup

2020-10-09 Thread Thomas Monjalon
09/10/2020 09:24, David Marchand: > > --- a/lib/librte_eal/include/rte_eal.h > > +++ b/lib/librte_eal/include/rte_eal.h > > @@ -130,8 +130,9 @@ int rte_eal_init(int argc, char **argv); > > * be made. It is expected that common usage of this function is to call it > > * just before terminating t

[dpdk-dev] [PATCH v3] net/hinic: fix secondary process's using coredump.

2020-10-09 Thread l00283554
fix coredump when secondary process using the hinic port. the reason is that during the stage of secondary process port initialization, it lack the initialization of "eth_dev->dev_ops". Signed-off-by: Qingqing Li --- v3: update the signed-off information. --- v2: solve the coding style issue. -

Re: [dpdk-dev] [PATCH v7 3/3] doc: update prog_guide and rel_notes for GRO

2020-10-09 Thread yang_y_yi
Thomas, sorry for confusion, previous two merges did include changes against doc/guides/prog_guide/generic_receive_offload_lib.rst, but doc/guides/rel_notes/release_20_11.rst isn't updated yet, so I posted https://patches.dpdk.org/patch/80105/ to update it, please help merge https://patches.dpd

Re: [dpdk-dev] [PATCH v3] net/dpaa2: fix build error about timesync functions

2020-10-09 Thread Sachin Saxena (OSS)
Acked-by: Sachin Saxena On 08-Oct-20 6:42 PM, Ferruh Yigit wrote: On 10/8/2020 3:24 AM, Sachin Saxena (OSS) wrote: [please don't top post, I moved reply to down] On 06-Oct-20 10:46 PM, Ferruh Yigit wrote: From: Chenxu Di Some timesync related source files are built only when 'RTE_LIBRTE_I

Re: [dpdk-dev] [PATCH v2] net/netvsc: fix txq leak in error path

2020-10-09 Thread Long Li
>Subject: [dpdk-dev] [PATCH v2] net/netvsc: fix txq leak in error path > >From: Yunjian Wang > >In hn_dev_tx_queue_setup() allocated memory for txq, we don't free it >when error happens and it will lead to memory leak. > >We can check for tx_free_thresh at the beginning of the function to fix it,

Re: [dpdk-dev] [PATCH v2 4/5] vhost: add packed ring vectorized dequeue

2020-10-09 Thread Liu, Yong
> -Original Message- > From: Maxime Coquelin > Sent: Tuesday, October 6, 2020 11:19 PM > To: Liu, Yong ; Xia, Chenbo ; > Wang, Zhihong > Cc: dev@dpdk.org > Subject: Re: [PATCH v2 4/5] vhost: add packed ring vectorized dequeue > > > > On 9/21/20 8:48 AM, Marvin Liu wrote: > > Optimize

Re: [dpdk-dev] [PATCH v7 3/3] doc: update prog_guide and rel_notes for GRO

2020-10-09 Thread Thomas Monjalon
Please triple check, release notes were squashed and merged already. 09/10/2020 09:47, yang_y_yi: > Thomas, sorry for confusion, previous two merges did include changes against > doc/guides/prog_guide/generic_receive_offload_lib.rst, but > doc/guides/rel_notes/release_20_11.rst isn't updated yet,

Re: [dpdk-dev] [RFC v2 1/1] lib/ring: add scatter gather APIs

2020-10-09 Thread Ananyev, Konstantin
Hi lads, > On Thu, Oct 08, 2020 at 08:44:13PM +, Honnappa Nagarahalli wrote: > > > > > > > > > > Hi Honnappa, > > > > > > From a quick walkthrough, I have some questions/comments, please see > > > below. > > Hi Olivier, appreciate your input. > > > > > > > > On Tue, Oct 06, 2020 at 08:29:05AM

[dpdk-dev] [PATCH v2] crypto/octeontx2: add lookaside IPsec IPv6 support

2020-10-09 Thread Tejasree Kondoj
Adding IPv6 tunnel mode support in lookaside IPsec PMD. Signed-off-by: Tejasree Kondoj Change-Id: I3b2e31e6fb70d7ae66ba6e741d5f28c418e54019 --- v2: * Updated PMD documentation and release notes doc/guides/cryptodevs/octeontx2.rst | 1 + doc/guides/rel_notes/release_20_11.rst|

Re: [dpdk-dev] [PATCH v7 3/3] doc: update prog_guide and rel_notes for GRO

2020-10-09 Thread yang_y_yi
Thomas, sorry for quick reply, update for doc/guides/rel_notes/release_20_11.rst also has been there, so please ignore this one merge request. I'm totally confused. The version Jiayu acked is v7, here are diffstat of v7 I sent, I'm not sure why these documents are updated by previous two merges

Re: [dpdk-dev] [PATCH] doc: update rel_notes for GRO

2020-10-09 Thread yang_y_yi
Please ignore this one, it indeed has been there. At 2020-10-09 15:40:59, yang_y...@163.com wrote: >From: Yi Yang > >Release 20.11 added UDP/IPv4 and VXLAN UDP/IPv4 support >for GRO, so update rel_notes to reflect these changes. > >Signed-off-by: Yi Yang >Acked-by: Jiayu Hu >--- > doc/guides/re

Re: [dpdk-dev] [PATCH] doc: update rel_notes for GRO

2020-10-09 Thread David Marchand
On Fri, Oct 9, 2020 at 10:13 AM yang_y_yi wrote: > > Please ignore this one, it indeed has been there. Please mark it accordingly in patchwork. Thank you. -- David Marchand

[dpdk-dev] [PATCH v3 1/5] vhost: add vectorized data path

2020-10-09 Thread Marvin Liu
Packed ring operations are split into batch and single functions for performance perspective. Ring operations in batch function can be accelerated by SIMD instructions like AVX512. So introduce vectorized parameter in vhost. Vectorized data path can be selected if platform and ring format matched

[dpdk-dev] [PATCH v3 0/5] vhost add vectorized data path

2020-10-09 Thread Marvin Liu
Packed ring format is imported since virtio spec 1.1. All descriptors are compacted into one single ring when packed ring format is on. It is straight forward that ring operations can be accelerated by utilizing SIMD instructions. This patch set will introduce vectorized data path in vhost librar

[dpdk-dev] [PATCH v3 4/5] vhost: add packed ring vectorized dequeue

2020-10-09 Thread Marvin Liu
Optimize vhost packed ring dequeue path with SIMD instructions. Four descriptors status check and writeback are batched handled with AVX512 instructions. Address translation operations are also accelerated by AVX512 instructions. If platform or compiler not support vectorization, will fallback to

[dpdk-dev] [PATCH v3 3/5] vhost: prepare memory regions addresses

2020-10-09 Thread Marvin Liu
Prepare memory regions guest physical addresses for vectorized data path. These information will be utilized by SIMD instructions to find matched region index. Signed-off-by: Marvin Liu diff --git a/lib/librte_vhost/vhost.h b/lib/librte_vhost/vhost.h index 12b7699cf..a19fe9423 100644 --- a/lib/l

[dpdk-dev] [PATCH v3 2/5] vhost: reuse packed ring functions

2020-10-09 Thread Marvin Liu
Move parse_ethernet, offload, extbuf functions to header file. These functions will be reused by vhost vectorized path. Signed-off-by: Marvin Liu diff --git a/lib/librte_vhost/vhost.h b/lib/librte_vhost/vhost.h index 87583c0b6..12b7699cf 100644 --- a/lib/librte_vhost/vhost.h +++ b/lib/librte_vho

[dpdk-dev] [PATCH v3 5/5] vhost: add packed ring vectorized enqueue

2020-10-09 Thread Marvin Liu
Optimize vhost packed ring enqueue path with SIMD instructions. Four descriptors status and length are batched handled with AVX512 instructions. Address translation operations are also accelerated by AVX512 instructions. Signed-off-by: Marvin Liu diff --git a/lib/librte_vhost/vhost.h b/lib/librt

Re: [dpdk-dev] [PATCH] doc: update rel_notes for GRO

2020-10-09 Thread yang_y_yi
Thanks for reminder, marked as Superseded. At 2020-10-09 16:14:15, "David Marchand" wrote: >On Fri, Oct 9, 2020 at 10:13 AM yang_y_yi wrote: >> >> Please ignore this one, it indeed has been there. > >Please mark it accordingly in patchwork. >Thank you. > > >-- >David Marchand

Re: [dpdk-dev] [PATCH v8 8/8] sched: remove redundant code

2020-10-09 Thread Thomas Monjalon
Hi, > Remove redundant data structure fields references from > functions and subport level data structures. It also > update the release and deprecation note > > Signed-off-by: Savinay Dharmappa > --- > > doc/guides/rel_notes/deprecation.rst | 6 > doc/guides/rel_notes/release_20_11.rs

Re: [dpdk-dev] [dpdk-dev v10 2/4] cryptodev: add raw crypto data-path APIs

2020-10-09 Thread Zhang, Roy Fan
Hi Akhil, > > rte_cryptodev_raw_configure_dp_context creates a shadow copy of the > queue > > pair data with in ctx, where rte_cryptodev_raw_attach_session sets the > function > > handler based on the session data. Using of the same PMD callback > function is > > to > > save one function pointer s

Re: [dpdk-dev] [PATCH] ethdev: fix xstat name of basic stats per queue

2020-10-09 Thread Power, Ciara
Hi Ferruh, Thomas, >-Original Message- >From: Ferruh Yigit >Sent: Thursday 8 October 2020 16:42 >To: Thomas Monjalon ; dev@dpdk.org; Van Haaren, >Harry ; Power, Ciara ; >Laatz, Kevin >Cc: arybche...@solarflare.com >Subject: Re: [PATCH] ethdev: fix xstat name of basic stats per queue > >

Re: [dpdk-dev] [PATCH] ethdev: fix xstat name of basic stats per queue

2020-10-09 Thread Pattan, Reshma
> -Original Message- > From: Power, Ciara > Sent: Friday, October 9, 2020 9:33 AM > To: Yigit, Ferruh ; Thomas Monjalon > ; dev@dpdk.org; Van Haaren, Harry > ; Laatz, Kevin > Cc: arybche...@solarflare.com; Pattan, Reshma > Subject: RE: [PATCH] ethdev: fix xstat name of basic stats per

[dpdk-dev] [PATCH v3] pci: support both PIO and MMIO BAR for legacy virtio on x86

2020-10-09 Thread 谢华伟(此时此刻)
From: "huawei.xhw" Legacy virtio-pci only supports PIO BAR resource. As we need to create lots of virtio devices and PIO resource on x86 is very limited, we expose MMIO BAR. Kernel supports both PIO and MMIO BAR for legacy virtio-pci device. We handles different type of BAR in the similar way.

Re: [dpdk-dev] [PATCH v7 3/3] doc: update prog_guide and rel_notes for GRO

2020-10-09 Thread Thomas Monjalon
09/10/2020 10:11, yang_y_yi: > Thomas, sorry for quick reply, update for > doc/guides/rel_notes/release_20_11.rst also has been there, so please ignore > this one merge request. > > I'm totally confused. The version Jiayu acked is v7, here are diffstat of v7 > I sent, I'm not sure why these doc

Re: [dpdk-dev] [PATCH] vhost: fix external mbuf creation

2020-10-09 Thread yang_y_yi
Tested-by: Yi Yang At 2020-10-07 20:53:18, "Olivier Matz" wrote: >In virtio_dev_extbuf_alloc(), the shinfo structure used to store >the reference counter and the free callback of the external buffer >is by default stored inside the mbuf data. > >This is wrong because the mbuf

Re: [dpdk-dev] [PATCH] ethdev: fix xstat name of basic stats per queue

2020-10-09 Thread David Marchand
On Fri, Oct 9, 2020 at 10:36 AM Pattan, Reshma wrote: > > >> +* ethdev: Renamed basic statistics per queue. An underscore is > > >> +inserted > > >> + between the queue number and the rest of the xstat name: > > >> + > > >> + * ``rx_qN*`` -> ``rx_qN_*`` > > >> + * ``tx_qN*`` -> ``tx_qN_*`` > >

Re: [dpdk-dev] [PATCH] vhost: fix external mbuf creation

2020-10-09 Thread yang_y_yi
Thanks Oliver for posting this patch, it clearly explain his concern, I totally agree this change. I tested it by OVS DPDK, it works well. At 2020-10-07 20:53:18, "Olivier Matz" wrote: >In virtio_dev_extbuf_alloc(), the shinfo structure used to store >the reference counter and the free callback

Re: [dpdk-dev] [PATCH] maintainers: update for MCS lock

2020-10-09 Thread Thomas Monjalon
09/10/2020 03:19, Phil Yang: > Honnappa Nagarahalli wrote: > > > Subject: [PATCH] maintainers: update for MCS lock > > > > Updating MAINTAINERS file for MCS lock. > > > > Signed-off-by: Honnappa Nagarahalli > > Thank you, Honnappa. > Acked-by: Phil Yang Applied

Re: [dpdk-dev] [RFC PATCH] build: use libpcap only from pkg-config

2020-10-09 Thread Luca Boccassi
On Thu, 2020-10-08 at 18:08 +0100, Bruce Richardson wrote: > On Thu, Oct 08, 2020 at 06:05:36PM +0100, Bruce Richardson wrote: > > All recent linux distro's - including RHEL 8 and Ubuntu 18.04 - provide a > > pkg-config file for libpcap, and using other methods of finding the library > > can cause

Re: [dpdk-dev] [PATCH] ethdev: fix xstat name of basic stats per queue

2020-10-09 Thread Pattan, Reshma
> -Original Message- > From: David Marchand > Subject: Re: [dpdk-dev] [PATCH] ethdev: fix xstat name of basic stats per > queue > > On Fri, Oct 9, 2020 at 10:36 AM Pattan, Reshma > wrote: > > > >> +* ethdev: Renamed basic statistics per queue. An underscore is > > > >> +inserted > > >

Re: [dpdk-dev] [PATCH v4 02/10] eal: add power management intrinsics

2020-10-09 Thread Burakov, Anatoly
On 08-Oct-20 6:15 PM, Ananyev, Konstantin wrote: Add two new power management intrinsics, and provide an implementation in eal/x86 based on UMONITOR/UMWAIT instructions. The instructions are implemented as raw byte opcodes because there is not yet widespread compiler support for these instructio

[dpdk-dev] [PATCH v3] crypto/octeontx2: add lookaside IPsec IPv6 support

2020-10-09 Thread Tejasree Kondoj
Adding IPv6 tunnel mode support in lookaside IPsec PMD. Signed-off-by: Tejasree Kondoj Acked-by: Anoob Joseph --- v3: * Fixed checkpatch failures v2: * Updated PMD documentation and release notes doc/guides/cryptodevs/octeontx2.rst | 1 + doc/guides/rel_notes/release_20_11.rst

Re: [dpdk-dev] [PATCH v4 1/2] eal/windows: add pthread mutex lock

2020-10-09 Thread Tal Shnaiderman
> Subject: [dpdk-dev] [PATCH v4 1/2] eal/windows: add pthread mutex lock > > Add pthread mutex lock as it is needed for the thread safe rte_flow > functions. > > Signed-off-by: Suanming Mou > Acked-by: Dmitry Kozlyuk > --- > > v4: > - Add PTHREAD_MUTEX_INITIALIZER macro. > > v3: > - N

Re: [dpdk-dev] [PATCH v4 02/10] eal: add power management intrinsics

2020-10-09 Thread Burakov, Anatoly
On 09-Oct-20 6:42 AM, Jerin Jacob wrote: On Thu, Oct 8, 2020 at 10:38 PM Ananyev, Konstantin wrote: On Thu, Oct 8, 2020 at 6:57 PM Burakov, Anatoly wrote: On 08-Oct-20 9:44 AM, Jerin Jacob wrote: On Thu, Oct 8, 2020 at 2:04 PM Thomas Monjalon wrote: Add two new power management intri

Re: [dpdk-dev] [PATCH v5] testpmd: add speed capability in device info

2020-10-09 Thread Ferruh Yigit
On 10/8/2020 7:25 PM, Sarosh Arif wrote: Called rte_eth_dev_info_get() in testpmd, to get device info so that speed capabilities can be printed under "show device info" ​ Bugzilla ID: 496 Signed-off-by: Sarosh Arif --- app/test-pmd/config.c | 43 +++ 1

Re: [dpdk-dev] [PATCH v4 02/10] eal: add power management intrinsics

2020-10-09 Thread Thomas Monjalon
09/10/2020 11:25, Burakov, Anatoly: > On 09-Oct-20 6:42 AM, Jerin Jacob wrote: > > On Thu, Oct 8, 2020 at 10:38 PM Ananyev, Konstantin > > wrote: > >> > >>> > >>> On Thu, Oct 8, 2020 at 6:57 PM Burakov, Anatoly > >>> wrote: > > On 08-Oct-20 9:44 AM, Jerin Jacob wrote: > > On Thu, Oc

Re: [dpdk-dev] [PATCH 2/3] examples/fips_validation: ignore \r in input files

2020-10-09 Thread Zhang, Roy Fan
Hi, I agree. Thanks a lot Olivier. Also thanks for the other 2 FIPS patches :-). Regards, Fan > -Original Message- > From: Olivier Matz > Sent: Thursday, October 8, 2020 3:20 PM > To: Zhang, Roy Fan > Cc: dev@dpdk.org; Kovacevic, Marko ; Akhil > Goyal ; Kusztal, ArkadiuszX > ; sta...

Re: [dpdk-dev] [PATCH v4 02/10] eal: add power management intrinsics

2020-10-09 Thread Burakov, Anatoly
On 09-Oct-20 10:29 AM, Thomas Monjalon wrote: 09/10/2020 11:25, Burakov, Anatoly: On 09-Oct-20 6:42 AM, Jerin Jacob wrote: On Thu, Oct 8, 2020 at 10:38 PM Ananyev, Konstantin wrote: On Thu, Oct 8, 2020 at 6:57 PM Burakov, Anatoly wrote: On 08-Oct-20 9:44 AM, Jerin Jacob wrote: On Thu,

Re: [dpdk-dev] [PATCH v2 00/56] net: txgbe PMD

2020-10-09 Thread Ferruh Yigit
On 10/9/2020 4:03 AM, jiawe...@trustnetic.com wrote: Hi Ferruh, For the syntax/style check issue, should I fix all the errors and warnings or just fix the errors? It seems to be a lot of warnings. [Please don't top post, it makes archives un-readable] Please fix all, but beware that there m

Re: [dpdk-dev] [PATCH] examples/fips_validation: fix req file version incompatibility

2020-10-09 Thread Zhang, Roy Fan
Hi Archana, Sorry for late reply. Missed this one. > -Original Message- > From: Archana Muniganti > Sent: Monday, September 21, 2020 8:03 AM > To: Archana Muniganti ; Zhang, Roy Fan > ; Kovacevic, Marko > ; akhil.go...@nxp.com > Cc: Anoob Joseph ; Mcnamara, John > ; Jiang, YuX ; Xu, Qia

Re: [dpdk-dev] [PATCH] examples/fips_validation: fix req file version incompatibility

2020-10-09 Thread Jiang, YuX
Tested-by: Jiang, YuX Best Regards Jiang yu > > -Original Message- > > From: Archana Muniganti > > Sent: Wednesday, September 9, 2020 9:57 PM > > To: roy.fan.zh...@intel.com; marko.kovace...@intel.com; > > akhil.go...@nxp.com > > Cc: Archana Muniganti ; Anoob Joseph > > ; john.m

[dpdk-dev] [PATCH v2] build: add -moutline-atomics to default Arm build

2020-10-09 Thread Juraj Linkeš
-moutline-atomics allows LSE instructions to be used if available when compiling for ARMv8.0 instruction set. It's enabled by default on newer compilers, such as gcc-10.1. Enable the option in case an earlier compiler version is used for the default build that lacks either -mcpu or -mtune which wou

Re: [dpdk-dev] [PATCH V1 2/3] mbuf: change free_cb interface to adapt to GSO case

2020-10-09 Thread yang_y_yi
Olivier, thank you so much for your reply, your patch post for vhost help me understand your concern better, I totally agree. For GSO case, let me show you a simple code to explain my issue. struct rte_mbuf *pkt = rte_pktmbuf_alloc(mp); virtio_dev_extbuf_alloc(pkt, data_len) struct rte_mbuf

Re: [dpdk-dev] [PATCH v4 02/10] eal: add power management intrinsics

2020-10-09 Thread Jerin Jacob
On Fri, Oct 9, 2020 at 3:10 PM Burakov, Anatoly wrote: > > On 09-Oct-20 10:29 AM, Thomas Monjalon wrote: > > 09/10/2020 11:25, Burakov, Anatoly: > >> On 09-Oct-20 6:42 AM, Jerin Jacob wrote: > >>> On Thu, Oct 8, 2020 at 10:38 PM Ananyev, Konstantin > >>> wrote: > > > > > On Thu, Oct

Re: [dpdk-dev] [PATCH v4 02/10] eal: add power management intrinsics

2020-10-09 Thread Burakov, Anatoly
On 09-Oct-20 10:54 AM, Jerin Jacob wrote: On Fri, Oct 9, 2020 at 3:10 PM Burakov, Anatoly wrote: On 09-Oct-20 10:29 AM, Thomas Monjalon wrote: 09/10/2020 11:25, Burakov, Anatoly: On 09-Oct-20 6:42 AM, Jerin Jacob wrote: On Thu, Oct 8, 2020 at 10:38 PM Ananyev, Konstantin wrote: On Thu,

Re: [dpdk-dev] [PATCH v4 02/10] eal: add power management intrinsics

2020-10-09 Thread Thomas Monjalon
09/10/2020 12:03, Burakov, Anatoly: > On 09-Oct-20 10:54 AM, Jerin Jacob wrote: > > On Fri, Oct 9, 2020 at 3:10 PM Burakov, Anatoly > > wrote: > >> On 09-Oct-20 10:29 AM, Thomas Monjalon wrote: > >>> 09/10/2020 11:25, Burakov, Anatoly: > On 09-Oct-20 6:42 AM, Jerin Jacob wrote: > > On Thu

Re: [dpdk-dev] [PATCH v4 02/10] eal: add power management intrinsics

2020-10-09 Thread Jerin Jacob
On Fri, Oct 9, 2020 at 3:33 PM Burakov, Anatoly wrote: > > On 09-Oct-20 10:54 AM, Jerin Jacob wrote: > > On Fri, Oct 9, 2020 at 3:10 PM Burakov, Anatoly > > wrote: > >> > >> On 09-Oct-20 10:29 AM, Thomas Monjalon wrote: > >>> 09/10/2020 11:25, Burakov, Anatoly: > On 09-Oct-20 6:42 AM, Jerin

[dpdk-dev] [PATCH v6 00/14] remove make support in DPDK

2020-10-09 Thread Ciara Power
This patchset includes the remaining 14 patches that were not merged along with the others in v4/v5, pending rework and more review. *All*, please make the documentation update your highest priority. v6: - Rebased onto main and fixed conflicts. - Fixed some formatting and indentation. - Rewo

[dpdk-dev] [PATCH v6 01/14] doc: remove references to make from platforms guides

2020-10-09 Thread Ciara Power
Make is no longer supported for compiling DPDK, references are now removed in the documentation. Signed-off-by: Ciara Power Reviewed-by: Kevin Laatz --- doc/guides/platform/bluefield.rst | 22 - doc/guides/platform/octeontx.rst | 33 +-- doc/guid

[dpdk-dev] [PATCH v6 02/14] doc: remove references to make from mempool guide

2020-10-09 Thread Ciara Power
Make is no longer supported for compiling DPDK, references are now removed in the documentation. Signed-off-by: Ciara Power Reviewed-by: Kevin Laatz --- doc/guides/mempool/octeontx.rst | 28 +++- doc/guides/mempool/octeontx2.rst | 10 +- 2 files changed, 4 inser

[dpdk-dev] [PATCH v6 03/14] doc: remove references to make from NICs guides

2020-10-09 Thread Ciara Power
Make is no longer supported for compiling DPDK, references are now removed in the documentation. Signed-off-by: Ciara Power Reviewed-by: Bruce Richardson --- v6: Fixed indentation of testbbdev list entry. --- doc/guides/nics/ark.rst| 7 +--- doc/guides/nics/atlantic.rst | 4

[dpdk-dev] [PATCH v6 04/14] doc: remove references to make from vdpadevs guides

2020-10-09 Thread Ciara Power
Make is no longer supported for compiling DPDK, references are now removed in the documentation. Signed-off-by: Ciara Power --- doc/guides/vdpadevs/ifc.rst | 13 doc/guides/vdpadevs/mlx5.rst | 40 +++- 2 files changed, 3 insertions(+), 50 deletions(-

[dpdk-dev] [PATCH v6 06/14] doc: remove references to make from cryptodevs guides

2020-10-09 Thread Ciara Power
Make is no longer supported for compiling DPDK, references are now removed in the documentation. Signed-off-by: Ciara Power Reviewed-by: Kevin Laatz --- doc/guides/cryptodevs/aesni_gcm.rst | 4 +- doc/guides/cryptodevs/aesni_mb.rst | 4 +- doc/guides/cryptodevs/armv8.rst | 3 -- doc/gui

[dpdk-dev] [PATCH v6 07/14] doc: remove references to make from compressdevs guides

2020-10-09 Thread Ciara Power
Make is no longer supported for compiling DPDK, references are now removed in the documentation. Signed-off-by: Ciara Power Reviewed-by: Kevin Laatz Acked-by: Lee Daly --- doc/guides/compressdevs/isal.rst | 4 doc/guides/compressdevs/octeontx.rst | 24 ++-- doc/gu

[dpdk-dev] [PATCH v6 05/14] doc: remove references to make from bbdevs guides

2020-10-09 Thread Ciara Power
Make is no longer supported for compiling DPDK, references are now removed in the documentation. Signed-off-by: Ciara Power Reviewed-by: Kevin Laatz --- v5: Added meson steps to turbo_sw doc. --- doc/guides/bbdevs/fpga_5gnr_fec.rst | 5 + doc/guides/bbdevs/fpga_lte_fec.rst | 5 + do

[dpdk-dev] [PATCH v6 10/14] doc: remove references to make from app guides

2020-10-09 Thread Ciara Power
While make has been deprecated for DPDK, it's still applicable for some example apps to be built standalone, this patch adjusts the guides to take that into consideration. Signed-off-by: Ciara Power Acked-by: Nicolas Chautru --- v6: Modified commit log based on suggestions on v5. --- doc/guide

[dpdk-dev] [PATCH v6 09/14] doc: remove references to make from rawdevs guides

2020-10-09 Thread Ciara Power
Make is no longer supported for compiling DPDK, references are now removed in the documentation. Signed-off-by: Ciara Power Reviewed-by: Kevin Laatz Acked-by: Bruce Richardson Acked-by: Rosen Xu --- v6: Modified compilation section for ioat based on v5 feedback. --- doc/guides/rawdevs/dpaa2_

[dpdk-dev] [PATCH v6 08/14] doc: remove references to make from eventdevs guides

2020-10-09 Thread Ciara Power
Make is no longer supported for compiling DPDK, references are now removed in the documentation. Signed-off-by: Ciara Power Reviewed-by: Kevin Laatz --- doc/guides/eventdevs/dpaa.rst | 20 doc/guides/eventdevs/dpaa2.rst | 20 doc/guides/eventde

[dpdk-dev] [PATCH v6 11/14] doc: remove reference to make from tools guides

2020-10-09 Thread Ciara Power
Make is no longer supported for compiling DPDK, references are now removed in the documentation. Signed-off-by: Ciara Power Reviewed-by: Kevin Laatz Acked-by: Nicolas Chautru --- v6: - Fixed indentation for testbbdev list entry. v5: - Reworded sentence in pdump doc. - Replaced references

[dpdk-dev] [PATCH v6 12/14] doc: remove references to make from contributing guide

2020-10-09 Thread Ciara Power
Make is no longer supported for compiling DPDK, references are now removed in the documentation. Signed-off-by: Ciara Power Signed-off-by: Louise Kilheeney --- v5: - Removed reference to test-build.sh used for Make. - Added point back in for handling specific code, reworded as necessary

[dpdk-dev] [PATCH v6 13/14] doc: add to release notes to reflect removal of make

2020-10-09 Thread Ciara Power
Added an entry to describe the removal of the Make build system to the release notes for 20.11. Signed-off-by: Ciara Power --- v6: - Fixed spelling in commit log. - Fixed formatting of release note entry to be split logically. --- doc/guides/rel_notes/release_20_11.rst | 4 1 file chan

Re: [dpdk-dev] [PATCH v4 02/10] eal: add power management intrinsics

2020-10-09 Thread Burakov, Anatoly
On 09-Oct-20 11:17 AM, Thomas Monjalon wrote: 09/10/2020 12:03, Burakov, Anatoly: On 09-Oct-20 10:54 AM, Jerin Jacob wrote: On Fri, Oct 9, 2020 at 3:10 PM Burakov, Anatoly wrote: On 09-Oct-20 10:29 AM, Thomas Monjalon wrote: 09/10/2020 11:25, Burakov, Anatoly: On 09-Oct-20 6:42 AM, Jerin Ja

Re: [dpdk-dev] [PATCH v6 06/14] doc: remove references to make from cryptodevs guides

2020-10-09 Thread Akhil Goyal
> Make is no longer supported for compiling DPDK, references are now > removed in the documentation. > > Signed-off-by: Ciara Power > Reviewed-by: Kevin Laatz > --- The overall patch looks good. But there are some PMDs which are not enabled by default. The documentation should cover how to en

Re: [dpdk-dev] [RFC PATCH] build: use libpcap only from pkg-config

2020-10-09 Thread Bruce Richardson
On Fri, Oct 09, 2020 at 10:09:11AM +0100, Luca Boccassi wrote: > On Thu, 2020-10-08 at 18:08 +0100, Bruce Richardson wrote: > > On Thu, Oct 08, 2020 at 06:05:36PM +0100, Bruce Richardson wrote: > > > All recent linux distro's - including RHEL 8 and Ubuntu 18.04 - provide a > > > pkg-config file for

Re: [dpdk-dev] [PATCH] net/af_xdp: use snprintf instead of strncpy

2020-10-09 Thread Gaëtan Rivet
On 07/10/20 12:45 +0100, Ferruh Yigit wrote: > On 10/7/2020 11:28 AM, Bruce Richardson wrote: > > On Wed, Oct 07, 2020 at 11:26:38AM +0100, Bruce Richardson wrote: > > > On Wed, Oct 07, 2020 at 11:51:31AM +0200, Olivier Matz wrote: > > > > On Wed, Oct 07, 2020 at 10:40:32AM +0100, Ferruh Yigit wrot

Re: [dpdk-dev] [PATCH v4 02/10] eal: add power management intrinsics

2020-10-09 Thread Jerin Jacob
On Fri, Oct 9, 2020 at 3:53 PM Burakov, Anatoly wrote: > > On 09-Oct-20 11:17 AM, Thomas Monjalon wrote: > > 09/10/2020 12:03, Burakov, Anatoly: > >> On 09-Oct-20 10:54 AM, Jerin Jacob wrote: > >>> On Fri, Oct 9, 2020 at 3:10 PM Burakov, Anatoly > >>> wrote: > On 09-Oct-20 10:29 AM, Thomas M

Re: [dpdk-dev] [PATCH v4 02/10] eal: add power management intrinsics

2020-10-09 Thread Ananyev, Konstantin
> On 09-Oct-20 11:17 AM, Thomas Monjalon wrote: > > 09/10/2020 12:03, Burakov, Anatoly: > >> On 09-Oct-20 10:54 AM, Jerin Jacob wrote: > >>> On Fri, Oct 9, 2020 at 3:10 PM Burakov, Anatoly > >>> wrote: > On 09-Oct-20 10:29 AM, Thomas Monjalon wrote: > > 09/10/2020 11:25, Burakov, Anatoly:

Re: [dpdk-dev] [PATCH] net/af_xdp: use snprintf instead of strncpy

2020-10-09 Thread Bruce Richardson
On Fri, Oct 09, 2020 at 12:36:30PM +0200, Gaëtan Rivet wrote: > On 07/10/20 12:45 +0100, Ferruh Yigit wrote: > > On 10/7/2020 11:28 AM, Bruce Richardson wrote: > > > On Wed, Oct 07, 2020 at 11:26:38AM +0100, Bruce Richardson wrote: > > > > On Wed, Oct 07, 2020 at 11:51:31AM +0200, Olivier Matz wrot

Re: [dpdk-dev] [PATCH v3 4/4] vhost: fix async register/unregister deadlock

2020-10-09 Thread Fu, Patrick
> -Original Message- > From: Maxime Coquelin > Sent: Monday, October 5, 2020 10:26 PM > To: Fu, Patrick ; dev@dpdk.org; Xia, Chenbo > > Cc: Wang, Zhihong ; Jiang, Cheng1 > > Subject: Re: [PATCH v3 4/4] vhost: fix async register/unregister deadlock > > > > On 9/29/20 11:29 AM, Patric

Re: [dpdk-dev] [PATCH] net/af_xdp: use snprintf instead of strncpy

2020-10-09 Thread Ferruh Yigit
On 10/9/2020 11:36 AM, Gaëtan Rivet wrote: On 07/10/20 12:45 +0100, Ferruh Yigit wrote: On 10/7/2020 11:28 AM, Bruce Richardson wrote: On Wed, Oct 07, 2020 at 11:26:38AM +0100, Bruce Richardson wrote: On Wed, Oct 07, 2020 at 11:51:31AM +0200, Olivier Matz wrote: On Wed, Oct 07, 2020 at 10:40:

Re: [dpdk-dev] [PATCH] app/testpmd: fix transmission from speed to str

2020-10-09 Thread Ferruh Yigit
On 10/9/2020 4:45 AM, Min Hu (Connor) wrote: This patch uses a new 'rte_eth_link_speed_to_str()' API in the ethdev which enables removing above global 'eth_speed_name' array [1]. Fixes: 466c55e4d85b ("app/testpmd: add FEC command") Signed-off-by: Min Hu (Connor) Squashed into relevant commi

Re: [dpdk-dev] [PATCH v4 02/10] eal: add power management intrinsics

2020-10-09 Thread Burakov, Anatoly
On 09-Oct-20 11:48 AM, Ananyev, Konstantin wrote: On 09-Oct-20 11:17 AM, Thomas Monjalon wrote: 09/10/2020 12:03, Burakov, Anatoly: On 09-Oct-20 10:54 AM, Jerin Jacob wrote: On Fri, Oct 9, 2020 at 3:10 PM Burakov, Anatoly wrote: On 09-Oct-20 10:29 AM, Thomas Monjalon wrote: 09/10/2020 11:25

Re: [dpdk-dev] [PATCH v3 1/4] vhost: simplify async copy completion

2020-10-09 Thread Fu, Patrick
> > On 9/29/20 11:29 AM, Patrick Fu wrote: > > Current async ops allows check_completed_copies() callback to return > > arbitrary number of async iov segments finished from backend async > > devices. This design creates complexity for vhost to handle breaking > > transfer of a single packet (i.e. t

Re: [dpdk-dev] [PATCH v2 4/4] examples/mp_server: clear string truncation warning

2020-10-09 Thread Nicolau, Radu
On 8/21/2020 6:10 PM, Bruce Richardson wrote: Compiling with GCC 9.3 on Ubuntu 20.04 gives a warning about possible string truncation when getting the RX queue name: In file included from init.c:36: init.c: In function ‘init’: ../shared/common.h:38:28: warning: ‘%u’ directive output may be tru

Re: [dpdk-dev] [PATCH v2 3/4] examples/mp_server: fix snprintf overflow

2020-10-09 Thread Nicolau, Radu
On 8/21/2020 6:10 PM, Bruce Richardson wrote: When producing a printable mac address the buffer was appropriately sized for holding the mac address exactly, but the actual snprintf included a '\n' character at the end, which means that the snprintf technically is getting truncated i.e. the \n w

Re: [dpdk-dev] [PATCH v3] net/dpaa2: fix build error about timesync functions

2020-10-09 Thread Ferruh Yigit
On 10/9/2020 8:48 AM, Sachin Saxena (OSS) wrote: On 08-Oct-20 6:42 PM, Ferruh Yigit wrote: On 10/8/2020 3:24 AM, Sachin Saxena (OSS) wrote: [please don't top post, I moved reply to down] On 06-Oct-20 10:46 PM, Ferruh Yigit wrote: From: Chenxu Di Some timesync related source files are buil

Re: [dpdk-dev] [PATCH v2 1/8] net/memif: do not update local copy of tail in tx function

2020-10-09 Thread Jakub Grajciar -X (jgrajcia - PANTHEON TECH SRO at Cisco)
> > -Original Message- > > From: Honnappa Nagarahalli > > Sent: Monday, September 28, 2020 2:03 PM > > To: dev@dpdk.org; Honnappa Nagarahalli > ; > > Phil Yang ; jgraj...@cisco.com; > > ferruh.yi...@intel.com > > Cc: nd ; sta...@dpdk.org > > Subject: [PATCH v2 1/8] net/memif: do not update

[dpdk-dev] [PATCH v5 1/3] crypto/aesni_mb: support ZUC-EEA3/EIA3

2020-10-09 Thread Pablo de Lara
Add support for ZUC-EEA3/EIA3 algorithms through the intel-ipsec-mb job API, allowing the mix of these algorithms with others. Signed-off-by: Pablo de Lara --- v5: - Added NON_BYTE_ALIGNED feature flag - Rebased on top of crypto subtree v3/v4: - No changes v2: - Added commit description - Fixe

[dpdk-dev] [PATCH v5 2/3] crypto/aesni_mb: support SNOW3G-UEA2/UIA2

2020-10-09 Thread Pablo de Lara
Add support for SNOW3G-UEA2/UIA2 algorithms through the intel-ipsec-mb job API, allowing the mix of these algorithms with others. Signed-off-by: Pablo de Lara --- v5: - Rebased on top of crypto subtree v3/v4: - Fixed compilation when intel-ipsec-mb version is lower than 0.54 v2: - Added commit

[dpdk-dev] [PATCH v5 3/3] crypto/aesni_mb: support KASUMI F8/F9

2020-10-09 Thread Pablo de Lara
Add support for KASUMI-F8/F9 algorithms through the intel-ipsec-mb job API, allowing the mix of these algorithms with others. Signed-off-by: Pablo de Lara --- v5: - Rebased on top of crypto subtree v3/v4: - Fixed compilation when intel-ipsec-mb version is lower than 0.54 v2: - Added commit des

Re: [dpdk-dev] [PATCH v4 02/10] eal: add power management intrinsics

2020-10-09 Thread Bruce Richardson
On Fri, Oct 09, 2020 at 12:12:56PM +0100, Burakov, Anatoly wrote: > On 09-Oct-20 11:48 AM, Ananyev, Konstantin wrote: > > > On 09-Oct-20 11:17 AM, Thomas Monjalon wrote: > > > > 09/10/2020 12:03, Burakov, Anatoly: > > > > > On 09-Oct-20 10:54 AM, Jerin Jacob wrote: > > > > > > On Fri, Oct 9, 2020 a

Re: [dpdk-dev] [dpdk-stable] [PATCH v2] net/netvsc: fix txq leak in error path

2020-10-09 Thread Ferruh Yigit
On 10/9/2020 4:53 AM, Long Li wrote: Subject: [dpdk-dev] [PATCH v2] net/netvsc: fix txq leak in error path From: Yunjian Wang In hn_dev_tx_queue_setup() allocated memory for txq, we don't free it when error happens and it will lead to memory leak. We can check for tx_free_thresh at the beginn

[dpdk-dev] [PATCH v4 2/2] test/crypto: add GMAC SGL tests

2020-10-09 Thread Pablo de Lara
Add Scatter-Gather List tests for AES-GMAC. Signed-off-by: Pablo de Lara --- This patchset depends on series http://patches.dpdk.org/project/dpdk/list/?series=12819 Changes: - v4: Rebased on top of crypto subtree - v3: Fixed checkpatch issues - v2: Modified segment size to make reduce maxim

[dpdk-dev] [PATCH v4 1/2] crypto/aesni_gcm: support SGL on AES-GMAC

2020-10-09 Thread Pablo de Lara
Add Scatter-gather list support for AES-GMAC. Signed-off-by: Pablo de Lara --- This patchset depends on series http://patches.dpdk.org/project/dpdk/list/?series=12819 Changes: - v4: Rebased on top of crypto subtree - v2/v3: no change --- doc/guides/cryptodevs/aesni_gcm.rst | 2 - do

Re: [dpdk-dev] [PATCH v4 02/10] eal: add power management intrinsics

2020-10-09 Thread Burakov, Anatoly
On 09-Oct-20 12:36 PM, Bruce Richardson wrote: On Fri, Oct 09, 2020 at 12:12:56PM +0100, Burakov, Anatoly wrote: On 09-Oct-20 11:48 AM, Ananyev, Konstantin wrote: On 09-Oct-20 11:17 AM, Thomas Monjalon wrote: 09/10/2020 12:03, Burakov, Anatoly: On 09-Oct-20 10:54 AM, Jerin Jacob wrote: On Fr

[dpdk-dev] [PATCH] maintainers: update for bonding

2020-10-09 Thread Min Hu (Connor)
Adding Connor as additional maintainer to bonding. Signed-off-by: Min Hu (Connor) Reviewed-by: Wei Hu (Xavier) --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index 75a17d5..ba97f23 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -530,6 +530,7 @@ F: d

  1   2   3   4   >