[dpdk-dev] [PATCH v2] fix incorrect group value of sample suffix flow

2020-10-30 Thread Jiawei Wang
This patch fix the wrong flow group configuration for sample suffix flow in mlx5 pmd driver. v2: * Update commit message * Rebase Jiawei Wang (1): net/mlx5: fix incorrect group value of sample suffix flow drivers/net/mlx5/mlx5_flow.c| 155 ++-- drivers

[dpdk-dev] [PATCH v2] net/mlx5: fix incorrect group value of sample suffix flow

2020-10-30 Thread Jiawei Wang
mlx5 PMD splited the sampling flow into prefix flow and suffix flow. On the sample action translation function, the scaled group value of suffix flow be attached into sample object and saved into sample resource. mlx5 PMD fetched the group value from the sample resource to create the suffix flow.

[dpdk-dev] [PATCH] net/enic: fix header sizes when copying flow patterns

2020-10-30 Thread Hyong Youb Kim
Several functions use sizeof(struct rte_flow_item_eth) and sizeof(struct rte_flow_item_ipv6) when copying headers. These sizes used to coincide with the sizes of rte_ether_hdr and rte_ipv6_hdr. But, with recently added fields, rte_flow_item_eth and rte_flow_item_ipv6 have grown in size. Use sizeof(

[dpdk-dev] Segfault when eal thread executing mlx5 nic's lsc event

2020-10-30 Thread Weifeng LI
hi     I am using the dpdk bond of mlx5. There is a segment error in the process of starting the bond port. This is because EAL interrupt thread is processing LSC interrupt when slave_configure is executing the rte_eth_dev_rss_reta_update. rte_eth_dev_rss_reta_update will also use mlx5 flow l

[dpdk-dev] [v6 1/2] cryptodev: support enqueue & dequeue callback functions

2020-10-30 Thread Abhinandan Gujjar
This patch adds APIs to add/remove callback functions on crypto enqueue/dequeue burst. The callback function will be called for each burst of crypto ops received/sent on a given crypto device queue pair. Signed-off-by: Abhinandan Gujjar Acked-by: Konstantin Ananyev --- config/rte_config.h

[dpdk-dev] [v6 0/2] support enqueue & dequeue callbacks on cryptodev

2020-10-30 Thread Abhinandan Gujjar
In an eventdev world, multiple workers (with ordered queue) will be working on IPsec ESP processing. The ESP header's sequence number is unique and has to be sequentially incremented in an orderly manner. This rises a need for incrementing sequence number in crypto stage especially in event crypto

[dpdk-dev] [v6 2/2] test: add testcase for crypto enqueue callback

2020-10-30 Thread Abhinandan Gujjar
This patch adds test case for testing functionality of enqueue callback mechanism. Signed-off-by: Abhinandan Gujjar Acked-by: Konstantin Ananyev --- app/test/test_cryptodev.c | 135 +- 1 file changed, 133 insertions(+), 2 deletions(-) diff --git a/ap

Re: [dpdk-dev] Fwd: [PATCH] maintainers: update hns3 pmd maintainers

2020-10-30 Thread Ferruh Yigit
On 10/20/2020 3:16 AM, Wei Hu (Xavier) wrote: <...> I am a new hns3 pmd developer and reviewer for upstreaming hns3 pmd driver. So I want to help out here as well. Signed-off-by: Lijun Ou > > Acked-by: Wei Hu (Xavier) > Applied to dpdk-next-net/main, thanks.

Re: [dpdk-dev] [PATCH] net/hns3: enable RSS for ipv6-sctp dst/src port fields

2020-10-30 Thread Ferruh Yigit
On 10/21/2020 9:54 AM, Lijun Ou wrote: For Kunpeng930 NIC hardware, it supports to use dst/src port to RSS hash for ipv6-sctp packet type. However, the Kunpeng920 NIC hardware is different with it. The Kunpeng920 NIC only supports dst/src ip to RSS hash for ipv6-sctp packet type. Signed-off-by:

Re: [dpdk-dev] [PATCH v2] net/i40e: fix virtual channel confiliction issue

2020-10-30 Thread Ferruh Yigit
On 10/30/2020 5:32 AM, Zhang, Yuying wrote: -Original Message- From: Ferruh Yigit Sent: Friday, October 23, 2020 6:42 PM To: Zhang, Yuying ; dev@dpdk.org; Zhang, Qi Z ; Xing, Beilei Cc: sta...@dpdk.org Subject: Re: [dpdk-dev] [PATCH v2] net/i40e: fix virtual channel confiliction iss

[dpdk-dev] [PATCH v2 0/2] raw/ifpga: fix coverity defects

2020-10-30 Thread Wei Huang
These two patches fix defects found by coverity scan. Main changes from v3: - Add coverity issue number Main changes from v2: - Fix coding style issue Wei Huang (2): raw/ifpga: terminate string filled by readlink with null raw/ifpga: use trusted buffer to free drivers/raw/ifpga/ifpga_rawde

[dpdk-dev] [PATCH v3 1/2] raw/ifpga: terminate string filled by readlink with null

2020-10-30 Thread Wei Huang
readlink() does not terminate string, add a null character at the end of the string if readlink() succeeds. Coverity issue: 362820 Fixes: 9c006c45d0c5 ("raw/ifpga: scan PCIe BDF device tree") Signed-off-by: Wei Huang --- v2: fix coding style issue v3: add coverity issue number --- drivers/raw/i

[dpdk-dev] [PATCH v3 2/2] raw/ifpga: use trusted buffer to free

2020-10-30 Thread Wei Huang
In rte_fpga_do_pr, calling function read() may taints argument buffer which turn to an untrusted value as argumen of rte_free(). Coverity issue: 279449 Fixes: ef1e8ede3da5 ("raw/ifpga: add Intel FPGA bus rawdev driver") Signed-off-by: Wei Huang --- v2: add fixes information to log v3: add coveri

[dpdk-dev] [PATCH v12] net/iavf: support flex desc metadata extraction

2020-10-30 Thread Jeff Guo
Enable metadata extraction for flexible descriptors in AVF, that would allow network function directly get metadata without additional parsing which would reduce the CPU cost for VFs. The enabling metadata extractions involve the metadata of VLAN/IPv4/IPv6/IPv6-FLOW/TCP/MPLS flexible descriptors, a

[dpdk-dev] [PATCH v12] net/iavf: support flex desc metadata extraction

2020-10-30 Thread Jeff Guo
Enable metadata extraction for flexible descriptors in AVF, that would allow network function directly get metadata without additional parsing which would reduce the CPU cost for VFs. The enabling metadata extractions involve the metadata of VLAN/IPv4/IPv6/IPv6-FLOW/TCP/MPLS flexible descriptors, a

Re: [dpdk-dev] [PATCH v2 2/2] net/mlx5: add flow sync API

2020-10-30 Thread Ferruh Yigit
On 10/30/2020 5:37 AM, Bing Zhao wrote: Hi Ferruh, Thanks for your comments. PSB -Original Message- From: Ferruh Yigit Sent: Friday, October 30, 2020 6:43 AM To: Slava Ovsiienko ; Bing Zhao ; Matan Azrad ; Ori Kam Cc: dev@dpdk.org; Raslan Darawsheh Subject: Re: [dpdk-dev] [PATCH v2 2

Re: [dpdk-dev] [PATCH 1/3] common/sfc_efx: introduce 128-bit unsigned integer compat

2020-10-30 Thread Ferruh Yigit
On 10/22/2020 1:24 PM, Andrew Rybchenko wrote: Intel SSE has __m128i, but ARMv8 has __uint128_t. So, add compat efsys_uint128_t to be used in driver source and have either __u128i or __uint128_t behind. Signed-off-by: Andrew Rybchenko Reviewed-by: Andy Moreton Series applied to dpdk-next-net

Re: [dpdk-dev] [PATCH] ethdev: rte_eth_rx_burst() nb_pkts requirements

2020-10-30 Thread Ferruh Yigit
On 10/27/2020 10:24 AM, Bruce Richardson wrote: On Mon, Sep 14, 2020 at 01:05:11PM +0200, Morten Brørup wrote: Updated description of rte_eth_rx_burst() to reflect what drivers, when using vector instructions, expect from nb_pkts. Also discussed on the mailing list here: http://inbox.dpdk.org/d

[dpdk-dev] [PATCH v2] doc: add the doc for mlx5 specific header

2020-10-30 Thread Bing Zhao
The file "rte_pmd_mlx5.h" is used to provide mlx5 PMD specific APIs and it needs to be included in the document generation. Signed-off-by: Bing Zhao Reviewed-by: Thomas Monjalon Acked-by: Ori Kam --- v2: use alphabet order properly for "doxy-api.conf.in" --- doc/api/doxy-api-index.md | 1 + do

Re: [dpdk-dev] [PATCH v12] net/iavf: support flex desc metadata extraction

2020-10-30 Thread Zhang, Qi Z
> -Original Message- > From: Guo, Jia > Sent: Friday, October 30, 2020 4:41 PM > To: Wu, Jingjing ; Zhang, Qi Z ; > Xing, Beilei ; Yigit, Ferruh > Cc: dev@dpdk.org; Wang, Haiyue ; Richardson, > Bruce ; Guo, Jia > Subject: [PATCH v12] net/iavf: support flex desc metadata extraction > >

Re: [dpdk-dev] [PATCH v10 0/9] Add PMD power mgmt

2020-10-30 Thread Liang, Ma
On 29 Oct 18:42, Thomas Monjalon wrote: > 27/10/2020 15:59, Liang Ma: > > Liang Ma (9): > > eal: add new x86 cpuid support for WAITPKG > > eal: add power management intrinsics > > eal: add intrinsics support check infrastructure > > EAL patches applied, thanks. thanks! > > > ethdev: add s

[dpdk-dev] [PATCH v8 01/23] event/dlb: add documentation and meson infrastructure

2020-10-30 Thread Timothy McDaniel
Note that config/rte_config.h contains several configuration switches, providing for fine control of the PMD's runtime behaviour. The meson infrastructure is expanded as additional files are added to this patchset. Adds announcement of availabililty of the new driver for Intel Dynamic Load Balanc

[dpdk-dev] [PATCH v8 00/23] Add DLB PMD

2020-10-30 Thread Timothy McDaniel
The following patch series adds support for a new eventdev PMD. The DLB PMD adds support for the Intel Dynamic Load Balancer (DLB) hardware. The DLB is a PCIe device that provides load-balanced, prioritized scheduling of core-to-core communication. The device consists of queues and arbiters that co

[dpdk-dev] [PATCH v8 02/23] event/dlb: add dynamic logging

2020-10-30 Thread Timothy McDaniel
This commit adds base support for dynamic logging. The default log level is NOTICE. Dynamic logging is used exclusively throughout this patchset. Signed-off-by: Timothy McDaniel Reviewed-by: Gage Eads --- drivers/event/dlb/dlb.c | 7 +++ drivers/event/dlb/dlb_log.h | 25 +++

[dpdk-dev] [PATCH v8 05/23] event/dlb: add inline functions

2020-10-30 Thread Timothy McDaniel
Add miscellaneous inline functions that may be called from multiple files. These functions include inline assembly of new x86 instructions, such as movdir64b, since they are not available as builtin functions in the minimum supported GCC version. Signed-off-by: Timothy McDaniel Reviewed-by: Gage

[dpdk-dev] [PATCH v8 03/23] event/dlb: add private data structures and constants

2020-10-30 Thread Timothy McDaniel
Add headers used internally by the PMD. They include constants, macros for device resources, structure definitions for hardware interfaces and software state, and various forward-declarations. Signed-off-by: Timothy McDaniel Reviewed-by: Gage Eads --- drivers/event/dlb/dlb_priv.h | 508 +++

[dpdk-dev] [PATCH v8 04/23] event/dlb: add definitions shared with LKM or shared code

2020-10-30 Thread Timothy McDaniel
Add headers containing structs and constants shared between the PMD and the shared code. The term shared code refers to the code that implements the hardware interface. The shared code is introduced in the probe patch, and then is extended as additional eventdev PMD entry points are added to the p

[dpdk-dev] [PATCH v8 07/23] event/dlb: add flexible interface

2020-10-30 Thread Timothy McDaniel
This commit introduces the flexible interface. This interface allows the core code to operate in PF mode (direct hardware access) or bifurcated mode (hardware configured via kernel driver). This driver currently only supports PF modei, but bifurcated mode will be added in a future patch-set. Note t

[dpdk-dev] [PATCH v8 06/23] event/dlb: add eventdev probe

2020-10-30 Thread Timothy McDaniel
Add the eventdev portion of probe, and parse command line options, but do not initialize hardware. Changes since v5 patch-set probe: Primary and secondary probe-time init has been removed, and will be introduced in subsequent patches contained in this patch-set. Hardware init has been moved to a

[dpdk-dev] [PATCH v8 11/23] event/dlb: add queue and port default conf

2020-10-30 Thread Timothy McDaniel
Add support for getting the queue and port default configuration. Signed-off-by: Timothy McDaniel Reviewed-by: Gage Eads --- drivers/event/dlb/dlb.c | 29 + 1 file changed, 29 insertions(+) diff --git a/drivers/event/dlb/dlb.c b/drivers/event/dlb/dlb.c index c038794

[dpdk-dev] [PATCH v8 09/23] event/dlb: add xstats

2020-10-30 Thread Timothy McDaniel
Add support for DLB xstats. Perform initialization and add standard xstats entry points Signed-off-by: Timothy McDaniel Reviewed-by: Gage Eads --- drivers/event/dlb/dlb.c| 23 + drivers/event/dlb/dlb_xstats.c | 1222 drivers/event/dlb/meson.bu

[dpdk-dev] [PATCH v8 08/23] event/dlb: add probe-time hardware init

2020-10-30 Thread Timothy McDaniel
This commit adds probe-time low level hardware initialization. It also adds probe-time init for both primary and secondary DPDK processes. Signed-off-by: Timothy McDaniel --- drivers/event/dlb/dlb.c | 158 +++- drivers/event/dlb/meson.build| 3 +- driv

[dpdk-dev] [PATCH v8 12/23] event/dlb: add queue setup

2020-10-30 Thread Timothy McDaniel
Load balanced (ldb) queues are setup here. Directed queues are not set up until link time, at which point we know the directed port ID. Directed queue setup will only fail if this queue is already setup or there are no directed queues left to configure. Signed-off-by: Timothy McDaniel Reviewed-by

[dpdk-dev] [PATCH v8 10/23] event/dlb: add infos get and configure

2020-10-30 Thread Timothy McDaniel
Add support for configuring the DLB hardware. In particular, this patch configures the DLB hardware's scheduling domain, such that it is provisioned with the requested number of ports and queues, provided sufficient resources are available. Individual queues and ports are configured later in port s

[dpdk-dev] [PATCH v8 14/23] event/dlb: add port link

2020-10-30 Thread Timothy McDaniel
Add port link entry point. Directed queues are identified and created at this stage. Their setup deferred until link-time, at which point we know the directed port ID. Directed queue setup will only fail if this queue is already setup or there are no directed queues left to configure. Signed-off-b

[dpdk-dev] [PATCH v8 13/23] event/dlb: add port setup

2020-10-30 Thread Timothy McDaniel
Configure the load balanded (ldb) or directed (dir) port. The consumer queue (CQ) and producer port (PP) are also set up here. Signed-off-by: Timothy McDaniel --- doc/guides/eventdevs/dlb.rst | 40 + drivers/event/dlb/dlb.c | 516 ++- drivers/event/dlb/dlb

[dpdk-dev] [PATCH v8 15/23] event/dlb: add port unlink and port unlinks in progress

2020-10-30 Thread Timothy McDaniel
Add supports for the port unlink(s) eventdev entry points. The unlink operation is an asynchronous operation executed by a control thread, and the unlinks-in-progress function reads a counter shared with the control thread. Port QE and memzone memory is freed here. Signed-off-by: Timothy McDaniel

[dpdk-dev] [PATCH v8 16/23] event/dlb: add eventdev start

2020-10-30 Thread Timothy McDaniel
Add support for the eventdev start entry point. DLB delays setting up single link resources until eventdev start, because it is only then that it can ascertain which ports have just one linked queue. Signed-off-by: Timothy McDaniel Reviewed-by: Gage Eads --- drivers/event/dlb/dlb.c

[dpdk-dev] [PATCH v8 18/23] event/dlb: add dequeue and its burst variants

2020-10-30 Thread Timothy McDaniel
Add support for dequeue, dequeue_burst, ... DLB does not currently support interrupts, but instead uses umonitor/umwait if supported by the processor. This allows the software to monitor and wait on writes to a cache-line. DLB supports normal and sparse cq mode. In normal mode the hardware will p

[dpdk-dev] [PATCH v8 17/23] event/dlb: add enqueue and its burst variants

2020-10-30 Thread Timothy McDaniel
Add support for enqueue and its variants. Signed-off-by: Timothy McDaniel Reviewed-by: Gage Eads --- doc/guides/eventdevs/dlb.rst | 163 ++- drivers/event/dlb/dlb.c | 682 +++ 2 files changed, 844 insertions(+), 1 deletion(-) diff --git a/do

[dpdk-dev] [PATCH v8 21/23] event/dlb: add PMD self-tests

2020-10-30 Thread Timothy McDaniel
Add a variety of self-tests for both ldb and directed ports/queues, as well as configure, start, stop, link, etc... Signed-off-by: Timothy McDaniel Reviewed-by: Gage Eads --- app/test/test_eventdev.c |7 + drivers/event/dlb/dlb.c |1 + drivers/event/dlb/dlb_selftest.c |

[dpdk-dev] [PATCH v8 19/23] event/dlb: add eventdev stop and close

2020-10-30 Thread Timothy McDaniel
Add support for eventdev stop and close entry points. Signed-off-by: Timothy McDaniel Reviewed-by: Gage Eads --- drivers/event/dlb/dlb.c | 256 +-- drivers/event/dlb/dlb_iface.c| 6 + drivers/event/dlb/dlb_iface.h| 6 + dr

[dpdk-dev] [PATCH v8 20/23] event/dlb: add PMD's token pop public interface

2020-10-30 Thread Timothy McDaniel
The PMD uses a public interface to allow applications to control the token pop mode. Supported token pop modes are as follows, and they impact core scheduling affinity for ldb ports. AUTO_POP: Pop the CQ tokens immediately after dequeueing. DELAYED_POP: Pop CQ tokens after (dequeue_depth - 1) even

[dpdk-dev] [PATCH v8 23/23] event/dlb: add timeout ticks entry point

2020-10-30 Thread Timothy McDaniel
Adds the timeout ticks conversion function. Signed-off-by: Timothy McDaniel Reviewed-by: Gage Eads --- drivers/event/dlb/dlb.c | 13 + 1 file changed, 13 insertions(+) diff --git a/drivers/event/dlb/dlb.c b/drivers/event/dlb/dlb.c index aa22d03..b21c9b1 100644 --- a/drivers/event/d

[dpdk-dev] [PATCH v8 22/23] event/dlb: add queue and port release

2020-10-30 Thread Timothy McDaniel
These entry points are NO-OPS. DLB does not support reconfiguring individual queues or ports. The entire device must be reconfigured. Signed-off-by: Timothy McDaniel --- drivers/event/dlb/dlb.c | 27 +++ 1 file changed, 27 insertions(+) diff --git a/drivers/event/dlb/dlb

Re: [dpdk-dev] [PATCH] net/iavf: fix invalid RSS type

2020-10-30 Thread Zhang, Qi Z
> -Original Message- > From: Su, Simei > Sent: Friday, October 30, 2020 11:17 AM > To: Zhang, Qi Z > Cc: dev@dpdk.org; Guo, Jia ; Guo, Junfeng > ; Su, Simei > Subject: [PATCH] net/iavf: fix invalid RSS type > > When a RSS rule with symmetric hash function, the RSS type shouldn't carr

[dpdk-dev] [PATCH v5 00/23] Add DLB2 PMD

2020-10-30 Thread Timothy McDaniel
The following patch series adds support for a new eventdev PMD. The DLB2 PMD adds support for the Intel Dynamic Load Balancer 2.0 (DLB2) hardware. The DLB2 is a PCIe device that provides load-balanced, prioritized scheduling of core-to-core communication. The device consists of queues and arbiters

[dpdk-dev] [PATCH v5 01/23] event/dlb2: add documentation and meson build infrastructure

2020-10-30 Thread Timothy McDaniel
Adds the meson build infrastructure, which includes compile-time constants in rte_config.h. DLB2 is only supported on Linux 64 bit X86 platforms at this time. Adds announcement of availabililty for the new driver for Intel Dynamic Load Balancer 2.0 hardware. Signed-off-by: Timothy McDaniel Revie

[dpdk-dev] [PATCH v5 02/23] event/dlb2: add dynamic logging

2020-10-30 Thread Timothy McDaniel
This commit adds base support for dynamic logging. The default log level is NOTICE. Dynamic logging is used exclusively throughout this patchset. Signed-off-by: Timothy McDaniel Reviewed-by: Gage Eads --- drivers/event/dlb2/dlb2.c | 7 +++ drivers/event/dlb2/dlb2_log.h | 25 +

[dpdk-dev] [PATCH v5 04/23] event/dlb2: add definitions shared with LKM or shared code

2020-10-30 Thread Timothy McDaniel
Add headers containing structs and constants shared between the PMD and the shared code. The term shared code refers to the code that implements the hardware interface. The shared code is introduced in the probe patch, and then is extended as additional eventdev PMD entry points are added to the p

[dpdk-dev] [PATCH v5 03/23] event/dlb2: add private data structures and constants

2020-10-30 Thread Timothy McDaniel
The header file dlb2_priv.h is used internally by the PMD. It include constants, macros for device resources, structure definitions for hardware interfaces and software state, and various forward-declarations. The header file rte_pmd_dlb2.h will be exported in a subsequent patch, but is included he

[dpdk-dev] [PATCH v5 05/23] event/dlb2: add inline functions

2020-10-30 Thread Timothy McDaniel
Add miscellaneous inline functions that may be called from multiple files. These functions include inline assembly of new x86 instructions, such as movdir64b, since they are not available as builtin functions in the minimum supported GCC version. Signed-off-by: Timothy McDaniel Reviewed-by: Gage

[dpdk-dev] [PATCH v5 07/23] event/dlb2: add flexible interface

2020-10-30 Thread Timothy McDaniel
This commit introduces the flexible interface. This interface allows the core code to operate in PF mode (direct hardware access) or bifurcated mode (hardware configured via kernel driver). This driver currently only supports PF mode but bifurcated mode will be added in a future DPDK patch-set. Not

[dpdk-dev] [PATCH v5 08/23] event/dlb2: add probe-time hardware init

2020-10-30 Thread Timothy McDaniel
This commit adds probe-time low level hardware initialization. It also adds probe-time init for both primary and secondary DPDK processes. Signed-off-by: Timothy McDaniel --- drivers/event/dlb2/dlb2.c | 188 +++- drivers/event/dlb2/meson.build | 3

[dpdk-dev] [PATCH v5 09/23] event/dlb2: add xstats

2020-10-30 Thread Timothy McDaniel
Add support for DLB2 xstats. Perform initialization and add standard xstats entry points. Signed-off-by: Timothy McDaniel Reviewed-by: Gage Eads Reviewed-by: Chen, Mike Ximing --- drivers/event/dlb2/dlb2.c| 35 +- drivers/event/dlb2/dlb2_xstats.c | 1240 +

[dpdk-dev] [PATCH v5 11/23] event/dlb2: add queue and port default conf

2020-10-30 Thread Timothy McDaniel
Add support for getting the queue and port default configuration. Signed-off-by: Timothy McDaniel Reviewed-by: Gage Eads --- drivers/event/dlb2/dlb2.c | 30 ++ 1 file changed, 30 insertions(+) diff --git a/drivers/event/dlb2/dlb2.c b/drivers/event/dlb2/dlb2.c index

[dpdk-dev] [PATCH v5 13/23] event/dlb2: add port setup

2020-10-30 Thread Timothy McDaniel
Configure the load balanded (ldb) or directed (dir) port. The consumer queue (CQ) and producer port (PP) are also set up here. Signed-off-by: Timothy McDaniel --- doc/guides/eventdevs/dlb2.rst | 75 +++ drivers/event/dlb2/dlb2.c | 498 drivers/even

[dpdk-dev] [PATCH v5 10/23] event/dlb2: add infos get and configure

2020-10-30 Thread Timothy McDaniel
Add support for configuring the DLB2 hardware. In particular, this patch configures the DLB2 hardware's scheduling domain, such that it is provisioned with the requested number of ports and queues, provided sufficient resources are available. Individual queues and ports are configured later in port

[dpdk-dev] [PATCH v5 14/23] event/dlb2: add port link

2020-10-30 Thread Timothy McDaniel
Add port link entry point. Directed queues are identified and created at this stage. Their setup deferred until link-time, at which point we know the directed port ID. Directed queue setup will only fail if this queue is already setup or there are no directed queues left to configure. Signed-off-b

[dpdk-dev] [PATCH v5 15/23] event/dlb2: add port unlink and port unlinks in progress

2020-10-30 Thread Timothy McDaniel
Add supports for the port unlink(s) eventdev entry points. The unlink operation is an asynchronous operation executed by a control thread, and the unlinks-in-progress function reads a counter shared with the control thread. Signed-off-by: Timothy McDaniel Reviewed-by: Gage Eads --- drivers/even

[dpdk-dev] [PATCH v5 12/23] event/dlb2: add queue setup

2020-10-30 Thread Timothy McDaniel
Load balanced (ldb) queues are setup here. Directed queues are not set up until link time, at which point we know the directed port ID. Directed queue setup will only fail if this queue is already setup or there are no directed queues left to configure. Signed-off-by: Timothy McDaniel Reviewed-by

[dpdk-dev] [PATCH v5 16/23] event/dlb2: add eventdev start

2020-10-30 Thread Timothy McDaniel
Add support for the eventdev start entry point. We delay initializing some resources until eventdev start, since the number of linked queues can be used to determine if we are dealing with a ldb or dir resource. If this is a device restart, then the previous configuration will be reapplied. Signed

[dpdk-dev] [PATCH v5 18/23] event/dlb2: add dequeue and its burst variants

2020-10-30 Thread Timothy McDaniel
Add support for dequeue, dequeue_burst, ... DLB2 does not currently support interrupts, but instead use umonitor/umwait if supported by the processor. This allows the software to monitor and wait on writes to a cache-line. DLB2 supports normal and sparse cq mode. In normal mode the hardware will

[dpdk-dev] [PATCH v5 17/23] event/dlb2: add enqueue and its burst variants

2020-10-30 Thread Timothy McDaniel
Add support for enqueue and its variants. Signed-off-by: Timothy McDaniel Reviewed-by: Gage Eads --- doc/guides/eventdevs/dlb2.rst | 118 + drivers/event/dlb2/dlb2.c | 578 ++ 2 files changed, 696 insertions(+) diff --git a/doc/guides/eventde

[dpdk-dev] [PATCH v5 19/23] event/dlb2: add eventdev stop and close

2020-10-30 Thread Timothy McDaniel
Add support for eventdev stop and close entry points. Signed-off-by: Timothy McDaniel Reviewed-by: Gage Eads --- drivers/event/dlb2/dlb2.c | 257 +++-- drivers/event/dlb2/dlb2_iface.c| 6 + drivers/event/dlb2/dlb2_iface.h| 6 +

[dpdk-dev] [PATCH v5 20/23] event/dlb2: add PMD's token pop public interface

2020-10-30 Thread Timothy McDaniel
The PMD uses a public interface to allow applications to control the token pop mode. Supported token pop modes are as follows, and they impact core scheduling affinity for ldb ports. AUTO_POP: Pop the CQ tokens immediately after dequeueing. DELAYED_POP: Pop CQ tokens after (dequeue_depth - 1) even

[dpdk-dev] [PATCH v5 22/23] event/dlb2: add queue and port release

2020-10-30 Thread Timothy McDaniel
DLB does not support reconfiguring individual queues or ports on the fly. The entire device must be reconfigured. Previously allocated port QE and memzone memory is freed in this patch. Signed-off-by: Timothy McDaniel Reviewed-by: Gage Eads --- drivers/event/dlb2/dlb2.c | 24 +++

[dpdk-dev] [PATCH v5 21/23] event/dlb2: add PMD self-tests

2020-10-30 Thread Timothy McDaniel
Add a variety of self-tests for both ldb and directed ports/queues, as well as configure, start, stop, link, etc... Signed-off-by: Timothy McDaniel Reviewed-by: Gage Eads --- app/test/test_eventdev.c |7 + drivers/event/dlb2/dlb2.c |1 + drivers/event/dlb2/dlb2_selfte

[dpdk-dev] [PATCH v5 23/23] event/dlb2: add timeout ticks entry point

2020-10-30 Thread Timothy McDaniel
Adds the timeout ticks conversion function. Signed-off-by: Timothy McDaniel Reviewed-by: Gage Eads --- drivers/event/dlb2/dlb2.c | 13 + 1 file changed, 13 insertions(+) diff --git a/drivers/event/dlb2/dlb2.c b/drivers/event/dlb2/dlb2.c index 4b4719f..dea61fc 100644 --- a/drivers/e

Re: [dpdk-dev] [PATCH v10 0/9] Add PMD power mgmt

2020-10-30 Thread Thomas Monjalon
30/10/2020 10:36, Liang, Ma: > On 29 Oct 18:42, Thomas Monjalon wrote: > > 27/10/2020 15:59, Liang Ma: > > > Liang Ma (9): > > > eal: add new x86 cpuid support for WAITPKG > > > eal: add power management intrinsics > > > eal: add intrinsics support check infrastructure > > > > EAL patches ap

Re: [dpdk-dev] eal: DPDK: 18.11.6 version rte_eal_init() function cleans the runtime directory in 5.4.35 kernel

2020-10-30 Thread Burakov, Anatoly
On 29-Oct-20 5:40 PM, Mohakud, Amiya Ranjan wrote: Hi Anatoly Thanks for the reply. Do you have a sample code for primary and secondary processes which I can try in my setup? And once reproduced, can let you know. We have DPDK applications in our product with which I always see this issue.

Re: [dpdk-dev] [PATCH v5 00/23] Add DLB2 PMD

2020-10-30 Thread Thomas Monjalon
30/10/2020 10:43, Timothy McDaniel: > - note that the code still uses its private byte-encoded versions of > umonitor/umwait, rather than the new functions in the power > patch that are built on top of those intrinsics. This is intentional. Why? Now these intrinsics are available in the main b

Re: [dpdk-dev] [PATCH DPDK_KMODS v7 1/2] linux/igb_uio: remove DPDK dependency for building igb_uio

2020-10-30 Thread Ferruh Yigit
On 10/29/2020 11:17 PM, Hariprasad Govindharajan wrote: The igb_uio source code requires interrupt modes defined as MACROS and enums in the header file rte_pci_dev_features.h. Now, the definitions are moved to the igb_uio.c file so that this module can be built without building DPDK Signed-off-b

Re: [dpdk-dev] [PATCH v10 3/9] eal: add intrinsics support check infrastructure

2020-10-30 Thread Burakov, Anatoly
On 29-Oct-20 9:27 PM, David Marchand wrote: On Tue, Oct 27, 2020 at 4:00 PM Liang Ma wrote: Currently, it is not possible to check support for intrinsics that are platform-specific, cannot be abstracted in a generic way, or do not have support on all architectures. The CPUID flags can be used

Re: [dpdk-dev] [PATCH] net/mlx5: fix the flow sync flags

2020-10-30 Thread Ferruh Yigit
On 10/28/2020 12:23 PM, Bing Zhao wrote: In order to synchronize the flow steering cache with hardware in DR mode, the new function is introduced. The function needs to use both flags of "MLX5DV_DR_DOMAIN_SYNC_FLAGS_SW/HW", or else some actions and rules may get stuck in the work queue. And in s

Re: [dpdk-dev] [prefix=DPDK_KMODS v6 1/2] linux/igb_uio: remove DPDK dependency for building igb_uio

2020-10-30 Thread Thomas Monjalon
29/10/2020 22:14, Thomas Monjalon: > 29/10/2020 21:10, Hariprasad Govindharajan: > > + * These enums and MACRO definitions are copied from the > > s/These/This/ > s/MACRO/macro/ Sorry, after a second read in your last version, I think "These" was good because we have enum and macros. But maybe "e

Re: [dpdk-dev] [PATCH v10 3/9] eal: add intrinsics support check infrastructure

2020-10-30 Thread Thomas Monjalon
30/10/2020 11:09, Burakov, Anatoly: > On 29-Oct-20 9:27 PM, David Marchand wrote: > > On Tue, Oct 27, 2020 at 4:00 PM Liang Ma wrote: > >> > >> Currently, it is not possible to check support for intrinsics that > >> are platform-specific, cannot be abstracted in a generic way, or do not > >> have

Re: [dpdk-dev] [PATCH v5 00/23] Add DLB2 PMD

2020-10-30 Thread McDaniel, Timothy
> -Original Message- > From: Thomas Monjalon > Sent: Friday, October 30, 2020 5:02 AM > To: McDaniel, Timothy > Cc: dev@dpdk.org; Carrillo, Erik G ; Eads, Gage > ; Van Haaren, Harry ; > jer...@marvell.com; david.march...@redhat.com > Subject: Re: [PATCH v5 00/23] Add DLB2 PMD > > 30/10/2

Re: [dpdk-dev] [PATCH v5 00/23] Add DLB2 PMD

2020-10-30 Thread Jerin Jacob
On Fri, Oct 30, 2020 at 3:46 PM McDaniel, Timothy wrote: > > > -Original Message- > > From: Thomas Monjalon > > Sent: Friday, October 30, 2020 5:02 AM > > To: McDaniel, Timothy > > Cc: dev@dpdk.org; Carrillo, Erik G ; Eads, Gage > > ; Van Haaren, Harry ; > > jer...@marvell.com; david.mar

Re: [dpdk-dev] [PATCH v5 00/23] Add DLB2 PMD

2020-10-30 Thread Thomas Monjalon
30/10/2020 11:32, Jerin Jacob: > McDaniel, Timothy wrote: > > From: Thomas Monjalon > > > 30/10/2020 10:43, Timothy McDaniel: > > > > - note that the code still uses its private byte-encoded versions of > > > > umonitor/umwait, rather than the new functions in the power > > > > patch that are

Re: [dpdk-dev] [PATCH v4 2/6] build: refactor Arm build

2020-10-30 Thread Juraj Linkeš
> -Original Message- > From: Honnappa Nagarahalli > Sent: Thursday, October 29, 2020 9:54 PM > To: Juraj Linkeš ; bruce.richard...@intel.com; > Ruifeng Wang ; Phil Yang ; > vcchu...@amazon.com; Dharmik Thakkar ; > jerinjac...@gmail.com; hemant.agra...@nxp.com > Cc: dev@dpdk.org; nd ; Hon

Re: [dpdk-dev] [dpdk-stable] [PATCH] app/testpmd: don't allow to dynamic change nbcore

2020-10-30 Thread Ferruh Yigit
On 10/29/2020 4:43 AM, Dharmik Thakkar wrote: <...> On Oct 27, 2020, at 1:42 AM, Zhou Zhenghua wrote: When changing the number of forwarding cores in runtime, two issues may be encountered: - If the setting nbcore little than current nbcore, the forwarding thread will still running on

Re: [dpdk-dev] [PATCH v12] net/iavf: support flex desc metadata extraction

2020-10-30 Thread Ferruh Yigit
On 10/30/2020 8:40 AM, Jeff Guo wrote: Enable metadata extraction for flexible descriptors in AVF, that would allow network function directly get metadata without additional parsing which would reduce the CPU cost for VFs. The enabling metadata extractions involve the metadata of VLAN/IPv4/IPv6/I

[dpdk-dev] [PATCH dpdk-kmods v8 1/2] linux/igb_uio: remove DPDK dependency for building igb_uio

2020-10-30 Thread Hariprasad Govindharajan
The igb_uio source code requires interrupt modes defined as macros and enums in the header file rte_pci_dev_features.h. Now, the definitions are moved to the igb_uio.c file so that this module can be built without building DPDK Signed-off-by: Hariprasad Govindharajan --- linux/igb_uio/igb_uio.c

[dpdk-dev] [PATCH dpdk-kmods v8 2/2] linux/igb_uio: add Makefile to build the igb_uio module

2020-10-30 Thread Hariprasad Govindharajan
This patch provides a Makefile to the user, to build the igb_uio module when required by running make inside the source directory Signed-off-by: Hariprasad Govindharajan --- This patch will be part of dpdk-kmods repo https://git.dpdk.org/dpdk-kmods/ --- v8: Changed the commit message based on the

Re: [dpdk-dev] [PATCH dpdk-kmods v8 1/2] linux/igb_uio: remove DPDK dependency for building igb_uio

2020-10-30 Thread Ferruh Yigit
On 10/30/2020 10:52 AM, Hariprasad Govindharajan wrote: The igb_uio source code requires interrupt modes defined as macros and enums in the header file rte_pci_dev_features.h. Now, the definitions are moved to the igb_uio.c file so that this module can be built without building DPDK Signed-off-b

Re: [dpdk-dev] [PATCH v5 08/11] build: optional NUMA and cpu counts detection

2020-10-30 Thread Juraj Linkeš
> -Original Message- > From: Bruce Richardson > Sent: Wednesday, October 28, 2020 4:04 PM > To: Juraj Linkeš > Cc: ruifeng.w...@arm.com; honnappa.nagaraha...@arm.com; > phil.y...@arm.com; vcchu...@amazon.com; dharmik.thak...@arm.com; > jerinjac...@gmail.com; hemant.agra...@nxp.com; dev@

Re: [dpdk-dev] [PATCH] net/mlx5: fix the flow sync flags

2020-10-30 Thread Bing Zhao
Thanks for your help, Ferruh. BR. Bing > -Original Message- > From: Ferruh Yigit > Sent: Friday, October 30, 2020 6:10 PM > To: Bing Zhao ; Slava Ovsiienko > ; Matan Azrad ; Ori Kam > > Cc: dev@dpdk.org; Raslan Darawsheh > Subject: Re: [dpdk-dev] [PATCH] net/mlx5: fix the flow sync fla

[dpdk-dev] [PATCH 2/2] net/bnxt: pass dev args by reference

2020-10-30 Thread Somnath Kotur
Pass 'eth_da' pointer instead of pass by value to bnxt_rep_port_probe() Coverity issue: 360841 Fixes: 322bd6e70272 ("net/bnxt: add port representor infrastructure") Cc: sta...@dpdk.org Signed-off-by: Somnath Kotur Reviewed-by: Kalesh Anakkur Purayil --- drivers/net/bnxt/bnxt_ethdev.c | 10 +++

[dpdk-dev] [PATCH 1/2] net/bnxt: log failure for switch domain free

2020-10-30 Thread Somnath Kotur
Check and log an error message if switch domain free API fails Coverity issue: 362757 Fixes: 322bd6e70272 ("net/bnxt: add port representor infrastructure") Cc: sta...@dpdk.org Signed-off-by: Somnath Kotur Reviewed-by: Kalesh Anakkur Purayil --- drivers/net/bnxt/bnxt_ethdev.c | 10 --

Re: [dpdk-dev] [PATCH v12] net/iavf: support flex desc metadata extraction

2020-10-30 Thread Zhang, Qi Z
> -Original Message- > From: Ferruh Yigit > Sent: Friday, October 30, 2020 6:52 PM > To: Guo, Jia ; Wu, Jingjing ; > Zhang, Qi Z ; Xing, Beilei > Cc: dev@dpdk.org; Wang, Haiyue ; Richardson, > Bruce > Subject: Re: [PATCH v12] net/iavf: support flex desc metadata extraction > > On 10/3

Re: [dpdk-dev] [PATCH v5 11/11] build: update Arm builds with makefile flags

2020-10-30 Thread Juraj Linkeš
> -Original Message- > From: Bruce Richardson > Sent: Wednesday, October 28, 2020 4:08 PM > To: Juraj Linkeš > Cc: ruifeng.w...@arm.com; honnappa.nagaraha...@arm.com; > phil.y...@arm.com; vcchu...@amazon.com; dharmik.thak...@arm.com; > jerinjac...@gmail.com; hemant.agra...@nxp.com; dev@

Re: [dpdk-dev] [PATCH dpdk-kmods v8 1/2] linux/igb_uio: remove DPDK dependency for building igb_uio

2020-10-30 Thread Thomas Monjalon
30/10/2020 12:03, Ferruh Yigit: > On 10/30/2020 10:52 AM, Hariprasad Govindharajan wrote: > > The igb_uio source code requires interrupt modes defined as > > macros and enums in the header file rte_pci_dev_features.h. > > Now, the definitions are moved to the igb_uio.c file so that > > this module

[dpdk-dev] [PATCH 0/6] net/ena: fixes and missing version/doc udate

2020-10-30 Thread Michal Krawczyk
Hi, This patchset contains few fixes, and two of them are very important: * Fix for setting Rx checksum flags * align IO cq allocation to 4k Also it adds missing release notes regarding the ENI metrics which should go with the patches upstreamed previously, and also increases the driver version

[dpdk-dev] [PATCH 1/6] net/ena: fix getting xstats global stats offset

2020-10-30 Thread Michal Krawczyk
There was a bug in a code, which was reading stat_offset value from the ena_stats_rx_strings array instead of ena_stats_global_strings. It wasn't causing real problems just because ena_stats_rx_strings was not smaller than ena_stats_global_strings and both arrays hold the same offsets. Fixes: 783

[dpdk-dev] [PATCH 3/6] net/ena: change name of the supported PCI device IDs

2020-10-30 Thread Michal Krawczyk
The ID 0xEC21 is not associated with LLQ feature of the device, so it would be misleading for the user. Because of that, the current identifier is more precise. Together with code update, the documentation was changed to reflect current changes Signed-off-by: Michal Krawczyk Reviewed-by: Igor Ch

[dpdk-dev] [PATCH 2/6] net/ena: fix setting Rx checksum flags in mbuf

2020-10-30 Thread Michal Krawczyk
The driver was never setting PKT_RX_*_CKSUM_GOOD flags, so the only way of checking if the checksum was checked was by testing for the PKT_RX_*_CKSUM_BAD. In that situation, the application couldn't detect if the checksum was valid or unknown, as unknown flag is equal to 0. Moreover, the l3_csum_e

[dpdk-dev] [PATCH 4/6] net/ena/base: align IO cq allocation to a 4K

2020-10-30 Thread Michal Krawczyk
Latest generation HW requires IO completion queue descriptors to be aligned to a 4K in order to achieve the best performance. Because of that, the new allocation macros were added, which allows driver to allocate the memory with specified alignemnt. The previous allocation macros are now wrappers

[dpdk-dev] [PATCH 6/6] net/ena: upgrade driver version to v2.2.0

2020-10-30 Thread Michal Krawczyk
The v2.2.0 adds support for network interface metrics, includes some bug fixes and updates HAL to the latest version. Signed-off-by: Michal Krawczyk Reviewed-by: Igor Chauskin Reviewed-by: Guy Tzalik --- doc/guides/rel_notes/release_20_11.rst | 7 +++ drivers/net/ena/ena_ethdev.c

[dpdk-dev] [PATCH 5/6] doc: mark ARMv8 as supported by ENA PMD

2020-10-30 Thread Michal Krawczyk
The ARMv8 platform support was tested and works fine with the ENA PMD. It can be used on the AWS a1.* and m6g.* instances. The ARMv8 support in ENA is at least from v19.11, where the VFIO DPDK driver was fixed to work with 32-bit applications compiled for arm. Signed-off-by: Michal Krawczyk Rev

  1   2   3   4   5   >