Re: [dpdk-dev] [PATCH v4 0/3] vhost: fix fd an memory leaks

2020-11-13 Thread Maxime Coquelin
On 11/12/20 6:10 PM, Maxime Coquelin wrote: > This series fixes several leaks in Vhost-user requests > handling. > > Thanks to Xuan Ding from Intel for reporting these > issues. > > Changes in v4: > - Fix wrong return value in set_mem_table (Xueming) > > Changes in v3: > - Remove the right cl

Re: [dpdk-dev] [PATCH v5] examples/vhost: fix ioat dependency issue

2020-11-13 Thread Maxime Coquelin
On 11/12/20 4:49 PM, Cheng Jiang wrote: > Fix vhost-switch compiling issue when ioat dependency is missing. > Change 'RTE_x86' check into 'RTE_RAW_IOAT' check in meson build file. > Use 'RTE_RAW_IOAT' to control conditional compiling in source file. > Clean some codes. > > Fixes: abec60e7115d (

Re: [dpdk-dev] [PATCH v7 1/1] vfio: modify spapr iommu support to use static window sizing

2020-11-13 Thread Thomas Monjalon
10/11/2020 18:43, David Christensen: > The SPAPR IOMMU requires that a DMA window size be defined before memory > can be mapped for DMA. Current code dynamically modifies the DMA window > size in response to every new memory allocation which is potentially > dangerous because all existing mappings

Re: [dpdk-dev] [PATCH v1] examples/vhost: fix missing args length check

2020-11-13 Thread Maxime Coquelin
On 11/6/20 4:24 AM, Cheng Jiang wrote: > Add args length check before copying to fix the coverity issue. > > Fixes: 3a04ecb21420 ("examples/vhost: add async vhost args parsing") > Coverity issue: 363741 > > Signed-off-by: Cheng Jiang > --- > examples/vhost/main.c | 6 ++ > 1 file changed

Re: [dpdk-dev] [PATCH v2] examples/vhost: fix string split error handling issue

2020-11-13 Thread Maxime Coquelin
On 11/11/20 10:08 AM, Cheng Jiang wrote: > Add checking return value of string split function to fix the > coverity issue. > > Fixes: 3a04ecb21420 ("examples/vhost: add async vhost args parsing") > Coverity issue: 363739 > > Signed-off-by: Cheng Jiang > --- > v2: checked args_nr explicitly >

[dpdk-dev] [PATCH] common/sfc_efx/base: fix macro to extract from 256-bit type

2020-11-13 Thread Andrew Rybchenko
Fixes: eda1cc20c3bc ("common/sfc_efx/base: add 256-bit type") Signed-off-by: Andrew Rybchenko Reviewed-by: Andy Moreton --- drivers/common/sfc_efx/base/efx_types.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/common/sfc_efx/base/efx_types.h b/drivers/common/sfc_e

Re: [dpdk-dev] [PATCH v1] eal/arm: fix clang build of native target

2020-11-13 Thread Thomas Monjalon
> > When doing Clang build with '-mcpu=native' on N1 platform, build failed > > with: > > ../lib/librte_eal/arm/include/rte_atomic_64.h:76:39: > > error: instruction requires: lse > > __ATOMIC128_CAS_OP(__cas_128_release, "caspl") > > > > This is because native detection for Neoverse N1 was ad

Re: [dpdk-dev] [PATCH 1/2] crypto/armv8: update meson build

2020-11-13 Thread Thomas Monjalon
05/11/2020 17:11, Bruce Richardson: > On Thu, Nov 05, 2020 at 09:33:15AM -0600, Dharmik Thakkar wrote: > > With pkg-config support available within AArch64crypto library, > > meson option 'armv8_crypto_dir' can be removed. > > PKG_CONFIG_PATH environment variable should be set appropriately > > to

Re: [dpdk-dev] [PATCH 1/2] crypto/armv8: update meson build

2020-11-13 Thread Thomas Monjalon
13/11/2020 10:29, Thomas Monjalon: > 05/11/2020 17:11, Bruce Richardson: > > On Thu, Nov 05, 2020 at 09:33:15AM -0600, Dharmik Thakkar wrote: > > > With pkg-config support available within AArch64crypto library, > > > meson option 'armv8_crypto_dir' can be removed. > > > PKG_CONFIG_PATH environment

Re: [dpdk-dev] [kmods PATCH v2] windows: normalize line-endings

2020-11-13 Thread Thomas Monjalon
13/11/2020 08:06, Dmitry Kozlyuk: > Hi Luca, > > Thank you for taking the initiative. However, the patch fails to apply on my > system, and that's the reason I've been delaying my own): > > $ git am \[kmods\ PATCH\ v2\]\ windows:\ normalize\ line-endings > Applying: windows: normalize line-endin

[dpdk-dev] [kmods PATCH v3 1/2] windows: remove .gitattributes

2020-11-13 Thread luca . boccassi
From: Luca Boccassi It forces files line ending conversions, making applying patches impossible. Remove it. Line endings will be normalized in the next patch. Signed-off-by: Luca Boccassi --- v3: split the patch, and remove first the gitattributes, making it possible to apply the second pat

[dpdk-dev] [kmods PATCH v3 2/2] windows: normalize line-endings

2020-11-13 Thread luca . boccassi
From: Luca Boccassi MSBuild XML files have to use CRLF line-endings, otherwise any change results in the whole file being rewritten with CRLF line-endings by Visual Studio. However, it's inconvenient to have such files checked-out with CLRF in Unix environments. Suggested-by: John Alexander Sig

Re: [dpdk-dev] [kmods PATCH v2] windows: normalize line-endings

2020-11-13 Thread Luca Boccassi
On Fri, 2020-11-13 at 10:43 +0100, Thomas Monjalon wrote: > 13/11/2020 08:06, Dmitry Kozlyuk: > > Hi Luca, > > > > Thank you for taking the initiative. However, the patch fails to apply on my > > system, and that's the reason I've been delaying my own): > > > > $ git am \[kmods\ PATCH\ v2\]\ wind

Re: [dpdk-dev] [PATCH] event/dlb2: add missing delayed token pop logic

2020-11-13 Thread Jerin Jacob
On Thu, Nov 12, 2020 at 2:43 AM Chen, Mike Ximing wrote: > > > > > -Original Message- > > From: dev On Behalf Of Timothy McDaniel > > Sent: Wednesday, November 11, 2020 3:27 PM > > Cc: dev@dpdk.org; Carrillo, Erik G ; Eads, Gage > > ; Van Haaren, Harry ; > > jer...@marvell.com; tho...@mon

Re: [dpdk-dev] [PATCH] app/eventdev: fix segfault with incorrect timer adadpters

2020-11-13 Thread Jerin Jacob
On Thu, Nov 12, 2020 at 11:13 PM wrote: > > From: Pavan Nikhilesh > > Fix SEGFAULT when nb_timer_adapters command line parameter is > set to 0. > > Fixes: 98c6292105d4 ("app/eventdev: add options for event timer adapter") > Cc: sta...@dpdk.org > > Signed-off-by: Pavan Nikhilesh Acked-by: Jerin

[dpdk-dev] [pull-request] next-eventdev 20.11 RC4

2020-11-13 Thread Jerin Jacob Kollanukkaran
The following changes since commit 4630290af46ed44a58515067b6d2add9c044252a: mbuf: move pool pointer in first half (2020-11-12 16:39:10 +0100) are available in the Git repository at: http://dpdk.org/git/next/dpdk-next-eventdev for you to fetch changes up to c919c1039c07408da9b4ea0fd341818

Re: [dpdk-dev] [RFC PATCH] build: allow passing extra config header to build

2020-11-13 Thread Bruce Richardson
On Fri, Nov 13, 2020 at 04:55:57AM +, Honnappa Nagarahalli wrote: > > > > > > To allow per-build override of some settings, without having to change > > DPDK source-code files, i.e. rte_config.h, we can add an option to > > allow the user to pass in a file containing their own defines for th

Re: [dpdk-dev] [RFC] app/testpmd: fix MTU after device configure

2020-11-13 Thread Zhang, Qi Z
> -Original Message- > From: dev On Behalf Of Ferruh Yigit > Sent: Friday, November 6, 2020 2:10 AM > To: Lu, Wenzhuo ; Xing, Beilei > ; Iremonger, Bernard > Cc: Yigit, Ferruh ; dev@dpdk.org; Yang, SteveX > ; Thomas Monjalon ; > Andrew Rybchenko ; Ananyev, Konstantin > ; Olivier Matz ;

[dpdk-dev] [PATCH] net/pcap: fix registration of timestamp dynamic field

2020-11-13 Thread Olivier Matz
In pcap pmd, the timestamp mbuf dynamic field is mandatory. When the pcap pmd is created in a secondary process (this is the case for pdump), it cannot be registered because this is not allowed from a secondary process. To ensure that the field is properly registered, do it from probe() instead of

[dpdk-dev] [PATCH v10 01/15] build: alias default build as generic

2020-11-13 Thread Juraj Linkeš
The current machine='default' build name is not descriptive. The actual default build is machine='native'. Add an alternative string which does the same build and better describes what we're building: machine='generic'. Leave machine='default' for backwards compatibility. Signed-off-by: Juraj Link

[dpdk-dev] [PATCH v10 02/15] build: rename Arm build variables

2020-11-13 Thread Juraj Linkeš
Rename Arm build variables and values so that they better conform to Arm specifications. Also rename generically sounding variable to names that better capture what the variables hold. Rename machine_args_generic to part_number_config_arm since the variable contains more than just the generic mach

[dpdk-dev] [PATCH v10 00/15] Arm build options rework

2020-11-13 Thread Juraj Linkeš
The current way of specifying Arm configuration options is insufficient since we can't identify the SoC we're building for from the MIDR information. For example, we can't distinguish between N1SDP, Graviton2 or Ampere Altra. Add a way to specify the cpu count and numa node count for cross builds

[dpdk-dev] [PATCH v10 03/15] build: remove unused or superfluous variables

2020-11-13 Thread Juraj Linkeš
Remove variables that were either not used, referenced just once or not needed. Signed-off-by: Juraj Linkeš Reviewed-by: Ruifeng Wang Reviewed-by: Honnappa Nagarahalli --- config/arm/meson.build | 28 +++- 1 file changed, 7 insertions(+), 21 deletions(-) diff --git a/c

[dpdk-dev] [PATCH v10 05/15] build: simplify how Arm flags are processed

2020-11-13 Thread Juraj Linkeš
Set flags in one loop. Append flags to a list and use the list in the loop. Signed-off-by: Juraj Linkeš Reviewed-by: Honnappa Nagarahalli --- config/arm/meson.build | 37 + 1 file changed, 17 insertions(+), 20 deletions(-) diff --git a/config/arm/meson.build

[dpdk-dev] [PATCH v10 04/15] build: reformat and move Arm config and comments

2020-11-13 Thread Juraj Linkeš
Change formatting so that it's more consistent and readable, add/modify comments/stdout messages, move configuration options to more appropriate places and make the order consistent according to these rules: 1. First list generic configuration options, then list options that may be overwritten.

[dpdk-dev] [PATCH v10 09/15] build: use native machine args in Arm native build

2020-11-13 Thread Juraj Linkeš
Letting the compiler decide is going to yield the best results for native builds, so use native machine args usable for both GCC and Clang. Signed-off-by: Juraj Linkeš --- config/arm/meson.build | 54 ++ 1 file changed, 28 insertions(+), 26 deletions(-) d

[dpdk-dev] [PATCH v10 07/15] build: isolate configuration for generic build

2020-11-13 Thread Juraj Linkeš
Use generic configuration for the only build where it makes sense - the generic build. For other builds, if we don't know either of implementer ID or part number, the build is not supported. Add part numbers to cross files where fallback to generic configuration is assumed. Signed-off-by: Juraj Li

[dpdk-dev] [PATCH v10 06/15] build: organize Arm config into dict

2020-11-13 Thread Juraj Linkeš
Use dictionary lookup instead of checking for existing variables, iterating over all elements in the list or checking lists for optional configuration. Move variable contents into the dictionary for variables that would be referenced only once. Fallback to generic part number if the discovered part

[dpdk-dev] [PATCH v10 08/15] eal/arm: fix clang build of native target

2020-11-13 Thread Juraj Linkeš
From: Ruifeng Wang When doing Clang build with '-mcpu=native' on N1 platform, build failed with: ../lib/librte_eal/arm/include/rte_atomic_64.h:76:39: error: instruction requires: lse __ATOMIC128_CAS_OP(__cas_128_release, "caspl") This is because native detection for Neoverse N1 was added

[dpdk-dev] [PATCH v10 10/15] build: optional NUMA and cpu counts detection

2020-11-13 Thread Juraj Linkeš
Add an option to automatically discover the host's numa and cpu counts and use those values for a non cross-build. Give users the option to override the per-arch default values or values from cross files by specifying them on the command line with -Dmax_lcores and -Dmax_numa_nodes. Signed-off-by:

[dpdk-dev] [PATCH v10 11/15] build: add core and NUMA counts to cross files

2020-11-13 Thread Juraj Linkeš
Add support for setting core count and numa nodes in cross files. The values specified in cross files will override the default values. Also add missing default values to Arm config. Signed-off-by: Juraj Linkeš Reviewed-by: Honnappa Nagarahalli --- config/arm/arm64_armada_linux_gcc

[dpdk-dev] [PATCH v10 12/15] build: disable Arm drivers

2020-11-13 Thread Juraj Linkeš
A few options that disabled drivers in the old makefiles were improperly ported to the meson build system. Fix this by adding a to the list of disabled drivers, similarly how the command line option works. Remove unneeded driver options ported from the old makefile system. Add support for removing

[dpdk-dev] [PATCH v10 15/15] config: fix Arm implementer and its SoCs

2020-11-13 Thread Juraj Linkeš
Fix the implementer and part number of DPAA and ARMADA SoCs. The current values of 16 cores and 1 NUMA node don't cover all SoCs from the Arm implementer, e.g. Taishan 2280 has 64 cores and 4 NUMA nodes. Increase these to 64 and 4 to widen the coverage. Add configuration to SoC options where smalle

[dpdk-dev] [PATCH v10 13/15] build: disable libnuma in cross builds

2020-11-13 Thread Juraj Linkeš
Some Arm SoCs are not NUMA systems. Add the capability to disable NUMA for cross build and disable NUMA in Arm cross files. Signed-off-by: Juraj Linkeš Reviewed-by: Honnappa Nagarahalli --- config/arm/arm64_armada_linux_gcc | 1 + config/arm/arm64_bluefield_linux_gcc | 1

[dpdk-dev] [PATCH v10 14/15] build: add Arm SoC meson option

2020-11-13 Thread Juraj Linkeš
Add Arm SoC configuration to Arm meson.build and add a meson option to enable those options for native builds. This is preferable to specifying a cross file when doing aarch64 -> aarch64 builds, since the cross file specifies the toolchain as well. Signed-off-by: Juraj Linkeš Reviewed-by: Honnapp

[dpdk-dev] [PATCH v11 02/15] build: alias default build as generic

2020-11-13 Thread Juraj Linkeš
The current machine='default' build name is not descriptive. The actual default build is machine='native'. Add an alternative string which does the same build and better describes what we're building: machine='generic'. Leave machine='default' for backwards compatibility. Signed-off-by: Juraj Link

[dpdk-dev] [PATCH v11 00/15] Arm build options rework

2020-11-13 Thread Juraj Linkeš
The current way of specifying Arm configuration options is insufficient since we can't identify the SoC we're building for from the MIDR information. For example, we can't distinguish between N1SDP, Graviton2 or Ampere Altra. Add a way to specify the cpu count and numa node count for cross builds

[dpdk-dev] [PATCH v11 01/15] crypto/armv8: replace meson option with pkg-config support

2020-11-13 Thread Juraj Linkeš
From: Dharmik Thakkar With pkg-config support available within AArch64crypto library, meson option 'armv8_crypto_dir' can be removed. PKG_CONFIG_PATH environment variable should be set appropriately to use the crypto library. Suggested-by: Thomas Monjalon Signed-off-by: Dharmik Thakkar Reviewe

[dpdk-dev] [PATCH v11 04/15] build: remove unused or superfluous variables

2020-11-13 Thread Juraj Linkeš
Remove variables that were either not used, referenced just once or not needed. Signed-off-by: Juraj Linkeš Reviewed-by: Ruifeng Wang Reviewed-by: Honnappa Nagarahalli --- config/arm/meson.build | 28 +++- 1 file changed, 7 insertions(+), 21 deletions(-) diff --git a/c

[dpdk-dev] [PATCH v11 03/15] build: rename Arm build variables

2020-11-13 Thread Juraj Linkeš
Rename Arm build variables and values so that they better conform to Arm specifications. Also rename generically sounding variable to names that better capture what the variables hold. Rename machine_args_generic to part_number_config_arm since the variable contains more than just the generic mach

[dpdk-dev] [PATCH v11 05/15] build: reformat and move Arm config and comments

2020-11-13 Thread Juraj Linkeš
Change formatting so that it's more consistent and readable, add/modify comments/stdout messages, move configuration options to more appropriate places and make the order consistent according to these rules: 1. First list generic configuration options, then list options that may be overwritten.

[dpdk-dev] [PATCH v11 06/15] build: simplify how Arm flags are processed

2020-11-13 Thread Juraj Linkeš
Set flags in one loop. Append flags to a list and use the list in the loop. Signed-off-by: Juraj Linkeš Reviewed-by: Honnappa Nagarahalli --- config/arm/meson.build | 37 + 1 file changed, 17 insertions(+), 20 deletions(-) diff --git a/config/arm/meson.build

[dpdk-dev] [PATCH v11 07/15] build: organize Arm config into dict

2020-11-13 Thread Juraj Linkeš
Use dictionary lookup instead of checking for existing variables, iterating over all elements in the list or checking lists for optional configuration. Move variable contents into the dictionary for variables that would be referenced only once. Fallback to generic part number if the discovered part

[dpdk-dev] [PATCH v11 08/15] build: isolate configuration for generic build

2020-11-13 Thread Juraj Linkeš
Use generic configuration for the only build where it makes sense - the generic build. For other builds, if we don't know either of implementer ID or part number, the build is not supported. Add part numbers to cross files where fallback to generic configuration is assumed. Signed-off-by: Juraj Li

[dpdk-dev] [PATCH v11 09/15] build: use native machine args in Arm native build

2020-11-13 Thread Juraj Linkeš
Letting the compiler decide is going to yield the best results for native builds, so use native machine args usable for both GCC and Clang. Signed-off-by: Juraj Linkeš --- config/arm/meson.build | 54 ++ 1 file changed, 28 insertions(+), 26 deletions(-) d

[dpdk-dev] [PATCH v11 10/15] build: optional NUMA and cpu counts detection

2020-11-13 Thread Juraj Linkeš
Add an option to automatically discover the host's numa and cpu counts and use those values for a non cross-build. Give users the option to override the per-arch default values or values from cross files by specifying them on the command line with -Dmax_lcores and -Dmax_numa_nodes. Signed-off-by:

[dpdk-dev] [PATCH v11 12/15] build: disable Arm drivers

2020-11-13 Thread Juraj Linkeš
A few options that disabled drivers in the old makefiles were improperly ported to the meson build system. Fix this by adding a to the list of disabled drivers, similarly how the command line option works. Remove unneeded driver options ported from the old makefile system. Add support for removing

[dpdk-dev] [PATCH v11 14/15] build: add Arm SoC meson option

2020-11-13 Thread Juraj Linkeš
Add Arm SoC configuration to Arm meson.build and add a meson option to enable those options for native builds. This is preferable to specifying a cross file when doing aarch64 -> aarch64 builds, since the cross file specifies the toolchain as well. Signed-off-by: Juraj Linkeš Reviewed-by: Honnapp

[dpdk-dev] [PATCH v11 11/15] build: add core and NUMA counts to cross files

2020-11-13 Thread Juraj Linkeš
Add support for setting core count and numa nodes in cross files. The values specified in cross files will override the default values. Also add missing default values to Arm config. Signed-off-by: Juraj Linkeš Reviewed-by: Honnappa Nagarahalli --- config/arm/arm64_armada_linux_gcc

[dpdk-dev] [PATCH v11 13/15] build: disable libnuma in cross builds

2020-11-13 Thread Juraj Linkeš
Some Arm SoCs are not NUMA systems. Add the capability to disable NUMA for cross build and disable NUMA in Arm cross files. Signed-off-by: Juraj Linkeš Reviewed-by: Honnappa Nagarahalli --- config/arm/arm64_armada_linux_gcc | 1 + config/arm/arm64_bluefield_linux_gcc | 1

[dpdk-dev] [PATCH v11 15/15] config: fix Arm implementer and its SoCs

2020-11-13 Thread Juraj Linkeš
Fix the implementer and part number of DPAA and ARMADA SoCs. The current values of 16 cores and 1 NUMA node don't cover all SoCs from the Arm implementer, e.g. Taishan 2280 has 64 cores and 4 NUMA nodes. Increase these to 64 and 4 to widen the coverage. Add configuration to SoC options where smalle

[dpdk-dev] [PATCH] app/testpmd: fix MTU after device configure

2020-11-13 Thread Ferruh Yigit
In 'rte_eth_dev_configure()', if 'DEV_RX_OFFLOAD_JUMBO_FRAME' is not set the max frame size is limited to 'RTE_ETHER_MAX_LEN' (1518). This is mistake because for the PMDs that has frame size bigger than "RTE_ETHER_HDR_LEN + RTE_ETHER_CRC_LEN" (18 bytes), the MTU becomes less than 1500, causing a va

Re: [dpdk-dev] [PATCH v6] net/ice: fix outer checksum on cvl unknown

2020-11-13 Thread Ferruh Yigit
On 11/9/2020 6:06 AM, Murphy Yang wrote: Currently, driver does not support parse UDP outer checksum flag of tunneled packets. When execute 'csum set outer-udp hw 0' and 'csum parse-tunnel on 0' commands to enable hardware UDP outer checksum. This patch supports parse UDP outer checksum flag of

Re: [dpdk-dev] [PATCH] net/virtio: enable packet data prefetch on x86

2020-11-13 Thread Liu, Yong
+ more people into this conversation. IMHO, restore to previous state is the best choice by now. > -Original Message- > From: David Marchand > Sent: Friday, November 13, 2020 3:27 PM > To: Liu, Yong > Cc: Maxime Coquelin ; Xia, Chenbo > ; dev ; Richardson, Bruce > > Subject: Re: [dpdk

[dpdk-dev] [PATCH v2 00/11] Examples compilation fixes

2020-11-13 Thread David Marchand
I tested external compilation for all possible examples (in my env). The result is this series. -- David Marchand Changelog since v1: - added patch 7 to fix performance-thread example, - reworked last patch by introducing a new -Dexamples=buildall special value and removed exceptions for examp

[dpdk-dev] [PATCH v2 02/11] examples/ipsec-gw: fix build with pkg-config

2020-11-13 Thread David Marchand
flow.c: In function ‘parse_flow_tokens’: flow.c:153:23: error: taking address of packed member of ‘struct rte_ipv4_hdr’ may result in an unaligned pointer value [-Werror=address-of-packed-member] 153 | if (ipv4_addr_cpy(&rule->ipv4.spec.hdr.src_addr, | ^~~~

[dpdk-dev] [PATCH v2 01/11] examples/fips_validation: fix build with pkg-config

2020-11-13 Thread David Marchand
When this example started using rte_cryptodev_sym_session_pool_create, the part for pkg-config builds was not updated. Fixes: 261bbff75e34 ("examples: use separate crypto session mempools") Cc: sta...@dpdk.org Signed-off-by: David Marchand Acked-by: Bruce Richardson --- examples/fips_validatio

[dpdk-dev] [PATCH v2 04/11] examples/l2fwd-crypto: fix build with pkg-config

2020-11-13 Thread David Marchand
Two issues fixed here. First add the experimental flag. Then fix a link issue with the crypto scheduler driver: /usr/bin/ld: /tmp/cchr7aHA.o: in function `main': main.c:(.text.startup+0x1673): undefined reference to `rte_cryptodev_scheduler_workers_get' collect2: error: ld returned 1 exit status

[dpdk-dev] [PATCH v2 03/11] examples/kni: fix build with pkg-config

2020-11-13 Thread David Marchand
rm -f build/kni build/kni-static build/kni-shared test -d build && rmdir -p build || true [...] /usr/bin/ld: /tmp/cc72ssnK.o: undefined reference to symbol 'pthread_join@@GLIBC_2.2.5' This example explicitly call pthread API and should be linked against the pthread library. Fixes: 724beb913b44 ("

[dpdk-dev] [PATCH v2 05/11] examples/l3fwd-graph: fix static build

2020-11-13 Thread David Marchand
This example missed the rework from commit 8549295db07b ("build/pkg-config: improve static linking flags"). Fixes: 08bd1a174461 ("examples/l3fwd-graph: add graph-based l3fwd skeleton") Signed-off-by: David Marchand Acked-by: Bruce Richardson --- examples/l3fwd-graph/Makefile | 2 +- 1 file cha

[dpdk-dev] [PATCH v2 06/11] examples/ntb: fix clean target

2020-11-13 Thread David Marchand
When introducing this example, the cleanup from commit 7e9562a107f1 ("examples: fix make clean when using pkg-config") was missed. Fixes: c5eebf85badc ("examples/ntb: add example for NTB") Cc: sta...@dpdk.org Signed-off-by: David Marchand Acked-by: Bruce Richardson Acked-by: Xiaoyun Li --- ex

[dpdk-dev] [PATCH v2 07/11] examples/performance-thread: fix build with pkg-config

2020-11-13 Thread David Marchand
main.c: In function ‘lthread_tx’: main.c:2091:25: error: implicit declaration of function ‘sched_getcpu’; did you mean ‘sched_getparam’? [-Werror=implicit-function-declaration] 2091 | tx_conf->conf.cpu_id = sched_getcpu(); | ^~~~ |

[dpdk-dev] [PATCH v2 08/11] examples/vhost_blk: fix build with pkg-config

2020-11-13 Thread David Marchand
vhost_blk.c: In function ‘ctrlr_worker’: vhost_blk.c:543:2: warning: implicit declaration of function ‘CPU_ZERO’ [-Wimplicit-function-declaration] 543 | CPU_ZERO(&cpuset); | ^~~~ vhost_blk.c:544:2: warning: implicit declaration of function ‘CPU_SET’ [-Wimplicit-function-declaration]

[dpdk-dev] [PATCH v2 09/11] examples/rxtx_callbacks: fix build with pkg-config

2020-11-13 Thread David Marchand
This example is missing the experimental flag since it uses an experimental API. Fixes: cd1dadeb9b2a ("examples/rxtx_callbacks: support HW timestamp") Cc: sta...@dpdk.org Signed-off-by: David Marchand Acked-by: Bruce Richardson --- examples/rxtx_callbacks/Makefile | 2 ++ 1 file changed, 2 ins

[dpdk-dev] [PATCH v2 10/11] examples: restore trace point

2020-11-13 Thread David Marchand
Before make removal, those examples were built with experimental flag for tracepoints to be compiled in but the pkg-config part of those makefiles were missed. Fixes: 78d44153de8f ("ethdev: add tracepoints") Signed-off-by: David Marchand Acked-by: Bruce Richardson --- examples/cmdline/Makefile

[dpdk-dev] [PATCH v2 11/11] devtools: compile all buildable examples with pkg-config

2020-11-13 Thread David Marchand
Rather than just installing all examples, we can use the build checks to filter out any examples that are missing dependencies or are otherwise unbuildable on the current system. Introduce a new "buildable" special value for the -Dexamples= meson option, this way existing behavior on installing all

Re: [dpdk-dev] [PATCH 2/7] examples/l3fwd-acl: enhance getopt_long usage

2020-11-13 Thread Ananyev, Konstantin
Hi, > > Instead of using getopt_long return value, strcmp was used to > compare the input parameters with the struct option array. This > patch get rid of all those strcmp by directly binding each longopt > with an int enum. This is to improve readability and consistency in > all examples. > >

Re: [dpdk-dev] [PATCH v2 11/11] devtools: compile all buildable examples with pkg-config

2020-11-13 Thread David Marchand
Thomas, On Fri, Nov 13, 2020 at 1:28 PM David Marchand wrote: > - a fix for the vhost is waiting in next-virtio, I assume it will get > pulled before this series, If next-virtio is not pulled yet, we can add a temp: dpdk_examples_exclude += ['vhost'] -- David Marchand

Re: [dpdk-dev] [dpdk-stable] [PATCH] net/af_xdp: fix 32-bit build for older kernels

2020-11-13 Thread Ferruh Yigit
On 11/12/2020 4:35 PM, Ciara Loftus wrote: 'uint64_t' is used to hold pointers in multiple locations in the copy-mode code (used for kernels before 5.4). For a 32-bit build this assumption is wrong and results in build errors. This commit replaces such instances of 'uint64_t' with 'uintptr_t'. W

Re: [dpdk-dev] [PATCH v2 08/11] examples/vhost_blk: fix build with pkg-config

2020-11-13 Thread Maxime Coquelin
On 11/13/20 1:24 PM, David Marchand wrote: > vhost_blk.c: In function ‘ctrlr_worker’: > vhost_blk.c:543:2: warning: implicit declaration of function ‘CPU_ZERO’ > [-Wimplicit-function-declaration] > 543 | CPU_ZERO(&cpuset); > | ^~~~ > vhost_blk.c:544:2: warning: implicit declaration

Re: [dpdk-dev] [PATCH] net/tap: Allow all-zero checksum for UDP over IPv4

2020-11-13 Thread Ferruh Yigit
On 11/11/2020 9:31 AM, Ferruh Yigit wrote: On 11/11/2020 7:23 AM, Michael Pfeiffer wrote: Hi, On Tue, 2020-11-10 at 15:59 +, Ferruh Yigit wrote: On 11/9/2020 2:22 PM, Michael Pfeiffer wrote: Unlike TCP, UDP checksums are optional and may be zero to indicate "not set" [RFC 768] (except for

Re: [dpdk-dev] [PATCH] table: fix exact match lookup

2020-11-13 Thread David Marchand
On Thu, Nov 5, 2020 at 4:27 PM Cristian Dumitrescu wrote: > > Fix for the exact match lookup function. > > Fixes: d0a00966618b ("table: add exact match SWX table") > > Signed-off-by: Cristian Dumitrescu > Signed-off-by: Churchill Khangar Applied, thanks. -- David Marchand

Re: [dpdk-dev] [PATCH V2] doc: add the SWX pipeline type to the prog_guide

2020-11-13 Thread David Marchand
On Tue, Nov 10, 2020 at 9:03 PM Cristian Dumitrescu wrote: > > Add the new SWX pipeline type to the Programmer's Guide. Thanks for this high level description. Could you work on documenting how to start and use the new pipeline example too? > > V2 changes: fixed 2 typos. Patch changelog should

Re: [dpdk-dev] [PATCH v9 07/14] build: isolate configuration for generic build

2020-11-13 Thread Thomas Monjalon
11/11/2020 14:18, Juraj Linkeš: > Use generic configuration for the only build where it makes sense - the > generic build. For other builds, if we don't know either of implementer > ID or part number, the build is not supported. > Add part numbers to cross files where fallback to generic configurat

Re: [dpdk-dev] [PATCH] net/pcap: fix registration of timestamp dynamic field

2020-11-13 Thread Olivier Matz
On Fri, Nov 13, 2020 at 11:39:57AM +0100, Olivier Matz wrote: > In pcap pmd, the timestamp mbuf dynamic field is mandatory. When the > pcap pmd is created in a secondary process (this is the case for pdump), > it cannot be registered because this is not allowed from a secondary > process. > > To e

Re: [dpdk-dev] [PATCH v2] gso: add VXLAN UDP GSO support

2020-11-13 Thread Ananyev, Konstantin
... > diff --git a/lib/librte_gso/rte_gso.c b/lib/librte_gso/rte_gso.c > index 896350e..fb76a21 100644 > --- a/lib/librte_gso/rte_gso.c > +++ b/lib/librte_gso/rte_gso.c > @@ -11,6 +11,7 @@ > #include "gso_common.h" > #include "gso_tcp4.h" > #include "gso_tunnel_tcp4.h" > +#include "gso_tunnel_ud

Re: [dpdk-dev] [PATCH] example/qos_sched: fix option -i in usage

2020-11-13 Thread David Marchand
On Thu, Nov 5, 2020 at 9:57 AM David Marchand wrote: > > On Mon, Nov 2, 2020 at 12:59 PM Ibtisam Tariq > wrote: > > > > The short option written for interactive mode is --i in usage of > > this qos_sched example. Actually, it is -i. > > > > Fixes: cfd5c971e5e ("examples/qos_sched: add stats") Cc

Re: [dpdk-dev] [PATCH v4] build: add pkg-config validation

2020-11-13 Thread David Marchand
On Thu, Nov 5, 2020 at 1:37 PM Gregory Etelson wrote: > > DPDK relies on pkg-config(1) to provide correct parameters for > compiler and linker used in application build. > Inaccurate build parameters, produced by pkg-config from DPDK .pc > files could fail application build or cause unpredicted re

Re: [dpdk-dev] [PATCH] windows: minor install fix

2020-11-13 Thread Thomas Monjalon
31/10/2020 07:56, Nick Connolly: > Don't run symlink-drivers-solibs.sh as part of 'install' because > Windows doesn't support shell scripts. > > Signed-off-by: Nick Connolly > Tested-by: Ranjit Menon > Acked-by: Ranjit Menon Applied with title "build: fix install on Windows", thanks.

Re: [dpdk-dev] [PATCH v11 00/15] Arm build options rework

2020-11-13 Thread Ruifeng Wang
> -Original Message- > From: Juraj Linkeš > Sent: Friday, November 13, 2020 7:38 PM > To: bruce.richard...@intel.com; Ruifeng Wang ; > Honnappa Nagarahalli ; Phil Yang > ; vcchu...@amazon.com; Dharmik Thakkar > ; jerinjac...@gmail.com; > hemant.agra...@nxp.com; Ajit Khaparde (ajit.khapa...

Re: [dpdk-dev] [PATCH v2 04/11] examples/l2fwd-crypto: fix build with pkg-config

2020-11-13 Thread Bruce Richardson
On Fri, Nov 13, 2020 at 01:24:23PM +0100, David Marchand wrote: > Two issues fixed here. > > First add the experimental flag. > Then fix a link issue with the crypto scheduler driver: > /usr/bin/ld: /tmp/cchr7aHA.o: in function `main': > main.c:(.text.startup+0x1673): undefined reference to > `rte

Re: [dpdk-dev] [PATCH v1] build: add Wformat to fix gcc compile error

2020-11-13 Thread Walsh, Conor
Thanks for your reply Thomas, that's no problem. I will expand the explanation for this patch when I push a v2, v2 will hopefully also address the issues it caused with the icc build. /Conor > -Original Message- > From: Thomas Monjalon > Sent: Thursday 12 November 2020 18:47 > To: Walsh,

Re: [dpdk-dev] [PATCH v11 00/15] Arm build options rework

2020-11-13 Thread Juraj Linkeš
> -Original Message- > From: Ruifeng Wang > Sent: Friday, November 13, 2020 2:52 PM > To: Juraj Linkeš ; bruce.richard...@intel.com; > Honnappa Nagarahalli ; Phil Yang > ; vcchu...@amazon.com; Dharmik Thakkar > ; jerinjac...@gmail.com; > hemant.agra...@nxp.com; Ajit Khaparde (ajit.khapa.

Re: [dpdk-dev] [PATCH v2] examples/qos_sched: update profile oversubscribe config file

2020-11-13 Thread David Marchand
On Thu, Nov 5, 2020 at 10:39 AM Dharmappa, Savinay wrote: > Hi Thomas, > >> I see that this patch is not applied on rc2. When can this will be applied > >> ? will it be part of rc3 ?. Please let me know Please, pay attention when editing replies, this mail of yours added Cristian token again in

Re: [dpdk-dev] [PATCH] net/pcap: fix registration of timestamp dynamic field

2020-11-13 Thread Ferruh Yigit
On 11/13/2020 1:13 PM, Olivier Matz wrote: On Fri, Nov 13, 2020 at 11:39:57AM +0100, Olivier Matz wrote: In pcap pmd, the timestamp mbuf dynamic field is mandatory. When the pcap pmd is created in a secondary process (this is the case for pdump), it cannot be registered because this is not allow

[dpdk-dev] [PATCH v2] net/tap: Allow all-zero checksum for UDP over IPv4

2020-11-13 Thread Michael Pfeiffer
Unlike TCP, UDP checksums are optional and may be zero to indicate "not set" [RFC 768] (except for IPv6, where this prohibited [RFC 8200]). Add this special case to the checksum offload emulation in net/tap. Signed-off-by: Michael Pfeiffer --- v2: * Added comment. drivers/net/tap/rte_eth_tap.c

Re: [dpdk-dev] [PATCH v2] windows: minor build fixes

2020-11-13 Thread Thomas Monjalon
12/11/2020 22:35, Tal Shnaiderman: > > Subject: Re: [dpdk-dev] [PATCH v2] windows: minor build fixes > > > > Missing / incorrect '--in-reply-to'. Please ignore - still learning the > > process! > > > > On 31/10/2020 06:43, Nick Connolly wrote: > > > Meson versions >= 0.54.0 include support for h

Re: [dpdk-dev] [PATCH v9 07/14] build: isolate configuration for generic build

2020-11-13 Thread Juraj Linkeš
> -Original Message- > From: Thomas Monjalon > Sent: Friday, November 13, 2020 2:11 PM > To: Juraj Linkeš > Cc: bruce.richard...@intel.com; ruifeng.w...@arm.com; > honnappa.nagaraha...@arm.com; phil.y...@arm.com; > vcchu...@amazon.com; dharmik.thak...@arm.com; jerinjac...@gmail.com; > he

Re: [dpdk-dev] [PATCH v2 2/2] net/mlx5: fix Rx descriptor status returned value

2020-11-13 Thread Slava Ovsiienko
Hi, Maxime > -Original Message- > From: Maxime Leroy > Sent: Thursday, November 12, 2020 17:39 > To: Matan Azrad ; Shahaf Shuler ; > Slava Ovsiienko ; Olivier Matz > > Cc: dev@dpdk.org; Didier Pallard > Subject: [PATCH v2 2/2] net/mlx5: fix Rx descriptor status returned value > > From:

Re: [dpdk-dev] [PATCH v2 11/11] devtools: compile all buildable examples with pkg-config

2020-11-13 Thread Bruce Richardson
On Fri, Nov 13, 2020 at 01:24:30PM +0100, David Marchand wrote: > Rather than just installing all examples, we can use the build checks to > filter out any examples that are missing dependencies or are otherwise > unbuildable on the current system. > Introduce a new "buildable" special value for th

Re: [dpdk-dev] [PATCH v2 11/11] devtools: compile all buildable examples with pkg-config

2020-11-13 Thread David Marchand
On Fri, Nov 13, 2020 at 3:06 PM Bruce Richardson wrote: > > On Fri, Nov 13, 2020 at 01:24:30PM +0100, David Marchand wrote: > > Rather than just installing all examples, we can use the build checks to > > filter out any examples that are missing dependencies or are otherwise > > unbuildable on the

Re: [dpdk-dev] [PATCH v2 04/11] examples/l2fwd-crypto: fix build with pkg-config

2020-11-13 Thread David Marchand
On Fri, Nov 13, 2020 at 2:53 PM Bruce Richardson wrote: > > +NEED_CRYPTO_SCHEDULER = $(shell echo RTE_CRYPTO_SCHEDULER | $(CPP) > > $(CFLAGS) -P - | tail -1) > > +ifeq ($(NEED_CRYPTO_SCHEDULER), 1) > > Sorry for the last-minute comment, but I wonder for this check if we can do > better by adding

Re: [dpdk-dev] [EXTERNAL] [PATCH v2] windows: minor build fixes

2020-11-13 Thread Thomas Monjalon
> > Meson versions >= 0.54.0 include support for handling /implib > > with msvc link. Specifying it explicitly causes failures when > > linking against the dll. Tested using Link 14.27.29112.0 and > > Clang 11.0.0. > > > > There were a number of changes to the way that import libraries > > are han

Re: [dpdk-dev] [PATCH v9 07/14] build: isolate configuration for generic build

2020-11-13 Thread Thomas Monjalon
13/11/2020 15:03, Juraj Linkeš: > From: Thomas Monjalon > > 11/11/2020 14:18, Juraj Linkeš: > > > Use generic configuration for the only build where it makes sense - > > > the generic build. For other builds, if we don't know either of > > > implementer ID or part number, the build is not supporte

Re: [dpdk-dev] [PATCH v9 07/14] build: isolate configuration for generic build

2020-11-13 Thread Juraj Linkeš
> -Original Message- > From: Thomas Monjalon > Sent: Friday, November 13, 2020 3:18 PM > To: Juraj Linkeš > Cc: bruce.richard...@intel.com; ruifeng.w...@arm.com; > honnappa.nagaraha...@arm.com; phil.y...@arm.com; > vcchu...@amazon.com; dharmik.thak...@arm.com; jerinjac...@gmail.com; > h

Re: [dpdk-dev] [PATCH v2 11/11] devtools: compile all buildable examples with pkg-config

2020-11-13 Thread Bruce Richardson
On Fri, Nov 13, 2020 at 03:14:14PM +0100, David Marchand wrote: > On Fri, Nov 13, 2020 at 3:06 PM Bruce Richardson > wrote: > > > > On Fri, Nov 13, 2020 at 01:24:30PM +0100, David Marchand wrote: > > > Rather than just installing all examples, we can use the build checks to > > > filter out any ex

Re: [dpdk-dev] [PATCH] mempool: fix ignore return value Coverity issue

2020-11-13 Thread Thomas Monjalon
05/11/2020 14:58, Olivier Matz: > On Thu, Nov 05, 2020 at 01:51:14PM +, David Hunt wrote: > > Coverity flags that rte_mempool_ops_dequeue_bulk() is called without > > checking the return value. > > > > This ignoring is intentional, so this patch gets the return code, then > > uses RTE_SET_USED

[dpdk-dev] [PATCH v12 00/14] Arm build options rework

2020-11-13 Thread Juraj Linkeš
The current way of specifying Arm configuration options is insufficient since we can't identify the SoC we're building for from the MIDR information. For example, we can't distinguish between N1SDP, Graviton2 or Ampere Altra. Add a way to specify the cpu count and numa node count for cross builds

[dpdk-dev] [PATCH v12 01/14] build: alias default build as generic

2020-11-13 Thread Juraj Linkeš
The current machine='default' build name is not descriptive. The actual default build is machine='native'. Add an alternative string which does the same build and better describes what we're building: machine='generic'. Leave machine='default' for backwards compatibility. Signed-off-by: Juraj Link

[dpdk-dev] [PATCH v12 03/14] build: remove unused or superfluous variables

2020-11-13 Thread Juraj Linkeš
Remove variables that were either not used, referenced just once or not needed. Signed-off-by: Juraj Linkeš Reviewed-by: Ruifeng Wang Reviewed-by: Honnappa Nagarahalli --- config/arm/meson.build | 28 +++- 1 file changed, 7 insertions(+), 21 deletions(-) diff --git a/c

  1   2   >