Signed-off-by: Ido Goshen
---
v2:
* sum all queues (rx_missed_total += fix)
* null pcap protection
* inter stop/start persistancy (counter won't reset on stop)
drivers/net/pcap/rte_eth_pcap.c | 28
1 file changed, 28 insertions(+)
diff --git a/drivers/net/pcap/rte_e
Hi, Honnappa, Konstantin and Stephen
Thanks very much for your attention of this patch. Based on your opinion,
Ruifeng and I discuss about this and make a summary：
On 1/28/21 5:31 PM, Xueming(Steven) Li wrote:
>
>>> The patch of device SF capability, but seems I misunderstood your
>>> suggestion.
>>> Let me explain process to create a SF:
>>> 1. SF can be created on the fly with scripts, unlike VF which is statically
>>> pre-created.
>>
>> Is there a maxim
Hi Maxime.
We found three virtio issues and bad commit is this patch set. Could you help
to take a look?
https://bugs.dpdk.org/show_bug.cgi?id=631
Issue1: vdev_primary_secondary/Virtio_primary_and_secondary_process: start
dpdk-symmetric_mp occur core dumped in vm
Issue2: start testpmd occur co
Sorry, a mistake happens in the picture, after Wrk_cmd == WRK_CMD_RUN, it
should be a rmb rather than wmb.
> -邮件原件-
> 发件人: Honnappa Nagarahalli
> 发送时间: 2021年1月30日 9:24
> 收件人: Stephen Hemminger
> 抄送: Ananyev, Konstantin ; Feifei Wang
> ; dev@dpdk.org; nd ; Ruifeng
> Wang ; Honnappa Nagar
Hi Yinan,
On 2/1/21 9:44 AM, Wang, Yinan wrote:
> Hi Maxime.
>
> We found three virtio issues and bad commit is this patch set. Could you help
> to take a look?
Thanks for the testing and reports.
I'm already working on Bz630, will keep you updated.
> https://bugs.dpdk.org/show_bug.cgi?id=631
> -Original Message-
> From: Ferruh Yigit
> Sent: Thursday, 28 January 2021 20:21
> To: Ido Goshen
> Cc: dev@dpdk.org
> Subject: Re: [PATCH 1/1] net/pcap: imissed stats support
>
> On 1/25/2021 5:58 PM, Ido Goshen wrote:
> > Signed-off-by: Ido Goshen
>
> <...>
>
> > @@ -695,6 +708,1
Hi, everyone
Sorry for that there may be a problem in the e-mail format.
Please see the picture according to the following link:
https://ibb.co/SQ7yGfW
Best Regards
Feifei
> -邮件原件-
> 发件人: Feifei Wang
> 发送时间: 2021年2月1日 16:49
> 收件人: Honnappa Nagarahalli ; Stephen
> Hemminger
> 抄送: Ananye
While debugging a driver I was looking at the code and realized that
eventdev_info_get_t typedef is defined with void return value but documentation
for it says it should return 0
lib/librte_eventdev/eventdev_pmd.h:
...
* @return
* Returns 0 on success
*/
typedef void (*eventdev_info_get_t)(s
On 2/1/2021 8:53 AM, Ido Goshen wrote:
-Original Message-
From: Ferruh Yigit
Sent: Thursday, 28 January 2021 20:21
To: Ido Goshen
Cc: dev@dpdk.org
Subject: Re: [PATCH 1/1] net/pcap: imissed stats support
On 1/25/2021 5:58 PM, Ido Goshen wrote:
Signed-off-by: Ido Goshen
<...>
@
This patch includes several updates of the shared RSS action:
(1)
The shared RSS action, introduced recently, uses existing definitions
of the regular RSS action.
The new defined value MLX5_RSS_HASH_IPV4_TCP uses existing definition
IBV_RX_HASH_SRC_PORT_TCP twice, instead of using
IBV_RX_HASH_SRC_
When running in client mode, the listen file descriptor
is not initialized, and so has value 0. At destroy time,
the listen FD is closed if its value is greater than or
equal to zero, which causes STDIN to be closed.
Fixes: 949735312f5e ("net/virtio: move vhost-user specifics to its backend")
Bugz
> -Original Message-
> From: dev On Behalf Of Fredrik A Lindgren
> Sent: Monday, February 1, 2021 9:22 AM
> To: dev@dpdk.org
> Subject: [dpdk-dev] Question: typedef of eventdev_info_get_t bug?
>
> While debugging a driver I was looking at the code and realized that
> eventdev_info_get_t t
All,
Update the test status for Intel part. Till now 50% is executed and no critical
issue blocked the test.
# Basic Intel(R) NIC testing
* PF/VF(i40e,ixgbe and igb): 90% is tested. 2 issues are found but not are
big issue.
* PF/VF(ICE): 40% is tested. 2 issues are found regarding vf_vlan_st
On Mon, Feb 1, 2021 at 10:33 AM Maxime Coquelin
wrote:
>
> When running in client mode, the listen file descriptor
> is not initialized, and so has value 0. At destroy time,
> the listen FD is closed if its value is greater than or
> equal to zero, which causes STDIN to be closed.
>
> Fixes: 94973
Hi Harry,
You are correct, multiple structs with dev_infos_get defined in them caused me
to jump to wrong implementation.
Still a bit "wrong" that comment for eventdev_info_get_t for event setup states
returns 0 on success.
Using older version of
https://github.com/Xilinx/dma_ip_drivers/tree/
> -Original Message-
> From: Fredrik A Lindgren
> Sent: Monday, February 1, 2021 10:02 AM
> To: Van Haaren, Harry ; dev@dpdk.org
> Subject: RE: Question: typedef of eventdev_info_get_t bug?
>
> Hi Harry,
>
> You are correct, multiple structs with dev_infos_get defined in them caused
> m
On 2/1/2021 8:30 AM, Ido Goshen wrote:
Signed-off-by: Ido Goshen
---
v2:
* sum all queues (rx_missed_total += fix)
* null pcap protection
* inter stop/start persistancy (counter won't reset on stop)
drivers/net/pcap/rte_eth_pcap.c | 28
1 file changed, 28 inserti
I'm not 100% familiar with contribution guidelines of DPDK community and since
I'm doing this on work hours Corporate praxis is to get legal approval to
provide contributions to opensource
So if you have the time and already are familiar with contributing to DPDK feel
free to submit such patch
On 1/26/21 11:15 AM, Maxime Coquelin wrote:
>
> Only functionnal change in this second part is making the
> Vhost-user server mode blocking at init time, as long as
> a client is not connected. The goal of this change is to
> make the Vhost-user support much more robust, as without
> blocking, the
CC: ovs-dev
On 2/1/21 2:00 PM, Ilya Maximets wrote:
> On 1/26/21 11:15 AM, Maxime Coquelin wrote:
>>
>> Only functionnal change in this second part is making the
>> Vhost-user server mode blocking at init time, as long as
>> a client is not connected. The goal of this change is to
>> make the Vhos
Hi Ilya,
On 2/1/21 2:03 PM, Ilya Maximets wrote:
> CC: ovs-dev
>
> On 2/1/21 2:00 PM, Ilya Maximets wrote:
>> On 1/26/21 11:15 AM, Maxime Coquelin wrote:
>>>
>>> Only functionnal change in this second part is making the
>>> Vhost-user server mode blocking at init time, as long as
>>> a client is
The PMD info get API has a void return type. Remove the
@return 0 Success doxygen comment as it doesn't make sense here.
Reported-by: Fredrik A Lindgren
Signed-off-by: Harry van Haaren
---
lib/librte_eventdev/eventdev_pmd.h | 3 ---
1 file changed, 3 deletions(-)
diff --git a/lib/librte_eventd
> -Original Message-
> From: Fredrik A Lindgren
> Sent: Monday, February 1, 2021 12:50 PM
> To: Van Haaren, Harry ; dev@dpdk.org
> Subject: RE: Question: typedef of eventdev_info_get_t bug?
>
> I'm not 100% familiar with contribution guidelines of DPDK community and
> since I'm
> doing t
Hi,
> -Original Message-
> From: dev On Behalf Of Dekel Peled
> Sent: Sunday, January 31, 2021 3:30 PM
> To: Matan Azrad ; Shahaf Shuler
> ; Slava Ovsiienko
> Cc: dev@dpdk.org
> Subject: [dpdk-dev] [PATCH] net/mlx5: update flow meter capability flags
> names
>
> Existing names of the fl
Hi,
> -Original Message-
> From: dev On Behalf Of Dekel Peled
> Sent: Monday, February 1, 2021 11:29 AM
> To: Matan Azrad ; Shahaf Shuler
> ; Slava Ovsiienko
> Cc: dev@dpdk.org; sta...@dpdk.org
> Subject: [dpdk-dev] [PATCH] net/mlx5: fix shared RSS translation and
> cleanup
>
> This pat
On Mon, Feb 1, 2021 at 2:20 PM Harry van Haaren
wrote:
>
> The PMD info get API has a void return type. Remove the
> @return 0 Success doxygen comment as it doesn't make sense here.
Fixes: 5223a1f3b8de ("eventdev: define southbound driver interface")
Cc: sta...@dpdk.org
>
> Reported-by: Fredrik
On 2/1/21 2:16 PM, Maxime Coquelin wrote:
> Hi Ilya,
>
> On 2/1/21 2:03 PM, Ilya Maximets wrote:
>> CC: ovs-dev
>>
>> On 2/1/21 2:00 PM, Ilya Maximets wrote:
>>> On 1/26/21 11:15 AM, Maxime Coquelin wrote:
Only functionnal change in this second part is making the
Vhost-user server m
On 2/1/21 2:42 PM, Ilya Maximets wrote:
> On 2/1/21 2:16 PM, Maxime Coquelin wrote:
>> Hi Ilya,
>>
>> On 2/1/21 2:03 PM, Ilya Maximets wrote:
>>> CC: ovs-dev
>>>
>>> On 2/1/21 2:00 PM, Ilya Maximets wrote:
On 1/26/21 11:15 AM, Maxime Coquelin wrote:
>
> Only functionnal change in th
Hi Feifei,
>
> Hi, Honnappa, Konstantin and Stephen
>
> Thanks very much for your attention of this patch. Based on your opinion,
> Ruifeng and I discuss about this and make a summary：
>
> -Original Message-
> From: Ferruh Yigit
> Sent: Monday, 1 February 2021 13:49
> To: Ido Goshen
> Cc: dev@dpdk.org
> Subject: Re: [PATCH v2] net/pcap: imissed stats support
>
> On 2/1/2021 8:30 AM, Ido Goshen wrote:
> > Signed-off-by: Ido Goshen
> > ---
> > v2:
> > * sum all queues (
Ubuntu 18.04 GHA virtual machine images point at an invalid APT
repository.
We have no control over this, simply ignore the failure.
This was caught by Ilya for OVS and the robot just hit the same issue
for DPDK:
"""
Get:46 http://security.ubuntu.com/ubuntu bionic-security/restricted
Translation-
On 2/1/21 3:30 PM, David Marchand wrote:
> Ubuntu 18.04 GHA virtual machine images point at an invalid APT
> repository.
> We have no control over this, simply ignore the failure.
>
> This was caught by Ilya for OVS and the robot just hit the same issue
> for DPDK:
>
> """
> Get:46 http://securit
There are compiler issues when building with -mcpu=native with popular
compilers, such as GCC-8.4 and clang (which doesn't define
__ARM_FEATURE_ATOMIC). Fix this by always specifying the proper machine
args and never using the native flags.
Fixes: 78ac8eac7e8a ("config/arm: use native machine buil
01/02/2021 15:55, Juraj Linkeš:
> There are compiler issues when building with -mcpu=native with popular
> compilers, such as GCC-8.4 and clang (which doesn't define
> __ARM_FEATURE_ATOMIC).
What are the issues? Maybe worth pasting a log.
> Fix this by always specifying the proper machine
> args
VIRTIO_OPS() macro relies on the port ID stored in the
virtio_hw struct. Issue is that it is used before being
assigned at init time. It results in all devices setting
ops on port ID 0, causing crash later when calling ops
for port IDs other than 0.
This patch ensure port ID assignment is done bef
David Marchand writes:
> Ubuntu 18.04 GHA virtual machine images point at an invalid APT
> repository.
> We have no control over this, simply ignore the failure.
>
> This was caught by Ilya for OVS and the robot just hit the same issue
> for DPDK:
>
> """
> Get:46 http://security.ubuntu.com/ubunt
On 2/1/2021 2:02 PM, Ido Goshen wrote:
-Original Message-
From: Ferruh Yigit
Sent: Monday, 1 February 2021 13:49
To: Ido Goshen
Cc: dev@dpdk.org
Subject: Re: [PATCH v2] net/pcap: imissed stats support
On 2/1/2021 8:30 AM, Ido Goshen wrote:
Signed-off-by: Ido Goshen
---
v2:
* sum a
On Mon, Feb 1, 2021 at 4:16 PM Maxime Coquelin
wrote:
>
> VIRTIO_OPS() macro relies on the port ID stored in the
> virtio_hw struct. Issue is that it is used before being
> assigned at init time. It results in all devices setting
> ops on port ID 0, causing crash later when calling ops
> for port
On 2/1/21 5:32 PM, David Marchand wrote:
> On Mon, Feb 1, 2021 at 4:16 PM Maxime Coquelin
> wrote:
>>
>> VIRTIO_OPS() macro relies on the port ID stored in the
>> virtio_hw struct. Issue is that it is used before being
>> assigned at init time. It results in all devices setting
>> ops on port I
Hello,
There is an inconsistency in the name of variables:
most xconfig files use 'implementer_id'
two still use 'implementor_id'
Regards
Thierry
--
Thierry Herbelot
Senior Software Engineer
Tel: +33 1 39 30 92 61
http://www.6wind.com/
Follow us:
https://www.linkedin.com/compa
Verbs cannot be used to configure newly introduced miniCQE formats for
Flow Tag and L3/L4 Header compression. Support for these formats has
been added to the DevX configuration only. And the RX queue descriptor
has been updated with the CQE compression format information only as
well. But the datap
The private virtio_user_dev structure embeds a virtio_hw which itself
contains the ethdev port_id.
Make use of it and remove the duplicate port_id field.
Signed-off-by: David Marchand
---
Posting this cleanup that I caught when reviewing/discussing the port_id
fix from Maxime.
It can wait 21.05.
Now that the ethernet driver dev_ops structure definition is not
exported anymore, there is no need for an exception.
abidiff will only consider structures defined in the installed headers
(passed with --headers-dirX options).
Fixes: df96fd0d7395 ("ethdev: make driver-only headers private")
Signe
On 2/1/2021 6:08 PM, David Marchand wrote:
Now that the ethernet driver dev_ops structure definition is not
exported anymore, there is no need for an exception.
abidiff will only consider structures defined in the installed headers
(passed with --headers-dirX options).
Fixes: df96fd0d7395 ("ethd
On 1/31/2021 10:36 AM, Heinrich Kuhn wrote:
Release-on-close has been implemented for the NFP PMD. Remove the
UNMAINTAINED flag.
Signed-off-by: Heinrich Kuhn
---
MAINTAINERS | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/MAINTAINERS b/MAINTAINERS
index 77a2273c1..68c5ce6
VIRTIO_OPS() macro relies on the port ID stored in the
virtio_hw struct. Issue is that it is used before being
assigned at init time. It results in all devices setting
ops on port ID 0, causing crash later when calling ops
for port IDs other than 0.
This patch ensures port ID assignment is done at
On 2/1/21 7:08 PM, David Marchand wrote:
> Now that the ethernet driver dev_ops structure definition is not
> exported anymore, there is no need for an exception.
> abidiff will only consider structures defined in the installed headers
> (passed with --headers-dirX options).
>
> Fixes: df96fd0d
From: Asaf Penso
Adding more information about the release milestones.
This includes the scope of change, expectations, etc.
Signed-off-by: Asaf Penso
Signed-off-by: Thomas Monjalon
Acked-by: John McNamara
---
v2: fix styling format and add content in the commit message
v3: change punctuation
29/01/2021 23:44, Andrew Boyer:
> Replace copies of size(arr)/size(arr[0]) with RTE_DIM().
> Eventually all of these macro definitions should be removed.
>
> Signed-off-by: Andrew Boyer
> ---
> drivers/net/atlantic/atl_hw_regs.h| 2 +-
> drivers/net/axgbe/axgbe_common.h
> On Feb 1, 2021, at 5:28 PM, Thomas Monjalon wrote:
>
> 29/01/2021 23:44, Andrew Boyer:
>> Replace copies of size(arr)/size(arr[0]) with RTE_DIM().
>> Eventually all of these macro definitions should be removed.
>>
>> Signed-off-by: Andrew Boyer
>> ---
>> drivers/net/atlantic/atl_hw_regs.h
01/02/2021 23:31, Ajit Khaparde:
> On Mon, Feb 1, 2021 at 2:13 PM Thomas Monjalon wrote:
> >
> > From: Asaf Penso
> >
> > Adding more information about the release milestones.
> > This includes the scope of change, expectations, etc.
> >
> > Signed-off-by: Asaf Penso
> > Signed-off-by: Thomas Mo
s/implementor/implementer
Fixes: 3d01d65ba0d3 ("config: add aarch64 clang for Ubuntu 18.04")
Fixes: c51401832147 ("config/arm: add Graviton2")
Cc: sta...@dpdk.org
Reported-by: Thierry Herbelot
Signed-off-by: Ferruh Yigit
---
Cc: Juraj Linkeš
Cc: Ruifeng Wang
Cc: vcchu...@amazon.com
---
confi
eCPRI -> enhanced Common Public Radio Interface
FEC -> Forward Error Correction
SMP -> Symmetric Multiprocessing
Signed-off-by: Ferruh Yigit
---
devtools/words-case.txt | 3 +++
1 file changed, 3 insertions(+)
diff --git a/devtools/words-case.txt b/devtools/words-case.txt
index 8300d7e66ba1
> Subject: [PATCH] config/arm: fix typo in meson config
>
> s/implementor/implementer
>
> Fixes: 3d01d65ba0d3 ("config: add aarch64 clang for Ubuntu 18.04")
> Fixes: c51401832147 ("config/arm: add Graviton2")
> Cc: sta...@dpdk.org
>
> Reported-by: Thierry Herbelot
> Signed-off-by: Ferruh Yigi
vhost_new_device might be called in different threads at the same time.
thread 1(config thread)
rte_vhost_driver_start
->vhost_user_start_client
->vhost_user_add_connection
-> vhost_new_device
thread 2(vhost-events)
vhost_u
Hi, Chenbo,
Thanks for the detailed review!
Xia, Chenbo 于2021年2月1日周一 下午2:27写道：
>
> Hi Peng & Fei,
>
> > -Original Message-
> > From: dev On Behalf Of Peng He
> > Sent: Friday, January 29, 2021 3:36 PM
> > To: dev@dpdk.org
> > Cc: maxime.coque...@redhat.com
> > Subject: [dpdk-dev] [PATC
Hello Dear, My name is Corrin, I am a United States and a military woman never
married no kids yet. I came across your profile, and I personally took interest
in being your friend. For confidential matters, please contact me back through
my private email corrinc...@gmail.com to enable me send yo
For v19.11 the rpm specfile solution I had started build scriptlet by making
x86_64-native-linuxapp-gcc config which called into mk/rte.sdkconfig.mk. For
v20.11 there is no such directory and the top-level Makefile suggests following
the quickstart guide and building with meson. Is there any ref
The filter type (struct filter_v2.type) should always be set to
FILTER_DPDK_1, when advanced filtering is enabled in
firmware. Otherwise, for some old firmware versions, the driver sets
it to FILTER_USNIC_IP, and attempts to install filters fail. This
behavior matches that of the now-removed flow d
Add Intel 40GbE Ethernet adapter device IDs to netuio inf file
in order to enable them on Windows.
Signed-off-by: Pallavi Kadam
Reviewed-by: Ranjit Menon
---
windows/netuio/netuio.inf | 28
1 file changed, 28 insertions(+)
diff --git a/windows/netuio/netuio.inf b/w
miniCQE formats for Flow Tag and L3/L4 Header compression are only
supported by Mellanox FW starting version 16.29.392. There is no
point to allow user to enable these formats if FW cannot provide them.
Check FW capabilities and deny user requests if the selected miniCQE
format is not supported by
> -Original Message-
> From: Ferruh Yigit
> Sent: Tuesday, February 2, 2021 6:42 AM
> To: Jan Viktorin ; Ruifeng Wang
> ; jer...@marvell.com; Bruce Richardson
> ; Juraj Linkeš ;
> Honnappa Nagarahalli ; Vimal Chungath
>
> Cc: Ferruh Yigit ; dev@dpdk.org;
> tho...@monjalon.net; sta...@dpdk
On Mon, Feb 1, 2021 at 2:13 PM Thomas Monjalon wrote:
>
> From: Asaf Penso
>
> Adding more information about the release milestones.
> This includes the scope of change, expectations, etc.
>
> Signed-off-by: Asaf Penso
> Signed-off-by: Thomas Monjalon
> Acked-by: John McNamara
Looks good to me
Currently, X722 firmware doesn't support to add more than
one mirror rule in one VSI.
Signed-off-by: Liulingyu
---
V2 change:
- refine commit log
doc/guides/nics/i40e.rst | 5 +
1 file changed, 5 insertions(+)
diff --git a/doc/guides/nics/i40e.rst b/doc/guides/nics/i40e.rst
index 20c99839
From: Souvik Dey
As the internal MAC table is divided into Unicast and Multicast address
sections, we should check the type of synched MAC address before storing
it to the internal table. Currently the check is not done, and the
synched MAC of 33:33:00:00:00:01 gets stored in the unicast section
> -Original Message-
> From: Liu, Lingyu
> Sent: Tuesday, February 2, 2021 5:56 PM
> To: dev@dpdk.org; Xing, Beilei
> Cc: Liu, Lingyu
> Subject: [PATCH v2] doc: add mirror rule limitation of X722
>
> Currently, X722 firmware doesn't support to add more than one mirror rule in
> one V
Remove async inflight packet counter since there is no need to keep
tracking it. Increase MAX_ENQUEUED_SIZE to prevent packet segment number
tracking ring from being exhausted.
Fixes: a68ba8e0a6b6 ("examples/vhost: refactor vhost data path")
Signed-off-by: Cheng Jiang
---
v3: fixed fixes commit
Change the type of buff_idx from uint64_t to uint32_t to fix coverity
issue.
Fixes: a68ba8e0a6b6 ("examples/vhost: refactor vhost data path")
Coverity issue: 366264
Signed-off-by: Cheng Jiang
---
examples/vhost/main.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/examples/
> -Original Message-
> From: Ferruh Yigit
> Sent: Monday, February 1, 2021 11:42 PM
> To: Jan Viktorin ; Ruifeng Wang
> ; Jerin Jacob ; Bruce Richardson
> ; Juraj Linkeš ;
> Honnappa Nagarahalli ; Vimal Chungath
>
> Cc: Ferruh Yigit ; dev@dpdk.org; Thomas Monjalon
> ; sta...@dpdk.org; T
There is an 82599 errata that UDP frames with a zero checksum are
incorrectly marked as checksum invalid by the hardware. This was
leading to misleading PKT_RX_L4_CKSUM_BAD flag. This patch adds a
test around this checksum error flag set for this condition.
1. UDP Test
sendp(Ether()/IP()/UDP(ch
Change the type of buff_idx from uint64_t to uint32_t to fix coverity
issue.
Coverity issue: 366264
Fixes: a68ba8e0a6b6 ("examples/vhost: refactor vhost data path")
Signed-off-by: Cheng Jiang
---
v2: fixed the format of git log
examples/vhost/main.c | 2 +-
1 file changed, 1 insertion(+), 1 de
> -Original Message-
> From: Thomas Monjalon
> Sent: Monday, February 1, 2021 4:16 PM
> To: Juraj Linkeš
> Cc: bruce.richard...@intel.com; ruifeng.w...@arm.com;
> honnappa.nagaraha...@arm.com; jerinjac...@gmail.com;
> ferruh.yi...@intel.com; dev@dpdk.org
> Subject: Re: [RFC PATCH v1] co
+ ARM experts, Feifei and Ruifeng.
Need your further support for ARM NEON path.
https://patchwork.dpdk.org/patch/87617/
> -Original Message-
> From: Paolo Valerio
> Sent: Friday, January 29, 2021 22:20
> To: Wang, Haiyue ; Yang, Qiming
> Cc: Guo, Jia ; Aaron Conole ;
> dev@dpdk.org
>
74 matches
Mail list logo
