Re: [dpdk-dev] [PATCH v2 3/4] vhost: avoid deadlock on async register

2021-04-19 Thread Maxime Coquelin
On 4/19/21 6:10 AM, Hu, Jiayu wrote: > Hi Maxime, > >> -Original Message- >> From: Maxime Coquelin >> Sent: Friday, April 16, 2021 4:34 PM >> To: Hu, Jiayu ; dev@dpdk.org >> Cc: Xia, Chenbo ; Wang, Yinan >> ; Pai G, Sunil ; Jiang, Cheng1 >> >> Subject: Re: [PATCH v2 3/4] vhost: avoid

Re: [dpdk-dev] [PATCH] net/igc: fix Rx packet size error

2021-04-19 Thread Zhang, AlvinX
Hi Haiyue, Thanks for your review. > -Original Message- > From: Wang, Haiyue > Sent: Friday, April 16, 2021 9:57 AM > To: Zhang, AlvinX ; Guo, Jia > Cc: dev@dpdk.org; sta...@dpdk.org > Subject: RE: [PATCH] net/igc: fix Rx packet size error > > > -Original Message- > > From: Zha

[dpdk-dev] [PATCH] net/hns3: support RAS process in Kunpeng 930

2021-04-19 Thread Min Hu (Connor)
From: Hongbo Zheng Kunpeng 930 uses a new RAS exception reporting solution. The reset type and exception status are reported through firmware. The driver modifies the corresponding code to adapt to the new solution. Signed-off-by: Hongbo Zheng Signed-off-by: Min Hu (Connor) --- drivers/net/hn

Re: [dpdk-dev] [PATCH] examples/ptpclient: delete wrong comments

2021-04-19 Thread Min Hu (Connor)
Hi, Ferruh and all, If no other comments, could your please merge it into the branch? Thanks. 在 2021/4/12 16:04, Ferruh Yigit 写道: On 4/10/2021 10:11 AM, Min Hu (Connor) wrote: Hi, Ferruh, kirill and all,  Any comments about this patch? 在 2021/3/27 15:36, Min Hu (Connor) 写道

Re: [dpdk-dev] [PATCH] net/igc: fix Rx packet size error

2021-04-19 Thread Wang, Haiyue
> -Original Message- > From: Zhang, AlvinX > Sent: Monday, April 19, 2021 15:15 > To: Wang, Haiyue ; Guo, Jia > Cc: dev@dpdk.org; sta...@dpdk.org > Subject: RE: [PATCH] net/igc: fix Rx packet size error > > Hi Haiyue, > > Thanks for your review. > > > -Original Message- > > Fro

Re: [dpdk-dev] [PATCH 0/3] fix check of port and core

2021-04-19 Thread Min Hu (Connor)
Hi,Ferruh, bernard, tomasz, bruce and all, Any comments about this set of patches? 在 2021/4/10 17:14, Min Hu (Connor) 写道: Hi,Ferruh, bernard, tomasz, bruce and all, Any comments about this set of patches? 在 2021/3/27 15:40, Min Hu (Connor) 写道: Currently, some examples check that the p

Re: [dpdk-dev] [PATCH v4 1/4] app/testpmd: add packet id for IP fragment

2021-04-19 Thread Jack Min
On Tue, 21-04-13, 16:10, Jeff Guo wrote: > Add the new items to support the flow configuration for IP fragment > packets. > > Signed-off-by: Ting Xu > Signed-off-by: Jeff Guo > --- > app/test-pmd/cmdline_flow.c | 21 - > 1 file changed, 20 insertions(+), 1 deletion(-) [...s

[dpdk-dev] [PATCH] net/i40e: fix potential Tx hang

2021-04-19 Thread Wenzhuo Lu
Tx hang may happen if there's no memory barrier. Fixes: b4669bb95038 ("i40e: add vector Tx") Fixes: aed68d5b0e81 ("net/i40e: add AVX2 Tx function") Fixes: e6a6a138919f ("net/i40e: add AVX512 vector path") Cc: sta...@dpdk.org Reported-by: Tao Yang Signed-off-by: Wenzhuo Lu --- drivers/net/i40e/

Re: [dpdk-dev] [PATCH] app/testpmd: support the query of link flow ctrl info

2021-04-19 Thread Li, Xiaoyun
Hi > -Original Message- > From: Min Hu (Connor) > Sent: Monday, April 19, 2021 14:41 > To: Li, Xiaoyun ; dev@dpdk.org > Cc: Yigit, Ferruh > Subject: Re: [PATCH] app/testpmd: support the query of link flow ctrl info > > Hi, > > 在 2021/4/19 10:53, Li, Xiaoyun 写道: > > Hi > > > >> -Ori

Re: [dpdk-dev] [PATCH V4 0/3] add Hisilicon kunpeng CPU support

2021-04-19 Thread Thomas Monjalon
16/04/2021 11:57, Lijun Ou: > Chengchang Tang (3): > config/arm: add Hisilicon kunpeng implementer > config/arm: add kunpeng920 cross target > config/arm: add kunpeng930 cross target Squashed, sorted SoCs alphabetically with others, and applied.

Re: [dpdk-dev] dpdk-graph-crypto-perf on ARM platform

2021-04-19 Thread Nipun Gupta
Hi Ciara, Just for information, Kaleido and plotly v4.9+ worked for us. Thanks, Nipun > -Original Message- > From: Nipun Gupta > Sent: Wednesday, February 24, 2021 4:35 PM > To: Power, Ciara ; dev@dpdk.org > Cc: Vanshika Shukla ; Hemant Agrawal > ; Doherty, Declan ; > Dybkowski, AdamX

Re: [dpdk-dev] [PATCH v2 1/1] raw/ifpga/base: check size before assigning

2021-04-19 Thread Zhang, Qi Z
> -Original Message- > From: Huang, Wei > Sent: Thursday, April 8, 2021 4:52 PM > To: dev@dpdk.org; Xu, Rosen ; Zhang, Qi Z > > Cc: sta...@dpdk.org; Zhang, Tianfei ; Yigit, Ferruh > ; Huang, Wei > Subject: [PATCH v2 1/1] raw/ifpga/base: check size before assigning > > In max10_stagin

[dpdk-dev] [PATCH] net/hns3: delete redundant macro

2021-04-19 Thread Min Hu (Connor)
'HNS3_RXD_TSIND_S' and 'HNS3_RXD_TSIND_M' is unused, which should be deleted. This patch fixed it. Fixes: bba636698316 ("net/hns3: support Rx/Tx and related operations") Cc: sta...@dpdk.org Signed-off-by: Min Hu (Connor) --- drivers/net/hns3/hns3_rxtx.h | 2 -- 1 file changed, 2 deletions(-)

Re: [dpdk-dev] [PATCH] net/i40e: fix flow does not effect on uncustomed pctype

2021-04-19 Thread Xing, Beilei
Hi, > -Original Message- > From: Yang, MurphyX > Sent: Friday, April 16, 2021 10:20 AM > To: dev@dpdk.org > Cc: Yang, Qiming ; Guo, Jia ; > Xing, Beilei ; Yang, SteveX ; > Zhang, RobinX ; Yang, MurphyX > > Subject: [PATCH] net/i40e: fix flow does not effect on uncustomed pctype > > Uncu

[dpdk-dev] [PATCH v2] app/testpmd: support the query of link flow ctrl info

2021-04-19 Thread Min Hu (Connor)
From: Huisong Li This patch supports the query of the link flow control parameter on a port. The command format is as follows: show port flow_ctrl Signed-off-by: Huisong Li Signed-off-by: Min Hu (Connor) --- app/test-pmd/cmdline.c | 83 + doc

Re: [dpdk-dev] [PATCH] app/testpmd: support the query of link flow ctrl info

2021-04-19 Thread Min Hu (Connor)
Hi, fixed in v2, thanks 在 2021/4/19 16:04, Li, Xiaoyun 写道: Hi -Original Message- From: Min Hu (Connor) Sent: Monday, April 19, 2021 14:41 To: Li, Xiaoyun ; dev@dpdk.org Cc: Yigit, Ferruh Subject: Re: [PATCH] app/testpmd: support the query of link flow ctrl info Hi, 在 2021/4/19 10:5

[dpdk-dev] [PATCH v7 0/2] add packet integrity checks

2021-04-19 Thread Gregory Etelson
v7: move the __extension__ macro in rte_flow_item_integrity. Acked-by: Ferruh Yigit Ori Kam (2): ethdev: add packet integrity checks app/testpmd: add support for integrity item app/test-pmd/cmdline_flow.c | 39 doc/guides/prog_guide/rte_flow.rst |

[dpdk-dev] [PATCH v7 1/2] ethdev: add packet integrity checks

2021-04-19 Thread Gregory Etelson
From: Ori Kam Currently, DPDK application can offload the checksum check, and report it in the mbuf. However, as more and more applications are offloading some or all logic and action to the HW, there is a need to check the packet integrity so the right decision can be taken. The application lo

[dpdk-dev] [PATCH v7 2/2] app/testpmd: add support for integrity item

2021-04-19 Thread Gregory Etelson
From: Ori Kam The integrity item allows the application to match on the integrity of a packet. use example: match that packet integrity checks are ok. The checks depend on packet layers. For example ICMP packet will not check L4 level. flow create 0 ingress pattern integrity value mask 0x01 valu

Re: [dpdk-dev] [PATCH v7] net/iavf: deprecate i40evf pmd

2021-04-19 Thread Xing, Beilei
> -Original Message- > From: Zhang, RobinX > Sent: Monday, April 19, 2021 11:06 AM > To: dev@dpdk.org > Cc: Xing, Beilei ; Guo, Jia ; Wang, > Haiyue ; m...@ashroe.eu; nhor...@tuxdriver.com; > Wu, Jingjing ; Yang, Qiming > ; Yang, SteveX ; Zhang, > RobinX ; Zhang, Qi Z ; Yigit, > Ferruh

Re: [dpdk-dev] [PATCH v7] net/iavf: deprecate i40evf pmd

2021-04-19 Thread Zhang, Qi Z
> -Original Message- > From: Xing, Beilei > Sent: Monday, April 19, 2021 4:32 PM > To: Zhang, RobinX ; dev@dpdk.org > Cc: Guo, Jia ; Wang, Haiyue ; > m...@ashroe.eu; nhor...@tuxdriver.com; Wu, Jingjing > ; Yang, Qiming ; Yang, > SteveX ; Zhang, Qi Z ; Yigit, > Ferruh > Subject: RE: [PAT

[dpdk-dev] [PATCH] doc: add Kunpeng 930 support description

2021-04-19 Thread Min Hu (Connor)
Hns3 PMD has already supported Kunpeng 930 SoC. This patch added description for it. Signed-off-by: Min Hu (Connor) --- doc/guides/nics/hns3.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/doc/guides/nics/hns3.rst b/doc/guides/nics/hns3.rst index 20c7387..34e1c43 100644

Re: [dpdk-dev] [PATCH V6] ethdev: add queue state when retrieve queue information

2021-04-19 Thread Thomas Monjalon
19/04/2021 04:03, Lijun Ou: > --- a/doc/guides/rel_notes/release_21_05.rst > +++ b/doc/guides/rel_notes/release_21_05.rst > +* **Enhanced function for getting rxq/txq info ABI.** Reword: Added queue state in queried Rx/Tx queue info > + * Added new field ``queue_state`` to ``rte_eth_rxq_info`` s

Re: [dpdk-dev] [PATCH v4] meson: update minimum required meson version

2021-04-19 Thread Bruce Richardson
On Fri, Apr 16, 2021 at 07:28:57PM +0200, Thomas Monjalon wrote: > 16/04/2021 17:01, Thomas Monjalon: > > 23/03/2021 11:13, Andrew Rybchenko: > > > On 3/23/21 1:11 PM, Bruce Richardson wrote: > > > > On Tue, Mar 23, 2021 at 10:52:19AM +0100, Gabriel Ganne wrote: > > > >> Bump meson required version

Re: [dpdk-dev] [PATCH v7 1/2] ethdev: add packet integrity checks

2021-04-19 Thread Thomas Monjalon
19/04/2021 10:29, Gregory Etelson: > +Item: ``PACKET_INTEGRITY_CHECKS`` > +^ > + > +Matches packet integrity. > +For some devices application needs to enable integration checks in HW > +before using this item. > + > +- ``level``: the encapsulation level that should b

Re: [dpdk-dev] [PATCH v4 1/2] telemetry: fix missing check for thread creation

2021-04-19 Thread Power, Ciara
Hi Connor, >-Original Message- >From: Min Hu (Connor) >Sent: Friday 16 April 2021 09:18 >To: dev@dpdk.org >Cc: Yigit, Ferruh ; Power, Ciara >; Pattan, Reshma ; >david.march...@redhat.com >Subject: [PATCH v4 1/2] telemetry: fix missing check for thread creation > >From: Chengwen Feng > >A

[dpdk-dev] [PATCH v2] net/iavf: fix hash configuration on i40e VF

2021-04-19 Thread Alvin Zhang
In i40evf PMD, the VF directly accesses the hash enable registers to enable or disable hashing on ingress packets. When binding i40e VF to iavf, because the PF doesn't support VIRTCHNL_VF_OFFLOAD_ADV_RSS_PF capability. Therefore, the VF hashing cannot be enabled. This patch adds support of hash co

[dpdk-dev] [PATCH v7] ethdev: add queue state when retrieve queue information

2021-04-19 Thread Lijun Ou
Currently, upper-layer application could get queue state only through pointers such as dev->data->tx_queue_state[queue_id], this is not the recommended way to access it. So this patch add get queue state when call rte_eth_rx_queue_info_get and rte_eth_tx_queue_info_get API. Note: After add queue_s

Re: [dpdk-dev] [PATCH V6] ethdev: add queue state when retrieve queue information

2021-04-19 Thread oulijun
在 2021/4/19 16:41, Thomas Monjalon 写道: 19/04/2021 04:03, Lijun Ou: --- a/doc/guides/rel_notes/release_21_05.rst +++ b/doc/guides/rel_notes/release_21_05.rst +* **Enhanced function for getting rxq/txq info ABI.** Reword: Added queue state in queried Rx/Tx queue info + * Added new field ``

[dpdk-dev] [PATCH v2] net/i40e: add Tx preparation for simple Tx data path

2021-04-19 Thread Leyi Rong
Introduce i40e_simple_prep_pkts() as the preparation function for simple Tx data path, as it's for sanity check for simple Tx. Suggested-by: Konstantin Ananyev Signed-off-by: Leyi Rong --- drivers/net/i40e/i40e_rxtx.c | 42 +++- drivers/net/i40e/i40e_rxtx.h | 2

Re: [dpdk-dev] [PATCH v2 3/4] vhost: avoid deadlock on async register

2021-04-19 Thread Hu, Jiayu
> -Original Message- > From: Maxime Coquelin > Sent: Monday, April 19, 2021 3:13 PM > To: Hu, Jiayu ; dev@dpdk.org > Cc: Xia, Chenbo ; Wang, Yinan > ; Pai G, Sunil ; Jiang, Cheng1 > > Subject: Re: [PATCH v2 3/4] vhost: avoid deadlock on async register > > What about memory hot

Re: [dpdk-dev] [PATCH v7] ethdev: add queue state when retrieve queue information

2021-04-19 Thread Thomas Monjalon
19/04/2021 10:57, Lijun Ou: > Currently, upper-layer application could get queue state only > through pointers such as dev->data->tx_queue_state[queue_id], > this is not the recommended way to access it. So this patch > add get queue state when call rte_eth_rx_queue_info_get and > rte_eth_tx_queue_

[dpdk-dev] [PATCH v8 0/4] add support for packed ring in async vhost

2021-04-19 Thread Cheng Jiang
For now async vhost data path only supports split ring structure. In order to make async vhost compatible with virtio 1.1 spec this patch set cleans async split ring codes and enables packed ring in async vhost data path. Batch datapath is also enabled in async vhost packed ring. v8: * fix some v

[dpdk-dev] [PATCH v8 2/4] vhost: add support for packed ring in async vhost

2021-04-19 Thread Cheng Jiang
For now async vhost data path only supports split ring. This patch enables packed ring in async vhost data path to make async vhost compatible with virtio 1.1 spec. Signed-off-by: Cheng Jiang --- lib/librte_vhost/rte_vhost_async.h | 1 + lib/librte_vhost/vhost.c | 79 -- lib/lib

[dpdk-dev] [PATCH v8 3/4] vhost: add batch datapath for async vhost packed ring

2021-04-19 Thread Cheng Jiang
Add batch datapath for async vhost packed ring to improve the performance of small packet processing. Signed-off-by: Cheng Jiang --- lib/librte_vhost/virtio_net.c | 41 +++ 1 file changed, 37 insertions(+), 4 deletions(-) diff --git a/lib/librte_vhost/virtio_net.

[dpdk-dev] [PATCH v8 1/4] vhost: abstract and reorganize async split ring code

2021-04-19 Thread Cheng Jiang
This patch puts some codes of async vhost split ring into inline functions to improve the readability of the code. And, it changes the pointer index style of iterator to make the code more concise. Signed-off-by: Cheng Jiang Reviewed-by: Maxime Coquelin --- lib/librte_vhost/virtio_net.c | 132 +

[dpdk-dev] [PATCH v8 4/4] doc: add release note for vhost async packed ring

2021-04-19 Thread Cheng Jiang
Add release note for the support of vhost async packed ring. Signed-off-by: Cheng Jiang --- doc/guides/rel_notes/release_21_05.rst | 4 1 file changed, 4 insertions(+) diff --git a/doc/guides/rel_notes/release_21_05.rst b/doc/guides/rel_notes/release_21_05.rst index 374d6d98e..eb5200669 1

Re: [dpdk-dev] [PATCH] eal: check vsnprintf failure and return -EINVAL

2021-04-19 Thread Thomas Monjalon
16/03/2021 00:55, Tyler Retzlaff: > Check for failure, while here just increment len once after checking for > failure instead of duplicating len + 1 math in two different argument > lists. > > Signed-off-by: Tyler Retzlaff Applied, thanks

Re: [dpdk-dev] [PATCH v2 1/2] common/mlx5: support device global syntax

2021-04-19 Thread Raslan Darawsheh
Series applied to next-net-mlx, Kindest regards, Raslan Darawsheh > -Original Message- > From: dev On Behalf Of Raslan Darawsheh > Sent: Thursday, April 8, 2021 5:13 PM > To: Xueming(Steven) Li ; Slava Ovsiienko > > Cc: dev@dpdk.org; Matan Azrad ; Shahaf Shuler > ; NBU-Contact-Thomas Mo

Re: [dpdk-dev] [PATCH 0/2] support single flow dump on MLX5 PMD

2021-04-19 Thread Raslan Darawsheh
Hi, > -Original Message- > From: Haifei Luo > Sent: Wednesday, April 14, 2021 10:23 AM > To: ferruh.yi...@intel.com; Slava Ovsiienko ; > Matan Azrad ; xiaoyun...@intel.com; NBU-Contact- > Thomas Monjalon ; Ori Kam > Cc: dev@dpdk.org; Raslan Darawsheh ; > Xueming(Steven) Li ; Haifei Luo >

Re: [dpdk-dev] [PATCH v4 2/2] test: fix missing check for thread creation

2021-04-19 Thread Pattan, Reshma
> -Original Message- > From: Min Hu (Connor) > Subject: [PATCH v4 2/2] test: fix missing check for thread creation > > Fixes: 086eb64db39e ("test/pdump: add unit test for pdump library") > Cc: sta...@dpdk.org > > Signed-off-by: Chengwen Feng > Signed-off-by: Min Hu (Connor) Acked-

Re: [dpdk-dev] [PATCH v2] net/i40e: add Tx preparation for simple Tx data path

2021-04-19 Thread Zhang, Qi Z
> -Original Message- > From: Rong, Leyi > Sent: Monday, April 19, 2021 4:36 PM > To: Zhang, Qi Z ; Ananyev, Konstantin > > Cc: dev@dpdk.org; Rong, Leyi > Subject: [PATCH v2] net/i40e: add Tx preparation for simple Tx data path > > Introduce i40e_simple_prep_pkts() as the preparation

Re: [dpdk-dev] [PATCH v3] eal, power: use UINT64_MAX and UINT32_MAX

2021-04-19 Thread Thomas Monjalon
01/04/2021 13:22, Burakov, Anatoly: > On 16-Mar-21 12:13 AM, Tyler Retzlaff wrote: > > Use UINT64_MAX and UINT32_MAX instead of -1 or ~0 literal variations > > of different explicit widths when creating masks and sentinel values. > > > > some compilers generate a warning when applying a '-' to an

[dpdk-dev] [PATCH v3] build: optional NUMA and cpu counts detection

2021-04-19 Thread Juraj Linkeš
Add an option to automatically discover the host's numa and cpu counts and use those values for a non cross-build. Give users the option to override the per-arch default values or values from cross files by specifying them on the command line with -Dmax_lcores and -Dmax_numa_nodes. Signed-off-by:

Re: [dpdk-dev] [PATCH v2 1/2] common/mlx5: support device global syntax

2021-04-19 Thread Raslan Darawsheh
Sorry for all this confusion, But since we are still missing part of the dependency. so dropping form next-net-mlx again. Kindest regards, Raslan Darawsheh > -Original Message- > From: Raslan Darawsheh > Sent: Monday, April 19, 2021 12:30 PM > To: Raslan Darawsheh ; Xueming(Steven) Li >

Re: [dpdk-dev] [PATCH v7] ethdev: add queue state when retrieve queue information

2021-04-19 Thread Ferruh Yigit
On 4/19/2021 10:03 AM, Thomas Monjalon wrote: 19/04/2021 10:57, Lijun Ou: Currently, upper-layer application could get queue state only through pointers such as dev->data->tx_queue_state[queue_id], this is not the recommended way to access it. So this patch add get queue state when call rte_eth_

Re: [dpdk-dev] [PATCH v2] net/i40e: add Tx preparation for simple Tx data path

2021-04-19 Thread Ananyev, Konstantin
Hi Leyi, > Introduce i40e_simple_prep_pkts() as the preparation function for > simple Tx data path, as it's for sanity check for simple Tx. > > Suggested-by: Konstantin Ananyev > Signed-off-by: Leyi Rong > --- > drivers/net/i40e/i40e_rxtx.c | 42 +++- > drivers/

Re: [dpdk-dev] [PATCH] doc: add Kunpeng 930 support description

2021-04-19 Thread Ferruh Yigit
On 4/19/2021 9:36 AM, Min Hu (Connor) wrote: Hns3 PMD has already supported Kunpeng 930 SoC. This patch added description for it. Signed-off-by: Min Hu (Connor) Applied to dpdk-next-net/main, thanks.

Re: [dpdk-dev] [PATCH v7 0/2] add packet integrity checks

2021-04-19 Thread Ferruh Yigit
On 4/19/2021 9:29 AM, Gregory Etelson wrote: v7: move the __extension__ macro in rte_flow_item_integrity. Acked-by: Ferruh Yigit Ori Kam (2): ethdev: add packet integrity checks app/testpmd: add support for integrity item Can you please check the build error on CI: http://mails.dpdk.o

Re: [dpdk-dev] [dpdk-stable] [PATCH v5] eal: fix create user mem map repeatedly when it exists

2021-04-19 Thread Thomas Monjalon
10/04/2021 11:37, wangyunjian: > From: Yunjian Wang > > Currently, new user mem maps are checked if they are adjacent to > an existing mem map and if so, the mem map entries are merged. > > It doesn't check for duplicate mem maps, so if the API is called As Kevin suggested, it should be in the

Re: [dpdk-dev] [PATCH] net/hns3: delete redundant macro

2021-04-19 Thread Ferruh Yigit
On 4/19/2021 9:13 AM, Min Hu (Connor) wrote: 'HNS3_RXD_TSIND_S' and 'HNS3_RXD_TSIND_M' is unused, which should be deleted. This patch fixed it. Fixes: bba636698316 ("net/hns3: support Rx/Tx and related operations") Cc: sta...@dpdk.org Signed-off-by: Min Hu (Connor) Applied to dpdk-next-net/

Re: [dpdk-dev] [PATCH v7 0/2] add packet integrity checks

2021-04-19 Thread Gregory Etelson
> On 4/19/2021 9:29 AM, Gregory Etelson wrote: > > v7: move the __extension__ macro in rte_flow_item_integrity. > > > > Acked-by: Ferruh Yigit > > > > Ori Kam (2): > >ethdev: add packet integrity checks > >app/testpmd: add support for integrity item > > > > Can you please check the build

Re: [dpdk-dev] [PATCH v4 0/4] add travis ci support for ppc64le

2021-04-19 Thread Luca Boccassi
On Thu, 2021-04-15 at 16:45 +0200, Christian Ehrhardt wrote: > On Thu, Apr 2, 2020 at 7:13 PM David Wilder wrote: > > This patch series adds Travis gcc compilation jobs and unit testing > > for ppc64le. Limitations for ppc64le are similar to arm64 (see commit > > 31bb45bcfd). > > > > 1. Only gcc

Re: [dpdk-dev] [PATCH v4 1/1] ethdev: introduce indirect action APIs

2021-04-19 Thread Thomas Monjalon
16/04/2021 19:33, Bing Zhao: > --- a/doc/guides/rel_notes/release_21_05.rst > +++ b/doc/guides/rel_notes/release_21_05.rst > @@ -234,6 +234,9 @@ API Changes > * pci: The value ``PCI_ANY_ID`` is marked as deprecated >and can be replaced with ``RTE_PCI_ANY_ID``. > > +* ethdev: The experimental

Re: [dpdk-dev] [PATCH] net/mlx5: fix VLAN/DECAP actions not work in mirror flow

2021-04-19 Thread Raslan Darawsheh
Hi, > -Original Message- > From: dev On Behalf Of Jiawei Wang > Sent: Friday, April 9, 2021 3:37 PM > To: Matan Azrad ; Shahaf Shuler > ; Slava Ovsiienko ; > Jiawei(Jonny) Wang > Cc: dev@dpdk.org; sta...@dpdk.org > Subject: [dpdk-dev] [PATCH] net/mlx5: fix VLAN/DECAP actions not work in

[dpdk-dev] [PATCH] app: fix redundant comparison

2021-04-19 Thread Min Hu (Connor)
The return value of 'rte_eal_cleanup' is always zero, so comparison with zero is redundant. This patch fixed it by deleting the redundant comparison. Fixes: 67684d1e87b6 ("app/procinfo: call EAL cleanup before exit") Fixes: b68a82425da4 ("app/compress-perf: add performance measurement") Fixes: 5e

Re: [dpdk-dev] [PATCH v8 1/2] ethdev: add pre-defined meter policy API

2021-04-19 Thread Singh, Jasvinder
> +/* MTR meter policy add */ > +static int > +pmd_mtr_meter_policy_add(struct rte_eth_dev *dev, > + uint32_t meter_policy_id, > + struct rte_mtr_meter_policy_params *policy, > + struct rte_mtr_error *error) > +{ > + struct pmd_internals *p = dev->data->dev_private; > + struct

[dpdk-dev] [PATCH V4] app/testpmd: support Tx mbuf free on demand cmd

2021-04-19 Thread Lijun Ou
From: Chengwen Feng This patch support tx_done_cleanup command: tx_done_cleanup port (port_id) (queue_id) (free_cnt) Users must make sure there are no concurrent access to the same Tx queue (like rte_eth_tx_burst, rte_eth_dev_tx_queue_stop and so on) this command executed. Signed-off-by: Chengw

Re: [dpdk-dev] [PATCH] net/hns3: support RAS process in Kunpeng 930

2021-04-19 Thread Ferruh Yigit
On 4/19/2021 8:36 AM, Min Hu (Connor) wrote: From: Hongbo Zheng Kunpeng 930 uses a new RAS exception reporting solution. The reset type and exception status are reported through firmware. The driver modifies the corresponding code to adapt to the new solution. Signed-off-by: Hongbo Zheng Sign

Re: [dpdk-dev] [PATCH V3] app/testpmd: support Tx mbuf free on demand cmd

2021-04-19 Thread oulijun
在 2021/4/19 11:11, Li, Xiaoyun 写道: Hi -Original Message- From: Lijun Ou Sent: Monday, April 12, 2021 21:13 To: Yigit, Ferruh Cc: Li, Xiaoyun ; dev@dpdk.org; linux...@openeuler.org Subject: [PATCH V3] app/testpmd: support Tx mbuf free on demand cmd From: Chengwen Feng This patch

Re: [dpdk-dev] [PATCH] app: fix redundant comparison

2021-04-19 Thread David Hunt
Hi Connor, On 19/4/2021 1:29 PM, Min Hu (Connor) wrote: The return value of 'rte_eal_cleanup' is always zero, so comparison with zero is redundant. This patch fixed it by deleting the redundant comparison. Fixes: 67684d1e87b6 ("app/procinfo: call EAL cleanup before exit") Fixes: b68a82425da4 (

[dpdk-dev] [PATCH v8 0/2] add packet integrity checks

2021-04-19 Thread Gregory Etelson
v8: Update documents. Fix RTE_STD_C11 macro usage in rte_flow_item_integrity. Acked-by: Ferruh Yigit Ori Kam (2): ethdev: add packet integrity checks app/testpmd: add support for integrity item app/test-pmd/cmdline_flow.c | 39 doc/guides/prog_guide/rte

[dpdk-dev] [PATCH v8 1/2] ethdev: add packet integrity checks

2021-04-19 Thread Gregory Etelson
From: Ori Kam Currently, DPDK application can offload the checksum check, and report it in the mbuf. However, as more and more applications are offloading some or all logic and action to the HW, there is a need to check the packet integrity so the right decision can be taken. The application lo

[dpdk-dev] [PATCH v8 2/2] app/testpmd: add support for integrity item

2021-04-19 Thread Gregory Etelson
From: Ori Kam The integrity item allows the application to match on the integrity of a packet. use example: match that packet integrity checks are ok. The checks depend on packet layers. For example ICMP packet will not check L4 level. flow create 0 ingress pattern integrity value mask 0x01 valu

[dpdk-dev] [PATCH] net/ice: fix disabling of promisc mode (keep allmulti state)

2021-04-19 Thread Siwar Zitouni
When promiscuous mode is disabled, allmulticast is also disabled, even if it was previously enabled. Add a test in ice_promisc_disable() to check if allmulticast should be kept enabled. Fixes: c945e4bf9063 ("net/ice: support promiscuous mode") Cc: sta...@dpdk.org Signed-off-by: Thibaut Collet S

[dpdk-dev] [PATCH 1/2] net/mlx5: fix tunnel offload private items location

2021-04-19 Thread Gregory Etelson
Flow rules used in tunnel offload model require application to query PMD for private flow elements and explicitly add these elements to flow rule. Tunnel offload model does not restrict private elements location in a flow rule. The patch fixes MLX5 PMD requirement to place private tunnel offload PM

[dpdk-dev] [PATCH 2/2] app/testpmd: fix tunnel offload private items location

2021-04-19 Thread Gregory Etelson
Flow rules used in tunnel offload model require application to query PMD for private flow elements and explicitly add these elements to flow rule. Tunnel offload model does not restrict private elements location in a flow rule. The patch places tunnel offload private PMD flow elements between gener

Re: [dpdk-dev] [PATCH 00/14] Build file updates

2021-04-19 Thread Bruce Richardson
On Sun, Apr 18, 2021 at 08:45:25AM +, Xueming(Steven) Li wrote: > Hi Bruce, > > > -Original Message- > > From: dev On Behalf Of Bruce Richardson > > Sent: Saturday, April 17, 2021 1:05 AM > > To: dev@dpdk.org > > Cc: Bruce Richardson > > Subject: [dpdk-dev] [PATCH 00/14] Build file u

Re: [dpdk-dev] [PATCH 00/14] Build file updates

2021-04-19 Thread Bruce Richardson
On Mon, Apr 19, 2021 at 02:20:47AM +0200, Thomas Monjalon wrote: > 16/04/2021 19:04, Bruce Richardson: > > RFC -> V1: * rebased to current main branch * performed cleanup on many > > meson.build files to ensure correct formatting of lists: * split lists > > with >3 or >4 entries to be one per line

[dpdk-dev] [PATCH 00/10] fixes for clean code

2021-04-19 Thread Min Hu (Connor)
This patchset fix some bugs, to make the code more clean. Chengchang Tang (1): net/bonding: fix configuration assignment overflow HongBo Zheng (5): app/test: add NULL pointer check of memory allocation lib/librte_pipeline: fix the use of unsafe strcpy examples/l3fwd: add function return v

[dpdk-dev] [PATCH 03/10] bus/dpaa: fix management command init calling

2021-04-19 Thread Min Hu (Connor)
'bm_mc_init' only return 0, but the function whicl calls int check the negative ret, and this is redundant. This patch fixed it by not checking the return value. Fixes: f38f61e982f8 ("bus/dpaa: add BMAN hardware interfaces") Cc: sta...@dpdk.org Signed-off-by: Min Hu (Connor) --- drivers/bus/dp

[dpdk-dev] [PATCH 04/10] app/regex: fix division by zero

2021-04-19 Thread Min Hu (Connor)
Variable nb_jobs, which may be zero, is used as a denominator. This patch fixed it. Fixes: f5cffb7eb7fb ("app/regex: read data file once at startup") Cc: sta...@dpdk.org Signed-off-by: Min Hu (Connor) --- app/test-regex/main.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff

[dpdk-dev] [PATCH 10/10] net/bonding: fix configuration assignment overflow

2021-04-19 Thread Min Hu (Connor)
From: Chengchang Tang The expression may cause an overflow. This patch fix the codeDEX static check warning "INTEGER_OVERFLOW". Fixes: 46fb43683679 ("bond: add mode 4") Cc: sta...@dpdk.org Signed-off-by: Chengchang Tang Signed-off-by: Min Hu (Connor) --- drivers/net/bonding/rte_eth_bond_802

[dpdk-dev] [PATCH 05/10] app/test: add null pointer check of memory allocation

2021-04-19 Thread Min Hu (Connor)
From: HongBo Zheng The rte_zmalloc is called in test_crc_calc without null pointer check. This patch adds null pointer checks on return value of rte_zmalloc. Fixes: 9c77b848b1c1 ("test: add CRC computation") Cc: sta...@dpdk.org Signed-off-by: HongBo Zheng Signed-off-by: Min Hu (Connor) --- a

[dpdk-dev] [PATCH 07/10] examples/l3fwd: add function return value check

2021-04-19 Thread Min Hu (Connor)
From: HongBo Zheng Return value of a function 'rte_eth_macaddr_get' called at l3fwd_eth_dev_port_setup is not checked, but it is usually checked for this function. This patch fix this problem. Fixes: a65bf3d724df ("examples/l3fwd: add ethdev setup based on eventdev") Cc: sta...@dpdk.org Signed

[dpdk-dev] [PATCH 06/10] lib/librte_pipeline: fix the use of unsafe strcpy

2021-04-19 Thread Min Hu (Connor)
From: HongBo Zheng 'strcpy' is called in rte_swx_ctl_table_info_get, this function is unsafe, use 'strncpy' instead. Fixes: 393b96e2aa2a ("pipeline: add SWX pipeline query API") Cc: sta...@dpdk.org Signed-off-by: HongBo Zheng Signed-off-by: Min Hu (Connor) --- lib/librte_pipeline/rte_swx_pip

[dpdk-dev] [PATCH 09/10] net/e1000: add function return value check

2021-04-19 Thread Min Hu (Connor)
From: HongBo Zheng Return value of a function 'e1000_phy_has_link_generic' called at e1000_kmrn_lock_loss_workaround_ich8lan is not checked, but it is usually checked for this function. This patch fix this problem. Fixes: 5a32a257f957 ("e1000: more NICs in base driver") Cc: sta...@dpdk.org Sig

[dpdk-dev] [PATCH 01/10] net/pfe: check return value

2021-04-19 Thread Min Hu (Connor)
Variable 'fd', which may receive negative value when open "/dev/mem" file. This patch added checking return value process. Fixes: 67fc3ff97c39 ("net/pfe: introduce basic functions") Cc: sta...@dpdk.org Signed-off-by: Min Hu (Connor) --- drivers/net/pfe/pfe_ethdev.c | 6 ++ 1 file changed,

[dpdk-dev] [PATCH 02/10] common/sfc_efx/base: delete redundant handling

2021-04-19 Thread Min Hu (Connor)
the default case in 'rhead_nic_get_bar_region' is unreachable. This patch fixed that. Fixes: 3c1c5cc4a786 ("common/sfc_efx/base: add Riverhead support to NIC module") Cc: sta...@dpdk.org Signed-off-by: Min Hu (Connor) --- drivers/common/sfc_efx/base/rhead_nic.c | 3 +-- 1 file changed, 1 inser

[dpdk-dev] [PATCH 08/10] crypto/virtio: fix return values check error

2021-04-19 Thread Min Hu (Connor)
From: HongBo Zheng In virtio_crypto_pkt_tx_burst, we check the return values of virtqueue_crypto_enqueue_xmit, which may returns -ENOSPC/-EMSGSIZE, but we only check ENOSPC/EMSGSIZE, and cause the result of checks is always false. This patch fix this problem. Fixes: 82adb12a1fce ("crypto/virtio

[dpdk-dev] net/mlx5: no TX in multi-process setup (testpmd working)

2021-04-19 Thread Rajesh Kumar
Hi, DPDK: 19.11 OS: Ubuntu 18.04 (Kernel: 5.4.0-1043-azure) Iface: Mellanox Technologies MT27710 Family [ConnectX-4 Lx Virtual Function] We are bringing-up our dpdk based app on azure cloud, its multi-process setup (primary does dev_configure & dev_start ) – however no packet are getting tr

Re: [dpdk-dev] [PATCH v11] app/testpmd: support multi-process

2021-04-19 Thread Ferruh Yigit
On 4/19/2021 2:03 AM, Min Hu (Connor) wrote: This patch adds multi-process support for testpmd. The test cmd example as follows: the primary cmd: ./dpdk-testpmd -a xxx --proc-type=auto -l 0-1 -- -i \ --rxq=4 --txq=4 --num-procs=2 --proc-id=0 the secondary cmd: ./dpdk-testpmd -a xxx --proc-type=a

Re: [dpdk-dev] [PATCH 00/14] Build file updates

2021-04-19 Thread Thomas Monjalon
19/04/2021 15:09, Bruce Richardson: > On Mon, Apr 19, 2021 at 02:20:47AM +0200, Thomas Monjalon wrote: > > 16/04/2021 19:04, Bruce Richardson: > > > RFC -> V1: * rebased to current main branch * performed cleanup on many > > > meson.build files to ensure correct formatting of lists: * split lists >

Re: [dpdk-dev] [PATCH v3 1/3] ethdev: introduce conntrack flow action and item

2021-04-19 Thread Thomas Monjalon
16/04/2021 19:54, Bing Zhao: > +/** > + * The packet is valid after conntrack checking. > + */ > +#define RTE_FLOW_CONNTRACK_PKT_STATE_VALID RTE_BIT32(0) > +/** > + * The state of the connection is changed. > + */ > +#define RTE_FLOW_CONNTRACK_PKT_STATE_CHANGED RTE_BIT32(1) > +/** > + * Error is de

Re: [dpdk-dev] [PATCH v3 1/3] ethdev: introduce conntrack flow action and item

2021-04-19 Thread Thomas Monjalon
16/04/2021 20:30, Ajit Khaparde: > On Fri, Apr 16, 2021 at 10:54 AM Bing Zhao wrote: > > +struct rte_flow_action_conntrack { > > + /** The peer port number, can be the same port. */ > > + uint16_t peer_port; > > + /** > > +* Direction of this connection when creating a fl

Re: [dpdk-dev] [PATCH 00/14] Build file updates

2021-04-19 Thread Bruce Richardson
On Mon, Apr 19, 2021 at 03:47:49PM +0200, Thomas Monjalon wrote: > 19/04/2021 15:09, Bruce Richardson: > > On Mon, Apr 19, 2021 at 02:20:47AM +0200, Thomas Monjalon wrote: > > > 16/04/2021 19:04, Bruce Richardson: > > > > RFC -> V1: * rebased to current main branch * performed cleanup on many > > >

Re: [dpdk-dev] [PATCH v2] mbuf: support eCPRI hardware packet type

2021-04-19 Thread Olivier Matz
Hi Lingyu, On Sat, Apr 17, 2021 at 09:25:31AM +, Lingyu Liu wrote: > Add L2_ETHER_ECPRI and L4_UDP_TUNNEL_ECPRI in RTE_PTYPE. > > Signed-off-by: Lingyu Liu > Acked-by: Hemant Agrawal The number of available packet types for tunnels is quite low (already mentionned in this thread [1]). [1]

[dpdk-dev] [PATCH v5] Change shared action API to action handle API

2021-04-19 Thread Bing Zhao
The patch set includes: 1. API changes 2. testpmd adaption and guide update 3. driver update (only net/mlx5 is impacted) 4. rte_flow documentation update --- v2: add adaptions of testpmd and driver part v3: squash all patches into one and update rte_flow doc v4: fix the doc format er

[dpdk-dev] [PATCH v5] ethdev: introduce indirect action APIs

2021-04-19 Thread Bing Zhao
Right now, rte_flow_shared_action_* APIs are used for some shared actions, like RSS, count. The shared action should be created before using it inside a flow. These shared actions sometimes are not really shared but just some indirect actions decoupled from a flow. The new functions rte_flow_actio

[dpdk-dev] [PATCH v5 1/1] ethdev: introduce indirect action APIs

2021-04-19 Thread Bing Zhao
Right now, rte_flow_shared_action_* APIs are used for some shared actions, like RSS, count. The shared action should be created before using it inside a flow. These shared actions sometimes are not really shared but just some indirect actions decoupled from a flow. The new functions rte_flow_actio

[dpdk-dev] [PATCH v5 0/1] Change shared action API to action handle API

2021-04-19 Thread Bing Zhao
The patch set includes: 1. API changes 2. testpmd adaption and guide update 3. driver update (only net/mlx5 is impacted) 4. rte_flow documentation update --- v2: add adaptions of testpmd and driver part v3: squash all patches into one and update rte_flow doc v4: fix the doc format er

Re: [dpdk-dev] [PATCH 0/3] add lock-free stack support discovery

2021-04-19 Thread Stanisław Kardach
On Fri, Apr 16, 2021 at 08:34:29AM +0200, David Marchand wrote: > On Mon, Apr 12, 2021 at 10:29 AM Stanislaw Kardach wrote: > > > > The lock-free stack implementation (RTE_STACK_F_LF) is supported only on a > > subset of platforms, namely x86_64 and arm64. Platforms supporting 128b > > atomics >

Re: [dpdk-dev] [PATCH v5 1/1] ethdev: introduce indirect action APIs

2021-04-19 Thread Thomas Monjalon
19/04/2021 16:38, Bing Zhao: > The new functions rte_flow_action_handle_* are added to replace > the current shared functions rte_flow_shared_action_*. [...] > Signed-off-by: Bing Zhao > Acked-by: Andrey Vesnovaty > Acked-by: Ori Kam > Acked-by: Ajit Khaparde Acked-by: Thomas Monjalon

Re: [dpdk-dev] [PATCH V3] app/testpmd: support Tx mbuf free on demand cmd

2021-04-19 Thread Ferruh Yigit
On 4/19/2021 1:40 PM, oulijun wrote: 在 2021/4/19 11:11, Li, Xiaoyun 写道: Hi -Original Message- From: Lijun Ou Sent: Monday, April 12, 2021 21:13 To: Yigit, Ferruh Cc: Li, Xiaoyun ; dev@dpdk.org; linux...@openeuler.org Subject: [PATCH V3] app/testpmd: support Tx mbuf free on demand c

Re: [dpdk-dev] [PATCH v4 1/1] ethdev: introduce indirect action APIs

2021-04-19 Thread Bing Zhao
Hi Thomas, All the comments were addressed in the v5. Many thanks. > -Original Message- > From: Thomas Monjalon > Sent: Monday, April 19, 2021 8:26 PM > To: Ori Kam ; Bing Zhao > Cc: ferruh.yi...@intel.com; andrew.rybche...@oktetlabs.ru; Matan > Azrad ; Slava Ovsiienko ; > dev@dpdk.org;

Re: [dpdk-dev] [PATCH] app: fix redundant comparison

2021-04-19 Thread Stephen Hemminger
On Mon, 19 Apr 2021 20:29:51 +0800 "Min Hu (Connor)" wrote: > The return value of 'rte_eal_cleanup' is always zero, so comparison > with zero is redundant. > > This patch fixed it by deleting the redundant comparison. > > Fixes: 67684d1e87b6 ("app/procinfo: call EAL cleanup before exit") > Fixe

Re: [dpdk-dev] [PATCH v5 1/1] ethdev: introduce indirect action APIs

2021-04-19 Thread Ferruh Yigit
On 4/19/2021 3:50 PM, Thomas Monjalon wrote: 19/04/2021 16:38, Bing Zhao: The new functions rte_flow_action_handle_* are added to replace the current shared functions rte_flow_shared_action_*. [...] Signed-off-by: Bing Zhao Acked-by: Andrey Vesnovaty Acked-by: Ori Kam Acked-by: Ajit Khapard

Re: [dpdk-dev] [PATCH V4] app/testpmd: support Tx mbuf free on demand cmd

2021-04-19 Thread Ferruh Yigit
On 4/19/2021 1:36 PM, Lijun Ou wrote: From: Chengwen Feng This patch support tx_done_cleanup command: tx_done_cleanup port (port_id) (queue_id) (free_cnt) Instead of creating a new root level, 'tx_done_cleanup' command, what do you think to use existing port command, something like: "port

Re: [dpdk-dev] [PATCH] app/testpmd: support the query of link flow ctrl info

2021-04-19 Thread Kevin Traynor
On 15/04/2021 07:46, Min Hu (Connor) wrote: > From: Huisong Li > > This patch supports the query of the link flow control parameter > on a port. > > The command format is as follows: > show port flow_ctrl > > Signed-off-by: Huisong Li > Signed-off-by: Min Hu (Connor) Hi Connor, Just a few

Re: [dpdk-dev] [PATCH v4 1/4] app/testpmd: add packet id for IP fragment

2021-04-19 Thread Ferruh Yigit
On 4/13/2021 9:10 AM, Jeff Guo wrote: Add the new items to support the flow configuration for IP fragment packets. Signed-off-by: Ting Xu Signed-off-by: Jeff Guo Hi Ori, Can you please check this patch? If you don't have any objection, I am planning to get it for rc1.

  1   2   3   >