Re: [dpdk-dev] [EXT] Re: DPDK Telemetry library enhancement

2021-05-05 Thread David Marchand
On Wed, May 5, 2021 at 12:06 PM Harman Kalra wrote: > > > We have a use case where we need to gather statistics over network. > > > Current > > implementation of telemetry library is based on Unix socket, we would like > > to > > enhance the scope of library to use network sockets. We understand

Re: [dpdk-dev] [PATCH v6 1/8] ether: refine debug build option

2021-05-05 Thread Ferruh Yigit
On 4/1/2021 3:30 PM, Ferruh Yigit wrote: > On 3/31/2021 10:52 AM, Qi Zhang wrote: >> PMDs use RTE_LIBRTE__DEBUG_RX|TX as build option to wrap >> data path debug code. As .config has been removed since the meson build, >> It is not friendly for new DPDK users to notice those debug options. >> >> The

Re: [dpdk-dev] [PATCH v3] net/mlx5: add power monitoring support

2021-05-05 Thread Burakov, Anatoly
On 04-May-21 6:43 PM, Thomas Monjalon wrote: 04/05/2021 19:40, Ferruh Yigit: On 4/29/2021 3:55 PM, Alexander Kozyrev wrote: Support the PMD power management API in MLX5 driver. The monitor policy of this API puts a CPU core to sleep until a data in some monitored memory address is changed by th

Re: [dpdk-dev] [PATCH] doc/contributing/documentation: add info about including code

2021-05-05 Thread Burakov, Anatoly
On 04-May-21 12:56 PM, Thomas Monjalon wrote: 04/05/2021 13:15, Ferruh Yigit: On 5/4/2021 11:44 AM, Thomas Monjalon wrote: 04/05/2021 12:35, Ferruh Yigit: On 5/4/2021 10:59 AM, Thomas Monjalon wrote: 04/05/2021 11:32, Burakov, Anatoly: On 03-May-21 10:02 PM, Thomas Monjalon wrote: 21/04/202

[dpdk-dev] [PATCH] config/arm: add ability to express arch extensions

2021-05-05 Thread pbhagavatula
From: Pavan Nikhilesh The ARM architecture allows SoCs to have extensions in addition to base profiles such as Large System Extension (LSE), CRC etc. Add ability to declare SoC specific extensions. Signed-off-by: Pavan Nikhilesh --- More details about ARM extensions https://developer.arm.co

[dpdk-dev] [PATCH] crypto/dpaa2_sec: fix the close and unint functions

2021-05-05 Thread Hemant Agrawal
The init function was calling the dpseci_open while dpseci_close was called by the open function. This is a mismatch un-init shall clean the init configurations and close shall clear the configure function settings. This was causing issue with recent changes in test framework, where the close was

Re: [dpdk-dev] [PATCH v3 0/7] test: refactor crypto unit test framework

2021-05-05 Thread Hemant Agrawal
The issue was in dpaa2_sec driver, fix is submitted. Series Acked-by: Hemant Agrawal On 5/5/2021 4:11 PM, Hemant Agrawal wrote: Sorry for top posting. Akhil,     Will you please hold for a day on this patch? we are seeing few failures on dpaa2 with this patch, currently debugging them.

Re: [dpdk-dev] [PATCH v6 1/8] ether: refine debug build option

2021-05-05 Thread Michał Krawczyk
śr., 5 maj 2021 o 13:45 Ferruh Yigit napisał(a): > > On 4/1/2021 3:30 PM, Ferruh Yigit wrote: > > On 3/31/2021 10:52 AM, Qi Zhang wrote: > >> PMDs use RTE_LIBRTE__DEBUG_RX|TX as build option to wrap > >> data path debug code. As .config has been removed since the meson build, > >> It is not friend

[dpdk-dev] [PATCH v7 00/17] conntrack support in mlx5 PMD

2021-05-05 Thread Bing Zhao
This patch set adds the connection tracking offload support in the mlx5 driver, as well as the documents update. --- v2: code bug fixes, commits clean up and doc update v3: fix error input pointer for CT MR registering v4: fix typo in commit message of patch 11 v5: adjust mkey to lkey in SQ initi

[dpdk-dev] [PATCH v7 01/17] common/mlx5: add connection tracking object definition

2021-05-05 Thread Bing Zhao
The structures of ASO connection tracking offload object are added based on the definitions in the PRM. One CT object context will be loaded into the cache completely in a reversed order of dwords. The valid bit should be the MSB of the last dword. This is used for the conntrack context creation an

[dpdk-dev] [PATCH v7 02/17] common/mlx5: add CT offload capability checking

2021-05-05 Thread Bing Zhao
During startup, the ASO connection tracking offload capability could be queried via HCA_CAP_QUERY command. If the HW doesn't support ASO CT, the value would be 0 by default. The following initialization should be skipped and the creation of the CT object should return a failure directly. The follo

[dpdk-dev] [PATCH v7 03/17] net/mlx5: use meter color reg for CT

2021-05-05 Thread Bing Zhao
Based on the capacity, 3 registers could be used. Due to the register allocation, only the one REG_C_3 for meter color could be reused right now. Then in the same flow, no more than one ASO action can be supported. Signed-off-by: Bing Zhao Acked-by: Viacheslav Ovsiienko --- drivers/net/mlx5/ml

[dpdk-dev] [PATCH v7 04/17] net/mlx5: initialization of CT management

2021-05-05 Thread Bing Zhao
The definitions of ASO connection tracking objects management structures are added. Considering performance, the bulk allocation of ASO CT objects should be used. The maximal value per bulk and the granularity could be fetched from HCA capabilities 2. Right now, a fixed number of 64 is used for ea

[dpdk-dev] [PATCH v7 05/17] common/mlx5: add Dexv CT objects creation

2021-05-05 Thread Bing Zhao
Adding support for connection tracking ASO creation via Devx command. Right now only bulk creation is supported. By default, the objects with zero contents will be created. Before using a single object, the modification via posting a WQE to the ASO CT SQ is needed. Signed-off-by: Bing Zhao Acked

[dpdk-dev] [PATCH v7 06/17] net/mlx5: add modify support for CT

2021-05-05 Thread Bing Zhao
After the connection tracking object bulk is allocated, all the objects' contents are filled with zero by default. Every new-allocated object must be modified via WQE operation before it is used. In order to reduce the latency for the flow creation, an asynchronous way is used instead of busy wait

[dpdk-dev] [PATCH v7 07/17] net/mlx5: add actions creating for CT

2021-05-05 Thread Bing Zhao
Allocating a CT from the management pools and creating the DR actions for both directions by default. If there is no available connection tracking action, a new pool will be created with a fixed size bulk allocation. Right now, all the resources are controlled by the linked list. The ASO connecti

[dpdk-dev] [PATCH v7 08/17] net/mlx5: close CT management structure

2021-05-05 Thread Bing Zhao
When freeing the IB shared context during stopping a device, the ASO connection tracking management structure should also be cleaned up. All the DR actions created should be destroyed. The structures need to be freed and ASO CT QP should be released. In the meanwhile, the allocated and registered

[dpdk-dev] [PATCH v7 12/17] net/mlx5: add translation of CT item

2021-05-05 Thread Bing Zhao
The return register of the DR action will be used for matching. After the ASO CT checking of a TCP packet, the syndrome is filled in the register. Only the 8 LSB should be used. A converting from RTE_FLOW_CONNTRACK_FLAG* to the syndrome should be done after checing the spec and mask fields. Signed

[dpdk-dev] [PATCH v7 10/17] net/mlx5: add ASO CT destroy handling

2021-05-05 Thread Bing Zhao
When trying to destroy an ASO connection tracking context, the DR action created on this context should also be destroyed. Before inserting the related software object into the management free list, the reference count should be checked. Right now, the context object will not be freed to the syste

[dpdk-dev] [PATCH v7 11/17] net/mlx5: add translation of CT action

2021-05-05 Thread Bing Zhao
When creating a flow with this action context for CT, it needs to be translated in 2 levels. First, retrieve from action context to rte_flow action. Second, translate it to the corresponding DR action with traffic direction that was specified when creating or updating via rte_flow_action_handle* A

[dpdk-dev] [PATCH v7 09/17] net/mlx5: add ASO CT query implementation

2021-05-05 Thread Bing Zhao
After the connection tracking context is created and being used by the flows, the context will be updated by the HW automatically after a packet passed the CT validation. E.g., the ACK, SEQ, window and state of CT can be updated with both direction traffic. In order to query the updated contents o

[dpdk-dev] [PATCH v7 13/17] net/mlx5: add CT context update

2021-05-05 Thread Bing Zhao
When updating a connection tracking context, two separate parts could be updated. First, the direction. This will only update the traffic direction recorded in the software for flow creation. Second, the TCP parameters. The hardware context will be updated via the WQE. This update will be blocked u

[dpdk-dev] [PATCH v7 14/17] net/mlx5: validation of CT action

2021-05-05 Thread Bing Zhao
The validation of a CT action contains two parts. The first is the CT action configurations parameter. When creating a CT action context, some members need to be verified. The second is that when creating a flow, the DR action of CT should be validated with other actions and items as well. Current

[dpdk-dev] [PATCH v7 15/17] net/mlx5: validation of CT item

2021-05-05 Thread Bing Zhao
The item of ASO connection tracking will be translated into the register value when matching. The validation of this item has no dependency on other layers, since the flow including this item should be jumped from another group. All the layers checking was already done in the previous groups. Only

[dpdk-dev] [PATCH v7 16/17] net/mlx5: add support of CT between two ports

2021-05-05 Thread Bing Zhao
After creating a connection tracking context, it can be used between two ports. For each port, the flow for one direction traffic will be created. The context can only be shared between the owner port and the peer port that was specified when being created. Only the owner port could update the con

[dpdk-dev] [PATCH v7 17/17] doc: update mlx5 support for conntrack

2021-05-05 Thread Bing Zhao
In the release notes and mlx5 NIC document, the support and limitation of connection tracking are added. Signed-off-by: Bing Zhao Acked-by: Viacheslav Ovsiienko --- doc/guides/nics/features/default.ini | 1 + doc/guides/nics/features/mlx5.ini | 1 + doc/guides/nics/mlx5.rst

Re: [dpdk-dev] [PATCH] config/arm: add ability to express arch extensions

2021-05-05 Thread Jerin Jacob
On Wed, May 5, 2021 at 5:44 PM wrote: > > From: Pavan Nikhilesh > > The ARM architecture allows SoCs to have extensions in addition > to base profiles such as Large System Extension (LSE), CRC etc. > > Add ability to declare SoC specific extensions. > > Signed-off-by: Pavan Nikhilesh Acked-by:

Re: [dpdk-dev] [EXT] [PATCH v4 0/8] baseband: add NXP LA12xx driver

2021-05-05 Thread Akhil Goyal
> Subject: [EXT] [PATCH v4 0/8] baseband: add NXP LA12xx driver > > This series introduces the BBDEV LA12xx poll mode driver (PMD) to support > an implementation for offloading High Phy processing functions like > LDPC Encode / Decode 5GNR wireless acceleration function, using PCI based > LA12xx S

Re: [dpdk-dev] [PATCH] examples: allow pkg-config to override

2021-05-05 Thread Bruce Richardson
On Wed, May 05, 2021 at 04:49:44PM +0530, jer...@marvell.com wrote: > From: Jerin Jacob > > In the cross-compilation environment, it possible to have > different package config such as aarch64-linux-gnu-pkg-config. > Use PKGCONF variable to detect the libdpdk availability. > > Signed-off-by: Jer

Re: [dpdk-dev] [PATCH] baseband/turbo_sw: fix dereference of null

2021-05-05 Thread Akhil Goyal
> > > > -Original Message- > > From: Min Hu (Connor) > > Sent: Thursday, April 22, 2021 2:25 AM > > > > Return value of a function 'rte_malloc' is dereferenced without checking, > > and may result in segmetation fault. > > > > This patch fixed it. > > > > Fixes: 31a7853d1ed9 ("baseband/t

Re: [dpdk-dev] [PATCH] telemetry: remove internal symbol from public header

2021-05-05 Thread Power, Ciara
>-Original Message- >From: Jerin Jacob >Sent: Wednesday 5 May 2021 11:25 >To: David Marchand >Cc: Power, Ciara ; Richardson, Bruce >; jer...@marvell.com; dev@dpdk.org; >tho...@monjalon.net >Subject: Re: [dpdk-dev] [PATCH] telemetry: remove internal symbol from >public header > >On Wed, M

[dpdk-dev] [PATCH] lib: restore developer mode checks

2021-05-05 Thread David Marchand
Most of the checks on developer_mode have been accidentally dropped. Restore them. Fixes: 7d611e35b077 ("lib: simplify main build file") Signed-off-by: David Marchand --- lib/meson.build | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/meson.build b/lib/meson.build in

[dpdk-dev] [PATCH v2] examples: fix pkg-config override sequence

2021-05-05 Thread jerinj
From: Jerin Jacob Move pkg-config override to beginning in the Makefile to allow use PKGCONF variable to detect the libdpdk availability. Fixes: fda34680eb9a ("examples: remove legacy sections of makefiles") Cc: sta...@dpdk.org Signed-off-by: Jerin Jacob --- v2: Update the git comments to exp

[dpdk-dev] [PATCH v2 1/2] devtools: catch symbol duplicates in version map

2021-05-05 Thread David Marchand
Add a check on versioned symbol duplicates in map files. Signed-off-by: David Marchand --- Changes since v1: - rebased, --- devtools/check-symbol-maps.sh | 15 +++ 1 file changed, 15 insertions(+) diff --git a/devtools/check-symbol-maps.sh b/devtools/check-symbol-maps.sh index f063

[dpdk-dev] [PATCH v2 2/2] buildtools: check symbol maps in developer mode

2021-05-05 Thread David Marchand
Hook check-symbol-maps.sh in the symbol check when in developer mode to help developers catch issues before submitting their changes. Signed-off-by: David Marchand --- Changes since v1: - now that we have the developer mode, added this check in the build process, --- buildtools/check-symbols.

Re: [dpdk-dev] [PATCH v6 1/8] ether: refine debug build option

2021-05-05 Thread Ferruh Yigit
On 5/5/2021 1:21 PM, Michał Krawczyk wrote: > śr., 5 maj 2021 o 13:45 Ferruh Yigit napisał(a): >> >> On 4/1/2021 3:30 PM, Ferruh Yigit wrote: >>> On 3/31/2021 10:52 AM, Qi Zhang wrote: PMDs use RTE_LIBRTE__DEBUG_RX|TX as build option to wrap data path debug code. As .config has been remo

Re: [dpdk-dev] [dpdk-stable] [PATCH] ethdev: add missing buses in dev iterator

2021-05-05 Thread Xu, Rosen
Hi Thomas and Ferruh, I just back from my Labor Day Holiday. I have checked there is no usage in ifpga bus. Thanks, Rosen > -Original Message- > From: Thomas Monjalon > Sent: Tuesday, May 04, 2021 23:50 > To: hemant.agra...@nxp.com; Yigit, Ferruh > Cc: dev@dpdk.org; sta...@dpdk.org; s

Re: [dpdk-dev] [EXT] [PATCH v2] app/bbdev: fix wrong variable

2021-05-05 Thread Akhil Goyal
> The logging should show context by printing the two variable which > compared to each other. 'nb_harq_inputs', not 'nb_hard_outputs'; > 'nb_harq_outputs', not 'nb_hard_outputs'. > > This patch corrected misused variable. > > Fixes: d819c08327f3 ("app/bbdev: update for 5GNR") > Cc: sta...@dpdk.o

[dpdk-dev] [dpdk-dev v2] test/crypto: copy offset data to oop dst buffer

2021-05-05 Thread Kai Ji
Copy over the offset data required for auth in out-of-place op when auth offset and cipher offset are not aligned. Fixes: e847fc512817 ("test/crypto: add encrypted digest case for AES-CTR-CMAC") Cc: adamx.dybkow...@intel.com Signed-off-by: Kai Ji --- v2: - rebase to head of for-main branch a

Re: [dpdk-dev] [PATCH 1/2] common/qat: increase IM buffer size for QAT GEN3

2021-05-05 Thread Akhil Goyal
> > Subject: [PATCH 1/2] common/qat: increase IM buffer size for QAT GEN3 > > > > This patch increases the intermediate buffer size used for the > > compression on QAT GEN3 to accommodate new hardware versions. > > > > Fixes: a124830a6f00 ("compress/qat: enable dynamic huffman encoding") > > > > Si

Re: [dpdk-dev] [EXT] [PATCH] examples/ipsec-secgw: fix handling IPv6 extension headers

2021-05-05 Thread Akhil Goyal
> Recent patch to support UDP encapsulation introduced problem with > handling inbound IPv6 packets with header extensions. > This patch aims to fix the issue. > > Bugzilla ID: 695 > Fixes: 9a1cc8f1ed74 ("examples/ipsec-secgw: support UDP encapsulation") > > Reported-by: Vladimir Medvedkin > Sig

Re: [dpdk-dev] [PATCH v2 0/2] test/distributor: perf burst mode quit fixes

2021-05-05 Thread David Marchand
On Wed, Apr 28, 2021 at 4:28 PM Stanislaw Kardach wrote: > > This series addresses two issues: > > 1. Worker threads hang when finishing the burst-mode distributor perf >test. This was observed on a RISC-V platform as well as reproduced on >x86. > 2. Potential lack of fairness in final wak

Re: [dpdk-dev] [PATCH] ppc64le: fix build with Clang and without glibc

2021-05-05 Thread David Marchand
On Tue, Mar 23, 2021 at 6:48 PM Piotr Kubaj wrote: > > Looks like I forgot to commit the change that includes headers for > sysctlbyname(). > > Patch attached. The mailing list drops attachments. Please submit a v2. Thanks. -- David Marchand

Re: [dpdk-dev] [EXT] [PATCH v2] app/crypto-perf: fix dereference of null return

2021-05-05 Thread Akhil Goyal
> Return value of a function 'rte_zmalloc' is dereferenced without > checking, and it may call segmentation fault. > > This patch fixed it. > > Fixes: f8be1786b1b8 ("app/crypto-perf: introduce performance test > application") > Cc: sta...@dpdk.org > > Signed-off-by: Min Hu (Connor) > --- > v2:

Re: [dpdk-dev] test/crypto: fix auth-cipher compare length in oop

2021-05-05 Thread Akhil Goyal
> > Subject: [dpdk-dev] test/crypto: fix auth-cipher compare length in oop > > > > For out-of-place operations, comparing expected ciphertext with > > the operation result should skip cipher_offset bytes, as those > > will not be copied from source to the destination buffer, making > > the tests fa

Re: [dpdk-dev] [EXT] [PATCH] crypto/dpaa_sec: fix to affine the thread portal affinity

2021-05-05 Thread Akhil Goyal
> DPAA requires the I/O shall be done in a HW portal context only. > The portal affinity is currently only being done in session create > and config APIs with the assumption that same thread will be used > for IO. This is causing issue. > This patch add support during I/O to check the HW portal aff

Re: [dpdk-dev] [EXT] [PATCH] crypto/dpaa2_sec: fix the close and unint functions

2021-05-05 Thread Akhil Goyal
> The init function was calling the dpseci_open > while dpseci_close was called by the open function. > This is a mismatch un-init shall clean the init configurations and > close shall clear the configure function settings. > > This was causing issue with recent changes in test framework, where >

[dpdk-dev] [PATCH] telemetry: fix accessing callbacks list using lock

2021-05-05 Thread Ciara Power
The list_commands() function accessed the callbacks list, but did not take the lock. This may have caused inconsistencies if callbacks were being registered at the same time. This is now fixed to lock before iterating the list, and unlock afterwards. Fixes: f38748736eb2 ("telemetry: add default ca

Re: [dpdk-dev] [EXT] [dpdk-dev v2] test/crypto: copy offset data to oop dst buffer

2021-05-05 Thread Akhil Goyal
> Copy over the offset data required for auth in out-of-place op > when auth offset and cipher offset are not aligned. > > Fixes: e847fc512817 ("test/crypto: add encrypted digest case for AES-CTR- > CMAC") > Cc: adamx.dybkow...@intel.com > > Signed-off-by: Kai Ji > --- > v2: >- rebase to hea

Re: [dpdk-dev] [PATCH v2] examples: fix pkg-config override sequence

2021-05-05 Thread Bruce Richardson
On Wed, May 05, 2021 at 07:55:25PM +0530, jer...@marvell.com wrote: > From: Jerin Jacob > > Move pkg-config override to beginning in the Makefile to allow > use PKGCONF variable to detect the libdpdk availability. > > Fixes: fda34680eb9a ("examples: remove legacy sections of makefiles") > Cc: st

Re: [dpdk-dev] [PATCH] lib: restore developer mode checks

2021-05-05 Thread Bruce Richardson
On Wed, May 05, 2021 at 04:21:05PM +0200, David Marchand wrote: > Most of the checks on developer_mode have been accidentally dropped. > Restore them. > > Fixes: 7d611e35b077 ("lib: simplify main build file") > > Signed-off-by: David Marchand > --- Thanks. Acked-by: Bruce Richardson

Re: [dpdk-dev] [PATCH] telemetry: fix accessing callbacks list using lock

2021-05-05 Thread Bruce Richardson
On Wed, May 05, 2021 at 03:22:48PM +, Ciara Power wrote: > The list_commands() function accessed the callbacks list, > but did not take the lock. This may have caused inconsistencies if > callbacks were being registered at the same time. > This is now fixed to lock before iterating the list, >

Re: [dpdk-dev] [PATCH] app/testpmd: support meter color action in policy

2021-05-05 Thread Ori Kam
HI Haifei, > -Original Message- > From: Dumitrescu, Cristian > Sent: Monday, May 3, 2021 3:11 PM > Subject: RE: [PATCH] app/testpmd: support meter color action in policy > > > > > -Original Message- > > From: Yigit, Ferruh > > Sent: Friday, April 30, 2021 1:51 PM > > To: Haife

Re: [dpdk-dev] Questions about API with no parameter check

2021-05-05 Thread Tyler Retzlaff
On Tue, May 04, 2021 at 09:36:24AM +, Ananyev, Konstantin wrote: > > > > > > 2021-04-29 09:16 (UTC-0700), Tyler Retzlaff: > > > On Wed, Apr 07, 2021 at 05:10:00PM +0100, Ferruh Yigit wrote: > > > > On 4/7/2021 4:25 PM, Hemant Agrawal wrote: > > > > >>+1 > > > > >>But are we going to check al

[dpdk-dev] [PATCH] doc: support IPsec Multi-buffer lib v1.0

2021-05-05 Thread Pablo de Lara
Updated AESNI MB and AESNI GCM, KASUMI, ZUC and SNOW3G PMD documentation guides with information about the latest Intel IPSec Multi-buffer library supported. Signed-off-by: Pablo de Lara --- doc/guides/cryptodevs/aesni_gcm.rst | 6 +++--- doc/guides/cryptodevs/aesni_mb.rst | 6 +++--- doc/guide

Re: [dpdk-dev] [PATCH v10 00/10] app/testpmd: enable testpmd on Windows

2021-05-05 Thread Jie Zhou
On Tue, May 04, 2021 at 09:31:08AM +0200, Thomas Monjalon wrote: > When you receive an ack in previous versions, > you should add it manually in your patch > so we keep track of it. > Will send out V11 with adding back the acked-by from V9. Thanks.

Re: [dpdk-dev] [PATCH] examples/rxtx_callbacks: fix port ID format specifier

2021-05-05 Thread Tyler Retzlaff
On Tue, May 04, 2021 at 09:48:22AM +0300, Dmitry Kozlyuk wrote: > 2021-05-03 17:11 (UTC-0700), Tyler Retzlaff: > > On Sun, May 02, 2021 at 05:56:56AM +0300, Dmitry Kozlyuk wrote: > > > Use "%u" and a cast as in other places when port ID is formatted. > > > This fixes -Wformat warning with clang 10.

Re: [dpdk-dev] [PATCH v10 07/10] app/testpmd: replace POSIX specific code

2021-05-05 Thread Jie Zhou
On Wed, May 05, 2021 at 08:34:34AM +, Tal Shnaiderman wrote: > > Subject: [PATCH v10 07/10] app/testpmd: replace POSIX specific code > > > > External email: Use caution opening links or attachments > > > > > > - Make printf format OS independent > > - Replace htons with RTE_BE16 > > - Rep

Re: [dpdk-dev] [PATCH] telemetry: remove internal symbol from public header

2021-05-05 Thread David Marchand
On Tue, May 4, 2021 at 6:19 PM Power, Ciara wrote: > >> Remove TELEMETRY_MAX_CALLBACKS symbol from public rte_telemetry.h > >> header file. > >> > >> Signed-off-by: Jerin Jacob > >Acked-by: Bruce Richardson > Acked-by: Ciara Power Applied, thanks. I'll post my suggestion as a patch aimed at 2

Re: [dpdk-dev] [PATCH] telemetry: fix accessing callbacks list using lock

2021-05-05 Thread David Marchand
On Wed, May 5, 2021 at 5:36 PM Bruce Richardson wrote: > > On Wed, May 05, 2021 at 03:22:48PM +, Ciara Power wrote: > > The list_commands() function accessed the callbacks list, > > but did not take the lock. This may have caused inconsistencies if > > callbacks were being registered at the sa

Re: [dpdk-dev] [PATCH] eal: avoid side effects in RTE_ALIGN_MUL_NEAR(v, mul) for v and mul

2021-05-05 Thread Tyler Retzlaff
On Fri, Mar 12, 2021 at 09:07:22AM +0100, David Marchand wrote: > On Thu, Mar 11, 2021 at 10:08 PM Tyler Retzlaff > wrote: > > > > Avoid expanding v and mul parameters multiple times in the macro. based > > on usage of the macro it seems like side effects were not intended. > > > > For example: >

Re: [dpdk-dev] [PATCH v10 07/10] app/testpmd: replace POSIX specific code

2021-05-05 Thread Jie Zhou
On Wed, May 05, 2021 at 09:09:20AM -0700, Jie Zhou wrote: > On Wed, May 05, 2021 at 08:34:34AM +, Tal Shnaiderman wrote: > > > Subject: [PATCH v10 07/10] app/testpmd: replace POSIX specific code > > > > > > External email: Use caution opening links or attachments > > > > > > > > > - Make pr

Re: [dpdk-dev] [PATCH v1] test/ticketlock: use C11 atomic builtins for lcores sync

2021-05-05 Thread Tyler Retzlaff
On Wed, May 05, 2021 at 12:37:50AM +, Honnappa Nagarahalli wrote: > > > > > > > > > > > your subject line indicates the use of C11 which is a standard [1]. > > > > > > > > the patch itself uses gcc atomics builtins which are not part of C11 > > > > standard so the subject line is incorrect a

[dpdk-dev] [dpdk-dev v1] crypto/snow3g: add support for digest appended ops

2021-05-05 Thread Kai Ji
This patch enable out-of-place auth-cipher operations where digest should be encrypted among with the rest of raw data. It also adds support for partially encrypted digest when using auth-cipher operations. Fixes: 7c87e2d7b359 ("crypto/snow3g: use IPsec library") Cc: pablo.de.lara.gua...@intel.com

[dpdk-dev] [PATCH v11 01/10] lib: build libraries that testpmd depends on

2021-05-05 Thread Jie Zhou
Enable building libraries that testpmd depends on for Windows Signed-off-by: Jie Zhou Signed-off-by: Jie Zhou --- lib/meson.build | 7 +++ 1 file changed, 7 insertions(+) diff --git a/lib/meson.build b/lib/meson.build index c9a20f65b..2d499b238 100644 --- a/lib/meson.build +++ b/lib/meson.

[dpdk-dev] [PATCH v11 02/10] eal/windows: add necessary macros

2021-05-05 Thread Jie Zhou
Add required macros by testpmd on Windows in rte_os_shim.h Signed-off-by: Jie Zhou Signed-off-by: Jie Zhou Acked-by: Tal Shnaiderman --- lib/eal/windows/include/rte_os_shim.h | 9 + 1 file changed, 9 insertions(+) diff --git a/lib/eal/windows/include/rte_os_shim.h b/lib/eal/windows/

[dpdk-dev] [PATCH v11 00/10] app/testpmd: enable testpmd on Windows

2021-05-05 Thread Jie Zhou
This patchset is to enable testpmd on windows. It mainly includes: - Enable building libraries on Windows that testpmd depends on - Add necessary macros required by testpmd on Windows in rte_os_shim.h - Add device event stubs for Windows - Resolve name collisions with Windows types - Add clock_gett

[dpdk-dev] [PATCH v11 03/10] eal/windows: add device event stubs

2021-05-05 Thread Jie Zhou
Add device event stubs in eal_dev.c for Windows Signed-off-by: Jie Zhou Signed-off-by: Jie Zhou Acked-by: Tal Shnaiderman --- lib/eal/windows/eal_dev.c | 33 + lib/eal/windows/meson.build | 1 + 2 files changed, 34 insertions(+) create mode 100644 lib/eal/w

[dpdk-dev] [PATCH v11 04/10] eal/Windows: add clock_gettime on Windows

2021-05-05 Thread Jie Zhou
Add clock_gettime on Windows in rte_os_shim.h Signed-off-by: Jie Zhou Signed-off-by: Jie Zhou --- lib/eal/windows/include/rte_os_shim.h | 38 +++ 1 file changed, 38 insertions(+) diff --git a/lib/eal/windows/include/rte_os_shim.h b/lib/eal/windows/include/rte_os_shim.h

[dpdk-dev] [PATCH v11 06/10] app/testpmd: fix parse_fec_mode return type name

2021-05-05 Thread Jie Zhou
Replace parse_fec_mode misleading return type name mode with fec_capa Fixes: b19da32e3151 ("app/testpmd: add FEC command") Cc: sta...@dpdk.org Signed-off-by: Jie Zhou Signed-off-by: Jie Zhou --- app/test-pmd/cmdline.c | 6 +++--- app/test-pmd/config.c | 4 ++-- app/test-pmd/testpmd.h | 2 +-

[dpdk-dev] [PATCH v11 08/10] app/testpmd: fix headers inclusion

2021-05-05 Thread Jie Zhou
- Include rte_os_shim.h in testpmd.h - Remove redundant headers Signed-off-by: Jie Zhou Signed-off-by: Jie Zhou Acked-by: Tal Shnaiderman --- app/test-pmd/cmdline.c | 3 --- app/test-pmd/cmdline_flow.c | 2 -- app/test-pmd/parameters.c | 1 - app/test-pmd/testpmd.h | 1 + 4 files

[dpdk-dev] [PATCH v11 07/10] app/testpmd: replace POSIX specific code

2021-05-05 Thread Jie Zhou
- Make printf format OS independent - Replace htons with RTE_BE16 - Replace POSIX specific inet_aton with OS independent inet_pton - Replace sleep with rte_delay_us_sleep - Repalce random with rte_rand - #ifndef mman related code for now Signed-off-by: Jie Zhou Signed-off-by: Jie Zhou ---

[dpdk-dev] [PATCH v11 09/10] app/testpmd: fix unused function warnings

2021-05-05 Thread Jie Zhou
Function print_fdir_mask and print_fdir_flex_payload is only called when either i40e or ixgbe presents. Add #if defined to remove "unused function" compilation warning. Signed-off-by: Jie Zhou Signed-off-by: Jie Zhou Acked-by: Tal Shnaiderman --- app/test-pmd/config.c | 82 +++

[dpdk-dev] [PATCH v11 05/10] app/testpmd: resolve name collisions

2021-05-05 Thread Jie Zhou
Resolve name collisions with Windows types Signed-off-by: Jie Zhou Signed-off-by: Jie Zhou Acked-by: Tal Shnaiderman --- app/test-pmd/cmdline_flow.c | 512 ++-- 1 file changed, 256 insertions(+), 256 deletions(-) diff --git a/app/test-pmd/cmdline_flow.c b/app/

[dpdk-dev] [PATCH v11 10/10] app/testpmd: enable building testpmd on Windows

2021-05-05 Thread Jie Zhou
From: Jie Zhou - Disable unsupported Apps on Windows - Enable building of testpmd on Windows Signed-off-by: Jie Zhou Signed-off-by: Jie Zhou Acked-by: Tal Shnaiderman --- app/meson.build| 4 app/pdump/meson.build | 6 ++ app/proc-info/meson.build

Re: [dpdk-dev] [PATCH v7 00/17] conntrack support in mlx5 PMD

2021-05-05 Thread Raslan Darawsheh
Hi, > -Original Message- > From: Bing Zhao > Sent: Wednesday, May 5, 2021 3:23 PM > To: Slava Ovsiienko ; Matan Azrad > ; NBU-Contact-Thomas Monjalon > > Cc: dev@dpdk.org; Ori Kam ; Raslan Darawsheh > > Subject: [PATCH v7 00/17] conntrack support in mlx5 PMD > > This patch set adds the

[dpdk-dev] [PATCH v12 02/10] eal/windows: add necessary macros

2021-05-05 Thread Jie Zhou
Add required macros by testpmd on Windows in rte_os_shim.h Signed-off-by: Jie Zhou Signed-off-by: Jie Zhou Acked-by: Tal Shnaiderman --- lib/eal/windows/include/rte_os_shim.h | 9 + 1 file changed, 9 insertions(+) diff --git a/lib/eal/windows/include/rte_os_shim.h b/lib/eal/windows/

[dpdk-dev] [PATCH v12 01/10] lib: build libraries that testpmd depends on

2021-05-05 Thread Jie Zhou
Enable building libraries that testpmd depends on for Windows Signed-off-by: Jie Zhou Signed-off-by: Jie Zhou --- lib/meson.build | 7 +++ 1 file changed, 7 insertions(+) diff --git a/lib/meson.build b/lib/meson.build index c9a20f65b..2d499b238 100644 --- a/lib/meson.build +++ b/lib/meson.

[dpdk-dev] [PATCH v12 03/10] eal/windows: add device event stubs

2021-05-05 Thread Jie Zhou
Add device event stubs in eal_dev.c for Windows Signed-off-by: Jie Zhou Signed-off-by: Jie Zhou Acked-by: Tal Shnaiderman --- lib/eal/windows/eal_dev.c | 33 + lib/eal/windows/meson.build | 1 + 2 files changed, 34 insertions(+) create mode 100644 lib/eal/w

[dpdk-dev] [PATCH v12 00/10] app/testpmd: enable testpmd on Windows

2021-05-05 Thread Jie Zhou
Future work: - Some issues discovered at validation need further investigations * Perf inconsistency: TPUT fluctuated significantly from runs * After traffic stop, port stats shows pps being 0 while bps not * mempool allocation only succeed with native. Other methods failed at rte_mem_loc

[dpdk-dev] [PATCH v12 06/10] app/testpmd: fix parse_fec_mode return type name

2021-05-05 Thread Jie Zhou
Replace parse_fec_mode misleading return type name mode with fec_capa Fixes: b19da32e3151 ("app/testpmd: add FEC command") Cc: sta...@dpdk.org Signed-off-by: Jie Zhou Signed-off-by: Jie Zhou --- app/test-pmd/cmdline.c | 6 +++--- app/test-pmd/config.c | 4 ++-- app/test-pmd/testpmd.h | 2 +-

[dpdk-dev] [PATCH v12 08/10] app/testpmd: fix headers inclusion

2021-05-05 Thread Jie Zhou
- Include rte_os_shim.h in testpmd.h - Remove redundant headers Signed-off-by: Jie Zhou Signed-off-by: Jie Zhou Acked-by: Tal Shnaiderman --- app/test-pmd/cmdline.c | 3 --- app/test-pmd/cmdline_flow.c | 2 -- app/test-pmd/parameters.c | 1 - app/test-pmd/testpmd.h | 1 + 4 files c

[dpdk-dev] [PATCH v12 10/10] app/testpmd: enable building testpmd on Windows

2021-05-05 Thread Jie Zhou
From: Jie Zhou - Disable unsupported Apps on Windows - Enable building of testpmd on Windows Signed-off-by: Jie Zhou Signed-off-by: Jie Zhou Acked-by: Tal Shnaiderman --- app/meson.build| 4 app/pdump/meson.build | 6 ++ app/proc-info/meson.build

[dpdk-dev] [PATCH v12 04/10] eal/Windows: add clock_gettime on Windows

2021-05-05 Thread Jie Zhou
Add clock_gettime on Windows in rte_os_shim.h Signed-off-by: Jie Zhou Signed-off-by: Jie Zhou --- lib/eal/windows/include/rte_os_shim.h | 38 +++ 1 file changed, 38 insertions(+) diff --git a/lib/eal/windows/include/rte_os_shim.h b/lib/eal/windows/include/rte_os_shim.h

[dpdk-dev] [PATCH v12 07/10] app/testpmd: replace POSIX specific code

2021-05-05 Thread Jie Zhou
- Make printf format OS independent - Replace htons with RTE_BE16 - Replace POSIX specific inet_aton with OS independent inet_pton - Replace sleep with rte_delay_us_sleep - Repalce random with rte_rand - #ifndef mman related code for now Signed-off-by: Jie Zhou Signed-off-by: Jie Zhou ---

[dpdk-dev] [PATCH v12 05/10] app/testpmd: resolve name collisions

2021-05-05 Thread Jie Zhou
Resolve name collisions with Windows types Signed-off-by: Jie Zhou Signed-off-by: Jie Zhou Acked-by: Tal Shnaiderman --- app/test-pmd/cmdline_flow.c | 512 ++-- 1 file changed, 256 insertions(+), 256 deletions(-) diff --git a/app/test-pmd/cmdline_flow.c b/app/

[dpdk-dev] [PATCH v12 09/10] app/testpmd: fix unused function warnings

2021-05-05 Thread Jie Zhou
Function print_fdir_mask and print_fdir_flex_payload is only called when either i40e or ixgbe presents. Add #if defined to remove "unused function" compilation warning. Signed-off-by: Jie Zhou Signed-off-by: Jie Zhou Acked-by: Tal Shnaiderman --- app/test-pmd/config.c | 82

Re: [dpdk-dev] [dpdk-stable] [PATCH v3] net/mlx5: fix tunnel offload private items location

2021-05-05 Thread Ferruh Yigit
On 5/4/2021 10:12 AM, Gregory Etelson wrote: > Hello Ferruh, > > [:snip:] > >> Hi Gregory, >> >> The were some questions around testpmd part of this patch in previous >> version, they are not answered and this version is dropping the testpmd >> part. >> > > The tunnel offload API allows applicat

Re: [dpdk-dev] [PATCH v2] hash: fix tuple adjustment

2021-05-05 Thread Wang, Yipeng1
> -Original Message- > From: Medvedkin, Vladimir > Sent: Tuesday, May 4, 2021 7:25 AM > To: dev@dpdk.org > Cc: Ananyev, Konstantin ; Chilikin, Andrey > ; Kinsella, Ray ; Wang, > Yipeng1 ; Gobriel, Sameh > ; Richardson, Bruce > ; david.march...@redhat.com; > k...@semihalf.com; Medvedkin, Vl

Re: [dpdk-dev] [PATCH v7 17/17] doc: update mlx5 support for conntrack

2021-05-05 Thread Ferruh Yigit
On 5/5/2021 1:23 PM, Bing Zhao wrote: > In the release notes and mlx5 NIC document, the support and > limitation of connection tracking are added. > A new NIC feature seems added, better to be acked beyond the mlx5 scope. > Signed-off-by: Bing Zhao > Acked-by: Viacheslav Ovsiienko > --- > doc

[dpdk-dev] [PATCH] net/enic: enable GENEVE offload via VNIC configuration

2021-05-05 Thread John Daley
The admin-configured vNIC settings (i.e. via CIMC or UCSM) now include Geneve offload. Use that setting to decide whether to enable or disable Geneve offload and remove the devarg 'geneve-opt'. Also, the firmware now allows the driver to change the Geneve port number. So extend udp_tunnel_port_{ad

[dpdk-dev] [PATCH v13 01/10] lib: build libraries that testpmd depends on

2021-05-05 Thread Jie Zhou
Enable building libraries that testpmd depends on for Windows Signed-off-by: Jie Zhou Signed-off-by: Jie Zhou --- lib/meson.build | 7 +++ 1 file changed, 7 insertions(+) diff --git a/lib/meson.build b/lib/meson.build index 64a59abab..3fd1ffa0b 100644 --- a/lib/meson.build +++ b/lib/meson.

[dpdk-dev] [PATCH v13 03/10] eal/windows: add device event stubs

2021-05-05 Thread Jie Zhou
Add device event stubs in eal_dev.c for Windows Signed-off-by: Jie Zhou Signed-off-by: Jie Zhou Acked-by: Tal Shnaiderman --- lib/eal/windows/eal_dev.c | 33 + lib/eal/windows/meson.build | 1 + 2 files changed, 34 insertions(+) create mode 100644 lib/eal/wi

[dpdk-dev] [PATCH v13 04/10] eal/Windows: add clock_gettime on Windows

2021-05-05 Thread Jie Zhou
Add clock_gettime on Windows in rte_os_shim.h Signed-off-by: Jie Zhou Signed-off-by: Jie Zhou --- lib/eal/windows/include/rte_os_shim.h | 38 +++ 1 file changed, 38 insertions(+) diff --git a/lib/eal/windows/include/rte_os_shim.h b/lib/eal/windows/include/rte_os_shim.h

[dpdk-dev] [PATCH v13 00/10] app/testpmd: enable testpmd on Windows

2021-05-05 Thread Jie Zhou
This patchset is to enable testpmd on windows. It mainly includes: - Enable building libraries on Windows that testpmd depends on - Add necessary macros required by testpmd on Windows in rte_os_shim.h - Add device event stubs for Windows - Resolve name collisions with Windows types - Add clock_gett

[dpdk-dev] [PATCH v13 02/10] eal/windows: add necessary macros

2021-05-05 Thread Jie Zhou
Add required macros by testpmd on Windows in rte_os_shim.h Signed-off-by: Jie Zhou Signed-off-by: Jie Zhou Acked-by: Tal Shnaiderman --- lib/eal/windows/include/rte_os_shim.h | 9 + 1 file changed, 9 insertions(+) diff --git a/lib/eal/windows/include/rte_os_shim.h b/lib/eal/windows/i

[dpdk-dev] [PATCH v13 08/10] app/testpmd: fix headers inclusion

2021-05-05 Thread Jie Zhou
- Include rte_os_shim.h in testpmd.h - Remove redundant headers Signed-off-by: Jie Zhou Signed-off-by: Jie Zhou Acked-by: Tal Shnaiderman --- app/test-pmd/cmdline.c | 3 --- app/test-pmd/cmdline_flow.c | 2 -- app/test-pmd/parameters.c | 1 - app/test-pmd/testpmd.h | 1 + 4 files c

[dpdk-dev] [PATCH v13 06/10] app/testpmd: fix parse_fec_mode return type name

2021-05-05 Thread Jie Zhou
Replace parse_fec_mode misleading return type name mode with fec_capa Fixes: b19da32e3151 ("app/testpmd: add FEC command") Cc: sta...@dpdk.org Signed-off-by: Jie Zhou Signed-off-by: Jie Zhou --- app/test-pmd/cmdline.c | 6 +++--- app/test-pmd/config.c | 4 ++-- app/test-pmd/testpmd.h | 2 +-

[dpdk-dev] [PATCH v13 05/10] app/testpmd: resolve name collisions

2021-05-05 Thread Jie Zhou
Resolve name collisions with Windows types Signed-off-by: Jie Zhou Signed-off-by: Jie Zhou Acked-by: Tal Shnaiderman --- app/test-pmd/cmdline_flow.c | 512 ++-- 1 file changed, 256 insertions(+), 256 deletions(-) diff --git a/app/test-pmd/cmdline_flow.c b/app/t

[dpdk-dev] [PATCH v13 07/10] app/testpmd: replace POSIX specific code

2021-05-05 Thread Jie Zhou
- Make printf format OS independent - Replace htons with RTE_BE16 - Replace POSIX specific inet_aton with OS independent inet_pton - Replace sleep with rte_delay_us_sleep - Repalce random with rte_rand - #ifndef mman related code for now Signed-off-by: Jie Zhou Signed-off-by: Jie Zhou ---

<    1   2   3   >