Hi, Ruifeng
Could we go further and implement loop inside the conditional?
Like this:
if (mlx5_mr_btree_len(&rxq->mr_ctrl.cache_bh) > 1) {
for (i = 0; i < n; ++i) {
void *buf_addr = elts[i]->buf_addr;
wq[i].addr = rte_cpu_to_be_64((uintptr_t)buf_addr +
On Sat, Jun 26, 2021 at 11:59:49AM +0800, fengchengwen wrote:
> Hi, all
> I analyzed the current DPAM DMA driver and drew this summary in conjunction
> with the previous discussion, and this will as a basis for the V2
> implementation.
> Feedback is welcome, thanks
>
>
> dpaa2_qdma:
> [pro
> -Original Message-
> From: Slava Ovsiienko
> Sent: Friday, July 2, 2021 3:06 PM
> To: Ruifeng Wang ; Raslan Darawsheh
> ; Matan Azrad ; Shahaf Shuler
>
> Cc: dev@dpdk.org; jer...@marvell.com; nd ; Honnappa
> Nagarahalli
> Subject: RE: [PATCH 2/2] net/mlx5: reduce unnecessary memory acc
On 5/28/21 10:11 AM, Jiayu Hu wrote:
> The vhost notifies the application of device readiness via
> vhost_user_notify_queue_state(), but calling this function
> is not protected by the lock. This patch is to make this
> function call lock protected.
>
> Fixes: d0fcc38f5fa4 ("vhost: improve devi
> From: Bruce Richardson [mailto:bruce.richard...@intel.com]
> Sent: Thursday, 1 July 2021 18.34
>
> On Thu, Jul 01, 2021 at 08:31:00PM +0530, Jerin Jacob wrote:
> > On Sat, Jun 26, 2021 at 9:29 AM fengchengwen
> wrote:
> > >
> > > Hi, all
> > > I analyzed the current DPAM DMA driver and drew t
On 5/28/21 10:11 AM, Jiayu Hu wrote:
> This patch is to add thread unsafe version for async register and
s/is to add/adds/
> unregister functions.
>
> Signed-off-by: Jiayu Hu
> ---
> doc/guides/prog_guide/vhost_lib.rst | 12 +++
> lib/vhost/rte_vhost_async.h | 42 ++
> lib
On Thu, Jul 1, 2021 at 5:50 PM Ali Alnubani wrote:
>
> Hi,
>
> > -Original Message-
> > From: Christian Ehrhardt
> > Sent: Thursday, June 17, 2021 9:38 AM
> > To: sta...@dpdk.org
> > Cc: dev@dpdk.org; Abhishek Marathe ;
> > Akhil Goyal ; Ali Alnubani ;
> > benjamin.wal...@intel.com; David
On 7/1/21 10:19 PM, Wiles, Keith wrote:
>
>
>> On Jul 1, 2021, at 12:18 PM, Stephen Hemminger
>> wrote:
>>
>> On Thu, 1 Jul 2021 17:16:21 +0300
>> Andrew Rybchenko wrote:
>>
>>> On 6/16/21 7:15 AM, Stephen Hemminger wrote:
Since these always return 0, they were doing nothing useful.
Regarding the ongoing ABI stability project, it is suggested to export driver
interfaces as internal.
What are we targeting regarding ABI and API stability towards drivers?
-Morten
On 7/1/21 4:35 PM, Bruce Richardson wrote:
> On Thu, Jul 01, 2021 at 04:05:56PM +0300, Andrew Rybchenko wrote:
>> @Bruce, see below.
>>
>> On 7/1/21 3:34 PM, David Marchand wrote:
>>> On Thu, Jul 1, 2021 at 11:22 AM Andrew Rybchenko
>>> wrote:
The build works fine for me on FC34, but it has
>
> -Original Message-
> From: dev On Behalf Of Wenzhuo Lu
> Sent: Tuesday, June 29, 2021 10:29 AM
> To: dev@dpdk.org
> Cc: Lu, Wenzhuo
> Subject: [dpdk-dev] [PATCH v3 0/2] add Rx/Tx offload paths for ICE AVX2
>
> Add specific paths for RX/TX AVX2, called offload paths.
> In these paths,
Hi, Ruifeng
> -Original Message-
> From: Ruifeng Wang
> Sent: Tuesday, June 1, 2021 11:31
> To: Raslan Darawsheh ; Matan Azrad
> ; Shahaf Shuler ; Slava Ovsiienko
>
> Cc: dev@dpdk.org; jer...@marvell.com; n...@arm.com;
> honnappa.nagaraha...@arm.com; Ruifeng Wang ;
> sta...@dpdk.org
> Su
This patch set fixs several problems of MPLS RSS:
- removed MPLSoIP(HW doesn't support) related code
- support MPLSoUDP, MPLSoGRE RSS expansion
- reduced number of expanded sub-flows for inner MPLS
Xiaoyu Min (3):
net/mlx5: fix MPLS over IP
net/mlx5: fix MPLS RSS expansion
net/mlx5: limit
HW doesn't support match MPLS over IP traffic.
Remove related code.
Fixes: d1abe664ddde ("net/mlx5: add MPLS to Direct Verbs flow engine")
Cc: sta...@dpdk.org
Signed-off-by: Xiaoyu Min
---
drivers/net/mlx5/mlx5_flow.c| 5 ++---
drivers/net/mlx5/mlx5_flow_dv.c | 3 ---
2 files changed, 2 in
MPLSoUDP and MPLSoGRE are supported by PMD from
rte flow point of view.
RSS expansion doesn't support above but, instead, supports
normal MPLS over L2, which actually will be rejected by PMD.
This patch removes RSS expansion support of the MPLS over L2
and adds support of MPLSoUDP and MPLSoGRE.
If user wants to do MPLS inner RSS and only provides pattern
till MPLS without inner items [1], RSS expansion will expand flows
into 13 sub-flows[2] which is too many and it impacts flow insert
rate, stack usage becomes large as well.
This expansion into 13 sub-flows seems not worthy of and it can
Update base driver and support COUNT action in transfer flow rules.
v4:
- fix build on Fedora 32 and RHEL 8 / CentOS 8 with half-installed
libatomic
v3:
- fix build brekage because of incorrectly rebased and squashed
in fix
v2:
- add release notes
- add missing documentaion
- fix spel
rxq_intr flag requests support for interrupt mode for ethdev Rx queues.
There is no internal Rx queues yet.
Signed-off-by: Andrew Rybchenko
---
drivers/net/sfc/sfc_ev.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/net/sfc/sfc_ev.c b/drivers/net/sfc/sfc_ev.c
inde
From: Igor Romanov
Make software index of an Rx queue and ethdev index separate.
When an ethdev RxQ is accessed in ethdev callbacks, an explicit ethdev
queue index is used.
This is a preparation to introducing non-ethdev Rx queues.
Signed-off-by: Igor Romanov
Signed-off-by: Andrew Rybchenko
R
Target EvQ and IRQ number are specified in the same location
in MCDI request. The value is treated as IRQ number if the
event queue is interrupting (corresponding flag is set) and
as target event queue otherwise.
However it is better to separate it on helper API level to
make it more clear.
Signe
Custom mapping is actually supported for EF10 and EF100 families only.
A driver (e.g. DPDK PMD) may require to customize mapping of EvQ
to interrupts if, for example, extra EvQ are used for house-keeping
in polling or wake up (via another EvQ) mode.
Signed-off-by: Andrew Rybchenko
Reviewed-by: A
Interrupts support has assumptions on interrupt numbers used
for LSC and Rx queues. The first interrupt is used for LSC,
subsequent interrupts are used for Rx queues.
Signed-off-by: Andrew Rybchenko
Reviewed-by: Andy Moreton
---
drivers/net/sfc/sfc_ev.c | 32
1
From: Igor Romanov
Make software index of a Tx queue and ethdev index separate.
When an ethdev TxQ is accessed in ethdev callbacks, an explicit ethdev
queue index is used.
This is a preparation to introducing non-ethdev Tx queues.
Signed-off-by: Igor Romanov
Signed-off-by: Andrew Rybchenko
Re
From: Igor Romanov
Add a flag to request support for ingress m-port on an RxQ.
Implement it only for Riverhead, other families will return an error
if the flag is set.
Signed-off-by: Igor Romanov
Signed-off-by: Andrew Rybchenko
Reviewed-by: Andy Moreton
Reviewed-by: Ivan Malov
---
drivers/c
From: Igor Romanov
Add a flag to request support for user mark field on an RxQ.
The field is required to retrieve generation count value from
counter RxQ.
Implement it only for Riverhead and EF10 ESSB since they support
the field in the Rx prefix.
Signed-off-by: Igor Romanov
Signed-off-by: And
From: Igor Romanov
Add a function returning management event queue software index.
Signed-off-by: Igor Romanov
Signed-off-by: Andrew Rybchenko
Reviewed-by: Andy Moreton
---
drivers/net/sfc/sfc_ev.c | 2 +-
drivers/net/sfc/sfc_ev.h | 6 ++
2 files changed, 7 insertions(+), 1 deletion(-)
From: Igor Romanov
Add extra EFX flags to RxQ info initialization API to support
choosing different RxQ types and make the API public to use
it in for counter queues.
Signed-off-by: Igor Romanov
Signed-off-by: Andrew Rybchenko
Reviewed-by: Andy Moreton
---
drivers/net/sfc/sfc_rx.c | 10 +
The driver requires service cores for housekeeping. Share these
cores for many adapters and various purposes to avoid extra CPU
overhead.
Since housekeeping services will talk to NIC, it should be possible
to choose logical core on matching NUMA node.
Signed-off-by: Andrew Rybchenko
Reviewed-by:
From: Igor Romanov
MAE delivers counters data as special packets via dedicated Rx queue.
Reserve an RxQ so that it does not interfere with ethdev Rx queues.
A routine will be added later to handle these packets.
There is no point to reserve the queue if no service cores are
available and counter
From: Igor Romanov
User will be able to create and free MAE counters. Support for
associating counters with action set will be added in upcoming
patches.
Signed-off-by: Igor Romanov
Signed-off-by: Andrew Rybchenko
Reviewed-by: Andy Moreton
Reviewed-by: Ivan Malov
---
drivers/common/sfc_efx/
From: Igor Romanov
The MCDIs will be used to control counter Rx queue packet flow.
Signed-off-by: Igor Romanov
Signed-off-by: Andrew Rybchenko
Reviewed-by: Andy Moreton
Reviewed-by: Ivan Malov
---
drivers/common/sfc_efx/base/efx.h | 32 ++
drivers/common/sfc_efx/base/efx_mae.c | 13
From: Igor Romanov
The information about the number of pushed Rx buffers is required
for counter Rx queue to know when to give credits to counter
stream.
Signed-off-by: Igor Romanov
Signed-off-by: Andrew Rybchenko
Reviewed-by: Andy Moreton
Reviewed-by: Ivan Malov
---
drivers/net/sfc/sfc_dp_
From: Igor Romanov
User will be able to associate counter with MAE action set to
collect counter packets and bytes for a specific action set.
Signed-off-by: Igor Romanov
Signed-off-by: Andrew Rybchenko
Reviewed-by: Andy Moreton
Reviewed-by: Ivan Malov
---
drivers/common/sfc_efx/base/efx.h
From: Igor Romanov
The information about the maximum number of MAE counters is
crucial to the counter support in the driver.
Signed-off-by: Igor Romanov
Signed-off-by: Andrew Rybchenko
Reviewed-by: Andy Moreton
Reviewed-by: Ivan Malov
---
drivers/common/sfc_efx/base/efx.h | 1 +
drivers
Packetiser composes packets with MAE counters update.
Signed-off-by: Andrew Rybchenko
Reviewed-by: Andy Moreton
---
.../base/efx_regs_counters_pkt_format.h | 87 +++
1 file changed, 87 insertions(+)
create mode 100644 drivers/common/sfc_efx/base/efx_regs_counters_pkt_form
From: Igor Romanov
The query reports the number of hits for a counter associated
with a flow rule.
Signed-off-by: Igor Romanov
Signed-off-by: Andrew Rybchenko
Reviewed-by: Andy Moreton
Reviewed-by: Ivan Malov
---
drivers/net/sfc/sfc_flow.c| 48 ++-
drivers/net/sf
From: Igor Romanov
For now, a rule may have only one dedicated counter, shared counters
are not supported.
HW delivers (or "streams") counter readings using special packets.
The driver creates a dedicated Rx queue to receive such packets
and requests that HW start "streaming" the readings to it.
Hi David,
On 7/1/21 4:05 PM, Andrew Rybchenko wrote:
> @Bruce, see below.
>
> On 7/1/21 3:34 PM, David Marchand wrote:
>> On Thu, Jul 1, 2021 at 11:22 AM Andrew Rybchenko
>> wrote:
>>> The build works fine for me on FC34, but it has
>>> libatomic-11.1.1-3.fc34.x86_64 installed.
>>
>> I first pro
https://bugs.dpdk.org/show_bug.cgi?id=749
Bug ID: 749
Summary: mlx5: ConnectX-6 not all missed packets accounted for
when using large maximum packet size
Product: DPDK
Version: unspecified
Hardware: x86
OS:
On 6/30/21 4:56 AM, Min Hu (Connor) wrote:
> From: Chengwen Feng
>
> This patch adds link status event pre-conditions.
>
> Signed-off-by: Chengwen Feng
> Signed-off-by: Min Hu (Connor)
> ---
> v2:
> * not modified, only waiting for 5.13 kernel released.
> ---
> doc/guides/nics/hns3.rst | 10 +
This adds several fixes in ASO meter. With these fixes, meter created
on one port can be shared by other ports.
Shun Hao (4):
net/mlx5: use meter profile lookup table
net/mlx5: fix meter policy ID table container
net/mlx5: fix meter flow direction check
net/mlx5: fix meter policy flow matc
Currently a list is used to save all meter profile ids, which is
not efficient when looking up profile from huge mount of profiles.
This changes to use a l3 table instead to save meter profile ids,
so as to improve the lookup performance.
Signed-off-by: Shun Hao
Acked-by: Matan Azrad
---
drive
The meter policy handlers are managed by user IDs and the driver used l3
table in order to map the user ID to the internal driver handler of the
policy.
The l3 table was wrongly saved in the shared device structure which
manages all the switch domain ports what made the user IDs shared
between dif
When preparing prefix flow using ASO meter, if it's tx flow, need
to make meter action the first one.
Currently the check of flow direction in switch domain is incorrect
that it checks the flow dev port only.
This adds the fix for the check that if there's port_id match item
in flow, use that por
Currently when creating meter policy, a src port_id match item will
always be added in switch domain. So if one meter is used by another
port, it will not work correctly.
This issue is solved:
1. If policy fate action is port_id, add the src port_id match item,
and the meter cannot be shared by an
On 7/1/21 7:56 PM, Rahul Lakkireddy wrote:
> This series of patches add support to fetch port and queue stats via
> xstats API.
>
> Patch 1 adds support to fetch port and queue stats via xstats API.
Fixed mulit-line comments to following DPDK coding style.
Just made it single-line.
> Patch 2 rem
On 7/2/2021 10:00 AM, Morten Brørup wrote:
> Regarding the ongoing ABI stability project, it is suggested to export driver
> interfaces as internal.
>
> What are we targeting regarding ABI and API stability towards drivers?
>
Hi Morten,
It is about some device abstraction libraries, like crypt
On 4/29/21 11:42 AM, Li, Xiaoyun wrote:
>> -Original Message-
>> From: Min Hu (Connor)
>> Sent: Wednesday, April 28, 2021 16:37
>> To: dev@dpdk.org
>> Cc: Yigit, Ferruh ; Li, Xiaoyun
>>
>> Subject: [PATCH v2 2/2] app/testpmd: fix link speed for a specified port
>>
>> From: Huisong Li
>>
On 6/29/21 10:31 AM, Min Hu (Connor) wrote:
> Hi, Singh
>
> 在 2021/6/29 14:24, Singh, Aman Deep 写道:
>> Hi Min Hu,
>>
>> On 6/28/2021 8:55 AM, Min Hu (Connor) wrote:
>>> Hi, all,
>>> any comments?
>>
>> As part of this series-
>> [PATCH v2 1/2]: As per Huisong Li "So let's keep it the way it w
On Fri, Jul 02, 2021 at 09:39:10AM +0200, Morten Brørup wrote:
> > From: Bruce Richardson [mailto:bruce.richard...@intel.com] Sent:
> > Thursday, 1 July 2021 18.34
> >
> > On Thu, Jul 01, 2021 at 08:31:00PM +0530, Jerin Jacob wrote:
> > > On Sat, Jun 26, 2021 at 9:29 AM fengchengwen
> > wrote:
>
@Thomas, @Ferruh, I tend to accept it (with minor style fixes),
but I need your opinion on it before doing it.
Thanks,
Andrew.
On 6/29/21 5:27 AM, Huisong Li wrote:
>
> 在 2021/6/14 23:37, Andrew Rybchenko 写道:
>> Summary should start from "ethdev: "
>>
>> Don't forget to include all maintainers i
@Xiaoyun could you share your thoughts on it?
As far as I remember there is no agreement on the topic. Adding
more people in Cc.
On 5/1/21 12:37 AM, Kathleen Capella wrote:
> Performance of the LPM mode in L3fwd example application is used as an
> industry
> standard to compare between various p
Hi Aman,
On 6/14/21 3:42 PM, Singh, Aman Deep wrote:
> Hi Ivan,
>
> As a suggestion, can we add a check for debug log_level in
> "rte_flow_snprint" itself.
I see the reason, but I think it a bad idea to put the check
inside the function. If calling function cares, it should do
the check.
> So w
> -Original Message-
> From: Slava Ovsiienko
> Sent: Friday, July 2, 2021 4:13 PM
> To: Ruifeng Wang ; Raslan Darawsheh
> ; Matan Azrad ; Shahaf Shuler
>
> Cc: dev@dpdk.org; jer...@marvell.com; nd ; Honnappa
> Nagarahalli ; sta...@dpdk.org
> Subject: RE: [PATCH 1/2] net/mlx5: remove redun
Feature flags in dev would be updated during config. On reconfigure, the
field need to be set again to original value.
Signed-off-by: Anoob Joseph
---
drivers/crypto/octeontx2/otx2_cryptodev.c | 30 ---
drivers/crypto/octeontx2/otx2_cryptodev.h | 1 +
drivers/cry
During session destroy, clear session private memory.
Signed-off-by: Anoob Joseph
---
drivers/crypto/octeontx2/otx2_cryptodev_sec.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/crypto/octeontx2/otx2_cryptodev_sec.c
b/drivers/crypto/octeontx2/otx2_cryptodev_sec.c
index 3c5686a..
Hi Rebecca,
>-Original Message-
>From: Troy, Rebecca
>Sent: Thursday 1 July 2021 10:23
>To: dev@dpdk.org
>Cc: Power, Ciara ; Troy, Rebecca
>; tomaszx.kula...@intel.com; sta...@dpdk.org;
>Doherty, Declan
>Subject: [PATCH] test/crypto: fix typo in AES testcase description
>
>Fixed typo in
On 7/1/2021 11:16 AM, 王万臣 wrote:
> Hello, I tried to run a sample program (Skeleton) after installing DPDK
> according to the Getting Started Guide for Linux document, but failed,
> "Detected shared linkage of DPDK" is missing in the output of EAL
> initialization, compared with the correct outp
> -Original Message-
> From: David Marchand
> Sent: Thursday, July 1, 2021 3:41 PM
> To: Lin, Xueqin ; Burakov, Anatoly
>
> Cc: Jerin Jacob ; Peng, ZhihongX
> ; Ananyev, Konstantin
> ; Stephen Hemminger
> ; dpdk-dev
> Subject: Re: [dpdk-dev] [RFC v2] porting AddressSanitizer feature to D
On 7/2/2021 12:08 PM, Andrew Rybchenko wrote:
> @Thomas, @Ferruh, I tend to accept it (with minor style fixes),
> but I need your opinion on it before doing it.
>
I guess we were relying on the user/application to have correct order up until
now, it can be good to add this into the API. OK to add
From: "Min Hu (Connor)"
For example the following commands run two testpmd processes:
* the primary process:
./dpdk-testpmd --proc-type=auto -l 0-1 -- -i \
--rxq=4 --txq=4 --num-procs=2 --proc-id=0
* the secondary process:
./dpdk-testpmd --proc-type=auto -l 2-3 -- -i \
--rxq=4 --txq=4
02/07/2021 10:00, Morten Brørup:
> Regarding the ongoing ABI stability project, it is suggested to export driver
> interfaces as internal.
>
> What are we targeting regarding ABI and API stability towards drivers?
No stability for driver interface.
It is recommended to make drivers internal.
If
02/07/2021 10:43, Andrew Rybchenko:
> On 7/1/21 4:05 PM, Andrew Rybchenko wrote:
> > On 7/1/21 3:34 PM, David Marchand wrote:
> >> On Thu, Jul 1, 2021 at 11:22 AM Andrew Rybchenko
> >> wrote:
> >>> The build works fine for me on FC34, but it has
> >>> libatomic-11.1.1-3.fc34.x86_64 installed.
> >>
02/07/2021 10:55, Andrew Rybchenko:
> On 6/30/21 4:56 AM, Min Hu (Connor) wrote:
> > From: Chengwen Feng
> > +Firmware 1.8.0.0 and later versions support reporting link changes to the
> > PF.
> > +Therefore, to use the LSC for the PF driver, ensure that the firmware
> > version
> > +also support
On 7/2/21 3:09 PM, Andrew Rybchenko wrote:
> From: "Min Hu (Connor)"
>
> For example the following commands run two testpmd processes:
>
> * the primary process:
>
> ./dpdk-testpmd --proc-type=auto -l 0-1 -- -i \
>--rxq=4 --txq=4 --num-procs=2 --proc-id=0
>
> * the secondary process:
>
On 7/2/21 3:30 PM, Thomas Monjalon wrote:
> 02/07/2021 10:43, Andrew Rybchenko:
>> On 7/1/21 4:05 PM, Andrew Rybchenko wrote:
>>> On 7/1/21 3:34 PM, David Marchand wrote:
On Thu, Jul 1, 2021 at 11:22 AM Andrew Rybchenko
wrote:
> The build works fine for me on FC34, but it has
> l
When multi-process is not wanted and DPDK is run with the "no-shconf"
flag, the telemetry library still needs a runtime directory to place the
unix socket for telemetry connections. Therefore, rather than not
creating the directory when this flag is set, we can change the code to
attempt the creati
If the library fails to create the needed socket, add an additional
check to report if the error is due to a missing DPDK runtime dir.
Signed-off-by: Bruce Richardson
---
lib/telemetry/telemetry.c | 5 +
1 file changed, 5 insertions(+)
diff --git a/lib/telemetry/telemetry.c b/lib/telemetry/
On 7/2/21 3:35 PM, Thomas Monjalon wrote:
> 02/07/2021 10:55, Andrew Rybchenko:
>> On 6/30/21 4:56 AM, Min Hu (Connor) wrote:
>>> From: Chengwen Feng
>>> +Firmware 1.8.0.0 and later versions support reporting link changes to the
>>> PF.
>>> +Therefore, to use the LSC for the PF driver, ensure tha
On 6/17/21 1:59 PM, Jiawen Wu wrote:
> Adding bare minimum PMD library and doc build infrastructure
> and claim the maintainership for ngbe PMD.
>
> Signed-off-by: Jiawen Wu
Just one nit below.
[snip]
> diff --git a/drivers/net/ngbe/ngbe_ethdev.c b/drivers/net/ngbe/ngbe_ethdev.c
> new file mod
This patch introduces 'dmadevice' which is a generic type of DMA
device.
The APIs of dmadev library exposes some generic operations which can
enable configuration and I/O with the DMA devices.
Signed-off-by: Chengwen Feng
---
MAINTAINERS | 4 +
config/rte_config.h |
On 6/17/21 1:59 PM, Jiawen Wu wrote:
> Add log type and error type to trace functions.
>
> Signed-off-by: Jiawen Wu
> ---
> doc/guides/nics/ngbe.rst| 21 +
> drivers/net/ngbe/base/ngbe_status.h | 73 +
> drivers/net/ngbe/ngbe_ethdev.c | 14 +++
On 6/17/21 1:59 PM, Jiawen Wu wrote:
> Add device IDs for Wangxun 1Gb NICs, map device IDs to register ngbe
> PMD. Add basic PCIe ethdev probe and remove.
>
> Signed-off-by: Jiawen Wu
> ---
> doc/guides/nics/features/ngbe.ini | 1 +
> drivers/net/ngbe/base/meson.build | 18 +++
> driver
>
> On 7/2/2021 12:08 PM, Andrew Rybchenko wrote:
> > @Thomas, @Ferruh, I tend to accept it (with minor style fixes),
> > but I need your opinion on it before doing it.
> >
>
> I guess we were relying on the user/application to have correct order up until
> now, it can be good to add this into
> On Jun 15, 2021, at 11:15 PM, Stephen Hemminger
> wrote:
>
> This looks like some infrastructure that was set for some future
> change that never happened. Remove it.
>
> Stephen Hemminger (2):
> tap: remove useless offload capa functions
> tap: replace offload_capa function with define
On 2021/6/28 18:00, Bruce Richardson wrote:
>> 4) The driver's ops design (here we only list key points):
>> [dev_info_get]: mainly return the number of HW-queues
>> [dev_configure]: nothing important
>> [queue_setup]: create one virt-queue, has following main parameters:
>>
On 7/2/21 4:26 PM, Wiles, Keith wrote:
>
>
>> On Jun 15, 2021, at 11:15 PM, Stephen Hemminger
>> wrote:
>>
>> This looks like some infrastructure that was set for some future
>> change that never happened. Remove it.
>>
>> Stephen Hemminger (2):
>> tap: remove useless offload capa functions
>>
On Fri, Jul 2, 2021 at 10:43 AM Andrew Rybchenko
wrote:
> I've send v4 with the problem fixed. However, I'm afraid
> build test systems should be updated to have libatomic
> correctly installed. Otherwise, they do not really check
> net/sfc build.
CI systems must be updated if they check ABI.
And
On 7/2/21 4:37 PM, David Marchand wrote:
> On Fri, Jul 2, 2021 at 10:43 AM Andrew Rybchenko
> wrote:
>> I've send v4 with the problem fixed. However, I'm afraid
>> build test systems should be updated to have libatomic
>> correctly installed. Otherwise, they do not really check
>> net/sfc build.
>
On 2021/7/1 23:01, Jerin Jacob wrote:
>> [key point]:
>> ------
>> | channel || channel |
>> ------
>> \ /
>> \ /
>>\ /
>>
>> | H
On Tue, Jun 8, 2021 at 3:10 PM Andrew Rybchenko
wrote:
> > +RTE_PMD_REGISTER_VDEV(ENETFEC_NAME_PMD, pmd_enetfec_drv);
> > +RTE_PMD_REGISTER_PARAM_STRING(ENETFEC_NAME_PMD, ENET_VDEV_GEM_ID_ARG
> > "=");
> > +
> > +RTE_INIT(enetfec_pmd_init_log)
> > +{
> > + enetfec_logtype_pmd = rte_log_regist
On Fri, Jul 02, 2021 at 09:18:11PM +0800, Chengwen Feng wrote:
> This patch introduces 'dmadevice' which is a generic type of DMA
> device.
>
> The APIs of dmadev library exposes some generic operations which can
> enable configuration and I/O with the DMA devices.
>
> Signed-off-by: Chengwen Fen
On 2021/7/2 15:07, Liang Ma wrote:
>> 8) One example:
>> vq_id = rte_dmadev_queue_setup(dev, config.{HW-queue-index=x, opaque});
>> if (vq_id < 0) {
>> // create virt-queue failed
>> return;
>> }
>> // submit memcpy task
>> cookit = rte_dmadev_memcpy(dev,
Hi, Thomas
Please review this patch set, thanks.
PS: this patch set already reviewed by ARM guys, and the CI has some
errors, but it seem not related to this patch set.
On 2021/6/28 10:57, Chengwen Feng wrote:
> This patch set contains two bugfixes for SVE compile.
> Note:
> 1) Because 2/2 patc
> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Bruce Richardson
> Sent: Friday, 2 July 2021 14.56
> To: dev@dpdk.org
>
> When multi-process is not wanted and DPDK is run with the "no-shconf"
> flag, the telemetry library still needs a runtime directory to place
> the
> unix socket for tele
> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Bruce Richardson
> Sent: Friday, 2 July 2021 14.56
>
> If the library fails to create the needed socket, add an additional
> check to report if the error is due to a missing DPDK runtime dir.
>
> Signed-off-by: Bruce Richardson
> ---
> lib/
From: Viacheslav Galaktionov
In its current state, the API can overflow the user-passed buffer if a new
representor range appears between function calls.
In order to solve this problem, augment the representor info structure with
the numbers of allocated and initialized ranges. This way the user
> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of fengchengwen
> Sent: Friday, 2 July 2021 15.45
>
> On 2021/7/1 23:01, Jerin Jacob wrote:
> >> [key point]:
> >> ------
> >> | channel || channel |
> >> ------
> >> \
When VF reset happens, the QoS bandwidth configuration will be lost. If
the reset is not caused by DCB change, it is supposed to replay the
bandwidth configuration to VF by DCF. In this patch, when a vsi update
PF event is received from PF after VF reset, and it is confirmed that
DCB is not changed
The telemetry APIs have been present and unchanged for >1 year now, so
remove experimental tag from them.
Signed-off-by: Bruce Richardson
---
lib/telemetry/rte_telemetry.h | 18 --
lib/telemetry/version.map | 2 +-
2 files changed, 1 insertion(+), 19 deletions(-)
diff --git
On 6/17/21 1:59 PM, Jiawen Wu wrote:
> Add basic init and uninit function.
> Map device IDs and subsystem IDs to single ID for easy operation.
> Then initialize the shared code.
>
> Signed-off-by: Jiawen Wu
[snip]
> diff --git a/drivers/net/ngbe/ngbe_ethdev.c b/drivers/net/ngbe/ngbe_ethdev.c
>
On 6/17/21 1:59 PM, Jiawen Wu wrote:
> Initialize the hardware by resetting the hardware in base code.
>
> Signed-off-by: Jiawen Wu
[snip]
> diff --git a/drivers/net/ngbe/ngbe_ethdev.c b/drivers/net/ngbe/ngbe_ethdev.c
> index c779c46dd5..31d4dda976 100644
> --- a/drivers/net/ngbe/ngbe_ethdev.c
On 6/17/21 1:59 PM, Jiawen Wu wrote:
> Store MAC addresses and init receive address filters.
>
> Signed-off-by: Jiawen Wu
[snip]
> diff --git a/drivers/net/ngbe/ngbe_ethdev.c b/drivers/net/ngbe/ngbe_ethdev.c
> index 31d4dda976..deca64137d 100644
> --- a/drivers/net/ngbe/ngbe_ethdev.c
> +++ b/dr
On 6/17/21 1:59 PM, Jiawen Wu wrote:
> Register to handle device interrupt.
>
> Signed-off-by: Jiawen Wu
[snip]
> diff --git a/doc/guides/nics/ngbe.rst b/doc/guides/nics/ngbe.rst
> index 54d0665db9..0918cc2918 100644
> --- a/doc/guides/nics/ngbe.rst
> +++ b/doc/guides/nics/ngbe.rst
> @@ -8,6 +8
On 6/17/21 1:59 PM, Jiawen Wu wrote:
> Setup device Rx queue and release Rx queue.
>
> Signed-off-by: Jiawen Wu
> ---
> drivers/net/ngbe/meson.build | 1 +
> drivers/net/ngbe/ngbe_ethdev.c | 37 +++-
> drivers/net/ngbe/ngbe_ethdev.h | 16 ++
> drivers/net/ngbe/ngbe_rxtx.c | 308 +
On 6/17/21 1:59 PM, Jiawen Wu wrote:
> Setup device Tx queue and release Tx queue.
>
> Signed-off-by: Jiawen Wu
[snip]
> +int __rte_cold
> +ngbe_dev_tx_queue_setup(struct rte_eth_dev *dev,
> + uint16_t queue_idx,
> + uint16_t nb_desc,
> +
On 6/17/21 2:00 PM, Jiawen Wu wrote:
> Initialize device with the simplest receive function.
>
> Signed-off-by: Jiawen Wu
The patch cannot be tested before device start up.
So, it should go after the patch which implements
device and Rx queues start up.
[snip]
> diff --git a/drivers/net/ngbe/n
On 6/17/21 2:00 PM, Jiawen Wu wrote:
> Initialize device with the simplest transmit functions.
>
> Signed-off-by: Jiawen Wu
The patch cannot be tested before device start up.
So, it should go after corresponding patches.
[snip]
> +uint16_t
> +ngbe_xmit_pkts_simple(void *tx_queue, struct rte_mb
On 6/17/21 2:00 PM, Jiawen Wu wrote:
> Setup MSI-X interrupt, complete PHY configuration and set device link
> speed to start device. Disable interrupt, stop hardware and clear queues
> to stop device.
>
> Signed-off-by: Jiawen Wu
[snip]
> diff --git a/drivers/net/ngbe/ngbe_ethdev.c b/drivers/n
On 6/17/21 2:00 PM, Jiawen Wu wrote:
> Initializes transmit unit, support to start and stop transmit unit for
> specified queues.
>
> Signed-off-by: Jiawen Wu
[snip]
> diff --git a/drivers/net/ngbe/ngbe_rxtx.c b/drivers/net/ngbe/ngbe_rxtx.c
> index d4680afaae..b05cb0ec34 100644
> --- a/drivers/
1 - 100 of 129 matches
Mail list logo
