Re: [dpdk-dev] [PATCH v5 1/5] eventdev/rx_adapter: add event buffer size configurability

2021-10-05 Thread Jayatheerthan, Jay
> -Original Message- > From: Naga Harish K, S V > Sent: Monday, October 4, 2021 11:11 AM > To: jer...@marvell.com; Jayatheerthan, Jay > Cc: dev@dpdk.org; Kundapura, Ganapati > Subject: [PATCH v5 1/5] eventdev/rx_adapter: add event buffer size > configurability > > Currently event buffe

Re: [dpdk-dev] [PATCH v3 1/5] ethdev: add API to negotiate delivery of Rx meta data

2021-10-05 Thread Andrew Rybchenko
On 10/5/21 9:30 AM, Ori Kam wrote: > Hi Andrew, > >> -Original Message- >> From: Andrew Rybchenko >> Sent: Monday, October 4, 2021 4:53 PM >> Subject: Re: [PATCH v3 1/5] ethdev: add API to negotiate delivery of Rx meta >> data >> >> On 10/4/21 2:39 PM, Ivan Malov wrote: >>> On 04/10/2021 0

Re: [dpdk-dev] [PATCH v4 4/5] mbuf: make rte_mbuf_tx_offload as stable

2021-10-05 Thread Olivier Matz
On Mon, Oct 04, 2021 at 12:33:01PM -0700, Stephen Hemminger wrote: > This function should be made stable now. > > Cc: konstantin.anan...@intel.com > Signed-off-by: Stephen Hemminger > Acked-by: Andrew Rybchenko Acked-by: Olivier Matz

Re: [dpdk-dev] [PATCH v4 5/5] mbuf: mark rte_mbuf_to_priv as stable

2021-10-05 Thread Olivier Matz
On Mon, Oct 04, 2021 at 12:33:02PM -0700, Stephen Hemminger wrote: > This inline function was added in 18.08 > > Signed-off-by: Stephen Hemminger > --- > lib/mbuf/rte_mbuf.h | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/lib/mbuf/rte_mbuf.h b/lib/mbuf/rte_mbuf.h > index 6913b6d6f3ff..a

Re: [dpdk-dev] [PATCH] mbuf: promote some helpers to stable

2021-10-05 Thread Olivier Matz
On Mon, Oct 04, 2021 at 12:29:42PM -0700, Stephen Hemminger wrote: > On Sat, 2 Oct 2021 16:16:14 +0200 > David Marchand wrote: > > > Those accessors have been introduced more than two years ago > > (rte_mbuf_to_priv in v18.05, rte_mbuf_*_addr* in v19.02). > > Time to mark them stable. > > > > r

Re: [dpdk-dev] [PATCH] mbuf: promote some helpers to stable

2021-10-05 Thread Andrew Rybchenko
On 10/5/21 10:33 AM, Olivier Matz wrote: > On Mon, Oct 04, 2021 at 12:29:42PM -0700, Stephen Hemminger wrote: >> On Sat, 2 Oct 2021 16:16:14 +0200 >> David Marchand wrote: >> >>> Those accessors have been introduced more than two years ago >>> (rte_mbuf_to_priv in v18.05, rte_mbuf_*_addr* in v19.

Re: [dpdk-dev] [PATCH v5 2/5] test/event: add unit test for Rx adapter

2021-10-05 Thread Jayatheerthan, Jay
> -Original Message- > From: Naga Harish K, S V > Sent: Monday, October 4, 2021 11:11 AM > To: jer...@marvell.com; Jayatheerthan, Jay > Cc: dev@dpdk.org > Subject: [PATCH v5 2/5] test/event: add unit test for Rx adapter > > this patch adds unit test for rte_event_eth_rx_adapter_create_wi

Re: [dpdk-dev] [PATCH v5 3/5] eventdev/rx_adapter: introduce per queue event buffer

2021-10-05 Thread Jayatheerthan, Jay
> -Original Message- > From: Naga Harish K, S V > Sent: Monday, October 4, 2021 11:11 AM > To: jer...@marvell.com; Jayatheerthan, Jay > Cc: dev@dpdk.org > Subject: [PATCH v5 3/5] eventdev/rx_adapter: introduce per queue event buffer > > To configure per queue event buffer size, applicati

[dpdk-dev] [PATCH v1] doc: update machine meson option in prog guide

2021-10-05 Thread Juraj Linkeš
Update the docs to reflect the two new variables, cpu_instruction_set for non-arm builds and platform for arm builds. Fixes: bf66003b51ec ("build: use platform for generic and native builds") Signed-off-by: Juraj Linkeš --- doc/guides/prog_guide/build-sdk-meson.rst | 14 +++--- 1 file c

[dpdk-dev] [PATCH] common/cnxk: support BPHY telemetry

2021-10-05 Thread Tomasz Duszynski
Add initial support for baseband telemetry. Signed-off-by: Tomasz Duszynski --- drivers/common/cnxk/cnxk_telemetry_bphy.c | 43 +++ drivers/common/cnxk/meson.build | 7 +++- drivers/raw/cnxk_bphy/cnxk_bphy.c | 11 ++ drivers/raw/cnxk_bphy/cnxk_bphy_irq.

Re: [dpdk-dev] [PATCH v5 4/5] eventdev/rx_adapter: implement per queue event buffer

2021-10-05 Thread Jayatheerthan, Jay
> -Original Message- > From: Naga Harish K, S V > Sent: Monday, October 4, 2021 11:11 AM > To: jer...@marvell.com; Jayatheerthan, Jay > Cc: dev@dpdk.org > Subject: [PATCH v5 4/5] eventdev/rx_adapter: implement per queue event buffer > > this patch implement the per queue event buffer wit

Re: [dpdk-dev] [PATCH v5 5/5] test/event: add unit test for Rx adapter

2021-10-05 Thread Jayatheerthan, Jay
Acked-by: Jay Jayatheerthan > -Original Message- > From: Naga Harish K, S V > Sent: Monday, October 4, 2021 11:11 AM > To: jer...@marvell.com; Jayatheerthan, Jay > Cc: dev@dpdk.org > Subject: [PATCH v5 5/5] test/event: add unit test for Rx adapter > > this patch adds unit tests for che

[dpdk-dev] [Bug 823] [asan] ipc: buffer overflow when running test-null.sh

2021-10-05 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=823 Bug ID: 823 Summary: [asan] ipc: buffer overflow when running test-null.sh Product: DPDK Version: unspecified Hardware: All OS: All Status: UNCONFIRMED Severity: n

Re: [dpdk-dev] [EXT] [PATCH v1 0/2] fips validation app fixes

2021-10-05 Thread Akhil Goyal
> Included are patches with small fixes for unnecessary memory allocation, > and incomplete resetting of a pointer. > > Ciara Power (2): > examples/fips_validation: fix unused malloc > examples/fips_validation: fix resetting pointer > > examples/fips_validation/main.c | 5 +++-- > 1 file cha

Re: [dpdk-dev] [PATCH v4 4/5] mbuf: make rte_mbuf_tx_offload as stable

2021-10-05 Thread Ananyev, Konstantin
> On Mon, Oct 04, 2021 at 12:33:01PM -0700, Stephen Hemminger wrote: > > This function should be made stable now. > > > > Cc: konstantin.anan...@intel.com > > Signed-off-by: Stephen Hemminger > > Acked-by: Andrew Rybchenko > > Acked-by: Olivier Matz Acked-by: Konstantin Ananyev

Re: [dpdk-dev] [PATCH v4] eventdev/rx-adapter: fix segfault in queue conf get

2021-10-05 Thread Jayatheerthan, Jay
> -Original Message- > From: Kundapura, Ganapati > Sent: Monday, October 4, 2021 11:55 PM > To: Jayatheerthan, Jay ; jerinjac...@gmail.com; > dev@dpdk.org > Subject: RE: [PATCH v4] eventdev/rx-adapter: fix segfault in queue conf get > > Hi Jay, > > > -Original Message- > > From:

Re: [dpdk-dev] [PATCH] crypto/octeontx2: update min headroom and tailroom

2021-10-05 Thread Akhil Goyal
> > The driver consume 208B of tailroom but has min requirement as 8B and > > headroom needed is 48B, but minimum requirement is set as 24B. This > patch > > correct minimum requirements which application should honour. > > > > Signed-off-by: Akhil Goyal > > Acked-by: Anoob Joseph Applied to dp

Re: [dpdk-dev] [PATCH v2] lib/ring: remove experimental tag from functions

2021-10-05 Thread David Marchand
On Mon, Oct 4, 2021 at 11:22 AM Sean Morrissey wrote: > > These methods were introduced in 20.05. > There has been no changes in their public API since then. > They seem mature enough to remove the experimental tag. > > Signed-off-by: Sean Morrissey > Acked-by: Konstantin Ananyev For future pat

Re: [dpdk-dev] [PATCH] mbuf: promote some helpers to stable

2021-10-05 Thread David Marchand
On Tue, Oct 5, 2021 at 9:34 AM Andrew Rybchenko wrote: > > On 10/5/21 10:33 AM, Olivier Matz wrote: > > On Mon, Oct 04, 2021 at 12:29:42PM -0700, Stephen Hemminger wrote: > >> On Sat, 2 Oct 2021 16:16:14 +0200 > >> David Marchand wrote: > >> > >>> Those accessors have been introduced more than t

Re: [dpdk-dev] [PATCH v4 0/5] mbuf: promote experimental API's to stable

2021-10-05 Thread David Marchand
On Mon, Oct 4, 2021 at 9:33 PM Stephen Hemminger wrote: > > These are all functions that have been around since at least 19.05 > > v4 - fix the tx_offload patch > add the mbuf_to_priv patch > > Stephen Hemminger (5): > mbuf: make rte_pktmbuf_free_bulk and rte_pktmbuf_copy stable API's > m

Re: [dpdk-dev] [PATCH v23 1/6] dmadev: introduce DMA device library

2021-10-05 Thread Kevin Laatz
On 04/10/2021 22:12, Radha Mohan wrote: On Fri, Sep 24, 2021 at 3:58 AM Chengwen Feng wrote: The 'dmadevice' is a generic type of DMA device. This patch introduce the 'dmadevice' device allocation APIs. The infrastructure is prepared to welcome drivers in drivers/dma/ Signed-off-by: Chengwen

Re: [dpdk-dev] [PATCH v3 2/2] cmdline: make struct rdline opaque

2021-10-05 Thread Olivier Matz
Hi Dmitry, Few comments below. On Tue, Oct 05, 2021 at 03:55:16AM +0300, Dmitry Kozlyuk wrote: > Hide struct rdline definition and some RDLINE_* constants in order > to be able to change internal buffer sizes transparently to the user. > Add new functions: > > * rdline_create(): allocate and ini

Re: [dpdk-dev] [PATCH] examples/ipsec-secgw: use mbuf packet type in ev worker

2021-10-05 Thread Akhil Goyal
> > packet is parsed already by HW before and HW/PMD updates > > necessary info in mbuf packet type of the found protocols. > > > > This change is specifically for event mode. > > > > Signed-off-by: Nithin Dabilpuram > > --- > Acked-by: Akhil Goyal Applied to dpdk-next-crypto

Re: [dpdk-dev] [PATCH v3 1/5] ethdev: add API to negotiate delivery of Rx meta data

2021-10-05 Thread Andrew Rybchenko
Hi Ori, On 10/5/21 11:17 AM, Ori Kam wrote: > Hi Andrew, > >> -Original Message- >> From: Andrew Rybchenko >> Sent: Tuesday, October 5, 2021 10:27 AM >> Subject: Re: [PATCH v3 1/5] ethdev: add API to negotiate delivery of Rx meta >> data >> >> On 10/5/21 9:30 AM, Ori Kam wrote: >>> Hi An

[dpdk-dev] [dpdk-announce] DPDK Slack workspace is active

2021-10-05 Thread Ferruh Yigit
Hi All, DPDK has a Slack workspace now as an alternative to the IRC channel. You can join to the Slack workspace using following link: https://join.slack.com/t/dpdkproject/shared_invite/zt-v6c9ef5z-FqgOAS7BDAYqev_a~pbXdw This is also documented in the DPDK website: https://core.dpdk.org/contrib

Re: [dpdk-dev] [PATCH v3 2/2] cmdline: make struct rdline opaque

2021-10-05 Thread Dmitry Kozlyuk
Hi Olivier, Thanks for the review, please see below. 2021-10-05 10:27 (UTC+0200), Olivier Matz: > [...] > > diff --git a/lib/cmdline/cmdline_cirbuf.c b/lib/cmdline/cmdline_cirbuf.c > > index 829a8af563..cbb76a7016 100644 > > --- a/lib/cmdline/cmdline_cirbuf.c > > +++ b/lib/cmdline/cmdline_cirbuf.

Re: [dpdk-dev] [PATCH v3 2/2] cmdline: make struct rdline opaque

2021-10-05 Thread Olivier Matz
On Tue, Oct 05, 2021 at 12:03:01PM +0300, Dmitry Kozlyuk wrote: > Hi Olivier, > > Thanks for the review, please see below. > > 2021-10-05 10:27 (UTC+0200), Olivier Matz: > > [...] > > > diff --git a/lib/cmdline/cmdline_cirbuf.c b/lib/cmdline/cmdline_cirbuf.c > > > index 829a8af563..cbb76a7016 100

[dpdk-dev] [PATCH] sort symbols map

2021-10-05 Thread David Marchand
Fixed with ./devtools/update-abi.sh $(cat ABI_VERSION) Fixes: e73a7ab22422 ("net/softnic: promote manage API") Fixes: 8f532a34c4f2 ("fib: promote API to stable") Fixes: 4aeb92396b85 ("rib: promote API to stable") Signed-off-by: David Marchand --- I added "./devtools/update-abi.sh $(cat ABI_VERSI

Re: [dpdk-dev] [PATCH v1 02/12] ethdev: add eswitch port item to flow API

2021-10-05 Thread Andrew Rybchenko
Hi Ori, On 10/5/21 9:20 AM, Ori Kam wrote: > Hi Ivan, > >> -Original Message- >> From: Ivan Malov >> Cc: dev@dpdk.org >> Subject: Re: [PATCH v1 02/12] ethdev: add eswitch port item to flow API >> >> Hi Ori, >> >> On 04/10/2021 14:37, Ori Kam wrote: >>> Hi Ivan, >>> -Original Mes

Re: [dpdk-dev] [EXT] Re: [PATCH v3 1/5] net/enetfec: introduce NXP ENETFEC driver

2021-10-05 Thread Ferruh Yigit
On 10/5/2021 6:24 AM, Apeksha Gupta wrote: -Original Message- From: Ferruh Yigit Sent: Friday, October 1, 2021 8:15 PM To: Apeksha Gupta ; david.march...@redhat.com; andrew.rybche...@oktetlabs.ru Cc: dev@dpdk.org; Sachin Saxena ; Hemant Agrawal Subject: Re: [EXT] Re: [dpdk-dev] [PATC

Re: [dpdk-dev] [PATCH v7 0/3] net/i40e: remove i40evf

2021-10-05 Thread Thomas Monjalon
> > Robin Zhang (3): > > net/i40e: remove i40evf > > net/iavf: remove i40evf devargs option > > doc: remove i40evf related documentation > > Acked-by: Qi Zhang > > Applied to dpdk-next-inet-intel. The split of the patch is not logical. "net/iavf: remove i40evf devargs option" should be fi

Re: [dpdk-dev] [PATCH v4 4/7] ethdev: make burst functions to use new flat array

2021-10-05 Thread David Marchand
On Mon, Oct 4, 2021 at 3:59 PM Konstantin Ananyev wrote: > > Rework 'fast' burst functions to use rte_eth_fp_ops[]. > While it is an API/ABI breakage, this change is intended to be > transparent for both users (no changes in user app is required) and > PMD developers (no changes in PMD is required

Re: [dpdk-dev] [PATCH v3 1/5] ethdev: add API to negotiate delivery of Rx meta data

2021-10-05 Thread Andrew Rybchenko
Hi Ori, On 10/5/21 12:41 PM, Ori Kam wrote: > Hi Andrew, > >> -Original Message- >> From: Andrew Rybchenko >> Sent: Tuesday, October 5, 2021 11:39 AM >> Subject: Re: [PATCH v3 1/5] ethdev: add API to negotiate delivery of Rx meta >> data >> >> Hi Ori, >> >> On 10/5/21 11:17 AM, Ori Kam w

Re: [dpdk-dev] [PATCH v4 7/7] ethdev: hide eth dev related structures

2021-10-05 Thread David Marchand
On Mon, Oct 4, 2021 at 3:59 PM Konstantin Ananyev wrote: > > Move rte_eth_dev, rte_eth_dev_data, rte_eth_rxtx_callback and related > data into private header (ethdev_driver.h). > Few minor changes to keep DPDK building after that. This change is going to hurt a lot of people :-). But this is a ne

Re: [dpdk-dev] [PATCH v3 6/6] bbdev: reduce warning level for one scenario

2021-10-05 Thread Akhil Goyal
> Can this serie below be applied now? > Thanks and regards, > Nic Series Applied to dpd-next-crypto Thanks.

Re: [dpdk-dev] [PATCH v1] baseband/acc100: fix 4GUL outbound size when CRC is dropped

2021-10-05 Thread Akhil Goyal
> Hi Akhil, > Can this be applied? The patch did not apply cleanly. It is rebased and Applied to dpdk-next-crypto. Please check. Thanks.

Re: [dpdk-dev] [PATCH v4 4/7] ethdev: make burst functions to use new flat array

2021-10-05 Thread Ananyev, Konstantin
> > > > Rework 'fast' burst functions to use rte_eth_fp_ops[]. > > While it is an API/ABI breakage, this change is intended to be > > transparent for both users (no changes in user app is required) and > > PMD developers (no changes in PMD is required). > > One extra thing to note - RX/TX callbac

Re: [dpdk-dev] [PATCH v1 02/12] ethdev: add eswitch port item to flow API

2021-10-05 Thread Ori Kam
Hi Ivan, > -Original Message- > From: Ivan Malov > Cc: dev@dpdk.org > Subject: Re: [PATCH v1 02/12] ethdev: add eswitch port item to flow API > > Hi Ori, > > On 04/10/2021 14:37, Ori Kam wrote: > > Hi Ivan, > > > >> -Original Message- > >> From: Ivan Malov > >> Sent: Monday, Oc

Re: [dpdk-dev] [PATCH v3 1/5] ethdev: add API to negotiate delivery of Rx meta data

2021-10-05 Thread Ori Kam
Hi Andrew, > -Original Message- > From: Andrew Rybchenko > Sent: Monday, October 4, 2021 4:53 PM > Subject: Re: [PATCH v3 1/5] ethdev: add API to negotiate delivery of Rx meta > data > > On 10/4/21 2:39 PM, Ivan Malov wrote: > > On 04/10/2021 09:56, Ori Kam wrote: > >>> On 04/10/2021 00:0

Re: [dpdk-dev] [EXT] [PATCH] cryptodev: build on Windows

2021-10-05 Thread Akhil Goyal
> Build the cryptography device library on Windows OS > by removing unneeded include and exports blocking the > compilation. > > Signed-off-by: Tal Shnaiderman > --- Acked-by: Akhil Goyal Applied to dpdk-next-crypto Thanks.

Re: [dpdk-dev] [PATCH v4 7/7] ethdev: hide eth dev related structures

2021-10-05 Thread Ferruh Yigit
On 10/5/2021 11:04 AM, David Marchand wrote: On Mon, Oct 4, 2021 at 3:59 PM Konstantin Ananyev wrote: Move rte_eth_dev, rte_eth_dev_data, rte_eth_rxtx_callback and related data into private header (ethdev_driver.h). Few minor changes to keep DPDK building after that. This change is going to

Re: [dpdk-dev] [EXT] [PATCH] cryptodev: build on Windows

2021-10-05 Thread Akhil Goyal
> > Build the cryptography device library on Windows OS > > by removing unneeded include and exports blocking the > > compilation. > > > > Signed-off-by: Tal Shnaiderman > > --- > Acked-by: Akhil Goyal > > Applied to dpdk-next-crypto Removing this patch from dpdk-next-crypto as the patch is supe

Re: [dpdk-dev] [EXT] [PATCH v3 1/4] security: use the net library for IP structs

2021-10-05 Thread Akhil Goyal
> From: Tal Shnaiderman > > Remove the netinet includes and replaces them > with rte_ip.h to support the in_addr/in6_addr structs > on all operating systems. > > Signed-off-by: Tal Shnaiderman > Acked-by: William Tu Acked-by: Akhil Goyal

Re: [dpdk-dev] [EXT] [PATCH v3 2/4] security: build on Windows

2021-10-05 Thread Akhil Goyal
> From: Tal Shnaiderman > > Build the security library on Windows. > > Remove unneeded export from version file. > > Signed-off-by: Tal Shnaiderman > Acked-by: William Tu Acked-by: Akhil Goyal

Re: [dpdk-dev] [EXT] [PATCH v3 3/4] cryptodev: build on Windows

2021-10-05 Thread Akhil Goyal
> From: Tal Shnaiderman > > Build the cryptography device library on Windows OS > by removing unneeded include and exports blocking the > compilation. > > Signed-off-by: Tal Shnaiderman > Acked-by: William Tu Acked-by: Akhil Goyal

[dpdk-dev] [PATCH] net/ice/base: added union to avoid ptr dereference

2021-10-05 Thread Aman Singh
Code changes done to avoid build issue as seen in Bug 817 - net/ice build failure with gcc 4.8.5 error: dereferencing type-punned pointer will break strict-aliasing rules. Signed-off-by: Aman Singh --- drivers/net/ice/base/ice_parser_rt.c | 36 +++- 1 file changed, 20 ins

Re: [dpdk-dev] [PATCH v3 1/5] ethdev: add API to negotiate delivery of Rx meta data

2021-10-05 Thread Andrew Rybchenko
Hi Ori, On 10/5/21 1:10 PM, Ori Kam wrote: > Hi Andrew, > >> -Original Message- >> From: Andrew Rybchenko >> Sent: Tuesday, October 5, 2021 1:02 PM >> Subject: Re: [PATCH v3 1/5] ethdev: add API to negotiate delivery of Rx meta >> data >> >> Hi Ori, >> >> On 10/5/21 12:41 PM, Ori Kam wro

Re: [dpdk-dev] [PATCH v4 7/7] ethdev: hide eth dev related structures

2021-10-05 Thread David Marchand
On Tue, Oct 5, 2021 at 12:43 PM Ferruh Yigit wrote: > > This change is going to hurt a lot of people :-). > > But this is a necessary move. > > > > +1 that it is necessary move, but I am surprised to see how much > 'rte_eth_devices' > is accessed directly. > > Do you have any idea/suggestion on h

Re: [dpdk-dev] [PATCH v3] telemetry: fix "in-memory" process socket conflicts

2021-10-05 Thread Ferruh Yigit
On 9/29/2021 2:54 PM, Bruce Richardson wrote: When DPDK is run with --in-memory mode, multiple processes can run simultaneously using the same runtime dir. This leads to each process, as it starts up, removing the telemetry socket of another process, giving unexpected behaviour. This patch chang

Re: [dpdk-dev] [PATCH v2 3/3] ci: run unit tests with ASAN

2021-10-05 Thread Aaron Conole
David Marchand writes: > Enable ASAN for clang jobs. > This can greatly help identify leaks and buffer overflows. > This patch is more a fyi, as some unit tests stil have issues. > > Signed-off-by: David Marchand > --- I know this isn't yet ready to be merged due to failing unit tests, and I st

[dpdk-dev] [PATCH] net/ice/base: fix build error for GCC 4.8.5

2021-10-05 Thread Aman Singh
Code changes done for build issue as reported in Bug 817 error: dereferencing type-punned pointer will break strict-aliasing rules. added union to avoid pointer dereferencing Fixes: 39925373a333 ("net/ice/base: add parser execution main loop") Cc: sta...@dpdk.org Signed-off-by: Aman Singh --- d

Re: [dpdk-dev] [PATCH v4 1/7] ethdev: allocate max space for internal queue array

2021-10-05 Thread Thomas Monjalon
04/10/2021 15:55, Konstantin Ananyev: > At queue configure stage always allocate space for maximum possible > number (RTE_MAX_QUEUES_PER_PORT) of queue pointers. > That will allow 'fast' inline functions (eth_rx_burst, etc.) to refer > pointer to internal queue data without extra checking of curren

Re: [dpdk-dev] [PATCH v1 02/12] ethdev: add eswitch port item to flow API

2021-10-05 Thread Ivan Malov
Hi Ori, Andrew, On 05/10/2021 12:19, Andrew Rybchenko wrote: Hi Ori, On 10/5/21 9:20 AM, Ori Kam wrote: Hi Ivan, -Original Message- From: Ivan Malov Cc: dev@dpdk.org Subject: Re: [PATCH v1 02/12] ethdev: add eswitch port item to flow API Hi Ori, On 04/10/2021 14:37, Ori Kam wrote:

[dpdk-dev] [PATCH v2 0/6] make rte_intr_handle internal

2021-10-05 Thread Harman Kalra
Moving struct rte_intr_handle as an internal structure to avoid any ABI breakages in future. Since this structure defines some static arrays and changing respective macros breaks the ABI. Eg: Currently RTE_MAX_RXTX_INTR_VEC_ID imposes a limit of maximum 512 MSI-X interrupts that can be defined for

[dpdk-dev] [PATCH v2 1/6] eal/interrupts: implement get set APIs

2021-10-05 Thread Harman Kalra
Prototype/Implement get set APIs for interrupt handle fields. User wont be able to access any of the interrupt handle fields directly while should use these get/set APIs to access/manipulate them. Internal interrupt header i.e. rte_eal_interrupt.h is rearranged, as APIs defined are moved to rte_in

[dpdk-dev] [PATCH v2 3/6] test/interrupt: apply get set interrupt handle APIs

2021-10-05 Thread Harman Kalra
Updating the interrupt testsuite to make use of interrupt handle get set APIs. Signed-off-by: Harman Kalra --- app/test/test_interrupts.c | 163 ++--- 1 file changed, 98 insertions(+), 65 deletions(-) diff --git a/app/test/test_interrupts.c b/app/test/test_interr

[dpdk-dev] [PATCH v2 5/6] eal/interrupts: make interrupt handle structure opaque

2021-10-05 Thread Harman Kalra
Moving interrupt handle structure definition inside the c file to make its fields totally opaque to the outside world. Dynamically allocating the efds and elist array os intr_handle structure, based on size provided by user. Eg size can be MSIX interrupts supported by a PCI device. Signed-off-by:

[dpdk-dev] [PATCH v2 6/6] eal/alarm: introduce alarm fini routine

2021-10-05 Thread Harman Kalra
Implementing alarm cleanup routine, where the memory allocated for interrupt instance can be freed. Signed-off-by: Harman Kalra --- lib/eal/common/eal_private.h | 11 +++ lib/eal/freebsd/eal.c| 1 + lib/eal/freebsd/eal_alarm.c | 7 +++ lib/eal/linux/eal.c | 1 +

[dpdk-dev] [PATCH v2 2/6] eal/interrupts: avoid direct access to interrupt handle

2021-10-05 Thread Harman Kalra
Making changes to the interrupt framework to use interrupt handle APIs to get/set any field. Direct access to any of the fields should be avoided to avoid any ABI breakage in future. Signed-off-by: Harman Kalra --- lib/eal/freebsd/eal_interrupts.c | 111 lib/eal/include/rte_interrup

Re: [dpdk-dev] [PATCH v3 1/5] ethdev: add API to negotiate delivery of Rx meta data

2021-10-05 Thread Ori Kam
Hi Andrew, > -Original Message- > From: Andrew Rybchenko > Sent: Tuesday, October 5, 2021 10:27 AM > Subject: Re: [PATCH v3 1/5] ethdev: add API to negotiate delivery of Rx meta > data > > On 10/5/21 9:30 AM, Ori Kam wrote: > > Hi Andrew, > > > >> -Original Message- > >> From: An

Re: [dpdk-dev] [PATCH v4 1/7] ethdev: allocate max space for internal queue array

2021-10-05 Thread Thomas Monjalon
04/10/2021 15:55, Konstantin Ananyev: > At queue configure stage always allocate space for maximum possible > number (RTE_MAX_QUEUES_PER_PORT) of queue pointers. The problem with this max is that it cannot be changed dynamically. That could be another patch, but I would like to see this number a d

Re: [dpdk-dev] [PATCH] ethdev: let apps find transfer admin port for a given ethdev

2021-10-05 Thread Ivan Malov
Hi Ori, Thanks a lot for eagerly reviewing this and related patches. That's very helpful of yours. On 05/10/2021 12:22, Ori Kam wrote: Hi Ivan, -Original Message- From: Ivan Malov Sent: Tuesday, October 5, 2021 3:36 AM Subject: [PATCH] ethdev: let apps find transfer admin port for

Re: [dpdk-dev] [PATCH v4 1/5] ethdev: negotiate delivery of packet metadata from HW to PMD

2021-10-05 Thread Ivan Malov
Hi Ori, On 05/10/2021 15:03, Ori Kam wrote: Hi Ivan, Just a nit below. -Original Message- From: Ivan Malov Sent: Tuesday, October 5, 2021 2:50 AM Subject: [PATCH v4 1/5] ethdev: negotiate delivery of packet metadata from HW to PMD Provide an API to let the application control the NI

[dpdk-dev] [RFC PATCH] ethdev: support priority based flow control

2021-10-05 Thread jerinj
From: Jerin Jacob rte_eth_dev_priority_flow_ctrl_set() based API is not generic as it can not support other than VLAN priority mapping to PFC traffic class. Introducing RTE_FLOW_ACTION_TYPE_PFC_SET_TC rte_flow action to set the traffic class as per 802.1Qbb specification. This will enable, Traff

[dpdk-dev] [PATCH] net: fix IPv4 change announce

2021-10-05 Thread Gregory Etelson
IPv4 header encodes fragment information into 16 bits field. 3 bits hold flags and remaining 13 bits are for fragment offset. 13 bits bit-field cannot be defined both for big and little endian systems. The patch removes IPv4 fragments union announce. Signed-off-by: Gregory Etelson --- doc/guide

[dpdk-dev] Should we keep autotest.py ?

2021-10-05 Thread David Marchand
Looking at how to add an autotest, I came upon autotest_data.py used by autotest.py which has been in DPDK for a long time. >From what I see, DTS directly calls the test binary. The public CI relies on meson to invoke unit tests. Is the autotest.py script still used in some CI or can we remove it

Re: [dpdk-dev] [PATCH v4 3/7] ethdev: copy ethdev 'fast' API into separate structure

2021-10-05 Thread Thomas Monjalon
04/10/2021 15:55, Konstantin Ananyev: > Copy public function pointers (rx_pkt_burst(), etc.) and related > pointers to internal data from rte_eth_dev structure into a > separate flat array. That array will remain in a public header. > The intention here is to make rte_eth_dev and related structures

Re: [dpdk-dev] [EXT] [PATCH V3] compress/mlx5: allow partial transformations support

2021-10-05 Thread Akhil Goyal
> Currently compress, decompress and dma are allowed only when all 3 > capabilities are on. > A case where the user wants decompress offload, if decompress capability > is on but one of compress, dma is off, is not allowed. > Split compress/decompress/dma support check to allow partial > transforma

Re: [dpdk-dev] [PATCH v4 5/7] ethdev: add API to retrieve multiple ethernet addresses

2021-10-05 Thread Thomas Monjalon
04/10/2021 15:56, Konstantin Ananyev: > Introduce rte_eth_macaddrs_get() to allow user to retrieve all ethernet > addresses assigned to given port. We already have functions to get MAC addresses. Please explain the difference. [...] > +* **Add new function into ethdev lib.** > + > + * Added ``rt

Re: [dpdk-dev] [PATCH v4 6/7] ethdev: remove legacy Rx descriptor done API

2021-10-05 Thread Thomas Monjalon
04/10/2021 15:56, Konstantin Ananyev: > rte_eth_rx_descriptor_status() should be used as a replacement. > > Signed-off-by: Andrew Rybchenko > Reviewed-by: Ferruh Yigit > Acked-by: Konstantin Ananyev It should be the first patch, or even a standalone patch to apply quickly.

Re: [dpdk-dev] [PATCH v4 1/5] ethdev: negotiate delivery of packet metadata from HW to PMD

2021-10-05 Thread Andrew Rybchenko
On 10/5/21 3:50 PM, Ivan Malov wrote: > Hi Ori, > > On 05/10/2021 15:03, Ori Kam wrote: >> Hi Ivan, >> >> Just a nit below. >> >>> -Original Message- >>> From: Ivan Malov >>> Sent: Tuesday, October 5, 2021 2:50 AM >>> Subject: [PATCH v4 1/5] ethdev: negotiate delivery of packet metadata >

Re: [dpdk-dev] [PATCH] ethdev: let apps find transfer admin port for a given ethdev

2021-10-05 Thread Ori Kam
Hi Ivan, > -Original Message- > From: Ivan Malov > Sent: Tuesday, October 5, 2021 3:36 AM > Subject: [PATCH] ethdev: let apps find transfer admin port for a given ethdev > > Introduce a helper API to let applications find transfer admin port for a > given > ethdev to avoid failures when

Re: [dpdk-dev] [PATCH v4 7/7] ethdev: hide eth dev related structures

2021-10-05 Thread Thomas Monjalon
04/10/2021 15:56, Konstantin Ananyev: > Move rte_eth_dev, rte_eth_dev_data, rte_eth_rxtx_callback and related > data into private header (ethdev_driver.h). [...] > +/** > + * @internal > + * Structure used to hold information about the callbacks to be called for a > + * queue on RX and TX. > + */ >

Re: [dpdk-dev] [PATCH v3 1/5] ethdev: add API to negotiate delivery of Rx meta data

2021-10-05 Thread Ori Kam
Hi Andrew, > -Original Message- > From: Andrew Rybchenko > Sent: Tuesday, October 5, 2021 11:39 AM > Subject: Re: [PATCH v3 1/5] ethdev: add API to negotiate delivery of Rx meta > data > > Hi Ori, > > On 10/5/21 11:17 AM, Ori Kam wrote: > > Hi Andrew, > > > >> -Original Message-

Re: [dpdk-dev] [EXT] [PATCH] app/test: enable crypto unit tests on Windows

2021-10-05 Thread Akhil Goyal
> Enable cryptography unit tests on Windows supported crypto PMDs. > > Signed-off-by: Tal Shnaiderman > --- > Depends-on: series-18674 ("app/test: enable subset of tests on Windows") > Depends-on: patch-98942 ("security: build on Windows") > --- Acked-by: Akhil Goyal Delegating this patch to Th

Re: [dpdk-dev] [PATCH] net/ice/base: fix build error for GCC 4.8.5

2021-10-05 Thread David Marchand
On Tue, Oct 5, 2021 at 2:07 PM Aman Singh wrote: > > Code changes done for build issue as reported in Bug 817 > error: dereferencing type-punned pointer will break strict-aliasing rules. > added union to avoid pointer dereferencing > About the title, Ali reproduced the issue with other versions o

Re: [dpdk-dev] [PATCH 3/3] test/devargs: add devargs test cases

2021-10-05 Thread David Marchand
On Tue, Oct 5, 2021 at 2:31 PM Xueming Li wrote: > diff --git a/app/test/meson.build b/app/test/meson.build > index f144d8b8ed6..c688ba2b70a 100644 > --- a/app/test/meson.build > +++ b/app/test/meson.build > @@ -42,6 +42,7 @@ test_sources = files( > 'test_cryptodev_security_pdcp.c', >

Re: [dpdk-dev] [PATCH v3 1/5] ethdev: add API to negotiate delivery of Rx meta data

2021-10-05 Thread Ori Kam
Hi Andrew, > -Original Message- > From: Andrew Rybchenko > Sent: Tuesday, October 5, 2021 1:02 PM > Subject: Re: [PATCH v3 1/5] ethdev: add API to negotiate delivery of Rx meta > data > > Hi Ori, > > On 10/5/21 12:41 PM, Ori Kam wrote: > > Hi Andrew, > > > >> -Original Message-

Re: [dpdk-dev] [PATCH] common/cnxk: support 98XX CPT dual block

2021-10-05 Thread Akhil Goyal
> CN98xx SoC comes up with two CPT blocks wrt > CN96xx, CN93xx, to achieve higher performance. > > Adding support to allocate all LFs of VF with even BDF from CPT0 > and all LFs of VF with odd BDF from CPT1. > If LFs are not available in one block then they will be allocated > from alternate block

Re: [dpdk-dev] [PATCH v23 2/6] dmadev: add control plane function support

2021-10-05 Thread Matan Azrad
Hi Chengwen API looks good to me, thanks! I have some questions below. > This patch add control plane functions for dmadev. > > +/** > + * DMA transfer direction defines. > + * > + * @see struct rte_dma_vchan_conf::direction */ enum rte_dma_direction > +{ > + /** DMA transfer direction

Re: [dpdk-dev] [PATCH] sort symbols map

2021-10-05 Thread Kinsella, Ray
On 05/10/2021 10:16, David Marchand wrote: > Fixed with ./devtools/update-abi.sh $(cat ABI_VERSION) > > Fixes: e73a7ab22422 ("net/softnic: promote manage API") > Fixes: 8f532a34c4f2 ("fib: promote API to stable") > Fixes: 4aeb92396b85 ("rib: promote API to stable") > > Signed-off-by: David Mar

[dpdk-dev] [PATCH v6 0/5] improve telemetry support with in-memory mode

2021-10-05 Thread Bruce Richardson
This patchset cleans up telemetry support for "in-memory" mode, so that multiple independent processes can be run using that mode and still have telemetry support. It also removes problems of one process removing the socket of another - which was the original issue reported. The main changes in thi

[dpdk-dev] [PATCH v6 1/5] eal: limit telemetry to primary processes

2021-10-05 Thread Bruce Richardson
Telemetry interface should be exposed for primary processes only, since secondary processes will conflict on socket creation, and since all data in secondary process is generally available to primary. For example, all device stats for ethdevs, cryptodevs, etc. will all be common across processes.

[dpdk-dev] [PATCH v6 2/5] telemetry: fix deletion of active sockets

2021-10-05 Thread Bruce Richardson
When DPDK is run with --in-memory mode, multiple processes can run simultaneously using the same runtime dir. This leads to each process, as it starts up, removing the telemetry socket of another process, giving unexpected behaviour. This patch changes that behaviour to first check if the existing

[dpdk-dev] [PATCH v6 3/5] telemetry: use unique socket paths for in-memory mode

2021-10-05 Thread Bruce Richardson
When DPDK is run using "in-memory" flag, multiple processes can be run using the same file-prefix and hence the same runtime directory. To avoid problems with conflicting telemetry unix socket paths, we can put the pid of the process into the socket name. As with the existing telemetry socket files

[dpdk-dev] [PATCH v6 4/5] usertools/dpdk-telemetry: connect to in-memory processes

2021-10-05 Thread Bruce Richardson
Allow connecting to an in-memory process via "-p " flag, which can be used to identify the in-memory process to which to connect. Signed-off-by: Bruce Richardson --- doc/guides/howto/telemetry.rst | 6 ++ usertools/dpdk-telemetry.py| 7 ++- 2 files changed, 12 insertions(+), 1 deleti

[dpdk-dev] [PATCH v6 5/5] usertools/dpdk-telemetry: provide info on available sockets

2021-10-05 Thread Bruce Richardson
When a user runs the dpdk-telemetry script and fails to connect because the socket path does not exist, run a scan for possible sockets that could be connected to and inform the user of the command needed to connect to those. For example, when running the script without any parameters, but there a

Re: [dpdk-dev] [dpdk-stable] [PATCH] net/ice/base: fix build error for GCC 4.8.5

2021-10-05 Thread Ferruh Yigit
On 10/5/2021 2:57 PM, David Marchand wrote: On Tue, Oct 5, 2021 at 2:07 PM Aman Singh wrote: Code changes done for build issue as reported in Bug 817 error: dereferencing type-punned pointer will break strict-aliasing rules. added union to avoid pointer dereferencing About the title, Ali re

Re: [dpdk-dev] [PATCH] net/ice/base: added union to avoid ptr dereference

2021-10-05 Thread Ferruh Yigit
On 10/5/2021 11:57 AM, Aman Singh wrote: Code changes done to avoid build issue as seen in Bug 817 - net/ice build failure with gcc 4.8.5 error: dereferencing type-punned pointer will break strict-aliasing rules. Signed-off-by: Aman Singh superseded by 'net/ice/base: fix build error for GCC 4

Re: [dpdk-dev] [PATCH] sort symbols map

2021-10-05 Thread David Marchand
On Tue, Oct 5, 2021 at 4:17 PM Kinsella, Ray wrote: > On 05/10/2021 10:16, David Marchand wrote: > > Fixed with ./devtools/update-abi.sh $(cat ABI_VERSION) > > > > Fixes: e73a7ab22422 ("net/softnic: promote manage API") > > Fixes: 8f532a34c4f2 ("fib: promote API to stable") > > Fixes: 4aeb92396b85

[dpdk-dev] [PATCH v6 2/5] test/event: add unit test for Rx adapter

2021-10-05 Thread Naga Harish K S V
this patch adds unit test for rte_event_eth_rx_adapter_create_with_params api and validate all possible input combinations. Signed-off-by: Naga Harish K S V --- app/test/test_event_eth_rx_adapter.c | 53 +--- 1 file changed, 49 insertions(+), 4 deletions(-) diff --git a/

[dpdk-dev] [PATCH v6 3/5] eventdev/rx_adapter: introduce per queue event buffer

2021-10-05 Thread Naga Harish K S V
To configure per queue event buffer size, application sets ``rte_event_eth_rx_adapter_params::use_queue_event_buf`` flag as true and is passed to ``rte_event_eth_rx_adapter_create_with_params`` api. The per queue event buffer size is populated in ``rte_event_eth_rx_adapter_queue_conf::event_buf_s

[dpdk-dev] [PATCH v6 4/5] eventdev/rx_adapter: implement per queue event buffer

2021-10-05 Thread Naga Harish K S V
this patch implement the per queue event buffer with required validations. Signed-off-by: Naga Harish K S V --- lib/eventdev/rte_event_eth_rx_adapter.c | 192 ++-- 1 file changed, 143 insertions(+), 49 deletions(-) diff --git a/lib/eventdev/rte_event_eth_rx_adapter.c b/lib/

[dpdk-dev] [PATCH v6 1/5] eventdev/rx_adapter: add event buffer size configurability

2021-10-05 Thread Naga Harish K S V
Currently event buffer is static array with a default size defined internally. To configure event buffer size from application, ``rte_event_eth_rx_adapter_create_with_params`` api is added which takes ``struct rte_event_eth_rx_adapter_params`` to configure event buffer size in addition other param

[dpdk-dev] [PATCH v6 5/5] test/event: add unit test for Rx adapter

2021-10-05 Thread Naga Harish K S V
this patch adds unit tests for checking per rx queue event buffer feature using rte_event_eth_rx_adapter_queue_add api. Signed-off-by: Naga Harish K S V --- app/test/test_event_eth_rx_adapter.c | 86 1 file changed, 86 insertions(+) diff --git a/app/test/test_event_

Re: [dpdk-dev] [PATCH v6 3/5] telemetry: use unique socket paths for in-memory mode

2021-10-05 Thread Kevin Traynor
Hi Bruce, I started reviewing v5 before v6 was pushed, so these are just comments from v5, On 05/10/2021 14:59, Bruce Richardson wrote: When DPDK is run using "in-memory" flag, multiple processes can be run using the same file-prefix and hence the same runtime directory. To avoid problems with

Re: [dpdk-dev] [PATCH 3/4] ethdev: support PPPoL2TPv2oUDP RSS Hash

2021-10-05 Thread Ferruh Yigit
On 9/30/2021 3:38 PM, Ori Kam wrote: Hi Jie, You are missing updating the rte_flow.rst and release notes: Please see more comments below. Thanks, Ori -Original Message- From: dev On Behalf Of Jie Wang Sent: Friday, September 24, 2021 6:17 PM Subject: [dpdk-dev] [PATCH 3/4] ethdev: s

Re: [dpdk-dev] [PATCH v5 1/5] eventdev/rx_adapter: add event buffer size configurability

2021-10-05 Thread Naga Harish K, S V
Hi Jay, > -Original Message- > From: Jayatheerthan, Jay > Sent: Tuesday, October 5, 2021 12:49 PM > To: Naga Harish K, S V ; jer...@marvell.com > Cc: dev@dpdk.org; Kundapura, Ganapati > Subject: RE: [PATCH v5 1/5] eventdev/rx_adapter: add event buffer size > configurability > > > -O

Re: [dpdk-dev] [EXT] [dpdk-dev v2] app: fix buffer overrun

2021-10-05 Thread Akhil Goyal
> This patch fixes a possible buffer overrun problem in crypto perf test. > Previously when user configured aad size is over 12 bytes the copy of > template aad will cause a buffer overrun. > The problem is fixed by only copy up to 12 bytes of aad template. > > Fixes: 8a5b494a7f99 ("app/test-crypt

Re: [dpdk-dev] [PATCH v5 4/5] eventdev/rx_adapter: implement per queue event buffer

2021-10-05 Thread Naga Harish K, S V
Hi Jay, > -Original Message- > From: Jayatheerthan, Jay > Sent: Tuesday, October 5, 2021 1:26 PM > To: Naga Harish K, S V ; jer...@marvell.com > Cc: dev@dpdk.org > Subject: RE: [PATCH v5 4/5] eventdev/rx_adapter: implement per queue > event buffer > > > -Original Message- > > Fro

  1   2   3   >