[dpdk-dev] [PATCH v2 15/41] common/mlx5: add PF_INET socket interface

2021-10-08 Thread Srikanth Kaka
Similar to NETLINK ROUTE socket in Linux, PF_INET sockets are used to communicate with FreeBSD network stack Signed-off-by: Srikanth Kaka Signed-off-by: Vag Singh Signed-off-by: Anand Thulasiram --- drivers/common/mlx5/freebsd/meson.build | 1 + drivers/common/mlx5/freebsd/mlx5_inet.c | 308

[dpdk-dev] [PATCH v2 21/41] net/mlx5: add set MTU routine

2021-10-08 Thread Srikanth Kaka
using IOCTL call MTU is set Signed-off-by: Srikanth Kaka Signed-off-by: Vag Singh Signed-off-by: Anand Thulasiram --- drivers/net/mlx5/freebsd/mlx5_ethdev_os.c | 19 +++ 1 file changed, 19 insertions(+) diff --git a/drivers/net/mlx5/freebsd/mlx5_ethdev_os.c b/drivers/net/mlx5

[dpdk-dev] [PATCH v2 16/41] common/mlx5: add VLAN vmwa structures

2021-10-08 Thread Srikanth Kaka
Add VLAN vmwa structures to compilation success. It is not yet supported in FreeBSD Signed-off-by: Srikanth Kaka Signed-off-by: Vag Singh Signed-off-by: Anand Thulasiram --- drivers/common/mlx5/freebsd/mlx5_inet.h | 18 ++ 1 file changed, 18 insertions(+) diff --git a/drivers/

[dpdk-dev] [PATCH v2 24/41] net/mlx5: read device clock

2021-10-08 Thread Srikanth Kaka
read device clock Signed-off-by: Srikanth Kaka Signed-off-by: Vag Singh Signed-off-by: Anand Thulasiram --- drivers/net/mlx5/freebsd/mlx5_ethdev_os.c | 31 +++ 1 file changed, 31 insertions(+) diff --git a/drivers/net/mlx5/freebsd/mlx5_ethdev_os.c b/drivers/net/mlx5/freeb

[dpdk-dev] [PATCH v2 23/41] net/mlx5: add link update callback

2021-10-08 Thread Srikanth Kaka
callback to retrieve physical link information Signed-off-by: Srikanth Kaka Signed-off-by: Vag Singh Signed-off-by: Anand Thulasiram --- drivers/net/mlx5/freebsd/mlx5_ethdev_os.c | 175 ++ 1 file changed, 175 insertions(+) diff --git a/drivers/net/mlx5/freebsd/mlx5_ethdev_

[dpdk-dev] [PATCH v2 17/41] net/mlx5: add vlan vmwa stub

2021-10-08 Thread Srikanth Kaka
VLAN workaround for ESXi is not yet supported in FreeBSD, adding placeholders Signed-off-by: Srikanth Kaka Signed-off-by: Vag Singh Signed-off-by: Anand Thulasiram --- drivers/net/mlx5/freebsd/mlx5_vlan_os.c | 84 + 1 file changed, 84 insertions(+) create mode 100644 d

[dpdk-dev] [PATCH v2 20/41] net/mlx5: add OS MAC routines

2021-10-08 Thread Srikanth Kaka
The OS MAC routines use INET socket to perform their tasks Signed-off-by: Srikanth Kaka Signed-off-by: Vag Singh Signed-off-by: Anand Thulasiram --- drivers/net/mlx5/freebsd/mlx5_os.c | 105 + 1 file changed, 105 insertions(+) diff --git a/drivers/net/mlx5/freebsd/

[dpdk-dev] [PATCH v2 30/41] net/mlx5: add stubs for bonding

2021-10-08 Thread Srikanth Kaka
add stubs for bonding Signed-off-by: Srikanth Kaka Signed-off-by: Vag Singh Signed-off-by: Anand Thulasiram --- drivers/net/mlx5/freebsd/mlx5_ethdev_os.c | 42 +++ 1 file changed, 42 insertions(+) diff --git a/drivers/net/mlx5/freebsd/mlx5_ethdev_os.c b/drivers/net/mlx5/f

[dpdk-dev] [PATCH v2 25/41] net/mlx5: handle async device events

2021-10-08 Thread Srikanth Kaka
These function is implemented to support event sharing between multiple ports of single IB device. They are a copy of their Linux counterparts. Signed-off-by: Srikanth Kaka Signed-off-by: Vag Singh Signed-off-by: Anand Thulasiram --- drivers/net/mlx5/freebsd/mlx5_ethdev_os.c | 216 +++

[dpdk-dev] [PATCH v2 35/41] net/mlx5: add pci probe and dev spawn support

2021-10-08 Thread Srikanth Kaka
add pci probe and dev spawn support Signed-off-by: Srikanth Kaka Signed-off-by: Vag Singh Signed-off-by: Anand Thulasiram --- drivers/net/mlx5/freebsd/mlx5_os.c | 1836 +++- 1 file changed, 1835 insertions(+), 1 deletion(-) diff --git a/drivers/net/mlx5/freebsd/mlx5_os

[dpdk-dev] [PATCH v2 26/41] net/mlx5: add callback to check dev is removed

2021-10-08 Thread Srikanth Kaka
add callback to check dev is removed Signed-off-by: Srikanth Kaka Signed-off-by: Vag Singh Signed-off-by: Anand Thulasiram --- drivers/net/mlx5/freebsd/mlx5_ethdev_os.c | 20 1 file changed, 20 insertions(+) diff --git a/drivers/net/mlx5/freebsd/mlx5_ethdev_os.c b/driver

[dpdk-dev] [PATCH v2 36/41] net/mlx5: set file descriptor as non-blocking

2021-10-08 Thread Srikanth Kaka
set file descriptor as non-blocking Signed-off-by: Srikanth Kaka Signed-off-by: Vag Singh Signed-off-by: Anand Thulasiram --- drivers/net/mlx5/freebsd/mlx5_os.c | 21 + 1 file changed, 21 insertions(+) diff --git a/drivers/net/mlx5/freebsd/mlx5_os.c b/drivers/net/mlx5/fre

[dpdk-dev] [PATCH v2 34/41] net/mlx5: add flow workspace APIs

2021-10-08 Thread Srikanth Kaka
add flow workspace APIs Signed-off-by: Srikanth Kaka Signed-off-by: Vag Singh Signed-off-by: Anand Thulasiram --- drivers/net/mlx5/freebsd/mlx5_flow_os.c | 38 ++ drivers/net/mlx5/freebsd/mlx5_flow_os.h | 484 2 files changed, 522 insertions(+) create mode 100644 dri

[dpdk-dev] [PATCH v2 28/41] net/mlx5: add module callbacks

2021-10-08 Thread Srikanth Kaka
add stubs for nodule callbacks Signed-off-by: Srikanth Kaka Signed-off-by: Vag Singh Signed-off-by: Anand Thulasiram --- drivers/net/mlx5/freebsd/mlx5_ethdev_os.c | 39 +++ 1 file changed, 39 insertions(+) diff --git a/drivers/net/mlx5/freebsd/mlx5_ethdev_os.c b/drivers/n

[dpdk-dev] [PATCH v2 33/41] net/mlx5: add initialization routines

2021-10-08 Thread Srikanth Kaka
The mlx5_init_once() and mlx5_init_shared_data() are equivalent to their Linux counterparts Signed-off-by: Srikanth Kaka Signed-off-by: Vag Singh Signed-off-by: Anand Thulasiram --- drivers/net/mlx5/freebsd/mlx5_os.c | 139 + 1 file changed, 139 insertions(+) diff

[dpdk-dev] [PATCH v2 27/41] net/mlx5: add flow control callbacks

2021-10-08 Thread Srikanth Kaka
add flow control stub callbacks Signed-off-by: Srikanth Kaka Signed-off-by: Vag Singh Signed-off-by: Anand Thulasiram --- drivers/net/mlx5/freebsd/mlx5_ethdev_os.c | 46 +++ 1 file changed, 46 insertions(+) diff --git a/drivers/net/mlx5/freebsd/mlx5_ethdev_os.c b/drivers/

[dpdk-dev] [PATCH v2 32/41] net/mlx5: add multiprocess support

2021-10-08 Thread Srikanth Kaka
These routines are equivalent to their Linux counterparts Signed-off-by: Srikanth Kaka Signed-off-by: Vag Singh Signed-off-by: Anand Thulasiram --- drivers/net/mlx5/freebsd/mlx5_mp_os.c | 305 ++ 1 file changed, 305 insertions(+) create mode 100644 drivers/net/mlx5/fre

[dpdk-dev] [PATCH v2 29/41] net/mlx5: added stats support

2021-10-08 Thread Srikanth Kaka
Initialize device stats and fetch them using sysctl. Signed-off-by: Srikanth Kaka Signed-off-by: Vag Singh Signed-off-by: Anand Thulasiram --- drivers/net/mlx5/freebsd/mlx5_ethdev_os.c | 217 ++ 1 file changed, 217 insertions(+) diff --git a/drivers/net/mlx5/freebsd/mlx5_e

[dpdk-dev] [PATCH v2 31/41] net/mlx5: add stub to read hw counters

2021-10-08 Thread Srikanth Kaka
retrieving hw counter stats is not supported at the moment. Signed-off-by: Srikanth Kaka Signed-off-by: Vag Singh Signed-off-by: Anand Thulasiram --- drivers/net/mlx5/freebsd/mlx5_os.c | 24 1 file changed, 24 insertions(+) diff --git a/drivers/net/mlx5/freebsd/mlx5_o

[dpdk-dev] [PATCH v2 37/41] net/mlx5: add routine to extract pdn

2021-10-08 Thread Srikanth Kaka
add routine to extract pdn Signed-off-by: Srikanth Kaka Signed-off-by: Vag Singh Signed-off-by: Anand Thulasiram --- drivers/net/mlx5/freebsd/mlx5_os.c | 35 ++ 1 file changed, 35 insertions(+) diff --git a/drivers/net/mlx5/freebsd/mlx5_os.c b/drivers/net/mlx5/fre

[dpdk-dev] [PATCH v2 38/41] net/mlx5: set promisc and allmulti modes

2021-10-08 Thread Srikanth Kaka
Using INET socket, promisc and allmulti modes are set/unset In FreeBSD, allmulti mode cannot be toggled from userspace thus it can only be unset in DPDK but not at device level. Signed-off-by: Srikanth Kaka Signed-off-by: Vag Singh Signed-off-by: Anand Thulasiram --- drivers/net/mlx5/freebsd/m

[dpdk-dev] [PATCH v2 39/41] common/mlx5: add stub for mlx5_translate_port_name

2021-10-08 Thread Srikanth Kaka
Add stub for mlx5_translate_port_name Signed-off-by: Srikanth Kaka Signed-off-by: Vag Singh Signed-off-by: Anand Thulasiram --- drivers/common/mlx5/freebsd/mlx5_common_os.c | 20 1 file changed, 20 insertions(+) diff --git a/drivers/common/mlx5/freebsd/mlx5_common_os.c b

[dpdk-dev] [PATCH v2 40/41] net/mlx5: add meson support for FreeBSD

2021-10-08 Thread Srikanth Kaka
- On FreeBSD, XOPEN_SOURCE=600 is missing 'strlen' prototype. The default XOPEN_SOURCE value (700) is used. Signed-off-by: Srikanth Kaka Signed-off-by: Vag Singh Signed-off-by: Anand Thulasiram --- drivers/net/mlx5/freebsd/meson.build | 14 ++ drivers/net/mlx5/meson.build

[dpdk-dev] [PATCH v2 02/11] bus/vmbus: scan and get the network device

2021-10-08 Thread Srikanth Kaka
From: srikanth-oc Using sysctl, all the devices on the VMBUS are identified by the PMD. On finding the Network device's device id, it is added to VMBUS dev list. v2 - replaced strncpy with memcpy - replaced malloc.h with stdlib.h Signed-off-by: Srikanth Kaka Signed-off-by: Vag Singh Signed

[dpdk-dev] [PATCH v2 05/11] bus/vmbus: open subchannels

2021-10-08 Thread Srikanth Kaka
From: srikanth-oc In FreeBSD, unlike Linux there is no sub-channel open callback that could be called by HV_UIO driver, upon their grant by the hypervisor. Thus, the PMD makes an IOCTL to the HV_UIO to open the granted sub-channels v2 - Added comment in linux/vmbus_uio.c Signed-off-by: Srikanth

[dpdk-dev] [PATCH v2 11/11] net/netvsc: add meson support for FreeBSD

2021-10-08 Thread Srikanth Kaka
From: srikanth-oc add meson support for FreeBSD v2 - moved include statement to after OS detection - updated ./MAINTAINERS file Signed-off-by: Srikanth Kaka Signed-off-by: Vag Singh Signed-off-by: Anand Thulasiram --- MAINTAINERS| 2 ++ drivers/net/netvsc/free

[dpdk-dev] [PATCH v2 41/41] doc/mlx5: update docs with FreeBSD information

2021-10-08 Thread Srikanth Kaka
Added FreeBSD prerequisites, limitations and features supported. --- doc/guides/nics/mlx5.rst | 30 ++ 1 file changed, 30 insertions(+) diff --git a/doc/guides/nics/mlx5.rst b/doc/guides/nics/mlx5.rst index bae73f42d8..cf6d1e70f6 100644 --- a/doc/guides/nics/mlx5.rst +

Re: [dpdk-dev] [EXT] Re: [PATCH v5 1/3] net/thunderx: enable build only on 64-bit Linux

2021-10-08 Thread Ferruh Yigit
On 10/4/2021 1:54 PM, Pavan Nikhilesh Bhagavatula wrote: On 10/4/2021 1:01 PM, Pavan Nikhilesh Bhagavatula wrote: On 10/4/2021 12:34 PM, Pavan Nikhilesh Bhagavatula wrote: On 10/4/2021 11:02 AM, Pavan Nikhilesh Bhagavatula wrote: On 10/4/2021 6:56 AM, pbhagavat...@marvell.com wrote: From: Pav

Re: [dpdk-dev] [PATCH v5 1/3] eal/linux: make hugetlbfs analysis reusable

2021-10-08 Thread John Levon
On Tue, Oct 05, 2021 at 07:36:21PM +0200, Thomas Monjalon wrote: > 21/09/2021 10:16, dkozl...@oss.nvidia.com: > > From: Dmitry Kozlyuk > > > > get_hugepage_dir() searched for a hugetlbfs mount with a given page size > > using handcraft parsing of /proc/mounts and mixing traversal logic with > >

Re: [dpdk-dev] [PATCH v5 1/3] eal/linux: make hugetlbfs analysis reusable

2021-10-08 Thread Dmitry Kozlyuk
Hello John, > Any progress on these? Since now my original patch ("eal: allow hugetlbfs > sub-directories") is going to have to wait behind this series, since nobody > responded to review of the last version. Your patch does not directly depend on this one and can be merged earlier. Maybe my prev

[dpdk-dev] [PATCH v3] ipv4 and udp/tcp cksum verification through software

2021-10-08 Thread Usama Nadeem
checks if ipv4 and udptcp cksum offload capability available If not available, cksum is verified through software If cksum is corrupt, packet is dropped, rest of the packets are forwarded back. Bugzilla ID:545 Signed-off-by: Usama Nadeem --- examples/l3fwd/l3fwd.h | 6 examples/l3fwd/l

Re: [dpdk-dev] [PATCH v5 1/6] ethdev: fix max Rx packet length

2021-10-08 Thread Ananyev, Konstantin
> There is a confusion on setting max Rx packet length, this patch aims to > clarify it. > > 'rte_eth_dev_configure()' API accepts max Rx packet size via > 'uint32_t max_rx_pkt_len' field of the config struct 'struct > rte_eth_conf'. > > Also 'rte_eth_dev_set_mtu()' API can be used to set the

Re: [dpdk-dev] [PATCH v3 11/14] eventdev: move timer adapters memory to hugepage

2021-10-08 Thread Carrillo, Erik G
> -Original Message- > From: Pavan Nikhilesh Bhagavatula > Sent: Friday, October 8, 2021 12:38 AM > To: Carrillo, Erik G ; Jerin Jacob Kollanukkaran > > Cc: dev@dpdk.org > Subject: RE: [dpdk-dev] [PATCH v3 11/14] eventdev: move timer adapters > memory to hugepage > > Hi Erik, > > >Hi Pa

Re: [dpdk-dev] [PATCH v2] net/e1000: build on Windows

2021-10-08 Thread Wang, Haiyue
> -Original Message- > From: William Tu > Sent: Friday, October 8, 2021 21:54 > To: dev@dpdk.org > Cc: Kadam, Pallavi ; david.march...@redhat.com; > Wang, Haiyue > > Subject: [PATCH v2] net/e1000: build on Windows > > This patch enables building the e1000 driver for Windows. > I tested

[dpdk-dev] [PATCH v2 11/11] net/netvsc: add meson support for FreeBSD

2021-10-08 Thread Srikanth Kaka
add meson support for FreeBSD v2 - moved include statement to after OS detection - updated ./MAINTAINERS file Signed-off-by: Srikanth Kaka Signed-off-by: Vag Singh Signed-off-by: Anand Thulasiram --- MAINTAINERS| 2 ++ drivers/net/netvsc/freebsd/meson.build | 6

[dpdk-dev] [PATCH v2 02/11] bus/vmbus: scan and get the network device

2021-10-08 Thread Srikanth Kaka
Using sysctl, all the devices on the VMBUS are identified by the PMD. On finding the Network device's device id, it is added to VMBUS dev list. v2 - replaced strncpy with memcpy - replaced malloc.h with stdlib.h Signed-off-by: Srikanth Kaka Signed-off-by: Vag Singh Signed-off-by: Anand Thula

[dpdk-dev] [PATCH v2 05/11] bus/vmbus: open subchannels

2021-10-08 Thread Srikanth Kaka
In FreeBSD, unlike Linux there is no sub-channel open callback that could be called by HV_UIO driver, upon their grant by the hypervisor. Thus, the PMD makes an IOCTL to the HV_UIO to open the granted sub-channels v2 - Added comment in linux/vmbus_uio.c Signed-off-by: Srikanth Kaka Signed-off-by

Re: [dpdk-dev] [PATCH v5 5/6] ethdev: unify MTU checks

2021-10-08 Thread Ananyev, Konstantin
> Both 'rte_eth_dev_configure()' & 'rte_eth_dev_set_mtu()' sets MTU but > have slightly different checks. Like one checks min MTU against > RTE_ETHER_MIN_MTU and other RTE_ETHER_MIN_LEN. > > Checks moved into common function to unify the checks. Also this has > benefit to have common error logs.

Re: [dpdk-dev] [PATCH v5 6/6] examples/ip_reassembly: remove unused parameter

2021-10-08 Thread Ananyev, Konstantin
> Remove 'max-pkt-len' parameter. > > Signed-off-by: Ferruh Yigit > --- > examples/ip_reassembly/main.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/examples/ip_reassembly/main.c b/examples/ip_reassembly/main.c > index af67db49f7fb..2ff5ea3e7bc5 100644 > --- a/examples/ip_reassem

Re: [dpdk-dev] [dpdk-stable] [PATCH v6 1/2] app/testpmd: update forward engine beginning

2021-10-08 Thread Ferruh Yigit
On 9/23/2021 9:01 AM, Alvin Zhang wrote: For each forward engine, there may be some special conditions must be met before the forwarding runs. Adding checks for these conditions in configuring is not suitable, because one condition may rely on multiple configurations, and the conditions required

Re: [dpdk-dev] [PATCH v5 4/6] ethdev: remove jumbo offload flag

2021-10-08 Thread Ananyev, Konstantin
> > Removing 'DEV_RX_OFFLOAD_JUMBO_FRAME' offload flag. > > Instead of drivers announce this capability, application can deduct the > capability by checking reported 'dev_info.max_mtu' or > 'dev_info.max_rx_pktlen'. > > And instead of application setting this flag explicitly to enable jumbo >

[dpdk-dev] [PATCH v7 0/5] improve telemetry support with in-memory mode

2021-10-08 Thread Bruce Richardson
This patchset cleans up telemetry support for "in-memory" mode, so that multiple independent processes can be run using that mode and still have telemetry support. It also removes problems of one process removing the socket of another - which was the original issue reported. The main changes in thi

[dpdk-dev] [PATCH v7 1/5] eal: limit telemetry to primary processes

2021-10-08 Thread Bruce Richardson
Telemetry interface should be exposed for primary processes only, since secondary processes will conflict on socket creation, and since all data in secondary process is generally available to primary. For example, all device stats for ethdevs, cryptodevs, etc. will all be common across processes.

[dpdk-dev] [PATCH v7 2/5] telemetry: fix deletion of active sockets

2021-10-08 Thread Bruce Richardson
When DPDK is run with --in-memory mode, multiple processes can run simultaneously using the same runtime dir. This leads to each process, as it starts up, removing the telemetry socket of another process, giving unexpected behaviour. This patch changes that behaviour to first check if the existing

[dpdk-dev] [PATCH v7 3/5] telemetry: use unique socket paths for in-memory mode

2021-10-08 Thread Bruce Richardson
When running in in-memory mode, multiple processes can use the same runtime dir, leading to conflicts with the telemetry sockets in that directory. We can resolve this by appending a suffix to each socket beyond the first, with the suffix being an increasing counter value. Each process uses the fir

[dpdk-dev] [PATCH v7 4/5] usertools/dpdk-telemetry: connect to separate instances

2021-10-08 Thread Bruce Richardson
For processes run using "in-memory" mode sharing the same runtime dir, we add support for connecting to the separate instance sockets created using ":1", ":2" etc. via new "-i" or "--instance" argument. Add details on connecting to separate instances to the telemetry howto document. Signed-off-by:

[dpdk-dev] [PATCH v7 5/5] usertools/dpdk-telemetry: provide info on available sockets

2021-10-08 Thread Bruce Richardson
When a user runs the dpdk-telemetry script and fails to connect because the socket path does not exist, run a scan for possible sockets that could be connected to and inform the user of the command needed to connect to those. For example: $ ./usertools/dpdk-telemetry.py -i4 Connecting to /run

Re: [dpdk-dev] [PATCH v5 3/6] ethdev: move check to library for MTU set

2021-10-08 Thread Ananyev, Konstantin
> > Move requested MTU value check to the API to prevent the duplicated > code. > > Signed-off-by: Ferruh Yigit > Reviewed-by: Andrew Rybchenko > Reviewed-by: Rosen Xu > Acked-by: Somnath Kotur > --- Acked-by: Konstantin Ananyev > 2.31.1

Re: [dpdk-dev] [PATCH v5 2/6] ethdev: move jumbo frame offload check to library

2021-10-08 Thread Ananyev, Konstantin
> > Setting MTU bigger than RTE_ETHER_MTU requires the jumbo frame support, > and application should enable the jumbo frame offload support for it. > > When jumbo frame offload is not enabled by application, but MTU bigger > than RTE_ETHER_MTU is requested there are two options, either fail or >

Re: [dpdk-dev] [PATCH 0/2] Bugfixes for bonding

2021-10-08 Thread Ferruh Yigit
On 9/22/2021 8:09 AM, Min Hu (Connor) wrote: This patchset contains two bugfixes for bonding. Chengchang Tang (2): net/bonding: fix dedicated queue mode in vector burst net/bonding: fix RSS key length Series applied to dpdk-next-net/main, thanks.

Re: [dpdk-dev] [EXT] [PATCH 1/3] crypto/aesni_mb: add NULL/NULL support

2021-10-08 Thread Akhil Goyal
> > Hi Radu and Akhil > > We can add this change as a patch into > http://patchwork.dpdk.org/project/dpdk/cover/20210929163035.608387-1-ciara.po...@intel.com/ > v4 it is ok. > The doc can be updated accordingly. > No issues from my side.

Re: [dpdk-dev] [EXT] [PATCH v7 0/8] new features for ipsec and security libraries

2021-10-08 Thread Akhil Goyal
> Add support for: > TSO, NAT-T/UDP encapsulation, ESN > AES_CCM, CHACHA20_POLY1305 and AES_GMAC > SA telemetry > mbuf offload flags > Initial SQN value > > Radu Nicolau (8): > security: add ESN field to ipsec_xform > ipsec: add support for AEAD algorithms > security: add UDP params for IPse

Re: [dpdk-dev] [EXT] [PATCH v7 2/8] ipsec: add support for AEAD algorithms

2021-10-08 Thread Akhil Goyal
> Add support for AES_CCM, CHACHA20_POLY1305 and AES_GMAC. > > Signed-off-by: Declan Doherty > Signed-off-by: Radu Nicolau > Signed-off-by: Abhijit Sinha > Signed-off-by: Daniel Martin Buckley > Acked-by: Fan Zhang > Acked-by: Konstantin Ananyev > --- > lib/ipsec/crypto.h | 137 >

Re: [dpdk-dev] [EXT] [PATCH v3 1/8] examples/ipsec-secgw: add stats interval argument

2021-10-08 Thread Akhil Goyal
> diff --git a/doc/guides/sample_app_ug/ipsec_secgw.rst > b/doc/guides/sample_app_ug/ipsec_secgw.rst > index 78171b25f9..846cf2b81a 100644 > --- a/doc/guides/sample_app_ug/ipsec_secgw.rst > +++ b/doc/guides/sample_app_ug/ipsec_secgw.rst > @@ -127,6 +127,7 @@ The application has a number of command

Re: [dpdk-dev] [EXT] [PATCH v3 2/8] examples/ipsec-secgw: update create inline session

2021-10-08 Thread Akhil Goyal
> Rework create inline session function as to update the session > configuration parameters before create session is called. > Also updated the rss key array size to prevent buffers overflows > with PMDs that copy more than 40 bytes. > > Signed-off-by: Radu Nicolau > --- Acked-by: Akhil Goyal

Re: [dpdk-dev] [EXT] [PATCH v3 3/8] examples/ipsec-secgw: add support for inline crypto UDP encapsulation

2021-10-08 Thread Akhil Goyal
> Enable UDP encapsulation for both transport and tunnel modes for the > inline crypto offload path. > > Signed-off-by: Radu Nicolau > --- > examples/ipsec-secgw/ipsec.c | 33 + > examples/ipsec-secgw/ipsec.h | 7 ++- > examples/ipsec-secgw/sa.c| 9 +++

Re: [dpdk-dev] [EXT] [PATCH v3 4/8] examples/ipsec-secgw: add support for TSO

2021-10-08 Thread Akhil Goyal
> Add support to allow user to specific MSS for TSO offload on a per SA > basis. MSS configuration in the context of IPsec is only supported for > outbound SA's in the context of an inline IPsec Crypto offload. > > Signed-off-by: Declan Doherty > Signed-off-by: Radu Nicolau > --- > doc/guides/s

Re: [dpdk-dev] [EXT] [PATCH v3 5/8] examples/ipsec-secgw: add support for telemetry

2021-10-08 Thread Akhil Goyal
Subject can be Examples/ipsec-secgw: support telemetry > Add telemetry support to the IPsec GW sample app > Elaborate patch description to show how it can be used. Probably it is worth mentioning how the output will look like. > Signed-off-by: Declan Doherty > Signed-off-by: Radu Nicolau > ---

Re: [dpdk-dev] [EXT] [PATCH v3 6/8] examples/ipsec-secgw: add support for defining initial sequence number value

2021-10-08 Thread Akhil Goyal
> Subject: [EXT] [PATCH v3 6/8] examples/ipsec-secgw: add support for > defining initial sequence number value > Subject too long. examples/ipsec-secgw: define initial ESN value > Add esn field to SA definition block to allow initial ESN value The commit description should describe the new opt

Re: [dpdk-dev] [EXT] [PATCH v3 8/8] examples/ipsec-secgw: add support for additional algorithms

2021-10-08 Thread Akhil Goyal
> Add support for AES-GMAC, AES_CTR, AES_XCBC_MAC, > AES_CCM, CHACHA20_POLY1305 > > Signed-off-by: Declan Doherty > Signed-off-by: Radu Nicolau > --- > examples/ipsec-secgw/ipsec.h | 3 +- > examples/ipsec-secgw/sa.c| 133 --- > 2 files changed, 126 inserti

Re: [dpdk-dev] [EXT] [PATCH] crypto/ipsec_mb: support ZUC-256

2021-10-08 Thread Akhil Goyal
> Add support for ZUC-EEA3-256 and ZUC-EIA3-256 > (only 4-byte tags supported for now). > > Signed-off-by: Pablo de Lara > --- > > This patch depends on patchset > https://patches.dpdk.org/project/dpdk/list/?series=18470 > Hi Fan/Ciara/Pablo, Please add this patch also to the dependent series.

Re: [dpdk-dev] [EXT] [PATCH v1] bbdev: remove experimental tag from API

2021-10-08 Thread Akhil Goyal
> This promotes the bbdev interface to stable. > Overdue for some time as bbdev interface has been stable. > > Signed-off-by: Nicolas Chautru > --- Acked-by: Akhil Goyal If anybody has any objections please raise or else this patch Will be merged in RC1.

[dpdk-dev] [PATCH v2] test/crypto-perf: support lookaside IPsec

2021-10-08 Thread Akhil Goyal
Added support for lookaside IPsec protocol offload. Supported cases: -AEAD -Cipher+auth Command used for testing: ./dpdk-test-crypto-perf -c 0xf -- --devtype crypto_octeontx2 --ptest throughput --optype ipsec --cipher-algo aes-cbc --pool-sz 16384 --cipher-op encrypt --cipher-key-sz 16 --cipher-iv-

Re: [dpdk-dev] [PATCH v3 6/9] gpudev: add memory barrier

2021-10-08 Thread Thomas Monjalon
09/10/2021 03:53, eagost...@nvidia.com: > From: Elena Agostini > > Add a function for the application to ensure the coherency > of the writes executed by another device into the GPU memory. > > Signed-off-by: Elena Agostini > --- > +/** > + * @warning > + * @b EXPERIMENTAL: this API may change

Re: [dpdk-dev] [PATCH v3 5/9] gpudev: add memory API

2021-10-08 Thread Thomas Monjalon
09/10/2021 03:53, eagost...@nvidia.com: > --- a/lib/gpudev/version.map > +++ b/lib/gpudev/version.map > + rte_gpu_free; > rte_gpu_info_get; > rte_gpu_init; > rte_gpu_is_valid; > + rte_gpu_malloc; > + rte_gpu_register; > + rte_gpu_unregister; > }; Should we insert

Re: [dpdk-dev] [PATCH v2] kni: Fix request overwritten

2021-10-08 Thread Ferruh Yigit
On 10/4/2021 7:27 PM, Elad Nachman wrote: בתאריך יום ב׳, 4 באוק׳ 2021, 20:00, מאת Eric Christian ‏ : I am not sure that only we can recreate the KNI request overwrite. We may be the only ones with a current use case that exposes the vulnerability. It is possible for any KNI operation to enc

Re: [dpdk-dev] [EXT] [PATCH v7 0/8] new features for ipsec and security libraries

2021-10-08 Thread Akhil Goyal
> Subject: RE: [EXT] [PATCH v7 0/8] new features for ipsec and security > libraries > > > Add support for: > > TSO, NAT-T/UDP encapsulation, ESN > > AES_CCM, CHACHA20_POLY1305 and AES_GMAC > > SA telemetry > > mbuf offload flags > > Initial SQN value > > > > Radu Nicolau (8): > > security: add

Re: [dpdk-dev] [PATCH v2] net/e1000: build on Windows

2021-10-08 Thread Dmitry Kozlyuk
2021-10-08 06:53 (UTC-0700), William Tu: > This patch enables building the e1000 driver for Windows. > I tested using two Windows VM on top of VMware Fusion, > creating two e1000 devices with device ID 0x10D3, > verifying rx/tx works correctly using dpdk-testpmd.exe > rxonly and txonly mode. > > S

[dpdk-dev] [PATCH v2 1/3] cryptodev: remove LIST_END enumerators

2021-10-08 Thread Akhil Goyal
Remove *_LIST_END enumerators from asymmetric crypto lib to avoid ABI breakage for every new addition in enums. Signed-off-by: Akhil Goyal --- v2: no change app/test/test_cryptodev_asym.c | 4 ++-- drivers/crypto/qat/qat_asym.c | 2 +- lib/cryptodev/rte_crypto_asym.h | 4 3 files change

[dpdk-dev] [PATCH v2 2/3] security: hide internal API

2021-10-08 Thread Akhil Goyal
rte_security_dynfield_register() is an internal API to be used by the driver, hence moving it to internal. Signed-off-by: Akhil Goyal Acked-by: Konstantin Ananyev --- v2: no change lib/security/rte_security_driver.h | 2 +- lib/security/version.map | 7 ++- 2 files changed, 7 ins

[dpdk-dev] [PATCH v2 3/3] security: add reserved bitfields

2021-10-08 Thread Akhil Goyal
In struct rte_security_ipsec_sa_options, for every new option added, there is an ABI breakage, to avoid, a reserved_opts bitfield is added to for the remaining bits available in the structure. Now for every new sa option, these reserved_opts can be reduced and new option can be added. Signed-off-b

Re: [dpdk-dev] [PATCH v2] kni: Fix request overwritten

2021-10-08 Thread Ferruh Yigit
On 10/4/2021 5:18 PM, Elad Nachman wrote: On Mon, Oct 4, 2021 at 7:05 PM Ferruh Yigit wrote: On 10/4/2021 3:58 PM, Elad Nachman wrote: בתאריך יום ב׳, 4 באוק׳ 2021, 17:51, מאת Ferruh Yigit ‏< ferruh.yi...@intel.com>: On 10/4/2021 3:25 PM, Elad Nachman wrote: Can you please try to not top po

[dpdk-dev] [PATCH] doc/windows_gsg: update section on driver installation

2021-10-08 Thread Dmitry Kozlyuk
Windows GSG included a section only on virt2phys driver installation, but not on NetUIO. The content of the section duplicated documentation in dpdk-kmods, but contained no links to it, only a reference. Add subsections for virt2phys and NetUIO, explaining their roles. Refer to documenttion in dpd

Re: [dpdk-dev] [PATCH v2] net/e1000: build on Windows

2021-10-08 Thread Kadam, Pallavi
On 10/8/2021 9:08 AM, Wang, Haiyue wrote: -Original Message- From: William Tu Sent: Friday, October 8, 2021 21:54 To: dev@dpdk.org Cc: Kadam, Pallavi ; david.march...@redhat.com; Wang, Haiyue Subject: [PATCH v2] net/e1000: build on Windows This patch enables building the e1000 drive

[dpdk-dev] [PATCH] test/hash: fix buffer overflow

2021-10-08 Thread Vladimir Medvedkin
This patch fixes buffer overflow reported by ASAN, please reference https://bugs.dpdk.org/show_bug.cgi?id=818 Some tests for the rte_hash table use the rte_jhash_32b() as the hash function. This hash function interprets the length argument in units of 4 bytes. This patch divides configured key le

[dpdk-dev] [PATCH] lpm: fix buffer overflow

2021-10-08 Thread Vladimir Medvedkin
This patch fixes buffer overflow reported by ASAN, please reference https://bugs.dpdk.org/show_bug.cgi?id=819 The rte_lpm6 keeps routing information for control plane purpose inside the rte_hash table which uses rte_jhash() as a hash function. >From the rte_jhash() documentation: If input key is n

Re: [dpdk-dev] [PATCH v2] net/e1000: build on Windows

2021-10-08 Thread William Tu
On Fri, Oct 8, 2021 at 1:35 PM Dmitry Kozlyuk wrote: > > 2021-10-08 06:53 (UTC-0700), William Tu: > > This patch enables building the e1000 driver for Windows. > > I tested using two Windows VM on top of VMware Fusion, > > creating two e1000 devices with device ID 0x10D3, > > verifying rx/tx works

[dpdk-dev] [PATCH v3 4/9] gpudev: support multi-process

2021-10-08 Thread eagostini
From: Thomas Monjalon The device data shared between processes are moved in a struct allocated in a shared memory (a new memzone for all GPUs). The main struct rte_gpu references the shared memory via the pointer mpshared. The API function rte_gpu_attach() is added to attach a device from the se

[dpdk-dev] [PATCH v3 3/9] gpudev: add child device representing a device context

2021-10-08 Thread eagostini
From: Thomas Monjalon The computing device may operate in some isolated contexts. Memory and processing are isolated in a silo represented by a child device. The context is provided as an opaque by the caller of rte_gpu_add_child(). Signed-off-by: Thomas Monjalon --- doc/guides/prog_guide/gpud

[dpdk-dev] [PATCH v3 2/9] gpudev: add event notification

2021-10-08 Thread eagostini
From: Thomas Monjalon Callback functions may be registered for a device event. Callback management is per-process and not thread-safe. The events RTE_GPU_EVENT_NEW and RTE_GPU_EVENT_DEL are notified respectively after creation and before removal of a device, as part of the library functions. Som

[dpdk-dev] [PATCH v3 0/9] GPU library

2021-10-08 Thread eagostini
From: eagostini In heterogeneous computing system, processing is not only in the CPU. Some tasks can be delegated to devices working in parallel. The goal of this new library is to enhance the collaboration between DPDK, that's primarily a CPU framework, and GPU devices. When mixing network act

[dpdk-dev] [PATCH v3 5/9] gpudev: add memory API

2021-10-08 Thread eagostini
From: Elena Agostini In heterogeneous computing system, processing is not only in the CPU. Some tasks can be delegated to devices working in parallel. Such workload distribution can be achieved by sharing some memory. As a first step, the features are focused on memory management. A function all

[dpdk-dev] [PATCH v3 1/9] gpudev: introduce GPU device class library

2021-10-08 Thread eagostini
From: Elena Agostini In heterogeneous computing system, processing is not only in the CPU. Some tasks can be delegated to devices working in parallel. The new library gpudev is for dealing with GPGPU computing devices from a DPDK application running on the CPU. The infrastructure is prepared to

[dpdk-dev] [PATCH v3 8/9] gpudev: add communication list

2021-10-08 Thread eagostini
From: Elena Agostini In heterogeneous computing system, processing is not only in the CPU. Some tasks can be delegated to devices working in parallel. When mixing network activity with task processing there may be the need to put in communication the CPU with the device in order to synchronize op

[dpdk-dev] [PATCH v3 7/9] gpudev: add communication flag

2021-10-08 Thread eagostini
From: Elena Agostini In heterogeneous computing system, processing is not only in the CPU. Some tasks can be delegated to devices working in parallel. When mixing network activity with task processing there may be the need to put in communication the CPU with the device in order to synchronize op

[dpdk-dev] [PATCH v3 6/9] gpudev: add memory barrier

2021-10-08 Thread eagostini
From: Elena Agostini Add a function for the application to ensure the coherency of the writes executed by another device into the GPU memory. Signed-off-by: Elena Agostini --- doc/guides/prog_guide/gpudev.rst | 8 lib/gpudev/gpudev.c | 19 +++ lib/gpudev/

[dpdk-dev] [PATCH v3 9/9] doc: add CUDA example in GPU guide

2021-10-08 Thread eagostini
From: Elena Agostini Signed-off-by: Elena Agostini --- doc/guides/prog_guide/gpudev.rst | 122 +++ 1 file changed, 122 insertions(+) diff --git a/doc/guides/prog_guide/gpudev.rst b/doc/guides/prog_guide/gpudev.rst index cbaec5a1e4..1baf0c6772 100644 --- a/doc/guides

Re: [dpdk-dev] [PATCH v5 0/7] hide eth dev related structures

2021-10-08 Thread Slava Ovsiienko
Hi, I've reviewed the series, and it looks good to me. I see we did not introduce new indirect referencing on the datapath (just replaced rte_eth_devices[] being hidden with the new rte_eth_fp_ops[].) My only concern - we'll get two places where pointers to the PMDs routines are stored, and it me

[dpdk-dev] [PATCH v15 0/9] eal: Add EAL API for threading

2021-10-08 Thread Narcisa Ana Maria Vasile
From: Narcisa Vasile EAL thread API **Problem Statement** DPDK currently uses the pthread interface to create and manage threads. Windows does not support the POSIX thread programming model, so it currently relies on a header file that hides the Windows calls under pthread matched interfaces. Gi

[dpdk-dev] [PATCH v15 1/9] eal: add basic threading functions

2021-10-08 Thread Narcisa Ana Maria Vasile
From: Narcisa Vasile Use a portable, type-safe representation for the thread identifier. Add functions for comparing thread ids and obtaining the thread id for the current thread. Signed-off-by: Narcisa Vasile --- lib/eal/common/meson.build| 1 + lib/eal/{unix => common}/rte_threa

[dpdk-dev] [PATCH v15 3/9] eal/windows: translate Windows errors to errno-style errors

2021-10-08 Thread Narcisa Ana Maria Vasile
From: Narcisa Vasile Add function to translate Windows error codes to errno-style error codes. The possible return values are chosen so that we have as much semantical compatibility between platforms as possible. Signed-off-by: Narcisa Vasile --- lib/eal/common/rte_thread.c | 6 +-- lib/eal/

[dpdk-dev] [PATCH v15 4/9] eal: implement functions for thread affinity management

2021-10-08 Thread Narcisa Ana Maria Vasile
From: Narcisa Vasile Implement functions for getting/setting thread affinity. Threads can be pinned to specific cores by setting their affinity attribute. Signed-off-by: Narcisa Vasile Signed-off-by: Dmitry Malloy --- lib/eal/common/rte_thread.c | 16 lib/eal/include/rte_thread.h |

[dpdk-dev] [PATCH v15 2/9] eal: add thread attributes

2021-10-08 Thread Narcisa Ana Maria Vasile
From: Narcisa Vasile Implement thread attributes for: * thread affinity * thread priority Implement functions for managing thread attributes. Priority is represented through an enum that allows for two levels: - RTE_THREAD_PRIORITY_NORMAL - RTE_THREAD_PRIORITY_REALTIME_CRITICAL

[dpdk-dev] [PATCH v15 5/9] eal: implement thread priority management functions

2021-10-08 Thread Narcisa Ana Maria Vasile
From: Narcisa Vasile Add functions for setting and getting the priority of a thread. Priorities on multiple platforms are similarly determined by a priority value and a priority class/policy. On Linux, the following mapping is created: RTE_THREAD_PRIORITY_NORMAL corresponds to * policy SCHED_OTH

[dpdk-dev] [PATCH v15 9/9] Add unit tests for thread API

2021-10-08 Thread Narcisa Ana Maria Vasile
From: Narcisa Vasile As a new API for threading is introduced, a set of unit tests have been added to test the new interface. The tests verify that: * mutexes and barriers behave as expected * thread properties are applied correctly * the thread id is retrieved correctly * thread creation/des

[dpdk-dev] [PATCH v15 6/9] eal: add thread lifetime management

2021-10-08 Thread Narcisa Ana Maria Vasile
From: Narcisa Vasile Add functions for thread creation, joining, detaching. The *rte_thread_create()* function can optionally receive an rte_thread_attr_t object that will cause the thread to be created with the affinity and priority described by the attributes object. If no rte_thread_attr_t is

[dpdk-dev] [PATCH v15 8/9] eal: implement functions for thread barrier management

2021-10-08 Thread Narcisa Ana Maria Vasile
From: Narcisa Vasile Add functions for barrier init, destroy, wait. A portable type is used to represent a barrier identifier. The rte_thread_barrier_wait() function returns the same value on all platforms. Signed-off-by: Narcisa Vasile --- lib/eal/common/rte_thread.c | 61 ++

[dpdk-dev] [PATCH v15 7/9] eal: implement functions for mutex management

2021-10-08 Thread Narcisa Ana Maria Vasile
From: Narcisa Vasile Add functions for mutex init, destroy, lock, unlock, trylock. Add RTE_STATIC_MUTEX macro to replace static initialization of mutexes. Windows does not have a static initializer. Initialization is only done through InitializeCriticalSection(). The RTE_STATIC_MUTEX calls into

Re: [dpdk-dev] [PATCH v5 1/2] cmdline: make struct cmdline opaque

2021-10-08 Thread Narcisa Ana Maria Vasile
On Fri, Oct 08, 2021 at 01:10:27AM +0300, Dmitry Kozlyuk wrote: > Remove the definition of `struct cmdline` from public header. > Deprecation notice: > https://mails.dpdk.org/archives/dev/2020-September/183310.html > > Signed-off-by: Dmitry Kozlyuk > Acked-by: David Marchand > Acked-by: Olivier

Re: [dpdk-dev] [PATCH v5 2/2] cmdline: make struct rdline opaque

2021-10-08 Thread Narcisa Ana Maria Vasile
On Fri, Oct 08, 2021 at 01:10:28AM +0300, Dmitry Kozlyuk wrote: > Hide struct rdline definition and some RDLINE_* constants in order > to be able to change internal buffer sizes transparently to the user. > Add new functions: > > * rdline_new(): allocate and initialize struct rdline. > This func

<    1   2   3   >