Re: [dpdk-dev] [PATCH v2 3/5] cryptodev: move inline APIs into separate structure

2021-10-18 Thread Akhil Goyal
> Hi Akhil, > > > Move fastpath inline function pointers from rte_cryptodev into a > > separate structure accessed via a flat array. > > The intension is to make rte_cryptodev and related structures private > > to avoid future API/ABI breakages. > > > > Signed-off-by: Akhil Goyal > > --- > > lib

Re: [dpdk-dev] [PATCH v6 2/3] common/octeontx: enable build only on 64-bit Linux

2021-10-18 Thread Harman Kalra
> -Original Message- > From: pbhagavat...@marvell.com > Sent: Friday, October 15, 2021 1:27 AM > To: ferruh.yi...@intel.com; Jerin Jacob Kollanukkaran ; > Harman Kalra ; Ashish Gupta > ; Fiona Trahe ; Anoob > Joseph > Cc: dev@dpdk.org; Pavan Nikhilesh Bhagavatula > > Subject: [dpdk-de

Re: [dpdk-dev] [PATCH v2] net/virtio: handle Tx checksums correctly for tunnel packets

2021-10-18 Thread Andrew Rybchenko
On 10/15/21 11:32 AM, Olivier Matz wrote: > On Thu, Oct 14, 2021 at 07:12:29AM +, Xia, Chenbo wrote: >>> -Original Message- >>> From: Ivan Malov >>> Sent: Friday, September 17, 2021 2:50 AM >>> To: dev@dpdk.org >>> Cc: Maxime Coquelin ; sta...@dpdk.org; Andrew >>> Rybchenko ; Xia, Chen

Re: [dpdk-dev] [PATCH v4 07/14] eventdev: hide event device related structures

2021-10-18 Thread Harman Kalra
> -Original Message- > From: pbhagavat...@marvell.com > Sent: Saturday, October 16, 2021 12:32 AM > To: Jerin Jacob Kollanukkaran ; Timothy McDaniel > ; Mattias Rönnblom > ; Pavan Nikhilesh Bhagavatula > ; Harman Kalra ; Ray > Kinsella > Cc: dev@dpdk.org > Subject: [dpdk-dev] [PATCH v4

Re: [dpdk-dev] [PATCH v2 5/5] cryptodev: move device specific structures

2021-10-18 Thread Akhil Goyal
> > +struct rte_cryptodev_data { > > + /** Device ID for this instance */ > > + uint8_t dev_id; > > + /** Socket ID where memory is allocated */ > > + uint8_t socket_id; > > + /** Unique identifier name */ > > + char name[RTE_CRYPTODEV_NAME_MAX_LEN]; > > + > > + __extension__ > > +

Re: [dpdk-dev] [EXT] [PATCH v5 00/15] crypto: add raw vector support in DPAAx

2021-10-18 Thread Zhang, Roy Fan
Hi Akhil, We have been prepared for that. For this release we will update QAT PMD to return -ENOTSUP if we found dst sgl is not NULL or not equal to src sgl. Regards, Fan > -Original Message- > From: Akhil Goyal > Sent: Sunday, October 17, 2021 6:59 PM > To: Hemant Agrawal ; dev@dpdk.o

Re: [dpdk-dev] [PATCH v2 1/1] net: fix aliasing issue in checksum computation

2021-10-18 Thread Morten Brørup
> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Georg Sauthoff > Sent: Sunday, 17 October 2021 22.37 +Ferruh, as delegate to v1 in Patchwork. > > That means a superfluous cast is removed and aliasing through a uint8_t > pointer is eliminated. NB: The C standard specifies that a unsigned >

Re: [dpdk-dev] [PATCH v4 03/14] drivers/crypto: move aesni-mb PMD to IPsec-mb framework

2021-10-18 Thread Zhang, Roy Fan
> -Original Message- > From: Power, Ciara > Sent: Friday, October 15, 2021 3:40 PM > To: dev@dpdk.org > Cc: Zhang, Roy Fan ; Bronowski, PiotrX > ; gak...@marvell.com; De Lara Guarch, Pablo > ; m...@ashroe.eu; Power, Ciara > ; Thomas Monjalon > Subject: [PATCH v4 03/14] drivers/crypto: mov

Re: [dpdk-dev] [PATCH v4 04/14] crypto/ipsec_mb: support ZUC-256 for aesni_mb

2021-10-18 Thread Zhang, Roy Fan
> -Original Message- > From: Power, Ciara > Sent: Friday, October 15, 2021 3:40 PM > To: dev@dpdk.org > Cc: Zhang, Roy Fan ; Bronowski, PiotrX > ; gak...@marvell.com; De Lara Guarch, Pablo > ; m...@ashroe.eu > Subject: [PATCH v4 04/14] crypto/ipsec_mb: support ZUC-256 for aesni_mb > > Fro

Re: [dpdk-dev] [PATCH v4 05/14] test/crypto: check cipher parameters

2021-10-18 Thread Zhang, Roy Fan
> -Original Message- > From: Power, Ciara > Sent: Friday, October 15, 2021 3:40 PM > To: dev@dpdk.org > Cc: Zhang, Roy Fan ; Bronowski, PiotrX > ; gak...@marvell.com; De Lara Guarch, Pablo > ; m...@ashroe.eu; Doherty, Declan > > Subject: [PATCH v4 05/14] test/crypto: check cipher paramete

Re: [dpdk-dev] [PATCH v4 06/14] test/crypto: check auth parameters

2021-10-18 Thread Zhang, Roy Fan
> -Original Message- > From: Power, Ciara > Sent: Friday, October 15, 2021 3:40 PM > To: dev@dpdk.org > Cc: Zhang, Roy Fan ; Bronowski, PiotrX > ; gak...@marvell.com; De Lara Guarch, Pablo > ; m...@ashroe.eu; Doherty, Declan > > Subject: [PATCH v4 06/14] test/crypto: check auth parameters

Re: [dpdk-dev] [PATCH v4 09/14] drivers/crypto: move kasumi PMD to IPsec-mb framework

2021-10-18 Thread Zhang, Roy Fan
> -Original Message- > From: Power, Ciara > Sent: Friday, October 15, 2021 3:40 PM > To: dev@dpdk.org > Cc: Zhang, Roy Fan ; Bronowski, PiotrX > ; gak...@marvell.com; De Lara Guarch, Pablo > ; m...@ashroe.eu; Power, Ciara > ; Thomas Monjalon > Subject: [PATCH v4 09/14] drivers/crypto: mov

Re: [dpdk-dev] [PATCH v4 07/14] test/crypto: add ZUC-256 vectors

2021-10-18 Thread Zhang, Roy Fan
> -Original Message- > From: Power, Ciara > Sent: Friday, October 15, 2021 3:40 PM > To: dev@dpdk.org > Cc: Zhang, Roy Fan ; Bronowski, PiotrX > ; gak...@marvell.com; De Lara Guarch, Pablo > ; m...@ashroe.eu; Doherty, Declan > > Subject: [PATCH v4 07/14] test/crypto: add ZUC-256 vectors >

Re: [dpdk-dev] [PATCH v4 10/14] drivers/crypto: move snow3g PMD to IPsec-mb framework

2021-10-18 Thread Zhang, Roy Fan
> -Original Message- > From: Power, Ciara > Sent: Friday, October 15, 2021 3:40 PM > To: dev@dpdk.org > Cc: Zhang, Roy Fan ; Bronowski, PiotrX > ; gak...@marvell.com; De Lara Guarch, Pablo > ; m...@ashroe.eu; Power, Ciara > ; Thomas Monjalon > Subject: [PATCH v4 10/14] drivers/crypto: mov

Re: [dpdk-dev] [PATCH v4 08/14] drivers/crypto: move aesni-gcm PMD to IPsec-mb framework

2021-10-18 Thread Zhang, Roy Fan
> -Original Message- > From: Power, Ciara > Sent: Friday, October 15, 2021 3:40 PM > To: dev@dpdk.org > Cc: Zhang, Roy Fan ; Bronowski, PiotrX > ; gak...@marvell.com; De Lara Guarch, Pablo > ; m...@ashroe.eu; Power, Ciara > ; Thomas Monjalon > Subject: [PATCH v4 08/14] drivers/crypto: mov

Re: [dpdk-dev] [PATCH v4 11/14] crypto/ipsec_mb: add snow3g digest appended ops support

2021-10-18 Thread Zhang, Roy Fan
> -Original Message- > From: Power, Ciara > Sent: Friday, October 15, 2021 3:40 PM > To: dev@dpdk.org > Cc: Zhang, Roy Fan ; Bronowski, PiotrX > ; gak...@marvell.com; De Lara Guarch, Pablo > ; m...@ashroe.eu; Damian Nowak > ; Ji, Kai ; Power, Ciara > > Subject: [PATCH v4 11/14] crypto/ips

Re: [dpdk-dev] [PATCH v4 12/14] drivers/crypto: move zuc PMD to IPsec-mb framework

2021-10-18 Thread Zhang, Roy Fan
> -Original Message- > From: Power, Ciara > Sent: Friday, October 15, 2021 3:40 PM > To: dev@dpdk.org > Cc: Zhang, Roy Fan ; Bronowski, PiotrX > ; gak...@marvell.com; De Lara Guarch, Pablo > ; m...@ashroe.eu; Power, Ciara > ; Thomas Monjalon > Subject: [PATCH v4 12/14] drivers/crypto: mov

Re: [dpdk-dev] [PATCH v4 13/14] crypto/ipsec_mb: add chacha20-poly1305 PMD to framework

2021-10-18 Thread Zhang, Roy Fan
> -Original Message- > From: Power, Ciara > Sent: Friday, October 15, 2021 3:40 PM > To: dev@dpdk.org > Cc: Zhang, Roy Fan ; Bronowski, PiotrX > ; gak...@marvell.com; De Lara Guarch, Pablo > ; m...@ashroe.eu; Ji, Kai > ; Power, Ciara ; Thomas > Monjalon > Subject: [PATCH v4 13/14] crypto/

Re: [dpdk-dev] [PATCH v4 14/14] test/crypto: add test for chacha20_poly1305 PMD

2021-10-18 Thread Zhang, Roy Fan
> -Original Message- > From: Power, Ciara > Sent: Friday, October 15, 2021 3:40 PM > To: dev@dpdk.org > Cc: Zhang, Roy Fan ; Bronowski, PiotrX > ; gak...@marvell.com; De Lara Guarch, Pablo > ; m...@ashroe.eu; Ji, Kai > ; Power, Ciara ; Doherty, Declan > > Subject: [PATCH v4 14/14] test/cr

Re: [dpdk-dev] [EXT] Re: [Bug 828] [dpdk-21.11] zuc unit test is failing

2021-10-18 Thread David Marchand
On Fri, Oct 15, 2021 at 8:05 PM Akhil Goyal wrote: > > > Hello, > > > > On Fri, Oct 15, 2021 at 10:02 AM wrote: > > > > > > https://bugs.dpdk.org/show_bug.cgi?id=828 > > > > > > Bug ID: 828 > > >Summary: [dpdk-21.11] zuc unit test is failing > > >Product: DPDK

[dpdk-dev] [PATCH 1/2] common/cnxk: align CPT queue depth to power of 2

2021-10-18 Thread Anoob Joseph
Use CPT LF queue depth as power of 2 to aid in masked checks for pending queue. Signed-off-by: Anoob Joseph Acked-by: Jerin Jacob Kollanukkaran --- drivers/common/cnxk/roc_cpt.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/common/cnxk/roc_cpt.c b/drivers/common/cnxk/roc_cpt.c

[dpdk-dev] [PATCH 2/2] crypto/cnxk: rework pending queue

2021-10-18 Thread Anoob Joseph
Rework pending queue to allow producer and consumer cores to be different. Signed-off-by: Anoob Joseph --- doc/guides/cryptodevs/cnxk.rst| 6 --- drivers/crypto/cnxk/cn10k_cryptodev_ops.c | 36 +++--- drivers/crypto/cnxk/cn9k_cryptodev_ops.c | 63 ++-

Re: [dpdk-dev] [PATCH v2] net/virtio: handle Tx checksums correctly for tunnel packets

2021-10-18 Thread Olivier Matz
On Mon, Oct 18, 2021 at 10:04:46AM +0300, Andrew Rybchenko wrote: > On 10/15/21 11:32 AM, Olivier Matz wrote: > > On Thu, Oct 14, 2021 at 07:12:29AM +, Xia, Chenbo wrote: > >>> -Original Message- > >>> From: Ivan Malov > >>> Sent: Friday, September 17, 2021 2:50 AM > >>> To: dev@dpdk.o

Re: [dpdk-dev] [PATCH v7 12/12] raw/ioat: deprecate ioat rawdev driver

2021-10-18 Thread Thomas Monjalon
14/10/2021 11:49, Conor Walsh: > Deprecate the rawdev IOAT driver as both IOAT and IDXD drivers have > moved to dmadev. > > Signed-off-by: Conor Walsh > Acked-by: Kevin Laatz > Acked-by: Bruce Richardson > --- > --- a/doc/guides/rel_notes/deprecation.rst > +++ b/doc/guides/rel_notes/deprecation

Re: [dpdk-dev] [PATCH v2 1/1] net: fix aliasing issue in checksum computation

2021-10-18 Thread Olivier Matz
On Mon, Oct 18, 2021 at 09:35:41AM +0200, Morten Brørup wrote: > > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Georg Sauthoff > > Sent: Sunday, 17 October 2021 22.37 > > +Ferruh, as delegate to v1 in Patchwork. > > > > > That means a superfluous cast is removed and aliasing through a ui

Re: [dpdk-dev] [PATCH v2 2/4] mbuf: mark old VLAN offload flags as deprecated

2021-10-18 Thread Olivier Matz
Hi Andrew, On Sat, Oct 16, 2021 at 10:50:50AM +0300, Andrew Rybchenko wrote: > On 10/15/21 10:24 PM, Olivier Matz wrote: > > The flags PKT_TX_VLAN_PKT and PKT_TX_QINQ_PKT are > > marked as deprecated since commit 380a7aab1ae2 ("mbuf: rename deprecated > > VLAN flags") (2017). But they were not usi

Re: [dpdk-dev] [PATCH v2] net/virtio: handle Tx checksums correctly for tunnel packets

2021-10-18 Thread Andrew Rybchenko
On 10/18/21 10:54 AM, Olivier Matz wrote: > On Mon, Oct 18, 2021 at 10:04:46AM +0300, Andrew Rybchenko wrote: >> On 10/15/21 11:32 AM, Olivier Matz wrote: >>> On Thu, Oct 14, 2021 at 07:12:29AM +, Xia, Chenbo wrote: > -Original Message- > From: Ivan Malov > Sent: Friday, Se

[dpdk-dev] [PATCH] eventdev/rx_adapter: fix wrr buffer overrun issue

2021-10-18 Thread Naga Harish K S V
when a poll queue is removed from a rx_adapter instance, the wrr poll array is recomputed. The wrr array length is reduced in this case. The next wrr position to poll is stored in wrr_pos variable of rx_adapter instance. This wrr_pos can become invalid in some cases after wrr is recomputed. Using t

[dpdk-dev] [PATCH] eventdev/rx_adapter: fix wrr buffer overrun issue

2021-10-18 Thread Naga Harish K S V
when a poll queue is removed from a rx_adapter instance, the wrr poll array is recomputed. The wrr array length is reduced in this case. The next wrr position to poll is stored in wrr_pos variable of rx_adapter instance. This wrr_pos can become invalid in some cases after wrr is recomputed. Using t

[dpdk-dev] [PATCH] mempool: accept user flags only

2021-10-18 Thread David Marchand
As reported by Dmitry, MEMPOOL_F_POOL_CREATED is a flag only manipulated internally. This flag is not supposed to be requested from an application and would probably result in an incorrect behavior if an application did pass it. Other internal flags may be introduced later. Rework the check and e

[dpdk-dev] [PATCH v2] pipeline: add support for action annotations

2021-10-18 Thread Yogesh Jangra
Enable restricting the scope of an action to regular table entries or to the table default entry in order to support the P4 language tableonly or defaultonly annotations. Signed-off-by: Yogesh Jangra Acked-by: Cristian Dumitrescu --- lib/pipeline/rte_swx_ctl.c | 6 ++ lib/pipeli

Re: [dpdk-dev] [PATCH] mempool: accept user flags only

2021-10-18 Thread Olivier Matz
On Mon, Oct 18, 2021 at 10:26:35AM +0200, David Marchand wrote: > As reported by Dmitry, MEMPOOL_F_POOL_CREATED is a flag only manipulated > internally. > This flag is not supposed to be requested from an application and would > probably result in an incorrect behavior if an application did pass it

Re: [dpdk-dev] [PATCH] mempool: accept user flags only

2021-10-18 Thread Andrew Rybchenko
On 10/18/21 11:26 AM, David Marchand wrote: > As reported by Dmitry, MEMPOOL_F_POOL_CREATED is a flag only manipulated > internally. > This flag is not supposed to be requested from an application and would > probably result in an incorrect behavior if an application did pass it. > > Other interna

Re: [dpdk-dev] [PATCH 2/5] ethdev: add capability to keep shared objects on restart

2021-10-18 Thread Ferruh Yigit
On 10/16/2021 9:32 PM, Dmitry Kozlyuk wrote: -Original Message- From: Ferruh Yigit Sent: 15 октября 2021 г. 19:27 To: Dmitry Kozlyuk ; dev@dpdk.org; Andrew Rybchenko ; Ori Kam ; Raslan Darawsheh Cc: NBU-Contact-Thomas Monjalon ; Qi Zhang ; jer...@marvell.com; Maxime Coquelin Subject: R

Re: [dpdk-dev] [PATCH v6 1/6] ethdev: fix max Rx packet length

2021-10-18 Thread Ferruh Yigit
On 10/16/2021 1:24 AM, Ferruh Yigit wrote: On 10/12/2021 12:53 AM, Ferruh Yigit wrote: There is a confusion on setting max Rx packet length, this patch aims to clarify it. 'rte_eth_dev_configure()' API accepts max Rx packet size via 'uint32_t max_rx_pkt_len' field of the config struct 'struct r

Re: [dpdk-dev] [PATCH v2 1/5] ethdev: add capability to keep flow rules on restart

2021-10-18 Thread Andrew Rybchenko
On 10/15/21 7:18 PM, Dmitry Kozlyuk wrote: > Currently, it is not specified what happens to the flow rules when > the device is stopped, possibly reconfigured, then started. > If flow rules were kept, it could be convenient for application > developers, because they wouldn't need to save and restor

Re: [dpdk-dev] [PATCH] mempool: accept user flags only

2021-10-18 Thread Olivier Matz
On Mon, Oct 18, 2021 at 11:37:32AM +0300, Andrew Rybchenko wrote: > On 10/18/21 11:26 AM, David Marchand wrote: > > As reported by Dmitry, MEMPOOL_F_POOL_CREATED is a flag only manipulated > > internally. > > This flag is not supposed to be requested from an application and would > > probably resul

Re: [dpdk-dev] [PATCH] mempool: accept user flags only

2021-10-18 Thread Andrew Rybchenko
On 10/18/21 11:58 AM, Olivier Matz wrote: > On Mon, Oct 18, 2021 at 11:37:32AM +0300, Andrew Rybchenko wrote: >> On 10/18/21 11:26 AM, David Marchand wrote: >>> As reported by Dmitry, MEMPOOL_F_POOL_CREATED is a flag only manipulated >>> internally. >>> This flag is not supposed to be requested fro

Re: [dpdk-dev] [EXT] [PATCH v10 0/9] new features for ipsec and security libraries

2021-10-18 Thread Nicolau, Radu
On 10/17/2021 1:17 PM, Akhil Goyal wrote: Add support for: NAT-T/UDP encapsulation AES_CCM, CHACHA20_POLY1305 and AES_GMAC SA telemetry ESN with initial SQN value Signed-off-by: Declan Doherty Signed-off-by: Radu Nicolau Signed-off-by: Abhijit Sinha Signed-off-by: Daniel Martin Buckley Ra

Re: [dpdk-dev] [PATCH v7 00/13] add test suite for DMA drivers

2021-10-18 Thread Thomas Monjalon
13/10/2021 17:17, Bruce Richardson: > Bruce Richardson (10): > dmadev: add channel status check for testing use > dma/skeleton: add channel status function > dma/skeleton: add burst capacity function > dmadev: add device iterator > app/test: add basic dmadev instance tests > app/test: a

Re: [dpdk-dev] [PATCH v4 2/2] hash: unify crc32 selection for x86 and Arm

2021-10-18 Thread Ruifeng Wang
> -Original Message- > From: pbhagavat...@marvell.com > Sent: Monday, October 4, 2021 1:53 PM > To: Ruifeng Wang ; > konstantin.anan...@intel.com; jer...@marvell.com; Yipeng Wang > ; Sameh Gobriel ; > Bruce Richardson ; Vladimir Medvedkin > > Cc: dev@dpdk.org; Pavan Nikhilesh > Subject:

Re: [dpdk-dev] [PATCH v12 11/12] doc: changes for new pcapng and dumpcap

2021-10-18 Thread Pattan, Reshma
> -Original Message- > From: Stephen Hemminger > On Fri, 15 Oct 2021 16:42:19 + > "Pattan, Reshma" wrote: > > > > @@ -0,0 +1,24 @@ > > > +.. SPDX-License-Identifier: BSD-3-Clause > > > +Copyright(c) 2016 Intel Corporation. > > > > need to edit the licence > > Do you want me

[dpdk-dev] [PATCH v4 0/3] support PPPoL2TPv2oUDP RSS Hash

2021-10-18 Thread Jie Wang
Support IAVF PPPoL2TPv2oUDP RSS Hash. Required to distribute packets based on inner IP src+dest address and TCP/UDP src+dest port. --- v4: * update commit log. * redefine PPP protocol header. * delete l2tpv2_encap. v3: * add testpmd match ppp and l2tpv2 protocol header fields value. * add the

[dpdk-dev] [PATCH v4 1/3] ethdev: support PPP and L2TPV2 procotol

2021-10-18 Thread Jie Wang
Added flow pattern items and header formats of L2TPv2 and PPP. Signed-off-by: Wenjun Wu Signed-off-by: Jie Wang --- doc/guides/prog_guide/rte_flow.rst | 25 +++ doc/guides/rel_notes/release_21_11.rst | 5 + lib/ethdev/rte_flow.c | 2 + lib/ethdev/rte_flow.h

[dpdk-dev] [PATCH v4 2/3] net/iavf: support PPPoL2TPv2oUDP RSS Hash

2021-10-18 Thread Jie Wang
Add support for PPP over L2TPv2 over UDP protocol RSS Hash based on inner IP src/dst address and TCP/UDP src/dst port. Patterns are listed below: eth/ipv4(6)/udp/l2tpv2/ppp/ipv4(6) eth/ipv4(6)/udp/l2tpv2/ppp/ipv4(6)/udp eth/ipv4(6)/udp/l2tpv2/ppp/ipv4(6)/tcp Signed-off-by: Wenjun Wu Signed-off-b

[dpdk-dev] [PATCH v4 3/3] app/testpmd: support L2TPV2 and PPP protocol pattern

2021-10-18 Thread Jie Wang
Add support for test-pmd to parse protocol pattern L2TPv2 and PPP. Signed-off-by: Wenjun Wu Signed-off-by: Jie Wang --- app/test-pmd/cmdline_flow.c | 251 1 file changed, 251 insertions(+) diff --git a/app/test-pmd/cmdline_flow.c b/app/test-pmd/cmdline_flow

[dpdk-dev] [PATCH] devtools: fix letter case check in commit title

2021-10-18 Thread Thomas Monjalon
The prefix (before the colon) of the title is lowercase. The check of uppercase/lowercase in the commit title was supposed to apply after the colon, but some greps were not limited to the exact word. So in the case of "test/dma: add basic dmadev instance tests", the lowercase word "dmadev" was wron

[dpdk-dev] [PATCH v7 0/4] net/mlx5: implicit mempool registration

2021-10-18 Thread Dmitry Kozlyuk
MLX5 hardware has its internal IOMMU where PMD registers the memory. On the data path, PMD translates VA into a key consumed by the device IOMMU. It is impractical for the PMD to register all allocated memory because of increased lookup cost both in HW and SW. Most often mbuf memory comes from me

[dpdk-dev] [PATCH v7 1/4] mempool: add event callbacks

2021-10-18 Thread Dmitry Kozlyuk
Data path performance can benefit if the PMD knows which memory it will need to handle in advance, before the first mbuf is sent to the PMD. It is impractical, however, to consider all allocated memory for this purpose. Most often mbuf memory comes from mempools that can come and go. PMD can enumer

[dpdk-dev] [PATCH v7 2/4] mempool: add non-IO flag

2021-10-18 Thread Dmitry Kozlyuk
Mempool is a generic allocator that is not necessarily used for device IO operations and its memory for DMA. Add MEMPOOL_F_NON_IO flag to mark such mempools automatically a) if their objects are not contiguous; b) if IOVA is not available for any object. Other components can inspect this flag in or

[dpdk-dev] [PATCH v7 3/4] common/mlx5: add mempool registration facilities

2021-10-18 Thread Dmitry Kozlyuk
Add internal API to register mempools, that is, to create memory regions (MR) for their memory and store them in a separate database. Implementation deals with multi-process, so that class drivers don't need to. Each protection domain has its own database. Memory regions can be shared within a data

[dpdk-dev] [PATCH v7 4/4] net/mlx5: support mempool registration

2021-10-18 Thread Dmitry Kozlyuk
When the first port in a given protection domain (PD) starts, install a mempool event callback for this PD and register all existing memory regions (MR) for it. When the last port in a PD closes, remove the callback and unregister all mempools for this PD. This behavior can be switched off with a n

Re: [dpdk-dev] [PATCH 02/10] vdpa/sfc: add support for device initialization

2021-10-18 Thread Vijay Kumar Srivastava
Hi Chenbo, >-Original Message- >From: Xia, Chenbo >Sent: Saturday, October 9, 2021 8:36 AM >To: Vijay Kumar Srivastava ; dev@dpdk.org >Cc: maxime.coque...@redhat.com; andrew.rybche...@oktetlabs.ru; Harpreet >Singh Anand ; Praveen Kumar Jain >Subject: RE: [PATCH 02/10] vdpa/sfc: add suppo

[dpdk-dev] [PATCH v3] usertools/telemetry: add list of available file-prefixes

2021-10-18 Thread Conor Walsh
This patch adds the option --list (-l) to dpdk-telemetry.py which will print all of the available dpdk file-prefixes that have telemetry enabled. The prefixes will also be printed if the user passes an incorrect prefix in the --file-prefix (-f) option. Signed-off-by: Conor Walsh Acked-by: Ciara P

Re: [dpdk-dev] [PATCH] app/testpmd: fix l4 sw csum over multi segments

2021-10-18 Thread Ananyev, Konstantin
> > > + /* When sw csum is needed, multi-segs needs a buf to contain > > > + * the whole packet for later UDP/TCP csum calculation. > > > + */ > > > + if (m->nb_segs > 1 && !(tx_ol_flags & PKT_TX_TCP_SEG) && > > > + !(tx_offloads & UDP_TCP_CSUM)) { >

[dpdk-dev] [PATCH v5 0/5] Virtio PMD RSS support & RSS fixes

2021-10-18 Thread Maxime Coquelin
This series is mainly adding support for RSS to Virtio PMD driver. The two last patches are fixing an issue in testpmd that could cause out of bounds access, and fix an issue spotted in the mlx5 driver while looking for inspiration. The first motivation for this series is to eventually support RSS

[dpdk-dev] [PATCH v5 1/5] net/virtio: add initial RSS support

2021-10-18 Thread Maxime Coquelin
Provide the capability to update the hash key, hash types and RETA table on the fly (without needing to stop/start the device). However, the key length and the number of RETA entries are fixed to 40B and 128 entries respectively. This is done in order to simplify the design, but may be revisited la

[dpdk-dev] [PATCH v5 2/5] app/testpmd: fix RSS key length

2021-10-18 Thread Maxime Coquelin
port_rss_hash_key_update() initializes rss_conf with the RSS key configuration provided by the user, but it calls rte_eth_dev_rss_hash_conf_get() before calling rte_eth_dev_rss_hash_update(), which overrides the parsed RSS config. While the RSS key value is set again after, this is not the case o

[dpdk-dev] [PATCH v5 3/5] app/testpmd: fix RSS type display

2021-10-18 Thread Maxime Coquelin
This patch fixes the display of the RSS hash types configured in the port, which displayed "all" even if only a single type was configured Fixes: 3c90743dd3b9 ("app/testpmd: support more types for flow RSS") Cc: sta...@dpdk.org Signed-off-by: Maxime Coquelin Acked-by: Xiaoyun Li Reviewed-by: Ch

[dpdk-dev] [PATCH v5 4/5] net/mlx5: fix RSS RETA update

2021-10-18 Thread Maxime Coquelin
This patch fixes RETA updating for entries above 64. Without ithat, these entries are never updated as calculated mask value will always be 0. Fixes: 634efbc2c8c0 ("mlx5: support RETA query and update") Cc: sta...@dpdk.org Cc: nelio.laranje...@6wind.com Signed-off-by: Maxime Coquelin Acked-by: V

[dpdk-dev] [PATCH v5 5/5] app/testpmd: add missing flow types in port info

2021-10-18 Thread Maxime Coquelin
This patch adds missing IPv6-Ex and GTPU flow types to port info command. It also add the same definitions to str2flowtype(), used to configure flow director. Signed-off-by: Maxime Coquelin Acked-by: Xiaoyun Li --- app/test-pmd/cmdline.c | 4 app/test-pmd/config.c | 4 2 files change

[dpdk-dev] [PATCH v9 0/7] iavf: add iAVF IPsec inline crypto support

2021-10-18 Thread Radu Nicolau
Add support for inline crypto for IPsec, for ESP transport and tunnel over IPv4 and IPv6, as well as supporting the offload for ESP over UDP, and inconjunction with TSO for UDP and TCP flows. Depends on series "new features for ipsec and security libraries" https://patchwork.dpdk.org/project/dpdk/

[dpdk-dev] [PATCH v9 1/7] common/iavf: add iAVF IPsec inline crypto support

2021-10-18 Thread Radu Nicolau
Add support for inline crypto for IPsec. Signed-off-by: Declan Doherty Signed-off-by: Abhijit Sinha Signed-off-by: Radu Nicolau --- drivers/common/iavf/iavf_type.h | 1 + drivers/common/iavf/virtchnl.h | 17 +- drivers/common/iavf/virtchnl_inline_ipsec.h | 553 +

[dpdk-dev] [PATCH v9 2/7] net/iavf: rework tx path

2021-10-18 Thread Radu Nicolau
Rework the TX path and TX descriptor usage in order to allow for better use of oflload flags and to facilitate enabling of inline crypto offload feature. Signed-off-by: Declan Doherty Signed-off-by: Abhijit Sinha Signed-off-by: Radu Nicolau Acked-by: Jingjing Wu --- drivers/net/iavf/iavf_rxtx

[dpdk-dev] [PATCH v9 3/7] net/iavf: add support for asynchronous virt channel messages

2021-10-18 Thread Radu Nicolau
Add support for asynchronous virtual channel messages, specifically for inline IPsec messages. Signed-off-by: Declan Doherty Signed-off-by: Abhijit Sinha Signed-off-by: Radu Nicolau Acked-by: Jingjing Wu --- drivers/net/iavf/iavf.h | 16 drivers/net/iavf/iavf_vchnl.c | 138 +++

[dpdk-dev] [PATCH v9 4/7] net/iavf: add iAVF IPsec inline crypto support

2021-10-18 Thread Radu Nicolau
Add support for inline crypto for IPsec, for ESP transport and tunnel over IPv4 and IPv6, as well as supporting the offload for ESP over UDP, and inconjunction with TSO for UDP and TCP flows. Implement support for rte_security packet metadata Add definition for IPsec descriptors, extend support fo

[dpdk-dev] [PATCH v9 5/7] net/iavf: add xstats support for inline IPsec crypto

2021-10-18 Thread Radu Nicolau
Add per queue counters for maintaining statistics for inline IPsec crypto offload, which can be retrieved through the rte_security_session_stats_get() with more detailed errors through the rte_ethdev xstats. Signed-off-by: Declan Doherty Signed-off-by: Radu Nicolau Acked-by: Jingjing Wu --- dr

[dpdk-dev] [PATCH v9 6/7] net/iavf: add watchdog for VFLR

2021-10-18 Thread Radu Nicolau
Add watchdog to iAVF PMD which support monitoring the VFLR register. If the device is not already in reset then if a VF reset in progress is detected then notfiy user through callback and set into reset state. If the device is already in reset then poll for completion of reset. The watchdog is dis

[dpdk-dev] [PATCH v9 7/7] net/iavf: update doc with inline crypto support

2021-10-18 Thread Radu Nicolau
Update the PMD doc, feature matrix and release notes with the new inline crypto feature. Signed-off-by: Radu Nicolau --- doc/guides/nics/features/iavf.ini | 2 ++ doc/guides/nics/intel_vf.rst | 10 ++ doc/guides/rel_notes/release_21_11.rst | 1 + 3 files changed, 13 inse

[dpdk-dev] Minutes of Technical Board Meeting, 2021-Oct-06

2021-10-18 Thread Kevin Traynor
Minutes of Technical Board Meeting, 2021-Oct-06 Members Attending - -Aaron -Bruce -Ferruh -Hemant -Honnappa -Jerin -Kevin (Chair) -Konstantin -Maxime -Olivier -Stephen -Thomas NOTE: The technical board meetings every second Wednesday at https://meet.jit.si/DPDK at 3 pm UTC. Meeti

Re: [dpdk-dev] [PATCH v7 02/16] dma/idxd: add skeleton for VFIO based DSA device

2021-10-18 Thread Thomas Monjalon
13/10/2021 18:30, Kevin Laatz: > Add the basic device probe/remove skeleton code for DSA device bound to > the vfio pci driver. Relevant documentation and MAINTAINERS update also > included. It seems there is a compilation issue with this patch: undefined reference to `idxd_pmd_logtype' P

[dpdk-dev] [PATCH] usertools/telemetry: fix instance help text

2021-10-18 Thread Conor Walsh
The instance option help text was incorrect, this patch corrects it. Fixes: 11435aae2089 ("usertools/telemetry: connect to separate instances") Signed-off-by: Conor Walsh --- usertools/dpdk-telemetry.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/usertools/dpdk-telemetry

Re: [dpdk-dev] [PATCH v2 1/5] hash: add new toeplitz hash implementation

2021-10-18 Thread Ananyev, Konstantin
> On Fri, 15 Oct 2021 10:30:02 +0100 > Vladimir Medvedkin wrote: > > > + m[i * 8 + j] = (rss_key[i] << j)| > > + (uint8_t)((uint16_t)(rss_key[i + 1]) >> > > + (8 - j)); > > + } > > This ends up being harder than ne

[dpdk-dev] [PATCH v4 0/7] IPsec Sec GW new features

2021-10-18 Thread Radu Nicolau
Update the IPsec sample app with new features and updates: - telemetry support - add reset callback - stats screen configurable as a command line parameter - UDP encapsulation support for inline crypto - ESN with configurable start value Radu Nicolau (7): examples/ipsec-secgw: add stats interva

[dpdk-dev] [PATCH v4 1/7] examples/ipsec-secgw: add stats interval argument

2021-10-18 Thread Radu Nicolau
Add -t for stats screen update interval, disabled by default. Signed-off-by: Radu Nicolau Acked-by: Hemant Agrawal Acked-by: Anoob Joseph --- doc/guides/sample_app_ug/ipsec_secgw.rst | 5 examples/ipsec-secgw/ipsec-secgw.c | 29 examples/ipsec-secgw/ipsec-s

[dpdk-dev] [PATCH v4 2/7] examples/ipsec-secgw: update create inline session

2021-10-18 Thread Radu Nicolau
Rework create inline session function as to update the session configuration parameters before create session is called. Also updated the rss key array size to prevent buffers overflows with PMDs that copy more than 40 bytes. Signed-off-by: Radu Nicolau Acked-by: Akhil Goyal --- examples/ipsec-

[dpdk-dev] [PATCH v4 3/7] examples/ipsec-secgw: add support for inline crypto UDP encapsulation

2021-10-18 Thread Radu Nicolau
Enable UDP encapsulation for both transport and tunnel modes for the inline crypto offload path. Signed-off-by: Radu Nicolau --- doc/guides/sample_app_ug/ipsec_secgw.rst | 3 ++- examples/ipsec-secgw/ipsec.c | 33 +--- examples/ipsec-secgw/ipsec.h |

[dpdk-dev] [PATCH v4 4/7] examples/ipsec-secgw: support telemetry

2021-10-18 Thread Radu Nicolau
Add telemetry support to the IPsec GW sample app and add support for per SA telemetry when using IPsec library. Signed-off-by: Declan Doherty Signed-off-by: Radu Nicolau --- doc/guides/rel_notes/release_21_11.rst | 4 + doc/guides/sample_app_ug/ipsec_secgw.rst | 11 + examples/ipsec-secgw/

[dpdk-dev] [PATCH v4 5/7] examples/ipsec-secgw: define initial ESN value

2021-10-18 Thread Radu Nicolau
New option added to the SA configuration arguments that allows setting an arbitrary start value for ESN. For example in the SA below ESN will be enabled and first egress IPsec packet will have the ESN value 1: sa out 15 cipher_algo null auth_algo null mode ipv4-tunnel \ src 172.16.1.5 dst 172

[dpdk-dev] [PATCH v4 6/7] examples/ipsec-secgw: add ethdev reset callback

2021-10-18 Thread Radu Nicolau
Applications should not quietly ignore an ethdev reset event. Register an event handler for ethdev reset callback RTE_ETH_EVENT_INTR_RESET that prints a message and quits the application. Signed-off-by: Declan Doherty Signed-off-by: Radu Nicolau --- examples/ipsec-secgw/ipsec-secgw.c | 14 +

[dpdk-dev] [PATCH v4 7/7] examples/ipsec-secgw: add support for additional algorithms

2021-10-18 Thread Radu Nicolau
Add support for AES-GMAC, AES_CTR, AES_XCBC_MAC, AES_CCM, CHACHA20_POLY1305 Signed-off-by: Declan Doherty Signed-off-by: Radu Nicolau --- doc/guides/rel_notes/release_21_11.rst | 2 + doc/guides/sample_app_ug/ipsec_secgw.rst | 3 +- examples/ipsec-secgw/ipsec.h | 3 +- examp

Re: [dpdk-dev] [PATCH v7 02/16] dma/idxd: add skeleton for VFIO based DSA device

2021-10-18 Thread Kevin Laatz
On 18/10/2021 11:32, Thomas Monjalon wrote: 13/10/2021 18:30, Kevin Laatz: Add the basic device probe/remove skeleton code for DSA device bound to the vfio pci driver. Relevant documentation and MAINTAINERS update also included. It seems there is a compilation issue with this patch: und

Re: [dpdk-dev] [PATCH v6 1/5] ethdev: introduce shared Rx queue

2021-10-18 Thread Xueming(Steven) Li
On Mon, 2021-10-18 at 09:46 +0300, Andrew Rybchenko wrote: > On 10/15/21 1:54 PM, Xueming(Steven) Li wrote: > > On Fri, 2021-10-15 at 12:28 +0300, Andrew Rybchenko wrote: > > > On 10/12/21 5:39 PM, Xueming Li wrote: > > > > In current DPDK framework, each Rx queue is pre-loaded with mbufs to > > >

Re: [dpdk-dev] [PATCH] usertools/telemetry: fix instance help text

2021-10-18 Thread Bruce Richardson
On Mon, Oct 18, 2021 at 10:39:29AM +, Conor Walsh wrote: > The instance option help text was incorrect, this patch corrects it. > > Fixes: 11435aae2089 ("usertools/telemetry: connect to separate instances") > > Signed-off-by: Conor Walsh > --- > usertools/dpdk-telemetry.py | 2 +- > 1 file

Re: [dpdk-dev] [PATCH v2 1/5] hash: add new toeplitz hash implementation

2021-10-18 Thread Medvedkin, Vladimir
Hi Stephen, Thanks for reviewing On 15/10/2021 18:58, Stephen Hemminger wrote: On Fri, 15 Oct 2021 10:30:02 +0100 Vladimir Medvedkin wrote: + m[i * 8 + j] = (rss_key[i] << j)| + (uint8_t)((uint16_t)(rss_key[i + 1]) >> +

Re: [dpdk-dev] [PATCH] eventdev/rx_adapter: fix wrr buffer overrun issue

2021-10-18 Thread Jayatheerthan, Jay
Acked-by: Jay Jayatheerthan > -Original Message- > From: Naga Harish K, S V > Sent: Monday, October 18, 2021 1:56 PM > To: jer...@marvell.com; Jayatheerthan, Jay > Cc: dev@dpdk.org > Subject: [PATCH] eventdev/rx_adapter: fix wrr buffer overrun issue > > when a poll queue is removed fro

Re: [dpdk-dev] [PATCH 2/5] ethdev: add capability to keep shared objects on restart

2021-10-18 Thread Dmitry Kozlyuk
> -Original Message- > From: Ferruh Yigit > Sent: 18 октября 2021 г. 11:42 > To: Dmitry Kozlyuk ; dev@dpdk.org; Andrew Rybchenko > ; Ori Kam ; Raslan > Darawsheh ; NBU-Contact-Thomas Monjalon > > Cc: Qi Zhang ; jer...@marvell.com; Maxime Coquelin > > Subject: Re: [PATCH 2/5] ethdev: add

Re: [dpdk-dev] [PATCH v2 2/4] mbuf: mark old VLAN offload flags as deprecated

2021-10-18 Thread Somnath Kotur
On Mon, Oct 18, 2021 at 1:40 PM Olivier Matz wrote: > > Hi Andrew, > > On Sat, Oct 16, 2021 at 10:50:50AM +0300, Andrew Rybchenko wrote: > > On 10/15/21 10:24 PM, Olivier Matz wrote: > > > The flags PKT_TX_VLAN_PKT and PKT_TX_QINQ_PKT are > > > marked as deprecated since commit 380a7aab1ae2 ("mbuf

Re: [dpdk-dev] [PATCH v2 4/4] mbuf: add rte prefix to offload flags

2021-10-18 Thread Somnath Kotur
On Sun, Oct 17, 2021 at 8:16 PM Ajit Khaparde wrote: > > On Sat, Oct 16, 2021 at 12:57 AM Andrew Rybchenko > wrote: > > > > On 10/15/21 10:24 PM, Olivier Matz wrote: > > > Fix the mbuf offload flags namespace by adding an RTE_ prefix to the > > > name. The old flags remain usable, but a deprecati

Re: [dpdk-dev] [PATCH] net/enic: fix build with GCC 7.5

2021-10-18 Thread Ferruh Yigit
On 10/15/2021 12:16 PM, David Marchand wrote: On Fri, Oct 15, 2021 at 12:28 PM Ferruh Yigit wrote: Build error: ../drivers/net/enic/enic_fm_flow.c: In function 'enic_fm_flow_parse': ../drivers/net/enic/enic_fm_flow.c:1467:24: error: 'dev' may be used uninitialized in this function

Re: [dpdk-dev] [PATCH 2/5] ethdev: add capability to keep shared objects on restart

2021-10-18 Thread Ferruh Yigit
On 10/18/2021 12:13 PM, Dmitry Kozlyuk wrote: -Original Message- From: Ferruh Yigit Sent: 18 октября 2021 г. 11:42 To: Dmitry Kozlyuk ; dev@dpdk.org; Andrew Rybchenko ; Ori Kam ; Raslan Darawsheh ; NBU-Contact-Thomas Monjalon Cc: Qi Zhang ; jer...@marvell.com; Maxime Coquelin Subject:

Re: [dpdk-dev] [PATCH] mempool: accept user flags only

2021-10-18 Thread David Marchand
On Mon, Oct 18, 2021 at 11:05 AM Andrew Rybchenko wrote: > >>> +/** > >>> + * This macro lists all the mempool flags an application may request. > >>> + */ > >>> +#define MEMPOOL_VALID_USER_FLAGS (MEMPOOL_F_NO_SPREAD \ > >> > >> I think RTE_ prefix is missing here since it is in a public > >> head

Re: [dpdk-dev] [PATCH v10 3/4] pipeline: Fix compilation error with gcc ASan

2021-10-18 Thread Dumitrescu, Cristian
> -Original Message- > From: Peng, ZhihongX > Sent: Friday, October 15, 2021 4:11 PM > To: david.march...@redhat.com; Burakov, Anatoly > ; Ananyev, Konstantin > ; step...@networkplumber.org; > Dumitrescu, Cristian ; Mcnamara, John > > Cc: dev@dpdk.org; Lin, Xueqin ; Peng, ZhihongX > ;

[dpdk-dev] [PATCH v8 00/16] add dmadev driver for idxd devices

2021-10-18 Thread Kevin Laatz
This patchset adds a dmadev driver and associated documentation to support Intel Data Streaming Accelerator devices. This driver is intended to ultimately replace the current IDXD part of the IOAT rawdev driver. v8: * fix compilation issues of individual patches v7: * rebase on above patchsets

[dpdk-dev] [PATCH v8 01/16] raw/ioat: only build if dmadev not present

2021-10-18 Thread Kevin Laatz
From: Bruce Richardson Only build the rawdev IDXD/IOAT drivers if the dmadev drivers are not present. This change requires the dependencies to be reordered in drivers/meson.build so that rawdev can use the "RTE_DMA_* build macros to check for the presence of the equivalent dmadev driver. A note

[dpdk-dev] [PATCH v8 02/16] dma/idxd: add skeleton for VFIO based DSA device

2021-10-18 Thread Kevin Laatz
Add the basic device probe/remove skeleton code for DSA device bound to the vfio pci driver. Relevant documentation and MAINTAINERS update also included. Signed-off-by: Bruce Richardson Signed-off-by: Kevin Laatz Reviewed-by: Conor Walsh --- v8: fix compile issue --- MAINTAINERS

[dpdk-dev] [PATCH v8 03/16] dma/idxd: add bus device probing

2021-10-18 Thread Kevin Laatz
Add the basic device probing for DSA devices bound to the IDXD kernel driver. These devices can be configured via sysfs and made available to DPDK if they are found during bus scan. Relevant documentation is included. Signed-off-by: Bruce Richardson Signed-off-by: Kevin Laatz Reviewed-by: Conor

[dpdk-dev] [PATCH v8 04/16] dma/idxd: create dmadev instances on bus probe

2021-10-18 Thread Kevin Laatz
When a suitable device is found during the bus scan/probe, create a dmadev instance for each HW queue. Internal structures required for device creation are also added. Signed-off-by: Bruce Richardson Signed-off-by: Kevin Laatz Reviewed-by: Conor Walsh --- drivers/dma/idxd/idxd_bus.c | 19

[dpdk-dev] [PATCH v8 05/16] dma/idxd: create dmadev instances on pci probe

2021-10-18 Thread Kevin Laatz
When a suitable device is found during the PCI probe, create a dmadev instance for each HW queue. HW definitions required are also included. Signed-off-by: Bruce Richardson Signed-off-by: Kevin Laatz Reviewed-by: Conor Walsh --- drivers/dma/idxd/idxd_hw_defs.h | 63 drivers/dma/idxd

[dpdk-dev] [PATCH v8 06/16] dma/idxd: add datapath structures

2021-10-18 Thread Kevin Laatz
Add data structures required for the data path for IDXD devices. Signed-off-by: Bruce Richardson Signed-off-by: Kevin Laatz Reviewed-by: Conor Walsh --- drivers/dma/idxd/idxd_bus.c | 1 + drivers/dma/idxd/idxd_common.c | 33 + drivers/dma/idxd/idxd_hw_defs.h |

  1   2   3   >