Re: [dpdk-dev] [PATCH] doc: remove deprecation notice for vhost

2021-11-03 Thread David Marchand
On Wed, Nov 3, 2021 at 6:25 AM Xia, Chenbo wrote: > > Hi, > > I notice that from the start, I should not send the notice.. as the abi > policy said: > > For removing the experimental tag associated with an API, deprecation notice > is not required. > > Sorry for the mistake. It is not required,

Re: [dpdk-dev] [PATCH] common/cnxk: fix device MSIX greater than default value

2021-11-03 Thread David Marchand
On Mon, Nov 1, 2021 at 6:44 PM Harman Kalra wrote: > > Handling the case where number of MSIX interrupts are greater > than default value i.e. PLT_MAX_RXTX_INTR_VEC_ID. On PCI probe > device is queried for supported MSIX interrupts, and respective > interrupt resources are reallocated with this va

[dpdk-dev] [PATCH v2] common/cnxk: fix device MSIX greater than default value

2021-11-03 Thread Harman Kalra
Handling the case where number of MSIX interrupts are greater than default value i.e. PLT_MAX_RXTX_INTR_VEC_ID. On PCI probe device is queried for supported MSIX interrupts, and respective interrupt resources are reallocated with this value. Same MSIX count should be used while registering new inte

Re: [dpdk-dev] Question about RSS offload types

2021-11-03 Thread Thomas Monjalon
03/11/2021 02:35, lihuisong (C): > Below macros are defined for RSS offload types in rte_ethdev.h. > > #define *ETH_RSS_IPV4 * (1ULL << 2) > #define ETH_RSS_FRAG_IPV4 (1ULL << 3) > #define ETH_RSS_NONFRAG_IPV4_TCP (1ULL << 4) > #define ETH_RSS_NONFRAG_IPV4_UDP (1ULL << 5)

Re: [dpdk-dev] [PATCH v4] examples/vhost: fix failure to launch dpdk-vhost

2021-11-03 Thread Maxime Coquelin
Hi Chenbo, On 11/3/21 05:58, Xia, Chenbo wrote: Hi, -Original Message- From: Ma, WenwuX Sent: Wednesday, November 3, 2021 10:17 PM To: dev@dpdk.org Cc: maxime.coque...@redhat.com; Xia, Chenbo ; Yigit, Ferruh ; Jiang, Cheng1 ; Hu, Jiayu ; Yang, YvonneX ; Ma, WenwuX ; sta...@dpdk.org Su

Re: [dpdk-dev] [PATCH] doc: remove deprecation notice for vhost

2021-11-03 Thread Maxime Coquelin
On 11/3/21 06:00, Chenbo Xia wrote: Ten vhost APIs were announced to be stable and promoted in below commit, so remove the related deprecation notice. Fixes: 945ef8a04098 ("vhost: promote some APIs to stable") Signed-off-by: Chenbo Xia Reported-by: Maxime Coquelin --- doc/guides/rel_note

Re: [dpdk-dev] [PATCH] vhost: rename driver callbacks struct

2021-11-03 Thread Xia, Chenbo
Hi Maxime, > -Original Message- > From: Maxime Coquelin > Sent: Tuesday, November 2, 2021 6:48 PM > To: dev@dpdk.org; Xia, Chenbo ; > david.march...@redhat.com > Cc: Maxime Coquelin > Subject: [PATCH] vhost: rename driver callbacks struct > > As previously announced, this patch renames

Re: [dpdk-dev] [PATCH] vhost: rename driver callbacks struct

2021-11-03 Thread David Marchand
On Wed, Nov 3, 2021 at 9:16 AM Xia, Chenbo wrote: > Testing issues reported in patchwork is expected as SPDK uses > this struct, so we can ignore it as SPDK will rename it when it > adapts to DPDK 21.11 Please, no. We can't simply say "ignore failure in CI". The SPDK build test must be disabled

Re: [dpdk-dev] [PATCH] vhost: rename driver callbacks struct

2021-11-03 Thread Maxime Coquelin
Hi David, On 11/3/21 09:36, David Marchand wrote: On Wed, Nov 3, 2021 at 9:16 AM Xia, Chenbo wrote: Testing issues reported in patchwork is expected as SPDK uses this struct, so we can ignore it as SPDK will rename it when it adapts to DPDK 21.11 Please, no. We can't simply say "ignore failu

Re: [dpdk-dev] [PATCH] vhost: add vDPA resource cleanup callback

2021-11-03 Thread Xia, Chenbo
Hi Xueming, > -Original Message- > From: Xueming(Steven) Li > Sent: Thursday, October 21, 2021 8:36 PM > To: maxime.coque...@redhat.com; dev@dpdk.org > Cc: Xia, Chenbo > Subject: Re: [PATCH] vhost: add vDPA resource cleanup callback > > On Thu, 2021-10-21 at 14:00 +0200, Maxime Coquelin

Re: [dpdk-dev] [PATCH] vhost: add vDPA resource cleanup callback

2021-11-03 Thread Maxime Coquelin
On 11/3/21 09:41, Xia, Chenbo wrote: Hi Xueming, -Original Message- From: Xueming(Steven) Li Sent: Thursday, October 21, 2021 8:36 PM To: maxime.coque...@redhat.com; dev@dpdk.org Cc: Xia, Chenbo Subject: Re: [PATCH] vhost: add vDPA resource cleanup callback On Thu, 2021-10-21 at 1

Re: [dpdk-dev] [PATCH] ethdev: mark old macros as deprecated

2021-11-03 Thread Ferruh Yigit
On 11/3/2021 12:05 AM, Stephen Hemminger wrote: On Tue, 2 Nov 2021 23:44:34 + Ferruh Yigit wrote: Old macros kept for backward compatibility, but this cause old macro usage to sneak in silently. Marking old macros as deprecated. Downside is this will cause some noise for applications tha

Re: [dpdk-dev] [PATCH] vhost: rename driver callbacks struct

2021-11-03 Thread Xia, Chenbo
Hi David, > -Original Message- > From: David Marchand > Sent: Wednesday, November 3, 2021 4:36 PM > To: Xia, Chenbo ; Maxime Coquelin > > Cc: dev@dpdk.org; Liu, Changpeng ; Thomas Monjalon > ; Aaron Conole ; dpdklab > ; c...@dpdk.org > Subject: Re: [PATCH] vhost: rename driver callbacks

Re: [dpdk-dev] [EXT] [PATCH v6 1/7] examples/ipsec-secgw: add stats interval argument

2021-11-03 Thread Akhil Goyal
> -#if (STATS_INTERVAL > 0) > struct ipsec_core_statistics { > uint64_t tx; > uint64_t rx; > @@ -94,7 +90,6 @@ struct ipsec_core_statistics { > } __rte_cache_aligned; > > struct ipsec_core_statistics core_statistics[RTE_MAX_LCORE]; > -#endif /* STATS_INTERVAL */ Did you check compil

Re: [dpdk-dev] [PATCH v2] test/crypto: fix: test vectors for zuc 256 bit key

2021-11-03 Thread De Lara Guarch, Pablo
Hi Sagar, > -Original Message- > From: dev On Behalf Of Vidya Sagar Velumuri > Sent: Wednesday, November 3, 2021 6:55 AM > To: adwiv...@marvell.com; ano...@marvell.com; ktejas...@marvell.com; > ndabilpu...@marvell.com; gak...@marvell.com; Zhang, Roy Fan > > Cc: dev@dpdk.org > Subject: [d

[dpdk-dev] [PATCH v3] test/crypto: fix: test vectors for zuc 256 bit key

2021-11-03 Thread Vidya Sagar Velumuri
Fix the test vectors added for zuc 256-bit key Add known vectors form ZUC 256 RFC. Fixes: fa5bf9345d4e (test/crypto: add ZUC cases with 256-bit keys) Signed-off-by: Vidya Sagar Velumuri v3: * Fixed spell check diff --git a/app/test/test_cryptodev.c b/app/test/test_cryptodev.c index 814a0b401d..

[dpdk-dev] [PATCH v4] net/af_packet: fix ignoring full ring on tx

2021-11-03 Thread Tudor Cornea
The poll call can return POLLERR which is ignored, or it can return POLLOUT, even if there are no free frames in the mmap-ed area. We can account for both of these cases by re-checking if the next frame is empty before writing into it. We have attempted to reproduce this issue with pktgen-dpdk, u

Re: [dpdk-dev] [PATCH v13 1/4] enable ASan AddressSanitizer

2021-11-03 Thread Lin, Xueqin
> -Original Message- > From: David Marchand > Sent: Wednesday, November 3, 2021 1:29 AM > To: Lin, Xueqin > Cc: Peng, ZhihongX ; Thomas Monjalon > ; Burakov, Anatoly ; > Ananyev, Konstantin ; Stephen Hemminger > ; Dumitrescu, Cristian > ; Mcnamara, John > ; Richardson, Bruce > ; dev ; Che

Re: [dpdk-dev] [PATCH v1] examples/flow_filtering: fix wrong comment

2021-11-03 Thread Walsh, Conor
> From: Joyce Kong > Sent: Wednesday 3 November 2021 02:41 > To: Ori Kam ; Mcnamara, John > ; Walsh, Conor ; > Conor Fogarty > Cc: dev@dpdk.org; n...@arm.com; sta...@dpdk.org > Subject: [PATCH v1] examples/flow_filtering: fix wrong comment > > Change the 'IPV4' level to 'ETH' level in the commen

Re: [dpdk-dev] [PATCH v13 1/4] enable ASan AddressSanitizer

2021-11-03 Thread David Marchand
On Wed, Nov 3, 2021 at 10:36 AM Lin, Xueqin wrote: > > > Are they DPDK bugs or this tool code bugs? > > > > DPDK bugs that I started reporting some weeks ago. > > I mentionned it during CI call. > > bzs can be queried via: https://bugs.dpdk.org/buglist.cgi?quicksearch=[asan] > > Some fixes have be

Re: [dpdk-dev] [PATCH] eal/linux: fix uevent message parsing

2021-11-03 Thread David Marchand
On Tue, Nov 2, 2021 at 7:43 PM David Marchand wrote: > > Caught with ASan: > > ==9727==ERROR: AddressSanitizer: stack-buffer-overflow on address > > 0x7f0daa2fc0d0 at pc 0x7f0daeefacb2 bp 0x7f0daa2fadd0 sp 0x7f0daa2fa578 > > READ of size 1 at 0x7f0daa2fc0d0 thread T1 > > #0 0x7f0daeefacb1 (

Re: [dpdk-dev] [PATCH] vhost: rename driver callbacks struct

2021-11-03 Thread Maxime Coquelin
On 11/3/21 09:38, Maxime Coquelin wrote: Hi David, On 11/3/21 09:36, David Marchand wrote: On Wed, Nov 3, 2021 at 9:16 AM Xia, Chenbo wrote: Testing issues reported in patchwork is expected as SPDK uses this struct, so we can ignore it as SPDK will rename it when it adapts to DPDK 21.11

[dpdk-dev] [PATCH v2 1/2] net/ice: save rule on switch filter creation

2021-11-03 Thread dapengx . yu
From: Dapeng Yu The VSI number, lookup elements and rule information for creating switch filter are abandoned when switch filter is created in original implementation. This patch saved the abandoned data in RTE flow, it is for future use on replay when handling exception at flow redirect. Cc: s

[dpdk-dev] [PATCH v2 2/2] net/ice: fix flow redirect failure

2021-11-03 Thread dapengx . yu
From: Dapeng Yu It's possible that a switch rule can't be redirect successfully due to kernel driver is busy to handle an ongoing VF reset, so the redirect action need to be deferred into next redirect request which is promised by kernel driver after VF reset done. This patch uses the saved flow

Re: [dpdk-dev] [PATCH v5 2/2] eal: add additional info if core mask too long

2021-11-03 Thread David Hunt
Hi David, On 2/11/2021 5:45 PM, David Marchand wrote: On Thu, Sep 23, 2021 at 1:03 PM David Hunt wrote: If the user requests to use an lcore above 128 using -c, the eal will exit with "EAL: invalid coremask syntax" and very little else useful information. This patch adds some extra informatio

Re: [dpdk-dev] [PATCH v5 2/2] eal: add additional info if core mask too long

2021-11-03 Thread David Marchand
On Wed, Nov 3, 2021 at 11:27 AM David Hunt wrote: > > >> for (; i >= 0; i--) > >> - if (coremask[i] != '0') > >> + if (coremask[i] != '0') { > >> + RTE_LOG(ERR, EAL, "invalid characters in coremask: > >> [%s]\n", > >> +

Re: [dpdk-dev] [EXT] [PATCH v6 1/7] examples/ipsec-secgw: add stats interval argument

2021-11-03 Thread Nicolau, Radu
On 11/3/2021 9:23 AM, Akhil Goyal wrote: -#if (STATS_INTERVAL > 0) struct ipsec_core_statistics { uint64_t tx; uint64_t rx; @@ -94,7 +90,6 @@ struct ipsec_core_statistics { } __rte_cache_aligned; struct ipsec_core_statistics core_statistics[RTE_MAX_LCORE]; -#endif /* STAT

Re: [dpdk-dev] [PATCH v2 2/2] bpf: fix convert API can be undefined

2021-11-03 Thread Ananyev, Konstantin
> On Tue, 2 Nov 2021 10:54:59 + > "Ananyev, Konstantin" wrote: > > > > > rte_bpf_convert() implementation depends on libpcap. > > > > Right now it is defined only when this library is installed and > > > > RTE_PORT_PCAP is defined. > > > > Fix that by providing for such case stub rte_bpf_c

[dpdk-dev] [PATCH] examples/ipsec-secgw: fix build error

2021-11-03 Thread Radu Nicolau
Move core_statistics definition out of header file. Fixes: 1329602b6c8f ("examples/ipsec-secgw: add per-core packet statistics") Cc: sta...@dpdk.org Signed-off-by: Radu Nicolau --- examples/ipsec-secgw/ipsec-secgw.c | 2 ++ examples/ipsec-secgw/ipsec-secgw.h | 2 +- 2 files changed, 3 insertion

[dpdk-dev] [PATCH] bus/pci: fix use after free on unplug

2021-11-03 Thread David Marchand
rte_pci_unmap_device() needs intr_handle objects to unregister callbacks. Bugzilla ID: 845 Fixes: d61138d4f0e2 ("drivers: remove direct access to interrupt handle") Signed-off-by: David Marchand --- drivers/bus/pci/pci_common.c | 17 + 1 file changed, 9 insertions(+), 8 deletion

[dpdk-dev] [PATCH v3 0/2] few bpf library fixes

2021-11-03 Thread Konstantin Ananyev
v3: - add meson warnings if dependencies are missing (Stephen) - more descriptive error message (Stephen) v2: - add fix for doxygen comments Konstantin Ananyev (2): bpf: fix doxygen comments bpf: fix convert API can be undefined app/dumpcap/main.c | 3 ++- lib/bpf/bpf_load.c | 18

[dpdk-dev] [PATCH v3 1/2] bpf: fix doxygen comments

2021-11-03 Thread Konstantin Ananyev
Fix typo in doxygen comments for rte_bpf_convert(). Fixes: 2eccf6afbea9 ("bpf: add function to convert classic BPF to DPDK BPF") Signed-off-by: Konstantin Ananyev --- lib/bpf/rte_bpf.h | 2 -- 1 file changed, 2 deletions(-) diff --git a/lib/bpf/rte_bpf.h b/lib/bpf/rte_bpf.h index 0d0a84b130..f

[dpdk-dev] [PATCH v3 2/2] bpf: fix convert API can be undefined

2021-11-03 Thread Konstantin Ananyev
rte_bpf_convert() implementation depends on libpcap. Right now it is defined only when this library is installed and RTE_PORT_PCAP is defined. Fix that by providing for such case stub rte_bpf_convert() implementation that will always return an error. To draw user attention, if proper implementation

[dpdk-dev] [PATCH v1 1/2] common/cnxk: fix: use appropriate zuc constants

2021-11-03 Thread Vidya Sagar Velumuri
Use appropriate ZUC constants based on key length and mac length Fixes: a90db80d7d72 ("common/cnxk: set key length for PDCP algos") Cc: vvelum...@marvell.com Signed-off-by: Vidya Sagar Velumuri Change-Id: Ie982110035916d2168cc4e79b7f5145c6d6ac021 diff --git a/drivers/common/cnxk/roc_se.c b/driv

[dpdk-dev] [PATCH v1 2/2] crypto/cnxk: fix: supported iv length for zuc 256

2021-11-03 Thread Vidya Sagar Velumuri
Fix supported IV length for ZUC 256 Add support in capability for 4 byte mac len for zuc 256 Pack the last 8 bytes of IV to 6 bytes by ignoring the 2 msb bits of each byte. Fixes: 29742632ac9e ("crypto/cnxk: support ZUC with 256-bit key") Cc: vvelum...@marvell.com Signed-off-by: Vidya Sagar Velum

Re: [dpdk-dev] [PATCH] pdump: fix uninit not freeing statistics memzone

2021-11-03 Thread Thomas Monjalon
26/10/2021 21:57, Stephen Hemminger: > On Tue, 26 Oct 2021 12:53:01 +0100 > Konstantin Ananyev wrote: > > > diff --git a/lib/pdump/rte_pdump.c b/lib/pdump/rte_pdump.c > > index 71602685d5..a708935861 100644 > > --- a/lib/pdump/rte_pdump.c > > +++ b/lib/pdump/rte_pdump.c > > @@ -74,6 +74,7 @@ stat

Re: [dpdk-dev] [PATCH] examples/ipsec-secgw: fix build error

2021-11-03 Thread Thomas Monjalon
I don't see any compilation issue. How do you trigger the problem? The scope may be precised in the title. 03/11/2021 11:51, Radu Nicolau: > Move core_statistics definition out of header file. Why? Please add explanation and error log here. > Fixes: 1329602b6c8f ("examples/ipsec-secgw: add per-c

[dpdk-dev] [PATCH] failsafe: Remove the vdev args check for secondary process which prevents the secondary from attaching to the device created by the primary process via the hotplug framework. This c

2021-11-03 Thread Kumara Parameshwaran
Signed-off-by: Kumara Parameshwaran --- drivers/net/failsafe/failsafe.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/net/failsafe/failsafe.c b/drivers/net/failsafe/failsafe.c index ad6b43538e..3c754a5f66 100644 --- a/drivers/net/failsafe/failsafe.c +++ b/drivers/n

[dpdk-dev] [PATCH v2] examples/ipsec-secgw: fix potential build error

2021-11-03 Thread Radu Nicolau
When STATS_INTERVAL is set to a non-zero value the core_statistics array will be defined in multiple compilation units and this can trigger a linker error on particular environments. In order to fix this the core_statistics definition was moved out of the header file. Fixes: 1329602b6c8f ("example

Re: [dpdk-dev] [PATCH v10 0/4] enable protocol agnostic flow offloading in FDIR

2021-11-03 Thread Zhang, Qi Z
> -Original Message- > From: Guo, Junfeng > Sent: Wednesday, November 3, 2021 12:40 PM > To: Zhang, Qi Z ; Wu, Jingjing ; > Xing, Beilei > Cc: dev@dpdk.org; Yigit, Ferruh ; Xu, Ting > ; Guo, Junfeng > Subject: [PATCH v10 0/4] enable protocol agnostic flow offloading in FDIR > > Proto

[dpdk-dev] [PATCH v2] net/sfc: allow control threads for counter queue polling

2021-11-03 Thread Andrew Rybchenko
From: Viacheslav Galaktionov MAE counters can be polled from a control thread if no service core is allocated for this. Signed-off-by: Viacheslav Galaktionov Signed-off-by: Andrew Rybchenko Reviewed-by: Andy Moreton --- The problem to require service cores for HW offload was raised by David o

Re: [dpdk-dev] [PATCH v3 0/3] enable protocol agnostic flow offloading in RSS

2021-11-03 Thread Zhang, Qi Z
> -Original Message- > From: Xu, Ting > Sent: Tuesday, November 2, 2021 9:50 AM > To: dev@dpdk.org > Cc: Zhang, Qi Z ; Yang, Qiming > ; Guo, Junfeng ; Xu, Ting > > Subject: [PATCH v3 0/3] enable protocol agnostic flow offloading in RSS > > Enable protocol agnostic flow offloading to s

Re: [dpdk-dev] [PATCH] pipeline: remove unreachable branch

2021-11-03 Thread Dumitrescu, Cristian
> -Original Message- > From: David Marchand > Sent: Wednesday, November 3, 2021 6:57 AM > To: dev@dpdk.org > Cc: Dumitrescu, Cristian ; Lin, Xueqin > ; Peng, ZhihongX > Subject: [PATCH] pipeline: remove unreachable branch > > A previous change blamed it on compiler/ASan, while this is

[dpdk-dev] [PATCH] kni: update kernel API to set random MAC address

2021-11-03 Thread Ferruh Yigit
Previously used 'random_ether_addr()' API is removed in upstream kernel with commit Commit ba530fea8ca1 ("ethernet: remove random_ether_addr()") Replacement API 'eth_random_addr()' is around since v3.6 [1], so simply switching to this API without any version checks. [1] 0a4dd594982a ("etherdevice

Re: [dpdk-dev] [PATCH v2] net/sfc: allow control threads for counter queue polling

2021-11-03 Thread David Marchand
On Wed, Nov 3, 2021 at 1:40 PM Andrew Rybchenko wrote: > > From: Viacheslav Galaktionov > > MAE counters can be polled from a control thread if no service core is > allocated for this. > > Signed-off-by: Viacheslav Galaktionov > Signed-off-by: Andrew Rybchenko > Reviewed-by: Andy Moreton > -

Re: [dpdk-dev] [PATCH v2] examples/ipsec-secgw: fix potential build error

2021-11-03 Thread Thomas Monjalon
03/11/2021 12:56, Radu Nicolau: > When STATS_INTERVAL is set to a non-zero value the core_statistics array > will be defined in multiple compilation units and this can trigger a > linker error on particular environments. In order to fix this the > core_statistics definition was moved out of the hea

Re: [dpdk-dev] [dpdklab] Re: [PATCH] vhost: rename driver callbacks struct

2021-11-03 Thread Lincoln Lavoie
On Wed, Nov 3, 2021 at 5:53 AM Maxime Coquelin wrote: > > > On 11/3/21 09:38, Maxime Coquelin wrote: > > Hi David, > > > > On 11/3/21 09:36, David Marchand wrote: > >> On Wed, Nov 3, 2021 at 9:16 AM Xia, Chenbo > wrote: > >>> Testing issues reported in patchwork is expected as SPDK uses > >>> th

Re: [dpdk-dev] [PATCH v2] net/sfc: allow control threads for counter queue polling

2021-11-03 Thread Andrew Rybchenko
On 11/3/21 4:00 PM, David Marchand wrote: On Wed, Nov 3, 2021 at 1:40 PM Andrew Rybchenko wrote: From: Viacheslav Galaktionov MAE counters can be polled from a control thread if no service core is allocated for this. Signed-off-by: Viacheslav Galaktionov Signed-off-by: Andrew Rybchenko Re

[dpdk-dev] [PATCH v3] net/sfc: allow control threads for counter queue polling

2021-11-03 Thread Andrew Rybchenko
From: Viacheslav Galaktionov MAE counters can be polled from a control thread if no service core is allocated for this. Signed-off-by: Viacheslav Galaktionov Signed-off-by: Andrew Rybchenko Reviewed-by: Andy Moreton Reviewed-by: David Marchand --- The problem to require service cores for HW

Re: [dpdk-dev] [dpdklab] Re: [PATCH] vhost: rename driver callbacks struct

2021-11-03 Thread Maxime Coquelin
On 11/3/21 14:11, Lincoln Lavoie wrote: On Wed, Nov 3, 2021 at 5:53 AM Maxime Coquelin mailto:maxime.coque...@redhat.com>> wrote: On 11/3/21 09:38, Maxime Coquelin wrote: > Hi David, > > On 11/3/21 09:36, David Marchand wrote: >> On Wed, Nov 3, 2021 at 9:16 AM X

[dpdk-dev] [PATCH v2 1/2] common/cnxk: fix: use appropriate zuc constants

2021-11-03 Thread Vidya Sagar Velumuri
Use appropriate ZUC constants based on key length and mac length Fixes: a90db80d7d72 ("common/cnxk: set key length for PDCP algos") Cc: vvelum...@marvell.com Signed-off-by: Vidya Sagar Velumuri v2: * Fixed remove gerrit ID warning diff --git a/drivers/common/cnxk/roc_se.c b/drivers/common/cnxk/

[dpdk-dev] [PATCH v2 2/2] crypto/cnxk: fix: supported iv length for zuc 256

2021-11-03 Thread Vidya Sagar Velumuri
Fix supported IV length for ZUC 256 Add support in capability for 4 byte mac len for zuc 256 Pack the last 8 bytes of IV to 6 bytes by ignoring the 2 msb bits of each byte. Fixes: 29742632ac9e ("crypto/cnxk: support ZUC with 256-bit key") Cc: vvelum...@marvell.com Signed-off-by: Vidya Sagar Velum

Re: [dpdk-dev] [PATCH v2] buildtools: fix build with meson 0.60

2021-11-03 Thread Thomas Monjalon
02/11/2021 19:08, Dmitry Kozlyuk: > 2021-11-01 17:03 (UTC+), Bruce Richardson: > > Meson 0.60 switched the format of uninstalled static libraries > > to thin archives, that is, they contain only paths to object files, > > not the files themselves. Files cannot be extracted in this case, > > res

Re: [dpdk-dev] [EXT] [PATCH v6 1/7] examples/ipsec-secgw: add stats interval argument

2021-11-03 Thread Akhil Goyal
> On 11/3/2021 9:23 AM, Akhil Goyal wrote: > >> -#if (STATS_INTERVAL > 0) > >> struct ipsec_core_statistics { > >>uint64_t tx; > >>uint64_t rx; > >> @@ -94,7 +90,6 @@ struct ipsec_core_statistics { > >> } __rte_cache_aligned; > >> > >> struct ipsec_core_statistics core_statistics[RTE_

Re: [dpdk-dev] [PATCH v4 01/20] net/bnxt: add NAT support for dest IP and port combination

2021-11-03 Thread Ferruh Yigit
On 11/3/2021 12:52 AM, Ajit Khaparde wrote: From: Kishore Padmanabha * Added support for NAT action for the destination IP and port combination for the Thor platform. This is not supported for Whitney platform. I know a Whitley platform but I guess this is something else, still want to

Re: [dpdk-dev] [PATCH v4 02/20] net/bnxt: add support for multi root capability

2021-11-03 Thread Ferruh Yigit
On 11/3/2021 12:52 AM, Ajit Khaparde wrote: From: Kishore Padmanabha Update driver to read the multi root capability and ignore pci address check while creating ulp session when multi root capability is enabled in the hardware. DPDK HSI version updated from 1.10.1.70 to 1.10.2.68. According c

Re: [dpdk-dev] [PATCH v4 05/20] net/bnxt: add capability option for socket redirect

2021-11-03 Thread Ferruh Yigit
On 11/3/2021 12:52 AM, Ajit Khaparde wrote: From: Kishore Padmanabha Added support for socket redirect feature capability so applications can enable or disable this feature. This patch contains the template changes. Signed-off-by: Kishore Padmanabha Signed-off-by: Venkat Duvvuru Reviewed-by:

Re: [dpdk-dev] [PATCH v4 10/20] net/bnxt: remove devargs for stats accumulation

2021-11-03 Thread Ferruh Yigit
On 11/3/2021 12:52 AM, Ajit Khaparde wrote: From: Kishore Padmanabha The accumulation of flow counters is not determined by the application device arguments anymore. Instead it is now dictated by the platform capabilities whether to do software based accumulation or not. Signed-off-by: Kishore

Re: [dpdk-dev] [PATCH v4 18/20] net/bnxt: remove 2 slice WC entries

2021-11-03 Thread Ferruh Yigit
On 11/3/2021 12:52 AM, Ajit Khaparde wrote: From: Mike Baucom Remove 2-slice Wild Card entries for scale. The type-5 WC IPv6 flows are removed in order to increase the scale for app-id=3. The app no longer supports 2-slice WC entries. 'WC' is mostly used for "Write combining", didn't see be

Re: [dpdk-dev] [PATCH v4 06/20] net/bnxt: enable wildcard match for ingress flows

2021-11-03 Thread Ferruh Yigit
On 11/3/2021 12:52 AM, Ajit Khaparde wrote: From: Kishore Padmanabha Enabled wildcard match support for ipv4 ingress flows. Signed-off-by: Kishore Padmanabha Signed-off-by: Venkat Duvvuru Reviewed-by: Michael Baucom Reviewed-by: Randy Schacher Acked-by: Ajit Khaparde --- .../generic_tem

Re: [dpdk-dev] [PATCH v4 11/20] net/bnxt: fix clang compiler warnings

2021-11-03 Thread Ferruh Yigit
On 11/3/2021 12:52 AM, Ajit Khaparde wrote: From: Shahaji Bhosle Typecast flow_item type, action_item type and the ENUMs to uint32_t before comparing. Fixes: 53a0d4f7663 ("net/bnxt: support flow API item parsing") Cc: sta...@dpdk.org Hi Ajit, Is above Fixes commit correct? It is from v20.05

Re: [dpdk-dev] [PATCH v5 2/2] eal: add additional info if core mask too long

2021-11-03 Thread David Hunt
On 3/11/2021 10:27 AM, David Hunt wrote: Hi David, On 2/11/2021 5:45 PM, David Marchand wrote: On Thu, Sep 23, 2021 at 1:03 PM David Hunt wrote: If the user requests to use an lcore above 128 using -c, the eal will exit with "EAL: invalid coremask syntax" and very little else useful informa

Re: [dpdk-dev] [PATCH v2] buildtools: fix build with meson 0.60

2021-11-03 Thread Thomas Monjalon
03/11/2021 14:20, Thomas Monjalon: > 02/11/2021 19:08, Dmitry Kozlyuk: > > 2021-11-01 17:03 (UTC+), Bruce Richardson: > > > Meson 0.60 switched the format of uninstalled static libraries > > > to thin archives, that is, they contain only paths to object files, > > > not the files themselves. Fi

Re: [dpdk-dev] [PATCH v4 10/20] net/bnxt: remove devargs for stats accumulation

2021-11-03 Thread Ajit Khaparde
On Wed, Nov 3, 2021 at 6:24 AM Ferruh Yigit wrote: > > On 11/3/2021 12:52 AM, Ajit Khaparde wrote: > > From: Kishore Padmanabha > > > > The accumulation of flow counters is not determined by the > > application device arguments anymore. Instead it is now dictated by > > the platform capabilities

Re: [dpdk-dev] [EXT] Re: [PATCH v2] examples/ipsec-secgw: fix potential build error

2021-11-03 Thread Akhil Goyal
> 03/11/2021 12:56, Radu Nicolau: > > When STATS_INTERVAL is set to a non-zero value the core_statistics array > > will be defined in multiple compilation units and this can trigger a > > linker error on particular environments. In order to fix this the > > core_statistics definition was moved out

Re: [dpdk-dev] [dpdk-stable] [PATCH v2] examples/ipsec-secgw: fix potential build error

2021-11-03 Thread David Marchand
On Wed, Nov 3, 2021 at 2:09 PM Thomas Monjalon wrote: > > 03/11/2021 12:56, Radu Nicolau: > > When STATS_INTERVAL is set to a non-zero value the core_statistics array > > will be defined in multiple compilation units and this can trigger a > > linker error on particular environments. In order to f

Re: [dpdk-dev] [EXT] Re: [dpdk-stable] [PATCH v2] examples/ipsec-secgw: fix potential build error

2021-11-03 Thread Akhil Goyal
> On Wed, Nov 3, 2021 at 2:09 PM Thomas Monjalon > wrote: > > > > 03/11/2021 12:56, Radu Nicolau: > > > When STATS_INTERVAL is set to a non-zero value the core_statistics array > > > will be defined in multiple compilation units and this can trigger a > > > linker error on particular environments.

Re: [dpdk-dev] [PATCH] vhost: rename driver callbacks struct

2021-11-03 Thread Maxime Coquelin
On 11/2/21 11:47, Maxime Coquelin wrote: As previously announced, this patch renames struct vhost_device_ops to struct rte_vhost_device_ops. Signed-off-by: Maxime Coquelin --- doc/guides/rel_notes/deprecation.rst | 3 --- doc/guides/rel_notes/release_21_11.rst | 2 ++ drivers/net/vhost

Re: [dpdk-dev] [PATCH] doc: remove deprecation notice for vhost

2021-11-03 Thread Maxime Coquelin
On 11/3/21 06:00, Chenbo Xia wrote: Ten vhost APIs were announced to be stable and promoted in below commit, so remove the related deprecation notice. Fixes: 945ef8a04098 ("vhost: promote some APIs to stable") Signed-off-by: Chenbo Xia Reported-by: Maxime Coquelin --- doc/guides/rel_note

Re: [dpdk-dev] [PATCH v3] vhost: mark vDPA driver API as internal

2021-11-03 Thread Maxime Coquelin
On 11/2/21 10:56, Maxime Coquelin wrote: This patch marks the vDPA driver APIs as internal and rename the corresponding header file to vdpa_driver.h. Signed-off-by: Maxime Coquelin Acked-by: Thomas Monjalon Reviewed-by: Chenbo Xia --- Changes in v3: == - Update deprecation noti

Re: [dpdk-dev] [PATCH] vhost: add vDPA resource cleanup callback

2021-11-03 Thread Maxime Coquelin
On 11/3/21 14:45, Xueming(Steven) Li wrote: On Wed, 2021-11-03 at 09:46 +0100, Maxime Coquelin wrote: On 11/3/21 09:41, Xia, Chenbo wrote: Hi Xueming, -Original Message- From: Xueming(Steven) Li Sent: Thursday, October 21, 2021 8:36 PM To: maxime.coque...@redhat.com; dev@dpdk.org

Re: [dpdk-dev] [EXT] Re: [dpdk-stable] [PATCH v2] examples/ipsec-secgw: fix potential build error

2021-11-03 Thread David Marchand
On Wed, Nov 3, 2021 at 2:45 PM Akhil Goyal wrote: > > > On Wed, Nov 3, 2021 at 2:09 PM Thomas Monjalon > > wrote: > > > > > > 03/11/2021 12:56, Radu Nicolau: > > > > When STATS_INTERVAL is set to a non-zero value the core_statistics array > > > > will be defined in multiple compilation units and

Re: [dpdk-dev] [EXT] Re: [dpdk-stable] [PATCH v2] examples/ipsec-secgw: fix potential build error

2021-11-03 Thread Akhil Goyal
> > Yes this series initiated the issue, applying both the patch and the series > now > > On next-crypto > > It means a patch of this series broke compilation, and this fix here > should be squashed in it. Actually no, this is definitely an issue introduced earlier and should be part of stable. T

[dpdk-dev] [PATCH v4 00/10] vdpa/sfc: introduce Xilinx vDPA driver

2021-11-03 Thread Vijay Srivastava
This patch series introduces vDPA driver for Xilinx devices. The Xilinx vDPA (vhost data path acceleration) provides support for the Xilinx SN1022 SmartNICs. Vijay Kumar Srivastava (10): vdpa/sfc: introduce Xilinx vDPA driver vdpa/sfc: add support for device initialization vdpa/sfc: add supp

[dpdk-dev] [PATCH v4 01/10] vdpa/sfc: introduce Xilinx vDPA driver

2021-11-03 Thread Vijay Srivastava
From: Vijay Kumar Srivastava Add new vDPA PMD to support vDPA operations of Xilinx devices. This patch implements probe and remove functions. Signed-off-by: Vijay Kumar Srivastava Acked-by: Andrew Rybchenko --- v2: * Updated logging macros to remove redundant code. v3: * Replaced depreciated

[dpdk-dev] [PATCH v4 02/10] vdpa/sfc: add support for device initialization

2021-11-03 Thread Vijay Srivastava
From: Vijay Kumar Srivastava Add HW initialization and vDPA device registration support. Signed-off-by: Vijay Kumar Srivastava Acked-by: Andrew Rybchenko --- v2: * Used rte_memzone_reserve_aligned for mcdi buffer allocation. * Freeing mcdi buff when DMA map fails. * Fixed one typo. v4: * Remo

[dpdk-dev] [PATCH v4 03/10] vdpa/sfc: add support to get device and protocol features

2021-11-03 Thread Vijay Srivastava
From: Vijay Kumar Srivastava Implement vDPA ops get_feature and get_protocol_features. This patch retrieves device supported features and enables protocol features. Signed-off-by: Vijay Kumar Srivastava Acked-by: Andrew Rybchenko Reviewed-by: Maxime Coquelin Reviewed-by: Chenbo Xia --- doc/

[dpdk-dev] [PATCH v4 04/10] vdpa/sfc: get device supported max queue count

2021-11-03 Thread Vijay Srivastava
From: Vijay Kumar Srivastava Implement vDPA ops get_queue_num to get the maximum number of queues supported by the device. Signed-off-by: Vijay Kumar Srivastava Acked-by: Andrew Rybchenko Reviewed-by: Maxime Coquelin Reviewed-by: Chenbo Xia --- v4: * Updated format specifier in log message.

[dpdk-dev] [PATCH v4 05/10] vdpa/sfc: add support to get VFIO device fd

2021-11-03 Thread Vijay Srivastava
From: Vijay Kumar Srivastava Implement vDPA ops get_vfio_device_fd to get the VFIO device fd. Signed-off-by: Vijay Kumar Srivastava Acked-by: Andrew Rybchenko Reviewed-by: Maxime Coquelin Reviewed-by: Chenbo Xia --- drivers/vdpa/sfc/sfc_vdpa_ops.c | 24 1 file chang

[dpdk-dev] [PATCH v4 07/10] vdpa/sfc: add support to get queue notify area info

2021-11-03 Thread Vijay Srivastava
From: Vijay Kumar Srivastava Implement the vDPA ops get_notify_area to get the notify area info of the queue. Signed-off-by: Vijay Kumar Srivastava Acked-by: Andrew Rybchenko --- v2: * Added error log in sfc_vdpa_get_notify_area. v4: * Updated parameter for sfc_vdpa_setup_notify_ctrl driver

[dpdk-dev] [PATCH v4 08/10] vdpa/sfc: add support for MAC filter config

2021-11-03 Thread Vijay Srivastava
From: Vijay Kumar Srivastava Add support for unicast and broadcast MAC filter configuration. Signed-off-by: Vijay Kumar Srivastava Acked-by: Andrew Rybchenko --- v4: * Removed redundant NULL check. * Improved line usage by rearranging function params. doc/guides/vdpadevs/sfc.rst| 4

[dpdk-dev] [PATCH v4 09/10] vdpa/sfc: add support to set vring state

2021-11-03 Thread Vijay Srivastava
From: Vijay Kumar Srivastava Implements vDPA ops set_vring_state to configure vring state. Signed-off-by: Vijay Kumar Srivastava Acked-by: Andrew Rybchenko Reviewed-by: Maxime Coquelin Reviewed-by: Chenbo Xia --- drivers/vdpa/sfc/sfc_vdpa_ops.c | 54 ++---

[dpdk-dev] [PATCH v4 10/10] vdpa/sfc: set a multicast filter during vDPA init

2021-11-03 Thread Vijay Srivastava
From: Vijay Kumar Srivastava Insert unknown multicast filter to allow IPv6 neighbor discovery Signed-off-by: Vijay Kumar Srivastava Acked-by: Andrew Rybchenko Reviewed-by: Chenbo Xia --- v4: * Improved line usage by rearranging function params. drivers/vdpa/sfc/sfc_vdpa.h| 3 ++- d

[dpdk-dev] [PATCH v4 06/10] vdpa/sfc: add support for dev conf and dev close ops

2021-11-03 Thread Vijay Srivastava
From: Vijay Kumar Srivastava Implement vDPA ops dev_conf and dev_close for DMA mapping, interrupt and virtqueue configurations. Signed-off-by: Vijay Kumar Srivastava Acked-by: Andrew Rybchenko --- v2: * Removed redundant null check while calling free(). * Added error handling for rte_vhost_get

Re: [dpdk-dev] [PATCH v3 2/3] net/ice: enable protocol agnostic flow offloading in RSS

2021-11-03 Thread Ferruh Yigit
On 11/2/2021 1:49 AM, Ting Xu wrote: +static int +ice_hash_rem_raw_cfg(struct ice_adapter *ad, + struct ice_parser_profile *prof, + u16 vsi_handle) +{ + struct ice_hw *hw = &ad->hw; + int ptg, ret; + u16 vsig; + u64 id; + + id

Re: [dpdk-dev] [EXT] [PATCH v6 0/7] IPsec Sec GW new features

2021-11-03 Thread Akhil Goyal
> Update the IPsec sample app with new features and updates: > - telemetry support > - add reset callback > - stats screen configurable as a command line parameter > - UDP encapsulation support for inline crypto > - ESN with configurable start value > > Radu Nicolau (7): > examples/ipsec-secgw:

Re: [dpdk-dev] [PATCH v3 0/3] enable protocol agnostic flow offloading in RSS

2021-11-03 Thread Ferruh Yigit
On 11/3/2021 12:45 PM, Zhang, Qi Z wrote: -Original Message- From: Xu, Ting Sent: Tuesday, November 2, 2021 9:50 AM To: dev@dpdk.org Cc: Zhang, Qi Z ; Yang, Qiming ; Guo, Junfeng ; Xu, Ting Subject: [PATCH v3 0/3] enable protocol agnostic flow offloading in RSS Enable protocol agnos

[dpdk-dev] [PATCH v6 1/2] eal: add additional info if core list too long

2021-11-03 Thread David Hunt
If the user requests to use an lcore above 128 using -l, the eal will exit with "EAL: invalid core list syntax" and very little else useful information. This patch adds some extra information suggesting to use --lcores so that physical cores above RTE_MAX_LCORE (default 128) can be used. This is a

[dpdk-dev] [PATCH v6 2/2] eal: add additional info if core mask too long

2021-11-03 Thread David Hunt
If the user requests to use an lcore above 128 using -c, the eal will exit with "EAL: invalid coremask syntax" and very little else useful information. This patch adds some extra information suggesting to use --lcores so that physical cores above RTE_MAX_LCORE (default 128) can be used. This is ac

Re: [dpdk-dev] Overriding rte_config.h

2021-11-03 Thread Ben Magistro
Thanks for the clarification. I agree bumping RTE_LIBRTE_IP_FRAG_MAX_FRAG to 8 probably makes sense to easily support jumbo frames. The other use case we have is supporting highly fragmented UDP. To support this we were increasing to 64 (next power of 2) based on a 64K UDP max and a link MTU of

Re: [dpdk-dev] [dpdklab] Re: [PATCH] vhost: rename driver callbacks struct

2021-11-03 Thread Lincoln Lavoie
On Wed, Nov 3, 2021 at 9:16 AM Maxime Coquelin wrote: > > > On 11/3/21 14:11, Lincoln Lavoie wrote: > > > > > > > > On Wed, Nov 3, 2021 at 5:53 AM Maxime Coquelin > > mailto:maxime.coque...@redhat.com>> wrote: > > > > > > > > On 11/3/21 09:38, Maxime Coquelin wrote: > > > Hi David, > >

Re: [dpdk-dev] [PATCH v9 2/5] pflock: use wait until scheme for read pflock

2021-11-03 Thread David Marchand
On Mon, Nov 1, 2021 at 7:00 AM Feifei Wang wrote: > > Instead of polling for read pflock update, use wait until scheme for > this case. > > Jira: ENTNET-2903 I dropped what looks like an internal tag. > Signed-off-by: Feifei Wang > Reviewed-by: Ruifeng Wang > Acked-by: Jerin Jacob -- David

Re: [dpdk-dev] [PATCH v9 0/5] add new helper for wait scheme

2021-11-03 Thread David Marchand
On Mon, Nov 1, 2021 at 7:00 AM Feifei Wang wrote: > > Add new helper for wait scheme, and apply this new definitions into > lib to replace rte_pause. > > v2: > 1. use macro to create new wait scheme (Stephen) > > v3: > 1. delete unnecessary bug fix in bpf (Konstantin) > > v4: > 1. put size into th

Re: [dpdk-dev] [PATCH] test/mbuf: fix access to freed memory

2021-11-03 Thread David Marchand
On Fri, Oct 29, 2021 at 2:16 PM Olivier Matz wrote: > > Seen by ASan. > > In the external buffer mbuf test, we check that the buffer is freed > by checking that its refcount is 0. This is not a valid condition, > because it accesses to an already freed area. > > Fix this by setting a boolean flag

[dpdk-dev] [PATCH] crypto/qat: fix qp number

2021-11-03 Thread Przemyslaw Zegan
This patch fixes incorrect number of queue pairs Fixes: 4c0d2ee23c39 ("crypto/qat: remove incorrect usage of bundle number" ) Cc: roy.fan.zh...@intel.com Signed-off-by: Przemyslaw Zegan --- drivers/common/qat/qat_adf/adf_transport_access_macros.h | 2 +- 1 file changed, 1 insertion(+), 1 deleti

Re: [dpdk-dev] [PATCH 1/9] common/cnxk: add code to write CPT CTX through microcode op

2021-11-03 Thread Jerin Jacob
On Tue, Nov 2, 2021 at 9:24 PM Nithin Dabilpuram wrote: > > From: Srujana Challa > > Adds APIs to write CPT CTX through microcode op(SET_CTX/WRITE_SA). > > Signed-off-by: Srujana Challa Series Acked-by: Jerin Jacob Series applied to dpdk-next-net-mrvl/for-next-net. Thanks. > --- > drivers/c

[dpdk-dev] [PATCH] crypto/qat: fix access to null pointer

2021-11-03 Thread Przemyslaw Zegan
This patch fixes a possible access to null pointer Fixes: 9f4b9222019c ("common/qat: add gen specific queue implementation") Cc: roy.fan.zh...@intel.com Signed-off-by: Przemyslaw Zegan --- drivers/common/qat/dev/qat_dev_gen1.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/commo

Re: [dpdk-dev] [PATCH v2] common/cnxk: fix device MSIX greater than default value

2021-11-03 Thread Jerin Jacob
On Wed, Nov 3, 2021 at 1:29 PM Harman Kalra wrote: > > Handling the case where number of MSIX interrupts are greater > than default value i.e. PLT_MAX_RXTX_INTR_VEC_ID. On PCI probe > device is queried for supported MSIX interrupts, and respective > interrupt resources are reallocated with this va

Re: [dpdk-dev] [PATCH] common/cnxk: fix a few typos

2021-11-03 Thread Jerin Jacob
On Wed, Nov 3, 2021 at 12:18 AM Tomasz Duszynski wrote: > > Fix typos here and there. > > Signed-off-by: Tomasz Duszynski > Reviewed-by: Jerin Jacob Kollanukkaran Changed to common/cnxk: fix a few typos Fix a few typos. Fixes: fa8f86a14e2e ("common/cnxk: add build infrastructre

Re: [dpdk-dev] [RFC] mempool: implement index-based per core cache

2021-11-03 Thread Dharmik Thakkar
Hi, Thank you everyone for the comments! I am currently working on making the global pool ring’s implementation as index based. Once done, I will send a patch for community review. I will also make it as a compile time option. > On Oct 31, 2021, at 3:14 AM, Morten Brørup wrote: > >> From: Mor

  1   2   >