Re: [PATCH v10 4/5] net/enetfec: add Rx/Tx support

On Sat, 13 Nov 2021 10:01:40 +0530 Apeksha Gupta wrote: > + if (mbuf) > + rte_pktmbuf_free(mbuf); Null check is unnecessary. rte_pktmbuf_free(NULL) is defined to be safe, like free(NULL).

Re: [PATCH v10 3/5] net/enetfec: support queue configuration

On Sat, 13 Nov 2021 10:01:39 +0530 Apeksha Gupta wrote: > + /* Tx deferred start is not supported */ > + if (tx_conf->tx_deferred_start) { > + ENETFEC_PMD_ERR("%p:Tx deferred start not supported", > + (void *)dev); Small observations: 1. Cast to void *

[PATCH v6 0/5] cleanup more resources on eal_cleanup

When testing using ASAN or valgrind with DPDK; there are lots of leftover memory and file descriptors. This makes it hard to find application leaks versus internal DPDK leaks. The DPDK has a function that applications can use to tell it to cleanup resources on shutdown (rte_eal_cleanup). But the c

[PATCH v6 1/5] eal: close log in eal_cleanup

When application calls rte_eal_cleanup on shutdown, the DPDK log should be closed and cleaned up. This helps reduce false reports from tools like ASAN and valgrind that track memory leaks. Signed-off-by: Stephen Hemminger --- lib/eal/common/eal_common_log.c | 13 + lib/eal/common/ea

[PATCH v6 2/5] eal: mp: end the multiprocess thread during cleanup

When rte_eal_cleanup is called, all control threads should exit. For the mp thread, this best handled by closing the mp_socket and letting the thread see that. This also fixes potential problems where the mp_socket gets another hard error, and the thread runs away repeating itself by reading the s

[PATCH v6 3/5] eal: vfio: cleanup the mp sync handle

When rte_eal_cleanup is called the rte_mp_action for VFIO should be freed. Fixes: edf73dd33072 ("ipc: handle unsupported IPC in action register") Cc: anatoly.bura...@intel.com Cc: sta...@dpdk.org Signed-off-by: Stephen Hemminger Acked-by: Anatoly Burakov --- lib/eal/linux/eal.c | 4

[PATCH v6 4/5] eal: hotplug: cleanup multiprocess resources

When rte_eal_cleanup is called, hotplug should unregister the resources associated with the multi-process server. Signed-off-by: Stephen Hemminger --- lib/eal/common/hotplug_mp.c | 5 + lib/eal/common/hotplug_mp.h | 6 ++ lib/eal/linux/eal.c | 1 + 3 files changed, 12 insertions(

[PATCH v6 5/5] eal: malloc: cleanup mp resources

The mp action resources in malloc should be cleaned up via rte_eal_cleanup. Signed-off-by: Stephen Hemminger Acked-by: Anatoly Burakov --- lib/eal/common/malloc_heap.c | 6 ++ lib/eal/common/malloc_heap.h | 3 +++ lib/eal/common/malloc_mp.c | 12 lib/eal/common/malloc_mp.h

test_debug: calling rte_exit() in a forked child

This test looks bogus it is doing something that DPDK as a library really shouldn't allow: /* use fork() to test rte_exit() */ static int test_exit_val(int exit_val) { int pid; int status; /* manually cleanup EAL memory, as the fork() below would otherwise * caus

[PATCH] doc: add explaination when feature "=P" for ice

Users are confused with a feature with "P", added necessary explaination for this. Signed-off-by: Qi Zhang --- doc/guides/nics/features/ice.ini | 3 +++ 1 file changed, 3 insertions(+) diff --git a/doc/guides/nics/features/ice.ini b/doc/guides/nics/features/ice.ini index 00ace32398..a15f42f94c

[PATCH] doc: add explanation when feature "=P" for ice

Users are confused with a feature with "P", added necessary explanation for this. Signed-off-by: Qi Zhang --- v2: - fix spell. doc/guides/nics/features/ice.ini | 3 +++ 1 file changed, 3 insertions(+) diff --git a/doc/guides/nics/features/ice.ini b/doc/guides/nics/features/ice.ini index 00ace