RE: [PATCH] vhost: fix get hpa fail from guest pages

2021-11-15 Thread Xia, Chenbo
> -Original Message- > From: Wang, YuanX > Sent: Thursday, November 11, 2021 2:27 PM > To: maxime.coque...@redhat.com; Xia, Chenbo > Cc: dev@dpdk.org; Hu, Jiayu ; Ding, Xuan > ; Ma, WenwuX ; He, Xingguang > ; Yang, YvonneX ; Wang, YuanX > > Subject: [PATCH] vhost: fix get hpa fail from g

RE: [PATCH v3] vhost: fix physical address mapping

2021-11-15 Thread Ding, Xuan
Hi Chenbo, > -Original Message- > From: Xia, Chenbo > Sent: 2021年11月15日 15:21 > To: Ding, Xuan ; maxime.coque...@redhat.com > Cc: dev@dpdk.org; Hu, Jiayu ; Wang, YuanX > ; He, Xingguang > Subject: RE: [PATCH v3] vhost: fix physical address mapping > > Hi Xuan, > > > -Original Messa

Re: [PATCH] event/dlb2: fix delayed_pop test in dlb2_selftest

2021-11-15 Thread Jerin Jacob
On Sat, Nov 13, 2021 at 2:33 AM Chen, Mike Ximing wrote: > > > > > -Original Message- > > From: Shetty, Rashmi > > Sent: Friday, November 12, 2021 2:49 PM > > To: dev@dpdk.org > > Cc: jer...@marvell.com; Van Haaren, Harry ; > > Pathak, Pravin > > ; Chen, Mike Ximing ; > > McDaniel, Timo

RE: [PATCH] ethdev: fix typos

2021-11-15 Thread Ori Kam
Hi > -Original Message- > From: Ferruh Yigit > Sent: Friday, November 12, 2021 2:14 PM > Subject: [PATCH] ethdev: fix typos > > Signed-off-by: Ferruh Yigit > --- > lib/ethdev/ethdev_driver.h | 4 ++-- > lib/ethdev/rte_flow.h | 4 ++-- > 2 files changed, 4 insertions(+), 4 deletion

Re: [PATCH v1] app/testpmd: avoid the process ID out of range

2021-11-15 Thread Min Hu (Connor)
Acked-by: Min Hu (Connor) 在 2021/11/15 14:05, Haiyue Wang 写道: The 'proc-id' should be less than 'num-procs', if not, exit the testpmd and show the error message. Fixes: a550baf24af9 ("app/testpmd: support multi-process") Signed-off-by: Haiyue Wang --- app/test-pmd/parameters.c | 6 ++

Re: [PATCH 1/3] config/x86: skip GNU binutils bug check for LLVM

2021-11-15 Thread Bruce Richardson
On Sat, Nov 13, 2021 at 12:48:24AM +0300, Dmitry Kozlyuk wrote: > AVX512 was disabled when GNU binutils were missing or had a known bug, > even if LLVM binutils were used for the build, > because binutils-avx512-check.sh was invoked regardless and failed. > In particular, this was the case for Free

Re: [PATCH 5/7] drivers/net: fix unused but set variables

2021-11-15 Thread David Marchand
Hello Ajit, Somnath, On Fri, Nov 12, 2021 at 3:02 PM Conor Walsh wrote: > > This patch fixes unused but set variables in the following net drivers: > - bnxt > - hinic > - liquidio > - nfp > - octeontx > - qede > - txgbe > - vmxnet3 > > This patch also fixes an unused function warning for

Re: [PATCH 2/3] buildtools: make AVX512 check script portable

2021-11-15 Thread Bruce Richardson
On Sat, Nov 13, 2021 at 12:48:25AM +0300, Dmitry Kozlyuk wrote: > buildtools/binutils-avx512-check.sh was Unix-only > and could not be used in cross builds: > 1) written in shell; > 2) used the assembler binary that may be missing, >e.g. when building on Windows with LLVM; > 3) located the asse

Re: [PATCH 3/3] config/x86: fix MinGW cross build with meson 0.49

2021-11-15 Thread Bruce Richardson
On Sat, Nov 13, 2021 at 12:48:26AM +0300, Dmitry Kozlyuk wrote: > Cross build with MinGW was broken for the baseline meson 0.49.2. > Cause: in c_args = '-mno-avx512f' from config/x86/cross-mingw, > each character was treated as a separate compiler option: > > meson.build:4:0: ERROR: Compiler

Re: [PATCH v11 0/5] drivers/net: add NXP ENETFEC driver

2021-11-15 Thread Ferruh Yigit
On 11/15/2021 7:19 AM, Apeksha Gupta wrote: This patch series introduce the enetfec driver, ENETFEC (Fast Ethernet Controller) is a network poll mode driver for the inbuilt NIC found in the NXP i.MX 8M Mini SoC. An overview of the enetfec driver with probe and remove are in patch 1. Patch 2 desi

Re: [PATCH v9 3/5] net/enetfec: support queue configuration

2021-11-15 Thread Ferruh Yigit
On 11/10/2021 1:54 PM, Ferruh Yigit wrote: On 11/10/2021 7:48 AM, Apeksha Gupta wrote: This patch adds Rx/Tx queue configuration setup operations. On packet reception the respective BD Ring status bit is set which is then used for packet processing. Signed-off-by: Sachin Saxena Signed-off-by:

Re: [PATCH v11 1/5] net/enetfec: introduce NXP ENETFEC driver

2021-11-15 Thread Ferruh Yigit
On 11/15/2021 7:19 AM, Apeksha Gupta wrote: ENETFEC (Fast Ethernet Controller) is a network poll mode driver for NXP SoC i.MX 8M Mini. This patch adds skeleton for enetfec driver with probe function. Signed-off-by: Sachin Saxena Signed-off-by: Apeksha Gupta Acked-by: Hemant Agrawal <...>

Re: [PATCH v11 3/5] net/enetfec: support queue configuration

2021-11-15 Thread Ferruh Yigit
On 11/15/2021 7:19 AM, Apeksha Gupta wrote: This patch adds Rx/Tx queue configuration setup operations. On packet reception the respective BD Ring status bit is set which is then used for packet processing. Signed-off-by: Sachin Saxena Signed-off-by: Apeksha Gupta Acked-by: Hemant Agrawal I pu

Re: [PATCH] net/axgbe: fix PCI ID to distinguish v1000 vs e3000

2021-11-15 Thread Awan, Arsalan
Thanks, Chandu! Appreciate you guys looking into this! Looking forward to hear from you soon. Thanks and regards, Arsalan From: Namburu, Chandu-babu Sent: Friday, November 12, 2021 7:48 PM To: Awan, Arsalan; dev@dpdk.org Cc: Somalapuram, Amaranath; Sebas

Re: [PATCH v9 3/5] net/enetfec: support queue configuration

2021-11-15 Thread Ferruh Yigit
On 11/15/2021 10:06 AM, Ferruh Yigit wrote: On 11/10/2021 1:54 PM, Ferruh Yigit wrote: On 11/10/2021 7:48 AM, Apeksha Gupta wrote: This patch adds Rx/Tx queue configuration setup operations. On packet reception the respective BD Ring status bit is set which is then used for packet processing.

Re: [PATCH v11 3/5] net/enetfec: support queue configuration

2021-11-15 Thread Ferruh Yigit
On 11/15/2021 10:11 AM, Ferruh Yigit wrote: On 11/15/2021 7:19 AM, Apeksha Gupta wrote: This patch adds Rx/Tx queue configuration setup operations. On packet reception the respective BD Ring status bit is set which is then used for packet processing. Signed-off-by: Sachin Saxena Signed-off-by:

Re: [PATCH v9 3/5] net/enetfec: support queue configuration

2021-11-15 Thread Ferruh Yigit
On 11/15/2021 10:23 AM, Ferruh Yigit wrote: On 11/15/2021 10:06 AM, Ferruh Yigit wrote: On 11/10/2021 1:54 PM, Ferruh Yigit wrote: On 11/10/2021 7:48 AM, Apeksha Gupta wrote: This patch adds Rx/Tx queue configuration setup operations. On packet reception the respective BD Ring status bit is se

Re: [PATCH v11 3/5] net/enetfec: support queue configuration

2021-11-15 Thread Ferruh Yigit
On 11/15/2021 10:24 AM, Ferruh Yigit wrote: On 11/15/2021 10:11 AM, Ferruh Yigit wrote: On 11/15/2021 7:19 AM, Apeksha Gupta wrote: This patch adds Rx/Tx queue configuration setup operations. On packet reception the respective BD Ring status bit is set which is then used for packet processing.

[PATCH] net/mlx5: fix missing RSS validation with meter policy

2021-11-15 Thread Bing Zhao
The RSS can be one of the fate actions when creating a meter with policy. In the previous implementation, the RSS validation was missed when creating a flow rule with such meter due to the fact that a policy meter was created firstly and then used in the rule. In the stage of meter creation, no rte

RE: [dpdk-dev] [Bug 826] red_autotest random failures

2021-11-15 Thread Dumitrescu, Cristian
> -Original Message- > From: David Marchand > Sent: Friday, November 12, 2021 2:16 PM > To: Lincoln Lavoie > Cc: Dumitrescu, Cristian ; dev > ; Aaron Conole ; Thomas Monjalon > ; Yigit, Ferruh ; > c...@dpdk.org > Subject: Re: [dpdk-dev] [Bug 826] red_autotest random failures > > On Fri

RE: [PATCH] test/red: fix typo in comment

2021-11-15 Thread Dumitrescu, Cristian
> -Original Message- > From: David Marchand > Sent: Friday, November 12, 2021 1:57 PM > To: dev@dpdk.org > Cc: Dumitrescu, Cristian ; Singh, Jasvinder > > Subject: [PATCH] test/red: fix typo in comment > > This is probably due a s/red/rte_red/ a long time ago. > > Fixes: de3cfa2c9823

[PATCH] net/iavf: fix VLAN insertion

2021-11-15 Thread Radu Nicolau
Fix wrong VLAN insertion position as inner. Fixes: 1e728b01120c ("net/iavf: rework Tx path") Signed-off-by: Radu Nicolau --- drivers/net/iavf/iavf_rxtx.c | 50 1 file changed, 34 insertions(+), 16 deletions(-) diff --git a/drivers/net/iavf/iavf_rxtx.c b/driv

RE: [PATCH v3] vhost: fix physical address mapping

2021-11-15 Thread Xia, Chenbo
> -Original Message- > From: Ding, Xuan > Sent: Monday, November 15, 2021 4:13 PM > To: Xia, Chenbo ; maxime.coque...@redhat.com > Cc: dev@dpdk.org; Hu, Jiayu ; Wang, YuanX > ; He, Xingguang ; Burakov, > Anatoly > Subject: RE: [PATCH v3] vhost: fix physical address mapping > > Hi Chenbo,

[PATCH v4] vhost: fix physical address mapping

2021-11-15 Thread Xuan Ding
When choosing IOVA as PA mode, IOVA is likely to be discontinuous, which requires page by page mapping for DMA devices. To be consistent, this patch implements page by page mapping instead of mapping at the region granularity for both IOVA as VA and PA mode. Fixes: 7c61fa08b716 ("vhost: enable IOM

Re: [PATCH v3] app/testpmd: fix DCB in VT configuration

2021-11-15 Thread Singh, Aman Deep
On 11/15/2021 8:59 AM, Jie Wang wrote: When set port DCB in VT mode enabled, it should remove RSS HASH offload before reconfiguring the device and queues. Because port multi-queue mode is changed from RSS to DCB in VT. Fixes: 2a977b891f99 ("app/testpmd: fix DCB configuration") Signed-off-by:

Re: [dpdk-dev] [PATCH 1/3] app/testpmd: fix port status of active slave device

2021-11-15 Thread Singh, Aman Deep
On 10/25/2021 12:09 PM, Min Hu (Connor) wrote: From: Huisong Li Stopping a bond device also stops all active slaves under the bond device. If this port is bond device, we need to modify the port status of all slaves from RTE_PORT_STARTED to RTE_PORT_STOPPED. Fixes: 0e545d3047fe ("app/testpmd:

[PATCH v6 01/11] doc: add skeleton for eventdevs feature matrices

2021-11-15 Thread skori
From: Sunil Kumar Kori Patch adds skeleton for feature matrices for event dev and Rx/Tx adapters. Along with, .ini files are added for all supported PMDs. Signed-off-by: Sunil Kumar Kori --- v6: - Rebased to 21.11 rc2 - Added feature matrices for all supported drivers - Added doc vs code ch

[PATCH v6 02/11] doc: update eventdev feature matrix for octeontx

2021-11-15 Thread skori
From: Sunil Kumar Kori Patch updates eventdev and adapters feature matrices for octeontx platform. Signed-off-by: Sunil Kumar Kori --- v6: - Rebased to 21.11 rc2 - Added feature matrices for all supported drivers - Added doc vs code check script v5: - Rebased to 21.11 - Added feature mat

[PATCH v6 03/11] doc: update eventdev feature matrix for octeontx2

2021-11-15 Thread skori
From: Sunil Kumar Kori Patch updates eventdev and adapters feature matrices for octeontx2 platform. Signed-off-by: Sunil Kumar Kori --- v6: - Rebased to 21.11 rc2 - Added feature matrices for all supported drivers - Added doc vs code check script v5: - Rebased to 21.11 - Added feature ma

[PATCH v6 04/11] doc: update eventdev feature matrix for cn9k

2021-11-15 Thread skori
From: Sunil Kumar Kori Patch updates eventdev and adapters feature matrices for cn9k platform. Signed-off-by: Sunil Kumar Kori --- v6: - Rebased to 21.11 rc2 - Added feature matrices for all supported drivers - Added doc vs code check script v5: - Rebased to 21.11 - Added feature matrix

[PATCH v6 05/11] doc: update eventdev feature matrix for cn10k

2021-11-15 Thread skori
From: Sunil Kumar Kori Patch updates eventdev and adapters feature matrices for cn10k platform. Signed-off-by: Sunil Kumar Kori --- v6: - Rebased to 21.11 rc2 - Added feature matrices for all supported drivers - Added doc vs code check script v5: - Rebased to 21.11 - Added feature matrix

[PATCH v6 06/11] doc: update eventdev feature matrix for dpaa

2021-11-15 Thread skori
From: Sunil Kumar Kori Patch updates eventdev and adapters feature matrices for dpaa platform. Signed-off-by: Sunil Kumar Kori --- v6: - Rebased to 21.11 rc2 - Added feature matrices for all supported drivers - Added doc vs code check script v5: - Rebased to 21.11 - Added feature matrix

[PATCH v6 07/11] doc: update eventdev feature matrix for dpaa2

2021-11-15 Thread skori
From: Sunil Kumar Kori Patch updates eventdev and adapters feature matrices for dpaa2 platform. Signed-off-by: Sunil Kumar Kori --- v6: - Rebased to 21.11 rc2 - Added feature matrices for all supported drivers - Added doc vs code check script v5: - Rebased to 21.11 - Added feature matrix

[PATCH v6 08/11] doc: update eventdev feature matrix for SW

2021-11-15 Thread skori
From: Sunil Kumar Kori Patch updates eventdev and adapters feature matrices for sw platform. Signed-off-by: Sunil Kumar Kori --- v6: - Rebased to 21.11 rc2 - Added feature matrices for all supported drivers - Added doc vs code check script v5: - Rebased to 21.11 - Added feature matrix fo

[PATCH v6 09/11] doc: update eventdev feature matrix for opdl

2021-11-15 Thread skori
From: Sunil Kumar Kori Patch updates eventdev and adapters feature matrices for opdl platform. Signed-off-by: Sunil Kumar Kori --- v6: - Rebased to 21.11 rc2 - Added feature matrices for all supported drivers - Added doc vs code check script v5: - Rebased to 21.11 - Added feature matrix

[PATCH v6 10/11] doc: update eventdev feature matrix for dsw

2021-11-15 Thread skori
From: Sunil Kumar Kori Patch updates eventdev and adapters feature matrices for dsw platform. Signed-off-by: Sunil Kumar Kori --- v6: - Rebased to 21.11 rc2 - Added feature matrices for all supported drivers - Added doc vs code check script v5: - Rebased to 21.11 - Added feature matrix f

[PATCH v6 11/11] devtools: check event device doc tables

2021-11-15 Thread skori
From: Sunil Kumar Kori In this commit, check is added for event device, Rx, Tx, Crypto and Timer adapters tables for all supported drivers. Signed-off-by: Sunil Kumar Kori --- v6: - Rebased to 21.11 rc2 - Added feature matrices for all supported drivers - Added doc vs code check script v5:

[PATCH v5 0/1] gpu/cuda: introduce CUDA driver

2021-11-15 Thread eagostini
From: Elena Agostini This is the CUDA implementation of the gpudev library. Funcitonalities implemented through CUDA Driver API are: - Device probe and remove - Manage device memory allocations - Register/unregister external CPU memory in the device memory area Changelog: - CUDA driver implemen

[PATCH v5 1/1] gpu/cuda: introduce CUDA driver

2021-11-15 Thread eagostini
From: Elena Agostini This is the CUDA implementation of the gpudev library. Funcitonalities implemented through CUDA Driver API are: - Device probe and remove - Manage device memory allocations - Register/unregister external CPU memory in the device memory area Signed-off-by: Elena Agostini --

[PATCH v2] net/mlx5: fix missing RSS validation with meter policy

2021-11-15 Thread Bing Zhao
The RSS can be one of the fate actions when creating a meter with policy. In the previous implementation, the RSS validation was missed when creating a flow rule with such meter due to the fact that a policy meter was created firstly and then used in the rule. In the stage of meter creation, no rte

[PATCH v1] app/test-gpudev: improve tests' output

2021-11-15 Thread eagostini
From: Elena Agostini Signed-off-by: Elena Agostini --- app/test-gpudev/main.c | 90 ++ 1 file changed, 55 insertions(+), 35 deletions(-) diff --git a/app/test-gpudev/main.c b/app/test-gpudev/main.c index 1db3f69e10..e42133b3aa 100644 --- a/app/test-gpude

release schedule change proposal

2021-11-15 Thread Thomas Monjalon
For the last 5 years, DPDK was doing 4 releases per year, in February, May, August and November (the LTS one): .02 .05 .08 .11 (LTS) This schedule has multiple issues: - clash with China's Spring Festival - too many rushes, impacting maintainers & testers - no

Re: [PATCH v11 0/5] drivers/net: add NXP ENETFEC driver

2021-11-15 Thread Ferruh Yigit
On 11/15/2021 7:19 AM, Apeksha Gupta wrote: This patch series introduce the enetfec driver, ENETFEC (Fast Ethernet Controller) is a network poll mode driver for the inbuilt NIC found in the NXP i.MX 8M Mini SoC. An overview of the enetfec driver with probe and remove are in patch 1. Patch 2 desi

Re: [dpdk-dev] [PATCH] ethdev: fine tune error reporting in pick transfer proxy API

2021-11-15 Thread Thomas Monjalon
15/11/2021 15:15, Ivan Malov: > On Wed, 10 Nov 2021, Ferruh Yigit wrote: > > > On 11/2/2021 5:04 PM, David Marchand wrote: > >> On Tue, Nov 2, 2021 at 4:59 PM Andrew Rybchenko > >> wrote: > > IMHO, spamming of testpmd logs in described case should be fixed > > in testpmd itself to avoid l

Re: release schedule change proposal

2021-11-15 Thread Luca Boccassi
On Mon, 2021-11-15 at 15:58 +0100, Thomas Monjalon wrote: > For the last 5 years, DPDK was doing 4 releases per year, > in February, May, August and November (the LTS one): > .02 .05 .08 .11 (LTS) > > This schedule has multiple issues: > - clash with China's Spring Festival >

Re: [PATCH v1] app/testpmd: avoid the process ID out of range

2021-11-15 Thread Ferruh Yigit
On 11/15/2021 8:56 AM, Min Hu (Connor) wrote: 在 2021/11/15 14:05, Haiyue Wang 写道: The 'proc-id' should be less than 'num-procs', if not, exit the testpmd and show the error message. Fixes: a550baf24af9 ("app/testpmd: support multi-process") Signed-off-by: Haiyue Wang > Acked-by: Min Hu (Co

Re: [PATCH v2] net/nfb: update links in documentation

2021-11-15 Thread Ferruh Yigit
On 11/11/2021 6:39 AM, Martin Spinler wrote: On Wed, 2021-11-10 at 16:12 +, Ferruh Yigit wrote: On 11/10/2021 3:39 PM, Martin Spinler wrote: Update the software dependency link because of website shutdown. Netcope Technologies was recently renamed to Magmio and no longer provides packages

RE: [dpdk-dev] [PATCH] ethdev: fine tune error reporting in pick transfer proxy API

2021-11-15 Thread Ori Kam
> -Original Message- > From: Thomas Monjalon > Sent: Monday, November 15, 2021 5:09 PM > Subject: Re: [dpdk-dev] [PATCH] ethdev: fine tune error reporting in pick > transfer proxy API > > 15/11/2021 15:15, Ivan Malov: > > On Wed, 10 Nov 2021, Ferruh Yigit wrote: > > > > > On 11/2/2021

Re: release schedule change proposal

2021-11-15 Thread Jerin Jacob
On Mon, Nov 15, 2021 at 8:42 PM Luca Boccassi wrote: > > On Mon, 2021-11-15 at 15:58 +0100, Thomas Monjalon wrote: > > For the last 5 years, DPDK was doing 4 releases per year, > > in February, May, August and November (the LTS one): > > .02 .05 .08 .11 (LTS) > > > > This schedule has

Re: [PATCH v2] net/szedata2: remove driver

2021-11-15 Thread Ferruh Yigit
On 11/11/2021 9:26 AM, Ferruh Yigit wrote: On 11/11/2021 9:08 AM, Martin Spinler wrote: On Wed, 2021-11-10 at 16:08 +, Ferruh Yigit wrote: On 11/10/2021 3:39 PM, Martin Spinler wrote: Remove the szedata2 device driver as the platform is no longer supported. Signed-off-by: Martin Spinler

Re: release schedule change proposal

2021-11-15 Thread Kevin Traynor
On 15/11/2021 14:58, Thomas Monjalon wrote: For the last 5 years, DPDK was doing 4 releases per year, in February, May, August and November (the LTS one): .02 .05 .08 .11 (LTS) This schedule has multiple issues: - clash with China's Spring Festival - too many rushes

Re: [PATCH v3] app/testpmd: fix DCB in VT configuration

2021-11-15 Thread Ferruh Yigit
On 11/15/2021 12:46 PM, Singh, Aman Deep wrote: On 11/15/2021 8:59 AM, Jie Wang wrote: When set port DCB in VT mode enabled, it should remove RSS HASH offload before reconfiguring the device and queues. Because port multi-queue mode is changed from RSS to DCB in VT. Fixes: 2a977b891f99 ("app/

[PATCH v2] event/dlb2: fix delayed_pop test in dlb2_selftest

2021-11-15 Thread Rashmi Shetty
Number of events scheduled and available for dequeue after token pop was set to dequeue_depth-1 instead of dequeue_depth in test_delayed_pop. The expectation is that all dequeue_depth number of events can be dequeued once the last event is released. Fixes: a10e8e96865f ("event/dlb2: add delayed to

Re: [PATCH] ethdev: fix typos

2021-11-15 Thread Ferruh Yigit
On 11/15/2021 8:32 AM, Ori Kam wrote: Hi -Original Message- From: Ferruh Yigit Sent: Friday, November 12, 2021 2:14 PM Subject: [PATCH] ethdev: fix typos Signed-off-by: Ferruh Yigit Acked-by: Ori Kam Fixes: 9039c8125730 ("ethdev: change promiscuous callbacks to return stat

Re: release schedule change proposal

2021-11-15 Thread Stephen Hemminger
On Mon, 15 Nov 2021 15:58:15 +0100 Thomas Monjalon wrote: > For the last 5 years, DPDK was doing 4 releases per year, > in February, May, August and November (the LTS one): > .02 .05 .08 .11 (LTS) > > This schedule has multiple issues: > - clash with China's Spring Festival >

Re: [PATCH 1/2] net/af_xdp: revert use BPF link for XDP programs

2021-11-15 Thread Ferruh Yigit
On 11/12/2021 10:30 AM, Ciara Loftus wrote: The commit ae70cc6e893b ("net/af_xdp: use BPF link for XDP programs") caused compilation errors on kernels older than v5.8 due to absence of the bpf_link_info struct and some definitions in the linux/bpf.h header. Since relying on the reported kernel ve

Re: release schedule change proposal

2021-11-15 Thread Shepard Siegel
> Opinions? Atomic Rules has been releasing our Arkville product in lockstep with DPDK for the past 19 quarters. Our FPGA solution has the added burden of testing with async releases of FPGA vendor CAD tools. Although we have gotten used to the quarterly cadence, for the reasons given by Thomas an

RE: [dpdk-dev] [Bug 826] red_autotest random failures

2021-11-15 Thread Liguzinski, WojciechX
Hi, Sure, I will have a look. Best Regards, Wojciech -Original Message- From: Dumitrescu, Cristian Sent: Monday, November 15, 2021 12:51 PM To: David Marchand ; Lincoln Lavoie ; Liguzinski, WojciechX ; Ajmera, Megha ; Singh, Jasvinder Cc: dev ; Aaron Conole ; Thomas Monjalon ; Yi

Re: [PATCH 1/2] net/hns3: optimized Tx performance by mbuf fast free

2021-11-15 Thread Ferruh Yigit
On 11/11/2021 1:38 PM, Min Hu (Connor) wrote: From: Chengwen Feng Currently the vector and simple xmit algorithm don't support multi_segs, so if Tx offload support MBUF_FAST_FREE, driver could invoke rte_mempool_put_bulk() to free Tx mbufs in this situation. In the testpmd single core MAC forw

Re: [PATCH 2/2] net/hns3: optimized Tx performance

2021-11-15 Thread Ferruh Yigit
On 11/11/2021 1:38 PM, Min Hu (Connor) wrote: From: Chengwen Feng The PMD should check whether the descriptor is done by hardware before free the corresponding mbuf. Currently the common xmit algorithm will free mbuf every time when it's invoked. Because hardware may not have finished sending, t

Re: [dpdk-dev] [PATCH] ethdev: fine tune error reporting in pick transfer proxy API

2021-11-15 Thread Ivan Malov
On Wed, 10 Nov 2021, Ferruh Yigit wrote: On 11/2/2021 5:04 PM, David Marchand wrote: On Tue, Nov 2, 2021 at 4:59 PM Andrew Rybchenko wrote: IMHO, spamming of testpmd logs in described case should be fixed in testpmd itself to avoid logs in the case of ENOTSUP. That's it. I think we should n

RE: release schedule change proposal

2021-11-15 Thread Asaf Penso
>-Original Message- >From: Jerin Jacob >Sent: Monday, November 15, 2021 5:39 PM >To: Luca Boccassi >Cc: NBU-Contact-Thomas Monjalon ; dpdk-dev >; us...@dpdk.org >Subject: Re: release schedule change proposal > >On Mon, Nov 15, 2021 at 8:42 PM Luca Boccassi wrote: >> >> On Mon, 2021-11-15

[PATCH 0/6] fix unused but set variables

2021-11-15 Thread Conor Walsh
When DPDK is compiled with clang 13, several warnings for unused but set variables are present. This patchset fixes these warnings, which were present within: - app/test - drivers/bus/fslmc - drivers/common/qat - drivers/event/sw - drivers/net - examples/performance-thread This patchset is

[PATCH 1/6] app/test: fix unused but set variables

2021-11-15 Thread Conor Walsh
This patch fixes unused but set variables within the following test apps: - test distributor perf - test thash perf Bugzilla ID: 881 Fixes: c0de0eb82e40 ("distributor: switch over to new API") Fixes: 239fffe0402e ("test/thash: add performance tests for Toeplitz hash") Cc: sta...@dpdk.org Report

[PATCH 2/6] drivers/bus/fslmc: fix unused but set variables

2021-11-15 Thread Conor Walsh
This patch removes the device_count variable from the rte_fslmc_scan function within the fslmc bus driver as it is an unused but set variable. Bugzilla ID: 881 Fixes: 828d51d8fc3e ("bus/fslmc: refactor scan and probe functions") Cc: sta...@dpdk.org Reported-by: Liang Longfeng Signed-off-by: Cono

[PATCH 4/6] drivers/event/sw: fix unused but set variables

2021-11-15 Thread Conor Walsh
This patch removes the inflights variable from the sw_dump function within the software section of the event driver as it is an unused but set variable. Bugzilla ID: 881 Fixes: c66baa68e453 ("event/sw: add dump function for easier debugging") Cc: sta...@dpdk.org Reported-by: Liang Longfeng Signe

[PATCH 3/6] drivers/common/qat: fix unused but set variables

2021-11-15 Thread Conor Walsh
This patch removes the us variable from the qat_pf2vf_exch_msg function within the PF to VF section of the QAT driver as it is an unused but set variable. Bugzilla ID: 881 Fixes: b17d16fb47b4 ("common/qat: add PF to VF communication") Cc: sta...@dpdk.org Reported-by: Liang Longfeng Signed-off-by

[PATCH 5/6] drivers/net: fix unused but set variables

2021-11-15 Thread Conor Walsh
This patch fixes unused but set variables in the following net drivers: - bnxt - hinic - liquidio - nfp - octeontx - qede - txgbe - vmxnet3 Bugzilla ID: 881 Fixes: b87abb2e55cb ("net/bnxt: support marking packet") Fixes: 88badb3aef94 ("net/bnxt: add helper functions for blob/regfile ops")

[PATCH 6/6] examples/performance-thread: fix unused but set variables

2021-11-15 Thread Conor Walsh
This patch removes the hits variable from the cpu_load_collector function within the performance thread example app as it is an unused but set variable. Bugzilla ID: 881 Fixes: d48415e1fee3 ("examples/performance-thread: add l3fwd-thread app") Cc: sta...@dpdk.org Reported-by: Liang Longfeng Sign

Re: [dpdk-dev] [PATCH v5 1/4] doc: add skeleton for eventdevs feature matrices

2021-11-15 Thread Jerin Jacob
On Fri, Oct 22, 2021 at 1:18 PM wrote: > > From: Sunil Kumar Kori > > Patch adds skeleton for feature matrices for event dev > and Rx/Tx adapters. > > Along with, .ini files are added for all supported PMDs. > > Signed-off-by: Sunil Kumar Kori Please fix the below. doc out of sync for dsw

[PATCH 0/2] net/bnxt: minor performance fixes for AVX2 Rx

2021-11-15 Thread Lance Richardson
This series contains two minor performance fixes for the bnxt AVX2 vecgtorized burst receive function. Lance Richardson (2): net/bnxt: avoid unnecessary work in AVX2 Rx path net/bnxt: remove software prefetches from AVX2 Rx path drivers/net/bnxt/bnxt_rxtx_vec_avx2.c | 16 +++- 1

[PATCH 1/2] net/bnxt: avoid unnecessary work in AVX2 Rx path

2021-11-15 Thread Lance Richardson
Each call to the AVX2 vector burst receive function makes at least one pass through the function's inner loop, loading 256 bytes of completion descriptors and copying 8 rte_mbuf pointers regardless of whether there are any packets to be received. Unidirectional forwarding performance is improved b

[PATCH 2/2] net/bnxt: remove software prefetches from AVX2 Rx path

2021-11-15 Thread Lance Richardson
Testing has shown no performance benefit from software prefetching of receive completion descriptors in the AVX2 burst receive path, and slightly better performance without them on some CPU families, so this patch removes them. Fixes: c4e4c18963b0 ("net/bnxt: add AVX2 RX/Tx") Cc: sta...@dpdk.org S

[PATCH] eal/ppc: support ASan

2021-11-15 Thread David Christensen
Add support for Address Sanitizer (ASan) for PPC/POWER architecture. Signed-off-by: David Christensen --- config/meson.build | 2 +- doc/guides/prog_guide/asan.rst | 4 ++-- lib/eal/common/malloc_elem.h | 2 ++ 3 files changed, 5 insertions(+), 3 deletions(-) diff --git a/config/m

Re: [PATCH V2] app/testpmd: fix parameters order when calling rte_ether_addr_copy()

2021-11-15 Thread Ferruh Yigit
On 11/11/2021 2:29 AM, Xu, Wei1 wrote: Running in 'csum' mode, the 'from' and 'to' parameters are not in the correct order when calling rte_ether_addr_copy() which means the 'src/dst' mac addresses in the mbuf will be overwriten. Hi Wei, Original code looks good. What are you trying to fix ex

Re: [dpdk-dev] [PATCH v2] app/testpmd: fix gtp psc extension header length

2021-11-15 Thread Ferruh Yigit
On 11/4/2021 9:40 AM, Raslan Darawsheh wrote: Current implementation for raw encap sets the length to be in bytes, but, GTP 'extension' header length is an 8-bit field in 4-octet units. This fixes the length calculation of the header length. Fixes: 9213c50e36fa ("app/testpmd: support GTP PSC op

Re: [PATCH] eal/ppc: support ASan

2021-11-15 Thread David Marchand
On Mon, Nov 15, 2021 at 7:41 PM David Christensen wrote: > > Add support for Address Sanitizer (ASan) for PPC/POWER architecture. > > Signed-off-by: David Christensen > --- > config/meson.build | 2 +- > doc/guides/prog_guide/asan.rst | 4 ++-- > lib/eal/common/malloc_elem.h | 2 ++

[PATCH v2] eal/ppc: support ASan

2021-11-15 Thread David Christensen
Add support for Address Sanitizer (ASan) for PPC/POWER architecture. Signed-off-by: David Christensen --- v2: Removed architecture test, modified programmer's guide text config/meson.build | 2 +- doc/guides/prog_guide/asan.rst | 6 +++--- lib/eal/common/malloc_elem.h | 2 ++ 3 fi

[PATCH v2] checkpatches: suppress warning about strlcpy

2021-11-15 Thread Stephen Hemminger
Current version of Linux kernel checkpatch now complains about usages of strlcpy because the Linux kernel perfers strcspy. WARNING:STRLCPY: Prefer strscpy over strlcpy But DPDK project allows strlcpy, therefore suppress the warning. Signed-off-by: Stephen Hemminger Acked-by: Bruce Richardson -

[PATCH v3] test/bpf_convert: do not require DNS lookup

2021-11-15 Thread Stephen Hemminger
These tests were using strings with hostname (dpdk.org) and this makes test code do a DNS lookup. In container environment used for OpenSuse build, DNS is unavailable. Replace dpdk.org with an IPv4 address reserved for documentation (RFC 5737) and use IPv6 in one example (RFC 3849). Actual addresse

Re: [dpdk-dev] [PATCH] kni: remove non-C11 path from FIFO sync

2021-11-15 Thread Ferruh Yigit
On 8/19/2021 7:04 AM, Joyce Kong wrote: Non-C11 path was meant to not break build with GCC version < 4.7(when C11 atomics were introduced), while now minimum GCC version supported by DPDK has been 4.9, C11 atomics support in compiler is no longer a problem. So non-C11 path can be removed. As fa

[PATCH v3] checkpatches: suppress warning about strlcpy

2021-11-15 Thread Stephen Hemminger
Current version of Linux kernel checkpatch now complains about usages of strlcpy because the Linux kernel prefers strcspy. WARNING:STRLCPY: Prefer strscpy over strlcpy But DPDK project allows strlcpy, therefore suppress the warning. Signed-off-by: Stephen Hemminger Acked-by: Bruce Richardson -

[PATCH v4] test/bpf_convert: do not require DNS lookup

2021-11-15 Thread Stephen Hemminger
These tests were using strings with hostname (dpdk.org) and this makes test code do a DNS lookup. In container environment used for OpenSuse build, DNS is unavailable. Replace dpdk.org with an IPv4 address reserved for documentation (RFC5737) and use IPv6 in one example (RFC3849). Actual addresses

[PATCH v5] test/bpf_convert: do not require DNS lookup

2021-11-15 Thread Stephen Hemminger
These tests were using strings with hostname (dpdk.org) and this makes test code do a DNS lookup. In container environment used for OpenSuse build, DNS is unavailable. Replace dpdk.org with an IPv4 address reserved for documentation (RFC5737) and use IPv6 in one example (RFC3849). Actual addresses

ethdev: hide internal structures

2021-11-15 Thread Tyler Retzlaff
hi folks, I don't understand the text of this change. would you mind explaining? commit f9bdee267ab84fd12dc288419aba341310b6ae08 Author: Konstantin Ananyev Date: Wed Oct 13 14:37:04 2021 +0100 ethdev: hide internal structures +* ethdev: Made ``rte_eth_

RE: [PATCH] net/ice/base: fix wrong defines of GTPU UL/DL flag

2021-11-15 Thread Zhang, Qi Z
> -Original Message- > From: Guo, Junfeng > Sent: Friday, November 12, 2021 4:50 PM > To: Zhang, Qi Z ; Wu, Jingjing ; > Xing, Beilei > Cc: dev@dpdk.org; sta...@dpdk.org; Yigit, Ferruh ; > Guo, Junfeng ; Xu, Ting > Subject: [PATCH] net/ice/base: fix wrong defines of GTPU UL/DL flag >

Re: [dpdk-dev] [PATCH 1/3] app/testpmd: fix port status of active slave device

2021-11-15 Thread lihuisong (C)
在 2021/11/15 21:01, Singh, Aman Deep 写道: On 10/25/2021 12:09 PM, Min Hu (Connor) wrote: From: Huisong Li Stopping a bond device also stops all active slaves under the bond device. If this port is bond device, we need to modify the port status of all slaves from RTE_PORT_STARTED to RTE_PORT

RE: [PATCH v2] net/ice: fix secondary process Rx offload path

2021-11-15 Thread Zhang, Qi Z
> -Original Message- > From: Zhang, AlvinX > Sent: Monday, November 15, 2021 10:06 AM > To: Zhang, Qi Z ; Rong, Leyi > Cc: dev@dpdk.org; Zhang, AlvinX ; sta...@dpdk.org > Subject: [PATCH v2] net/ice: fix secondary process Rx offload path > > Secondary process depends on the vector off

[PATCH v2 0/2] performance optimized for hns3 PMD

2021-11-15 Thread Min Hu (Connor)
This patch set contains two ways to optimized Tx performance. Chengwen Feng (2): net/hns3: optimized Tx performance by mbuf fast free net/hns3: optimized Tx performance doc/guides/nics/features/hns3.ini | 1 + drivers/net/hns3/hns3_rxtx.c | 129 +++--- drivers/

[PATCH v2 2/2] net/hns3: optimized Tx performance

2021-11-15 Thread Min Hu (Connor)
From: Chengwen Feng This patch uses tx_free_thresh to control mbufs free when the common xmit algorithm is used. This patch also modifies the implementation of PMD's tx_done_cleanup because the mbuf free algorithm changed. In the testpmd single core MAC forwarding scenario, the performance is i

[PATCH v2 1/2] net/hns3: optimized Tx performance by mbuf fast free

2021-11-15 Thread Min Hu (Connor)
From: Chengwen Feng Currently the vector and simple xmit algorithm don't support multi_segs, so if Tx offload support MBUF_FAST_FREE, driver could invoke rte_mempool_put_bulk() to free Tx mbufs in this situation. In the testpmd single core MAC forwarding scenario, the performance is improved by

Re: [PATCH 1/2] net/hns3: optimized Tx performance by mbuf fast free

2021-11-15 Thread Min Hu (Connor)
Hi, Ferruh, fixed in v2, thanks. 在 2021/11/16 1:30, Ferruh Yigit 写道: On 11/11/2021 1:38 PM, Min Hu (Connor) wrote: From: Chengwen Feng Currently the vector and simple xmit algorithm don't support multi_segs, so if Tx offload support MBUF_FAST_FREE, driver could invoke rte_mempool_put_bulk() t

RE: [dpdk-dev] [PATCH] doc: update release notes for DCF reset API

2021-11-15 Thread Zhang, Qi Z
> -Original Message- > From: dev On Behalf Of dapengx...@intel.com > Sent: Wednesday, November 10, 2021 4:59 PM > Cc: dev@dpdk.org; Yigit, Ferruh ; Yu, DapengX > > Subject: [dpdk-dev] [PATCH] doc: update release notes for DCF reset API > > From: Dapeng Yu > > The ice DCF device rese

RE: [PATCH v2] net/ice: fix secondary process Rx offload path

2021-11-15 Thread Zhang, AlvinX
> -Original Message- > From: Zhang, Qi Z > Sent: Tuesday, November 16, 2021 9:22 AM > To: Zhang, AlvinX ; Rong, Leyi > Cc: dev@dpdk.org; sta...@dpdk.org > Subject: RE: [PATCH v2] net/ice: fix secondary process Rx offload path > > > > > -Original Message- > > From: Zhang, AlvinX

[PATCH v3] net/ice: fix secondary process Rx offload path

2021-11-15 Thread Alvin Zhang
Secondary process depends on the vector offload flag to select right Rx offload path. This patch adds a variable in share memory to store the vector offload flag that can be directly read by secondary process. Fixes: 808a17b3c1e6 ("net/ice: add Rx AVX512 offload path") Cc: sta...@dpdk.org Signed-

RE: [PATCH v3] net/ice: fix secondary process Rx offload path

2021-11-15 Thread Sun, QinX
> -Original Message- > From: Alvin Zhang > Sent: Tuesday, November 16, 2021 10:32 AM > To: Zhang, Qi Z ; Rong, Leyi > Cc: dev@dpdk.org; Zhang, AlvinX ; > sta...@dpdk.org > Subject: [PATCH v3] net/ice: fix secondary process Rx offload path > > Secondary process depends on the vector offlo

RE: [PATCH v3] net/ice: fix secondary process Rx offload path

2021-11-15 Thread Zhang, Qi Z
> -Original Message- > From: Sun, QinX > Sent: Tuesday, November 16, 2021 11:09 AM > To: Zhang, AlvinX ; Zhang, Qi Z > ; Rong, Leyi > Cc: dev@dpdk.org; Zhang, AlvinX ; sta...@dpdk.org > Subject: RE: [PATCH v3] net/ice: fix secondary process Rx offload path > > > -Original Message-

[PATCH v1] examples/l3fwd-power: add wakeup log

2021-11-15 Thread Miao Li
This patch adds a log in main telemetry loop to show the thread is waked up and begins to send and receive packets. Signed-off-by: Miao Li --- examples/l3fwd-power/main.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/examples/l3fwd-power/main.c b/examples/l3fwd-power/main.c index 6988a0

Re: [PATCH 5/7] drivers/net: fix unused but set variables

2021-11-15 Thread Somnath Kotur
On Mon, Nov 15, 2021 at 2:58 PM David Marchand wrote: > > Hello Ajit, Somnath, > > On Fri, Nov 12, 2021 at 3:02 PM Conor Walsh wrote: > > > > This patch fixes unused but set variables in the following net drivers: > > - bnxt > > - hinic > > - liquidio > > - nfp > > - octeontx > > - qede > >

Re: [PATCH 5/7] drivers/net: fix unused but set variables

2021-11-15 Thread Ajit Khaparde
On Mon, Nov 15, 2021 at 8:58 PM Somnath Kotur wrote: > > On Mon, Nov 15, 2021 at 2:58 PM David Marchand > wrote: > > > > Hello Ajit, Somnath, > > > > On Fri, Nov 12, 2021 at 3:02 PM Conor Walsh wrote: > > > > > > This patch fixes unused but set variables in the following net drivers: > > > - bn

  1   2   >