Re: [PATCH 1/1] net/cnxk: add outb soft expiry notification support

2022-02-24 Thread Jerin Jacob
On Thu, Feb 24, 2022 at 11:41 AM Vamsi Attunuru wrote: > > Patch implements soft expiry notification mechanism in out bound outbound > path by creating required number of ring buffers and a common poll > thread which polls for soft expiry events enqueued by ucode. ucode -> microcode. Subject s

[PATCH 1/2] net/cnxk: add callback handler to read ptp timestamp

2022-02-24 Thread Rakesh Kudurumalla
timestamp resolution for an incoming and outgoing packets is different for CN10k and CN9K.Added platform specific callback to retrieve timestamp in correct format when read by application Signed-off-by: Rakesh Kudurumalla --- drivers/net/cnxk/cn10k_ethdev.c | 23 +++ drivers/

[PATCH 2/2] event/cnxk: add callback handler to read ptp timestamp

2022-02-24 Thread Rakesh Kudurumalla
timestamp resolution for an incoming and outgoing packets is different for CN10k and CN9K.Added platform specific callback to retrieve timestamp in correct format when read by application Signed-off-by: Rakesh Kudurumalla --- drivers/event/cnxk/cn10k_worker.h | 4 ++-- drivers/event/cnxk/cn9k_w

Re: [PATCH v10 01/11] ethdev: introduce flow engine configuration

2022-02-24 Thread Andrew Rybchenko
On 2/23/22 06:02, Alexander Kozyrev wrote: The flow rules creation/destruction at a large scale incurs a performance penalty and may negatively impact the packet processing when used as part of the datapath logic. This is mainly because software/hardware resources are allocated and prepared durin

Re: [PATCH v10 02/11] ethdev: add flow item/action templates

2022-02-24 Thread Andrew Rybchenko
On 2/23/22 06:02, Alexander Kozyrev wrote: Treating every single flow rule as a completely independent and separate entity negatively impacts the flow rules insertion rate. Oftentimes in an application, many flow rules share a common structure (the same item mask and/or action list) so they can b

[PATCH] net/cnxk: update RSS RETA table

2022-02-24 Thread Rakesh Kudurumalla
rss reta table is corrupted during rte_eth_dev_rss_reta_update.This fix restores previous table entries before updating. Fixes: 00242a687de ("net/cnxk: support RETA and RSS hash") Cc: sta...@dpdk.org Signed-off-by: Rakesh Kudurumalla --- drivers/net/cnxk/cnxk_ethdev_ops.c | 2 ++ 1 file changed

Re: [PATCH v10 03/11] ethdev: bring in async queue-based flow rules operations

2022-02-24 Thread Andrew Rybchenko
On 2/23/22 06:02, Alexander Kozyrev wrote: A new, faster, queue-based flow rules management mechanism is needed for applications offloading rules inside the datapath. This asynchronous and lockless mechanism frees the CPU for further packet processing and reduces the performance impact of the flo

Re: [PATCH v10 04/11] ethdev: bring in async indirect actions operations

2022-02-24 Thread Andrew Rybchenko
On 2/23/22 06:02, Alexander Kozyrev wrote: Queue-based flow rules management mechanism is suitable not only for flow rules creation/destruction, but also for speeding up other types of Flow API management. Indirect action object operations may be executed asynchronously as well. Provide async ver

RE: [PATCH v2 0/6] mlx5: external RxQ support

2022-02-24 Thread Matan Azrad
From: Michael Baum > These patches add support to external Rx queues. > External queue is a queue that is managed by a process external to PMD, but > uses PMD process to generate its flow rules. > > For the hardware to allow the DPDK process to set rules for it, the process > needs > to use th

RE: [PATCH v1] drivers: fix incorrect E-Switch manager vport ID

2022-02-24 Thread Raslan Darawsheh
Hi, > -Original Message- > From: Ferruh Yigit > Sent: Wednesday, February 23, 2022 9:00 PM > To: Raslan Darawsheh ; Shun Hao > ; Matan Azrad ; Slava Ovsiienko > ; Ori Kam ; NBU-Contact- > Thomas Monjalon (EXTERNAL) ; Xueming(Steven) > Li > Cc: dpdk-dev ; sta...@dpdk.org > Subject: Re: [P

[PATCH] devtools: add E-Switch keyword for commit checks

2022-02-24 Thread Raslan Darawsheh
This adds the syntax for E-Switch to have check on how it suppose to be for commits Signed-off-by: Raslan Darawsheh --- devtools/words-case.txt | 1 + 1 file changed, 1 insertion(+) diff --git a/devtools/words-case.txt b/devtools/words-case.txt index bc33470532..1146706e54 100644 --- a/devtools

Re: [PATCH] app/testpmd: skip stopped queues when forwarding

2022-02-24 Thread Thomas Monjalon
21/02/2022 09:58, Dmitry Kozlyuk: > Andrew, Ferruh, Thomas, which behavior does ethdev assume (see below)? For the whole device stop, this is the documentation: " The transmit and receive functions should not be invoked when the device is stopped. " There is also this comment on rte_eth_dev_r

Re: [PATCH] devtools: add E-Switch keyword for commit checks

2022-02-24 Thread Thomas Monjalon
24/02/2022 10:26, Raslan Darawsheh: > This adds the syntax for E-Switch to have check on how > it suppose to be for commits [...] > +E-Switch It looks Mellanox people use this syntax in Linux kernel as well. Where does it come from? Is it a Mellanox-only wording? Intuitively, I would have written

[PATCH v2 1/1] net/cnxk: support outbound soft expiry notification

2022-02-24 Thread Vamsi Attunuru
Patch implements soft expiry notification mechanism in outbound path by creating required number of ring buffers and a common poll thread which polls for soft expiry events enqueued by microcode. Signed-off-by: Vamsi Attunuru --- v2: fix subject and commit message. --- drivers/common/cnxk/roc_id

[PATCH 1/3] common/cnxk: enable packet marking

2022-02-24 Thread skoteshwar
From: Satha Rao cnxk platforms supports packet marking when TM enabled with valid shaper rates. VLAN DEI, IP ECN, or IP DSCP inside packet will be updated based on mark flags selected. Signed-off-by: Satha Rao --- drivers/common/cnxk/meson.build | 1 + drivers/common/cnxk/roc_nix.h

[PATCH 2/3] net/cnxk: event/cnxk: enable packet marking callbacks

2022-02-24 Thread skoteshwar
From: Satha Rao cnxk platform supports red/yellow packet marking based on TM configuration. This patch set hooks to enable/disable packet marking for VLAN DEI, IP DSCP and IP ECN. Marking enabled only in scalar mode. Signed-off-by: Satha Rao --- drivers/event/cnxk/cn10k_worker.h | 3 +- dri

[PATCH 3/3] common/cnxk: check SQ node before setting bp config

2022-02-24 Thread skoteshwar
From: Satha Rao Validate sq_node and parent before accessing their fields. SQ was created without any associated TM node, this is valid negative case, so return success while stopping TM without SQ node. Signed-off-by: Satha Rao --- drivers/common/cnxk/roc_nix_tm.c | 8 ++-- drivers/co

[PATCH] net/cnxk: remove unused files after template rework

2022-02-24 Thread Nithin Dabilpuram
Remove unused files that were left over after Rx and Tx template function rework. Fixes: 5169508a68fa ("net/cnxk: add cn9k template Rx functions to build") Fixes: dd8c20eee472 ("net/cnxk: add cn9k template Tx functions to build") Fixes: be294749a12a ("net/cnxk: add cn10k template Rx functions to b

RE: [EXT] [PATCH v2 0/4] ipsec_mb fixes for ZUC algorithm

2022-02-24 Thread Akhil Goyal
> This patchset fixes various issues affecting ZUC and AESNI MB PMD, > when ZUC algorithm is used. > > -v2: rebased on main branch > > Pablo de Lara (4): > crypto/ipsec_mb: check for missing operation types > crypto/ipsec_mb: fix ZUC authentication verify > crypto/ipsec_mb: fix crypto opera

RE: [EXT] [PATCH] doc: support IPsec Multi-buffer lib v1.2

2022-02-24 Thread Akhil Goyal
> Updated AESNI MB and AESNI GCM, KASUMI, ZUC and SNOW3G PMD > documentation > guides with information about the latest Intel IPSec Multi-buffer > library supported. > > Signed-off-by: Pablo de Lara > --- Applied to dpdk-next-crypto

[PATCH] common/cnxk: show more detailed info on model mismatch

2022-02-24 Thread Tomasz Duszynski
Model is uniquely identified by 4 numbers. Print them all in case model being populated is not on a list of known models. This makes debugging a bit easier. Signed-off-by: Tomasz Duszynski Reviewed-by: Jakub Palider Reviewed-by: Jerin Jacob Kollanukkaran --- drivers/common/cnxk/roc_model.c | 3

[PATCH] common/cnxk: support B0 variant

2022-02-24 Thread Tomasz Duszynski
Add B0 variant to the list of supported models. Signed-off-by: Tomasz Duszynski Reviewed-by: Jerin Jacob Kollanukkaran --- drivers/common/cnxk/roc_model.c | 1 + drivers/common/cnxk/roc_model.h | 6 -- 2 files changed, 5 insertions(+), 2 deletions(-) diff --git a/drivers/common/cnxk/roc_mo

[PATCH v3 0/3] net/mlx5: support send scheduling for ConnectX-7

2022-02-24 Thread Viacheslav Ovsiienko
Since the ConnectX-6DX the send scheduling capability is provided. An application can register the dynamic field and dynamic flags in mbuf for timestamp and specify the desired moment of time the packet should sent. The send scheduling feature over ConnectX-6DX uses the complicated infrastructure

[PATCH v3 1/3] common/mlx5: add send on time capability check

2022-02-24 Thread Viacheslav Ovsiienko
The patch provides check for send scheduling on time hardware capability. With this capability enabled hardware is able to handle Wait WQEs with directly specified timestamp values. No Clock Queue is needed anymore to handle send scheduling. Signed-off-by: Viacheslav Ovsiienko --- drivers/common

[PATCH v3 2/3] net/mlx5: configure Tx queue with send on time offload

2022-02-24 Thread Viacheslav Ovsiienko
The wait on time configuration flag is copied to the Tx queue structure due to performance considerations. Timestamp mask is preparted and stored in queue structure as well. Signed-off-by: Viacheslav Ovsiienko --- drivers/net/mlx5/linux/mlx5_verbs.c | 4 drivers/net/mlx5/mlx5.h

[PATCH v3 3/3] net/mlx5: add wait on time support in Tx datapath

2022-02-24 Thread Viacheslav Ovsiienko
The hardware since ConnectX-7 supports waiting on specified moment of time with new introduced wait descriptor. A timestamp can be directly placed into descriptor and pushed to sending queue. Once hardware encounter the wait descriptor the queue operation is suspended till specified moment of time.

RE: [PATCH v2 4/4] doc: update send scheduling mlx5 feature description

2022-02-24 Thread Slava Ovsiienko
> -Original Message- > From: Ferruh Yigit > Sent: Wednesday, February 23, 2022 20:56 > To: Slava Ovsiienko ; dev@dpdk.org > Cc: Matan Azrad ; Raslan Darawsheh > > Subject: Re: [PATCH v2 4/4] doc: update send scheduling mlx5 feature > description > > On 2/22/2022 10:26 AM, Viacheslav Ovsi

RE: [PATCH 2/2] lib/ethdev: add reverse macro to quit testpmd

2022-02-24 Thread Wu, WenxuanX
> -Original Message- > From: Yigit, Ferruh > Sent: 2022年2月19日 1:05 > To: Wu, WenxuanX ; Yang, Qiming > ; Zhang, Qi Z ; Li, Xiaoyun > ; Singh, Aman Deep ; > Zhang, Yuying > Cc: dev@dpdk.org > Subject: Re: [PATCH 2/2] lib/ethdev: add reverse macro to quit testpmd > > On 2/17/2022 10:14 AM,

RE: [PATCH v5 0/2] Add config file support for l3fwd

2022-02-24 Thread Ananyev, Konstantin
> > 22/02/2022 16:13, Ananyev, Konstantin: > > > > > > > > > > > > > > >> Or have a generic library for reading LPM entries. L3fwd is > > > > > > > > >> supposed > > > > > > > > >> to be as small as possible (it no longer is), and the real > > > > > > > > >> work should > > > > > > > > >> be

RE: [PATCH] devtools: add E-Switch keyword for commit checks

2022-02-24 Thread Raslan Darawsheh
++ adding more people here, > -Original Message- > From: Thomas Monjalon > Sent: Thursday, February 24, 2022 11:36 AM > To: Raslan Darawsheh > Cc: dev@dpdk.org; ferruh.yi...@intel.com; Gal Cohen (ProdM) > > Subject: Re: [PATCH] devtools: add E-Switch keyword for commit checks > > 24/02

Re: [PATCH 1/2] net/cnxk: add callback handler to read ptp timestamp

2022-02-24 Thread Jerin Jacob
On Thu, Feb 24, 2022 at 1:32 PM Rakesh Kudurumalla wrote: > > timestamp resolution for an incoming and outgoing packets > is different for CN10k and CN9K.Added platform specific > callback to retrieve timestamp in correct format when read by > application > > Signed-off-by: Rakesh Kudurumalla Sq

Re: [PATCH v2] net/ice/base: support E824S and E825 devices

2022-02-24 Thread Ferruh Yigit
On 2/23/2022 2:42 AM, Zhang, Qi Z wrote: -Original Message- From: Zhang, RobinX Sent: Wednesday, February 16, 2022 3:45 PM To: dev@dpdk.org Cc: Yang, Qiming ; Zhang, Qi Z ; Guo, Junfeng ; Yang, SteveX ; Zhang, RobinX Subject: [PATCH v2] net/ice/base: support E824S and E825 devices A

Re: [PATCH v2] net/i40e: fix unintentional integer overflow

2022-02-24 Thread Ferruh Yigit
On 2/24/2022 6:21 AM, Yang, SteveX wrote: -Original Message- From: Stephen Hemminger Sent: Thursday, February 24, 2022 12:11 PM To: Yang, SteveX Cc: dev@dpdk.org; Yigit, Ferruh ; Xing, Beilei ; sta...@dpdk.org Subject: Re: [PATCH v2] net/i40e: fix unintentional integer overflow On T

[PATCH] app/pdump: free mempool at cleanup resources

2022-02-24 Thread Tianli Lai
the mempool should be free when cleanup resources. Signed-off-by: Tianli Lai --- app/pdump/main.c | 4 1 file changed, 4 insertions(+) diff --git a/app/pdump/main.c b/app/pdump/main.c index 46f9d25..8101078 100644 --- a/app/pdump/main.c +++ b/app/pdump/main.c @@ -510,6 +510,10 @@ struct pa

[PATCH] net/iavf: add NAT-T / UDP encapsulation support

2022-02-24 Thread Radu Nicolau
Add support for NAT-T / UDP encapsulated ESP. Signed-off-by: Radu Nicolau --- drivers/common/iavf/virtchnl_inline_ipsec.h | 9 + drivers/net/iavf/iavf_ipsec_crypto.c| 16 +--- drivers/net/iavf/iavf_ipsec_crypto.h| 4 +++- 3 files changed, 25 insertions(+), 4

RE: [PATCH v3 0/3] net/mlx5: support send scheduling for ConnectX-7

2022-02-24 Thread Raslan Darawsheh
Hi, > -Original Message- > From: Slava Ovsiienko > Sent: Thursday, February 24, 2022 12:55 PM > To: dev@dpdk.org > Cc: Matan Azrad ; Raslan Darawsheh > > Subject: [PATCH v3 0/3] net/mlx5: support send scheduling for ConnectX-7 > > Since the ConnectX-6DX the send scheduling capability is

[PATCH] app/pdump: free mempool at cleanup resources

2022-02-24 Thread Tianli Lai
the mempool should be free when cleanup resources. Signed-off-by: Tianli Lai --- app/pdump/main.c | 4 1 file changed, 4 insertions(+) diff --git a/app/pdump/main.c b/app/pdump/main.c index 04a38e8..9c77fc6 100644 --- a/app/pdump/main.c +++ b/app/pdump/main.c @@ -507,6 +507,10 @@ struct pa

Re: [PATCH v10 00/11] ethdev: datapath-focused flow rules management

2022-02-24 Thread Ferruh Yigit
On 2/23/2022 3:02 AM, Alexander Kozyrev wrote: Three major changes to a generic RTE Flow API were implemented in order to speed up flow rule insertion/destruction and adapt the API to the needs of a datapath-focused flow rules management applications: 1. Pre-configuration hints. Application may

Re: [PATCH v10 00/11] ethdev: datapath-focused flow rules management

2022-02-24 Thread Ferruh Yigit
On 2/24/2022 1:07 PM, Ferruh Yigit wrote: On 2/23/2022 3:02 AM, Alexander Kozyrev wrote: Three major changes to a generic RTE Flow API were implemented in order to speed up flow rule insertion/destruction and adapt the API to the needs of a datapath-focused flow rules management applications: 1

RE: [PATCH v10 00/11] ethdev: datapath-focused flow rules management

2022-02-24 Thread Raslan Darawsheh
> -Original Message- > From: Ferruh Yigit > Sent: Thursday, February 24, 2022 3:13 PM > To: Alexander Kozyrev ; dev@dpdk.org; Raslan > Darawsheh > Cc: Ori Kam ; NBU-Contact-Thomas Monjalon > (EXTERNAL) ; ivan.ma...@oktetlabs.ru; > andrew.rybche...@oktetlabs.ru; mohammad.abdul.a...@intel

RE: [PATCH v3] maintainers: update for testpmd

2022-02-24 Thread Dumitrescu, Cristian
> -Original Message- > From: Zhang, Yuying > Sent: Thursday, February 10, 2022 2:51 PM > To: dev@dpdk.org; Li, Xiaoyun ; Yigit, Ferruh > ; tho...@monjalon.net; Dumitrescu, Cristian > > Cc: Zhang, Yuying > Subject: [PATCH v3] maintainers: update for testpmd > > Move 'test-pmd/cmdline_t

RE: [PATCH] net/mlx5: support matching optional fields of GRE

2022-02-24 Thread Raslan Darawsheh
Hi Sean, Can you kindly rebase this patch on top of the latest next-net-mlx/main? And send a new version? Kindest regards, Raslan Darawsheh > -Original Message- > From: Sean Zhang > Sent: Thursday, February 17, 2022 8:27 AM > To: NBU-Contact-Thomas Monjalon (EXTERNAL) ; > Matan Azrad ;

[PATCH] examples/vdpa: fix disabled VirtQ statistics query

2022-02-24 Thread Xueming Li
Quit VirtQ statistics query instead of reporting error. Fixes: 6505865aa8ed ("examples/vdpa: add statistics show command") Cc: sta...@dpdk.org Signed-off-by: Xueming Li --- examples/vdpa/main.c | 21 +++-- 1 file changed, 19 insertions(+), 2 deletions(-) diff --git a/examples/v

[PATCH 0/7] vdpa/mlx5: improve device shutdown time

2022-02-24 Thread Xueming Li
Xueming Li (7): vdpa/mlx5: fix interrupt trash that leads to segment fault vdpa/mlx5: fix dead loop when process interrupted vdpa/mlx5: no kick handling during shutdown vdpa/mlx5: reuse resources in reconfiguration vdpa/mlx5: cache and reuse hardware resources vdpa/mlx5: support devic

[PATCH 1/7] vdpa/mlx5: fix interrupt trash that leads to segment fault

2022-02-24 Thread Xueming Li
Disable interrupt unregister timeout to avoid invalid FD caused interrupt thread segment fault. Fixes: 62c813706e41 ("vdpa/mlx5: map doorbell") Cc: ma...@mellanox.com Cc: sta...@dpdk.org Signed-off-by: Xueming Li --- drivers/vdpa/mlx5/mlx5_vdpa_virtq.c | 20 1 file changed,

[PATCH 2/7] vdpa/mlx5: fix dead loop when process interrupted

2022-02-24 Thread Xueming Li
In Ctrl+C handling, sometimes kick handling thread gets endless EGAIN error and fall into dead lock. Kick happens frequently in real system due to busy traffic or retry mechanism. This patch simplifies kick firmware anyway and skip setting hardware notifier due to potential device error, notifier

[PATCH 3/7] vdpa/mlx5: no kick handling during shutdown

2022-02-24 Thread Xueming Li
When Qemu suspend a VM, hw notifier is un-mmapped while vCPU thread may still active and write notifier through kick socket. PMD kick handler thread tries to install hw notifier through slave socket in such case will timeout and slow down device close. This patch skips hw notifier install if VQ o

[PATCH 4/7] vdpa/mlx5: reuse resources in reconfiguration

2022-02-24 Thread Xueming Li
To speed up device resume, create reuseable resources during device probe state, release when device remove. Reused resources includes TIS, TD, VAR Doorbell mmap, error handling event channel and interrupt handler, UAR, Rx event channel, NULL MR, steer domain and table. Signed-off-by: Xueming Li

[PATCH 6/7] vdpa/mlx5: support device cleanup callback

2022-02-24 Thread Xueming Li
This patch supports device cleanup callback API which called when device disconected with VM. Cached resources like VM MR and VQ memory are released. Signed-off-by: Xueming Li --- drivers/vdpa/mlx5/mlx5_vdpa.c | 23 +++ drivers/vdpa/mlx5/mlx5_vdpa.h | 1 + 2 files changed, 2

[PATCH 7/7] vdpa/mlx5: make statistics counter persistent

2022-02-24 Thread Xueming Li
To speed the device suspend and resume time, make counter persitent in reconfiguration until the device gets removed. Signed-off-by: Xueming Li --- doc/guides/vdpadevs/mlx5.rst| 6 ++ drivers/vdpa/mlx5/mlx5_vdpa.c | 19 +++-- drivers/vdpa/mlx5/mlx5_vdpa.h |

[PATCH 5/7] vdpa/mlx5: cache and reuse hardware resources

2022-02-24 Thread Xueming Li
During device suspend and resume, resources are not changed normally. When huge resources allocated to VM, like huge memory size or lots of queues, time spent on release and recreate became significant. To speed up, this patch reuse resoruces like VM MR and VirtQ memory if not changed. Signed-off

[PATCH v4 00/14] net/mlx5: add hardware steering

2022-02-24 Thread Suanming Mou
The Connect-X steering is a lookup hardware mechanism that accesses flow tables, matches packets to the rules, and performs specified actions. Historically, mlx5 PMD implements several software engines to manage steering hardware facility: - FW Steering - Verbs/Direct Verbs, uses FW calls to ma

[PATCH v4 01/14] net/mlx5: introduce hardware steering operation

2022-02-24 Thread Suanming Mou
The Connect-X steering is a lookup hardware mechanism that accesses flow tables, matches packets to the rules, and performs specified actions. Historically, mlx5 PMD implements several software engines to manage steering hardware facility: - FW Steering - Verbs/Direct Verbs, uses FW calls to ma

[PATCH v4 02/14] net/mlx5: add HW steering low-level abstract code

2022-02-24 Thread Suanming Mou
The HW steering low-level implementation will be added later in another patch series. To avoid the linkage issues the abstract stub replacement is provided currently. Signed-off-by: Suanming Mou Acked-by: Viacheslav Ovsiienko --- drivers/net/mlx5/meson.build | 1 + drivers/net/mlx5/mlx5_dr.c

[PATCH v4 04/14] net/mlx5: add port flow configuration

2022-02-24 Thread Suanming Mou
The hardware steering is backend to support rte_flow_async API in mlx5 PMD. The port configuration function creates the queues and needed flow management resources. The PMD layer configuration function allocates the queues' context and per-queue job descriptor pool. The job descriptor pool size is

[PATCH v4 03/14] net/mlx5: introduce hardware steering enable routine

2022-02-24 Thread Suanming Mou
The new hardware steering engine relies on using dedicated steering WQEs instead of direct writing to the low-level steering table entries directly. In the first introduce implementation the hardware steering engine supports the new queue based Flow API, the existing synchronous non-queue based Flo

[PATCH v4 06/14] net/mlx5: add action template management

2022-02-24 Thread Suanming Mou
The action template holds a list of action types that will be used together on the same rule. The template's actions instances will be created only when the template bind to the dedicated group. And the created actions will be saved to each individual group in order for best performance. The action

[PATCH v4 05/14] net/mlx5: add pattern template management

2022-02-24 Thread Suanming Mou
The pattern template defines flows that have the same matching fields but with different matching values. For example, matching on 5 tuple TCP flow, the template will be (eth(null) + IPv4(source + dest) + TCP(s_port + d_port) while the values for each rule will be different. Due to the pattern tem

[PATCH v4 10/14] net/mlx5: add flow jump action

2022-02-24 Thread Suanming Mou
Jump action connects different level of flow tables and allows packet handling in the chain of flows. A new action construct data struct is also added in this commit to help to handle not only the dynamic jump action but also for the other generic dynamic actions. The actions with empty mask confi

[PATCH v4 08/14] net/mlx5: add basic flow queue operation

2022-02-24 Thread Suanming Mou
The HW steering uses async queue-based flow rules management mechanism. The matcher and part of the actions have been prepared during flow table creation. Some remaining actions will be constructed during flow creation if needed. A flow postpone attribute bit describes if flow management should be

[PATCH v4 11/14] net/mlx5: add queue and RSS action

2022-02-24 Thread Suanming Mou
This commit adds the queue and RSS action. Similar to the jump action, dynamic ones will be added to the action construct list. Due to the queue and RSS action in template should not be destroyed during port restart, the actions are created with standalone indirect table as indirect action does. W

[PATCH v4 12/14] net/mlx5: add mark action

2022-02-24 Thread Suanming Mou
The mark action is covered by tag action internally. While it is added the HW will add a tag to the packet. The mark value can be set as fixed or dynamic as the action mask indicates. Signed-off-by: Suanming Mou Acked-by: Viacheslav Ovsiienko --- drivers/net/mlx5/mlx5.h | 2 + drivers/

[PATCH v4 09/14] net/mlx5: add flow flush function

2022-02-24 Thread Suanming Mou
In case port is being stopped, all created flows should be flushed. This commit adds the flow flush helper function. Signed-off-by: Suanming Mou Acked-by: Viacheslav Ovsiienko --- drivers/net/mlx5/mlx5_flow.c| 8 ++ drivers/net/mlx5/mlx5_flow_hw.c | 129 2

[PATCH v4 07/14] net/mlx5: add table management

2022-02-24 Thread Suanming Mou
Flow table is a group of flows with the same matching criteria and the same actions defined for them. The table defines rules that have the same matching fields but with different matching values. For example, matching on 5 tuple, the table will be (IPv4 source + IPv4 dest + s_port + d_port + next_

[PATCH v4 14/14] net/mlx5: add header reformat action

2022-02-24 Thread Suanming Mou
HW steering header reformat action can work under bulk mode. In this case, when create the table, bulk size of header reformat actions will be allocated in low level. Afterwards, when create flow, just simply specify the action index in the bulk and the encapsulation data to the action will be enou

[PATCH v4 13/14] net/mlx5: add indirect action

2022-02-24 Thread Suanming Mou
HW steering can support indirect action as well. With indirect action, the flow can be created with more flexible shared RSS action selection. This will can save the action template with different RSS actions. This commit adds the flow queue operation callback for: rte_flow_async_action_handle_cre

Re: [PATCH] net/cnxk: update RSS RETA table

2022-02-24 Thread Jerin Jacob
On Thu, Feb 24, 2022 at 2:05 PM Rakesh Kudurumalla wrote: > > rss reta table is corrupted during > rte_eth_dev_rss_reta_update.This fix restores > previous table entries before updating. > > Fixes: 00242a687de ("net/cnxk: support RETA and RSS hash") > Cc: sta...@dpdk.org > > Signed-off-by: Rakesh

Re: [PATCH v5 0/2] Add config file support for l3fwd

2022-02-24 Thread Thomas Monjalon
24/02/2022 12:06, Ananyev, Konstantin: > > > > > > > > > >> Or have a generic library for reading LPM entries. L3fwd > > > > > > > > > >> is supposed > > > > > > > > > >> to be as small as possible (it no longer is), and the real > > > > > > > > > >> work should > > > > > > > > > >> be done by l

[PATCH 1/2] net/cnxk: optimize Rx pktsize extraction

2022-02-24 Thread pbhagavatula
From: Pavan Nikhilesh In vWQE mode, the mbuf address is calculated without using the iova list. Packet length can also be calculated by using NIX_PARSE_S by which we can completely eliminate reading 2nd cache line depending on the offloads enabled. Signed-off-by: Pavan Nikhilesh --- drivers/ne

[PATCH 2/2] event/cnxk: align perfetchs to CN10K cache model

2022-02-24 Thread pbhagavatula
From: Pavan Nikhilesh Align perfetchs for CN10K cache model for vWQE in Rx and Tx. Move mbuf->next NULL assignment to Tx path and enabled it only when multi segments offload is enabled to reduce L1 pressure. Add macros to detect corrupted mbuf->next values when MEMPOOL_DEBUG is set. Signed-off-b

Re: [PATCH v5 0/2] Add config file support for l3fwd

2022-02-24 Thread Bruce Richardson
On Thu, Feb 24, 2022 at 02:46:24PM +0100, Thomas Monjalon wrote: > 24/02/2022 12:06, Ananyev, Konstantin: > > > > > > > > > > >> Or have a generic library for reading LPM entries. > > > > > > > > > > >> L3fwd is supposed > > > > > > > > > > >> to be as small as possible (it no longer is), and the

Re: [PATCH] net/cnxk: remove unused files after template rework

2022-02-24 Thread Jerin Jacob
On Thu, Feb 24, 2022 at 3:44 PM Nithin Dabilpuram wrote: > > Remove unused files that were left over after Rx and Tx template > function rework. > > Fixes: 5169508a68fa ("net/cnxk: add cn9k template Rx functions to build") > Fixes: dd8c20eee472 ("net/cnxk: add cn9k template Tx functions to build")

Re: [PATCH] bus/pci: assign driver's pointer before mapping

2022-02-24 Thread Michał Krawczyk
śr., 19 sty 2022 o 15:50 Michal Krawczyk napisał(a): > > Patch changing the way of accessing interrupt handle also changed order > of the rte_pci_map_device() call and rte_pci_device:driver assignment. > It was causing issues with Write Combine mapping on the Linux platform > if it was used with t

[PATCH v1 0/7] vdpa/mlx5: improve device shutdown time

2022-02-24 Thread Xueming Li
v1: - rebase with latest upstream code - fix coverity issues Xueming Li (7): vdpa/mlx5: fix interrupt trash that leads to segment fault vdpa/mlx5: fix dead loop when process interrupted vdpa/mlx5: no kick handling during shutdown vdpa/mlx5: reuse resources in reconfiguration vdpa/mlx5:

[PATCH v1 2/7] vdpa/mlx5: fix dead loop when process interrupted

2022-02-24 Thread Xueming Li
In Ctrl+C handling, sometimes kick handling thread gets endless EGAIN error and fall into dead lock. Kick happens frequently in real system due to busy traffic or retry mechanism. This patch simplifies kick firmware anyway and skip setting hardware notifier due to potential device error, notifier

[PATCH v1 1/7] vdpa/mlx5: fix interrupt trash that leads to segment fault

2022-02-24 Thread Xueming Li
Disable interrupt unregister timeout to avoid invalid FD caused interrupt thread segment fault. Fixes: 62c813706e41 ("vdpa/mlx5: map doorbell") Cc: ma...@mellanox.com Cc: sta...@dpdk.org Signed-off-by: Xueming Li --- drivers/vdpa/mlx5/mlx5_vdpa_virtq.c | 20 1 file changed,

[PATCH v1 4/7] vdpa/mlx5: reuse resources in reconfiguration

2022-02-24 Thread Xueming Li
To speed up device resume, create reuseable resources during device probe state, release when device remove. Reused resources includes TIS, TD, VAR Doorbell mmap, error handling event channel and interrupt handler, UAR, Rx event channel, NULL MR, steer domain and table. Signed-off-by: Xueming Li

[PATCH v1 3/7] vdpa/mlx5: no kick handling during shutdown

2022-02-24 Thread Xueming Li
When Qemu suspend a VM, hw notifier is un-mmapped while vCPU thread may still active and write notifier through kick socket. PMD kick handler thread tries to install hw notifier through client socket in such case will timeout and slow down device close. This patch skips hw notifier install if VQ

[PATCH v1 5/7] vdpa/mlx5: cache and reuse hardware resources

2022-02-24 Thread Xueming Li
During device suspend and resume, resources are not changed normally. When huge resources allocated to VM, like huge memory size or lots of queues, time spent on release and recreate became significant. To speed up, this patch reuse resoruces like VM MR and VirtQ memory if not changed. Signed-off

[PATCH v1 6/7] vdpa/mlx5: support device cleanup callback

2022-02-24 Thread Xueming Li
This patch supports device cleanup callback API which called when device disconnected with VM. Cached resources like VM MR and VQ memory are released. Signed-off-by: Xueming Li --- drivers/vdpa/mlx5/mlx5_vdpa.c | 23 +++ drivers/vdpa/mlx5/mlx5_vdpa.h | 1 + 2 files changed,

[PATCH v1 7/7] vdpa/mlx5: make statistics counter persistent

2022-02-24 Thread Xueming Li
To speed the device suspend and resume time, make counter persitent in reconfiguration until the device gets removed. Signed-off-by: Xueming Li --- doc/guides/vdpadevs/mlx5.rst| 6 ++ drivers/vdpa/mlx5/mlx5_vdpa.c | 19 +++-- drivers/vdpa/mlx5/mlx5_vdpa.h |

[PATCH v3 0/3] ixgbe SFP handling fixes

2022-02-24 Thread Jeff Daly
Hello all, We have several platforms based on Intel's C3000 series of SoCs that have integrated ixgbe devices (X550EM) operating in the "Native SFI" mode (the 0x15c4 device ID). This set of patches address issues with detection and hotplug of SPFs. This is the first of a series of patches to ref

[PATCH v3 1/3] net/ixgbe: Fix ixgbe_is_sfp() to return valid result for X550EM_a devs

2022-02-24 Thread Jeff Daly
From: Stephen Douthit Currently all X500EM* MAC types fallthrough to the default case and get reported as non-SFP regardless of media type, which isn't correct. Fixes: 0790adeb567 ("ixgbe/base: support X550em_a device") Cc: sta...@dpdk.org Signed-off-by: Stephen Douthit Signed-off-by: Jeff Dal

[PATCH v3 2/3] net/ixgbe: Limit SDP3 check of TX_DISABLE to appropriate devices

2022-02-24 Thread Jeff Daly
1ca05831b9b added a check that SDP3 (used as a TX_DISABLE output to the SFP cage on these cards) is not asserted to avoid incorrectly reporting link up when the SFP's laser is turned off. ff8162cb957 limited this workaround to fiber ports This patch: * Adds additional check for 82599 type, not al

[PATCH v3 3/3] net/ixgbe: Fix SFP detection and linking on hotplug

2022-02-24 Thread Jeff Daly
Currently the ixgbe driver does not ID any SFP except for the first one plugged in. This can lead to no-link, or incorrect speed conditions. For example: * If link is initially established with a 1G SFP, and later a 1G/10G multispeed part is later installed, then the MAC link setup functions are

[PATCH 1/2] test/efd: fix size of constant

2022-02-24 Thread Pablo de Lara
Constant value 1 has a size of 32 bits, and shifting it more than 32 bits to the left overflows. 1ULL is needed to be able to get a 64-bit value. Coverity ID: 375846 Fixes: 8751a7e9832b ("efd: allow more CPU sockets in table creation") Cc: pablo.de.lara.gua...@intel.com Cc: sta...@dpdk.org Signed

[PATCH 2/2] efd: fix uninitialized structure

2022-02-24 Thread Pablo de Lara
Coverity flags that both elements of efd_online_group_entry are used unititialized. This is OK because this structure is initially used for starting values, so any value is OK. Coverity ID: 375868 Fixes: 56b6ef874f80 ("efd: new Elastic Flow Distributor library") Cc: pablo.de.lara.gua...@intel.com

[PATCH v2 0/7] vdpa/mlx5: improve device shutdown time

2022-02-24 Thread Xueming Li
v1: - rebase with latest upstream code - fix coverity issues v2: - fix build issue on OS w/o flow DR API Xueming Li (7): vdpa/mlx5: fix interrupt trash that leads to segment fault vdpa/mlx5: fix dead loop when process interrupted vdpa/mlx5: no kick handling during shutdown vdpa/mlx5: re

[PATCH v2 1/7] vdpa/mlx5: fix interrupt trash that leads to segment fault

2022-02-24 Thread Xueming Li
Disable interrupt unregister timeout to avoid invalid FD caused interrupt thread segment fault. Fixes: 62c813706e41 ("vdpa/mlx5: map doorbell") Cc: ma...@mellanox.com Cc: sta...@dpdk.org Signed-off-by: Xueming Li --- drivers/vdpa/mlx5/mlx5_vdpa_virtq.c | 20 1 file changed,

[PATCH v2 2/7] vdpa/mlx5: fix dead loop when process interrupted

2022-02-24 Thread Xueming Li
In Ctrl+C handling, sometimes kick handling thread gets endless EGAIN error and fall into dead lock. Kick happens frequently in real system due to busy traffic or retry mechanism. This patch simplifies kick firmware anyway and skip setting hardware notifier due to potential device error, notifier

[PATCH v2 4/7] vdpa/mlx5: reuse resources in reconfiguration

2022-02-24 Thread Xueming Li
To speed up device resume, create reuseable resources during device probe state, release when device remove. Reused resources includes TIS, TD, VAR Doorbell mmap, error handling event channel and interrupt handler, UAR, Rx event channel, NULL MR, steer domain and table. Signed-off-by: Xueming Li

[PATCH v2 3/7] vdpa/mlx5: no kick handling during shutdown

2022-02-24 Thread Xueming Li
When Qemu suspend a VM, hw notifier is un-mmapped while vCPU thread may still active and write notifier through kick socket. PMD kick handler thread tries to install hw notifier through client socket in such case will timeout and slow down device close. This patch skips hw notifier install if VQ

[PATCH v2 5/7] vdpa/mlx5: cache and reuse hardware resources

2022-02-24 Thread Xueming Li
During device suspend and resume, resources are not changed normally. When huge resources allocated to VM, like huge memory size or lots of queues, time spent on release and recreate became significant. To speed up, this patch reuse resoruces like VM MR and VirtQ memory if not changed. Signed-off

[PATCH v2 6/7] vdpa/mlx5: support device cleanup callback

2022-02-24 Thread Xueming Li
This patch supports device cleanup callback API which called when device disconnected with VM. Cached resources like VM MR and VQ memory are released. Signed-off-by: Xueming Li --- drivers/vdpa/mlx5/mlx5_vdpa.c | 23 +++ drivers/vdpa/mlx5/mlx5_vdpa.h | 1 + 2 files changed,

[PATCH v2 7/7] vdpa/mlx5: make statistics counter persistent

2022-02-24 Thread Xueming Li
To speed the device suspend and resume time, make counter persitent in reconfiguration until the device gets removed. Signed-off-by: Xueming Li --- doc/guides/vdpadevs/mlx5.rst| 6 ++ drivers/vdpa/mlx5/mlx5_vdpa.c | 19 +++-- drivers/vdpa/mlx5/mlx5_vdpa.h |

[PATCH] net/bnxt: fix a null dereference in cleanup label

2022-02-24 Thread Weiguo Li
Fixes: a46bbb57605b4 ("net/bnxt: update multi device design") In tf_session_create(), there is a case that with 'tfp->session' still be NULL and run 'goto cleanup', which will leads to a null dereference by 'tfp_free(tfp->session->core_data)' in the cleanup. Signed-off-by: Weiguo Li --- drivers

[PATCH] doc: fix modify field action description for mlx5

2022-02-24 Thread Viacheslav Ovsiienko
This patch adds mlx5 specifics description about handling the Ethernet type by modify field action for VLAN-ed traffic. Fixes: 641dbe4fb053 ("net/mlx5: support modify field flow action") Cc: sta...@dpdk.org Signed-off-by: Viacheslav Ovsiienko --- doc/guides/nics/mlx5.rst | 5 + 1 file chang

[PATCH v2 1/2] test/efd: fix size of constant

2022-02-24 Thread Pablo de Lara
Constant value 1 has a size of 32 bits, and shifting it more than 32 bits to the left overflows. 1ULL is needed to be able to get a 64-bit value. Coverity ID: 375846 Fixes: 8751a7e9832b ("efd: allow more CPU sockets in table creation") Cc: pablo.de.lara.gua...@intel.com Cc: sta...@dpdk.org Signed

[PATCH v2 2/2] efd: fix uninitialized structure

2022-02-24 Thread Pablo de Lara
Coverity flags that both elements of efd_online_group_entry are used uninitialized. This is OK because this structure is initially used for starting values, so any value is OK. Coverity ID: 375868 Fixes: 56b6ef874f80 ("efd: new Elastic Flow Distributor library") Cc: pablo.de.lara.gua...@intel.com

Re: [PATCH] app/pdump: free mempool at cleanup resources

2022-02-24 Thread Stephen Hemminger
On Thu, 24 Feb 2022 20:14:58 +0800 Tianli Lai wrote: > + if (pt->mp) { > + rte_mempool_free(pt->mp); > + pt->mp = NULL; Check for null is unnecessary here, rte_mempool_free(NULL) is nop.

  1   2   >