RE: [PATCH] ethdev: add protocol param to color table update

2022-07-21 Thread Sunil Kumar Kori
Hello all, Please have look on it and provide your feedback. Regards Sunil Kumar Kori > -Original Message- > From: sk...@marvell.com > Sent: Thursday, July 7, 2022 12:28 PM > To: Cristian Dumitrescu ; Aman Singh > ; Yuying Zhang ; > Nithin Kumar Dabilpuram ; Kiran Kumar > Kokkilagadda ;

[PATCH v3 2/3] net/ixgbe: move testpmd commands

2022-07-21 Thread David Marchand
Move related specific testpmd commands into this driver directory. The bypass init is left in testpmd at this point and can be moved later. While at it, fix checkpatch warnings. Signed-off-by: David Marchand --- Changes since v2: - rebased, Changes since v1: - rebased on next-net, - updated link

[PATCH v3 1/3] app/testpmd: restore ixgbe bypass commands

2022-07-21 Thread David Marchand
Since the switch to meson, ixgbe bypass commands were ineffective as the RTE_LIBRTE_IXGBE_BYPASS build flag was not set, even though the net/ixgbe driver had this feature compiled in. Fixes: 16ade738fd0d ("app/testpmd: build with meson") Cc: sta...@dpdk.org Signed-off-by: David Marchand --- app

[PATCH v3 3/3] net/ixgbe: move bypass init in a testpmd command

2022-07-21 Thread David Marchand
Introduce a new command and remove the last part of specific port init from testpmd. Signed-off-by: David Marchand --- app/test-pmd/meson.build | 1 - app/test-pmd/testpmd.c| 4 -- doc/guides/nics/ixgbe.rst | 7 +++ drivers/net/ixgbe/ixgbe_testpmd.c | 82 +

[Bug 1055] [dpdk 19.11.13-rc1] drivers/net/ice meson build error with gcc11.2 on Ubuntu22.04

2022-07-21 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=1055 Bug ID: 1055 Summary: [dpdk 19.11.13-rc1] drivers/net/ice meson build error with gcc11.2 on Ubuntu22.04 Product: DPDK Version: 19.11 Hardware: All OS: All

Re: [PATCH v2 1/3] power: add uncore API to power library

2022-07-21 Thread Bruce Richardson
On Wed, Jul 20, 2022 at 04:10:07PM +, Pattan, Reshma wrote: > > > > -Original Message- > > From: Kearney, Tadhg > > diff --git a/config/x86/meson.build b/config/x86/meson.build index > > +dpdk_conf.set('RTE_MAX_NUMA_DIE', 1) > > +dpdk_conf.set('RTE_MAX_UNCORE_FREQS', 32) > > Check i

Re: [RFC PATCH v1] net/i40e: put mempool cache out of API

2022-07-21 Thread Konstantin Ananyev
Refer to "i40e_tx_free_bufs_avx512", this patch puts mempool cache out of API to free buffers directly. There are two changes different with previous version: 1. change txep from "i40e_entry" to "i40e_vec_entry" 2. put cache out of "mempool_bulk" API to copy buffers into it directly Performa

Re: [PATCH] version: 22.11-rc0

2022-07-21 Thread David Marchand
On Mon, Jul 18, 2022 at 12:10 PM David Marchand wrote: > > Start a new release cycle with empty release notes. > > The ABI version becomes 23.0. Here we go! > The map files are updated to the new ABI major number (23). > The ABI exceptions are dropped and CI ABI checks are disabled because > com

Re: [v3 00/24] Support LoongArch architecture

2022-07-21 Thread zhoumin
On 2022年07月21日 00:33, David Marchand wrote: Hello, On Mon, Jun 6, 2022 at 3:11 PM Min Zhou wrote: Dear team, The following patch set is intended to support DPDK running on LoongArch architecture. LoongArch is the general processor architecture of Loongson and is a new RISC ISA, which is a

[PATCH] net/tap: fix the overflow of the network interface index.

2022-07-21 Thread Alex Kiselev
On Linux and most other systems, network interface index is a 32-bit integer. Indexes overflowing the 16-bit integer are frequently seen when used inside a Docker container. Signed-off-by: Alex Kiselev --- drivers/net/tap/tap_flow.c | 2 +- drivers/net/tap/tap_tcmsgs.c | 18 +

[PATCH] net/tap: fix the overflow of the network interface index.

2022-07-21 Thread Alex Kiselev
On Linux and most other systems, network interface index is a 32-bit integer. Indexes overflowing the 16-bit integer are frequently seen when used inside a Docker container. Signed-off-by: Alex Kiselev --- drivers/net/tap/tap_flow.c | 2 +- drivers/net/tap/tap_tcmsgs.c | 18 +

RE: [PATCH v4 1/2] mem: telemetry support for memseg and element information

2022-07-21 Thread Amit Prakash Shukla
Ping for review or feedback for the updated patch. Thanks, Amit Shukla > -Original Message- > From: Amit Prakash Shukla > Sent: Thursday, June 30, 2022 11:22 AM > To: Anatoly Burakov ; > david.march...@redhat.com; bruce.richard...@intel.com > Cc: dev@dpdk.org; Jerin Jacob Kollanukkaran >

RE: [PATCH v4 2/2] mem: telemetry support for system memory information

2022-07-21 Thread Amit Prakash Shukla
Ping for review or feedback for the patch. Thanks, Amit Shukla > -Original Message- > From: Amit Prakash Shukla > Sent: Thursday, June 30, 2022 11:24 AM > To: Anatoly Burakov ; > bruce.richard...@intel.com; david.march...@redhat.com > Cc: dev@dpdk.org; Jerin Jacob Kollanukkaran > Subject

[RFC PATCH 1/3] net/af_xdp: simplify libbpf version checking in meson

2022-07-21 Thread Ciara Loftus
Test if the libbpf version is >= v0.7.0 at the beginning of the meson build. Later when we want to check if the version is <= v0.6.0 just use the inverse of the first check ie. ! >= v0.7.0. Signed-off-by: Ciara Loftus --- drivers/net/af_xdp/meson.build | 12 ++-- 1 file changed, 6 insert

[RFC PATCH 2/3] net/af_xdp: determine libbpf version by checking for symbols

2022-07-21 Thread Ciara Loftus
Instead of using pkg-config to query the version of the libbpf library, search for symbols in the library and use their presence or absence to determine what version of the library is being linked. Suggested-by: Andrew Rybchenko Signed-off-by: Ciara Loftus --- drivers/net/af_xdp/meson.build | 1

[RFC PATCH 3/3] net/af_xdp: use autoconf file instead of cflags

2022-07-21 Thread Ciara Loftus
Generate af_xdp_autoconf.h which contains the different features detected by the meson build instead of using cflags. Suggested-by: Andrew Rybchenko Signed-off-by: Ciara Loftus --- drivers/net/af_xdp/compat.h| 8 +--- drivers/net/af_xdp/meson.build | 15 --- 2 files changed

RE: [PATCH v2 3/3] l3fwd-power: add option to call uncore API

2022-07-21 Thread Pattan, Reshma
> -Original Message- > From: Kearney, Tadhg > +* -i (frequency index): optional, sets uncore frequency to frequency index > value, by setting min and max values to be the same. > + This is not optional argument. Need to remove optional in the help text of the parameter. > +``-i

rte_eth_fdir_conf deprecation to be processed in 22.11

2022-07-21 Thread Andrew Rybchenko
Hi all, we have the following deprecation waiting for more than 2 years already: * ethdev: The flow director API, including ``rte_eth_conf.fdir_conf`` field,   and the related structures (``rte_fdir_*`` and ``rte_eth_fdir_*``),   will be removed in DPDK 20.11. I think 2 years is more than enoug

RE: [PATCH] net/af_xdp: make compatible with libbpf v0.8.0

2022-07-21 Thread Loftus, Ciara
> > > > > On 6/24/22 13:23, Ciara Loftus wrote: > > > libbpf v0.8.0 deprecates the bpf_get_link_xdp_id and > > >> bpf_set_link_xdp_fd > > > functions. Use meson to detect if libbpf >= v0.7.0 is linked and if > > > so, > > use > > > the recommended replacement functions b

[PATCH v4 02/24] eal/loongarch: add byte order operations for LoongArch

2022-07-21 Thread Min Zhou
This patch adds architecture specific byte order operations for LoongArch architecture. LoongArch bit designations are always little-endian. Signed-off-by: Min Zhou --- lib/eal/loongarch/include/rte_byteorder.h | 46 +++ 1 file changed, 46 insertions(+) create mode 100644 li

[PATCH v4 00/24] Support LoongArch architecture

2022-07-21 Thread Min Zhou
Dear team, The following patch set is intended to support DPDK running on LoongArch architecture. LoongArch is the general processor architecture of Loongson and is a new RISC ISA, which is a bit like MIPS or RISC-V. The online documents of LoongArch are here: https://loongson.github.io/Loong

[PATCH v4 04/24] eal/loongarch: add prefetch operations for LoongArch

2022-07-21 Thread Min Zhou
This patch adds architecture specific prefetch operations for LoongArch architecture. Signed-off-by: Min Zhou --- lib/eal/loongarch/include/rte_prefetch.h | 47 1 file changed, 47 insertions(+) create mode 100644 lib/eal/loongarch/include/rte_prefetch.h diff --git a/li

[PATCH v4 03/24] eal/loongarch: add cpu cycle operations for LoongArch

2022-07-21 Thread Min Zhou
This patch adds architecture specific cpu cycle operations for LoongArch. The RDTIME.D instruction is used to read constant frequency timer information including counter value. The CPUCFG instruction is used to dynamically identify which features of LoongArch are implemented in the running processo

[PATCH v4 05/24] eal/loongarch: add spinlock operations for LoongArch

2022-07-21 Thread Min Zhou
This patch adds spinlock operations for LoongArch architecture. These implementations are based on standard atomics of toolchain and heavily reference generic spinlock codes. Signed-off-by: Min Zhou --- lib/eal/loongarch/include/rte_spinlock.h | 90 1 file changed, 90 in

[PATCH v4 07/24] eal/loongarch: add dummy vector memcpy for LoongArch

2022-07-21 Thread Min Zhou
The hardware instructions based vector implementation for memcpy will come later. At present, this dummy implementation can also work. Signed-off-by: Min Zhou --- lib/eal/loongarch/include/rte_memcpy.h | 193 + lib/eal/loongarch/include/rte_vect.h | 46 ++ 2 files

[PATCH v4 06/24] eal/loongarch: add cpu flag checks for LoongArch

2022-07-21 Thread Min Zhou
This patch uses aux vector software register to get CPU flags and add CPU flag checking support for LoongArch architecture. Signed-off-by: Min Zhou --- lib/eal/loongarch/include/rte_cpuflags.h | 39 ++ lib/eal/loongarch/rte_cpuflags.c | 94 2 files change

[PATCH v4 01/24] eal/loongarch: add atomic operations for LoongArch

2022-07-21 Thread Min Zhou
This patch adds architecture specific atomic operations for LoongArch architecture. These implementations use standard atomics of toolchain and heavily reference generic atomics codes. Signed-off-by: Min Zhou --- lib/eal/loongarch/include/rte_atomic.h | 253 + 1 file chan

[PATCH v4 08/24] eal/loongarch: add io operations for LoongArch

2022-07-21 Thread Min Zhou
This patch adds io operations for LoongArch architecture. Let it uses generic I/O implementation. Signed-off-by: Min Zhou --- lib/eal/loongarch/include/rte_io.h | 18 ++ 1 file changed, 18 insertions(+) create mode 100644 lib/eal/loongarch/include/rte_io.h diff --git a/lib/eal/

[PATCH v4 09/24] eal/loongarch: add mcslock operations for LoongArch

2022-07-21 Thread Min Zhou
This patch adds mcslock operations for LoongArch architecture. Let it uses generic mcslock implementation. Signed-off-by: Min Zhou --- lib/eal/loongarch/include/rte_mcslock.h | 18 ++ 1 file changed, 18 insertions(+) create mode 100644 lib/eal/loongarch/include/rte_mcslock.h di

[PATCH v4 11/24] eal/loongarch: add pflock operations for LoongArch

2022-07-21 Thread Min Zhou
This patch adds pflock operations for LoongArch architecture. Let it uses generic pflock implementation. Signed-off-by: Min Zhou --- lib/eal/loongarch/include/rte_pflock.h | 17 + 1 file changed, 17 insertions(+) create mode 100644 lib/eal/loongarch/include/rte_pflock.h diff --

[PATCH v4 13/24] eal/loongarch: add ticketlock operations for LoongArch

2022-07-21 Thread Min Zhou
This patch adds ticketlock operations for LoongArch architecture. Let it uses generic ticketlock implementation. Signed-off-by: Min Zhou --- lib/eal/loongarch/include/rte_ticketlock.h | 18 ++ 1 file changed, 18 insertions(+) create mode 100644 lib/eal/loongarch/include/rte_tick

[PATCH v4 12/24] eal/loongarch: add rwlock operations for LoongArch

2022-07-21 Thread Min Zhou
This patch adds rwlock operations for LoongArch architecture. These implementations refer to rte_rwlock.h of PPC. Signed-off-by: Min Zhou --- lib/eal/loongarch/include/rte_rwlock.h | 42 ++ 1 file changed, 42 insertions(+) create mode 100644 lib/eal/loongarch/include/rte

[PATCH v4 16/24] mem: add huge page size definition for LoongArch

2022-07-21 Thread Min Zhou
LoongArch architecture has a different huge page size (32MB) than other architectures. This patch adds a new huge page size for LoongArch architecture. Signed-off-by: Min Zhou --- lib/eal/include/rte_memory.h | 1 + lib/eal/include/rte_memzone.h | 1 + 2 files changed, 2 insertions(+) diff --g

[PATCH v4 15/24] eal/loongarch: add hypervisor operations for LoongArch

2022-07-21 Thread Min Zhou
This patch adds hypervisor operations for LoongArch architecture. In fact, these operations are currently not supported on LoongArch. Signed-off-by: Min Zhou --- lib/eal/loongarch/rte_hypervisor.c | 11 +++ 1 file changed, 11 insertions(+) create mode 100644 lib/eal/loongarch/rte_hyperv

[PATCH v4 17/24] eal/linux: set eal base address for LoongArch

2022-07-21 Thread Min Zhou
This patch sets a different eal base address for LoongArch architecture. Signed-off-by: Min Zhou --- lib/eal/linux/eal_memory.c | 4 1 file changed, 4 insertions(+) diff --git a/lib/eal/linux/eal_memory.c b/lib/eal/linux/eal_memory.c index c890c42106..60fc8cc6ca 100644 --- a/lib/eal/linux/

[PATCH v4 14/24] eal/loongarch: add power operations for LoongArch

2022-07-21 Thread Min Zhou
This patch adds power operations for LoongArch architecture. In fact, these operations are temporarily not supported on LoongArch. Signed-off-by: Min Zhou --- .../loongarch/include/rte_power_intrinsics.h | 20 lib/eal/loongarch/rte_power_intrinsics.c | 51 +++ 2 fi

[PATCH v4 19/24] test/xmmt_ops: add dummy vector implementation for LoongArch

2022-07-21 Thread Min Zhou
The hardware instructions based vector implementation will come in a future patch. This dummy implementation can also work. Signed-off-by: Min Zhou --- app/test/test_xmmt_ops.h | 17 + 1 file changed, 17 insertions(+) diff --git a/app/test/test_xmmt_ops.h b/app/test/test_xmmt_op

[PATCH v4 18/24] meson: introduce LoongArch architecture

2022-07-21 Thread Min Zhou
This patch adds some meson.build files for building DPDK on LoongArch architecture. Signed-off-by: Min Zhou --- .../loongarch/loongarch_loongarch64_linux_gcc | 16 +++ config/loongarch/meson.build | 43 +++ lib/eal/loongarch/include/meson.build | 21 +

[PATCH v4 21/24] i40e: add dummy vector implementation for LoongArch

2022-07-21 Thread Min Zhou
The purpose of this patch is used to fix building issues for LoongArch architecture. The hardware instructions based vector implementation will come in a future patch. Signed-off-by: Min Zhou --- drivers/net/i40e/i40e_rxtx_vec_lsx.c | 54 drivers/net/i40e/meson.build

[PATCH v4 24/24] maintainers: claim responsibility for LoongArch

2022-07-21 Thread Min Zhou
This patch adds claim responsibility for LoongArch architecture. Signed-off-by: Min Zhou --- MAINTAINERS | 9 + 1 file changed, 9 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 32ffdd1a61..996e70c1cb 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -275,6 +275,15 @@ F: lib/eal/

[PATCH v4 20/24] ixgbe: add dummy vector implementation for LoongArch

2022-07-21 Thread Min Zhou
The purpose of this patch is used to fix building issues for LoongArch architecture. The hardware instructions based vector implementation will come in a future patch. Signed-off-by: Min Zhou --- drivers/net/ixgbe/ixgbe_rxtx_vec_lsx.c | 60 ++ drivers/net/ixgbe/meson.buil

[PATCH v4 23/24] memif: add system call number for LoongArch

2022-07-21 Thread Min Zhou
This patch adds system call number of memfd_create for LoongArch architecture. Signed-off-by: Min Zhou --- drivers/net/memif/rte_eth_memif.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/memif/rte_eth_memif.h b/drivers/net/memif/rte_eth_memif.h index 81e7dceae0

[PATCH v4 22/24] tap: add system call number for LoongArch

2022-07-21 Thread Min Zhou
This patch adds system call number of bpf for LoongArch architecture. Signed-off-by: Min Zhou --- drivers/net/tap/tap_bpf.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/tap/tap_bpf.h b/drivers/net/tap/tap_bpf.h index 639bdf3a79..4707f65e1d 100644 --- a/drivers/

[PATCH v4 10/24] eal/loongarch: add pause operations for LoongArch

2022-07-21 Thread Min Zhou
This patch adds architecture specific pause operations for LoongArch architecture. Signed-off-by: Min Zhou --- lib/eal/loongarch/include/rte_pause.h | 24 1 file changed, 24 insertions(+) create mode 100644 lib/eal/loongarch/include/rte_pause.h diff --git a/lib/eal/loo

Re: [PATCH] net/tap: fix the overflow of the network interface index.

2022-07-21 Thread Stephen Hemminger
On Thu, 21 Jul 2022 11:13:01 + Alex Kiselev wrote: > On Linux and most other systems, network interface index is a 32-bit > integer. Indexes overflowing the 16-bit integer are frequently seen > when used inside a Docker container. > > Signed-off-by: Alex Kiselev Looks good, Linux API is i

Re: [RFC] memarea: introduce memory area library

2022-07-21 Thread Stephen Hemminger
On Thu, 21 Jul 2022 12:46:48 +0800 Chengwen Feng wrote: > +struct rte_memarea { > + void *private_data; /**< private management data pointer*/ > + struct rte_memarea_param init; > +}; Why does this structure have to be exposed in user API? Hiding it in implementation would reduce ABI bre

[PATCH 1/2] examples/ipsec-secgw: use Tx cksum offload conditionally

2022-07-21 Thread Nithin Dabilpuram
Use Tx checksum offload only when all the ports have it enabled as the qconf for a particular lcore stores ipv4_offloads for all the Tx ports and each lcore can Tx to any port. Fixes: 03128be4cd4d ("examples/ipsec-secgw: allow disabling some Rx/Tx offloads") Cc: konstantin.anan...@intel.com Sign

[PATCH 2/2] examples/ipsec-secgw: fix issue with IP hdr manipulation

2022-07-21 Thread Nithin Dabilpuram
Fix issue with ip header pointer computation to pick the right offset. Fixes: 6eb3ba03995c ("examples/ipsec-secgw: support poll mode NEON LPM lookup") Cc: rbhans...@marvell.com Signed-off-by: Nithin Dabilpuram --- examples/ipsec-secgw/ipsec_neon.h | 2 +- 1 file changed, 1 insertion(+), 1 delet

RE: [PATCH v2 3/3] l3fwd-power: add option to call uncore API

2022-07-21 Thread Pattan, Reshma
> -Original Message- > From: Kearney, Tadhg > +static int > +parse_uncore_index(const char *choice) > +{ > + if (frequency_index > freq_array_len) { Should this be compared against freq_array_len-1 ?. Ex: If total 10 frequencies the index can be only 0-9. Thanks, Reshma

Re: [RFC v2] non-temporal memcpy

2022-07-21 Thread Konstantin Ananyev
Hi Morten, This RFC proposes a set of functions optimized for non-temporal memory copy. At this stage, I am asking for feedback on the concept. Applications sometimes data to another memory location, which is only used much later. In this case, it is inefficient to pollute the data cache with