On 11/10/22 19:53, Stephen Hemminger wrote:
Do a clean shutdown of testpmd when a signal is received;
instead of having testpmd kill itself.
This fixes the problem where a signal could be received
in the middle of a PMD and then the signal handler would call
PMD's close routine leading to locking
CRC is stripped by the hardware in the scattered Rx path. The last buffer
is invalid if it's packet length is zero.
This patch adds a judgment for the last buffer length to fix this issue,
it would free the mbuf associated to the last one if the last buffer is
empty.
Fixes: 6eac0b7fde95 ("net/ice
The scalar Tx path would send empty buffer that causes the Tx queue to
overflow.
This patch adds the last buffer length judgment in tx_prepare to fix this
issue, rte_errno will be set to EINVAL and returned if the last buffer is
empty.
Fixes: 17c7d0f9d6a4 ("net/ice: support basic Rx/Tx")
Fixes: c
The vector Tx path does not support VLAN insertion via the L2TAG2 field,
but the scalar path supports. The earlier commit was to force to select
scalar path as soon as kernel driver requests to use L2TAG2. That logic is
incorrect. Because other case like VLAN offloading not required but scalar
path
11/11/2022 08:26, Feifei Wang:
> For Arm aarch, power monitor uses WFE instruction to enable, which can
> not exit automatically within the time limit. This means
> 'rte_power_monitor_wakeup' API needs to be called to wake up sleep cores
> if there is no store operation to monitored address.
>
> F
The scalar Tx path would send empty buffer that causes the Tx queue to
overflow.
This patch adds the last buffer length judgment in tx_prepare to fix this
issue, rte_errno will be set to EINVAL and returned if the last buffer is
empty.
Fixes: 17c7d0f9d6a4 ("net/ice: support basic Rx/Tx")
Fixes: c
CRC is stripped by the hardware in the scattered Rx path. The last buffer
is invalid if it's packet length is zero.
This patch adds a judgment for the last buffer length to fix this issue,
it would free the mbuf associated to the last one if the last buffer is
empty.
Fixes: 6eac0b7fde95 ("net/ice
> -Original Message-
> From: Stephen Hemminger
> Sent: 2022年11月9日 0:40
> To: Owen Hilyard
> Cc: Honnappa Nagarahalli ;
> tho...@monjalon.net; Singh, Aman Deep ;
> Zhang, Yuying ; david.march...@redhat.com;
> dev@dpdk.org; Tu, Lijuan ; Juraj Linkeš
> ; nd
> Subject: Re: testpmd logging
> -Original Message-
> From: Zhang, Qi Z
> Sent: 2022年11月11日 13:09
> To: Ye, MingjinX ; dev@dpdk.org
> Cc: Yang, Qiming ; sta...@dpdk.org; Zhou, YidingX
> ; Wu, Jingjing ; Lu,
> Wenzhuo ; Ferruh Yigit ; Li,
> Xiaoyun ; Liu, KevinX
> Subject: RE: [PATCH v3 2/2] net/ice: fix scalar Tx pa
On 10/19/22 19:39, Ferruh Yigit wrote:
On 10/17/2022 3:41 PM, Andrew Rybchenko wrote:
This is useful for the incoming support of TCP TSO in Tx only mode.
Signed-off-by: Georgiy Levashov
Signed-off-by: Ivan Ilchenko
Signed-off-by: Andrew Rybchenko
---
app/test-pmd/parameters.c | 6 +--
ap
On 10/19/22 19:41, Ferruh Yigit wrote:
On 10/17/2022 3:41 PM, Andrew Rybchenko wrote:
Add '--txonly-tso-mss=N' option that enables TSO offload
and generates packets with specified MSS in txonly mode.
Signed-off-by: Georgiy Levashov
Signed-off-by: Ivan Ilchenko
Signed-off-by: Andrew Rybchenko
> -Original Message-
> From: Ye, MingjinX
> Sent: Friday, November 11, 2022 4:31 PM
> To: Zhang, Qi Z ; dev@dpdk.org
> Cc: Yang, Qiming ; sta...@dpdk.org; Zhou, YidingX
> ; Wu, Jingjing ; Lu,
> Wenzhuo ; Ferruh Yigit ; Li,
> Xiaoyun ; Liu, KevinX
> Subject: RE: [PATCH v3 2/2] net/ice:
Add command-line option to generate TSO packets with specified MSS
in txonly mode.
I'm not sure that it is a good idea to enable TSO offload automaticaly
when the options is specified, but it is convenient.
v2:
- fix wrong data length calculation (as per review notes from Ferruh)
Andrew Rybc
This is useful for the incoming support of TCP TSO in Tx only mode.
Signed-off-by: Georgiy Levashov
Signed-off-by: Ivan Ilchenko
Signed-off-by: Andrew Rybchenko
---
app/test-pmd/parameters.c | 6 +--
app/test-pmd/testpmd.h| 4 +-
app/test-pmd/txonly.c | 98 +--
Add '--txonly-tso-mss=N' option that enables TSO offload
and generates packets with specified MSS in txonly mode.
Signed-off-by: Georgiy Levashov
Signed-off-by: Ivan Ilchenko
Signed-off-by: Andrew Rybchenko
---
app/test-pmd/parameters.c | 10 ++
app/test-pmd/testpmd.c
On 11/11/22 11:49, Andrew Rybchenko wrote:
Add command-line option to generate TSO packets with specified MSS
in txonly mode.
I'm not sure that it is a good idea to enable TSO offload automaticaly
when the options is specified, but it is convenient.
v2:
- fix wrong data length calculation
On 11/11/22 11:36, Andrew Rybchenko wrote:
On 10/19/22 19:39, Ferruh Yigit wrote:
On 10/17/2022 3:41 PM, Andrew Rybchenko wrote:
@@ -449,7 +474,8 @@ tx_only_begin(portid_t pi)
return -EINVAL;
}
- setup_pkt_udp_ip_headers(&pkt_ip_hdr, &pkt_udp_hdr, pkt_data_len);
+ setup_pk
> -Original Message-
> From: Kaiwen Deng
> Sent: Friday, November 11, 2022 2:39 PM
> To: dev@dpdk.org
> Cc: Yang, Qiming ; Zhou, YidingX
> ; Deng, KaiwenX ;
> Wang, Haiyue ; Dongdong Liu
> ; Andrew Rybchenko
>
> Subject: [PATCH v2] net/ixgbe: fix error of drop queue index
>
> The drop
> -Original Message-
> From: Ye, MingjinX
> Sent: Saturday, November 12, 2022 12:13 AM
> To: dev@dpdk.org
> Cc: Yang, Qiming ; sta...@dpdk.org; Zhou, YidingX
> ; Ye, MingjinX ; Zhang, Qi
> Z ; Wu, Jingjing ; Ferruh Yigit
> ; Lu, Wenzhuo ; Liu,
> KevinX
> Subject: [PATCH v4 2/2] net/ice
> -Original Message-
> From: Ye, MingjinX
> Sent: Saturday, November 12, 2022 12:13 AM
> To: dev@dpdk.org
> Cc: Yang, Qiming ; sta...@dpdk.org; Zhou, YidingX
> ; Ye, MingjinX ; Zhang, Qi
> Z ; Wu, Jingjing ; Ferruh Yigit
> ; Lu, Wenzhuo ; Li,
> Xiaoyun
> Subject: [PATCH v4 1/2] net/ice
This is useful for the incoming support of TCP TSO in Tx only mode.
Signed-off-by: Georgiy Levashov
Signed-off-by: Ivan Ilchenko
Signed-off-by: Andrew Rybchenko
---
app/test-pmd/parameters.c | 6 +--
app/test-pmd/testpmd.h| 4 +-
app/test-pmd/txonly.c | 109
Add command-line option to generate TSO packets with specified MSS
in txonly mode.
I'm not sure that it is a good idea to enable TSO offload automaticaly
when the options is specified, but it is convenient.
v3:
- a bit better fix of review notes from Ferruh
v2:
- fix wrong data length ca
Add '--txonly-tso-mss=N' option that enables TSO offload
and generates packets with specified MSS in txonly mode.
Signed-off-by: Georgiy Levashov
Signed-off-by: Ivan Ilchenko
Signed-off-by: Andrew Rybchenko
---
app/test-pmd/parameters.c | 10
app/test-pmd/testpmd.c
> -Original Message-
> From: Yang, Qiming
> Sent: Friday, November 11, 2022 1:27 PM
> To: dev@dpdk.org; Zhang, Qi Z
> Cc: Yang, Qiming
> Subject: [PATCH v2] doc: update matching list for i40e and ice driver
>
> Add recommended matching list for ice PMD in DPDK 22.07 and i40e PMD in
>
On Thu, Nov 10, 2022 at 12:39 AM Stephen Hemminger <
step...@networkplumber.org> wrote:
> On Wed, 9 Nov 2022 14:04:34 +0800
> Yangchao Zhou wrote:
>
> > In some scenarios, mbufs returned by rte_kni_rx_burst are not freed
> > immediately. So kni_allocate_mbufs may be failed, but we don't know.
>
> -Original Message-
> From: Zhang, Qi Z
> Sent: Friday, November 11, 2022 5:03 PM
> To: Ye, MingjinX ; dev@dpdk.org
> Cc: Yang, Qiming ; sta...@dpdk.org; Zhou, YidingX
> ; Wu, Jingjing ; Ferruh
> Yigit ; Lu, Wenzhuo ; Li,
> Xiaoyun
> Subject: RE: [PATCH v4 1/2] net/ice: fix scalar Rx
> -Original Message-
> From: Zhang, Qi Z
> Sent: Friday, November 11, 2022 5:02 PM
> To: Ye, MingjinX ; dev@dpdk.org
> Cc: Yang, Qiming ; sta...@dpdk.org; Zhou, YidingX
> ; Wu, Jingjing ; Ferruh
> Yigit ; Lu, Wenzhuo ; Liu,
> KevinX
> Subject: RE: [PATCH v4 2/2] net/ice: fix scalar Tx
This series adds self monitoring support i.e allows to configure and
read performance measurement unit (PMU) counters in runtime without
using perf utility. This has certain adventages when application runs on
isolated cores with nohz_full kernel parameter.
Events can be read directly using rte_pm
Add support for programming PMU counters and reading their values
in runtime bypassing kernel completely.
This is especially useful in cases where CPU cores are isolated
(nohz_full) i.e run dedicated tasks. In such cases one cannot use
standard perf utility without sacrificing latency and performa
Add support for reading ARM PMU events in runtime.
Signed-off-by: Tomasz Duszynski
---
app/test/test_pmu.c | 4 ++
lib/eal/arm/include/meson.build | 1 +
lib/eal/arm/include/rte_pmu_pmc.h | 37 +++
lib/eal/arm/meson.build | 4 ++
lib/eal/arm/rte_pmu.c
Add support for reading Intel PMU events in runtime.
Signed-off-by: Tomasz Duszynski
---
app/test/test_pmu.c | 2 ++
lib/eal/include/rte_pmu.h | 2 +-
lib/eal/x86/include/meson.build | 1 +
lib/eal/x86/include/rte_pmu_pmc.h | 32 +++
4 files
In order to profile app one needs to store significant amount of samples
somewhere for an analysis latern on. Since trace library supports
storing data in a CTF format lets take adventage of that and add a
dedicated PMU tracepoint.
Signed-off-by: Tomasz Duszynski
---
app/test/test_trace_perf.c
Add support for queue operations:
- rx_queue_release
- tx_queue_release
Previous gve_tx_queue_release and gve_rx_queue_release functions are
only used internally to release Rx/Tx queue related resources. But
when the queues or ports are required to re-config, both of the dev
ops tx_queue_release
> >
> > Good comment, I'll improve in v2.
>
> One more thing, if we go with changing the Formatting echo, then we should
> also change the Linting echo. Or we could do it in some other place just once,
> I'm not sure which is better.
>
I have one more request, could you add "echo 'Summary:'" bef
11/11/2022 11:06, Juraj Linkeš:
> > >
> > > Good comment, I'll improve in v2.
> >
> > One more thing, if we go with changing the Formatting echo, then we should
> > also change the Linting echo. Or we could do it in some other place just
> > once,
> > I'm not sure which is better.
>
> I have one
For Arm aarch, use WFE instructions to enable PMD power management.
Test Results:
dynamic instructions over 1sec without wfe with wfepercentage
ampere-altra6,298,483,712 9,117,624 -99.855%
thunderx2 6,990,909,373 3,247,226 -99.
For wait scheme generic helper, add 8 bits case.
Signed-off-by: Feifei Wang
Reviewed-by: Ruifeng Wang
---
lib/eal/arm/include/rte_pause_64.h | 27 ---
1 file changed, 24 insertions(+), 3 deletions(-)
diff --git a/lib/eal/arm/include/rte_pause_64.h
b/lib/eal/arm/include
For Arm aarch, use WFE instruction to enable power monitor API, and use
SEV instruction to enable wake up API.
Signed-off-by: Feifei Wang
Reviewed-by: Ruifeng Wang
---
lib/eal/arm/include/rte_pause_64.h | 5 ++-
lib/eal/arm/rte_cpuflags.c | 5 +++
lib/eal/arm/rte_power_intrinsics.c |
For ARM aarch, power monitor uses WFE instruction to enable, which can
not exit automatically within the time limit. This means
'rte_power_monitor_wakeup' API needs to be called to wake up sleep cores
if there is no store operation to monitored address.
For other aarch, 'rte_power_monitor_wakeup'
On ARM, WFE instruction, which is used to power monitor, has no timeout
wake-up mechanism, and if users want to exit power monitor actively, the
main lcore is needed to send SEV instruction to wake up other lcores.
So it is necessary to ensure the main lcore does not enter the
power-monitor state.
Hi, Thomas
> -邮件原件-
> 发件人: Thomas Monjalon
> 发送时间: Friday, November 11, 2022 4:22 PM
> 收件人: Feifei Wang
> 抄送: David Hunt ; dev@dpdk.org;
> david.march...@redhat.com; step...@networkplumber.org; nd
> ; Ruifeng Wang ; Honnappa
> Nagarahalli
> 主题: Re: [PATCH v3 3/3] examples/l3fwd-power: en
Release status meeting minutes 2022-11-10
=
Agenda:
* Release Dates
* Subtrees
* Roadmaps
* LTS
* Defects
* Opens
Participants:
* ARM [No]
* Canonical [No]
* Debian/Microsoft
* Intel
* Marvell
* Nvidia
* Red Hat
* Xilinx/AMD
Release Dates
-
T
This patch remove incorrect bitwise and operator used in the
return function of sw snow3g testcase
Signed-off-by: Kai Ji
---
app/test/test_cryptodev.c | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/app/test/test_cryptodev.c b/app/test/test_cryptodev.c
index e1122fcd7c.
On 11/11/2022 11:59 AM, Kai Ji wrote:
This patch remove incorrect bitwise and operator used in the
return function of sw snow3g testcase
Signed-off-by: Kai Ji
---
app/test/test_cryptodev.c | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/app/test/test_cryptodev.c b/a
> Subject: [EXT] Re: [dpdk-dev v1] app/test: fix of bitwise and operator in
> return
>
> External Email
>
> --
> On 11/11/2022 11:59 AM, Kai Ji wrote:
> > This patch remove incorrect bitwise and operator used in the
> > return f
Reset the crypto device after asym tests so that the state from
asymmetric tests won't affect the tests executed later.
Signed-off-by: Anoob Joseph
---
app/test/test_cryptodev_asym.c | 6 ++
1 file changed, 6 insertions(+)
diff --git a/app/test/test_cryptodev_asym.c b/app/test/test_cryptode
On 11/11/2022 9:58 AM, Junfeng Guo wrote:
Add support for queue operations:
- rx_queue_release
- tx_queue_release
Previous gve_tx_queue_release and gve_rx_queue_release functions are
only used internally to release Rx/Tx queue related resources. But
when the queues or ports are required to r
On 11/8/2022 3:00 PM, Dariusz Sosnowski wrote:
From: Suanming Mou
This patch adds explicit flushing of template tables,
pattern and actions templates, when a port is closed or
detached.
Signed-off-by: Suanming Mou
Acked-by: Aman Singh
---
Hi Kai,
> -Original Message-
> From: Ji, Kai
> Sent: Thursday, November 10, 2022 11:40 AM
> To: De Lara Guarch, Pablo
> Cc: dev@dpdk.org; Power, Ciara
> Subject: RE: [PATCH v3] doc: support IPsec Multi-buffer lib v1.3
>
> Do we need to add the section about chacha-poly PMD ?
> is that
This patch remove incorrect bitwise and operator used in the
return function of sw snow3g testcase
Fixes: 24342ade2c9d ("test/crypto: check SNOW3G when digest is encrypted")
Cc: lukaszx.krakow...@intel.com
Signed-off-by: Kai Ji
---
app/test/test_cryptodev.c | 6 --
1 file changed, 4 inserti
On Fri, 11 Nov 2022 11:05:24 +0300
Andrew Rybchenko wrote:
> It looks wrong to skip pmd_test_exit() in periodic stats
> case (if body above). Earlier it happened in signal handler.
> IMHO, pmd_test_exit() should be done just before pdump
> uninit below (outside if/else bodies (and removed from
>
Do a clean shutdown of testpmd when a signal is received;
instead of having testpmd kill itself.
This fixes the problem where a signal could be received
in the middle of a PMD and then the signal handler would call
PMD's close routine leading to locking problems.
An added benefit is it gets rid of
Minutes of Technical Board Meeting, 2022-Nov-2
Members Attending
-
-Aaron
-Bruce
-Honnappa
-Jerin
-Kevin (Chair)
-Maxime
-Stephen
-Thomas
NOTE: The technical board meetings every second Wednesday at
https://meet.jit.si/DPDK at 3 pm UTC.
Meetings are public, and DPDK community mem
On Fri, 11 Nov 2022 05:41:05 +
Bing Zhao wrote:
> Hi Stephen,
>
> > -Original Message-
> > From: Stephen Hemminger
> > Sent: Friday, November 11, 2022 12:22 AM
> > To: Bing Zhao
> > Cc: Slava Ovsiienko ; Matan Azrad
> > ; dev@dpdk.org; Raslan Darawsheh
> > ; sta...@dpdk.org
> > Sub
Hi Mattias,
Maybe an example helps explain this. Here is an example where the CRC hash
function is registered in the DPDK pipeline:
http://git.dpdk.org/dpdk/tree/lib/pipeline/rte_swx_pipeline.c?id=203dcc9cfe4151518bb5a5c59ee22a754e649e35#n10115.
We need something similar to this for the XOR hash.
Hi Robin,
On 21/10/2022 15:53, Robin Jarry wrote:
Some control protocols are used to maintain link status between
forwarding engines (e.g. LACP). When the system is not sized properly,
the PMD threads may not be able to process all incoming traffic from the
configured Rx queues. When a signaling
On Thu, Oct 20, 2022 at 08:36:05AM -0700, Stephen Hemminger wrote:
> On Thu, 20 Oct 2022 13:20:40 +0200
> David Marchand wrote:
>
> > On Fri, Oct 14, 2022 at 9:54 AM Markus Theil
> > wrote:
> > >
> > > From: Michael Pfeiffer
> > >
> > > Also expose the pthread id of each lcore, in
> > > order
57 matches
Mail list logo
