Re: [PATCH v2 2/2] doc: simplify the binding steps

2022-11-23 Thread Thomas Monjalon
22/11/2022 22:21, Chautru, Nicolas: > From: Thomas Monjalon > > 15/11/2022 20:59, Nicolas Chautru: > > > -The PCI virtual functions must be configured before working or > > > getting assigned -to VMs/Containers. The configuration involves > > > allocating the number of hardware > > > +The device m

[Bug 1132] net/i40e changes recommended Rx ring_size after device start

2022-11-23 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=1132 Bug ID: 1132 Summary: net/i40e changes recommended Rx ring_size after device start Product: DPDK Version: 22.11 Hardware: All OS: All Status: UNCONFIRME

[RFC PATCH 0/4] lcore telemetry improvements

2022-11-23 Thread Robin Jarry
This is a follow up on previous work by Kevin Laatz: http://patches.dpdk.org/project/dpdk/list/?series=24658&state=* This is a much more basic and naive approach which leaves the busy cycles percentage completely up to the application. This series is aimed at allowing DPDK applications to expose

[RFC PATCH 1/4] eal: add lcore info in telemetry

2022-11-23 Thread Robin Jarry
Report the same information than rte_lcore_dump() in the telemetry API into /eal/lcore/list and /eal/lcore/info,ID. Example: --> /eal/lcore/info,3 { "/eal/lcore/info": { "lcore_id": 3, "socket": 0, "role": "RTE", "cpuset": "3" } } Signed-off-by: Robin Jarry

[RFC PATCH 2/4] eal: allow applications to report their cpu utilization

2022-11-23 Thread Robin Jarry
Allow applications to register a callback that will be invoked in rte_lcore_dump() and when requesting lcore info in the telemetry API. The callback is expected to return a number between 0 and 100 representing the percentage of busy cycles spent over a fixed period of time. The period of time is

[RFC PATCH 3/4] testpmd: add show lcores command

2022-11-23 Thread Robin Jarry
Add a simple command that calls rte_lcore_dump(). Signed-off-by: Robin Jarry --- app/test-pmd/cmdline.c | 31 +++ 1 file changed, 31 insertions(+) diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c index b32dc8bfd445..d290938ffb4e 100644 --- a/app/test-pmd/

[RFC PATCH 4/4] testpmd: report lcore usage

2022-11-23 Thread Robin Jarry
Reuse the --record-core-cycles option to account for busy cycles. One turn of packet_fwd_t is considered "busy" if there was at least one received or transmitted packet. Add two new interval_cycles and busy_cycles fields to the fwd_stream structure. The core_cycles field cannot be reset to zero wi

[RFC PATCH 0/4] lcore telemetry improvements

2022-11-23 Thread Robin Jarry
This is a follow up on previous work by Kevin Laatz: http://patches.dpdk.org/project/dpdk/list/?series=24658&state=* This is a much more basic and naive approach which leaves the busy cycles percentage completely up to the application. This series is aimed at allowing DPDK applications to expose

[RFC PATCH 1/4] eal: add lcore info in telemetry

2022-11-23 Thread Robin Jarry
Report the same information than rte_lcore_dump() in the telemetry API into /eal/lcore/list and /eal/lcore/info,ID. Example: --> /eal/lcore/info,3 { "/eal/lcore/info": { "lcore_id": 3, "socket": 0, "role": "RTE", "cpuset": "3" } } Signed-off-by: Robin Jarry

[RFC PATCH 2/4] eal: allow applications to report their cpu utilization

2022-11-23 Thread Robin Jarry
Allow applications to register a callback that will be invoked in rte_lcore_dump() and when requesting lcore info in the telemetry API. The callback is expected to return a number between 0 and 100 representing the percentage of busy cycles spent over a fixed period of time. The period of time is

[RFC PATCH 3/4] testpmd: add show lcores command

2022-11-23 Thread Robin Jarry
Add a simple command that calls rte_lcore_dump(). Signed-off-by: Robin Jarry --- app/test-pmd/cmdline.c | 31 +++ 1 file changed, 31 insertions(+) diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c index b32dc8bfd445..d290938ffb4e 100644 --- a/app/test-pmd/

[RFC PATCH 4/4] testpmd: report lcore usage

2022-11-23 Thread Robin Jarry
Reuse the --record-core-cycles option to account for busy cycles. One turn of packet_fwd_t is considered "busy" if there was at least one received or transmitted packet. Add two new interval_cycles and busy_cycles fields to the fwd_stream structure. The core_cycles field cannot be reset to zero wi

Re: [RFC PATCH 0/4] lcore telemetry improvements

2022-11-23 Thread Robin Jarry
There was a hiccup with my smtp config. Sorry about the double send. Please ignore this series and reply on the other one. I have updated patchwork accordingly.

[PATCH v2] devtools: set DTS directory to format check

2022-11-23 Thread Thomas Monjalon
The script was running on the current directory. If not in the DTS directory, it would re-format every Python files. A new positional argument is added to specify the directory to check. In most cases, the (new) default value should be enough. While updating argument handling, the usage is printe

RE: [RFC PATCH 2/4] eal: allow applications to report their cpu utilization

2022-11-23 Thread Morten Brørup
> From: Robin Jarry [mailto:rja...@redhat.com] > Sent: Wednesday, 23 November 2022 11.19 > To: dev@dpdk.org > Cc: Bruce Richardson; Jerin Jacob; Kevin Laatz; Konstantin Ananyev; > Mattias Rönnblom; Morten Brørup; Robin Jarry > Subject: [RFC PATCH 2/4] eal: allow applications to report their cpu > u

[PATCH] net/mlx5: fix GENEVE resource overwritten

2022-11-23 Thread Suanming Mou
Currently, one rte_flow may be split to multiple sub mlx5_flows. While GENEVE option resource was allocated in the first mlx5_flow, the flag will be overwritten by next sub mlx5_flow. This caused GENEVE option resource leakage. This commit adds the check of GENEVE option resource to avoid the GENE

RE: [RFC PATCH v2 03/10] dts: add dpdk build on sut

2022-11-23 Thread Juraj Linkeš
Apologies for removing recipients in my previous reply. From: Owen Hilyard Sent: Monday, November 21, 2022 1:35 PM To: Juraj Linkeš Subject: Re: [RFC PATCH v2 03/10] dts: add dpdk build on sut On Fri, Nov 18, 2022 at 7:24 AM Juraj Linkeš mailto:juraj.lin...@pantheon.tech>> wrote: A note: If I'

[PATCH] net/ice: fix link status error when dev start

2022-11-23 Thread Shuang Han
ice_link_update get port link status and wait for one second when dev start. If the device need almost one second for link up, ice_link_update will enter the last rte_delay_ms(CHECK_INTERVAL) with link down, in the meantime link interrupt raised, the interrupt handler update dev->data->dev_link to

RE: [RFC PATCH v2 04/10] dts: add dpdk execution handling

2022-11-23 Thread Juraj Linkeš
Again, apologies for removing recipients in my earlier reply. From: Owen Hilyard Sent: Monday, November 21, 2022 1:40 PM To: Juraj Linkeš Subject: Re: [RFC PATCH v2 04/10] dts: add dpdk execution handling On Fri, Nov 18, 2022 at 8:00 AM Juraj Linkeš mailto:juraj.lin...@pantheon.tech>> wrote: d

Re: [RFC PATCH 2/4] eal: allow applications to report their cpu utilization

2022-11-23 Thread Robin Jarry
Hi Morten, Morten Brørup, Nov 23, 2022 at 12:52: > This patch is based on a "gauge" (i.e. the busyness percentage) and an > "interval" (i.e. the duration the gauge covers). I have to sample this > gauge exactly every interval to collect data for a busyness chart. If > the application's reporting i

RE: [PATCH v2] devtools: set DTS directory to format check

2022-11-23 Thread Juraj Linkeš
-Original Message- From: Thomas Monjalon Sent: Wednesday, November 23, 2022 12:22 PM To: dev@dpdk.org Cc: Juraj Linkeš ; Owen Hilyard ; Lijuan Tu Subject: [PATCH v2] devtools: set DTS directory to format check The script was running on the current directory. If not in the DTS directo

RE: [RFC PATCH v2 05/10] dts: add node memory setup

2022-11-23 Thread Juraj Linkeš
From: Owen Hilyard Sent: Wednesday, November 16, 2022 2:48 PM To: Juraj Linkeš Cc: tho...@monjalon.net; honnappa.nagaraha...@arm.com; lijuan...@intel.com; bruce.richard...@intel.com; dev@dpdk.org Subject: Re: [RFC PATCH v2 05/10] dts: add node memory setup On Mon, Nov 14, 2022 at 11:54 AM J

Re: [PATCH v2] devtools: set DTS directory to format check

2022-11-23 Thread Thomas Monjalon
> The script was running on the current directory. > If not in the DTS directory, it would re-format every Python files. > > A new positional argument is added to specify the directory to check. > In most cases, the (new) default value should be enough. > > While updating argument handling, > the

Re: [PATCH] devtools: fix checkpatches subject retrieval from stdin

2022-11-23 Thread Thomas Monjalon
29/09/2022 14:04, Olivier Matz: > When passing the patch to checkpatches.sh through stdin, the subject is > retrieved by reading the input until a "Subject:" entry is found. The > rest of the input is piped to checkpatch.pl. > > Since the "From:" line is before the "Subject:" line, it won't be sen

Re: [RFC PATCH 2/4] eal: allow applications to report their cpu utilization

2022-11-23 Thread Stephen Hemminger
On Wed, 23 Nov 2022 11:19:29 +0100 Robin Jarry wrote: > +static rte_lcore_busy_percent_cb lcore_busy_cb; > +static unsigned int lcore_busy_period; > + > +void > +rte_lcore_register_busy_percent_cb(rte_lcore_busy_percent_cb cb, unsigned > int period) > +{ > + lcore_busy_cb = cb; > + lcore

[PATCH 0/2] eal: provide leading and trailing zero bit count

2022-11-23 Thread Tyler Retzlaff
Provide leading and trailing zero bit count functions to abstract away compiler specific implementations. Include basic unit test for new leading/trailing zero bit count functions. Tyler Retzlaff (2): eal: provide leading and trailing zero bit count abstraction test/bitcount: add bitcount tes

[PATCH 2/2] test/bitcount: add bitcount tests

2022-11-23 Thread Tyler Retzlaff
basic unit test of following functions rte_clz rte_clzl rte_clzll rte_ctz rte_ctzl rte_ctzll Signed-off-by: Tyler Retzlaff --- app/test/meson.build | 2 ++ app/test/test_bitcount.c | 92 2 files changed, 94 insertions

[PATCH 1/2] eal: provide leading and trailing zero bit count abstraction

2022-11-23 Thread Tyler Retzlaff
Provide an abstraction for leading and trailing zero bit counting functions to hide compiler specific intrinsics and builtins. Signed-off-by: Tyler Retzlaff --- lib/eal/include/meson.build| 1 + lib/eal/include/rte_bitcount.h | 257 + 2 files changed

Re: Commit broke 32-bit testpmd app

2022-11-23 Thread Sampath Peechu (speechu)
Hi Maxime, I’m attaching the following for reference. * Instructions for Centos8 test setup * Diffs between the working and non-working versions (working version has the problem commit backed out) * Working logs (stats show that ping packets from neighbor VM can be seen with both 6

Re: [RFC PATCH 1/4] eal: add lcore info in telemetry

2022-11-23 Thread Robin Jarry
Stephen Hemminger, Nov 23, 2022 at 17:44: > Rather than reporting cpuset as a string might it be better > as a JSON array? > "cpuset" : [ 3, 5 ] Good point, will do that in v2.

[PATCH v2 0/2] eal: provide leading and trailing zero bit count

2022-11-23 Thread Tyler Retzlaff
Provide leading and trailing zero bit count functions to abstract away compiler specific implementations. Include basic unit test for new leading/trailing zero bit count functions. v2: * use unsigned int instead of unsigned (checkpatches) * match multiple include guard naming convention to rt

[PATCH v2 1/2] eal: provide leading and trailing zero bit count abstraction

2022-11-23 Thread Tyler Retzlaff
Provide an abstraction for leading and trailing zero bit counting functions to hide compiler specific intrinsics and builtins. Signed-off-by: Tyler Retzlaff --- lib/eal/include/meson.build| 1 + lib/eal/include/rte_bitcount.h | 265 + 2 files changed

[PATCH v2 2/2] test/bitcount: add bitcount tests

2022-11-23 Thread Tyler Retzlaff
basic unit test of following functions rte_clz rte_clzl rte_clzll rte_ctz rte_ctzl rte_ctzll Signed-off-by: Tyler Retzlaff --- app/test/meson.build | 2 ++ app/test/test_bitcount.c | 92 2 files changed, 94 insertions

Re: [RFC PATCH 3/4] testpmd: add show lcores command

2022-11-23 Thread fengchengwen
Hi Robin, On 2022/11/23 18:19, Robin Jarry wrote: > Add a simple command that calls rte_lcore_dump(). > > Signed-off-by: Robin Jarry > --- > app/test-pmd/cmdline.c | 31 +++ > 1 file changed, 31 insertions(+) > > diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cm

RE: [PATCH v2 2/2] doc: simplify the binding steps

2022-11-23 Thread Chautru, Nicolas
Hi Thomas, > -Original Message- > From: Thomas Monjalon > Sent: Wednesday, November 23, 2022 12:35 AM > To: Chautru, Nicolas > Cc: dev@dpdk.org; gak...@marvell.com; maxime.coque...@redhat.com; > Vargas, Hernan > Subject: Re: [PATCH v2 2/2] doc: simplify the binding steps > > 22/11/202

[PATCH] net/gve: add support for basic stats

2022-11-23 Thread Junfeng Guo
Add support for dev_ops of stats_get and stats_reset. Queue stats update will be moved into xstat [1], but the basic stats items may still be required. So we just keep the remaining ones and will implement the queue stats via xstats in the coming release. [1] https://elixir.bootlin.com/dpdk/v22.0