[dpdk-dev] [PATCH 1/1] eal: fix error log in rte_dev_probe

2022-12-05 Thread Yunjian Wang
In the device probing, there is no need to log the error message in the case, that device has been already probed and return with -EEXIST. Fixes: 244d5130719c ("eal: enable hotplug on multi-process") Cc: sta...@dpdk.org Signed-off-by: Lipei Liang Signed-off-by: Yunjian Wang --- lib/eal/common/

[PATCH 2/2] net/bonding: support dump LACP info

2022-12-05 Thread Chengwen Feng
This patch adds dump lacp info in eth_dev_priv_dump ops. The extra dump output is to testpmd command "show bonding lacp info [port]". Signed-off-by: Chengwen Feng --- drivers/net/bonding/rte_eth_bond_pmd.c | 143 - 1 file changed, 141 insertions(+), 2 deletions(-) diff

[PATCH 0/2] support device private dump

2022-12-05 Thread Chengwen Feng
This patchset adds device private dump for bonding PMD. Chengwen Feng (2): net/bonding: support private dump ops net/bonding: support dump LACP info drivers/net/bonding/rte_eth_bond_pmd.c | 242 - 1 file changed, 241 insertions(+), 1 deletion(-) -- 2.17.1

[PATCH 1/2] net/bonding: support private dump ops

2022-12-05 Thread Chengwen Feng
This patch implements eth_dev_priv_dump ops which could enhance the debug capability. The dump output is similar to testpmd command "show bonding config [port]". Signed-off-by: Chengwen Feng --- drivers/net/bonding/rte_eth_bond_pmd.c | 103 - 1 file changed, 102 insertio

Re: [EXT] Re: [PATCH v3 1/1] app/testpmd: control passing Rx metadata to PMD

2022-12-05 Thread Thomas Monjalon
05/12/2022 08:59, Hanumanth Reddy Pothula: > From: Thomas Monjalon > > 02/12/2022 17:14, Hanumanth Reddy Pothula: > > > -Original Message- > > > > 27/10/2022 09:34, Thomas Monjalon: > > > > > 17/10/2022 10:32, Andrew Rybchenko: > > > > > > On 10/6/22 21:35, Hanumanth Pothula wrote: > > > >

[PATCH] maintainers: split baseband from crypto tree

2022-12-05 Thread Akhil Goyal
Baseband patches are now split from dpdk-next-crypto, All baseband patches need to be submitted to dpdk-next-baseband which will be maintained by Maxime. Cc: maxime.coque...@redhat.com Signed-off-by: Akhil Goyal --- MAINTAINERS | 12 1 file changed, 8 insertions(+), 4 deletions(-)

RE: [EXT] Re: [PATCH v3 1/1] app/testpmd: control passing Rx metadata to PMD

2022-12-05 Thread Slava Ovsiienko
> -Original Message- > From: Thomas Monjalon > Sent: Monday, December 5, 2022 10:29 > To: Andrew Rybchenko ; Hanumanth Reddy > Pothula > Cc: dev@dpdk.org; Aman Singh ; Yuying Zhang > ; dev@dpdk.org; Jerin Jacob Kollanukkaran > ; Nithin Kumar Dabilpuram ; > Raslan Darawsheh ; Ori Kam ; Sla

[PATCH] eal: have unregistered non-EAL threads use dedicated PRNG

2022-12-05 Thread Mattias Rönnblom
Prior to this change, unregistered non-EAL threads shared a PRNG instance with the main lcore. The main lcore may well be used for fast path processing, potentially making rte_rand() calls in the process. It should not need to synchronize with control threads. With this change, all unregistered no

RE: [PATCH v2] eal: add nonnull and access function attributes

2022-12-05 Thread Ruifeng Wang
> -Original Message- > From: Morten Brørup > Sent: Saturday, December 3, 2022 10:23 PM > To: dev@dpdk.org; roret...@linux.microsoft.com > Cc: Ruifeng Wang ; zhou...@loongson.cn; > d...@linux.vnet.ibm.com; > k...@semihalf.com; bruce.richard...@intel.com; > konstantin.v.anan...@yandex.ru;

Re: [PATCH v4 1/2] drivers: fix symbol exports when map is omitted

2022-12-05 Thread David Marchand
On Fri, Dec 2, 2022 at 2:39 PM Aaron Conole wrote: > > David Marchand writes: > > > ld exports any global symbol by default if no version script is passed. > > As a consequence, the incriminated change let any public symbol leak > > out of the driver shared libraries. > > > > Hide again those sym

RE: [EXT] Re: [PATCH v4 1/2] drivers: fix symbol exports when map is omitted

2022-12-05 Thread Akhil Goyal
> On Fri, Dec 2, 2022 at 2:39 PM Aaron Conole wrote: > > > > David Marchand writes: > > > > > ld exports any global symbol by default if no version script is passed. > > > As a consequence, the incriminated change let any public symbol leak > > > out of the driver shared libraries. > > > > > > Hi

RE: [PATCH] maintainers: split baseband from crypto tree

2022-12-05 Thread Hemant Agrawal
> Baseband patches are now split from dpdk-next-crypto, All baseband > patches need to be submitted to dpdk-next-baseband which will be > maintained by Maxime. > > Cc: maxime.coque...@redhat.com > > Signed-off-by: Akhil Goyal > --- > MAINTAINERS | 12 > 1 file changed, 8 insertions

RE: [PATCH] eal: have unregistered non-EAL threads use dedicated PRNG

2022-12-05 Thread Morten Brørup
> From: Mattias Rönnblom [mailto:mattias.ronnb...@ericsson.com] > Sent: Monday, 5 December 2022 11.04 > > Prior to this change, unregistered non-EAL threads shared a PRNG > instance with the main lcore. The main lcore may well be used for fast > path processing, potentially making rte_rand() calls

Re: [PATCH] maintainers: split baseband from crypto tree

2022-12-05 Thread Zhang, Fan
On 12/5/2022 7:59 AM, Akhil Goyal wrote: Baseband patches are now split from dpdk-next-crypto, All baseband patches need to be submitted to dpdk-next-baseband which will be maintained by Maxime. Cc: maxime.coque...@redhat.com Signed-off-by: Akhil Goyal --- MAINTAINERS | 12 1 f

Re: [PATCH] net/i40e: fix X722 NIC receives jumbo frame packets

2022-12-05 Thread David Marchand
Hi Kevin, Qi, On Thu, Nov 10, 2022 at 10:48 AM Zhang, Qi Z wrote: > > > Subject: [PATCH] net/i40e: fix X722 NIC receives jumbo frame packets > > > > > > For NIC I40E_10G-10G_BASE_T_X722, when the port is configured with > > > link speed, it cannot receive jumbo frame packets. > > > > > > Because

RE: [EXT] [PATCH v2 2/5] eventdev/crypto: fix wrong crypto enqueue count stats

2022-12-05 Thread Volodymyr Fialko
> -Original Message- > From: Ganapati Kundapura > Sent: Thursday, December 1, 2022 7:47 AM > To: dev@dpdk.org; Jerin Jacob Kollanukkaran ; > s.v.naga.haris...@intel.com; > abhinandan.guj...@intel.com > Cc: jay.jayatheert...@intel.com > Subject: [EXT] [PATCH v2 2/5] eventdev/crypto: fix

RE: [EXT] [PATCH v2 3/5] eventdev/crypto: fix wrong offset used while flushing events

2022-12-05 Thread Volodymyr Fialko
> -Original Message- > From: Ganapati Kundapura > Sent: Thursday, December 1, 2022 7:47 AM > To: dev@dpdk.org; Jerin Jacob Kollanukkaran ; > s.v.naga.haris...@intel.com; > abhinandan.guj...@intel.com > Cc: jay.jayatheert...@intel.com > Subject: [EXT] [PATCH v2 3/5] eventdev/crypto: fix

RE: [EXT] [PATCH v2 4/5] eventdev/crypto: fix overflow in circular buffer

2022-12-05 Thread Volodymyr Fialko
> -Original Message- > From: Ganapati Kundapura > Sent: Thursday, December 1, 2022 7:47 AM > To: dev@dpdk.org; Jerin Jacob Kollanukkaran ; > s.v.naga.haris...@intel.com; > abhinandan.guj...@intel.com > Cc: jay.jayatheert...@intel.com > Subject: [EXT] [PATCH v2 4/5] eventdev/crypto: fix

RE: [EXT] [PATCH v2 5/5] eventdev/crypto: add all failed events to circular buffer

2022-12-05 Thread Volodymyr Fialko
> -Original Message- > From: Ganapati Kundapura > Sent: Thursday, December 1, 2022 7:47 AM > To: dev@dpdk.org; Jerin Jacob Kollanukkaran ; > s.v.naga.haris...@intel.com; > abhinandan.guj...@intel.com > Cc: jay.jayatheert...@intel.com > Subject: [EXT] [PATCH v2 5/5] eventdev/crypto: add

Re: [PATCH] net/i40e: fix X722 NIC receives jumbo frame packets

2022-12-05 Thread Kevin Traynor
On 05/12/2022 11:15, David Marchand wrote: Hi Kevin, Qi, On Thu, Nov 10, 2022 at 10:48 AM Zhang, Qi Z wrote: Subject: [PATCH] net/i40e: fix X722 NIC receives jumbo frame packets For NIC I40E_10G-10G_BASE_T_X722, when the port is configured with link speed, it cannot receive jumbo frame packet

Re: [EXT] Re: [PATCH v4 1/2] drivers: fix symbol exports when map is omitted

2022-12-05 Thread David Marchand
On Mon, Dec 5, 2022 at 11:44 AM Akhil Goyal wrote: > > Please, maintainers and CI teams, when you enable ABI checks in the > > main branch, or in the 22.11 LTS branch, use the dpdk-stable 22.11.1 > > tag as a reference. > > Thanks. > > Should we also add a tag on main repo, as new development does

RE: [EXT] Re: [PATCH v4 1/2] drivers: fix symbol exports when map is omitted

2022-12-05 Thread Akhil Goyal
> On Mon, Dec 5, 2022 at 11:44 AM Akhil Goyal wrote: > > > Please, maintainers and CI teams, when you enable ABI checks in the > > > main branch, or in the 22.11 LTS branch, use the dpdk-stable 22.11.1 > > > tag as a reference. > > > Thanks. > > > > Should we also add a tag on main repo, as new de

Re: [EXT] Re: [PATCH v4 1/2] drivers: fix symbol exports when map is omitted

2022-12-05 Thread Thomas Monjalon
05/12/2022 14:47, Akhil Goyal: > > On Mon, Dec 5, 2022 at 11:44 AM Akhil Goyal wrote: > > > > Please, maintainers and CI teams, when you enable ABI checks in the > > > > main branch, or in the 22.11 LTS branch, use the dpdk-stable 22.11.1 > > > > tag as a reference. > > > > Thanks. > > > > > > Sho

mlx5 rte_eth_dev_info.reta_size value

2022-12-05 Thread Robin Jarry
Hi Ori, While working on a patch for OvS[1], I have tried to reconfigure the redirection table using the code examples that are layout around in testpmd and other places. [1]: http://patchwork.ozlabs.org/project/openvswitch/patch/20221021145308.141933-1-rja...@redhat.com/ Here is a stripped dow

Re: [RFC 2/2] ethdev: add API to set process to primary or secondary

2022-12-05 Thread Stephen Hemminger
On Fri, 2 Dec 2022 03:27:38 + Rongwei Liu wrote: > > > > The state of the devices and the system is really unstable if this fails. > > There is > > no rollback here. > > > Assume application is calling rte_eth_process_set_primary(false); > Once failed, call all preceding successful ports

RE: [EXT] Re: [PATCH v4 1/2] drivers: fix symbol exports when map is omitted

2022-12-05 Thread Akhil Goyal
> 05/12/2022 14:47, Akhil Goyal: > > > On Mon, Dec 5, 2022 at 11:44 AM Akhil Goyal wrote: > > > > > Please, maintainers and CI teams, when you enable ABI checks in the > > > > > main branch, or in the 22.11 LTS branch, use the dpdk-stable 22.11.1 > > > > > tag as a reference. > > > > > Thanks. > >

How to use specific OPENSSL

2022-12-05 Thread Pankaj Gupta
Hi All, We want to use specific downloaded openssl while compiling the DPDKv21.11. We don’t want to use the openssl installed in the build machine. We tried adding -Dc_args and -Dc_link_args to meson configure to specify the director of external openssl but build still seems to be linking to inst

[PATCH 2/3] test: add rte control thread create API test

2022-12-05 Thread Tyler Retzlaff
Duplicate the rte_ctrl_thread_create test adapted to use rte_control_thread create to keep both apis under test until rte_ctrl_thread_create is removed. Signed-off-by: Tyler Retzlaff --- app/test/test_lcores.c | 44 1 file changed, 44 insertions(+) d

[PATCH 3/3] eal: deprecate pthread control thread create API

2022-12-05 Thread Tyler Retzlaff
Signed-off-by: Tyler Retzlaff --- doc/guides/rel_notes/deprecation.rst | 4 1 file changed, 4 insertions(+) diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst index b9b02dc..cb74e08 100644 --- a/doc/guides/rel_notes/deprecation.rst +++ b/doc/guides/rel

[PATCH 0/3] eal: rte_ctrl_thread_create API replacement

2022-12-05 Thread Tyler Retzlaff
Remove rte_ctrl_thread_create API which exposes pthread_t and provide new rte_control_thread_create API based on EALs rte_thread_t. To limit compatibility regression risk and ease of removal of the existing rte_ctrl_thread_create in the future duplicate most of the existing implementation. The dup

[PATCH 1/3] eal: add rte control thread create API

2022-12-05 Thread Tyler Retzlaff
Signed-off-by: Tyler Retzlaff --- lib/eal/common/eal_common_thread.c | 93 ++ lib/eal/include/rte_thread.h | 29 lib/eal/version.map| 3 ++ 3 files changed, 117 insertions(+), 8 deletions(-) diff --git a/lib/eal/common/eal_c

RE: [PATCH 0/3] eal: rte_ctrl_thread_create API replacement

2022-12-05 Thread Morten Brørup
> From: Tyler Retzlaff [mailto:roret...@linux.microsoft.com] > Sent: Monday, 5 December 2022 21.24 > > Remove rte_ctrl_thread_create API which exposes pthread_t and provide > new rte_control_thread_create API based on EALs rte_thread_t. > > To limit compatibility regression risk and ease of remov

Re: [PATCH 1/3] eal: add rte control thread create API

2022-12-05 Thread Stephen Hemminger
On Mon, 5 Dec 2022 12:24:26 -0800 Tyler Retzlaff wrote: > Signed-off-by: Tyler Retzlaff > --- > lib/eal/common/eal_common_thread.c | 93 > ++ > lib/eal/include/rte_thread.h | 29 > lib/eal/version.map| 3 ++ > 3 files cha

Re: [PATCH 3/3] eal: deprecate pthread control thread create API

2022-12-05 Thread Stephen Hemminger
On Mon, 5 Dec 2022 12:24:28 -0800 Tyler Retzlaff wrote: > + > +* eal: The function ``rte_ctrl_thread_create`` will be removed and > + replaced by the new ``rte_control_thread_create``api, continuing the > + effort to decouple eal from platform-specific thread implementations. If you want to c

[PATCH] net/memif: change socket listener owner uid/gid

2022-12-05 Thread Junxiao Shi
This allows a DPDK application running with root privilege to create a memif socket listener with non-root owner uid and gid, which can be connected from client applications running without root privilege. Signed-off-by: Junxiao Shi --- doc/guides/nics/memif.rst | 2 ++ drivers/net/memi

RE: [PATCH] net/i40e: fix X722 NIC receives jumbo frame packets

2022-12-05 Thread Zhang, Qi Z
Hi David: > -Original Message- > From: David Marchand > Sent: Monday, December 5, 2022 7:15 PM > To: Kevin Traynor ; Zhang, Qi Z > > Cc: sta...@dpdk.org; Yuan, DukaiX ; Wang, Jie1X > ; dev@dpdk.org; Yang, SteveX > ; Yang, Qiming ; Xing, > Beilei ; Zhang, Yuying > Subject: Re: [PATCH] ne

RE: [PATCH] maintainers: split baseband from crypto tree

2022-12-05 Thread Chautru, Nicolas
> > Baseband patches are now split from dpdk-next-crypto, All baseband > patches need to be submitted to dpdk-next-baseband which will be > maintained by Maxime. > > Cc: maxime.coque...@redhat.com > > Signed-off-by: Akhil Goyal > --- > MAINTAINERS | 12 > 1 file changed, 8 inserti

RE: [PATCH v1 2/2] test/bbdev: fix build issue with optional build flag

2022-12-05 Thread Chautru, Nicolas
Hi Maxime, > -Original Message- > From: Maxime Coquelin > Sent: Thursday, November 24, 2022 12:09 PM > To: Chautru, Nicolas ; dev@dpdk.org; > tho...@monjalon.net; gak...@marvell.com > Cc: Vargas, Hernan ; vipin.vargh...@amd.com; > Mcnamara, John ; ferruh.yi...@amd.com; > clinton.fra...@a

Re: [PATCH 1/3] eal: add rte control thread create API

2022-12-05 Thread Tyler Retzlaff
On Mon, Dec 05, 2022 at 01:11:16PM -0800, Stephen Hemminger wrote: > On Mon, 5 Dec 2022 12:24:26 -0800 > Tyler Retzlaff wrote: > > > Signed-off-by: Tyler Retzlaff > > --- > > lib/eal/common/eal_common_thread.c | 93 > > ++ > > lib/eal/include/rte_thread.h

Re: [PATCH 3/3] eal: deprecate pthread control thread create API

2022-12-05 Thread Tyler Retzlaff
On Mon, Dec 05, 2022 at 01:18:05PM -0800, Stephen Hemminger wrote: > On Mon, 5 Dec 2022 12:24:28 -0800 > Tyler Retzlaff wrote: > > > + > > +* eal: The function ``rte_ctrl_thread_create`` will be removed and > > + replaced by the new ``rte_control_thread_create``api, continuing the > > + effort

[PATCH 0/2] enable lcores test on Windows

2022-12-05 Thread Tyler Retzlaff
Enable the lcores test on Windows instead of skipping it. Two bugs are fixed to allow this test to build, run & pass. * Mark memory configuration complete during rte_eal_init() * Use rte thread api to get a proper implementation of thread join. Tyler Retzlaff (2): eal: add missing call mark

[PATCH 2/2] test: enable lcores test on Windows

2022-12-05 Thread Tyler Retzlaff
Stop using pthread and convert the test to use EAL thread APIs. Because the EAL thread APIs provide more than just a stub for thread join on Windows the tests now pass and need not be skipped. Signed-off-by: Tyler Retzlaff --- app/test/test_lcores.c | 28 +--- 1 file chan

[PATCH 1/2] eal: add missing call marking memory config complete

2022-12-05 Thread Tyler Retzlaff
Memory configuration was not being marked as completed add the missing call to rte_eal_init() for Windows. Signed-off-by: Tyler Retzlaff --- lib/eal/windows/eal.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/lib/eal/windows/eal.c b/lib/eal/windows/eal.c index adb929a..56fadc7 100644 --

[PATCH] common/mlx5: improve AES-XTS tweek capability check

2022-12-05 Thread Suanming Mou
Bluefield-3 and above devices use aes_xts_multi_block_be_tweak bit to indicate AES-XTS capability. The devices below use aes_xts_single_block_le_tweak bit. This commit adds the AES-XTS attribute set while one of the bits is set to make the attribute compatible with all the devices. Signed-off-by:

Re: [PATCH 1/2] net/bonding: support private dump ops

2022-12-05 Thread humin (Q)
Hi, 在 2022/12/5 16:10, Chengwen Feng 写道: This patch implements eth_dev_priv_dump ops which could enhance the debug capability. The dump output is similar to testpmd command "show bonding config [port]". Signed-off-by: Chengwen Feng --- drivers/net/bonding/rte_eth_bond_pmd.c | 103 ++

RE: [EXT] [PATCH v1 04/13] graph: add get/set graph worker model APIs

2022-12-05 Thread Kiran Kumar Kokkilagadda
> -Original Message- > From: Zhirun Yan > Sent: 17 November 2022 10:39 AM > To: dev@dpdk.org; Jerin Jacob Kollanukkaran ; Kiran > Kumar Kokkilagadda ; Nithin Kumar Dabilpuram > > Cc: cunming.li...@intel.com; haiyue.w...@intel.com; Zhirun Yan > > Subject: [EXT] [PATCH v1 04/13] graph:

RE: [RFC 2/2] ethdev: add API to set process to primary or secondary

2022-12-05 Thread Rongwei Liu
Hi BR Rongwei > -Original Message- > From: Stephen Hemminger > Sent: Tuesday, December 6, 2022 00:08 > To: Rongwei Liu > Cc: Matan Azrad ; Slava Ovsiienko > ; Ori Kam ; NBU-Contact- > Thomas Monjalon (EXTERNAL) ; Ferruh Yigit > ; Andrew Rybchenko > ; dev@dpdk.org; Raslan Darawsheh > >

[PATCH] vhost: exclude VM hugepages from coredumps

2022-12-05 Thread Mike Pattrick
Currently if an application wants to include shared hugepages in coredumps in conjunction with the vhost library, the coredump will be larger than expected and include unneeded virtual machine memory. This patch will mark all vhost huge pages as DONTDUMP, except for some select pages used by DPDK.

Re: [RFC 2/2] ethdev: add API to set process to primary or secondary

2022-12-05 Thread Stephen Hemminger
On Tue, 6 Dec 2022 03:47:42 + Rongwei Liu wrote: > Hi > > BR > Rongwei > > > -Original Message- > > From: Stephen Hemminger > > Sent: Tuesday, December 6, 2022 00:08 > > To: Rongwei Liu > > Cc: Matan Azrad ; Slava Ovsiienko > > ; Ori Kam ; NBU-Contact- > > Thomas Monjalon (EXTERNA

[PATCH V3 3/5] app/testpmd: check the validity of the port

2022-12-05 Thread Huisong Li
This patch checks the validity of port id for all events in 'eth_event_callback()'. Signed-off-by: Huisong Li Acked-by: Aman Singh --- app/test-pmd/testpmd.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c index 134d79a555

[PATCH V3 5/5] app/testpmd: stop forwarding in new or destroy event

2022-12-05 Thread Huisong Li
When testpmd receives the new or destroy event, the port related information will be updated. Testpmd must stop packet forwarding before updating the information to avoid some serious problems. Signed-off-by: Huisong Li --- app/test-pmd/testpmd.c | 4 1 file changed, 4 insertions(+) diff -

[PATCH V3 0/5] app/testpmd: support mulitple process attach and detach port

2022-12-05 Thread Huisong Li
This patchset fix some bugs and support attaching and detaching port in primary and secondary. --- -v3: 1) merge patch 1/6 and patch 2/6 into patch 1/5, and add some similar modifications for other bus type. 2) add a RTE_ETH_DEV_ALLOCATED state in rte_eth_dev_state to resolve th

[PATCH V3 1/5] drivers/bus: restore driver assignment at front of probing

2022-12-05 Thread Huisong Li
The driver assignment was moved back at the end of the device probing because there is no something to use rte_driver during the phase of probing. See commit 391797f04208 ("drivers/bus: move driver assignment to end of probing") However, it is necessary for probing callback to reference rte_driver

[PATCH V3 2/5] ethdev: fix skip valid port in probing callback

2022-12-05 Thread Huisong Li
The event callback in application may use the macro RTE_ETH_FOREACH_DEV to iterate over all enabled ports to do something(like, verifying the port id validity) when receive a probing event. If the ethdev state of a port is RTE_ETH_DEV_UNUSED, this port will be skiped. Currently, this state is set

[PATCH V3 4/5] app/testpmd: add attach and detach port for multiple process

2022-12-05 Thread Huisong Li
This patch supports attach and detach port in primary and secondary process. Signed-off-by: Huisong Li Signed-off-by: Dongdong Liu --- app/test-pmd/testpmd.c| 38 --- app/test-pmd/testpmd.h| 1 - drivers/net/bonding/bonding_testpmd.c | 1