[PATCH v3 3/9] telemetry: rename unsigned 64-bit enum value to uint

For telemetry data, rather than having unsigned 64-bit values and signed 32-bit values, we want to just have unsigned and signed values, each stored with the max bit-width i.e. 64-bits. To that end, we rename the U64 enum entry to "UINT" to have a more generic name For backward API-level compatibi

[PATCH v3 4/9] telemetry: add uint type as alias for u64

To match the "_int" suffix for telemetry data functions taking signed values, we can add new functions with the "_uint" suffix for unsigned ones. While later patches will deprecate the old public functions, for now we can just add the new functions as aliases or duplicates of the older ones with th

[PATCH v3 5/9] global: rename telemetry functions to newer versions

Within the DPDK code-base, replace all occurences of "rte_tel_data_add_array_u64" with "rte_tel_data_add_array_uint", and similarly replace all occurences of "rte_tel_data_add_dict_u64" with "rte_tel_data_add_dict_uint". This allows us to later mark the older functions as deprecated without hitting

[PATCH v3 6/9] telemetry: mark old names of renamed fns as deprecated

Add a deprecation notice for the renaming of the telemetry data u64/uint functions, and point users to the newer versions of them when building. To do this, we also need to mark the renamed versions as stable, rather than experimental. Signed-off-by: Bruce Richardson --- Note: This patch adds th

[PATCH v3 7/9] telemetry: update json functions to use int/uint in names

Since we are standardizing on using uint in place of u64, and expanding the int values to 64-bit, we can update the internal json functions to use the new names and expanded signed type. Suggested-by: Morten Brørup Signed-off-by: Bruce Richardson Acked-by: Morten Brørup Acked-by: Tyler Retzlaff

[PATCH v3 8/9] telemetry: make internal int representation 64-bits

The internal storage for int values can be expanded from 32-bit to 64-bit without affecting the external ABI. Suggested-by: Morten Brørup Signed-off-by: Bruce Richardson Acked-by: Morten Brørup Acked-by: Tyler Retzlaff --- lib/telemetry/telemetry_data.h | 2 +- 1 file changed, 1 insertion(+),

[PATCH v3 9/9] telemetry: change public API to use 64-bit signed values

While the unsigned values added to telemetry dicts/arrays were up to 64-bits in size, the sized values were only up to 32-bits. We can standardize the API by having both int and uint functions take 64-bit values. For ABI compatibility, we use function versioning to ensure older binaries can still u

[PATCH V4 00/11] pipeline: add IPsec support

This patch set introduces a companion block for the SWX pipeline for IPsec support. The IPsec block is external to the pipeline, hence it needs to be explicitly instantiated by the user and connected to a pipeline instance through the pipeline I/O ports. Main features: * IPsec inbound (encrypted

[PATCH V4 01/11] pipeline: add IPsec support

This block is providing IPsec support to the SWX pipeline. The IPsec block is external to the pipeline, so it needs to be explicitly instantiated and connected to a pipeline through the I/O ports. Signed-off-by: Cristian Dumitrescu Signed-off-by: Kamalakannan R --- lib/pipeline/meson.build

[PATCH V4 02/11] examples/pipeline: rework memory pool support

Rework the memory pool CLI command to accommodate the MBUF private meta-data area size parameter. Signed-off-by: Cristian Dumitrescu Signed-off-by: Kamalakannan R --- examples/pipeline/cli.c | 72 ++--- examples/pipeline/examples/fib.cli| 2 +- exa

[PATCH V4 03/11] examples/pipeline: streamline ring support

Remove redundant ring related code. Signed-off-by: Cristian Dumitrescu Signed-off-by: Kamalakannan R --- examples/pipeline/cli.c | 24 ++-- examples/pipeline/obj.c | 63 - examples/pipeline/obj.h | 21 -- 3 files changed, 15 insert

[PATCH V4 04/11] examples/pipeline: streamline the Ethernet device support

Streamline the Ethernet device support code and remove redundant code. Signed-off-by: Cristian Dumitrescu Signed-off-by: Kamalakannan R --- examples/pipeline/cli.c | 175 ++-- examples/pipeline/main.c | 12 +-- examples/pipeline/obj.c | 186 +--

[PATCH V4 05/11] examples/pipeline: support crypto devices

Add support for crypto devices in the application. Signed-off-by: Cristian Dumitrescu Signed-off-by: Kamalakannan R --- examples/pipeline/obj.c | 60 + examples/pipeline/obj.h | 11 2 files changed, 71 insertions(+) diff --git a/examples/pipelin

[PATCH V4 06/11] examples/pipeline: add CLI command for crypto device

Add CLI command for the configuration of crypto devices. Signed-off-by: Cristian Dumitrescu Signed-off-by: Kamalakannan R --- examples/pipeline/cli.c | 63 + 1 file changed, 63 insertions(+) diff --git a/examples/pipeline/cli.c b/examples/pipeline/cli.c

[PATCH V4 07/11] examples/pipeline: add IPsec CLI commands

Add CLI commands for IPsec block configuration. Signed-off-by: Cristian Dumitrescu Signed-off-by: Kamalakannan R --- examples/pipeline/cli.c | 298 1 file changed, 298 insertions(+) diff --git a/examples/pipeline/cli.c b/examples/pipeline/cli.c index 6b

[PATCH V4 08/11] examples/pipeline: rework the thread configuration updates

Previously, the configuration updates for the data plane threads were performed through message queues. Now, this mechanism is replaced by the control thread updating the mirror copy of the data plane thread configuration followed by pointer swapping. Signed-off-by: Cristian Dumitrescu Signed-off

[PATCH V4 09/11] examples/pipeline: support blocks other than pipelines

Previously, the data plane threads only supported the execution of pipelines assigned to them through configuration updates. Now, the data plane threads also support running blocks such as IPsec. Signed-off-by: Cristian Dumitrescu Signed-off-by: Kamalakannan R --- examples/pipeline/thread.c | 1

[PATCH V4 10/11] examples/pipeline: add block enable/disable CLI commands

Add CLI commands to enable/disable block execution on data plane threads. Signed-off-by: Cristian Dumitrescu Signed-off-by: Kamalakannan R --- examples/pipeline/cli.c | 154 1 file changed, 154 insertions(+) diff --git a/examples/pipeline/cli.c b/exampl

[PATCH V4 11/11] examples/pipeline: add IPsec example

Add example files to illustrate the pipeline IPsec support. Signed-off-by: Cristian Dumitrescu Signed-off-by: Kamalakannan R --- examples/pipeline/examples/ipsec.cli| 57 +++ examples/pipeline/examples/ipsec.io | 23 +++ examples/pipeline/examples/ipsec.spec | 138 ++

[PATCH] crypto/qat: fix build

Instead of undefining AES_BLOCK_SIZE, define NO_COMPAT_IMB_API_053, which prevents legacy macros like AES_BLOCK_SIZE from being defined from IPSec MB library. Fixes: 3227bc7138f5 ("crypto/qat: use intel-ipsec-mb for partial hash and AES") Cc: sta...@dpdk.org Cc: kai...@intel.com Signed-off-by: Pa

[PATCH v3 0/7] baseband/acc: changes for 23.03

v3: Remove unused mempool header. v2: Reordered commits and added one more fix. v1: Upstreaming ACC100 changes for 23.03. Hernan Vargas (7): baseband/acc: acc100 free harq layout pointer baseband/acc: acc100 fix iteration counter in TB baseband/acc: acc100 fix multiplexing multiple ops bas

[PATCH v3 1/7] baseband/acc: acc100 free harq layout pointer

Explicitly call rte_free for harq_layout pointer in dev_close function to prevent memory leak. Fixes: ba2262fe16c ("baseband/acc100: fix close cleanup") Cc: sta...@dpdk.org Signed-off-by: Hernan Vargas --- drivers/baseband/acc/rte_acc100_pmd.c | 1 + 1 file changed, 1 insertion(+) diff --git a

[PATCH v3 2/7] baseband/acc: acc100 fix iteration counter in TB

Use ldpc or turbo iteration counter based on the operation type. Fixes: 5ad5060f8f7 ("baseband/acc100: add LDPC processing functions") Cc: sta...@dpdk.org Signed-off-by: Hernan Vargas --- drivers/baseband/acc/rte_acc100_pmd.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff -

[PATCH v3 3/7] baseband/acc: acc100 fix multiplexing multiple ops

Function to check if multiplexing is possible for multiple operations in one descriptor returns number of enqueued ops. Fixes: 32e8b7ea35d ("baseband/acc100: refactor to segregate common code") Signed-off-by: Hernan Vargas --- drivers/baseband/acc/rte_acc100_pmd.c | 6 +++--- 1 file changed, 3

[PATCH v3 4/7] baseband/acc: acc100 fix queue mapping to 64 bits

Fix potential overflow for Q mapping extension to 64 bits. Fixes: 32e8b7ea35d ("baseband/acc100: refactor to segregate common code") Signed-off-by: Hernan Vargas --- drivers/baseband/acc/rte_acc100_pmd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/baseband/acc/rt

[PATCH v3 5/7] baseband/acc: acc100 use define constant

Use define constant ACC_HARQ_ALIGN_64B instead of hardcoded number. No functional impact. Signed-off-by: Hernan Vargas --- drivers/baseband/acc/rte_acc100_pmd.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/baseband/acc/rte_acc100_pmd.c b/drivers/baseband/acc/r

[PATCH v3 6/7] baseband/acc: acc100 use desc helper functions

Use the designated descriptor helper functions for descriptor address calculations. No functional impact. Signed-off-by: Hernan Vargas --- drivers/baseband/acc/rte_acc100_pmd.c | 35 +-- 1 file changed, 12 insertions(+), 23 deletions(-) diff --git a/drivers/baseband/acc/

[PATCH v3 7/7] baseband/acc: acc100 ignore missing mempools

Mempool not strictly required to be present in op for processing. Previous criteria too strict. No functional impact. Signed-off-by: Hernan Vargas --- drivers/baseband/acc/rte_acc100_pmd.c | 9 - 1 file changed, 9 deletions(-) diff --git a/drivers/baseband/acc/rte_acc100_pmd.c b/driver

[PATCH v2 0/4] fix Windows build with MinGW and mlx5

The first patch is a fix for EAL Windows. The 3 other patches are cleaning up mlx5 for Windows. The result is to make possible to compile mlx5 on Linux for Windows. v2: improve mlx5 doc and remove weak attribute from mlx5 Thomas Monjalon (4): eal/windows: fix pedantic build common/mlx5: get W

[PATCH v2 1/4] eal/windows: fix pedantic build

MinGW GCC 12 shows an illegal pointer conversion when included in a pedantic module: lib/eal/windows/include/pthread.h:137:41: error: ISO C forbids conversion of object pointer to function pointer type [-Werror=pedantic] 137 | hThread = CreateThread(NULL, 0, (LPTHREAD_START_ROUTIN

[PATCH v2 0/4] fix Windows build with MinGW and mlx5

The first patch is a fix for EAL Windows. The 3 other patches are cleaning up mlx5 for Windows. The result is to make possible to compile mlx5 on Linux for Windows. v2: improve mlx5 doc and remove weak attribute from mlx5 Thomas Monjalon (4): eal/windows: fix pedantic build common/mlx5: get W

[PATCH v2 2/4] common/mlx5: get Windows dependency from standard variables

It was requested to provide path to DevX library through DEVX_INC_PATH and DEVX_LIB_PATH. It was non-standard and triggers some issues with recent Meson. Using CFLAGS/LDFLAGS is standard and simpler. It is also possible to use the Meson options -Dc_args and -Dc_link_args. There are 2 options to pr

[PATCH v2 3/4] net/mlx5: remove weak stub functions

The vector Rx functions are conditionally compiled. Some stub functions were also always compiled with weak attribute. If there is no vector support, the weak functions were linked. These weak functions are moved in a specific file which is compiled only if there is no vector support. This way it

[PATCH v2 4/4] net/mlx5: fix Windows build with MinGW GCC 12

With recent changes in Meson and MinGW toolchain, the driver mlx5 was not able to compile on Linux for Windows. There were errors due to system detection, non-typed constants, constant going over int range forbidden in pedantic mode, and minimum-comparison of different types. Cc: sta...@dpdk.org

Re: [PATCH] crypto/qat: fix build

12/01/2023 20:30, Pablo de Lara: > Instead of undefining AES_BLOCK_SIZE, define NO_COMPAT_IMB_API_053, > which prevents legacy macros like AES_BLOCK_SIZE from being defined > from IPSec MB library. Given we are discarding my first workaround, your first sentence doesn't really make sense. Please g

[PATCH] eal: abstract compiler atomics

Introduce an abstraction for compiler specific atomics and a meson option to allow standard C11 atomics use. Note, this series does not attempt to convert to the use of the abstraction it only introduces it as per the plan discussed here. http://mails.dpdk.org/archives/dev/2023-January/258693.html

[PATCH] eal: introduce atomics abstraction

Introduce atomics abstraction that permits optional use of standard C11 atomics when meson is provided the new enable_stdatomics=true option. Signed-off-by: Tyler Retzlaff --- config/meson.build | 11 +++ lib/eal/arm/include/rte_atomic_32.h| 6 +- lib/eal/arm/include/r

Re: [PATCH v2 1/4] eal: add thread set name API operating on rte thread

On Wed, Jan 11, 2023 at 05:09:25PM +0100, David Marchand wrote: > On Wed, Dec 14, 2022 at 5:47 PM Tyler Retzlaff > wrote: > > diff --git a/lib/eal/common/eal_common_trace.c > > b/lib/eal/common/eal_common_trace.c > > index 5caaac8..89522dc 100644 > > --- a/lib/eal/common/eal_common_trace.c > > ++

Re: [EXT] Re: [PATCH] ring: compilation fix with GCC-12

23/08/2022 11:38, Amit Prakash Shukla: > From: Konstantin Ananyev > > 06/08/2022 19:35, Honnappa Nagarahalli пишет: > > >> Replacing memcpy with rte_memcpy fixes the GCC-12 compilation issue. > > > > > > Any reason why this replacement fixes the problem? > > > Do you have any performance numbers

[PATCH v3 0/4] add rte_thread_set_name API for rte_thread_t

Replace the rte_thread_setname API which operates on pthread_t with rte_thread_set_name that operates on rte_thread_t. v3: * fix coding style error * move remove of rte_thread_getname to patch #2 v2: * initial series provided get/set for lcore thread id, those additions have been remove

[PATCH v3 3/4] drivers: mlx5 use rte thread set name

Use the new internal rte_thread_set_name API instead of the now deprecated rte_thread_setname API. Signed-off-by: Tyler Retzlaff --- drivers/net/mlx5/mlx5_hws_cnt.c | 3 ++- drivers/vdpa/mlx5/mlx5_vdpa_event.c | 3 +-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/ne

[PATCH v3 4/4] eal: deprecate rte thread setname API

Notify deprecation of rte_thread_setname API, it is being removed as it exposes platform-specific thread details. The functionality it provided is now implicitly provided via the rte_lcore_set_name API if the underlying platform supports it. Signed-off-by: Tyler Retzlaff --- doc/guides/rel_notes

[PATCH v3 2/4] eal: remove thread getname API

Remove the rte_thread_getname API. The API is __rte_experimental and requires no deprecation notice. Signed-off-by: Tyler Retzlaff --- lib/eal/common/eal_common_trace.c | 2 -- lib/eal/freebsd/eal_thread.c | 9 - lib/eal/include/rte_lcore.h | 17 - lib/eal/l

[PATCH v3 1/4] eal: add thread set name API operating on rte thread

Add a rte_thread_set_name that sets the name of an rte_thread_t thread. This is a replacement for the rte_thread_setname(pthread_t, ...) which exposes platform-specific details. Signed-off-by: Tyler Retzlaff --- lib/eal/common/eal_common_thread.c | 9 +++- lib/eal/freebsd/eal.c

[PATCH v5 0/1] Add support AVX512 split queue datapath

This patchset enables AVX512 data path for split queue model. It is based on the below two pathsets 1. https://patches.dpdk.org/project/dpdk/cover/20230106090501.9106-1-beilei.x...@intel.com/ 2. https://patches.dpdk.org/project/dpdk/cover/20230106091627.13530-1-beilei.x...@intel.com/ v3: fix l

[PATCH v5 1/1] common/idpf: add AVX512 data path for split queue model

Add support of AVX512 data path for split queue model. Signed-off-by: Wenjun Wu Reviewed-by: Wenjing Qiao Acked-by: Wenzhuo Lu --- drivers/common/idpf/idpf_common_rxtx.c| 22 +- drivers/common/idpf/idpf_common_rxtx.h| 19 +- drivers/common/idpf/idpf_common_rxtx_avx512.c | 797

RE: [PATCH] vhost: fix net header settings in vhost datapath

> -Original Message- > From: Wenwu Ma > Sent: Wednesday, January 4, 2023 10:40 AM > To: dev@dpdk.org > Cc: Ma, WenwuX ; sta...@dpdk.org > Subject: [PATCH] vhost: fix net header settings in vhost datapath > > In vhost sync batch enqueue, the "num_buffers" of virtio net header is not > be s

RE: [PATCH] vhost: fix net header settings in vhost datapath

Hi Wenwu, > -Original Message- > From: Wenwu Ma > Sent: Wednesday, January 4, 2023 10:40 AM > To: dev@dpdk.org > Cc: Ma, WenwuX ; sta...@dpdk.org > Subject: [PATCH] vhost: fix net header settings in vhost datapath > > In vhost sync batch enqueue, the "num_buffers" of virtio net header is

[PATCH v2 0/3] Async vhost packed ring optimization

To improve the performance of async vhost packed ring. We remove the unnecessary data copy in async vhost packed ring. And add the batch data path in both enqueue data path and dequeue data path. v2: fixed net header settings. Cheng Jiang (3): vhost: remove redundant copy for packed shadow used

[PATCH v2 1/3] vhost: remove redundant copy for packed shadow used ring

In the packed ring enqueue data path of the current asynchronous Vhost design, the shadow used ring is first copied to the sync shadow used ring, and then it will be moved to the async shadow used ring for some historical reasons. This is completely unnecessary. This patch removes redundant copy fo

[PATCH v2 3/3] vhost: add batch dequeue in async vhost packed ring

Add batch dequeue function in asynchronous vhost packed ring to improve the performance. Chained mbufs are not supported, it will be handled in single dequeue function. Signed-off-by: Cheng Jiang Signed-off-by: Yuan Wang --- lib/vhost/virtio_net.c | 170 -

[PATCH v2 2/3] vhost: add batch enqueue in async vhost packed ring

Add batch enqueue function in asynchronous vhost packed ring to improve the performance. Chained mbufs are not supported, it will be handled in single enqueue function. Signed-off-by: Cheng Jiang --- lib/vhost/virtio_net.c | 163 + 1 file changed, 163 inse

Re: [PATCH v2 1/4] eal: add thread set name API operating on rte thread

On Wed, Jan 11, 2023 at 9:39 PM David Marchand wrote: > > On Wed, Dec 14, 2022 at 5:47 PM Tyler Retzlaff > wrote: > > diff --git a/lib/eal/common/eal_common_trace.c > > b/lib/eal/common/eal_common_trace.c > > index 5caaac8..89522dc 100644 > > --- a/lib/eal/common/eal_common_trace.c > > +++ b/lib

Minutes of Technical Board Meeting, 2022-06-15

Members Attending = 11/11 - Aaron - Bruce - David - Hemant - Kevin - Konstantin - Maxime - Nathan - Olivier - Stephen (chair) - Thomas NOTE: The technical board meetings are on every second Wednesday at https://meet.jit.si/DPDK at 3 pm UTC. Meetings are public, and DPDK community

Re: [PATCH] common/cnxk: reduce channel count per LMAC

On Wed, Jan 4, 2023 at 11:37 AM wrote: > > From: Sunil Kumar Kori > > Due to limitation, imposed by latest kernel, maximum number of > channel supported per LMAC is reduced to 8. Because of this change > application gets failed to initialize for more channels. > > Also this limitation impacts PFC

Re: [PATCH v3 1/1] common/cnxk: add mbox locking

On Fri, Jan 6, 2023 at 11:15 PM Rakesh Kudurumalla wrote: > > this patch adds mbox locking using spinlock > to have different subsystems sharing same mbox Clean up the git commit and tell why? > > Signed-off-by: Rakesh Kudurumalla Please fix the below and resend the next version [for-next-net

RE: [PATCH] net/iavf:fix slow memory allocation

> -Original Message- > From: David Marchand > Sent: 2023年1月10日 18:17 > To: You, KaisenX > Cc: Ferruh Yigit ; dev@dpdk.org; Burakov, Anatoly > ; sta...@dpdk.org; Yang, Qiming > ; Zhou, YidingX ; Wu, > Jingjing ; Xing, Beilei ; Zhang, > Qi Z ; Luca Boccassi ; Mcnamara, > John ; Kevin Tray

RE: [EXT] Re: [PATCH] common/cnxk: reduce channel count per LMAC

Ack. Regards Sunil Kumar Kori > -Original Message- > From: Jerin Jacob > Sent: Friday, January 13, 2023 10:54 AM > To: Sunil Kumar Kori > Cc: Nithin Kumar Dabilpuram ; Kiran Kumar > Kokkilagadda ; Satha Koteswara Rao Kottidi > ; dev@dpdk.org; sta...@dpdk.org > Subject: [EXT] Re: [PATCH]

RE: [PATCH v5 3/6] ethdev: add trace points for remaining functions

Hi Sunil, My comments are inline. >-Original Message- >From: Sunil Kumar Kori >Sent: Thursday, January 12, 2023 10:09 PM >To: Ankur Dwivedi ; dev@dpdk.org >Cc: tho...@monjalon.net; david.march...@redhat.com; m...@ashroe.eu; >or...@nvidia.com; ferruh.yi...@amd.com; ch...@att.com; >humi...

RE: [EXT] Re: [PATCH v5 0/6] add trace points in ethdev library

Hi Ferruh, My comments are inline. >-Original Message- >From: Ferruh Yigit >Sent: Thursday, January 12, 2023 10:33 PM >To: Ankur Dwivedi ; dev@dpdk.org >Cc: tho...@monjalon.net; david.march...@redhat.com; m...@ashroe.eu; >or...@nvidia.com; ch...@att.com; humi...@huawei.com; >linvi...@tux

Re: [PATCH] net/hns3: fix inaccurate RTC time to read

Hi Huisong On 2023/1/9 16:23, Huisong Li wrote: The sequence of reading current RTC time register doesn't meet the hardware requirements, which causes this time obtained is the one before modifying RTC time. Fixes: 38b539d96eb6 ("net/hns3: support IEEE 1588 PTP") Cc: sta...@dpdk.org Signed-off

RE: [EXT] Re: [PATCH v5 0/4] add support for self monitoring

>-Original Message- >From: Tyler Retzlaff >Sent: Wednesday, January 11, 2023 10:06 PM >To: Tomasz Duszynski >Cc: bruce.richard...@intel.com; m...@smartsharesystems.com; dev@dpdk.org; >tho...@monjalon.net; Jerin >Jacob Kollanukkaran ; ruifeng.w...@arm.com; >mattias.ronnb...@ericsson.c

<    1   2