Re: [EXT] Re: [PATCH v5 2/2] app/testpmd: add command to process Rx metadata negotiation

2023-02-02 Thread Andrew Rybchenko
On 2/2/23 15:03, Thomas Monjalon wrote: 02/02/2023 12:55, Ivan Malov: On Thu, 2 Feb 2023, Thomas Monjalon wrote: OK we are progressing on this topic :) Indeed we are. 02/02/2023 11:48, Ivan Malov: I apologise, there was a typo in the previous mail: "PMD does not need this API". Should re

Re: [PATCH v7] ethdev: add special flags when creating async transfer table

2023-02-02 Thread Andrew Rybchenko
On 2/2/23 14:29, Thomas Monjalon wrote: 02/02/2023 10:21, Andrew Rybchenko: On 2/1/23 16:48, Thomas Monjalon wrote: 01/02/2023 12:38, Andrew Rybchenko: On 2/1/23 14:18, Thomas Monjalon wrote: 01/02/2023 12:10, Andrew Rybchenko: On 2/1/23 13:58, Thomas Monjalon wrote: 01/02/2023 11:17, Andre

[PATCH v4] net/i40e: rework maximum frame size configuration

2023-02-02 Thread Simei Su
This patch reverts mentionned changes below to remove unnecessary link status check and only moves max frame size configuration to dev_start. Also, it sets the parameter "wait to complete" true to wait for complete right after setting link up. Fixes: a4ba77367923 ("net/i40e: enable maximum frame s

[PATCH V8] ethdev: fix one address occupies two entries in MAC addrs

2023-02-02 Thread Huisong Li
The dev->data->mac_addrs[0] will be changed to a new MAC address when applications modify the default MAC address by .mac_addr_set(). However, if the new default one has been added as a non-default MAC address by .mac_addr_add(), the .mac_addr_set() doesn't remove it from the mac_addrs list. As a r

[PATCH v5] net/i40e: rework maximum frame size configuration

2023-02-02 Thread Simei Su
This patch reverts mentioned changes below to remove unnecessary link status check and only moves max frame size configuration to dev_start. Also, it sets the parameter "wait to complete" true to wait for complete right after setting link up. Fixes: a4ba77367923 ("net/i40e: enable maximum frame si

RE: [PATCH v3 12/12] app/mldev: add documentation for mldev test cases

2023-02-02 Thread Anup Prabhu
> -Original Message- > From: Srikanth Yalavarthi > Sent: Friday, December 9, 2022 12:59 AM > To: Thomas Monjalon ; Srikanth Yalavarthi > > Cc: dev@dpdk.org; Shivah Shankar Shankar Narayan Rao > ; Jerin Jacob Kollanukkaran > ; Anup Prabhu > Subject: [PATCH v3 12/12] app/mldev: add docum

[PATCH v6 0/8] start cleanup of rte_flow_item_*

2023-02-02 Thread Ferruh Yigit
There was a plan to have structures from lib/net/ at the beginning of corresponding flow item structures. Unfortunately this plan has not been followed up so far. This series is a step to make the most used items, compliant with the inheritance design explained above. The old API is kept in anonymo

[PATCH v6 2/8] net: add smaller fields for VXLAN

2023-02-02 Thread Ferruh Yigit
From: Thomas Monjalon The VXLAN and VXLAN-GPE headers were including reserved fields with other fields in big uint32_t struct members. Some more precise definitions are added as union of the old ones. The new struct members are smaller in size and in names. Signed-off-by: Thomas Monjalon Acke

[PATCH v6 3/8] ethdev: use VXLAN protocol struct for flow matching

2023-02-02 Thread Ferruh Yigit
From: Thomas Monjalon As announced in the deprecation notice, flow item structures should re-use the protocol header definitions from the directory lib/net/. In the case of VXLAN-GPE, the protocol struct is added in an unnamed union, keeping old field names. The VXLAN headers (including VXLAN-G

[PATCH v6 1/8] ethdev: use Ethernet protocol struct for flow matching

2023-02-02 Thread Ferruh Yigit
From: Thomas Monjalon As announced in the deprecation notice, flow item structures should re-use the protocol header definitions from the directory lib/net/. The Ethernet headers (including VLAN) structures are used instead of the redundant fields in the flow items. The remaining protocols to cl

[PATCH v6 4/8] ethdev: use GRE protocol struct for flow matching

2023-02-02 Thread Ferruh Yigit
From: Thomas Monjalon As announced in the deprecation notice, flow item structures should re-use the protocol header definitions from the directory lib/net/. The protocol struct is added in an unnamed union, keeping old field names. The GRE header struct members are used in apps and drivers ins

[PATCH v6 5/8] ethdev: use GTP protocol struct for flow matching

2023-02-02 Thread Ferruh Yigit
From: Thomas Monjalon As announced in the deprecation notice, flow item structures should re-use the protocol header definitions from the directory lib/net/. The protocol struct is added in an unnamed union, keeping old field names. The GTP header struct members are used in apps and drivers ins

[PATCH v6 6/8] ethdev: use ARP protocol struct for flow matching

2023-02-02 Thread Ferruh Yigit
From: Thomas Monjalon As announced in the deprecation notice, flow item structures should re-use the protocol header definitions from the directory lib/net/. The protocol struct is added in an unnamed union, keeping old field names. The ARP header struct members are used in testpmd instead of t

[PATCH v6 7/8] doc: fix description of L2TPV2 flow item

2023-02-02 Thread Ferruh Yigit
From: Thomas Monjalon The flow item structure includes the protocol definition from the directory lib/net/, so it is reflected in the guide. Section title underlining is also fixed around. Fixes: 3a929df1f286 ("ethdev: support L2TPv2 and PPP procotol") Cc: sta...@dpdk.org Signed-off-by: Thomas

[PATCH v6 8/8] net: mark all big endian types

2023-02-02 Thread Ferruh Yigit
From: Thomas Monjalon Some protocols (ARP, MPLS and HIGIG2) were using uint16_t and uint32_t types for their 16 and 32-bit fields. It was correct but not conveying the big endian nature of these fields. As for other protocols defined in this directory, all types are explicitly marked as big endi

[PATCH v9 0/4] add support for self monitoring

2023-02-02 Thread Tomasz Duszynski
This series adds self monitoring support i.e allows to configure and read performance measurement unit (PMU) counters in runtime without using perf utility. This has certain adventages when application runs on isolated cores with nohz_full kernel parameter. Events can be read directly using rte_pm

[PATCH v9 1/4] lib: add generic support for reading PMU events

2023-02-02 Thread Tomasz Duszynski
Add support for programming PMU counters and reading their values in runtime bypassing kernel completely. This is especially useful in cases where CPU cores are isolated (nohz_full) i.e run dedicated tasks. In such cases one cannot use standard perf utility without sacrificing latency and performa

[PATCH v9 2/4] pmu: support reading ARM PMU events in runtime

2023-02-02 Thread Tomasz Duszynski
Add support for reading ARM PMU events in runtime. Signed-off-by: Tomasz Duszynski Acked-by: Morten Brørup --- app/test/test_pmu.c | 4 ++ lib/pmu/meson.build | 7 +++ lib/pmu/pmu_arm64.c | 94 + lib/pmu/rte_pmu.h | 4 ++

[PATCH v9 3/4] pmu: support reading Intel x86_64 PMU events in runtime

2023-02-02 Thread Tomasz Duszynski
Add support for reading Intel x86_64 PMU events in runtime. Signed-off-by: Tomasz Duszynski Acked-by: Morten Brørup --- app/test/test_pmu.c | 2 ++ lib/pmu/meson.build | 1 + lib/pmu/rte_pmu.h| 2 ++ lib/pmu/rte_pmu_pmc_x86_64.h | 24 4

[PATCH v9 4/4] eal: add PMU support to tracing library

2023-02-02 Thread Tomasz Duszynski
In order to profile app one needs to store significant amount of samples somewhere for an analysis latern on. Since trace library supports storing data in a CTF format lets take adventage of that and add a dedicated PMU tracepoint. Signed-off-by: Tomasz Duszynski Acked-by: Morten Brørup --- app

Re: [EXT] Re: [PATCH v6 2/6] ethdev: add trace points for ethdev (part one)

2023-02-02 Thread Ferruh Yigit
On 2/2/2023 10:20 AM, Ankur Dwivedi wrote: >>> +RTE_TRACE_POINT_FP( >>> + rte_eth_trace_find_next, >>> + RTE_TRACE_POINT_ARGS(uint16_t port_id), >>> + rte_trace_point_emit_u16(port_id); >>> +) >>> + >> >> Why 'rte_eth_trace_find_next' added as fast

Re: [PATCH v5] net/i40e: rework maximum frame size configuration

2023-02-02 Thread David Marchand
On Thu, Feb 2, 2023 at 1:37 PM Simei Su wrote: > > This patch reverts mentioned changes below to remove unnecessary link > status check and only moves max frame size configuration to dev_start. > Also, it sets the parameter "wait to complete" true to wait for complete > right after setting link up

Re: [PATCH v3 2/2] ring: add ring info telemetry cmd

2023-02-02 Thread Konstantin Ananyev
31/01/2023 02:28, Jie Hai пишет: This patch supports dump of the info of ring by its name. An example using this command is shown below: --> /ring/info,MP_mb_pool_0 { "/ring/info": { "name": "MP_mb_pool_0", "socket": 0, "flags": 0, "producer_type": "MP", "consumer_typ

Re: [PATCH V8] ethdev: fix one address occupies two entries in MAC addrs

2023-02-02 Thread Thomas Monjalon
02/02/2023 13:36, Huisong Li: > The dev->data->mac_addrs[0] will be changed to a new MAC address when > applications modify the default MAC address by .mac_addr_set(). However, > if the new default one has been added as a non-default MAC address by > .mac_addr_add(), the .mac_addr_set() doesn't rem

Re: [PATCH v4] net/i40e: rework maximum frame size configuration

2023-02-02 Thread Kevin Traynor
On 02/02/2023 12:30, Simei Su wrote: This patch reverts mentionned changes below to remove unnecessary link status check and only moves max frame size configuration to dev_start. Also, it sets the parameter "wait to complete" true to wait for complete right after setting link up. I think it wo

Re: [PATCH v5] net/i40e: rework maximum frame size configuration

2023-02-02 Thread David Marchand
On Thu, Feb 2, 2023 at 1:37 PM Simei Su wrote: > @@ -2467,8 +2466,16 @@ i40e_dev_start(struct rte_eth_dev *dev) > "please call hierarchy_commit() " > "before starting the port"); > > - max_frame_size = dev->data->mtu + I40E_ETH_OVERHEAD

Re: Re: [PATCH v2] .mailmap:update

2023-02-02 Thread wushao...@chinatelecom.cn
Sorry, I misspelled the main brach as superseded. It has now been restored. Please check again。 .mailmap:update - Patchwork (dpdk.org) From: Thomas Monjalon Date: 2023-02-02 01:30 To: wushaohua CC: dev; david.marchand Subject: Re: [PATCH v2] .mailmap:update 02/01/2023 08:19, wushao...@chinate

RE: [EXT] Re: [PATCH v6 2/6] ethdev: add trace points for ethdev (part one)

2023-02-02 Thread Ankur Dwivedi
> >On 2/2/2023 10:20 AM, Ankur Dwivedi wrote: > +RTE_TRACE_POINT_FP( + rte_eth_trace_find_next, + RTE_TRACE_POINT_ARGS(uint16_t port_id), + rte_trace_point_emit_u16(port_id); +) + >>> >>> Why 'rte_eth_trace_find_next' adde

[PATCH v8 0/5] lcore telemetry improvements

2023-02-02 Thread Robin Jarry
This is a follow up on previous work by Kevin Laatz: http://patches.dpdk.org/project/dpdk/list/?series=24658&state=* This series is aimed at allowing DPDK applications to expose their CPU usage stats in the DPDK telemetry under /eal/lcore/info. This is a much more basic and naive approach which l

[PATCH v8 2/5] eal: report applications lcore usage

2023-02-02 Thread Robin Jarry
Allow applications to register a callback that will be invoked in rte_lcore_dump() and when requesting lcore info in the telemetry API. The callback is expected to return the number of TSC cycles that have passed since application start and the number of these cycles that were spent doing busy wor

[PATCH v8 1/5] eal: add lcore info in telemetry

2023-02-02 Thread Robin Jarry
Report the same information than rte_lcore_dump() in the telemetry API into /eal/lcore/list and /eal/lcore/info,ID. Example: --> /eal/lcore/info,3 { "/eal/lcore/info": { "lcore_id": 3, "socket": 0, "role": "RTE", "cpuset": [ 3 ] } } Signed-off-

[PATCH v8 3/5] app/testpmd: add dump command for lcores

2023-02-02 Thread Robin Jarry
Add a simple command that calls rte_lcore_dump(). Signed-off-by: Robin Jarry Acked-by: Morten Brørup Acked-by: Konstantin Ananyev Reviewed-by: Kevin Laatz --- Notes: v7 -> v8: no change app/test-pmd/cmdline.c | 3 +++ doc/guides/testpmd_app_ug/testpmd_funcs.rst | 7

[PATCH v8 5/5] eal: add lcore usage telemetry endpoint

2023-02-02 Thread Robin Jarry
Allow fetching CPU cycles usage for all lcores with a single request. This endpoint is intended for repeated and frequent invocations by external monitoring systems and therefore returns condensed data. It consists of a single dictionary with three keys: "lcore_ids", "total_cycles" and "busy_cycle

[PATCH v8 4/5] app/testpmd: report lcore usage

2023-02-02 Thread Robin Jarry
Reuse the --record-core-cycles option to account for busy cycles. One turn of packet_fwd_t is considered "busy" if there was at least one received or transmitted packet. Add a new busy_cycles field in struct fwd_stream. Update get_end_cycles to accept an additional argument for the number of proce

Re: [EXT] Re: [PATCH v6 2/6] ethdev: add trace points for ethdev (part one)

2023-02-02 Thread Ferruh Yigit
On 2/2/2023 1:40 PM, Ankur Dwivedi wrote: >> >> On 2/2/2023 10:20 AM, Ankur Dwivedi wrote: >> > +RTE_TRACE_POINT_FP( > + rte_eth_trace_find_next, > + RTE_TRACE_POINT_ARGS(uint16_t port_id), > + rte_trace_point_emit_u16(port_id); > +) > + >

[PATCH v10 1/2] ethdev: add query and update sync and async function calls

2023-02-02 Thread Gregory Etelson
Current API allows either query or update indirect flow action. If indirect action must be conditionally updated according to it's present state application must first issue action query then analyze returned data and if needed issue update request. When the update will be processed, action state c

[PATCH v10 2/2] ethdev: add quota flow action and item

2023-02-02 Thread Gregory Etelson
Quota action limits traffic according to pre-defined configuration. Quota reflects overall traffic usage regardless bandwidth. Quota flow action initialized with signed tokens number value. Quota flow action updates tokens number according to these rules: 1. if quota was configured to count packet

Re: [PATCH v5] net/i40e: rework maximum frame size configuration

2023-02-02 Thread David Marchand
On Thu, Feb 2, 2023 at 2:24 PM David Marchand wrote: > > On Thu, Feb 2, 2023 at 1:37 PM Simei Su wrote: > > @@ -2467,8 +2466,16 @@ i40e_dev_start(struct rte_eth_dev *dev) > > "please call hierarchy_commit() " > > "before starting the port");

RE: [PATCH v7 4/6] ethdev: add trace points for flow

2023-02-02 Thread Ori Kam
Hi Ankur, > -Original Message- > From: Ankur Dwivedi > Sent: Monday, 23 January 2023 11:02 > > Adds trace points for rte_flow specific functions in ethdev lib. > > Signed-off-by: Ankur Dwivedi > --- > lib/ethdev/ethdev_trace_points.c | 117 ++ > lib/ethdev/rte_ethdev_trace.h

RE: [EXT] Re: [PATCH v6 2/6] ethdev: add trace points for ethdev (part one)

2023-02-02 Thread Ankur Dwivedi
> >On 2/2/2023 1:40 PM, Ankur Dwivedi wrote: >>> >>> On 2/2/2023 10:20 AM, Ankur Dwivedi wrote: >>> >> +RTE_TRACE_POINT_FP( >> +rte_eth_trace_find_next, >> +RTE_TRACE_POINT_ARGS(uint16_t port_id), >> +rte_trace_point_emit_u16(port_id); >> +) >

RE: [PATCH v7 4/6] ethdev: add trace points for flow

2023-02-02 Thread Ori Kam
Sorry sent before all comments, Adding missing comments > -Original Message- > From: Ori Kam > Sent: Thursday, 2 February 2023 15:52 > > Hi Ankur, > > > -Original Message- > > From: Ankur Dwivedi > > Sent: Monday, 23 January 2023 11:02 > > > > Adds trace points for rte_flow spe

RE: [PATCH v8 5/5] eal: add lcore usage telemetry endpoint

2023-02-02 Thread Morten Brørup
> From: Robin Jarry [mailto:rja...@redhat.com] > Sent: Thursday, 2 February 2023 14.43 > > Allow fetching CPU cycles usage for all lcores with a single request. > This endpoint is intended for repeated and frequent invocations by > external monitoring systems and therefore returns condensed data.

RE: [PATCH] crypto/ipsec_mb: fix zuc256 maximum tag length

2023-02-02 Thread Dooley, Brian
Hi Ciara, > -Original Message- > From: Ciara Power > Sent: Tuesday 31 January 2023 17:20 > To: Ji, Kai ; De Lara Guarch, Pablo > > Cc: dev@dpdk.org; Power, Ciara > Subject: [PATCH] crypto/ipsec_mb: fix zuc256 maximum tag length > > The AESNI_MB PMD supports 8 and 16 byte tag lengths fo

RE: [EXT] Re: [PATCH v6 1/4] lib: add generic support for reading PMU events

2023-02-02 Thread Morten Brørup
> From: Tomasz Duszynski [mailto:tduszyn...@marvell.com] > Sent: Thursday, 26 January 2023 16.28 > > >From: Bruce Richardson > >Sent: Thursday, January 26, 2023 1:59 PM > > > >Other possible complication is - how does this work with threads that > are not pinned to a > >particular physical core?

Re: [PATCH v3 1/3] ethdev: enable direct rearm with separate API

2023-02-02 Thread Konstantin Ananyev
Hi Feifei, Add 'tx_fill_sw_ring' and 'rx_flush_descriptor' API into direct rearm mode for separate Rx and Tx Operation. And this can support different multiple sources in direct rearm mode. For examples, Rx driver is ixgbe, and Tx driver is i40e. Thanks for your effort and thanks for taking c

Re: [PATCH v3 2/3] net/i40e: enable direct rearm with separate API

2023-02-02 Thread Konstantin Ananyev
04/01/2023 07:30, Feifei Wang пишет: Add internal API to separate direct rearm operations between Rx and Tx. Suggested-by: Honnappa Nagarahalli Signed-off-by: Feifei Wang Reviewed-by: Ruifeng Wang Reviewed-by: Honnappa Nagarahalli --- drivers/net/i40e/i40e_ethdev.c | 1 + driver

Re: [PATCH v2 2/2] ethdev: introduce the PHY affinity field in Tx queue API

2023-02-02 Thread Thomas Monjalon
02/02/2023 10:28, Andrew Rybchenko: > On 2/1/23 18:50, Jiawei(Jonny) Wang wrote: > > From: Andrew Rybchenko > >> On 1/30/23 20:00, Jiawei Wang wrote: > >>> Adds the new tx_phy_affinity field into the padding hole of > >>> rte_eth_txconf structure, the size of rte_eth_txconf keeps the same. > >>> A

RE: [PATCH v2] net/af_xdp: AF_XDP PMD CNI Integration

2023-02-02 Thread Zhang, Qi Z
> -Original Message- > From: Koikkara Reeny, Shibin > Sent: Thursday, January 19, 2023 11:10 PM > To: Zhang, Qi Z ; dev@dpdk.org; Burakov, Anatoly > ; Richardson, Bruce > > Cc: Loftus, Ciara > Subject: RE: [PATCH v2] net/af_xdp: AF_XDP PMD CNI Integration > > > > -Original Messa

Re: [PATCH v2] net/af_xdp: AF_XDP PMD CNI Integration

2023-02-02 Thread Bruce Richardson
On Thu, Feb 02, 2023 at 02:49:52PM +, Zhang, Qi Z wrote: > > > > -Original Message- > > From: Koikkara Reeny, Shibin > > Sent: Thursday, January 19, 2023 11:10 PM > > To: Zhang, Qi Z ; dev@dpdk.org; Burakov, Anatoly > > ; Richardson, Bruce > > > > Cc: Loftus, Ciara > > Subject: RE:

RE: [PATCH v7 4/6] ethdev: add trace points for flow

2023-02-02 Thread Ankur Dwivedi
>Subject: [EXT] RE: [PATCH v7 4/6] ethdev: add trace points for flow > >External Email > >-- >Sorry sent before all comments, >Adding missing comments > >> -Original Message- >> From: Ori Kam >> Sent: Thursday, 2 February

[PATCH] config: added support for NVIDIA ARM implementer ID

2023-02-02 Thread cburdick
From: cliffburdick Signed-off-by: cliffburdick --- .mailmap | 1 + config/arm/meson.build | 21 + 2 files changed, 22 insertions(+) diff --git a/.mailmap b/.mailmap index 6a91c11be4..2cb0d9e41b 100644 --- a/.mailmap +++ b/.mailmap @@ -230,6 +230,7 @@ Cian Fer

Re: [PATCH v6 0/2] eal: provide leading and trailing zero bit count abstraction

2023-02-02 Thread Tyler Retzlaff
On Thu, Feb 02, 2023 at 10:14:41AM +0100, David Marchand wrote: > Hello Tyler, > > On Fri, Jan 20, 2023 at 11:14 PM Tyler Retzlaff > wrote: > > > > hi folks, > > > > i think this one can probably be merged? > > > > Series-acked-by: Morten Brørup > > Series-acked-by: Bruce Richardson > > patch 1

Re: [PATCH v6 0/2] eal: provide leading and trailing zero bit count abstraction

2023-02-02 Thread Tyler Retzlaff
On Thu, Feb 02, 2023 at 11:56:41AM +0100, David Marchand wrote: > On Thu, Feb 2, 2023 at 10:14 AM David Marchand > wrote: > > > > Hello Tyler, > > > > On Fri, Jan 20, 2023 at 11:14 PM Tyler Retzlaff > > wrote: > > > > > > hi folks, > > > > > > i think this one can probably be merged? > > > > > >

[v2 2/5] net/mlx5/hws: change STC array size to 32K

2023-02-02 Thread Hamdan Igbaria
Change STC array size from 16K to 32K. This change allows supporting more actions using HWS. Signed-off-by: Hamdan Igbaria --- drivers/net/mlx5/hws/mlx5dr_pool.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/mlx5/hws/mlx5dr_pool.h b/drivers/net/mlx5/hws/mlx5dr_

[v2 1/5] net/mlx5/hws: fix alias_rtc_0 print location in debug dump

2023-02-02 Thread Hamdan Igbaria
Fix alias_rtc_0 print location in debug dump, move it to the end of matcher dumped info instead of the middle, to keep the dump compatibility. Fixes: dd2845361a58 ("net/mlx5/hws: add debug details for cross gvmi") Signed-off-by: Hamdan Igbaria --- drivers/net/mlx5/hws/mlx5dr_debug.c | 12 ++-

[v2 3/5] net/mlx5/hws: support STC info dump

2023-02-02 Thread Hamdan Igbaria
Dump the STC info in debug dump. Signed-off-by: Hamdan Igbaria --- drivers/net/mlx5/hws/mlx5dr_debug.c | 55 + drivers/net/mlx5/hws/mlx5dr_debug.h | 1 + 2 files changed, 56 insertions(+) diff --git a/drivers/net/mlx5/hws/mlx5dr_debug.c b/drivers/net/mlx5/hws/mlx5d

[v2 4/5] net/mlx5/hws: support IP version matching for non relaxed

2023-02-02 Thread Hamdan Igbaria
Enable matching on IP version explicitly for non relaxed mode. This will add support for the user cases where he needs to match on ip version explicitly, for such case to have outer ipv6 and inner ipv4 packets, etc. Signed-off-by: Hamdan Igbaria --- drivers/net/mlx5/hws/mlx5dr_definer.c | 16 +++

[v2 5/5] net/mlx5: support HW steering debug dump

2023-02-02 Thread Hamdan Igbaria
Add the ability for the DPDK apps to call HW steering relevant debug data dump function. Signed-off-by: Hamdan Igbaria --- drivers/net/mlx5/mlx5_flow.c | 12 +--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/drivers/net/mlx5/mlx5_flow.c b/drivers/net/mlx5/mlx5_flow.c ind

RE: [PATCH v2 1/3] eventdev/eth_rx: add params set/get APIs

2023-02-02 Thread Naga Harish K, S V
Hi Jerin, > -Original Message- > From: Jerin Jacob > Sent: Monday, January 30, 2023 8:13 PM > To: Naga Harish K, S V > Cc: jer...@marvell.com; Carrillo, Erik G ; Gujjar, > Abhinandan S ; dev@dpdk.org; > Jayatheerthan, Jay > Subject: Re: [PATCH v2 1/3] eventdev/eth_rx: add params set/get

[PATCH v2 0/8] compress/mlx5: add LZ4 support

2023-02-02 Thread Michael Baum
Add support for LZ4 decompression algorithm for mlx5 compress PMD. Complete the support of compress PMD for Bluefield-3 smart-nic. RFC: https://patchwork.dpdk.org/project/dpdk/patch/20220410182622.8828-1-rzid...@nvidia.com/ Depends-on: series-26747 ("compressdev: add LZ4 support") Depends-on: ser

[PATCH v2 1/8] compress/mlx5: fix decompress xform validation

2023-02-02 Thread Michael Baum
In xform creation, it first validate the xform according the capabilities. One of validations verifies that given "hash_algo" is "RTE_COMP_HASH_ALGO_NONE" for both compress and decompress xform objects. However, the validation for decompress checks it again for compress xform object. This patch c

[PATCH v2 2/8] compress/mlx5: fix wrong output Adler-32 checksum offset

2023-02-02 Thread Michael Baum
After de/compress dequeue, the output checksum is copied into the op structure. The "output_checksum" field in op structure is "uint64_t" type, and the 32-bit checksums (CRC32, Adler-32) are copied into the lower 32 bits. When both CRC32 and Adler-32 are configured, CRC32 is copied into the lower

[PATCH v2 3/8] compress/mlx5: fix QP setup for partial transformations

2023-02-02 Thread Michael Baum
The mlx5_compress_qp_setup() function creates QP for compress, decompress and DMA. Thus, the MMO flag is turned on only when all operations are supported. However, since partial transformations have been allowed, it should be turn on for part of them. This patch removes the compress MMO support r

[PATCH v2 4/8] compress/mlx5: support new metadata layout added in BF3

2023-02-02 Thread Michael Baum
Commit [1] add support in Bluefield-3, but Bluefield-3 has different GGA opaque structure than Bluefield-2. This patch updates the PRM structure to include both versions, and culculate the relevant offset for each version in control path. Commit [1] 559014f232b4 ("compress/mlx5: add Bluefield-3 d

[PATCH v2 7/8] common/mlx5: add LZ4 capabilities check

2023-02-02 Thread Michael Baum
Add capabilities check for LZ4 decompression algorithm. Signed-off-by: Michael Baum --- drivers/common/mlx5/mlx5_devx_cmds.c | 6 ++ drivers/common/mlx5/mlx5_devx_cmds.h | 3 +++ drivers/common/mlx5/mlx5_prm.h | 16 ++-- 3 files changed, 23 insertions(+), 2 deletions(-)

[PATCH v2 8/8] compress/mlx5: add support for LZ4 algorithm

2023-02-02 Thread Michael Baum
Add support for decompress LZ4 algorithm for mlx5 PMD. Signed-off-by: Michael Baum --- doc/guides/compressdevs/features/mlx5.ini | 18 ++- doc/guides/compressdevs/mlx5.rst | 49 ++- doc/guides/rel_notes/release_23_03.rst| 4 + drivers/compress/mlx5/mlx5_compress.c | 150

[PATCH v2 5/8] compress/mlx5: remove unused variable from priv structure

2023-02-02 Thread Michael Baum
The priv structure has variable named "min_block_size" coming from HCA capabilities. This field isn't used and copied into the priv structure for free. This patch removes this field. Signed-off-by: Michael Baum --- drivers/compress/mlx5/mlx5_compress.c | 3 --- 1 file changed, 3 deletions(-)

[PATCH v2 6/8] compress/mlx5: add xform validate function

2023-02-02 Thread Michael Baum
Separate the xform validations from create function into new function. The new function checks caps directly from HCA attr structure, so all capabilities in priv structure were removed. Signed-off-by: Michael Baum --- drivers/compress/mlx5/mlx5_compress.c | 75 +++ 1 file

[PATCH v3] net/af_xdp: AF_XDP PMD CNI Integration

2023-02-02 Thread Shibin Koikkara Reeny
Integrate support for the AF_XDP CNI and device plugin [1] so that the DPDK AF_XDP PMD can work in an unprivileged container environment. Part of the AF_XDP PMD initialization process involves loading an eBPF program onto the given netdev. This operation requires privileges, which prevents the PMD

RE: [PATCH v2] net/af_xdp: AF_XDP PMD CNI Integration

2023-02-02 Thread Koikkara Reeny, Shibin
> -Original Message- > From: Richardson, Bruce > Sent: Thursday, February 2, 2023 3:19 PM > To: Zhang, Qi Z > Cc: Koikkara Reeny, Shibin ; > dev@dpdk.org; Burakov, Anatoly ; Loftus, > Ciara > Subject: Re: [PATCH v2] net/af_xdp: AF_XDP PMD CNI Integration > > On Thu, Feb 02, 2023 at 0

Re: [PATCH v6 4/8] ethdev: use GRE protocol struct for flow matching

2023-02-02 Thread Thomas Monjalon
02/02/2023 13:44, Ferruh Yigit: > --- a/lib/net/rte_gre.h > +++ b/lib/net/rte_gre.h > @@ -28,6 +28,8 @@ extern "C" { > */ > __extension__ > struct rte_gre_hdr { > + union { > + struct { > #if RTE_BYTE_ORDER == RTE_LITTLE_ENDIAN > uint16_t res2:4; /**< Reserved */ >

Re: [PATCH v6 8/8] net: mark all big endian types

2023-02-02 Thread Thomas Monjalon
02/02/2023 13:45, Ferruh Yigit: > --- a/lib/ethdev/rte_flow.h > +++ b/lib/ethdev/rte_flow.h > @@ -642,8 +642,8 @@ struct rte_flow_item_higig2_hdr { > static const struct rte_flow_item_higig2_hdr rte_flow_item_higig2_hdr_mask = > { > .hdr = { > .ppt1 = { > -

[PATCH] config: added support for NVIDIA ARM implementer ID

2023-02-02 Thread cburdick
From: Cliff Burdick Signed-off-by: Cliff Burdick --- .mailmap | 1 + config/arm/meson.build | 21 + 2 files changed, 22 insertions(+) diff --git a/.mailmap b/.mailmap index 6a91c11be4..2cb0d9e41b 100644 --- a/.mailmap +++ b/.mailmap @@ -230,6 +230,7 @@ Cian F

Re: [PATCH V8] ethdev: fix one address occupies two entries in MAC addrs

2023-02-02 Thread Ferruh Yigit
On 2/2/2023 12:36 PM, Huisong Li wrote: > The dev->data->mac_addrs[0] will be changed to a new MAC address when > applications modify the default MAC address by .mac_addr_set(). However, > if the new default one has been added as a non-default MAC address by > .mac_addr_add(), the .mac_addr_set() d

[PATCH] doc: fix an alignment issue in bnxt NIC documentation

2023-02-02 Thread Ajit Khaparde
The supported firmware version information was not aligned correctly. This patch fixes it. Fixes: b845c295cd13 ("doc: update Broadcom bnxt guide") Signed-off-by: Ajit Khaparde --- doc/guides/nics/bnxt.rst | 1 + 1 file changed, 1 insertion(+) diff --git a/doc/guides/nics/bnxt.rst b/doc/guides/n

RE: [PATCH v2 1/3] ethdev: add ICMPv6 ID and sequence

2023-02-02 Thread Leo Xu (Networking SW)
Hi Thomas PSB > 31/01/2023 07:53, Leo Xu (Networking SW): > > From: Thomas Monjalon > > > 20/12/2022 08:44, Leo Xu: > > > > +/** > > > > + * ICMP6 header > > > > + */ > > > > +struct rte_icmp6_hdr { > > > > + uint8_t type; > > > > + uint8_t code; > > > > + rte_be16_t checksum; > > >

Re: [PATCH] eal: introduce atomics abstraction

2023-02-02 Thread Tyler Retzlaff
On Thu, Feb 02, 2023 at 09:43:58AM +0100, Morten Brørup wrote: > > From: Tyler Retzlaff [mailto:roret...@linux.microsoft.com] > > Sent: Wednesday, 1 February 2023 22.41 > > > > On Wed, Feb 01, 2023 at 01:07:59AM +, Honnappa Nagarahalli wrote: > > > > > > > From: Thomas Monjalon > > > > Sent:

Sign changes through function signatures

2023-02-02 Thread Ben Magistro
Hello, While making some updates to our code base for 22.11.1 that were missed in our first pass through, we hit the numa node change[1]. In the process of updating our code, we noticed that a couple functions (rx/tx_queue_setup, maybe more that we aren't using) state they accept `SOCKET_ID_ANY`

Re: Sign changes through function signatures

2023-02-02 Thread Tyler Retzlaff
On Thu, Feb 02, 2023 at 02:23:39PM -0500, Ben Magistro wrote: > Hello, > > While making some updates to our code base for 22.11.1 that were missed in > our first pass through, we hit the numa node change[1]. In the process of > updating our code, we noticed that a couple functions (rx/tx_queue_se

RE: [PATCH] eal: introduce atomics abstraction

2023-02-02 Thread Morten Brørup
> From: Tyler Retzlaff [mailto:roret...@linux.microsoft.com] > Sent: Thursday, 2 February 2023 20.00 > > On Thu, Feb 02, 2023 at 09:43:58AM +0100, Morten Brørup wrote: > > > From: Tyler Retzlaff [mailto:roret...@linux.microsoft.com] > > > Sent: Wednesday, 1 February 2023 22.41 > > > > > > On Wed,

Re: Sign changes through function signatures

2023-02-02 Thread Thomas Monjalon
02/02/2023 21:26, Tyler Retzlaff: > On Thu, Feb 02, 2023 at 02:23:39PM -0500, Ben Magistro wrote: > > Hello, > > > > While making some updates to our code base for 22.11.1 that were missed in > > our first pass through, we hit the numa node change[1]. In the process of > > updating our code, we n

Re: [PATCH V8] ethdev: fix one address occupies two entries in MAC addrs

2023-02-02 Thread Thomas Monjalon
02/02/2023 19:09, Ferruh Yigit: > On 2/2/2023 12:36 PM, Huisong Li wrote: > > The dev->data->mac_addrs[0] will be changed to a new MAC address when > > applications modify the default MAC address by .mac_addr_set(). However, > > if the new default one has been added as a non-default MAC address by

Re: [PATCH v2 1/3] ethdev: add ICMPv6 ID and sequence

2023-02-02 Thread Thomas Monjalon
02/02/2023 19:33, Leo Xu (Networking SW): > > 31/01/2023 07:53, Leo Xu (Networking SW): > > > From: Thomas Monjalon > > > > 20/12/2022 08:44, Leo Xu: > > > > > +/** > > > > > + * ICMP6 header > > > > > + */ > > > > > +struct rte_icmp6_hdr { > > > > > + uint8_t type; > > > > > + uint8_t cod

RE: Sign changes through function signatures

2023-02-02 Thread Morten Brørup
> From: Thomas Monjalon [mailto:tho...@monjalon.net] > Sent: Thursday, 2 February 2023 21.45 > > 02/02/2023 21:26, Tyler Retzlaff: > > On Thu, Feb 02, 2023 at 02:23:39PM -0500, Ben Magistro wrote: > > > Hello, > > > > > > While making some updates to our code base for 22.11.1 that were > missed in

RE: [PATCH V8] ethdev: fix one address occupies two entries in MAC addrs

2023-02-02 Thread Morten Brørup
> From: Thomas Monjalon [mailto:tho...@monjalon.net] > Sent: Thursday, 2 February 2023 22.11 > > 02/02/2023 19:09, Ferruh Yigit: > > On 2/2/2023 12:36 PM, Huisong Li wrote: > > > The dev->data->mac_addrs[0] will be changed to a new MAC address > when > > > applications modify the default MAC addre

Re: [PATCH] build: detect backtrace availability

2023-02-02 Thread Thomas Monjalon
09/01/2023 10:08, Bruce Richardson: > On Sun, Jan 08, 2023 at 10:59:20AM +0100, Thomas Monjalon wrote: > > Backtrace dump is available: > > - always on Windows > > - on Linux/BSD if execinfo.h is available (not anymore on Alpine) > > > > The flag RTE_BACKTRACE was set unconditionnaly in rt

Re: [PATCH] net/gve: add support for basic stats

2023-02-02 Thread Joshua Washington
Tested-by: Joshua Washington On Tue, Jan 31, 2023 at 2:05 AM Ferruh Yigit wrote: > On 1/31/2023 1:51 AM, Joshua Washington wrote: > > Hello, > > > > I tested it out, and the updates to testpmd seem to work. > > > > Hi Joshua, > > Thanks for testing, I will send a patch soon. > > But this was te

Re: [dpdk-dev] [PATCH v1 01/12] mldev: introduce machine learning device library

2023-02-02 Thread Stephen Hemminger
On Wed, 1 Feb 2023 13:34:41 + Shivah Shankar Shankar Narayan Rao wrote: > --- a/lib/eal/include/rte_log.h > +++ b/lib/eal/include/rte_log.h > @@ -48,6 +48,7 @@ extern "C" { > #define RTE_LOGTYPE_EFD 18 /**< Log related to EFD. */ > #define RTE_LOGTYPE_EVENTDEV 19 /**< Log related to

Re: [dpdk-dev] [PATCH v1 01/12] mldev: introduce machine learning device library

2023-02-02 Thread Stephen Hemminger
On Wed, 1 Feb 2023 13:34:41 + Shivah Shankar Shankar Narayan Rao wrote: > +struct rte_ml_dev_info { > + const char *driver_name; > + /**< Driver name */ > + int16_t max_models; Why is max_models signed? other fields are unsigned

Re: [dpdk-dev] [PATCH v1 01/12] mldev: introduce machine learning device library

2023-02-02 Thread Stephen Hemminger
On Wed, 1 Feb 2023 13:34:41 + Shivah Shankar Shankar Narayan Rao wrote: > +#define RTE_ML_STR_MAX 128 > +/**< Maximum length of name string */ Fixed length strings do create long term technical issues. But this is big enough, I doubt it matters. You may want to make sure that string is alwa

[PATCH] net/nfp: advertise no support for keeping flow rules

2023-02-02 Thread Chaoyong He
From: Peng Zhang Explicitly clear the RTE_ETH_DEV_CAPA_FLOW_RULE_KEEP capability bit to match behavior of other PMDs. This was missed when first adding flow support for the NFP PMD. Fixes: 30ecce522732 ("net/nfp: support flow API") Cc: chaoyong...@corigine.com Cc: sta...@dpdk.org Signed-off-by:

Re: [PATCH V8] ethdev: fix one address occupies two entries in MAC addrs

2023-02-02 Thread lihuisong (C)
在 2023/2/3 5:10, Thomas Monjalon 写道: 02/02/2023 19:09, Ferruh Yigit: On 2/2/2023 12:36 PM, Huisong Li wrote: The dev->data->mac_addrs[0] will be changed to a new MAC address when applications modify the default MAC address by .mac_addr_set(). However, if the new default one has been added as

[PATCH v2] net/nfp: advertise no support for keeping flow rules

2023-02-02 Thread Chaoyong He
From: Peng Zhang Explicitly clear the RTE_ETH_DEV_CAPA_FLOW_RULE_KEEP capability bit to match behavior of other PMDs. This was missed when first adding flow support for the NFP PMD. Fixes: 30ecce522732 ("net/nfp: support flow API") Cc: chaoyong...@corigine.com Cc: sta...@dpdk.org Signed-off-by:

[PATCH v4] net/ice: add devargs for disabling default mac

2023-02-02 Thread Ke Zhang
From: "ke1x.zhang" There is a requirement that if a flow rule is created, received packet is permitted to pass if rule matching, or else drop. But in default, a mac filter will be created and the default mac will be added into lookup table during driver initialization, it makes drop action imposs

[dpdk-dev] [PATCH v2 1/1] compress/octeontx: support scatter gather mode

2023-02-02 Thread Mahipal Challa
Scatter gather mode feature support is added to compress or decompress the larger data in a single compression or decompression operation. Signed-off-by: Mahipal Challa --- v2: - Checkpatch warning is resolved. - PMD debug logs are used for debug prints. - Documentation is updated. --- --- d

[PATCH] net/nfp: fix length comparison for max DMA length

2023-02-02 Thread Chaoyong He
From: Richard Donkin The DMA transfer length is allowed to be as large as NFDK_TX_MAX_DATA_PER_HEAD. The existing check would not allow a simple- type descriptor to be created for a packet of size NFDK_TX_MAX_DATA_PER_HEAD, but it would also not enable gather-type descriptors to be created correc

RE: [PATCH v2 1/3] ethdev: add ICMPv6 ID and sequence

2023-02-02 Thread Leo Xu (Networking SW)
> 02/02/2023 19:33, Leo Xu (Networking SW): > > > 31/01/2023 07:53, Leo Xu (Networking SW): > > > > From: Thomas Monjalon > > > > > 20/12/2022 08:44, Leo Xu: > > > > > > +/** > > > > > > + * ICMP6 header > > > > > > + */ > > > > > > +struct rte_icmp6_hdr { > > > > > > + uint8_t type; > > > >

[PATCH] net/nfp: refresh function comment

2023-02-02 Thread Chaoyong He
From: Zerun Fu Fix sections where the documentation have gone out of sync with the function names. While at it add documentation for functions to make it clear on what device they operate on. Signed-off-by: Zerun Fu Reviewed-by: Chaoyong He Reviewed-by: Niklas Söderlund --- drivers/net/nfp/n

RE: [PATCH v3 2/2] net/igc: enable launch time offloading

2023-02-02 Thread Su, Simei
Hi Stephen, > -Original Message- > From: Stephen Hemminger > Sent: Friday, February 3, 2023 8:31 AM > To: Su, Simei > Cc: Zhang, Qi Z ; Guo, Junfeng > ; dev@dpdk.org; Wu, Wenjun1 > > Subject: Re: [PATCH v3 2/2] net/igc: enable launch time offloading > > On Thu, 2 Feb 2023 15:18:01 +08

RE: [PATCH v5] net/i40e: rework maximum frame size configuration

2023-02-02 Thread Su, Simei
Hi David, > -Original Message- > From: David Marchand > Sent: Thursday, February 2, 2023 8:56 PM > To: Su, Simei ; Zhang, Qi Z > Cc: Xing, Beilei ; Zhang, Yuying > ; dev@dpdk.org; Yang, Qiming > ; sta...@dpdk.org > Subject: Re: [PATCH v5] net/i40e: rework maximum frame size configuration

<    1   2   3   >