Updated invitation: DTS Working Group - DPDK @ Every 2 weeks from 15:00 to 16:00 on Wednesday (CET) (dev@dpdk.org)

2023-02-08 Thread juraj . linkes
BEGIN:VCALENDAR PRODID:-//Google Inc//Google Calendar 70.9054//EN VERSION:2.0 CALSCALE:GREGORIAN METHOD:REQUEST BEGIN:VTIMEZONE TZID:America/Detroit X-LIC-LOCATION:America/Detroit BEGIN:DAYLIGHT TZOFFSETFROM:-0500 TZOFFSETTO:-0400 TZNAME:EDT DTSTART:19700308T02 RRULE:FREQ=YEARLY;BYMONTH=3;BYDAY

Updated invitation: DTS Working Group - DPDK @ Every 2 weeks from 15:00 to 16:00 on Wednesday (CEST) (dev@dpdk.org)

2023-02-08 Thread juraj . linkes
BEGIN:VCALENDAR PRODID:-//Google Inc//Google Calendar 70.9054//EN VERSION:2.0 CALSCALE:GREGORIAN METHOD:REQUEST BEGIN:VTIMEZONE TZID:America/Detroit X-LIC-LOCATION:America/Detroit BEGIN:DAYLIGHT TZOFFSETFROM:-0500 TZOFFSETTO:-0400 TZNAME:EDT DTSTART:19700308T02 RRULE:FREQ=YEARLY;BYMONTH=3;BYDAY

RE: [PATCH v3] net/af_xdp: AF_XDP PMD CNI Integration

2023-02-08 Thread Zhang, Qi Z
> -Original Message- > From: Koikkara Reeny, Shibin > Sent: Friday, February 3, 2023 12:55 AM > To: dev@dpdk.org; Zhang, Qi Z ; Burakov, Anatoly > ; Richardson, Bruce > ; Mcnamara, John > > Cc: Loftus, Ciara ; Koikkara Reeny, Shibin > > Subject: [PATCH v3] net/af_xdp: AF_XDP PMD CNI I

RE: [PATCH v6 1/6] common/idpf: add hw statistics

2023-02-08 Thread Liu, Mingxia
Thanks, will update module name. And there is no warning when checked by ./devtools/check-git-log.sh. > -Original Message- > From: Zhang, Qi Z > Sent: Wednesday, February 8, 2023 10:00 AM > To: Liu, Mingxia ; dev@dpdk.org; Wu, Jingjing > ; Xing, Beilei > Subject: RE: [PATCH v6 1/6] commo

[PATCH v13 4/6] test/memarea: support alloc and free API test

2023-02-08 Thread Chengwen Feng
This patch supports rte_memarea_alloc() and rte_memarea_free() API test. Signed-off-by: Chengwen Feng Reviewed-by: Dongdong Liu Acked-by: Morten Brørup --- app/test/test_memarea.c | 135 +++- 1 file changed, 134 insertions(+), 1 deletion(-) diff --git a/app

[PATCH v13 1/6] memarea: introduce memarea library

2023-02-08 Thread Chengwen Feng
The memarea library is an allocator of variable-size object which based on a memory region. This patch provides rte_memarea_create() and rte_memarea_destroy() API. Signed-off-by: Chengwen Feng Reviewed-by: Dongdong Liu Acked-by: Morten Brørup --- MAINTAINERS| 5 +

[PATCH v13 2/6] test/memarea: support memarea test

2023-02-08 Thread Chengwen Feng
This patch supports memarea test of rte_memarea_create() and rte_memarea_destroy() API. Signed-off-by: Chengwen Feng Reviewed-by: Dongdong Liu Acked-by: Morten Brørup --- MAINTAINERS | 1 + app/test/meson.build| 2 + app/test/test_memarea.c | 130 +++

[PATCH v13 6/6] test/memarea: support dump API test

2023-02-08 Thread Chengwen Feng
This patch supports rte_memarea_dump() API test. Signed-off-by: Chengwen Feng Reviewed-by: Dongdong Liu Acked-by: Morten Brørup --- app/test/test_memarea.c | 34 ++ 1 file changed, 34 insertions(+) diff --git a/app/test/test_memarea.c b/app/test/test_memarea.c

[PATCH v13 0/6] introduce memarea library

2023-02-08 Thread Chengwen Feng
The memarea library is an allocator of variable-size object which based on a memory region. The main features are as follows: - The memory region can be initialized from the following memory sources: 1. HEAP: e.g. invoke rte_malloc_socket. 2. LIBC: e.g. invoke posix_memalign. 3. Another me

[PATCH v13 3/6] memarea: support alloc and free API

2023-02-08 Thread Chengwen Feng
This patch supports rte_memarea_alloc() and rte_memarea_free() API. Signed-off-by: Chengwen Feng Reviewed-by: Dongdong Liu Acked-by: Morten Brørup --- doc/guides/prog_guide/memarea_lib.rst | 6 + lib/memarea/rte_memarea.c | 180 ++ lib/memarea/rte_memarea.

[PATCH v13 5/6] memarea: support dump API

2023-02-08 Thread Chengwen Feng
This patch supports rte_memarea_dump() API which could be used for debug. Signed-off-by: Chengwen Feng Reviewed-by: Dongdong Liu Acked-by: Morten Brørup --- doc/guides/prog_guide/memarea_lib.rst | 3 + lib/memarea/rte_memarea.c | 97 +++ lib/memarea/rte_mem

[PATCH v7 0/6] add idpf pmd enhancement features

2023-02-08 Thread Mingxia Liu
This patchset add several enhancement features of idpf pmd. Including the following: - add hw statistics, support stats/xstats ops - add rss configure/show ops - add event handle: link status - add scattered data path for single queue v2 changes: - Fix rss lut config issue. v3 changes: - rebase

[PATCH v7 2/6] net/idpf: add RSS set/get ops

2023-02-08 Thread Mingxia Liu
Add support for these device ops: - rss_reta_update - rss_reta_query - rss_hash_update - rss_hash_conf_get Signed-off-by: Mingxia Liu --- drivers/common/idpf/idpf_common_device.h | 1 + drivers/common/idpf/idpf_common_virtchnl.c | 119 + drivers/common/idpf/idpf_common_virtchnl.h |

[PATCH v7 1/6] net/idpf: add hw statistics

2023-02-08 Thread Mingxia Liu
This patch add hardware packets/bytes statistics. Signed-off-by: Mingxia Liu --- drivers/common/idpf/idpf_common_device.c | 17 + drivers/common/idpf/idpf_common_device.h | 4 + drivers/common/idpf/idpf_common_virtchnl.c | 27 +++ drivers/common/idpf/idpf_common_virtchnl.h | 3 + d

RE: [PATCH] eal: introduce atomics abstraction

2023-02-08 Thread Morten Brørup
> From: Tyler Retzlaff [mailto:roret...@linux.microsoft.com] > Sent: Wednesday, 8 February 2023 02.21 > > On Tue, Feb 07, 2023 at 11:34:14PM +, Honnappa Nagarahalli wrote: > > > > > > > > > > > > > > Honnappa, please could you give your view on the future of > atomics in > > > DPDK? > > > > T

[PATCH v7 4/6] net/idpf: add rss_offload hash in singleq rx

2023-02-08 Thread Mingxia Liu
This patch add rss valid flag and hash value parsing of rx descriptor. Signed-off-by: Mingxia Liu --- drivers/common/idpf/idpf_common_rxtx.c | 16 1 file changed, 16 insertions(+) diff --git a/drivers/common/idpf/idpf_common_rxtx.c b/drivers/common/idpf/idpf_common_rxtx.c inde

[PATCH v7 3/6] net/idpf: support single q scatter RX datapath

2023-02-08 Thread Mingxia Liu
This patch add single q recv scatter rx function. Signed-off-by: Mingxia Liu Signed-off-by: Wenjun Wu --- drivers/common/idpf/idpf_common_rxtx.c | 135 + drivers/common/idpf/idpf_common_rxtx.h | 3 + drivers/common/idpf/version.map| 1 + drivers/net/idpf/idpf

[PATCH v7 6/6] net/idpf: add xstats ops

2023-02-08 Thread Mingxia Liu
Add support for these device ops: -idpf_dev_xstats_get -idpf_dev_xstats_get_names -idpf_dev_xstats_reset Signed-off-by: Mingxia Liu --- drivers/net/idpf/idpf_ethdev.c | 80 ++ 1 file changed, 80 insertions(+) diff --git a/drivers/net/idpf/idpf_ethdev.c b/drivers/

[PATCH v7 5/6] net/idpf: add alarm to support handle vchnl message

2023-02-08 Thread Mingxia Liu
Handle virtual channel message. Refine link status update. Signed-off-by: Mingxia Liu Signed-off-by: Beilei Xing --- drivers/common/idpf/idpf_common_device.h | 5 + drivers/common/idpf/idpf_common_virtchnl.c | 33 ++-- drivers/common/idpf/idpf_common_virtchnl.h | 6 + drivers/common/idpf

RE: [PATCH v13 0/6] introduce memarea library

2023-02-08 Thread Morten Brørup
> From: Chengwen Feng [mailto:fengcheng...@huawei.com] > Sent: Wednesday, 8 February 2023 09.25 > > The memarea library is an allocator of variable-size object which based > on a memory region. The main features are as follows: > > - The memory region can be initialized from the following memory

[PATCH] net/ice: fix ice dcf contrl thread crash

2023-02-08 Thread Ke Zhang
The control thread accesses the hardware resources after the resources were released, resulting in a segment error. This commit fixes the bug by exiting thread before resource released. Signed-off-by: Ke Zhang --- drivers/net/ice/ice_dcf.c | 4 1 file changed, 4 insertions(+) diff --git a

[RESEND PATCH v9 0/5] lcore telemetry improvements

2023-02-08 Thread Robin Jarry
This is a follow up on previous work by Kevin Laatz: http://patches.dpdk.org/project/dpdk/list/?series=24658&state=* This series is aimed at allowing DPDK applications to expose their CPU usage stats in the DPDK telemetry under /eal/lcore/info. This is a much more basic and naive approach which l

[RESEND PATCH v9 2/5] eal: report applications lcore usage

2023-02-08 Thread Robin Jarry
Allow applications to register a callback that will be invoked in rte_lcore_dump() and when requesting lcore info in the telemetry API. The callback is expected to return the number of TSC cycles that have passed since application start and the number of these cycles that were spent doing busy wor

[RESEND PATCH v9 1/5] eal: add lcore info in telemetry

2023-02-08 Thread Robin Jarry
Report the same information than rte_lcore_dump() in the telemetry API into /eal/lcore/list and /eal/lcore/info,ID. Example: --> /eal/lcore/info,3 { "/eal/lcore/info": { "lcore_id": 3, "socket": 0, "role": "RTE", "cpuset": [ 3 ] } } Signed-off-

[RESEND PATCH v9 3/5] app/testpmd: add dump command for lcores

2023-02-08 Thread Robin Jarry
Add a simple command that calls rte_lcore_dump(). Signed-off-by: Robin Jarry Acked-by: Morten Brørup Acked-by: Konstantin Ananyev Reviewed-by: Kevin Laatz --- Notes: v8 -> v9: no change app/test-pmd/cmdline.c | 3 +++ doc/guides/testpmd_app_ug/testpmd_funcs.rst | 7

[RESEND PATCH v9 5/5] eal: add lcore usage telemetry endpoint

2023-02-08 Thread Robin Jarry
Allow fetching CPU cycles usage for all lcores with a single request. This endpoint is intended for repeated and frequent invocations by external monitoring systems and therefore returns condensed data. It consists of a single dictionary with three keys: "lcore_ids", "total_cycles" and "busy_cycle

[RESEND PATCH v9 4/5] app/testpmd: report lcore usage

2023-02-08 Thread Robin Jarry
The --record-core-cycles option already accounts for busy cycles. One turn of packet_fwd_t is considered "busy" if there was at least one received or transmitted packet. Rename core_cycles to busy_cycles in struct fwd_stream to make it more explicit. Add total_cycles to struct fwd_lcore. Add cycle

Re: [PATCH] telemetry: reset data before passing it to callback

2023-02-08 Thread Bruce Richardson
On Tue, Feb 07, 2023 at 07:45:20PM +0100, Robin Jarry wrote: > If a telemetry endpoint callback returns 0 without modifying the data > object, output_json() may be called with undefined contents in data. > This can cause crashes and/or worse (double free, etc.). > > Reset data before passing it to

[PATCH] net/nfp: support 48-bit DMA address for firmware with NFDk

2023-02-08 Thread Chaoyong He
From: Peng Zhang 48-bit DMA address is supported in the firmware with NFDk, so enable this feature in PMD now. But the firmware with NFD3 still just support 40-bit DMA address. RX free list descriptor, used by both NFD3 and NFDk, is also modified to support 48-bit DMA address. That's OK because

[PATCH] net/nfp: fix the incorrect vni of VXLAN encap action

2023-02-08 Thread Chaoyong He
The helper function which send the tunnel configuration to firmware requires the vni with CPU endian. The original VXLAN encap logic wrongly invoke it with the big-endian value. Fixes: 724662b4ce5b ("net/nfp: support IPv4 VXLAN encap flow action") Fixes: c3b7254093c2 ("net/nfp: support IPv6 VXLAN

RE: [PATCH v7 0/6] add idpf pmd enhancement features

2023-02-08 Thread Zhang, Qi Z
> -Original Message- > From: Mingxia Liu > Sent: Wednesday, February 8, 2023 3:34 PM > To: dev@dpdk.org > Cc: Wu, Jingjing ; Xing, Beilei > ; > Liu, Mingxia > Subject: [PATCH v7 0/6] add idpf pmd enhancement features > > This patchset add several enhancement features of idpf pmd. > I

Re: [PATCH] vhost: fix vdpa driver multi-queue initialization failure

2023-02-08 Thread Hao Chen
On 2023/2/3 18:38, Maxime Coquelin wrote: On 1/28/23 04:06, Hao Chen wrote: When 'virtio_is_Ready' returns 1, 'vdpa_dev->ops->dev_conf' will be called, and the vdpa driver called 'rte_vhost_get_vhost_vring' to get the vring addr info from 'vhost_devices->virtqueue[]'. virtio_is_ready's nr_vr

Re: [PATCH v2 01/10] net/ngbe: fix Rx buffer size in configure register

2023-02-08 Thread Ferruh Yigit
On 2/2/2023 9:21 AM, Jiawen Wu wrote: > When buffer size is less than 1K, round down makes it 0, which is an > error value. > > Fixes: 62fc35e63d0e ("net/ngbe: support Rx queue start/stop") > Cc: sta...@dpdk.org > > Signed-off-by: Jiawen Wu > --- > drivers/net/ngbe/ngbe_rxtx.c | 5 - > 1 fi

RE: [EXT] Re: [PATCH v9 2/6] ethdev: add trace points for ethdev (part one)

2023-02-08 Thread Ankur Dwivedi
>Subject: [EXT] Re: [PATCH v9 2/6] ethdev: add trace points for ethdev (part >one) > >External Email > >-- >On 2/7/2023 6:32 AM, Ankur Dwivedi wrote: >> Adds trace points for ethdev functions. >> >> The rte_ethdev_trace.h is remo

RE: [PATCH] lib/net: support UDP pseudo-header for UFO

2023-02-08 Thread Zeng, ZhichaoX
Hi Olivier Could you please help to review this patch? Thanks. BR Zhichao > -Original Message- > From: Zeng, ZhichaoX > Sent: Thursday, January 12, 2023 5:26 PM > To: dev@dpdk.org > Cc: Zhou, YidingX ; Zeng, ZhichaoX > ; Matz, Olivier > Subject: [PATCH] lib/net: support UDP pseudo-heade

RE: [EXT] Re: [PATCH v9 3/6] ethdev: add trace points for ethdev (part two)

2023-02-08 Thread Ankur Dwivedi
>Subject: [EXT] Re: [PATCH v9 3/6] ethdev: add trace points for ethdev (part >two) > >External Email > >-- >On 2/7/2023 6:32 AM, Ankur Dwivedi wrote: >> Subject: >> [PATCH v9 3/6] ethdev: add trace points for ethdev (part two) >> F

[PATCH v2 0/3] power: remove experimental empty poll API

2023-02-08 Thread David Hunt
The empty poll mechanism was an experimental API added in commit id 450f0791312c. It aimed to allow power saving depending on the traffic profile. However, it required a training phase and required the user to adjust magic numbers depending on their workload. A new and improved mechanism was added

[PATCH v2 1/3] examples/power: remove empty poll mode from l3fwd-power

2023-02-08 Thread David Hunt
Remove calls to the experimental empty poll API. l3fwd-power is the only app that uses this. This API is no longer needed as it is superseded by the monitor/pause/scale callback mechanism. Signed-off-by: David Hunt --- examples/l3fwd-power/main.c | 270 +--- 1 fi

[PATCH v2 2/3] libs/power: remove experimental empty poll API

2023-02-08 Thread David Hunt
This patchset removes the empty poll experimental API, which has been in an experimental state since it was added. This API is no longer needed as it is superseded by the PMD Power Management monitor/pause/scale callback mechanism. Signed-off-by: David Hunt Acked-by: Reshma Pattan --- lib/powe

[PATCH v2 3/3] doc/power: remove empty poll documentation

2023-02-08 Thread David Hunt
Remove the documentation for the removed experimental empty poll API, as it is no longer needed. This API is no longer needed as it is superseded by the PMD Power Management monitor/pause/scale callback mechanism. Signed-off-by: David Hunt Acked-by: Reshma Pattan --- doc/guides/prog_guide/powe

Re: [EXT] Re: [PATCH v9 3/6] ethdev: add trace points for ethdev (part two)

2023-02-08 Thread Ferruh Yigit
On 2/8/2023 10:42 AM, Ankur Dwivedi wrote: >>> +RTE_TRACE_POINT( >>> + rte_ethdev_trace_set_mc_addr_list, >>> + RTE_TRACE_POINT_ARGS(uint16_t port_id, >>> + const struct rte_ether_addr *mc_addr_set, uint32_t >> nb_mc_addr, >>> + int ret), >>> + rte_trace_point_emit_u16(por

Re: [EXT] Re: [PATCH v9 3/6] ethdev: add trace points for ethdev (part two)

2023-02-08 Thread Ferruh Yigit
On 2/8/2023 11:00 AM, Ferruh Yigit wrote: > On 2/8/2023 10:42 AM, Ankur Dwivedi wrote: +RTE_TRACE_POINT( + rte_ethdev_trace_set_mc_addr_list, + RTE_TRACE_POINT_ARGS(uint16_t port_id, + const struct rte_ether_addr *mc_addr_set, uint32_t >>> nb_mc_addr, +

RE: [PATCH v2 1/3] examples/power: remove empty poll mode from l3fwd-power

2023-02-08 Thread Pattan, Reshma
> -Original Message- > From: Hunt, David > > Signed-off-by: David Hunt > --- Acked-By: Reshma Pattan

Re: [PATCH] bus: fix leak for devices without driver

2023-02-08 Thread Kevin Laatz
Hi Volodymyr, On 07/01/2023 15:12, Volodymyr Fialko wrote: For devices not assigned to any driver, we leak a pci device object since it is never freed from the PCI bus device list, reported by ASAN. Fixes: 1cab1a40ea9b ("bus: cleanup devices on shutdown") Signed-off-by: Volodymyr Fialko ---

RE: [PATCH v2 1/9] ethdev: sharing indirect actions between ports

2023-02-08 Thread Ori Kam
Hi Slava > -Original Message- > From: Slava Ovsiienko > Sent: Tuesday, 7 February 2023 16:02 > > The RTE Flow API implements the concept of shared objects, > known as indirect actions (RTE_FLOW_ACTION_TYPE_INDIRECT). > An application can create the indirect action of desired > type and

Re: [PATCH v2 00/10] Wangxun fixes and new supports

2023-02-08 Thread Ferruh Yigit
On 2/2/2023 9:21 AM, Jiawen Wu wrote: > Fix some bugs and support to process more interrupt events. > > v2: > - fix buffer size less than 1K > - fix c99 comment syntax ('//') > - remove useless parameter 'ptype' > - expand commit log for packet type > - separate the interrupt disable fix to anothe

RE: no printf in drivers code

2023-02-08 Thread Hemant Agrawal
Hi Thomas, On 2023-02-03 14:57:06 +0100, Thomas Monjalon wrote: > Hello, > > > > We have too many drivers using printf() instead of rte_log(). > > Please propose a plan to replace or remove the calls to printf(). > > If no plan, I could propose one but you may not like it :) > > > > Affected d

Re: [PATCH] telemetry: reset data before passing it to callback

2023-02-08 Thread Robin Jarry
Bruce Richardson, Feb 08, 2023 at 10:03: > This is also fixed by patch > http://patches.dpdk.org/project/dpdk/patch/20230120033456.29710-3-fengcheng...@huawei.com/ > > While both work the same way, I think I prefer the fix to set "= {0}" on > init rather than explicit memset. Oh I had missed that

Re: [PATCH] acl: fix trie splitting

2023-02-08 Thread Arthur Leung
Hi Konstantin Thanks for the explanation and examples, I see I've misunderstood "node limit for tree split" to mean "the limit of the total number of nodes in a tree", rather than the intended logic of "the limit of new nodes that can be created in a trie as a result of merging". Sorry for the bo

Re: net/bnxt: wrong link status when lsc_intr is used

2023-02-08 Thread Edwin Brossette
Hello, Thank you for your quick answer. This was added long back in the driver code by this commit (as you can > see 6+ yrs old :)) , so I believe at the time the intent was to get > this link notification asynchronous > and 'lsc' I believe was for link state change? Please suggest an > alternat

Re: [PATCH] Intel iavf: Return in the case of ADD/DEL ETH address

2023-02-08 Thread Vipin P R
From: Zhang, Qi Z Sent: 17 January 2023 07:24 To: Vipin P R ; Wu, Jingjing ; Xing, Beilei Cc: dev@dpdk.org ; sta...@dpdk.org Subject: RE: [PATCH] Intel iavf: Return in the case of ADD/DEL ETH address !! External Email > -Original Message- > From: Vip

Re: [PATCH v2] net/memif: default to physical socket

2023-02-08 Thread Nathan Skrzypczak
Hi Ferruh, Sorry for the late reply, You can probably drop this patch. Kind regards, -Nathan Le ven. 9 déc. 2022 à 16:13, Ferruh Yigit a écrit : > On 12/8/2022 11:24 AM, Nathan Skrzypczak wrote: > > Hi Stephen, Hi Ferruh, > > > > I don't have a strong opinion on usage of regular sockets vs abs

[PATCH v10 0/6] add trace points in ethdev library

2023-02-08 Thread Ankur Dwivedi
This series adds trace points for functions in the ethdev library. The trace points are added in ethdev, flow, mtr and tm files. v10: - Removed const in basic types in tracepoint. - Removed capture of pointer value where some fields in structure are captured. - Resolved RHEL 7 failure: ..

[PATCH v10 1/6] eal: trace: add trace point emit for blob

2023-02-08 Thread Ankur Dwivedi
Adds a trace point emit function for capturing a blob. The blob captures the length passed by the application followed by the array. The maximum blob bytes which can be captured is bounded by RTE_TRACE_BLOB_LEN_MAX macro. The value for max blob length macro is 64 bytes. If the length is less than

[PATCH v10 2/6] ethdev: add trace points for ethdev (part one)

2023-02-08 Thread Ankur Dwivedi
Adds trace points for ethdev functions. The rte_ethdev_trace.h is removed. The file ethdev_trace.h is added as an internal header. ethdev_trace.h contains internal slow path and fast path tracepoints. The public fast path tracepoints are present in rte_ethdev_trace_fp.h header. Signed-off-by: Ank

[PATCH v10 3/6] ethdev: add trace points for ethdev (part two)

2023-02-08 Thread Ankur Dwivedi
Adds trace points for remaining ethdev functions. Signed-off-by: Ankur Dwivedi Acked-by: Sunil Kumar Kori --- lib/ethdev/ethdev_trace.h| 875 +++ lib/ethdev/ethdev_trace_points.c | 252 + lib/ethdev/rte_ethdev.c | 485 ++--- lib/e

[PATCH v10 4/6] ethdev: add trace points for flow

2023-02-08 Thread Ankur Dwivedi
Adds trace points for rte_flow specific functions in ethdev lib. Signed-off-by: Ankur Dwivedi --- lib/ethdev/ethdev_trace.h| 503 +++ lib/ethdev/ethdev_trace_points.c | 117 +++ lib/ethdev/rte_flow.c| 356 +- 3 files changed

[PATCH v10 5/6] ethdev: add trace points for mtr

2023-02-08 Thread Ankur Dwivedi
Adds trace points for rte_mtr specific functions in ethdev lib. Signed-off-by: Ankur Dwivedi Acked-by: Sunil Kumar Kori --- lib/ethdev/ethdev_trace.h| 206 +++ lib/ethdev/ethdev_trace_points.c | 63 ++ lib/ethdev/rte_mtr.c | 150 +

[PATCH v10 6/6] ethdev: add trace points for tm

2023-02-08 Thread Ankur Dwivedi
Adds trace points for rte_tm specific functions in ethdev lib. Signed-off-by: Ankur Dwivedi --- lib/ethdev/ethdev_trace.h| 304 +++ lib/ethdev/ethdev_trace_points.c | 90 + lib/ethdev/rte_tm.c | 225 --- 3 files change

Outlook for DPDK multi-process support

2023-02-08 Thread Lukáš Šišmiš
Hello all, I'd like to ask you about future outlook of multi-process support in DPDK (https://doc.dpdk.org/guides/prog_guide/multi_proc_support.html). On DPDK Userspace 2022, I have presented a solution that uses multi-process support (https://youtu.be/TtiR74w3Yv4) in Suricata IDS. But aft

Re: [PATCH v4 2/5] telemetry: fix repeat display when callback don't init dict

2023-02-08 Thread Bruce Richardson
On Fri, Jan 20, 2023 at 03:34:53AM +, Chengwen Feng wrote: > When a telemetry callback doesn't initialize the telemetry data > structure and returns a non-negative number, the telemetry will repeat > to display the last result. This patch zero the data structure to avoid > the problem. > > Fix

Re: [PATCH v4 0/5] support dmadev/ethdev stats reset

2023-02-08 Thread Bruce Richardson
On Fri, Jan 20, 2023 at 03:34:51AM +, Chengwen Feng wrote: > This patchset contains dmadev/ethdev stats reset, and also support > hide zero for ethdev xstats and two telemetry related bugs. > > Chengwen Feng (5): > dmadev: support stats reset telemetry command > telemetry: fix repeat displ

RE: [EXT] Re: [PATCH v9 3/6] ethdev: add trace points for ethdev (part two)

2023-02-08 Thread Ankur Dwivedi
>Subject: Re: [EXT] Re: [PATCH v9 3/6] ethdev: add trace points for ethdev (part >two) > >On 2/8/2023 11:00 AM, Ferruh Yigit wrote: >> On 2/8/2023 10:42 AM, Ankur Dwivedi wrote: > +RTE_TRACE_POINT( > + rte_ethdev_trace_set_mc_addr_list, > + RTE_TRACE_POINT_ARGS(uint16_t port_id, > +

[PATCH] telemetry: rework code to avoid compiler warnings

2023-02-08 Thread Bruce Richardson
When printing values as hex strings, the telemetry code temporarily disabled warnings about non-literal format strings. This was because the actual format string was built-up programmatically to ensure the output was of the desired bitwidth. However, this code can be reworked and shortened by taki

RE: [PATCH] telemetry: rework code to avoid compiler warnings

2023-02-08 Thread Morten Brørup
> From: Bruce Richardson [mailto:bruce.richard...@intel.com] > Sent: Wednesday, 8 February 2023 15.38 > To: dev@dpdk.org > Cc: Huisong Li; Chengwen Feng; Morten Brørup; Bruce Richardson > Subject: [PATCH] telemetry: rework code to avoid compiler warnings > > When printing values as hex strings, th

Re: [PATCH] telemetry: rework code to avoid compiler warnings

2023-02-08 Thread Wiles, Keith
From: Bruce Richardson Sent: Wednesday, February 8, 2023 8:37 AM To: dev@dpdk.org Cc: Huisong Li; Chengwen Feng; Morten Brørup; Richardson, Bruce Subject: [PATCH] telemetry: rework code to avoid compiler warnings When printing values as hex strings, the telemetry code temporarily disabled warning

Re: [EXT] Re: [PATCH v9 3/6] ethdev: add trace points for ethdev (part two)

2023-02-08 Thread Ferruh Yigit
On 2/8/2023 2:15 PM, Ankur Dwivedi wrote: >> Subject: Re: [EXT] Re: [PATCH v9 3/6] ethdev: add trace points for ethdev >> (part >> two) >> >> On 2/8/2023 11:00 AM, Ferruh Yigit wrote: >>> On 2/8/2023 10:42 AM, Ankur Dwivedi wrote: >> +RTE_TRACE_POINT( >> +rte_ethdev_trace_set_mc_ad

RE: [EXT] Re: [PATCH v9 3/6] ethdev: add trace points for ethdev (part two)

2023-02-08 Thread Ankur Dwivedi
>Subject: Re: [EXT] Re: [PATCH v9 3/6] ethdev: add trace points for ethdev (part >two) > >On 2/8/2023 2:15 PM, Ankur Dwivedi wrote: >>> Subject: Re: [EXT] Re: [PATCH v9 3/6] ethdev: add trace points for >>> ethdev (part >>> two) >>> >>> On 2/8/2023 11:00 AM, Ferruh Yigit wrote: On 2/8/2023 10:

Re: [PATCH] build: fix invalid characters in toolchain definitions

2023-02-08 Thread Wiles, Keith
From: Richardson, Bruce Sent: Tuesday, February 7, 2023 9:22 AM To: dev@dpdk.org Cc: Richardson, Bruce; sta...@dpdk.org; Wiles, Keith Subject: [PATCH] build: fix invalid characters in toolchain definitions When using "icx" (Intel(R) oneAPI DPC++/C++ Compil

RE: [PATCH v10 4/6] ethdev: add trace points for flow

2023-02-08 Thread Ori Kam
Hi Ankur, > -Original Message- > From: Ankur Dwivedi > Sent: Wednesday, 8 February 2023 15:28 > > Adds trace points for rte_flow specific functions in ethdev lib. > > Signed-off-by: Ankur Dwivedi > --- Acked-by: Ori Kam Best, Ori

Re: [PATCH] eal: introduce atomics abstraction

2023-02-08 Thread Tyler Retzlaff
On Wed, Feb 08, 2023 at 09:31:32AM +0100, Morten Brørup wrote: > > From: Tyler Retzlaff [mailto:roret...@linux.microsoft.com] > > Sent: Wednesday, 8 February 2023 02.21 > > > > On Tue, Feb 07, 2023 at 11:34:14PM +, Honnappa Nagarahalli wrote: > > > > > > > > > > > > > > > > > > Honnappa, plea

Re: [PATCH v2] app/testpmd: expand noisy neighbour forward mode support

2023-02-08 Thread Singh, Aman Deep
On 2/2/2023 12:33 AM, Mike Pattrick wrote: On Wed, Feb 1, 2023 at 10:19 AM Singh, Aman Deep wrote: Hi Mike, Thanks a lot for the patch. On 1/26/2023 10:25 AM, Mike Pattrick wrote: Previously the noisy neighbour vnf simulation would only operate in io mode, forwarding packets as is. However

Re: [PATCH v9 1/5] eal: add lcore info in telemetry

2023-02-08 Thread Robin Jarry
Hi lihuisong, lihuisong (C), Feb 08, 2023 at 03:24: > > static int > > lcore_dump_cb(unsigned int lcore_id, void *arg) > > { > > struct rte_config *cfg = rte_eal_get_configuration(); > > char cpuset[RTE_CPU_AFFINITY_STR_LEN]; > > - const char *role; > > FILE *f = arg; > > i

Re: [PATCH] doc: add supported APIs section to nfp guide

2023-02-08 Thread Niklas Soderlund
Hello Ajit, On 2023-01-24 09:13:20 +, Ferruh Yigit wrote: > On 1/24/2023 2:44 AM, Chaoyong He wrote: > >> On 12/1/2022 1:38 AM, Chaoyong He wrote: > >>> Add a new section 'Supported APIs', inculding the supported > >>> APIs/items/actions of rte_flow. > >>> > >> > >> Isn't this information alre

Re: [PATCH] build: fix invalid characters in toolchain definitions

2023-02-08 Thread Bruce Richardson
On Tue, Feb 07, 2023 at 03:22:00PM +, Bruce Richardson wrote: > When using "icx" (Intel(R) oneAPI DPC++/C++ Compiler) to build DPDK, > meson reports the toolchain as "intel-llvm"[1]. This value is used > directly to define the RTE_TOOLCHAIN macros, which means that we end up > with the invalid

[PATCH v11 0/6] add trace points in ethdev library

2023-02-08 Thread Ankur Dwivedi
This series adds trace points for functions in the ethdev library. The trace points are added in ethdev, flow, mtr and tm files. v11: - Added rte_trace_point_emit_blob to capture mac address list in rte_ethdev_trace_set_mc_addr_list tracepoint. - Added ack by Ori in patch (4/6) ethdev: add

[PATCH v11 1/6] eal: trace: add trace point emit for blob

2023-02-08 Thread Ankur Dwivedi
Adds a trace point emit function for capturing a blob. The blob captures the length passed by the application followed by the array. The maximum blob bytes which can be captured is bounded by RTE_TRACE_BLOB_LEN_MAX macro. The value for max blob length macro is 64 bytes. If the length is less than

[PATCH v11 2/6] ethdev: add trace points for ethdev (part one)

2023-02-08 Thread Ankur Dwivedi
Adds trace points for ethdev functions. The rte_ethdev_trace.h is removed. The file ethdev_trace.h is added as an internal header. ethdev_trace.h contains internal slow path and fast path tracepoints. The public fast path tracepoints are present in rte_ethdev_trace_fp.h header. Signed-off-by: Ank

[PATCH v11 3/6] ethdev: add trace points for ethdev (part two)

2023-02-08 Thread Ankur Dwivedi
Adds trace points for remaining ethdev functions. Signed-off-by: Ankur Dwivedi Acked-by: Sunil Kumar Kori --- lib/ethdev/ethdev_trace.h| 877 +++ lib/ethdev/ethdev_trace_points.c | 252 + lib/ethdev/rte_ethdev.c | 485 ++--- lib/e

[PATCH v11 4/6] ethdev: add trace points for flow

2023-02-08 Thread Ankur Dwivedi
Adds trace points for rte_flow specific functions in ethdev lib. Signed-off-by: Ankur Dwivedi Acked-by: Ori Kam --- lib/ethdev/ethdev_trace.h| 503 +++ lib/ethdev/ethdev_trace_points.c | 117 +++ lib/ethdev/rte_flow.c| 356 +---

[PATCH v11 5/6] ethdev: add trace points for mtr

2023-02-08 Thread Ankur Dwivedi
Adds trace points for rte_mtr specific functions in ethdev lib. Signed-off-by: Ankur Dwivedi Acked-by: Sunil Kumar Kori --- lib/ethdev/ethdev_trace.h| 206 +++ lib/ethdev/ethdev_trace_points.c | 63 ++ lib/ethdev/rte_mtr.c | 150 +

[PATCH v11 6/6] ethdev: add trace points for tm

2023-02-08 Thread Ankur Dwivedi
Adds trace points for rte_tm specific functions in ethdev lib. Signed-off-by: Ankur Dwivedi --- lib/ethdev/ethdev_trace.h| 304 +++ lib/ethdev/ethdev_trace_points.c | 90 + lib/ethdev/rte_tm.c | 225 --- 3 files change

RE: [PATCH 1/3] examples/l3fwd: validate ptype only for type of traffic sent

2023-02-08 Thread Kamalakshitha Aligeri
Hi all, Can you please check the patch and provide comments? Thanks, Kamalakshitha > -Original Message- > From: Kamalakshitha Aligeri > Sent: Monday, November 14, 2022 1:26 PM > To: jer...@marvell.com; tho...@monjalon.net; > david.march...@redhat.com > Cc: dev@dpdk.org; nd ; Kamalakshith

Re: [PATCH V3 00/10] net/hns3: some bugfixes for rss

2023-02-08 Thread Ferruh Yigit
On 1/31/2023 1:02 PM, Dongdong Liu wrote: > This patchset is to do some bugfixes for hns3 rss. > > v2->v3: > - Fix segmentation fault when key_len is 40 and key is NULL for > [PATCH V2 09/10]. > > v1->v2: > - Fix missing comparison of types and level when verifying duplicate > rules for [PATC

Re: [PATCH] build: fix invalid characters in toolchain definitions

2023-02-08 Thread Tyler Retzlaff
On Tue, Feb 07, 2023 at 03:22:00PM +, Bruce Richardson wrote: > When using "icx" (Intel(R) oneAPI DPC++/C++ Compiler) to build DPDK, > meson reports the toolchain as "intel-llvm"[1]. This value is used > directly to define the RTE_TOOLCHAIN macros, which means that we end up > with the invalid

Re: [PATCH] bnxt: fix unwanted interrupt config on link state change

2023-02-08 Thread Ajit Khaparde
On Mon, Feb 6, 2023 at 9:44 PM Somnath Kotur wrote: > > On Mon, Feb 6, 2023 at 10:44 PM wrote: > > > > From: Edwin Brossette > > > > When getting the device's info via bnxt_dev_info_get_op(), the device > > enables interrupts on link state changes because of the following line: > > > > > eth_d

Re: [PATCH v3] net/af_xdp: AF_XDP PMD CNI Integration

2023-02-08 Thread Ferruh Yigit
On 2/2/2023 4:55 PM, Shibin Koikkara Reeny wrote: > Integrate support for the AF_XDP CNI and device plugin [1] so that the > DPDK AF_XDP PMD can work in an unprivileged container environment. > Part of the AF_XDP PMD initialization process involves loading > an eBPF program onto the given netdev. T

Re: [PATCH v11 3/6] ethdev: add trace points for ethdev (part two)

2023-02-08 Thread Ferruh Yigit
On 2/8/2023 5:12 PM, Ankur Dwivedi wrote: > Adds trace points for remaining ethdev functions. > > Signed-off-by: Ankur Dwivedi > Acked-by: Sunil Kumar Kori Reviewed-by: Ferruh Yigit

Re: [PATCH v11 0/6] add trace points in ethdev library

2023-02-08 Thread Ferruh Yigit
On 2/8/2023 5:12 PM, Ankur Dwivedi wrote: > This series adds trace points for functions in the ethdev library. > The trace points are added in ethdev, flow, mtr and tm files. > > v11: > - Added rte_trace_point_emit_blob to capture mac address list in >rte_ethdev_trace_set_mc_addr_list tracepo

Re: [PATCH v5] ethdev: add flow rule group description

2023-02-08 Thread Ferruh Yigit
On 2/7/2023 2:57 AM, Rongwei Liu wrote: > Add more sentences to describe the group concepts > and define group 0 as root group for traffic to search a > hit rule. > > Signed-off-by: Rongwei Liu > Acked-by: Ori Kam > --- > lib/ethdev/rte_flow.h | 13 - > 1 file changed, 12 insertions

RE: [PATCH v1 13/13] test/bbdev: remove iteration count check

2023-02-08 Thread Vargas, Hernan
Hi Maxime, We would like to keep the same signature for validate_dec_op because there are functions such as latency_test_dec that have vector_mask on their signatures and they pass it to validate_dec_op. Let me know if you'd like to discuss more. Thanks, Hernan -Original Message- From:

[PATCH v6 3/3] doc: announce deprecation of thread ctrl create function

2023-02-08 Thread Tyler Retzlaff
Notify deprecation of rte_ctrl_thread_create API, it will be removed as it exposes platform-specific thread details. Signed-off-by: Tyler Retzlaff Acked-by: Morten Brørup Acked-by: David Marchand Reviewed-by: Mattias Rönnblom --- doc/guides/rel_notes/deprecation.rst | 8 1 file chang

[PATCH v6 0/3] eal: deprecate last use of pthread_t in public API

2023-02-08 Thread Tyler Retzlaff
Announce deprecation of rte_ctrl_thread_create API which is the final remaining stable API exposing pthread_t. Provide an equivalent replacement API rte_thread_create_control that uses the new rte_thread_t type. Provide a unit test for the new rte_thread_create_control API (test code provided by

[PATCH v6 1/3] eal: add rte thread create control API

2023-02-08 Thread Tyler Retzlaff
Add rte_thread_create_control API as a replacement for rte_ctrl_thread_create to allow deprecation of the use of platform specific types in DPDK public API. Add test from David Marchand to exercise the new API. Signed-off-by: Tyler Retzlaff Acked-by: Morten Brørup Reviewed-by: Mattias Rönnblom

[PATCH v6 2/3] doc: add missing index entry for thread

2023-02-08 Thread Tyler Retzlaff
Add missing thread index referencing rte_thread.h under the basic topic. Signed-off-by: Tyler Retzlaff Reviewed-by: David Marchand --- doc/api/doxy-api-index.md | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/doc/api/doxy-api-index.md b/doc/api/doxy-api-index.md index de48

[PATCH v2] eal: abstract compiler atomics

2023-02-08 Thread Tyler Retzlaff
Introduce an abstraction for compiler specific atomics and a meson option to allow standard C11 atomics use. Note, this series does not attempt to convert to the use of the abstraction it only introduces it as per the plan discussed here. http://mails.dpdk.org/archives/dev/2023-January/258693.html

[PATCH v2] eal: introduce atomics abstraction

2023-02-08 Thread Tyler Retzlaff
Introduce atomics abstraction that permits optional use of standard C11 atomics when meson is provided the new enable_stdatomics=true option. Signed-off-by: Tyler Retzlaff --- config/meson.build | 11 lib/eal/arm/include/rte_atomic_32.h| 6 ++- lib/eal/arm/include/r

[PATCH v2] mailmap: update mailmap entry for second address

2023-02-08 Thread Tyler Retzlaff
Signed-off-by: Tyler Retzlaff --- .mailmap | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.mailmap b/.mailmap index 5015494..9b5c507 100644 --- a/.mailmap +++ b/.mailmap @@ -1358,7 +1358,7 @@ Tsotne Chakhvadze Tudor Brindus Tudor Cornea Tummala Sivaprasad -Tyler Retzl

Re: [PATCH v2] net/sfc: export pick transfer proxy callback to representors

2023-02-08 Thread Ferruh Yigit
On 1/31/2023 11:13 AM, Andrew Rybchenko wrote: > On 1/31/23 14:08, Ivan Malov wrote: >> Currently, the "pick transfer proxy ethdev" callback is only >> advertised for non-representor (in example, main PF) ethdevs. >> That does not sit well with the original idea of this method, >> which is to let a

Re: [PATCH] app/testpmd: fix link check condition on port start

2023-02-08 Thread Ferruh Yigit
On 2/3/2023 9:56 AM, Singh, Aman Deep wrote: > > On 1/28/2023 4:15 AM, Ferruh Yigit wrote: >> In testpmd port start function, 'need_check_link_status' variable is >> used to detect if a link check is required after port is started. >> >> Intention is if at least one port is started, link check sho

  1   2   >