On 2/9/2023 8:01 AM, Ori Kam wrote:
> Hi Rongwei,
>
>> -Original Message-
>> From: Rongwei Liu
>> Sent: Thursday, 9 February 2023 9:33
>>
>> Add more sentences to describe the group concepts
>> and define group 0 as root group for traffic to search a
>> hit rule.
>>
>> Signed-off-by: Rong
> From: Feifei Wang [mailto:feifei.wa...@arm.com]
> Sent: Thursday, 9 February 2023 11.59
>
> Hi, Morten
>
> > 发件人: Morten Brørup
> > 发送时间: Thursday, February 9, 2023 5:34 PM
> >
> > > From: Kamalakshitha Aligeri [mailto:kamalakshitha.alig...@arm.com]
> > > Sent: Thursday, 9 February 2023 07.25
> -Original Message-
> From: Ferruh Yigit
> Sent: Wednesday, February 8, 2023 6:31 PM
> To: Koikkara Reeny, Shibin ;
> dev@dpdk.org; Zhang, Qi Z ; Burakov, Anatoly
> ; Richardson, Bruce
> ; Mcnamara, John
>
> Cc: Loftus, Ciara
> Subject: Re: [PATCH v3] net/af_xdp: AF_XDP PMD CNI Integr
On Wed, Feb 8, 2023 at 10:26 PM Tyler Retzlaff
wrote:
>
> Announce deprecation of rte_ctrl_thread_create API which is the final
> remaining stable API exposing pthread_t.
>
> Provide an equivalent replacement API rte_thread_create_control that
> uses the new rte_thread_t type.
>
> Provide a unit t
Integrate support for the AF_XDP CNI and device plugin [1] so that the
DPDK AF_XDP PMD can work in an unprivileged container environment.
Part of the AF_XDP PMD initialization process involves loading
an eBPF program onto the given netdev. This operation requires
privileges, which prevents the PMD
On 2/9/23 10:16, Maxime Coquelin wrote:
This series introduces control queue support for Vhost-vDPA
backend. This is a requirement to support multiqueue, but
be usefull for other features like RSS for example.
Since the Virtio-user layer of the Virtio PMD must handle
some control messages, li
On 2/7/23 17:22, Maxime Coquelin wrote:
This two-patches series fix possible FD leaks when
receiving Vhost-user messages fails. It also improve
logging by differentiating message's buffer truncation
and control data truncation.
Changes in v3:
==
- Improve logs on error (David)
Ma
On 2/6/23 16:07, Maxime Coquelin wrote:
This patch changes VHOST_USER_SET_VRING_ERR and
VHOST_USER_SET_LOG_FD "not implemented" log levels from
INFO to DEBUG, as implementing these requests is not
mandatory. Having them being displayed at INFO level
may induce some confusion to the end-user.
Add SDP packet mode to support EP driver in loop
and NIC mode.
Signed-off-by: Sathesh Edara
---
drivers/net/octeon_ep/otx2_ep_vf.h| 2 +-
drivers/net/octeon_ep/otx_ep_common.h | 30 ++-
drivers/net/octeon_ep/otx_ep_ethdev.c | 20 --
drivers/net/octeon
Add a validation test suite that helps in verifying that the output
generated by two different cryptodevs match for a wide range of input
parameter combinations.
Crypto autotest performs a comprehensive testing of the cryptodev but since
it performs verification by comparing against known vectors,
Alarm and multiprocess hotplug still need access hugepage memory,
if alarm event processed after memory detach, it may cause SEGV.
So cleanup alarm and multiprocess hotplug before memory detach.
Fixes: 90b13ab8d4f7 ("alarm: remove direct access to interrupt handle")
Fixes: a0cc7be20dd1 ("mem: clea
On 2/4/2023 2:57 AM, lihuisong (C) wrote:
>
> 在 2023/2/3 20:58, Ferruh Yigit 写道:
>> On 2/3/2023 1:56 AM, lihuisong (C) wrote:
>>> 在 2023/2/3 5:10, Thomas Monjalon 写道:
02/02/2023 19:09, Ferruh Yigit:
> On 2/2/2023 12:36 PM, Huisong Li wrote:
>> The dev->data->mac_addrs[0] will be chang
On 2/9/2023 9:04 AM, Bruce Richardson wrote:
> On Wed, Feb 08, 2023 at 01:43:38PM -0800, Tyler Retzlaff wrote:
>> Introduce atomics abstraction that permits optional use of standard C11
>> atomics when meson is provided the new enable_stdatomics=true option.
>>
>> Signed-off-by: Tyler Retzlaff
>>
On 2/5/2023 1:41 PM, Leo Xu wrote:
> Currently, rte_flow API does not support matching
> ID and sequence fields of icmp6 echo packets.
>
> This patchset is used to support match icmpv6 ID and
> sequence in rte_flow. It adds needed API in rte_flow,
> and gives corresponding implementation for mlx5
During the bus scan, memory for device configuration is allocated.
Currently, if a driver wasn't attached to the device during initialization,
memory for that device will not be released at bus cleanup.
This patch address this issue and releases the memory for all allocated
devices.
Fixes: 1cab1a4
The internal tracepoints of a library are not needed to be exported in
version.map file, as they will not be called from outside the library.
Only the tracepoints called from a public function need to be exported
in version.map. This patch removes the internal tracepoints from
version.map for mempo
The file rte_mempool_trace.h contains tracepoints which are internal to the
mempool library. This file is renamed to mempool_trace.h, and is made an
internal header. The tracepoints in this file are removed from the
experimental section in version.map file.
Signed-off-by: Ankur Dwivedi
---
.../{
The file rte_cryptodev_trace.h contains tracepoints which are internal to
the cryptodev library. This file is renamed to cryptodev_trace.h, and is
made an internal header. The tracepoints in this file are removed from the
experimental and internal section in version.map file.
Signed-off-by: Ankur
The file rte_eal_trace.h contains some tracepoints which are internal to
the eal library. Those tracepoints are moved to a new file
eal_trace_internal.h. The internal tracepoints are removed from the
version.map file.
Signed-off-by: Ankur Dwivedi
---
lib/eal/common/eal_common_launch.c |
The internal trcepoints are removed from the version.map file.
Signed-off-by: Ankur Dwivedi
---
lib/ethdev/version.map | 6 --
1 file changed, 6 deletions(-)
diff --git a/lib/ethdev/version.map b/lib/ethdev/version.map
index 17201fbe0f..d8e9941356 100644
--- a/lib/ethdev/version.map
+++ b/l
The internal tracepoints are removed from the version.map file.
Signed-off-by: Ankur Dwivedi
---
lib/eventdev/version.map | 30 --
1 file changed, 30 deletions(-)
diff --git a/lib/eventdev/version.map b/lib/eventdev/version.map
index 3add5e3088..9153c09b42 100644
---
On Tue, Feb 7, 2023 at 11:45 AM David Marchand
wrote:
>
> vhost internals involves multiple locks to protect data access by
> multiple threads.
>
> This series uses clang thread safety checks [1] to catch issues during
> compilation: EAL spinlock, seqlock and rwlock are annotated and vhost
> code
On 2/9/2023 1:30 PM, Ankur Dwivedi wrote:
> The internal trcepoints are removed from the version.map file.
>
> Signed-off-by: Ankur Dwivedi
> ---
> lib/ethdev/version.map | 6 --
> 1 file changed, 6 deletions(-)
>
> diff --git a/lib/ethdev/version.map b/lib/ethdev/version.map
> index 17201f
On Thu, Feb 9, 2023 at 2:30 PM Ankur Dwivedi wrote:
>
> The file rte_mempool_trace.h contains tracepoints which are internal to the
> mempool library. This file is renamed to mempool_trace.h, and is made an
> internal header. The tracepoints in this file are removed from the
This patch also expor
Add a validation test suite that helps in verifying that the output
generated by two different cryptodevs match for a wide range of input
parameter combinations.
Crypto autotest performs a comprehensive testing of the cryptodev but since
it performs verification by comparing against known vectors,
Zero-copy access to mempool caches is beneficial for PMD performance, and
must be provided by the mempool library to fix [Bug 1052] without a
performance regression.
[Bug 1052]: https://bugs.dpdk.org/show_bug.cgi?id=1052
Bugzilla ID: 1052
Signed-off-by: Morten Brørup
Acked-by: Konstantin Ananye
Hi Slava
> -Original Message-
> From: Slava Ovsiienko
> Sent: Tuesday, 7 February 2023 16:02
>
> The RTE Flow API implements the concept of shared objects,
> known as indirect actions (RTE_FLOW_ACTION_TYPE_INDIRECT).
> An application can create the indirect action of desired
> type and c
Hi Slava,
> -Original Message-
> From: Slava Ovsiienko
> Sent: Tuesday, 7 February 2023 16:02
>
> Host port id parameter is added to "flow configure" command.
>
> Signed-off-by: Viacheslav Ovsiienko
> ---
Acked-by: Ori Kam
Best,
Ori
Hi Slava,
> -Original Message-
> From: Slava Ovsiienko
> Sent: Tuesday, 7 February 2023 16:02
> Subject: [PATCH v2 3/9] app/testpmd: add shared indirect action support
>
> The shared indirect action can be shared between ports,
> action should be created on single port and the handle
> c
Hi Slava,
> -Original Message-
> From: Slava Ovsiienko
> Sent: Tuesday, 7 February 2023 16:02
>
> The patch updates the Release Notes and documentation
> for the indirect RTE Flow actions as shared ones between
> ports on the same physical NIC.
>
> Signed-off-by: Viacheslav Ovsiienko
>
On 2/6/2023 3:39 AM, Rongwei Liu wrote:
> Support flex item matching and modify field in async flow.
> Syntax follows sync flow exactly.
>
> v4: split ethdev part.
> v3: enhance format, add flex_handle document.
>
> Rongwei Liu (4):
> ethdev: add flex item modify field support
> app/testpmd:
Hi Rakesh,
> -Original Message-
> From: Rakesh Kudurumalla
> Sent: Thursday, 9 February 2023 10:36
> Subject: [PATCH v4 1/3] ethdev: skip congestion management configuration
>
> Introduce new flow action to skip congestion management configuration
> This feature helps to skip the congest
Zero-copy access to mempool caches is beneficial for PMD performance, and
must be provided by the mempool library to fix [Bug 1052] without a
performance regression.
[Bug 1052]: https://bugs.dpdk.org/show_bug.cgi?id=1052
Bugzilla ID: 1052
Signed-off-by: Morten Brørup
Acked-by: Konstantin Ananye
Zero-copy access to mempool caches is beneficial for PMD performance, and
must be provided by the mempool library to fix [Bug 1052] without a
performance regression.
[Bug 1052]: https://bugs.dpdk.org/show_bug.cgi?id=1052
Bugzilla ID: 1052
Signed-off-by: Morten Brørup
Acked-by: Konstantin Ananye
On 2/2/2023 1:47 PM, Gregory Etelson wrote:
> Current API allows either query or update indirect flow action.
> If indirect action must be conditionally updated according to it's
> present state application must first issue action query then
> analyze returned data and if needed issue update reques
The software timer adapter converts event timer timeout ticks to a
number of TSC cycles at which an rte_timer should expire. The
computation uses an integer multiplication that can result in overflow.
If necessary, reduce the timeout_nsecs value by the number of whole
seconds it contains to keep t
On 2/6/2023 3:39 AM, Rongwei Liu wrote:
> diff --git a/doc/guides/rel_notes/release_23_03.rst
> b/doc/guides/rel_notes/release_23_03.rst
> index c15f6fbb9f..3fb6e738e2 100644
> --- a/doc/guides/rel_notes/release_23_03.rst
> +++ b/doc/guides/rel_notes/release_23_03.rst
> @@ -69,6 +69,10 @@ New Feat
Hello Ferruh,
[]
>
> it seems there were some comments from Andrew to previous version, are
> they resolved now?
>
I resolved all outstanding comments
> @Andrew, do you have any objection/comment on this version?
Regards,
Gregory
On Thu, 9 Feb 2023 08:45:20 +
Mingxia Liu wrote:
> The patchset introduced the cpfl (Control Plane Function Library) PMD
> for Intel® IPU E2100’s Configure Physical Function (Device ID: 0x1453)
>
> The cpfl PMD inherits all the features from idpf PMD which will follow
> an ongoing standard
On Thu, Jan 19, 2023 at 11:16 AM Owen Hilyard wrote:
> Everything looks good to me with the exception of some issues I ran into
> with terminal codes. Setting TERM=dumb before running fixed it, but we
> might want to set that inside of DTS since I can't think of a reason why we
> would need color
On Thu, 9 Feb 2023 10:13:41 +0100
David Marchand wrote:
> Stephen, Reshma,
>
> On Fri, Feb 3, 2023 at 9:19 AM Amit Prakash Shukla
> wrote:
> >
> > This change enhances rte_pcapng_copy to have comment in enhanced
> > packet block.
> >
> > Signed-off-by: Amit Prakash Shukla
>
> Is this change
PING bnx2x maintainers. Care to review this bugfix, so it can be included in
23.03?
> From: Morten Brørup [mailto:m...@smartsharesystems.com]
> Sent: Monday, 16 January 2023 14.07
>
> Bugfix: The vlan in the bulletin does not contain a VLAN header, only
> the
> VLAN ID, so only copy 2 byte, not
On Fri, Nov 4, 2022 at 5:16 AM Juraj Linkeš
wrote:
> Adding folks I forgot to add.
>
> > -Original Message-
> > From: Juraj Linkeš
> > Sent: Thursday, November 3, 2022 2:47 PM
> > Cc: dev@dpdk.org; Juraj Linkeš
> > Subject: [PATCH v1] dts: add Dockerfile
> >
> > The Dockerfile defines d
PING dlb2 maintainers. Care to review this, so it can be included in 23.03?
> From: Morten Brørup [mailto:m...@smartsharesystems.com]
> Sent: Monday, 16 January 2023 14.07
>
> Copying with the same src and dst address has no effect; removed to
> avoid compiler warning with decorated rte_memcpy.
>
PING mlx5 maintainers. Care to review this minor improvement, so it can be
included in 23.03?
> From: Morten Brørup [mailto:m...@smartsharesystems.com]
> Sent: Monday, 16 January 2023 14.07
>
> Use RTE_PTR_ADD where copying to the offset of a field in a structure
> holding multiple fields, to av
The adapter configuration parameters defined in the
``struct rte_event_eth_rx_adapter_runtime_params`` can be configured
and retrieved using ``rte_event_eth_rx_adapter_runtime_params_set`` and
``rte_event_eth_tx_adapter_runtime_params_get`` respectively.
Signed-off-by: Naga Harish K S V
---
app/
The adapter runtime configuration parameters defined in the
``struct rte_event_crypto_adapter_runtime_params`` can be configured
and retrieved using ``rte_event_crypto_adapter_runtime_params_set``
and ``rte_event_eth_rx_adapter_runtime_params_get`` respectively.
Signed-off-by: Naga Harish K S V
-
The adapter configuration parameters defined in the
``struct rte_event_eth_tx_adapter_runtime_params`` can be
configured and retrieved using
``rte_event_eth_tx_adapter_runtime_params_set`` and
``rte_event_eth_tx_adapter_runtime_params_get`` respectively.
Signed-off-by: Naga Harish K S V
---
app/
Hi Maxime,
> -Original Message-
> From: Maxime Coquelin
> Sent: Thursday, February 9, 2023 1:11 AM
> To: Vargas, Hernan ; dev@dpdk.org;
> gak...@marvell.com; Rix, Tom
> Cc: Chautru, Nicolas ; Zhang, Qi Z
>
> Subject: Re: [PATCH v1 13/13] test/bbdev: remove iteration count check
>
>
>
> -Original Message-
> From: Jerin Jacob
> Sent: Monday, February 6, 2023 10:08 PM
> To: Naga Harish K, S V
> Cc: jer...@marvell.com; Carrillo, Erik G ; Gujjar,
> Abhinandan S ; dev@dpdk.org;
> Jayatheerthan, Jay
> Subject: Re: [PATCH v2 1/3] eventdev/eth_rx: add params set/get APIs
>
This is split out of other rte_log patchset.
The DPDK libraries and drivers should not be using the USER1 logtype.
v2 - fix some compile warnings
Stephen Hemminger (5):
ip_frag: use a dynamic logtype
reorder: use a dynamic logtype
latencystats: use dynamic logtype
vhost: use logtype inste
DPDK libraries should not be reusing RTE_LOGTYPE_USER1 in
lieu of doing proper logtype registration.
Acked-by: Konstantin Ananyev
Fixes: 416707812c03 ("ip_frag: refactor reassembly code into a proper library")
Signed-off-by: Stephen Hemminger
---
lib/ip_frag/ip_frag_common.h | 16 ++-
lib
Libraries should not be reusing RTE_LOGTYPE_USER1 instead
of doing proper logtype registration.
Fixes: b70b56032bff ("reorder: new library")
Cc: sergio.gonzalez.mon...@intel.com
Signed-off-by: Stephen Hemminger
---
lib/reorder/rte_reorder.c | 35 +++
1 file change
Fix instances of USER1 logtype in fdset and crypto
sections.
Acked-by: Chenbo Xia
Signed-off-by: Stephen Hemminger
---
lib/vhost/fd_man.c | 16 +---
lib/vhost/vhost_crypto.c | 25 +++--
2 files changed, 20 insertions(+), 21 deletions(-)
diff --git a/lib/vh
Libraries should not reuse RTE_LOGTYPE_USER1 for their
logging. Instead they should register their own type.
Fixes: 5cd3cac9ed22 ("latency: added new library for latency stats")
Cc: reshma.pat...@intel.com
Signed-off-by: Stephen Hemminger
---
lib/latencystats/rte_latencystats.c | 55
There already is a logtype in this driver, use it!
Fixes: b35848bc01f6 ("crypto/ipsec_mb: add multi-process IPC request handler")
Cc: kai...@intel.com
Signed-off-by: Stephen Hemminger
---
drivers/crypto/ipsec_mb/ipsec_mb_ops.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a
On Thu, Feb 9, 2023 at 2:06 PM Rakesh Kudurumalla
wrote:
>
> Dropping of packets is based on action configured
> to meter.If both skip_red and drop actions are configured
> then tail dropping in invoked else if only drop action is
> configured then RED drop is invoked.This action is supported
> on
On Thu, Feb 9, 2023 at 3:54 PM Amit Prakash Shukla
wrote:
>
> Added support to configure pcap capture.
>
> Signed-off-by: Amit Prakash Shukla
Acked-by: Jerin Jacob
> ---
> v2:
> - Fixed code style issue
> - Fixed CI compilation issue on github-robot
>
> v3:
> - Code review suggestion from
On Thu, Feb 09, 2023 at 12:16:38AM +, Honnappa Nagarahalli wrote:
>
>
> > > > > >
> > > > > > >
> > > > > > > For environments where stdatomics are not supported, we could
> > > > have a
> > > > > > stdatomic.h in DPDK implementing the same APIs (we have to
> > > > > > support
> > > > only
>
On Thu, Feb 09, 2023 at 09:04:16AM +, Bruce Richardson wrote:
> On Wed, Feb 08, 2023 at 01:43:38PM -0800, Tyler Retzlaff wrote:
> > Introduce atomics abstraction that permits optional use of standard C11
> > atomics when meson is provided the new enable_stdatomics=true option.
> >
> > Signed-o
On Thu, Feb 09, 2023 at 12:53:41PM +, Ferruh Yigit wrote:
> On 2/9/2023 9:04 AM, Bruce Richardson wrote:
> > On Wed, Feb 08, 2023 at 01:43:38PM -0800, Tyler Retzlaff wrote:
> >> Introduce atomics abstraction that permits optional use of standard C11
> >> atomics when meson is provided the new e
On Thu, Feb 09, 2023 at 09:05:46AM +0100, Morten Brørup wrote:
> > From: Tyler Retzlaff [mailto:roret...@linux.microsoft.com]
> > Sent: Wednesday, 8 February 2023 22.44
> >
> > Introduce atomics abstraction that permits optional use of standard C11
> > atomics when meson is provided the new enable
Acked: by abdullah.sevin...@intel.com
-Original Message-
From: Morten Brørup
Sent: Thursday, February 9, 2023 8:51 AM
To: dev@dpdk.org; roret...@linux.microsoft.com; rm...@marvell.com; McDaniel,
Timothy ; ma...@nvidia.com; viachesl...@nvidia.com
Cc: ruifeng.w...@arm.com; zhou...@loongso
Hello Andrew,
> On 2/2/23 14:54, Gregory Etelson wrote:
> > diff --git a/lib/ethdev/rte_flow.c b/lib/ethdev/rte_flow.c
> > index 7d0c24366c..4554c8f021 100644
> > --- a/lib/ethdev/rte_flow.c
> > +++ b/lib/ethdev/rte_flow.c
> > @@ -1883,3 +1883,85 @@ rte_flow_async_action_handle_query(uint16_t
> po
> From: Tyler Retzlaff [mailto:roret...@linux.microsoft.com]
> Sent: Thursday, 9 February 2023 19.15
>
> On Thu, Feb 09, 2023 at 09:05:46AM +0100, Morten Brørup wrote:
> > > From: Tyler Retzlaff [mailto:roret...@linux.microsoft.com]
> > > Sent: Wednesday, 8 February 2023 22.44
> > >
> > > Introduc
On 2/3/2023 1:33 PM, Jiawei Wang wrote:
> When multiple physical ports are connected to a single DPDK port,
> (example: kernel bonding, DPDK bonding, failsafe, etc.),
> we want to know which physical port is used for Rx and Tx.
>
I assume "kernel bonding" is out of context, but this patch concern
On Thu, Feb 09, 2023 at 08:19:14PM +0100, Morten Brørup wrote:
> > From: Tyler Retzlaff [mailto:roret...@linux.microsoft.com]
> > Sent: Thursday, 9 February 2023 19.15
> >
> > On Thu, Feb 09, 2023 at 09:05:46AM +0100, Morten Brørup wrote:
> > > > From: Tyler Retzlaff [mailto:roret...@linux.microso
On 2/9/2023 5:40 PM, Tyler Retzlaff wrote:
> On Thu, Feb 09, 2023 at 12:53:41PM +, Ferruh Yigit wrote:
>> On 2/9/2023 9:04 AM, Bruce Richardson wrote:
>>> On Wed, Feb 08, 2023 at 01:43:38PM -0800, Tyler Retzlaff wrote:
Introduce atomics abstraction that permits optional use of standard C11
Hi,
Series of mainly fixes for corner-cases and protection
in the VRB PMD.
The last 2 commits are not fixes but add support for
missing minor capability, as well as a request to remove printf
from code (function called from bbdev-test).
Thanks
Nic
Nicolas Chautru (9):
baseband/acc: protection
Implementation to support the case when using LTE
decoder with soft output and transport block mode.
Fixes: bec597b78a0 ("baseband/acc200: add LTE processing")
Cc: sta...@dpdk.org
Signed-off-by: Nicolas Chautru
---
drivers/baseband/acc/rte_vrb_pmd.c | 21 +++--
1 file changed, 1
Adding handling of negative scenario for malformed
Transport Block mode operations.
Fixes: bec597b78a0 ("baseband/acc200: add LTE processing")
Cc: sta...@dpdk.org
Signed-off-by: Nicolas Chautru
---
drivers/baseband/acc/rte_vrb_pmd.c | 20
1 file changed, 20 insertions(+)
d
Adding an explicit mbuf append in the case of soft output
mbuf being provided.
Fixes: e640f6cdfa84 ("baseband/acc200: add LDPC processing")
Cc: sta...@dpdk.org
Signed-off-by: Nicolas Chautru
---
drivers/baseband/acc/rte_vrb_pmd.c | 4
1 file changed, 4 insertions(+)
diff --git a/drivers/b
Not enabling interrupt in VRB1 PMD variant to avoid
potential corner case.
Fixes: 3cabc8eaf524 ("baseband/acc200: support interrupt")
Cc: sta...@dpdk.org
Signed-off-by: Nicolas Chautru
---
drivers/baseband/acc/rte_vrb_pmd.c | 8
1 file changed, 8 insertions(+)
diff --git a/drivers/bas
Add support for corner-case when more operations are
requested than expected, in the case of encoder muxing
operations.
Fixes: e640f6cdfa84 ("baseband/acc200: add LDPC processing")
Cc: sta...@dpdk.org
Signed-off-by: Nicolas Chautru
---
drivers/baseband/acc/rte_vrb_pmd.c | 27 +++
The iteration count was not using correct structure (4G vs 5G)
in TB mode.
Fixes: bec597b78a0 ("baseband/acc200: add LTE processing")
Cc: sta...@dpdk.org
Signed-off-by: Nicolas Chautru
---
drivers/baseband/acc/rte_vrb_pmd.c | 10 +++---
1 file changed, 7 insertions(+), 3 deletions(-)
diff
Adding support for the capability to drop the CRC24B
when using the turbo-decoder.
Signed-off-by: Nicolas Chautru
---
drivers/baseband/acc/rte_vrb_pmd.c | 9 +++--
1 file changed, 7 insertions(+), 2 deletions(-)
diff --git a/drivers/baseband/acc/rte_vrb_pmd.c
b/drivers/baseband/acc/rte_vrb
Coverity issue: 383154
Fixes: 8e16839937 ("baseband/acc: extension of the device structure")
Cc: sta...@dpdk.org
Signed-off-by: Nicolas Chautru
---
drivers/baseband/acc/rte_vrb_pmd.c | 2 +-
drivers/baseband/acc/vrb_pmd.h | 1 +
2 files changed, 2 insertions(+), 1 deletion(-)
diff --git a/d
Replacing usage of printf in companion function for
bbdev-test by rte_log.
Signed-off-by: Nicolas Chautru
---
drivers/baseband/acc/rte_acc100_pmd.c | 18 +-
drivers/baseband/acc/rte_vrb_pmd.c| 2 +-
2 files changed, 10 insertions(+), 10 deletions(-)
diff --git a/drivers/bas
On 2/9/2023 3:07 AM, Chengwen Feng wrote:
> The number of xstats may be large, after the hide zero option is added,
> only non-zero values can be displayed.
>
Hi Chengwen,
No objection on the functionality, we have similar config option in
testpmd too, but I have some question on telemetry side
The DPDK libraries and drivers should not be using the USER1 logtype.
v3 - fix typo in ip_frag
v2 - fix some compiler warnings
Stephen Hemminger (5):
ip_frag: use a dynamic logtype
reorder: use a dynamic logtype
latencystats: use dynamic logtype
vhost: use logtype instead of RTE_LOGTYPE_U
DPDK libraries should not be reusing RTE_LOGTYPE_USER1 in
lieu of doing proper logtype registration.
Acked-by: Konstantin Ananyev
Fixes: 416707812c03 ("ip_frag: refactor reassembly code into a proper library")
Signed-off-by: Stephen Hemminger
---
lib/ip_frag/ip_frag_common.h | 16 ++-
lib
Libraries should not be reusing RTE_LOGTYPE_USER1 instead
of doing proper logtype registration.
Fixes: b70b56032bff ("reorder: new library")
Cc: sergio.gonzalez.mon...@intel.com
Signed-off-by: Stephen Hemminger
---
lib/reorder/rte_reorder.c | 35 +++
1 file change
Libraries should not reuse RTE_LOGTYPE_USER1 for their
logging. Instead they should register their own type.
Fixes: 5cd3cac9ed22 ("latency: added new library for latency stats")
Cc: reshma.pat...@intel.com
Signed-off-by: Stephen Hemminger
---
lib/latencystats/rte_latencystats.c | 55
Fix instances of USER1 logtype in fdset and crypto
sections.
Acked-by: Chenbo Xia
Signed-off-by: Stephen Hemminger
---
lib/vhost/fd_man.c | 16 +---
lib/vhost/vhost_crypto.c | 25 +++--
2 files changed, 20 insertions(+), 21 deletions(-)
diff --git a/lib/vh
There already is a logtype in this driver, use it!
Fixes: b35848bc01f6 ("crypto/ipsec_mb: add multi-process IPC request handler")
Cc: kai...@intel.com
Signed-off-by: Stephen Hemminger
---
drivers/crypto/ipsec_mb/ipsec_mb_ops.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a
On Thu, Feb 09, 2023 at 10:13:41PM +, Ferruh Yigit wrote:
> On 2/9/2023 5:40 PM, Tyler Retzlaff wrote:
> > On Thu, Feb 09, 2023 at 12:53:41PM +, Ferruh Yigit wrote:
> >> On 2/9/2023 9:04 AM, Bruce Richardson wrote:
> >>> On Wed, Feb 08, 2023 at 01:43:38PM -0800, Tyler Retzlaff wrote:
>
This patchset removes the main uses of static LOGTYPE's in DPDK
libraries. It starts with the easy one and goes on to the more complex ones.
It does not address the larger effort which is the eal,
eventdev, cryptodev, and pmd log types.
Mostly this is semi-automatic conversion but some places lik
If a large packet is passed into GSO routines of unknown protocol
then library would log a message and pass it through. This is incorrect
behaviour on many levels:
- it allows oversize packet to get passed on to NIC driver
- no direct return is visible to applications
- if it happens once, ma
The timer code does not use rte_log.
Signed-off-by: Stephen Hemminger
---
lib/eal/common/eal_common_log.c | 1 -
lib/eal/include/rte_log.h | 2 +-
2 files changed, 1 insertion(+), 2 deletions(-)
diff --git a/lib/eal/common/eal_common_log.c b/lib/eal/common/eal_common_log.c
index c369154cb
Replace all uses of global logtype with a local log type.
Do not break message formats across source lines.
Signed-off-by: Stephen Hemminger
---
lib/eal/common/eal_common_log.c | 1 -
lib/eal/include/rte_log.h | 2 +-
lib/efd/rte_efd.c | 106 +++---
Introduce a new dynamic logtype for mbuf related messages.
Since this is used in multiple files put one macro in mbuf_log.h
Signed-off-by: Stephen Hemminger
---
lib/eal/common/eal_common_log.c | 1 -
lib/eal/include/rte_log.h | 2 +-
lib/mbuf/mbuf_log.h | 10 ++
lib/m
Get rid of RTE_LOGTYPE_ACL and RTE_LOGTYPE_MALLOC.
For ACL library use a dynamic type.
The one message using RTE_LOGTYPE_MALLOC should have been
under the ACL logtype anyway.
The test code should not have been using fixed log type
so just change that to stderr.
Signed-off-by: Stephen Hemminger
-
Use dynamic log type for power library.
Also replace use of RTE_LOGTYPE_USER1 with lib.power.guest.
Signed-off-by: Stephen Hemminger
---
lib/eal/common/eal_common_log.c| 1 -
lib/eal/include/rte_log.h | 2 +-
lib/power/guest_channel.c | 48 +
lib/power/power_ac
The logtype for ring only used in library.
Signed-off-by: Stephen Hemminger
---
lib/eal/common/eal_common_log.c | 1 -
lib/eal/include/rte_log.h | 2 +-
lib/ring/rte_ring.c | 31 +++
3 files changed, 20 insertions(+), 14 deletions(-)
diff --git a/
Convert from RTE_LOGTYPE_MEMPOOL to logtype_mempool.
Signed-off-by: Stephen Hemminger
---
lib/eal/common/eal_common_log.c | 1 -
lib/eal/include/rte_log.h | 2 +-
lib/mempool/rte_mempool.c | 33 ++---
lib/mempool/rte_mempool_log.h | 10 ++
lib/
Split lpm and lpm6 into separate log types since they
are in different files and user may want to change log
levels for IPv4 vs IPv6.
For rib and fib libraries give them own types as well.
Signed-off-by: Stephen Hemminger
---
lib/eal/common/eal_common_log.c | 1 -
lib/eal/include/rte_log.h
Even though KNI will eventually disappear, fix the
logtype now.
Signed-off-by: Stephen Hemminger
---
lib/eal/common/eal_common_log.c | 1 -
lib/eal/include/rte_log.h | 2 +-
lib/kni/rte_kni.c | 63 ++---
3 files changed, 35 insertions(+), 31 dele
A little more complex here since the one hash library actually
has multiple routines in it. Split up the logtypes for
hash and toeplitz.
The hash crc file has another issue around logging.
It is calling RTE_LOG during a constructor which is maybe
problematic because this will all run before the D
Also can remove unused RTE_LOGTYPE_METER
Signed-off-by: Stephen Hemminger
---
lib/eal/common/eal_common_log.c | 2 -
lib/eal/include/rte_log.h | 4 +-
lib/sched/rte_pie.c | 16 +-
lib/sched/rte_sched.c | 299 +---
lib/sched/rte_sched_l
Split up the single static RTE_LOGTYPE_PORT into separate
sub types for each component: port.ethdev, port.evendev, ...
Signed-off-by: Stephen Hemminger
---
lib/eal/common/eal_common_log.c | 1 -
lib/eal/include/rte_log.h | 2 +-
lib/port/rte_port_ethdev.c | 23 +
lib/port/rt
101 - 200 of 238 matches
Mail list logo
