RE: [EXT] [PATCH 4/9] cryptodev: fix segment fault when parse input args

2023-03-02 Thread Akhil Goyal
> The rte_kvargs_process() was used to parse KV pairs, it also supports > to parse 'only keys' (e.g. socket_id) type. And the callback function > parameter 'value' is NULL when parsed 'only keys'. > > This patch fixes segment fault when parse input args with 'only keys' > (e.g. socket_id,max_nb_qu

RE: [PATCH v4 08/12] app/mldev: enable support for queue pairs and size

2023-03-02 Thread Anup Prabhu
> -Original Message- > From: Srikanth Yalavarthi > Sent: Tuesday, February 7, 2023 9:20 PM > To: Srikanth Yalavarthi > Cc: dev@dpdk.org; Shivah Shankar Shankar Narayan Rao > ; Jerin Jacob Kollanukkaran > ; Anup Prabhu ; Prince Takkar > ; Parijat Shukla > Subject: [PATCH v4 08/12] app/m

[Bug 1172] hash: return value is different from the description

2023-03-02 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=1172 Bug ID: 1172 Summary: hash: return value is different from the description Product: DPDK Version: 23.03 Hardware: All OS: All Status: UNCONFIRMED Severity: normal

RE: [PATCH v1 04/13] graph: add get/set graph worker model APIs

2023-03-02 Thread Yan, Zhirun
> -Original Message- > From: Jerin Jacob > Sent: Monday, February 27, 2023 6:23 AM > To: Yan, Zhirun > Cc: dev@dpdk.org; jer...@marvell.com; kirankum...@marvell.com; > ndabilpu...@marvell.com; Liang, Cunming ; > Wang, Haiyue > Subject: Re: [PATCH v1 04/13] graph: add get/set graph work

Re: [PATCH v2 00/20] Enable lock annotations on most libraries and drivers

2023-03-02 Thread David Marchand
On Mon, Feb 27, 2023 at 5:13 PM Gaëtan Rivet wrote: > Ah ok, so if I understand correctly, DPDK would need to declare some > '__rte_lockable rte_mutex' and associated functions for transparent support, > to wrap above the pthread API. Yes, this is what I had in mind for the mid/long term but it w

Re: [PATCH v2] ethdev: add link speed 400G

2023-03-02 Thread Ferruh Yigit
On 3/1/2023 2:50 PM, Ajit Khaparde wrote: > On Wed, Mar 1, 2023 at 3:16 AM Thomas Monjalon wrote: >> >> There are some devices supporting 400G speed, >> and it is well standardized in IEEE. >> >> Signed-off-by: Thomas Monjalon >> Reviewed-by: Morten Brørup >> Acked-by: Andrew Rybchenko >> Acked

Re: [PATCH 0/9] fix kvargs callback prototype not clearly defined

2023-03-02 Thread fengchengwen
Sorry to resend, because the original v1 --cc-cmd failed. On 2023/3/2 15:50, Chengwen Feng wrote: > The rte_kvargs_process() was used to parse KV pairs, it also supports > to parse 'only keys' (e.g. socket_id) type. And the callback function > parameter 'value' is NULL when parsed 'only keys'. >

Re: [EXT] [PATCH 4/9] cryptodev: fix segment fault when parse input args

2023-03-02 Thread fengchengwen
On 2023/3/2 16:11, Akhil Goyal wrote: >> The rte_kvargs_process() was used to parse KV pairs, it also supports >> to parse 'only keys' (e.g. socket_id) type. And the callback function >> parameter 'value' is NULL when parsed 'only keys'. >> >> This patch fixes segment fault when parse input args wi

Re: [PATCH v2 11/20] net/virtio: annotate lock for guest announce

2023-03-02 Thread David Marchand
On Mon, Feb 27, 2023 at 5:28 PM Maxime Coquelin wrote: > As discussed with David off-list, I think we could simplify and inline > virtio_dev_pause()/virtio_dev_resume() into virtio_notify_peers() since > there are no other users of these functions (see below). I was looking at doing this and, as

RE: [PATCH 11/17] net/iavf: use previous value atomic fetch operations

2023-03-02 Thread Ruifeng Wang
> -Original Message- > From: Tyler Retzlaff > Sent: Thursday, March 2, 2023 8:48 AM > To: dev@dpdk.org > Cc: Honnappa Nagarahalli ; tho...@monjalon.net; > Tyler > Retzlaff > Subject: [PATCH 11/17] net/iavf: use previous value atomic fetch operations > > Use __atomic_fetch_{add,and,or,su

Re: [PATCH v2 11/20] net/virtio: annotate lock for guest announce

2023-03-02 Thread Maxime Coquelin
On 3/2/23 10:26, David Marchand wrote: On Mon, Feb 27, 2023 at 5:28 PM Maxime Coquelin wrote: As discussed with David off-list, I think we could simplify and inline virtio_dev_pause()/virtio_dev_resume() into virtio_notify_peers() since there are no other users of these functions (see below)

Re: [PATCH v8 21/21] net/cpfl: add xstats ops

2023-03-02 Thread Ferruh Yigit
On 3/2/2023 10:35 AM, Mingxia Liu wrote: > Add support for these device ops: > - dev_xstats_get > - dev_xstats_get_names > - dev_xstats_reset > > Signed-off-by: Mingxia Liu <...> > +static int cpfl_dev_xstats_get_names(__rte_unused struct rte_eth_dev *dev, > + s

Re: [PATCH v8 01/21] net/cpfl: support device initialization

2023-03-02 Thread Ferruh Yigit
On 3/2/2023 10:35 AM, Mingxia Liu wrote: > Support device init and add the following dev ops: > - dev_configure > - dev_close > - dev_infos_get > - link_update > - dev_supported_ptypes_get > > Signed-off-by: Mingxia Liu <...> > --- /dev/null > +++ b/doc/guides/nics/cpfl.rst > @@ -0,0 +1,85

Re: [PATCH 02/17] telemetry: use previous value atomic fetch operations

2023-03-02 Thread Bruce Richardson
On Wed, Mar 01, 2023 at 04:47:33PM -0800, Tyler Retzlaff wrote: > Use __atomic_fetch_{add,and,or,sub,xor} instead of > __atomic_{add,and,or,sub,xor}_fetch when we have no interest in the > result of the operation. > > Reduces unnecessary codegen that provided the result of the atomic > operation t

RE: [PATCH v2] net/idpf: refine Rx/Tx queue model info

2023-03-02 Thread Zhang, Qi Z
> -Original Message- > From: Mingxia Liu > Sent: Thursday, March 2, 2023 3:27 AM > To: dev@dpdk.org > Cc: Wu, Jingjing ; Xing, Beilei > ; > Liu, Mingxia > Subject: [PATCH v2] net/idpf: refine Rx/Tx queue model info > > This patch updates queue mode info in struct idpf_adapter. > Usin

[PATCH] vhost: fix vring enable with VDPA

2023-03-02 Thread David Marchand
For VDPA devices, vq are not locked once the device has been configured. But we need to hold the vq lock to check if vhost async is enabled. Combining VDPA and vhost async does not seem to make much sense, so prevent this combination, and only assert the lock is taken when VDPA is not configured o

RE: [PATCH v6] net/i40e: rework maximum frame size configuration

2023-03-02 Thread Zhang, Qi Z
> -Original Message- > From: David Marchand > Sent: Tuesday, February 28, 2023 5:37 PM > To: Zhang, Qi Z > Cc: Su, Simei ; Xing, Beilei ; > Zhang, Yuying ; dev@dpdk.org; Yang, Qiming > ; sta...@dpdk.org; Kevin Traynor > ; Thomas Monjalon > Subject: Re: [PATCH v6] net/i40e: rework maxim

RE: [PATCH 5/5] test/crypto: add chained ZUC256 testcases

2023-03-02 Thread De Lara Guarch, Pablo
Hi Ciara, > -Original Message- > From: Power, Ciara > Sent: Wednesday, March 1, 2023 5:39 PM > To: Akhil Goyal ; Fan Zhang > > Cc: dev@dpdk.org; Ji, Kai ; De Lara Guarch, Pablo > ; Power, Ciara > Subject: [PATCH 5/5] test/crypto: add chained ZUC256 testcases > > Testcases are added for

Re: [EXT] Re: [PATCH v1 1/2] ethdev: fix null pointer dereference

2023-03-02 Thread Ferruh Yigit
On 2/28/2023 4:27 PM, Ferruh Yigit wrote: > On 2/28/2023 3:40 PM, Ankur Dwivedi wrote: >>> -- >>> On 2/23/2023 12:30 PM, Ankur Dwivedi wrote: The speed_fec_capa pointer can be null. So dereferencing the pointer is removed

Re: [PATCH v2] net/idpf: refine Rx/Tx queue model info

2023-03-02 Thread Ferruh Yigit
On 3/2/2023 9:46 AM, Zhang, Qi Z wrote: > > >> -Original Message- >> From: Mingxia Liu >> Sent: Thursday, March 2, 2023 3:27 AM >> To: dev@dpdk.org >> Cc: Wu, Jingjing ; Xing, Beilei >> ; >> Liu, Mingxia >> Subject: [PATCH v2] net/idpf: refine Rx/Tx queue model info >> >> This patch up

RE: [PATCH 0/5] test/crypto: add ZUC256 chained tests

2023-03-02 Thread Dooley, Brian
Hi Ciara, > -Original Message- > From: Ciara Power > Sent: Wednesday 1 March 2023 16:39 > Cc: dev@dpdk.org; Ji, Kai ; De Lara Guarch, Pablo > ; Power, Ciara > Subject: [PATCH 0/5] test/crypto: add ZUC256 chained tests > > This patchset adds chained testcases for each ZUC256 digest size:

RE: [PATCH 3/3] doc/l3fwd: lpm supports IPv4 and IPv6 forwarding

2023-03-02 Thread Ruifeng Wang
> -Original Message- > From: Kamalakshitha Aligeri > Sent: Tuesday, November 15, 2022 5:26 AM > To: jer...@marvell.com; tho...@monjalon.net; david.march...@redhat.com > Cc: dev@dpdk.org; nd ; Kamalakshitha Aligeri > ; > sta...@dpdk.org; Honnappa Nagarahalli > Subject: [PATCH 3/3] doc/l3f

Re: [PATCH v2 04/16] test/bbdev: add timeout for latency tests

2023-03-02 Thread Maxime Coquelin
On 2/28/23 23:37, Chautru, Nicolas wrote: Hi Maxime, -Original Message- From: Maxime Coquelin Sent: Monday, February 27, 2023 1:45 AM To: Vargas, Hernan ; dev@dpdk.org; gak...@marvell.com; Rix, Tom Cc: Chautru, Nicolas ; Zhang, Qi Z Subject: Re: [PATCH v2 04/16] test/bbdev: add ti

Re: [PATCH v3] vhost: fix madvise arguments alignment

2023-03-02 Thread Maxime Coquelin
Hi Mike, On 3/1/23 21:02, Mike Pattrick wrote: The arguments passed to madvise should be aligned to the alignment of the backing memory. Now we keep track of each regions alignment and use then when setting coredump preferences. To facilitate this, a new member was added to rte_vhost_mem_region.

Re: [PATCH] vhost: fix slot index in async split virtqueue Tx

2023-03-02 Thread Maxime Coquelin
On 2/23/23 03:30, Cheng Jiang wrote: The slot_idx in the asynchronous Vhost split virtqueue dequeue data path is supposed to be decreased by 1 when desc_to_mbuf() fails. Fixes: 84d5204310d7 ("vhost: support async dequeue for split ring") Cc: sta...@dpdk.org Signed-off-by: Cheng Jiang ---

Re: [PATCH] net/virtio: deduce IP length for Virtio TSO checksum

2023-03-02 Thread Maxime Coquelin
Hi Boleslav, On 2/16/23 13:35, Boleslav Stankevich wrote: The length of TSO payload could not fit into 16 bits provided by the IPv4 total length and IPv6 payload length fields. Thus, deduce it from the length of the packet. My understanding is this is a fix. If so could you please add the Fixe

RE: [PATCH v2] net/idpf: refine Rx/Tx queue model info

2023-03-02 Thread Zhang, Qi Z
> -Original Message- > From: Ferruh Yigit > Sent: Thursday, March 2, 2023 6:07 PM > To: Zhang, Qi Z ; Liu, Mingxia > ; dev@dpdk.org > Cc: Wu, Jingjing ; Xing, Beilei > Subject: Re: [PATCH v2] net/idpf: refine Rx/Tx queue model info > > On 3/2/2023 9:46 AM, Zhang, Qi Z wrote: > > > > >

Re: [PATCH] vhost: fix vring enable with VDPA

2023-03-02 Thread Maxime Coquelin
On 3/2/23 10:48, David Marchand wrote: For VDPA devices, vq are not locked once the device has been configured. But we need to hold the vq lock to check if vhost async is enabled. Combining VDPA and vhost async does not seem to make much sense, so prevent this combination, and only assert the

[PATCH] event/cnxk: fix SSO return code at fini

2023-03-02 Thread Volodymyr Fialko
dev_fini() can return EAGAIN in case if LF is active(used by other devices). Ignoring return code leads to early free of resources that are still in use. Fixes: 8558dcaa05b8 ("event/cnxk: add build infra and device setup") Cc: sta...@dpdk.org Signed-off-by: Volodymyr Fialko --- drivers/event/cn

RE: [PATCH v8 21/21] net/cpfl: add xstats ops

2023-03-02 Thread Liu, Mingxia
> -Original Message- > From: Ferruh Yigit > Sent: Thursday, March 2, 2023 5:30 PM > To: Liu, Mingxia ; dev@dpdk.org; Xing, Beilei > ; Zhang, Yuying > Subject: Re: [PATCH v8 21/21] net/cpfl: add xstats ops > > On 3/2/2023 10:35 AM, Mingxia Liu wrote: > > Add support for these device ops

RE: [PATCH v8 01/21] net/cpfl: support device initialization

2023-03-02 Thread Liu, Mingxia
> -Original Message- > From: Ferruh Yigit > Sent: Thursday, March 2, 2023 5:31 PM > To: Liu, Mingxia ; dev@dpdk.org; Xing, Beilei > ; Zhang, Yuying > Subject: Re: [PATCH v8 01/21] net/cpfl: support device initialization > > On 3/2/2023 10:35 AM, Mingxia Liu wrote: > > Support device in

[PATCH v3] net/idpf: refine Rx/Tx queue model info

2023-03-02 Thread Mingxia Liu
This patch updates queue mode info in struct idpf_adapter. Using is_rx_singleq_model to diffentiate rx_singq and rx_splitq explicitly, instead of deducing it from pointer values. Signed-off-by: Mingxia Liu --- drivers/common/idpf/idpf_common_device.c | 4 ++-- drivers/common/idpf/idpf_common_dev

RE: [PATCH v2] net/idpf: refine Rx/Tx queue model info

2023-03-02 Thread Liu, Mingxia
> -Original Message- > From: Zhang, Qi Z > Sent: Thursday, March 2, 2023 6:28 PM > To: Ferruh Yigit ; Liu, Mingxia > ; dev@dpdk.org > Cc: Wu, Jingjing ; Xing, Beilei > > Subject: RE: [PATCH v2] net/idpf: refine Rx/Tx queue model info > > > > > -Original Message- > > From: Fer

[PATCH v2] crypto/ccp: fix PCI probing

2023-03-02 Thread David Marchand
This driver has been converted from a vdev driver to a pci driver some time ago. This conversion is buggy as it tries to probe any pci devices present on a system for *each* probe request from the PCI bus. Rely on the passed pci device and only probe what is requested. While at it: - stop copyin

Re: [PATCH v8 01/21] net/cpfl: support device initialization

2023-03-02 Thread Ferruh Yigit
On 3/2/2023 11:24 AM, Liu, Mingxia wrote: > > >> -Original Message- >> From: Ferruh Yigit >> Sent: Thursday, March 2, 2023 5:31 PM >> To: Liu, Mingxia ; dev@dpdk.org; Xing, Beilei >> ; Zhang, Yuying >> Subject: Re: [PATCH v8 01/21] net/cpfl: support device initialization >> >> On 3/2/20

Re: [EXT] [PATCH v1] crypto/ccp: bug fixes for ccp device probe flow

2023-03-02 Thread David Marchand
On Mon, Feb 27, 2023 at 7:29 PM Akhil Goyal wrote: > > > - Fixed flow for probe and initialization of requested ccp devices > > - Removed unnecessary code enumerating for all the PCI devices > > available in the system. > > - Removed ccp_pmd_init_done flag controlling probe and initialization >

RE: [PATCH v8 01/21] net/cpfl: support device initialization

2023-03-02 Thread Xing, Beilei
> -Original Message- > From: Ferruh Yigit > Sent: Thursday, March 2, 2023 5:31 PM > To: Liu, Mingxia ; dev@dpdk.org; Xing, Beilei > ; Zhang, Yuying > Subject: Re: [PATCH v8 01/21] net/cpfl: support device initialization > > On 3/2/2023 10:35 AM, Mingxia Liu wrote: > > Support device in

RE: [PATCH v2] net/idpf: refine Rx/Tx queue model info

2023-03-02 Thread Xing, Beilei
> -Original Message- > From: Liu, Mingxia > Sent: Thursday, March 2, 2023 3:27 AM > To: dev@dpdk.org > Cc: Wu, Jingjing ; Xing, Beilei > ; > Liu, Mingxia > Subject: [PATCH v2] net/idpf: refine Rx/Tx queue model info > > This patch updates queue mode info in struct idpf_adapter. > Usi

RE: [PATCH v8 01/21] net/cpfl: support device initialization

2023-03-02 Thread Xing, Beilei
> -Original Message- > From: Ferruh Yigit > Sent: Thursday, March 2, 2023 7:51 PM > To: Liu, Mingxia ; dev@dpdk.org; Xing, Beilei > ; Zhang, Yuying > Subject: Re: [PATCH v8 01/21] net/cpfl: support device initialization > > On 3/2/2023 11:24 AM, Liu, Mingxia wrote: > > > > > >> -Or

RE: [PATCH 1/5] ethdev: fix race-condition of proactive error handling mode

2023-03-02 Thread Konstantin Ananyev
> In the proactive error handling mode, the PMD will set the data path > pointers to dummy functions and then try recovery, in this period the > application may still invoking data path API. This will introduce a > race-condition with data path which may lead to crash [1]. > > Although the PMD a

RE: [PATCH 3/5] net/bnxt: fix race-condition when report error recovery

2023-03-02 Thread Konstantin Ananyev
> If set data path functions to dummy functions before reports error > recovering event, there maybe a race-condition with data path threads, > this patch fixes it by setting data path functions to dummy functions > only after reports such event. > > Fixes: e11052f3a46f ("net/bnxt: support proac

RE: [PATCH 4/5] net/bnxt: use fp ops setup function

2023-03-02 Thread Konstantin Ananyev
> Use rte_eth_fp_ops_setup() instead of directly manipulating > rte_eth_fp_ops variable. > > Cc: sta...@dpdk.org > > Signed-off-by: Chengwen Feng > --- > drivers/net/bnxt/bnxt_cpr.c| 5 + > drivers/net/bnxt/bnxt_ethdev.c | 5 + > 2 files changed, 2 insertions(+), 8 deletions(-) >

Re: [PATCH v2 11/20] net/virtio: annotate lock for guest announce

2023-03-02 Thread David Marchand
On Thu, Mar 2, 2023 at 10:28 AM Maxime Coquelin wrote: > On 3/2/23 10:26, David Marchand wrote: > > On Mon, Feb 27, 2023 at 5:28 PM Maxime Coquelin > > wrote: > >> As discussed with David off-list, I think we could simplify and inline > >> virtio_dev_pause()/virtio_dev_resume() into virtio_notify

RE: [PATCH 5/5] app/testpmd: add error recovery usage demo

2023-03-02 Thread Konstantin Ananyev
> > This patch adds error recovery usage demo which will: > 1. stop packet forwarding when the RTE_ETH_EVENT_ERR_RECOVERING event >is received. > 2. restart packet forwarding when the RTE_ETH_EVENT_RECOVERY_SUCCESS >event is received. > 3. prompt the ports that fail to recovery and need

[PATCH v9 01/21] net/cpfl: support device initialization

2023-03-02 Thread Mingxia Liu
Support device init and add the following dev ops: - dev_configure - dev_close - dev_infos_get - link_update - dev_supported_ptypes_get Signed-off-by: Mingxia Liu --- MAINTAINERS| 8 + doc/guides/nics/cpfl.rst | 85 +++ doc/guides/nics/features/c

[PATCH v9 00/21] add support for cpfl PMD in DPDK

2023-03-02 Thread Mingxia Liu
The patchset introduced the cpfl (Control Plane Function Library) PMD for Intel® IPU E2100’s Configure Physical Function (Device ID: 0x1453) The cpfl PMD inherits all the features from idpf PMD which will follow an ongoing standard data plan function spec https://www.oasis-open.org/committees/tc_h

[PATCH v9 02/21] net/cpfl: add Tx queue setup

2023-03-02 Thread Mingxia Liu
Add support for tx_queue_setup ops. There are two queue modes, single queue mode and split queue mode for Tx queue. For the single queue model, the descriptor TX queue is used by SW to post buffer descriptors to HW, and it's also used by HW to post completed descriptors to SW. For the split queu

[PATCH v9 03/21] net/cpfl: add Rx queue setup

2023-03-02 Thread Mingxia Liu
Add support for rx_queue_setup ops. There are two queue modes supported, single queue mode and split queue mode for Rx queue. For the single queue model, the descriptor RX queue is used by SW to post buffer descriptors to HW, and it's also used by HW to post completed descriptors to SW. For the

[PATCH v9 04/21] net/cpfl: support device start and stop

2023-03-02 Thread Mingxia Liu
Add dev ops dev_start, dev_stop and link_update. Signed-off-by: Mingxia Liu --- drivers/net/cpfl/cpfl_ethdev.c | 35 ++ 1 file changed, 35 insertions(+) diff --git a/drivers/net/cpfl/cpfl_ethdev.c b/drivers/net/cpfl/cpfl_ethdev.c index ae011da76f..6cbc950d84 1006

[PATCH v9 05/21] net/cpfl: support queue start

2023-03-02 Thread Mingxia Liu
Add support for these device ops: - rx_queue_start - tx_queue_start Signed-off-by: Mingxia Liu --- drivers/net/cpfl/cpfl_ethdev.c | 41 ++ drivers/net/cpfl/cpfl_rxtx.c | 138 + drivers/net/cpfl/cpfl_rxtx.h | 4 + 3 files changed, 183 insertions(+)

[PATCH v9 06/21] net/cpfl: support queue stop

2023-03-02 Thread Mingxia Liu
Add support for these device ops: - rx_queue_stop - tx_queue_stop Signed-off-by: Mingxia Liu --- drivers/net/cpfl/cpfl_ethdev.c | 10 +++- drivers/net/cpfl/cpfl_rxtx.c | 98 ++ drivers/net/cpfl/cpfl_rxtx.h | 3 ++ 3 files changed, 110 insertions(+), 1 delet

[PATCH v9 07/21] net/cpfl: support queue release

2023-03-02 Thread Mingxia Liu
Add support for queue operations: - rx_queue_release - tx_queue_release Signed-off-by: Mingxia Liu --- drivers/net/cpfl/cpfl_ethdev.c | 2 ++ drivers/net/cpfl/cpfl_rxtx.c | 24 drivers/net/cpfl/cpfl_rxtx.h | 2 ++ 3 files changed, 28 insertions(+) diff --git a/d

[PATCH v9 08/21] net/cpfl: support MTU configuration

2023-03-02 Thread Mingxia Liu
Add dev ops mtu_set. Signed-off-by: Mingxia Liu --- doc/guides/nics/features/cpfl.ini | 1 + drivers/net/cpfl/cpfl_ethdev.c| 27 +++ 2 files changed, 28 insertions(+) diff --git a/doc/guides/nics/features/cpfl.ini b/doc/guides/nics/features/cpfl.ini index a2d1ca9e1

[PATCH v9 09/21] net/cpfl: support basic Rx data path

2023-03-02 Thread Mingxia Liu
Add basic Rx support in split queue mode and single queue mode. Signed-off-by: Mingxia Liu --- drivers/net/cpfl/cpfl_ethdev.c | 2 ++ drivers/net/cpfl/cpfl_rxtx.c | 18 ++ drivers/net/cpfl/cpfl_rxtx.h | 1 + 3 files changed, 21 insertions(+) diff --git a/drivers/net/cpfl/c

[PATCH v9 10/21] net/cpfl: support basic Tx data path

2023-03-02 Thread Mingxia Liu
Add basic Tx support in split queue mode and single queue mode. Signed-off-by: Mingxia Liu --- drivers/net/cpfl/cpfl_ethdev.c | 3 +++ drivers/net/cpfl/cpfl_rxtx.c | 20 drivers/net/cpfl/cpfl_rxtx.h | 1 + 3 files changed, 24 insertions(+) diff --git a/drivers/net/cpf

[PATCH v9 11/21] net/cpfl: support write back based on ITR expire

2023-03-02 Thread Mingxia Liu
ITR is the interval between two interrupts, it can be understood as a timer here. WB_ON_ITR(write back on ITR expire) is used for receiving packets without interrupts or full cache line, then packets can be received one by one. To enable WB_ON_ITR, need to enable some interrupt with 'idpf_vport_ir

[PATCH v9 12/21] net/cpfl: support RSS

2023-03-02 Thread Mingxia Liu
Add RSS support. Signed-off-by: Mingxia Liu --- drivers/net/cpfl/cpfl_ethdev.c | 60 ++ drivers/net/cpfl/cpfl_ethdev.h | 15 + 2 files changed, 75 insertions(+) diff --git a/drivers/net/cpfl/cpfl_ethdev.c b/drivers/net/cpfl/cpfl_ethdev.c index ef40ae08df.

[PATCH v9 13/21] net/cpfl: support Rx offloading

2023-03-02 Thread Mingxia Liu
Add Rx offloading support: - support CHKSUM and RSS offload for split queue model - support CHKSUM offload for single queue model Signed-off-by: Mingxia Liu --- doc/guides/nics/features/cpfl.ini | 2 ++ drivers/net/cpfl/cpfl_ethdev.c| 6 ++ 2 files changed, 8 insertions(+) diff --git

[PATCH v9 14/21] net/cpfl: support Tx offloading

2023-03-02 Thread Mingxia Liu
Add Tx offloading support: - support TSO for single queue model and split queue model. Signed-off-by: Mingxia Liu --- doc/guides/nics/features/cpfl.ini | 1 + drivers/net/cpfl/cpfl_ethdev.c| 8 +++- 2 files changed, 8 insertions(+), 1 deletion(-) diff --git a/doc/guides/nics/features/c

[PATCH v9 16/21] net/cpfl: support timestamp offload

2023-03-02 Thread Mingxia Liu
Add support for timestamp offload. Signed-off-by: Mingxia Liu --- drivers/net/cpfl/cpfl_ethdev.c | 3 ++- drivers/net/cpfl/cpfl_rxtx.c | 7 +++ 2 files changed, 9 insertions(+), 1 deletion(-) diff --git a/drivers/net/cpfl/cpfl_ethdev.c b/drivers/net/cpfl/cpfl_ethdev.c index e64cadfd38..ae

[PATCH v9 17/21] net/cpfl: add AVX512 data path for split queue model

2023-03-02 Thread Mingxia Liu
Add support of AVX512 data path for split queue model. Signed-off-by: Wenjun Wu Signed-off-by: Mingxia Liu --- drivers/net/cpfl/cpfl_rxtx.c| 56 +++-- drivers/net/cpfl/cpfl_rxtx_vec_common.h | 20 - drivers/net/cpfl/meson.build| 6 ++- 3 file

[PATCH v9 18/21] net/cpfl: add HW statistics

2023-03-02 Thread Mingxia Liu
This patch add hardware packets/bytes statistics. Signed-off-by: Mingxia Liu --- drivers/net/cpfl/cpfl_ethdev.c | 87 ++ 1 file changed, 87 insertions(+) diff --git a/drivers/net/cpfl/cpfl_ethdev.c b/drivers/net/cpfl/cpfl_ethdev.c index ae716d104c..4970020139 100

[PATCH v9 19/21] net/cpfl: add RSS set/get ops

2023-03-02 Thread Mingxia Liu
Add support for these device ops: - rss_reta_update - rss_reta_query - rss_hash_update - rss_hash_conf_get Signed-off-by: Mingxia Liu --- drivers/net/cpfl/cpfl_ethdev.c | 271 - 1 file changed, 270 insertions(+), 1 deletion(-) diff --git a/drivers/net/cpfl/cpfl_e

[PATCH v9 15/21] net/cpfl: add AVX512 data path for single queue model

2023-03-02 Thread Mingxia Liu
Add support of AVX512 vector data path for single queue model. Signed-off-by: Wenjun Wu Signed-off-by: Mingxia Liu --- doc/guides/nics/cpfl.rst| 24 +- drivers/net/cpfl/cpfl_ethdev.c | 3 +- drivers/net/cpfl/cpfl_rxtx.c| 93 ++ dr

[PATCH v9 20/21] net/cpfl: support scalar scatter Rx datapath for single queue model

2023-03-02 Thread Mingxia Liu
This patch add single q recv scatter Rx function. Signed-off-by: Wenjun Wu Signed-off-by: Mingxia Liu --- drivers/net/cpfl/cpfl_ethdev.c | 3 ++- drivers/net/cpfl/cpfl_rxtx.c | 27 +++ drivers/net/cpfl/cpfl_rxtx.h | 2 ++ 3 files changed, 31 insertions(+), 1 deleti

[PATCH v9 21/21] net/cpfl: add xstats ops

2023-03-02 Thread Mingxia Liu
Add support for these device ops: - dev_xstats_get - dev_xstats_get_names - dev_xstats_reset Signed-off-by: Mingxia Liu --- drivers/net/cpfl/cpfl_ethdev.c | 79 ++ 1 file changed, 79 insertions(+) diff --git a/drivers/net/cpfl/cpfl_ethdev.c b/drivers/net/cpfl/cpf

RE: [PATCH v8 01/21] net/cpfl: support device initialization

2023-03-02 Thread Liu, Mingxia
> -Original Message- > From: Ferruh Yigit > Sent: Thursday, March 2, 2023 7:51 PM > To: Liu, Mingxia ; dev@dpdk.org; Xing, Beilei > ; Zhang, Yuying > Subject: Re: [PATCH v8 01/21] net/cpfl: support device initialization > > On 3/2/2023 11:24 AM, Liu, Mingxia wrote: > > > > > >> -Or

[PATCH v3 0/3] mlx5: fix Windows build with Linux MinGW

2023-03-02 Thread Thomas Monjalon
The result is to make possible to compile mlx5 on Linux for Windows. v2: improve mlx5 doc and remove weak attribute from mlx5 v3: avoid MinGW on Windows - EAL patch already applied Thomas Monjalon (3): common/mlx5: get Windows dependency from standard variables net/mlx5: remove weak stub fun

[PATCH v3 1/3] common/mlx5: get Windows dependency from standard variables

2023-03-02 Thread Thomas Monjalon
The DevX library path had to be provided through the variables DEVX_INC_PATH and DEVX_LIB_PATH. It was non-standard and triggers some issues with recent Meson. Using CFLAGS/LDFLAGS is standard and simpler. It is also possible to use the Meson options -Dc_args and -Dc_link_args. There are 2 options

[PATCH v3 3/3] net/mlx5: fix Windows build with MinGW GCC 12

2023-03-02 Thread Thomas Monjalon
With recent changes in Meson and MinGW toolchain, the driver mlx5 was not able to compile on Linux for Windows. There were errors due to system detection, non-typed constants, constant going over int range forbidden in pedantic mode, and minimum-comparison of different types. Cc: sta...@dpdk.org

[PATCH v3 2/3] net/mlx5: remove weak stub functions

2023-03-02 Thread Thomas Monjalon
The vector Rx functions are conditionally compiled. Some stub functions were also always compiled with weak attribute. If there is no vector support, the weak functions were linked. These weak functions are moved in a specific file which is compiled only if there is no vector support. This way it

Re: [PATCH v2] net: not build PMD AVX library when no IOVA as PA

2023-03-02 Thread Thomas Monjalon
19/02/2023 13:01, Thomas Monjalon: > 19/02/2023 12:08, Thomas Monjalon: > > 19/02/2023 11:04, Thomas Monjalon: > > > 29/01/2023 13:35, Zhang, Qi Z: > > > > From: Zhang, Qi Z > > > > > > > > > > PMD not announce pmd_supports_disable_iova_as_pa will not be build > > > > > when RTE_IOVA_AS_PA is not

[PATCH] net/ice: fix incorrect Rx timestamp for E822

2023-03-02 Thread Simei Su
The Rx timestamp is 0 due to the missing PHY clock timer setup for E822. Also, the source clock index in use is based on device capabilities instead of always being zero. Fixes: 953e74e6b73a ("net/ice: enable Rx timestamp on flex descriptor") Fixes: 646dcbe6c701 ("net/ice: support IEEE 1588 PTP")

RE: [PATCH] drivers: skip build of sub-libs not supporting IOVA mode

2023-03-02 Thread Zhang, Qi Z
> -Original Message- > From: Thomas Monjalon > Sent: Sunday, February 19, 2023 7:55 PM > To: dev@dpdk.org > Cc: David Marchand ; Richardson, Bruce > ; Zhang, Qi Z ; > sta...@dpdk.org; Wu, Jingjing ; Xing, Beilei > ; McDaniel, Timothy ; > Ajit Khaparde ; Somnath Kotur > ; Daley, John ; >

Re: [PATCH] drivers: skip build of sub-libs not supporting IOVA mode

2023-03-02 Thread Thomas Monjalon
02/03/2023 14:52, Zhang, Qi Z: > From: Thomas Monjalon > > If IOVA as PA is disabled and the driver does not support IOVA as VA, the > > build of the driver was disabled. > > Unfortunately some drivers were building some sub-libraries (with specific > > options for vector paths) which were not dis

Re: [PATCH v1 04/13] graph: add get/set graph worker model APIs

2023-03-02 Thread Jerin Jacob
On Thu, Mar 2, 2023 at 2:09 PM Yan, Zhirun wrote: > > > > > -Original Message- > > From: Jerin Jacob > > Sent: Monday, February 27, 2023 6:23 AM > > To: Yan, Zhirun > > Cc: dev@dpdk.org; jer...@marvell.com; kirankum...@marvell.com; > > ndabilpu...@marvell.com; Liang, Cunming ; > > Wang,

RE: [PATCH] drivers: skip build of sub-libs not supporting IOVA mode

2023-03-02 Thread Morten Brørup
> From: Thomas Monjalon [mailto:tho...@monjalon.net] > Sent: Sunday, 19 February 2023 12.55 > > If IOVA as PA is disabled and the driver does not support IOVA as VA, > the build of the driver was disabled. > Unfortunately some drivers were building some sub-libraries > (with specific options for v

RE: [PATCH] drivers: skip build of sub-libs not supporting IOVA mode

2023-03-02 Thread Zhang, Qi Z
> -Original Message- > From: Thomas Monjalon > Sent: Thursday, March 2, 2023 9:58 PM > To: Zhang, Qi Z > Cc: dev@dpdk.org; David Marchand ; > Richardson, Bruce ; sta...@dpdk.org; Wu, > Jingjing ; Xing, Beilei ; > McDaniel, Timothy ; Ajit Khaparde > ; Somnath Kotur > ; Daley, John ; > H

RE: [PATCH 00/17] use __atomic operations returning previous value

2023-03-02 Thread Morten Brørup
> From: Tyler Retzlaff [mailto:roret...@linux.microsoft.com] > Sent: Thursday, 2 March 2023 01.48 > To: dev@dpdk.org > Cc: honnappa.nagaraha...@arm.com; tho...@monjalon.net; Tyler Retzlaff > Subject: [PATCH 00/17] use __atomic operations returning previous value > > This series replaces uses of __

Re: [PATCH v3] net/idpf: refine Rx/Tx queue model info

2023-03-02 Thread Ferruh Yigit
On 3/2/2023 7:51 PM, Mingxia Liu wrote: > This patch updates queue mode info in struct idpf_adapter. > Using is_rx_singleq_model to diffentiate rx_singq and rx_splitq > explicitly, instead of deducing it from pointer values. > > Signed-off-by: Mingxia Liu Moving ack from previous version: Acked-

Re: [PATCH 01/17] vhost: use previous value atomic fetch operations

2023-03-02 Thread Maxime Coquelin
On 3/2/23 01:47, Tyler Retzlaff wrote: Use __atomic_fetch_{add,and,or,sub,xor} instead of __atomic_{add,and,or,sub,xor}_fetch when we have no interest in the result of the operation. Reduces unnecessary codegen that provided the result of the atomic operation that was not used. Change brings

Re: [PATCH 07/17] examples/vhost: use previous value atomic fetch operations

2023-03-02 Thread Maxime Coquelin
On 3/2/23 01:47, Tyler Retzlaff wrote: Use __atomic_fetch_{add,and,or,sub,xor} instead of __atomic_{add,and,or,sub,xor}_fetch when we have no interest in the result of the operation. Reduces unnecessary codegen that provided the result of the atomic operation that was not used. Change brings

Re: [PATCH 08/17] net/virtio: use previous value atomic fetch operations

2023-03-02 Thread Maxime Coquelin
On 3/2/23 01:47, Tyler Retzlaff wrote: Use __atomic_fetch_{add,and,or,sub,xor} instead of __atomic_{add,and,or,sub,xor}_fetch when we have no interest in the result of the operation. Reduces unnecessary codegen that provided the result of the atomic operation that was not used. Change brings

Re: [PATCH v9 00/21] add support for cpfl PMD in DPDK

2023-03-02 Thread Ferruh Yigit
On 3/2/2023 9:20 PM, Mingxia Liu wrote: > The patchset introduced the cpfl (Control Plane Function Library) PMD > for Intel® IPU E2100’s Configure Physical Function (Device ID: 0x1453) > > The cpfl PMD inherits all the features from idpf PMD which will follow > an ongoing standard data plan functi

Re: [PATCH] ethdev: remove telemetry Rx mbuf alloc failed field

2023-03-02 Thread Ferruh Yigit
On 3/1/2023 2:08 PM, Andrew Rybchenko wrote: > On 3/1/23 14:37, Thomas Monjalon wrote: >> 28/02/2023 19:02, Ferruh Yigit: >>> 'eth_dev->data->rx_mbuf_alloc_failed' field is not directly exposed to >>> user via ethdev APIs but it is used internally to set "stats->rx_nombuf' >>> which is exposed via

Re: [PATCH 11/17] net/iavf: use previous value atomic fetch operations

2023-03-02 Thread Tyler Retzlaff
On Thu, Mar 02, 2023 at 09:28:09AM +, Ruifeng Wang wrote: > > -Original Message- > > From: Tyler Retzlaff > > Sent: Thursday, March 2, 2023 8:48 AM > > To: dev@dpdk.org > > Cc: Honnappa Nagarahalli ; > > tho...@monjalon.net; Tyler > > Retzlaff > > Subject: [PATCH 11/17] net/iavf: use

RE: [EXT] [PATCH] drivers: skip build of sub-libs not supporting IOVA mode

2023-03-02 Thread Shijith Thotton
>If IOVA as PA is disabled and the driver does not support IOVA as VA, >the build of the driver was disabled. >Unfortunately some drivers were building some sub-libraries >(with specific options for vector paths) which were not disabled. > >The build parsing of those drivers need to be skipped earl

[PATCH v2 01/17] vhost: use previous value atomic fetch operations

2023-03-02 Thread Tyler Retzlaff
Use __atomic_fetch_{add,and,or,sub,xor} instead of __atomic_{add,and,or,sub,xor}_fetch when we have no interest in the result of the operation. Reduces unnecessary codegen that provided the result of the atomic operation that was not used. Change brings closer alignment with atomics available in

[PATCH v2 02/17] telemetry: use previous value atomic fetch operations

2023-03-02 Thread Tyler Retzlaff
Use __atomic_fetch_{add,and,or,sub,xor} instead of __atomic_{add,and,or,sub,xor}_fetch when we have no interest in the result of the operation. Reduces unnecessary codegen that provided the result of the atomic operation that was not used. Change brings closer alignment with atomics available in

[PATCH v2 00/17] use __atomic operations returning previous value

2023-03-02 Thread Tyler Retzlaff
This series replaces uses of __atomic_{add,and,or,sub,xor}_fetch with __atomic_fetch_{add,and,or,sub,xor} intrinsics. The latter omits generation of code that is only needed if the returned value is actually used. Additionally, this change simplifies adapting dpdk to standard atomics planned for

[PATCH v2 03/17] stack: use previous value atomic fetch operations

2023-03-02 Thread Tyler Retzlaff
Use __atomic_fetch_{add,and,or,sub,xor} instead of __atomic_{add,and,or,sub,xor}_fetch when we have no interest in the result of the operation. Reduces unnecessary codegen that provided the result of the atomic operation that was not used. Change brings closer alignment with atomics available in

[PATCH v2 05/17] distributor: use previous value atomic fetch operations

2023-03-02 Thread Tyler Retzlaff
Use __atomic_fetch_{add,and,or,sub,xor} instead of __atomic_{add,and,or,sub,xor}_fetch when we have no interest in the result of the operation. Reduces unnecessary codegen that provided the result of the atomic operation that was not used. Change brings closer alignment with atomics available in

[PATCH v2 04/17] eal: use previous value atomic fetch operations

2023-03-02 Thread Tyler Retzlaff
Use __atomic_fetch_{add,and,or,sub,xor} instead of __atomic_{add,and,or,sub,xor}_fetch when we have no interest in the result of the operation. Reduces unnecessary codegen that provided the result of the atomic operation that was not used. Change brings closer alignment with atomics available in

[PATCH v2 07/17] examples/vhost: use previous value atomic fetch operations

2023-03-02 Thread Tyler Retzlaff
Use __atomic_fetch_{add,and,or,sub,xor} instead of __atomic_{add,and,or,sub,xor}_fetch when we have no interest in the result of the operation. Reduces unnecessary codegen that provided the result of the atomic operation that was not used. Change brings closer alignment with atomics available in

[PATCH v2 11/17] net/iavf: use previous value atomic fetch operations

2023-03-02 Thread Tyler Retzlaff
Use __atomic_fetch_{add,and,or,sub,xor} instead of __atomic_{add,and,or,sub,xor}_fetch when we have no interest in the result of the operation. Reduces unnecessary codegen that provided the result of the atomic operation that was not used. Change brings closer alignment with atomics available in

[PATCH v2 12/17] net/cxgbe: use previous value atomic fetch operations

2023-03-02 Thread Tyler Retzlaff
Use __atomic_fetch_{add,and,or,sub,xor} instead of __atomic_{add,and,or,sub,xor}_fetch when we have no interest in the result of the operation. Reduces unnecessary codegen that provided the result of the atomic operation that was not used. Change brings closer alignment with atomics available in

[PATCH v2 09/17] net/octeontx: use previous value atomic fetch operations

2023-03-02 Thread Tyler Retzlaff
Use __atomic_fetch_{add,and,or,sub,xor} instead of __atomic_{add,and,or,sub,xor}_fetch when we have no interest in the result of the operation. Reduces unnecessary codegen that provided the result of the atomic operation that was not used. Change brings closer alignment with atomics available in

[PATCH v2 10/17] net/mlx5: use previous value atomic fetch operations

2023-03-02 Thread Tyler Retzlaff
Use __atomic_fetch_{add,and,or,sub,xor} instead of __atomic_{add,and,or,sub,xor}_fetch when we have no interest in the result of the operation. Reduces unnecessary codegen that provided the result of the atomic operation that was not used. Change brings closer alignment with atomics available in

[PATCH v2 08/17] net/virtio: use previous value atomic fetch operations

2023-03-02 Thread Tyler Retzlaff
Use __atomic_fetch_{add,and,or,sub,xor} instead of __atomic_{add,and,or,sub,xor}_fetch when we have no interest in the result of the operation. Reduces unnecessary codegen that provided the result of the atomic operation that was not used. Change brings closer alignment with atomics available in

[PATCH v2 06/17] bbdev: use previous value atomic fetch operations

2023-03-02 Thread Tyler Retzlaff
Use __atomic_fetch_{add,and,or,sub,xor} instead of __atomic_{add,and,or,sub,xor}_fetch when we have no interest in the result of the operation. Reduces unnecessary codegen that provided the result of the atomic operation that was not used. Change brings closer alignment with atomics available in

  1   2   >