[PATCH] common/cnxk: thread to handle VF messages

2023-06-05 Thread Harman Kalra
PF receives all the VFs mbox/flr messages which it forwards to AF. This is all handled by interrupt thread. Due to mbox locking in place a deadlock situation may arise which may lead to mbox timeout. Say at T1 - PF sends its own mbox to AF and wait for response. (PF is holding mbox lock) T2 - VF mb

[dpdk-dev] [PATCH] net/cnxk: add spec for SPI to SA action for cnxk

2023-06-05 Thread psatheesh
From: Kiran Kumar K Adding spec for MS_28_25 Flow action for cnxk device. Signed-off-by: Kiran Kumar K Reviewed-by: Nithin Kumar Dabilpuram --- drivers/net/cnxk/rte_pmd_cnxk.h | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/drivers/net/cnxk/rte_pmd_cnxk.h b/drivers/n

RE: [PATCH v4 13/26] vhost: add API to set max queue pairs

2023-06-05 Thread Xia, Chenbo
> -Original Message- > From: Maxime Coquelin > Sent: Friday, June 2, 2023 4:08 AM > To: dev@dpdk.org; Xia, Chenbo ; > david.march...@redhat.com; m...@redhat.com; f...@redhat.com; > jasow...@redhat.com; Liang, Cunming ; Xie, Yongji > ; echau...@redhat.com; epere...@redhat.com; > amore...@re

RE: [PATCH v4 26/26] vhost: add VDUSE device stop

2023-06-05 Thread Xia, Chenbo
> -Original Message- > From: Maxime Coquelin > Sent: Friday, June 2, 2023 4:08 AM > To: dev@dpdk.org; Xia, Chenbo ; > david.march...@redhat.com; m...@redhat.com; f...@redhat.com; > jasow...@redhat.com; Liang, Cunming ; Xie, Yongji > ; echau...@redhat.com; epere...@redhat.com; > amore...@re

Re: [PATCH v5 1/5] bus/cdx: introduce AMD CDX bus

2023-06-05 Thread Nipun Gupta
On 6/1/2023 8:30 PM, David Marchand wrote: Hello, On Thu, May 25, 2023 at 12:08 PM Nipun Gupta wrote: + * AMD CDX bus interface + */ + +#ifdef __cplusplus +extern "C" { +#endif Do you expect some out of tree drivers written in C++? Otherwise, this is unneeded. As the CDX devices

Re: [PATCH v5 4/5] bus/cdx: add support for MSI

2023-06-05 Thread Nipun Gupta
On 6/1/2023 8:39 PM, David Marchand wrote: On Thu, May 25, 2023 at 12:09 PM Nipun Gupta wrote: @@ -116,6 +141,18 @@ cdx_vfio_unmap_resource_secondary(struct rte_cdx_device *dev) { struct mapped_cdx_resource *vfio_res = NULL; struct mapped_cdx_res_list *vfio_res_li

[PATCH 1/3] examples/ipsec-secgw: avoid error pkt prints in fast path

2023-06-05 Thread Nithin Dabilpuram
Avoid printing errors due to bad packets in fast path as it effects performance. Make them RTE_LOG_DP() instead. Also print the actual ptype that is used to classify the pkt. Signed-off-by: Nithin Dabilpuram --- examples/ipsec-secgw/ipsec_worker.c | 2 +- examples/ipsec-secgw/ipsec_worker.h | 5

[PATCH 2/3] examples/ipsec-secgw: skip Rx scatter for HW reassembly

2023-06-05 Thread Nithin Dabilpuram
When HW reassembly is enabled, currently both Rx scatter and Tx multi-segs ethdev offload flags are enabled. Tx multi-seg is needed to Tx the reassembled pkt but Rx scatter is not needed as reassembly should be self sufficient offload flag. Hence remove it and only enable Tx multi-segs when HW reas

[PATCH 3/3] app/test: test inline reassembly with multi seg

2023-06-05 Thread Nithin Dabilpuram
Support testing inline reassembly with multi seg in inline ipsec multi seg test command. Signed-off-by: Nithin Dabilpuram --- app/test/test_security_inline_proto.c | 17 -- app/test/test_security_inline_proto_vectors.h | 53 ++- 2 files changed, 64 insertions(+), 6 de

Re: [PATCH v4 6/6] net/ring: replace rte atomics with GCC builtin atomics

2023-06-05 Thread Olivier Matz
Hi Tyler, Few comments below. On Fri, Jun 02, 2023 at 12:45:07PM -0700, Tyler Retzlaff wrote: > Replace the use of rte_atomic.h types and functions, instead use GCC > supplied C++11 memory model builtins. > > Signed-off-by: Tyler Retzlaff > Acked-by: Morten Brørup > Acked-by: Bruce Richardson

RE: [PATCH v8 03/14] net/cpfl: add haipin queue group during vport init

2023-06-05 Thread Wu, Jingjing
> -Original Message- > From: Xing, Beilei > Sent: Monday, June 5, 2023 2:17 PM > To: Wu, Jingjing > Cc: dev@dpdk.org; Liu, Mingxia ; Xing, Beilei > > Subject: [PATCH v8 03/14] net/cpfl: add haipin queue group during vport init > > From: Beilei Xing > > This patch adds haipin queue

[PATCH v2] common/cnxk: fix mbox timeout due to deadlock

2023-06-05 Thread Harman Kalra
PF receives all the VFs mbox/flr messages which it forwards to AF. This is all handled by interrupt thread. Due to mbox locking in place a deadlock situation may arise which may lead to mbox timeout. Say at T1 - PF sends its own mbox to AF and wait for response. (PF is holding mbox lock) T2 - VF mb

[PATCH V7] lib: set/get max memzone segments

2023-06-05 Thread Ophir Munk
Currently, the max memzones count constat (RTE_MAX_MEMZONE) is used to decide how many memzones a DPDK application can have. This value could technically be changed by manually editing `rte_config.h` before compilation, but if DPDK is already compiled, that option is not useful. There are certain u

RE: [PATCH v8 03/14] net/cpfl: add haipin queue group during vport init

2023-06-05 Thread Xing, Beilei
> -Original Message- > From: Wu, Jingjing > Sent: Monday, June 5, 2023 4:36 PM > To: Xing, Beilei > Cc: dev@dpdk.org; Liu, Mingxia > Subject: RE: [PATCH v8 03/14] net/cpfl: add haipin queue group during vport > init > > > > > -Original Message- > > From: Xing, Beilei > > S

[PATCH] net/octeon_ep: rework transmit routine

2023-06-05 Thread Vamsi Attunuru
Patch optimizes transmit path for multi-seg packets by pre-allocating the gather list memory instead of allocating it in fast path. Signed-off-by: Vamsi Attunuru --- drivers/net/octeon_ep/otx_ep_common.h | 66 +++ drivers/net/octeon_ep/otx_ep_rxtx.c | 251 ++ drive

Re: [PATCH v4] lib/net: add MPLS insert and strip functionality

2023-06-05 Thread Olivier Matz
Hi, Sorry for the late feedback, please see some comments below. To be honest, I have some doubts about the usefulness of the patch, especially the function that strips all the MPLS headers. On Sat, Feb 25, 2023 at 06:53:43PM +0500, Tanzeel-inline wrote: > From: Tanzeel Ahmed > > This patch is

[PATCH v9 00/14] net/cpfl: add hairpin queue support

2023-06-05 Thread beilei . xing
From: Beilei Xing This patchset adds hairpin queue support. v2 changes: - change hairpin rx queus configuration sequence. - code refine. v3 changes: - Refine the patchset based on the latest code. v4 change: - Remove hairpin rx buffer queue's sw_ring. - Change hairpin rx queus configurati

[PATCH v9 02/14] common/idpf: support queue groups add/delete

2023-06-05 Thread beilei . xing
From: Beilei Xing This patch adds queue group add/delete virtual channel support. Signed-off-by: Mingxia Liu Signed-off-by: Beilei Xing --- drivers/common/idpf/idpf_common_virtchnl.c | 66 ++ drivers/common/idpf/idpf_common_virtchnl.h | 9 +++ drivers/common/idpf/version.

[PATCH v9 01/14] net/cpfl: refine structures

2023-06-05 Thread beilei . xing
From: Beilei Xing This patch refines some structures to support hairpin queue, cpfl_rx_queue/cpfl_tx_queue/cpfl_vport. Signed-off-by: Mingxia Liu Signed-off-by: Beilei Xing --- drivers/net/cpfl/cpfl_ethdev.c | 85 +++- drivers/net/cpfl/cpfl_ethdev.h | 6 +- driver

[PATCH v9 04/14] net/cpfl: support hairpin queue capbility get

2023-06-05 Thread beilei . xing
From: Beilei Xing This patch adds hairpin_cap_get ops support. Signed-off-by: Xiao Wang Signed-off-by: Mingxia Liu Signed-off-by: Beilei Xing --- drivers/net/cpfl/cpfl_ethdev.c | 18 ++ drivers/net/cpfl/cpfl_rxtx.h | 3 +++ 2 files changed, 21 insertions(+) diff --git a/d

[PATCH v9 03/14] net/cpfl: add haipin queue group during vport init

2023-06-05 Thread beilei . xing
From: Beilei Xing This patch adds haipin queue group during vport init. Signed-off-by: Mingxia Liu Signed-off-by: Beilei Xing --- drivers/net/cpfl/cpfl_ethdev.c | 134 + drivers/net/cpfl/cpfl_ethdev.h | 18 + drivers/net/cpfl/cpfl_rxtx.h | 7 ++ 3 file

[PATCH v9 05/14] net/cpfl: support hairpin queue setup and release

2023-06-05 Thread beilei . xing
From: Beilei Xing Support hairpin Rx/Tx queue setup and release. Signed-off-by: Xiao Wang Signed-off-by: Mingxia Liu Signed-off-by: Beilei Xing --- drivers/net/cpfl/cpfl_ethdev.c | 6 + drivers/net/cpfl/cpfl_ethdev.h | 11 + drivers/net/cpfl/cpfl_rxtx.c| 364

[PATCH v9 06/14] common/idpf: add queue config API

2023-06-05 Thread beilei . xing
From: Beilei Xing This patch supports Rx/Tx queue configuration APIs. Signed-off-by: Mingxia Liu Signed-off-by: Beilei Xing --- drivers/common/idpf/idpf_common_virtchnl.c | 70 ++ drivers/common/idpf/idpf_common_virtchnl.h | 6 ++ drivers/common/idpf/version.map

[PATCH v9 07/14] net/cpfl: support hairpin queue configuration

2023-06-05 Thread beilei . xing
From: Beilei Xing This patch supports Rx/Tx hairpin queue configuration. Signed-off-by: Xiao Wang Signed-off-by: Mingxia Liu Signed-off-by: Beilei Xing --- drivers/net/cpfl/cpfl_ethdev.c | 136 +++-- drivers/net/cpfl/cpfl_rxtx.c | 88 + driv

[PATCH v9 08/14] common/idpf: add switch queue API

2023-06-05 Thread beilei . xing
From: Beilei Xing This patch adds idpf_vc_ena_dis_one_queue API. Signed-off-by: Mingxia Liu Signed-off-by: Beilei Xing --- drivers/common/idpf/idpf_common_virtchnl.c | 2 +- drivers/common/idpf/idpf_common_virtchnl.h | 3 +++ drivers/common/idpf/version.map| 1 + 3 files changed,

[PATCH v9 09/14] net/cpfl: support hairpin queue start/stop

2023-06-05 Thread beilei . xing
From: Beilei Xing This patch supports Rx/Tx hairpin queue start/stop. Signed-off-by: Xiao Wang Signed-off-by: Mingxia Liu Signed-off-by: Beilei Xing --- drivers/net/cpfl/cpfl_ethdev.c | 46 + drivers/net/cpfl/cpfl_rxtx.c | 164 + drivers/net/cpfl/cp

[PATCH v9 10/14] common/idpf: add irq map config API

2023-06-05 Thread beilei . xing
From: Beilei Xing This patch supports idpf_vport_irq_map_config_by_qids API. Signed-off-by: Mingxia Liu Signed-off-by: Beilei Xing --- drivers/common/idpf/idpf_common_device.c | 75 drivers/common/idpf/idpf_common_device.h | 4 ++ drivers/common/idpf/version.map

[PATCH v9 11/14] net/cpfl: enable write back based on ITR expire

2023-06-05 Thread beilei . xing
From: Beilei Xing This patch enables write back based on ITR expire (WR_ON_ITR) for hairpin queues. Signed-off-by: Mingxia Liu Signed-off-by: Beilei Xing --- drivers/net/cpfl/cpfl_ethdev.c | 13 - 1 file changed, 12 insertions(+), 1 deletion(-) diff --git a/drivers/net/cpfl/cpfl_

[PATCH v9 12/14] net/cpfl: support peer ports get

2023-06-05 Thread beilei . xing
From: Beilei Xing This patch supports get hairpin peer ports. Signed-off-by: Xiao Wang Signed-off-by: Beilei Xing --- drivers/net/cpfl/cpfl_ethdev.c | 41 ++ 1 file changed, 41 insertions(+) diff --git a/drivers/net/cpfl/cpfl_ethdev.c b/drivers/net/cpfl/cpfl_e

[PATCH v9 13/14] net/cpfl: support hairpin bind/unbind

2023-06-05 Thread beilei . xing
From: Beilei Xing This patch supports hairpin_bind/unbind ops. Signed-off-by: Xiao Wang Signed-off-by: Beilei Xing --- drivers/net/cpfl/cpfl_ethdev.c | 137 + 1 file changed, 137 insertions(+) diff --git a/drivers/net/cpfl/cpfl_ethdev.c b/drivers/net/cpfl/cpfl

[PATCH v9 14/14] doc: update the doc of CPFL PMD

2023-06-05 Thread beilei . xing
From: Beilei Xing Update cpfl.rst to clarify hairpin support. Signed-off-by: Beilei Xing --- doc/guides/nics/cpfl.rst | 7 +++ 1 file changed, 7 insertions(+) diff --git a/doc/guides/nics/cpfl.rst b/doc/guides/nics/cpfl.rst index d25db088eb..8d5c3082e4 100644 --- a/doc/guides/nics/cpfl.rs

[PATCH] net/ice/base: support customized DDP package

2023-06-05 Thread Simei Su
This patch adds support for custom DDP version 255.4.0.0. Signed-off-by: Simei Su --- drivers/net/ice/base/ice_ddp.c | 41 ++ drivers/net/ice/base/ice_ddp.h | 1 + 2 files changed, 38 insertions(+), 4 deletions(-) diff --git a/drivers/net/ice/base/ice_ddp.c b/dr

[RFC DPDK 21.11] net/ice/base: support customized DDP package

2023-06-05 Thread Simei Su
This patch adds support for custom DDP version 255.4.0.0 based on DPDK 21.11. Signed-off-by: Simei Su --- drivers/net/ice/base/ice_flex_pipe.c | 43 +--- drivers/net/ice/base/ice_flex_pipe.h | 1 + 2 files changed, 40 insertions(+), 4 deletions(-) diff --git a/drivers/n

[PATCH V8] lib: set/get max memzone segments

2023-06-05 Thread Ophir Munk
Currently, the max memzones count constat (RTE_MAX_MEMZONE) is used to decide how many memzones a DPDK application can have. This value could technically be changed by manually editing `rte_config.h` before compilation, but if DPDK is already compiled, that option is not useful. There are certain u

Re: [PATCH v5 1/2] ip_frag: optimize key compare and hash generation

2023-06-05 Thread Константин Ананьев
  From: Pavan Nikhilesh Use optimized rte_hash_k32_cmp_eq routine for key comparison forx86 and ARM64.Use CRC instructions for hash generation on ARM64.Signed-off-by: Pavan Nikhilesh Reviewed-by: Ruifeng Wang ---On Neoverse-N

Re: [PATCH 22/25] net/nfp: replace snprintf with strlcpy

2023-06-05 Thread Niklas Söderlund
Hi Stephen, Thanks for your work. On 2023-06-01 08:01:03 -0700, Stephen Hemminger wrote: > Suggested by devtools/cocci/strlcpy-with-header.cocci > > Signed-off-by: Stephen Hemminger Reviewed-by: Niklas Söderlund > --- > drivers/net/nfp/flower/nfp_flower_representor.c | 4 ++-- > 1 file chan

Re: [PATCH v4 2/2] test: add reassembly perf test

2023-06-05 Thread Константин Ананьев
   From: Pavan Nikhilesh Add reassembly perf autotest for both ipv4 and ipv6 reassembly.Each test is performed with variable number of fragments per flow,either ordered or unordered fragments and interleaved flows.Signed-off-by: Pavan Nikhilesh Re

RE: [PATCH v8 12/14] net/cpfl: support peer ports get

2023-06-05 Thread Wu, Jingjing
> -Original Message- > From: Xing, Beilei > Sent: Monday, June 5, 2023 2:17 PM > To: Wu, Jingjing > Cc: dev@dpdk.org; Liu, Mingxia ; Xing, Beilei > ; Wang, Xiao W > Subject: [PATCH v8 12/14] net/cpfl: support peer ports get > > From: Beilei Xing > > This patch supports get hairpin

[PATCH v7 00/15] graph enhancement for multi-core dispatch

2023-06-05 Thread Zhirun Yan
V7: Revert rte_rdtsc_precise() in fastpath to fix performance issues in patch 03. Introduce new scheme for model choosing. Use RTE_GRAPH_MODEL_SELECT to choose in compile-time in patch 13, 15.(must have rte_graph_worker_model_set() to help other config func to do model specific things like allo

[PATCH v7 01/17] graph: rename rte_graph_work as common

2023-06-05 Thread Zhirun Yan
Rename rte_graph_work.h to rte_graph_work_common.h for supporting multiple graph worker model. Signed-off-by: Haiyue Wang Signed-off-by: Cunming Liang Signed-off-by: Zhirun Yan --- MAINTAINERS | 3 ++- lib/graph/graph_pcap.c

[PATCH v7 02/17] graph: split graph worker into common and default model

2023-06-05 Thread Zhirun Yan
To support multiple graph worker model, split graph into common and default. Naming the current walk function as rte_graph_model_rtc cause the default model is RTC(Run-to-completion). Signed-off-by: Haiyue Wang Signed-off-by: Cunming Liang Signed-off-by: Zhirun Yan --- lib/graph/graph_pcap.c

[PATCH v7 03/17] graph: move node process into inline function

2023-06-05 Thread Zhirun Yan
Node process is a single and reusable block, move the code into an inline function. Signed-off-by: Haiyue Wang Signed-off-by: Cunming Liang Signed-off-by: Zhirun Yan --- lib/graph/rte_graph_model_rtc.h | 20 ++--- lib/graph/rte_graph_worker_common.h | 33 +++

[PATCH v7 05/17] graph: introduce graph node core affinity API

2023-06-05 Thread Zhirun Yan
Add lcore_id for node to hold affinity core id and impl rte_graph_model_mcore_dispatch_lcore_affinity_set to set node affinity with specific lcore. Signed-off-by: Haiyue Wang Signed-off-by: Cunming Liang Signed-off-by: Zhirun Yan --- lib/graph/graph_private.h | 2 + lib/graph

[PATCH v7 04/17] graph: add get/set graph worker model APIs

2023-06-05 Thread Zhirun Yan
Add new get/set APIs to configure graph worker model which is used to determine which model will be chosen. Signed-off-by: Haiyue Wang Signed-off-by: Cunming Liang Signed-off-by: Zhirun Yan --- lib/graph/meson.build | 1 + lib/graph/rte_graph_worker.c| 70 +++

[PATCH v7 06/17] graph: introduce graph bind unbind API

2023-06-05 Thread Zhirun Yan
Add lcore_id for graph to hold affinity core id where graph would run on. Add bind/unbind API to set/unset graph affinity attribute. lcore_id will be set as MAX by default, it means not enable this attribute. Signed-off-by: Haiyue Wang Signed-off-by: Cunming Liang Signed-off-by: Zhirun Yan ---

[PATCH v7 07/17] graph: move node clone name func into private as common

2023-06-05 Thread Zhirun Yan
Move clone_name() into graph_private.h as a common function for both node and graph to naming a new cloned object. Signed-off-by: Haiyue Wang Signed-off-by: Cunming Liang Signed-off-by: Zhirun Yan --- lib/graph/graph_private.h | 41 +++ lib/graph/node.c

[PATCH v7 08/17] graph: introduce graph clone API for other worker core

2023-06-05 Thread Zhirun Yan
This patch adds graph API for supporting to clone the graph object for a specified worker core. The new graph will also clone all nodes. Signed-off-by: Haiyue Wang Signed-off-by: Cunming Liang Signed-off-by: Zhirun Yan --- lib/graph/graph.c | 86 +++

[PATCH v7 09/17] graph: add structure for stream moving between cores

2023-06-05 Thread Zhirun Yan
Add graph_mcore_dispatch_wq_node to hold graph scheduling workqueue node. Signed-off-by: Haiyue Wang Signed-off-by: Cunming Liang Signed-off-by: Zhirun Yan --- lib/graph/graph.c | 2 ++ lib/graph/graph_populate.c | 1 + lib/graph/graph_private.h | 12

[PATCH v7 10/17] graph: introduce stream moving cross cores

2023-06-05 Thread Zhirun Yan
This patch introduces key functions to allow a worker thread to enable enqueue and move streams of objects to the next nodes over different cores for mcore dispatch model. Signed-off-by: Haiyue Wang Signed-off-by: Cunming Liang Signed-off-by: Zhirun Yan --- lib/graph/graph.c

[PATCH v7 11/17] graph: enable create and destroy graph scheduling workqueue

2023-06-05 Thread Zhirun Yan
This patch enables to create and destroy scheduling workqueue into common graph operations. Signed-off-by: Haiyue Wang Signed-off-by: Cunming Liang Signed-off-by: Zhirun Yan --- lib/graph/graph.c | 9 + 1 file changed, 9 insertions(+) diff --git a/lib/graph/graph.c b/lib/graph/graph.c

[PATCH v7 12/17] graph: introduce graph walk by cross-core dispatch

2023-06-05 Thread Zhirun Yan
This patch introduces the task scheduler mechanism to enable dispatching tasks to another worker cores. Currently, there is only a local work queue for one graph to walk. We introduce a scheduler worker queue in each worker core for dispatching tasks. It will perform the walk on scheduler work queu

[PATCH v3] node: add ipv4 reassembly node

2023-06-05 Thread pbhagavatula
From: Pavan Nikhilesh Add IPv4 reassembly node. Signed-off-by: Pavan Nikhilesh --- Depends-on: series-28278 v3 Changes: - Actually include the changes that fix compilation. v2 Changes: - Fix compilation. doc/guides/prog_guide/graph_lib.rst | 8 ++ lib/node/ethdev_rx.c|

[PATCH v7 13/17] graph: enable graph multicore dispatch scheduler model

2023-06-05 Thread Zhirun Yan
This patch enables to chose new scheduler model. Signed-off-by: Haiyue Wang Signed-off-by: Cunming Liang Signed-off-by: Zhirun Yan --- lib/graph/rte_graph_worker.h | 12 1 file changed, 12 insertions(+) diff --git a/lib/graph/rte_graph_worker.h b/lib/graph/rte_graph_worker.h inde

[PATCH v7 14/17] graph: add stats for cross-core dispatching

2023-06-05 Thread Zhirun Yan
Add stats for cross-core dispatching scheduler if stats collection is enabled. Signed-off-by: Haiyue Wang Signed-off-by: Cunming Liang Signed-off-by: Zhirun Yan --- lib/graph/graph_debug.c| 6 ++ lib/graph/graph_stats.c| 74 +++--- lib/g

[PATCH v7 15/17] examples/l3fwd-graph: introduce multicore dispatch worker model

2023-06-05 Thread Zhirun Yan
Add new parameter "model" to choose mcore dispatch or rtc model. And in dispatch model, the node will affinity to worker core successively. Note: RTE_GRAPH_MODEL_SELECT is set to GRAPH_MODEL_RTC by default. Must set model the same as RTE_GRAPH_MODEL_SELECT If set it as rtc or mcore dispatch explic

[PATCH v7 16/17] test/graph: add functional tests for mcore dispatch model

2023-06-05 Thread Zhirun Yan
Add functional test for mcore dispatch model including graph clone, graph model set/get, node worker affinity, graph worker binding/unbinding. Signed-off-by: Haiyue Wang Signed-off-by: Cunming Liang Signed-off-by: Zhirun Yan --- app/test/test_graph.c | 113 +

[PATCH v7 17/17] doc: update multicore dispatch model in graph guides

2023-06-05 Thread Zhirun Yan
Update graph documentation to introduce new multicore dispatch model. Signed-off-by: Haiyue Wang Signed-off-by: Cunming Liang Signed-off-by: Zhirun Yan --- doc/guides/prog_guide/graph_lib.rst | 60 +++-- 1 file changed, 56 insertions(+), 4 deletions(-) diff --git a/doc

[PATCH] net/cnxk: add support for reassembly of multi-seg pkts

2023-06-05 Thread Nithin Dabilpuram
Add support for HW reassembly of multi-seg pkts. Also optimize the code for normal reassembly path. Change-Id: I1ea3d04e4734eacc395a6f61560fc400882c0afc Signed-off-by: Nithin Dabilpuram --- drivers/event/cnxk/cn10k_worker.h | 21 +- drivers/net/cnxk/cn10k_rx.h | 714 +++---

[PATCH v2] net/cnxk: add support for reassembly of multi-seg pkts

2023-06-05 Thread Nithin Dabilpuram
Add support for HW reassembly of multi-seg pkts. Also optimize the code for normal reassembly path. Signed-off-by: Nithin Dabilpuram --- drivers/event/cnxk/cn10k_worker.h | 21 +- drivers/net/cnxk/cn10k_rx.h | 714 +++--- 2 files changed, 375 insertions(+), 360 del

Re: [PATCH 1/5] ethdev: support setting and querying rss algorithm

2023-06-05 Thread Dongdong Liu
Hi Ferruh On 2023/6/3 4:19, Ferruh Yigit wrote: On 3/16/2023 1:16 PM, Dongdong Liu wrote: Hi Thomas On 2023/3/15 21:43, Thomas Monjalon wrote: 15/03/2023 12:00, Dongdong Liu: From: Jie Hai --- a/doc/guides/rel_notes/release_23_03.rst +++ b/doc/guides/rel_notes/release_23_03.rst -* No ABI cha

Re: [PATCH v7 04/17] graph: add get/set graph worker model APIs

2023-06-05 Thread Jerin Jacob
On Mon, Jun 5, 2023 at 4:56 PM Zhirun Yan wrote: > > Add new get/set APIs to configure graph worker model which is used to > determine which model will be chosen. > > Signed-off-by: Haiyue Wang > Signed-off-by: Cunming Liang > Signed-off-by: Zhirun Yan > --- > lib/graph/meson.build

Re: [PATCH v7 06/17] graph: introduce graph bind unbind API

2023-06-05 Thread Jerin Jacob
On Mon, Jun 5, 2023 at 4:56 PM Zhirun Yan wrote: > > Add lcore_id for graph to hold affinity core id where graph would run on. > Add bind/unbind API to set/unset graph affinity attribute. lcore_id will > be set as MAX by default, it means not enable this attribute. > > Signed-off-by: Haiyue Wang

Re: [PATCH v3 1/3] node/kernel_tx: support packet transmit to kernel

2023-06-05 Thread Nithin Dabilpuram
Acked-by: Nithin Dabilpuram On Fri, Jun 2, 2023 at 9:52 PM Vamsi Attunuru wrote: > > Patch adds a node to transmit the packets to kernel over > a raw socket. > > Signed-off-by: Vamsi Attunuru > --- > doc/guides/prog_guide/graph_lib.rst | 9 ++ > lib/node/kernel_tx.c| 122

Re: [PATCH v7 09/17] graph: add structure for stream moving between cores

2023-06-05 Thread Jerin Jacob
On Mon, Jun 5, 2023 at 4:56 PM Zhirun Yan wrote: > > Add graph_mcore_dispatch_wq_node to hold graph scheduling workqueue > node. > > Signed-off-by: Haiyue Wang > Signed-off-by: Cunming Liang > Signed-off-by: Zhirun Yan > --- > lib/graph/graph.c | 2 ++ > lib/graph/graph_popu

Re: [PATCH v3 2/3] node/kernel_rx: support receiving packets from kernel

2023-06-05 Thread Nithin Dabilpuram
Acked-by: Nithin Dabilpuram On Fri, Jun 2, 2023 at 9:52 PM Vamsi Attunuru wrote: > > Adds a node to receive packets from kernel over > a raw socket. > > Signed-off-by: Vamsi Attunuru > --- > doc/guides/prog_guide/graph_lib.rst | 8 + > lib/node/kernel_rx.c| 276 ++

Re: [PATCH v3 3/3] node/ethdev_rx: remove hardcoded node next details

2023-06-05 Thread Nithin Dabilpuram
Acked-by: Nithin Dabilpuram On Fri, Jun 2, 2023 at 9:52 PM Vamsi Attunuru wrote: > > For ethdev_rx node, node_next details can be populated > during node cloning time and same gets assigned to > node context structure during node initialization. > > Patch removes overriding node_next details in n

Re: [PATCH v6 1/4] ethdev: add API for mbufs recycle mode

2023-06-05 Thread Константин Ананьев
  Hi Feifei, few more comments from me, see below.Add 'rte_eth_recycle_rx_queue_info_get' and 'rte_eth_recycle_mbufs'APIs to recycle used mbufs from a transmit queue of an Ethernet device,and move these mbufs into a mbuf ring for a receive queue of an Ethernetdevice. This can bypass mempool 'put/ge

Re: [PATCH v6 2/4] net/i40e: implement mbufs recycle mode

2023-06-05 Thread Константин Ананьев
   Define specific function implementation for i40e driver.Currently, mbufs recycle mode can support 128bitvector path and avx2 path. And can be enabled both infast free and no fast free mode.Suggested-by: Honnappa Nagarahalli Signed-off-by: Feifei Wang

Re: [PATCH 3/5] app/proc-info: fix never show RSS info

2023-06-05 Thread Dongdong Liu
Hi Ferruh On 2023/6/3 4:19, Ferruh Yigit wrote: On 3/15/2023 11:00 AM, Dongdong Liu wrote: From: Jie Hai Command show-port shows rss info only if rss_conf.rss_key is not null but it will never be true. This patch allocates memory for rss_conf.rss_key and makes it possible to show rss info.

Re: [PATCH 3/5] app/proc-info: fix never show RSS info

2023-06-05 Thread Dongdong Liu
Hi Stephen On 2023/6/3 5:19, Stephen Hemminger wrote: On Wed, 15 Mar 2023 19:00:31 +0800 Dongdong Liu wrote: + rss_key = rte_malloc(NULL, + dev_info.hash_key_size * sizeof(uint8_t), 0); + if (rss_key == NULL) + return;

Re: [PATCH v6 4/4] app/testpmd: add recycle mbufs engine

2023-06-05 Thread Константин Ананьев
   Add recycle mbufs engine for testpmd. This engine forward pkts withI/O forward mode. But enable mbufs recycle feature to recycle usedtxq mbufs for rxq mbuf ring, which can bypass mempool path and saveCPU cycles.Suggested-by: Jerin Jacob Signed-off-by: Feifei Wang

Getting network port ID by ethdev port ID

2023-06-05 Thread Ivan Malov
Dear community, Is there any means in DPDK to discover relationship between network/physical ports of the given adapter/board and etdevs deployed in DPDK application on top of it? For example, in Linux, there are facilities like /sys/class/net//phys_port_name /sys/class/net//dev_port and d

Re: [PATCH 4/5] app/proc-info: show RSS types with strings

2023-06-05 Thread Dongdong Liu
Hi Ferruh On 2023/6/3 4:22, Ferruh Yigit wrote: On 3/15/2023 11:00 AM, Dongdong Liu wrote: From: Jie Hai show RSS types details and adjust RSS info display format as following: - RSS info -- hf: ipv4 ipv4-frag ipv4-other ipv6 ipv6-frag ipv6-other -

[PATCH v6 0/4] Support AMD CDX bus

2023-06-05 Thread Nipun Gupta
The CDX devices are memory mapped on system bus for embedded CPUs. It uses sysfs interface and the vfio-cdx driver to discover and initialize the CDX devices. The CDX bus and VFIO support is available at Xilinx/AMD open source tree: https://github.com/Xilinx/linux-xlnx (drivers/cdx/ and drivers/v

[PATCH v6 1/4] bus/cdx: introduce AMD CDX bus

2023-06-05 Thread Nipun Gupta
AMD CDX bus supports multiple type of devices, which can be exposed to user-space via vfio-cdx. vfio-cdx provides the MMIO IO_MEMORY regions as well as the DMA interface for the device (IOMMU). This support aims to enable the DPDK to support the cdx devices in user-space using VFIO interface. Si

[PATCH v6 2/4] bus/cdx: add DMA map and unmap support

2023-06-05 Thread Nipun Gupta
AMD CDX bus can use VFIO interface for mapping and unmapping of DMA addresses in the IOMMU. This change adds the callback support for map and unmap APIs as well as fetching the IOMMU class. Signed-off-by: Nipun Gupta Acked-by: Ferruh Yigit --- drivers/bus/cdx/cdx.c | 30

[PATCH v6 4/4] bus/cdx: support plug unplug and dev iterator

2023-06-05 Thread Nipun Gupta
This change adds support for plugging and unplugging CDX devices on AMD CDX bus. Also, CDX dev iterator support has been added for the CDX bus. Signed-off-by: Nipun Gupta Acked-by: Ferruh Yigit --- drivers/bus/cdx/bus_cdx_driver.h | 1 + drivers/bus/cdx/cdx.c| 122

[PATCH v6 3/4] bus/cdx: add support for MSI

2023-06-05 Thread Nipun Gupta
MSI's are exposed to the devices using VFIO (vfio-cdx). This patch uses the same to add support for MSI for the devices on the cdx bus. Signed-off-by: Nipun Gupta Acked-by: Ferruh Yigit --- drivers/bus/cdx/bus_cdx_driver.h | 25 + drivers/bus/cdx/cdx.c| 11 ++ drivers/bus/cdx/

Re: [PATCH v12 06/22] acl: convert RTE_LOGTYPE_ACL to dynamic type

2023-06-05 Thread Константин Ананьев
  Get rid of RTE_LOGTYPE_ACL and RTE_LOGTYPE_MALLOC.For ACL library use a dynamic type.The one message using RTE_LOGTYPE_MALLOC should have beenunder the ACL logtype anyway.The test code should not have been using fixed log typeso just change that to stderr.Signed-off-by: Stephen Hemminger

Re: Getting network port ID by ethdev port ID

2023-06-05 Thread Thomas Monjalon
Hello, 05/06/2023 15:09, Ivan Malov: > Dear community, > > Is there any means in DPDK to discover relationship between > network/physical ports of the given adapter/board and > etdevs deployed in DPDK application on top of it? > > For example, in Linux, there are facilities like > > > /sys/clas

Re: [PATCH v12 10/22] ring: convert RTE_LOGTYPE_RING to dynamic type

2023-06-05 Thread Константин Ананьев
   The logtype for ring only used in library.Signed-off-by: Stephen Hemminger --- lib/eal/common/eal_common_log.c | 1 - lib/eal/include/rte_log.h | 2 +- lib/ring/rte_ring.c | 3 +++ 3 files changed, 4 insertions(+), 2 deletions(-)diff --git a/lib/eal/common/eal_common_log

Re: [PATCH v7 15/17] examples/l3fwd-graph: introduce multicore dispatch worker model

2023-06-05 Thread Jerin Jacob
On Mon, Jun 5, 2023 at 4:57 PM Zhirun Yan wrote: > > Add new parameter "model" to choose mcore dispatch or rtc model. > And in dispatch model, the node will affinity to worker core successively. > > Note: > RTE_GRAPH_MODEL_SELECT is set to GRAPH_MODEL_RTC by default. Must set > model the same as R

Re: Getting network port ID by ethdev port ID

2023-06-05 Thread Ivan Malov
Hi Thomas, Thanks for responding. Please see below. On Mon, 5 Jun 2023, Thomas Monjalon wrote: Hello, 05/06/2023 15:09, Ivan Malov: Dear community, Is there any means in DPDK to discover relationship between network/physical ports of the given adapter/board and etdevs deployed in DPDK appli

Re: Getting network port ID by ethdev port ID

2023-06-05 Thread Thomas Monjalon
05/06/2023 16:03, Ivan Malov: > Hi Thomas, > > Thanks for responding. Please see below. > > On Mon, 5 Jun 2023, Thomas Monjalon wrote: > > > Hello, > > > > 05/06/2023 15:09, Ivan Malov: > >> Dear community, > >> > >> Is there any means in DPDK to discover relationship between > >> network/physic

Re: Getting network port ID by ethdev port ID

2023-06-05 Thread Ivan Malov
On Mon, 5 Jun 2023, Thomas Monjalon wrote: 05/06/2023 16:03, Ivan Malov: Hi Thomas, Thanks for responding. Please see below. On Mon, 5 Jun 2023, Thomas Monjalon wrote: Hello, 05/06/2023 15:09, Ivan Malov: Dear community, Is there any means in DPDK to discover relationship between network

Re: Getting network port ID by ethdev port ID

2023-06-05 Thread Ivan Malov
Sorry, I missed your question. See below. On Mon, 5 Jun 2023, Thomas Monjalon wrote: 05/06/2023 16:03, Ivan Malov: Hi Thomas, Thanks for responding. Please see below. On Mon, 5 Jun 2023, Thomas Monjalon wrote: Hello, 05/06/2023 15:09, Ivan Malov: Dear community, Is there any means in DP

Re: [PATCH v3] eal: add tracepoints to track lcores and services

2023-06-05 Thread Arnaud Fiorini
On 2023-05-12 10:30 a.m., Arnaud Fiorini wrote: The tracepoints added are used to track lcore role and status, as well as service mapping and service runstates. These tracepoints are then used in analyses in Trace Compass. Signed-off-by: Arnaud Fiorini --- .mailmap

VPP crash observed in DPDK for MLX5 driver

2023-06-05 Thread Chinmaya Agarwal
Hi, We are using VPP with DPDK and MLX5 driver and we see random VPP crash when the traffic is flowing through the interface with below dump. May 28 21:53:25 j3da1vmstm01 vnet[2280]: received signal SIGSEGV, PC 0x7f45eab17b5a, faulting address 0x0 May 28 21:53:25 j3da1vmstm01 vnet[2280]: #0 0x

Error while installing DPDK libraries.

2023-06-05 Thread Nikhil Kapoor
Dear Team, We are facing issues in installing DPDK packages in our linux server. Please find attached error for four reference. -- With Regards, Nikhil Kapoor Senior System Engineer Pinnacle Digital Analytics (P) Ltd. New Delhi, India P +91 11 41670403 | M +91 7838345731 www.pinnacledigital.i

[PATCH v2] net/vmxnet3: fix return code in initializing

2023-06-05 Thread Kaijun Zeng
Improve error handling Fixes: dfaff37fc46d ("vmxnet3: import new vmxnet3 poll mode driver implementation") Cc: sta...@dpdk.org Signed-off-by: Kaijun Zeng --- drivers/net/vmxnet3/vmxnet3_rxtx.c | 12 +++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/drivers/net/vmxnet3/

Re: [dpdk-dev] [PATCH] net/cnxk: add spec for SPI to SA action for cnxk

2023-06-05 Thread Jerin Jacob
On Mon, Jun 5, 2023 at 1:10 PM wrote: > > From: Kiran Kumar K > > Adding spec for MS_28_25 Flow action for cnxk device. > > Signed-off-by: Kiran Kumar K > Reviewed-by: Nithin Kumar Dabilpuram Updated the git commit as follows and applied to dpdk-next-net-mrvl/for-next-net. Thanks net/cnxk

Re: Getting network port ID by ethdev port ID

2023-06-05 Thread Thomas Monjalon
05/06/2023 16:29, Ivan Malov: > Sorry, I missed your question. See below. > > On Mon, 5 Jun 2023, Thomas Monjalon wrote: > > > 05/06/2023 16:03, Ivan Malov: > >> Hi Thomas, > >> > >> Thanks for responding. Please see below. > >> > >> On Mon, 5 Jun 2023, Thomas Monjalon wrote: > >> > >>> Hello, >

Re: [PATCH 0/4] Heap library and test case changes

2023-06-05 Thread Thomas Monjalon
19/05/2023 06:29, Ruifeng Wang: > This series fixed a heap free list management issue which was captured > by unit test failure. > It also includes fixes of the unit test. > > Ruifeng Wang (4): > eal: fix list index for 256 byte element > eal: simplify check condition > test/malloc: fix miss

Re: [PATCH] eal: fix calling cleanup function twice

2023-06-05 Thread Thomas Monjalon
01/06/2023 18:08, Bruce Richardson: > If an app calls rte_eal_cleanup() inside it's own code, then cleanup > could be called a second time automatically when the app exits. While > mostly harmless, we can avoid any potential issues by guaranteeing that > cleanup only gets called once, in the same w

Re: [PATCH v3 2/3] lib: add IPv6 rewrite node

2023-06-05 Thread Nithin Dabilpuram
Acked-by: Nithin Dabilpuram On Wed, May 31, 2023 at 5:08 PM Amit Prakash Shukla wrote: > > Similar to IPv4 rewrite node, patch adds IPv6 rewrite node. > > Signed-off-by: Amit Prakash Shukla > --- > v2: > - Performance related changes > > v3: > - Removing redundant dynamic variable > > doc/guid

Re: [PATCH v3 3/3] examples/l3fwd-graph: add IPv6 lookup and rewrite support

2023-06-05 Thread Nithin Dabilpuram
Acked-by: Nithin Dabilpuram On Wed, May 31, 2023 at 5:08 PM Amit Prakash Shukla wrote: > > From: Sunil Kumar Kori > > Similar to ipv4, to support IPv6 lookup and rewrite node > routes and rewrite data needs to be added. > > Patch adds routes for ipv6 to validate ip6_lookup node > and rewrite d

Re: Generic flow string parser

2023-06-05 Thread kumaraparameshwaran rathinavel
On Sun, Apr 30, 2023 at 3:10 AM Thomas Monjalon wrote: > This thread is an API suggestion, it should be discussed in > the developer mailing list (did the Cc here). > > 29/04/2023 16:23, Cliff Burdick: > > > Would rather the flow parser was rewritten as well. Doing open coded > > > parser is much

Re: [PATCH V8] lib: set/get max memzone segments

2023-06-05 Thread Thomas Monjalon
05/06/2023 12:50, Ophir Munk: > Currently, the max memzones count constat (RTE_MAX_MEMZONE) is used to > decide how many memzones a DPDK application can have. This value could > technically be changed by manually editing `rte_config.h` before > compilation, but if DPDK is already compiled, that opt

Re: Getting network port ID by ethdev port ID

2023-06-05 Thread Stephen Hemminger
On Mon, 05 Jun 2023 18:03:14 +0200 Thomas Monjalon wrote: > 05/06/2023 16:29, Ivan Malov: > > Sorry, I missed your question. See below. > > > > On Mon, 5 Jun 2023, Thomas Monjalon wrote: > > > > > 05/06/2023 16:03, Ivan Malov: > > >> Hi Thomas, > > >> > > >> Thanks for responding. Please se

Re: [PATCH v1 1/1] doc: announce change in bbdev api related to operation extension

2023-06-05 Thread Maxime Coquelin
On 5/26/23 05:47, Stephen Hemminger wrote: On Fri, 26 May 2023 02:11:32 + Nicolas Chautru wrote: + +* bbdev: Will extend the API to support the new operation type ``RTE_BBDEV_OP_MLDTS`` as per + this `v1 `. This will also intr

  1   2   >