Re: [Bug 1249] [dpdk-23.07] ixgbe port stop failed after launch testpmd

2023-06-14 Thread David Marchand
On Wed, Jun 14, 2023 at 8:57 AM Yang, Qiming wrote: > > Hi, Tyler > May I know why you need to change the legacy atomics? rte_atomic32_xxx series > action is performance optimized, I don't think the change is needed as no bug > or other requirement. The deprecation of rte_atomic32_xxx atomics i

RE: [Bug 1249] [dpdk-23.07] ixgbe port stop failed after launch testpmd

2023-06-14 Thread Morten Brørup
> From: David Marchand [mailto:david.march...@redhat.com] > Sent: Wednesday, 14 June 2023 09.14 > > On Wed, Jun 14, 2023 at 8:57 AM Yang, Qiming wrote: > > > > Hi, Tyler > > May I know why you need to change the legacy atomics? rte_atomic32_xxx > series action is performance optimized, I don't th

Re: [PATCH 2/2] doc/contributing: guidelines for logging, tracing and telemetry

2023-06-14 Thread Bruce Richardson
On Tue, Jun 13, 2023 at 09:38:55PM +0200, Morten Brørup wrote: > > From: Bruce Richardson [mailto:bruce.richard...@intel.com] > > Sent: Tuesday, 13 June 2023 16.34 > > > > As discussed by DPDK technical board [1], out contributor guide should > > Typo: out -> our > > > include some details as to

RE: [dpdk-dev] [RFC] hash: introduce resizable hash list

2023-06-14 Thread Bing Zhao
Hi Stephen, > -Original Message- > From: Stephen Hemminger > Sent: Tuesday, June 13, 2023 12:44 AM > To: Bing Zhao > Cc: yipeng1.w...@intel.com; sameh.gobr...@intel.com; > bruce.richard...@intel.com; pablo.de.lara.gua...@intel.com; dev@dpdk.org > Subject: Re: [dpdk-dev] [RFC] hash: intro

RE: [PATCH 2/2] doc/contributing: guidelines for logging, tracing and telemetry

2023-06-14 Thread Morten Brørup
> From: Bruce Richardson [mailto:bruce.richard...@intel.com] > Sent: Wednesday, 14 June 2023 10.37 > > On Tue, Jun 13, 2023 at 09:38:55PM +0200, Morten Brørup wrote: > > > From: Bruce Richardson [mailto:bruce.richard...@intel.com] > > > Sent: Tuesday, 13 June 2023 16.34 > > > > > > As discussed by

[PATCH v2] net/iavf: fix abnormal disable HW interrupt

2023-06-14 Thread Mingjin Ye
For command VIRTCHNL_OP_REQUEST_QUEUES, polling access to the admin queue has the issue of access overruns after disabling interrupt. That results in FW disabling HW interrupt for protection purposes. The updates/changes in this patch: 1. Remove the polling admin queue processing and use the gener

[PATCH] bus/cdx: Remove ineffective code statement

2023-06-14 Thread Abhijit Gangurde
ret = 0 statement is ineffective since it is overwritten in a loop. Coverity issue: 385379 Fixes: 45ef232af515 ("bus/cdx: introduce AMD CDX bus") Signed-off-by: Abhijit Gangurde --- drivers/bus/cdx/cdx.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/bus/cdx/cdx.c b/drivers/bus/cdx/c

[PATCH] bus/cdx: Move debug print before unmapping resource

2023-06-14 Thread Abhijit Gangurde
Debug print is moved before unmapping requested address to fix use after free coverity issue. Coverity issue: 385381 Fixes: 45ef232af515 ("bus/cdx: introduce AMD CDX bus") Signed-off-by: Abhijit Gangurde --- drivers/bus/cdx/cdx.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --gi

[PATCH] bus/cdx: Fix resource leak

2023-06-14 Thread Abhijit Gangurde
Freeing the allocated resources on error scenarios. Coverity issue: 385377 Fixes: f29fb5caa135 ("bus/cdx: support MSI") Signed-off-by: Abhijit Gangurde --- drivers/bus/cdx/cdx.c | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/drivers/bus/cdx/cdx.c b/drivers/bus/cdx

Re: [PATCH v3 5/5] config/arm: add AMD CDX

2023-06-14 Thread Ferruh Yigit
On 5/9/2023 6:55 AM, Ruifeng Wang wrote: >> -Original Message- >> From: Ferruh Yigit >> Sent: Monday, May 8, 2023 7:27 PM >> To: Gupta, Nipun ; dev@dpdk.org; tho...@monjalon.net; >> david.march...@redhat.com; Honnappa Nagarahalli >> ; Ruifeng >> Wang >> Cc: Anand, Harpreet ; Agarwal, Nik

Re: [PATCH v2 3/3] event/cnxk: use WFE in Tx fc wait

2023-06-14 Thread Jerin Jacob
On Tue, Jun 13, 2023 at 2:56 PM wrote: > > From: Pavan Nikhilesh > > Use WFE is Tx path when waiting for space in the Tx queue. > Depending upon the Tx queue contention and size, WFE will > reduce the cache pressure and power consumption. > In multi-core scenarios we have observed up to 8W power

Re: [PATCH] usertools: enhance logic to display NUMA

2023-06-14 Thread Ferruh Yigit
On 3/28/2022 3:56 AM, Varghese, Vipin wrote: > Hi Thomas, > > > > 26/03/2022 08:32, Vipin Varghese: >>> enhance python logic to accomadate NUMA information. Current logic >>> considers physical socket with CPU threads to core map. With new AMD >>> SKU vairant NUMA is no longer same as SOCKET.

RE: [PATCH v3] net/ixgbe: add proper memory barriers for some Rx functions

2023-06-14 Thread Konstantin Ananyev
Konstantin Ananyev Mobile: +353-873459988 Email: konstantin.anan...@huawei.com From:zhoumin To:Thomas Monjalon ;Ruifeng Wang ;Zhang, Qi Z Cc:dev ;mb ;konstantin.v.ananyev ;Yang, Qiming ;Wu, Wenjun1 ;drc ;roretzla ;stable ;maobibo ;nd ;David Marchand ;

Re: [PATCH] usertools: enhance logic to display NUMA

2023-06-14 Thread Dmitry Kozlyuk
Hi, 2023-06-14 11:48 (UTC+0100), Ferruh Yigit: > Also @Dmitry, is there solution for Windows for this issue (a tool to > replace cpu_layout.py)? hwloc binaries, including lstopo-no-graphics.exe, are packaged for Windows by the authors: https://www.open-mpi.org/software/hwloc/current/

Re: [PATCH 2/2] doc/contributing: guidelines for logging, tracing and telemetry

2023-06-14 Thread Ferruh Yigit
On 6/13/2023 3:33 PM, Bruce Richardson wrote: > As discussed by DPDK technical board [1], out contributor guide should > include some details as to when to use logging vs tracing vs telemetry > to provide the end user with information about the running process and > the DPDK libraries it uses. > >

Re: [PATCH v3 2/2] build: change libfdt flag variable type to boolean

2023-06-14 Thread David Marchand
On Tue, Jun 13, 2023 at 5:34 PM Bruce Richardson wrote: > > The has_libfdt flag was using 0 and 1 integer values, instead of the > more appropriate boolean type. Change to use true/false instead. > > Signed-off-by: Bruce Richardson Reviewed-by: David Marchand -- David Marchand

[PATCH v5 00/15] net/cnxk: add MACsec support

2023-06-14 Thread Akhil Goyal
Added MACsec support in Marvell cnxk PMD. The patchset is pending from last release [1] Sending as a new series as the functionality is now complete and tested on hardware. [1] https://patches.dpdk.org/project/dpdk/cover/20220928124516.93050-1-gak...@marvell.com/ Changes in v5: - fix copyright y

[PATCH v5 01/15] common/cnxk: add ROC MACsec initialization

2023-06-14 Thread Akhil Goyal
Added ROC init and fini APIs for supporting MACsec. Signed-off-by: Ankur Dwivedi Signed-off-by: Vamsi Attunuru Signed-off-by: Akhil Goyal --- drivers/common/cnxk/meson.build | 1 + drivers/common/cnxk/roc_api.h | 3 + drivers/common/cnxk/roc_features.h | 12 ++ drivers/common/c

[PATCH v5 02/15] common/cnxk: add MACsec SA configuration

2023-06-14 Thread Akhil Goyal
Added ROC APIs to allocate/free MACsec resources and APIs to write SA policy. Signed-off-by: Ankur Dwivedi Signed-off-by: Vamsi Attunuru Signed-off-by: Akhil Goyal --- drivers/common/cnxk/meson.build | 1 + drivers/common/cnxk/roc_mbox.h| 12 ++ drivers/common/cnxk/roc_mcs.h

[PATCH v5 03/15] common/cnxk: add MACsec SC configuration APIs

2023-06-14 Thread Akhil Goyal
Added ROC APIs to configure MACsec secure channel(SC) and its mapping with SAs for both Rx and Tx. Signed-off-by: Ankur Dwivedi Signed-off-by: Vamsi Attunuru Signed-off-by: Akhil Goyal --- drivers/common/cnxk/roc_mbox.h| 37 ++ drivers/common/cnxk/roc_mcs.h | 42 +++

[PATCH v5 04/15] common/cnxk: add MACsec secy and flow configuration

2023-06-14 Thread Akhil Goyal
Added ROC APIs to configure MACsec secy policy and flow entries. Signed-off-by: Ankur Dwivedi Signed-off-by: Vamsi Attunuru Signed-off-by: Akhil Goyal --- drivers/common/cnxk/roc_mbox.h| 38 + drivers/common/cnxk/roc_mcs.h | 37 + drivers/common/cnxk/roc_mcs_s

[PATCH v5 05/15] common/cnxk: add MACsec PN and LMAC mode configuration

2023-06-14 Thread Akhil Goyal
Added ROC APIs for setting packet number and LMAC related configurations. Signed-off-by: Ankur Dwivedi Signed-off-by: Vamsi Attunuru Signed-off-by: Akhil Goyal --- drivers/common/cnxk/roc_mbox.h| 56 + drivers/common/cnxk/roc_mcs.c | 71 +

[PATCH v5 06/15] common/cnxk: add MACsec stats

2023-06-14 Thread Akhil Goyal
Added ROC APIs for MACsec stats for SC/SECY/FLOW/PORT Signed-off-by: Ankur Dwivedi Signed-off-by: Vamsi Attunuru Signed-off-by: Akhil Goyal --- drivers/common/cnxk/meson.build | 1 + drivers/common/cnxk/roc_mbox.h | 93 ++ drivers/common/cnxk/roc_mcs.h | 85 +

[PATCH v5 08/15] common/cnxk: add MACsec port configuration

2023-06-14 Thread Akhil Goyal
Added ROC APIs for MACsec port configurations Signed-off-by: Ankur Dwivedi Signed-off-by: Vamsi Attunuru Signed-off-by: Akhil Goyal --- drivers/common/cnxk/roc_mbox.h | 40 drivers/common/cnxk/roc_mcs.c | 346 drivers/common/cnxk/roc_mcs.h | 48

[PATCH v5 07/15] common/cnxk: add MACsec interrupt APIs

2023-06-14 Thread Akhil Goyal
Added ROC APIs to support various MACsec interrupts. Signed-off-by: Ankur Dwivedi Signed-off-by: Vamsi Attunuru Signed-off-by: Akhil Goyal --- drivers/common/cnxk/roc_dev.c | 86 + drivers/common/cnxk/roc_mbox.h | 37 +++- drivers/common/cnxk/roc_mcs.c | 117

[PATCH v5 10/15] common/cnxk: add MACsec FIPS mbox

2023-06-14 Thread Akhil Goyal
Added MACsec FIPS configuration mbox Signed-off-by: Ankur Dwivedi Signed-off-by: Vamsi Attunuru Signed-off-by: Akhil Goyal --- drivers/common/cnxk/roc_mbox.h | 74 ++ drivers/common/cnxk/roc_mcs.h | 69 +++ 2 files changed, 143 inser

[PATCH v5 09/15] common/cnxk: add MACsec control port configuration

2023-06-14 Thread Akhil Goyal
Added ROC APIs to configure MACsec control port. Signed-off-by: Ankur Dwivedi Signed-off-by: Vamsi Attunuru Signed-off-by: Akhil Goyal --- drivers/common/cnxk/roc_mbox.h | 72 drivers/common/cnxk/roc_mcs.c | 117 drivers/common/cnxk/roc

[PATCH v5 11/15] common/cnxk: derive hash key for MACsec

2023-06-14 Thread Akhil Goyal
MACsec hardware configuration need hash key to be generated from the cipher key of AES-GCM-128/256. Added an ROC API to derive the hash key and extend the case for AES-256 as well. Signed-off-by: Akhil Goyal --- drivers/common/cnxk/roc_aes.c | 86 ++--- drivers/comm

[PATCH v5 13/15] net/cnxk: create/destroy MACsec SC/SA

2023-06-14 Thread Akhil Goyal
Added support to create/destroy MACsec SA and SC. Signed-off-by: Akhil Goyal --- drivers/net/cnxk/cn10k_ethdev_sec.c | 9 +- drivers/net/cnxk/cnxk_ethdev_mcs.c | 253 drivers/net/cnxk/cnxk_ethdev_mcs.h | 16 ++ 3 files changed, 274 insertions(+), 4 deletions(-)

[PATCH v5 12/15] net/cnxk: add MACsec initialization

2023-06-14 Thread Akhil Goyal
Added initialization routines for MACsec for cn10kb platform. Signed-off-by: Akhil Goyal --- drivers/net/cnxk/cn10k_ethdev_sec.c | 6 ++ drivers/net/cnxk/cnxk_ethdev.c | 13 +++ drivers/net/cnxk/cnxk_ethdev.h | 14 +++ drivers/net/cnxk/cnxk_ethdev_mcs.c | 151 +

[PATCH v5 15/15] net/cnxk: add MACsec stats

2023-06-14 Thread Akhil Goyal
Added support for MACsec SC/flow/session stats. Signed-off-by: Akhil Goyal --- doc/guides/rel_notes/release_23_07.rst | 10 ++-- drivers/net/cnxk/cn10k_ethdev_sec.c| 11 +++-- drivers/net/cnxk/cnxk_ethdev_mcs.c | 64 ++ drivers/net/cnxk/cnxk_ethdev_mcs.h | 9

[PATCH v5 14/15] net/cnxk: add MACsec session and flow configuration

2023-06-14 Thread Akhil Goyal
Added support for MACsec session/flow create/destroy. Signed-off-by: Akhil Goyal --- drivers/net/cnxk/cn10k_ethdev_sec.c | 11 +- drivers/net/cnxk/cn10k_flow.c | 23 ++- drivers/net/cnxk/cnxk_ethdev.c | 2 + drivers/net/cnxk/cnxk_ethdev.h | 16 ++ drivers/net/cnxk/cnxk_ethde

Re: [PATCH v4 3/4] eal: removed unnecessary checks in x86 power monitor APIs

2023-06-14 Thread Burakov, Anatoly
On 4/18/2023 9:25 AM, Sivaprasad Tummala wrote: current x86 power monitor implementation fails on platforms with only monitor supported and not power_pause. Signed-off-by: Sivaprasad Tummala --- Acked-by: Anatoly Burakov -- Thanks, Anatoly

Re: [PATCH v4 4/4] power: amd power monitor support

2023-06-14 Thread Burakov, Anatoly
On 4/18/2023 9:25 AM, Sivaprasad Tummala wrote: mwaitx allows EPYC processors to enter a implementation dependent power/performance optimized state (C1 state) for a specific period or until a store to the monitored address range. Signed-off-by: Sivaprasad Tummala --- Bar one fix below, Acked

Re: [PATCH v4 2/4] eal: add x86 cpuid support for monitorx

2023-06-14 Thread Burakov, Anatoly
On 4/18/2023 9:25 AM, Sivaprasad Tummala wrote: Add a new CPUID flag to indicate support for monitorx instruction on AMD EPYC processors. Signed-off-by: Sivaprasad Tummala --- Acked-by: Anatoly Burakov -- Thanks, Anatoly

[PATCH] ixgbe: Allow setting IVAR register for X550EM_a

2023-06-14 Thread Vladimir Ratnikov
Fix interrupt mode initialization for X550EM_a revision Signed-off-by: Vladimir Ratnikov --- drivers/net/ixgbe/ixgbe_ethdev.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c b/drivers/net/ixgbe/ixgbe_ethdev.c index 43aea2e16f..d44ef37a7a 100644 --- a/drivers/

[PATCH] eal/interrupts: Allow UIO interrupts when using igb_uio

2023-06-14 Thread Vladimir Ratnikov
Some drivers and devices(ex: igc + i225/i226) use RTE_INTR_HANDLE_UIO handler when captured under igb_uio so just let them use it. Signed-off-by: Vladimir Ratnikov --- lib/eal/linux/eal_interrupts.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/lib/eal/linux/eal_interrupts.c b/lib/eal/

Re: [PATCH] usertools: enhance logic to display NUMA

2023-06-14 Thread Thomas Monjalon
14/06/2023 12:48, Ferruh Yigit: > Should we document preferred tool and usage in DPDK, if so where is good > location for it? I think it should be in the user guide. We are starting to merge the 3 user guides in 1. You can add it to the Linux guide only for now.

[PATCH 0/5] cleanup in library header files

2023-06-14 Thread Thomas Monjalon
While pulling some trees for DPDK 23.07-rc1, I've seen that some wrong coding style for comments were copied over and over. In order to avoid copying wrong comment style, the three first patches are fixing a lot of comments. As it is not critical, they are not marked for backport. While looking t

[PATCH 1/5] lib: remove blank line ending comment blocks

2023-06-14 Thread Thomas Monjalon
At the end of a comment, no need for an extra line. This pattern was fixed with the following command: git ls lib | xargs sed -i '/^ *\* *$/{N;/ *\*\/ *$/D;}' Signed-off-by: Thomas Monjalon --- lib/bbdev/rte_bbdev.h | 2 -- lib/bbdev/rte_bbdev_op.h| 1 - lib/

[PATCH 2/5] lib: remove extra asterisks ending comment blocks

2023-06-14 Thread Thomas Monjalon
A comment should always be terminated with */ Extra asterisks were found with this kind of command: git grep '\* *\*/' lib Signed-off-by: Thomas Monjalon --- lib/cfgfile/rte_cfgfile.h | 2 +- lib/cryptodev/rte_crypto_sym.h | 2 +- lib/cryptodev/rte_cryptodev.h | 4 ++--

[PATCH 3/5] lib: align comment blocks

2023-06-14 Thread Thomas Monjalon
Some comment blocks were missing a space or had too many spaces at the beginning of the lines, resulting in misalignment of asterisks. Such mistakes were found with this kind of commands: git grep '^\*' lib git grep '^ *\*' lib Signed-off-by: Thomas Monjalon --- lib/acl/acl_ge

[PATCH 4/5] lib: restrict use of keyword extern

2023-06-14 Thread Thomas Monjalon
Variable declarations in header files are using extern, it is valid. But function declarations do not need the keyword extern. Also, extern "C" should have a space after the keyword extern. Signed-off-by: Thomas Monjalon --- lib/acl/acl.h | 2 +- lib/bpf/bpf_impl.h|

[PATCH 5/5] cryptodev: fix comments of modular operation parameters

2023-06-14 Thread Thomas Monjalon
The Doxygen comments are made after the struct field, but were missing the Doxygen syntax /**<. Fixes: 518a974bfecc ("cryptodev: reorganize asymmetric structs") Cc: sta...@dpdk.org Signed-off-by: Thomas Monjalon --- lib/cryptodev/rte_crypto_asym.h | 4 ++-- 1 file changed, 2 insertions(+), 2 de

Re: [PATCH 0/5] cleanup in library header files

2023-06-14 Thread Jerin Jacob
On Wed, Jun 14, 2023 at 8:01 PM Thomas Monjalon wrote: > > While pulling some trees for DPDK 23.07-rc1, > I've seen that some wrong coding style for comments > were copied over and over. > > In order to avoid copying wrong comment style, > the three first patches are fixing a lot of comments. > As

Re: [PATCH 0/5] cleanup in library header files

2023-06-14 Thread Bruce Richardson
On Wed, Jun 14, 2023 at 04:26:46PM +0200, Thomas Monjalon wrote: > While pulling some trees for DPDK 23.07-rc1, > I've seen that some wrong coding style for comments > were copied over and over. > > In order to avoid copying wrong comment style, > the three first patches are fixing a lot of commen

[PATCH] buildtools: remove assumption about current work dir

2023-06-14 Thread Bruce Richardson
According to meson documentation, we should not make any assumptions as to what directory a script is called from[1]. The use of "relpath" when processing the output of directory globbing is therefore unsafe, as it was stripping off paths relative to the current directory - which just happened to b

Re: [PATCH 0/5] cleanup in library header files

2023-06-14 Thread David Marchand
On Wed, Jun 14, 2023 at 4:42 PM Jerin Jacob wrote: > > On Wed, Jun 14, 2023 at 8:01 PM Thomas Monjalon wrote: > > > > While pulling some trees for DPDK 23.07-rc1, > > I've seen that some wrong coding style for comments > > were copied over and over. > > > > In order to avoid copying wrong comment

[PATCH] ethdev: rename functions checking queue validity

2023-06-14 Thread Thomas Monjalon
Two functions helping to check Rx/Tx queues validity were added in DPDK 23.07-rc1. As the release is not closed, it is still time to rename. The name proposed originally rte_eth_dev_is_valid_*xq is consistent with this function: rte_eth_dev_is_valid_port() However, the suffixes "rx

Re: [PATCH] ethdev: rename functions checking queue validity

2023-06-14 Thread Ferruh Yigit
On 6/14/2023 4:20 PM, Thomas Monjalon wrote: > Two functions helping to check Rx/Tx queues validity > were added in DPDK 23.07-rc1. > As the release is not closed, it is still time to rename. > > The name proposed originally > rte_eth_dev_is_valid_*xq > is consistent with this function: >

Re: [PATCH 0/5] cleanup in library header files

2023-06-14 Thread Thomas Monjalon
14/06/2023 17:08, David Marchand: > On Wed, Jun 14, 2023 at 4:42 PM Jerin Jacob wrote: > > > > On Wed, Jun 14, 2023 at 8:01 PM Thomas Monjalon wrote: > > > > > > While pulling some trees for DPDK 23.07-rc1, > > > I've seen that some wrong coding style for comments > > > were copied over and over.

[PATCH v15 00/16] graph enhancement for multi-core dispatch

2023-06-14 Thread Zhirun Yan
V15: Fix build issues. (add unused macro in patch 10 then remove in patch 11, fix log message format in patch 01, rm wrong assert in dispatch_walk in patch 12) V14: Rebase to main and fix build issues.(align header name in patch 01,02) V13: Add sub header into meson indirect_headers list to expo

[PATCH v15 01/16] graph: rename rte graph worker header as common

2023-06-14 Thread Zhirun Yan
Rename rte_graph_work.h to rte_graph_work_common.h for supporting multiple graph worker model. Signed-off-by: Haiyue Wang Signed-off-by: Cunming Liang Signed-off-by: Zhirun Yan Acked-by: Jerin Jacob --- MAINTAINERS | 3 ++- app/test/test_graph.c

[PATCH v15 02/16] graph: split graph worker into common and default model

2023-06-14 Thread Zhirun Yan
To support multiple graph worker model, split graph into common and default. Naming the current walk function as rte_graph_model_rtc cause the default model is RTC(Run-to-completion). Signed-off-by: Haiyue Wang Signed-off-by: Cunming Liang Signed-off-by: Zhirun Yan Acked-by: Jerin Jacob --- a

[PATCH v15 03/16] graph: move node process into inline function

2023-06-14 Thread Zhirun Yan
Node process is a single and reusable block, move the code into an inline function. Signed-off-by: Haiyue Wang Signed-off-by: Cunming Liang Signed-off-by: Zhirun Yan Acked-by: Jerin Jacob --- lib/graph/rte_graph_model_rtc.h | 20 ++--- lib/graph/rte_graph_worker_common.h | 33

[PATCH v15 04/16] graph: add get/set graph worker model APIs

2023-06-14 Thread Zhirun Yan
Add new get/set APIs to configure graph worker model which is used to determine which model will be chosen. Signed-off-by: Haiyue Wang Signed-off-by: Cunming Liang Signed-off-by: Zhirun Yan Acked-by: Jerin Jacob --- lib/graph/meson.build | 1 + lib/graph/rte_graph_worker.c

[PATCH v15 05/16] graph: introduce graph node core affinity API

2023-06-14 Thread Zhirun Yan
Add lcore_id for node to hold affinity core id and impl rte_graph_model_mcore_dispatch_lcore_affinity_set to set node affinity with specific lcore. Signed-off-by: Haiyue Wang Signed-off-by: Cunming Liang Signed-off-by: Zhirun Yan Acked-by: Jerin Jacob --- lib/graph/graph_private.h

[PATCH v15 06/16] graph: introduce graph bind unbind API

2023-06-14 Thread Zhirun Yan
Add lcore_id for graph to hold affinity core id where graph would run on. Add bind/unbind API to set/unset graph affinity attribute. lcore_id will be set as MAX by default, it means not enable this attribute. Signed-off-by: Haiyue Wang Signed-off-by: Cunming Liang Signed-off-by: Zhirun Yan Acke

[PATCH v15 07/16] graph: move node clone name func into private as common

2023-06-14 Thread Zhirun Yan
Move clone_name() into graph_private.h as a common function for both node and graph to naming a new cloned object. Signed-off-by: Haiyue Wang Signed-off-by: Cunming Liang Signed-off-by: Zhirun Yan Acked-by: Jerin Jacob --- lib/graph/graph_private.h | 41 +++

[PATCH v15 08/16] graph: introduce graph clone API for other worker core

2023-06-14 Thread Zhirun Yan
This patch adds graph API for supporting to clone the graph object for a specified worker core. The new graph will also clone all nodes. Signed-off-by: Haiyue Wang Signed-off-by: Cunming Liang Signed-off-by: Zhirun Yan Acked-by: Jerin Jacob --- lib/graph/graph.c | 89 +

[PATCH v15 09/16] graph: add structure for stream moving between cores

2023-06-14 Thread Zhirun Yan
Add graph_mcore_dispatch_wq_node to hold graph scheduling workqueue node. Signed-off-by: Haiyue Wang Signed-off-by: Cunming Liang Signed-off-by: Zhirun Yan --- lib/graph/graph.c | 2 ++ lib/graph/graph_populate.c | 1 + lib/graph/graph_private.h | 12

[PATCH v15 10/16] graph: introduce stream moving cross cores

2023-06-14 Thread Zhirun Yan
This patch introduces key functions to allow a worker thread to enable enqueue and move streams of objects to the next nodes over different cores for mcore dispatch model. Signed-off-by: Haiyue Wang Signed-off-by: Cunming Liang Signed-off-by: Zhirun Yan Acked-by: Pavan Nikhilesh --- lib/graph

[PATCH v15 11/16] graph: enable create and destroy graph scheduling workqueue

2023-06-14 Thread Zhirun Yan
This patch enables to create and destroy scheduling workqueue into common graph operations. Signed-off-by: Haiyue Wang Signed-off-by: Cunming Liang Signed-off-by: Zhirun Yan Acked-by: Pavan Nikhilesh --- lib/graph/graph.c | 11 ++- 1 file changed, 10 insertions(+), 1 deletion(-) diff

[PATCH v15 12/16] graph: introduce graph walk by cross-core dispatch

2023-06-14 Thread Zhirun Yan
This patch introduces the task scheduler mechanism to enable dispatching tasks to another worker cores. Currently, there is only a local work queue for one graph to walk. We introduce a scheduler worker queue in each worker core for dispatching tasks. It will perform the walk on scheduler work queu

[PATCH v15 13/16] graph: enable graph multicore dispatch scheduler model

2023-06-14 Thread Zhirun Yan
This patch enables to chose new scheduler model. Must define RTE_GRAPH_MODEL_SELECT before including rte_graph_worker.h to enable specific model choosing. Signed-off-by: Haiyue Wang Signed-off-by: Cunming Liang Signed-off-by: Zhirun Yan Acked-by: Jerin Jacob Acked-by: Pavan Nikhilesh --- doc

[PATCH v15 14/16] graph: add stats for mcore dispatch model

2023-06-14 Thread Zhirun Yan
Add stats for mcore dispatch model if stats collection is enabled. Signed-off-by: Haiyue Wang Signed-off-by: Cunming Liang Signed-off-by: Zhirun Yan Acked-by: Jerin Jacob Acked-by: Pavan Nikhilesh --- lib/graph/graph_debug.c| 6 ++ lib/graph/graph_stats.c

[PATCH v15 15/16] test/graph: add functional tests for mcore dispatch model

2023-06-14 Thread Zhirun Yan
Add functional test for mcore dispatch model including graph clone, graph model set/get, node worker affinity, graph worker binding/unbinding. Signed-off-by: Haiyue Wang Signed-off-by: Cunming Liang Signed-off-by: Zhirun Yan Acked-by: Pavan Nikhilesh --- app/test/test_graph.c | 130 ++

[PATCH v15 16/16] examples/l3fwd-graph: introduce mcore dispatch worker model

2023-06-14 Thread Zhirun Yan
Add new parameter "model" to choose mcore dispatch or rtc model. And in dispatch model, the node will affinity to worker core successively. RTE_GRAPH_MODEL_SELECT is set to RTE_GRAPH_MODEL_RTC by default. Must set model the same as RTE_GRAPH_MODEL_SELECT if set it as rtc or mcore dispatch explicit

Re: [PATCH] ethdev: rename functions checking queue validity

2023-06-14 Thread Stephen Hemminger
On Wed, 14 Jun 2023 17:20:59 +0200 Thomas Monjalon wrote: > Two functions helping to check Rx/Tx queues validity > were added in DPDK 23.07-rc1. > As the release is not closed, it is still time to rename. > > The name proposed originally > rte_eth_dev_is_valid_*xq > is consistent with this

RE: [RFC PATCH] ethdev: advertise flow restore in mbuf

2023-06-14 Thread Slava Ovsiienko
Hi, David It looks like a good application datapath optimization, as for me. But I see some concerns: 1. Are we sure the PMD should register the flag, not application? IIRC, usually application registers needed flags/fields and PMDs just follow. + if (!sh->tunnel_hub && sh->config.dv_miss_

Reminder - Please submit your DPDK Summit Presentation pitches to our CFP and Register for our September Event!

2023-06-14 Thread Nathan Southern
Good morning DPDK Community, Summer is upon us, and within a few months we will hold our DPDK Summit 2023 in Dublin, Ireland. September 12-13, 2023, at the Gibson Hotel in Point Square. Registration and attendance for this event are *free!* We've put out a CFP now for talks, to be presented to at

RE: [PATCH 1/4] net/mlx5/hws: use the same function to check rule

2023-06-14 Thread Ori Kam
> -Original Message- > From: Alexander Kozyrev > Sent: Monday, June 12, 2023 11:06 PM > To: dev@dpdk.org > Cc: Raslan Darawsheh ; Matan Azrad > ; Slava Ovsiienko ; Ori Kam > ; Erez Shitrit > Subject: [PATCH 1/4] net/mlx5/hws: use the same function to check rule > > From: Erez Shitrit

RE: [PATCH 2/4] net/mlx5/hws: use union in the wqe-data struct

2023-06-14 Thread Ori Kam
> -Original Message- > From: Alexander Kozyrev > Sent: Monday, June 12, 2023 11:06 PM > > From: Erez Shitrit > > To be clear about which field we are going to set. > > Signed-off-by: Erez Shitrit > Reviewed-by: Alex Vesker > --- > drivers/net/mlx5/hws/mlx5dr_send.c | 2 +- > 1 fil

RE: [PATCH 3/4] net/mlx5/hws: support rule update after its creation

2023-06-14 Thread Ori Kam
> -Original Message- > From: Alexander Kozyrev > Sent: Monday, June 12, 2023 11:06 PM > > From: Erez Shitrit > > Add the ability to change rule's actions after the rule already created. > The new actions should be one of the action template list. > That support is only for matcher tha

RE: [PATCH] app/testpmd: add flow update CLI command

2023-06-14 Thread Ori Kam
Hi > -Original Message- > From: Alexander Kozyrev > Sent: Tuesday, June 13, 2023 12:14 AM > > Add testpmd CLI interface for the flow update API. > flow queue 1 update 2 rule 3 actions_template 4 postpone yes > pattern end actions queue index 3 / end > > Signed-off-by: Alexan

[PATCH 0/3] Add event dispatcher

2023-06-14 Thread Mattias Rönnblom
The purpose of the event dispatcher is to decouple different parts of an application (e.g., processing pipeline stages), sharing the same underlying event device. The event dispatcher replaces the conditional logic (often, a switch statement) that typically follows an event device dequeue operatio

[PATCH 1/3] eventdev: introduce event dispatcher

2023-06-14 Thread Mattias Rönnblom
The purpose of the event dispatcher is to help reduce coupling in an Eventdev-based DPDK application. In addition, the event dispatcher also provides a convenient and flexible way for the application to use service cores for application-level processing. Signed-off-by: Mattias Rönnblom Tested-by

[PATCH 2/3] test: add event dispatcher test suite

2023-06-14 Thread Mattias Rönnblom
Add unit tests for the event dispatcher. -- PATCH: o Extend test to cover often-used handler optimization feature. RFC v4: o Adapt to non-const events in process function prototype. Signed-off-by: Mattias Rönnblom --- app/test/meson.build | 1 + app/test/test_event_dispatcher.c

[PATCH 3/3] doc: add event dispatcher programming guide

2023-06-14 Thread Mattias Rönnblom
Provide programming guide the for the event dispatcher. Signed-off-by: Mattias Rönnblom -- PATCH: o Improve grammar and spelling. RFC v4: o Extend event matching section of the programming guide. o Improve grammar and spelling. --- doc/api/doxy-api-index.md | 1 + doc/gui

[PATCH v3] crypto/qat: add SM3 HMAC to gen4 devices

2023-06-14 Thread Arek Kusztal
This commit adds SM3 HMAC to Intel QuickAssist Technology PMD generation 3 and 4 devices. Signed-off-by: Arek Kusztal --- v2: - Fixed problem with chaining operations - Added implementation of prefix tables v3: - Added support for gen3 devices doc/guides/cryptodevs/features/qat.ini | 1

RE: [EXT] [PATCH v2 0/9] crypto/mlx5: support AES-GCM

2023-06-14 Thread Akhil Goyal
> AES-GCM provides both authenticated encryption and the ability to check > the integrity and authentication of additional authenticated data (AAD) > that is sent in the clear. > > The crypto operations are performed with crypto WQE. If the input > buffers(AAD, mbuf, digest) are not contiguous and

Re: [PATCH 1/3] eventdev: introduce event dispatcher

2023-06-14 Thread Stephen Hemminger
On Wed, 14 Jun 2023 19:25:25 +0200 Mattias Rönnblom wrote: > static struct rte_event_dispatcher_handler* > +evd_lcore_get_handler_by_id(struct rte_event_dispatcher_lcore *lcore, > + int handler_id) > +{ > + int i in other places you used uint16_t for iterating over ha

RE: [EXT] [PATCH 0/6] Trivial crypto PMDs cleanup

2023-06-14 Thread Akhil Goyal
> This small series cleans-up some crypto PMD drivers. > Please rebase.

RE: [PATCH v1 1/1] doc: announce change in bbdev api related to operation extension

2023-06-14 Thread Chautru, Nicolas
Hi Maxime, > -Original Message- > From: Maxime Coquelin > Hi, > > On 6/13/23 19:16, Chautru, Nicolas wrote: > > Hi Maxime, > > > >> -Original Message- > >> From: Maxime Coquelin > > > >> > >> On 6/12/23 22:53, Chautru, Nicolas wrote: > >>> Hi Maxime, David, > >>> > -Or

RE: [EXT] [PATCH v5] crypto/qat: default to IPsec MB for computations

2023-06-14 Thread Akhil Goyal
> -IMB_required_ver = '1.2.0' > +IMB_required_ver = '1.4.0' > IMB_header = '#include' > if arch_subdir == 'arm' > IMB_header = '#include' > endif I believe there are compilation issues with arm repo for 1.4 version. It is better to fix that first before making this to default. > libipsec

Re: [PATCH v2 3/3] event/cnxk: use WFE in Tx fc wait

2023-06-14 Thread Patrick Robb
Hello Pavan and Jerin, The Community Lab's CI testing failed this patchseries on clang compile on ARM systems. That wasn't properly reported to Patchwork due to issues with our reporting process, which we are resolving currently. This updated report show the failed compile. Apologies for the incom

RE: [RFC] lib/ethdev: introduce table driven APIs

2023-06-14 Thread Ori Kam
Hi Qi, 1. it may be useful to get some general calling flow what comes from the application, what comes from the compiler. Simple example will be good. 2. I gave some comments about names but those are in low priority, first, we need to understand what is the basic flow. 3. in your suggested A

RE: [EXT] [PATCH v6] crypto/qat: support to enable insecure algorithms

2023-06-14 Thread Akhil Goyal
> All the insecure algorithms are default disable from > cryptodev Gen 1,2,3 and 4. > use qat_legacy_capa to enable all the legacy > algorithms. > These change effects both sym and asym insecure crypto > algorithms. > > Signed-off-by: Vikash Poddar > --- > Depends-on: patch-28182 ("[v2] common/qa

RE: [EXT] [PATCH] crypto/openssl: add aes-xts support

2023-06-14 Thread Akhil Goyal
> Add aes-128-xts and aes-256-xts support for crypto openssl pmd. As xts mode > we got 2 key, the key length is multiplied by two, i.e. 32 and 64. > > Signed-off-by: Michael Leung > --- Fix checkpatch issues Also update doc/guides/cryptodevs/features/openssl.ini

RE: [EXT] [PATCH] crypto/openssl: add aes-xts support

2023-06-14 Thread Akhil Goyal
++Kai for review. > -Original Message- > From: Akhil Goyal > Sent: Thursday, June 15, 2023 12:21 AM > To: Michael Leung ; dev@dpdk.org > Subject: RE: [EXT] [PATCH] crypto/openssl: add aes-xts support > > > Add aes-128-xts and aes-256-xts support for crypto openssl pmd. As xts mode > > we

Re: [dpdk-dev] [PATCH 1/1] build: allow disabling libs

2023-06-14 Thread Stephen Hemminger
On Fri, 18 Sep 2020 14:57:50 +0100 Bruce Richardson wrote: > On Fri, Sep 18, 2020 at 02:54:21PM +0200, Mohammed Hawari wrote: > > Hello Bruce, > > > > Thanks for the quick response, see inline > > > > Best regards, > > > > Mohammed > > > > > On 18 Sep 2020, at 13:43, Bruce Richardson > >

RE: [EXT] [PATCH v2 resend] crypto/uadk: set queue pair in dev_configure

2023-06-14 Thread Akhil Goyal
> By default, uadk only alloc two queues for each algorithm, which > will impact performance. > Set queue pair number as required in dev_configure. > The default max queue pair number is 8, which can be modified > via para: max_nb_queue_pairs > > Example: > sudo dpdk-test-crypto-perf -l 0-10 --vde

Re: [dpdk-dev] [PATCH v2] eal/windows: Switched to an external pthreads library

2023-06-14 Thread Stephen Hemminger
On Thu, 24 Sep 2020 12:41:01 +0100 John Alexander wrote: > The Windows EAL build now pulls in the pthreads4w project as an external > subproject. The pthreads4w subproject does not currently provide a > meson build so the project has been patched with one. > > Removed the placeholder librte_eal

Re: [dpdk-dev] [PATCH v7] eal: add manual probing option

2023-06-14 Thread Stephen Hemminger
On Thu, 23 Jan 2020 10:58:13 +0100 Gaetan Rivet wrote: > Add a new EAL option enabling manual probing in the EAL. > This command line option will configure the EAL so that buses > will not trigger their probe step on their own. > > Applications are then expected to hotplug devices as they see fi

Re: [dpdk-dev] [PATCH v4 0/4] add unit tests for eal vfio library

2023-06-14 Thread Stephen Hemminger
On Wed, 4 Sep 2019 13:04:38 +0100 Chaitanya Babu Talluri wrote: > 1/4: fix vfio unmap that fails unexpectedly > 2/4: fix vfio unmap that succeeds unexpectedly > 3/4: add API to check iommu type is set > 4/4: add unit tests for eal vfio > > Patch 4/4 depends on 1/4,2/4,3/4 > > Signed-off-by: Ch

Re: [dpdk-dev] [PATCH 0/3] fix error path of multi-process probe

2023-06-14 Thread Stephen Hemminger
On Sat, 2 Mar 2019 03:42:50 +0100 Thomas Monjalon wrote: > While working on multi-process support of failsafe with Raslan, > some issues have been discovered on probing failures. > > Thomas Monjalon (3): > eal: remove useless checks for already probed device > eal: remove error logs for alr

Re: [dpdk-dev] [PATCH 0/8] Introduce emudev library and iavf emudev driver

2023-06-14 Thread Stephen Hemminger
On Fri, 18 Dec 2020 15:47:28 +0800 Chenbo Xia wrote: > This series introduces a new device abstraction called emudev for emulated > devices. A new library (librte_emudev) is implemented. The first emudev > driver is also introduced, which emulates Intel Adaptive Virtual Function > (iavf) as a sof

[PATCH] drivers/cnxk: disable asm operand width warning

2023-06-14 Thread pbhagavatula
From: Pavan Nikhilesh Disable -Wasm-operand-widths when using clang. Fixes: 1c80eb7a3ccc ("event/cnxk: use WFE in Tx flow control wait") Signed-off-by: Pavan Nikhilesh --- Jerin, Please squash this to 1c80eb7a3ccc. drivers/event/cnxk/meson.build | 4 drivers/net/cnxk/meson.build | 3

RE: [EXT] Re: [PATCH v2 3/3] event/cnxk: use WFE in Tx fc wait

2023-06-14 Thread Pavan Nikhilesh Bhagavatula
Thanks Patrick, I have sent out a fix. https://mails.dpdk.org/archives/dev/2023-June/271209.html Pavan. From: Patrick Robb Sent: Wednesday, June 14, 2023 11:57 PM To: Jerin Jacob Cc: Pavan Nikhilesh Bhagavatula ; Jerin Jacob Kollanukkaran ; Shijith Thotton ; Nithin Kumar Dabilpuram ; Kira

Re: [dpdk-dev] [RFC] net: make eCPRI header host network order

2023-06-14 Thread Stephen Hemminger
On Fri, 27 Nov 2020 19:09:20 + Ferruh Yigit wrote: > Other protocol structs are in the host byte order, having eCPRI in > network byte order is insistent and error prone. > > Making eCPRI protocol header host byte order. > > Signed-off-by: Haiyue Wang > Signed-off-by: Ferruh Yigit The di

  1   2   >