Re: [PATCH 2/2] lib: make graph optional

2023-06-20 Thread David Marchand
On Tue, Jun 20, 2023 at 8:56 AM Jerin Jacob wrote: > > On Tue, Jun 20, 2023 at 2:17 AM David Marchand > wrote: > > > > Allow disabling of the graph library in builds. > > Good to make graph as optional. > I did not check the build, will examples/l3fwd-graph/ skip automatically ? Yes. Each exampl

[PATCH v8] app/dma-perf: introduce dma-perf application

2023-06-20 Thread Cheng Jiang
There are many high-performance DMA devices supported in DPDK now, and these DMA devices can also be integrated into other modules of DPDK as accelerators, such as Vhost. Before integrating DMA into applications, developers need to know the performance of these DMA devices in various scenarios and

RE: [EXT] [PATCH v7 1/3] common/qat: fix qat_dev_cmd_param corruption

2023-06-20 Thread Akhil Goyal
> Adding fix to address the memory corruption issue for > qat_dev_cmd_param structure on QAT GEN3. > > This fix aligns the storage where it stores the value > on 4 byte unsigned integer data type after > reading slice configuration of QAT capabilities. > > Fixes: b3cbbcdffa4f ("common/qat: read H

RE: [PATCH v5] gro : fix reordering of packets in GRO library

2023-06-20 Thread Hu, Jiayu
Hi Kumara, Please see replies inline. Thanks, Jiayu > -Original Message- > From: Kumara Parameshwaran > Sent: Tuesday, November 1, 2022 3:06 PM > To: Hu, Jiayu > Cc: dev@dpdk.org; Kumara Parameshwaran > ; Kumara Parameshwaran > > Subject: [PATCH v5] gro : fix reordering of packets in

[PATCH v2 0/6] Trivial crypto PMDs cleanup

2023-06-20 Thread Maxime Coquelin
This small series cleans-up some crypto PMD drivers. Changes in v2: == - Rebased on top of next-crypto - Fix typo in commit message (patch 4) - Applied A-by's & R-by's Maxime Coquelin (6): crypto/qat: fix sym device prototype crypto/qat: remove security lib presence checks crypt

[PATCH v2 2/6] crypto/qat: remove security lib presence checks

2023-06-20 Thread Maxime Coquelin
Since security library is a required dependency for building QAT crypto PMD, remove useless #ifdefs around rte_security APIs calls. Signed-off-by: Maxime Coquelin --- drivers/common/qat/qat_qp.c | 2 -- drivers/crypto/qat/dev/qat_crypto_pmd_gen2.c | 3 --- drivers/crypto/qat/d

[PATCH v2 3/6] crypto/dpaa2_sec: remove security lib presence checks

2023-06-20 Thread Maxime Coquelin
Since security library is a required dependency for building DPAA2 crypto PMD, remove useless #ifdefs around rte_security APIs calls. Acked-by: Hemant Agrawal Signed-off-by: Maxime Coquelin --- drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c | 36 ++--- drivers/crypto/dpaa2_sec/dpaa

[PATCH v2 1/6] crypto/qat: fix sym device prototype

2023-06-20 Thread Maxime Coquelin
qat_dev_cmd_param parameter of qat_sym_dev_create() was wrongly marked as unused, this patch fixes it. Fixes: fb3b9f492205 ("crypto/qat: rework burst data path") Cc: sta...@dpdk.org Acked-by: Tyler Retzlaff Acked-by: Fan Zhang Signed-off-by: Maxime Coquelin --- drivers/crypto/qat/qat_sym.c |

[PATCH v2 4/6] crypto/dpaa_sec: remove security lib presence checks

2023-06-20 Thread Maxime Coquelin
Since security library is a required dependency for building DPAA crypto PMD, remove useless #ifdefs around rte_security APIs calls. Acked-by: Hemant Agrawal Signed-off-by: Maxime Coquelin --- drivers/crypto/dpaa_sec/dpaa_sec.c| 26 ++- drivers/crypto/dpaa_sec/dpaa_s

[PATCH v2 5/6] crypto/ipsec_mb: remove security lib presence checks

2023-06-20 Thread Maxime Coquelin
Since security library is a required dependency for building ipsec_mb crypto PMD, remove useless check before security lib headers inclusion. The patch also takes the opportunity to remove unused related defines. Signed-off-by: Maxime Coquelin --- drivers/crypto/ipsec_mb/ipsec_mb_private.h | 3

[PATCH v2 6/6] crypto/qat: remove useless log level checks

2023-06-20 Thread Maxime Coquelin
qat_sym_debug_log_dump() being stubbed if log level is less than debug, it is not necessary to check the log level before calling it. Acked-by: Fan Zhang Signed-off-by: Maxime Coquelin --- drivers/crypto/qat/dev/qat_crypto_pmd_gen3.c | 9 +-- drivers/crypto/qat/dev/qat_crypto_pmd_gen4.c |

Re: [EXT] [PATCH 0/6] Trivial crypto PMDs cleanup

2023-06-20 Thread Maxime Coquelin
Hi Akhil, On 6/20/23 08:49, Akhil Goyal wrote: Hi Maxime, Can you please rebase on next-crypto? The series does not apply. Thanks for the heads-up, v2 posted. Maxime Regards, Akhil -Original Message- From: Akhil Goyal Sent: Wednesday, June 14, 2023 11:47 PM To: Maxime Coquelin ;

RE: [PATCH v2 5/8] crypto/cnxk: add support for raw APIs

2023-06-20 Thread Akhil Goyal
> Subject: [PATCH v2 5/8] crypto/cnxk: add support for raw APIs > > From: Anoob Joseph > > Add crypto RAW API support in cnxk PMD > Enable the flag to allow execution of raw test suite. > > Signed-off-by: Vidya Sagar Velumuri > Signed-off-by: Anoob Joseph > --- > doc/guides/rel_notes/release

[Bug 1083] [aarch64] crypto/openssl build failure in Ubuntu 22.04

2023-06-20 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=1083 Ali Alnubani (alia...@nvidia.com) changed: What|Removed |Added Status|UNCONFIRMED |RESOLVED Resolution|-

Re: [PATCH 2/2] lib: make graph optional

2023-06-20 Thread Bruce Richardson
On Mon, Jun 19, 2023 at 10:46:50PM +0200, David Marchand wrote: > Allow disabling of the graph library in builds. > > Signed-off-by: David Marchand > --- > app/test/meson.build | 12 +++- > lib/meson.build | 1 + > 2 files changed, 8 insertions(+), 5 deletions(-) > Acked-by: Bruce

Re: [PATCH v4 3/3] ring: add telemetry cmd for ring info

2023-06-20 Thread Jie Hai
On 2023/2/20 20:55, David Marchand wrote: On Fri, Feb 10, 2023 at 3:50 AM Jie Hai wrote: This patch supports dump of ring information by its name. An example using this command is shown below: --> /ring/info,MP_mb_pool_0 { "/ring/info": { "name": "MP_mb_pool_0", "socket": 0,

Re: [PATCH 2/2] lib: make graph optional

2023-06-20 Thread Jerin Jacob
On Tue, Jun 20, 2023 at 1:40 PM Bruce Richardson wrote: > > On Mon, Jun 19, 2023 at 10:46:50PM +0200, David Marchand wrote: > > Allow disabling of the graph library in builds. > > > > Signed-off-by: David Marchand > > --- > > app/test/meson.build | 12 +++- > > lib/meson.build | 1

RE: [EXT] [PATCH v3] crypto/qat: add SM3 HMAC to gen4 devices

2023-06-20 Thread Akhil Goyal
> This commit adds SM3 HMAC to Intel QuickAssist Technology PMD > generation 3 and 4 devices. > > Signed-off-by: Arek Kusztal Please be consistent in the signoff names with the .mailmap file. > --- > v2: > - Fixed problem with chaining operations > - Added implementation of prefix tables >

Re: [PATCH v3] build: select optional libraries

2023-06-20 Thread David Marchand
On Mon, Jun 19, 2023 at 4:26 PM Bruce Richardson wrote: > > On Mon, Jun 19, 2023 at 04:11:37PM +0200, David Marchand wrote: > > On Fri, Jun 16, 2023 at 9:21 AM David Marchand > > wrote: > > > @@ -141,13 +137,25 @@ foreach l:libraries > > > deps += ['eal'] > > > endif > > > > > > -

Re: [PATCH v3] build: select optional libraries

2023-06-20 Thread Bruce Richardson
On Tue, Jun 20, 2023 at 10:31:19AM +0200, David Marchand wrote: > On Mon, Jun 19, 2023 at 4:26 PM Bruce Richardson > wrote: > > > > On Mon, Jun 19, 2023 at 04:11:37PM +0200, David Marchand wrote: > > > On Fri, Jun 16, 2023 at 9:21 AM David Marchand > > > wrote: > > > > @@ -141,13 +137,25 @@ forea

Re: [PATCH v3] build: select optional libraries

2023-06-20 Thread David Marchand
On Tue, Jun 20, 2023 at 10:36 AM Bruce Richardson wrote: > On Tue, Jun 20, 2023 at 10:31:19AM +0200, David Marchand wrote: > > On Mon, Jun 19, 2023 at 4:26 PM Bruce Richardson > > wrote: > > > > > > On Mon, Jun 19, 2023 at 04:11:37PM +0200, David Marchand wrote: > > > > On Fri, Jun 16, 2023 at 9:

Re: [PATCH v3] build: select optional libraries

2023-06-20 Thread Bruce Richardson
On Tue, Jun 20, 2023 at 10:38:33AM +0200, David Marchand wrote: > On Tue, Jun 20, 2023 at 10:36 AM Bruce Richardson > wrote: > > On Tue, Jun 20, 2023 at 10:31:19AM +0200, David Marchand wrote: > > > On Mon, Jun 19, 2023 at 4:26 PM Bruce Richardson > > > wrote: > > > > > > > > On Mon, Jun 19, 2023

Re: [PATCH v3] build: select optional libraries

2023-06-20 Thread David Marchand
On Tue, Jun 20, 2023 at 10:45 AM Bruce Richardson wrote: > > > > > I notice the change in behaviour for enabling the deprecated libs. Is > > > > > there > > > > > any other change in behaviour for current users? > > > > > > > > The only change I see, is that this implementation breaks enabling >

[PATCH] common/cnxk/roc_npa: fix npa_aura_fini

2023-06-20 Thread Thierry Herbelot
Unlock mbox when an error is detected. Fixes: ea4d70cc4f0b46d5 ('common/cnxk: add NPA aura create/destroy ROC APIs') Signed-off-by: Thierry Herbelot --- drivers/common/cnxk/roc_npa.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/common/cnxk/roc_npa.c b/drivers

RE: [EXT] [PATCH v2 0/6] Trivial crypto PMDs cleanup

2023-06-20 Thread Akhil Goyal
> This small series cleans-up some crypto PMD drivers. > > Changes in v2: > == > - Rebased on top of next-crypto > - Fix typo in commit message (patch 4) > - Applied A-by's & R-by's Series applied to dpdk-next-crypto Thanks.

Re: [PATCH v3] build: select optional libraries

2023-06-20 Thread Bruce Richardson
On Tue, Jun 20, 2023 at 10:48:50AM +0200, David Marchand wrote: > On Tue, Jun 20, 2023 at 10:45 AM Bruce Richardson > wrote: > > > > > > I notice the change in behaviour for enabling the deprecated libs. > > > > > > Is there > > > > > > any other change in behaviour for current users? > > > > > >

[PATCH] doc: update IPsec Multi-buffer version for Arm

2023-06-20 Thread Ruifeng Wang
Updated SNOW3G and ZUC PMD documentation guides with information about the latest library version supported. Signed-off-by: Ruifeng Wang --- doc/guides/cryptodevs/snow3g.rst | 2 +- doc/guides/cryptodevs/zuc.rst| 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/doc/guides

RE: [EXT] [PATCH v3 9/9] crypto/mlx5: enable AES-GCM capability

2023-06-20 Thread Akhil Goyal
> This commit generates AES-GCM capability based on the NIC > attributes and enables AES-GCM algo. > > An new devarg "algo" is added to identify if the crypto PMD will > be initialized as AES-GCM(algo=1) or AES-XTS(algo=0, default). > > Signed-off-by: Suanming Mou You should mention changelog f

[PATCH v4] crypto/qat: add SM3 HMAC to gen4 devices

2023-06-20 Thread Arek Kusztal
This commit adds SM3 HMAC to Intel QuickAssist Technology PMD generation 3 and 4 devices. Signed-off-by: Arkadiusz Kusztal Acked-by: Ciara Power --- doc/guides/cryptodevs/features/qat.ini | 1 + doc/guides/cryptodevs/qat.rst| 2 + doc/guides/rel_notes/release_23_07.rst

RE: [EXT] [PATCH] common/cnxk/roc_npa: fix npa_aura_fini

2023-06-20 Thread Ashwin Sekhar T K
Hi Thierry, Could you please add the same fix in npa_aura_pool_fini() as well. Thanks Ashwin Sekhar T K > -Original Message- > From: Thierry Herbelot > Sent: Tuesday, June 20, 2023 2:22 PM > To: dev@dpdk.org > Cc: Thierry Herbelot ; Thomas Monjalon > ; Nithin Kumar Dabilpuram > ; Satha

Re: [PATCH] crypto/openssl: do not build useless workaround

2023-06-20 Thread Ji, Kai
Acked-by: Kai Ji mailto:kai...@intel.com>> From: Didier Pallard Sent: 18 April 2023 15:56 To: dev@dpdk.org Cc: sta...@dpdk.org ; Ji, Kai ; Mrzyglod, Daniel T ; Tomasz Kulasek ; Kobylinski, Michal ; De Lara Guarch, Pablo ; Mrozowicz, SlawomirX Subject: [PATC

Re: [EXT] [PATCH] common/cnxk/roc_npa: fix npa_aura_fini

2023-06-20 Thread Thierry Herbelot
Hello Ashwin, I will resend a patch with a fix also in npa_aura_pool_fini Thierry On 6/20/23 11:27, Ashwin Sekhar T K wrote: Hi Thierry, Could you please add the same fix in npa_aura_pool_fini() as well. Thanks Ashwin Sekhar T K -Original Message- From: Thierry Herbelot Se

Re: [PATCH] common/cnxk/roc_npa: fix npa_aura_fini

2023-06-20 Thread David Marchand
On Tue, Jun 20, 2023 at 10:51 AM Thierry Herbelot wrote: > > Unlock mbox when an error is detected. Out of curiosity, how did you catch it? This issue could probably be caught with clang thread safety checks, but it is disabled on this driver atm. https://git.dpdk.org/dpdk/commit/drivers/common/

[Bug 1254] [dpdk-23.07] iavf performance drop 8%

2023-06-20 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=1254 Bug ID: 1254 Summary: [dpdk-23.07] iavf performance drop 8% Product: DPDK Version: 23.07 Hardware: x86 OS: Linux Status: UNCONFIRMED Severity: normal Pr

[PATCH v2] common/cnxk/roc_npa: unlock mbox in error cases

2023-06-20 Thread Thierry Herbelot
In npa_aura_pool_fini and in npa_aura_fini, Unlock mbox when an error is detected. Fixes: ea4d70cc4f0b46d5 ('common/cnxk: add NPA aura create/destroy ROC APIs') Signed-off-by: Thierry Herbelot -- V2: also patch npa_aura_pool_fini --- drivers/common/cnxk/roc_npa.c | 12 1 file change

RE: [EXT] [PATCH v3 9/9] crypto/mlx5: enable AES-GCM capability

2023-06-20 Thread Suanming Mou
> -Original Message- > From: Akhil Goyal > Sent: Tuesday, June 20, 2023 5:25 PM > To: Suanming Mou ; Matan Azrad > > Cc: Raslan Darawsheh ; dev@dpdk.org > Subject: RE: [EXT] [PATCH v3 9/9] crypto/mlx5: enable AES-GCM capability > > > This commit generates AES-GCM capability based on t

Re: [PATCH v2 2/4] examples/server_node_efd: simplify build configuration

2023-06-20 Thread Thomas Monjalon
13/06/2023 16:06, David Marchand: > Rename sub directories in this example. > This removes the only special case in examples and will ease a next > change. For more clarity, it could be said what is a special case (name of directory different of the generated binary).

[PATCH v3] common/cnxk/roc_npa: unlock mbox in error cases

2023-06-20 Thread Thierry Herbelot
In npa_aura_pool_fini and in npa_aura_fini, Unlock mbox when an error is detected. Fixes: ea4d70cc4f0b46d5 ('common/cnxk: add NPA aura create/destroy ROC APIs') Signed-off-by: Thierry Herbelot -- V2: also patch npa_aura_pool_fini V3: add missing space --- drivers/common/cnxk/roc_npa.c | 12 +

RE: [EXT] Re: [PATCH v2 8/8] crypto/ipsec_mb: set and use session ID

2023-06-20 Thread Fangming Fang
> From: Akhil Goyal > Subject: RE: [EXT] Re: [PATCH v2 8/8] crypto/ipsec_mb: set and use session ID > > > > > > > > > > > > > For info, this does not compile with > > > > > > https://urldefense.proofpoint.com/v2/url?u=https- > > 3A__git.gitlab.arm.com_arm-2Dreference-2Dsolutions_ipsec- > > > 2Dmb&

Re: [PATCH v2 3/4] devtools: build all examples externally

2023-06-20 Thread Thomas Monjalon
13/06/2023 16:06, David Marchand: > + sed -ne > "s,$srcdir/examples/\([^/]*\)\(/.*\|\)/$target/Makefile,\1,p" I think -e is not needed. If you use -r, you can avoid backslashing the parentheses.

RE: [EXT] [PATCH v3 9/9] crypto/mlx5: enable AES-GCM capability

2023-06-20 Thread Akhil Goyal
> > You should mention changelog for the changes done in the current patchset > over > > previous one. > > It helps in review. > > V1 is RFC, V1 compared to V2 was xts and gcm file split. V3 just did a minor > fix in > aes-gcm 256 key creation. > I put the change log in the cover-letter, but than

Re: [PATCH] common/cnxk/roc_npa: fix npa_aura_fini

2023-06-20 Thread Thierry Herbelot
Hello David, I added a trace in mbox_get() to print when a mbox lock was already locked. The traces were displayed when running an internal CI/CD test suite. Best regards Thierry On 6/20/23 11:32, David Marchand wrote: On Tue, Jun 20, 2023 at 10:51 AM Thierry Herbelot wrote:

Re: [PATCH v2 3/4] devtools: build all examples externally

2023-06-20 Thread David Marchand
On Tue, Jun 20, 2023 at 11:45 AM Thomas Monjalon wrote: > > 13/06/2023 16:06, David Marchand: > > + sed -ne > > "s,$srcdir/examples/\([^/]*\)\(/.*\|\)/$target/Makefile,\1,p" > > I think -e is not needed. Indeed. > If you use -r, you can avoid backslashing the parentheses. -r is not

RE: [PATCH v2 0/9] crypto/mlx5: support AES-GCM

2023-06-20 Thread Suanming Mou
Hi Akhil, Maybe due to "To" is empty, it was not collected correctly to the ML. But it was in my inbox, and you were cced. Thanks, Suanming > -Original Message- > From: Suanming Mou > Sent: Tuesday, June 20, 2023 9:23 AM > Cc: Raslan Darawsheh ; dev@dpdk.org; > gak...@marvell.com > Sub

Re: [PATCH v5 2/3] common/sfc_efx/base: add support to enable VLAN stripping

2023-06-20 Thread Artemii Morozov
On 6/19/23 14:28, Andrew Rybchenko wrote: On 6/13/23 18:12, Artemii Morozov wrote: To enable VLAN stripping, two conditions must be met: the corresponding flag must be set and the appropriate RX prefix should be requested. RX -> Rx VLAN stripping is supported for ef100 datapath only. "ef1

[dpdk-dev] [PATCH v1] doc: fix ip6 node API doxygen generation

2023-06-20 Thread jerinj
From: Jerin Jacob Add ip6 node public API to doxygen list. Fixes: 20365d793e45 ("node: add IPv6 lookup node") Cc: Sunil Kumar Kori Cc: Amit Prakash Shukla Cc: Nithin Dabilpuram Signed-off-by: Jerin Jacob --- doc/api/doxy-api-index.md | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)

RE: [EXT] [PATCH v3 9/9] crypto/mlx5: enable AES-GCM capability

2023-06-20 Thread Suanming Mou
> -Original Message- > From: Akhil Goyal > Sent: Tuesday, June 20, 2023 5:48 PM > To: Suanming Mou ; Matan Azrad > > Cc: Raslan Darawsheh ; dev@dpdk.org > Subject: RE: [EXT] [PATCH v3 9/9] crypto/mlx5: enable AES-GCM capability > > > > You should mention changelog for the changes done

RE: [PATCH v2 0/9] crypto/mlx5: support AES-GCM

2023-06-20 Thread Akhil Goyal
Hi Suanming, > Hi Akhil, > > Maybe due to "To" is empty, it was not collected correctly to the ML. But it > was > in my inbox, and you were cced. > This is a v2 cover-letter as per the title.

Re: [PATCH v2 2/4] examples/server_node_efd: simplify build configuration

2023-06-20 Thread David Marchand
On Tue, Jun 20, 2023 at 11:42 AM Thomas Monjalon wrote: > > 13/06/2023 16:06, David Marchand: > > Rename sub directories in this example. > > This removes the only special case in examples and will ease a next > > change. > > For more clarity, it could be said what is a special case > (name of dir

Re: [PATCH] crypto/openssl: fix memory leak in auth processing function

2023-06-20 Thread Ji, Kai
Acked-by: Kai Ji mailto:kai...@intel.com>> > -Original Message- > From: Didier Pallard > Sent: Tuesday 18 April 2023 15:26 > To: dev@dpdk.org > Cc: sta...@dpdk.org; Ji, Kai ; Akhil Goyal > ; Fan Zhang ; Ashwin > Sekhar T K > Subject: [PATCH] crypto/openssl: fix memory leak in auth proce

RE: [PATCH v2 0/9] crypto/mlx5: support AES-GCM

2023-06-20 Thread Suanming Mou
> -Original Message- > From: Akhil Goyal > Sent: Tuesday, June 20, 2023 5:59 PM > To: Suanming Mou > Cc: Raslan Darawsheh ; dev@dpdk.org > Subject: RE: [PATCH v2 0/9] crypto/mlx5: support AES-GCM > > Hi Suanming, > > Hi Akhil, > > > > Maybe due to "To" is empty, it was not collected c

RE: [RFC PATCH v2] ethdev: advertise flow restore in mbuf

2023-06-20 Thread Ali Alnubani
> -Original Message- > From: David Marchand > Sent: Thursday, June 15, 2023 4:47 PM > To: dev@dpdk.org > Cc: NBU-Contact-Thomas Monjalon (EXTERNAL) ; > i.maxim...@ovn.org; Aman Singh ; Yuying > Zhang ; Matan Azrad ; Slava > Ovsiienko ; Ori Kam ; > Suanming Mou ; David Christensen > ; Ruife

Re: [PATCH v4] app/testpmd: fix primary process not polling all queues

2023-06-20 Thread Jie Hai
On 2023/6/9 19:10, Ferruh Yigit wrote: On 6/9/2023 10:03 AM, Jie Hai wrote: Here's how the problem arises. step1: Start the app. dpdk-testpmd -a :35:00.0 -l 0-3 -- -i --rxq=10 --txq=10 step2: Perform the following steps and send traffic. As expected, queue 7 does not send or receive pa

Re: [PATCH v3] net/bonding: fix bond startup failure when NUMA is -1

2023-06-20 Thread Ferruh Yigit
On 6/20/2023 3:53 AM, humin (Q) wrote: > > 在 2023/6/19 16:57, Ferruh Yigit 写道: >> On 6/16/2023 1:00 PM, humin (Q) wrote: >>> Hi, >>> >>> 在 2023/6/16 15:20, Chaoyong He 写道: From: Zerun Fu After the mainline Linux kernel commit "fe205d984e7730f4d21f6f8ebc60f0698404ac31" (ACPI: R

[PATCH v3 0/8] fixes and improvements to CNXK crypto PMD

2023-06-20 Thread Tejasree Kondoj
This series adds SM4, raw cryptodev API support and fixes to CNXK crypto PMD. v3: * Updated feature file for cn10k v2: * Fixed documentation build failure * Updated release notes Aakash Sasidharan (1): crypto/cnxk: use pt inst for null cipher with null auth Anoob Joseph (3): crypto/cnxk: re

[PATCH v3 1/8] crypto/cnxk: check for null pointer

2023-06-20 Thread Tejasree Kondoj
Checking for NULL pointer dereference. Signed-off-by: Tejasree Kondoj --- drivers/crypto/cnxk/cnxk_se.h | 14 -- 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/drivers/crypto/cnxk/cnxk_se.h b/drivers/crypto/cnxk/cnxk_se.h index c66ab80749..a85e4c5170 100644 --- a/drive

[PATCH v3 2/8] crypto/cnxk: remove packet length checks in crypto offload

2023-06-20 Thread Tejasree Kondoj
From: Anoob Joseph When performing crypto offload, the packet length of the input/output buffer does not matter. The length that matters is the cipher/authentication range specified in crypto_op. Since application can request for ciphering of a small portion of the buffer, the extra comparison of

[PATCH v3 3/8] crypto/cnxk: use pt inst for null cipher with null auth

2023-06-20 Thread Tejasree Kondoj
From: Aakash Sasidharan Use passthrough instruction for NULL cipher with NULL auth combination. Signed-off-by: Aakash Sasidharan --- drivers/crypto/cnxk/cnxk_cryptodev_ops.c | 20 drivers/crypto/cnxk/cnxk_se.h| 59 2 files changed, 50 insertions(+)

[PATCH v3 4/8] crypto/cnxk: enable context cache for 103XX

2023-06-20 Thread Tejasree Kondoj
Enabling context cache for SE instructions on 106B0 and 103XX. Signed-off-by: Tejasree Kondoj --- drivers/crypto/cnxk/cnxk_cryptodev_ops.c | 6 +++--- drivers/crypto/cnxk/cnxk_cryptodev_ops.h | 8 2 files changed, 11 insertions(+), 3 deletions(-) diff --git a/drivers/crypto/cnxk/cnxk_c

[PATCH v3 5/8] crypto/cnxk: add support for raw APIs

2023-06-20 Thread Tejasree Kondoj
From: Anoob Joseph Add crypto RAW API support in cnxk PMD Enable the flag to allow execution of raw test suite. Signed-off-by: Vidya Sagar Velumuri Signed-off-by: Anoob Joseph --- doc/guides/cryptodevs/features/cn10k.ini | 1 + doc/guides/rel_notes/release_23_07.rst| 1 + drivers/cry

[PATCH v3 6/8] test/crypto: enable raw crypto tests for crypto_cn10k

2023-06-20 Thread Tejasree Kondoj
From: Anoob Joseph Enable raw crypto tests with crypto_cn10k. Signed-off-by: Anoob Joseph --- app/test/test_cryptodev.c | 8 1 file changed, 8 insertions(+) diff --git a/app/test/test_cryptodev.c b/app/test/test_cryptodev.c index fb2af40b99..2ba37ed4bd 100644 --- a/app/test/test_cryp

[PATCH v3 7/8] crypto/cnxk: add support for sm4

2023-06-20 Thread Tejasree Kondoj
From: Vidya Sagar Velumuri Add support for SM4 cipher Support for modes: SM4_CBC, SM4_ECB, SM4_CTR, SM4_OFB, SM4_CFB Signed-off-by: Vidya Sagar Velumuri --- doc/guides/cryptodevs/cnxk.rst| 1 + doc/guides/cryptodevs/features/cn10k.ini | 5 + doc/guides/rel_notes/releas

[PATCH v3 8/8] crypto/cnxk: fix order of ECFPM parameters

2023-06-20 Thread Tejasree Kondoj
From: Gowrishankar Muthukrishnan Fix order of ECFPM parameters. Fixes: 76618fc4bef ("crypto/cnxk: fix order of ECFPM parameters") Signed-off-by: Gowrishankar Muthukrishnan --- drivers/crypto/cnxk/cnxk_ae.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/crypto/cn

RE: [PATCH v3 0/8] fixes and improvements to CNXK crypto PMD

2023-06-20 Thread Akhil Goyal
> Subject: [PATCH v3 0/8] fixes and improvements to CNXK crypto PMD > > This series adds SM4, raw cryptodev API support and > fixes to CNXK crypto PMD. > > v3: > * Updated feature file for cn10k Series applied to dpdk-next-crypto Had just applied your v2 with the doc changes and few title update

RE: [EXT] [PATCH v4] crypto/qat: add SM3 HMAC to gen4 devices

2023-06-20 Thread Akhil Goyal
> This commit adds SM3 HMAC to Intel QuickAssist Technology PMD > generation 3 and 4 devices. > > Signed-off-by: Arkadiusz Kusztal > Acked-by: Ciara Power Fix your .gitconfig to have uniform author name and signoff names. Applied to dpdk-next-crypto Thanks.

Re: [PATCH 1/2] test: add graph tests

2023-06-20 Thread Kevin Traynor
On 20/06/2023 07:56, David Marchand wrote: On Tue, Jun 20, 2023 at 8:50 AM Jerin Jacob wrote: On Tue, Jun 20, 2023 at 2:17 AM David Marchand wrote: We forgot to add graph unit tests to the CI testsuites. Signed-off-by: David Marchand Could we add Fixes: ? Either way, Acked-by: Jerin Jac

RE: [PATCH] examples/ipsec-secgw: fix AES-CTR IV length

2023-06-20 Thread Akhil Goyal
> Subject: [PATCH] examples/ipsec-secgw: fix AES-CTR IV length > > Set AES-CTR IV length to 8 in SA config as it is > used for per packet IV length and set it to 16 > in xform since the application populates 16B IV > in the datapath. AES-CTR requires 16B IV > constructed from nonce and counter. >

[PATCH v4 0/3] Replace obsolote test cases.

2023-06-20 Thread Arkadiusz Kusztal
This patchset removes obsolete test cases for RSA, MOD EXP, MOD INV. Doing that, new way of handling ut_setup and ut_teardown was proposed. Now both behave like constructor/desctuctor in the unit tests. It frees particular alghorithm functions from any kind of responsibility to free resources for

[PATCH v4 1/3] app/test: remove obsolete test function

2023-06-20 Thread Arkadiusz Kusztal
Removed function `one by one` as it was not enough scalable and robust. Signed-off-by: Arkadiusz Kusztal --- app/test/test_cryptodev_asym.c | 418 -- app/test/test_cryptodev_mod_test_vectors.h | 925 - app/test/test_cryptodev_rsa_test_vectors.h | 224 -

[PATCH v4 2/3] app/test: add modexp and modinv functions

2023-06-20 Thread Arkadiusz Kusztal
Added modular exponentiation and modular inverse tests to the asymmetric crypto testsuite. Signed-off-by: Arkadiusz Kusztal --- app/test/test_cryptodev_asym.c | 152 +++-- app/test/test_cryptodev_mod_test_vectors.h | 123 + 2 files changed, 263 inserti

[PATCH v4 3/3] app/test: add rsa none padding tests

2023-06-20 Thread Arkadiusz Kusztal
Added RSA NONE padding test cases. Signed-off-by: Arkadiusz Kusztal --- app/test/test_cryptodev_asym.c | 205 +++ app/test/test_cryptodev_rsa_test_vectors.h | 220 + 2 files changed, 425 insertions(+) diff --git a/app/test/test_cryptodev_asym.c b/

RE: [PATCH 1/3] examples/ipsec-secgw: avoid error pkt prints in fast path

2023-06-20 Thread Akhil Goyal
> Subject: [PATCH 1/3] examples/ipsec-secgw: avoid error pkt prints in fast path > > Avoid printing errors due to bad packets in fast path as it > effects performance. Make them RTE_LOG_DP() instead. > Also print the actual ptype that is used to classify the pkt. > > Signed-off-by: Nithin Dabilpu

[PATCH v7] crypto/qat: default to IPsec MB for computations

2023-06-20 Thread Brian Dooley
Pre and post computations currently use the OpenSSL library by default. This patch changes the default option to Intel IPsec MB library version 1.4 for the required computations. If this version of IPsec is not met it will fallback to use OpenSSL. ARM will always default to using OpenSSL as ARM IPs

Re: [PATCH v4] app/testpmd: fix primary process not polling all queues

2023-06-20 Thread Ferruh Yigit
On 6/20/2023 11:07 AM, Jie Hai wrote: > On 2023/6/9 19:10, Ferruh Yigit wrote: >> On 6/9/2023 10:03 AM, Jie Hai wrote: >>> Here's how the problem arises. >>> step1: Start the app. >>> dpdk-testpmd -a :35:00.0 -l 0-3 -- -i --rxq=10 --txq=10 >>> >>> step2: Perform the following steps and sen

RE: [PATCH] crypto/openssl: fix memory leak in auth processing function

2023-06-20 Thread Akhil Goyal
Applied to dpdk-next-crypto Thanks.

RE: [PATCH] crypto/openssl: do not build useless workaround

2023-06-20 Thread Akhil Goyal
Applied to dpdk-next-crypto Thanks.

[dpdk-dev] [PATCH] net/cnxk: fix incorrect queue index validation

2023-06-20 Thread psatheesh
From: Satheesh Paul When creating a flow rule directing traffic from PF to VF, current validation is incorrectly checking the RQ index in flow action with the PF's maximum configured RQs. This validation is applicable only when action target is an RQ of the PF. The validation has been modified ac

Re: [PATCH v3] net/bonding: fix bond startup failure when NUMA is -1

2023-06-20 Thread Niklas Söderlund
Hi Connor and Ferruh, On 2023-06-19 09:57:17 +0100, Ferruh Yigit wrote: > On 6/16/2023 1:00 PM, humin (Q) wrote: > > Hi, > > > > 在 2023/6/16 15:20, Chaoyong He 写道: > >> From: Zerun Fu > >> > >> After the mainline Linux kernel commit > >> "fe205d984e7730f4d21f6f8ebc60f0698404ac31" (ACPI: Remove s

[Bug 1255] [asan] net/mlx5: memory leak on port cleanup

2023-06-20 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=1255 Bug ID: 1255 Summary: [asan] net/mlx5: memory leak on port cleanup Product: DPDK Version: unspecified Hardware: All OS: All Status: UNCONFIRMED Severity: normal

[RFC PATCH v3] ethdev: advertise flow restore in mbuf

2023-06-20 Thread David Marchand
As reported by Ilya [1], unconditionally calling rte_flow_get_restore_info() impacts an application performance for drivers that do not provide this ops. It could also impact processing of packets that require no call to rte_flow_get_restore_info() at all. Register a dynamic mbuf flag when an appl

RE: [RFC] lib/ethdev: introduce table driven APIs

2023-06-20 Thread Ori Kam
Hi > -Original Message- > From: Jerin Jacob > Sent: Tuesday, June 20, 2023 8:07 AM > > On Tue, Jun 20, 2023 at 7:22 AM Zhang, Qi Z wrote: > > > > > > > > > -Original Message- > > > From: Jerin Jacob > > > Sent: Monday, June 19, 2023 5:52 PM > > > To: Zhang, Qi Z > > > Cc: Dumi

Re: [PATCH] net/bonding: fix destroy dedicated queues flow

2023-06-20 Thread Ferruh Yigit
On 6/20/2023 4:02 AM, humin (Q) wrote: > 在 2023/6/8 10:59, Chaoyong He 写道: >> From: Long Wu >> >> Bonding port in mode 4 enables dedicated queues, we >> will create a flow for this feature. So we need to >> destroy this flow when we remove the member port. >> >> Furthermore if we don't destroy th

Re: [PATCH 1/3] net/sfc: split link update function

2023-06-20 Thread Ferruh Yigit
On 6/2/2023 9:52 AM, Andrew Rybchenko wrote: > On 6/2/23 01:23, Denis Pryazhennikov wrote: >> Separate the original link update function into >> two functions: state retrieval and update. >> This improves code clarity and maintainability. >> >> Signed-off-by: Denis Pryazhennikov >> Reviewed-by: Iv

Re: [PATCH v2 3/3] net/sfc: support FEC feature

2023-06-20 Thread Ferruh Yigit
On 6/19/2023 10:39 AM, Andrew Rybchenko wrote: > On 6/15/23 11:38, Denis Pryazhennikov wrote: >> Support ethdev methods to query and set FEC information. >> Limitations: ignoring rte_eth_fec_get_capability() results >> can lead to NOFEC if the device is not strated. >> >> Signed-off-by: Denis Pryaz

Re: [PATCH v2 2/3] common/sfc_efx/base: add FEC related macros

2023-06-20 Thread Ferruh Yigit
On 6/15/2023 9:38 AM, Denis Pryazhennikov wrote: > Added new macros to simplify working with FEC bits. > > Signed-off-by: Denis Pryazhennikov > Reviewed-by: Andy Moreton > Acked-by: Andrew Rybchenko > --- > drivers/common/sfc_efx/base/efx.h | 9 + > 1 file changed, 9 insertions(+) > >

Re: [PATCH 1/3] net/sfc: split link update function

2023-06-20 Thread Andrew Rybchenko
On 6/20/23 14:25, Ferruh Yigit wrote: On 6/2/2023 9:52 AM, Andrew Rybchenko wrote: On 6/2/23 01:23, Denis Pryazhennikov wrote: Separate the original link update function into two functions: state retrieval and update. This improves code clarity and maintainability. Signed-off-by: Denis Pryazhe

Re: [PATCH v2 0/3] net/sfc: support FEC feature

2023-06-20 Thread Ferruh Yigit
On 6/15/2023 9:38 AM, Denis Pryazhennikov wrote: > This patch series adds setting and querying of Forward error > correction (FEC). AUTO, BASER and RS modes are supported > by EF10/EF100 hardware. LLRS mode is not supported. > > Changes in v2: > * Applied review notes in [2/3] and [3/3]; > * Added

Re: [PATCH v5 2/3] common/sfc_efx/base: add support to enable VLAN stripping

2023-06-20 Thread Andrew Rybchenko
On 6/20/23 12:55, Artemii Morozov wrote: On 6/19/23 14:28, Andrew Rybchenko wrote: On 6/13/23 18:12, Artemii Morozov wrote: To enable VLAN stripping, two conditions must be met: the corresponding flag must be set and the appropriate RX prefix should be requested. RX -> Rx VLAN stripping is

[Bug 1256] drivers/common/mlx5: mlx5_malloc() called on invalid socket ID when global MR cache is full and rte_extmem_* API is used

2023-06-20 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=1256 Bug ID: 1256 Summary: drivers/common/mlx5: mlx5_malloc() called on invalid socket ID when global MR cache is full and rte_extmem_* API is used Product: DPDK Version: 21.1

Re: [PATCH 1/2] test: add graph tests

2023-06-20 Thread David Marchand
On Tue, Jun 20, 2023 at 12:32 PM Kevin Traynor wrote: > > On 20/06/2023 07:56, David Marchand wrote: > > On Tue, Jun 20, 2023 at 8:50 AM Jerin Jacob wrote: > >> > >> On Tue, Jun 20, 2023 at 2:17 AM David Marchand > >> wrote: > >>> > >>> We forgot to add graph unit tests to the CI testsuites. > >

RE: [PATCH v2 0/5] net/mlx5: introduce Tx datapath tracing

2023-06-20 Thread Raslan Darawsheh
Hi, > -Original Message- > From: Viacheslav Ovsiienko > Sent: Tuesday, June 13, 2023 7:59 PM > To: dev@dpdk.org > Subject: [PATCH v2 0/5] net/mlx5: introduce Tx datapath tracing > > The mlx5 provides the send scheduling on specific moment of time, > and for the related kind of applicatio

RE: [EXT] [PATCH v7] crypto/qat: default to IPsec MB for computations

2023-06-20 Thread Akhil Goyal
> Pre and post computations currently use the OpenSSL library by default. > This patch changes the default option to Intel IPsec MB library version > 1.4 for the required computations. If this version of IPsec is not met > it will fallback to use OpenSSL. ARM will always default to using > OpenSSL

RE: [EXT] [PATCH v2] doc: updated libcrypto dependencies in QAT guide

2023-06-20 Thread Akhil Goyal
> The documentation needs extra steps for customers to explicitly > show how to install libcrypto, which is needed for QAT. > It requires the commands to install libcrypto for > Ubuntu and RHEL. > > Signed-off-by: Samina Arshad Applied to dpdk-next-crypto Thanks.

Re: [PATCH 1/2] test: add graph tests

2023-06-20 Thread Kevin Traynor
On 20/06/2023 12:52, David Marchand wrote: On Tue, Jun 20, 2023 at 12:32 PM Kevin Traynor wrote: On 20/06/2023 07:56, David Marchand wrote: On Tue, Jun 20, 2023 at 8:50 AM Jerin Jacob wrote: On Tue, Jun 20, 2023 at 2:17 AM David Marchand wrote: We forgot to add graph unit tests to the C

RE: [EXT] [PATCH] doc: update IPsec Multi-buffer version for Arm

2023-06-20 Thread Akhil Goyal
> Updated SNOW3G and ZUC PMD documentation guides with information > about the latest library version supported. > > Signed-off-by: Ruifeng Wang Applied to dpdk-next-crypto Thanks.

Re: [PATCH v5 2/3] common/sfc_efx/base: add support to enable VLAN stripping

2023-06-20 Thread Artemii Morozov
On 6/20/23 15:50, Andrew Rybchenko wrote: On 6/20/23 12:55, Artemii Morozov wrote: On 6/19/23 14:28, Andrew Rybchenko wrote: On 6/13/23 18:12, Artemii Morozov wrote: To enable VLAN stripping, two conditions must be met: the corresponding flag must be set and the appropriate RX prefix should

Re: [PATCH v3] net/bonding: fix bond startup failure when NUMA is -1

2023-06-20 Thread humin (Q)
Hi, Niklas, Ferruh, 在 2023/6/20 19:03, Niklas Söderlund 写道: Hi Connor and Ferruh, On 2023-06-19 09:57:17 +0100, Ferruh Yigit wrote: On 6/16/2023 1:00 PM, humin (Q) wrote: Hi, 在 2023/6/16 15:20, Chaoyong He 写道: From: Zerun Fu After the mainline Linux kernel commit "fe205d984e7730f4d21f6f8e

RE: [PATCH] test/security: fix event inline IPsec reassembly tests

2023-06-20 Thread Akhil Goyal
> -Original Message- > From: Rahul Bhansali > Sent: Tuesday, June 6, 2023 10:37 AM > To: dev@dpdk.org; Akhil Goyal ; Anoob Joseph > ; Volodymyr Fialko > Cc: Rahul Bhansali > Subject: [PATCH] test/security: fix event inline IPsec reassembly tests > > Event Inline IPsec test suite stuc

RE: [PATCH] test/pdcp: remove side affect from assertion

2023-06-20 Thread Akhil Goyal
> > Remove side affect from test assertion, to avoid different behaviour in non- > > debug build. Issues reported by coverity scan. > > > > Coverity issue: 385419, 385420 > > Fixes: 6f00462979ad ("test/pdcp: add timer expiry cases") > > > > Signed-off-by: Volodymyr Fialko > > Acked-by: Anoob Jose

[PATCH] ci: fix libabigail cache in GHA

2023-06-20 Thread David Marchand
In repositories where multiple branches run the ABI checks using different versions of libabigail (for example, a 22.11 branch using libabigail-1.8 and a main branch using libabigail-2.1), a collision happens on the libabigail binary cache entry. As a single cache entry is used, the content of the

  1   2   >