RE: [PATCH v2 0/9] crypto/mlx5: support AES-GCM

2023-06-20 Thread Matan Azrad
From: Suanming Mou > > -Original Message- > > From: Akhil Goyal > > Sent: Tuesday, June 20, 2023 5:59 PM > > To: Suanming Mou > > Cc: Raslan Darawsheh ; dev@dpdk.org > > Subject: RE: [PATCH v2 0/9] crypto/mlx5: support AES-GCM > > > > Hi Suanming, > > > Hi Akhil, > > > > > > Maybe due t

Re: [PATCH v5 2/3] common/sfc_efx/base: add support to enable VLAN stripping

2023-06-20 Thread Andrew Rybchenko
On 6/20/23 16:10, Artemii Morozov wrote: On 6/20/23 15:50, Andrew Rybchenko wrote: On 6/20/23 12:55, Artemii Morozov wrote: On 6/19/23 14:28, Andrew Rybchenko wrote: On 6/13/23 18:12, Artemii Morozov wrote: To enable VLAN stripping, two conditions must be met: the corresponding flag must be

[PATCH v3 4/4] ci: build examples externally

2023-06-20 Thread David Marchand
Enhance our CI coverage by building examples against an installed DPDK. Signed-off-by: David Marchand Acked-by: Bruce Richardson Acked-by: Aaron Conole --- Changes since v2: - dropped unneeded -e in sed cmdline, Changes since v1: - reworked built examples discovery, - added comment for people

[PATCH v3 3/4] devtools: build all examples externally

2023-06-20 Thread David Marchand
So far, users of test-meson-builds.sh had to define their own set of examples to build externally. This is not that great because users need to maintain this list when examples are removed/added. Rework the script so that the 'all' value triggers an automatic discovery based on what was configured

[PATCH v3 2/4] examples/server_node_efd: simplify build configuration

2023-06-20 Thread David Marchand
The server_node_efd example contains various binaries whose sources are in sub directories that do not match their name. Rename sub directories in this example and stop overriding the binaries names in meson.build. This makes a next change easier in the build scripts used by CI. Signed-off-by: Da

Re: [PATCH v3] net/bonding: fix bond startup failure when NUMA is -1

2023-06-20 Thread Ferruh Yigit
On 6/20/2023 2:15 PM, humin (Q) wrote: > Hi, Niklas, Ferruh, > > 在 2023/6/20 19:03, Niklas Söderlund 写道: >> Hi Connor and Ferruh, >> >> On 2023-06-19 09:57:17 +0100, Ferruh Yigit wrote: >>> On 6/16/2023 1:00 PM, humin (Q) wrote: Hi, 在 2023/6/16 15:20, Chaoyong He 写道: > From: Zer

[PATCH v3 0/4] Test examples compilation externally

2023-06-20 Thread David Marchand
As DPDK provides examples compiled with makefiles, we need some tests in the CI. So far, a few maintainers have been testing them but a simple issue has been missed for some time and there was no way to try to build all examples that were built with meson. Additionnally, this series can help in id

[PATCH v3 1/4] examples/fips_validation: fix external build

2023-06-20 Thread David Marchand
Added sources were not referenced in the makefile used when compiling this example externally. Fixes: 36128a67c27e ("examples/fips_validation: add asymmetric validation") Fixes: b455d261eb89 ("examples/fips_validation: validate ECDSA") Cc: sta...@dpdk.org Signed-off-by: David Marchand Acked-by:

[PATCH v4 0/9] crypto/mlx5: support AES-GCM

2023-06-20 Thread Suanming Mou
AES-GCM provides both authenticated encryption and the ability to check the integrity and authentication of additional authenticated data (AAD) that is sent in the clear. The crypto operations are performed with crypto WQE. If the input buffers(AAD, mbuf, digest) are not contiguous and there is no

[PATCH v4 1/9] common/mlx5: export memory region lookup by address

2023-06-20 Thread Suanming Mou
In case user provides the address without mempool. Export the function to lookup the address without mempool is required. Signed-off-by: Suanming Mou Acked-by: Matan Azrad --- drivers/common/mlx5/mlx5_common_mr.c | 2 +- drivers/common/mlx5/mlx5_common_mr.h | 4 drivers/common/mlx5/version

[PATCH v4 3/9] crypto/mlx5: add AES-GCM query and initialization

2023-06-20 Thread Suanming Mou
AES-GCM provides both authenticated encryption and the ability to check the integrity and authentication of additional authenticated data (AAD) that is sent in the clear. This commit adds the AES-GCM attributes query and initialization function. Signed-off-by: Suanming Mou Acked-by: Matan Azrad

[PATCH v4 2/9] crypto/mlx5: split AES-XTS

2023-06-20 Thread Suanming Mou
As there will be other crypto algo be supported. This commit splits AES-XTS code to another *_xts.c file. The mlx5_crypto.c file will just contain the common code. Signed-off-by: Suanming Mou Acked-by: Matan Azrad --- drivers/crypto/mlx5/meson.build | 1 + drivers/crypto/mlx5/mlx5_crypt

[PATCH v4 4/9] crypto/mlx5: add AES-GCM encryption key

2023-06-20 Thread Suanming Mou
The crypto device requires the DEK(data encryption key) object for data encryption/decryption operation. This commit adds the AES-GCM DEK object management support. Signed-off-by: Suanming Mou Acked-by: Matan Azrad --- drivers/crypto/mlx5/mlx5_crypto.h | 17 - drivers/crypto/mlx5/mlx5

[PATCH v4 5/9] crypto/mlx5: add AES-GCM session configure

2023-06-20 Thread Suanming Mou
Sessions are used in symmetric transformations in order to prepare objects and data for packet processing stage. The AES-GCM session includes IV, AAD, digest(tag), DEK, operation mode information. Signed-off-by: Suanming Mou Acked-by: Matan Azrad --- drivers/common/mlx5/mlx5_prm.h| 12

[PATCH v4 6/9] common/mlx5: add WQE-based QP synchronous basics

2023-06-20 Thread Suanming Mou
Nvidia HW provides a synchronous mechanism between QPs. When creating the QPs, user can set one as primary and another as follower. The follower QP's WQE execution can be controlled by primary QP via SEND_EN WQE. This commit introduces the SEND_EN WQE to improve the WQE execution sync-up between p

[PATCH v4 7/9] crypto/mlx5: add queue pair setup for GCM

2023-06-20 Thread Suanming Mou
Crypto queue pair is for handling the encryption/decryption operations. As AES-GCM AEAD API provides AAD, mbuf, digest separately, low-level FW only accepts the data in a single contiguous memory region, two internal QPs are created for AES-GCM queue pair. One for organizing the memory to be conti

[PATCH v4 8/9] crypto/mlx5: add enqueue and dequeue operations

2023-06-20 Thread Suanming Mou
The crypto operations are performed with crypto WQE. If the input buffers(AAD, mbuf, digest) are not contiguous and there is no enough headroom/tailroom for copying AAD/digest, as the requirement from FW, an UMR WQE is needed to generate contiguous address space for crypto WQE. The UMR WQE and cryp

[PATCH v4 9/9] crypto/mlx5: enable AES-GCM capability

2023-06-20 Thread Suanming Mou
This commit generates AES-GCM capability based on the NIC attributes and enables AES-GCM algo. An new devarg "algo" is added to identify if the crypto PMD will be initialized as AES-GCM(algo=1) or AES-XTS(algo=0, default). Signed-off-by: Suanming Mou Acked-by: Matan Azrad --- doc/guides/crypto

Re: [PATCH v3] net/bonding: fix bond startup failure when NUMA is -1

2023-06-20 Thread Thomas Monjalon
20/06/2023 16:10, Ferruh Yigit: > On 6/20/2023 2:15 PM, humin (Q) wrote: > > Hi, Niklas, Ferruh, > > > > 在 2023/6/20 19:03, Niklas Söderlund 写道: > >> Hi Connor and Ferruh, > >> > >> On 2023-06-19 09:57:17 +0100, Ferruh Yigit wrote: > >>> On 6/16/2023 1:00 PM, humin (Q) wrote: > Hi, > > >

Re: [PATCH] ci: fix libabigail cache in GHA

2023-06-20 Thread Aaron Conole
David Marchand writes: > In repositories where multiple branches run the ABI checks using > different versions of libabigail (for example, a 22.11 branch using > libabigail-1.8 and a main branch using libabigail-2.1), a collision > happens on the libabigail binary cache entry. > As a single cache

Re: [PATCH v3] build: select optional libraries

2023-06-20 Thread Thomas Monjalon
20/06/2023 11:03, Bruce Richardson: > On Tue, Jun 20, 2023 at 10:48:50AM +0200, David Marchand wrote: > > On Tue, Jun 20, 2023 at 10:45 AM Bruce Richardson > > wrote: > > > > > > > I notice the change in behaviour for enabling the deprecated > > > > > > > libs. Is there > > > > > > > any other ch

Re: [PATCH v4 3/3] ring: add telemetry cmd for ring info

2023-06-20 Thread Thomas Monjalon
20/06/2023 10:14, Jie Hai: > On 2023/2/20 20:55, David Marchand wrote: > > On Fri, Feb 10, 2023 at 3:50 AM Jie Hai wrote: > >> > >> This patch supports dump of ring information by its name. > >> An example using this command is shown below: > >> > >> --> /ring/info,MP_mb_pool_0 > >> { > >>"/ri

Re: [PATCH v3] build: select optional libraries

2023-06-20 Thread Bruce Richardson
On Tue, Jun 20, 2023 at 04:33:15PM +0200, Thomas Monjalon wrote: > 20/06/2023 11:03, Bruce Richardson: > > On Tue, Jun 20, 2023 at 10:48:50AM +0200, David Marchand wrote: > > > On Tue, Jun 20, 2023 at 10:45 AM Bruce Richardson > > > wrote: > > > > > > > > I notice the change in behaviour for enabl

Re: [EXT] Re: [PATCH v2 8/8] crypto/ipsec_mb: set and use session ID

2023-06-20 Thread Thomas Monjalon
16/06/2023 11:38, Akhil Goyal: > > > > > > > > > > > > For info, this does not compile with > > > > > > https://urldefense.proofpoint.com/v2/url?u=https- > > 3A__git.gitlab.arm.com_arm-2Dreference-2Dsolutions_ipsec- > > 2Dmb&d=DwIFAg&c=nKjWec2b6R0mOyPaz7xtfQ&r=DnL7Si2wl_PRwpZ9TWey3e > > u68gBzn7DkP

[PATCH] net/igc: disable EEE by default on I225/226

2023-06-20 Thread Matthew Smith
I226-V devices can hang when EEE is enabled. Explicitly disable EEE during initialization of the device, as the Linux and FreeBSD kernel drivers do. Signed-off-by: Matthew Smith --- drivers/net/igc/base/igc_i225.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/net/igc/base/igc_i

Re: [PATCH v3] build: select optional libraries

2023-06-20 Thread Bruce Richardson
On Tue, Jun 20, 2023 at 04:33:15PM +0200, Thomas Monjalon wrote: > 20/06/2023 11:03, Bruce Richardson: > > On Tue, Jun 20, 2023 at 10:48:50AM +0200, David Marchand wrote: > > > On Tue, Jun 20, 2023 at 10:45 AM Bruce Richardson > > > wrote: > > > > > > > > I notice the change in behaviour for enabl

Re: ring name length simplification in ipsec_mb_qp_create_processed_ops_ring

2023-06-20 Thread Ji, Kai
Can you fix the commit messages with signed-off and Fixes Acked-by: Kai Ji mailto:kai...@intel.com>> From: Stephen Hemminger Sent: 31 May 2023 00:34 To: Fan Zhang Cc: dev@dpdk.org Subject: ring name length simplification in ipsec_mb_qp_create_processed_ops_rin

Re: [PATCH 0/9] Wangxun bug fixes

2023-06-20 Thread Ferruh Yigit
On 6/14/2023 3:34 AM, Jiawen Wu wrote: > Fix some bugs for txgbe and ngbe. > > Jiawen Wu (9): > net/txgbe: fix Tx failure with fiber hotplug > net/txgbe: fix interrupt enable mask > net/txgbe: fix issues caused by MNG veto bit setting > net/txgbe: fix to set autoneg for 1G speed > net/tx

Re: [PATCH v3] net/ixgbe: add proper memory barriers for some Rx functions

2023-06-20 Thread Thomas Monjalon
13/06/2023 11:25, Ruifeng Wang: > From: Thomas Monjalon > > 12/06/2023 13:58, zhoumin: > > > On Mon, June 12, 2023 at 6:26PM, Thomas Monjalon wrote: > > > > 15/05/2023 04:10, Zhang, Qi Z: > > > >> From: Ruifeng Wang > > > >>> From: Min Zhou > > > --- > > > v3: > > > - Use rte_smp_

Re: [PATCH] ethdev: rename functions checking queue validity

2023-06-20 Thread Ferruh Yigit
On 6/19/2023 10:41 AM, Andrew Rybchenko wrote: > On 6/14/23 19:44, Stephen Hemminger wrote: >> On Wed, 14 Jun 2023 17:20:59 +0200 >> Thomas Monjalon wrote: >> >>> Two functions helping to check Rx/Tx queues validity >>> were added in DPDK 23.07-rc1. >>> As the release is not closed, it is still ti

RE: [RFC PATCH v3] ethdev: advertise flow restore in mbuf

2023-06-20 Thread Slava Ovsiienko
> -Original Message- > From: David Marchand > Sent: Tuesday, June 20, 2023 2:10 PM > To: dev@dpdk.org > Cc: NBU-Contact-Thomas Monjalon (EXTERNAL) ; > i.maxim...@ovn.org; Ali Alnubani ; Aman Singh > ; Yuying Zhang ; > Matan Azrad ; Slava Ovsiienko > ; Ori Kam ; Suanming Mou > ; David Chris

Re: [PATCH v4] app/testpmd: fix primary process not polling all queues

2023-06-20 Thread Ferruh Yigit
On 6/20/2023 11:07 AM, Jie Hai wrote: > On 2023/6/9 19:10, Ferruh Yigit wrote: >> On 6/9/2023 10:03 AM, Jie Hai wrote: >>> Here's how the problem arises. >>> step1: Start the app. >>> dpdk-testpmd -a :35:00.0 -l 0-3 -- -i --rxq=10 --txq=10 >>> >>> step2: Perform the following steps and sen

[PATCH v2 0/2] Improve docs on getting info on running process

2023-06-20 Thread Bruce Richardson
Add details to our documentation on how to register logging for a component. Also provide guidelines on when to use logs vs tracing vs telemetry. V2: extended second patch based on the feedback provided. Hopefully, we can keep this section short and clear as the revisions roll! :-) Bruce

[PATCH v2 1/2] doc/contributing: provide coding details for dynamic logging

2023-06-20 Thread Bruce Richardson
While the section on dynamic logging in the contributors guide covered the details of the logging naming scheme, it failed to cover exactly how the component developer, i.e. the contributor, could actually use dynamic logging in their component. Fix this by splitting the details of the naming sche

[PATCH v2 2/2] doc/contributing: guidelines for logging, tracing and telemetry

2023-06-20 Thread Bruce Richardson
As discussed by DPDK technical board [1], our contributor guide should include some details as to when to use logging vs tracing vs telemetry to provide the end user with information about the running process and the DPDK libraries it uses. [1] https://mails.dpdk.org/archives/dev/2023-March/265204

RE: [dpdk-dev] [PATCH v1] doc: fix ip6 node API doxygen generation

2023-06-20 Thread Sunil Kumar Kori
> -Original Message- > From: jer...@marvell.com > Sent: Tuesday, June 20, 2023 3:26 PM > To: dev@dpdk.org; Nithin Kumar Dabilpuram ; > Amit Prakash Shukla ; Sunil Kumar Kori > > Cc: Jerin Jacob Kollanukkaran > Subject: [dpdk-dev] [PATCH v1] doc: fix ip6 node API doxygen generation > >

Re: [PATCH] net/nfp: fix add redundant read configure operations

2023-06-20 Thread Ferruh Yigit
On 6/14/2023 6:51 AM, Chaoyong He wrote: > From: Qin Ke > > Performance is reduced because of adding redundant read configure > operations in nfp_net_parse_ptype() called by nfp_net_recv_pkts(), > which cause every received packet to spend more time. > > Fix the performance issue by deleting the

RE: [EXT] [PATCH v4 0/9] crypto/mlx5: support AES-GCM

2023-06-20 Thread Akhil Goyal
> AES-GCM provides both authenticated encryption and the ability to check > the integrity and authentication of additional authenticated data (AAD) > that is sent in the clear. > > The crypto operations are performed with crypto WQE. If the input > buffers(AAD, mbuf, digest) are not contiguous and

[pull-request] next-crypto 23.07 rc2

2023-06-20 Thread Akhil Goyal
The following changes since commit 4645ed709d36bab64fbf2b8cff12054d39398af9: examples/l3fwd-graph: introduce mcore dispatch worker model (2023-06-19 21:27:05 +0200) are available in the Git repository at: http://git.dpdk.org/next/dpdk-next-crypto for you to fetch changes up to 4dc146d0e92

[PATCH v7 1/1] hash: add XOR32 hash function

2023-06-20 Thread Bili Dong
An XOR32 hash is needed in the Software Switch (SWX) Pipeline for its use case in P4. We implement it in this patch so it could be easily registered in the pipeline later. Signed-off-by: Bili Dong --- v7: * Simplified byte ordering conversion logic. (re Vladimir Medvedkin ) * Added test cases wi

Re: [PATCH] hash: add XOR32 hash function

2023-06-20 Thread Bili Dong
For the HW I have access to, I think so. That is actually one of the major final goals of this patch, so we can model this HW in P4, including all the hash functions it supports, through the DPDK SWX pipeline. Thanks, Bili On Sat, Jun 17, 2023 at 1:59 PM Stephen Hemminger < step...@networkplumbe

[PATCH] member: fix PRNG seed reset in NitroSketch mode

2023-06-20 Thread Dmitry Kozlyuk
Sketch creation seeded the global PRNG using the supplied seed for hashing. The use of this seed by SKETCH set summary was not documented. SKETCH set summary does not require two independent hash seeds, unlike other set summary types. Seeding the global PRNG at sketch creation does not make the ske

RE: [PATCH] net/igc: disable EEE by default on I225/226

2023-06-20 Thread Zhang, Qi Z
> -Original Message- > From: Matthew Smith > Sent: Tuesday, June 20, 2023 10:56 PM > To: Guo, Junfeng ; Su, Simei > Cc: dev@dpdk.org; Smith, Matthew > Subject: [PATCH] net/igc: disable EEE by default on I225/226 > > I226-V devices can hang when EEE is enabled. Explicitly disable EEE

RE: [PATCH] ixgbe: Allow setting IVAR register for X550EM_a

2023-06-20 Thread Zhang, Qi Z
> -Original Message- > From: Joyce Kong > Sent: Monday, June 19, 2023 5:45 PM > To: Zhang, Qi Z ; Vladimir Ratnikov > ; Yang, Qiming ; Wu, > Wenjun1 > Cc: dev@dpdk.org; Ruifeng Wang > Subject: RE: [PATCH] ixgbe: Allow setting IVAR register for X550EM_a > > Hi All, > > It seems a fal

[PATCH] net/iavf: fix SCTP tunnel packet forwarding issue

2023-06-20 Thread Wenzhuo Lu
The SCTP tunnel packets cannot be forwarded in AVX2 mode. As 2 features are developed in parallel, 5712bf9d6e14 ("net/iavf: add Tx AVX2 offload path") doesn't consider the impact of 4f8259df563a ("net/iavf: enable Tx outer checksum offload on AVX512"). So, the wrong TX path is selected. Fixes: 57

[PATCH] net/iavf: fix VLAN insertion in vector path

2023-06-20 Thread Wenzhuo Lu
As the VLAN insertion is partially supported in vector path, the behavior is different in scalar and vector path. For a VLAN packet, if using scalar path, the new VLAN tag will be inserted after the original VLAN tag. If using vector path, the new VLAN tag is inserted before the original VLAN tag.

Re: [PATCH v3] net/bonding: fix bond startup failure when NUMA is -1

2023-06-20 Thread humin (Q)
在 2023/6/20 22:10, Ferruh Yigit 写道: On 6/20/2023 2:15 PM, humin (Q) wrote: Hi, Niklas, Ferruh, 在 2023/6/20 19:03, Niklas Söderlund 写道: Hi Connor and Ferruh, On 2023-06-19 09:57:17 +0100, Ferruh Yigit wrote: On 6/16/2023 1:00 PM, humin (Q) wrote: Hi, 在 2023/6/16 15:20, Chaoyong He 写道: Fr

Re: [dpdk-dev] [PATCH] net/cnxk: fix incorrect queue index validation

2023-06-20 Thread Jerin Jacob
On Tue, Jun 20, 2023 at 4:32 PM wrote: > > From: Satheesh Paul > > When creating a flow rule directing traffic from PF > to VF, current validation is incorrectly checking the > RQ index in flow action with the PF's maximum > configured RQs. This validation is applicable only > when action target

RE: [EXT] [PATCH v3] common/cnxk/roc_npa: unlock mbox in error cases

2023-06-20 Thread Ashwin Sekhar T K
Acked-by: Ashwin Sekhar T K > -Original Message- > From: Thierry Herbelot > Sent: Tuesday, June 20, 2023 3:14 PM > To: dev@dpdk.org > Cc: Thierry Herbelot ; Thomas Monjalon > ; Nithin Kumar Dabilpuram > ; Satha Koteswara Rao Kottidi > ; Jerin Jacob Kollanukkaran > > Subject: [EXT] [PATC

Re: [EXT] [PATCH v3] common/cnxk/roc_npa: unlock mbox in error cases

2023-06-20 Thread Jerin Jacob
On Wed, Jun 21, 2023 at 10:17 AM Ashwin Sekhar T K wrote: > > Acked-by: Ashwin Sekhar T K > > > -Original Message- > > From: Thierry Herbelot > > Sent: Tuesday, June 20, 2023 3:14 PM > > To: dev@dpdk.org > > Cc: Thierry Herbelot ; Thomas Monjalon > > ; Nithin Kumar Dabilpuram > > ; Satha

RE: release candidate 23.07-rc1

2023-06-20 Thread Xu, HailinX
> -Original Message- > From: Xu, HailinX > Sent: Thursday, June 15, 2023 3:18 PM > To: Thomas Monjalon ; annou...@dpdk.org; > dev@dpdk.org > Cc: Kovacevic, Marko ; Mcnamara, John > ; Richardson, Bruce > ; Ferruh Yigit > Subject: RE: release candidate 23.07-rc1 > > > -Original Message-

Re: [PATCH v3 1/4] examples/fips_validation: fix external build

2023-06-20 Thread David Marchand
On Tue, Jun 20, 2023 at 4:30 PM David Marchand wrote: > > Added sources were not referenced in the makefile used when compiling > this example externally. > > Fixes: 36128a67c27e ("examples/fips_validation: add asymmetric validation") > Fixes: b455d261eb89 ("examples/fips_validation: validate ECDS

[PATCH] eal: add notes to SMP memory barrier APIs

2023-06-20 Thread Ruifeng Wang
The rte_smp_xx() APIs are deprecated. But it is not mentioned in the function header. Added notes in function header for clarification. Signed-off-by: Ruifeng Wang --- lib/eal/include/generic/rte_atomic.h | 15 +++ 1 file changed, 15 insertions(+) diff --git a/lib/eal/include/generi

RE: [PATCH v3] net/ixgbe: add proper memory barriers for some Rx functions

2023-06-20 Thread Ruifeng Wang
> -Original Message- > From: Thomas Monjalon > Sent: Tuesday, June 20, 2023 11:53 PM > To: Zhang, Qi Z ; zhoumin ; > Ruifeng Wang > > Cc: dev@dpdk.org; m...@smartsharesystems.com; konstantin.v.anan...@yandex.ru; > Yang, Qiming > ; Wu, Wenjun1 ; > d...@linux.vnet.ibm.com; > roret...@lin

<    1   2