> From: Jerin Jacob [mailto:jerinjac...@gmail.com]
> Sent: Friday, 17 November 2023 05.34
>
> On Thu, Sep 28, 2023 at 11:10 AM wrote:
> >
> > From: Jerin Jacob
> >
> > Define qualification criteria for external library
> > based on a techboard meeting minutes [1] and past
> > learnings from mail
> From: Stephen Hemminger [mailto:step...@networkplumber.org]
> Sent: Friday, 17 November 2023 05.03
>
> Zero length arrays are a GNU extension that has been
> superseded by flex arrays.
>
> https://gcc.gnu.org/onlinedocs/gcc/Zero-Length.html
>
> These are places found by cocci/zero_length_array
On 11/17/2023 2:45 AM, Jiawen Wu wrote:
> On Thursday, November 16, 2023 10:07 PM, ferruh.yi...@amd.com wrote:
>> Reported by SuSe CI [1] by GCC [2], possibly false positive. Error:
>>
>> In function 'txgbe_host_interface_command',
>> inlined from 'txgbe_host_interface_command'
>>
On 11/17/2023 3:28 AM, Stephen Hemminger wrote:
> On Fri, 17 Nov 2023 00:50:16 +
> Ferruh Yigit wrote:
>
Hi Kaiwen,
I am trying to understand the problem, what is the testcase that has
checksum error?
Are the received mbuf data_len & pkt_len wrong? Instead of try
Hi Akhil,
> -Original Message-
> From: Akhil Goyal
> Sent: Monday, November 13, 2023 12:31 PM
> To: Sivaramakrishnan, VenkatX ; Fan
> Zhang
> Cc: dev@dpdk.org; sta...@dpdk.org
> Subject: RE: [EXT] [PATCH 2/2] test/crypto: add negative test cases for cipher
> buffer alignment
>
> > add
On Fri, Nov 17, 2023 at 09:27:02AM +0100, Morten Brørup wrote:
> > From: Jerin Jacob [mailto:jerinjac...@gmail.com]
> > Sent: Friday, 17 November 2023 05.34
> >
> > On Thu, Sep 28, 2023 at 11:10 AM wrote:
> > >
> > > From: Jerin Jacob
> > >
> > > Define qualification criteria for external librar
> -Original Message-
> From: Mingjin Ye
> Sent: Tuesday, November 14, 2023 6:28 PM
> To: dev@dpdk.org
> Cc: Yang, Qiming ; Ye, MingjinX
> ; sta...@dpdk.org
> Subject: [PATCH v7] app/test: secondary process passes allow parameters
>
> In EAL related test cases, the allow parameters are
Reported by SuSe CI [1] by GCC [2], possibly false positive. Error:
In function 'txgbe_host_interface_command',
inlined from 'txgbe_host_interface_command'
at ../drivers/net/txgbe/base/txgbe_mng.c:104:1,
inlined from 'txgbe_hic_reset'
at ../drivers/net/txgbe/ba
On 11/17/2023 1:31 AM, lihuisong (C) wrote:
>> On 2023/11/17 1:21, Ferruh Yigit wrote:
>>> In command to set Tx offload:
>>> "port config tx_offload on|off",
>>>
>>> there is a defect in "on|off" comparison, so command does opposite of
>>> what is intended. Fixed comparison.
>>>
>>> Fixes: 6280f
Hi Richardson,
can you please take a look at this patch.
Thanks,
Mingjin
> -Original Message-
> From: Ye, MingjinX
> Sent: Tuesday, November 14, 2023 6:28 PM
> To: dev@dpdk.org
> Cc: Yang, Qiming ; Ye, MingjinX
> ; sta...@dpdk.org
> Subject: [PATCH v7] app/test: secondary process passe
Hi Burakov,
can you please take a look at this patch.
Thanks,
Mingjin
> > -Original Message-
> > From: Ling, WeiX
> > Sent: Tuesday, September 12, 2023 5:08 PM
> > To: Ye, MingjinX ; dev@dpdk.org
> > Cc: Yang, Qiming ; Zhou, YidingX
> > ; Ye, MingjinX ;
> > sta...@dpdk.org; Burakov, Ana
On Thu, Nov 16, 2023 at 08:45:35AM +0100, Morten Brørup wrote:
> > From: Stanisław Kardach [mailto:k...@semihalf.com]
> > Sent: Thursday, 16 November 2023 00.21
> >
> > On Wed, Nov 15, 2023 at 10:31 PM Morten Brørup
> > wrote:
> > >
> > > > From: Tyler Retzlaff [mailto:roret...@linux.microsoft.co
> From: Bruce Richardson [mailto:bruce.richard...@intel.com]
> Sent: Friday, 17 November 2023 10.52
>
> On Fri, Nov 17, 2023 at 09:27:02AM +0100, Morten Brørup wrote:
> > > From: Jerin Jacob [mailto:jerinjac...@gmail.com]
> > > Sent: Friday, 17 November 2023 05.34
> > >
> > > On Thu, Sep 28, 2023
On 11/17/2023 1:35 AM, lihuisong (C) wrote:
>
> 在 2023/11/17 6:16, Joshua Washington 写道:
>> The new max_rx_bufsize field in dev_info can be used to guide mbuf sizes
>> chosen by DPDK programs by ensuring that DPDK programs do not waste
>> memory by using an mbuf size too large for the maximum RX b
On Fri, Nov 17, 2023 at 10:24:41AM +, Ye, MingjinX wrote:
> Hi Richardson,
>
> can you please take a look at this patch.
>
> Thanks,
> Mingjin
>
Hi,
I acked v6. If nothing major has changed in the patch, then the ack can be
kept for v7. If there is something that has changed that you think
+CC Thomas, this patch is ready to be applied to 23.11.
> From: Bruce Richardson [mailto:bruce.richard...@intel.com]
> Sent: Friday, 17 November 2023 11.55
>
> On Thu, Nov 16, 2023 at 08:45:35AM +0100, Morten Brørup wrote:
> > > From: Stanisław Kardach [mailto:k...@semihalf.com]
> > > Sent: Thurs
On Thu, Nov 16, 2023 at 12:18:13PM +0100, Robin Jarry wrote:
> Fix the following error when a command list file contains empty lines:
>
> Traceback (most recent call last):
> File "buildtools/dpdk-cmdline-gen.py", line 202, in
> main()
> File "buildtools/dpdk-cmdline-gen.py", line 184, in
> From: Ferruh Yigit [mailto:ferruh.yi...@amd.com]
> Sent: Friday, 17 November 2023 10.30
>
> On 11/17/2023 3:28 AM, Stephen Hemminger wrote:
> > On Fri, 17 Nov 2023 00:50:16 +
> > Ferruh Yigit wrote:
> >
> Hi Kaiwen,
>
> I am trying to understand the problem, what is the testc
Improve dma-perf application to support PCI dev and SG copy,
along with additional supports below:
- validate copied memory
- skip tests if not opted.
v7:
- PCI patch updated.
Amit Prakash Shukla (2):
app/dma-perf: add skip support
app/dma-perf: add PCI device support
Gowrishankar Muthukr
From: Amit Prakash Shukla
Add support to skip running a dma-perf test-case.
Signed-off-by: Amit Prakash Shukla
Acked-by: Anoob Joseph
---
app/test-dma-perf/config.ini | 2 ++
app/test-dma-perf/main.c | 23 +++
app/test-dma-perf/main.h | 1 +
3 files changed, 26 i
From: Amit Prakash Shukla
Add support to test performance for "device to memory" and
"memory to device" data transfer.
Signed-off-by: Amit Prakash Shukla
Acked-by: Anoob Joseph
---
v7:
- changed cfg->raddr type to uintptr_t to fix 32 bit compilation.
---
app/test-dma-perf/benchmark.c | 108 +
Validate copied memory to ensure DMA copy did not fail.
Signed-off-by: Gowrishankar Muthukrishnan
Acked-by: Anoob Joseph
---
app/test-dma-perf/benchmark.c | 21 -
app/test-dma-perf/main.c | 16 +++-
app/test-dma-perf/main.h | 2 +-
3 files changed, 32
Add SG copy support.
Signed-off-by: Gowrishankar Muthukrishnan
Acked-by: Anoob Joseph
---
app/test-dma-perf/benchmark.c | 274 +-
app/test-dma-perf/config.ini | 19 ++-
app/test-dma-perf/main.c | 34 -
app/test-dma-perf/main.h | 5 +-
4 files c
check cipher length alignment for 3DES CBC and AES CBC
to change it to NULL service type for buffer misalignment.
Fixes: def38073ac90 ("crypto/qat: check cipher buffer alignment")
Cc: sta...@dpdk.org
Signed-off-by: Sivaramakrishnan Venkat
Acked-by: Kai Ji
---
v2:
Dropped new tests patch.
On Wed, Nov 15, 2023 at 08:28:55PM -0500, Dave Young wrote:
>Bruce,
>Is the following Linux update correct per your feedback?
>Linux
>-
>To run DPDK applications without root privileges on Linux, perform the
>following steps:
>1. **Create a DPDK User Group**: Create
Getting readable and consistent logs is important when running a DPDK
application, especially when troubleshooting.
A common issue with logs is when a DPDK change do not add (or on the
contrary add too many \n) in the format string.
This issue would only get noticed when actually hitting this log
Fix places where two newline characters may be logged.
Also fix some direct calls to printf or RTE_LOG when a dedicated log
helper for a library existed.
Cc: sta...@dpdk.org
Signed-off-by: David Marchand
---
drivers/crypto/ipsec_mb/ipsec_mb_ops.c | 2 +-
lib/bbdev/rte_bbdev.c
gcc builtin __builtin_strchr can be used as a static assertion to check
whether passed format strings contain a \n.
This can be useful to detect double \n in log messages.
Signed-off-by: David Marchand
---
lib/log/rte_log.h | 21 +
1 file changed, 21 insertions(+)
diff --git
Use RTE_LOG_LINE in existing macros that append a \n.
Signed-off-by: David Marchand
---
lib/bbdev/rte_bbdev.c | 3 ++-
lib/cfgfile/rte_cfgfile.c | 4 ++--
lib/compressdev/rte_compressdev_internal.h | 5 +++--
lib/cryptodev/rte_cryptodev.h | 1
On Fri, Nov 17, 2023 at 02:18:21PM +0100, David Marchand wrote:
> Getting readable and consistent logs is important when running a DPDK
> application, especially when troubleshooting.
> A common issue with logs is when a DPDK change do not add (or on the
> contrary add too many \n) in the format st
> From: David Marchand [mailto:david.march...@redhat.com]
> Sent: Friday, 17 November 2023 14.18
>
> Getting readable and consistent logs is important when running a DPDK
> application, especially when troubleshooting.
> A common issue with logs is when a DPDK change do not add (or on the
> contra
On Fri, Nov 17, 2023 at 2:27 PM Bruce Richardson
wrote:
>
> On Fri, Nov 17, 2023 at 02:18:21PM +0100, David Marchand wrote:
> > Getting readable and consistent logs is important when running a DPDK
> > application, especially when troubleshooting.
> > A common issue with logs is when a DPDK change
On Fri, Nov 17, 2023 at 2:47 PM Morten Brørup
wrote:
>
> > From: David Marchand [mailto:david.march...@redhat.com]
> > Sent: Friday, 17 November 2023 14.18
> >
> > Getting readable and consistent logs is important when running a DPDK
> > application, especially when troubleshooting.
> > A common
On Fri, Nov 17, 2023 at 02:48:25PM +0100, David Marchand wrote:
> On Fri, Nov 17, 2023 at 2:27 PM Bruce Richardson
> wrote:
> >
> > On Fri, Nov 17, 2023 at 02:18:21PM +0100, David Marchand wrote:
> > > Getting readable and consistent logs is important when running a DPDK
> > > application, especia
> From: David Marchand [mailto:david.march...@redhat.com]
> Sent: Friday, 17 November 2023 15.10
>
> On Fri, Nov 17, 2023 at 2:47 PM Morten Brørup
> wrote:
> >
> > > From: David Marchand [mailto:david.march...@redhat.com]
> > > Sent: Friday, 17 November 2023 14.18
> > >
> > > Getting readable and
On Fri, Nov 17, 2023 at 3:11 PM Bruce Richardson
wrote:
>
> On Fri, Nov 17, 2023 at 02:48:25PM +0100, David Marchand wrote:
> > On Fri, Nov 17, 2023 at 2:27 PM Bruce Richardson
> > wrote:
> > >
> > > On Fri, Nov 17, 2023 at 02:18:21PM +0100, David Marchand wrote:
> > > > Getting readable and cons
> -Original Message-
> From: Sivaramakrishnan Venkat
> Sent: Friday, November 17, 2023 12:38 PM
> To: dev@dpdk.org
> Cc: sta...@dpdk.org; Ji, Kai ; gak...@marvell.com;
> Sivaramakrishnan, VenkatX
> Subject: [PATCH v2] crypto/qat: fix block cipher misalignment for AES CBC and
> 3DES CBC
Zero length arrays are a GNU extension that has been
superseded by flex arrays.
https://gcc.gnu.org/onlinedocs/gcc/Zero-Length.html
These are places found by cocci/zero_length_array.cocci
Series-acked-by: Morten Brørup
v3 - fix misuse of flex array in dpaxx found by clang
v2 - rebased on 23.1
Zero length arrays are GNU extension. Replace with
standard flex array.
Signed-off-by: Stephen Hemminger
Reviewed-by: Tyler Retzlaff
---
lib/member/rte_member_heap.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/member/rte_member_heap.h b/lib/member/rte_member_heap.h
i
Zero length arrays are GNU extension. Replace with
standard flex array.
Signed-off-by: Stephen Hemminger
Reviewed-by: Tyler Retzlaff
---
lib/cryptodev/cryptodev_pmd.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/cryptodev/cryptodev_pmd.h b/lib/cryptodev/cryptodev_pmd.
Zero length arrays are GNU extension. Replace with
standard flex array.
Signed-off-by: Stephen Hemminger
Reviewed-by: Tyler Retzlaff
---
lib/security/rte_security_driver.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/security/rte_security_driver.h
b/lib/security/rte_
Zero length arrays are GNU extension. Replace with
standard flex array.
Signed-off-by: Stephen Hemminger
Reviewed-by: Tyler Retzlaff
---
lib/pipeline/rte_swx_pipeline_internal.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/pipeline/rte_swx_pipeline_internal.h
b/lib/p
Zero length arrays are GNU extension. Replace with
standard flex array.
Signed-off-by: Stephen Hemminger
Acked-by: Niklas Söderlund
Reviewed-by: Tyler Retzlaff
---
drivers/net/nfp/flower/nfp_flower_cmsg.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/nfp/flowe
Zero length arrays are GNU extension. Replace with
standard flex array.
Signed-off-by: Stephen Hemminger
Acked-by: John Daley
Reviewed-by: Tyler Retzlaff
---
drivers/net/enic/base/vnic_devcmd.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/enic/base/vnic_devcm
Zero length arrays are GNU extension. Replace with
standard flex array.
Signed-off-by: Stephen Hemminger
Reviewed-by: Tyler Retzlaff
---
drivers/common/mlx5/mlx5_prm.h | 2 +-
drivers/net/mlx5/mlx5.h| 4 ++--
drivers/net/mlx5/mlx5_flow.h | 2 +-
drivers/net/mlx5/mlx5_tx.h | 2 +-
Zero length arrays are GNU extension. Replace with
standard flex array.
Signed-off-by: Stephen Hemminger
Reviewed-by: Tyler Retzlaff
Acked-by: Anoob Joseph
---
lib/pdcp/pdcp_entity.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/pdcp/pdcp_entity.h b/lib/pdcp/pdcp_enti
Zero length arrays are GNU extension. Replace with
standard flex array.
Signed-off-by: Stephen Hemminger
Reviewed-by: Tyler Retzlaff
---
drivers/net/cpfl/cpfl_flow_engine_fxp.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/cpfl/cpfl_flow_engine_fxp.c
b/drivers
There is a place holder zero length array in this driver.
But since the structure is embedded in other structures,
it could not have been safely used anyway.
There doesn't appear to be any uses of it in the current code.
Signed-off-by: Stephen Hemminger
---
drivers/common/dpaax/caamflib/desc/ips
On Fri, 17 Nov 2023 09:29:41 +
Ferruh Yigit wrote:
> >> I agree using 'l3_len' instead is correct fix.
> >>
> >> But this requires ABI/API change,
> >> plus do we have any reason to keep the padding, discarding it as this
> >> patch does is also simpler alternative.
> >
> >
> > Possibly a
On Fri, 17 Nov 2023 13:11:50 +0100
Morten Brørup wrote:
> > rte_ipv4_udptcp_cksum_mbuf() and rte_ipv6_udptcp_cksum_mbuf() are
> > inline
> > functions, unfortunately we can't version them.
> >
> > But those functions already gets IP header as parameter, can't we use
> > IP
> > header to get the
The response from MP server sets err_value to negative
on error. The convention for rte_errno is to use a positive
value on error. This makes errors like duplicate registration
show up with the correct error value.
Fixes: 660098d61f57 ("pdump: use generic multi-process channel")
Signed-off-by: Ste
It fixes issues related to timestamping. The design choices are
to maximize performance in the primary process; and do
all the time adjustment in the secondary (dumpcap) since
the dumpcap needs to system calls anyway to write the result.
This patches set changes where the adjustment is calculated
If dumpcap is run twice with each instance pointing a different
interface, it would fail because of overlap in ring a pool names.
Fix by putting process id in the name.
It is still not allowed to do multiple invocations on the same
interface because only one callback is allowed and only one copy
o
The computation of timestamp is best done in the part of
pcapng library that is in secondary process.
The secondary process is already doing a bunch of system
calls which makes it not performance sensitive.
This does change the rte_pcapng_copy()
and rte_pcapng_write_stats() experimental API's.
Sim
The function alloca() like VLA's has problems if the caller
passes a large value. Instead use a fixed size buffer (2K)
which will be more than sufficient for the info related blocks
in the file. Add bounds checks as well.
Signed-off-by: Stephen Hemminger
Acked-by: Morten Brørup
---
lib/pcapng/r
Overhaul of the pcapng test:
- promote it to be a fast test so it gets regularly run.
- create null device and use i.
- use UDP discard packets that are valid so that for debugging
the resulting pcapng file can be looked at with wireshark.
- do basic checks on resulting pcap file that l
Both good points, I'll be sure to add/adjust those docstrings.
On Thu, Nov 16, 2023 at 1:05 PM Juraj Linkeš
wrote:
> On Mon, Nov 13, 2023 at 9:28 PM wrote:
> >
> > From: Jeremy Spewock
> >
> > Adds methods in both os_session and linux session to allow for setting
> > MTU of port interfaces in
On Thu, Nov 16, 2023 at 1:10 PM Juraj Linkeš
wrote:
> On Mon, Nov 13, 2023 at 9:28 PM wrote:
> >
> > From: Jeremy Spewock
> >
> > Added allow list to the EAL parameters created in DTS to ensure that
> > only the relevant PCI devices are considered when launching DPDK
> > applications.
> >
> > S
On Thu, Nov 16, 2023 at 1:34 PM Juraj Linkeš
wrote:
> As I'm thinking about the filtering, it's not a trivial manner. For
> now, I'd like to pass a class instead of multiple parameters, as that
> will be easier to extend if we need to add to the filter. The class
> could be a dataclass holding th
On Thu, Nov 16, 2023 at 1:53 PM Juraj Linkeš
wrote:
> On Mon, Nov 13, 2023 at 9:28 PM wrote:
> >
> > From: Jeremy Spewock
> >
> > Modified interactive applications to allow for the ability to pass
> > parameters into the app on start up. Also modified the way EAL
> > parameters are handled so t
On Thu, Nov 16, 2023 at 2:05 PM Juraj Linkeš
wrote:
> On Mon, Nov 13, 2023 at 9:28 PM wrote:
> >
> > From: Jeremy Spewock
> >
> > Added a method within the testpmd interactive shell that polls the
> > status of ports and verifies that the link status on a given port is
> > "up." Polling will co
On 11/16/2023 4:03 PM, Jesna K E wrote:
> Added TSO support for axgbe PMD.
>
> Initial Implementation for the TSO feature support
> Currently only headers transmitted to
> tester receiver side
>
> Signed-off-by: Jesna K E
> ---
> doc/guides/nics/features/axgbe.ini | 1 +
> drivers/net/axgbe/ax
https://bugs.dpdk.org/show_bug.cgi?id=1328
Bug ID: 1328
Summary: af_xdp driver not built on Fedora 39
Product: DPDK
Version: 23.11
Hardware: All
OS: All
Status: UNCONFIRMED
Severity: normal
Prior
On Fri, Nov 17, 2023 at 08:18:23AM -0800, Stephen Hemminger wrote:
> On Fri, 17 Nov 2023 09:31:11 +0100
> Morten Brørup wrote:
>
> > Series-acked-by: Morten Brørup
> >
> > Suggest checkpatches to disallow this, if it doesn't already.
>
> Unfortunately, matching this with awk is too hard. Cocci
Document the basic requirements for download and add an option
describing how to build with MSVC.
Signed-off-by: Tyler Retzlaff
---
doc/guides/windows_gsg/build_dpdk.rst | 33 -
1 file changed, 28 insertions(+), 5 deletions(-)
diff --git a/doc/guides/windows_gsg/
Hello,
We will be doing some network maintenance at the Community Lab tomorrow,
11/18, which will result in CI testing being offline from approximately
12:00 UTC to 8:00 UTC. Testing will resume as normal tomorrow evening, and
if there are any patchseries which are submitted during the downtime, w
66 matches
Mail list logo
