Re: [PATCH 1/1] eal: add C++ include guard in generic/rte_vect.h

2024-03-13 Thread Ashish Sadanandan
On Mon, Feb 12, 2024 at 9:02 AM Morten Brørup wrote: > > From: Ferruh Yigit [mailto:ferruh.yi...@amd.com] > > Sent: Monday, 12 February 2024 16.43 > > > > On 2/5/2024 9:07 PM, Morten Brørup wrote: > > >> From: Tyler Retzlaff [mailto:roret...@linux.microsoft.com] > > >> Sent: Monday, 5 February 20

Re: [PATCH 1/1] eal: add C++ include guard in generic/rte_vect.h

2024-03-13 Thread Thomas Monjalon
13/03/2024 21:26, Ashish Sadanandan: > On Mon, Feb 12, 2024 at 9:02 AM Morten Brørup > wrote: > > > > From: Ferruh Yigit [mailto:ferruh.yi...@amd.com] > > > Sent: Monday, 12 February 2024 16.43 > > > > > > On 2/5/2024 9:07 PM, Morten Brørup wrote: > > > >> From: Tyler Retzlaff [mailto:roret...@li

Re: [PATCH] test-pmd: add more packet decode options (verbose)

2024-03-13 Thread Stephen Hemminger
On Tue, 12 Mar 2024 15:01:27 -0700 Stephen Hemminger wrote: > The existing verbose levels 1..3 provide a messy multi-line > output per packet. This is unhelpful when diagnosing many > types of problems like packet flow. > > This patch adds two new levels: > 4: one line per packet is printed in a

[RFC] doc: update required Mingw version

2024-03-13 Thread Stephen Hemminger
Add a required version for mingw. The version is selected is the version available for Debian oldstable (Bullseye) as listed on: https://www.mingw-w64.org/downloads/ The 10.0 version was released in 4/4/2022, The current upstream version 11.0. Also drop note about Ubuntu 16.04 because that rele

Re: [PATCH 1/1] eal: add C++ include guard in generic/rte_vect.h

2024-03-13 Thread Ashish Sadanandan
On Wed, Mar 13, 2024 at 2:45 PM Thomas Monjalon wrote: > 13/03/2024 21:26, Ashish Sadanandan: > > On Mon, Feb 12, 2024 at 9:02 AM Morten Brørup > > wrote: > > > > > > From: Ferruh Yigit [mailto:ferruh.yi...@amd.com] > > > > Sent: Monday, 12 February 2024 16.43 > > > > > > > > On 2/5/2024 9:07 PM

RE: [EXTERNAL] [PATCH] app/crypto-perf-test: fix unset crc algorithm

2024-03-13 Thread Kusztal, ArkadiuszX
> -Original Message- > From: Akhil Goyal > Sent: Wednesday, March 13, 2024 7:22 PM > To: Kusztal, ArkadiuszX ; dev@dpdk.org > Cc: Power, Ciara > Subject: RE: [EXTERNAL] [PATCH] app/crypto-perf-test: fix unset crc algorithm > > > Because net crc api is not thread-safe, setting crc algo

Re: [PATCH 4/4] app/testpmd: enhance getopt_long usage

2024-03-13 Thread Ferruh Yigit
On 3/13/2024 4:51 PM, David Marchand wrote: <...> >> >> And just after while loop, there is "if (optind != argc)" check, I don't >> see when this check will be hit, so it looks useless. > But this part actually looks correct to me. > We could still hit this part with non handled trailing strings:

Re: [PATCH 4/4] app/testpmd: enhance getopt_long usage

2024-03-13 Thread Ferruh Yigit
On 3/13/2024 5:20 PM, David Marchand wrote: > On Wed, Mar 13, 2024 at 5:51 PM David Marchand > wrote: >>> + { TESTPMD_OPT_ETH_PEERS_CONFIGFILE, 1, NULL, TESTPMD_OPT_ETH_PEERS_CONFIGFILE_NUM }, + { TESTPMD_OPT_ETH_PEER, 1, NULL, TESTPMD_OPT_ETH_PEER_NUM }, >>> >>> These

RE: [EXTERNAL] [PATCH 1/2] examples/ipsec-secgw: fix SA salt endianness problem

2024-03-13 Thread Chaoyong He
> > Subject: [EXTERNAL] [PATCH 1/2] examples/ipsec-secgw: fix SA salt > > endianness problem > > From: Shihong Wang > > > > The SA salt of struct ipsec_sa is a CPU-endian u32 variable, but it’s > > value is stored in an array of encryption or authentication keys > > according to big-endian. So it

[PATCH] net/iavf: fix fail to reset vf when using dcf

2024-03-13 Thread Kaiwen Deng
On the latest ice kernel driver, renegotiating VIRTCHNL_OP_GET_VF_RESOURCES will fail without hardware reset when using dcf. This commit will send VIRTCHNL_OP_RESET_VF to pf before dpdk resets vf. Fixes: 7a93cd3575eb ("net/iavf: add VF reset check") Cc: sta...@dpdk.org Signed-off-by: Kaiwen Deng

[PATCH v2] examples/ipsec-secgw: fix SA salt endianness problem

2024-03-13 Thread Chaoyong He
From: Shihong Wang The SA salt of struct ipsec_sa is a CPU-endian u32 variable, but it’s value is stored in an array of encryption or authentication keys according to big-endian. So it maybe need to convert the endianness order to ensure that the value assigned to the SA salt is CPU-endian. Fixe

Re: [PATCH 1/1] eal: add C++ include guard in generic/rte_vect.h

2024-03-13 Thread Tyler Retzlaff
On Wed, Mar 13, 2024 at 04:45:36PM -0700, Stephen Hemminger wrote: > On Fri, 2 Feb 2024 13:58:19 -0700 > Ashish Sadanandan wrote: > > > > I think just having the extern "C" guard in all files is the safest > > > choice, > > > because it's immediately obvious in each and every file that it is >

<    1   2