[PATCH v2 0/3] Introduce event pre-scheduling

2024-09-17 Thread pbhagavatula
From: Pavan Nikhilesh Event pre-scheduling improves scheduling performance by assigning events to event ports in advance when dequeues are issued. This series introduces various types and levels of pre-scheduling to the eventdev library. pre-scheduling Types: * RTE_EVENT_DEV_PRESCHEDULE_NONE: N

[PATCH v2 1/3] eventdev: introduce event pre-scheduling

2024-09-17 Thread pbhagavatula
From: Pavan Nikhilesh Event pre-scheduling improves scheduling performance by assigning events to event ports in advance when dequeues are issued. The dequeue operation initiates the pre-schedule operation, which completes in parallel without affecting the dequeued event flow contexts and dequeue

[PATCH v2 2/3] eventdev: add event port pre-schedule modify

2024-09-17 Thread pbhagavatula
From: Pavan Nikhilesh Some event devices allow pre-schedule types to be modified at runtime on an event port. Add `RTE_EVENT_DEV_CAP_EVENT_PER_PORT_PRESCHEDULE` capability to indicate that the event device supports this feature. Add `rte_event_port_preschedule_modify()` API to modify the pre-sch

[PATCH v2 3/3] eventdev: add SW event preschedule hint

2024-09-17 Thread pbhagavatula
From: Pavan Nikhilesh Add a new eventdev API to provide a hint to the eventdev PMD to pre-schedule the next event into the event port, without releasing the current flow context. Event device that support this feature advertises the capability using the RTE_EVENT_DEV_CAP_SW_PRESCHEDULE capability

RE: [PATCH v4 1/7] eal: add static per-lcore memory allocation facility

2024-09-17 Thread Morten Brørup
> From: Konstantin Ananyev [mailto:konstantin.anan...@huawei.com] > Sent: Tuesday, 17 September 2024 01.20 > > > > > +/** > > > > + * Get pointer to lcore variable instance of the current thread. > > > > + * > > > > + * May only be used by EAL threads and registered non-EAL threads. > > > > + */ >

RE: [PATCH] net/tap: add new macpair option for split MAC address

2024-09-17 Thread Morten Brørup
> From: Isaac Boukris [mailto:ibouk...@gmail.com] > Sent: Tuesday, 17 September 2024 08.49 > > Hi Stephen > > On Tue, Sep 17, 2024 at 6:36 AM Stephen Hemminger > wrote: > > > > On Mon, 16 Sep 2024 20:38:51 +0300 > > Isaac Boukris wrote: > > > > > + if (mac_pair) { > > > +

RE: [PATCH v4 1/7] eal: add static per-lcore memory allocation facility

2024-09-17 Thread Konstantin Ananyev
> > From: Konstantin Ananyev [mailto:konstantin.anan...@huawei.com] > > Sent: Tuesday, 17 September 2024 01.20 > > > > > > > +/** > > > > > + * Get pointer to lcore variable instance of the current thread. > > > > > + * > > > > > + * May only be used by EAL threads and registered non-EAL threads.

[PATCH v9] mempool: test performance with larger bursts

2024-09-17 Thread Morten Brørup
Bursts of up to 64, 128 and 256 packets are not uncommon, so increase the maximum tested get and put burst sizes from 32 to 256. For convenience, also test get and put burst sizes of RTE_MEMPOOL_CACHE_MAX_SIZE. Some applications keep more than 512 objects, so increase the maximum number of kept ob

Re: [PATCH 1/2] eal/linux: fix VFIO hotplug with multiprocess

2024-09-17 Thread Maxime Coquelin
On 9/16/24 14:30, David Marchand wrote: At the moment, if VFIO is not available at DPDK init, it won't be available unless a subsequent rte_vfio_enable() is done. Yet, even if rte_vfio_enable() is called again in primary and secondary processes, a secondary process will never get to know that

Re: [PATCH 2/2] bus/pci: enhance hotplug for VFIO bound devices

2024-09-17 Thread Maxime Coquelin
On 9/16/24 14:30, David Marchand wrote: VFIO modules may get loaded/initialized after DPDK initialized (like when starting an application without knowing which devices will be used, and whether their drivers require VFIO). Retry enabling VFIO if not available. This way, it is not required to

RE: [EXTERNAL] [v2 0/7] DPAA2 crypto changes

2024-09-17 Thread Akhil Goyal
> v2 changes: > * fix patch sequence > * add missing code in > "crypto/dpaa2_sec: rework debug code" > > Changes related to crypto driver > > Gagandeep Singh (1): > crypto/dpaa2_sec: fix memory leak > > Jun Yang (5): > net/dpaa2: support FLC stashing API > crypto/dpaa2_se

RE: [PATCH 0/6] Fixes and improvements in crypto unit tests

2024-09-17 Thread Akhil Goyal
> Subject: [PATCH 0/6] Fixes and improvements in crypto unit tests > > Enable larger packet sizes in TLS tests and add minor improvements in > crypto unit tests. > > Anoob Joseph (6): > test/crypto: add asserts to validate test lengths > test/crypto: enable larger packet sizes with TLS > te

RE: [PATCH 00/11] fixes and improvements to cnxk crypto PMD

2024-09-17 Thread Akhil Goyal
> Subject: [PATCH 00/11] fixes and improvements to cnxk crypto PMD > > Adding new PMD APIs and improvements to cnxk crypto PMD. > > Anoob Joseph (9): > common/cnxk: ensure CPTR is 128B aligned > common/cnxk: rearrange to remove hole > common/cnxk: remove abort from flush API > common/cnxk

RE: [PATCH v1 1/3] cryptodev: add queue pair reset API

2024-09-17 Thread Akhil Goyal
> Subject: [PATCH v1 1/3] cryptodev: add queue pair reset API > > The API will reset the specific queue pair of a cryptodev. > The current API, cryptodev_queue_pair_setup(), requires the cryptodev > to be stopped before reconfiguring any queue pair. Stopping the > cryptodev in one thread can res

RE: [PATCH v1 3/3] test/crypto: add support for error recovery

2024-09-17 Thread Akhil Goyal
> Subject: [PATCH v1 3/3] test/crypto: add support for error recovery > > Add a callback for error recovery and register it with cryptodev. > Add a unit test to verify the error recovery of cryptodev. > The unit test generates an error by passing an mbuf to cryptodev > allocated from heap memory.

RE: [PATCH v1 2/3] crypto/cnxk: add queue pair reset support

2024-09-17 Thread Akhil Goyal
> Subject: [PATCH v1 2/3] crypto/cnxk: add queue pair reset support > > Add support for reset of a specific queue pair on cnxk platform. > > Signed-off-by: Vidya Sagar Velumuri Acked-by: Akhil Goyal

RE: [PATCH v2] examples/ipsec-secgw: fix dequeue count from cryptodev

2024-09-17 Thread Akhil Goyal
> Subject: [PATCH v2] examples/ipsec-secgw: fix dequeue count from cryptodev > > Setting dequeue packet count to max of MAX_PKT_BURST > size instead of MAX_PKTS. > > Dequeue from cryptodev is called with MAX_PKTS but > routing functions allocate hop/dst_ip arrays of > size MAX_PKT_BURST. This can

RE: [EXTERNAL] [PATCH] doc: fix crashes in scheduler_multicore due to incorrect variable usage

2024-09-17 Thread Akhil Goyal
Hi Kai, Please review. The patch title is not correct. Please fix. > The variable `pending_deq_ops` was incorrectly used > instead of `pending_enq_ops`. > This causes the program to crash > when the worker PMD accesses the session > > Bugzilla ID: 1537 > Fixes: 6812b9bf470e ("crypto/scheduler: u

Re: [PATCH v6 1/6] dpdk: do not force C linkage on include file dependencies

2024-09-17 Thread Mattias Rönnblom
On 2024-09-16 14:05, David Marchand wrote: Hello, On Tue, Sep 10, 2024 at 10:41 AM Mattias Rönnblom wrote: diff --git a/lib/acl/rte_acl_osdep.h b/lib/acl/rte_acl_osdep.h index 3c1dc402ca..e4c7d07c69 100644 --- a/lib/acl/rte_acl_osdep.h +++ b/lib/acl/rte_acl_osdep.h @@ -5,10 +5,6 @@ #ifndef _

[PATCH v7 4/6] eal: add atomic bit operations

2024-09-17 Thread Mattias Rönnblom
Add atomic bit test/set/clear/assign/flip and test-and-set/clear/assign/flip functions. All atomic bit functions allow (and indeed, require) the caller to specify a memory order. Signed-off-by: Mattias Rönnblom Acked-by: Morten Brørup Acked-by: Tyler Retzlaff Acked-by: Jack Bond-Preston --

[PATCH v7 0/6] Improve EAL bit operations API

2024-09-17 Thread Mattias Rönnblom
This patch set represent an attempt to improve and extend the RTE bitops API, in particular for functions that operate on individual bits. All new functionality is exposed to the user as generic selection macros, delegating the actual work to private (__-marked) static inline functions. Public fun

[PATCH v7 3/6] eal: add unit tests for bit operations

2024-09-17 Thread Mattias Rönnblom
Extend bitops tests to cover the rte_bit_[test|set|clear|assign|flip]() functions. The tests are converted to use the test suite runner framework. Signed-off-by: Mattias Rönnblom Acked-by: Morten Brørup Acked-by: Tyler Retzlaff Acked-by: Jack Bond-Preston -- RFC v6: * Test rte_bit_*test()

[PATCH v7 5/6] eal: add unit tests for atomic bit access functions

2024-09-17 Thread Mattias Rönnblom
Extend bitops tests to cover the rte_bit_atomic_*() family of functions. Signed-off-by: Mattias Rönnblom Acked-by: Morten Brørup Acked-by: Tyler Retzlaff Acked-by: Jack Bond-Preston -- RFC v4: * Add atomicity test for atomic bit flip. RFC v3: * Rename variable 'main' to make ICC happy. --

[PATCH v7 2/6] eal: extend bit manipulation functionality

2024-09-17 Thread Mattias Rönnblom
Add functionality to test and modify the value of individual bits in 32-bit or 64-bit words. These functions have no implications on memory ordering, atomicity and does not use volatile and thus does not prevent any compiler optimizations. Signed-off-by: Mattias Rönnblom Acked-by: Morten Brørup

[PATCH v7 6/6] eal: extend bitops to handle volatile pointers

2024-09-17 Thread Mattias Rönnblom
Have rte_bit_[test|set|clear|assign|flip]() and rte_bit_atomic_*() handle volatile-marked pointers. Signed-off-by: Mattias Rönnblom Acked-by: Morten Brørup Acked-by: Jack Bond-Preston -- PATCH v3: * Updated to reflect removed 'fun' parameter in __RTE_GEN_BIT_*() (Jack Bond-Preston). PATC

Re: [PATCH v2] dts: fix runner target in the Dockerfile

2024-09-17 Thread Luca Vizzarro
Reviewed-by: Luca Vizzarro

RE: [RFC PATCH 0/3] add featur arc in rte_graph

2024-09-17 Thread Kiran Kumar Kokkilagadda
> -Original Message- > From: Nitin Saxena > Sent: Saturday, September 7, 2024 12:35 PM > To: Jerin Jacob ; Kiran Kumar Kokkilagadda > ; Nithin Kumar Dabilpuram > ; Zhirun Yan > Cc: dev@dpdk.org > Subject: [RFC PATCH 0/3] add featur arc in rte_graph > > Feature arc represents an ordere

[PATCH v8 2/6] eal: extend bit manipulation functionality

2024-09-17 Thread Mattias Rönnblom
Add functionality to test and modify the value of individual bits in 32-bit or 64-bit words. These functions have no implications on memory ordering, atomicity and does not use volatile and thus does not prevent any compiler optimizations. Signed-off-by: Mattias Rönnblom Acked-by: Morten Brørup

[PATCH v8 3/6] eal: add unit tests for bit operations

2024-09-17 Thread Mattias Rönnblom
Extend bitops tests to cover the rte_bit_[test|set|clear|assign|flip]() functions. The tests are converted to use the test suite runner framework. Signed-off-by: Mattias Rönnblom Acked-by: Morten Brørup Acked-by: Tyler Retzlaff Acked-by: Jack Bond-Preston -- RFC v6: * Test rte_bit_*test()

[PATCH v8 6/6] eal: extend bitops to handle volatile pointers

2024-09-17 Thread Mattias Rönnblom
Have rte_bit_[test|set|clear|assign|flip]() and rte_bit_atomic_*() handle volatile-marked pointers. Signed-off-by: Mattias Rönnblom Acked-by: Morten Brørup Acked-by: Jack Bond-Preston -- PATCH v3: * Updated to reflect removed 'fun' parameter in __RTE_GEN_BIT_*() (Jack Bond-Preston). PATC

[PATCH v8 0/6] Improve EAL bit operations API

2024-09-17 Thread Mattias Rönnblom
This patch set represent an attempt to improve and extend the RTE bitops API, in particular for functions that operate on individual bits. All new functionality is exposed to the user as generic selection macros, delegating the actual work to private (__-marked) static inline functions. Public fun

[PATCH v8 5/6] eal: add unit tests for atomic bit access functions

2024-09-17 Thread Mattias Rönnblom
Extend bitops tests to cover the rte_bit_atomic_*() family of functions. Signed-off-by: Mattias Rönnblom Acked-by: Morten Brørup Acked-by: Tyler Retzlaff Acked-by: Jack Bond-Preston -- RFC v4: * Add atomicity test for atomic bit flip. RFC v3: * Rename variable 'main' to make ICC happy. --

[PATCH v8 4/6] eal: add atomic bit operations

2024-09-17 Thread Mattias Rönnblom
Add atomic bit test/set/clear/assign/flip and test-and-set/clear/assign/flip functions. All atomic bit functions allow (and indeed, require) the caller to specify a memory order. Signed-off-by: Mattias Rönnblom Acked-by: Morten Brørup Acked-by: Tyler Retzlaff Acked-by: Jack Bond-Preston --

Re: [PATCH 3/5] dts: use Pydantic in the configuration

2024-09-17 Thread Juraj Linkeš
On 22. 8. 2024 18:39, Luca Vizzarro wrote: This change brings in Pydantic in place of Warlock. Pydantic offers a built-in model validation system in the classes, which allows for a more resilient and simpler code. As a consequence of this change: - most validation is now built-in - further va

Re: [RFC v3 1/3] uapi: introduce kernel uAPI headers import

2024-09-17 Thread David Marchand
On Wed, Sep 11, 2024 at 9:32 PM Maxime Coquelin wrote: > > This patch introduces uAPI headers import into the DPDK > repository. This import is possible thanks to Linux Kernel > licence exception for syscalls: > > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/LICENSES/exc

Re: [PATCH 4/5] dts: use TestSuiteSpec class imports

2024-09-17 Thread Juraj Linkeš
diff --git a/dts/framework/runner.py b/dts/framework/runner.py @@ -229,139 +221,34 @@ def _get_test_suites_with_cases( +filtered_test_cases: list[TestCase] = [ +test_case +for test_case in test_suite_spec.test_cases +if not test_

[PATCH] net/tap: add new macpair option for split MAC address

2024-09-17 Thread Isaac Boukris
Normally, the MAC address of the kernel interface is the same as in the interface in dpdk, as they represent the same interface. It is useful to allow viewing them as separate connected interfaces (like ip's veth). This solves a problem I have running a freebsd-based IPv6 stack on top of dpdk and

Re: [PATCH 5/5] dts: add JSON schema generation script

2024-09-17 Thread Juraj Linkeš
create mode 100755 dts/generate-schema.py Could it be worth putting this into devtools? It is a devtool. diff --git a/doc/guides/tools/dts.rst b/doc/guides/tools/dts.rst @@ -430,6 +430,16 @@ Refer to the script for usage: ``devtools/dts-check-format.sh -h``. Configuration Schema

[PATCH v4 0/5] Stage-Ordered API and other extensions for ring library

2024-09-17 Thread Konstantin Ananyev
From: Konstantin Ananyev v2 -> v3: - fix compilation/doxygen complains (attempt #2) - updated release notes v2 -> v3: - fix compilation/doxygen complains - dropped patch: "examples/l3fwd: make ACL work in pipeline and eventdev modes": [2] As was mentioned in the patch desctiption it was way

[PATCH v4 1/5] ring: common functions for 'move head' ops

2024-09-17 Thread Konstantin Ananyev
From: Konstantin Ananyev Note upfront: that change doesn't introduce any functional or performance changes. It is just a code-reordering for: - code deduplication - ability in future to re-use the same code to introduce new functionality For each sync mode corresponding move_prod_head() and mo

[PATCH v4 2/5] ring: make copying functions generic

2024-09-17 Thread Konstantin Ananyev
From: Konstantin Ananyev Note upfront: that change doesn't introduce any functional or performance changes. It is just a code-reordering for: - improve code modularity and re-usability - ability in future to re-use the same code to introduce new functionality There is no real need for enqueue_

[PATCH v4 3/5] ring: make dump function more verbose

2024-09-17 Thread Konstantin Ananyev
From: Eimear Morrissey The current rte_ring_dump function uses the generic rte_ring_headtail structure to access head/tail positions. This is incorrect for the RTS case where the head is stored in a different offset in the union of structs. Switching to a separate function for each sync type allo

[PATCH v4 4/5] ring/soring: introduce Staged Ordered Ring

2024-09-17 Thread Konstantin Ananyev
From: Konstantin Ananyev Staged-Ordered-Ring (SORING) provides a SW abstraction for 'ordered' queues with multiple processing 'stages'. It is based on conventional DPDK rte_ring, re-uses many of its concepts, and even substantial part of its code. It can be viewed as an 'extension' of rte_ring fu

[PATCH v4 5/5] app/test: add unit tests for soring API

2024-09-17 Thread Konstantin Ananyev
From: Konstantin Ananyev Add both functional and stess test-cases for soring API. Stress test serves as both functional and performance test of soring enqueue/dequeue/acquire/release operations under high contention (for both over committed and non-over committed scenarios). Signed-off-by: Eimea

Re: [PATCH] net/tap: add new macpair option for split MAC address

2024-09-17 Thread Isaac Boukris
Hi, This is a V2 addressing previous comments, I mistakenly passed the -v2 to send-mail instead of format-patch.. Thanks! On Tue, Sep 17, 2024 at 2:52 PM Isaac Boukris wrote: > > Normally, the MAC address of the kernel interface is the same as in the > interface in dpdk, as they represent the s

[PATCH v1] common/iavf: update README documentation

2024-09-17 Thread Soumyadeep Hore
Updating README documentation to have the latest version for IAVF Base driver. Signed-off-by: Soumyadeep Hore --- drivers/common/iavf/README | 8 +++- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/drivers/common/iavf/README b/drivers/common/iavf/README index 89bdbc827e..d91e4

Re: [PATCH v1] common/iavf: update README documentation

2024-09-17 Thread Bruce Richardson
On Tue, Sep 17, 2024 at 11:45:02AM +, Soumyadeep Hore wrote: > Updating README documentation to have the latest > version for IAVF Base driver. > > Signed-off-by: Soumyadeep Hore > --- > drivers/common/iavf/README | 8 +++- > 1 file changed, 3 insertions(+), 5 deletions(-) > > diff --gi

Re: [PATCH v3 1/1] dts: add text parser for testpmd verbose output

2024-09-17 Thread Jeremy Spewock
On Mon, Sep 9, 2024 at 7:44 AM Juraj Linkeš wrote: > > > > diff --git a/dts/framework/parser.py b/dts/framework/parser.py > > index 741dfff821..0b39025a48 100644 > > --- a/dts/framework/parser.py > > +++ b/dts/framework/parser.py > > @@ -160,6 +160,36 @@ def _find(text: str) -> Any: > > > >

Re: [PATCH v1] common/iavf: update README documentation

2024-09-17 Thread Bruce Richardson
On Tue, Sep 17, 2024 at 03:20:59PM +0100, Hore, Soumyadeep wrote: > Hi Bruce, > > The below wording looks fine. We can proceed with it. > Applied to dpdk-next-net-intel after base code update patchset. Thanks, /Bruce

Re: [PATCH v1 0/9] Update IAVF Base Driver

2024-09-17 Thread Bruce Richardson
On Mon, Sep 16, 2024 at 03:29:12PM +0100, Bruce Richardson wrote: > On Tue, Sep 10, 2024 at 10:12:15AM +, Soumyadeep Hore wrote: > > Updated the IAVF Base driver with latest sharedcode patches. > > > > Ahmed Zaki (2): > > common/iavf: define the maximum MSIX index > > common/iavf: add RSS

RE: [PATCH v1] common/iavf: update README documentation

2024-09-17 Thread Hore, Soumyadeep
Hi Bruce, The below wording looks fine. We can proceed with it. On Tue, Sep 17, 2024 at 11:45:02AM +, Soumyadeep Hore wrote: > Updating README documentation to have the latest version for IAVF Base > driver. > > Signed-off-by: Soumyadeep Hore > --- > drivers/common/iavf/README | 8 +++

Re: [PATCH v3 0/9] riscv: implement accelerated crc using zbc

2024-09-17 Thread Daniel Gregory
Would it be possible to get a review on this patchset? I would be happy to hear any feedback on the approach to RISC-V extension detection or how I have implemented the hardware-optimised CRCs. Kind regards, Daniel

Re: [PATCH v4 1/7] eal: add static per-lcore memory allocation facility

2024-09-17 Thread Mattias Rönnblom
On 2024-09-16 16:02, Konstantin Ananyev wrote: Introduce DPDK per-lcore id variables, or lcore variables for short. An lcore variable has one value for every current and future lcore id-equipped thread. The primary use case is for statically allocating small, frequently-accessed data struct

Re: [PATCH] net/iavf: delay VF reset command

2024-09-17 Thread Bruce Richardson
On Mon, Sep 09, 2024 at 12:03:56PM +0100, Bruce Richardson wrote: > Commit 0f9ec0cbd2a9 ("net/iavf: fix VF reset when using DCF"), > introduced a VF-reset adminq call into the reset sequence for iavf. > However, that call was very early in the sequence before other adminq > commands had been sent.

Re: [RFC v3 1/3] uapi: introduce kernel uAPI headers import

2024-09-17 Thread Maxime Coquelin
On 9/17/24 13:36, David Marchand wrote: On Wed, Sep 11, 2024 at 9:32 PM Maxime Coquelin wrote: This patch introduces uAPI headers import into the DPDK repository. This import is possible thanks to Linux Kernel licence exception for syscalls: https://git.kernel.org/pub/scm/linux/kernel/git/

[PATCH v5 2/7] eal: add lcore variable functional tests

2024-09-17 Thread Mattias Rönnblom
Add functional test suite to exercise the API. Signed-off-by: Mattias Rönnblom Acked-by: Morten Brørup -- RFC v5: * Adapt tests to reflect the removal of the GET() and SET() macros. RFC v4: * Check all lcore id's values for all variables in the many variables test case. * Introduce tes

[PATCH v5 7/7] eal: keep per-lcore power intrinsics state in lcore variable

2024-09-17 Thread Mattias Rönnblom
Keep per-lcore power intrinsics state in a lcore variable to reduce cache working set size and avoid any CPU next-line-prefetching causing false sharing. Signed-off-by: Mattias Rönnblom Acked-by: Morten Brørup Acked-by: Konstantin Ananyev --- lib/eal/x86/rte_power_intrinsics.c | 17 +++

[PATCH v5 5/7] power: keep per-lcore state in lcore variable

2024-09-17 Thread Mattias Rönnblom
Replace static array of cache-aligned structs with an lcore variable, to slightly benefit code simplicity and performance. Signed-off-by: Mattias Rönnblom Acked-by: Morten Brørup Acked-by: Konstantin Ananyev -- RFC v3: * Replace for loop with FOREACH macro. --- lib/power/rte_power_pmd_mgmt.

[PATCH v5 3/7] eal: add lcore variable performance test

2024-09-17 Thread Mattias Rönnblom
Add basic micro benchmark for lcore variables, in an attempt to assure that the overhead isn't significantly greater than alternative approaches, in scenarios where the benefits aren't expected to show up (i.e., when plenty of cache is available compared to the working set size of the per-lcore dat

[PATCH v5 4/7] random: keep PRNG state in lcore variable

2024-09-17 Thread Mattias Rönnblom
Replace keeping PRNG state in a RTE_MAX_LCORE-sized static array of cache-aligned and RTE_CACHE_GUARDed struct instances with keeping the same state in a more cache-friendly lcore variable. Signed-off-by: Mattias Rönnblom Acked-by: Morten Brørup Acked-by: Konstantin Ananyev -- RFC v3: * Remo

[PATCH v5 6/7] service: keep per-lcore state in lcore variable

2024-09-17 Thread Mattias Rönnblom
Replace static array of cache-aligned structs with an lcore variable, to slightly benefit code simplicity and performance. Signed-off-by: Mattias Rönnblom Acked-by: Morten Brørup Acked-by: Konstantin Ananyev -- RFC v6: * Remove a now-redundant lcore variable value memset(). RFC v5: * Fix l

[PATCH v5 0/7] Lcore variables

2024-09-17 Thread Mattias Rönnblom
This patch set introduces a new API for static per-lcore id data allocation. Please refer to the API documentation for both a rationale for this new API, and a comparison to the alternatives available. The adoption of this API would affect many different DPDK modules, but the author updated onl

[PATCH v5 1/7] eal: add static per-lcore memory allocation facility

2024-09-17 Thread Mattias Rönnblom
Introduce DPDK per-lcore id variables, or lcore variables for short. An lcore variable has one value for every current and future lcore id-equipped thread. The primary use case is for statically allocating small, frequently-accessed data structures, for which one instance should exist for each l

Re: [PATCH v19 5/5] dts: add API doc generation

2024-09-17 Thread Juraj Linkeš
On 16. 9. 2024 14:48, Thomas Monjalon wrote: 16/09/2024 10:51, Juraj Linkeš: On 12. 9. 2024 22:09, Thomas Monjalon wrote: 21/08/2024 17:02, Juraj Linkeš: +req_deps = _get_dependencies(_DTS_DEP_FILE_PATH) +req_deps.pop('python') + +for req_dep, dep_data in (req_deps | _EXTRA_DEPS

Re: [PATCH] test/event: fix missing schedule type assignment

2024-09-17 Thread Jerin Jacob
On Wed, Jul 24, 2024 at 1:02 AM wrote: > > From: Pavan Nikhilesh > > Missing schedule type assignment might set it to > incorrect value, set it to SCHED_TYPE_PARALLEL. > > Fixes: d007a7f39de3 ("eventdev: introduce link profiles") > Cc: sta...@dpdk.org > > Signed-off-by: Pavan Nikhilesh Applied

Re: [PATCH v2] dts: fix runner target in the Dockerfile

2024-09-17 Thread Patrick Robb
Dean actually just came down with an illness. Since the changes in his series are minimal (I see the only ones left are updating dts.rst and the devcontainer json) I think that one of us at UNH should submit a patch which is essentially a v2 of his series. It's probably not worth blocking a "critic

Re: [PATCH] eventdev: do not use zero length arrays

2024-09-17 Thread Jerin Jacob
On Thu, Jul 25, 2024 at 11:24 PM Stephen Hemminger wrote: > > Zero length array's are a GNU C extension and should be replaced > by use of flexible arrayrs. This has been fixed almost everywhere > in DPDK 24.07 but looks like some event code got missed. > > Generated by devtools/cocci/zero_length_

[PATCH] devtools: fix false positive from checkpatch

2024-09-17 Thread Stephen Hemminger
The codespell dictionary has "stdio" in its bad word list, but stdio.h is often used in DPDK code and creates bogus false postitives from checkpatch. Also add a check to the parameters to build-dict.sh so it gives usage error if parameter is missing or does not point to the codespell git clone. S

RE: [PATCH v5 3/7] eal: add lcore variable performance test

2024-09-17 Thread Morten Brørup
> + start = rte_rdtsc(); > + > + for (i = 0; i < ITERATIONS; i++) > + update_fun(mods[i & num_mods_mask]); This indexing adds more instructions to be executed than just the update function. The added overhead is the same for all tested access methods, so the absolute differen

Re: [PATCH] devtools: fix false positive from checkpatch

2024-09-17 Thread Bruce Richardson
On Tue, Sep 17, 2024 at 08:34:21AM -0700, Stephen Hemminger wrote: > The codespell dictionary has "stdio" in its bad word list, > but stdio.h is often used in DPDK code and creates bogus false > postitives from checkpatch. > > Also add a check to the parameters to build-dict.sh so it > gives usage

Re: [PATCH] devtools: fix false positive from checkpatch

2024-09-17 Thread Thomas Monjalon
17/09/2024 17:45, Bruce Richardson: > On Tue, Sep 17, 2024 at 08:34:21AM -0700, Stephen Hemminger wrote: > > The codespell dictionary has "stdio" in its bad word list, > > but stdio.h is often used in DPDK code and creates bogus false > > postitives from checkpatch. > > > > Also add a check to the

Re: [PATCH] examples/eventdev: fix segment fault with generic pipeline

2024-09-17 Thread Jerin Jacob
On Thu, Aug 1, 2024 at 4:54 PM Chengwen Feng wrote: > > There was a segmentation fault when executing eventdev_pipeline with > command [1] with ConnectX-5 NIC card: > > 0x0079208c in rte_eth_tx_buffer (tx_pkt=0x16f8ed300, buffer=0x100, > queue_id=11, port_id=0) at ../lib/ethdev/rte_ethdev

RE: [PATCH v4 1/7] eal: add static per-lcore memory allocation facility

2024-09-17 Thread Konstantin Ananyev
> >> + > >> +/** > >> + * Get pointer to lcore variable instance with the specified lcore id. > >> + * > >> + * @param lcore_id > >> + * The lcore id specifying which of the @c RTE_MAX_LCORE value > >> + * instances should be accessed. The lcore id need not be valid > >> + * (e.g., may be @re

Re: 21.11.8 patches review and test

2024-09-17 Thread Kevin Traynor
On 11/09/2024 14:10, Ali Alnubani wrote: >> -Original Message- >> From: Kevin Traynor >> Sent: Wednesday, September 11, 2024 3:20 PM >> To: Ali Alnubani ; sta...@dpdk.org >> Cc: dev@dpdk.org; Abhishek Marathe ; >> Hemant Agrawal ; Ian Stokes >> ; Jerin Jacob ; John McNamara >> ; Ju-Hyoung

RE: 21.11.8 patches review and test

2024-09-17 Thread Ali Alnubani
> -Original Message- > From: Kevin Traynor > Sent: Tuesday, September 17, 2024 7:14 PM > To: Ali Alnubani ; sta...@dpdk.org > Cc: dev@dpdk.org; Abhishek Marathe ; > Hemant Agrawal ; Ian Stokes > ; Jerin Jacob ; John McNamara > ; Ju-Hyoung Lee ; Luca > Boccassi ; Pei Zhang ; Raslan > Daraws

RE: [PATCH v4 1/7] eal: add static per-lcore memory allocation facility

2024-09-17 Thread Konstantin Ananyev
> >> +#define LCORE_BUFFER_SIZE (RTE_MAX_LCORE_VAR * RTE_MAX_LCORE) > >> + > >> +static void *lcore_buffer; > >> +static size_t offset = RTE_MAX_LCORE_VAR; > >> + > >> +static void * > >> +lcore_var_alloc(size_t size, size_t align) > >> +{ > >> + void *handle; > >> + void *value; > >> + > >> +

Re: 21.11.8 patches review and test

2024-09-17 Thread Kevin Traynor
On 17/09/2024 17:21, Ali Alnubani wrote: >> -Original Message- >> From: Kevin Traynor >> Sent: Tuesday, September 17, 2024 7:14 PM >> To: Ali Alnubani ; sta...@dpdk.org >> Cc: dev@dpdk.org; Abhishek Marathe ; >> Hemant Agrawal ; Ian Stokes >> ; Jerin Jacob ; John McNamara >> ; Ju-Hyoung Le

[PATCH v2] devtools: fix false positive from checkpatch

2024-09-17 Thread Stephen Hemminger
The codespell dictionary has "stdio" in its bad word list, but stdio.h is often used in DPDK code and creates bogus false positives from checkpatch. Also add a check to the parameters to build-dict.sh so it gives usage error if parameter is missing or does not point to the codespell git clone. Si

RE: [PATCH v2] ipsec: allow stateless IPsec processing

2024-09-17 Thread Konstantin Ananyev
> Introduce stateless packet preparation API for IPsec > processing. The new API would allow preparation of IPsec > packets without altering the internal state of an IPsec > session. > > For outbound IPsec processing, the change enables user to > provide sequence number to be used for the IPsec

RE: [PATCH] ip_frag: support IPv6 reassembly with extensions

2024-09-17 Thread Konstantin Ananyev
> > On Mon, 26 Aug 2024 13:23:28 +0200 > wrote: > > > diff --git a/lib/ip_frag/ip_reassembly.h b/lib/ip_frag/ip_reassembly.h > > index 54afed5417..429e74f1b3 100644 > > --- a/lib/ip_frag/ip_reassembly.h > > +++ b/lib/ip_frag/ip_reassembly.h > > @@ -54,6 +54,8 @@ struct __rte_cache_aligned ip_f

RE: [PATCH] ip_frag: support IPv6 reassembly with extensions

2024-09-17 Thread Konstantin Ananyev
> From: Vignesh PS > > Add support to ip_frag library to perform IPv6 reassembly > when extension headers are present before the fragment > extension in the packet. > > Signed-off-by: Vignesh PS > --- > .mailmap | 1 + > lib/ip_frag/ip_frag_common.h | 2 + > l

RE: [EXTERNAL] [PATCH v6 1/8] zsda: Introduce zsda device drivers

2024-09-17 Thread Akhil Goyal
> Introduce driver support for ZSDA which can > help to accelerate storage data process. > > v6: modify code for ci compile > > Signed-off-by: Hanxiao Li > --- > MAINTAINERS | 4 + > config/rte_config.h | 4 + > drivers/common/zsda/meson.build | 25 +

RE: [EXTERNAL] [PATCH v6 5/8] zsda: modify files for introducing zsda cryptodev

2024-09-17 Thread Akhil Goyal
> -Original Message- > From: Hanxiao Li > Sent: Wednesday, September 11, 2024 1:24 PM > To: dev@dpdk.org > Cc: wang.yon...@zte.com.cn; Hanxiao Li > Subject: [EXTERNAL] [PATCH v6 5/8] zsda: modify files for introducing zsda > cryptodev > > It is necessary to make necessary modification

RE: [EXTERNAL] [PATCH v6 6/8] zsda: add zsda crypto-pmd

2024-09-17 Thread Akhil Goyal
> Add new file zsda_sym_pmd.c, zsda_sym_pmd.h in drivers/crypto/zsda > > Signed-off-by: Hanxiao Li Please split the patches appropriately for better review. Please follow https://patches.dpdk.org/project/dpdk/patch/20240916162856.11566-1-step...@networkplumber.org/ > --- > drivers/crypto/zsda/

RE: [EXTERNAL] [PATCH v6 8/8] zsda: add zsda crypto-session and compile file

2024-09-17 Thread Akhil Goyal
> Add new file zsda_sym_session.c, zsda_symsession.h > and modify drivers/common/zsda/meson.build > > Signed-off-by: Hanxiao Li > --- > drivers/common/zsda/meson.build| 16 +- > drivers/crypto/zsda/zsda_sym_session.c | 503 + > drivers/crypto/zsda/zsda_sym_sessio

RE: [EXTERNAL] Re: [PATCH] doc: update Arm IPsec-MB dependency version

2024-09-17 Thread Akhil Goyal
> On 31/07/2024 22:26, Wathsala Vithanage wrote: > > Updates the tag of Arm IPsec-MB library to SECLIB-IPSEC-2024.07.08 > > in snow3g and zuc documentation. > > > > Signed-off-by: Wathsala Vithanage > > Reviewed-by: Dhruv Tripathi > Acked-by: Jack Bond-Preston Applied to dpdk-next-crypto Thanks.

[DPDK/core Bug 1546] fib6 perf test failing

2024-09-17 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=1546 Bug ID: 1546 Summary: fib6 perf test failing Product: DPDK Version: 24.11 Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: Normal

[PATCH v22 00/15] Logging improvements

2024-09-17 Thread Stephen Hemminger
Improvements and unification of logging library. This version works on all platforms: Linux, Windows and FreeBSD. This is update to rework patch set. It adds several new features to the console log output. * Putting a timestamp on console output which is useful for analyzing performance of

[PATCH v22 01/15] maintainers: add for log library

2024-09-17 Thread Stephen Hemminger
"You touch it you own it" Add myself as maintainer for log library. Signed-off-by: Stephen Hemminger Acked-by: Tyler Retzlaff Acked-by: Morten Brørup --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index c5a703b5c0..ecf6f955cc 100644 --- a/MAINTAIN

[PATCH v22 02/15] windows: make getopt functions have const properties

2024-09-17 Thread Stephen Hemminger
Having different prototypes on different platforms can lead to lots of unnecessary workarounds. Looks like the version of getopt used from windows was based on an older out of date version from FreeBSD. This patch changes getopt, getopt_long, etc to have the same const attributes as Linux and Fre

[PATCH v22 03/15] windows: add os shim for localtime_r

2024-09-17 Thread Stephen Hemminger
Windows does not have localtime_r but it does have a similar function that can be used instead. Signed-off-by: Stephen Hemminger Acked-by: Tyler Retzlaff Acked-by: Morten Brørup --- lib/eal/windows/include/rte_os_shim.h | 10 ++ 1 file changed, 10 insertions(+) diff --git a/lib/eal/wi

[PATCH v22 04/15] eal: make eal_log_level_parse common

2024-09-17 Thread Stephen Hemminger
The code to parse for log-level option should be same on all OS variants. Signed-off-by: Stephen Hemminger Acked-by: Tyler Retzlaff Acked-by: Morten Brørup --- lib/eal/common/eal_common_options.c | 45 + lib/eal/common/eal_options.h| 1 + lib/eal/freebsd/ea

[PATCH v22 05/15] eal: do not duplicate rte_init_alert() messages

2024-09-17 Thread Stephen Hemminger
The message already goes through logging, and does not need to be printed on stderr. Message level should be ALERT to match function name. Signed-off-by: Stephen Hemminger Acked-by: Tyler Retzlaff Acked-by: Morten Brørup --- lib/eal/freebsd/eal.c | 3 +-- lib/eal/linux/eal.c | 3 +-- 2 files

[PATCH v22 06/15] eal: change rte_exit() output to match rte_log()

2024-09-17 Thread Stephen Hemminger
The rte_exit() output format confuses the timestamp and coloring options. Change it to use be a single line with proper prefix. Before: [ 0.006481] EAL: Error - exiting with code: 1 Cause: [ 0.006489] Cannot init EAL: Permission denied After: [ 0.006238] EAL: Error - exiting with co

[PATCH v22 07/15] log: move handling of syslog facility out of eal

2024-09-17 Thread Stephen Hemminger
The syslog facility property is better handled in lib/log rather than in eal. This also allows for changes to what syslog flag means in later steps. Signed-off-by: Stephen Hemminger Acked-by: Morten Brørup --- lib/eal/common/eal_common_options.c | 51 ++--- lib/eal/freeb

[PATCH v22 08/15] eal: initialize log before everything else

2024-09-17 Thread Stephen Hemminger
In order for all log messages (including CPU mismatch) to come out through the logging library, it must be initialized as early in rte_eal_init() as possible on all platforms. Where it was done before was likely historical based on the support of non-OS isolated CPU's which required a shared memor

[PATCH v22 09/15] log: drop syslog support, and make code common

2024-09-17 Thread Stephen Hemminger
This patch makes the log setup code common across all platforms. Drops syslog support for now, will come back in later patch. Signed-off-by: Stephen Hemminger Acked-by: Morten Brørup --- app/test/test_eal_flags.c | 11 ++- lib/eal/common/eal_common_options.c | 3 - lib/log/log.c

[PATCH v22 10/15] log: add hook for printing log messages

2024-09-17 Thread Stephen Hemminger
This is useful for when decorating log output for console or journal. Provide basic version in this patch. Signed-off-by: Stephen Hemminger Acked-by: Morten Brørup --- lib/log/log.c | 6 +- lib/log/log_private.h | 9 + 2 files changed, 14 insertions(+), 1 deletion(-) create

[PATCH v22 11/15] log: add timestamp option

2024-09-17 Thread Stephen Hemminger
When debugging driver or startup issues, it is useful to have a timestamp on each message printed. The messages in syslog already have a timestamp, but often syslog is not available during testing. There are multiple timestamp formats similar to Linux dmesg. The default is time relative since star

[PATCH v22 12/15] log: add optional support of syslog

2024-09-17 Thread Stephen Hemminger
Log to syslog only if option is specified. And if syslog is used then normally only log to syslog, don't duplicate output. Also enables syslog support on FreeBSD. Signed-off-by: Stephen Hemminger Acked-by: Morten Brørup --- app/test/test_eal_flags.c | 5 +- doc/guides/linux

  1   2   >